thodg/libgit2/src/curl_stream.h

• Show log

  Commit

• Hash : b35c3098
  Author :
  Date : 2018-02-28T12:06:59
  

  curl: explicitly initialize and cleanup global curl state Our curl-based streams make use of the easy curl interface. This interface automatically initializes and de-initializes the global curl state by calling out to `curl_global_init` and `curl_global_cleanup`. Thus, all global state will be repeatedly re-initialized when creating multiple curl streams in succession. Despite being inefficient, this is not thread-safe due to `curl_global_init` being not thread-safe itself. Thus a multi-threaded programing handling multiple curl streams at the same time is inherently racy. Fix the issue by globally initializing and cleaning up curl's state.

Download

• src/curl_stream.h

• /*
   * Copyright (C) the libgit2 contributors. All rights reserved.
   *
   * This file is part of libgit2, distributed under the GNU GPL v2 with
   * a Linking Exception. For full terms see the included COPYING file.
   */
  #ifndef INCLUDE_curl_stream_h__
  #define INCLUDE_curl_stream_h__
  
  #include "git2/sys/stream.h"
  
  extern int git_curl_stream_global_init(void);
  extern int git_curl_stream_new(git_stream **out, const char *host, const char *port);
  
  #endif
  

Download