thodg/libgit2/src/config_entries.h

• Show log

  Commit

• Hash : 76182e84
  Author :
  Date : 2019-07-24T18:04:38
  

  config_entries: fix possible segfault when duplicating entries When duplicating a configuration entry, we allocate a new entry but do not verify that we get a valid pointer back. As we're dereferencing the pointer afterwards, we might thus run into a segfault in out-of-memory situations. Extract a new function `git_config_entries_dup_entry` that handles the complete entry duplication. Fix the error by using `GIT_ERROR_CHECK_ALLOC`.

Download

• src/config_entries.h

• /*
   * Copyright (C) the libgit2 contributors. All rights reserved.
   *
   * This file is part of libgit2, distributed under the GNU GPL v2 with
   * a Linking Exception. For full terms see the included COPYING file.
   */
  
  #include "common.h"
  
  #include "git2/sys/config.h"
  #include "config.h"
  
  typedef struct git_config_entries git_config_entries;
  
  int git_config_entries_new(git_config_entries **out);
  int git_config_entries_dup(git_config_entries **out, git_config_entries *entries);
  int git_config_entries_dup_entry(git_config_entries *entries, const git_config_entry *entry);
  void git_config_entries_incref(git_config_entries *entries);
  void git_config_entries_free(git_config_entries *entries);
  /* Add or append the new config option */
  int git_config_entries_append(git_config_entries *entries, git_config_entry *entry);
  int git_config_entries_get(git_config_entry **out, git_config_entries *entries, const char *key);
  int git_config_entries_get_unique(git_config_entry **out, git_config_entries *entries, const char *key);
  int git_config_entries_iterator_new(git_config_iterator **out, git_config_entries *entries);
  

Download