thodg/libgit2/tests/core/strmap.c

• Show log

  Commit

• Hash : ef507bc7
  Author :
  Date : 2019-01-23T10:44:02
  

  strmap: introduce `git_strmap_get` and use it throughout the tree
  
  The current way of looking up an entry from a map is tightly coupled with the
  map implementation, as one first has to look up the index of the key and then
  retrieve the associated value by using the index. As a caller, you usually do
  not care about any indices at all, though, so this is more complicated than
  really necessary. Furthermore, it invites for errors to happen if the correct
  error checking sequence is not being followed.
  
  Introduce a new high-level function `git_strmap_get` that takes a map and a key
  and returns a pointer to the associated value if such a key exists. Otherwise,
  a `NULL` pointer is returned. Adjust all callers that can trivially be
  converted.
  

Download

• tests/core/strmap.c

• #include "clar_libgit2.h"
  #include "strmap.h"
  
  static git_strmap *g_table;
  
  void test_core_strmap__initialize(void)
  {
  	cl_git_pass(git_strmap_new(&g_table));
  	cl_assert(g_table != NULL);
  }
  
  void test_core_strmap__cleanup(void)
  {
  	git_strmap_free(g_table);
  }
  
  void test_core_strmap__0(void)
  {
  	cl_assert(git_strmap_size(g_table) == 0);
  }
  
  static void insert_strings(git_strmap *table, size_t count)
  {
  	size_t i, j, over;
  	int err;
  	char *str;
  
  	for (i = 0; i < count; ++i) {
  		str = malloc(10);
  		for (j = 0; j < 10; ++j)
  			str[j] = 'a' + (i % 26);
  		str[9] = '\0';
  
  		/* if > 26, then encode larger value in first letters */
  		for (j = 0, over = i / 26; over > 0; j++, over = over / 26)
  			str[j] = 'A' + (over % 26);
  
  		git_strmap_insert(table, str, str, &err);
  		cl_assert(err >= 0);
  	}
  
  	cl_assert_equal_i(git_strmap_size(table), count);
  }
  
  void test_core_strmap__1(void)
  {
  	int i;
  	char *str;
  
  	insert_strings(g_table, 20);
  
  	cl_assert(git_strmap_exists(g_table, "aaaaaaaaa"));
  	cl_assert(git_strmap_exists(g_table, "ggggggggg"));
  	cl_assert(!git_strmap_exists(g_table, "aaaaaaaab"));
  	cl_assert(!git_strmap_exists(g_table, "abcdefghi"));
  
  	i = 0;
  	git_strmap_foreach_value(g_table, str, { i++; free(str); });
  	cl_assert(i == 20);
  }
  
  void test_core_strmap__2(void)
  {
  	size_t pos;
  	int i;
  	char *str;
  
  	insert_strings(g_table, 20);
  
  	cl_assert(git_strmap_exists(g_table, "aaaaaaaaa"));
  	cl_assert(git_strmap_exists(g_table, "ggggggggg"));
  	cl_assert(!git_strmap_exists(g_table, "aaaaaaaab"));
  	cl_assert(!git_strmap_exists(g_table, "abcdefghi"));
  
  	cl_assert(git_strmap_exists(g_table, "bbbbbbbbb"));
  	pos = git_strmap_lookup_index(g_table, "bbbbbbbbb");
  	cl_assert(git_strmap_valid_index(g_table, pos));
  	cl_assert_equal_s(git_strmap_value_at(g_table, pos), "bbbbbbbbb");
  	free(git_strmap_value_at(g_table, pos));
  	git_strmap_delete_at(g_table, pos);
  
  	cl_assert(!git_strmap_exists(g_table, "bbbbbbbbb"));
  
  	i = 0;
  	git_strmap_foreach_value(g_table, str, { i++; free(str); });
  	cl_assert(i == 19);
  }
  
  void test_core_strmap__3(void)
  {
  	int i;
  	char *str;
  
  	insert_strings(g_table, 10000);
  
  	i = 0;
  	git_strmap_foreach_value(g_table, str, { i++; free(str); });
  	cl_assert(i == 10000);
  }
  
  void test_core_strmap__get_succeeds_with_existing_entries(void)
  {
  	const char *keys[] = { "foo", "bar", "gobble" };
  	char *values[] = { "oof", "rab", "elbbog" };
  	int error;
  	size_t i;
  
  	for (i = 0; i < ARRAY_SIZE(keys); i++) {
  		git_strmap_insert(g_table, keys[i], values[i], &error);
  		cl_assert_equal_i(error, 1);
  	}
  
  	cl_assert_equal_s(git_strmap_get(g_table, "foo"), "oof");
  	cl_assert_equal_s(git_strmap_get(g_table, "bar"), "rab");
  	cl_assert_equal_s(git_strmap_get(g_table, "gobble"), "elbbog");
  }
  
  void test_core_strmap__get_returns_null_on_nonexisting_key(void)
  {
  	const char *keys[] = { "foo", "bar", "gobble" };
  	char *values[] = { "oof", "rab", "elbbog" };
  	int error;
  	size_t i;
  
  	for (i = 0; i < ARRAY_SIZE(keys); i++) {
  		git_strmap_insert(g_table, keys[i], values[i], &error);
  		cl_assert_equal_i(error, 1);
  	}
  
  	cl_assert_equal_p(git_strmap_get(g_table, "other"), NULL);
  }
  

Download