thodg/libgit2/src/mwindow.h

• Show log

  Commit

• Hash : f9b55bcb
  Author :
  Date : 2013-01-05T18:20:42
  

  git_mwindow_file_deregister() shouldn't return errors As a function that appears to only be called on error paths, I don't think it makes sense for it to return an error, or clobber the global giterr. Note that no existing callsites actually check the return code. In my own application, there are errors where the real error ends up being hidden, as git_mwindow_file_deregister() clobbers the global giterr. I'm not sure this error is even relevant?

Download

• src/mwindow.h

• /*
   * Copyright (C) 2009-2012 the libgit2 contributors
   *
   * This file is part of libgit2, distributed under the GNU GPL v2 with
   * a Linking Exception. For full terms see the included COPYING file.
   */
  
  #ifndef INCLUDE_mwindow__
  #define INCLUDE_mwindow__
  
  #include "map.h"
  #include "vector.h"
  
  typedef struct git_mwindow {
  	struct git_mwindow *next;
  	git_map window_map;
  	git_off_t offset;
  	size_t last_used;
  	size_t inuse_cnt;
  } git_mwindow;
  
  typedef struct git_mwindow_file {
  	git_mwindow *windows;
  	int fd;
  	git_off_t size;
  } git_mwindow_file;
  
  typedef struct git_mwindow_ctl {
  	size_t mapped;
  	unsigned int open_windows;
  	unsigned int mmap_calls;
  	unsigned int peak_open_windows;
  	size_t peak_mapped;
  	size_t used_ctr;
  	git_vector windowfiles;
  } git_mwindow_ctl;
  
  int git_mwindow_contains(git_mwindow *win, git_off_t offset);
  void git_mwindow_free_all(git_mwindow_file *mwf);
  unsigned char *git_mwindow_open(git_mwindow_file *mwf, git_mwindow **cursor, git_off_t offset, size_t extra, unsigned int *left);
  int git_mwindow_file_register(git_mwindow_file *mwf);
  void git_mwindow_file_deregister(git_mwindow_file *mwf);
  void git_mwindow_close(git_mwindow **w_cursor);
  
  #endif
  

Download