thodg/libgit2/cmake/Modules/AddCFlagIfSupported.cmake
Tag
-
Show log
Commit
-
Hash : 6af6170b
Author :
Date : 2019-01-05T20:50:42
Make ENABLE_WERROR actually work This change explicitly adds -Werror to the CFLAGS. Due to the way that the ADD_C_FLAG_IF_SUPPORTED() macro was mangling the flag name to convert it into a define name, any warning that had a dash in its name was not being correctly enabled. Additionally, any flag that is enabled implicitly by the compiler (like -Wunused-result and -Wdeprecated-declarations) would not cause an error unless they were explicitly enabled with the ENABLE_WARNINGS() macro.
-
cmake/Modules/AddCFlagIfSupported.cmake
-
# - Append compiler flag to CMAKE_C_FLAGS if compiler supports it # ADD_C_FLAG_IF_SUPPORTED(<flag>) # <flag> - the compiler flag to test # This internally calls the CHECK_C_COMPILER_FLAG macro. INCLUDE(CheckCCompilerFlag) MACRO(ADD_C_FLAG _FLAG) STRING(TOUPPER ${_FLAG} UPCASE) STRING(REGEX REPLACE "[-=]" "_" UPCASE_PRETTY ${UPCASE}) STRING(REGEX REPLACE "^_+" "" UPCASE_PRETTY ${UPCASE_PRETTY}) CHECK_C_COMPILER_FLAG(${_FLAG} IS_${UPCASE_PRETTY}_SUPPORTED) IF(IS_${UPCASE_PRETTY}_SUPPORTED) SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${_FLAG}") ELSE() MESSAGE(FATAL_ERROR "Required flag ${_FLAG} is not supported") ENDIF() ENDMACRO() MACRO(ADD_C_FLAG_IF_SUPPORTED _FLAG) STRING(TOUPPER ${_FLAG} UPCASE) STRING(REGEX REPLACE "[-=]" "_" UPCASE_PRETTY ${UPCASE}) STRING(REGEX REPLACE "^_+" "" UPCASE_PRETTY ${UPCASE_PRETTY}) CHECK_C_COMPILER_FLAG(${_FLAG} IS_${UPCASE_PRETTY}_SUPPORTED) IF(IS_${UPCASE_PRETTY}_SUPPORTED) SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${_FLAG}") ENDIF() ENDMACRO()