kc3-lang/SDL/src/video

• Show log

  Commit

• Hash : 3a08b463
  Author :
  Date : 2015-06-25T11:49:48
  

  Fixed bug 2834 - Patch to support dead keys on Windows Elise Maurer When inputting text, dead-keys are currently not handled correctly on Windows with the latest SDL2 tip as well as the 2.0.3 release. Using a French AZERTY keyboard, when I type the `^` key followed by `e` key to compose the `` character, I erroneously get two SDL_TEXTINPUT events, one with the `^` character and one with the `e` character. I've looked at the history for SDL_windowsevents.c and there's been some back-and-forth with several methods for handling text input: * r8142 removed any handling of WM_CHAR because keyboard input was being handled through WM_KEYDOWN along with ToUnicode since r7645. * But using ToUnicode actually breaks dead-keys (googling for "ToUnicode dead keys" reports many horror stories of people trying to work around that and failing). * It seems like r7645 introduced a double-fix: it fixed WM_CHAR to properly handle Unicode, and also (unnecessarily?) added text input handling to WM_KEYDOWN. Later, r8142 removed the WM_CHAR stuff instead of the WM_KEYDOWN stuff. The attached patch restores handling of text input through WM_CHAR and removes it from WM_KEYDOWN. I've tested it with French, English and Russian layouts and it seems to do its job. Obviously, with such matters, it's still a risky change.

• Files

• SDL_RLEaccel.c
• SDL_RLEaccel_c.h
• SDL_blit.c
• SDL_blit.h
• SDL_blit_0.c
• SDL_blit_1.c
• SDL_blit_A.c
• SDL_blit_N.c
• SDL_blit_auto.c
• SDL_blit_auto.h
• SDL_blit_copy.c
• SDL_blit_copy.h
• SDL_blit_slow.c
• SDL_blit_slow.h
• SDL_bmp.c
• SDL_clipboard.c
• SDL_egl.c
• SDL_egl_c.h
• SDL_fillrect.c
• SDL_pixels.c
• SDL_pixels_c.h
• SDL_rect.c
• SDL_rect_c.h
• SDL_shape.c
• SDL_shape_internals.h
• SDL_stretch.c
• SDL_surface.c
• SDL_sysvideo.h
• SDL_video.c
• android/
• cocoa/
• directfb/
• dummy/
• emscripten/
• haiku/
• mir/
• nacl/
• pandora/
• psp/
• raspberry/
• sdlgenblit.pl
• uikit/
• vivante/
• wayland/
• windows/
• winrt/
• x11/

• Properties

• Git HTTP	https://git.kmx.io/kc3-lang/SDL.git
  Git SSH	git@git.kmx.io:kc3-lang/SDL.git
  Public access ?	public
  Description	Fork of https://github.com/libsdl-org/SDL
  Users
  Tags