kc3-lang/angle

Log

Author Commit Date CI Message
Shahbaz Youssefi 02ae054c 2025-04-07T13:48:29 Translator: Fix init of inactive output variables Bug: chromium:398401939 Change-Id: I0df494b945b8d0e805a62cf7645d06bf233f36ca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6438495 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Jiaqi Li a6f44806 2025-04-01T17:30:53 Wrong condition to call copyBufferDataToImage In function copyBufferDataToImage, it call vulkan vkCopyBufferToImage directly. To call copyBufferDataToImage directly, it needs that there's no overlap when copy. If mImage is not valid, it will assert in mImage->getActualFormatID(). Need to check its validation at beginning. Bug: angleproject:406566447 Change-Id: I875c2a97bec52251b9c5b3d196466e8bf5ce662d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6400313 Auto-Submit: Jiaqi Li <Jiaqi.Li@arm.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Yuly Novikov 1ee585fd 2025-04-09T10:03:26 Rename ANGLE S22 builders to S24 Also start targeting S24 phones on the new builders. Bug: angleproject:394893136 Change-Id: I50496a5a5b114034bccf326001aa8ebc8a601398 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6439516 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 1cc059ef 2025-04-09T10:01:56 Roll vulkan-deps from d04dafb08ac6 to c8554b0ea83f (13 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/d04dafb08ac6..c8554b0ea83f Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/938eedb181975417efef1657784b4e15092de9f0..8a466340c0b1477cb5413c3665172fd3b9da2f1f https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/1a811fd69871da36d9cca84586d8a7799be893ec..e940239220e38bd5179c26bf43092cc807dfe6fe https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/59dc56aa3023434317a5197d77be51855b5fd2fb..555dca10345cc87918876ff8c55805e54014b6ac https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/abc2498bde8d65841f463431a6220701fad44c64..ad2ffcba7b2b3f327dcbcb1f825450d49181b46d https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/6ebe2666e8d9ec374657066d0834560ed8551acc..2b23c202d275793f067b1e3821f42eb24edeaa5c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I5d56e8d3c8cf5aa3eeac7f7738b9ccf78df85211 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6443130 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 3a12660e 2025-04-09T07:00:22 Roll Chromium from b61baca1a417 to 75621a1b9953 (584 revisions) https://chromium.googlesource.com/chromium/src.git/+log/b61baca1a417..75621a1b9953 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/95794d6fdc..d580cf25e8 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/9f61cc436c..dc03d452a6 * buildtools/linux64: git_revision:6e8e0d6d4a151ab2ed9b4a35366e630c55888444..git_revision:c0a46c5e8c316010baf1a0eb2d2ee5a86f73e4c2 * buildtools/mac: git_revision:6e8e0d6d4a151ab2ed9b4a35366e630c55888444..git_revision:c0a46c5e8c316010baf1a0eb2d2ee5a86f73e4c2 * buildtools/win: git_revision:6e8e0d6d4a151ab2ed9b4a35366e630c55888444..git_revision:c0a46c5e8c316010baf1a0eb2d2ee5a86f73e4c2 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/803e127f59..b5aac41fd7 * third_party/android_build_tools/manifest_merger/cipd: MBIQRTQ6FavhzrjRrKgZHXpedUncW5cLxVQjYvkSnHgC..as9uz7sX05xpw-A5S-NU9MbMzlggbUhOfJdarGxMJ84C * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/afb0c8b908..3ea4639ac5 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/c79b6718f6..6f6dc922b8 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/94c5d7a8ed..78140a7276 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/6df4308a5d..7f56bd496d * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/d05fde5052..79d087e955 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/57194cae87..9b28bb6693 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/d1eb0d45b5..b1212bb2fd No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: Ie36bb5ac111ed27c047f514e27806564d4b522a7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6442785 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuxin Hu f680e107 2025-04-08T16:22:29 Change the VVL missing log from WARN() to INFO() On certain chromium Android CI, VK_LAYER_KHRONOS_validation layer is missing, and WARN() message causes tests to fail: https://ci.chromium.org/ui/p/chromium/builders/ci/Android%20FYI%20Release%20(Nexus%205X)/77567/infra Bug: chromium:409350833 Change-Id: I16f85d73ad41f81a40cc25b1a80ee14fd772a78e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6442304 Auto-Submit: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Yuxin Hu a0a5c565 2025-04-07T15:05:11 Vulkan: Add assert to check only clear is staged on swapchain image The swap after clear optimizations on swapchain image multisampled image https://chromium-review.googlesource.com/c/angle/angle/+/6072416 works with the assumption that the only staged updates on swapchain multisampled image is clear. This change adds an assert to validate the assumption holds true before applying the optimization. If the assert is ever triggered, we will know the assumption is violated, and we need to look into how to tweak the optimization or add other optimizations to solve the violated case. Bug: angleproject:382006939 Change-Id: I7ce23dd7767b7730f1fa3ec89cb6616689339602 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6437217 Reviewed-by: mohan maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Cody Northrop 3207b535 2025-04-08T12:50:19 Tests: Skip new denorm test on Pixel 6 Test: GLSLTest_ES3.DenormFloatsToIntValues Bug: b/406827038 Change-Id: I9202e750dc5f80f1ed0d9c2153cdc2c73b72c1d2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6441469 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Cody Northrop <cnorthrop@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Dirk Pranke 3d3188e0 2025-04-08T10:11:17 Remove exec_script_whitelist from dotfile_settings.gni. All of the clients of this file have been updated to use exec_script_allowlist, so we no longer need to set exec_script_whitelist as well. Bug: chromium:389986807 Change-Id: Ifb5ce794e4329b54e5a91ca658c41ce9ba038c4d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6441919 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com>
Roman Lavrov 2fcd88e1 2025-04-08T09:30:59 Tests: order bot mode batch configs alphabetically Currently ordered by hashmap key ordering which shuffles the order even with --max-processes=1. Adding a sort to make this deterministic. Bug: angleproject:408276172 Change-Id: Ice96e350ba4247a1f40870e275d04d2f654bc4f5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6438024 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Yuly Novikov 8424dd22 2025-04-08T13:39:59 Suppress end2end test on iOS Metal PixelLocalStorageTest.FlushFinishSync added in https://chromium-review.googlesource.com/c/angle/angle/+/6427324 Bug: angleproject:40096838 Change-Id: Ibd357a357823e757c71c0d4527db774f721b28f6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6440285 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov 1a1978fd 2025-04-08T13:29:12 Suppress dEQP-GLES2.functional.debug_marker.random on Linux SwANGLE Bug: angleproject:42266920 Change-Id: Ib45f9c6f5c64c6fab5310f8ea24b5da308097c66 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6439421 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Cody Northrop d27a1fd0 2025-04-03T19:59:20 Compiler: Allow denorm float values in the lexer This adds an option to preserve denorm values in the lexer, skipping the explicit zero conversions for below range floats. There are applications in the wild that expect to be able to use denorm float values. They are typically immediately converted to integer values, not used in floating point operations. The option is only enabled for Vulkan backends. Test: FloatLexTest, DenormFloatsToIntValues, app traces Bug: b/406827038 Change-Id: Iab5a1a69a540b78ccbce8ea90b532d2d4976e29e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6432237 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
angle-autoroll c0f30251 2025-04-08T10:01:12 Roll vulkan-deps from fb4fe29989cb to d04dafb08ac6 (11 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/fb4fe29989cb..d04dafb08ac6 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/54eddbe9fcf33a6b5e77b8044f332cea872fc704..938eedb181975417efef1657784b4e15092de9f0 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/b8eb2b901835497b91db7bd7005f4d6ddba2bf1e..7b6539f24633096c25631bab9fd572bd1ad9b27b https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/289efccc7560f2b970e2b4e0f50349da87669311..59dc56aa3023434317a5197d77be51855b5fd2fb https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/01851ecae564f8d3da0123659c26a2f5bbfc0228..abc2498bde8d65841f463431a6220701fad44c64 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/6f9d2d358f9585bbd302106e7b5b8135cb19f716..6ebe2666e8d9ec374657066d0834560ed8551acc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I22133cbf1c9d17c59ba3eef0a841bf0633788da8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6441103 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 998ed587 2025-04-08T03:01:13 Roll SwiftShader from 4982425ff1bd to 2b323370501c (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/4982425ff1bd..2b323370501c 2025-04-07 swiftshader.regress@gmail.com Regres: Update test lists @ 4982425f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: Ic305fb6c9183e445b91c8c099475585870d7483f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6440521 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 48b7d12e 2025-04-08T07:58:50 Roll Chromium from 6a2660221a4c to b61baca1a417 (683 revisions) https://chromium.googlesource.com/chromium/src.git/+log/6a2660221a4c..b61baca1a417 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/38290a4010..95794d6fdc * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/5ed32accde..9f61cc436c * testing: https://chromium.googlesource.com/chromium/src/testing/+log/df390a2691..803e127f59 * third_party/android_build_tools/error_prone/cipd: muHOjW6H-gb8j6gY4sUylWC1paxyWPRMAeYZ1Ok8KkwC..ZK9e0tqXwlyM9VSS1O09u8kkCtk-SfKOTtSXyAq22-UC * third_party/android_build_tools/lint/cipd: cpi5krkjlhoCfjDOZ3fIdPXDOqnCGMBVzm_yHg1WnWUC..vBqKHQdjLFM5l79fpi3L9l7kD9b1FfeyfWbIFjXShSgC * third_party/android_build_tools/manifest_merger/cipd: vHfVYpJ8u72iZgoN6s-BvRweZgVkKP-j_QbT8eSgc3gC..MBIQRTQ6FavhzrjRrKgZHXpedUncW5cLxVQjYvkSnHgC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/f14985b465..d4a30bd2e4 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/c8d1e18466..afb0c8b908 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/4e8b01e3c1..c79b6718f6 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/aa5c758d87..6df4308a5d * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/f2622a898c..de1750a8ce * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/09ef5722d8..d05fde5052 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/de3df440c0..57194cae87 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/951584ca07..374799d778 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/4f2c56de67..d1eb0d45b5 * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/7cdd3d9540..b549758ca9 No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: If2dbea035f1d435e3200025b67c5661af42763bd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6440806 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexey Knyazev cbd6cdc9 2025-03-28T00:00:00 Ensure CopyTexImageParameters validation consistency * Validation must succeed for no-op commands. * Moved no-op conditions handling to the Context. Bug: angleproject:406922380 Change-Id: I9102955198b755844d05c0c4f07832664ff24100 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6439412 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 6e992fa2 2025-03-28T00:00:00 Ensure consistency of context lost aware validation Some commands must generate CONTEXT_LOST but still return a value. Moved error generation to the Context to ensure validation consistency. Bug: angleproject:406922380 Change-Id: Ie5dae39bada951366afb86cab4324f2247c84ab7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6433684 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Yuxin Hu 16c85291 2025-03-19T18:15:43 Reland "Enable VVL on vulkan instance created in GetSystemInfoVulkanWithICD" This is a reland of 3f028fc158fac948723e8d535463eb80d0a85fed. On Fuchsia, it is possible that there is no vulkan driver and vkCreateInstance() triggered VVLDebugUtilsMessenger. "vkCreateInstance: Found no drivers" is a VK_DEBUG_UTILS_MESSAGE_TYPE_GENERAL_BIT_EXT message. We should only care about VK_DEBUG_UTILS_MESSAGE_TYPE_VALIDATION_BIT_EXT message type. Remove VK_DEBUG_UTILS_MESSAGE_TYPE_GENERAL_BIT_EXT and VK_DEBUG_UTILS_MESSAGE_TYPE_PERFORMANCE_BIT_EXT from the VkDebugUtilsMessengerCreateInfoEXT. Add code to print the VVL message in the log so we know what's wrong. Add a condition to only assert when the VVL message severity is VK_DEBUG_UTILS_MESSAGE_SEVERITY_ERROR_BIT_EXT. Original change's description: > Enable VVL on vulkan instance created in GetSystemInfoVulkanWithICD > > This helps catching bugs for vulkan calls issued > during GetSystemInfoVulkanWithICD(). > > Also changed getProc() function to get vulkan function pointers by > calling vkGetInstanceProcAddr(), instead of calling dlsym(). Only use > dlsym() to get vkGetInstanceProcAddr() function pointer. > Bug: angleproject:407116232 > Change-Id: I14dce3453c76a084db63fdb45a3db07b7b4d5294 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6374305 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Charlie Lao <cclao@google.com> > Commit-Queue: Yuxin Hu <yuxinhu@google.com> Bug: angleproject:407116232 Change-Id: I1ffc4041368782641fc605366ff7cf03e43eb53f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6435033 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov 79832ea3 2025-04-07T10:33:17 Revert "Suppress 5 dEQP EGL tests on Pixel 6 Vulkan" This reverts commit 87950668c45a0b5df6045d750afd4fd3c0502be2. Reason for revert: should be fixed by https://github.com/KhronosGroup/Vulkan-ValidationLayers/pull/9860 Original change's description: > Suppress 5 dEQP EGL tests on Pixel 6 Vulkan > > Report VUID-vkGetDeviceFaultInfoEXT-device-07336 after VVL roll > https://chromium-review.googlesource.com/c/angle/angle/+/6430461 > > Bug: angleproject:408225528 > Change-Id: I5208e5b4a8eea598feb0a155a6dadb3e1e722143 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6432451 > Auto-Submit: Yuly Novikov <ynovikov@chromium.org> > Commit-Queue: Yuly Novikov <ynovikov@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bug: angleproject:408225528 Change-Id: Ie832e7cb6856184e51a26d27c372753e2e597137 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6439031 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Geoff Lang 0e28c030 2025-04-02T17:26:28 ScalarizeVecAndMatConstructorArgs on WGSL shaders. WGSL does not support mixing types in the constructors of vectors and matrices. Use the ScalarizeVecAndMatConstructorArgs traverser to scalarize these constructors and update it to cast to the destination type if the inputs are not in that type already. Bug: angleproject:395659799 Change-Id: I4c270f2b18e79393e3c187916f33ad719bc88a63 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6427067 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Chris Dalton 0f356a34 2025-04-02T14:14:43 Update invalidation commands to disable PLS Previously, commands that flush or invalidate tiled memory were specified to generate an error if issued while PLS was active. Remove all provisions around Flush(), Finish() and ClientWaitSync(), and add a test to ensure these commands have no effect on PLS. The reason we can make this change now is because we no longer support EXT_shader_pixel_local_storage, which previously prevented us from allowing these 3 commands. Update the invalidation commands to disable PLS instead. This is more in line with the general design pattern of PLS. Update the wording of the spec to reflect this better organization. Also clean up some legacy code that was no longer used. Bug: angleproject:40096838 Change-Id: I9687deaf17a583f8757ffcd050eda154b4e7a949 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6427324 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Chris Dalton <chris@rive.app> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Roman Lavrov 1593390b 2025-04-07T11:22:21 Increase ANGLE_LIKELY/UNLIKELY probability to 99.99% I can't find the exact value for clang, but according to GCC docs __builtin_expect probability is assumed to be only 90%. When we actually bother to use ANGLE_LIKELY we mean "almost always", so this value can be much higher. Setting to 99.99% because lower values don't seem to trigger the optimization below (at least 99.9% doesn't) __builtin_expect already enables some optimizations such as moving unlikely branches (e.g. cold function calls) out of the primary flow. Increasing the probability enables more aggressive optimizations such as making those function calls store/load registers only in the rare cases when this call is made - which allows the rest of the caller to be made more efficient by not having to handle these register changes. Example: stur w4, [x29, #-0xc] stur x8, [x29, #-0x8] str x3, [sp, #0x8] stp w2, w1, [x29, #0x18] bl 0x356fdc <_ZNK2gl7Context25getActiveLinkedProgramPPOEv> ldp w2, w1, [x29, #0x18] ldr x3, [sp, #0x8] ldur w4, [x29, #-0xc] ldur x8, [x29, #-0x8] Bug: b/383305597 Change-Id: I077f4f2cb90cfb8282409d12adcb02c3302e7761 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6437572 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Dave Tapuska 1b92a973 2025-04-04T11:20:02 [ios blink] Add arm64e cpu target Add arm64e cpu target to angle. Bug: chromium:40254930 Change-Id: Iae9418c7e068fecde08ff6e93ed0c7e2ae65da97 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6431489 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
angle-autoroll 768c1744 2025-04-07T10:01:11 Roll vulkan-deps from f8cc64f338fb to fb4fe29989cb (15 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/f8cc64f338fb..fb4fe29989cb Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/c3d39de93955f884e443c39e9ffecf86e4aac883..4a038eafdf9e9f3e0ac2e200127df969f3a51ddb https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/4bd1536ed79003a5194a4bd8c9aa2fa17a84c15b..1a811fd69871da36d9cca84586d8a7799be893ec https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/2ac81691baf291e7f4aad07596d7073974dbc4dd..5ceb9ed481e58e705d0d9b5326537daedd06b97d https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/723d6b4aa35853315c6e021ec86388b3a2559fae..b8eb2b901835497b91db7bd7005f4d6ddba2bf1e https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/551221d913cc56218fcaddce086ae293d375ac28..01851ecae564f8d3da0123659c26a2f5bbfc0228 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/5c62066bdf33a51ba8481ff16270f543c1f10076..6f9d2d358f9585bbd302106e7b5b8135cb19f716 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: Ia2fff692792aaf37e390a6f558c4bdb7e95ae85e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6437469 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll c59c745a 2025-04-07T08:01:03 Roll VK-GL-CTS from b6bb4bab7b4a to ad6225aacbc5 (12 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/b6bb4bab7b4a..ad6225aacbc5 2025-04-04 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.2 into vk-gl-cts/main 2025-04-04 ziga@lunarg.com Add tests using VK_IMAGE_LAYOUT_GENERAL and global memory barriers 2025-04-03 rgarcia@igalia.com Test counterOffset in vkCmdDrawIndirectByteCountEXT 2025-04-03 jasuarez@igalia.com Reduce mismatch reporting on failing tests 2025-04-03 piotr.byszewski@mobica.com Add two tests for partially-resident sparse buffers 2025-04-03 rgarcia@igalia.com Fix duplicate structures in pNext chain 2025-04-03 zzoon@igalia.com Fix validation errors in dEQP-VK.video.decode.av1.allintra_nosetup_8_separated_dpb 2025-04-03 mateusz.bahyrycz@mobica.com Replace vkCmdBlitImage() with vkCmdCopyImage() 2025-04-03 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.2 into vk-gl-cts/main 2025-04-03 lorenzo@khronosgroup.org Merge remote-tracking branch 'vk-gl-cts/dev/VK_EXT_present_mode_fifo_latest_ready' into main 2025-04-01 zzoon@igalia.com Fix a crash in Vulkan Video encoding tests. 2025-04-01 ziga@lunarg.com Fix lambda captures in pipeline depth tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I365d2fe0bac134857ff56c81b912851ca6f5d041 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6437073 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 0feb9ed6 2025-04-07T07:02:39 Roll Chromium from f748acbd614f to 6a2660221a4c (648 revisions) https://chromium.googlesource.com/chromium/src.git/+log/f748acbd614f..6a2660221a4c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/303d67a359..38290a4010 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/f2adf9050d..5ed32accde * testing: https://chromium.googlesource.com/chromium/src/testing/+log/67e802f7d1..df390a2691 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/df9b88b552..c8d1e18466 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/7f8f85ae73..4e8b01e3c1 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/16e46844a2..aa5c758d87 * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/acc2c0d4d0..09ef5722d8 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/d42377337b..de3df440c0 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/eda5b50d9f..951584ca07 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/7a5268f3f2..4f2c56de67 No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: I686e458d71d0352c9c1d18550d577ec7af2a1828 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6435966 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexey Knyazev 84056594 2025-03-28T00:00:00 Ensure ValidateCopyTextureCHROMIUM consistency Moved ValidImageSizeParameters out of IsValidCopyTextureDestinationLevel to not generate two errors for a single command call. Bug: angleproject:406922380 Change-Id: Ie96e1c51743d5973f258a49aa2613d72b47e1bfb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6433915 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 01d1c7b4 2025-03-28T00:00:00 Ensure EXT_debug_marker validation consistency * Moved no-op conditions handling to the Context. * Removed redundant comments. Bug: angleproject:406922380 Change-Id: I1064312b2e5940d6b97c95f22544bbc9749fc1ec Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6433224 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Alex Dean 3818d37d 2025-04-04T15:07:59 CL: Add end_capture to capture/replay tool Many different applications don't explicitly make it clear the ending frame of what's being run. With the end_capture utility, when the user sets end_capture to 0, the application automatically finishes the capture immediately. Example OpenCL applications where this is useful: AI-Benchmark, Geekbench Compute, Geekbench AI Bug: angleproject:402174922 Change-Id: I1710ae1b1703f710865a9862c4cf3de753c2ccbd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6339791 Reviewed-by: Roman Lavrov <romanl@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Alexey Knyazev 2a4ea88e 2025-03-28T00:00:00 Simplify CopyImageSubData validation * Removed duplicated switch cases. * Reduced the number of enum conversions. * Used correct error message. Bug: angleproject:42262256 Change-Id: If686b5a0a0b29884b6b5c655df130f6ad918a61a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6433680 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov 5462a528 2025-04-04T15:12:01 Add "likely" hints to glDrawElements validation ValidateDrawStates in particular is large (almost 3KB assembly), this appears to make a difference in synthetic benchmarks on Android. Bug: b/383305597 Change-Id: I4fd07d7080da70e370947b971e61f6d36c293c42 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6431272 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi c9e90490 2025-03-27T18:26:19 Capture: Keep binary data in memory in chunks This is needed for taking large captures out of Chromium, because its memory allocator refuses to allocate objects bigger than 1~2GB. Incidentally, it also optimizes taking large captures by avoiding frequent calls to `vector::resize` while the vector is very large. Bug: b/381284577 Change-Id: I4ccd3c8ea50df59520334f70e99083847da20c9f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6406214 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Mark Łobodziński <mark@lunarg.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Yuxin Hu 7d4c77b9 2025-04-04T11:15:51 Revert "Enable VVL on vulkan instance created in GetSystemInfoVulkanWithICD" This reverts commit 3f028fc158fac948723e8d535463eb80d0a85fed. Reason for revert: triggering asserts in fuchsia tests: https://crrev.com/c/6431747 Original change's description: > Enable VVL on vulkan instance created in GetSystemInfoVulkanWithICD > > This helps catching bugs for vulkan calls issued > during GetSystemInfoVulkanWithICD(). > > Also changed getProc() function to get vulkan function pointers by > calling vkGetInstanceProcAddr(), instead of calling dlsym(). Only use > dlsym() to get vkGetInstanceProcAddr() function pointer. > > Bug: angleproject:407116232 > Change-Id: I14dce3453c76a084db63fdb45a3db07b7b4d5294 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6374305 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Charlie Lao <cclao@google.com> > Commit-Queue: Yuxin Hu <yuxinhu@google.com> Bug: angleproject:407116232 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ic81ebf77f3519cb6a4365dc57ea7753867ae086c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6433022 Auto-Submit: Yuxin Hu <yuxinhu@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Igor Nazarov f798b0d2 2025-04-04T08:17:57 Vulkan: Remove enablePreRotateSurfaces feature Removed to simplify the code and to avoid the problem for which `presentSubOptimalReturnedOnTransformChange` feature was added. Platforms without the per-rotation support always have `VK_SURFACE_TRANSFORM_IDENTITY_BIT_KHR` as the `currentTransform`, so the code will perform the same as when the feature was disabled. Add `warmUpPreRotatePipelineVariations` to explicitly control per-rotation pipeline warm up. Bug: angleproject:42262166 Change-Id: I44f6c221c11105f01f62f62622987b1955bc58aa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6433586 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>
Igor Nazarov b77f8af7 2025-04-02T19:01:48 Vulkan: Ignore SUBOPTIMAL on Android without pre-rotate Android returns `VK_SUBOPTIMAL_KHR` when window orientation changes, while ignores size changes. When "enablePreRotateSurfaces" is disabled, each present will return `VK_SUBOPTIMAL_KHR` if `currentTransform` is not `VK_SURFACE_TRANSFORM_IDENTITY_BIT_KHR`, causing swapchain recreate on each swap. This behavior makes disabling "enablePreRotateSurfaces" on Android worse than suboptimal. New "presentSubOptimalReturnedOnTransformChange" feature is currently enabled only on Android for the reason described above. It may be enabled for other platforms in the future if required. Change also improves error handling, by moving `deferAcquireNextImage()` call right after the `queuePresent()`, before any other call that may fail. This will avoid repeated present of the same image if something fails after successful `queuePresent()` call. The `checkForOutOfDateSwapchain()` and `computePresentOutOfDate()` was combined into a single method to improve error handling and to simplify the code. Bug: angleproject:397848903 Bug: angleproject:42266082 Bug: angleproject:42262166 Change-Id: I7ba2389ad2ddafc0c77c3068cd85ac9b9251ccdd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6424753 Commit-Queue: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Roman Lavrov 12dd42b8 2025-04-04T09:54:12 Reduce number of function calls in glVertexAttribPointer Small but noticeable improvement in a synthetic test on Android Bug: b/383305597 Change-Id: I6e88a06f4d3bf2e0b51ee1fd3f4f26bf55d9364e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6432611 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov 9e3467c8 2025-04-04T09:58:05 Run end2end tests single process on Linux Intel Multi-process suspected for flaky WebGPU backend test failures. Bug: angleproject:408276172 Change-Id: I2813d49f1263eeefea7db6999b5452d4cf61db92 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6432449 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 0a61aa4a 2025-04-04T09:50:59 Roll Chromium from 7d6c9811c3ae to f748acbd614f (650 revisions) Set 'android_static_analysis = "on"' GN args explicitly on Android bots (this was the default before). https://chromium.googlesource.com/chromium/src.git/+log/7d6c9811c3ae..f748acbd614f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/26ff83f048..303d67a359 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/4b3b2242db..f2adf9050d * testing: https://chromium.googlesource.com/chromium/src/testing/+log/576e7554b9..67e802f7d1 * third_party/android_build_tools/manifest_merger/cipd: CsU9U9KptiCc6Y9kUTfQfM4CWrRw4W_SxhOt6SNdf7MC..vHfVYpJ8u72iZgoN6s-BvRweZgVkKP-j_QbT8eSgc3gC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/d69d75e4f8..f14985b465 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/8010a1b2f5..df9b88b552 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/723abbda20..7f8f85ae73 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/4b760d9a76..16e46844a2 * third_party/r8/cipd: lg4ep5S4K6V2zni9jgt42ga6U-8AR6aAWNSqbe2VdmoC..zwFzxlsxS07IH4Ed1SfJTUKKoelP1ZliLtFWZqW0OioC * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/76986168fd..acc2c0d4d0 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/788cb3c270..ce5a169f50 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/a1531f6aae..d42377337b * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/d05ab7b5b9..eda5b50d9f * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/98c476af7d..2aa6f329bf * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/4faaa52ad8..7a5268f3f2 * tools/skia_goldctl/mac_amd64: Ody7aR8OnFLweRhMIL774WL6ph95_ZTz9It5m9bzo8sC..yNIr-9hJd-v5rwyRRQk5z9eBz_Ru52p8YTOc-WHIoBgC Clang version changed llvmorg-21-init-5118-g52cd27e6:llvmorg-21-init-6681-g5b36835d Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/d05ab7b5b9eccb00b2a73a1d2d19c1b0594f762e..eda5b50d9f0af91694d27361cbdd9f3357878f04/scripts/update.py Bug: angleproject:342096132, chromium:404503040 Change-Id: I1c09b6b376caf6428616d16db12a026663b68d7a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6433018 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll ce71fbaa 2025-04-04T10:01:16 Roll vulkan-deps from 48f50085fcda to f8cc64f338fb (5 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/48f50085fcda..f8cc64f338fb Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/9e702e25aa472c8528b49c874a3c03d514df1ede..54eddbe9fcf33a6b5e77b8044f332cea872fc704 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/b2fee806c378105400a1ed4bc4b63ee3c08ddc4e..5c62066bdf33a51ba8481ff16270f543c1f10076 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: I78591195c2ff91b10c3c7a0f6fb83e29c827ef41 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6433019 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov 87950668 2025-04-04T10:38:07 Suppress 5 dEQP EGL tests on Pixel 6 Vulkan Report VUID-vkGetDeviceFaultInfoEXT-device-07336 after VVL roll https://chromium-review.googlesource.com/c/angle/angle/+/6430461 Bug: angleproject:408225528 Change-Id: I5208e5b4a8eea598feb0a155a6dadb3e1e722143 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6432451 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Yuxin Hu 127aec7e 2025-04-03T13:54:17 Vulkan: Remove VVL error skips that have been fixed Test: --gtest_filter='MemoryBarrierBufferTest.TransformFeedbackBitWriteThenCapture*' Bug: angleproject:42266506 Change-Id: I0261a26157f6e44d25e6631faec96a55e470ea66 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6431825 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Yuxin Hu b8151923 2025-04-03T11:34:18 Vulkan: Remove VVL error skips that have been fixed Test: --gtest_filter='MemoryBarrierBufferTest.TransformFeedbackBitWriteThenCapture*' Bug: angleproject:42266506 Change-Id: I314ee10d9ee67f5871312d730f35c2232a9372b7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6430466 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Alexey Knyazev 1f77aa6b 2025-03-28T00:00:00 Align GetValidShader and GetValidProgram usage * Added comments and made the error condition more obvious at all call sites. * Ensured that only one error is generated by GetActiveUniform, GetAttribLocation, and ProgramUniform* entry points. Bug: angleproject:406922380 Change-Id: I26244b86b44749488dd63b538a2e7f94873a87b7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6430029 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Yuxin Hu 3f028fc1 2025-03-19T18:15:43 Enable VVL on vulkan instance created in GetSystemInfoVulkanWithICD This helps catching bugs for vulkan calls issued during GetSystemInfoVulkanWithICD(). Also changed getProc() function to get vulkan function pointers by calling vkGetInstanceProcAddr(), instead of calling dlsym(). Only use dlsym() to get vkGetInstanceProcAddr() function pointer. Bug: angleproject:407116232 Change-Id: I14dce3453c76a084db63fdb45a3db07b7b4d5294 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6374305 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
angle-autoroll 92cb669b 2025-04-03T15:26:42 Manual roll vulkan-deps from 12ef946decd5 to 48f50085fcda (21 revisions) Suppress VUID-vkQueueSubmit-pSignalSemaphores-00067 due to https://github.com/KhronosGroup/Vulkan-ValidationLayers/pull/9840 Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/12ef946decd5..48f50085fcda Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/e57f993cff981c8c3ffd38967e030f04d13781a9..c3d39de93955f884e443c39e9ffecf86e4aac883 https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/27e60d9cd9d68cfcb6ca597956a4e57ac330413b..9e702e25aa472c8528b49c874a3c03d514df1ede https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/8c88e0c4c94a21de825efccba5f99a862b049825..8e82b7cfeca98baae9a01a53511483da7194f854 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/056e3ed2c7ca7b30aa803685f806de7a2402aa85..4bd1536ed79003a5194a4bd8c9aa2fa17a84c15b https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/73d7d74bc979c8a16c823c4eae4ee881153e000a..b2fee806c378105400a1ed4bc4b63ee3c08ddc4e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,romanl@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:408190758 Change-Id: I835d826a71590c788c29cecd7958951e5b648df8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6430461 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Geoff Lang 4d478713 2025-04-03T08:10:40 Revert "Metal: Make StateCache descriptors hash consistent" This reverts commit 4334125be506e0c2c5dde4cfc29b31a7ff2bdec6. Reason for revert: Pipeline creation failures. Bug: chromium:407310859 Original change's description: > Metal: Make StateCache descriptors hash consistent > > Various descriptors would compare equality and do hashing based on the > underlying storage. The storage contains alignment padding and > bitfields. The contents of these are not defined, even when the > constructors tried to memset and memcpy. > > The various hash and compare functions also seemed to be missing some > elements, like rasterSampleCount. > > Missing == on fields and hashing unused memory may lead to inconsistency > where a==b is true but hash(a) != hash(b). > > Fix by: > Remove the memset/memcpy and write out the operator== and > hash() consistently. > > Initialize the members to their default values. > > Use uint32_t : 1 instead of bool if the struct tries to optimize for > size, since mixing types stops the packing. > > Use uint32_t to get the alignment to uint32_t, which is mostly what > is expected. > > Use uint32 someVar : N where N is payload bits + padding bits for > the last member. This way the assignment clears the padding bits. > The goal os to get the operator== to compare the padding bits, which > lets the compiler elide the memberwise compares and use word-wise > compares where it makes sense. > > This is an attempt to fix rare crashes related to map inserts > and lookups. std::unordered_map will crash if operator== is not > consistent with hash. > > Bug: angleproject:403372465 > Change-Id: I0a3a2ff327ac9f65e7d41bc9585cda54ce93ab86 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6355828 > Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com> > Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> > Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com> > Reviewed-by: Geoff Lang <geofflang@chromium.org> Bug: angleproject:403372465 Change-Id: Id111c0728b603776fd8085fd395819bb5aa14722 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6428466 Commit-Queue: Quyen Le <lehoangquyen@chromium.org> Reviewed-by: Quyen Le <lehoangquyen@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Yuly Novikov 9a3c3718 2025-04-03T09:45:37 Stop Mac Intel experiment 14.6 confirmed to not have the needed fix. Remove Intel testing from mac-exp-test, leaving only AMD testing on Radeon Pro 555X. Bug: chromium:355249262 Change-Id: I520bf2ce0f78c6962ac9e316a3ebf181d073a812 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6428765 Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Alexey Knyazev 6631db11 2025-03-28T00:00:00 Ensure ValidateTexParameterBase consistency Invalid calls must not reach the context. Bug: angleproject:406922380 Change-Id: If514b57409ceebe52182fdb3af3807b4d6236201 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6428766 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov 57b5f12f 2025-04-02T17:26:05 Move ANGLE wrangler documentation Update infra/README.md with relevant moved info and remove obsolete. Bug: b/407512213 Change-Id: Ia6e480b060d3bfae465974f76453d93790c93386 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6424754 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Alexey Knyazev eb52b568 2025-03-28T00:00:00 Remove unsupported 1D and DSA entry points OpenGL ES does not support 1D textures, removed TexStorage1DEXT. OpenGL ES does not support DSA, removed EGLImageTargetTextureStorageEXT. Added an explicit command blocklist. Added hashes for *_vulkan_secondaries_* def files. Fixed: angleproject:407932145 Change-Id: Iec34fa475f34a0fa832a49223c51ff1f87b1915d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6426049 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Alexey Knyazev f20c0c5e 2025-03-28T00:00:00 Remove obsolete desktop GL files Bug: angleproject:370937467 Change-Id: Ibd15c982b646627fb8154d92ad2e0e35f98fbd32 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6428567 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov a7e8c957 2025-04-01T17:08:01 Split SetUniform into inline and noinline path Makes a single smaller function for the common cases, and setting uniforms with a stride or boolean conversion is extracted to separate function calls. This results in the main SetUniform being about half in assembly size and yields a small but noticeable performance improvement in my tests on an Android device. Impact on the binary size is negligible. Bug: b/383305597 Change-Id: I630ff41cfeea6ce9e24e30cdebfbb58382e67de7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6422893 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll f276df66 2025-04-03T07:01:43 Roll Chromium from 7174c94754cb to 7d6c9811c3ae (593 revisions) https://chromium.googlesource.com/chromium/src.git/+log/7174c94754cb..7d6c9811c3ae If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/bcb43d769b..26ff83f048 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/299cb62c60..4b3b2242db * testing: https://chromium.googlesource.com/chromium/src/testing/+log/cbdef77aaa..576e7554b9 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/a34b6b0a58..d69d75e4f8 * third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/4c4968f108..9b76875fb4 * third_party/fuchsia-sdk/sdk: version:27.20250326.5.1..version:27.20250402.5.1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/35a5aaad4a..723abbda20 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/23bef80461..4b760d9a76 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/5f7b95ef68..f2622a898c * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/58c91d0ae3..76986168fd * third_party/siso/cipd: git_revision:9e4e007a51fdfd51e809d2817a3d6bbd3ec3b648..git_revision:0dd559fac7db9d72c9cbee525ab596b8a10b79d0 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/8dc5380671..a1531f6aae * tools/luci-go: git_revision:7a44078a668bc9f75dd6e40a332450e76f2f7399..git_revision:cd0142e4e2f376bb0bd1b34a3b91167aff5226bf * tools/luci-go: git_revision:7a44078a668bc9f75dd6e40a332450e76f2f7399..git_revision:cd0142e4e2f376bb0bd1b34a3b91167aff5226bf * tools/luci-go: git_revision:7a44078a668bc9f75dd6e40a332450e76f2f7399..git_revision:cd0142e4e2f376bb0bd1b34a3b91167aff5226bf * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/d1c57e211b..98c476af7d * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/e53211ba36..4faaa52ad8 * tools/skia_goldctl/linux: mAk01oyt7P30KZ8p-gF-TU0M9dL73ZIC-I_tGTQa6KAC..Ygv7ZB2vTXUWbXtH1I2DNMSB1D7GkvpabMuyVEJpINAC * tools/skia_goldctl/mac_amd64: APuhNAZ7G50nWWPrYCk2prrPklE_TclJEz4gicnBaSwC..Ody7aR8OnFLweRhMIL774WL6ph95_ZTz9It5m9bzo8sC * tools/skia_goldctl/mac_arm64: Sfu8dXj0tJ8uWFOZr90L_rVRcp8Kcy8zLsfelpk6K2YC..zQOaSHuVEWVro28b0D6FdKiq5f8KhkMG_XOFqAdgoIUC * tools/skia_goldctl/win: xe_VroL0THL1s9UZb-GM9rfVmOK9xmX2rya2pwbfX-AC..DWI5tbnr7u5QE7UFkrzeJI3hqZyLqA8E_xOqOpNU0vgC No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: Ia7ab1fa1b9c8194f2f08b44dae3e1dd2c7ef1cb8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6429307 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Le Hoang Quyen 0f9feb49 2025-03-15T23:51:04 Metal: Use render passes for B2T PBO copies. This would make it possible to avoid setting ShaderWrite usage to all textures in future. Bug: chromium:392521084 Change-Id: I25145f3578589c71ee469df08162d3a3f17c8cbe Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6356129 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Quyen Le <lehoangquyen@chromium.org>
Yuxin Hu 9ee2c7e7 2025-04-02T16:01:45 Vulkan: Remove VVL error skips that have been fixed Bug: angleproject:42265220 Change-Id: I828f1d96a19efd0de9220b2168cfa9c3aab80912 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6427323 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Kenneth Russell fd722f9a 2025-03-31T23:23:26 Avoid emitting SampleCmp in discontinuous loops. Apply fix by Mikkel Simonsen from Unity to use texture level 0 when using textureLod with a shadow sampler inside a discontinuous loop. Bug: angleproject:406190894 Change-Id: If02b687f15ec4c3e8bd1b8eece72098d498e2ce1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6421496 Auto-Submit: Kenneth Russell <kbr@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org>
Alexey Knyazev f56c8e02 2025-03-28T00:00:00 Fix & cleanup advanced blend equations support * Made advanced blend equation extensions enableable to facilitate better testing. * Made initial BLEND_ADVANCED_COHERENT state to be unconditionally true regardless of the extension support. If the coherent extension is unsupported, that state must not be observable anyway. * Ensured that advanced blend equation functionality is supported on unextended OpenGL ES 3.2 contexts. * Removed redundant ES 2.0+ context version checks because these extensions must never be enabled on ES 1.x contexts. * Fixed ValidateBlendBarrierKHR to set the correct error code and properly mark invalid calls. * Added more negative test cases and enabled tests on OpenGL ES 3.0 contexts. Bug: angleproject:42262258 Bug: angleproject:406922380 Change-Id: I709376ad40b09972a31a691ca3813e87dd2c8165 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6421857 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Robic Sun 45de9be0 2025-03-27T16:38:28 num_views layout qualifiers are allowed only in vs Bug: angleproject:385038758 Change-Id: I415c9d83b227673f9fbeeb30e8f51d69c34212ef Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6414749 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Robic Sun <Robic.Sun@arm.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Yuxin Hu a625043f 2025-04-01T16:09:14 Vulkan: Remove VVL error skips that have been fixed Bug: angleproject:42265220 Change-Id: Ia2048817c6238031c83aaa237c6c88b0e9a9ebf9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6423550 Auto-Submit: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi b64aa6d5 2025-03-27T18:31:19 Capture: Implement param capture for some Chromium entry points Bug: b/381284577 Change-Id: I3b019e795aecf989ad58e644dc8475d9c8740314 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6406216 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll c1ac75fd 2025-04-02T08:34:36 Roll Chromium from 9c50be5811be to 7174c94754cb (665 revisions) https://chromium.googlesource.com/chromium/src.git/+log/9c50be5811be..7174c94754cb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/01729aa466..bcb43d769b * testing: https://chromium.googlesource.com/chromium/src/testing/+log/810b107183..cbdef77aaa * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/3fbb10e80d..1e8b41f1ec * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/5bda0fdab9..8010a1b2f5 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/97989c1bfa..23bef80461 * third_party/r8/d8/cipd: f-Ka2tsB3j_I6-Av4qE9ftl6KddtjV-pRVcUUc9cgYQC..wvbyt_Mr06Bl4Rcv4zoX-sTk_keiEYxfspOMUufh5nIC * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/0f7aa4a0bc..58c91d0ae3 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/c321e793a0..8dc5380671 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/0078c27c43..d05ab7b5b9 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/47050c4ced..e53211ba36 * tools/skia_goldctl/mac_amd64: pCkkLpPyiV-gWMQPUcghBJQnI8o55Ql5Litx-M4FZBUC..APuhNAZ7G50nWWPrYCk2prrPklE_TclJEz4gicnBaSwC * tools/skia_goldctl/mac_arm64: nPFIBSkoK5DC-UNkPXfSgIRWqJznIQ4uhmoBWYvKU20C..Sfu8dXj0tJ8uWFOZr90L_rVRcp8Kcy8zLsfelpk6K2YC No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: I0c2ac366d739c23848cafdc42d8dc4bdf797e62f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6424521 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 1b95a5ae 2025-04-01T16:36:38 Capture: Fake surface size if no surface If a context never uses a surface, create a fake one for the sake of capture/replay. Bug: b/381284577 Change-Id: I42db06d52d0ad17ee9921542e7cb56c910810ae7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6422892 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi c9956ce0 2025-04-01T16:35:32 Capture: unMakeCurrent before destroying a context In preparation for a change where unMakeCurrent can act like swap to capture contents in applications that don't actually call swap. Bug: b/381284577 Change-Id: I6449590f90964107c5f0feb82cbe29d26bbd0d9d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6422891 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Roman Lavrov 23c1e11e 2025-04-01T11:27:02 Disable platform trace events by default, except Chromium build Observed overhead in perf builds is too significant, some workloads generate thousands of events per second. There does not seem to be a simple way to get around the overhead - it could be somewhat reduced but the event rate is just too high. ANGLE_TRACE_EVENT*(...) etc become a no-op by default. Can be re-enabled with angle_enable_platform_trace_events=true gn arg Bug: angleproject:404542398 Change-Id: I8d7363ee28d22226f1860e24f2399bb4129cfb84 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6419308 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Feels: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Alexey Knyazev eec873ed 2025-03-28T00:00:00 Fix FramebufferTexture2DMultisampleEXT validation Generate an error when the samples value is negative. Bug: angleproject:406922380 Change-Id: I508f3ddf82e30291fdcc3086ab19ebfa4f84947c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6421716 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Alexey Knyazev f4386ce6 2025-03-28T00:00:00 Ensure ValidateEGLImageTargetTexStorage entry point consistency Invalid calls must not reach the context. Also fixed the cube map array support condition. Bug: angleproject:406922380 Change-Id: Ibc67c6b5ccddb7cf6c86b0c93589fe0b186bcdbd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6418902 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Alexey Knyazev c51c1679 2025-03-28T00:00:00 Ensure ValidateEGLImageTargetTexture2D entry point consistency Invalid calls must not reach the context. Bug: angleproject:406922380 Change-Id: Id546e54faac68d1b47b32df701ec00cd6fba1d6d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6419042 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 9b471972 2025-03-28T00:00:00 Ensure ValidateTexStorageAttribs* entry points consistency Invalid calls must not reach the context. The corresponding extension requires OpenGL ES 3.0. Bug: angleproject:406922380 Change-Id: I8e19a192b536a384c36514e6cab226ee0663edd3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6419162 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
angle-autoroll 2ded15f2 2025-04-01T10:01:07 Roll vulkan-deps from 2b7c95ec76d5 to 12ef946decd5 (5 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/2b7c95ec76d5..12ef946decd5 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/6f355619b1b1bfce2b5fb1dcf2aca0d55f9606de..27e60d9cd9d68cfcb6ca597956a4e57ac330413b https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/2e83ad7e6f2cc51f7eaff3ffeb10e34351b3c157..056e3ed2c7ca7b30aa803685f806de7a2402aa85 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/78c359741d855213e8685278eb81bb62599f8e56..2ac81691baf291e7f4aad07596d7073974dbc4dd https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/0d5b49b80f17bca25e7f9321ad4e671a56f70887..551221d913cc56218fcaddce086ae293d375ac28 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/f05377bc6368b09065f2746eb2f5758ae98deb38..73d7d74bc979c8a16c823c4eae4ee881153e000a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: If9ee3a56f8f77eb38827ced12daa2fa70db422f1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6421498 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 4225a654 2025-04-01T03:01:12 Roll SwiftShader from e48c89759b6c to 4982425ff1bd (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/e48c89759b6c..4982425ff1bd 2025-03-31 swiftshader.regress@gmail.com Regres: Update test lists @ e48c8975 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: If7befb577eb46728aaf51648fd74ce214d1bd027 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6421940 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll aa80ab40 2025-04-01T07:00:44 Roll Chromium from 28cc0f7b2a08 to 9c50be5811be (604 revisions) https://chromium.googlesource.com/chromium/src.git/+log/28cc0f7b2a08..9c50be5811be If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/451ef881d7..01729aa466 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/6f359296da..299cb62c60 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/f46b86c7f1..810b107183 * third_party/android_build_tools/error_prone/cipd: 2cQ2nbgV3geU7-RincCggMgIe4NuUB_eW5Rm58CgMY8C..muHOjW6H-gb8j6gY4sUylWC1paxyWPRMAeYZ1Ok8KkwC * third_party/android_build_tools/lint/cipd: hwubetoXxz5wxh6e9dQGVJl1Ih69nM8m0tFi5cUGujIC..cpi5krkjlhoCfjDOZ3fIdPXDOqnCGMBVzm_yHg1WnWUC * third_party/android_build_tools/manifest_merger/cipd: Gv6-zTnY5Cj7i1ck5bS92diwCClFq1HHoTCf4kWr4SsC..CsU9U9KptiCc6Y9kUTfQfM4CWrRw4W_SxhOt6SNdf7MC * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/449310fe2e..35a5aaad4a * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/188329a7f2..97989c1bfa * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/ed57732033..0f7aa4a0bc * third_party/siso/cipd: git_revision:68bdc49e4e23aef066fc652cbdb1b4973aab1a31..git_revision:9e4e007a51fdfd51e809d2817a3d6bbd3ec3b648 * third_party/turbine/cipd: lnlrbUuImYl1BaRqVclTMOqA0KVYDYdym4ujLkPurbMC..scfGptWnO9bwzbg-jr0mcnVO3NG5KQJvlAQd_JSD5QUC * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/01d0ad994b..47050c4ced No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: I8ce03fb2bafc08aa935d4915720756266a0a4d20 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6419667 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amirali Abdolrashidi bbf92d12 2025-03-21T12:43:14 Vulkan: Add workaround flag for extra submit fence This change is a workaround for some devices exhibiting a device-lost error related to the fence usage in the command batches when working with EGL sync objects, such as a cycle similar to below: - <Some GL work> - eglCreateSyncKHR() - glFlush() - eglDupNativeFenceFDANDROID() - eglDestroySyncKHR() - <More GL work> (The exact point of error and the reason for the device-lost remain unknown.) This change is meant to mitigate such errors on those devices if needed. However, for the rest, the feature will remain disabled. * Added a new feature flag: enableExtraSubmitFence * Modified the usage of mFence in CommandBatch * It is also used when enableExtraSubmitFence is enabled, even if there is an external fence. * When there is an external fence, this object is used to create an empty submission after the primary commands are submitted using the external fence. * Added the config to enable EnableExtraSubmitFence for the following suite: EGLSyncTest Bug: b/384477641 Change-Id: I05f8bdcc804967c4984416af802326d22afd7a46 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6378778 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Neil Zhang 0d1478f3 2025-03-27T18:40:05 Fix dFdx() dFdy() in frag shader not work as expected When render to FBO0, Y axis will flipping, Angle's compile module will handle this, but only when glsl version > 300, that's a mistake as glsl 100 also have dFdx/dFdy when have GL_OES_standard_derivatives. Bug: angleproject:406819301 Change-Id: I656cfcfdeff1e80db374cfa083578adda6064e69 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6407233 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Auto-Submit: Neil Zhang <Neil.Zhang@arm.com> Commit-Queue: Charlie Lao <cclao@google.com>
Alexey Knyazev 603fd115 2025-03-28T00:00:00 Ensure ValidateLoseContextCHROMIUM entry point consistency Invalid calls must not reach the context. Bug: angleproject:406922380 Change-Id: I5d0d74ea28ae16efba1bd447f6187a36c05c45c7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6417008 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev de71760b 2025-03-28T00:00:00 Ensure ValidateGetMemoryObjectParameter entry point consistency Invalid calls must not reach the context. Bug: angleproject:406922380 Change-Id: I6b4fadabe93215839fcd6c8d35952f37d5a6755b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6417007 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Alexey Knyazev a8c60a3e 2025-03-28T00:00:00 Ensure texture_border_clamp entry points consistency Invalid calls must not reach the context. Affects all entry points added by the texture_border_clamp extensions. Bug: angleproject:406922380 Change-Id: I5e2a58ef70396e27f1ae681595359690e1ca14f4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6417005 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao ecc378cc 2025-03-03T16:43:33 Reland "Dont use Subject/Observer for SwapchainImageChanged" This is reland of the following CL https://chromium-review.googlesource.com/c/angle/angle/+/6319893 Because we do deferred ANI (VkAcquireNextImage) call until image is needed, we need a way to force Context to go through FramebufferVk::syncState call (FramebufferVk::syncState calls WindowSurfaceVk::getAttachmentRenderTarget, which end up calling ANI. Right now we uses subject/observer mechanism, by sending angle::SubjectMessage::SwapchainImageChanged to all observers of WindowSurfaceVk. In this case it is egl::Surface. Then eglSurface redirects this message to its observers, which are all gl::Framebuffer's attachments: color, depth, stencil. Even though only color attachment needs to be notified, but because we don't have a separate list of observers, depth/stencil attachment also receive the notification and they early out. Then gl::Framebuffer sets DIRTY_BIT_COLOR_BUFFER_CONTENTS_0 dirty bit and send the angle::SubjectMessage::DirtyBitsFlagged to Context, which dirty DrawFBO and ReadFBO and dirty cached state. Note that this is specific for swap image changed case, there is no surface property change (surface property change will still trigger the subject/observer message with SubjectMessage::SubjectChanged message, but this occurs rarely). This gets worse for apps that uses multiple contexts, for the example pokemon_masters_ex has three contexts, each context has its own default frame buffer that attach to the same surface, and we never remove non-current context from the observer list. This end up with egl::Surface has 12 observers and for every frame, it loop over the list of 12 observers and send message (virtual function call) to each of them. Color attachment also ends up sending two messages to Context, one for Read FBO and another for Draw FBO. There are total 21 virtual function calls. Even for single context usage, you have 6 virtual function calls, for every frame. EGL spec says "an EGLSurface must be current on only one thread at a time", any other context must call EGLMakeCurrent in order to use this surface, which will add all necessary dirty bits at that time. So we really only need to notify current context. In this CL, SwapchainImageChanged no longer uses subject/observer mechanism, so this message is removed. This CL still uses subject/observer mechanism to send DirtyBitsFlagged from Framebuffer back to context. We could call setDrawFramebufferDirty and setReadFramebufferDirty directly, but that will require to remove the "const" decoration out of gl::Context which generates too much code diff, so onStateChange(angle::SubjectMessage::DirtyBitsFlagged) is still used. Bug: angleproject:400711938 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6319893 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Change-Id: I017b0e8934b5194a520828fa5c4af1d6e3ef9aac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6404621
Roman Lavrov cbfa8e38 2025-03-31T09:51:33 Add "likely" hints to common validation paths This makes the hot path assembly more local. I can't tell if there is an observable effect of just doing this on the regular build performance, but this generally makes sense and reduces the assembly difference with PGO builds. Bug: b/383305597 Change-Id: Icb191e8e927217d9db4cb505d5cd6f76536403e3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6416263 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Shahbaz Youssefi 362161fa 2025-03-28T11:22:46 Translator: Use unsized int for swizzle components Bug: angleproject:349994211 Change-Id: Ibee2c664f159960cf9bf860496038bbb32ae355a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6408391 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 4536457b 2025-03-28T00:00:00 Ensure ValidateCompressedTex[Sub]Image*Robust consistency Invalid calls must not reach the context. Bug: angleproject:406922380 Change-Id: I3c3849c08f17fda76f4cf1f2b4ec989d3da81431 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6415818 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 7eb57729 2025-03-31T10:01:22 Roll vulkan-deps from 23bc8dbadec2 to 2b7c95ec76d5 (6 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/23bc8dbadec2..2b7c95ec76d5 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/393d5c7df150532045c50affffea2df22e8231b0..2e83ad7e6f2cc51f7eaff3ffeb10e34351b3c157 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/10054abc9804429e754c89e086479ec02fbc1f41..f05377bc6368b09065f2746eb2f5758ae98deb38 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: Ib645791db6cd0726d338d4a43a2608e17a1b5588 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6414633 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 87b40ed7 2025-03-31T08:01:13 Roll Chromium from 00f326e47697 to 28cc0f7b2a08 (867 revisions) https://chromium.googlesource.com/chromium/src.git/+log/00f326e47697..28cc0f7b2a08 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/69a0df1110..451ef881d7 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/244e7cf445..6f359296da * testing: https://chromium.googlesource.com/chromium/src/testing/+log/f04b724022..f46b86c7f1 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/f4cca3dc40..3fbb10e80d * third_party/android_build_tools/lint/cipd: DGEQcQfbonqqmrtaKLbu7qkNhJgyZ5ONzcseAUFVX08C..hwubetoXxz5wxh6e9dQGVJl1Ih69nM8m0tFi5cUGujIC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/058fc7baf2..a34b6b0a58 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/5b409767f0..5bda0fdab9 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/4f05e20cbe..449310fe2e * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/ffdeea1ab2..188329a7f2 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/b714f7890b..5f7b95ef68 * tools/skia_goldctl/linux: vazjtxPs2ne3diaKMZlh4oRw0uOc0QRtGX1ef8Mk1XwC..mAk01oyt7P30KZ8p-gF-TU0M9dL73ZIC-I_tGTQa6KAC * tools/skia_goldctl/mac_amd64: 2r-pYYyfAsqSnHU2lu_Wks4oYZe25O8BkIr57nrTkxYC..pCkkLpPyiV-gWMQPUcghBJQnI8o55Ql5Litx-M4FZBUC * tools/skia_goldctl/mac_arm64: 3Y8BzQv26tXLWIz4Yxmu5__U7FuZI-Lj6sGFEHe3jA4C..nPFIBSkoK5DC-UNkPXfSgIRWqJznIQ4uhmoBWYvKU20C * tools/skia_goldctl/win: Bmh87jeaHatj39PYjQrF4wz1Ly2FIHp_11IwqQKX_KkC..xe_VroL0THL1s9UZb-GM9rfVmOK9xmX2rya2pwbfX-AC No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: Ie91d8037fb27db30ad5eee07329dc0fed1892088 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6414631 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b0d8fe89 2025-03-31T08:01:37 Roll VK-GL-CTS from 57854cfe3f6c to b6bb4bab7b4a (12 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/57854cfe3f6c..b6bb4bab7b4a 2025-03-28 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.2 into vk-gl-cts/main 2025-03-28 lorenzo@khronosgroup.org Notice of withdrawal of Vulkan CTS 1.3.8.x 2025-03-27 javed@igalia.com Add coverage for indirect after base dispatch 2025-03-27 javed@igalia.com Add test for OpArrayLength 2025-03-27 ziga@lunarg.com Add simple xfb test with triangles 2025-03-27 ziga@lunarg.com Test using a swapchain with acquired image in .oldSwapchain 2025-03-27 zzoon@igalia.com Fix validation errors in Vulkan Video encoding tests. 2025-03-27 rgarcia@igalia.com Add depth/stencil <-> color copy variants with attachment usage 2025-03-27 rgarcia@igalia.com Add tests for depth-only pre-passes and post-passes 2025-03-27 rgarcia@igalia.com Add callable shaders to RT VK_KHR_pipeline_binary tests 2025-03-27 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.12 into vk-gl-cts/main 2025-03-26 rgarcia@igalia.com Remove unused classes and methods that were causing compiler warnings If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: I9bc130703471b4d2d414a177b05dee03ee462607 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6414632 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexey Knyazev 1b34d2a1 2025-03-28T00:00:00 Ensure ValidateUniform* consistency Uniform calls are valid when location is -1 or ignored. Bug: angleproject:406922380 Change-Id: I7f829f7f8a67ba6bac39ff8ee06c7f26c1421417 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6408952 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 64dc6096 2025-03-28T00:00:00 Ensure ValidateDelete{Program|Shader} consistency Deleting program zero is valid. Deleting shader zero is valid. Bug: angleproject:406922380 Change-Id: I2a26be8200585fae3a70c0a904be96ff590ebe7b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6409251 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Yuxin Hu eb8deecd 2025-03-28T14:03:50 Remove VVL error skips that have been fixed Bug: angleproject:42265220 Change-Id: I1588db6ec2846faf92eef9042ba483547c0f5127 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6410511 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
angle-autoroll 406f9217 2025-03-28T19:01:21 Manual roll vulkan-deps from 525b5b9d77ef to 23bc8dbadec2 (10 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/525b5b9d77ef..23bc8dbadec2 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/0e710677989b4326ac974fd80c5308191ed80965..8c88e0c4c94a21de825efccba5f99a862b049825 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/6b3cbe3f81357a47cdcac896bd9b145bcd3fa14e..10054abc9804429e754c89e086479ec02fbc1f41 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I4127b1d4165da7c07248e678b6f9ad3b0640c676 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6408893 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexey Knyazev 05d15800 2025-03-28T00:00:00 Ensure ValidatePixelStorei consistency Added missing return and frontend assertion for the GL_PACK_REVERSE_ROW_ORDER_ANGLE parameter. Covered by WebGLCompatibilityTest.EnablePackReverseRowOrderExtension Bug: angleproject:406922380 Change-Id: Iafa7646c0429d1269315e1003fac98d61231af55 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6409831 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov b1eecd41 2025-03-28T16:54:49 Skip flaky BlitFramebufferTest on Linux Intel GL Bug: angleproject:404958319 Change-Id: I287723feeb7ba3a526a9b4eab91ef53d16f436bd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6409092 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Yuly Novikov 9542be7f 2025-03-28T16:37:15 Allow uninstantiated ContextNoErrorTestES31 No ES31 on iOS Metal. Bug: angleproject:406935597 Change-Id: I754c8bb7ba6a1798f7c55411ad5332eca8c7b86a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6409091 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 8c26988a 2025-03-28T13:56:40 Manual roll vulkan-deps from 436b13b0fc28 to 525b5b9d77ef (1 revision) Manual roll requested by ynovikov@google.com Update export_targets.py due to http://github.com/KhronosGroup/Vulkan-ValidationLayers/pull/9790 conditionally including "parallel_hashmap/phmap.h" instead of "robin_hood.h" behind USE_CUSTOM_HASH_MAP. https://chromium.googlesource.com/vulkan-deps.git/+log/436b13b0fc28..525b5b9d77ef Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/2e6787d498d65bc20c195d667b8cd3c63e1a8aa9..6b3cbe3f81357a47cdcac896bd9b145bcd3fa14e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:42264327 Change-Id: I05b9511948e35f98d332ac70984eda7c6af5978e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6407871 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi 33b9c065 2025-03-27T18:22:30 Capture/Replay: Fix sample build It still doesn't correctly run however, it looks like loading the entry points is broken. Bug: angleproject:42264451 Change-Id: I946b07ea622145e62410d9739541e074904b7a6c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6406213 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 184a389f 2025-03-27T00:00:00 Ensure program state for indirect draw entry points If the currently bound program is being relinked, Context::prepareForDraw needs to wait until it's ready before syncing the backend state. Added the required logic and no-op handling to indirect draw entry points. Fixed: angleproject:406935597 Change-Id: I82fb426b02a275bc67f71f9bd07484fa5802bc09 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6404481 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuxiang Qian 0bd4e4fe 2025-03-20T17:34:47 Add EGL siblings check in eglCreateImage If a renderbuffer/texture is created from an EGL image, then it is an EGL target and considered as an EGL sibling. If it is used to create EGL image, then it would also be an EGL source. EGL_BAD_ACCESS should be returned. An end2end test is also added. Bug: angleproject:406029225 Change-Id: I51fe5b70d8a6d1939ae1defc02edfe5cf8167684 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6389218 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll ba74a1f3 2025-03-28T11:12:40 Manual roll vulkan-deps from 7f9757f8082d to 436b13b0fc28 (4 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/7f9757f8082d..436b13b0fc28 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/a48b473403b0990c62ff3175f1e63cbd8c906184..393d5c7df150532045c50affffea2df22e8231b0 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/32ee3e6e333a4bc4064fe64cfdfdcf6e71a92743..289efccc7560f2b970e2b4e0f50349da87669311 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/52b492f11e74dcd44ad3e906125feae79d440c99..2e6787d498d65bc20c195d667b8cd3c63e1a8aa9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I224054b58825dbaeaaee494f582fee4951c41b54 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6407315 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Kimmo Kinnunen 4334125b 2025-03-14T16:12:32 Metal: Make StateCache descriptors hash consistent Various descriptors would compare equality and do hashing based on the underlying storage. The storage contains alignment padding and bitfields. The contents of these are not defined, even when the constructors tried to memset and memcpy. The various hash and compare functions also seemed to be missing some elements, like rasterSampleCount. Missing == on fields and hashing unused memory may lead to inconsistency where a==b is true but hash(a) != hash(b). Fix by: Remove the memset/memcpy and write out the operator== and hash() consistently. Initialize the members to their default values. Use uint32_t : 1 instead of bool if the struct tries to optimize for size, since mixing types stops the packing. Use uint32_t to get the alignment to uint32_t, which is mostly what is expected. Use uint32 someVar : N where N is payload bits + padding bits for the last member. This way the assignment clears the padding bits. The goal os to get the operator== to compare the padding bits, which lets the compiler elide the memberwise compares and use word-wise compares where it makes sense. This is an attempt to fix rare crashes related to map inserts and lookups. std::unordered_map will crash if operator== is not consistent with hash. Bug: angleproject:403372465 Change-Id: I0a3a2ff327ac9f65e7d41bc9585cda54ce93ab86 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6355828 Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll ddb625e1 2025-03-28T08:24:43 Roll Chromium from ec4e9eb8075e to 00f326e47697 (674 revisions) https://chromium.googlesource.com/chromium/src.git/+log/ec4e9eb8075e..00f326e47697 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/c78c56ad7e..69a0df1110 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/4eaf4a392d..f04b724022 * third_party/android_build_tools/manifest_merger/cipd: YS3S6_AiCf06beDfeUId4rgDQEi9n0QGN_dUHdUiMx4C..Gv6-zTnY5Cj7i1ck5bS92diwCClFq1HHoTCf4kWr4SsC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/d405938e5a..058fc7baf2 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/5b44c1060a..5b409767f0 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/225cbadd34..ffdeea1ab2 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/b370f51abd..b714f7890b * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/64b6cce205..ed57732033 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/1c3ff5c90c..0078c27c43 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/20b7955065..d1c57e211b * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/a3f52bfa9f..01d0ad994b No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: Ib21ab9efd433a324495bc8e6f3afc5980abbc093 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6405728 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexey Knyazev 799d301f 2025-03-27T00:00:00 Ensure program state for multi-draw entry points If the currently bound program is being relinked, Context::prepareForDraw needs to wait until it's ready before syncing the backend state. Aligned all three no-op draw context helpers. Fixed: angleproject:406814763 Change-Id: I10eed90bb2fe853b558291fc8fe17d13652e0420 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6405536 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Robic Sun 7fb1ac40 2025-03-10T20:28:56 Support EGLImageTargetTexture2DOES + GenerateMipmap According to the spec, If an application adds mipmap levels to a texture originally created with EGLImageTargetTexture2D, OpenGL will allocate new memory for the updated texture, copying existing data, including from the EGLImage source. So, relevant support is added. Bug: angleproject:405840226 Change-Id: I4495df2d8ee1e18b4482808a290dcd861ef85b77 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6335305 Auto-Submit: Robic Sun <Robic.Sun@arm.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
kmx.io     mail     discord kmxgit v0.4.0