kc3-lang/angle

Log

Author Commit Date CI Message
angle-autoroll 0a40f9f3 2025-06-26T16:05:37 Manual roll Chromium from e9b993c93b3b to 3e575cefc53a (204 revisions) Manual roll requested by geofflang@google.com https://chromium.googlesource.com/chromium/src.git/+log/e9b993c93b3b..3e575cefc53a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/660c19b81f..9cfbcbcdd9 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/14abe7e6ae..78457247d1 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/cb4a6fc970..9d5b043d87 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/046519adb4..532e27cf37 No update to Clang. Bug: angleproject:427600175 Tbr: yuxinhu@google.com,geofflang@google.com Change-Id: Ie8226208abd9af52b2892fd2ab605f4c2391f61c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6680000 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Kramer Ge dcc715ee 2025-06-19T15:35:53 Enable EGL_PLATFORM_GBM_KHR platform with device selection FunctionsEGL.cpp: - Allow EGL_PLATFORM_GBM_KHR platform and explicit device selection. - Skip getPreferredDisplay if an explicit device is specified. Display.cpp: - Use DisplayEGL impl with EGL_PLATFORM_GBM_KHR. - Wayland can use GBM platform, and OPENGLES. angle.gni: - Rename ozone_platform_gbm to ozone_platform_drm since its deprecated. Bug: angleproject:425569857, b/396434686 Change-Id: I9493118f9dc95f78ebe46277bb4fcfeb7a29d465 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6663699 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Kramer Ge <fangzhoug@chromium.org>
angle-autoroll e7ede7d7 2025-06-26T10:01:15 Roll vulkan-deps from e7bba33afe37 to 216f8f420080 (18 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/e7bba33afe37..216f8f420080 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/efd24d75bcbc55620e759f6bf42c45a32abac5f8..e9d166cd3bdb4d3c89c6c89c7d9f196a0c9e4ffb https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/8e3261f207f1c520522be2021cf364ebb1bad3f0..00e8a166b8c371d8ff6f70ea7872a311b43817ee https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/2a611a970fdbc41ac2e3e328802aed9985352dca..04b76709bf40a7ce8df3382060ef3620f19de566 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/33e02568181e3312f49a3cf33df470bf96ef293a..604c3e75a41b3605ac86bdf5bc26987bd9f9589f https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/6016c4624f8ad3df64987936bfbeb29f32da2d55..153542280969323563e588308cb8796df5931d06 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: Icd95d43f905e897e4b7a59706ecfabdc07d1c3fd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6679275 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 5023a762 2025-06-26T03:01:45 Roll SwiftShader from ed01d9931de3 to 436722b39118 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/ed01d9931de3..436722b39118 2025-06-25 tikuta@google.com Fix conflicting types error in clang modules build If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I31eb7618114872edae931e04181238ffef7942b3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6678109 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 19e4deb5 2025-06-26T09:41:09 Roll Chromium from 263c8e504d0e to e9b993c93b3b (576 revisions) https://chromium.googlesource.com/chromium/src.git/+log/263c8e504d0e..e9b993c93b3b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/7404e7cb13..660c19b81f * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/cf875f9ac3..f7862e515c * testing: https://chromium.googlesource.com/chromium/src/testing/+log/c4185e4f15..14abe7e6ae * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/9fc6afe878..06a7007d07 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/0c0721de3c..8b6c661e42 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/2c359c239b..b5d83e70a1 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/e44c3c4560..02570151a8 * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/4b5d818f29..10890f1e73 * third_party/siso/cipd: git_revision:c23de742b8483ddc09d8b68ef845efc7f5c6192f..git_revision:13b7a626dcadfb49c7f4759a44095cebea6e91bc * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/b1c9da6382..046519adb4 * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/12ac1a1b8e..c52b68f9dc No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: Ibe8856d9ad9cafa0323b37d1cded42c34e611116 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6679272 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Igor Nazarov d5babf99 2025-06-23T12:46:51 Vulkan: Fix unhandled deferred clears after glGetMultisamplefv Issue was introduced in the commit that implemented deferred clears. The `glGetMultisamplefv()` synchronizes draw framebuffer which defers possibly staged clears. Since API is not handling deferred clears they are left untouched, causing the ASSERT. This change fixes the issue by not deferring clears for the `glGetMultisamplefv()` command during flushing staged updates of dirty framebuffer attachments. Changes: - Add `gl::Command::GetMultisample` enumeration for clarity. - Add `gl::CommandBlitBuffer::CommandBlitBufferDepthStencil` enumeration to improve code readability. - Add `command` parameter into `gl::State::syncDirtyObject()` method to use actual command enum instead of `Other`. - Remove `previousDeferredClears` local variable and update ASSERT in the `FramebufferVk::syncState()` method. New assert ensures empty `mDeferredClears` instead of just checking dirty attachments, since it is easy to make all attachments dirty making old and new assertions act the same. - Replace logic in `FramebufferVk::syncState()` that decides whether need to defer attachments or not with switch-case. This makes the logic more clear regarding handling individual commands and simplify updating this handling in the future. Except of the bug fix with `GetMultisample` command, handling of other command is uncached. - Remove `flushDeferredClears()` from `FramebufferVk::readPixels()` because `mDeferredClears` are not expected (now it's more clear after the refactoring). And even if there are `mDeferredClears` (in case of a bug or after API failure), `flushDeferredClears()` only flushes clears for the draw framebuffer, while checking `mDeferredClears` of the read framebuffer. This is a problem in case if read and draw framebuffers are not the same. Bug: angleproject:40644727 Test: angle_end2end_tests --gtest_filter=TextureMultisampleTest.GetMultisamplefvAfterClear/* Test: angle_end2end_tests --gtest_filter=EGLSurfaceTest.GetMultisamplefvAfterClear/* Change-Id: I376a62de52de5e17dbc63cc7ddb0506741a69266 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6661958 Commit-Queue: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Mohan Maiya b3ec3a5f 2025-06-23T14:51:13 Track active uniform and storage buffer blocks Track active uniform and storage buffer block indices so we can process updates to only active buffer blocks Bug: angleproject:426412564 Change-Id: I54fa6fbe795073887646d672303d231ed4317b65 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6663825 Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com>
angle-autoroll c455bda6 2025-06-25T09:34:06 Roll Chromium from 2fb03826f7a0 to 263c8e504d0e (692 revisions) https://chromium.googlesource.com/chromium/src.git/+log/2fb03826f7a0..263c8e504d0e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/8d59c1de51..7404e7cb13 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/39d3a59234..cf875f9ac3 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/d1addfdf7f..c4185e4f15 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/e3d58ba1a2..43850be4d3 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/f46835180c..9fc6afe878 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/c4f7831fe8..0c0721de3c * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ea7a0baff0..838762e3ae * third_party/r8/d8/cipd: F0pTWc6uG70kZPngypnQxCgD3CgY5D8O-pDqj_qeoQMC..9vZCRnASPSjh3_T-2AsumCO_8C5PuBJ5-e84K9b7-80C * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/35982745eb..4b5d818f29 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/5a2ef49216..0677411eff * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/3b495dd794..cb4a6fc970 * tools/luci-go: git_revision:b0488766ec2a119f97c0189ffa5fff13e4da0131..git_revision:6c2c13d25bc8014a0da038302089bc3e9b236931 * tools/luci-go: git_revision:b0488766ec2a119f97c0189ffa5fff13e4da0131..git_revision:6c2c13d25bc8014a0da038302089bc3e9b236931 * tools/luci-go: git_revision:b0488766ec2a119f97c0189ffa5fff13e4da0131..git_revision:6c2c13d25bc8014a0da038302089bc3e9b236931 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/c5b01d0483..b1c9da6382 * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/6c0ba3465b..12ac1a1b8e Clang version changed llvmorg-21-init-11777-gfd3fecfc:llvmorg-21-init-16348-gbd809ffb Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/3b495dd79432abeb32aeb7b51cf4021e4defd24f..cb4a6fc9704f19e6977d7fd1da2a578274b9f611/scripts/update.py Bug: None Tbr: yuxinhu@google.com Change-Id: I843a2e1464773a0305a9c37893a286746f8e35ae Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6670383 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Gyuyoung Kim e15d293c 2025-06-16T16:24:09 tvOS: Disable child process creation code tvOS does not support multi-process applications. As a result, the code that creates a new process causes build failures when building ANGLE unit tests on tvOS. This CL disables that code to prevent the build from breaking. Bug: b/424256388 Change-Id: Ib638d3f75b2839e1a75efc571645921f0d336e55 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6640919 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Solti Ho <solti@google.com>
Alexey Knyazev beae1b4a 2025-06-19T00:00:00 Metal: Remove obsolete workarounds Removed Intel-specific Metal workarounds that are not used on macOS 12 and later. Removed a redundant version check. Bug: angleproject:427600175 Change-Id: I34c7e53108f7e030512c9436ab2b9ae38ad17946 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6672312 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll 14960950 2025-06-24T10:01:50 Roll vulkan-deps from 317a1e4780ef to e7bba33afe37 (15 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/317a1e4780ef..e7bba33afe37 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/21b4e37133868b3a50ef15fc027ecd6d3a52c875..efd24d75bcbc55620e759f6bf42c45a32abac5f8 https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/da60ac4327af194dfa773a07db6cd5d5aaa6848d..8e3261f207f1c520522be2021cf364ebb1bad3f0 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/108b19e5c6979f496deffad4acbe354237afa7d3..33e02568181e3312f49a3cf33df470bf96ef293a https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/c8a2c8c9164a58ce71c1c77104e28e8de724539e..342da33fdec78d269657194c9082835d647d2e68 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/0f0babb553a60da5971d9f4d40cf720ce01602f1..72665ee1e50db3d949080df8d727dffa8067f5f8 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/89c6a9b6500e2e0bda127113bbfe1d70f1ab2d20..6016c4624f8ad3df64987936bfbeb29f32da2d55 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I9944562cd1530a415cc2173d9e6857555e38714d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6665688 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 448c8dab 2025-06-24T03:01:51 Roll SwiftShader from 0ce9bc68d3fc to ed01d9931de3 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/0ce9bc68d3fc..ed01d9931de3 2025-06-23 swiftshader.regress@gmail.com Regres: Update test lists @ 0ce9bc68 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I9883e01ac2797c0dc568965cd7c82352996a8b33 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6666627 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll bbeff29f 2025-06-24T07:00:58 Roll Chromium from f88e654e8ceb to 2fb03826f7a0 (562 revisions) https://chromium.googlesource.com/chromium/src.git/+log/f88e654e8ceb..2fb03826f7a0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/169fcf699b..8d59c1de51 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/5b7491dfe5..39d3a59234 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/0d5210a4b1..d1addfdf7f * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/c7f3762b71..f46835180c * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/a03b70978c..c4f7831fe8 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8f87843807..ea7a0baff0 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/3dc83eebbd..79a5aa1b7f * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/274de19b1d..35982745eb * third_party/turbine/cipd: npJIrAZr4-2wb6qWV0r2oeWQd-Q1wiMGAAi8Up15SkQC..oD9ecDiZFUZfazjjD0N5yl6G4aJsgODDdNjqIp5m1GwC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/ae0ff70908..3b495dd794 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/bd0baf9e31..c5b01d0483 * tools/skia_goldctl/linux: I1LygzXVm-v4LePMcFJ9j0k1AZoLq1UFO5FvEue2TbsC..DuaWI_iN1aKYqw68BNRC2gsLbwarydFdh-0pBp8HS6UC * tools/skia_goldctl/mac_amd64: uI8NbGw_UiTJ3W2CTVNlIycIt9w6x1ozArj3Y3F4UtkC..kfSAMIADvMhxx5OoeY0EajZqqvBTlkVsrDEiWApdnsMC * tools/skia_goldctl/mac_arm64: QSSJvE4WdrL_WsuphR6xIEvHYbO5MAX3yzL1OZUDCMEC..TMdajugFqfAjHrtZbG5sFxtFgsHk5GeyYgO7Exhlx20C * tools/skia_goldctl/win: 72BoyHuvkKlIhZ3QJunOfOnQ4xpyI3ImPWyF8OcXrHMC..2KZkcCD9mC9MsaKQTOIECvyDm_gtn0YaOjpfdhXw9wcC No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: Ida6202335aa1acab4cb41f7d9ef10f16536f66bc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6666420 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao 79ac1a8c 2025-06-23T11:11:10 Revert "Vulkan: Move VertexArray::ElementBuffer away from observer" This reverts commit 3f012a43ee2c101543785720eedfeaa80708479d. Reason for revert: https://issues.chromium.org/427064102 Bug: angleproject:400711938 Original change's description: > Vulkan: Move VertexArray::ElementBuffer away from observer > > Right now, VertexArray's element buffer is always observing buffer's > change. In previous CLs, we have moved vertex array away from > subject/observer usage. This CL moves element buffer away from > subject/observer as well. Since the gl::Buffer tracks buffer's binding > to each context's current vertex array's binding point, > kElementArrayBufferIndex is added to VertexArrayBufferBindingMask bits > so that the element buffer is tracked exactly the same as other vertex > array buffer bindings. The VerextArray code has been modified to handle > this special bit, since element buffer has its own binding point > VertexArrayState::mElementArrayBuffer as opposed to > VertexArrayState::mVertexBindings. After this CL, VertexArray object > should be completely off subject/observer usages. > > Bug: angleproject:400711938 > Change-Id: I662ddfabc95034bdc7734939c944ab033f41801c > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6552160 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Geoff Lang <geofflang@chromium.org> > Commit-Queue: Charlie Lao <cclao@google.com> Bug: angleproject:400711938 Change-Id: I9487ba8b108baaeda1c8a27189dba64f77616774 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6663539 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Charlie Lao 5df85793 2025-06-23T11:08:49 Revert "Vulkan: Avoid some loops in VertexArray::onBufferChanged" This reverts commit 8d6d127acc1072488e5b57ba4e7e93da2d94bfda. Reason for revert: https://issues.chromium.org/427064102 Bug: angleproject:400711938 Original change's description: > Vulkan: Avoid some loops in VertexArray::onBufferChanged > > Before this CL, VertexArray::onBufferChanged() loops over > bufferBindingMask bits and calls onSubjectStateChange. In this CL, > VertexArray::onSubjectStateChange is embedded into > VertexArray::onBufferChanged(). DIRTY_BIT_ELEMENT_ARRAY_BUFFER and > DIRTY_BIT_ELEMENT_ARRAY_BUFFER_DATA is re-arranged so that we can map > bufferBindingMask directly to VertexArray::mDirtyBits. This especially > useful when one buffer is bound to multiple indices in the VertexArray. > > This CL also removes angle::ObserverInterface from VertexArray, since it > no longer observes anything. > > ASSERT is added in gl::Buffer::mContentsObservers to ensure it only > contains BufferTexture, since vertexArray is no longer using the > subject/observer. > > Bug: angleproject:400711938 > Change-Id: Ie6e7159d7a89f0da5e1b7ca0a9dbe60a1e6c682f > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6569638 > Reviewed-by: Geoff Lang <geofflang@chromium.org> > Commit-Queue: Charlie Lao <cclao@google.com> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Bug: angleproject:400711938 Change-Id: I3b8e77db7b3d06b9ed875bfe7787904ac753da11 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6664161 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Junji Watanabe 0a47f441 2025-05-27T16:00:38 Set use_siso=true by default in .gn This CL enables use_siso=true by default. Developers builds will switch to Siso, or get suggestion to run `gn clean` to switch. Bug: b/401959048 Change-Id: I7cf7efecc9cd8c7816dbbd74ea48e66e61a1b6f2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6589553 Auto-Submit: Junji Watanabe <jwata@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Mohan Maiya 2fd033d0 2025-05-22T04:21:11 Vulkan: Optimize updates to uniform buffers ... when only the offset is modified. Most of the work done when handling dirty uniforms can be skipped since the buffer bindings haven't changed Bug: angleproject:386749841 Tests: UniformBufferTest31.UniformBufferBindingRangeChange*Vulkan Change-Id: Ic811bd71f0f2993f88ce9bcf93f9e8e46dfc6d99 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6581359 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Shahbaz Youssefi d59dd3e4 2025-06-23T10:17:46 Unskip passing tests The spec change to varying packing in Vulkan is reverted and so is the SPIR-V validation change that enforced it. Bug: angleproject:404418769 Change-Id: I6eb82b8285121f65a4ac071ad6ede106dfe07988 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6661620 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 60c50fe8 2025-06-23T10:01:26 Roll vulkan-deps from 316ed08fbc9a to 317a1e4780ef (11 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/316ed08fbc9a..317a1e4780ef Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/422150b405c2ac2e05e51a19defabb232efd9187..108b19e5c6979f496deffad4acbe354237afa7d3 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/b39ab380a44b6c8df462c34e976ea9ce2d2c336b..10739e8e00a7b6f74d22dd0a547f1406ff1f5eb9 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/dc6786e527cf8cefd244318f546b3b2ec26e84f4..c8a2c8c9164a58ce71c1c77104e28e8de724539e https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/d671923090e4dc74c0ebdb10c6e09fa0826e1fe9..e3fc64396755191b3c51e5c57d0454872e7fa487 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/54c9baf20802a13279e23fa4cb0528dd5cf16064..0f0babb553a60da5971d9f4d40cf720ce01602f1 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/4b207eefa09f304a06c237fcf4913304e0b7d8d1..89c6a9b6500e2e0bda127113bbfe1d70f1ab2d20 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I2d388ca2b4fb9ccfb6edca31fc697273d6f4513a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6661102 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 8bc3d6e2 2025-06-23T09:21:17 Roll Chromium from 558ed507cbc4 to f88e654e8ceb (799 revisions) https://chromium.googlesource.com/chromium/src.git/+log/558ed507cbc4..f88e654e8ceb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/ed15b02ce4..169fcf699b * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/b2eba427b8..5b7491dfe5 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/4e8c09e96b..0d5210a4b1 * third_party/android_build_tools/lint/cipd: Ddt_nMFT2APf615MrUZPaZpe-MqZSNrJmk8s9ud-f3gC..RevkTwhOQRk-oOzI4BBk3FYEeVAlBijeTqjNPrGsi_8C * third_party/android_build_tools/manifest_merger/cipd: JcTHGCKOl5tWhax5LSv_vf5dQV14RZdPF9xSRKU76JgC..v0s5-TwZ9OxfzbqU5ULhQ7vufSuKIIld6Z7TK8artzoC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/8a80ddf29e..c7f3762b71 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/116ec83ba8..a03b70978c * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9a17210302..8f87843807 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/e09972e094..3dc83eebbd * third_party/r8/cipd: kgSCvDyebyXaL6suvPTOC8fS-Wsu-SmeFTrIkT51K14C..9vZCRnASPSjh3_T-2AsumCO_8C5PuBJ5-e84K9b7-80C * third_party/siso/cipd: git_revision:7e7d85fc69f9084d2168385fb504b31e830dbfff..git_revision:c23de742b8483ddc09d8b68ef845efc7f5c6192f * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/dd092af0a1..5a2ef49216 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/299c639544..ae0ff70908 * tools/luci-go: git_revision:0250323d999386415553b5e2297eafe827ca41f3..git_revision:b0488766ec2a119f97c0189ffa5fff13e4da0131 * tools/luci-go: git_revision:0250323d999386415553b5e2297eafe827ca41f3..git_revision:b0488766ec2a119f97c0189ffa5fff13e4da0131 * tools/luci-go: git_revision:0250323d999386415553b5e2297eafe827ca41f3..git_revision:b0488766ec2a119f97c0189ffa5fff13e4da0131 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/854c2669c7..bd0baf9e31 No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: Icccb70141b839f1f52d8b62075183772f013099e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6661100 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 2102183a 2025-06-23T08:01:53 Roll VK-GL-CTS from 9390207187c6 to 4c617fa74b67 (9 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/9390207187c6..4c617fa74b67 2025-06-21 michal.jakubek@mobica.com Incorrect object reservation count choices made by the CTS 2025-06-21 michal.jakubek@mobica.com Adapt query pool statistics tests to Capabilities System 2025-06-21 ewerness@nvidia.com Ray tracing vertex fetch alignment changes for testing 2025-06-21 ziga@lunarg.com Add test case for tessellation matrix multiplication 2025-06-21 zzoon@igalia.com Set to use layered dpb only when separate dpb not supported 2025-06-21 michal.jakubek@mobica.com Adapt depth tests to Capabilities System 2025-06-21 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.3 into vk-gl-cts/main 2025-06-18 ewerness@nvidia.com Delete comment with a merge conflict in it 2025-06-18 lorenzo@khronosgroup.org Add comments and fix order of generated code If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: Ib2e088cffa41e78469b747f096b17d41d38ef518 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6659844 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuxin Hu 5220e634 2025-06-16T11:14:22 Fix glCopyImageSubData validation check part 2 For compressed texture, we also need to check if the copy subregion starting points (offset) are aligned with the compressed block. This change also moves *FillsEntireMip check to the ValidateCompressedRegion() function, as it is easier to do a per-dimension check. Bug: b/419048313 Bug: angleproject:42264179 Bug: angleproject:42265887 Change-Id: I0f415e575bbc77bdf5178e2b5fc1260c43e7de4b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6648198 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com>
Tim Van Patten 3b7528e1 2025-05-20T12:31:28 Support running the full end2end suite against the System EGL Update the end2end test instantiation to either fully target the packaged ANGLE libraries or the system EGL, but not a combination of both simultaneously. The GN argument |angle_test_enable_system_egl| controls which driver is being tested by all the instantiated tests. It's default value is "false", which means the tests target the ANGLE libraries by default: kDefaultGLESDriver = GLESDriverType::AngleEGL When |angle_test_enable_system_egl = true|: kDefaultGLESDriver = GLESDriverType::SystemEGL This allows for testing the system EGL with the full end2end test suite, which is useful on devices where ANGLE is the system EGL (e.g., Android). It also allows for specifying which backend to use (or all) during system EGL testing, when ANGLE is the EGL driver. This also includes removing the various ESx_EGL() functions, because the end2end tests must now fully commit to testing either the ANGLE driver or system driver, rather than a combination of both. This is similar to many other test suites, such as the Khronos CTS (dEQP), which only test validate a single driver per invocation. Bug: b/279980674 Test: angle_end2end_tests Change-Id: I4f7dc2ccb4f26b3bd02767d0a0d2876f8612f2ae Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6580876 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Amirali Abdolrashidi 6bb47e67 2025-06-17T13:42:47 Vulkan: Limit finalizing foreign image layouts Currently, any submission results in finalizing all foreign images. However, if the submission is only limited to the outside render pass command buffer, this would result in oldLayout VVL errors (01197), as it would be too early to finalize the layout of such images at those times. At this time, this type of submission can occur if the size of buffer-to-image updates exceeds the following threshold: kMaxBufferToImageCopySize In this change, finalizing the foreign image layouts would only occur when all commands are being submitted. * In ContextVk::submitCommands(), finalizeAllForeignImages() is now called only when the submission type is Submit::AllCommands. * Added new submit tests for foreign images to ImageTest: * UploadForeignUntilSubmitDoesNotBreakRenderPass * CopyToForeignUntilSubmitDoesNotBreakRenderPass Bug: b/425987310 Change-Id: Ia345e176be79017ba18ef52a57256eeeb298e39a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6653602 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
angle-autoroll 98bd576f 2025-06-19T08:01:25 Roll VK-GL-CTS from 53a925d9098c to 9390207187c6 (28 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/53a925d9098c..9390207187c6 2025-06-17 kamil.goras@mobica.com Add OpenGL tests for textureQueryLevels 2025-06-16 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkansc-cts-1.0.3 into vk-gl-cts/main 2025-06-16 lorenzo@khronosgroup.org Merge remote-tracking branch 'vk-gl-cts/dev/VK_EXT_shader_float8' 2025-06-16 lorenzo@khronosgroup.org Update external sources (Vulkan 1.4.318) 2025-06-16 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.12 into vk-gl-cts/main 2025-06-13 ziga@lunarg.com Fix missing submit infos in sync multi queue tests 2025-06-13 rgarcia@igalia.com Fix DeprecationWarnings in fetch_sources.py 2025-06-13 scerveau@igalia.com CMake: add additional pc checks 2025-06-13 rgarcia@igalia.com Test conditional rendering with ray tracing commands 2025-06-13 rgarcia@igalia.com Test "unaligned" buffer<->image copies 2025-06-13 jbolz@nvidia.com Add cooperative vector tests for readonly loads w/bounds checking 2025-06-13 rgarcia@igalia.com Test maintenance5 default point size without large points 2025-06-13 rgarcia@igalia.com Fix missing largePoints capability for multiview tests 2025-06-13 vikram.tarikere@imgtec.com Honour undefined behaviour from OpSDiv. 2025-06-13 lorenzo@khronosgroup.org Fix dependencies checks for extensions and functions 2025-06-13 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.3 into vk-gl-cts/main 2025-06-12 kamil.goras@mobica.com Add negative tests that texture lookup function bias parameter is not accepted in any other shader than fragment shader. 2025-06-11 lorenzo@khronosgroup.org Add VK_EXT_shader_float8 JSON 2025-06-11 lorenzo@khronosgroup.org Add VK_KHR_maintenance9 JSON 2025-06-11 lorenzo@khronosgroup.org Add VK_KHR_video_decode_vp9 JSON 2025-06-11 lorenzo@khronosgroup.org Add VK_KHR_unified_image_layouts JSON 2025-06-11 lorenzo@khronosgroup.org Update external sources 2025-06-11 lorenzo@khronosgroup.org Merge remote-tracking branch 'vk-gl-cts/dev/VK_KHR_maintenance9' 2025-06-10 scerveau@igalia.com video: VP9 decode tests: update public repo 2025-06-09 lorenzo@khronosgroup.org Merge remote-tracking branch 'vk-gl-cts/dev/VK_KHR_video_decode_vp9' into main 2025-06-09 lorenzo@khronosgroup.org Merge remote-tracking branch 'vk-gl-cts/dev/VK_KHR_unified_image_layouts' into main 2025-06-09 lorenzo@khronosgroup.org Update external sources (Vulkan 1.4.317) 2025-06-06 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-cts-4.6.6 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Change-Id: I1f614f11f0f5cb73c24dd4346a837ec6dc88b0bf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6658499 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang cb432540 2025-06-19T17:00:27 WebGPU: Expand dEQP test expectations This lowers our unexpectged passes from ~8k to ~3.5k. Bug: angleproject:356399840 Change-Id: Idb9d4aee9103bc18783a7283d938c368c7efbe5b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5875956 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Liza Burakova <liza@chromium.org> Commit-Queue: Liza Burakova <liza@chromium.org>
angle-autoroll b89c6008 2025-06-20T10:01:33 Roll vulkan-deps from 1c18b20944ca to 316ed08fbc9a (4 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/1c18b20944ca..316ed08fbc9a Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/da0ec29bb41cbba8af5920c81ee990536a4f6492..422150b405c2ac2e05e51a19defabb232efd9187 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/d004bbbbeb7e1bfe79533522af631bacec407ad2..4b207eefa09f304a06c237fcf4913304e0b7d8d1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I9d02c7c5f082088a6a3d7d9f95f276a24fa68737 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6655689 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 9e629bbb 2025-06-20T07:49:41 Roll Chromium from ad04c4bcf5c3 to 558ed507cbc4 (156 revisions) https://chromium.googlesource.com/chromium/src.git/+log/ad04c4bcf5c3..558ed507cbc4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/68ebe7a23d..ed15b02ce4 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/4b48c46a57..4e8c09e96b * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/3c116585c2..f43e2cc47f * third_party/android_build_tools/error_prone/cipd: RiplT9oTSE0lQHviAF6FMk5P9863t0-WHcl2te12hi0C..KOECi08Fw4fRTVXkKocxg94coB-e_dlcHRokC21yxyoC * third_party/android_build_tools/lint/cipd: 3bWjs4NjBtTIXoWH03nPx8c--ehZzlDkL8PUE_GaPKUC..Ddt_nMFT2APf615MrUZPaZpe-MqZSNrJmk8s9ud-f3gC * third_party/android_build_tools/manifest_merger/cipd: AFWUMAcwcd0L1DG2-ib4ghtQYFsCvZjWuQkhuTJl4ToC..JcTHGCKOl5tWhax5LSv_vf5dQV14RZdPF9xSRKU76JgC * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3f633ff2f9..9a17210302 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/66ae6e2bd8..e09972e094 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/0f5d505e9f..e0f7527112 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/4c7b4a2749..299c639544 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/85829f8649..854c2669c7 No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: Id969db10acb146fe01d62d62aba87f8ea0cb1e1b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6655687 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 9e24b0b1 2025-06-19T20:32:21 Manual roll vulkan-deps from 3517bebf7845 to 1c18b20944ca (4 revisions) Manual roll requested by syoussefi@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/3517bebf7845..1c18b20944ca Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/05cfcc1613c28c1274036f53616d66324f7cd383..21b4e37133868b3a50ef15fc027ecd6d3a52c875 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/dab29fb163948c142b33f0176eb8baa086fa5df3..da0ec29bb41cbba8af5920c81ee990536a4f6492 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/0bab7fb4fbccc967ca50db3466ef5c48c9f2950f..d004bbbbeb7e1bfe79533522af631bacec407ad2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,geofflang@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com,syoussefi@google.com Change-Id: I8c2831568c85b8b6f503c9068fce116f74f93731 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6654835 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang 98d2d5d8 2025-06-19T14:44:21 WebGPU: Add missing WebGPU suffix for perf tests. Bug: angleproject:419821694 Change-Id: Ic509df3fbd270ffc2a8f91c1565d673fb82a6bd2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6652900 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang 5d124404 2025-06-17T17:04:12 WebGPU: Fix bind groups leaking in CommandBuffer. Wrap all per-submission member variables in a struct so that we can reset everything at once using the default constructor. This avoids similar leaks in the future. Bug: chromium:413078308 Change-Id: I3f926c82905b73b27d6b751cfe2878a41ced916a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6652290 Reviewed-by: Matthew Denton <mpdenton@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi 64951493 2025-06-19T14:47:24 Manual roll vulkan-deps from 222889ea0395 to 3517bebf7845 (45 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/222889ea0395..3517bebf7845 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/e088d553426a3036270701d07dde28bf33d318be..da60ac4327af194dfa773a07db6cd5d5aaa6848d https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/50daff941d88609b4d2ad076eae558e727f8e5cd..2a611a970fdbc41ac2e3e328802aed9985352dca https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/e0bad2825dacf274578ec6d3c0e64e406d5e4fd7..dab29fb163948c142b33f0176eb8baa086fa5df3 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/1d6c53f65443ceeb97d3bdc695aaecc7ea6cc441..b39ab380a44b6c8df462c34e976ea9ce2d2c336b https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/63b05d2b087952662623de7eddd44f2e57d71a1e..dc6786e527cf8cefd244318f546b3b2ec26e84f4 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/fbe722654b7173da961398cf78bd4a62d1839b65..d671923090e4dc74c0ebdb10c6e09fa0826e1fe9 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/e48ae20a7938b01aee62806bfcdafe8a0883b1e4..54c9baf20802a13279e23fa4cb0528dd5cf16064 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/6d6e6ec8e51cd219498359cbc48e4762d1a80616..0bab7fb4fbccc967ca50db3466ef5c48c9f2950f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I20f12f2c5df65f356b2d4ecb6942ebcae0a71384 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6657062 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll ad7db36c 2025-06-19T18:31:26 Manual roll Chromium from f799bcdd69c9 to ad04c4bcf5c3 (768 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/chromium/src.git/+log/f799bcdd69c9..ad04c4bcf5c3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/6311c38ef2..68ebe7a23d * buildtools/linux64: git_revision:54169531ed6da64425ad6e8e9535945c8f6220d0..git_revision:97b68a0bb62b7528bc3491c7949d6804223c2b82 * buildtools/mac: git_revision:54169531ed6da64425ad6e8e9535945c8f6220d0..git_revision:97b68a0bb62b7528bc3491c7949d6804223c2b82 * buildtools/win: git_revision:54169531ed6da64425ad6e8e9535945c8f6220d0..git_revision:97b68a0bb62b7528bc3491c7949d6804223c2b82 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/77495fa0f9..4b48c46a57 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/7b109e5560..e3d58ba1a2 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/b31bc302aa..8a80ddf29e * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/5b85fe2b7c..116ec83ba8 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/377f55f382..3f633ff2f9 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/3d71fc6b43..66ae6e2bd8 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/5166221f85..0f5d505e9f * third_party/r8/cipd: vyND5ed7BNCedbc49JaNOodeA7NrhM08caDYzWEh4PoC..kgSCvDyebyXaL6suvPTOC8fS-Wsu-SmeFTrIkT51K14C * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/f9255e9cc4..274de19b1d * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/5b41c48c17..4c7b4a2749 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/2d39541093..85829f8649 No update to Clang. Bug: None Tbr: geofflang@google.com,ynovikov@google.com Change-Id: Ibe57bb67f8f3ba14df762fe0dfd3ed3253960e06 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6657245 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov ad7f595d 2025-06-19T18:20:15 Set src/common/base "Update Mechanism" Bug: chromium:419410757 Change-Id: Ib2a980edd6e7c9b9790c31c8fb6002d58da4a08f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6650800 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi f48fcb46 2025-06-19T07:11:48 Revert "Metal: Wraparound int arithmetic for add, sub" This reverts commit 2f6f0514563d81e439e04ba09eee9e8a1d6ca8d1. Reason for revert: Leads to MSL compiler errors: > error: non-const reference cannot bind to vector element Bug: angleproject:382215759 Original change's description: > Metal: Wraparound int arithmetic for add, sub > > Implement wraparound int arithmetic for > int, ivec +, -, +=, -=, ++, --. > > All of the added tests pass also without the changes. > > Bug: angleproject:382215759 > Change-Id: I7605582ab2931e63010c34fba474797f7edd19f9 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6578729 > Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Geoff Lang <geofflang@chromium.org> > Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com> Bug: angleproject:382215759 Bug: chromium:425746892 Change-Id: I831d96c6ee7b8bcdeaa08fbf32d430def87a3c30 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6656001 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Kai Ninomiya 41144603 2025-06-06T10:56:03 WebGPU: Handle Dawn breaking change in CreateInstance Needed in order to update Dawn to match the standard webgpu.h, here: https://dawn-review.googlesource.com/c/dawn/+/245242 Bug: chromium:414868137 Change-Id: I2bdf5bd5747a8da8ed0612a99d70eee8a3d09ecb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6652516 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Auto-Submit: Kai Ninomiya <kainino@chromium.org>
angle-autoroll 2f18b71d 2025-06-19T03:01:28 Roll SwiftShader from 47399fc146fa to 0ce9bc68d3fc (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/47399fc146fa..0ce9bc68d3fc 2025-06-18 swiftshader.regress@gmail.com Regres: Update test lists @ 47399fc1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I2095406397416037393189eb94ee32135d9717b8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6655415 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao 59281334 2025-05-22T17:13:22 Vulkan: Reduce kMaxEmptySlots for SharedDescriptorSetCacheKey There is report that addKey is still showing up in simpleperf. This CL breaks addKeyImpl into three functions so that SharedFramebufferCacheKey will still have the same behavior. SharedDescriptorSetCacheKey is changed to track 64 cache key at maximum, and updateEmptySlotBits() is never called in SharedDescriptorSetCacheKey. This means the shared cache key tracking is further limited to usage case where a buffer/texture is only involved in less than 64 descriptorSets. Otherwise we will not track the remaining DescriptorSets, which means if this buffer is released, the corresponding descriptorSet will not immediately destroyed, and we will rely on cache eviction code to take care of DS growing problem. Bug: b/384839847 Change-Id: I99abd17966446377babace6d06cc8f380a71c084 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6581492 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Geoff Lang dea162cc 2025-06-09T15:43:05 WebGPU: Finalize command blocks when starting a new one The command buffer abstraction would not finalize blocks of commands when creating a new block, leading to possible infinite loops when processing the commands. Bug: chromium:413078308 Change-Id: Idf4e95a5ccc71f3ddc9a4202e5e000c0e2cd5f87 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6629473 Reviewed-by: Liza Burakova <liza@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Mohan Maiya 9d70781f 2025-06-17T07:06:37 Vulkan: Bugfix in TextureVk::initImage(...) Account for compute based mipmap generation during initImage Bug: angleproject:405840226 Tests: ImageTestES3.SourceAHBTargetTexture2DGenerateMipmap* Change-Id: Ic2f6c4576ec8ff464a5d60c4a49aeb87be3a5785 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6650712 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
angle-autoroll aa23ec21 2025-06-18T09:11:41 Roll Chromium from 9832934fc40b to f799bcdd69c9 (636 revisions) https://chromium.googlesource.com/chromium/src.git/+log/9832934fc40b..f799bcdd69c9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/71742cf0df..6311c38ef2 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/175c1fa28c..b2eba427b8 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/c2344f7d79..77495fa0f9 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/84b990c066..7b109e5560 * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/34bf3dd2d9..3c116585c2 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/83a7b85088..b31bc302aa * third_party/android_platform: https://chromium.googlesource.com/chromium/src/third_party/android_platform/+log/98aee46efb..e97e62b0b5 * third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/67418b87fc..e71ef403c5 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/4481cd5a9f..5b85fe2b7c * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2ac2988f7b..377f55f382 * third_party/ijar: https://chromium.googlesource.com/chromium/src/third_party/ijar/+log/4b6f53ee62..935be444d6 * third_party/jinja2: https://chromium.googlesource.com/chromium/src/third_party/jinja2/+log/5e1ee241ab..c3027d8849 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/ced0173352..3d71fc6b43 * third_party/markupsafe: https://chromium.googlesource.com/chromium/src/third_party/markupsafe/+log/9f8efc8637..4256084ae1 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/d0fb5d4f4b..5166221f85 * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/567abeb822..f9255e9cc4 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/470d3a2ee4..4028ebf871 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/147c7317c0..dd092af0a1 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/3c75c1e0b9..5b41c48c17 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/372f32c9bd..2d39541093 * tools/valgrind: https://chromium.googlesource.com/chromium/src/tools/valgrind/+log/6e97bd1a16..5ba62550b2 No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: Ib0ca9d9b99eca6354d1beec358fd198e30459fa0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6653847 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amirali Abdolrashidi 9e000857 2025-02-04T16:12:47 Vulkan: Utilize VkBufferUsageFlags2 for bufferview * Added the following struct to bufferview createInfo in case of VK_KHR_maintenance5 support: VkBufferUsageFlags2CreateInfoKHR * Limited VVL 08779 to platforms without KHR_maintenance5 support. Bug: angleproject:394353300 Change-Id: I46beac693cda3216afc497c8ed74cbf51b72e549 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6231512 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Cody Northrop 67b3702d 2025-06-17T11:19:17 Infra: Add smoke trace list, use with ASAN Add a config that can reduce the traces used in our CI. It uses a curated list of traces to provide coverage of engines. Use the list with our ASAN builder to greatly reduce build time. Bug: b/421425259 Change-Id: I1b23eee4b96ad1ca21c121ec405b751f58e74e6b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6652311 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Charlie Lao <cclao@google.com>
Martin Arjovsky a2b84cc0 2025-06-17T09:47:58 Fix bug in translator fuzzer. We were incorrectly checking a type against a spec. bug: angleproject:425580663 Change-Id: I7a57852b143ea26a41414015414d43720e2e53b1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6650788 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Matthew Denton 243ebfa7 2025-06-16T16:07:06 WebGPU: Allow glReadPixels from non-base mip levels. Before, the WebGPU backend always read from the base level of the texture attached to the current framebuffer. Bug: angleproject:42267090 Change-Id: Ibe5b8575f6fa90c1942ba566485b6175ee10f808 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6634558 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Auto-Submit: Matthew Denton <mpdenton@chromium.org>
angle-autoroll 45ac6404 2025-06-17T03:01:55 Roll SwiftShader from 7b7b93aa0b85 to 47399fc146fa (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/7b7b93aa0b85..47399fc146fa 2025-06-16 swiftshader.regress@gmail.com Regres: Update test lists @ 7b7b93aa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I32db1c1ff658b01307ffdd574025ae45ef5c7b02 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6650656 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 84119cb6 2025-06-17T08:50:25 Roll Chromium from 1a2e111b764d to 9832934fc40b (653 revisions) https://chromium.googlesource.com/chromium/src.git/+log/1a2e111b764d..9832934fc40b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/97494799c2..71742cf0df * testing: https://chromium.googlesource.com/chromium/src/testing/+log/cdb084b125..c2344f7d79 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/fcd0e32b73..83a7b85088 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/9e57472d99..4481cd5a9f * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d4c627ed62..2ac2988f7b * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/a2f7b489cd..ced0173352 * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/886355a984..567abeb822 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/b0469a039c..147c7317c0 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/123fb93db6..3c75c1e0b9 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/a9c048e6f6..372f32c9bd * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/096f45497e..6c0ba3465b Clang version changed llvmorg-21-init-15009-g841a7f08:llvmorg-21-init-11777-gfd3fecfc Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/123fb93db6b179a3a651bf92e1def7e7856639f6..3c75c1e0b9501817a0c1012152c2f846b29761ac/scripts/update.py Bug: None Tbr: geofflang@google.com Change-Id: I7220762fe25ae4198569df1f09069afe684320ab Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6650708 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shufen Ma db70fca6 2025-06-11T16:59:36 Add a separable program test ES 3.2 spec section 7.4.1 Shader Interface Matching is vague about the case when a program has more than one shader whose interfaces do not match and the program is set to GL_PROGRAM_SEPARABLE by glProgramParameteri API. Angle implementation thinks it is not right and the program is not linked. But since the shaders are attached to one program, the program should have enough information to link. Bug: angleproject:424050949 Change-Id: Icb9c8cbff906671beb6679309795f5c1b3acec6f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6636452 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Shufen Ma <Shufen.Ma@arm.com>
Aurora Zhang dfefcbc6 2025-06-09T16:30:55 glGetProgramiv should return the properties in effect glProgramParameteri can set values to GL_PROGRAM_BINARY_RETRIEVABLE_HINT. However, this setting will not be in effect until the next time glLinkProgram or glProgramBinary has been called successfully. Also, glGetProgramiv returns the properties currently in effect for program. Therefore, we need to add a variable to record the ineffective value and copy it at the stage of glLinkProgram or glProgramBinary. Bug: angleproject:421219220 Change-Id: Ib564e6df03d34f3fc7389f926795cb3e64cbf687 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6606372 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Aurora Zhang <Aurora.Zhang@arm.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Kimmo Kinnunen 94ee620d 2025-05-22T10:07:05 Metal: Allow optimization of simple loops Reimplement the feature to avoid undefined behavior of infinite loops. Add EnsureLoopForwardProgress rewrite pass that inserts a volatile variable access to all loops that it cannot analyze as being finite. Detect loops of form `for (; i <op> x; ++i)` as being finite. The <op> can be any of <,<=,>,>=,==, != operator. The i can be int or uint. The ++i can be -- or ++, -=1, +=1. This assumes that backends using the feature emit signed int arithmetic with defined wraparound semantics. Uses volatile write instead of asm("") due to asm not forcing the behavior in some compiler versions. The volatile variable access is defined in C++ as forward progress, and by inheritance this works in MSL. Later commits may remove injectAsmStatementIntoLoopBodies if ensureLoopForwardProgress is appropriate for all use-cases. Bug: angleproject:418918522 Change-Id: Ic9c29f57044b792195386483208632354d24c854 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6575051 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com>
angle-autoroll 543b6cf6 2025-06-16T07:02:58 Roll Chromium from 5d8e5baf56fe to 1a2e111b764d (773 revisions) https://chromium.googlesource.com/chromium/src.git/+log/5d8e5baf56fe..1a2e111b764d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/cb527f4b98..97494799c2 * buildtools/linux64: git_revision:899572b32b8bb610cfeeefd162d9aefb46e29d97..git_revision:54169531ed6da64425ad6e8e9535945c8f6220d0 * buildtools/mac: git_revision:899572b32b8bb610cfeeefd162d9aefb46e29d97..git_revision:54169531ed6da64425ad6e8e9535945c8f6220d0 * buildtools/win: git_revision:899572b32b8bb610cfeeefd162d9aefb46e29d97..git_revision:54169531ed6da64425ad6e8e9535945c8f6220d0 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/dd6fb44bdc..cdb084b125 * third_party/android_build_tools/lint/cipd: Otd2S_y5ozK3q8Q7eMr1NqNH38ESBnUYT4I842UsU0UC..3bWjs4NjBtTIXoWH03nPx8c--ehZzlDkL8PUE_GaPKUC * third_party/android_build_tools/manifest_merger/cipd: UrgRDTQRxa2KqkIGo6gwYOY7uf56hYmH-QAjov2N9NMC..AFWUMAcwcd0L1DG2-ib4ghtQYFsCvZjWuQkhuTJl4ToC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/6abf1d7a33..fcd0e32b73 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/1d50003d81..9e57472d99 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/1f64d055db..a2f7b489cd * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/345a48f432..d0fb5d4f4b * third_party/r8/cipd: F0pTWc6uG70kZPngypnQxCgD3CgY5D8O-pDqj_qeoQMC..vyND5ed7BNCedbc49JaNOodeA7NrhM08caDYzWEh4PoC * third_party/siso/cipd: git_revision:d704490133011610c402696584afedea80829dbd..git_revision:7e7d85fc69f9084d2168385fb504b31e830dbfff * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/479e8c395f..b0469a039c * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/7e6f482ce7..123fb93db6 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/5730d2a457..a9c048e6f6 * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/11d67ba328..096f45497e Clang version changed llvmorg-21-init-11777-gfd3fecfc:llvmorg-21-init-15009-g841a7f08 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/7e6f482ce7bf792e6cb034b57285b766c5df1355..123fb93db6b179a3a651bf92e1def7e7856639f6/scripts/update.py Bug: None Tbr: geofflang@google.com Change-Id: I1d533ef366c9cc16d05983a994576aaf000b95e2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6643467 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuxin Hu 79ec8b34 2025-06-12T14:32:42 Fix glCopyImageSubData validation check When checking if the copy subregion meets the compressed texture alignment requirements, we should consider if the copy subregion covers the entire width and height of texture level. It is not required to make texture size aligned with compressed texture block size when creating the texture image (e.g. width and height do not have to be multiple of 6 when calling glTexStorage2D for GL_COMPRESSED_RGBA_ASTC_6X6 textures). If the copy subregion width and height equals to the width and height of the texture level, even if they are not aligned with the compressed texture block size, the copy is allowed. This is currently covered by fillsEntireMip check. However, fillsEntireMip enforces copy subregion width, height, and depth all equal to the texture level width, height, and depth, where we should not check depth because we don't enforce depth alignment for compressed texture. For example, for a 2D texture array that has dimension of 32*16*2 in current level, a copy region with width=32, heigh=16, depth=1 should be considered as fillsEntireMip. In the spec, it says: "The source and destination subregions must be contained entirely within the specified level of the corresponding image objects". Right now we only check if width and height are within the image bounds, this change adds a check to make sure depth is also within the image bounds. Bug: b/419048313 Change-Id: I6e5339cfdfd5785f935a059638c22c9646c12162 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6634232 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 26d5d4e2 2025-06-13T14:24:29 Avoid OOB access in Load* functions Bug: angleproject:424695342 Change-Id: I245612a41d55026c615ca0185af76a153c9fe3ec Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6642699 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shufen Ma c53c908c 2025-06-11T15:36:48 Refine GetProgramiv validation An INVALID_OPERATION error is generated if TESS_CONTROL_OUTPUT_- VERTICES is queried for a program which has not been linked successfully, or which does not contain objects to form a tessellation control shader. An INVALID_OPERATION error is generated if TESS_GEN_MODE, TESS_GEN_SPACING, TESS_GEN_VERTEX_ORDER, or TESS_GEN_POINT_MODE are queried for a program which has not been linked successfully, or which does not contain objects to form a tessellation evaluation shader. Bug: angleproject:424050946 Change-Id: I9d6110d2783efb21efbcb62d9da7b35590c89f61 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6637010 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Auto-Submit: Shufen Ma <Shufen.Ma@arm.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov c7d86644 2025-06-13T15:41:48 Set Update Mechanism of "Autoconf M4 macros used by Bison" Bug: chromium:422061086 Change-Id: I4ad0e678f1d8341bd22b94416aaa9929e08e7c07 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6641269 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Igor Nazarov 10b7414f 2025-06-12T17:03:51 Vulkan: Do not skip VUID-vkQueueSubmit-pSignalSemaphores-00067 ... when "VK_EXT_swapchain_maintenance1" is disabled. Problem only happened in shared present mode and is now fixed by VVL: 69b41e6fbe16619526daa861444cbb3eb8fcedce layers: Do not report in-use error for shared present mode Bug: angleproject:408190758 Change-Id: I4453de01ee239a0cb4cfd0269adfcb283a00866b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6641915 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll ce156f3b 2025-06-13T10:01:20 Roll vulkan-deps from cd8294df9efa to 222889ea0395 (5 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/cd8294df9efa..222889ea0395 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/ac1c686d562147c751a0c284f879499418beee46..05cfcc1613c28c1274036f53616d66324f7cd383 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/27dd301f866121798eca9f2b920b6cb58be3a92e..e0bad2825dacf274578ec6d3c0e64e406d5e4fd7 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/95dbf1f8f499b068e47967e58ccd3d4eaa941422..6d6e6ec8e51cd219498359cbc48e4762d1a80616 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: I68866dc7ca06badd6722da5e709ab01a57f4e466 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6643029 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll db0c266c 2025-06-13T07:01:21 Roll Chromium from 3d57e475d87b to 5d8e5baf56fe (514 revisions) https://chromium.googlesource.com/chromium/src.git/+log/3d57e475d87b..5d8e5baf56fe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/d3120086b9..cb527f4b98 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/5585f637a9..175c1fa28c * testing: https://chromium.googlesource.com/chromium/src/testing/+log/e1f1d61956..dd6fb44bdc * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/46e997c931..84b990c066 * third_party/android_build_tools/error_prone/cipd: OFmDaNXqS5PTb5YKd4fCb0Y4cK4ImQXeZISzw9p1ILcC..RiplT9oTSE0lQHviAF6FMk5P9863t0-WHcl2te12hi0C * third_party/android_build_tools/lint/cipd: elV-KSOeiX0hBeuw8Swk8wWiXT8Ns35MNwiOp6SLR4QC..Otd2S_y5ozK3q8Q7eMr1NqNH38ESBnUYT4I842UsU0UC * third_party/android_build_tools/manifest_merger/cipd: VcONzD64-9oyADpPb46XY3qQ0bWCJVaFIKA2dNziAY4C..UrgRDTQRxa2KqkIGo6gwYOY7uf56hYmH-QAjov2N9NMC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/850859350a..1d50003d81 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ea261d7c75..d4c627ed62 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/3a31ad538c..e44c3c4560 * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/79e514564f..5bbf35ae68 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/383ed10195..1f64d055db * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/9ca8819752..886355a984 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/03b01d3183..7e6f482ce7 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/a7295ec21f..5730d2a457 No update to Clang. Bug: None Tbr: solti@google.com Change-Id: Ic359a4bc4ee967be0c8ca055b39eb524a1b75326 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6642231 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Tim Van Patten fdff1170 2025-06-06T10:46:03 tests: SystemEGL: Skip tests needing unsupported ANGLE EXTs The system EGL may not expose ANGLE extensions, even if it *is* ANGLE, due to platform EGL restrictions (e.g., Android platform EGL). Skip any tests requiring ANGLE-specific extensions during test setup, rather than failing them. This also requires refactoring ANGLETestBase to derive ::testing::Test so it has access to Test::IsSkipped(). Bug: b/279980674 Change-Id: I8e424509c41fa5a69dee9fc8e0c92da58e4758fe Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6622112 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Matthew Denton 005336e4 2025-06-11T17:17:16 WGPU: Basic texture cubes Allows uploading to texture cube faces and sampling from them in shaders using samplerCube. Bug: angleproject:420782526 Change-Id: I45d4370fcc418f39afb225114d13632a78c7c200 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6593999 Reviewed-by: Liza Burakova <liza@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org>
Yuxin Hu 5d63c8d5 2025-06-11T13:01:25 Reformat VVL error message Update the VVL error message to use the new format. Remove the unused VVL error. Bug: angleproject:42264926 Bug: angleproject:42263911 Bug: angleproject:42265079 Bug: angleproject:42264496 Change-Id: I151960942c1bbf346693f250ec57f01fa3432784 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6634225 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
angle-autoroll 746ccc66 2025-06-12T03:01:00 Roll SwiftShader from 13a5d59c83e4 to 7b7b93aa0b85 (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/13a5d59c83e4..7b7b93aa0b85 2025-06-11 syoussefi@google.com Implement VK_KHR_unified_image_layouts 2025-06-11 ynovikov@chromium.org Add missing include If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:422982681 Tbr: solti@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I1b6ba1ff4c994fa05f67d3d8ecba5ac3b8f3f944 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6639522 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 8cc8bdc7 2025-06-12T10:01:07 Roll vulkan-deps from e16ef854c44f to cd8294df9efa (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/e16ef854c44f..cd8294df9efa Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/3b9447dc98371e96b59a6225bd062a9867e1d203..50daff941d88609b4d2ad076eae558e727f8e5cd https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/e9a8ceeddbf7e3aaadac2ab6f8a6ab6437872e88..27dd301f866121798eca9f2b920b6cb58be3a92e https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/59483c4ebaaecbaa4ca887a68c1631d17177a35c..95dbf1f8f499b068e47967e58ccd3d4eaa941422 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: I07862f99b92e8c1bc8bf83d1a2617c19a835c17f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6640345 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 37b9f78d 2025-06-12T07:53:59 Roll Chromium from 618b8dc7c27c to 3d57e475d87b (645 revisions) https://chromium.googlesource.com/chromium/src.git/+log/618b8dc7c27c..3d57e475d87b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/af5fc163a6..d3120086b9 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/164f8abf67..5585f637a9 * buildtools/linux64: git_revision:8ea3af9118a65387fe4d8428db6f59c5927dd55a..git_revision:899572b32b8bb610cfeeefd162d9aefb46e29d97 * buildtools/mac: git_revision:8ea3af9118a65387fe4d8428db6f59c5927dd55a..git_revision:899572b32b8bb610cfeeefd162d9aefb46e29d97 * buildtools/win: git_revision:8ea3af9118a65387fe4d8428db6f59c5927dd55a..git_revision:899572b32b8bb610cfeeefd162d9aefb46e29d97 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/9e9017624a..e1f1d61956 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/2b011cd0e9..46e997c931 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/8413456528..6abf1d7a33 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/a1a1df4d27..850859350a * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/974e876217..ea261d7c75 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/aca8664738..3a31ad538c * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/e3eb847e51..79e514564f * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/2be4a578cb..383ed10195 * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/1097f51190..9ca8819752 * tools/luci-go: git_revision:a716714d42790a4677b6abb0bf0c3102d6d5bb6f..git_revision:0250323d999386415553b5e2297eafe827ca41f3 * tools/luci-go: git_revision:a716714d42790a4677b6abb0bf0c3102d6d5bb6f..git_revision:0250323d999386415553b5e2297eafe827ca41f3 * tools/luci-go: git_revision:a716714d42790a4677b6abb0bf0c3102d6d5bb6f..git_revision:0250323d999386415553b5e2297eafe827ca41f3 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/d57ede6ba3..a7295ec21f * tools/skia_goldctl/linux: lkxqvhJtv-45S0zRCu7Z3er-IcDc6t931-7jM1lN-RMC..I1LygzXVm-v4LePMcFJ9j0k1AZoLq1UFO5FvEue2TbsC * tools/skia_goldctl/mac_amd64: r2LyNXR63hRBteBs8GN14Otjpbnu_VQvVOvDVUFjeV4C..uI8NbGw_UiTJ3W2CTVNlIycIt9w6x1ozArj3Y3F4UtkC * tools/skia_goldctl/mac_arm64: tJUKq9z8lfdk4KydEare4F1gdGAXnTVuC5W3k8mBQBMC..QSSJvE4WdrL_WsuphR6xIEvHYbO5MAX3yzL1OZUDCMEC * tools/skia_goldctl/win: 1pUE-hNBek5om-0mUbI4sJSEt4-m1AwEGnVNuEfMFOIC..72BoyHuvkKlIhZ3QJunOfOnQ4xpyI3ImPWyF8OcXrHMC No update to Clang. Bug: None Tbr: solti@google.com Change-Id: I4d32caf5fd38da29d16e8e71069ce9d63bea83ef Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6639844 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jisun Lee d8c15499 2025-05-27T03:46:24 Vulkan: Clear depth and stencil unresolve separately To take into account two situations. 1. LoadOp for depth and stencil attachments are set differently. 2. depth and stencil unresolves could be different between the previous render pass and the current render pass. Bug: angleproject:42266019 Change-Id: I9e069b3972f86abb84eee6280919e6bba2901225 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6590197 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Tim Van Patten d9818437 2025-05-22T12:52:29 tests: Cleanup build_angle_end2end_tests_library block 1. If Vulkan is enabled, always include the Vulkan tests in the end2end tests, rather than excluding them when build_angle_end2end_tests_library is 'true'. 2. Remove NDK include. It's unnecessary, because the 'angle' target already manages its own include_dirs. Bug: b/279980674 Change-Id: Ibf3c29a5f90f161a7c9a69f5c4736ea4c3ef49ae Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6580875 Reviewed-by: Solti Ho <solti@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Tim Van Patten <timvp@google.com>
Tim Van Patten 3c2bff4b 2025-05-22T12:33:12 Rename angle_end2end_tests_aosp to angle_end2end_tests_library Rename the GN arg angle_end2end_tests_aosp to angle_end2end_tests_library, because while building the end2end tests is relevant for Android, it's not restricted or specific to Android. Bug: b/279980674 Change-Id: I8f03e0fe264ac918cb34c379be85b65d7bfc0ab1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6580873 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Tim Van Patten <timvp@google.com>
Tim Van Patten f9053516 2025-06-10T14:24:13 MultiviewTestBase: Remove setWebGLCompatibilityEnabled(true) Remove setWebGLCompatibilityEnabled(true) from MultiviewTestBase since it's not required and prevents running the tests when the extension EGL_ANGLE_create_context_webgl_compatibility is not available. Bug: b/279980674 Test: angle_end2end_tests --gtest_filter=*Multiview* Change-Id: I32a95b110e17afcb0d45c0c8447d43f456310fee Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6635032 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Tim Van Patten 0d441eda 2025-05-29T12:04:46 util: Give all ConfigParameters default values ConfigParameters has a mix of 'bool' and 'Optional<bool>', with some tests setting the Optional<> values to the default value, inadvertently creating a dependency on the associated extension. To reduce the dependency on various extensions and allow more tests to run, update ConfigParameters to only contain raw bools and initialize them to the default values defined by the associated spec. This allows EGLWindow to only require the necessary extension when a non-default value is set by a test. This also requires updates to a handful of tests which were relying on the state of extensions due to non-default values. Bug: b/279980674 Change-Id: I77a7e102559e4393aadcdbf37886ae80cbbb9e29 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6618033 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
angle-autoroll d54c84e4 2025-06-11T10:01:56 Roll vulkan-deps from c102e5508704 to e16ef854c44f (5 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/c102e5508704..e16ef854c44f Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/90cfb3e96463b267e2a3b88181edf7bfde08d947..e9a8ceeddbf7e3aaadac2ab6f8a6ab6437872e88 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/a8f8e645cd32508a134597bd9089a35e8da26240..59483c4ebaaecbaa4ca887a68c1631d17177a35c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: I9de3b10b3647614b564bb810be9cabd469f81c94 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6637589 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 97043921 2025-06-11T03:01:07 Roll SwiftShader from a857503547cb to 13a5d59c83e4 (3 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/a857503547cb..13a5d59c83e4 2025-06-11 syoussefi@google.com Fix Debug build 2025-06-10 syoussefi@google.com Update Vulkan headers to version 1.4.317 2025-06-10 swiftshader.regress@gmail.com Regres: Update test lists @ a8575035 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:422982681 Tbr: solti@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I590150706f1054a7218dd578367cf4443f6662ae Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6637332 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 569f567e 2025-06-11T07:16:00 Roll Chromium from 48d63a682177 to 618b8dc7c27c (379 revisions) https://chromium.googlesource.com/chromium/src.git/+log/48d63a682177..618b8dc7c27c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/110bbb568f..af5fc163a6 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/941e05d14d..164f8abf67 * buildtools/linux64: git_revision:e5c4d1881b85b82789b7013233a944cf1a46370f..git_revision:8ea3af9118a65387fe4d8428db6f59c5927dd55a * buildtools/mac: git_revision:e5c4d1881b85b82789b7013233a944cf1a46370f..git_revision:8ea3af9118a65387fe4d8428db6f59c5927dd55a * buildtools/win: git_revision:e5c4d1881b85b82789b7013233a944cf1a46370f..git_revision:8ea3af9118a65387fe4d8428db6f59c5927dd55a * testing: https://chromium.googlesource.com/chromium/src/testing/+log/105a2f2754..9e9017624a * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d255a8d41e..974e876217 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/c7b224d8e8..2be4a578cb * third_party/r8/d8/cipd: i5l_yPIc-ZuKle_ibElGMSf50XN8buMgspBkoObkkRAC..F0pTWc6uG70kZPngypnQxCgD3CgY5D8O-pDqj_qeoQMC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/37098fd050..03b01d3183 * tools/luci-go: git_revision:4ee25ef52cdb1d0ce5bba817578a4b40381bc39e..git_revision:a716714d42790a4677b6abb0bf0c3102d6d5bb6f * tools/luci-go: git_revision:4ee25ef52cdb1d0ce5bba817578a4b40381bc39e..git_revision:a716714d42790a4677b6abb0bf0c3102d6d5bb6f * tools/luci-go: git_revision:4ee25ef52cdb1d0ce5bba817578a4b40381bc39e..git_revision:a716714d42790a4677b6abb0bf0c3102d6d5bb6f * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/d0f35a370e..d57ede6ba3 No update to Clang. Bug: None Tbr: solti@google.com Change-Id: I298b834f37ddd9c736c3ddba6f85afdb6c522fa6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6635836 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shashank Sharma c6b3440b 2025-06-06T23:34:33 Vulkan: Add G10X6_B10X6R10X6_2PLANE_420_UNORM_3PACK16 support. Add support for YCBCR_P010 format. Bug: b/408996471 Change-Id: I899533b604e5b2fd0ad1fb1e940dd1f119179794 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6628658 Reviewed-by: Solti Ho <solti@google.com> Auto-Submit: Shashank Sharma <shawshanks@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Amirali Abdolrashidi c39f4a5c 2025-06-05T15:35:06 Vulkan: Update border color assignment for stencil In texture border clamp, if the border color is assigned together stencil mode (both using glTexParameter()), its red component is used to set up a border color to be used in each backend: * (Set up in AdjustBorderColor()) In the Vulkan backend, this is used when updating SamplerDesc, which is then used later to set up the custom border color: * (VkSamplerCustomBorderColorCreateInfoEXT) According to the spec, in case of undefined format, integer border color, and stencil image, the implementation is required to use either the first or the second component of the custom color, although it is recommended to use the first. However, at the moment, only the first component is being populated, while using the second component is also valid. * Added feature: usesSecondComponentForStencilBorderColor * Added bit to SamplerDesc: mUsesSecondComponentForStencil * It is set based on the feature flag above and the texture format. * When setting the custom border color info, the second component will be used based on the above flag. * Added test suites to test this on ES31 and ES32: TextureBorderClampTestES3*.CustomBorderColorWithStencil* * Updated capture params for glTexParameterIuivEXT(). * Suppressed the ES32 version for the following: * P4 * Linux/NVIDIA (due to out-of-date driver) Bug: b/390710636 Change-Id: Ie50c19e8ea66da40dc8b8db49d7e622a582637a5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6626416 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Aurora Zhang 65159c4e 2025-06-05T15:05:46 Update pipeline desc when sample count changes * If the sample count changes when calling glFramebufferTexture2DMultisampleEXT, we need to update pipeline desc to ensure it is the same as the API requires. * Add a new end2end test to verify. Bug: angleproject:422611722 Change-Id: I7de7d3d17513cf03f5e24baa2db83633a229b4b8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6623419 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Aurora Zhang <Aurora.Zhang@arm.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 2519de7c 2025-06-10T18:34:57 Manual roll Chromium from 89af20128575 to 48d63a682177 (1478 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/chromium/src.git/+log/89af20128575..48d63a682177 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/74fd4e41fc..110bbb568f * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/64b9f65d16..941e05d14d * testing: https://chromium.googlesource.com/chromium/src/testing/+log/0cb342c45f..105a2f2754 * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/18bc289fc3..34bf3dd2d9 * third_party/android_build_tools/lint/cipd: B12WztL3EZsuJ7B1dMlfrnCHVd4n5qgxf_HYDQyzOkAC..elV-KSOeiX0hBeuw8Swk8wWiXT8Ns35MNwiOp6SLR4QC * third_party/android_build_tools/manifest_merger/cipd: 1QtZ_gZ5icFNOEvVrY34lJgcC2XoXxBfgPmz-eBrk7UC..VcONzD64-9oyADpPb46XY3qQ0bWCJVaFIKA2dNziAY4C * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/aa341ec41f..a1a1df4d27 * third_party/fuchsia-sdk/sdk: version:28.20250605.5.1..version:28.20250609.4.1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/cdae0b78c3..2c359c239b * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/39b4cdb3bd..c7b224d8e8 * third_party/r8/cipd: pxgwR4ardZ3LnNCARPEbdl_gTA9R1aaHowtsCNRpZaYC..F0pTWc6uG70kZPngypnQxCgD3CgY5D8O-pDqj_qeoQMC * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/4a625964c6..1097f51190 * third_party/siso/cipd: git_revision:963177240b1a36697c9762856f51ad36ab545ceb..git_revision:d704490133011610c402696584afedea80829dbd * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/60453178b6..479e8c395f * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/71e38a3895..37098fd050 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/04d0441efb..1c0b50128b * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/70322b4cf9..d0f35a370e No update to Clang. Bug: None Tbr: solti@google.com,ynovikov@google.com Change-Id: I79296225469163b4d99f784d1389742578588427 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6634622 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuxin Hu 1e613fec 2025-05-27T16:59:26 Compiler: sort uniforms by precision This change reoreders the AST sequences so that uniform declarations with lower precisions are places in front of uniform declarations with higher precisions. This is to prepare for the upcoming change that converts uniforms declared with mediump or lowp to 16-bit and pack them to 32-bit integeter using packHalf2x16(). Bug: b/405795981 Change-Id: I5e1e293399dc8b51b9a6e83115f95beb0c4a7b1b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6594255 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Mohan Maiya c45e7c83 2025-05-22T04:14:52 Vulkan: Optimize uniform and storage buffer updates Maintain a map between buffer block index and its DescriptorDesc index in WriteDescriptorDescs and look up the map instead of repeatedly calculating it when updating DescriptorDesc Bug: angleproject:386749841 Change-Id: I74d14f6205f07992fae1e338697998d04de1c563 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6603986 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Tim Van Patten b888dc2b 2025-06-09T16:58:38 OcclusionQueriesTest: Convert to ANGLETest<> Convert OcclusionQueriesTest to an ANGLETest<> and remove calling ANGLETestSetUp() directly. This can be error-prone if ANGLETestSetUp() doesn't complete, but the test still executes GL commands either in SetUp() or testSetUp(), before the test itself can be skipped. In that case, there may not be a current Context, leading to calls like glGetString() returning nullptr. This also includes some additional cleanup to remove the GetParam() calls. Bug: b/279980674 Change-Id: I5604836c78845424b82b693bc1b74e84b6b557d4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6631025 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Tim Van Patten 0ac62dd7 2025-06-09T16:47:22 MultiviewRenderTest: Return if test should be skipped MultiviewFramebufferTestBase::FramebufferTestSetUp() may not complete if ANGLETestBase::ANGLETestSetUp() determines the test needs to be skipped due to (for example) missing extension support. In that case, there may not be a current Context, leading to calls like glGetString() returning nullptr. Check if the test is marked "Skipped" before continuing in MultiviewRenderTest::SetUp(). Bug: b/279980674 Change-Id: Iba869029bc26fc5528853be0323fd3c50037a493 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6631023 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Shahbaz Youssefi ef85f283 2025-06-10T10:45:06 Test for deferred clear vs robust init vs invalidate Bug: b/381284577 Change-Id: I15effe1f216523a51af83a154ad27d2921e52258 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6633791 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Tim Van Patten de00cc6b 2025-05-28T17:06:59 tests: Move wglWindow to a guard statement WGL tests are currently disabled. Refactor the check to be a guard statement earlier in ANGLETestBase::ANGLETestSetUp(), so it bails out sooner. This also allows for pulling everything in the else-block out, reducing indentation and improving readability. Bug: b/279980674 Change-Id: Id91b68e2a2e5ffd301a7c49733940b7f08892dce Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6604937 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Tim Van Patten <timvp@google.com>
angle-autoroll 8c512f3e 2025-06-10T10:01:24 Roll vulkan-deps from 9fc5fb6a6005 to c102e5508704 (8 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/9fc5fb6a6005..c102e5508704 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/ec1c9ca71ae2e0a63f4245978accde381865266b..90cfb3e96463b267e2a3b88181edf7bfde08d947 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/bf4ea01344ced4bbfee5d2a04ce02e8c1e99df99..63b05d2b087952662623de7eddd44f2e57d71a1e https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/6104c98e8d16bcd392116cf30d32c519835a6cfe..a8f8e645cd32508a134597bd9089a35e8da26240 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: I7c60072e04e65720bc81831c05c79310ac45fc71 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6631749 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jeff Vigil a7877665 2025-06-02T08:13:30 Fix drm format and modifier handling Move functions to private Change case on methods to lowercase per style guide Change related methods to use set instead of vector, this saves a copy from set to vector. Initialize formats before supportsDmaBufFormat because queryDmaBufModifiers can be called before queryDmaBufFormats and need to initialize at supportsDmaBufFormats. Bug: angleproject:412730346 Change-Id: I8575bee6e7a6a09d9065ed81acff899e73004764 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6610088 Reviewed-by: mohan maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Amirali Abdolrashidi d84248ce 2025-06-09T10:40:37 Revert "Disable unused private field for dEQP compilation" This reverts commit b670d47b7aaff94d3a9e2e1b975e73d0ea336d85. Reason for revert: Warnings resolved on the tests Bug: angleproject:420728429 Original change's description: > Disable unused private field for dEQP compilation > > Incoming VK-GL-CTS rolls are failing due to the following error > for some dEQP targets: > "private field 'm_size' is not used [-Werror,-Wunused-private-field]" > This warning can be suppressed for this target temporarily, allowing > the autoroller to merge new changes. Once the issue has been addressed > on the CTS code, this change should be reverted. > > * Added -Wno-unused-private-field to gles2 and gles31 targets. > * This is a temporary change. It should be removed once the issue > has been addressed. > > Bug: angleproject:420728429 > Change-Id: I0177ded84ad58a148884e8abfac3aea9a1ff7d43 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6604679 > Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> > Reviewed-by: Yuxin Hu <yuxinhu@google.com> Bug: angleproject:420728429 Change-Id: I6b655a37568f42fabf710380c82ab775b126bdc7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6630278 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Panfeng Hou 9a436772 2025-06-04T16:47:51 Vulkan: Add entry points for GL_EXT_fragment_shading_rate Bug: angleproject:420310117 Change-Id: I8a8efad6cad810b2cb0b600106f6496070495605 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6620340 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com>
Mavis Deng 65091427 2025-06-05T14:08:01 Query draw buffer should return NONE for no surface default FB When querying the draw buffer state via glGetIntegerv(GL_DRAW_BUFFER) on the default framebuffer with no surface bound, GL_NONE should be returned. Bug: angleproject:422631118 Change-Id: Iad2f1662692b0a92563e4cfd7fe09437cb40f0c7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6619453 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Mavis Deng <mavis.deng@arm.com> Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 2ca17c76 2025-06-09T03:01:54 Roll SwiftShader from 11dc1b167af4 to a857503547cb (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/11dc1b167af4..a857503547cb 2025-06-06 swiftshader.regress@gmail.com Regres: Update test lists @ 11dc1b16 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I2671e20e557946685a52fb39cd0a23f80471074e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6630254 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 666809c0 2025-06-09T10:55:52 Roll vulkan-deps from 1c3b39ad6dc0 to 9fc5fb6a6005 (13 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/1c3b39ad6dc0..9fc5fb6a6005 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/fd96661925488574fe247a779babe5d380b63635..3b9447dc98371e96b59a6225bd062a9867e1d203 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/7dda3c01fb4c0f9941d3cb792947d57d896ac55f..ec1c9ca71ae2e0a63f4245978accde381865266b https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/b11eecd68fb4b770f30fe2c9da522ff966f95b1e..1d6c53f65443ceeb97d3bdc695aaecc7ea6cc441 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/bf4aec7ddb0f46d729ebd3255296d9fe8eed73ec..bf4ea01344ced4bbfee5d2a04ce02e8c1e99df99 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/e4fb76dc08f139df0436e9c3031f75be5e1f6264..fbe722654b7173da961398cf78bd4a62d1839b65 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/03e1445cc7cce22baeeef8eff7bb934362d040eb..e48ae20a7938b01aee62806bfcdafe8a0883b1e4 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/287caf1be206dca1b8a391b10eab474a7e238fd6..6104c98e8d16bcd392116cf30d32c519835a6cfe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: Icff35c41cc4da5955e3e8e3d2ef79da675222d4b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6630275 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll a8da66d3 2025-06-09T08:01:22 Roll VK-GL-CTS from 832d82a93cb1 to 53a925d9098c (12 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/832d82a93cb1..53a925d9098c 2025-06-06 piotr.byszewski@mobica.com Add coverage for scalar int to/from float conversions 2025-06-06 ziga@lunarg.com Test not setting unused dynamic states 2025-06-06 marcin.zajac@cognizant.com Compact and update acceleration structures 2025-06-06 michal.jakubek@mobica.com Add various tests for bfloat16 type. 2025-06-06 rgarcia@igalia.com Test updating empty acceleration structures 2025-06-06 erik.faye-lund@collabora.com Correct failure condition for max-samples 2025-06-06 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.3 into vk-gl-cts/main 2025-06-05 michal.jakubek@mobica.com Allow vkt::TestCase access to VkInstance and VkDevice 2025-06-05 lorenzo@khronosgroup.org Improvements to code generation for mandatory features 2025-06-05 lorenzo@khronosgroup.org Fixes to mandatory feature tests generation (also corrects typo) 2025-06-05 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.3 into vk-gl-cts/main 2025-06-04 lorenzo@khronosgroup.org Update external sources (Vulkan 1.4.316) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: Ifc321611524caed58916324c8cbfa39e21a06ebd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6629607 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya 3a15fab0 2025-06-05T13:47:18 Add tests for per-sample shading state tracking Add tests to cover usecases exposed by these optimizations - - https://chromium-review.googlesource.com/c/angle/angle/+/6622156 - https://chromium-review.googlesource.com/c/angle/angle/+/6619019 Bug: angleproject:386749841 Change-Id: I848ed68afe00757a10c8c970ee1f9a9b4646e9ab Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6622107 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
angle-autoroll 3d81e45d 2025-06-06T10:01:23 Roll vulkan-deps from 0dbc05833984 to 1c3b39ad6dc0 (3 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/0dbc05833984..1c3b39ad6dc0 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/fc060af4813d2d9b973f982c4987e1d53b1ec1c6..ac1c686d562147c751a0c284f879499418beee46 https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/7bcaa58729088d25eb6cbe6fce3dee9a9812f43e..e088d553426a3036270701d07dde28bf33d318be https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/596534df7e93137255f803653de4614e9d9e7ba2..287caf1be206dca1b8a391b10eab474a7e238fd6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I80aa1fe06a26cfb4dd66ca53d118e52d94afc352 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6626328 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 0cab8c9c 2025-06-06T03:01:39 Roll SwiftShader from b62ac8aa106b to 11dc1b167af4 (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/b62ac8aa106b..11dc1b167af4 2025-06-05 syoussefi@google.com Keep VIEW_INDEX_FROM_DEVICE_INDEX_BIT unsupported 2025-06-05 yiwzhang@google.com specify the gerrit listener type to be legacy poller If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: Ia9d9d451eba376b44d986fe180b750902ff595e0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6626392 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 921b5a1c 2025-06-06T07:01:29 Roll Chromium from ae0de49bcdc3 to 89af20128575 (548 revisions) https://chromium.googlesource.com/chromium/src.git/+log/ae0de49bcdc3..89af20128575 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/e78b1cf9e6..74fd4e41fc * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/3c185fa96c..64b9f65d16 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/4abe594e45..0cb342c45f * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/ea769d2a2a..aa341ec41f * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6d52c22ee3..d255a8d41e * third_party/fuchsia-sdk/sdk: version:28.20250528.4.1..version:28.20250605.5.1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/0e242589e5..cdae0b78c3 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/644c27c66c..39b4cdb3bd * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/483563e40f..4a625964c6 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/6268d2158a..71e38a3895 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/db7318cc95..70322b4cf9 * tools/skia_goldctl/linux: bg1T2otEnMQQe-Lo1MLLZexZL1VsvAVAqfwuhhjSxQ4C..lkxqvhJtv-45S0zRCu7Z3er-IcDc6t931-7jM1lN-RMC * tools/skia_goldctl/mac_amd64: v4HGLZ-ir5Y-4pZMGKYMAgJ7yAEv5Y5Kj-cdpYfzlgoC..r2LyNXR63hRBteBs8GN14Otjpbnu_VQvVOvDVUFjeV4C * tools/skia_goldctl/mac_arm64: LNWlZ0vnIDglaN4JlNc530ujLuhm_WIlIjLZEbgNfOcC..tJUKq9z8lfdk4KydEare4F1gdGAXnTVuC5W3k8mBQBMC * tools/skia_goldctl/win: RKUSAHdNBItBShnfuk9DnsnmBS-7kTAt7k2N_GzFzmsC..1pUE-hNBek5om-0mUbI4sJSEt4-m1AwEGnVNuEfMFOIC No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: I3cdec55cddf71ee03a4a4e8f85ceacf1a9028080 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6626326 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya db962407 2025-06-03T08:00:43 Vulkan: Optimize FramebufferVk::getSamples() Cache value of samples during syncState(...) and return this value on subsequent queries Bug: angleproject:386749841 Change-Id: I21fb2221187c7b2159fed1b271da642ba2552348 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6619019 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Alexey Knyazev f6b40bc8 2025-05-15T00:00:00 Add a missing compile macro Bug: angleproject:406922380 Change-Id: If2d4cc1472b490b3507591f0a6ac940369df5ccb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6624377 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 8c48b502 2025-06-05T02:09:54 Vulkan: Fix deferred clear vs robust init vs invalidate The DIRTY_OBJECT_DRAW_ATTACHMENTS bit, when handled, goes over framebuffer attachments and requests that they be cleared. This is done only with robust init. The DIRTY_OBJECT_DRAW_FRAMEBUFFER bit, when handled, results in staged updates to be applied to the attachments. When syncDirtyObjects is called, the above bits are handled. If we end up in a situation where DIRTY_OBJECT_DRAW_ATTACHMENTS is set, but not DIRTY_OBJECT_DRAW_FRAMEBUFFER, the following happens with Vulkan: - Handle DIRTY_OBJECT_DRAW_ATTACHMENTS - TextureVk::initializeContents - ImageHelper::stageResourceClearWithFormat - Observer message to TextureVk->Texture->Framebuffer->Context - Context sets DIRTY_OBJECT_DRAW_FRAMEBUFFER - However syncDirtyObjects does not notice this bit, as it has cached the dirty objects and is in the middle of looping over them In the above scenario, the call that results in syncDirtyObjects does not process the draw framebuffer (if not already dirty for some other reason), meaning the clear is not applied _before_ the current operation but after it (whenever framebuffer is synced next). In this change, I attempted to ensure that if DIRTY_OBJECT_DRAW_ATTACHMENTS is ever dirty, DIRTY_OBJECT_DRAW_FRAMEBUFFER is also dirty. There were a few operations that could theoretically lead to this which are fixed by this change. The particular one that revealed the bug was State::syncDirtyObject syncing only the FRAMEBUFFER bit and leaving the ATTACHMENTS bit for the unsuspecting following operation. The aforementioned assertion is not included in this change however, as it revealed one unresolved issue with the d3d backend where DIRTY_OBJECT_DRAW_ATTACHMENTS is not set, but processing DIRTY_OBJECT_DRAW_ATTACHMENTS sets it while dirty bits are being processed. Bug: b/381284577 Change-Id: If3c35fbade069ae75f66dd6d4df5d73882a08a93 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6621059 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 92dec961 2025-05-15T00:00:00 Enforce validation consistency for lockless entry points Bug: angleproject:406922380 Change-Id: If4e6051d0ac465f4ae8abca0a62cad14d1d739b7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6624114 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Amirali Abdolrashidi b6579180 2025-05-15T15:29:28 Add test case for CS writes without barriers * Added the following test to ComputeShaderTest: WriteToSeparateSSBOComponentsWithoutExplicitBarrier * Based on KHR-GLES31 test: .core.shader_storage_buffer_object.advanced-switchBuffers-cs * It involves writing to different components of an SSBO without explicit barriers in between. Bug: b/417769912 Change-Id: I9f6170937c9ccf3487d8f9e7758196c950252ea3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6552162 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
angle-autoroll 25fc5046 2025-06-05T03:01:42 Roll SwiftShader from a8133cbb3c89 to b62ac8aa106b (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/a8133cbb3c89..b62ac8aa106b 2025-06-04 swiftshader.regress@gmail.com Regres: Update test lists @ a8133cbb 2025-06-04 syoussefi@google.com Fix a number of asserts hit by latest tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: Ibaa7fc30224a1cf9b48953d36af07310ae4003f7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6623507 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
kmx.io     mail     discord kmxgit v0.4.0