|
2364578f
|
2022-12-07T10:33:05
|
|
infra: Enable UBSAN together with ASAN and LSAN.
These flags are compatible. This should save on testing resources.
Bug: angleproject:7871
Change-Id: I860e3724f54bdbf06e7530bd6bfe72ec0f53cc54
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4086283
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
583fc6a7
|
2022-12-07T16:21:36
|
|
Skip FramebufferExtensionsTest.ColorBufferHalfFloat on iOS
Bug: angleproject:7853
Change-Id: I25f2a37a64ac2445b4eb5eb567acf32834f5e55f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4085142
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
|
|
9dc82cb3
|
2022-12-07T10:01:47
|
|
Roll SwiftShader from 2783f6bf0a03 to 0c98167cb31e (1 revision)
https://swiftshader.googlesource.com/SwiftShader.git/+log/2783f6bf0a03..0c98167cb31e
2022-12-06 sugoi@google.com Merge changes I1950088a,Iecb2d8a2,I250a1541,I4dc2e503
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC abdolrashidi@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: abdolrashidi@google.com
Change-Id: I85f264a26fc8007258d0f89755b9ba4c05cb5ba5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4084529
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
dad69cc7
|
2022-12-06T12:00:39
|
|
Suppress rgb_to_hsl_vertex test on Pixel 6
Bug: angleproject:7867
Change-Id: I2678c0db19fafb780245f818f365e88c7736c5ca
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4083524
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
|
|
|
3bd0cce8
|
2022-12-06T09:56:58
|
|
Roll Chromium from bdfdd7d2b008 to 6a123e5dfc29 (584 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/bdfdd7d2b008..6a123e5dfc29
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC abdolrashidi@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/988bc9fa63..d286aa4250
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/1547c3fe52..d1379d3f07
* buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/f92e1b7e40..8e00079800
* buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/44d54baf42..f46bba92c0
* buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/fd49ee4ee9..2b51e6f1ec
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/2a9f393809..af35c6055b
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..d8be2db858
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ec1882fbc2..25334bb18e
* third_party/turbine: 4Cvss-AYlYPcW_PIdcX45Ew7ZQwsaeurs7mUjS3LFyQC..R-Qp1tMBqIuETMfXNqQU9GB00ij6dsPjVmjDuvH_194C
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/dabb142daf..9f615fd096
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/828f44d2de..d9c9c23e02
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/cb53190619..a5b1342192
No update to Clang.
Bug: None
Tbr: abdolrashidi@google.com
Change-Id: I645582357f53670d974323ff9b3c2d04e3dc5852
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4083106
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
384ce5cf
|
2022-11-29T14:18:34
|
|
Capture/Replay: Corretly reset the UnpackAlignment at end of MEC
Direcly setting the value doesn't set the relevant dirty state,
use the appropriate setter call instead. This fixes the reported
difference between the UnpackAlignment value stored in the trace
and the one recorded ruring validation for MEC.
Bug: angleproject:7564
Bug: angleproject:7180
Change-Id: Ic931cac9b7e33519e992ae55ee5cab2adb2958ca
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4063892
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
701ef3f2
|
2022-12-06T10:01:53
|
|
Roll SwiftShader from e6a3153888f0 to 2783f6bf0a03 (2 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/e6a3153888f0..2783f6bf0a03
2022-12-06 sugoi@google.com Change Chromium's SwiftShader owners
2022-12-06 swiftshader.regress@gmail.com Regres: Update test lists @ e6a31538
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC abdolrashidi@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: abdolrashidi@google.com
Change-Id: I1e6340f37ef870026e8fb49e575ad9bccc0ce024
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4082295
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
aba757d4
|
2022-12-06T10:01:08
|
|
Roll vulkan-deps from ca8ca2aba961 to a497ee9d6755 (62 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/ca8ca2aba961..a497ee9d6755
Changed dependencies:
* glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/88fd417b0b..a7603c132d
* spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/c214f6f2d1..1d31a10040
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/46ca66e699..40f5bf59c6
* vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/b092b2fccc..891c40de1a
* vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/3a092fe869..82d4232f0f
* vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/ec541c410e..ce45337c51
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/7a9d51a51c..1f2848428c
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC abdolrashidi@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: abdolrashidi@google.com
Change-Id: I2feeac1a9e1fed54d9f57d4f29e926b48efa33e5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4083107
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
a9464755
|
2022-12-06T01:50:52
|
|
Roll SwiftShader from 6a259c87ef52 to e6a3153888f0 (24 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/6a259c87ef52..e6a3153888f0
2022-12-02 capn@google.com Use helper function for SPIR-V explicit layout storage classes
2022-12-02 sugoi@google.com Add memory allocation checks
2022-11-29 lokokung@google.com Adds some extra comment/documentation for DebugMessenger in VkInstance.
2022-11-28 lokokung@google.com Fixes leaking DebugUtilsMessenger in Instance.
2022-11-28 sugoi@google.com Unify BGRA masks
2022-11-25 sugoi@google.com Add 5/6-bit unorm support to the floating point version of writeColor
2022-11-25 sugoi@google.com Add 4-bit unorm support to the floating point version of writeColor
2022-11-25 sugoi@google.com Add 10-bit unorm support to the floating point version of writeColor
2022-11-25 sugoi@google.com Add sRGB support to the floating point version of writeColor
2022-11-25 sugoi@google.com Add 8-bit unorm support to the floating point version of writeColor
2022-11-25 sugoi@google.com Color write mask refactor
2022-11-24 sugoi@google.com Add utility function to transpose BGRA data
2022-11-24 sugoi@google.com Fix linear to sRGB conversion functions
2022-11-24 swiftshader.regress@gmail.com Regres: Update test lists @ bb5d3bdb
2022-11-24 sugoi@google.com Update SPIR-V Tools to 597631b69
2022-11-24 capn@google.com Output storage class stores have effect in helper invocations
2022-11-24 swiftshader.regress@gmail.com Regres: Update test lists @ 95c2e209
2022-11-24 capn@google.com Fix SPIRV-Tools Android.bp build, part two
2022-11-23 capn@google.com Fix SPIRV-Tools Android.bp build
2022-11-23 capn@google.com infra: Also automatically run win-swangle-try-tot-swiftshader-x64
2022-11-23 swiftshader.regress@gmail.com Regres: Update test lists @ d34588e0
2022-11-21 swiftshader.regress@gmail.com Regres: Update test lists @ d89bb011
2022-11-18 capn@google.com Update SPIR-V Tools to 1a7f71afb
2022-11-18 capn@google.com Update SPIR-V Headers to c214f6f2d
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC abdolrashidi@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: abdolrashidi@google.com
Change-Id: I7e9dbb80b332e11c9ea65f0ccf170e00e4440bba
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4081062
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
982755e0
|
2022-12-05T15:32:42
|
|
Suppress VUID-vkCmdDraw-None-06887
* Suppressed the following VVLs:
* VUID-vkCmdDraw-None-06887
* VUID-vkCmdDrawIndexed-None-06887
Bug: angleproject:7861
Change-Id: I15cdf934bd87b5d5219e69eebc9d339d4c180660
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4082149
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Auto-Submit: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
0f7471ff
|
2022-12-05T16:28:41
|
|
Skip AssignAssignmentToSwizzled on SwS Linux/Win
Bug: angleproject:7863
Change-Id: I9921e2e08834f793071ea07b211941bc8887b313
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4082150
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
3b57c2a8
|
2022-12-05T15:33:43
|
|
Add cmnt for VUID-vkDestroySemaphore suppression
Bug: angleproject:7729
Change-Id: I46d8afe9702b9263a776e9acfa9a3364b7184579
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4080592
Reviewed-by: Ian Elliott <ianelliott@google.com>
Auto-Submit: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>
|
|
2d87551d
|
2022-12-05T10:47:40
|
|
Vulkan: Make mLargestAllocatedIndex atomic
TSAN is complaining mLargestAllocatedIndex not thread safe. This CL
makes it atomic and make it mean " the largest queue index we have ever
allocated/seen" so that it will be thread safe. It is impossible to use
a queueIndex before it been allocated. But it is still possible that
some mUse still referencing a queueIndex after it is been released. The
only downside is that we may get into slightly less optimal code path
for GetBatchCountUpToSerials if we ever get into more than 64 queueIndex
and then get bellow 64 again, but that should not a real concern.
Bug: angleproject:7860
Change-Id: I4c99bae24e9d72298253e43f8d108444a8f46ebc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4080590
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
bd79968a
|
2022-12-02T14:17:14
|
|
Vulkan: Make sure program's pipeline cache is created
The condition to create or use the program's pipeline cache has become
quite complicated. This change simplifies things by making sure the
pipeline cache is created if and when it's used, instead of guessing how
it will be used and pre-create it.
Bug: angleproject:7369
Change-Id: I7f3558e55f391da8c701e359d2f88d248c820de4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4076508
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
8181c056
|
2022-11-22T15:34:48
|
|
Vulkan: Remove RenderPassSerial
RenderPassSerial was introduced to uniquely identify a
RenderPassCommands. With the work of per current context queue serial,
now every started RenderPassCommands already have a unique QueueSerial.
This CL removes RenderPassSerial and use renderPass's queueSerial
instead.
Bug: b/255414841
Change-Id: Id0a87319a9132cdb74aba195f1f05aa31454592b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4049966
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
|
|
87815de2
|
2022-12-01T00:00:00
|
|
Adjust GetFramebufferAttachmentParameterivBase validation
GL_FRAMEBUFFER_ATTACHMENT_COMPONENT_TYPE_EXT state queries
should be allowed for ES 2.0 clients when floating-point
color buffer extensions are enabled.
Bug: angleproject:7853
Change-Id: I4a0a3b336e44648635233be54f598a3ab20cf717
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4071926
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
3fedd435
|
2022-12-05T10:15:22
|
|
Overlay: Switch font to RobotoMono
Which has an Apache 2.0 license
Bug: b/260423572
Change-Id: Ibc4b664ddfe844be08ccbac57c27e81951940490
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4079268
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
d9c9eede
|
2022-12-05T15:11:21
|
|
Roll VK-GL-CTS from 9d22258ed442 to d90c76e77622 (14 revisions)
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/9d22258ed442..d90c76e77622
2022-12-02 quic_mnetsch@quicinc.com Merge vk-gl-cts/opengl-es-cts-3.2.8 into vk-gl-cts/main
2022-12-02 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkansc-cts-1.0.1 into vk-gl-cts/main
2022-12-02 rgarcia@igalia.com Remove custom instances from robustness index access tests
2022-12-01 lionel.g.landwerlin@intel.com Fix uninitialized blendConstants in ColorBlendState
2022-12-01 ziga@lunarg.com Add missing extension checks in extended dynamic state tests
2022-12-01 piotr.byszewski@mobica.com Ensure robustness for OOB index buffer accesses
2022-12-01 ziga@lunarg.com Test creating device with promoted feature structures
2022-12-01 rgarcia@igalia.com Avoid passing unsupported structs in mandatory features test
2022-12-01 cturner@igalia.com Adds coverage for gl_PrimitiveID implicit passthrough with GPL.
2022-12-01 rgarcia@igalia.com Avoid using custom instances in robustness tests
2022-12-01 mcanal@igalia.com Allow override of wayland-scanner executable
2022-12-01 rgarcia@igalia.com Add VK_NULL_HANDLE definition to vkDefs.hpp
2022-12-01 zzoon@igalia.com Add tests for buffer device address with buffers bound at offset
2022-12-01 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkan-cts-1.3.4 into vk-gl-cts/main
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC abdolrashidi@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: abdolrashidi@google.com
Change-Id: Ic01d46349b71964bd250515d6246a36cc75fee89
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4080546
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
3269998c
|
2022-12-05T07:00:43
|
|
Roll Chromium from 5d807d6fc7dd to bdfdd7d2b008 (315 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/5d807d6fc7dd..bdfdd7d2b008
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/d5942868d8..988bc9fa63
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/fdc7c13983..1547c3fe52
* buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/2dda3c5c1b..f92e1b7e40
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/952f26fb11..2a9f393809
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..41eec55d82
* third_party/r8: FNMbaJ4o3bVeGVnIwu9D0VSqXEZIi5v2LV9ycHFpqrkC..0SzbA94FRVtzsELRN30my7jJQTeHVH65wHSU1JF2bQMC
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/65848dccd6..dabb142daf
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/ea9a7de758..828f44d2de
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/b1111b1e0a..cb53190619
No update to Clang.
Bug: None
Tbr: cnorthrop@google.com
Change-Id: I38bc3e5b58a3b3b27bde2c2191d7a10fcb20fd1d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4078757
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
b36e337e
|
2022-12-02T22:18:18
|
|
Roll Chromium from 366b354bb4e3 to 5d807d6fc7dd (318 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/366b354bb4e3..5d807d6fc7dd
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/961774e175..d5942868d8
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/c1f7bc4f73..952f26fb11
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..550c7afb52
* third_party/r8: NhcNRQ45-HIXvuu5CxFmUsIbvW9Or8_tkceuhByYJywC..FNMbaJ4o3bVeGVnIwu9D0VSqXEZIi5v2LV9ycHFpqrkC
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/b187174108..b1111b1e0a
No update to Clang.
Bug: None
Tbr: cnorthrop@google.com
Change-Id: If29982352c520f9c8076ad51183bcedb6440f935
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4077107
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
2031e215
|
2022-12-02T15:30:54
|
|
Fixes for Vulkan secondaries build.
Includes the defined name of the alternate library in every
build, so that platforms without Vulkan still have access to
the library name define.
Also fixes checks for the ANGLE driver in the tests to work
with the new secondaries enum. This will let developers run
trace tests with the vulkan secondaries library.
Bug: angleproject:6811
Change-Id: If3846d68e532238f0b1c1c506638867a23fb4357
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4076513
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
650f2274
|
2022-12-02T15:51:09
|
|
Vulkan: Remove fixed VVL errors
Bug: angleproject:7338
Change-Id: I4d2b05c5fd5ad505fda2089dbfa2119e8db8ac16
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4076515
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
0790a807
|
2022-12-01T23:58:36
|
|
Capture/Replay: Add ResourcesToDelete
For resources that are deleted but not recreated by the app,
we need to skip the delete call we've been making for
ResourcesToRegen. To support this, track which resources need
to be deleted.
We've gotten by without this for so long because most apps
will immediately recreate a resource after deleting it. When
they simply delete starting resources, we can't try to delete
them again.
Test: MEC of multiple apps
Bug: angleproject:4599
Change-Id: I226ba7887e2b7b31d4ce9a75d6a8d0a24f3f32ac
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4075486
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
f17cb883
|
2022-11-30T17:23:12
|
|
Vulkan: Add two tests for per context queue serial work
SubmittingOutsideCommandBufferTriggersEndRenderPass: This test is added
to test outside command buffer uploads that triggers endRenderPass works
properly.
CreateMultiSharedContextAndDraw: This test is added to test draw with
shared vertex buffer in the shared context group works properly.
Bug: b/255414841
Change-Id: I8b4f343fe220a9f0b7c6e042f4663e23ae6f4c9d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4064148
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
|
58d7ace2
|
2022-11-22T16:08:07
|
|
Vulkan: Add memory allocation log support in debug
* Added a memory tracker to the renderer object to keep track of the
memory allocations and deallocations in more detail.
* This feature is used for debugging only.
* To enable it, set angle_enable_memory_alloc_logging=true in GN args
(added in renderer/vulkan/BUILD).
* It is related to ANGLE_ENABLE_MEMORY_ALLOC_LOGGING in the code.
* The tracker are updated in the memory allocation tracking functions
if the feature is enabled. (The counter is always updated, even if
the feature is disabled.)
* At the end of a RendererVk object, it checks for and logs any
remaining allocated memory from MemoryAllocationType members.
* The data is stored in the map object "mMemoryAllocationTracker".
The key used for it is currently of type angle::BacktraceInfo.
* If angle_enable_unwind_backtrace_support is disabled, or not on
Android, the key is an empty object.
* MemoryAllocInfoMapKey is used as a key to access the allocation
information.
Bug: b/242641395
Change-Id: If701a4bdea2f8738a830ee47e0c7c5cdacf95b87
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4050103
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
66a7117a
|
2022-11-30T10:34:30
|
|
GLES1: Use less precision for color and tex coords
Per the GLES1 spec, color and tex coords are satisified by
half-precision floats.
Bug: angleproject:6644
Change-Id: Ia3f8e45d4c35557a25373f9ad572e87708bc2001
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4067803
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
2e5ca217
|
2022-11-18T10:44:49
|
|
Vulkan: Let each current context has its own QueueSerial.
This CL makes every current context has its own queueSerial. At context
creation time or when context becomes current, it allocates a QueueIndex
from renderer. When it becomes non-current, it releases QueueIndex for
others to reuse. This way we significantly reduces the max number of
QueueIndexs for reasonable usage. Each CommandBuffer has its own unique
QueueSerial and we use that to determine if a resource is being used by
the given CommandBuffer. The QueueSerial for RenderPassCommands is
deferred until renderPass starts, and when we generate queueSerial for
renderPassCommands, we also reserve a range of serials for
outsideRenderPassCommands so that we can do incremental submission of
outsideRenderPassCommands without need to close renderPassCommands. In
rare situation, if that reserved serials runs out, we also close
renderPassCommands to ensure the ordering of serials matches ordering of
command buffers.
With per current context queue serial, this CL is able to set resource
queue serial as it is being used. This CL completely removes usage of
ResourceUseList class since it was introduced due to deferred setSerial.
This CL also get rid of refCount from ResourceUse since there we no
longer add it to a ResourceUseList. With that, we also able to remove
SharedResourceUse class since access to ResourceUse itself is now thread
safe since we are able to make a copy of it when we add it to
GarbageList.
Because RenderPassCommands now has its own unique QueueSerial as it
encodes command, we can use it to detect if a resource is being used by
it or not, thus this CL also removes usage of CommandBufferID.
Bug: b/255414841
Change-Id: I36dcbeaa7bc996f04e6c04bf9ad44cd0d630f61a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4038096
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
|
db557905
|
2022-12-02T11:32:10
|
|
Vulkan: Fix -Wbitfield-enum-conversion
Bug: chromium:701384
Change-Id: I8c729934365c035a682e81467679fb7149864aac
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4076505
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
bdb127da
|
2022-12-02T10:53:22
|
|
Android: Remove smhasher license
Removed in:
https://chromium-review.googlesource.com/c/angle/angle/+/4066987
Causes the ANGLE to Android roller to fail:
https://android-review.git.corp.google.com/c/platform/external/angle/+/2323099
Error:
external/angle/Android.bp:6474:1:
module "external_angle_license": module source path
"external/angle/src/common/third_party/smhasher/LICENSE"
does not exist
Bug: b/260426695
Change-Id: I974d79f155b1077d8d42555245fed1eed69056f9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4073983
Commit-Queue: Solti Ho <solti@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Auto-Submit: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Solti Ho <solti@google.com>
|
|
ec4629d6
|
2022-12-02T10:53:38
|
|
Android: set android:allowBackup="false" in manifset
This wasn't previously being set, and a partner pointed out that it
causes a security scan issue as explained in
https://stackoverflow.com/questions/12648373/what-is-androidallowbackup).
Bug: b/242671681
Change-Id: I17a0d9eec4ee7904ebb07bf934c7e2cdd8d61921
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4073982
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>
|
|
|
aaee3c23
|
2022-11-30T14:24:13
|
|
Build and test ANGLE with Vulkan secondary CBs.
This will allow us to run tests with both permutations of
ANGLE (custom secondaries & Vulkan secondaries) in the same
build directory. It will also allow us to run these configs
as tests on our infra. This CL adds a few simple test to CI.
Bug: angleproject:6811
Change-Id: I053f8cc5bafc2a7ab7d0665da9301f0ba7f8417f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4067806
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
b432c84c
|
2022-12-01T10:40:03
|
|
Capture/Replay: Fix collecting the initialized contexts
The main context initialization function will be emitted as
"Shared" and not based on the context number, so only add the
secondary contexts to the list of contexts that need additional
setup.
Fixes: b301b82235ca686d036a8d29380da22bb2060060
Capture/Replay: emit context setup for pre-MEC contexts only
Bug: angleproject:7805
Change-Id: I4ac770a303ac93a448c9b46bf8c4cd58900ddd54
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4068124
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
1005639f
|
2022-12-02T07:01:02
|
|
Roll Chromium from 076a539c2991 to 366b354bb4e3 (53 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/076a539c2991..366b354bb4e3
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/8d4ff27e86..fdc7c13983
* buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/ae1fbc4037..2dda3c5c1b
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/a870c3d506..c1f7bc4f73
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..550c7afb52
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0922aaade1..ec1882fbc2
* third_party/fuchsia-sdk/sdk: version:10.20221201.2.1..version:10.20221201.3.1
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/83f8830a1d..65848dccd6
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/bf34997e15..b187174108
No update to Clang.
Bug: None
Tbr: cnorthrop@google.com
Change-Id: Ibdcbe584a94101f4c01b4ec90816a4f9dacf9408
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4075485
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
7e1ed5f1
|
2022-12-02T02:32:40
|
|
Revert "Vulkan: Enable async pipeline cache sync by default"
This reverts commit c7414946b84410bfcc8705759a902577c13d9fc4.
Reason for revert: b/260752276
Original change's description:
> Vulkan: Enable async pipeline cache sync by default
>
> Bug: b/246683126
> Change-Id: I593650364250f8802e9f546ab9957cf1c30e596a
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4031487
> Reviewed-by: Cody Northrop <cnorthrop@google.com>
> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Bug: b/246683126
Bug: b/260752276
Change-Id: I0ebac7e46e213790ac39e4124e89feda76551011
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4074765
Commit-Queue: Solti Ho <solti@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
80f030c1
|
2022-12-02T02:35:39
|
|
Roll Chromium from 42032d061a0a to 076a539c2991 (1718 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/42032d061a0a..076a539c2991
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/0efbd89bb5..961774e175
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/f2fe6dda1e..8d4ff27e86
* buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/c2e10323cc..ae1fbc4037
* buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/9231726c61..44d54baf42
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/542427f5ea..a870c3d506
* third_party/android_build_tools/aapt2: -QrdsGmvVhHeoRc5wKCnU2LXEjk1s0ocheitXWf5dhYC..cbNG7g8Sinh-lsT8hWsU-RyXqLT_uh4jIb1fjCdhrzIC
* third_party/android_build_tools/lint: PwX3e0EPv-j0ip-tcNNfhy3YcFHle4vxKVo-IbTCtZYC..9qiQ29AZRZapFWdlmgjd22gc1RxJ1oXZKPAsTq_3G88C
* third_party/android_build_tools/manifest_merger: 1_tPfyswsXgfbNegip6nTy55E2ASlhsRqA2sKhUo01YC..X4l8RIBEAF108FpSEWRF7UHqq-kY8T3ibSsObGU5u3UC
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..550c7afb52
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fc04ff1628..0922aaade1
* third_party/fuchsia-sdk/sdk: version:10.20221128.3.1..version:10.20221201.2.1
* third_party/r8: WqQE6kGnQ571Jtmn-m9LD7Qnd7nOi46mty5n-fZznKQC..NhcNRQ45-HIXvuu5CxFmUsIbvW9Or8_tkceuhByYJywC
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/a7fe07b40d..83f8830a1d
* tools/luci-go: git_revision:f8f64a8c560d2bf68a3ad1137979d17cffb36d30..git_revision:4814885a05fd7cc925933f614dc6fcc58bc83e4b
* tools/luci-go: git_revision:f8f64a8c560d2bf68a3ad1137979d17cffb36d30..git_revision:4814885a05fd7cc925933f614dc6fcc58bc83e4b
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/3750e10528..ea9a7de758
* tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/797585e74b..5d2efcc932
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/0d9e5429c6..bf34997e15
Clang version changed llvmorg-16-init-10736-ged9638c4:llvmorg-16-init-12251-g87d0ff91
Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/a7fe07b40dfb6171c4cae3a46c0e0ca2172519e1..83f8830a1d904629e02b8895acccdc98f4e6b3d5/scripts/update.py
Bug: angleproject:6430
Tbr: cnorthrop@google.com
Change-Id: Ibf75c4d5060d770b7954da32e7a416e7e1aa2abe
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4074766
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
eafdf206
|
2022-12-01T12:33:11
|
|
Reset thread context during threadCleanup
Once thread cleanup is complete reset its mContext
member to nullptr. Running CTS tests in batches sometimes
exposes a bug where Thread::mContext is accessed after
Display::threadCleanup is complete.
Bug: angleproject:6723
Bug: angleproject:6798
Change-Id: Ie252954e60b5d4565697095939fd19d002dfccf3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4072208
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
4eed6b9b
|
2022-12-01T16:42:54
|
|
ubsan: Ignore errors from SwiftShader
More errors exposed by the bots when trying to land this roll:
https://chromium-review.googlesource.com/c/angle/angle/+/4070947
Test: angle_deqp_gles31_tests --use-angle=swiftshader
Bug: angleproject:7852
Change-Id: I38e669817382ee17c403fbfd54ab2282a3f78cf0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4072219
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
9bd9c1c2
|
2022-11-03T11:49:33
|
|
Workaround for AMD [[raster_order_group()]] bug
Metal [[raster_order_group()]] does not work for read_write textures on
AMD when the render pass doesn't have a color attachment on slot 0. To
work around this we attach one of the PLS textures to
GL_COLOR_ATTACHMENT0, if there isn't one already.
Bug: angleproject:7792
Bug: angleproject:7803
Bug: angleproject:7818
Change-Id: I7567ed28ed30c7e3ca23dc52778ed90f2fdff965
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4004529
Reviewed-by: Kyle Piddington <kpiddington@apple.com>
Commit-Queue: Chris Dalton <chris@rive.app>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
|
|
c904cba3
|
2022-11-30T19:22:48
|
|
android: Remove uncompress_shared_libraries
The Android build assumes uncompress_shared_libraries==true, so this
change should have no effect on the build while also allowing to remove
the variable from chromium-src.
Bug: chromium:1337134
Change-Id: I4b0d15b41b0ee5199f11e7534f7681cc0746df82
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4067322
Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>
|
|
aa7bb157
|
2022-12-01T00:33:31
|
|
Include volk.h from a relative location
Previously it was always included from third_party/volk/
This change makes it easier to use an externally provided copy of
volk.
Bug: b/260093525
Change-Id: I60bdb0ee4f6f6293fce5198af438e9af8d84421f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4066872
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
938f4372
|
2022-11-30T15:30:23
|
|
Move trace_event into anglebase
This originates from Chromium's base/trace_event/ so it doesn't need to
be under a third-party folder.
Bug: b/260093525
Change-Id: Iab7a40569b6c1f91454f099c07bf51e3ce4b65df
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4068342
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
c991eb22
|
2022-12-01T14:05:07
|
|
Move the anglebase folder up a level
This code originates from Chromium's base/ directory so it doesn't have
to be under a third-party folder.
Bug: b/260093525
Change-Id: I0bf6950095c685f36c5c237093980a64cf6e74f0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4068339
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Nicolas Capens <nicolascapens@google.com>
|
|
|
e4054a3f
|
2022-12-01T16:51:48
|
|
Add ANGLE experimental bots for Win Intel
Targeting Optiplex 7080.
Not running any tests for now.
Bug: chromium:1349828
Change-Id: I6e3973c684cbcbefd283f314b2a48bf33f8ce6da
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4071104
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
a58ea0ac
|
2022-12-01T09:32:44
|
|
ubsan: Ignore alignment errors
We are using unaligned allocations in memory pools to service
ANGLE's SecondaryCommandBuffer implementation. Until this is
fixed, ignore the ubsan errors.
We also are seeing errors from zlib, so including that in the
ignore until it is fixed upstream.
Test: angle_deqp_gles31_tests
Bug: angleproject:7852
Change-Id: Iaa34f12b7da7fa55558ba9ab0eace8fccf081653
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4070985
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Auto-Submit: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
0d7a4884
|
2022-11-30T14:33:12
|
|
Use string_view to compute custom string hash
C++17 supports std::hash<string_view>, which can be used to compute a
hash for the custom sh::TString class.
This eliminates the dependency on smhasher.
Bug: b/260426695
Change-Id: I2f4044fea4e44396a5d798436ec02da22a37bed7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4066987
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Nicolas Capens <nicolascapens@google.com>
|
|
|
022b52f5
|
2022-11-30T14:58:01
|
|
Include xxhash.h from a relative location
Previously it was always included from src/common/third_party/xxhash/
This change makes it easier to use an externally provided copy of
xxhash.
Bug: b/260093525
Change-Id: I27c375c58ac3776a15d5d68483c235ece235b059
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4066278
Commit-Queue: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
76ef4207
|
2022-12-01T10:17:56
|
|
Remove trace tests from win-intel.
This test configuration is flaky due to non-deterministic
rendering. It's also running a very old configuration. We can
revisit turning this on when our test machines are updated.
Bug: angleproject:7708
Change-Id: I486607f673e49123b3b77e02b335049eb5ab34ff
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4070224
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Auto-Submit: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
8ee1b89f
|
2022-11-04T13:10:37
|
|
Refactor pixel local storage options
The various different PLS options were getting scattered and unruly. We
are also in need of more backend-specific PLS options that would be
difficult to add as-is. This CL refactors them into a single
"ShPixelLocalStorageOptions" struct that gets initialized all in one
place, and shared between the compiler and the backends.
Bug: angleproject:7279
Change-Id: Ic58dccb8d1ba350a0b6cc5848ce15bd687e30fad
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4006715
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Chris Dalton <chris@rive.app>
|
|
|
a4db9477
|
2022-10-06T10:35:39
|
|
Implement pixel local storage with metal::read_write textures
Metal's programmable blending feature isn't available on non-Apple
Silicon, so on these devices we have to polyfill pixel local storage
using read_write textures, which can also be coherent if
raster_order_groups are supported.
This change leverages the existing PLS transformation to images, and
implements just enough shader image functionality in Metal to support
the pixel local storage usecase. Missing shader image features are
marked with UNIMPLEMENTED().
Bug: angleproject:7279
Bug: angleproject:7792
Bug: angleproject:7794
Bug: angleproject:7797
Bug: angleproject:7803
Change-Id: Ia96a714693d352d57351a1bae4f45437dde000e4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3993363
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Quyen Le <lehoangquyen@chromium.org>
Commit-Queue: Chris Dalton <chris@rive.app>
Reviewed-by: Kyle Piddington <kpiddington@apple.com>
|
|
|
fa37af38
|
2022-07-12T22:47:22
|
|
Translator: Support SSO's built-in redeclaration
EXT_separate_shader_objects requires that gl_Position and gl_PointSize
be redeclared in the vertex shader. This is not adopted by GLES3.2, but
is nevertheless required to be supported if the shader enables this
extension explicitly.
Bug: angleproject:6590
Change-Id: I3428851ff9f00fb63573e4322bb62fe04bf0a095
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3757918
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
db67df60
|
2022-10-31T13:01:25
|
|
Metal texture cleanups
* Record the texture arguments' location in main() instead of inferring
their position based on an assumption that the texture pipeline comes
last.
* Fix one spot that was using mMainSamplerIndex that should have been
using mMainTextureIndex.
Bug: angleproject:7279
Change-Id: I53af0f016e52217c53d98b560011ffe958746cda
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3993362
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Chris Dalton <chris@rive.app>
|
|
|
2ecb3217
|
2022-11-28T15:24:39
|
|
Vulkan: Turn CPU throttling into fail safe
CPU throttling is moved back to after queue present instead of before.
Doing it before was a mistake, as the app had already recorded the
command buffers, there was no point in delaying its submission.
Proper throttling would have been moving the wait from after recording
commands (before present of frame i+2) to before recording (after
present of frame i+1). However, throttling is the responsibility of the
app and this change triggers throttling one frame later (after present
of frame i+2) as a fail safe.
Currently, CPU throttling is relied upon for acquire semaphore
recycling. If the two are untangled, CPU throttling can be removed.
CPU throttling can also be trivially weakened by increasing
kSwapHistorySize (currently 2).
Bug: angleproject:7268
Change-Id: Ib7a8be6f8e72c6b8589d4e8b5de7ceaf6a28bb8e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4060454
Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
|
31c40936
|
2022-11-25T12:28:27
|
|
Vulkan: Rework present semaphore recycling
Present semaphores and old swapchains are now associated with a fence
for clean up. The fence is the one coming from the _next_ acquire of
the same image index.
See doc/PresentSemaphores.md for more details.
Bug: angleproject:7847
Change-Id: I16891ccf6df7ac39d8b17328aac35afc422eede0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4058286
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
|
90b4541c
|
2022-11-28T11:39:24
|
|
Vulkan: Pass signal semaphore by value to async thread
Otherwise the signal semaphore is pointing to whatever was passed in
from the main thread. Currently, this is ok because:
- For external semaphores, ensureNoPendingWork is called
- For surfaces, there's a fixed buffer of semaphores
However, an upcoming change passes a semaphore specified on the stack,
and the thread should not be referencing it.
Bug: angleproject:7847
Change-Id: I9a823214bde59b9d7ff23313694c1749a76e6b8e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4060453
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
|
|
|
7f4caaf5
|
2022-11-23T15:40:53
|
|
Vulkan: Fix VulkanPerformanceCounterTest.SubmittingOutsideCom
VulkanPerformanceCounterTest.SubmittingOutsideCommandBufferDoesNotCollectRenderPassGarbage
depends on the implementation detail on how we flush and submit
commands. The recent change crrev.com/c/4038095 fixes one issue that we
are now having one less submission on pixel 6 device. This CL adjust the
test to account for that.
This CL also changed to set mHasDeferredFlush to true only when there is
a started renderpass upon FBO bind.
This CL also opt in swiftshader into preferSubmitAtFBOBoundary feature
for test coverage and ease of debugging since ARM GPU (which enables
this flag) is not been tested on CI.
Bug: b/255414841
Change-Id: I295cec33a8ca257a5d5a98604b8c4c0c29e97cdf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4054101
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
2805e164
|
2022-11-29T15:16:42
|
|
Fix EGLImage related race condition crash
Bug: chromium:1383195
Change-Id: Ibd74126f19674dad9425d2c8f5b3a217cfd590e4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4062912
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
|
|
1434697f
|
2022-11-23T14:47:38
|
|
Add a vk feature flag to only enable precision match fixer on IMG
According to
https://gitlab.khronos.org/vulkan/vulkan/-/merge_requests/5273,
RelaxedPrecision does not need to match in the interface matching
rules. However, removing the precision match is causing triangle
clipping issues on IMG hardware. This change adds a feature
flag to only run the code path that applies precision match in
SpirV if the hardware is IMG.
This is a follow-up change to https://crrev.com/c/4049421.
Instead of adding back the code path that handles varying
precision mismatch for every hardware, only enabling the code
path if the vendor is IMG.
Test:
On Pixel6:
$ adb shell setprop debug.angle.feature_overrides_enabled
varyingsRequireMatchingPrecisionInSpirv
$ out/AndroidDebug/angle_end2end_tests
--gtest_filter="GLSLTest_ES3.MismatchPrecision*" --verbose
Bug: angleproject:7488
Change-Id: Ia0155f14d523195df2f47b852ed6642918270e2a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4054100
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
2de99d47
|
2022-11-17T12:19:35
|
|
Reset instance/device extensions in RendererVk::onDestroy()
RendererVk::initialize() adds a nullptr to the end of
RendererVk::mEnabledInstanceExtensions (presumably to ensure the
VK implementation crashes if it tries to read past?). If
RendererVk::onDestroy() fails to clear this nullptr, it can lead
to a crash when sorting the extension lists when the renderer
is re-initialized the second time.
Bug: b/249457381
Test: cvd start --gpu_mode=guest_swiftshader
Test: EGLDisplayTest.InitalizeTerminateInitalize/ES3_Vulkan_NoFixture
Change-Id: Ib24af11024cad6b28284f3a75cc862c48abec258
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4035646
Commit-Queue: Jason Macnak <natsu@google.com>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
b301b822
|
2022-11-07T09:37:14
|
|
Capture/Replay: emit context setup for pre-MEC contexts only
When a context is made current for the first time it is added to
the shared context set. If this happens after the mid execution
capture has started, then the call to the context setup function
is created, but the according function implementations was not
emitted leading to compilation failure of the so created trace.
Since a context that was never current doesn't actually have any
setup that needs to be done when starting a MEC replay. Hence,
there is no need to emit the calls fot SetupReplayContextXX.
So track which context where actually in the shared context set
when MEC started, and only emit the according calls to the setup
functions.
Bug: angleproject:7805
Change-Id: I83f8714733ead5c0d71560013c360b5671f0822a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4008199
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
|
|
|
e691bb4f
|
2022-11-29T07:02:21
|
|
Roll Chromium from a198ee76f3e6 to 42032d061a0a (1195 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/a198ee76f3e6..42032d061a0a
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/31a9827c1c..0efbd89bb5
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/9ca2fd2711..f2fe6dda1e
* buildtools/linux64: git_revision:1c4151ff5c1d6fbf7fa800b8d4bb34d3abc03a41..git_revision:70d6c60823c0233a0f35eccc25b2b640d2980bdc
* buildtools/mac: git_revision:1c4151ff5c1d6fbf7fa800b8d4bb34d3abc03a41..git_revision:70d6c60823c0233a0f35eccc25b2b640d2980bdc
* buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/cd0a050474..c2e10323cc
* buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/1a32724f72..9231726c61
* buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/5870472fdd..fd49ee4ee9
* buildtools/win: git_revision:1c4151ff5c1d6fbf7fa800b8d4bb34d3abc03a41..git_revision:70d6c60823c0233a0f35eccc25b2b640d2980bdc
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/e0c66183a0..542427f5ea
* third_party/Python-Markdown: https://chromium.googlesource.com/chromium/src/third_party/Python-Markdown/+log/4838827d12..0f44735461
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/ffbead8e41..9181906668
* third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/216373bd26..1e254c17ed
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..41982a4a32
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/73a26246e5..fc04ff1628
* third_party/fuchsia-sdk/sdk: version:10.20221123.1.1..version:10.20221128.3.1
* third_party/r8: -zz1KNSGZYTw6zwg-o6R2OWhvHaE2AA9nrCpsrR8psYC..WqQE6kGnQ571Jtmn-m9LD7Qnd7nOi46mty5n-fZznKQC
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/4f8bb52f0a..a7fe07b40d
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/5d8bcccd51..3750e10528
* tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/4a3820026f..797585e74b
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/cd8457b738..0d9e5429c6
No update to Clang.
Bug: None
Tbr: cnorthrop@google.com
Change-Id: I7cf5b82f29b4ae8541bac172c34f40172cdba45f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4063299
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
000b3bfa
|
2022-11-28T15:06:06
|
|
Vulkan: Init mLast***Serials from CommandQueue::initialize
Exposed by a recent test from Jason crrev.com/cl/4035646, If RendererVk
gets re-initialized, we can't rely on CommandQueue's constructor to do
initalization. We have to manually initialize mLastSubmittedSerials to 0
since destroy will set it to Infinite.
Bug: b/249457381
Change-Id: I90e654981fb821324cbfb177712f604b67ccc70c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4063046
Reviewed-by: Jason Macnak <natsu@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
b00fa5e5
|
2022-11-23T12:10:47
|
|
Vulkan: Pipeline graph dump vs pipeline libraries
The pipeline graph dump code is now made aware of partial pipelines.
Vertex input and fragment output pipelines are also output. As a
collateral, UtilsVk pipelines are also included.
Bug: angleproject:7369
Change-Id: I327fbd07b83ae42d27766847d70637ada04d86cd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4051623
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
|
35d1736f
|
2022-11-28T09:27:06
|
|
Update enabled instance extenion handling
- Null terminating the instance extensions at the end of
initialize to potentially avoid having the nullptr interact
poorly with other initialization code that scans through the
enabled instance extensions.
- Ensure the enabled instance extension sort happens after all
desired instance extensions have been added.
Bug: b/249457381
Test: cvd start --gpu_mode=guest_swiftshader
Change-Id: I2a479065444ffdfd97ecbf281fe6a777e22d584c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4060238
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jason Macnak <natsu@google.com>
|
|
|
86a194c3
|
2022-11-24T00:00:00
|
|
Fix expected texture target for 3D blocks
ASTC 3D blocks are supported only for TEXTURE_3D targets.
Bug: angleproject:3675
Change-Id: I5fa2ee87666bd69272419dc1d604348f7376aa46
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4055649
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
3cfdb191
|
2022-11-28T14:42:34
|
|
Change ninja path to third_party/ninja/ninja
It also removes `.exe` extension as it seems not necessary.
Bug: chromium:1338373
Change-Id: Ic94426771d56c54b8c03627cdff6dccccec1a267
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4060128
Auto-Submit: Junji Watanabe <jwata@google.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
|
|
|
35247a4d
|
2022-11-23T17:19:19
|
|
Android: Remove java_api_finder from Android.bp
No longer used in Android.
Mirrors the following change:
https://android-review.git.corp.google.com/c/platform/external/angle/+/2316258
Test: None
Bug: b/260268418
Change-Id: Idb6c31b9d31a17108979f2ecca0d28cef60a11fb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4053263
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Auto-Submit: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
|
678cce80
|
2022-11-24T07:00:04
|
|
Roll Chromium from 9f3d33d253ac to a198ee76f3e6 (392 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/9f3d33d253ac..a198ee76f3e6
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/88913de942..31a9827c1c
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/3c8fef071e..9ca2fd2711
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/7b5c1435de..e0c66183a0
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..07489847d9
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6fde0fbe92..73a26246e5
* third_party/fuchsia-sdk/sdk: version:10.20221122.0.1..version:10.20221123.1.1
* third_party/r8: 6IAjJKfUwjFSLKQ31fxSTeXHZXcsGeoUlMKBcirZTbUC..-zz1KNSGZYTw6zwg-o6R2OWhvHaE2AA9nrCpsrR8psYC
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/842cb67d55..5d8bcccd51
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/7f2b5fe8eb..cd8457b738
No update to Clang.
Bug: None
Tbr: ianelliott@google.com
Change-Id: Ib37e7ec82be185dadb5f371a5e2c3d640d7775e7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4053671
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
541cdcbf
|
2022-11-23T15:44:53
|
|
Fix flakiness in EGL surface multithread tests.
This moves the surface acquisition to inside the scoped lock.
This should fix the flakiness we see on the linux-tsan-test
bot.
Bug: angleproject:7791
Change-Id: Idcc0f3c9d6e172b446f10c32bf6fb911fd887658
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4051622
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Auto-Submit: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
e9e0da6a
|
2022-11-23T19:53:46
|
|
Roll VK-GL-CTS from 2db7b0a1c310 to 9d22258ed442 (5 revisions)
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/2db7b0a1c310..9d22258ed442
2022-11-21 quic_mnetsch@quicinc.com Merge vk-gl-cts/dev/VK_EXT_mutable_descriptor_type into vk-gl-cts/main
2022-11-21 quic_mnetsch@quicinc.com Merge "Merge vk-gl-cts/dev/VK_EXT_descriptor_buffer into vk-gl-cts/main" into main
2022-11-18 quic_mnetsch@quicinc.com Update json files for postmortem features
2022-11-18 quic_mnetsch@quicinc.com Merge vk-gl-cts/dev/VK_EXT_device_address_binding_report into vk-gl-cts/main
2022-11-18 quic_mnetsch@quicinc.com Merge vk-gl-cts/dev/VK_EXT_device_fault into vk-gl-cts/main
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: ianelliott@google.com
Change-Id: I449b3a3e46c83084544712efe53fa608fd4c6857
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4052764
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
d5ce0b80
|
2022-11-23T12:16:46
|
|
Skip crashed test on Pixel6 due to a bug in precision matching fixer
We recently need to add back the code that
does spriv precision match fixer to help IMG
fix a triangle clipping issue. However, the
code added back is causing Pixel 6 to crash on
this test:
dEQP-GLES31.functional.shaders.linkage.es31.tessellation.varying.rules.internal_different_precision
We are skipping this test for now until we
add a feature to enable the code path on IMG only.
Bug: angleproject:7488
Change-Id: I0fb2738d2faabe2ca78077e0383af3d100c75b03
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4053100
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
|
|
|
71ead7b4
|
2022-11-20T15:56:42
|
|
Tests: Add Diablo Immortal trace
Test: angle_trace_tests --gtest_filter="*diablo_immortal*"
Bug: angleproject:7402
Bug: angleproject:7837
Change-Id: I7c7ccc0099707714213564740f58f04f7965a275
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4041134
Reviewed-by: Roman Lavrov <romanl@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
6458178e
|
2022-11-18T11:39:16
|
|
Vulkan: Clean up flushCommandsAndEndRenderPass APIs
ContextVk::flushCommandsAndEndRenderPassWithoutQueueSubmit is calling
flushCommandsAndEndRenderPassImpl(QueueSubmitType::SkipQueueSubmit).
This is a bit odd and creates confusion and trouble with future CLs.
This CL removes QueueSubmitType and straight up the submission code and
removes some function that was doing little but to call another
function.
Bug: b/255414841
Change-Id: I0ed2122a98b0fc5b819fd331173bf6945d23ff8a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4038095
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
7dd8478e
|
2022-11-17T10:11:02
|
|
Vulkan: Make ResourceUse::serial an FastVector of Serials
In preparation for per context queue serial, this CL makes
ResourceUse::serial a FastVector of Serial. Right now we still limited
to one serial index so that it still work the same way as before. This
CL adds necessary data type and change the function names to reflect
that tracking GPU progress needs a ResourceUse object instead of a
single Serial number.
Bug: b/255414841
Change-Id: Ic60cdf5ec8da45d1821f65a55947f5c553f65737
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4034548
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
|
0e12695c
|
2022-11-23T08:31:43
|
|
Suppress VUID-VkGraphicsPipelineCreateInfo-renderPass-06040
Bug: angleproject:7843
Change-Id: I013dd1d2942c7b9d340ae4e3c4124b592dc9b94b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4049765
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Auto-Submit: Ian Elliott <ianelliott@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
6384f76b
|
2022-11-16T21:47:04
|
|
Vulkan: Move PipelineCacheAccess to namespace vk
In preparation for a change that uses it in that namespace.
Bug: angleproject:7369
Change-Id: Icc75b8839d702fd3e6d3d00c1d8f81619cdd89cc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4031150
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
11de5157
|
2022-11-14T14:48:33
|
|
Capture/Replay: Reset Shaders
We've been resetting Programs correctly, but not Shaders. This hasn't
been a blocker so far, but it has been identified as a performance
problem for traces that compile mid-trace. We're not getting cache
hits because the persistent blob cache is not updated until a shader
is deleted.
Part of the challenge here is ShadersIDs and ProgramIDs share a
ResourceIDType, so separating them requires a bit more tracking.
To fix, start tracking which ShaderProgramIDs are actually
shaders and emit the correct glDelete* command.
Test: diablo_immortal MEC
Bug: angleproject:7823
Change-Id: I934f6eee243ab9681dca5fdebdad33ba31457cf5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4029226
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
5c301b52
|
2022-11-23T13:08:12
|
|
Roll Chromium from ab42c3da0f40 to 9f3d33d253ac (64 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/ab42c3da0f40..9f3d33d253ac
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC ianelliott@google.com,ynovikov@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/8961725eee..88913de942
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/1a716cbded..7b5c1435de
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..cce68bc50e
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2fc7e1ffd5..6fde0fbe92
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/4d7494f60c..842cb67d55
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/8ee02eacb5..7f2b5fe8eb
No update to Clang.
Bug: None
Tbr: ianelliott@google.com,ynovikov@google.com
Change-Id: I58d9e100bdf3eefded571e09f1c82e2ffc3efc1e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4050291
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
494640e5
|
2022-11-18T12:02:28
|
|
Capture/Replay: Make secondary contexts current during MEC
When replaying, the context is made current at the beginning of
the context setup function, and is still current when we hot the
validation point at the end of the setup function. When a context
is current is has a valid default framebuffer, and hence, during a
replay of the trace the context serialization will contain this
framebuffer. However, during MEC the secondary contexts were not made
current during capture, and hence they dind't have a default
framebuffer which resulted in a validation error.
Therefore, make the secondary contexts current when they are captured
during MEC to make sure we also capture the default framebuffer.
Bug: angleproject:7812
Change-Id: Iaccc4150e8a71a02286e772882fb150bef1d82a8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4037982
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
c03478e0
|
2022-11-23T07:00:14
|
|
Roll Chromium from 2e2c857c4980 to ab42c3da0f40 (572 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/2e2c857c4980..ab42c3da0f40
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/81415f1f5f..8961725eee
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/09154d65c3..3c8fef071e
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/3329b47db7..1a716cbded
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..cce68bc50e
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/30e3ce8b1c..2fc7e1ffd5
* third_party/fuchsia-sdk/sdk: version:10.20221121.3.1..version:10.20221122.0.1
* third_party/r8: zJXokrYtEiaa-jjRGetxUuWf3Zkv_G7Fvl5oCXkhBAsC..6IAjJKfUwjFSLKQ31fxSTeXHZXcsGeoUlMKBcirZTbUC
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/77843ad775..4f8bb52f0a
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/ed1991b2c6..4d7494f60c
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/1e02624893..8ee02eacb5
No update to Clang.
Bug: None
Tbr: ianelliott@google.com
Change-Id: I4b602888d7070f2927627cd0af688d7710c2a7e7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4050481
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
3db679eb
|
2022-11-22T10:37:31
|
|
Revert "Vulkan: Remove useRelaxedPrecision" and "Vulkan: remove SpirvVaryingPrecisionFixer"
This reverts commit cb618b3d42d9013c48b5aa233efc4d80a9c4efa4
and commit 427086a9c7612da7325cb36054859a929c3727d5
Reason for revert: IMG reported that they need to keep the
"precision qualifier matching" feature to make triangle clipping
work properly, because the clipping needs to to know the decoration
in vertex shader output in order to sort the data correctly for
clipping.
Original change's description:
> Vulkan: Remove useRelaxedPrecision
>
> Bug: angleproject:7488
> Change-Id: I30ca3e2740d8810a01615ca778eb072d77ad34d9
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3856658
> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Original change's description:
> Vulkan: remove SpirvVaryingPrecisionFixer
>
> Bug: angleproject:7488
> Change-Id: I957839bd8fbdf1cd849d5ed7e9edd65fd1a5f2cb
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3780874
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Bug: angleproject:7488
Change-Id: I90b584cbc549a663bca734a59d135a1d1d5bcbfc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4049421
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
27727e50
|
2022-11-21T00:00:00
|
|
Fix ProvokingVertex typos
Aligned the parameter name with the upstream specs
Moved ValidateProvokingVertexANGLE to validationESEXT.cpp
Bug: angleproject:2829
Change-Id: I820a90c20ef0a1873640c933b1de52526cac7e70
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4043701
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
|
b2f55ec3
|
2022-11-14T16:07:19
|
|
Vulkan: Add memory allocation/deallocation counter
* Added a counter to the renderer object to keep track of the
memory allocations and deallocations per allocation type.
* The counters are updated with the functions onMemoryAlloc() and
onMemoryDealloc(), which can be added next to the allocation or
deallocation point.
* Currently used for buffer memory and image memory.
* Removed some of the redundant arguments from vk_helper and
suballocation functions.
Bug: b/242641395
Change-Id: I58b38f619df7bef0ba5fa3373a8db5aed0ef142c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4014164
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
c5724a8d
|
2022-11-17T15:48:16
|
|
Vulkan: Retain mCurrentGraphicsPipeline if RP started
ContextVk::mCurrentGraphicsPipeline is created before renderpass
started. Right now we retain mCurrentGraphicsPipeline immediately. In
future CL of per context queue serial, renderpass will not have queue
serial until started, which means we can only retain pipeline object
after renderpass started. This CL moves the
mRenderPassCOmmands.retain(mCurrentGraphicsPipeline) call to renderpass
start time. This exposed a bug that ContextVk may have a dangling
mCurrentGraphicsPipeline pointer to an already destroyed object, if the
program has been destroyed. When ProgramExecutableVk::resetLayout()
calls ContextVk::onProgramExecutableReset () we early out because
executable no longer matches. This causes mCurrentGraphicsPipeline still
point to now deleted pipeline object. This CL fix this dangling pointer
bug by always clear mCurrentGraphicsPipeline to null in
ContextVk::onProgramExecutableReset() without checking if program
executable is the one gets reset.
Bug: b/255414841
Change-Id: I6d698c517d7a948b65c465eaaa59ea0bca24e2c8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4035107
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
|
|
|
fc1c8cd1
|
2022-11-01T00:00:00
|
|
Refactor validation of partial compressed texture uploads
Optimized ValidCompressedSubImageSize for valid usage
and simplified its control flow.
Fixed false negative validation when the replaced
image region does not fill the entire level but
nevertheless reaches the image boundaries.
Updated InternalFormat::getCompressedImageMinBlocks
to use IsPVRTC1Format helper function.
Fixed InternalFormat::computeCompressedImageSize for
3D compressed texture blocks.
Removed redundant checks from ValidateES3TexImageParametersBase.
Optimized IsPVRTC1Format helper function to be a constexpr.
Adjusted tests, added suppressions for Intel and Adreno.
Bug: angleproject:7473
Change-Id: I6fadce949785a35e2706b06eeb00e878aa3710a7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4037671
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
15c8a055
|
2022-11-22T13:31:39
|
|
GL: Only reset transform feedback varyings when necessary.
ProgramGL sychronizes all state before linking. This means setting the
transform feedback varyings to 0 when transform feedback is not used.
Skip this call to synchronize transform feedback varyings when it will
have no effect.
This is a speculative fix for crashes on IMG drivers. Some of the logs
mention glTransformFeedbackVaryings reading invalid memory.
Bug: chromium:1322820
Change-Id: Ib4ba9c6ea6f9ab8accb82f243472c4d4443b7fd5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4049420
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
|
|
|
37d6a9db
|
2022-11-18T17:42:21
|
|
Support versioned library names
Previously ANGLE_GLESV2_LIBRARY_NAME was expected to be the library name
without extension, and on Linux .so would be appended. This didn't allow
for building ANGLE as libEGL.so.1 and libGLESv2.so.2 as is common.
This change checks if the library name already contains a dot, and if so
doesn't append the platform specific extension suffix.
Bug: b/259282560
Change-Id: I81cda218180ae7fe6321e1ac7e4eff7257bf1493
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4038450
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Auto-Submit: Nicolas Capens <nicolascapens@google.com>
|
|
c86f0988
|
2022-11-22T14:34:16
|
|
Cleanup: Use XAllocSizeHints, move to helper.
Dynamic allocation (XAllocSizeHints) is recommended due to struct
potentially changing in future. Also move the repated code block
to a helper function.
Bug: angleproject:7840
Change-Id: I1e91c7adc0e36e31a385263f5d1a556520ece45c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4048661
Auto-Submit: Roman Lavrov <romanl@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
68b47e58
|
2022-11-16T10:46:59
|
|
Vulkan: Initial support for VK_EXT_graphics_pipeline_library
When available, this change uses VK_EXT_graphics_pipeline_library to
create pipelines. Currently, it is only used when
graphicsPipelineLibraryFastLinking is available. This restricts the use
of this extension to devices where monolithic pipelines are not any more
performant than linked libraries.
A future change adds support for other implementations by providing
async pipeline creation.
Bug: angleproject:7369
Change-Id: I1e3b7ac4aa56e75c7d6f4d0d5ea91cb0b862e581
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4031489
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Steven Noonan <steven@valvesoftware.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
1f69f580
|
2022-11-18T14:33:20
|
|
Perf tests: Add --fixed-test-time-with-warmup
Warmup trials combined with fixed-test-time was broken
recently. It was already fragile and only worked when
parameters were provided in the right order.
On Android we're relying on this combination to get steady
results without hitting thermal limits.
To address this:
- Add a new parameter that encapsulates the combination
- ASSERT that flags aren't provided in unsupported combinations
Test: python3 restricted_trace_perf.py --fixedtime 10
Bug: angleproject:7755
Change-Id: I56fce1f65d4f0538e623951163a9c8736cb3fb03
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4027282
Reviewed-by: Roman Lavrov <romanl@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
317870f9
|
2022-03-08T14:47:14
|
|
Reland "util/X11Window: Set PMinSize and PMaxSize hints."
This is a reland of commit a78eca2cab5f7826c1719e47fca229086ec06947
Revert https://crrev.com/c/3661210 refers to cropping on SwS bots which might be due to another X11 related issue I recently fixed (https://crrev.com/c/3979168)
Lack of min width/height is triggering a swapchain recreation with smaller extents due to window being resized by the WM:
https://anglebug.com/7840#c2
Also, capturing screenshots past the first frame (--screenshot-frame=2) results in partial screenshots.
Original change's description:
> util/X11Window: Set PMinSize and PMaxSize hints.
>
> Before this patch replay windows were down-sized to match the default
> screen size in case their extent was greater than the screen size.
>
> Setting a PMinSize on XSizeHints resolves the issue on modern window
> managers. Tested with GNOME Shell 41.3 with both native X11 and Wayland
> (over XWayland) backends.
> Setting PMaxSize was also requried to pass the
> BlitFramebufferANGLETest tests.
>
> This fixes retracing with correct extents and resolves a VVL performance
> warning.
>
> Bug: angleproject:6808
> Bug: angleproject:7083
> Change-Id: I00ee149ec02efe08c5801e4231913049d31e262b
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3507514
> Reviewed-by: Cody Northrop <cnorthrop@google.com>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Bug: angleproject:6808
Bug: angleproject:7083
Bug: angleproject:7840
Change-Id: Ide540ecf55c2c0f39635f2b6b0688d7c2ddffc0b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4048025
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Roman Lavrov <romanl@google.com>
|
|
|
202fcb8d
|
2022-11-21T15:05:13
|
|
TraceTest: Route EGLSync entry points through WGL
Test: diablo_immortal trace
Bug: angleproject:7402
Bug: angleproject:7839
Change-Id: I8897337bac38cb1923e58a9503de01454766158d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4044865
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
72e2ce69
|
2022-11-22T10:01:36
|
|
Roll vulkan-deps from a3f4f653c783 to ca8ca2aba961 (7 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/a3f4f653c783..ca8ca2aba961
Changed dependencies:
* spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/edd66a2fc9..c77b09b57c
* vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/974db1cede..b092b2fccc
* vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/6c7b2db415..3a092fe869
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/fc1c628605..7a9d51a51c
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: ianelliott@google.com
Change-Id: Id26b716a65cf697068114f5c1e75367b069c9b10
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4046941
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
12fa46f0
|
2022-11-22T07:00:52
|
|
Roll Chromium from 26b47bd446e8 to 2e2c857c4980 (530 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/26b47bd446e8..2e2c857c4980
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/bd893617b2..81415f1f5f
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/d5ad5f5098..3329b47db7
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..c996ebbd3d
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d06e475934..30e3ce8b1c
* third_party/fuchsia-sdk/sdk: version:10.20221120.3.1..version:10.20221121.3.1
* third_party/r8: vqsrb5_6fg9u-aSAqrcJiG7q2GOG66_39vdYTKgHmHgC..zJXokrYtEiaa-jjRGetxUuWf3Zkv_G7Fvl5oCXkhBAsC
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/ed5ed0ecab..77843ad775
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/124c1e7294..ed1991b2c6
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/468419086d..1e02624893
Clang version changed llvmorg-16-init-10467-g1239d37b:llvmorg-16-init-10736-ged9638c4
Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/ed5ed0ecabbf9b12b336a01a70f64aedf1a02a09..77843ad77570e76003c802390694598501abc6b8/scripts/update.py
Bug: None
Tbr: ianelliott@google.com
Change-Id: Idb3489ac27cc8558d9bb9b1b5c9d92b9f579fdcc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4044052
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
356b2a59
|
2022-11-18T18:50:03
|
|
Roll VK-GL-CTS from c4fe10a0c86d to 2db7b0a1c310 (7 revisions)
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/c4fe10a0c86d..2db7b0a1c310
2022-11-18 tapani.palli@intel.com Fix for the string query tests on desktop GL
2022-11-18 aitor@lunarg.com Add tests for out-param aliasing against other variables
2022-11-18 cturner@igalia.com Fix a typo setupVertexInputStete -> setupVertexInputState
2022-11-18 rgarcia@igalia.com Improve failure error messages in format_feature_flags2 tests
2022-11-18 amber@igalia.com Add tests for linearly tiled images
2022-11-17 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkan-cts-1.3.4 into vk-gl-cts/main
2022-11-16 ziga@lunarg.com Merge vk-gl-cts/dev/VK_EXT_pipeline_protected_access into vk-gl-cts/main
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: jonahr@google.com
Change-Id: Ia91e36411440ba5fe572d0971b54ae6857bbeb9c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4037817
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
|
|
|
f37a32f0
|
2022-11-14T14:11:06
|
|
Remove DisplayGbm and SurfaceGbm.
The Gbm classes were used to emulate WindowSurfaces on ChromeOS for
testing. These emulated features are not used in any shipping
configuration and cause issues because ANGLE opens drm devices
uneccessarily.
Bug: chromium:1344962
Change-Id: If564e40744f7825035bbbd63c141b154c534ed72
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4023096
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Brian Ho <hob@chromium.org>
|
|
|
55d46ffa
|
2022-11-21T10:01:04
|
|
Roll vulkan-deps from eb108f5f3b15 to a3f4f653c783 (11 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/eb108f5f3b15..a3f4f653c783
Changed dependencies:
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/1a7f71afb4..46ca66e699
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/38f7ab2634..fc1c628605
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: jonahr@google.com
Change-Id: Icd07184c48675986536dabca10945299d03b2f82
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4041635
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
cbc75633
|
2022-11-21T07:00:13
|
|
Roll Chromium from 1f4a045ca0a4 to 26b47bd446e8 (645 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/1f4a045ca0a4..26b47bd446e8
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/dc2384c048..bd893617b2
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/a9bbf9d24e..d5ad5f5098
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..b898eb3e06
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1f67d5573f..d06e475934
* third_party/fuchsia-sdk/sdk: version:10.20221117.0.1..version:10.20221120.3.1
* third_party/r8: SRv8kr_t534yPmvzQnKEBqgw_lidewzTdKnAKoWYkz0C..vqsrb5_6fg9u-aSAqrcJiG7q2GOG66_39vdYTKgHmHgC
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/d21aa5eb7e..ed5ed0ecab
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/ff50c9b60c..124c1e7294
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/d25dda6c4f..468419086d
No update to Clang.
Bug: None
Tbr: jonahr@google.com
Change-Id: Ia374a5814d6d9c2334dfb5fd8253fe7bd2fed86e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4041630
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
0c0bbcf5
|
2022-11-18T22:18:55
|
|
Revert "Vulkan: Only allocate default attribute if needed"
This reverts commit 85c98a92bb763452133bd7b4580d80625bb2c75d.
Reason for revert: This caused regression on pixel 6, https://ci.chromium.org/ui/p/angle/builders/ci/android-arm64-exp-test/1969/overview
Original change's description:
> Vulkan: Only allocate default attribute if needed
>
> mDirtyDefaultAttribsMask has all bits set when starts.
> ContextVk::handleDirtyGraphicsDefaultAttribs() is looping all dirty bits
> and try to allocate buffer for it, which means we are looping 16
> times when app starts. This CL changes to allocate a buffer only if used
> by program.
>
> Bug: b/258862506
> Change-Id: I2f0a75d1fe141c9ac3101088fdc4ce4f60b0c4ee
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4024544
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
> Commit-Queue: Charlie Lao <cclao@google.com>
Bug: b/258862506
Change-Id: Iff7d9c6d605613773f0b91a5539cefd6da6454eb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4038449
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Charlie Lao <cclao@google.com>
Auto-Submit: Charlie Lao <cclao@google.com>
|
|
|
3857752d
|
2022-11-18T14:35:42
|
|
Tests: Fix parameter parsing with partial matches
New parameter parsing code needs a small tweak to handle
partial flag matches.
For instance, a new flag being added would trigger as if an
old one had been provided:
new: --fixed-test-time-with-warmup
old: --fixed-test-time
And if equals notations were being used:
--fixed-test-time-with-warmup=value
the code before this CL will treat the entire thing as
--fixed-test-time and attempt to consume the next argument
as value
Bug: angleproject:7755
Change-Id: I57eae2847053d664338d40b0191d5223ddd95852
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4038494
Reviewed-by: Roman Lavrov <romanl@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
8378032e
|
2022-11-15T11:47:55
|
|
Vulkan: Remove get API for mLastCompletedQueueSerial
In preparation for per context queue serial, this CL makes
mLastSubmittedQueueSerial and mLastCompletedQueueSerial private to
CommandQueue. Before this CL, we have a get function to return the last
submitted serial and last completed serial and passing these serials
around. This works because the serial is a single uint64_t number. With
per context queue serial, this will be an array of serials and there is
potential risk associated with access it from different threads. This CL
makes these serials private to CommandQueue and when you want to know if
GPU is completed with resource, you ask RendererVk/CommandQueue
directly. This way we can ensure they have thread safe access in the
CommandQueue (no lock is necessary, but all access will be restricted to
one class).
Bug: b/255414841
Change-Id: Ica565decce4a80588e0b447e179a2b634b55d7c3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4021676
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>
|