kc3-lang/angle

Log

Author Commit Date CI Message
angle-autoroll 28d759cd 2025-07-16T07:09:53 Roll Chromium from a9fc4ae13759 to 3f250af9a632 (705 revisions) https://chromium.googlesource.com/chromium/src.git/+log/a9fc4ae13759..3f250af9a632 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/70c150bc0a..c734cf94f4 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/428390e5e3..bb0dbc354c * testing: https://chromium.googlesource.com/chromium/src/testing/+log/b8f44a601a..da9b17c744 * third_party/android_build_tools/lint/cipd: 4wuXV6kRekEDGfw7Du9CYwHpAy2Kid1LP83vU1VmHoUC..Udt_ui9-OCSxeIcww7Glc5tu_22Nynmo1p-LSAUG6qkC * third_party/android_build_tools/manifest_merger/cipd: FLEP0X72qx2m1yrM43PuOhtsxlEgqOtpiG9WBzl9_VgC..X1QeCG1bnGy8cHpJcHN8WYgMmiQXjpDUbIvx7cc1MbMC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/e33c8a1d71..31cfff6e10 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/ffa0089e2c..16ae41e875 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fa0292bfbe..8532fbcf79 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/4a1b486425..8eeec53078 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/3b4cfd9875..cac117af24 * third_party/siso/cipd: git_revision:f96f46a8e4cf30c097110903d4b71516ef976fb6..git_revision:dcd000e47f19677c7a5e02550abafa9eadbd4923 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/bf1e8de6cc..363a126ed2 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/d607298097..7ade8a8f2a * tools/luci-go: git_revision:f703132ac353da666df180762f59ddac9c91594c..git_revision:6d38f0fa9f6c3c973753dbb762b0ed7b711db56c * tools/luci-go: git_revision:f703132ac353da666df180762f59ddac9c91594c..git_revision:6d38f0fa9f6c3c973753dbb762b0ed7b711db56c * tools/luci-go: git_revision:f703132ac353da666df180762f59ddac9c91594c..git_revision:6d38f0fa9f6c3c973753dbb762b0ed7b711db56c * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/775ff79edb..a840c75371 * tools/skia_goldctl/linux: KCo7Lg4SuHJXTXEj_I63tP9huvzRni1axcDQ8t4fpJsC..S61nYM2LARYt8FGKUv9IwoQhQe-J4-IuZJ23SCq5R1oC * tools/skia_goldctl/mac_amd64: kmLqktry2Sv-JeG-gufWzWWt9lyIEh1APpkDay-nvn0C..d88GmiB-c0r_703cXAupUOC3E17SEnJ2gWASKadmsdsC * tools/skia_goldctl/mac_arm64: 3PdwEJIjUzT3GKwX2f-GBcY-Nn18qL3TqS6N5GnHIL4C..97SClzQJSwtymf_fcA4k_ZKZ2-BFRfFpUqIrgsRMM0EC * tools/skia_goldctl/win: GaVdXTdDGGBHQdW6qHtziqhqR6RHk_az7g0BOtUg2nIC..KuqayTqHpavNZjlc3YwoVsu3LhcUItZKbHs-NEl148sC * tools/valgrind: https://chromium.googlesource.com/chromium/src/tools/valgrind/+log/5ba62550b2..da34b95fdb No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: I625acbe37a56c86b6741388d718bb27aa23d1114 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6758913 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya 890b5d8f 2025-07-07T13:06:54 Vulkan: Encapsulate more descriptor set logic in ProgramExecutableVk - ProgramExecutableVk handles SharedDescriptorSetCacheKey updates - Inline most update*DescInfo methods - Add dedicated methods to handle uniform and storage buffers to remove some branches from frequently used code paths Bug: angleproject:426412564 Tests: UniformBufferTest31.UniformBufferBindingRangeChangeWith*FBF Change-Id: I54b8ae2bd8778231e4d187b2cfd30f4d71de7f3b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6733546 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Kimmo Kinnunen b3986258 2025-07-14T14:47:02 Include <utility> in PoolAlloc to fix gcc builds std::exchange needs #include <utility>. Bug: angleproject:429513168 Change-Id: I61e323055cb70545bda883c8bcfb103dcede5136 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6734441 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com>
Renato Pereyra d36f1d71 2025-07-15T14:55:30 Enable AFDO for the Android EGL/GLES libraries built in-tree Bug: b/432060204 Bug: b/383305597 Test: Built ANGLE in Android tree Change-Id: Ifecc3ba56fb4c05133cca4d1ac35049bd6d59726 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6757853 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Takuto Ikuta c03b2d59 2025-07-15T14:18:28 common: Fix include for std::exchange This is to fix error in https://ci.chromium.org/ui/p/chromium/builders/ci/linux-modules-compile-fyi-rel/41761/overview Bug: chromium:40263312 Change-Id: I4d37bd92370b80856571cdd97144b61f8477f362 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6734419 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Devon Loehr ae19969a 2025-07-14T18:23:40 Suppress thread-safety in its own config Followup to crrev.com/c/6716457. Some targets remove the warning config, so move the suppression flag to its own config that is always used. Bug: chromium:430317494 Change-Id: I088e66fca1011ec7fbf6459296f104d9ccb54267 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6732938 Auto-Submit: Devon Loehr <dloehr@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
angle-autoroll e0697648 2025-07-15T10:01:36 Roll vulkan-deps from a7e6b510dbaa to 4e8bc564952b (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/a7e6b510dbaa..4e8bc564952b Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/da8d2caad9341ca8c5a7c3deba217d7da50a7c24..235d1d2cf617af03a2ecbf6e951287595138feda https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/06ae73a3dc3a03466817d8370355203dac7b79b1..5968d14a1ef8a7eeacf342e1542099e1aff20f70 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/cb20eb451cf2e272daaf40099e864a916d8b5542..dc6f68172430999a96a209ef4700784917dab1a2 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/e123e58c8245e00d5b214450dd001df1b6281d87..6f5b5e78b22cdd8d9535986e0d4c1b94ebe2d7b4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I1f24e7c91e363d19968c56b76057815d7ad900b0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6735944 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 1f4399f0 2025-07-15T03:01:06 Roll SwiftShader from c1f7fbbec4e1 to 65b2c4777e5f (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/c1f7fbbec4e1..65b2c4777e5f 2025-07-14 swiftshader.regress@gmail.com Regres: Update test lists @ c1f7fbbe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: If9847d73dd9fcfa0484cbfd778b633d95f4b97b9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6735195 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll db3e7490 2025-07-15T07:58:50 Roll Chromium from 4ff49a95c802 to a9fc4ae13759 (512 revisions) https://chromium.googlesource.com/chromium/src.git/+log/4ff49a95c802..a9fc4ae13759 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/cb592905b1..70c150bc0a * testing: https://chromium.googlesource.com/chromium/src/testing/+log/920f26785f..b8f44a601a * third_party/android_build_tools/error_prone/cipd: 2lYOqu-UyPNYEMX0rO60MpXImuj6kMqnOlVshCO6JLEC..bCQ_MOCwzM4fJFiHDoTJEB9hoP1Oo-OypDACePv2ChEC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/2d708009cd..e33c8a1d71 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/dd8909f212..fa0292bfbe * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/8f9d244c75..3b4cfd9875 * third_party/turbine/cipd: oD9ecDiZFUZfazjjD0N5yl6G4aJsgODDdNjqIp5m1GwC..pLwUKCRZD6noaKQQ0JaosQDV85ccs7FpR9OJT4biM1UC * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/ce898434ac..775ff79edb No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: I57eaa9b15995243eeb07261a4a077b32a010cbcf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6734875 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gyuyoung Kim ab1a2da0 2025-07-04T16:13:04 Disable EnsureLoopForwardProgressTest on iOS The CL[1] that enabled the optimization of simple loops introduced the EnsureLoopForwardProgressTest. However, this test relies on SH_ESSL_OUTPUT, which requires angle_enable_essl to be enabled. Since this is not currently supported on iOS, this CL disables the test on iOS until a proper solution is found. [1] https://chromium-review.googlesource.com/c/angle/angle/+/6575051 Bug: b/426055001 Change-Id: If694be82bad4b4724ace5051c9ee38829a367170 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6703073 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Yuxin Hu 7cbb77a8 2025-07-14T11:32:04 Fix the uniform reorder bug When sorting uniforms, we should first check if both uniforms are structs, and make sure to place the uniforms with specifier in front of the uniforms without specifier. Bug: chromium:431318231 Change-Id: I8be9501f34073983b7f3d040780b749a7366e3d2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6733547 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Shufen Ma d3119b0a 2025-07-07T09:35:04 Relax shader interface matching for program link ES spec 3.2 section 7.4.1 shader interface matching: With separable program objects, interfaces between shader stages may involve the outputs from one program object and the inputs from a second program object. For such interfaces, it is not possible to detect mismatches at link time, because the programs are linked separately. Before this CL, we are applying the the number of output varying and the number of input varyings must match requirement to both glProgram object as well as glPipelineProgram object which is incorrect. This CL removes such check from Program::linkVaryings. A new function LinkValidateInOutNumberMatching is added to handle the this program pipeline specific spec requirement. Bug: angleproject:424050949 Change-Id: I0d2e4360b37d175b2b998e341f15815915771413 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6704827 Reviewed-by: Charlie Lao <cclao@google.com> Auto-Submit: Shufen Ma <Shufen.Ma@arm.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Andrew Mitchell b9588511 2025-07-10T01:18:47 Update committers policy for 2FA requirement Bug: b/415190329 Change-Id: Ic39602dcf31bcd04da0e13aaf9f5d7214a92c3db Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6722090 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Kai Ninomiya 3f170c17 2025-07-11T15:35:01 Roll third_party/dawn/ (1684 commits) and clean up WGPU_BREAKING_CHANGEs With this roll, Dawn has completed the WGPU_BREAKING_CHANGE_* changes, so the old paths are no longer used. The roll: https://dawn.googlesource.com/dawn.git/+log/7a8946456d49..d85fc050fef7 Created with: roll-dep third_party/dawn Bug: chromium:427242889 Change-Id: Ia17fbc1447944e7bcea20d5004367d94cf7be10e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6729918 Commit-Queue: Geoff Lang <geofflang@chromium.org> Auto-Submit: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll 11d20bf3 2025-07-14T10:01:37 Roll vulkan-deps from 5e97ca13797b to a7e6b510dbaa (10 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/5e97ca13797b..a7e6b510dbaa Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/f33fa78f889a176db127e323064f86501e7a679a..4056002eb2401b9406e78b9ea71fd0ce65737ebe https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/2e434ffa1bb776fa2f613269daf6b267aa5e6d1f..6c9b7771527dc92cd3efde054ec0704557f31ae9 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/7806d0a7006b51979b891d807ae285e1f3554b36..257a227fbadf8176ea386c7d8fb9b889cbf08640 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/2cd90f9d20df57eac214c148f3aed885372ddcfe..7cff847503174e2049b08253ee5f30428866fea3 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/e14ac8c7545d7397bc6e902fec716a8a10995f4d..e123e58c8245e00d5b214450dd001df1b6281d87 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I5440333cd67b6c1eb07616693c90af1a553ac017 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6733301 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll f1658153 2025-07-14T09:14:38 Roll Chromium from ddc3627f40bf to 4ff49a95c802 (819 revisions) https://chromium.googlesource.com/chromium/src.git/+log/ddc3627f40bf..4ff49a95c802 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/9a0b74bfb0..cb592905b1 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/17bdad4a57..428390e5e3 * buildtools/linux64: git_revision:635a71e20e99db0b08520ca0746b501167a5c7e5..git_revision:c4748415f12ac92d2781608b8b84fcc0e33e5ff9 * buildtools/mac: git_revision:635a71e20e99db0b08520ca0746b501167a5c7e5..git_revision:c4748415f12ac92d2781608b8b84fcc0e33e5ff9 * buildtools/win: git_revision:635a71e20e99db0b08520ca0746b501167a5c7e5..git_revision:c4748415f12ac92d2781608b8b84fcc0e33e5ff9 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/ab78562f47..920f26785f * third_party/android_build_tools/lint/cipd: SprQhm8ND7zXM2ZhH-8EwKeVUJiLGvzpriWfty0071cC..4wuXV6kRekEDGfw7Du9CYwHpAy2Kid1LP83vU1VmHoUC * third_party/android_build_tools/manifest_merger/cipd: nttKi291XL8l3g1B2tNCmfxEtDcCa9tfIghqosYX22oC..FLEP0X72qx2m1yrM43PuOhtsxlEgqOtpiG9WBzl9_VgC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/b3eb8f07c3..ffa0089e2c * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c2a6159a0d..dd8909f212 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/8c999157a9..8f9d244c75 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/93cad36976..2a25945218 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/1c0b50128b..6c50647ee9 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/11e9f8e093..ce898434ac * tools/skia_goldctl/linux: zqVpcU_pZ6eeM_4GIZzXgzy9VxI8afqtNPpRXxjqXWkC..KCo7Lg4SuHJXTXEj_I63tP9huvzRni1axcDQ8t4fpJsC * tools/skia_goldctl/mac_arm64: DTcviz1jGdq8E1HXhjV1G6jsKCX3lJ8gr5KW0F1n3iAC..3PdwEJIjUzT3GKwX2f-GBcY-Nn18qL3TqS6N5GnHIL4C No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: I4381f6a4f85c6a644ae9943b9db8766ed9782082 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6732784 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Kimmo Kinnunen 93b659f9 2025-07-04T12:35:29 Remove PoolAllocator push/pop feature PoolAllocator would manage a stack of memory pools upon client calling push() and pop(). This made the code unnecessarily complicated. The feature was only used with nesting of one, to mark the memory unused after a shader compile. Fix by removing the push/pop feature. Instantiate PoolAllocator in places the previous push() was and uninstantiating instead of previous pop(). This removes the feature where the PoolAllocator would hold on to the allocated memory in order to reuse it. This is seen as a progression: the allocator is held by the compiler, the compiler is held by the shader and each shader typically see only one compile. Thus the free pages were just leaking unused until the shader was destroyed. Instead, destructing the PoolAllocator instead of pop() will donate the memory back to platform/OS, where it is likely more useful. To preserve existing Vulkan behavior, add PoolAllocator::reset() which would mark the memory unused but leave them reserved for the PoolAllocator. Removes UB where PageHeader::nextPage would be accessed after ~PageHeader. Bug: angleproject:429513168 Change-Id: I21e58b46e0887380db3a2cab5ce22f0042cfae9e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6701153 Reviewed-by: Geoff Lang <geofflang@chromium.org> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 1efc27c6 2025-07-14T08:01:31 Roll VK-GL-CTS from 46724b178e40 to 73db56e823f8 (16 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/46724b178e40..73db56e823f8 2025-07-11 syoussefi@google.com Call vkAcquireNextImage only once for shared present modes 2025-07-11 ziga@lunarg.com Add VK_EXT_debug_utils tests with transfer and video only queues 2025-07-11 ziga@lunarg.com Add image tests using general layout 2025-07-11 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.12 into vk-gl-cts/main 2025-07-11 michal.jakubek@mobica.com Mispell of vkDeviceFeturesVariantDecl in Capabilities System 2025-07-11 marcin.zajac@cognizant.com postCheckout procedure for vulkan-validationlayer 2025-07-11 rgarcia@igalia.com Fix CMake config and build warnings for DEQP_LOG_NODE_SOURCE 2025-07-11 marcin.zajac@cognizant.com Expand query pool statistics testing 2025-07-11 maciej.dziuban@amd.com Add sample location tests for non-MSAA images 2025-07-11 javed@igalia.com Add option --deqp-log-all-images 2025-07-11 pdaniell@nvidia.com Ensure all floats are +ve when converting to uint 2025-07-11 pierre-eric.pelloux-prayer@amd.com Use correct BARRIER_BIT in load/store tests 2025-07-11 jbolz@nvidia.com Change tcu::Float FLOAT_SUPPORT_INFINITY to FLOAT_NO_INFINITY 2025-07-11 gleese@broadcom.com Add rounding mode support for double to deFloat16 2025-07-11 rgarcia@igalia.com Test calling EmitMeshTasksEXT in control flow 2025-07-11 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.3 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I62ace820a8489113d1ced6b985a8f1368aea802b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6733022 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Kimmo Kinnunen 1443a451 2025-07-04T16:18:30 Regenerate the parsers with current cl format The format tool has changed since last parser generation. This causes overly many changes when downstream regenerates the parsers. The diff formatting fails for flex and bison generated content. Format them in full always. Bug: angleproject:429588208 Change-Id: I7a4b8e966e9502920fc25f5c1c5bf80246f5cf0b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6705451 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com>
Cody Northrop 03356f06 2025-07-10T19:21:04 Vulkan: Skip VK_KHR_maintenance9 warning A warning has been added about behavior that will change if VK_KHR_maintenance9 is enabled. Since we can't make this change until drivers support the feature, let's add warning that will fire when we do decide to turn it on. This CL: - Adds a feature for maintenance9 - Adds a VVL skip if isn't enabled - Updates our skip code to check for message IDs Test: Traces Bug: angleproject:429339330 Change-Id: I5763cbc5f343ef165ff8810b9b60b8c809075b8f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6724905 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Amirali Abdolrashidi 065b80a6 2025-07-10T15:50:43 Vulkan: Remove the enum to indicate submitted CB Currently, the function ContextVk::submitCommands() takes the following enum to indicate whether all command buffers or only the outside command buffer is submitted: "Submit" However, ContextVk::submitCommands() is only called twice. Also, this enum is only used to manage a few things, such as garbage collection, and finalizing foreign image layouts. It is possible to move these operations to the respective callers and remove this enum completely. * Moved the operations relying on the enum "Submit" to the locations before submitCommands() as required. * Removed the enum "Submit". (Credit for the idea to move the ops up to the callers: cclao) Bug: b/425987310 Change-Id: Ic0e1c15ee3d2e7cf22a4f7a57b6ac31acc38c861 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6724899 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
angle-autoroll 2bfd1727 2025-07-11T10:01:36 Roll vulkan-deps from 5f1b6fd3d9c3 to 5e97ca13797b (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/5f1b6fd3d9c3..5e97ca13797b Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/2e24222cd9d19e737f8c790a2f485d5ba0d62166..f33fa78f889a176db127e323064f86501e7a679a https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/cc0c28a22acce6de2ef77d41fd7d7b922f7c21e0..2e434ffa1bb776fa2f613269daf6b267aa5e6d1f https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/8dec5f4c41b34e2895e57d3009da93ebadb9f831..e14ac8c7545d7397bc6e902fec716a8a10995f4d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I6e514d8df5b6af850a2afc7de91db8a0d951242e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6725182 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 43baba22 2025-07-11T07:27:38 Roll Chromium from c8f8677ca55f to ddc3627f40bf (582 revisions) https://chromium.googlesource.com/chromium/src.git/+log/c8f8677ca55f..ddc3627f40bf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/777cde7d79..9a0b74bfb0 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/1a1b9975e2..ab78562f47 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/3c08e5e7d4..2d708009cd * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/09cd5e163e..b3eb8f07c3 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7784911e43..c2a6159a0d * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/f37e727ed1..8c999157a9 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/3102d2a0da..bf1e8de6cc * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/b17ffb3e80..d607298097 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/ede01d2603..11e9f8e093 * tools/skia_goldctl/mac_amd64: T9oaospSraHP7PbSCu8LqHHz9MTeuISEv4PUGBnFkOgC..kmLqktry2Sv-JeG-gufWzWWt9lyIEh1APpkDay-nvn0C * tools/skia_goldctl/win: R5dpE9jzORx6Rxc3KF5daqWnVsYylVOsaAd6G87eY4MC..GaVdXTdDGGBHQdW6qHtziqhqR6RHk_az7g0BOtUg2nIC No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: I9e2a787b8574bc31a29832492f2221646a57bd33 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6726364 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuxin Hu 68fa8169 2025-07-09T18:02:16 Vulkan: Reformat VVL error message Remove the VVL that is no longer observed on bots. Reformat the other VVL to use extraProperties only. Bug: angleproject:40644740 Change-Id: I57da1259754d5eba18c8c11385872b3ec9527e09 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6719618 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Mohan Maiya 3b90872b 2025-07-06T09:02:27 Vulkan: Selectively invalidate uniform buffers Call invalidateCurrentShaderUniformBuffers iff current program has active uniform buffers. Also add DIRTY_BIT_UNIFORM_BUFFERS bit to mNew*CommandBufferDirtyBits Bug: angleproject:426412564 Bug: angleproject:429585235 Tests: UniformBufferTest31.UniformBufferBinding*WithMultiplePrograms* Change-Id: I88c37c8317205aecad638553846ffe3beff87f11 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6706537 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com>
Tim Van Patten 6d18ed63 2025-07-08T16:26:53 ValidateGetTexLevelParameterBase: Remove ES 2.0 check This CL addresses review comments in: https://crrev.com/c/6710993 1. Remove the ES_2_0 check for GL_MEMORY_SIZE_ANGLE in ValidateGetTexLevelParameterBase() since the GL_ANGLE_memory_size extension already requires OpenGL ES 2.0, making the version check redundant. 2. Update the test MemorySizeTest.BasicUsageTexture to use the function glGetTexLevelParameterivANGLE() if the context version is below OpenGL ES 3.1 and the extension GL_ANGLE_get_tex_level_parameter is available. Bug: b/409384875 Change-Id: I831d4b35eec20fcb4aff331c5a642a749bd52e67 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6715885 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Jeff Vigil 41a5b397 2025-07-09T09:17:10 Vulkan: Fix checking if fds are identical This helps to decide whether it's really disjoint or not. Bug: angleproject:426480610 Change-Id: I8ec9b352195ab16a7e11d2dab30e98138d9f5a6c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6658648 Reviewed-by: mohan maiya <m.maiya@samsung.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 5f8d93fc 2025-07-10T10:01:02 Roll vulkan-deps from c91d04c5a3ae to 5f1b6fd3d9c3 (10 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/c91d04c5a3ae..5f1b6fd3d9c3 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/9d0dbe9d59159ac936cdc56f9fc85e001afed183..cc0c28a22acce6de2ef77d41fd7d7b922f7c21e0 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/54fc95232ced45f39348c091f6f95545588e350a..7806d0a7006b51979b891d807ae285e1f3554b36 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/2991293a9a1d1d3a9d87d7737dbe812252c1fb40..8dec5f4c41b34e2895e57d3009da93ebadb9f831 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I13b6c4bae06e5d4df5be941e0bbd18617237ff26 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6721311 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 3f1cc048 2025-07-10T03:01:43 Roll SwiftShader from be6ed66fa563 to c1f7fbbec4e1 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/be6ed66fa563..c1f7fbbec4e1 2025-07-09 swiftshader.regress@gmail.com Regres: Update test lists @ be6ed66f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I51c0a81c4a2cca0cf4af3683c00dd7288504bc90 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6720934 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Corentin Wallez 5d51bd19 2025-07-01T15:40:10 Translator: Handle arrays of samplers in FlagSamplersWithTexelFetch This was found while running tests for Dawn's "sized binding arrays" (including arrays of textures) with ANGLE + Swiftshader. Adds a test that ASSERTs without the change. Bug: chromium:411573957 Change-Id: Ib7fad0f5c0b4f3aa70e6af5bf5977b82956e1986 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6695013 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
angle-autoroll 7bd4c395 2025-07-10T07:52:06 Roll Chromium from be763f950c79 to c8f8677ca55f (388 revisions) https://chromium.googlesource.com/chromium/src.git/+log/be763f950c79..c8f8677ca55f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/f7a659bc4e..777cde7d79 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/5f058f2af1..17bdad4a57 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/c11db4cd92..1a1b9975e2 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/209ab6791b..3c08e5e7d4 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0f872505cc..7784911e43 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/3f8818c405..f37e727ed1 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/6eae421681..b17ffb3e80 * tools/luci-go: git_revision:421eb17838d044c10a7cd661a68b5bfa2510f6af..git_revision:f703132ac353da666df180762f59ddac9c91594c * tools/luci-go: git_revision:421eb17838d044c10a7cd661a68b5bfa2510f6af..git_revision:f703132ac353da666df180762f59ddac9c91594c * tools/luci-go: git_revision:421eb17838d044c10a7cd661a68b5bfa2510f6af..git_revision:f703132ac353da666df180762f59ddac9c91594c * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/4410576c49..ede01d2603 * tools/protoc_wrapper: https://chromium.googlesource.com/chromium/src/tools/protoc_wrapper/+log/bc02803b16..3438d4183b * tools/skia_goldctl/linux: 2v1Ogsr5B2ZzLTgxhDCUrs7f3QNdJAw0etD0NJPFkBwC..zqVpcU_pZ6eeM_4GIZzXgzy9VxI8afqtNPpRXxjqXWkC * tools/skia_goldctl/mac_amd64: sB2C9nyKoe0aixRfQ9ociaa3TGzo8Pn5em_Md8a51a0C..T9oaospSraHP7PbSCu8LqHHz9MTeuISEv4PUGBnFkOgC * tools/skia_goldctl/mac_arm64: yQbqw0wv-j0IsBpNmiZnivv8rVuM2ZfaKDm-2DoDw1kC..DTcviz1jGdq8E1HXhjV1G6jsKCX3lJ8gr5KW0F1n3iAC * tools/skia_goldctl/win: YwoTmtJT_JKxB9mVFMCkzABlA_hIEw8P2qB3pTZ0azUC..R5dpE9jzORx6Rxc3KF5daqWnVsYylVOsaAd6G87eY4MC No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: Ic0eccaab44a328ce4ae86e2f3c51647e0f1aa967 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6721990 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amirali Abdolrashidi ec2a04cc 2025-07-09T16:09:08 Vulkan: Skip dEQP clip/cull tests for GS/TS * Skipped the following KHR-GLES3 tests on the Vulkan backend: *.cull_distance.functional_test_item_{5/6}_* Bug: angleproject:42264006 Bug: b/415288635 Bug: b/353358652 Change-Id: I0cc052a66fa91d2c8e4e9f433bec9a3db2962bb9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6720745 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Jisun Lee 7b5a8096 2025-07-09T06:26:21 Vulkan: Enable varyingsRequireMatchingPrecisionInSpirv for Samsung Bug: b/430501085 Change-Id: Iac5061c5d33642af1e53a990487833c26df45b30 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6717687 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
angle-autoroll 0db54987 2025-07-09T17:13:15 Manual roll Chromium from 5e47731919d1 to be763f950c79 (787 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/chromium/src.git/+log/5e47731919d1..be763f950c79 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/a6f8dde294..f7a659bc4e * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/f30f8f10c9..5f058f2af1 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/4f8adf9e3a..c11db4cd92 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/5254207afe..cae4b6a399 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/c586b85d4d..209ab6791b * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/8bfd9f2e53..09cd5e163e * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0d6837383d..0f872505cc * third_party/fuchsia-sdk/sdk: version:28.20250626.4.1..version:28.20250709.3.1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/b5d83e70a1..7a36df3acb * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/33b29ab05d..4a1b486425 * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/5bbf35ae68..634c609746 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/e18275a956..3f8818c405 * third_party/r8/d8/cipd: 9vZCRnASPSjh3_T-2AsumCO_8C5PuBJ5-e84K9b7-80C..JPUb5oFXJVCZnmHps_x4jsuJNZzT4zTUYPDo0AsI1K0C * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/4c6ed84d48..6eae421681 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/f133d28292..4410576c49 * tools/protoc_wrapper: https://chromium.googlesource.com/chromium/src/tools/protoc_wrapper/+log/502dcad523..bc02803b16 No update to Clang. Bug: None Tbr: cnorthrop@google.com,ynovikov@google.com Change-Id: Ide70d658418fff65f692124b2f1a3956aa6529d6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6719951 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Tim Van Patten dc9fb800 2025-07-08T16:59:33 ComputeShaderTestES3.NotSupported: Skip if ES 3.1+ The test ComputeShaderTestES3.NotSupported requires that the context version is exactly OpenGL ES 3.0. However, if the system EGL does not support the ANGLE extension EGL_ANGLE_create_context_backwards_compatible, the maximum conformant version the display supports will be returned instead. This causes the test to fail, because OpenGL ES 3.1+ contexts *do* support creating compute shaders. Skip the test when testing the system EGL if the context version is 3.1+. Only skip when testing the system EGL, so we still fail if the context version is not exactly 3.0, since that's (likely) a bug. Bug: b/279980674 Change-Id: I38090d7f562c7760f2c1b1c3211d1e622b0e0ad4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6715721 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Tim Van Patten <timvp@google.com>
Devon Loehr 9e1bc106 2025-07-08T20:32:02 Suppress thread-safety analysis Clang recently expanded its thread safety analysis to check more things by default. Angle doesn't have the annotations to support it, so make sure the flag isn't passed or else we'll get warnings. Bug: chromium:430317494 Change-Id: I39ea40bcc0023cdf08086ab97577c57a491ac767 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6716457 Auto-Submit: Devon Loehr <dloehr@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Mohan Maiya 30a1cbc9 2025-07-03T13:00:05 Vulkan: Separate out descriptor set for uniform buffers Bug: angleproject:426412564 Change-Id: Icdbb1e634fc543714d1e3b9cdba0530d400cb153 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6705153 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com>
angle-autoroll 7de3c91a 2025-07-08T09:45:23 Manual roll Chromium from ecafbee68f76 to 5e47731919d1 (1548 revisions) https://chromium.googlesource.com/chromium/src.git/+log/ecafbee68f76..5e47731919d1 Manual change adds one new DEP for LLVM: llvm-objdump If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/2fbd9aa354..a6f8dde294 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/f7ada7bb31..4f8adf9e3a * third_party/android_build_tools/error_prone/cipd: dFVMo_NVD5IoNgsCTx1nb8lGGNZNmY6xP94EJtjdm3sC..2lYOqu-UyPNYEMX0rO60MpXImuj6kMqnOlVshCO6JLEC * third_party/android_build_tools/lint/cipd: vjJL0xmNT9EN1STXqXADApReB1GtO9U4OjJB03hfZG4C..SprQhm8ND7zXM2ZhH-8EwKeVUJiLGvzpriWfty0071cC * third_party/android_build_tools/manifest_merger/cipd: mVbkvXY9mSO2xflwykvZDKapEa-3YQG4myL5jEizsbEC..nttKi291XL8l3g1B2tNCmfxEtDcCa9tfIghqosYX22oC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/9c0f16eca6..c586b85d4d * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/7b82569dae..8bfd9f2e53 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/abc5109882..0d6837383d * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/02570151a8..33b29ab05d * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/cbedb1dbfa..e18275a956 * third_party/r8/cipd: EuC8PQbsjuCJyQ-BPbcNPedpvZDvZfR4uA5JGDjS6_gC..JPUb5oFXJVCZnmHps_x4jsuJNZzT4zTUYPDo0AsI1K0C * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/95fb7f7986..8bbd6f5553 * third_party/siso/cipd: git_revision:c46a6c9266d0685fa462694be456204ad243c030..git_revision:f96f46a8e4cf30c097110903d4b71516ef976fb6 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/4028ebf871..3102d2a0da * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/79aeafa6ee..93cad36976 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/9659fbf621..4c6ed84d48 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/c761ecc240..f133d28292 No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: Icd44b4254eedee58ad80081748a3f81fa42f4aa5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6715620 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Jeff Vigil 8e9132c3 2025-07-08T15:23:17 Add missing brackets to gl_tests Add missing brackets required for format style Bug: angleproject:430338389 Change-Id: I4757f03c06bc25734c7492284160d04c8c8fd459 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6715884 Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: mohan maiya <m.maiya@samsung.com>
angle-autoroll 8de23ce6 2025-07-09T10:01:43 Roll vulkan-deps from 7c32c6e7a3da to c91d04c5a3ae (9 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/7c32c6e7a3da..c91d04c5a3ae Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/a45e175a45fe2792bf62e3acebcc817fecfc8422..2e24222cd9d19e737f8c790a2f485d5ba0d62166 https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/e1d9499713162ca7053844479d84f73860417d4c..9d0dbe9d59159ac936cdc56f9fc85e001afed183 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/edce8bd5e7275462709d4c6610c0caec5457f678..54fc95232ced45f39348c091f6f95545588e350a https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/ec329e2721921f79743b90307ee047d08e057788..cb20eb451cf2e272daaf40099e864a916d8b5542 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/a5639cedf4d9f6009d11a43865003bb889982d5e..2991293a9a1d1d3a9d87d7737dbe812252c1fb40 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I826c95da0f8c78ff26a80f2b295a12cb6fcc7120 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6718293 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya d44244ca 2025-07-03T11:36:37 Vulkan: Simplify default uniform WriteDescriptorDescs ProgramExecutableVk fully encapsulates interaction with DescriptorSetDescBuilder with https:://crrev.com/c/6702410 which allows us to keep WriteDescriptorDescs members private. Remove mDefaultUniformWriteDescriptorDescs and reuse mDefaultUniformAndXfbWriteDescriptorDescs for both emulated and extension based XFB codepaths Bug: angleproject:426412564 Change-Id: Icf76440b6efbda93eb8d48c36591a99ccd1a5750 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6705152 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 735c345a 2025-07-09T08:01:19 Roll VK-GL-CTS from a7dbc48b7b02 to 46724b178e40 (5 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/a7dbc48b7b02..46724b178e40 2025-07-08 lorenzo@khronosgroup.org Add JSON for VK_KHR_surface_maintenance1 2025-07-08 lorenzo@khronosgroup.org Add JSON for VK_KHR_present_mode_fifo_latest_ready 2025-07-07 lorenzo@khronosgroup.org Merge remote-tracking branch 'vk-gl-cts/dev/VK_KHR_present_mode_fifo_latest_ready' into main 2025-07-07 lorenzo@khronosgroup.org Merge remote-tracking branch 'vk-gl-cts/dev/VK_KHR_surface_maintenance1' into main 2025-07-07 lorenzo@khronosgroup.org Update external sources (Vulkan 1.4.321) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I10a1e738142b60fc8a2bbb2135a48351a8470cd0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6717685 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya ce289330 2025-07-01T19:41:46 Vulkan: Simplify descriptor set management - Descriptor logic is contained in ProgramExecutableVk and doesn't leak into ContextVk - Reduces CPU overhead by not having to constantly copy and resize the DescriptorSetDescBuilder - Simplifies decoupling of descriptor set of uniform buffers from that of other shader resources Bug: angleproject:426412564 Change-Id: Ic0926d0d466ea21f611c2b2c7b844e0bb9027c1b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6702410 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Neil Zhang 8a9fe208 2025-06-20T16:32:11 Vulkan: Fixed rate compression not work as expected on Android On Android C++ compiler do more optimization and results different with Linux, re-write code to correct the issue. Bug: angleproject:352364583 Change-Id: I1863d2d255cd831d4ca9dd866c85e419f410bd9a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6687014 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Neil Zhang <Neil.Zhang@arm.com> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Jisun Lee 18091004 2025-06-19T16:50:58 GLES1: Skip updating vertex attrib array when binding zero texture Previously, when usecases bind the zero texture, the vertex attrib array was disabled. This made the following bound textures lose the vertex attrib data. In this change, updating vertex attrib array in prepareForDraw() is skipped when the application binds zero texture but does not activate the corresponding texture unit. Also GLES1 tests using zero texture are added to make sure vertex attrib array is enabled correctly. Test: angle_end2end_tests --gtest_filter=DrawTextureTest.* Bug: b/426740680 Change-Id: Ic5aad0a60c9d987edcb1d05cdb6b68dd93eac309 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6659335 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Tim Van Patten 2e9de3c7 2025-07-07T16:58:18 ValidateGetTexLevelParameterBase: Support GL_MEMORY_SIZE_ANGLE ANGLE supports the extension GL_ANGLE_memory_size, which adds the new parameter GL_MEMORY_SIZE_ANGLE. However, the parameter value is not supported in ValidateGetTexLevelParameterBase(), so any calls using it always fail with GL_INVALID_ENUM. The parameter is supposed to be tested by MemorySizeTest.BasicUsageTexture/*, but the portion of the test validating GL_MEMORY_SIZE_ANGLE is never executed because it requires an OpenGL ES 3.1+ context, but the test is only instantiated for GLES 2.0 and 3.0. Based on all the above: 1. Add support for GL_MEMORY_SIZE_ANGLE to ValidateGetTexLevelParameterBase(), requiring GLES 2.0+ and the extension memorySizeANGLE is enabled. 2. Instantiate MemorySizeTest to run on GLES 2.0, 3.0, 3.1, and 3.2, so the entire test is run on devices that support GLES 3.1+ contexts. Bug: b/409384875 Test: angle_end2end_tests --gtest_filter=MemorySizeTest.* Change-Id: I70c5721c5da18cb8edbc9a7e18038d5d9fb486da Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6710993 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll 12fff4bb 2025-07-08T10:01:22 Roll vulkan-deps from ab8b8743ea91 to 7c32c6e7a3da (8 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/ab8b8743ea91..7c32c6e7a3da Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/9d5196d657bdbd06d325790d56d586a3242f52cb..e1d9499713162ca7053844479d84f73860417d4c https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/cc07e5303f1613d8577c2ff61995de39ccc2effd..edce8bd5e7275462709d4c6610c0caec5457f678 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/f0f308ad2cdc2e8fd58985d6230df4a29cc44eb6..06ae73a3dc3a03466817d8370355203dac7b79b1 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/481fd7133a972edc8b59404b6fdf655c6c06b04a..a5639cedf4d9f6009d11a43865003bb889982d5e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Ibb61158338a5b2617c1c91419a8a74a8b42e58ef Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6713729 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Tim Van Patten 825b4062 2025-07-01T17:36:05 tests: Skip ProgramBinariesAcrossPlatforms on SystemEGL+Android ProgramBinariesAcrossPlatforms.CreateAndReloadBinary/* is failing when testing the system EGL on Android. The issue is that the test calls eglWindow->initializeGL(), without checking all of the required extensions are available first. Specifically, it needs the same type of checking that was added to ANGLETestBase with https://crrev.com/c/6622112. Rather than duplicating that work, we should instead find a way to refactor things so both ProgramBinariesAcrossPlatforms and ANGLETestBase can share the implementation. This would also fix the issue that ProgramBinariesAcrossPlatforms cannot be skipped with an entry in angle_end2end_tests_expectations.txt, also due to not inheriting from ANGLETestBase. Due to this, the test needs to be skipped directly within ProgramBinariesAcrossPlatforms::SetUp(), before mOSWindow->initialize() is called (and fails). Bug: b/424595860 Bug: b/429026255 Change-Id: I118a912e871a4693ac529376ddf97c60dd77b1a0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6694919 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Tim Van Patten <timvp@google.com>
angle-autoroll 2466c3ff 2025-07-07T10:01:50 Roll vulkan-deps from 61576f7bb0ed to ab8b8743ea91 (4 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/61576f7bb0ed..ab8b8743ea91 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/44c93ad924b647b0d803ef4c924251c4341b838b..cc07e5303f1613d8577c2ff61995de39ccc2effd https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/42094612240193e0748bb7c19294ca144da4db97..481fd7133a972edc8b59404b6fdf655c6c06b04a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I444a57e11e7b876fd587a51a1f89bcbb2579c516 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6707707 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 8905d531 2025-07-04T16:42:12 Manual roll vulkan-deps from e9520b14c6c9 to 61576f7bb0ed (12 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/e9520b14c6c9..61576f7bb0ed Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/0a2dad5cb501e1d201c62e6f9f6ba86079629829..9d5196d657bdbd06d325790d56d586a3242f52cb https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/16cedde3564629c43808401ad1eb3ca6ef24709a..2cd90f9d20df57eac214c148f3aed885372ddcfe https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/8beef6cb63ffadb02300bf6321b4d3af85ea7417..da8d2caad9341ca8c5a7c3deba217d7da50a7c24 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/f3cfb7fa8994e37c7c0568e33a785591af2ca696..ec329e2721921f79743b90307ee047d08e057788 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/8ee8c17b03f9e66b949fa70245bd3ec6642394df..42094612240193e0748bb7c19294ca144da4db97 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: Ifbdf6cbe17439f405950add24f07210755509e01 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6705155 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov f346ced7 2025-07-03T15:49:41 Fix UninstantiatedParameterizedTestSuite on iOS CopyCompressedTextureTestES32 missed rename in https://chromium-review.googlesource.com/c/angle/angle/+/6648198 Bug: b/419048313 Change-Id: I9c1b64a5625f9cd15b083ff6a0827c069752aa5c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6703639 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov a035c7b6 2025-07-03T16:33:11 Fix rolling to Android after googletest update Because of changes in googletest build files, re2 must be rolled into Android as well. Bug: angleproject:428697844 Change-Id: I3960cccf7cca808b8e4cc2d5f0def030a57f956f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6705237 Commit-Queue: Geoff Lang <geofflang@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Yuly Novikov 619e8bf8 2025-07-03T15:36:30 Skip MultisampleDepthStencilResolveSeparately on Pixel 6 Already skipped on Pixel 4. Fails on Pixel 6 Android 14. Bug: angleproject:42266019 Change-Id: I5e1dfd805b48d59c68e28e07a2d6e4f58653c27c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6702483 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Kramer Ge 52005af1 2025-07-02T16:11:30 Define angle_use_gbm=false when !angle_has_build angle_use_gbm is not defined when !angle_has_build. This causes build to fail. Define it to false in this case. Bug: angleproject:425569857 Change-Id: I8ba66f528b3052725467aeafe046900ec06b8989 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6701310 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Kramer Ge <fangzhoug@chromium.org>
angle-autoroll 5c8e4e48 2025-07-03T10:01:32 Roll vulkan-deps from a1b7197600d4 to e9520b14c6c9 (10 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/a1b7197600d4..e9520b14c6c9 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/8a85691a0740d390761a1008b4696f57facd02c4..a45e175a45fe2792bf62e3acebcc817fecfc8422 https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/cf70be28b43563fb5ffc2681fb3bbe424707b920..0a2dad5cb501e1d201c62e6f9f6ba86079629829 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/04b76709bf40a7ce8df3382060ef3620f19de566..c8ad050fcb29e42a2f57d9f59e97488f465c436d https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/bc7c60e96e141bc55b7099a3d35fb9e0eb1fc801..44c93ad924b647b0d803ef4c924251c4341b838b https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/f216bb107bfc6d99a9605572963613e828b10880..f3cfb7fa8994e37c7c0568e33a785591af2ca696 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/a30de91e1618558a71362e68afa62d7fc6f7ce24..8ee8c17b03f9e66b949fa70245bd3ec6642394df If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I27d47c869caa5a30dc63a20b553381f0b3159c87 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6703228 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Takuto Ikuta 74321385 2025-07-03T14:36:54 Add a missing include for std::pair Bug: chromium:40263312 Change-Id: Id2609c9cae7dedec537cb0d0db130d608166c148 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6701872 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 85a56e89 2025-07-03T03:01:25 Roll SwiftShader from 96a63130d839 to be6ed66fa563 (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/96a63130d839..be6ed66fa563 2025-07-02 swiftshader.regress@gmail.com Regres: Update test lists @ 96a63130 2025-07-02 krzysio@google.com Disable -Wbitwise-instead-of-logical. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: Iac73ac69c312b9edecb634c9267c9ad855e8fde4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6703629 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 9df55d9b 2025-07-03T08:05:24 Roll Chromium from e4e9341de2f7 to ecafbee68f76 (613 revisions) https://chromium.googlesource.com/chromium/src.git/+log/e4e9341de2f7..ecafbee68f76 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/70d5459e6e..2fbd9aa354 * buildtools/linux64: git_revision:97b68a0bb62b7528bc3491c7949d6804223c2b82..git_revision:635a71e20e99db0b08520ca0746b501167a5c7e5 * buildtools/mac: git_revision:97b68a0bb62b7528bc3491c7949d6804223c2b82..git_revision:635a71e20e99db0b08520ca0746b501167a5c7e5 * buildtools/win: git_revision:97b68a0bb62b7528bc3491c7949d6804223c2b82..git_revision:635a71e20e99db0b08520ca0746b501167a5c7e5 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/29d6e4bb40..f7ada7bb31 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/dd86c62796..5254207afe * third_party/android_build_tools/aapt2/cipd: _lNsOL_GGlXLOIMGtrbMOqNd7TQHabaP1q8SlvUpFbMC..QAJPvXRIKAdvDEnn23X7nLv-pZlN3qjPeD_vq4QsYRIC * third_party/android_build_tools/lint/cipd: eWRdzGzH7yQ87tWs3ziVgS5K-hEL5sDdOZgIR2pSduoC..vjJL0xmNT9EN1STXqXADApReB1GtO9U4OjJB03hfZG4C * third_party/android_build_tools/manifest_merger/cipd: QmC9cZkulirpeFoG7WaWIGRovPGsS8sMpycIswB1CwkC..mVbkvXY9mSO2xflwykvZDKapEa-3YQG4myL5jEizsbEC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/63527f0b9e..9c0f16eca6 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/559a8cbd6e..7b82569dae * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/615f4a2f03..abc5109882 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/34e6c8e85a..cbedb1dbfa * third_party/r8/cipd: FXmk4HnrTNsJaRZsLuDZ749YMcCaP-Es0XYIrNMTsfUC..EuC8PQbsjuCJyQ-BPbcNPedpvZDvZfR4uA5JGDjS6_gC * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/c8ffe73cf2..95fb7f7986 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/4f3180cff2..9659fbf621 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/715f296aa6..c761ecc240 No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: I0e9073cb62573cd380e9d81d47647dd580c71241 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6703225 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao 2269011c 2025-06-30T14:08:11 Remove BitSet::to_ulong and BitSetArray::to_ulong BitSet::to_ulong() is a bit redundant with bits(), and has a risk of losing upper bits on windows platform where unsigned long is 32 bit. This CL removes the usage of it and replaced with bits(). BitSetArray::to_ulong() method only captures up to 64 bits, all other bits are dropped silently which is wrong. This CL fix this and serialize it as a vector of uint64_t. BitSetArray::to_ulong() is removed in this CL. Bug: angleproject:42264163 Change-Id: I663b2cdacc0e930ee616e333131e831ec124a9d4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6691283 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Geoff Lang 2f8193ec 2025-06-25T13:17:47 Validate buffers bound for transform feedback are not modified. The ES spec says it is undefined to write to a buffer that is currently being used for transform feedback output but recommends generating an error. Generate INVALID_OPERATION in this case. Bug: chromium:427162086 Change-Id: I727d18c2035509fe2e5d60680eb5198e40a60e33 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6673310 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Charlie Lao 9a05a2b7 2025-06-23T16:24:13 Reland "Vulkan: Avoid some loops in VertexArray::onBufferChanged" This reverts commit 5df85793c602d64d47ef68e29542313be4116bc0. Reason for revert: the regression bug is fixed Some of the functionality related code has been merged into previous CL. This CL now mostly clean up. The old subject/observer code is been deleted from VertexArray. Bug: angleproject:400711938 Original change's description: > Revert "Vulkan: Avoid some loops in VertexArray::onBufferChanged" > > This reverts commit 8d6d127acc1072488e5b57ba4e7e93da2d94bfda. > > Reason for revert: https://issues.chromium.org/427064102 > > Bug: angleproject:400711938 > Original change's description: > > Vulkan: Avoid some loops in VertexArray::onBufferChanged > > > > Before this CL, VertexArray::onBufferChanged() loops over > > bufferBindingMask bits and calls onSubjectStateChange. In this CL, > > VertexArray::onSubjectStateChange is embedded into > > VertexArray::onBufferChanged(). DIRTY_BIT_ELEMENT_ARRAY_BUFFER and > > DIRTY_BIT_ELEMENT_ARRAY_BUFFER_DATA is re-arranged so that we can map > > bufferBindingMask directly to VertexArray::mDirtyBits. This especially > > useful when one buffer is bound to multiple indices in the VertexArray. > > > > This CL also removes angle::ObserverInterface from VertexArray, since it > > no longer observes anything. > > > > ASSERT is added in gl::Buffer::mContentsObservers to ensure it only > > contains BufferTexture, since vertexArray is no longer using the > > subject/observer. > > > > Bug: angleproject:400711938 > > Change-Id: Ie6e7159d7a89f0da5e1b7ca0a9dbe60a1e6c682f > > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6569638 > > Reviewed-by: Geoff Lang <geofflang@chromium.org> > > Commit-Queue: Charlie Lao <cclao@google.com> > > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > > Bug: angleproject:400711938 > Change-Id: I3b8e77db7b3d06b9ed875bfe7787904ac753da11 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6664161 > Commit-Queue: Charlie Lao <cclao@google.com> > Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Bug: angleproject:400711938 Change-Id: If7989b26701dcccbb8e49c42d388c0217e2d0b7f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6663536 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Charlie Lao 2ac49bb6 2025-07-01T12:11:12 Reland "Vulkan: Move VertexArray::ElementBuffer away from observer" This reverts commit 79ac1a8cd767a32cce6401203e20c4bd4ca4d539. Reason for revert: the regression bug is fixed in PS6 The regression bug with the original CL is caused by when we bind a vertex array without element buffer rebind, we missed to reset mIndexRangeInlineCache. The other bug is that VertexArray::mDiryBits is 64 bit but VertexArrayBufferBindingMask is 16 bit, in VertexArray::setDependentDirtyBits(), bufferBindingMask.to_ulong() << DIRTY_BIT_BUFFER_DATA_0 is only producing the 32 bit value on windows platform due to unsigned long is 32 bit value. bits() is used and bit shift is operated on to uint64_t here to avoid dropping high bits on windows. Two tests are added that reproduce the regression bug caused by the original CL. Bug: angleproject:400711938 Original change's description: > Revert "Vulkan: Move VertexArray::ElementBuffer away from observer" > > This reverts commit 3f012a43ee2c101543785720eedfeaa80708479d. > > Reason for revert: https://issues.chromium.org/427064102 > > Bug: angleproject:400711938 > Original change's description: > > Vulkan: Move VertexArray::ElementBuffer away from observer > > > > Right now, VertexArray's element buffer is always observing buffer's > > change. In previous CLs, we have moved vertex array away from > > subject/observer usage. This CL moves element buffer away from > > subject/observer as well. Since the gl::Buffer tracks buffer's binding > > to each context's current vertex array's binding point, > > kElementArrayBufferIndex is added to VertexArrayBufferBindingMask bits > > so that the element buffer is tracked exactly the same as other vertex > > array buffer bindings. The VerextArray code has been modified to handle > > this special bit, since element buffer has its own binding point > > VertexArrayState::mElementArrayBuffer as opposed to > > VertexArrayState::mVertexBindings. After this CL, VertexArray object > > should be completely off subject/observer usages. > > > > Bug: angleproject:400711938 > > Change-Id: I662ddfabc95034bdc7734939c944ab033f41801c > > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6552160 > > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > > Reviewed-by: Geoff Lang <geofflang@chromium.org> > > Commit-Queue: Charlie Lao <cclao@google.com> > > Bug: angleproject:400711938 > Change-Id: I9487ba8b108baaeda1c8a27189dba64f77616774 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6663539 > Commit-Queue: Charlie Lao <cclao@google.com> > Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Bug: angleproject:400711938 Change-Id: I3f47ad1238c41f12b5cbd7a59b84be3fce1e9562 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6664004 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Tim Van Patten de40b6e5 2025-06-06T13:18:09 tests: Add GetEglPlatform() Testing the system EGL library was recently added to ANGLE's end2end tests, breaking the assumption that the tests were interacting with the ANGLE EGL library directly. Many EGL end2end tests call eglGetPlatformDisplay() with the platform value EGL_PLATFORM_ANGLE_ANGLE. However, Android only allows EGL_PLATFORM_ANDROID_KHR, rejecting all other values (returning EGL_NO_DISPLAY). Add GetEglPlatform() to return the platform value to pass to eglGetPlatformDisplay(), based on things like the driver being tested and the OS the tests are running on. Currently, this only supports returning EGL_PLATFORM_ANDROID_KHR for SystemEGL+Android, and EGL_PLATFORM_ANGLE_ANGLE for everything else. Bug: b/279980674 Change-Id: Ib8d7970c8e178beb14ecc6a4f96156783e60c257 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6634554 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
angle-autoroll 7bfdfcc8 2025-07-02T09:47:07 Roll Chromium from 4eaa3d114a3f to e4e9341de2f7 (1812 revisions) https://chromium.googlesource.com/chromium/src.git/+log/4eaa3d114a3f..e4e9341de2f7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/71876cfb44..70d5459e6e * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/f7862e515c..f30f8f10c9 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/a4a57f7e2a..29d6e4bb40 * third_party/android_build_tools/error_prone/cipd: KOECi08Fw4fRTVXkKocxg94coB-e_dlcHRokC21yxyoC..dFVMo_NVD5IoNgsCTx1nb8lGGNZNmY6xP94EJtjdm3sC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/06a7007d07..63527f0b9e * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/57fbead964..559a8cbd6e * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4f1723dd1f..615f4a2f03 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/d9dd3097ff..34e6c8e85a * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/e0f7527112..17e748fa88 * third_party/r8/cipd: 9vZCRnASPSjh3_T-2AsumCO_8C5PuBJ5-e84K9b7-80C..FXmk4HnrTNsJaRZsLuDZ749YMcCaP-Es0XYIrNMTsfUC * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/2c5b3e50a6..c8ffe73cf2 * third_party/siso/cipd: git_revision:13b7a626dcadfb49c7f4759a44095cebea6e91bc..git_revision:c46a6c9266d0685fa462694be456204ad243c030 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/0677411eff..79aeafa6ee * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/9d5b043d87..4f3180cff2 * tools/luci-go: git_revision:e18061c271a8bd452f0205e61ca71f872a48ba9c..git_revision:421eb17838d044c10a7cd661a68b5bfa2510f6af * tools/luci-go: git_revision:e18061c271a8bd452f0205e61ca71f872a48ba9c..git_revision:421eb17838d044c10a7cd661a68b5bfa2510f6af * tools/luci-go: git_revision:e18061c271a8bd452f0205e61ca71f872a48ba9c..git_revision:421eb17838d044c10a7cd661a68b5bfa2510f6af * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/28767137ec..715f296aa6 * tools/skia_goldctl/linux: CAiXuvpP5wV2AC3jI0EO8yfxRxLXKPCBA7189V3-uR4C..2v1Ogsr5B2ZzLTgxhDCUrs7f3QNdJAw0etD0NJPFkBwC * tools/skia_goldctl/mac_amd64: MRvyuJb7Hj1mIvsxGYJCLQ6YLSGYa1H51dsruyE9wdkC..sB2C9nyKoe0aixRfQ9ociaa3TGzo8Pn5em_Md8a51a0C * tools/skia_goldctl/win: YEFP2NCjTSr_DWtN8J1z__-mKqVd9qUfnB3U3s9zmqYC..YwoTmtJT_JKxB9mVFMCkzABlA_hIEw8P2qB3pTZ0azUC No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: Ib9a5e4aef180fb50166a2afc39b813079a35837f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6699229 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Tim Van Patten 4e0537ce 2025-06-13T11:23:58 EGLWindow: Query the Context version after creation Move GetCurrentContextVersion() from src/tests/egl_tests/EGLBackwardsCompatibleContextTest.cpp to util/util_gl.h, so it can be used by both the test and EGLWindow. Without EGL_ANGLE_create_context_backwards_compatible and specifying EGL_CONTEXT_OPENGL_BACKWARDS_COMPATIBLE_ANGLE = EGL_FALSE, ANGLE will create a context with the maximum conformant version the display supports. If the extension is not supported, we need to query the actual context version, so each test can behave accordingly. EGL 1.5 Spec 3.7.1.1 OpenGL and OpenGL ES Context Versions The context returned must be the specified version, or a later version which is backwards compatible with that version. It is expected that EGL_ANGLE_create_context_backwards_compatible is *not* supported when testing the system EGL. This change also adds a log message when the requested context version does not match the actual version. Bug: b/279980674 Change-Id: I58c0779db72c2afcc39c7d88a9a559b37698c994 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6653853 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
angle-autoroll fae186be 2025-07-02T12:13:18 Roll vulkan-deps from ae9b2969a750 to a1b7197600d4 (8 revisions) Ignore optionally included "mimalloc-stats.h" https://chromium.googlesource.com/vulkan-deps.git/+log/ae9b2969a750..a1b7197600d4 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/58391db4fa55e4a19bb0b7377e24476bc88ae688..cf70be28b43563fb5ffc2681fb3bbe424707b920 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/3e25cb555c511d1375f84cb68ecb1c6ede84247a..a30de91e1618558a71362e68afa62d7fc6f7ce24 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Change-Id: I0facaf948305731b4381862d286cd561d6c47062 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6699077 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Tim Van Patten e181ce7a 2025-07-01T11:10:16 end2end: Remove reference to *_EGL configs from help message The *_EGL configs were removed with the following CL: Support running the full end2end suite against the System EGL https://crrev.com/c/6580876 Instead, users need to use the GN arg: angle_test_enable_system_egl = true Update the help message to remove the reference to *_EGL configs and point users to the GN arg instead. Bug: b/279980674 Change-Id: I05908a65eaab6d6a9fbdca9039b687ce4fc31567 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6696787 Reviewed-by: mohan maiya <m.maiya@samsung.com> Commit-Queue: Tim Van Patten <timvp@google.com>
Yuly Novikov f1ae163b 2025-07-01T17:02:14 Update googletest We need https://github.com/google/googletest/commit/fa8438ae6b70c57010177de47a9f13d7041a6328 in order to be able to roll in https://chromium-review.googlesource.com/c/chromium/src/+/6674713 This rolls: https://chromium.googlesource.com/chromium/src/third_party/googletest/+log/17bbed2084d3127bd7bcd27283f18d7a5861bea8..0784ddbe926a700e2216b224109791f7fa19eb2f https://chromium.googlesource.com/external/github.com/google/googletest/+log/2d924d7a971e9667d76ad09727fb2402b4f8a1e3..c67de117379f4d1c889c7581a0a76aa0979c2083 The above also requires adding re2 dependency, since newer googletest depends on it. re2 has 2 parts: build files in https://chromium.googlesource.com/chromium/src/third_party/re2/ and source files in https://chromium.googlesource.com/external/github.com/google/re2/. Unfortunately, git submodules don't allow us to have them nested. So, build files are copied into third_party/re2 from https://chromium.googlesource.com/chromium/src/third_party/re2/+/e9ea896a60f8d72b4943dcc079f0041863985c0e These would require manual updates if build breaks in the future. And then the sources are added as a submodule in third_party/re2/src. These would be autorolled in the future. Bug: angleproject:428697844 Change-Id: Ia695b83669d1822614177fb2aaad44f733b1dfb9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6695112 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Shufen Ma 154e5711 2025-06-24T15:28:28 Refine validation for GetQueryObjectuiv Spec says that after a graphics reset has occurred on a context, subsequent GL commands on that context (or any context which shares with that context) will generate a CONTEXT_LOST error. Exceptions to this behavior include: Any commands which might cause a polling application to block indefinitely will generate a CONTEXT_LOST error, but will also return a value indicating completion to the application. Such commands include: - GetSynciv with pname SYNC_STATUS ignores the other parameters and returns SIGNALED in values - GetQueryObjectuiv with pname QUERY_RESULT_AVAILABLE ignores the other parameters and returns TRUE in params Bug: angleproject:427242336 Change-Id: I86fd6f93a2c2a4b60c6a1e19637ee6382fadac7b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6666083 Auto-Submit: Shufen Ma <Shufen.Ma@arm.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Charlie Lao <cclao@google.com>
angle-autoroll 3ff59f61 2025-07-01T10:01:45 Roll vulkan-deps from d3f4b5f78306 to ae9b2969a750 (27 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/d3f4b5f78306..ae9b2969a750 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/95e6e51a2430185af06a92049395144a6f63a8e1..8a85691a0740d390761a1008b4696f57facd02c4 https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/9ad326e45722ca2cf321d41f5caedbe67a40a449..58391db4fa55e4a19bb0b7377e24476bc88ae688 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/40eb301f320e1d85ce3bc12798022149eae3eee3..bc7c60e96e141bc55b7099a3d35fb9e0eb1fc801 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/10739e8e00a7b6f74d22dd0a547f1406ff1f5eb9..16cedde3564629c43808401ad1eb3ca6ef24709a https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/342da33fdec78d269657194c9082835d647d2e68..8beef6cb63ffadb02300bf6321b4d3af85ea7417 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/e3fc64396755191b3c51e5c57d0454872e7fa487..f0f308ad2cdc2e8fd58985d6230df4a29cc44eb6 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/72665ee1e50db3d949080df8d727dffa8067f5f8..f216bb107bfc6d99a9605572963613e828b10880 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/3fd9510a5dcdb3604a3b16af70ba474c3a0f4944..3e25cb555c511d1375f84cb68ecb1c6ede84247a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I213fe4c2c22082e316a6ad90aec15c32e49cc1de Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6695865 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Tim Van Patten e738f5bc 2025-06-30T16:54:25 EGLWindow: Fix eglGetError in initializeSurface() From the EGL 1.5 spec: # Chapter 3 EGL Functions and Errors ## 3.1 Errors Additional information about the success or failure of the most recent EGL function called in a specific thread[1], in the form of an error code, can be obtained by calling EGLint eglGetError(void); [1] Note that calling eglGetError twice without any other intervening EGL calls will always return EGL_SUCCESS on the second call, since eglGetError is itself an EGL function, and the second call is reporting the success or failure of the first call. In other words, error checking must always be performed immediately after an EGL function fails. EGLWindow::initializeSurface() is checking the status of eglCreateWindowSurface() with eglGetError() and then calling eglGetError() again in the error log message. This results in the error message always containing 0x3000 (EGL_SUCCESS), as the spec states. Fix this by capturing the value of eglGetError() and then using the captured value in both the conditional and the log statement. Bug: b/279980674 Change-Id: I6310996b83960752a9b0d5e0bf40f5aab23174c7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6692271 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Tim Van Patten <timvp@google.com>
Tim Van Patten 56b5d523 2025-06-26T17:32:59 Fix GetTestConfigAPIFromRenderer() for SystemEGL Testing Add support for GLESDriverType::SystemEGL to GetTestConfigAPIFromRenderer() when system EGL testing is enabled with ANGLE_TEST_ENABLE_SYSTEM_EGL. This allows the correct GPUTestConfig value to be returned, rather than GPUTestConfig::kAPIUnknown. The side-effect of this is fixing the expectations file handling for entries with qualifiers like "VULKAN" and allowing those tests to be skipped, for example. Bug: b/279980674 Change-Id: Iaf039549b82f5ba7a047e621bb26968df511a75e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6681013 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
angle-autoroll 99b4ac7e 2025-07-01T03:01:11 Roll SwiftShader from 436722b39118 to 96a63130d839 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/436722b39118..96a63130d839 2025-06-30 swiftshader.regress@gmail.com Regres: Update test lists @ 436722b3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I1e778f8cf34253dee234be1f54a4ff1138c860c7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6696064 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov 777ded25 2025-06-30T15:09:52 Add a whitespace file to test auto cherry picker. Bug: chromium:428685230 Change-Id: Ie74d974c624cd4a9f0963a9f27e5796469b01b9e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6684312 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
angle-autoroll f4885b11 2025-06-30T08:01:55 Roll VK-GL-CTS from 4c617fa74b67 to a7dbc48b7b02 (7 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/4c617fa74b67..a7dbc48b7b02 2025-06-27 lorenzo@khronosgroup.org Update external sources (Vulkan 1.4.320) 2025-06-27 ziga@lunarg.com Add missing cmath include in cooperative matrix tests 2025-06-27 ziga@lunarg.com Add ray tracing query with availability bit tests 2025-06-27 rgarcia@igalia.com Add compile-time option to log test case source code origin 2025-06-27 lionel.g.landwerlin@intel.com Set LineWidth dynamic state for shader object with mesh shaders 2025-06-27 michal.jakubek@mobica.com Adapt Api Buffer Marker tests to Capabilities System 2025-06-27 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.3 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: Ice0113b1913d4309c64b0d3154505e1713611e17 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6687257 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya bb3f79dc 2025-06-26T16:59:48 Reorder shader resource dirty bits Process storage and atomic buffer dirty bits before uniform dirty bits. This helps the vulkan backend avoid duplicate work when multiple shader resources are dirty Bug: angleproject:426412564 Change-Id: Ibab3da44ee32d22078df851bfed4967d1c2a605e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6680035 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com>
Tim Van Patten bbe53b75 2025-06-05T10:36:30 tests: Skip ShaderBinaryTest for System EGL The system driver compiler version is not expected to match the version compiled into the test, causing glShaderBinary() to return GL_INVALID_VALUE due to the incompatible binaries. Bug: b/279980674 Change-Id: I6fce9848345ce981003f0d6d8954e45c2966b523 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6622113 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Tim Van Patten <timvp@google.com>
Zhuang Xu 3c8b492e 2025-06-26T09:39:29 Add histogram for DirectX device removal Bug: dawn:423964507 Change-Id: I22d40ede209797e759f4b4f9e4b86785df33dbe5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6665860 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Avi Drissman d28c6adf 2025-06-19T09:41:26 Modernize for macOS 12 macOS 12 is the minimum OS requirement, so remove the "main port" workaround and do other modernization. Bug: b/40250210 Change-Id: I9638014732f0589fc6171c0fe617b3c563f00c28 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6655558 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll ee071b31 2025-06-27T10:01:59 Roll vulkan-deps from 216f8f420080 to d3f4b5f78306 (6 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/216f8f420080..d3f4b5f78306 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/e9d166cd3bdb4d3c89c6c89c7d9f196a0c9e4ffb..95e6e51a2430185af06a92049395144a6f63a8e1 https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/00e8a166b8c371d8ff6f70ea7872a311b43817ee..9ad326e45722ca2cf321d41f5caedbe67a40a449 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/604c3e75a41b3605ac86bdf5bc26987bd9f9589f..40eb301f320e1d85ce3bc12798022149eae3eee3 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/153542280969323563e588308cb8796df5931d06..3fd9510a5dcdb3604a3b16af70ba474c3a0f4944 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I73233eba71a0bd61e4808c1cb9aad0d9ff49f087 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6682564 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 4b7b8ee3 2025-06-27T07:01:17 Roll Chromium from 3e575cefc53a to 4eaa3d114a3f (453 revisions) https://chromium.googlesource.com/chromium/src.git/+log/3e575cefc53a..4eaa3d114a3f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/9cfbcbcdd9..71876cfb44 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/78457247d1..a4a57f7e2a * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/43850be4d3..dd86c62796 * third_party/android_build_tools/lint/cipd: RevkTwhOQRk-oOzI4BBk3FYEeVAlBijeTqjNPrGsi_8C..eWRdzGzH7yQ87tWs3ziVgS5K-hEL5sDdOZgIR2pSduoC * third_party/android_build_tools/manifest_merger/cipd: v0s5-TwZ9OxfzbqU5ULhQ7vufSuKIIld6Z7TK8artzoC..QmC9cZkulirpeFoG7WaWIGRovPGsS8sMpycIswB1CwkC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/8b6c661e42..57fbead964 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/838762e3ae..4f1723dd1f * third_party/fuchsia-sdk/sdk: version:28.20250609.4.1..version:28.20250626.4.1 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/79a5aa1b7f..d9dd3097ff * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/10890f1e73..2c5b3e50a6 * tools/luci-go: git_revision:6c2c13d25bc8014a0da038302089bc3e9b236931..git_revision:e18061c271a8bd452f0205e61ca71f872a48ba9c * tools/luci-go: git_revision:6c2c13d25bc8014a0da038302089bc3e9b236931..git_revision:e18061c271a8bd452f0205e61ca71f872a48ba9c * tools/luci-go: git_revision:6c2c13d25bc8014a0da038302089bc3e9b236931..git_revision:e18061c271a8bd452f0205e61ca71f872a48ba9c * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/532e27cf37..28767137ec * tools/skia_goldctl/linux: DuaWI_iN1aKYqw68BNRC2gsLbwarydFdh-0pBp8HS6UC..CAiXuvpP5wV2AC3jI0EO8yfxRxLXKPCBA7189V3-uR4C * tools/skia_goldctl/mac_amd64: kfSAMIADvMhxx5OoeY0EajZqqvBTlkVsrDEiWApdnsMC..MRvyuJb7Hj1mIvsxGYJCLQ6YLSGYa1H51dsruyE9wdkC * tools/skia_goldctl/mac_arm64: TMdajugFqfAjHrtZbG5sFxtFgsHk5GeyYgO7Exhlx20C..yQbqw0wv-j0IsBpNmiZnivv8rVuM2ZfaKDm-2DoDw1kC * tools/skia_goldctl/win: 2KZkcCD9mC9MsaKQTOIECvyDm_gtn0YaOjpfdhXw9wcC..YEFP2NCjTSr_DWtN8J1z__-mKqVd9qUfnB3U3s9zmqYC No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: I57328330ed7040bd2f46ecefae6e107ce47c08d4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6680040 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya 3c41ca3e 2025-06-26T20:36:03 Bugfixes in YUV tests - There is no mechanism to query dataspace of AHB, ensure all color values are narrow range compatible - Ensure AHB usage flag reflects actual usage - Define YUV reference colors at the top and reuse in tests Bug: angleproject:386749841 Change-Id: I29d095055ede67653f89a11bae845c086c690b1a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6679988 Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 56e9bfff 2025-06-19T00:00:00 GL: Remove obsolete macOS workarounds Bug: angleproject:427600175 Change-Id: I8bfc062b71f1a34de09cbf76b504293ccd081fe0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6676022 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Shashank Sharma ca893fdf 2025-06-23T13:41:33 Search only for png files while pulling screenshot restricted_trace_perf.py should only look for png files in temp dir and then assert only for 1 screenshot to be present. Bug: b/427963936 Change-Id: I0692aded39f7c3bd5b0c30ee4a7b613db08eac04 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6680727 Auto-Submit: Shashank Sharma <shawshanks@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
angle-autoroll 0a40f9f3 2025-06-26T16:05:37 Manual roll Chromium from e9b993c93b3b to 3e575cefc53a (204 revisions) Manual roll requested by geofflang@google.com https://chromium.googlesource.com/chromium/src.git/+log/e9b993c93b3b..3e575cefc53a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/660c19b81f..9cfbcbcdd9 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/14abe7e6ae..78457247d1 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/cb4a6fc970..9d5b043d87 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/046519adb4..532e27cf37 No update to Clang. Bug: angleproject:427600175 Tbr: yuxinhu@google.com,geofflang@google.com Change-Id: Ie8226208abd9af52b2892fd2ab605f4c2391f61c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6680000 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Kramer Ge dcc715ee 2025-06-19T15:35:53 Enable EGL_PLATFORM_GBM_KHR platform with device selection FunctionsEGL.cpp: - Allow EGL_PLATFORM_GBM_KHR platform and explicit device selection. - Skip getPreferredDisplay if an explicit device is specified. Display.cpp: - Use DisplayEGL impl with EGL_PLATFORM_GBM_KHR. - Wayland can use GBM platform, and OPENGLES. angle.gni: - Rename ozone_platform_gbm to ozone_platform_drm since its deprecated. Bug: angleproject:425569857, b/396434686 Change-Id: I9493118f9dc95f78ebe46277bb4fcfeb7a29d465 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6663699 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Kramer Ge <fangzhoug@chromium.org>
angle-autoroll e7ede7d7 2025-06-26T10:01:15 Roll vulkan-deps from e7bba33afe37 to 216f8f420080 (18 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/e7bba33afe37..216f8f420080 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/efd24d75bcbc55620e759f6bf42c45a32abac5f8..e9d166cd3bdb4d3c89c6c89c7d9f196a0c9e4ffb https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/8e3261f207f1c520522be2021cf364ebb1bad3f0..00e8a166b8c371d8ff6f70ea7872a311b43817ee https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/2a611a970fdbc41ac2e3e328802aed9985352dca..04b76709bf40a7ce8df3382060ef3620f19de566 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/33e02568181e3312f49a3cf33df470bf96ef293a..604c3e75a41b3605ac86bdf5bc26987bd9f9589f https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/6016c4624f8ad3df64987936bfbeb29f32da2d55..153542280969323563e588308cb8796df5931d06 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: Icd95d43f905e897e4b7a59706ecfabdc07d1c3fd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6679275 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 5023a762 2025-06-26T03:01:45 Roll SwiftShader from ed01d9931de3 to 436722b39118 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/ed01d9931de3..436722b39118 2025-06-25 tikuta@google.com Fix conflicting types error in clang modules build If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I31eb7618114872edae931e04181238ffef7942b3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6678109 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 19e4deb5 2025-06-26T09:41:09 Roll Chromium from 263c8e504d0e to e9b993c93b3b (576 revisions) https://chromium.googlesource.com/chromium/src.git/+log/263c8e504d0e..e9b993c93b3b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/7404e7cb13..660c19b81f * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/cf875f9ac3..f7862e515c * testing: https://chromium.googlesource.com/chromium/src/testing/+log/c4185e4f15..14abe7e6ae * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/9fc6afe878..06a7007d07 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/0c0721de3c..8b6c661e42 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/2c359c239b..b5d83e70a1 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/e44c3c4560..02570151a8 * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/4b5d818f29..10890f1e73 * third_party/siso/cipd: git_revision:c23de742b8483ddc09d8b68ef845efc7f5c6192f..git_revision:13b7a626dcadfb49c7f4759a44095cebea6e91bc * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/b1c9da6382..046519adb4 * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/12ac1a1b8e..c52b68f9dc No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: Ibe8856d9ad9cafa0323b37d1cded42c34e611116 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6679272 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Igor Nazarov d5babf99 2025-06-23T12:46:51 Vulkan: Fix unhandled deferred clears after glGetMultisamplefv Issue was introduced in the commit that implemented deferred clears. The `glGetMultisamplefv()` synchronizes draw framebuffer which defers possibly staged clears. Since API is not handling deferred clears they are left untouched, causing the ASSERT. This change fixes the issue by not deferring clears for the `glGetMultisamplefv()` command during flushing staged updates of dirty framebuffer attachments. Changes: - Add `gl::Command::GetMultisample` enumeration for clarity. - Add `gl::CommandBlitBuffer::CommandBlitBufferDepthStencil` enumeration to improve code readability. - Add `command` parameter into `gl::State::syncDirtyObject()` method to use actual command enum instead of `Other`. - Remove `previousDeferredClears` local variable and update ASSERT in the `FramebufferVk::syncState()` method. New assert ensures empty `mDeferredClears` instead of just checking dirty attachments, since it is easy to make all attachments dirty making old and new assertions act the same. - Replace logic in `FramebufferVk::syncState()` that decides whether need to defer attachments or not with switch-case. This makes the logic more clear regarding handling individual commands and simplify updating this handling in the future. Except of the bug fix with `GetMultisample` command, handling of other command is uncached. - Remove `flushDeferredClears()` from `FramebufferVk::readPixels()` because `mDeferredClears` are not expected (now it's more clear after the refactoring). And even if there are `mDeferredClears` (in case of a bug or after API failure), `flushDeferredClears()` only flushes clears for the draw framebuffer, while checking `mDeferredClears` of the read framebuffer. This is a problem in case if read and draw framebuffers are not the same. Bug: angleproject:40644727 Test: angle_end2end_tests --gtest_filter=TextureMultisampleTest.GetMultisamplefvAfterClear/* Test: angle_end2end_tests --gtest_filter=EGLSurfaceTest.GetMultisamplefvAfterClear/* Change-Id: I376a62de52de5e17dbc63cc7ddb0506741a69266 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6661958 Commit-Queue: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Mohan Maiya b3ec3a5f 2025-06-23T14:51:13 Track active uniform and storage buffer blocks Track active uniform and storage buffer block indices so we can process updates to only active buffer blocks Bug: angleproject:426412564 Change-Id: I54fa6fbe795073887646d672303d231ed4317b65 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6663825 Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com>
angle-autoroll c455bda6 2025-06-25T09:34:06 Roll Chromium from 2fb03826f7a0 to 263c8e504d0e (692 revisions) https://chromium.googlesource.com/chromium/src.git/+log/2fb03826f7a0..263c8e504d0e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/8d59c1de51..7404e7cb13 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/39d3a59234..cf875f9ac3 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/d1addfdf7f..c4185e4f15 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/e3d58ba1a2..43850be4d3 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/f46835180c..9fc6afe878 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/c4f7831fe8..0c0721de3c * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ea7a0baff0..838762e3ae * third_party/r8/d8/cipd: F0pTWc6uG70kZPngypnQxCgD3CgY5D8O-pDqj_qeoQMC..9vZCRnASPSjh3_T-2AsumCO_8C5PuBJ5-e84K9b7-80C * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/35982745eb..4b5d818f29 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/5a2ef49216..0677411eff * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/3b495dd794..cb4a6fc970 * tools/luci-go: git_revision:b0488766ec2a119f97c0189ffa5fff13e4da0131..git_revision:6c2c13d25bc8014a0da038302089bc3e9b236931 * tools/luci-go: git_revision:b0488766ec2a119f97c0189ffa5fff13e4da0131..git_revision:6c2c13d25bc8014a0da038302089bc3e9b236931 * tools/luci-go: git_revision:b0488766ec2a119f97c0189ffa5fff13e4da0131..git_revision:6c2c13d25bc8014a0da038302089bc3e9b236931 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/c5b01d0483..b1c9da6382 * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/6c0ba3465b..12ac1a1b8e Clang version changed llvmorg-21-init-11777-gfd3fecfc:llvmorg-21-init-16348-gbd809ffb Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/3b495dd79432abeb32aeb7b51cf4021e4defd24f..cb4a6fc9704f19e6977d7fd1da2a578274b9f611/scripts/update.py Bug: None Tbr: yuxinhu@google.com Change-Id: I843a2e1464773a0305a9c37893a286746f8e35ae Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6670383 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Gyuyoung Kim e15d293c 2025-06-16T16:24:09 tvOS: Disable child process creation code tvOS does not support multi-process applications. As a result, the code that creates a new process causes build failures when building ANGLE unit tests on tvOS. This CL disables that code to prevent the build from breaking. Bug: b/424256388 Change-Id: Ib638d3f75b2839e1a75efc571645921f0d336e55 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6640919 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Solti Ho <solti@google.com>
Alexey Knyazev beae1b4a 2025-06-19T00:00:00 Metal: Remove obsolete workarounds Removed Intel-specific Metal workarounds that are not used on macOS 12 and later. Removed a redundant version check. Bug: angleproject:427600175 Change-Id: I34c7e53108f7e030512c9436ab2b9ae38ad17946 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6672312 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll 14960950 2025-06-24T10:01:50 Roll vulkan-deps from 317a1e4780ef to e7bba33afe37 (15 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/317a1e4780ef..e7bba33afe37 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/21b4e37133868b3a50ef15fc027ecd6d3a52c875..efd24d75bcbc55620e759f6bf42c45a32abac5f8 https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/da60ac4327af194dfa773a07db6cd5d5aaa6848d..8e3261f207f1c520522be2021cf364ebb1bad3f0 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/108b19e5c6979f496deffad4acbe354237afa7d3..33e02568181e3312f49a3cf33df470bf96ef293a https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/c8a2c8c9164a58ce71c1c77104e28e8de724539e..342da33fdec78d269657194c9082835d647d2e68 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/0f0babb553a60da5971d9f4d40cf720ce01602f1..72665ee1e50db3d949080df8d727dffa8067f5f8 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/89c6a9b6500e2e0bda127113bbfe1d70f1ab2d20..6016c4624f8ad3df64987936bfbeb29f32da2d55 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I9944562cd1530a415cc2173d9e6857555e38714d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6665688 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 448c8dab 2025-06-24T03:01:51 Roll SwiftShader from 0ce9bc68d3fc to ed01d9931de3 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/0ce9bc68d3fc..ed01d9931de3 2025-06-23 swiftshader.regress@gmail.com Regres: Update test lists @ 0ce9bc68 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I9883e01ac2797c0dc568965cd7c82352996a8b33 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6666627 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll bbeff29f 2025-06-24T07:00:58 Roll Chromium from f88e654e8ceb to 2fb03826f7a0 (562 revisions) https://chromium.googlesource.com/chromium/src.git/+log/f88e654e8ceb..2fb03826f7a0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/169fcf699b..8d59c1de51 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/5b7491dfe5..39d3a59234 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/0d5210a4b1..d1addfdf7f * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/c7f3762b71..f46835180c * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/a03b70978c..c4f7831fe8 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8f87843807..ea7a0baff0 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/3dc83eebbd..79a5aa1b7f * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/274de19b1d..35982745eb * third_party/turbine/cipd: npJIrAZr4-2wb6qWV0r2oeWQd-Q1wiMGAAi8Up15SkQC..oD9ecDiZFUZfazjjD0N5yl6G4aJsgODDdNjqIp5m1GwC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/ae0ff70908..3b495dd794 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/bd0baf9e31..c5b01d0483 * tools/skia_goldctl/linux: I1LygzXVm-v4LePMcFJ9j0k1AZoLq1UFO5FvEue2TbsC..DuaWI_iN1aKYqw68BNRC2gsLbwarydFdh-0pBp8HS6UC * tools/skia_goldctl/mac_amd64: uI8NbGw_UiTJ3W2CTVNlIycIt9w6x1ozArj3Y3F4UtkC..kfSAMIADvMhxx5OoeY0EajZqqvBTlkVsrDEiWApdnsMC * tools/skia_goldctl/mac_arm64: QSSJvE4WdrL_WsuphR6xIEvHYbO5MAX3yzL1OZUDCMEC..TMdajugFqfAjHrtZbG5sFxtFgsHk5GeyYgO7Exhlx20C * tools/skia_goldctl/win: 72BoyHuvkKlIhZ3QJunOfOnQ4xpyI3ImPWyF8OcXrHMC..2KZkcCD9mC9MsaKQTOIECvyDm_gtn0YaOjpfdhXw9wcC No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: Ida6202335aa1acab4cb41f7d9ef10f16536f66bc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6666420 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao 79ac1a8c 2025-06-23T11:11:10 Revert "Vulkan: Move VertexArray::ElementBuffer away from observer" This reverts commit 3f012a43ee2c101543785720eedfeaa80708479d. Reason for revert: https://issues.chromium.org/427064102 Bug: angleproject:400711938 Original change's description: > Vulkan: Move VertexArray::ElementBuffer away from observer > > Right now, VertexArray's element buffer is always observing buffer's > change. In previous CLs, we have moved vertex array away from > subject/observer usage. This CL moves element buffer away from > subject/observer as well. Since the gl::Buffer tracks buffer's binding > to each context's current vertex array's binding point, > kElementArrayBufferIndex is added to VertexArrayBufferBindingMask bits > so that the element buffer is tracked exactly the same as other vertex > array buffer bindings. The VerextArray code has been modified to handle > this special bit, since element buffer has its own binding point > VertexArrayState::mElementArrayBuffer as opposed to > VertexArrayState::mVertexBindings. After this CL, VertexArray object > should be completely off subject/observer usages. > > Bug: angleproject:400711938 > Change-Id: I662ddfabc95034bdc7734939c944ab033f41801c > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6552160 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Geoff Lang <geofflang@chromium.org> > Commit-Queue: Charlie Lao <cclao@google.com> Bug: angleproject:400711938 Change-Id: I9487ba8b108baaeda1c8a27189dba64f77616774 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6663539 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Charlie Lao 5df85793 2025-06-23T11:08:49 Revert "Vulkan: Avoid some loops in VertexArray::onBufferChanged" This reverts commit 8d6d127acc1072488e5b57ba4e7e93da2d94bfda. Reason for revert: https://issues.chromium.org/427064102 Bug: angleproject:400711938 Original change's description: > Vulkan: Avoid some loops in VertexArray::onBufferChanged > > Before this CL, VertexArray::onBufferChanged() loops over > bufferBindingMask bits and calls onSubjectStateChange. In this CL, > VertexArray::onSubjectStateChange is embedded into > VertexArray::onBufferChanged(). DIRTY_BIT_ELEMENT_ARRAY_BUFFER and > DIRTY_BIT_ELEMENT_ARRAY_BUFFER_DATA is re-arranged so that we can map > bufferBindingMask directly to VertexArray::mDirtyBits. This especially > useful when one buffer is bound to multiple indices in the VertexArray. > > This CL also removes angle::ObserverInterface from VertexArray, since it > no longer observes anything. > > ASSERT is added in gl::Buffer::mContentsObservers to ensure it only > contains BufferTexture, since vertexArray is no longer using the > subject/observer. > > Bug: angleproject:400711938 > Change-Id: Ie6e7159d7a89f0da5e1b7ca0a9dbe60a1e6c682f > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6569638 > Reviewed-by: Geoff Lang <geofflang@chromium.org> > Commit-Queue: Charlie Lao <cclao@google.com> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Bug: angleproject:400711938 Change-Id: I3b8e77db7b3d06b9ed875bfe7787904ac753da11 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6664161 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Junji Watanabe 0a47f441 2025-05-27T16:00:38 Set use_siso=true by default in .gn This CL enables use_siso=true by default. Developers builds will switch to Siso, or get suggestion to run `gn clean` to switch. Bug: b/401959048 Change-Id: I7cf7efecc9cd8c7816dbbd74ea48e66e61a1b6f2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6589553 Auto-Submit: Junji Watanabe <jwata@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
kmx.io     mail     discord kmxgit v0.4.0