kc3-lang/angle

Log

Author Commit Date CI Message
angle-autoroll 2d419eb1 2025-09-01T09:28:19 Roll Chromium from 659c6d688f03 to ddfbb7d832f0 (842 revisions) https://chromium.googlesource.com/chromium/src.git/+log/659c6d688f03..ddfbb7d832f0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/800bdadb6c..71f8022b66 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/b0b6f725c2..2ca9a5b96f * testing: https://chromium.googlesource.com/chromium/src/testing/+log/fc00cc4343..1c01106921 * third_party/android_build_tools/aapt2/cipd: 2Tff49a5dYTM5YvxxqyOsTQ9k8nOqM4ayydbCuKoxIwC..vtRNH1sTb9tAlXaPkdqGIH_MDSnuH2GrlWFtT1MhadUC * third_party/android_build_tools/error_prone/cipd: R8e42R2txro2We-fzwv-mCywXVgBpacnAx2ln84t9ZkC..47nFaUKq3UemCr0EHmMYPJ63Y9hRnNII7iNn5zYK9qsC * third_party/android_build_tools/lint/cipd: -JcaCbcpT3Q0in-E0Q-DQ8raNBQTA0mTz6N_smsM-YwC..KBlDDgCi2ePqd60Cg-MkB6N_YRqkgcJ0ldkVj8OW_I4C * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/e7fd5cc71d..0b4498fa66 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6b19831e3c..a54a6c133b * third_party/fuchsia-sdk/sdk: version:29.20250824.3.1..version:29.20250901.2.1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/3fbbed1e6e..70c21e34ea * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/c948b3c916..92fb77dfd4 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/be4d290e46..11725050a2 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/6bcedec5a3..e354a43e42 * third_party/siso/cipd: git_revision:15568691576f74b11a3c73c85a3c8dd5efb72f05..git_revision:8863265a67843154872be2be1fc0c37339691405 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/77d4c8dd8a..13fd72a058 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/2fa0b7d4c3..3895bad8d8 * tools/luci-go: git_revision:129260cb7597c1601e1fea08f0d2d672ae2330a6..git_revision:5482078f7d5948dab82fc4d4ab8e19a31536e6b0 * tools/luci-go: git_revision:129260cb7597c1601e1fea08f0d2d672ae2330a6..git_revision:5482078f7d5948dab82fc4d4ab8e19a31536e6b0 * tools/luci-go: git_revision:129260cb7597c1601e1fea08f0d2d672ae2330a6..git_revision:5482078f7d5948dab82fc4d4ab8e19a31536e6b0 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/a8cc349622..67dbacceca * tools/skia_goldctl/linux: Crs4pLO-tMSzA5ldZyYRfd6l8DlBceR6NUDI0K8aI4kC..9ByI3GXvRWtecAXo0R39pN9Jak7EvEeKnHr7AvwPTusC * tools/skia_goldctl/mac_amd64: HN1hkS7vu_wjGf_OP2V6--4DC6awi7V-ozpJRMt7OyEC..oSdrLMI0x9PkfobCI5WwpFuT5jYD2pnE3CsLIwkpT7AC * tools/skia_goldctl/mac_arm64: F2BnxcR4yVPrD2Aaw9X9JNQkeTvxrhCW5CZ8sSXxLR8C..YY51Byb3DdEAuCLgXvJ3TUzQRIAFSYMFGbHt18sHXlEC * tools/skia_goldctl/win: z5U3w9onZdvjd2_mryXXs_1V_APeMYuzeSAB4nGW26cC..3KmIxwEvH3rb0U2exjD0rxJpqdpKe1ceUGvnoKcS_w4C No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: I236d038a9b94011d23ebd730461b229506f31602 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6905488 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b59b287e 2025-09-01T08:01:13 Roll VK-GL-CTS from 3718ed21d713 to 15469c3d0039 (15 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/3718ed21d713..15469c3d0039 2025-08-29 piotr.byszewski@mobica.com Descriptor buffer tests to verify set invalidation rules 2025-08-29 mateusz.bahyrycz@mobica.com Add buffer to image copy tests for color formats 2025-08-29 lorenzo@khronosgroup.org Split vk-main-2023-03-01 into 3 parts to avoid large files 2025-08-29 javed@igalia.com Add coverage for non-resident sparse buffer 2025-08-29 nunes.erico@gmail.com Fix egl_fence_persistent_buffer deinit on GLES 2.0 2025-08-29 rgarcia@igalia.com Add tests to verify terminateInvocation works as expected 2025-08-29 scerveau@igalia.com video: use larger content for h265 encode 2025-08-29 zzoon@igalia.com Add CTS options to dump output of Vulkan video tests for both decoding and encoding. 2025-08-29 javed@igalia.com Refactor render pass test groups 2025-08-29 marcin.zajac@cognizant.com Separated E5B9G9R9 blend color write mask coverage 2025-08-29 zzoon@igalia.com Fix to detect video codecs for AV1 and VP9 2025-08-29 scerveau@igalia.com VideoEncodeTestsAV1: Fix options according to test names 2025-08-29 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.3 into vk-gl-cts/main 2025-08-28 lorenzo@khronosgroup.org Merge vk-gl-cts/github-main into vk-gl-cts/main 2025-08-26 scerveau@igalia.com video: do not create yuv folder if it exists If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I3bcba7f041598f4f1dd3d0f6fbad0792024dc1a8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6904519 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop 1e3e4eb7 2025-08-30T17:25:20 FrameCapture: Don't issue Begin/End for Timestamp queries Timestamp queries are issued with glQueryCounterEXT rather than glBeginQuery/glEndQuery. This CL updates how we generate timestamp queries in MEC. Before this, we were getting the following errors: API, Error, High: Error:glBeginQuery::<target> is not an accepted value API, Error, High: Error:glEndQuery::<target> is not an accepted value Test: Minecraft Vibrant Visuals trace Bug: b/442154222 Change-Id: Ib6dc01c3b57afcbebfdefa38e6abc883564ea6bd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6903038 Reviewed-by: Mark Łobodziński <mark@lunarg.com> Commit-Queue: Mark Łobodziński <mark@lunarg.com> Auto-Submit: Cody Northrop <cnorthrop@google.com>
Tom Sepez 3d08d885 2025-08-27T23:27:51 Log sanitized message in InfoLog::appendSanitized(). Currently, after producing a sanitized version, the unsanitized string is logged. -- convert away from char* arguments while at it. Bug: b/441583909 Change-Id: I9ee91d303df6c5b874fd1971347b9db3ba03f51c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6893268 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Tom Sepez <tsepez@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Amirali Abdolrashidi ded3e754 2025-08-18T14:42:59 Add more tests for RGB565 * Added more tests regarding RGB565 rendering, texture copy, blit, and border color clamp. Bug: b/409867243 Change-Id: Ic9d30aee89bda3e8f6c9147fffd99d8d2d8fac64 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6872406 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Tom Sepez eefcdafd 2025-08-29T00:13:27 Fix some old clang-tidy warnings about move constructors -- Remove move of copy-only ImmutableString -- Fix rule-of-five issues with StringPart. Bug: b/364788123 Change-Id: Ief9c2a83df15d2e8856e8f729c1908df65004bfc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6896659 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Auto-Submit: Tom Sepez <tsepez@chromium.org>
Tom Sepez 6f0337a0 2025-08-28T23:13:22 Avoid some needless c_str() calls. Remove conversions from string -> char* -> string, as detected some time ago by a clang compiler plugin. Typically, this occurs when passing a c_str() result to a function that expects a string argument. Bug: b/412730353 Change-Id: I1d9c83e9ed5c4900eec266e71f534661f0f3d4d4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6896657 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Tom Sepez <tsepez@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Yuxin Hu 28682948 2025-08-14T15:20:16 Update setFloat and getFloat APIs to handle 16-32 bit transformations This change checks that if linkedUniform.isFloat16() is true, then transform 32-bit float to 16-bit half float before writing the data to memory, and transform 16-bit half float to 32-bit float after reading the data from memory. Given that we did not change buffer layout, and the spirv requirement with matrix component alignment, we have to copy transformed data row by row / col by col, or element by element. This change is no op, as none of the linkedUniform.isFloat() bit is set to true. The change will take effect in the future change when we add the compiler code that set linkedUniform.isFloat() to true. Bug: angleproject:405795981 Change-Id: I72b74eb340dae723501038875c3706ad2c1cc3f7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6851558 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Cody Northrop 24d3f6a4 2025-08-29T09:43:58 Tests: Add Vita Mahjong trace This trace was contributed by Samsung. Test: angle_trace_tests --gtest_filter=*vita_mahjong Bug: b/441948358 Change-Id: Idde12aebb12bf3a1230de1e2f132f0a6ed586595 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6897504 Auto-Submit: Cody Northrop <cnorthrop@google.com> Commit-Queue: Mark Łobodziński <mark@lunarg.com> Reviewed-by: Mark Łobodziński <mark@lunarg.com>
Igor Nazarov e64b1e54 2025-08-29T15:51:30 FrameCapture: Restore end of trace capture log The log was accidentally removed by: Add long ANGLE traces feature https://crrev.com/c/angle/angle/+/6476924 That was originally added in: FrameCapture: log end of trace capture https://crrev.com/c/angle/angle/+/5557966 Bug: angleproject:343190307 Bug: angleproject:425728227 Change-Id: I68125981a3841c3d5e25aeaab3d792b8b047182a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6898285 Commit-Queue: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop 6ca17fba 2025-08-28T17:12:51 Tests: Add Indian Bikes Driving 3D trace Test: angle_trace_tests --gtest_filter=*indian_bikes_driving_3d Bug: b/441808359 Change-Id: I0a4f526fee4b3b3d0e46f30735a8fe48fe4f4d03 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6898414 Reviewed-by: Mark Łobodziński <mark@lunarg.com> Auto-Submit: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Commit-Queue: Mark Łobodziński <mark@lunarg.com>
Tom Sepez 3d8dff0a 2025-08-26T20:23:21 Suppress unsafe buffers on a file-by-file basis in util/ Bug: b/436880895 Change-Id: I299247e38853bb16afd466e3f6521342c0a2b0f8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6891980 Auto-Submit: Tom Sepez <tsepez@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
angle-autoroll ee512a88 2025-08-29T10:01:45 Roll vulkan-deps from d004638a44e4 to 3c8902583f3c (5 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/d004638a44e4..3c8902583f3c Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/c32bbc601dff6a0cacf6f2b65608742af1d57d26..bfe590945ebdc9c40639b6b73698bd10990f4568 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I41bbcc08313498b714a07bea0504b049eb753d09 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6898745 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 9ed1572e 2025-08-29T08:14:37 Roll Chromium from a8c806abc633 to 659c6d688f03 (1279 revisions) https://chromium.googlesource.com/chromium/src.git/+log/a8c806abc633..659c6d688f03 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/6920476cbc..800bdadb6c * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/4cb1372f8a..b0b6f725c2 * buildtools/linux64: git_revision:037970ef8d8e5b1d9d3d6defc9aa3886dbfea29a..git_revision:5d0a4153b0bcc86c5a23310d5b648a587be3c56d * buildtools/mac: git_revision:037970ef8d8e5b1d9d3d6defc9aa3886dbfea29a..git_revision:5d0a4153b0bcc86c5a23310d5b648a587be3c56d * buildtools/win: git_revision:037970ef8d8e5b1d9d3d6defc9aa3886dbfea29a..git_revision:5d0a4153b0bcc86c5a23310d5b648a587be3c56d * testing: https://chromium.googlesource.com/chromium/src/testing/+log/5d0a173278..fc00cc4343 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/4862f4f12d..5141e83267 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/0bbf370291..e7fd5cc71d * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c3749b59b3..6b19831e3c * third_party/ijar: https://chromium.googlesource.com/chromium/src/third_party/ijar/+log/4b641086e0..94af60a05b * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/a5fc4c8ab6..3fbbed1e6e * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/a8a291787d..be4d290e46 * third_party/r8/cipd: iGVAmwvi7lXeH5SCnaZ0PpcrSL_X8-fC6JbEKfYst-wC..nvFK5h1qU6auImeboro5vB72VxCbNz29K9X4kQ94q44C * third_party/r8/d8/cipd: pBaBgtFdvclLMBwz1H7s88bhc3ioF8iEyFh6rZ81054C..iGVAmwvi7lXeH5SCnaZ0PpcrSL_X8-fC6JbEKfYst-wC * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/9f2bf232b7..77d4c8dd8a * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/d9f910bd0f..2fa0b7d4c3 * tools/luci-go: git_revision:d404c33558d672701abed8ca167cfe06f36fa59e..git_revision:129260cb7597c1601e1fea08f0d2d672ae2330a6 * tools/luci-go: git_revision:d404c33558d672701abed8ca167cfe06f36fa59e..git_revision:129260cb7597c1601e1fea08f0d2d672ae2330a6 * tools/luci-go: git_revision:d404c33558d672701abed8ca167cfe06f36fa59e..git_revision:129260cb7597c1601e1fea08f0d2d672ae2330a6 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/1e73800b34..a8cc349622 * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/4b83b80356..f71995f8f9 * tools/skia_goldctl/linux: _0gFCSj5cqOmXXe-Atkb0kcFChMiI0RIeaA-mAYHxUIC..Crs4pLO-tMSzA5ldZyYRfd6l8DlBceR6NUDI0K8aI4kC * tools/skia_goldctl/mac_amd64: b-j1EfuXxMKGgGvSsu998B3Py6Im2cjyVMMFGXVabJYC..HN1hkS7vu_wjGf_OP2V6--4DC6awi7V-ozpJRMt7OyEC * tools/skia_goldctl/mac_arm64: 5lVrW5FJxzBE4lA0U1My-WYSBvHmTH2hooKWml9VnKYC..F2BnxcR4yVPrD2Aaw9X9JNQkeTvxrhCW5CZ8sSXxLR8C * tools/skia_goldctl/win: LdKqwqTVZ9jhO6opMlduYqa3AuEfV6Pt-cs1Bjgi3fwC..z5U3w9onZdvjd2_mryXXs_1V_APeMYuzeSAB4nGW26cC No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: Ifd42e9c3053eedafc2be4bfdd719865e847e33d0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6898422 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop a1fa1ddc 2025-08-28T13:16:57 Tests: Add Total Battle trace This trace was contributed by Samsung. Test: angle_trace_tests --gtest_filter=*total_battle Bug: b/441768019 Change-Id: I432a14aff611e84527521bb065fe447557ce72e3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6896936 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Auto-Submit: Cody Northrop <cnorthrop@google.com>
Gowtham Tammana 4983b4c9 2025-05-14T13:54:47 CL/VK: Track both read/write usages of mem objects Track both the read and write usages when determining the need for barrier insertion. Bug: angleproject:441240590 Change-Id: I2a70905dbadd9bdba6fe6b83dd980963b6380a79 Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6885851 Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Gowtham Tammana ce158355 2025-05-06T17:11:33 CL/VK: Add isReadOnly() query for CLKernelArgument A new helper function `isReadOnly()` is added to CLKernelArgument. This makes the determination of memory dependencies more flexible. As a result, updated the `addMemoryDependencies` function to take in the write usage boolean. Bug: angleproject:441240590 Change-Id: I8826f88b7ff84ee7c689a68df4c5121ee9f12619 Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6885850 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com>
Gowtham Tammana 2a44be85 2025-05-28T15:17:33 CL/VK: Update the HostTransferConfig to supported configs Setup HostTransferConfig constructors to enable only supported configurations. Bug: angleproject:441471275 Tests-Passing: - ocl_cts.test_mem_host_flags - ocl_cts.test_basic readwritebufferrect - ocl_cts.test_buffers - ocl_cts.test_allocations Change-Id: I19afab8f66d2b025b532b42de161557b9dfbf563 Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6892626 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com>
Gowtham Tammana 0efe1a44 2025-05-16T16:23:10 CL/VK: Use UHP buffers for host transfer config We setup staging copy command for host side enqueue commands - eg. enqueueWriteBuffer. Setting CL_MEM_USE_HOST_POINTER (UHP) buffers as defaults for these staging ops so that zero-copy can be leveraged if supported. Bug: angleproject:441471275 Tests-Passing: - ocl_cts.test_buffers - ocl_cts.test_allocations - ocl_cts.test_mem_host_flags - ocl_cts.test_basic bufferreadwriterect Change-Id: Ifc584652b513f0ed0633a8d0383b244f53d57363 Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6892625 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Tom Sepez cf28f60d 2025-08-26T19:25:22 Avoid c-style string arguments to writeFile(). Demonstrate how std::string_views can be used to make code simpler and safer, since all the callers already have std::strings. Bug: b/436880895 Change-Id: I0f9d4d95925e684c83eb10c2a1fbab22df55c2d8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6886033 Auto-Submit: Tom Sepez <tsepez@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Shyam Manohar e842b5f8 2025-05-06T14:38:27 CL/Vulkan: Zero-copy support added for CL Buffers - Used VK_EXT_external_memory_host and VK_KHR_external_memory extensions - Added interfaces to CLBufferVk class for validating zero-copy ability - Added logic in CLBufferVk::create to use zero-copy if eligible - Added new HostExternalMemory class to provide utility functions - Added VkPhysicalDeviceExternalMemoryHostPropertiesEXT for querying Tests-Passing (having usage of CL_MEM_USE_HOST_PTR): - ocl_cts.test_api - ocl_cts.test_basic - ocl_cts.test_buffers - ocl_cts.test_mem_host_flags Bug: angleproject:441471275 Change-Id: I296e709a4f67911dcd6d0ae89750e8e0262625f4 Signed-off-by: Shyam Manohar <s.manohar@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6892624 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com>
Tom Sepez a4e0bacc 2025-08-28T16:41:09 Avoid dangling pointer in Context11::popGroupMarker(). Fortunately, the pointee is unused, but move the string from the marker stack before destroying it during a pop() of the stack, so that its c_str() may live through a call to endEvent(). -- Do the same for Context9::popGroupMarker(). Bug: b/441729484 Change-Id: Id05aa92529ecc8938282273e68d95ac51966d229 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6896927 Auto-Submit: Tom Sepez <tsepez@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi 1ae273ee 2025-08-27T10:47:59 Translator: Output struct members in OutputTree Bug: chromium:438038775 Change-Id: I2a1bed5207b1b2c26f20ee9ebd80fb00ec803bc2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6891072 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi af0386cb 2025-08-27T10:44:53 Reorder structs entirely made of samplers to the end of struct An earlier change [1] moved samplers to the end of structs so that extracting them does not disturb the indices to the non-sampler fields. This change does the same for structs that only contain samplers, because they too get removed from the parent struct, disturbing indices. [1]:https://chromium-review.googlesource.com/c/angle/angle/+/5748789 Bug: chromium:438038775 Change-Id: I7ac2ea13723bf06b4b172b6e70f0dbe85bc45ce3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6891071 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Cody Northrop 08ee8585 2025-08-28T09:27:51 Tests: Add Soccer Superstar trace This trace was contributed by Samsung. Test: angle_trace_tests --gtest_filter=*soccer_superstar Bug: b/441721624 Change-Id: I8b954ace7ea96eff0dd7cc2edff19a87d6a8b437 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6897006 Reviewed-by: Mark Łobodziński <mark@lunarg.com> Commit-Queue: Mark Łobodziński <mark@lunarg.com>
Shahbaz Youssefi 1ed999ea 2025-08-25T16:02:01 Vulkan: Move sampler cache to share group The sampler cache (and the adjacent yuv-conversion-info cache) were in vk::Renderer, but they were not thread safe. Bug: angleproject:440364873 Change-Id: I2dc034f2db400f680ca91a9fde509d90f90c957e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6870736 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Cody Northrop 9dc36791 2025-08-28T07:24:21 WGSL: Fix unused variable in translator Test: Build with is_debug = false Bug: angleproject:441701631 Change-Id: Ifa44bb5388788602e76c2ae2005bdd41d2c22dd4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6896036 Auto-Submit: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 63ba3783 2025-08-28T10:56:03 Roll vulkan-deps from 4055d497de6c to d004638a44e4 (14 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/4055d497de6c..d004638a44e4 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/7a5308f4bb40860cccee31d3037feb81bb35a66a..3289b1d61b69a6c66c4b7cd2c6d3ab2a6df031e5 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/1d8f536946281ca95a9a03255aaaa73696d96f90..0c1acc220abd1a5791601d907b6bb49b640a62d2 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/35a62d3181eb9c238299a62618b49e521f3fe7b2..8b7e618308605235f61d78fa47a3785190440467 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/3f13668946a3075216275b35b4b9aad2e9b69406..c32bbc601dff6a0cacf6f2b65608742af1d57d26 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I8b2ebe0999cae1db5e40417a2a992ea6fd012eb5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6893279 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop 9a5eea61 2025-08-27T12:01:26 Tests: Add Football League 2025 trace This trace was contributed by Samsung. Test: angle_trace_tests --gtest_filter=*football_league_2025 Bug: b/441524270 Change-Id: I2fcb0d8fa61a5c9a8f7dcb142d79b25eda3d9d44 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6891990 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Auto-Submit: Cody Northrop <cnorthrop@google.com>
Cody Northrop 87347355 2025-08-27T10:14:46 Tests: Add School Party Craft trace This trace was contributed by Samsung. Test: angle_trace_tests --gtest_filter=*school_party_craft Bug: b/441504808 Change-Id: I777bccb132acc4fb1d5891ce0793e262a89af59d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6891912 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jonghyuk Eun cdf428a2 2025-04-01T10:24:08 CL/VK: Update Samsung preferred/native vec widths Update CL_DEVICE_PREFERRED_VECTOR_WIDTH_* and CL_DEVICE_NATIVE_VECTOR_WIDTH_* for Samsung. The values may vary depending on the vendor. Updating only the values for SAMSUNG here. Bug: angleproject:406022413 Change-Id: Iad575298a11cfb41e620ab9cfd5f970eb6ea0b55 Signed-off-by: jh.eun <jh.eun@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6386421 Reviewed-by: Austin Annestrand <a.annestrand@samsung.com> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop bb27274f 2025-08-27T09:04:05 Tests: Add Offline Games trace This trace was contributed by Samsung. Test: angle_trace_tests --gtest_filter=*offline_games Bug: b/441489135 Change-Id: I0bfbfab40c525bc87c8b077748e09171e501567a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6891371 Reviewed-by: Mark Łobodziński <mark@lunarg.com> Commit-Queue: Mark Łobodziński <mark@lunarg.com>
Amirali Abdolrashidi e9214c63 2025-08-26T13:53:52 Update trace event header to allow unsafe buffers * Updated the following file to allow unsafe buffers: trace_event.h * This is to prevent errors when the following GN flag is enabled: angle_enable_platform_trace_events Bug: b/436880895 Change-Id: Iefb5ab6ab07259580b569760816fe9ad1a833161 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6885893 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop 117cddc8 2025-08-27T07:48:01 Tests: Add Tile Club trace This trace was contributed by Samsung. Test: angle_trace_tests --gtest_filter=*tile_club Bug: b/440580308 Change-Id: Idb8f18402de702a434e16c9c9835fdb20c73db69 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6890511 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Mark Łobodziński <mark@lunarg.com>
Austin Annestrand 86a76e49 2025-08-24T12:33:16 third_party/clspv: Update clspv Rolls clspv and llvm: clspv: 0e20b2895e4b58e62311f5c311bfec4599f517e0 llvm: 7baa7edc00c5c92e2d17bae760db2e6df97dcec6 Bug: angleproject:440837006 Change-Id: I908e406e6daf7dd428a4057e2d204e3d23342f56 Signed-off-by: Austin Annestrand <a.annestrand@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6877795 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop be2fc5c3 2025-08-27T07:43:13 Tests: Add Royal Kingdom trace This trace was contributed by Samsung. Test: angle_trace_tests --gtest_filter=*royal_kingdom Bug: b/440579756 Change-Id: Ie30f37e58f2b422aa9bd8d5fd9acf3d8409fd7e3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6890419 Commit-Queue: Mark Łobodziński <mark@lunarg.com> Reviewed-by: Mark Łobodziński <mark@lunarg.com>
Tom Sepez a02670d6 2025-08-26T20:41:16 Move unsafe buffers inside header guard macros While this is exactly opposite of what Chromium has chosen to do, there is an issue with clang-format trying to indent preprocessor directives four spaces relative to include guard. This is because Angle's .clang-format file specifies IndentPPDirectives: AfterHash but Chromium's does not. The current placement is sufficient to throw off clang-format's guard detection since the guard macro no longer covers the entire file. Bug: b/436880895 Change-Id: Ic6b99c8cef6213939cdf9b42af8730e1eb423065 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6885892 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Auto-Submit: Tom Sepez <tsepez@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Takuto Ikuta 6c8df3b1 2025-08-27T17:12:16 infra/config: Remove luci.recipes.use_python3 experiment Python3 is used by default in recipes now and this config is not necessary anymore. Bug: chromium:440235171 Change-Id: I3a4f120f7c824fad7bbe3e45de31b52005bfd0fa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6888195 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
angle-autoroll 96643b13 2025-08-27T11:09:07 Roll vulkan-deps from edbec6047c6c to 4055d497de6c (11 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/edbec6047c6c..4055d497de6c Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/09d803cf217f1128b3111d58bf9853ae9be52bf1..7a5308f4bb40860cccee31d3037feb81bb35a66a https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/a8637796c28386c3cf3b4e8107020fbb52c46f3f..3397e1e4fe0a9964e1837c2934b81835093494b8 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/eb500be643aa8f8eb23dc0e11fe4069ec09a5c88..1d8f536946281ca95a9a03255aaaa73696d96f90 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/2efaa559ff41655ece68b2e904e2bb7e7d55d265..be73614e1dafe7dc4f4867305d4d1b91fe9d1649 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/ade310ac6b62af86e6c7bdbe08a2fab189ed76b6..35a62d3181eb9c238299a62618b49e521f3fe7b2 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/f70655e25a677bb88ad6b50d14414091abf0d33d..3f13668946a3075216275b35b4b9aad2e9b69406 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I7fa07a7e0825ea50278a12f218bf0bded686ab9f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6889161 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 3959b4db 2025-08-27T07:37:58 Roll Chromium from 458ba2f24871 to a8c806abc633 (606 revisions) https://chromium.googlesource.com/chromium/src.git/+log/458ba2f24871..a8c806abc633 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/0d2ae4e988..6920476cbc * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/b9a6526750..4cb1372f8a * testing: https://chromium.googlesource.com/chromium/src/testing/+log/6e7d7ced39..5d0a173278 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/bf3673451d..c3749b59b3 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/0a23f5d9b8..a5fc4c8ab6 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/25f97cc0f1..a8a291787d * third_party/r8/cipd: Xyh7Kdh-M2Dj5lwFGH2QRe7TFErRgYCvMFMkPiYnIwsC..iGVAmwvi7lXeH5SCnaZ0PpcrSL_X8-fC6JbEKfYst-wC * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/eb1877244c..f058a25008 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/622f070e80..9f2bf232b7 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/567370dc60..1e73800b34 * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/563051616f..4b83b80356 No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: I86437e94acd101e180f5cb7e50b9db08cae66548 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6888853 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Tom Sepez 60607c8e 2025-08-25T19:48:41 Activate unsafe buffer enforcement for Angle src/ Single-file patch for easy revert in case we have missed any files needing unsafe buffer suppressions. Bug: b/436880895 Change-Id: I67572c9441e084448ff40443c069db31455484a4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6880744 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Matthew Denton b9cec916 2025-08-12T19:44:18 WGSL: default uniforms gathered in interface block The default uniform struct was being manually output by OutputUniformBlocksAndSamplers(), which did not add the appropriate @align(16) annotations to lay the struct out according to WGSL's uniform address space layout requirements. This CL uses Vulkan's method of gathering the default uniforms into an interface block. The interface block will be output normally by the traverser, including @align() annotations. The variable declaring an instance of the interface block is still output by OutputUniformBlocksAndSamplers() because it needs special @group() and @binding() annotations. Bug: angleproject:376553328 Change-Id: Ib3be7d51ffedefe5ec579a1c9aaf0a535146c694 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6795028 Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by: Liza Burakova <liza@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop 17e99163 2025-08-25T21:19:08 Tests: Add Ace Racer trace Test: angle_trace_tests --gtest_filter="*ace_racer*" Bug: b/441170882 Change-Id: I8a244b2db1c9e62bd401e40ac911e868088c7dba Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6882667 Auto-Submit: Cody Northrop <cnorthrop@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Tom Sepez 25390156 2025-08-21T00:13:19 Suppress unsafe buffers on a file-by-file basis in src/ [1 of N] In this CL, we suppress many files but stop short of actually enabling the warning by not removing the line from the unsafe_buffers_paths.txt file. That will happen in a follow-on CL, along with resolving any stragglers missed here. This is mostly a manual change so as to familiarize myself with the kinds of issues faced by the Angle codebase when applying buffer safety warnings. -- Re-generate affected hashes. -- Clang-format applied to all changed files. -- Add a few missing .reserve() calls to vectors as noticed. -- Fix some mismatches between file names and header comments. -- Be more consistent with header comment format (blank lines and trailing //-only lines when a filename comment adjoins license boilerplate). Bug: b/436880895 Change-Id: I3bde5cc2059acbe8345057289214f1a26f1c34aa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6869022 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Sungyong Choi 616a341b 2025-08-26T13:56:40 Vulkan: Set EGL_NATIVE_VISUAL_ID for EGL_KHR_platform_gbm Spec requires EGLConfig on GBM platform to report a GBM color format in EGL_NATIVE_VISUAL_ID. Previously this field was left unset. This change ensures compliance by assigning the appropriate GBM color format. Bug: angleproject:7829 Change-Id: I6c5a23374824c444e0de0b6592ea31eb855722e4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6882716 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Yuxiang Qian 611f9ac0 2025-08-20T16:10:13 Lower the cap of max element index Currently, ANGLE follows vulkan spec and returns UINT_MAX -1 for GL_MAX_ELEMENT_INDEX. However, ANGLE stores vertex index in int, so even if we use index a little less than the limit, ANGLE would still catch the overflow error. Modify the cap to 2^30 - 1 to make it safer. An end2end test is also added. Bug: angleproject:440227026 Change-Id: Ie089c9847f3908f0e8a1b7c4b83c8fea1cde262e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6870270 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
angle-autoroll c6cab933 2025-08-26T10:01:21 Roll vulkan-deps from 36fbc53c546c to edbec6047c6c (14 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/36fbc53c546c..edbec6047c6c Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/7899f3c1bebd55594e405e0736abf43f700c2c8b..09d803cf217f1128b3111d58bf9853ae9be52bf1 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/8a8bb6c89174ed753eb18a438092ee59356efc3c..eb500be643aa8f8eb23dc0e11fe4069ec09a5c88 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/484f3cd7dfb13f63a8b8930cb0397e9b849ab076..ade310ac6b62af86e6c7bdbe08a2fab189ed76b6 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/0eb12b4ea70b15be6a10f6212c1633e5c9ce0cca..037423da2b2a84f330cb037699ef604ba0d0c94f https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/f45d804fb84c4744667a298e85741161aa98c5d6..f70655e25a677bb88ad6b50d14414091abf0d33d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Iec8e41443e60cd05ba7ff7f954ed8d49a746405d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6883327 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll fb1836c7 2025-08-26T07:22:03 Roll Chromium from 5910372d7545 to 458ba2f24871 (533 revisions) https://chromium.googlesource.com/chromium/src.git/+log/5910372d7545..458ba2f24871 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/77e3784d77..0d2ae4e988 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/e10f12d548..b9a6526750 * buildtools/linux64: git_revision:ee5b7e32b961a9da1933e9f46a018ba6cac8ef60..git_revision:037970ef8d8e5b1d9d3d6defc9aa3886dbfea29a * buildtools/mac: git_revision:ee5b7e32b961a9da1933e9f46a018ba6cac8ef60..git_revision:037970ef8d8e5b1d9d3d6defc9aa3886dbfea29a * buildtools/win: git_revision:ee5b7e32b961a9da1933e9f46a018ba6cac8ef60..git_revision:037970ef8d8e5b1d9d3d6defc9aa3886dbfea29a * testing: https://chromium.googlesource.com/chromium/src/testing/+log/affbdb9289..6e7d7ced39 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/8f103008c5..0bbf370291 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/cc1b6334b8..3c5077921d * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5b7fcc4bb7..bf3673451d * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/aad3b3bddf..0a23f5d9b8 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/0b06c2f825..6bcedec5a3 * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/46631abac7..eb1877244c * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/044b44e6de..caf4afa1af * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/18a43d530a..622f070e80 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/438a542cbc..567370dc60 * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/44e180c753..563051616f No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: I451e2c6adafa754c76ef8b0d5c2952bfa9054d54 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6883326 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mark Lobodzinski 19483cc6 2025-08-25T19:27:26 Tests: Add Bingo Blitz ANGLE trace Test: angle_trace_tests --gtest_filter=*bingo_blitz Bug: b/441137178 Change-Id: Ia463fbc93090d2c55a3f35f7cd34ca6267273c7f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6882619 Reviewed-by: Cody Northrop <cnorthrop@google.com> Auto-Submit: Mark Łobodziński <mark@lunarg.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi 677d8281 2025-08-25T15:59:46 Vulkan: Pass ContextVk to view-creation functions In preparation for moving the ycbcr conversion cache to the share group. This change is a no-op. Bug: angleproject:440364873 Change-Id: I0c18062259b07813dd04ec02650bb6fab48947ad Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6879204 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
kyongjoo.oh 2b45ec65 2025-08-24T12:26:12 CL/VK: Fix default LWS when GWS is less than 64 In the case where LWS is NULL and GWS is smaller than 64, the runtime produces a useless uniform region info. Thus, this change clamps LWS to the GWS to avoid this edge-case. Bug: angleproject:42267067 Change-Id: I418c7d503918f4f082825924b463c266bfd862dc Signed-off-by: kyongjoo.oh <kyongjoo.oh@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6877794 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com>
Shahbaz Youssefi fee2bf73 2025-08-25T15:54:50 Vulkan: Limit EGL_NV_context_priority_realtime to Android Device creation fails on Linux when a REALTIME queue is requested, likely due to permission issues. Bug: angleproject:397474813 Change-Id: I0451db1dac9cbf2795439b251274f1a8057cbd6e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6880530 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
hoonee.cho 5fed937e 2025-08-24T12:21:53 CL/VK: Add a compile option "-inline-entry-points" When processing the -cl-std=CL2.0 option, ensure that the processed options string includes both "-cl-std=CL2.0" and "-inline-entry-points". This change addresses a CLSPV's compiler option check failure where the -inline-entry-points flag was not being added when the -cl-std=CL2.0 (using generic address space) was specified. Bug: angleproject:440814992 Change-Id: Ie3e8907e367f21830e58cd5c405de06ba2cbd1da Signed-off-by: hoonee.cho <hoonee.cho@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6877793 Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Yang Gu 943aed8c 2025-08-25T17:37:34 Skip fake device with remote desktop on Windows When connecting with remote desktop on Windows, a fake device with same vendorId, deviceId, and driverVersion may be reported. This commit adds logic to skip such device to fix end2end tests. Bug: angleproject:440892567 Change-Id: Ie3b602385424bf4a77a302793b34eb06b610bbc9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6878724 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Panfeng Hou d65058be 2025-08-18T11:01:11 Vulkan: Add support for GL_EXT_fragment_shading_rate_primitive Add support for built-in GL_EXT_fragment_shading_rate_primitive and tests. Bug: angleproject:397255625 Change-Id: I0f37a87a73e869a91e39402f01e53166b359ec3c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6850353 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Panfeng Hou <panfeng.hou@arm.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Sungyong Choi 7d6aa630 2025-08-13T15:50:24 Reland: Rename enums to fix GCC -Wchanges-meaning error This is a reland of commit dc24ecca9ed920c0269e9d62dfcac4b3f3e5a4d4 Original change's description: > Renamed enums Key and MouseButton to enum class KeyType and > MouseButtonType to avoid name conflicts with union members in > Event.h on GCC, and to follow the ANGLE style guide preference > for scoped enums. > > BUG: angleproject:438226513 > Change-Id: I8892b438b3b05a3ce4e14f8c0769b81722688da8 > Signed-off-by: Sungyong Choi <sywow.choi@samsung.com> > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6845484 > Commit-Queue: Geoff Lang <geofflang@chromium.org> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Geoff Lang <geofflang@chromium.org> BUG: angleproject:438226513 Change-Id: Ifc1a7bad661881a1a71bd5380fe431270bc68686 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6874206 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuxin Hu f63751db 2025-08-22T10:34:45 Fix the UniformSortComparator not following strict weak order If one uniform is lowp and the other uniform is mediump, then the compare(a, b) and compare (b, a) both return true. This violates the strict weak order rule where: If comp(a, b) == true then comp(b, a) == false This change fixes the bug. Bug: angleproject:405795981 Change-Id: I47e2668fc0fa87ecea9d3f9bce511c9823a39929 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6876519 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Jisun Lee 0af6e4ee 2025-08-13T06:16:01 Vulkan: Check format compatibility to enable mip levels If redefining the texture level is needed while respecifying the image storage, the base level could be incompatible with the max level count. Enabling the whole level count can cause a null pointer dereference when copying an image that does not support `pixelReadFunction`. To handle the problem, this CL checks the format compatibility and enables only the effective base level. Bug: b/435727832 Test: angle_end2end_tests --gtest_filter=DXT1CompressedTextureTest.* Test: angle_end2end_tests --gtest_filter=Texture2DTestES3.* Change-Id: I01060332f282ef9b2856390d0d7296811a464795 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6813835 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov 9eecd3a3 2025-08-25T07:50:36 Revert "Skip clang modules in Android.bp" This reverts commit dddb8a6f815780227f31c982e1f5c7f9e41f40a9. Reason for revert: not needed after https://chromium-review.googlesource.com/c/chromium/src/+/6862663 Bug: chromium:439827607 Original change's description: > Skip clang modules in Android.bp > > These aren't used in Android build, but still listed as dependencies in > GN output and generate_android_bp.py tries to generate rules for them. > > Bug: chromium:439827607 > Change-Id: I01c5c38e15fb4b674f63a6be8ab060e84c381454 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6876280 > Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> > Commit-Queue: Geoff Lang <geofflang@chromium.org> > Auto-Submit: Yuly Novikov <ynovikov@chromium.org> > Reviewed-by: Geoff Lang <geofflang@chromium.org> Bug: chromium:439827607 Change-Id: Ic0406ec99a4fad35cf7009c1bb80b081d318d35a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6875545 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll f86af1ec 2025-08-25T14:12:22 Manual roll VK-GL-CTS from 0a3dad34ebb4 to 3718ed21d713 (19 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/0a3dad34ebb4..3718ed21d713 2025-08-22 marcin.zajac@cognizant.com Fix validation errors in pipeline tests 2025-08-22 rgarcia@igalia.com Test reading from sparse buffers without mapped memory 2025-08-22 michal.jakubek@mobica.com Fix build failure after merging vktComputeCooperativeMatrixOpConstantNullTest 2025-08-22 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.3 into vk-gl-cts/main 2025-08-22 vjaquez@igalia.com Use Vulkan headers generated by CTS in VVS 2025-08-22 lorenzo@khronosgroup.org Temporarily disable code that breaks the build (vktComputeCooperativeMatrixOpConstantNullTests) 2025-08-22 rgarcia@igalia.com Test variable descriptor counts with binding offsets and layout creation 2025-08-22 scerveau@igalia.com video: create missing yuv folder 2025-08-22 erik.faye-lund@collabora.com Merge consecutive lines when stippling 2025-08-22 javed@igalia.com Add coverage for non-resident ssbo read/write 2025-08-22 rgarcia@igalia.com Check maxVariableDescriptorCount makes sense for IUBs 2025-08-22 michal.jakubek@mobica.com OpConstantNull and cooperative matrices 2025-08-22 ziga@lunarg.com Test memory invariance with VkMemoryDedicatedRequirements 2025-08-22 ziga@lunarg.com Enable missing present id2/wait2 features 2025-08-22 ziga@lunarg.com Fix checkSupport in image 2d_array_compatible tests 2025-08-22 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.3 into vk-gl-cts/main 2025-08-20 piotr.byszewski@mobica.com Restore tests for packing rules for arrays 2025-08-19 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkansc-cts-1.0.3 into vk-gl-cts/main 2025-08-15 marcin.zajac@cognizant.com Fix validation errors in image tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com,ynovikov@google.com Change-Id: Iac6990203d191887c56485640e36d6c16957b24a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6879341 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuxiang Qian 51cffa97 2025-08-13T14:23:51 Implement EGL_NV_context_priority_realtime In this extension, new attribute value EGL_CONTEXT_PRIORITY_REALTIME_NV is accepted for EGL_CONTEXT_PRIORITY_LEVEL_IMG. In ANGLE, this extension should depend on VK_EXT_global_priority and VK_EXT_global_priority_query. The implementation of creating device queue is also modified for this new attribute value. New end2end test is added to check if this new attribute works. Bug: angleproject:397474813 Change-Id: I68316fe371f5a495dbc78b106fc89787be18e086 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6857673 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov 0bc3514b 2025-08-25T12:21:30 Roll chromium_revision f7c7637e7e..5910372d75 (1504994:1505803) Manual roll due to Siso path change in https://chromium-review.googlesource.com/c/chromium/src/+/6878583 Change log: https://chromium.googlesource.com/chromium/src/+log/f7c7637e7e..5910372d75 Full diff: https://chromium.googlesource.com/chromium/src/+/f7c7637e7e..5910372d75 Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/28fc2a8926..77e3784d77 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/5c2d6c70af..e10f12d548 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/f8580aca7e..affbdb9289 * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/d48cf42075..0c9a24dacc * third_party/android_build_tools/error_prone/cipd: vPi1VfStH9EQCdbZI5NAMcK7C_dWs3-8Frr1CAzIafEC..R8e42R2txro2We-fzwv-mCywXVgBpacnAx2ln84t9ZkC * third_party/android_build_tools/lint/cipd: wz3jGm7ZRm38JBU96mWdB_kyuGynEgbN_KAIvibvbAsC..-JcaCbcpT3Q0in-E0Q-DQ8raNBQTA0mTz6N_smsM-YwC * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/380bbf9e37..5b7fcc4bb7 * third_party/fuchsia-sdk/sdk: version:29.20250815.6.1..version:29.20250824.3.1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/91206b4d03..aad3b3bddf * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/2b79b2b486..25f97cc0f1 * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/5d5c1435d7..46631abac7 * third_party/siso/cipd: git_revision:7e3433bde6dcf9d760b0423c5f47c51e65c7c0fa..git_revision:15568691576f74b11a3c73c85a3c8dd5efb72f05 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/7d8848041e..18a43d530a * tools/luci-go: git_revision:230495e01666a7468ff6803179519a5c93317083..git_revision:d404c33558d672701abed8ca167cfe06f36fa59e * tools/luci-go: git_revision:230495e01666a7468ff6803179519a5c93317083..git_revision:d404c33558d672701abed8ca167cfe06f36fa59e * tools/luci-go: git_revision:230495e01666a7468ff6803179519a5c93317083..git_revision:d404c33558d672701abed8ca167cfe06f36fa59e * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/228d7968ff..438a542cbc * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/7074a194d0..44e180c753 * tools/skia_goldctl/linux: 46Onf_f3s_Mr84pViZFnexVYU47ArSn3knDqNZcIoYsC.._0gFCSj5cqOmXXe-Atkb0kcFChMiI0RIeaA-mAYHxUIC * tools/skia_goldctl/mac_amd64: itdWmANhuoNsgIG1DuIe7XMdwQR4Vc9kkznuHSuPOekC..b-j1EfuXxMKGgGvSsu998B3Py6Im2cjyVMMFGXVabJYC * tools/skia_goldctl/mac_arm64: aFRLGxnuqC86Y3ejs72PnkJfG0caCnrl72QiuxJ1XbkC..5lVrW5FJxzBE4lA0U1My-WYSBvHmTH2hooKWml9VnKYC * tools/skia_goldctl/win: sYuoNL-siny-CypUt4LuqE25k1hWho4rLa3T7ikBQAoC..LdKqwqTVZ9jhO6opMlduYqa3AuEfV6Pt-cs1Bjgi3fwC DEPS diff: https://chromium.googlesource.com/chromium/src/+/f7c7637e7e..5910372d75/DEPS No update to Clang. Bug: None Change-Id: Ia6ecfa01fc26933781f296f61e21382ecf644e53 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6876282 Commit-Queue: Cody Northrop <cnorthrop@google.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
angle-autoroll c8a9965a 2025-08-25T05:43:28 Roll SwiftShader from 5b45bdb479fa to 0390a544a952 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/5b45bdb479fa..0390a544a952 2025-08-25 swiftshader.regress@gmail.com Regres: Update test lists @ 5b45bdb4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I6341955c7f21cfa446685157cf16b8be1b464421 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6879273 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 9280c6b9 2025-08-20T08:04:15 Roll VK-GL-CTS from ad59a18f2ce0 to 0a3dad34ebb4 (60 revisions) Skip dEQP-GLES31.functional.copy_image.non_compressed.viewclass_16_bits.*.texture2d_array_to_texture3d dEQP-GLES31.functional.copy_image.non_compressed.viewclass_32_bits.* dEQP-GLES31.functional.copy_image.non_compressed.viewclass_64_bits.*.texture2d_array_to_texture3d on Pixel 4 Vulkan https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/ad59a18f2ce0..0a3dad34ebb4 2025-08-15 lorenzo@khronosgroup.org Merge "Merge vk-gl-cts/github-main into vk-gl-cts/main" into main 2025-08-15 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.3 into vk-gl-cts/main 2025-08-14 mateusz.bahyrycz@mobica.com Add tests for copying invalid binding 2025-08-14 ziga@lunarg.com Add HIC tests for all formats and reduce other variations 2025-08-14 rgarcia@igalia.com Test buffer and image capture&replay re-usage with descriptor buffer 2025-08-14 mateusz.bahyrycz@mobica.com Add tests for writting unused and invalid binding 2025-08-14 mateusz.bahyrycz@mobica.com Add tests for image to buffer copy for color formats 2025-08-14 rgarcia@igalia.com Modify suspend/resume FDM offset tests to use consistent offsets 2025-08-14 ziga@lunarg.com Fix image barrier issues in render_to_image tests 2025-08-14 ziga@lunarg.com Fix invalid access mask in buffer_view compute tests 2025-08-14 ziga@lunarg.com Fix image layout transitions in image 2d_array_compatible tests 2025-08-14 lorenzo@khronosgroup.org Update SPIR-V sources: replace gl_SemanticsRelaxed in atomicStore when used with non-zero storage class semantics 2025-08-14 piotr.byszewski@mobica.com Fix hlsl_functionality1.counter_buffer on spirv-tools TOT 2025-08-14 syoussefi@google.com GLES: Fix debug tests not clearing the error (if no message) 2025-08-11 lorenzo@khronosgroup.org Merge remote-tracking branch 'vk-gl-cts/dev/VK_KHR_shader_untyped_pointers' into main 2025-08-11 lorenzo@khronosgroup.org Update Vulkan headers to v1.4.325 2025-08-08 ziga@lunarg.com Test presenting image from retired swapchain 2025-08-08 piotr.byszewski@mobica.com Test computing LOD from explicit cubemap derivatives 2025-08-08 gleese@broadcom.com Enable some low-bit-depth bitfield tests without maint9 2025-08-08 ziga@lunarg.com Fix maintenance9 check in query pool get_create_reset tests 2025-08-08 ziga@lunarg.com Add missing barrier in sample locations tests 2025-08-08 ziga@lunarg.com Fix layer count in geometry layered tests 2025-08-08 ziga@lunarg.com Fix reading from image in undefined layout in query pool tests 2025-08-08 david.rosca@amd.com Don't require all modifiers to be compatible with video 2025-08-08 lorenzo@khronosgroup.org Complete automatic JSON generation for all remaining KHR extensions 2025-08-08 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.3 into vk-gl-cts/main 2025-08-05 lorenzo@khronosgroup.org Update Vulkan headers to 1.4.324 2025-08-01 zzoon@igalia.com Replace the customized parser with one in VVS Khronos. 2025-08-01 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.12 into vk-gl-cts/main 2025-08-01 lorenzo@khronosgroup.org Add JSON files for VK_KHR_present_id2 and VK_KHR_present_wait2 2025-08-01 lorenzo@khronosgroup.org Merge remote-tracking branch 'vk-gl-cts/dev/VK_KHR_present_id2' into main 2025-08-01 abdolrashidi@google.com Shift fixed-point value if between accepted values 2025-08-01 rgarcia@igalia.com Test descriptor buffer with 3-plane image formats 2025-08-01 rgarcia@igalia.com Check baseTriangle is honored in opacity micromap tests 2025-08-01 rgarcia@igalia.com Test large number of compute and task DGC sequences 2025-08-01 rgarcia@igalia.com Check maxMipLevels/maxArrayLayers in compressed image copy tests 2025-08-01 david.rosca@amd.com Don't call vkCmdFillBuffer on unsupported queues 2025-08-01 michal.jakubek@mobica.com Reduce link time and disk space for Capabilities 2025-08-01 michal.jakubek@mobica.com Unwritten attachments with dual-source blending 2025-08-01 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.3 into vk-gl-cts/main 2025-08-01 lorenzo@khronosgroup.org Auto-generate JSON for VK_EXT_fragment_density_map_offset 2025-08-01 lorenzo@khronosgroup.org Merge remote-tracking branch 'vk-gl-cts/dev/VK_EXT_fragment_density_map_offset' into main 2025-07-25 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-cts-4.6.6 into vk-gl-cts/main 2025-07-25 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.12 into vk-gl-cts/main 2025-07-25 ziga@lunarg.com Fix bad merge 2025-07-25 ziga@lunarg.com Add tests for ms input attachment feedback loop 2025-07-25 ziga@lunarg.com Test OpImageSampleImplicitLod with RelaxedPrecision and ycbcr image 2025-07-25 nikigupta@google.com Add test for gl_Position not declared inside built-in block in geometry shader 2025-07-25 marcin.zajac@cognizant.com Degenerate triangles in AS update 2025-07-25 david.rosca@amd.com Skip unsupported AV1 encode tiling tests according to maxTiles cap 2025-07-25 ziga@lunarg.com Fix errors in maintenance9 2d_array_compatible image tests 2025-07-25 ziga@lunarg.com Test writes to partially bound ds attachments are discarded 2025-07-25 gleese@broadcom.com Fix identity checking in subgroup scan tests 2025-07-25 lorenzo@khronosgroup.org Add auto-generation for existing KHR extensions (simple ones) 2025-07-25 scerveau@igalia.com VideoEncodeTestsAV1: keep same name for input filename 2025-07-25 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.3 into vk-gl-cts/main 2025-07-24 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.3 into vk-gl-cts/main 2025-07-24 lorenzo@khronosgroup.org Add logging and checking for missing JSONs for VK_KHR extensions 2025-07-24 lorenzo@khronosgroup.org Add VK_KHR_video_encode_intra_refresh JSON 2025-07-23 okuznetsov@google.com Add full image level copy tests to es31fCopyImageTests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:440743718 Change-Id: I9313b003dc8ae2a1dd64d264fa2b7847ae2b02ad Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6865062 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll bd06fd86 2025-08-25T10:01:37 Roll vulkan-deps from d74c51b56a14 to 36fbc53c546c (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/d74c51b56a14..36fbc53c546c Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/c60142fc3f6f0d3599614775ee425664003b9915..f45d804fb84c4744667a298e85741161aa98c5d6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I6d7fed2f8c0784d4e0134def76ed77a9d4e87407 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6879313 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
jh.eun 061a43c6 2025-08-13T16:35:20 CL/Vulkan: Implement cl_khr_priority_hints cl::CommandQueue contains queue priority from clCreateCommandQueueWithProperties. Similar to EGL_IMG_context_priority, a queue with a pre-assigned priority is selected when submission. Bug: angleproject:433980937 Tests-Passing: OCLCTS.test_api queue_hint Change-Id: I3a7bcc62e5d8186b51f771ab2c01cc18ddfcd195 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6785088 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com>
Mark Lobodzinski 8d43d9b9 2025-08-21T21:15:06 Tests: Add Hunter Assassin ANGLE trace Test: angle_trace_tests --gtest_filter=*hunter_assassin Bug: b/440565036 Change-Id: I502db22ba7967406f61ffa1437865992b05c1a34 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6876526 Auto-Submit: Mark Łobodziński <mark@lunarg.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Raja Wasim Husain 8ef76b6a 2025-08-04T12:34:17 CL/Vulkan: cl_khr_external_memory extension (pt.2) - Make this extension visible if Vulkan implementation support features supportsExternalMemoryFd and/or supportsExternalMemoryDmaBuf - Implemented APIs clEnqueueAcquireExternalMemObjectsKHR and clEnqueueReleaseExternalMemObjectsKHR - Updated clCreateBufferWithProperties to handle external memory file descriptor. Bug: angleproject:378017028 Change-Id: I1751982c8e9b2cd07b7e251cc54db5dcd1bcda20 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6843980 Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuxin Hu d4d42356 2025-08-22T11:30:42 Remove the duplicated branch There is no code difference in the if and the else branches, remove the duplicated branch. Bug: angleproject:405795981 Change-Id: If593476d2b5cd02567ed1896625072128cf21b0f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6876346 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Yuly Novikov dddb8a6f 2025-08-22T17:26:02 Skip clang modules in Android.bp These aren't used in Android build, but still listed as dependencies in GN output and generate_android_bp.py tries to generate rules for them. Bug: chromium:439827607 Change-Id: I01c5c38e15fb4b674f63a6be8ab060e84c381454 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6876280 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Geoff Lang <geofflang@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Yuxiang Qian 1f83d739 2025-08-01T16:59:11 Expose VK_EXT_global_priority and VK_EXT_global_priority_query To implement EGL_NV_context_priority_realtime, VK_EXT_global_priority and VK_EXT_global_priority_query should be exposed. With these extensions, we can query supported global priority and set global priority for the Vulkan queue. Bug: angleproject:397474813 Change-Id: I83f9f19d46f3c81b02246aae2892f7a9c1a09d1d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6857671 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Brian Sheedy 660c7b72 2025-08-21T15:06:38 Do not store tombstones on S24 devices Adds the no_tombstones mixin and applies it to the S24 tester since attempting to interact with tombstones on these devices with Android 15 runs into permission issues. Bug: chromium:419062315 Change-Id: If188e6ee94182e4a0ceefea76e4099b306cd268a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6872950 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Yuly Novikov c8e85760 2025-08-22T12:57:15 Roll chromium_revision 5992a4bbb9..f7c7637e7e (1504674:1504994) Manual roll due to https://chromium-review.googlesource.com/c/chromium/src/+/6873182 Change log: https://chromium.googlesource.com/chromium/src/+log/5992a4bbb9..f7c7637e7e Full diff: https://chromium.googlesource.com/chromium/src/+/5992a4bbb9..f7c7637e7e Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/8c5791ed4d..28fc2a8926 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/a54e78183b..f8580aca7e * third_party/android_build_tools/lint/cipd: 8i-9CpSofgFA-RhKjreXIK0ZbDC8IhGVe2yvxRX0ku4C..wz3jGm7ZRm38JBU96mWdB_kyuGynEgbN_KAIvibvbAsC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/96c34700fd..cc1b6334b8 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/778a576e20..380bbf9e37 * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/bdc00ca63e..c948b3c916 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/46fede94c0..2b79b2b486 * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/cc36abecbc..5d5c1435d7 * third_party/siso/cipd: git_revision:fac028f33f398558bd6e73380eb3327545751171..git_revision:7e3433bde6dcf9d760b0423c5f47c51e65c7c0fa * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/5ee6c221d1..d9f910bd0f * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/fabc68d394..228d7968ff * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/f2fba99158..7074a194d0 DEPS diff: https://chromium.googlesource.com/chromium/src/+/5992a4bbb9..f7c7637e7e/DEPS No update to Clang. Bug: b/440182383 Change-Id: I43f5bb53919e96f683663d7c1d95168fcb0d2cd4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6874905 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuxin Hu 01cfb98f 2025-08-14T14:17:28 Add a new property to LinkedUniform struct The new property isTransformedFloat will be used by front end API to determine if we should transform 32-bit float to 16-bit float before writing to memory, and transform 16-bit float to 32-bit float after reading from memory. The property value will be passed from UsedUniform (child struct of ShaderVariable) object in UniformLinkder::getResults(). This CL is no op. Bug: angleproject:405795981 Change-Id: Ic4908712f5fa56cb657206a25d9d618b51ac6322 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6851554 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Yuxin Hu 20dca0b9 2025-08-14T13:54:37 Add a new TInterfaceBlock class member to hint ANGLE default Uniform In later change, we will transform floats in ANGLE default uniform struct from 32-bit to 16-bit in SPIRV. The new class member mIsDefaultUniformBlock will help us identify this special struct. This change is no op. Bug: angleproject:405795981 Change-Id: I939caf7491ab5d7de130ba6a2fd8b1202958c375 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6852398 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Yuly Novikov ef80e82f 2025-08-22T15:07:59 Skip slow test on Mac Metal AMD GLSLTest_ES3.ManySamplerFieldsInStructComplex/ES3_Metal takes 38 seconds and causes batch timeouts. Bug: angleproject:440536251 Change-Id: I53ad821bc4da4696609f9b8c0f5cbee1ed94dbd1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6874571 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Geoff Lang 86a8d11c 2025-08-11T16:45:39 Metal: Fix potential incorrect format used for texSubImage TextureMtl caches the most recent format used for a texture redefinition in mFormat. During subImage calls, this format may not be the same as the image being uploaded to. Pass ImageDefinitionMtl to these functions which reference mFormat, it contains the format of the image being updated. MacOS OpenGL is skipped because the driver generates errors in glCompressedTexImage2D. Bug: chromium:435683799 Change-Id: Idec6f71870c2d376cad3a5e3628b957009bdced9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6838878 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Quyen Le <lehoangquyen@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
angle-autoroll e0069178 2025-08-22T10:01:31 Roll vulkan-deps from 24f6a1bae736 to d74c51b56a14 (18 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/24f6a1bae736..d74c51b56a14 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/fcf4e9296fa400e2b03c34e23b261e0c8a0ac34d..7899f3c1bebd55594e405e0736abf43f700c2c8b https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/68daa9bc0602e057a36c83fe4dcc441c9bd38447..a906345b8a7bccc416b006b2048e13f40d9b2327 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/925b0bd1eeb3ea1ceb18e2bb5929575b0cfb3f67..8a8bb6c89174ed753eb18a438092ee59356efc3c https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/e14b595d2441ada4247a811c4266ac542dd78f08..c60142fc3f6f0d3599614775ee425664003b9915 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I6dff397f291241eac4c7ba7b41506d65e4fc4a29 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6874825 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mark Lobodzinski d0ba2fb9 2025-08-20T12:16:07 Tests: Add Onmyoji ANGLE trace Test: angle_trace_tests --gtest_filter=*onmyoji Bug: b/440323747 Change-Id: Ia549dcfa370fac23785364adb717babde8b8ca4d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6871872 Commit-Queue: Mark Łobodziński <mark@lunarg.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
angle-autoroll dee1fcbf 2025-08-21T20:18:16 Manual roll Chromium from fc7a6f6aa138 to 5992a4bbb953 (175 revisions) Manual roll requested by bsheedy@google.com https://chromium.googlesource.com/chromium/src.git/+log/fc7a6f6aa138..5992a4bbb953 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,bsheedy@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/598d39bd27..8c5791ed4d * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/311f10f06a..5c2d6c70af * testing: https://chromium.googlesource.com/chromium/src/testing/+log/62256178de..a54e78183b * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/8512c34797..96c34700fd * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/28e24a669f..0b06c2f825 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/f10114ce19..5ee6c221d1 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/88de4dbaab..fabc68d394 No update to Clang. Bug: None Tbr: ynovikov@google.com,bsheedy@google.com Change-Id: I720bba140540c8cd8aad9544810d2c0af6dd7f32 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6872725 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov c5a4aaab 2025-08-21T12:34:30 Roll chromium_revision c57f111ea1..fc7a6f6aa1 (1504489:1504499) This includes fixes to several breakages: 1. Change siso path in DEPS due to https://chromium-review.googlesource.com/c/chromium/src/+/6864442 2. For unknown reason, "gclient sync --deps=all" no longer downloads mac dependencies on linux. Change conditions for buildtools/mac and others from host_os to checkout_mac, so that roll_chromium_deps can process these dependencies. 3. Remove third_party/googletest (BUILD.gn) submodule and copy build files from Chromium verbatim. Then add third_party/googletest/src submodule, which was previously added via recursedeps. This is because old structure had to be updated manually, and now we can autoroll googletest. Making this change now, because is_nacl was removed in https://chromium-review.googlesource.com/c/chromium/src/+/6857278 but the corresponding removal from BUILD.gn https://chromium-review.googlesource.com/c/chromium/src/+/6723712 didn't get rolled in due to crbug.com/440040381. Also roll googletest sources while at it. https://chromium.googlesource.com/external/github.com/google/googletest/+log/c67de117379f4d1c889c7581a0a76aa0979c2083..244cec869d12e53378fa0efb610cd4c32a454ec8 4. Use "use_clang_modules = false" to suppress missing includes in LLVM. 5. Add "tools/win" dependency needed for abseil-cpp after https://chromium-review.googlesource.com/c/chromium/src/+/6857983 Change log: https://chromium.googlesource.com/chromium/src/+log/c57f111ea1..fc7a6f6aa1 Full diff: https://chromium.googlesource.com/chromium/src/+/c57f111ea1..fc7a6f6aa1 Changed dependencies * buildtools/mac: git_revision:cc7c61e105fb56183fd6c5c52bbe3c37ff724a0d..git_revision:ee5b7e32b961a9da1933e9f46a018ba6cac8ef60 * buildtools/win: git_revision:cc7c61e105fb56183fd6c5c52bbe3c37ff724a0d..git_revision:ee5b7e32b961a9da1933e9f46a018ba6cac8ef60 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/fb889d0363..62256178de * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/1e18dc54a0..4862f4f12d * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/f43e2cc47f..d48cf42075 * third_party/android_build_tools/error_prone/cipd: wQ_Wsj0aINAwt4LrHHM6IEnMhVEAdvQtBFtLv7YL4PoC..vPi1VfStH9EQCdbZI5NAMcK7C_dWs3-8Frr1CAzIafEC * third_party/android_build_tools/lint/cipd: XO6ykSsPN632w1Hwz4YCLW0qC1KhVCn53F8FdJeuhKUC..8i-9CpSofgFA-RhKjreXIK0ZbDC8IhGVe2yvxRX0ku4C * third_party/android_build_tools/nullaway/cipd: mFkUqdlIqmMQ3rAaTHFmOBYjNFgFUQOmMlPG6PGgmHYC..Zk_ffB0B6qGrr2ZDKqCxAgnPmo4-5giVRIauRffZaZYC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/973ea8c7c6..8f103008c5 * third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/e71ef403c5..f1c6b36cde * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/8dc29cff6c..8512c34797 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/eddc72dce5..778a576e20 * third_party/fuchsia-sdk/sdk: version:29.20250730.5.1..version:29.20250815.6.1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/6f8fe913d6..91206b4d03 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/a6c815c69d..f7f5a32b3e * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/84c5262b57..bdc00ca63e * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/82c07b9654..46fede94c0 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/78c1ca719e..28e24a669f * third_party/r8/cipd: qD5apdNjxRv3dBblf27nEZYf7r_pbLEgfN7hWyXvP_UC..Xyh7Kdh-M2Dj5lwFGH2QRe7TFErRgYCvMFMkPiYnIwsC * third_party/r8/d8/cipd: qD5apdNjxRv3dBblf27nEZYf7r_pbLEgfN7hWyXvP_UC..pBaBgtFdvclLMBwz1H7s88bhc3ioF8iEyFh6rZ81054C * third_party/re2/src: https://chromium.googlesource.com/external/github.com/google/re2.git/+log/85c7c0fb11..6569a9a3df * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/5de5e7b6ba..cc36abecbc * third_party/turbine/cipd: TkTaFqF4Bs-JmFtxFV_Nfh4u5jh_401ZQsLhC7vIEqQC..9ZS5YYFBth7RSqNe7VLip-qJhk00WoicV_Qb0byHna8C * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/363a126ed2..044b44e6de * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/b44ad70ef5..7d8848041e * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/9d91ec919b..f10114ce19 * tools/luci-go: git_revision:2aa8d904a9f8cc8891d2710e4cf58156057fa4b3..git_revision:230495e01666a7468ff6803179519a5c93317083 * tools/luci-go: git_revision:2aa8d904a9f8cc8891d2710e4cf58156057fa4b3..git_revision:230495e01666a7468ff6803179519a5c93317083 * tools/luci-go: git_revision:2aa8d904a9f8cc8891d2710e4cf58156057fa4b3..git_revision:230495e01666a7468ff6803179519a5c93317083 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/c5719eb114..513bc2117e * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/c1a26b544f..88de4dbaab * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/fa1df48579..f2fba99158 * tools/skia_goldctl/linux: 84tAKAqEtqjebJywg8jyXDWUVodNBYZraFt9RZ0A2pwC..46Onf_f3s_Mr84pViZFnexVYU47ArSn3knDqNZcIoYsC * tools/skia_goldctl/mac_amd64: dpgLOuWsqpBYSIj44DbnlJD7fnp640TD4cprUlwV0VMC..itdWmANhuoNsgIG1DuIe7XMdwQR4Vc9kkznuHSuPOekC * tools/skia_goldctl/mac_arm64: AU5OTil4VjYO94g8-Jhq02qBoLka6t-JsgKKEzllcy8C..aFRLGxnuqC86Y3ejs72PnkJfG0caCnrl72QiuxJ1XbkC * tools/skia_goldctl/win: DW55Ki0OZtTTzxrsItNbFeB9IDA9GBVXB647W6SOLN4C..sYuoNL-siny-CypUt4LuqE25k1hWho4rLa3T7ikBQAoC DEPS diff: https://chromium.googlesource.com/chromium/src/+/c57f111ea1..fc7a6f6aa1/DEPS No update to Clang. Bug: chromium:440040381, angleproject:40041909, angleproject:439777063 Change-Id: Id814e849a08a1533c246ed9d1803f8b7c90fa68b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6870430 Reviewed-by: Geoff Lang <geofflang@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Raja Wasim Husain 6c160cad 2025-08-04T12:32:36 CL/Vulkan: cl_khr_external_memory extension (pt.1) - Make this extension visible if Vulkan implementation support features supportsExternalMemoryFd and/or supportsExternalMemoryDmaBuf - Implemented APIs clEnqueueAcquireExternalMemObjectsKHR and clEnqueueReleaseExternalMemObjectsKHR - Updated clCreateBufferWithProperties to handle external memory file descriptor. Bug: angleproject:378017028 Change-Id: Idff08808bc0227b5f98b84c2086b68541665146d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6785087 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com>
angle-autoroll b3ab485f 2025-08-21T03:01:33 Roll SwiftShader from a1b94a283161 to 5b45bdb479fa (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/a1b94a283161..5b45bdb479fa 2025-08-20 cwallez@chromium.org Support a variable descriptor count of 0. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I92d4c4a4b027e3227cbbabe4d095cac3e94c70c8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6869718 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mark Lobodzinski 995c4c4d 2025-08-20T12:14:47 Capture/Replay: Target GLES3.1 to avoid SSO limitations Retracing with get_min_reqs can produce results which limit trace portability. Modify retrace script to detect when GL_EXT_separate_shader_objects is required, and then to increase min_version to 3.1 where this ext was moved to core and remove the ext from the required list. Test: angle_trace_tests --gtest_filter=*onmyoji --use-gl=native Bug: b/440102792 Change-Id: I36258fd7b9b5c5aa3e87ad9908849ef2a900e898 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6866639 Auto-Submit: Mark Łobodziński <mark@lunarg.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Liza Burakova 03068e0c 2025-08-20T17:36:22 [WebGPU] Implement direct copy for images. This CL implements CopyImage specifically in cases where the source is the same size and format as the destination. Bug: angleproject:438268609 Change-Id: Icf5f3685bb2f49874d996883c839515314f1c189 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6842317 Commit-Queue: Liza Burakova <liza@chromium.org> Reviewed-by: Matthew Denton <mpdenton@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tim Van Patten 5d9d9b9b 2025-08-19T17:12:03 test: Use eglGetPlatformDisplay() From the EGL 1.5 spec: Appendix F Version 1.5 EGL version 1.5 was voted out of the Khronos Technical Working Group on January 31, 2014, and formally approved by the Khronos Board of Promoters on March 14, 2014. EGL 1.5 is the sixth release of EGL. It introduces the following new features (the EGL extension(s) each feature is based on are also shown parenthetically): * Platform support: – Providing a mechanism for support of multiple platforms (such as window systems or offscreen rendering frameworks) in a single EGL implementation at runtime (EGL_EXT_platform_base). Until https://crrev.com/c/6552257, many tests used eglGetPlatformDisplayEXT() which is provided by the EGL extension EGL_EXT_platform_base. With the promotion of the EGL_EXT_platform_base functions to core EGL in version 1.5 and ANGLE supporting EGL 1.5 (as of at least 2019), the calls were updated to use eglGetPlatformDisplay(). Unfortunately, EGLContextPassthroughShadersTest was missed. Bug: b/409384875 Test: angle_end2end_tests Change-Id: I5c620bce98c8e76113588f4c94b77d95a5223171 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6862841 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
Raja Wasim Husain 6ff016fb 2025-03-31T09:52:14 CL/Vulkan: Update caps for image1d_buffer max size Updated max number of pixels for a 1D image created from a buffer object to come from VK implementation. Bug: angleproject:406022415 Change-Id: I56e9821895245c3a3655ca0c4afbe49ed89baded Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6386422 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com>
Yuly Novikov ccbc9e9b 2025-08-20T05:28:12 Revert "Rename enums to fix GCC -Wchanges-meaning error" This reverts commit dc24ecca9ed920c0269e9d62dfcac4b3f3e5a4d4. Reason for revert: breaks ios-simulator build when rolled to Chromium https://chromium-review.googlesource.com/c/chromium/src/+/6863632 https://ci.chromium.org/ui/p/chromium/builders/try/ios-simulator/2446924/overview [10968/78005] OBJCXX obj/third_party/angle/util/angle_util_static/IOSWindow.o sdk/xcode_links/iPhoneSimulator18.2.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSDictionary.h:17:38: error: reference to 'KeyType' is ambiguous 17 | - (nullable ObjectType)objectForKey:(KeyType)aKey; BUG: angleproject:438226513 Original change's description: > Rename enums to fix GCC -Wchanges-meaning error > > Renamed enums Key and MouseButton to enum class KeyType and > MouseButtonType to avoid name conflicts with union members in > Event.h on GCC, and to follow the ANGLE style guide preference > for scoped enums. > > BUG: angleproject:438226513 > Change-Id: I8892b438b3b05a3ce4e14f8c0769b81722688da8 > Signed-off-by: Sungyong Choi <sywow.choi@samsung.com> > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6845484 > Commit-Queue: Geoff Lang <geofflang@chromium.org> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Geoff Lang <geofflang@chromium.org> Bug: angleproject:438226513 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Iff0d925b9fa608215cff0e472074a0315f14e861 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6863019 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
angle-autoroll 25440a9d 2025-08-20T10:01:04 Roll vulkan-deps from 6ab6cf8994f3 to 24f6a1bae736 (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/6ab6cf8994f3..24f6a1bae736 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/a2834ad28b4fdeef23d130a53b58a6d4b69ea149..925b0bd1eeb3ea1ceb18e2bb5929575b0cfb3f67 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/9000c2f6eef9f5b7bfa7b43d13fd73b4893644da..e14b595d2441ada4247a811c4266ac542dd78f08 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: Ic8f5a1e64f5192c12c74e24df168473596d8f42a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6865326 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Sungyong Choi dc24ecca 2025-08-13T15:50:24 Rename enums to fix GCC -Wchanges-meaning error Renamed enums Key and MouseButton to enum class KeyType and MouseButtonType to avoid name conflicts with union members in Event.h on GCC, and to follow the ANGLE style guide preference for scoped enums. BUG: angleproject:438226513 Change-Id: I8892b438b3b05a3ce4e14f8c0769b81722688da8 Signed-off-by: Sungyong Choi <sywow.choi@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6845484 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll ea47e07b 2025-08-19T03:01:55 Roll SwiftShader from fed7f25ca957 to a1b94a283161 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/fed7f25ca957..a1b94a283161 2025-08-18 swiftshader.regress@gmail.com Regres: Update test lists @ fed7f25c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I9668441798725df7f535696a76062a725ec3ef27 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6861554 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b553f6b4 2025-08-19T10:01:18 Roll vulkan-deps from a82edf807749 to 6ab6cf8994f3 (10 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/a82edf807749..6ab6cf8994f3 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/0f2400cd75c540a2fea883d780bf752c57b35b30..fcf4e9296fa400e2b03c34e23b261e0c8a0ac34d https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/e6d5e88c07cc66a798b668945e7fb29ec1cfee27..a8637796c28386c3cf3b4e8107020fbb52c46f3f https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/fda5a216e9d25fa2eeda73ec8436b96e395ce5d5..a2834ad28b4fdeef23d130a53b58a6d4b69ea149 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/dd409bf3329eb4002f87f7ce7fcc315c9a922583..9000c2f6eef9f5b7bfa7b43d13fd73b4893644da If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: Icbd114ced2dc710afea9c1ac2b2d33fde6f5e167 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6861452 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Sungyong Choi da5a5628 2025-08-11T10:53:06 bitset_utils: Fix GCC shift-count-overflow warning GCC triggers a -Werror=shift-count-overflow when kDefaultBitSetSize is 64, due to the constructor compiling a branch with `value >>= 64`. Although this path is never executed at runtime, GCC still inspects the code and emits the warning as an error. Refactored the constructor to: - Move common reset() into a single place - Split initialization into initFromValue<S>() overloads enabled only for S < 64 or S >= 64 via std::enable_if_t - Avoid generating any shift code when S >= 64 This change ensures GCC does not instantiate invalid shift operations and keeps the initialization logic cleaner. BUG: angleproject:438226513 Change-Id: I1ed0b42540f1bfce469d5738757045bc6d92ac61 Signed-off-by: Sungyong Choi <sywow.choi@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6845475 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Tom Sepez ff95cc93 2025-08-15T22:05:15 Enable clang unsafe buffers warnings for ANGLE. Then suppress all directories containing C++ source code to get a good initial state. Bug: b/436880895 Change-Id: Ib1e23015896078af7a1bec7d22cafdcd1fc713e2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6854299 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi 89295de2 2025-08-17T22:53:56 Vulkan: Don't define VK_USE_PLATFORM_XLIB_KHR Bug: angleproject:42266945 Change-Id: Iaf6cbb18358d95089fd4b6cd0f3ce23020cefa4c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6856878 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Sungyong Choi 68baeeeb 2025-08-12T15:51:07 State: avoid GCC -Waddress by using constexpr null-check helper GCC with -Waddress warns that the static_assert comparing `handlers[0] != nullptr` is always true when MakeDirtyObjectHandlers() fully initializes the array. During constant evaluation, handlers[0] is replaced with the specific member function address (&State::syncActiveTextures), which can never be null, making the comparison tautological. This change replaces the direct `handlers[0] != nullptr` check with a constexpr helper that iterates over all handlers and verifies none are null. By comparing each element in a loop, the check still runs at compile time (constexpr), but avoids a direct “function address vs nullptr” pattern that triggers -Waddress. BUG: angleproject:438226513 Change-Id: Iaa8441000f8b2aa28c44d17730ca223fd4d4595b Signed-off-by: Sungyong Choi <sywow.choi@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6845477 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Sungyong Choi 39265327 2025-08-13T08:05:24 Fix BindDescriptorSetParams bit-field size and -Wpadded warning Replace pipelineBindPoint : 8 with full VkPipelineBindPoint to hold all enum values. Reorder members and adjust bit-field widths to pack within 32-bit units, adding explicit padding to eliminate compiler-inserted padding and silence -Wpadded. BUG: angleproject:438226513 Change-Id: I8950fcb10d5796bd8485791f63980a2905179324 Signed-off-by: Sungyong Choi <sywow.choi@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6845479 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Tom Sepez 7d8f0748 2025-08-06T20:12:29 Use the chrome plugin in select Angle build recipes Turn on the chrome plugin for use in future CLs so that additional checks may be someday performed against this code base. This CL should not affect any generated code or produce additional warnings. To do so, remove find_bad_constructs as code was not compliant, just not subject to the plugin. Bug: b/436880895 Change-Id: I73bcc263fe0fe1656bce5a75a74e270ecf004362 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6825145 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alex Dean 9bd6785d 2025-08-12T15:19:08 Revert "Tests: Skip CapturedTestCL to unblock vulkan-deps roll" This reverts commit 2a5ad67c883a28436d7399d73a2ccdb9ef53c641. Additionally, this modifies CapturedTestCL.cpp so there is no failure coming from the vulkan-deps roll. Bug: angleproject:438220619 Bug: angleproject:438195622 Change-Id: I6cf2d11d7ff77ce4513948b22b8c59d970c7810b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6842222 Reviewed-by: Austin Annestrand <a.annestrand@samsung.com> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Sungyong Choi 1622d4ad 2025-08-13T07:22:13 Fix -Wparentheses in unlockAndRelease Add parentheses around (valid && owns_lock()) to clarify the intended grouping and silence GCC -Wparentheses warning. BUG: angleproject:438226513 Change-Id: I0d4f3e0153c277c96ec85f255f844bab085f9550 Signed-off-by: Sungyong Choi <sywow.choi@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6845478 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
kmx.io     mail     discord kmxgit v0.4.0