kc3-lang/angle

Log

Author Commit Date CI Message
Roman Lavrov 389707fc 2022-03-04T14:39:33 Capture/Replay: Clarify that capture is disabled by default. https://crrev.com/c/3163360 disabled capture when no vars are specified by changing the ANGLE_CAPTURE_FRAME_END default from 10 to 0. Bug: angleproject:6397 Change-Id: I22efceafa412fabf283542cb05f54a84d308931d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3503699 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Auto-Submit: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Charlie Lao 36ce2646 2022-03-04T11:37:08 Vulkan: Align the size before calling into VMA's allocator The size we saved in BufferSuballocation object may used for vkFlushMappedMemory() call. This will ensure that we save the aligned size to avoid VVL error for unaligned size in that flush call. bug: b/219974369 Change-Id: Iccf3199f43cd346dab80083d5494fbaeee39948f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3504000 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Mohan Maiya f9ade9fb 2022-02-18T15:08:54 Vulkan: Add feature to create pipeline during glLinkProgram Creating the pipeline will trigger the compilation of shaders to byte code thus warming up Vulkan shader caches. Typically most apps call into glLinkPrograms during app loadtime and the goal is to improve cache hit rate and reduce CPU workload during game play. Bug: angleproject:7046 Test: ProgramBinary*CreatePipelineDuringLink* Change-Id: I71351d45a9aa84e220ca38503735e94cff1dcf98 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3478354 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Cody Northrop fa595ac3 2022-03-02T14:51:37 Docs: Update CaptureAndReplay to include Perf tests This CL: * Updates the file list for captures * Remove outdated references to the source contents * Adds a section with steps that allow running your capture on Android via our trace replay harness (angle_perftests) Bug: angleproject:1944 Change-Id: Ied15a8af004681d7b7b626a27b7bdeeee727dd4f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3500905 Reviewed-by: Roman Lavrov <romanl@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Yuxin Hu 1cef917c 2022-03-02T23:50:11 Reland "Remove ImageViewHelper from ResourceUseList" This is a reland of 126e967de3978f0dc4f6cf0fa3f9749366ea39ba Original change's description: > Remove ImageViewHelper from ResourceUseList > > Instead of keeping a dedicated SharedResourceUse mUse for > ImageViewHelper, let ImageViewHelper take ImageHelper.mUse > for lifetime tracking. ImageViewHelper no longer needs to > add its' own mUse in the ResourceUseList through retain() > calls, and this should cut the ResourceUseList size by > almost half. For instance, in the trace aztec_ruins, > the maximum ResourceUseList size before the change is 3643, > and the maximum ResourceUseList size after the change is 1694. > Since ImageViewHelper no longer needs to keep SharedResourceUse > mUse as a class memberWe can remove the inheritance from > Resource class, and make ImageViewHelper simply a NonCopyable class. > Bug: angleproject:6717 > Change-Id: I460e83f5f3c1d6ef9722b9f3c9a5ba9552563cb9 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3449450 > Reviewed-by: Charlie Lao <cclao@google.com> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Yuxin Hu <yuxinhu@google.com> Bug: angleproject:6717 Change-Id: I3aa9785d7dcdc8db82847f1586f8cd7d5c838d7c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3501194 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Jamie Madill ef17f38a 2022-03-01T10:15:26 Vulkan: Add overlay widget for cache key size. Bug: angleproject:6776 Change-Id: I35ab18bc5919129b2decf58d541499f771140e47 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3472754 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Roman Lavrov bf3cdca5 2022-03-04T11:46:16 Capture/Replay: Mark two more tests as flaky. TransformFeedbackTest.BufferOutOfMemory VertexAttributeTestES3.DrawWithUnalignedData Flaked on win-trace. Bug: angleproject:6180 Bug: angleproject:7076 Change-Id: I75f3ca2468f2802cb3809340f32c064d56438c65 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3503693 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill ee96a461 2022-02-22T12:23:06 Vulkan: Fix missing empty buffer descriptor. This could happen for SSBOs and UBOs when the shader renders without a bound buffer, and robustness enabled. Bug: angleproject:6707 Change-Id: I993f2489aca47f07068908858c83afa78c9e0402 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3484979 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Auto-Submit: Jamie Madill <jmadill@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Lubosz Sarnecki 61e0c319 2022-03-04T15:39:40 Tests: Add Fire Emblem Heroes trace. Test: angle_perftests --gtest_filter="*fire_emblem_heroes*" Bug: angleproject:7077 Change-Id: I1121cca8bab51bb9a820215f7526a88e8b28e51d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3501893 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
angle-autoroll 31e739d6 2022-03-04T16:11:30 Roll VK-GL-CTS from 2328c3fcf88d to f7e842466e0a (5 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/2328c3fcf88d..f7e842466e0a 2022-03-04 quic_mnetsch@quicinc.com Merge "Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/main" into main 2022-03-03 siglesias@igalia.com Add a check that drmFormatModifierTilingFeatures has at least one bit set 2022-03-03 rgarcia@igalia.com Test primitive ID is not affected by culling 2022-03-03 antto.makinen@siru.fi Verify Depth/Stencil Write conditions 2022-03-03 quic_mnetsch@quicinc.com Merge vk-gl-cts/opengl-cts-4.6.2 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-bots+autoroll-info@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: angle-bots+autoroll-info@google.com,romanl@google.com Change-Id: I90b971c39b628e8c419768c9e2490fdca7258fe4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3498547 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 91dce104 2022-03-04T14:39:58 Roll Chromium from e2a60c1d35cf to 46c84f1b0c3f (1077 revisions) https://chromium.googlesource.com/chromium/src.git/+log/e2a60c1d35cf..46c84f1b0c3f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC romanl@google.com,jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/e795961f78..ab05046d45 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/893aa038dd..113dd1badb * testing: https://chromium.googlesource.com/chromium/src/testing/+log/dd7b891b7a..fca7fc03ce * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/a13888fac0..4a57e9eac2 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/060e35fe22..9892f2d7c2 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..10d8471fc7 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1c22c511d0..df1a3c0bb8 * third_party/r8: cEv1yyfxfmP_MaZrG22cR7YPc7hehgHAZd82lRx0DFAC..ZI5RPjew7GhVFtcZytIe_Sv91Pljm5KmhVan6HWxj8YC * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/aa5ea608a4..aa6909a566 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/3a67a5003b..1f05f8edb2 * tools/luci-go: git_revision:a1616e207f0d9c24beefe848ee899b7a73efcb70..git_revision:cb424e70e75136736a86359ef070aa96425fe7a3 * tools/luci-go: git_revision:a1616e207f0d9c24beefe848ee899b7a73efcb70..git_revision:cb424e70e75136736a86359ef070aa96425fe7a3 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/f2517d8f97..a84f13d03d * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/a7f0df865f..116401e58c * tools/skia_goldctl/linux: eZ3k373CYgRxlu4JKph6e-_7xkP02swy_jePFFMiyIQC..wjKDZ5vJELJ_j3O037nIWhBEMF0cY4Y1g4tLc47hPJoC * tools/skia_goldctl/mac_amd64: nHUjLIViYsLxRjv-zDdmzqT8p1R3VoyHq5gdGkKeMYwC..jw5QK1qcTGSBr-yjH0d-9F_MNeq6e5_5aWLq_oGWy0QC * tools/skia_goldctl/mac_arm64: -mc865SGfJAqreLZM6fkn8tgCJ7u5QLk5zm7r-ZRJ9gC..o4BSMT1hKtY4T4VBfANeSm-NuhxoxPYUp3lF0EpoUvMC * tools/skia_goldctl/win: iEqqRADI7znrc6pG-MVnc5pBZwD25koILREPC6x2AFAC..Vg04A_bOadtB2ljbA9DGKe69_Uc6pmX5mk_ABoO2R3EC No update to Clang. Bug: None Tbr: romanl@google.com,jmadill@google.com Change-Id: I8e53918f24745f5c51c4c4c5d5468bdedc8f003f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3503714 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Jamie Madill e14a20e3 2022-03-04T15:05:07 Revert "add host cached bit for staging buffer" This reverts commit e1af34a6f4fbcdc9bf1da5498f87b6d2aa8b526b. Reason for revert: Causes VVL error on Pixel 6: https://ci.chromium.org/ui/p/angle/builders/ci/android-arm64-exp-test/237/overview Original change's description: > add host cached bit for staging buffer > > bug: b/219974369 > Change-Id: Ia31109839af9cfa5b862b72152f7189c42e48e53 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3488773 > Reviewed-by: Charlie Lao <cclao@google.com> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Jamie Madill <jmadill@chromium.org> Change-Id: Ie91fe94471f48ac880c6470c69ac5e7746c603c9 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3503690 Auto-Submit: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 0b5485c5 2022-03-04T08:26:06 Call generate_test_spec_json with vpython3. Bug: chromium:1302648 Change-Id: If071d8f98b28b0dc3d279d35abd2cecde0976a58 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3503688 Reviewed-by: Jamie Madill <jmadill@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill d9002eef 2022-03-01T16:14:47 Protect against deleting a current XFB buffer. Bug: chromium:1295411 Change-Id: I097f272c38e444e0af71aa55c0dc508a07aa0bd3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3498262 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 8f9dac58 2022-03-04T10:01:12 Roll SwiftShader from 7089ef18891d to 561264b73b36 (7 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/7089ef18891d..561264b73b36 2022-03-04 capn@google.com Remove explicit broadcasts of constants in fragment operations 2022-03-03 capn@google.com Fix obtaining the RelaxedPrecision decoration from the result ID 2022-03-03 natsu@google.com Support VK_FORMAT_G10X6_B10X6R10X6_2PLANE_420_UNORM_3PACK16 2022-03-03 dvet@google.com Update googletest submodule to release-1.11.0 2022-03-03 capn@google.com Benchmark mediump GLSL.std.450 instructions 2022-03-03 capn@google.com Simplify obtaining SPIR-V decorations 2022-03-03 capn@google.com Remove duplicate transcendental functions If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: Ieca176e79636e225e2c6950ef7864ec093ca9411 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3499034 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 75422a63 2022-03-04T10:01:53 Roll vulkan-deps from a30aef1d7967 to e572921329ff (5 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/a30aef1d7967..e572921329ff Changed dependencies: * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/2ce1e5c140..6c7a40822f * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/d18d0d92e5..f56726a323 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/2f61d0d86c..78684b1a0b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: I9f45d4bd1895ff6c382639e6189422a515acd41d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3503448 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao b72718d2 2022-02-22T16:18:45 Vulkan: Fix the data race for mUse from two threads A data race of mUse object between two threads can occur with the following sequences: 1) You use the buffer in the context, it adds into mResourceUseList 2) You release the buffer. Now it goes into mGarbageList, even though it is still in the mResourceUseList. Now this mUse object has references from two lists, the mGarbageList and mResourceUseList, and they do not use the same mutex lock. This means the race could happen and corrupt the mUse data. The same thing could happen with ImageHelper object as well. This quick fix also grabs mGrabageMutex while processing mResourceUseList. This CL creates a new garbage list to hold garbage that has not been submitted to vulkan. And this list will only accessed from submission thread and with mGarbageMutex lock held. The advantage of this is that mSharedGarbage will only have objects that already submitted, which means it is in FIFO order so that we can break out the loop as soon as we see an uncompleted garbage. This bug was exposed by MultithreadingTest.MultiContextClear/ES3_Vulkan_SwiftShader on linux-tsan-test Bug: angleproject:7045 Change-Id: I264c970579aaa53373a61ff067fa0e21eb410ae6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3482158 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Amirali Abdolrashidi 9050cd64 2022-03-01T10:36:19 Add angle_white_box_tests to SwANGLE tests * Added angle_white_box_tests to the following: * swangle_gtests * swangle_non_deqp_slow_gtests * swangle_slow_gtests Bug: angleproject:7074 Change-Id: I703655d1901a6dc660d5e6b5c4044baf0994205d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3499200 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Tomasz Śniatowski 4a4bb07b 2022-03-03T21:56:05 Don't create a string out of a nullptr The code path is already behind an UNREACHABLE(), but having the code return nullptr in a function returning std::string is still UB, and won't compile in C++23. Return an empty string instead. Bug: chromium:1302724 Change-Id: I151d488c4e7e951dcae9f55c142ca49526e3b102 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3502448 Auto-Submit: Tomasz Śniatowski <tsniatowski@vewd.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Hailin Zhang e1af34a6 2022-02-24T10:52:31 add host cached bit for staging buffer bug: b/219974369 Change-Id: Ia31109839af9cfa5b862b72152f7189c42e48e53 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3488773 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 348ece42 2022-03-01T15:40:38 Vulkan: Fix issue with redefining a layered attachment. The fix ensures we complete level redefinition before we get the layer render target in TextureVk::getAttachmentRenderTarget. Bug: chromium:1296866 Change-Id: Id7fa8e9fed5e766c30580b09336713c675c4e4f0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3498283 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cody Northrop 7b202392 2022-03-02T17:32:45 Capture/Replay: Fix capture on Linux Need to add support for printing "const GLint *" types. We've been falling into the default handler and getting lucky with how other platforms handle ostream with a null value. We use this extensively with glShaderSource(). Test: MEC of an existing trace on Linux Bug: angleproject:7071 Change-Id: I7e4f1fbf2876dddac49ea6583918dbc534070d75 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3501201 Reviewed-by: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Tim Van Patten 83de4ebe 2022-03-02T17:14:45 WATCHLISTS: Remove timvp@ from 'vulkan' Remove timvp@ from the 'vulkan' WATCHLISTS. Bug: None Change-Id: Ibc43b877987d77fafe42dbd64907f317142e764b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3501198 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Roman Lavrov 722ac971 2022-03-02T19:24:26 Fix glClearColor calls to use GLColor32F constants. Bug: angleproject:5025 Change-Id: I8d8bc8ff0b93951e19697d57c07368e1196498ae Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3499564 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Mohan Maiya 55f57a37 2022-02-18T14:43:44 Vulkan: Reserve memory in move-constructor of ResourceUseList std::move leaves source in default state, re-reserve space for other.mResourceUses. Bug: angleproject:4950 Change-Id: Ib2b544c58676dc4a69f09926f05d73e0a57429d9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3499045 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll c1e32885 2022-03-03T10:01:12 Roll SwiftShader from 383901609736 to 7089ef18891d (10 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/383901609736..7089ef18891d 2022-03-03 capn@google.com Optimize log2() polynomial evaluation using FMA 2022-03-03 capn@google.com Remove exp/log constant propagation TODOs 2022-03-03 capn@google.com Optimize exp2() polynomial evaluation using FMA 2022-03-03 capn@google.com Disambiguate operations on single-component swizzles 2022-03-02 srisser@google.com Roll git-hooks forward 2022-03-02 capn@google.com Optimize sin() range reduction using FMA 2022-03-02 capn@google.com Optimize sin/cos polynomial evaluation using FMA 2022-03-02 capn@google.com Implement implicit broadcast of scalar constants 2022-03-02 capn@google.com Treat YCbCr images bound to Android hardware buffers as disjoint 2022-03-02 nicolascapens@google.com Merge changes Id4b3df16,Id12e7fe6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: Ifc70fca6c61639dcf502351bc7ed610caf4b66c2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3498892 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 57dfa04b 2022-03-03T10:21:52 Roll vulkan-deps from 7f867484330b to a30aef1d7967 (4 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/7f867484330b..a30aef1d7967 Changed dependencies: * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/d16183d1d2..2ce1e5c140 * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/f75fc98bad..0e994ee9c4 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/d57db97427..2f61d0d86c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: I01fc222de75ed5e5c0c792bf2b99c9bcdbafd59c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3501632 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov 6cb08a22 2022-03-03T01:33:00 Revert "Increase end2end timeout and sharding on Pixel 6" This reverts commit 3154b00bab776e366538e712558a7f8c2967d4ca. Reason for revert: perf regression worked around Original change's description: > Increase end2end timeout and sharding on Pixel 6 > > Bug: angleproject:7050 > Change-Id: I3402a9f930f47a32537afd13674a3d6bc514f606 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3481302 > Auto-Submit: Yuly Novikov <ynovikov@chromium.org> > Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> > Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Bug: angleproject:7050 Change-Id: I74eafcdef4edd256145ff4938a58f9dfffbbe063 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3501203 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Mohan Maiya 19fd3bc5 2022-02-28T13:23:20 Fix unaligned reads on armeabi-v7a If an application provides unaligned data to glVertexAttribPointer, we may attempt an unaligned read from this application-provided buffer. This change detects such a case and copies the data byte-by-byte in order to prevent SIGBUS errors on architectures that do not support unaligned reads. This fixes the issue ONLY for integer-to-float vertex attribute conversion. Other vertex attribute processing functions may still be affected by this problem. Bug: angleproject:7001 Test: VertexAttributeTestES3.DrawWithUnalignedData* Change-Id: Ic66a150a0bf9fe4df3afe5fc5c91646a46186e8d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3448420 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
angle-autoroll 15b558c1 2022-03-02T10:01:53 Roll vulkan-deps from 6f0521f42451 to 7f867484330b (2 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/6f0521f42451..7f867484330b Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/43d585d863..538231d8b4 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/8726d47ca7..d57db97427 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: I6dcf95c01740a05bd3d2d25872c08d592b7e24a0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3500383 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll c41cedd9 2022-03-02T10:01:13 Roll SwiftShader from 6e9eafd34639 to 383901609736 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/6e9eafd34639..383901609736 2022-03-01 capn@google.com Fix image subresource offset query If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: I12b7a252869c93c17c4ff33804818da9978eff85 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3500362 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 0f6a12e3 2022-03-02T07:00:53 Roll Chromium from 4f52dd6c4de1 to e2a60c1d35cf (443 revisions) https://chromium.googlesource.com/chromium/src.git/+log/4f52dd6c4de1..e2a60c1d35cf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/54a203edb9..e795961f78 * buildtools/linux64: git_revision:e3f114f46537152cfbdb553015518d1db1b812fd..git_revision:d7c2209cebcfe37f46dba7be4e1a7000ffc342fb * buildtools/mac: git_revision:e3f114f46537152cfbdb553015518d1db1b812fd..git_revision:d7c2209cebcfe37f46dba7be4e1a7000ffc342fb * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/2ea265b95a..d1c7f92b8b * buildtools/win: git_revision:e3f114f46537152cfbdb553015518d1db1b812fd..git_revision:d7c2209cebcfe37f46dba7be4e1a7000ffc342fb * testing: https://chromium.googlesource.com/chromium/src/testing/+log/f1eeca027d..dd7b891b7a * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/d936596e3c..060e35fe22 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..d62cc7b294 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ca9706d139..1c22c511d0 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/8faffb3a7d..f2517d8f97 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/1f34318e3e..a7f0df865f No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: I753d25f177176573e507eb3042b5de75cc919e1d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3500063 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop 1fd544a4 2022-02-25T12:22:01 Vulkan: Disable shader validation cache on Android With local testing and code analysis, we can see that shader validation caching doesn't work on Android. Turning it off entirely results in a decent speedup: Pixel 6 Pro Before: ~10000 ms Pixel 6 Pro After: ~7000 ms Test: angle_end2end_tests --gtest_filter="*GLSLTest*Fragment*ES3_Vulkan" Bug: angleproject:7050 Change-Id: I8107c366b5e2dca7131626d29262d64ad9666e0c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3491461 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Jeff Vigil 51967b4f 2022-02-11T13:01:54 Vulkan: Fix enabling external fences and semaphores These capabilities are Instance extensions need fixed to enable Native fences for Android Bug: angleproject:7009 Change-Id: I9f07dc88cabd52712ebde28ba938662d7773c8b5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3457743 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Cody Northrop 37bfc40d 2022-02-27T16:27:26 Tests: Add Blade&Soul Revolution trace Test: angle_perftests --gtest_filter="*blade_and_soul_revolution*" Bug: angleproject:7053 Change-Id: I0ef1442c5cf12c08f9b461559512ae858829e41c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3492850 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Ian Elliott 5e87ae0a 2022-03-01T12:41:00 Use VK_ANDROID_surfaceless_query for EGLConfig formats That extension allows DisplayVkAndroid::generateConfigs() to query the swapchain formats (but not yet colorspaces) before ANGLE is given any VkSurfaceKHR. This is used for creating EGLConfig's with GL_RGB10_A2 and GL_RGBA16F. Bug: b/203826952 Change-Id: I55302c98641fbce93f7af428087430763676bdb4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3492482 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Trevor David Black <vantablack@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
Cody Northrop 6acb927f 2022-02-28T16:40:57 Tests: Add Castlevania: Symphony of the Night trace Test: angle_perftests --gtest_filter="*castlevania_sotn*" Bug: angleproject:7067 Change-Id: Id93190d4827e7c87aa585d5d73ba55321e0d09f3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3495881 Reviewed-by: Lubosz Sarnecki <lubosz.sarnecki@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Antonio Caggiano 2a9c4b01 2022-02-10T11:33:32 dEQP: Enable CreateSurfacePlatformEXT tests Add the corresponding capability to NativeWindow and implement getPlatformExtension virtual method to return a native pointer that can be used with eglCreatePlatformWindowSurfaceEXT(). Bug: angleproject:6961 Change-Id: Ieb1a1fd8b3cae4e6f199c269f3922cbd0307aa35 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3452102 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Antonio Caggiano <antonio.caggiano@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Antonio Caggiano b92ebdb7 2022-02-24T12:23:09 EGL: Add code-gen for dmabuf extensions Add code-gen for EGL_EXT_image_dma_buf_import and EGL_EXT_image_dma_buf_import_modifiers. Bug: angleproject:7065 Change-Id: Ib1bd2a881f11e96b1e7e5128975bdba3bdc41e0f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3495122 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cody Northrop ef6688c9 2022-03-01T09:21:20 Tests: Add Five Nights at Freddy's trace Test: angle_perftests --gtest_filter="*five_nights_at_freddys*" Bug: angleproject:7066 Change-Id: Iad911da90eea7e798fabeaf697afea29fb53ce93 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3495880 Reviewed-by: Lubosz Sarnecki <lubosz.sarnecki@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Antonio Caggiano bf619311 2022-03-01T17:23:38 EGL: Implement isX11 for DisplayGLX This fixes CreatePlatformWindowSurfaceEXT for the GL renderer. Bug: angleproject:6961 Change-Id: Iaec90f5fe81ee605f43d62e6e63a3fbedd314cb4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3497684 Auto-Submit: Antonio Caggiano <antonio.caggiano@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Lubosz Sarnecki 309e6dad 2022-02-18T12:31:31 Tests: Add Final Fantasy Brave Exvius trace. Test: angle_perftests --gtest_filter="*final_fantasy_brave_exvius*" Bug: angleproject:7041 Change-Id: I3a30a317b1c10b016652dbdaadcd577bf167c5f0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3475352 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
angle-autoroll 697a942b 2022-03-01T10:01:12 Roll SwiftShader from 949ffcf55151 to 6e9eafd34639 (3 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/949ffcf55151..6e9eafd34639 2022-02-28 capn@google.com Support implicit conversion of Int4 component to Int 2022-02-28 capn@google.com Move Swizzle type definitions into a separate header 2022-02-28 swiftshader.regress@gmail.com Regres: Update test lists @ 949ffcf5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: Ib61b6842f5b4f7b49eb4b176eccff888e3ffd6a6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3496981 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Lubosz Sarnecki 1bfdc981 2022-01-21T14:21:45 TorusBufferStorage: Regenerate buffer storage every second. To test regeneration in FrameCapture, the torus buffer storage example now reinitializes its coherent buffer storage every second. Define attrib pointers every draw. Bug: angleproject:4599 Bug: angleproject:5857 Bug: angleproject:6774 Change-Id: I32984535d9810478b6906217102ac9c3e83464b2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3406756 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
angle-autoroll 3e00c7d5 2022-03-01T10:01:56 Roll vulkan-deps from 4d9fe6bf1f0c to 6f0521f42451 (35 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/4d9fe6bf1f0c..6f0521f42451 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/d15deba1d8..43d585d863 * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/188dc8b13c..d16183d1d2 * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/6a55fade62..f75fc98bad * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/b32da5329b..aa18f182eb * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/a32af9ca72..a4fb0b36cf * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/5f9e5f14e5..078d44e466 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/efcb50f63a..8726d47ca7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: I24401d520b1b61cf0777f08723a48dcd77d1be9d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3496645 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gert Wollny 5118002e 2021-11-29T21:01:03 Capture/Replay: test and handle texture gen-on-bind Bug: angleproject:6425 Change-Id: Ieb4c0a7a6ffdbf0690c07c10e001835a0dcbb6e1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3295620 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Gert Wollny bc20e55b 2021-11-29T21:00:45 Capture/Replay: test and handle renderbuffer gen-on-bind Bug: angleproject:6425 Change-Id: I591bf0fdfe2e7f83d7e02f63c8265234f7b85df6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3295618 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Gert Wollny efb951e8 2021-11-29T21:00:02 Capture/Replay: test and handle buffer gen-on-bind Bug: angleproject:6425 Change-Id: If8b573d0d77192befe6db82498158c535bd3b104 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3295619 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Gert Wollny 5236a767 2022-02-23T12:15:26 Capture/Replay: enable running GLES 3.2 tests with script In addition add annotations for the tests that fail (crash) Bug: angleproject:5366 Change-Id: I92747e70b4c0a494fb7f67ed0c282bd76788f505 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3484057 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
angle-autoroll 820a47be 2022-03-01T07:00:18 Roll Chromium from 5feb16fcf80f to 4f52dd6c4de1 (446 revisions) https://chromium.googlesource.com/chromium/src.git/+log/5feb16fcf80f..4f52dd6c4de1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/3651f40a5d..54a203edb9 * buildtools/linux64: git_revision:0725d7827575b239594fbc8fd5192873a1d62f44..git_revision:e3f114f46537152cfbdb553015518d1db1b812fd * buildtools/mac: git_revision:0725d7827575b239594fbc8fd5192873a1d62f44..git_revision:e3f114f46537152cfbdb553015518d1db1b812fd * buildtools/win: git_revision:0725d7827575b239594fbc8fd5192873a1d62f44..git_revision:e3f114f46537152cfbdb553015518d1db1b812fd * testing: https://chromium.googlesource.com/chromium/src/testing/+log/8bf5b5b5e9..f1eeca027d * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/da9e4a3759..d936596e3c * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..2cfdaa8ce0 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6b28c1ddef..ca9706d139 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/5de432790d..aa5ea608a4 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/55aa202015..3a67a5003b * tools/luci-go: git_revision:582e828c5a8aaf5cdd0ad1d5465fb9092b71eab8..git_revision:a1616e207f0d9c24beefe848ee899b7a73efcb70 * tools/luci-go: git_revision:582e828c5a8aaf5cdd0ad1d5465fb9092b71eab8..git_revision:a1616e207f0d9c24beefe848ee899b7a73efcb70 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/4b6550b5a7..8faffb3a7d * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/19bce3c47a..1f34318e3e No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: I8eb5c883dcc67a4e5782e223be30fdc71045bc21 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3496680 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gert Wollny 32881018 2022-01-14T16:03:22 Capture/Replay: atomic counter buffer limits are shader specific Therefore, the override must also be applied to the per shader values. Bug: angleproject:6895 Change-Id: Iecd790afaca9358ee767d41b4c806bb8257b5fa6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3386948 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Tim Van Patten 5749ec7d 2022-03-01T02:14:42 Revert "Vulkan: Move mid-RP color clear to loadOp if content undefined" This reverts commit cfe5a1735a934cc83133bb6c69d19aa27278a270. Reason for revert: https://bugs.chromium.org/p/angleproject/issues/detail?id=5048#c7 @timvp That change just caused a regression in my project. I clear the color + depth buffer before drawing, but initially draw only to the depth buffer. It seems that it decided to ignore the color buffer clear as a result of that. Original change's description: > Vulkan: Move mid-RP color clear to loadOp if content undefined > > Instead of using vkCmdClearAttachments, if the color attachment has not > been written to, modify the loadOp of the currently open renderpass to > CLEAR. > > Bug: angleproject:5048 > Test: VulkanPerformanceCounterTest.MidRenderpassClear > Change-Id: Ida47e6ac7d0f29e2c49bdf2e74c1d876a5d7c223 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3381912 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Tim Van Patten <timvp@google.com> Bug: angleproject:5048 Change-Id: Iec5c73632429a80f955f7d659cf670f9cbb6c9b7 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3496662 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Tim Van Patten <timvp@google.com>
Cody Northrop c80c7ae3 2022-02-24T10:43:15 Capture/Replay: Merge Deletes in Reset Before this CL, when regenning resources, we would iterate through each resource ID and issue a delete followed by a gen. The delete is required to get resources back to their original state, often caused by applications recreating them during the run. This ran into problems when our resource maps had stale data in them, i.e. a texture that had been deleted by the app but remained in our gTextureMap. We could inadvertently delete a resource we had just genned. For example, in ResetReplay(), say we have two textures to delete: // gTextureMap[1] start with 5 const GLuint glDeleteTextures_texturesPacked_1[] = { gTextureMap[1] }; glDeleteTextures(1, glDeleteTextures_texturesPacked_1); // We just deleted texture 5, now create a new one glGenTextures(1, reinterpret_cast<GLuint *>(gReadBuffer)); // The driver returned 15, which was unused at this time UpdateTextureID(1, 0); // gTextureMap[1] now contains 15 ... // gTextureMap[2] happens to start with 15, which was in use in // the trace, but was deleted and is no longer in use. The // deleted value is not cleared from gTextureMap (which is // another possible way to solve this). const GLuint glDeleteTextures_texturesPacked_2[] = { gTextureMap[2] }; glDeleteTextures(1, glDeleteTextures_texturesPacked_2); // Whoops! We just deleted our brand new texture 15, even though // it no longer maps to the original texture. glGenTextures(1, reinterpret_cast<GLuint *>(gReadBuffer)); UpdateTextureID(2, 0); // Now gTextureMap[2] contains whatever came back from the driver ... // The first use of gTextureMap[1] will fail on loop because // texture 15 no longer exists! To avoid this problem we delete all resources up front before genning any new ones. const GLuint deleteTextures[] = {gTextureMap[1], gTextureMap[2]}; glDeleteTextures(2, deleteTextures); // Now we no longer have any deletes in the create sequence glGenTextures(1, reinterpret_cast<GLuint *>(gReadBuffer)); UpdateTextureID(1, 0); glGenTextures(1, reinterpret_cast<GLuint *>(gReadBuffer)); UpdateTextureID(2, 0); This is applied to all the resources we regen right now. This CL: * Merges the deletion of new resources (that didn't exist when the trace starts) with resources that are being regenned. That means there is just one big delete. * Removes Delete from the call sequences we track for each resource since we no longer need to keep them around. * Adds a formatting helper to avoid code duplication. Test: Blade&Soul Revolution MEC (UE4) Bug: angleproject:4599 Bug: angleproject:7053 Change-Id: Ida3b7e1ad5d94c5e9860447d5cf959278f37ad47 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3492849 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Gert Wollny <gert.wollny@collabora.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Tim Van Patten cfe5a173 2022-01-11T19:26:42 Vulkan: Move mid-RP color clear to loadOp if content undefined Instead of using vkCmdClearAttachments, if the color attachment has not been written to, modify the loadOp of the currently open renderpass to CLEAR. Bug: angleproject:5048 Test: VulkanPerformanceCounterTest.MidRenderpassClear Change-Id: Ida47e6ac7d0f29e2c49bdf2e74c1d876a5d7c223 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3381912 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
Cody Northrop 802e0d4d 2022-02-15T16:40:07 Document perf test metrics Bug: angleproject:1944 Change-Id: I7f0d5c73c943ba28b3e0270e17681d7e69a7ee4a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3466757 Reviewed-by: Lingfeng Yang <lfy@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Auto-Submit: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Roman Lavrov 977945fa 2022-02-28T15:57:03 Fix self link broken by https://crrev.com/c/3124341 Bug: angleproject:6323 Change-Id: I9408aa3746770e112ed7301689f842598ffeb484 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3495023 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll 045e25de 2022-02-28T10:01:11 Roll SwiftShader from f423bda7e8e3 to 949ffcf55151 (9 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/f423bda7e8e3..949ffcf55151 2022-02-26 capn@google.com Refactor image offset methods 2022-02-26 swiftshader.regress@gmail.com Regres: Update test lists @ 310874c9 2022-02-25 sugoi@google.com Fix dynamic rendering implicit clears with multiview 2022-02-25 capn@google.com Set the stack limit through a function attribute 2022-02-25 capn@google.com Regres: remove OpenGL ES testlists 2022-02-25 capn@google.com Assert llvm::Expected<> don't contain an error 2022-02-25 sugoi@google.com VK_KHR_maintenance4 support 2022-02-25 sugoi@google.com LocalSizeId for VK_KHR_maintenance4 2022-02-25 martin.troiber@gmail.com Add LLVM-Submodule backend option If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I018a35625bb57bb983aa808dbeaebcc78996af10 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3493140 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 56378606 2022-02-28T07:01:38 Roll Chromium from 903941d19666 to 5feb16fcf80f (645 revisions) https://chromium.googlesource.com/chromium/src.git/+log/903941d19666..5feb16fcf80f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/9e7c4ed752..3651f40a5d * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/8cd7191937..2ea265b95a * testing: https://chromium.googlesource.com/chromium/src/testing/+log/e867c867ab..8bf5b5b5e9 * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/6f9d0386be..e6c2b86f92 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/0f23dc5218..da9e4a3759 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..666eff907b * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/c23f5e8299..5de432790d * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/3730026620..55aa202015 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/bf2c351791..4b6550b5a7 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/18673704e4..19bce3c47a No update to Clang. Bug: angleproject:6430,angleproject:6489 Tbr: abdolrashidi@google.com Change-Id: Ia0d1afd345f94e3a77e743b3117a31e866cd1d10 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3494136 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 8390196a 2022-02-26T02:36:22 Revert "Remove ImageViewHelper from ResourceUseList" This reverts commit 126e967de3978f0dc4f6cf0fa3f9749366ea39ba. Reason for revert: Hits an ASSERT about too much garbage being accumulated. anglebug.com/7063 Original change's description: > Remove ImageViewHelper from ResourceUseList > > Instead of keeping a dedicated SharedResourceUse mUse for > ImageViewHelper, let ImageViewHelper take ImageHelper.mUse > for lifetime tracking. ImageViewHelper no longer needs to > add its' own mUse in the ResourceUseList through retain() > calls, and this should cut the ResourceUseList size by > almost half. For instance, in the trace aztec_ruins, > the maximum ResourceUseList size before the change is 3643, > and the maximum ResourceUseList size after the change is 1694. > Since ImageViewHelper no longer needs to keep SharedResourceUse > mUse as a class memberWe can remove the inheritance from > Resource class, and make ImageViewHelper simply a NonCopyable class. > > Bug: angleproject:6717 > Change-Id: I460e83f5f3c1d6ef9722b9f3c9a5ba9552563cb9 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3449450 > Reviewed-by: Charlie Lao <cclao@google.com> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Yuxin Hu <yuxinhu@google.com> Bug: angleproject:6717 Change-Id: Iea3d40458e2cc5be6ab0257ba6df8b82a4eeecda No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3491345 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Gregg Tavares c11cef2f 2022-02-16T10:42:41 Add Clearifying comment about Occlusion Query Test Bug: angleproject:6752 Change-Id: I710273c43694b50ab4fb59a840ae15d6cb14391d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3469718 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org>
Amirali Abdolrashidi fd44f1a0 2022-02-25T13:34:01 Update API version in VulkanHelper to 1.1 * Updated the API version in VulkanHelper to avoid the validation error regarding UNASSIGNED-API-Version-Violation on Android devices. Bug: angleproject:7062 Change-Id: Iacb12cd5c79ecc803cdb5fe5c8738d1ac352eec0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3491502 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Tim Van Patten 6db60483 2022-02-25T11:13:40 Android: Skip flaky EGL end2end tests Skip flaky EGL end2end tests on Android. Bug: angleproject:7059 Test: EGLSurfaceTest.ResizeWindowWithDraw Test: EGLReadinessCheckTest.IsRunningOnANGLE Test: EGLReadinessCheckTest.GetProcAddressNegativeTest Test: EGLReadinessCheckTest.HasGetPlatformDisplayEXT Test: EGLContextSharingTestNoSyncTextureUploads.NoSync Change-Id: Ib6637625fa3bead4860268fcacd108da2183ce86 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3491501 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi ce243358 2022-02-25T14:07:17 Vulkan: Add precision fix to SPIR-V transformation validation The SPIR-V transformation validation ASSERT was done before varying precision fixes were determined. This change reorders the operations such that the ASSERT also includes varying precision fix information. Bug: angleproject:7046 Change-Id: I1685a41cda080ac128025aa84a783984042e7c4e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3488559 Reviewed-by: mohan maiya <m.maiya@samsung.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Antonio Caggiano f762cb1b 2022-01-05T20:33:06 EGL: CreatePlatformWindowSurfaceEXT Implement CreatePlatformWindowSurfaceEXT just like CreatePlatformWindowSurface in egl_stubs.cpp taking into account that native window for X11 should be Window* instead of Window. Bug: angleproject:6961 Change-Id: Ic129bd3e9dd264fdee12b062b5b422a9a6012dd8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3427425 Reviewed-by: Jeff Vigil <jvigilsamsung@gmail.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Auto-Submit: Antonio Caggiano <antonio.caggiano@collabora.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Erik Rose a70d728c 2022-02-25T13:50:54 Correct a typo that was keeping Skia from compiling. For example: https://logs.chromium.org/logs/skia/5948b4721f002c11/+/steps/gn_gen/0/stdout. More specifically: https://logs.chromium.org/logs/skia/5948b4721f002c11/+/steps/gn_gen/0/stdout. Bug crept in on https://chromium-review.googlesource.com/c/angle/angle/+/3487449. Bug: angleproject:7061 Change-Id: I6bae23375505aa714733033f5b84c1b3c8c421f9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3488558 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Brandon Schade ded25241 2021-08-11T18:38:15 Vulkan: Clear Recycler's mObjectFreeList on destroy Previously the Recycler class never freed it's mObjectFreeList. Free it on destroy(). Bug: angleproject:6278 Change-Id: I3d207aaf67db92350886528c2fb1ce57c3441136 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3089659 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Commit-Queue: Brandon Schade <b.schade@samsung.com>
Kyle Piddington af45d166 2022-02-23T14:05:47 Metal: PVRTC formats fail conformance tests on simulator Remove support for PVRTC in simulator, as conformance tests fail Bug: angleproject:6874 Change-Id: I2c3f9e26523098aaa6a988db5cb3f4bf748a0cdc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3485640 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kyle Piddington <kpiddington@apple.com>
Ian Elliott 1d137a48 2022-02-25T12:47:53 Add to ANGLE's OWNERS Add Frank and his new team members to OWNERS. Will also add to OWNERS.android so that they can land ANGLE->AOSP autorolls. Bug: b/221459804 Change-Id: I64ee42318fa5631dc3fc40948e3f137fe2b18955 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3488560 Reviewed-by: Lingfeng Yang <lfy@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
Yuxin Hu 126e967d 2022-02-09T01:46:25 Remove ImageViewHelper from ResourceUseList Instead of keeping a dedicated SharedResourceUse mUse for ImageViewHelper, let ImageViewHelper take ImageHelper.mUse for lifetime tracking. ImageViewHelper no longer needs to add its' own mUse in the ResourceUseList through retain() calls, and this should cut the ResourceUseList size by almost half. For instance, in the trace aztec_ruins, the maximum ResourceUseList size before the change is 3643, and the maximum ResourceUseList size after the change is 1694. Since ImageViewHelper no longer needs to keep SharedResourceUse mUse as a class memberWe can remove the inheritance from Resource class, and make ImageViewHelper simply a NonCopyable class. Bug: angleproject:6717 Change-Id: I460e83f5f3c1d6ef9722b9f3c9a5ba9552563cb9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3449450 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Mohan Maiya 5094968f 2022-02-24T16:28:00 Vulkan: Account for Invariant in transformDecorate When replacing a varying with a temp variable make sure to propagate the Invariant decorator to the replacement variable. Bug: angleproject:7046 Change-Id: I6e1f9ae5a6045ca963738cfdee5788f04ae620e4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3489812 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 06fead6d 2022-02-25T16:06:30 Roll VK-GL-CTS from d321c7ec84de to 2328c3fcf88d (4 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/d321c7ec84de..2328c3fcf88d 2022-02-24 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/main 2022-02-24 ari.suonpaa@siru.fi Test message passing using permuted indices 2022-02-24 michal.jakubek@mobica.com Reduce and amortize memory allocations in RT utilities 2022-02-21 gleese@broadcom.com Fix arguments for image test reference generation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC abdolrashidi@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com,angle-bots+autoroll-info@google.com Change-Id: I1c6fb7b4e7299ad1c5b418be93f0a791c374a2a5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3489821 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Tim Van Patten e2f8c5c6 2022-02-22T19:15:11 Vulkan: Add ClearBenchmark.Run/vulkan_scissoredClear Add the test ClearBenchmark.Run/vulkan_scissoredClear to benchmark scissored clears with the Vulkan backend. Bug: angleproject:5194 Test: ClearBenchmark.Run/vulkan_scissoredClear Change-Id: I7d6aeb8683b2ac2488e1c961d0cc194e6107b7f1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3408457 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
angle-autoroll 7f03fb5d 2022-02-25T10:01:11 Roll SwiftShader from cd8e0282137f to f423bda7e8e3 (12 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/cd8e0282137f..f423bda7e8e3 2022-02-25 swiftshader.regress@gmail.com Regres: Update test lists @ 9f170f07 2022-02-25 sugoi@google.com Image memory requirements for VK_KHR_maintenance4 2022-02-25 sugoi@google.com vkGetImageMemoryRequirements2 refactor 2022-02-24 sugoi@google.com Buffer memory requirements for VK_KHR_maintenance4 2022-02-24 sugoi@google.com VK_KHR_zero_initialize_workgroup_memory support 2022-02-24 swiftshader.regress@gmail.com Regres: Update test lists @ cd8e0282 2022-02-24 capn@google.com Implement DAZ/FTZ control for non-Windows x86 2022-02-24 capn@google.com Implement separate DAZ/FTZ control for Windows 2022-02-24 capn@google.com Fix comparing lodOrBias as integer values 2022-02-24 capn@google.com Add utility functions for detecting divergent/uniform values 2022-02-24 syoussefi@google.com Set advancedBlendMaxColorAttachments to max 2022-02-24 sugoi@google.com Remove unicode characters from comments If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:3586 Tbr: abdolrashidi@google.com Change-Id: I7e144b73af798b3e74c77dcaa47f65d7d1ba6b82 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3490201 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 240dcdff 2022-02-25T07:01:40 Roll Chromium from effb00c1eb6d to 903941d19666 (506 revisions) https://chromium.googlesource.com/chromium/src.git/+log/effb00c1eb6d..903941d19666 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/9a383acb5c..9e7c4ed752 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/82b83d357f..e867c867ab * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/10baf29753..0f23dc5218 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..8d2395bd1b * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2c668c866d..6b28c1ddef * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/27dbe48bd5..c23f5e8299 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/0c2c9b023a..bf2c351791 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/9d72bfaa27..18673704e4 No update to Clang. Bug: angleproject:6430,angleproject:6489 Tbr: abdolrashidi@google.com Change-Id: Ia5703d94bd15524f9a304de9f44bbc6c9d0156e3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3489814 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuxin Hu 1e1505b5 2022-02-24T20:59:57 Upgrade Python scripts from Python2 to Python3 Bug: angleproject:5707 Change-Id: I2c00ef7e7cb529eab2be61378c9a5511a69acd1a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3486298 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Antonio Caggiano 613ec1c8 2022-02-15T17:01:01 Vulkan: Duplicate dmabuf FD on import When importing a dmabuf FD, Vulkan takes the ownership and attempts to close on vkFreeMemory. This means we need to duplicate it. Bug: angleproject:7027 Change-Id: Ife3dce30bd0c88c6b6fd622b93a44528b6a9ea68 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3464855 Auto-Submit: Antonio Caggiano <antonio.caggiano@collabora.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill c874943b 2022-02-18T15:29:14 Rename FastUnordered types to FlatUnordered. These names are consistent with the common parlance. Flat indicates the values are packed in memory, while fast indicates that lookup is as fast as possible. Bug: angleproject:6776 Change-Id: I7b56af26d7fdbf5956872be5033c3aa3f6b1b8c7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3484978 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Auto-Submit: Jamie Madill <jmadill@chromium.org>
Antonio Caggiano e2d5eb72 2022-02-24T10:21:06 Vulkan: Wayland dependency Add wayland as a third-party dependency and add it to the include directories of vulkan-dependent targets. Bug: angleproject:6902 Change-Id: I1c6305ac3e214ecda532988e28acaa6b8e997fd2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3487449 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 43273273 2022-02-24T10:01:12 Roll SwiftShader from 7529468c7902 to cd8e0282137f (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/7529468c7902..cd8e0282137f 2022-02-23 sugoi@google.com VK_KHR_shader_non_semantic_info support 2022-02-23 swiftshader.regress@gmail.com Regres: Update test lists @ 7529468c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I2ee24d35fd5ce7bde35920f0027a652d322e45c1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3486409 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 5ceded43 2022-02-24T07:00:09 Roll Chromium from e092c426ee21 to effb00c1eb6d (431 revisions) https://chromium.googlesource.com/chromium/src.git/+log/e092c426ee21..effb00c1eb6d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/208912d7cb..9a383acb5c * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/93c15529c3..893aa038dd * testing: https://chromium.googlesource.com/chromium/src/testing/+log/f6ece9fd76..82b83d357f * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/4f4f006a04..a13888fac0 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/fdc771ba71..10baf29753 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..08a8050c47 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/306b03b191..2c668c866d * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/4823a8571d..27dbe48bd5 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/f932f4f5e7..0c2c9b023a * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/bf4b3f4070..9d72bfaa27 * tools/skia_goldctl/linux: td7IhN6Q3eTDLXn6p5jlbeSIDYl7rI75dlX0qj8fEEsC..eZ3k373CYgRxlu4JKph6e-_7xkP02swy_jePFFMiyIQC * tools/skia_goldctl/mac_amd64: im5u9GiTMHxNcLH_Nc2X3RqzjfDs2oDmC0VhkLgUCeYC..nHUjLIViYsLxRjv-zDdmzqT8p1R3VoyHq5gdGkKeMYwC * tools/skia_goldctl/mac_arm64: edDMT5wDXf_HjD5qeNPgIEmYXDGUB1BswQ0G84CQBdUC..-mc865SGfJAqreLZM6fkn8tgCJ7u5QLk5zm7r-ZRJ9gC * tools/skia_goldctl/win: 5k9ZnDE42Xoqs07enkcOdWOf9jT-bhW-OXOp2fY-IR4C..iEqqRADI7znrc6pG-MVnc5pBZwD25koILREPC6x2AFAC No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: I3cfa6349d8f2d19f04adfb169b610d46be5ccffe Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3486297 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi d3ded9aa 2022-02-22T23:02:59 Vulkan: Make Overlay init lazy So it's not done when overlay is not in use. Bug: angleproject:7051 Change-Id: Iae2ba20cf8c0825dc5f321e5b31dd278cd892066 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3481310 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 1e773db9 2022-02-22T10:51:15 Vulkan: Shader support for KHR_blend_equation_advanced Translator can accept the layout qualifiers for the advanced blend equation. No emulation code is currently generated, and ANGLE will initially rely on the corresponding Vulkan extension. Based on change by Brandon Schade <b.schade@samsung.com> Bug: angleproject:3586 Test: angle_unittests --gtest_filter=*KHRBlendEquationAdvanced* Change-Id: I3b728c5f144386d7030bbbb301ddb07daa1492b9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3481309 Reviewed-by: Brandon Schade <b.schade@samsung.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Lubosz Sarnecki b69349bc 2022-02-15T14:59:03 Tests: Add Real Racing 3 trace. Add GL_EXT_shader_framebuffer_fetch prerequisite. Test: angle_perftests --gtest_filter="*real_racing3*" Bug: angleproject:7026 Change-Id: Ie76e7ca43bb3a95c343e56d3b830f1f6d6e733c4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3475351 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Gert Wollny 19704a89 2022-02-15T13:21:12 Capture/Replay: Capture GetTexLevelParameterfvANGLE params Bug: angleproject:3565 Change-Id: I940154a4e3ace9a3b8683eebdcd7bbb14402a641 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3461564 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
angle-autoroll cbc1c9c8 2022-02-23T10:01:11 Roll SwiftShader from b8d7deae87a7 to 7529468c7902 (5 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/b8d7deae87a7..7529468c7902 2022-02-22 capn@google.com Exhaustively test the log2 implementation's conformance 2022-02-22 capn@google.com Assert exp2 is exact at integer values 2022-02-22 capn@google.com Make inc() flush subnormals to zero when DAZ is enabled 2022-02-22 sugoi@google.com Fix dynamic rendering with multiview 2022-02-22 swiftshader.regress@gmail.com Regres: Update test lists @ b8d7deae If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I51658eb7ef4b50aff2d9648f19d9e18b52221f35 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3484098 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gert Wollny 913d8add 2022-01-25T11:43:40 Capture/Replay: Mark another test as Windows-only crash Bug: angleproject:6631 Change-Id: I30395b2cc9358963d73f0748c179300c5bfbe72b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3413158 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Gert Wollny 223a25f0 2022-01-25T11:15:16 Capture/Replay: Allow capturing of multisample texture content It just works. Bug: angleproject:6611 Change-Id: Ia3da2ee0ea3e09889a65910fd101a7daaa99ea56 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3413157 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
angle-autoroll 0d1f67d1 2022-02-23T08:38:37 Roll Chromium from 76e3790bfd26 to e092c426ee21 (458 revisions) https://chromium.googlesource.com/chromium/src.git/+log/76e3790bfd26..e092c426ee21 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/eaff71261c..208912d7cb * testing: https://chromium.googlesource.com/chromium/src/testing/+log/d612e87084..f6ece9fd76 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/4c73a7ae74..fdc771ba71 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..58ce6f9e68 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/42cf2acbae..306b03b191 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/d29d689c1d..71d78db8de * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/f8d70d1346..4823a8571d * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/0a3dc05ff3..f932f4f5e7 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/16a46ce6d2..bf4b3f4070 * tools/skia_goldctl/linux: t-kuo00LREzFSvvcKqhCDfF9a3vrU6x8bvpcqoOolxQC..td7IhN6Q3eTDLXn6p5jlbeSIDYl7rI75dlX0qj8fEEsC * tools/skia_goldctl/mac_amd64: q0e0eoFci9WHabP-U6xwl2vazg4Fh0iDyXPwa7GGoQMC..im5u9GiTMHxNcLH_Nc2X3RqzjfDs2oDmC0VhkLgUCeYC * tools/skia_goldctl/mac_arm64: qRTt0rC2ItXtcqu1dxTrhYh8FVz21OFuYU2YzKfboRMC..edDMT5wDXf_HjD5qeNPgIEmYXDGUB1BswQ0G84CQBdUC * tools/skia_goldctl/win: 7MVl6nWD2T_LTrD1aXv5dLQaPIBY04wfSmCsu5NdVdwC..5k9ZnDE42Xoqs07enkcOdWOf9jT-bhW-OXOp2fY-IR4C No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: Ife71008329e87f07d099f09e7c440f1c6065eaf1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3483975 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amirali Abdolrashidi e47a67e4 2022-02-22T11:40:23 Update Python scripts to run with Python 3 * Updated the scripts used in run_code_generation.py so they could be run with Python 3 with no errors. Bug: angleproject:5707 Change-Id: Iad7ff61a34ce53b6d54821cdd53ee846dc4afc3c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3482156 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov 3154b00b 2022-02-22T16:34:29 Increase end2end timeout and sharding on Pixel 6 Bug: angleproject:7050 Change-Id: I3402a9f930f47a32537afd13674a3d6bc514f606 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3481302 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Shahbaz Youssefi b80635ca 2022-02-22T15:50:58 Revert "Vulkan: Suppress VVL message about allocation exceeding heap size" This reverts commit 158d47831e77edf16721f631c1c4b45149182f4d. Reason for revert: No longer necessary anglebug.com/6444#c20 Original change's description: > Vulkan: Suppress VVL message about allocation exceeding heap size > > VMA does not check the result of vkGetBufferMemoryRequirements against > the heap size before attempting to make an allocation, which leads to a > validation error. > > The error is benign for ANGLE as the subsequent Vulkan allocation will > fail, leading to an OOM generated by Vulkan isntead of ANGLE to the same > effect as far as the application is concerned. > > Bug: angleproject:6444 > Change-Id: Ia474629971d6835f727b3fb43313a6003e3c939a > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3387088 > Reviewed-by: Charlie Lao <cclao@google.com> > Reviewed-by: Nicolas Capens <nicolascapens@google.com> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bug: angleproject:6444 Change-Id: I6b153f6002b35c057fed11d287e0c8211f4ada66 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3480738 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Nicolas Capens <nicolascapens@google.com> Commit-Queue: Nicolas Capens <nicolascapens@google.com>
Antonio Caggiano 2944e265 2022-02-15T16:57:53 Vulkan: Fix dmabuf memory importable check Bug: angleproject:7027 Change-Id: I64522d2629c153b8456c975a06fd4293f89aa19a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3464854 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll a8ec86a5 2022-02-22T10:01:11 Roll SwiftShader from d25df2a67cd2 to b8d7deae87a7 (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/d25df2a67cd2..b8d7deae87a7 2022-02-21 capn@google.com Eliminate initialization of fragment shader inputs 2022-02-21 capn@google.com Use legacy math precision for the Pipeline source set as well If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I93b2acef9130aeacba167432cb9cc34f468e9046 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3479410 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 937d5a5d 2022-02-22T07:00:37 Roll Chromium from 2b8afbc70460 to 76e3790bfd26 (193 revisions) https://chromium.googlesource.com/chromium/src.git/+log/2b8afbc70460..76e3790bfd26 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/82354b2402..eaff71261c * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/7539622043..8cd7191937 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/3779e1fb3e..d612e87084 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/ad002f6051..4f4f006a04 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..b718bf93ff * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0cfa90e203..42cf2acbae * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/4aca88e355..f8d70d1346 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/9e0a2ac8d2..0a3dc05ff3 * tools/skia_goldctl/linux: njGzzVyYPSA__3tShsGxsvh8k5kJfL9V0wvLthXSUV4C..t-kuo00LREzFSvvcKqhCDfF9a3vrU6x8bvpcqoOolxQC * tools/skia_goldctl/mac_amd64: hO0OT7GrBan0deDL_pb0LFML9ueWrbdDtzCU-awv-8IC..q0e0eoFci9WHabP-U6xwl2vazg4Fh0iDyXPwa7GGoQMC * tools/skia_goldctl/mac_arm64: iG5_8Fr1Z6-7hWUIaiAy_BdqEqZztiO1hsUkG8KD_csC..qRTt0rC2ItXtcqu1dxTrhYh8FVz21OFuYU2YzKfboRMC * tools/skia_goldctl/win: k8tTHDT2HQHQFD7TPjRrdMHGABN8YbxP1GXsJnmS9JIC..7MVl6nWD2T_LTrD1aXv5dLQaPIBY04wfSmCsu5NdVdwC No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: I885224e7817c7168e8a4e3b50b3d39e74ac68ea0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3478456 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 3a4f862f 2022-02-21T10:01:11 Roll SwiftShader from b4a56a893496 to d25df2a67cd2 (5 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/b4a56a893496..d25df2a67cd2 2022-02-18 sugoi@google.com Implement buffer memory requirement for VK_KHR_maintenance4 2022-02-18 sugoi@google.com VK_KHR_dynamic_rendering support 2022-02-18 capn@google.com Use non-conformant transcendentals for Chromium 2022-02-18 sugoi@google.com Merge changes I3c7eb72e,Ib40d778f,I9d83501b,Idbe4c715 2022-02-18 swiftshader.regress@gmail.com Regres: Update test lists @ b4a56a89 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I5416d724e7972b75790ae3172eea847259f26a1d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3477117 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll c4494a52 2022-02-21T07:01:42 Roll Chromium from 6594a8d1e6cf to 2b8afbc70460 (606 revisions) https://chromium.googlesource.com/chromium/src.git/+log/6594a8d1e6cf..2b8afbc70460 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/2fb44025ab..82354b2402 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/aa5552f516..3779e1fb3e * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..b718bf93ff * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/988c0af5be..0cfa90e203 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/31e5ad1c42..4aca88e355 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/69635b2a1b..9e0a2ac8d2 * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/4d131c20da..3c34a54fcd No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: Ife87aa7be674328d530286a04e46a0a2c1c4b112 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3476387 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao de37ad17 2022-02-16T15:30:46 Vulkan: Call releaseStagedUpdates before releaseImage When Texture is destroyed, we call TextureVk::releaseAndDeleteImageAndViews(). Right now it calls releaseImage() first and then calls releaseStagedUpdates(). The correct order should be releaseStagedUpdates() before releaseImages(). Otherwise for EGLImages, releaseImages will set mImage to nullptr which will make releaseStagedUpdates skip and leave the staged updates there which causes problem since context gets destroyed while EGLImage still hold onto staging buffer belongs to this context's shared group. Bug: b/219646764 Change-Id: I04a005b742a0d90b981a2f399a5e03b03e3a0adb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3469727 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Jamie Madill 9296f389 2022-02-18T10:45:01 infra: Enable Python 3 for ANGLE recipe. Bug: chromium:1256377 Change-Id: I0c3a71b2a89fc3e271ad8d4f6c9a8cd91b339899 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3472130 Auto-Submit: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 78c64dd7 2022-02-18T10:01:11 Roll SwiftShader from 13f7365e81be to b4a56a893496 (11 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/13f7365e81be..b4a56a893496 2022-02-17 sergeyu@google.com [Fuchsia] Stop ignoring warnings in llvm-10.0 2022-02-17 capn@google.com Make shader inputs/outputs only statically indexable 2022-02-17 sugoi@google.com VK_EXT_inline_uniform_block implementation 2022-02-17 capn@google.com Fix rr::RoundIntClamped() for architectures other than x86 and ARM 2022-02-16 capn@google.com Fix and improve exp2 accuracy 2022-02-16 capn@google.com Fix handling overflow in Exp2() 2022-02-16 capn@google.com Exhaustively test the exp2 implementation's conformance 2022-02-16 sugoi@google.com Support render area instead of extent in Renderer::draw() 2022-02-16 swiftshader.regress@gmail.com Regres: Update test lists @ 13f7365e 2022-02-16 sugoi@google.com Small resolveDepthStencil refactor 2022-02-16 sugoi@google.com Format fix in VkPromotedExtensions.cpp If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Ic484c218da2d356fe82b35a0d0df6caac38b8954 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3474334 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop 00c4dc93 2022-02-18T09:10:34 Python3: Update generate_test_spec_json.py Bug: angleproject:5707 Change-Id: Ifa84ecfc4f718f2798b232da30613b8af4940a7a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3475171 Auto-Submit: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
kmx.io     mail     discord kmxgit v0.4.0