|
4397ff2f
|
2024-10-25T16:55:30
|
|
Metal: SeparateCompoundStructDeclarations fails validation
Consider GLSL:
struct S { int i; } s;
s=s;
SeparateCompoundStructDeclarations would rewrite this to:
struct S { int i; };
S s';
s=s;
The interm rewrite would rewrite the specification and declaration of s,
but not the use sites. The use sites would use the old type, and thus
something that was not in the tree anymore. This would fail the
validation.
This kind of bug was previously fixed for SeparateDeclarations
in commit 18fa02bebf901dd8501de3176f6052ae4ce984be.
Fix by adding the logic to SeparateDeclarations, as it is already
doing almost the exact task, separating `struct S { ..} a, b`.
The separation is tested in GLSLTests.StructInShader and various
other draw tests. These pass with MSL, but these would also fail
validation if that was enabled.
Bug: angleproject:375523825
Change-Id: I1697103d0ba47616dbd3159f36f9e71cb2831c4b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5964899
Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com>
Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
4a5b0284
|
2024-10-24T11:46:54
|
|
Disallow discarded uniform block references
Uniform block instances cannot be used by themselves, as there
is no way to refer to their type. Disallow the only typeless
access pattern, discarding via expression statement:
uniform MyBlock { int x; } b;
void main() {
b;
0, b;
}
Explained as disallowed in newer GLSL 300:
https://github.com/KhronosGroup/WebGL/issues/3644
The comma expression form would ASSERT in CollectVariables.
Bug: angleproject:42267026
Change-Id: I6c8b835482fd551bd97576c1bd24f005874da6af
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5961498
Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com>
Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com>
|
|
|
898a1c12
|
2024-10-24T13:09:36
|
|
Metal: Fix ToposortStructs validation == failures
ToposortStructs would convert mat, vec, struct == to ANGLE_equals()
calls. However, the functions called were not in AST. This would cause
"Found node calling previously undeclared function
<validateFunctionCall>" validation error and ASSERT.
Mat, vec equality calls would use prelude ANGLE_equals implementations.
The MSL emit already does the conversion from == to ANGLE_equals for
these builtins.
For user-defined structs the logic would be:
- collect struct decls, structs, create equality functions
- toposort
- for each sorted struct:
- insert struct decl
- insert equality function
Move the equality function creation after the toposort:
- collect struct decls, structs
- toposort
- for each sorted struct:
- insert struct decl
- create equality function
- insert equality function
This way the sort ensures that nested struct equality functions can
refer to previously introduced equality functions.
Bug: angleproject:375352601
Change-Id: I59efed98bca6d99b198abc2b5c7577cf5d1d5d83
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5961281
Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com>
|
|
2a62e525
|
2024-06-26T13:27:37
|
|
CL: Fixup copying empty string
Bug: angleproject:375982192
Change-Id: I0703ecf068ca966e1b24169c8f406df4c8dbb5ac
Signed-off-by: Gowtham Tammana <g.tammana@samsung.com>
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5971389
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
0e0e5eae
|
2024-10-28T14:12:30
|
|
Minor clean up for mSamplerBindings usage
Use "const" keyword for samplerBinding.
Bug: None
Change-Id: Ic2c0b133c405012a111919ad07f45d84c07eecee
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5972764
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
08c1724f
|
2024-10-11T14:29:00
|
|
Vulkan: Support GL_ARM_shader_framebuffer_fetch_depth_stencil
Bug: angleproject:352364582
Change-Id: I63fd78314fa7ebccbf366c252e309a9c0f09c8c1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5938150
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
65fcf9c4
|
2024-10-26T10:53:18
|
|
Vulkan: Remove redundant dependent feature checks
Since [1], when a feature is overriden, the dependent features
automatically take the override into account. Tests no longer need to
account for dependent features, neither does the logic in the code.
[1]:https://chromium-review.googlesource.com/c/angle/angle/+/4749524
Bug: angleproject:42266725
Change-Id: I5440aba4a89cffbe710e26ad7de4cfee783e9bdf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5967414
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
c13e9963
|
2024-10-28T15:19:09
|
|
Tests: skip mac intel dEQP-GLES2.functional.polygon_offset
Got re-enabled in
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+/0d2b73e3a4b70d3117abca393e2b86ccf99f4c31
The GLES3 version is already skipped for this config
Bug: angleproject:40096462
Change-Id: I8b6eca1faec9442c6de323000cd223b0c169e35d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5972595
Commit-Queue: Roman Lavrov <romanl@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Roman Lavrov <romanl@google.com>
|
|
ba65fc48
|
2024-05-01T15:53:20
|
|
ANGLE unit test to check const expression in a shader with uniform
Bug: b/338287961
Change-Id: I81586122fdb6cdfe650b9c9094582276220741f1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5507766
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
|
|
|
5987c2bc
|
2024-10-28T14:15:29
|
|
Disable treat_warnings_as_errors on MSVC builds
Chromium rolls into ANGLE are currently blocked due to:
error C2220: the following warning is treated as an error
warning C4068: unknown pragma 'GCC'
MSVC unsupported by Chromium since 2020:
https://groups.google.com/a/chromium.org/g/chromium-dev/c/fuVUxe1q6EA
V8 dropped MSVC support in 2024:
https://groups.google.com/g/v8-users/c/J8Q6VrX9e4M/
ANGLE currently does compile-only MSVC builds. This CL further relaxes
MSVC support by ignoring warnings.
Bug: angleproject:376074941
Change-Id: Id6327617fb95a4b19f64cfda13dbd68733c34aa5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5973134
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Roman Lavrov <romanl@google.com>
|
|
|
0d5c0bd1
|
2024-04-25T10:26:08
|
|
ANGLE end2end test to check const expressions are handled correctly
Bug: b/337046547
Change-Id: I1bd368f8c95a9676aba13fe91313d0eaba32db03
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5490170
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
a769fad4
|
2024-10-24T20:46:42
|
|
Vulkan: Optimize and fix glFinish for single buffered surfaces
Fixed bug:
When calling `onSharedPresentContextFlush()` from `ContextVk::finish()`
need to also call `finishImpl()` to wait for submitted commands. This
bug was introduced in the original commit where
`onSharedPresentContextFlush()` was added.
Optimization:
Skip calling `onSharedPresentContextFlush()` from `ContextVk::finish()`
similarly to `ContextVk::flush()` when there is nothing to flush.
Bug: angleproject:42265370
Bug: b/229908040
Change-Id: Ide9f9c5d8757257c925970faece1e137acf10dec
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5961290
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>
|
|
|
d9f8fba8
|
2024-09-27T15:56:36
|
|
CL/Vulkan: Fix event queue serials
Some of the events are finished at call site, dont set queue serials for
them.
Bug: angleproject:372157567
Change-Id: I4e0d568b76959be96bc7565bae7cdb5d4549619a
Signed-off-by: Gowtham Tammana <g.tammana@samsung.com>
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5916155
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
a0586d6e
|
2024-10-26T00:32:27
|
|
Remove feature description / condition strings
These strings show up in chrome://gpu so they can marginally be useful,
but are otherwise dead weight for most uses of ANGLE / users of ANGLE.
While slightly less convenient, the feature name can always be linked
back to the source code if needed so the presence of such metadata is
not necessary either.
This shaves 40KB from the binary size of ANGLE when built with Vulkan
only on Android.
Bug: chromium:371512561
Change-Id: I3959961bb7de95cc60a85130d0ff38a7fd533fb7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5968453
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
5b4609de
|
2024-10-07T14:40:49
|
|
CL/Vulkan: Adjust the pushConstant size/offset to multple of 4
The spec[1] requires the push constants size/offset to be multiple of 4.
Adjust them as needed.
[1]: https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/vkCmdPushConstants.html#_description
Bug: angleproject:372157565
Change-Id: I8ea788dbd68e3aea262e12af56e40ac84087ceef
Signed-off-by: Gowtham Tammana <g.tammana@samsung.com>
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5916154
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
f2a409f8
|
2024-10-28T10:01:08
|
|
Roll vulkan-deps from b0229dbd25db to 6bf0a68d2621 (25 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/b0229dbd25db..6bf0a68d2621
Also rolling transitive DEPS:
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/2fed4fc07c9190df5369db787a679096c55474e5..3454c3618be8754cb2cec77dc21b142121dc606a
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/252dc2df08f58e0e50c8437edc0e77eacdfb7559..22c4d1b1e9d1c7d9aa5086c93e6491f21080019b
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/895bb9ffecc2c48646b50f77aeb85f5b70b9bb37..ce92630396c2fd2d6d04819369116af4fb141a28
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/e271cfd4809ed133cadc6c3de7903e59628b3d8a..ab1ea9059d75b42a5717c7ab55713bdf194ccf21
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/2d2d46f38fb2e8c0362668ca3605f81d71236f68..c21cdf42bd0ae076d4d200337b9c0f6aa0481f8c
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/2030a5b09f5656d1e9b8c9c4ab3ebe98024da150..9e1ba445cb9ef5267c6062e91c2fa978b1771ba6
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/b541be2eae6f22772015dc76d215c723693ae028..dcb6173f7463ed233696e18eb9992cbe11262af0
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/4ed4b0579d24d04b32e529ab716821b68dcd3c0a..27fb703e7ae415867c17c305ef6738d6f114b2a7
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC angle-team@google.com,romanl@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: romanl@google.com
Change-Id: Iff3aabec62335d0cefc03bab2b96778a685c0b4d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5970618
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
127f1e15
|
2024-10-28T10:01:44
|
|
Roll SwiftShader from 145112eea713 to 3aaa6784ca31 (1 revision)
https://swiftshader.googlesource.com/SwiftShader.git/+log/145112eea713..3aaa6784ca31
2024-10-26 matt@mattcooley.net Don't install commit hook if not in a git
repo
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC angle-team@google.com,romanl@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in SwiftShader:
https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: romanl@google.com
Use-Permissive-Angle-Pixel-Comparison: True
Change-Id: I47200c57f0a9f6e34419cdf09bb1f7428bc6c44a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5970537
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
fe99836c
|
2024-10-25T14:34:23
|
|
Vulkan: Use ANGLE_PERF_WARNING when no serial for reserved serial
When we run out of OutsideRenderPassCommands' queue serial, we have to
call flushCommandsAndEndRenderPass() so that we can get a new set of
reserved serials for OutsideRenderPassCommands. The problem is that we
call ANGLE_VK_PERF_WARNING macro before calling
flushCommandsAndEndRenderPass(), which could insert a
CommandID::InsertDebugUtilsLabel command when debug marker is enabled.
This end up with mOutsideRenderPassCommands becomes not empty and
subsequent call of flushCommandsAndEndRenderPass end up with
flushOutsideRenderPassCommands and not able to early out due to command
buffer is not empty. This CL simply changes ANGLE_VK_PERF_WARNING to
ANGLE_PERF_WARNING to avoid getting into this situation. Assertion is
also added to catch the problem at at the spot it happens.
Bug: b/375661776
Change-Id: I2434af81b139c6b04d7ef1963f76035d60dfd471
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5967615
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Roman Lavrov <romanl@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
715fe91d
|
2024-10-25T17:51:44
|
|
Docs: add a Cuttlefish setup section for apk side-loading
Bug: b/371356548
Change-Id: I579235823cf0d66d9aa8ed86322ebc9f16730def
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5967934
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
|
|
|
4353d25c
|
2024-10-25T16:16:58
|
|
Fix ASAN bug in GLSL test
Bug: chromium:375344329
Change-Id: Id275ba7877c5092bf7b55c06fcfa80614886985c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5967933
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
2d6029d2
|
2024-10-25T08:36:17
|
|
DEPS: Add .git to libdrm URL
Caused autoroller to fail with mismatched URL:
ANGLE DEPS entry third_party/libdrm/src has a different URL (
https://chromium.googlesource.com/chromiumos/third_party/libdrm
) than Chromium (
https://chromium.googlesource.com/chromiumos/third_party/libdrm.git
).
Bug: b/375167852
Change-Id: Ibef2c22745a776ab500f18a10d3ea94370567f57
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5966138
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Auto-Submit: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
3a265f14
|
2024-10-24T17:34:15
|
|
Android tests: raise if --render-test-output-dir doesn't exist
For convenience when testing locally,
otherwise we get an obscure error later on
Bug: angleproject:370089935
Change-Id: I94f52aef90afb600baae45540e0e53f899554ee9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5960260
Auto-Submit: Roman Lavrov <romanl@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Roman Lavrov <romanl@google.com>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
ec262a32
|
2024-10-22T12:34:15
|
|
Trace tests: offscreen gles1 fix framebuffer binding handling
gles1 traces can call glBindFramebufferOES (ex: plague_inc) so we need
to intercept that for offscreen gles1 traces.
Also OES_framebuffer_object does not provide "read" bindings, only a
single framebuffer binding, so we need to special-case binding handling
in the gles1 case.
Bug: angleproject:370508393
Change-Id: Ia17df21ed67aa8a1e0aa45fe9bb929ce42852ba2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5953095
Commit-Queue: Roman Lavrov <romanl@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
12584049
|
2024-10-21T14:04:55
|
|
Make SimplifyLoopConditions testable
Add ShCompileOptions::simplifyLoopConditions, so that tests can turn
it on. Later edits to simplify loop condition logic are simpler to
review when the testing related edits are landed separately.
Test the feature by having ESSL as the input and ESSL as the natural
output, to reflect how AST changes.
To make the test expectations more deterministic across code changes,
change SymbolTable::kLastBuiltInId to
SymbolTable::kFirstUserDefinedSymbolId. This is simpler as no code
needs to know exact last built in id, so we can just ensure that
the user defined symbol ids do not clash with the builtin ids.
Bug: angleproject:374585769
Change-Id: Iea0efb8ac2878691d0fd5ff5cfe9a49ac754515d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5946724
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com>
|
|
|
f2315dbe
|
2024-10-23T13:34:39
|
|
Reland: Vulkan: Update checks for promoted extensions
This relands commit c2219ef9ec03277b6f8ad18d6d1ade41ddf88ba6.
Features that depend on promoted extensions are now enabled when
the extensions are present, OR the version of Vulkan that they were
promoted to is present. This commit checks for Vulkan 1.1 because
that is the version currently supported.
In the reland, the promoted extensions are not added to the list of
extensions to be enabled, because the underlying driver may not have
exposed them as extensions at all.
Bug: angleproject:374483183
Change-Id: I98e004d3fb4ed673984859ab63d40702f877b535
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5955635
Reviewed-by: Jason Macnak <natsu@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
2dcc80dd
|
2024-10-17T13:59:23
|
|
Vulkan: allocateDescriptorSet to avoid repeated try on same pool
DynamicDescriptorPool::allocateDescriptorSet has a few steps. It first
tries to allocate from the same pool. Then tries to allocate from
mCurrentPoolIndex and then loops all existing pools. This CL keeps the
same basic logic, but avoids repeated tries on the same pool.
Bug: angleproject:372268711
Change-Id: Ic3099ac8c68688fe9afe452f808be29ac9063d51
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5926182
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
a070b65a
|
2024-10-23T09:52:11
|
|
Roll Chromium from e7eae5389783 to ada7221c4738 (2147 revisions)
Sync libdrm from Chromium after
https://chromium-review.googlesource.com/c/chromium/src/+/5941361
https://chromium.googlesource.com/chromium/src.git/+log/e7eae5389783..ada7221c4738
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com,cnorthrop@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/64f08eb696..774b608643
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/3e502749c2..09ea565f4a
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/48150ad7ff..546ad56e8a
* third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/1bbb99f4c8..9c2addd45d
* third_party/android_build_tools/error_prone/cipd: hcirhm3eL0eu2NTEMxlGV_mdnvPATJ2-iQZa4SaUUfIC..n77J6kWie5cSD7pmkTyni9GjOYh2lyebCU6Eyr6GxXkC
* third_party/android_build_tools/lint/cipd: nKZoTG4Pkcpxo4-FX-0UVN1jIfWLTTTZs2lCfkq2Zg0C..4LvjVBJ-tE7OOEwn-wr9aM6zYpZjl2bZ6jvbfAdCo3wC
* third_party/android_build_tools/manifest_merger/cipd: BtJFh2thmUKU-OBYMaw_dRmyizFdL8AzLQ6C2pV99wUC..92AO-IC4QP7pBCfygcFNL6xN7xiJLTSWdiS0q-pq4ukC
* third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/306f6a40ac..fdebd3d15a
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/dc40fdd237..940a36cedf
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c4d75a1519..cc924d1ab6
* third_party/fuchsia-sdk/sdk: version:24.20241014.3.1..version:25.20241022.0.1
* third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/d9456b7a63..c8eec3629a
* third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/41b4634414..59d05179e3
* third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/a661187e08..29d8a79ce5
* third_party/r8/cipd: K7fIEIzzANXaspaV4maRvvy6jqYIHGEgoC4gfJvSD_0C..zNYp2KVrHI9KDsLQCdJIFzXTvkqx3Dav9o5vR1UlMxQC
* third_party/r8/d8/cipd: 3KCj5eRYCvGGYs5i90pRaeihkzsqgUGc4OkICT8AOlIC..zNYp2KVrHI9KDsLQCdJIFzXTvkqx3Dav9o5vR1UlMxQC
* third_party/siso/cipd: git_revision:f10ec3c74e86f2de9b9e5ad4e2d8d3b0192ea4d2..git_revision:4237c4b45d2accad9955693251a99f0b862a0a03
* third_party/turbine/cipd: vSia3h9tzpwpP_goLj4HMdl7_FEB5iVCv9nU5ZXOfIMC..dODwcAXI7V4M-fHO0rZvcMEcW3qgfNnkoPeuwxzO4DsC
* third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/fa9f14143c..c7678ba8af
* tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/f390ba146f..4b9a28a9b7
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/fcba6e59ba..53554bf3da
* tools/luci-go: git_revision:7dd39503276dfa4a920102ca77a2f409f2f67655..git_revision:d212e392e327834378013806f0263ab263600db2
* tools/luci-go: git_revision:7dd39503276dfa4a920102ca77a2f409f2f67655..git_revision:d212e392e327834378013806f0263ab263600db2
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/b2fd313bb8..752c7a08fc
* tools/skia_goldctl/linux: PpuoaxFG9rnuDcsvax6FcKG2ZWKhNvsO7tqW6G70GXAC..CXeEV6BLm5q9KGe-brhM2NLdmEgjyMyTutd_o3ioqMwC
* tools/skia_goldctl/mac_amd64: RQRQgiXDQ-q73iA9ZFw7R00gRWhOTXu3l1ns3hede0AC..XrxKbvaH3xwOzOdudnSzNTwqJhocETDPtsYNQNWHeIwC
* tools/skia_goldctl/mac_arm64: MU2sytEh51XCW0Nk_qOg2tC9GumCMAjxh-xg8tB0IYkC..oZ0XmjQl2uVb7JQS4TNGfkr4O_ZGRDCZK7VuTwAdZsoC
* tools/skia_goldctl/win: tEJ0WAy5v1qaOQ_jBcMUj540tXs7W8JZOXUNJKKQNPYC..fuydFP_nMX2mXcsO2vqFYHv2H1jdpvF95t8AGCcH7wIC
No update to Clang.
Bug: None
Change-Id: Ie03b429529f91371cc7f6da3973391c640eaf6c5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5955606
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
a05fc2bc
|
2024-10-23T13:36:54
|
|
Revert "Vulkan: Update checks for promoted extensions"
This reverts commit 9c1f96b8606a564b565d37208268b9b06efff03e.
Reason for revert: Still fails on Cuttlefish (which uses SwiftShader)
Bug: angleproject:374975259
Original change's description:
> Vulkan: Update checks for promoted extensions
>
> Features that depend on promoted extensions are now enabled when
> the extensions are present, OR the version of Vulkan that they were
> promoted to is present. This commit checks for Vulkan 1.1 because
> that is the version currently supported.
>
> Bug: angleproject:374483183
> Change-Id: I17d7956ac8a604f531e020e77c6f532e616b9dd5
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5954316
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Bug: angleproject:374483183
Change-Id: I1bef03f99b044bca91950a62e4015630a7c91530
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5956483
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Cody Northrop <cnorthrop@google.com>
|
|
|
70b711a8
|
2024-10-23T10:01:46
|
|
Roll vulkan-deps from d8276cfd24b7 to b0229dbd25db (2 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/d8276cfd24b7..b0229dbd25db
Also rolling transitive DEPS:
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/b955ae0edb4f02074bfbf134ccc1980e83122d30..e271cfd4809ed133cadc6c3de7903e59628b3d8a
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/6dca9173407b7718e06e7461d551cdffa64be68b..4ed4b0579d24d04b32e529ab716821b68dcd3c0a
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC angle-team@google.com,cnorthrop@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: cnorthrop@google.com
Change-Id: I90ce90cb94069a582ebd9e65a8cc49816a0dff5f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5956474
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
9a4c7495
|
2024-10-15T13:05:28
|
|
Vulkan: Add feature flag to enable descriptorSet cache
So that we can disable it to compare the performance difference.
Bug: angleproject:372268711
Change-Id: I02da254e5d58815741080634a2dd005617aa7432
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5936135
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
|
|
|
31c80bbf
|
2024-10-17T10:56:16
|
|
Vulkan: Avoid redundant work in updateFullActiveTextures
ContextVk keeps mActiveTexturesDesc, which gets updated by
UpdatePreCacheActiveTextures(). This is only used for cache lookup. When
there is a cache miss, we end up call updateFullActiveTextures() which
recomputes DescriptorSetDesc again, which is redundant work.
This CL removes mActiveTexturesDesc from ContextVk.
UpdatePreCacheActiveTextures has been changed to be a
DescriptorSetDescBuilder method so that it can directly update the
mDesc. updateFullActiveTextures has been renamed to
updateActiveTexturesForCacheMiss which avoid mDesc calculation.
updateFullActiveTextures is still kept for now which will be used in
next CL when cache is disabled.
Bug: b/372268711
Change-Id: Ic9a0cdaa7cefca5f72b599d26d079cef14888f07
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5905766
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
|
922147f9
|
2024-10-22T18:20:44
|
|
Trace tests: offscreen sRGB traces use sRGB format
Without this offscreen screenshots end up darker.
Currently applies to 7 traces, can be found with:
% egrep 'DrawSurfaceColorSpace.*0x3089' src/tests/restricted_traces/*/*.json
Bug: angleproject:370089935
Change-Id: I4a05782de2e7400fcfcb5757d18acf758749d6ef
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5953096
Commit-Queue: Roman Lavrov <romanl@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
dd54eeec
|
2024-10-11T13:26:46
|
|
Reland "Vulkan: Track GPU progress for individual DescriptorSet"
This is a reland of commit 292102944add2ab30f4aa12a971cac456cc7726b
with the fix of garbage being added back to garbage list.
Original change's description:
> Vulkan: Track GPU progress for individual DescriptorSet
>
> Right now ProgramExecutableVk keeps VkDescriptorSet object, and
> DescriptorSetHelper is created when a cache entry becomes invalid.
> Further, DescriptorSetCache keeps the cache of {VkDescriptorSet,
> RefCountedDescriptorPoolHelper} pair. So we are having three different
> type of objects at different stages of life: VkDescriptorSet,
> DescriptorSetHelper, and {VkDescriptorSet,
> RefCountedDescriptorPoolHelper. This CL makes DescriptorSetHelper at
> creation and at cache and at garbage. With this change, you have a
> reference counted DescriptorSetHelper object (i.e, DescriptorSetPointer)
> during entire life cycle and is passed around between cache and program
> as is. This CL is preparation for the future CL where we may disable
> cache for descriptorSet. The descriptorSet will be added to garbage list
> and reused constantly without go through the cache code. We need to
> track the individual descriptorSet with ResourceUse so that it won't
> reuse until GPU is finished. This CL is making DescriptorSetHelper a GPU
> tracking object so that it will still just work when cache is disabled.
>
> Bug: angleproject:372268711
> Change-Id: I1cfb77cc5069b202d870388fd8809e265cdca90b
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5918586
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Commit-Queue: Charlie Lao <cclao@google.com>
> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Bug: angleproject:372268711
Change-Id: Ic920f99cc78cde1e94690bdbee3b885844fa155b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5954701
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
|
|
60da450e
|
2024-09-20T17:56:55
|
|
CL: Implicit cmd queue submit on release
From OpenCL spec (3.0):
https://registry.khronos.org/OpenCL/specs/3.0-unified/html/OpenCL_API.html#_flush_and_finish
clReleaseCommandQueue perform an
implicit flush of the command-queue.
Bug: angleproject:8639
Change-Id: I0a3b0f3c602075fd2a6e1ac0310345b3d568df64
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5410931
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Austin Annestrand <a.annestrand@samsung.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
45cc47af
|
2024-10-22T21:41:22
|
|
Revert "Vulkan: Track GPU progress for individual DescriptorSet"
This reverts commit 292102944add2ab30f4aa12a971cac456cc7726b.
Reason for revert: Causing bot failure in later CLs
Original change's description:
> Vulkan: Track GPU progress for individual DescriptorSet
>
> Right now ProgramExecutableVk keeps VkDescriptorSet object, and
> DescriptorSetHelper is created when a cache entry becomes invalid.
> Further, DescriptorSetCache keeps the cache of {VkDescriptorSet,
> RefCountedDescriptorPoolHelper} pair. So we are having three different
> type of objects at different stages of life: VkDescriptorSet,
> DescriptorSetHelper, and {VkDescriptorSet,
> RefCountedDescriptorPoolHelper. This CL makes DescriptorSetHelper at
> creation and at cache and at garbage. With this change, you have a
> reference counted DescriptorSetHelper object (i.e, DescriptorSetPointer)
> during entire life cycle and is passed around between cache and program
> as is. This CL is preparation for the future CL where we may disable
> cache for descriptorSet. The descriptorSet will be added to garbage list
> and reused constantly without go through the cache code. We need to
> track the individual descriptorSet with ResourceUse so that it won't
> reuse until GPU is finished. This CL is making DescriptorSetHelper a GPU
> tracking object so that it will still just work when cache is disabled.
>
> Bug: angleproject:372268711
> Change-Id: I1cfb77cc5069b202d870388fd8809e265cdca90b
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5918586
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Commit-Queue: Charlie Lao <cclao@google.com>
> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Bug: angleproject:372268711
Change-Id: I4d3c34058d100112a098144276b52c0faf8d593a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5955529
Auto-Submit: Charlie Lao <cclao@google.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
|
|
9c1f96b8
|
2024-10-22T12:58:27
|
|
Vulkan: Update checks for promoted extensions
Features that depend on promoted extensions are now enabled when
the extensions are present, OR the version of Vulkan that they were
promoted to is present. This commit checks for Vulkan 1.1 because
that is the version currently supported.
Bug: angleproject:374483183
Change-Id: I17d7956ac8a604f531e020e77c6f532e616b9dd5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5954316
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
99ba07d3
|
2024-03-26T00:58:57
|
|
CL/Vulkan: Implement createImage
Enabling functionality of:
- clCreateImage
Tests-Passing: OCLCTS.test_api get_image<1d|2d|3d>_info
Bug: angleproject:42266936
Signed-off-by: Rafay Khurram <r.khurram@samsung.com>
Change-Id: I0281f092bff13cdd81b87d596fdd15b33dda7e46
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5796527
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
d774f75c
|
2024-10-21T00:00:00
|
|
Fix Python warning in overlay fonts generator
Fixed: angleproject:358565474
Change-Id: Ide48691fa4d52d063c5c80fc7cdbc16c99a97ed0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5953793
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
29210294
|
2024-10-11T13:26:46
|
|
Vulkan: Track GPU progress for individual DescriptorSet
Right now ProgramExecutableVk keeps VkDescriptorSet object, and
DescriptorSetHelper is created when a cache entry becomes invalid.
Further, DescriptorSetCache keeps the cache of {VkDescriptorSet,
RefCountedDescriptorPoolHelper} pair. So we are having three different
type of objects at different stages of life: VkDescriptorSet,
DescriptorSetHelper, and {VkDescriptorSet,
RefCountedDescriptorPoolHelper. This CL makes DescriptorSetHelper at
creation and at cache and at garbage. With this change, you have a
reference counted DescriptorSetHelper object (i.e, DescriptorSetPointer)
during entire life cycle and is passed around between cache and program
as is. This CL is preparation for the future CL where we may disable
cache for descriptorSet. The descriptorSet will be added to garbage list
and reused constantly without go through the cache code. We need to
track the individual descriptorSet with ResourceUse so that it won't
reuse until GPU is finished. This CL is making DescriptorSetHelper a GPU
tracking object so that it will still just work when cache is disabled.
Bug: angleproject:372268711
Change-Id: I1cfb77cc5069b202d870388fd8809e265cdca90b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5918586
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
|
|
|
47c66901
|
2024-10-21T12:47:22
|
|
Vulkan: Set gl_Layer to 0 if the framebuffer is not layered
Bug: angleproject:372390039
Change-Id: I29067c9488e06f6dd2e90f207fecb843267fb77c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5949263
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
e869b426
|
2024-10-22T10:04:06
|
|
Revert "Removed checks for promoted extensions"
This reverts commit c2219ef9ec03277b6f8ad18d6d1ade41ddf88ba6.
Reason for revert: Possible cause of boot failures on cuttlefish
Bug: angleproject:374975259
Original change's description:
> Removed checks for promoted extensions
>
> Removed checks for Vulkan extensions that have been promoted into Vulkan
> 1.1, which is already the minimum required version for ANGLE. The
> dependent features now work when the extensions are missing because the
> extensions are no longer necessary.
>
> Bug: angleproject:374483183
> Change-Id: Iad92b33a8e724eaa8f4bfcbe406f5b6b8536d6d8
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5944678
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Reviewed-by: Charlie Lao <cclao@google.com>
> Commit-Queue: Charlie Lao <cclao@google.com>
Bug: angleproject:374483183
Change-Id: I92eb6681c6d1b8f7e2d0832bb4e1cbf4597bd1c6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5952279
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
f4e776a8
|
2024-10-14T22:41:34
|
|
GLES1: Fix eye distance for fog
Distance should be non-negative, so use abs().
From the spec, OpenGL ES 1.1 §3.8. Note the 'abs' symbols.
An implementation may choose to approximate the eye-coordinate
distance from the eye to each fragment center by |z_{e}|.
Bug: b/369665616
Test: angle_trace_tests --gtest_filter="*minetest*"
Change-Id: Ic6c162ba2469600fa6a8c8d61e5bccf5c0cb12d9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5933566
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Lina Versace <linyaa@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Lina Versace <linyaa@google.com>
|
|
|
04c0ef46
|
2024-10-22T10:01:31
|
|
Roll SwiftShader from 0afe6a306dd2 to 145112eea713 (1 revision)
https://swiftshader.googlesource.com/SwiftShader.git/+log/0afe6a306dd2..145112eea713
2024-10-21 swiftshader.regress@gmail.com Regres: Update test lists @
0afe6a30
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC angle-team@google.com,cnorthrop@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in SwiftShader:
https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: cnorthrop@google.com
Use-Permissive-Angle-Pixel-Comparison: True
Change-Id: I84efb88927111550f11636f6de33706fc93ac2b6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5952689
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
dad24ded
|
2024-10-22T10:01:03
|
|
Roll vulkan-deps from 1ea770ceed23 to d8276cfd24b7 (7 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/1ea770ceed23..d8276cfd24b7
Also rolling transitive DEPS:
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/0d26b9d6d64f30105755b60fc9747065617998b4..2fed4fc07c9190df5369db787a679096c55474e5
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/ba37b3b5131832ace24becf40e65bb0857944775..895bb9ffecc2c48646b50f77aeb85f5b70b9bb37
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/edb909e193061350f0274345463e7b9747e109ba..6dca9173407b7718e06e7461d551cdffa64be68b
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC angle-team@google.com,cnorthrop@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: cnorthrop@google.com
Change-Id: Icb732099bd137cd8772250dde7cc7c9f76ae6aed
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5952613
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
4bdcdf0d
|
2024-10-16T11:44:49
|
|
Vulkan: Switch RefCountedDescriptorPoolBinding to use SharedPtr
This mostly a clean up. RefCountedDescriptorPoolBinding is replaced with
DescriptorPoolPointer, which is defined as
SharedPtr<DescriptorPoolHelper>. It has more intuitive semantics to use.
Bug: angleproject:372268711
Change-Id: I0397111b5228e896c1d226e00930851319d955a0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5938947
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
|
c52e8493
|
2024-10-11T14:21:19
|
|
Vulkan: Switch DescriptorPoolPointer to use SharedPtr
To make the reference counting easier to maintain, SharedPtr class is
added to automatically tracking the reference counting and object
creation/destruction. Right now we have BindingPointer class doing
similar things except it does not automatically manage the object
create/destroy, which makes it less robust as well as redundant code to
manage object life cycle. The other problem with BindingPointer is that
it does not work with normal assign/copy operator which made it hard to
read and use. SharedPtr uses exact same API semantics as
std::shared_ptr, which makes the reference counting very easy to use.
The main difference of SharedPtr and std::shared_ptr is that it does not
use any atomic or lock since it assumes user only uses it under thread
safe environment, which ANGLE's backend is.
This CL also changes mDescriptorPools to mDynamicDescriptorPools to make
it clear that it is dynamic descriptor pool not the descriptor pool.
This is also preparation CL for the next CL where we will use SharedPtr
to manage DescriptorSetHelper life cycle, which otherwise a bit
complicated to manually manage.
Bug: angleproject:372268711
Change-Id: I1033d9bf259bbc075a9b374d8a28e1f67d889873
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5926183
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
bbe68963
|
2024-10-21T15:11:27
|
|
Vulkan: Fix `precise` vs `mat4(...)[index]`
Bug: angleproject:374801303
Change-Id: I45550abe406aaaf4d2c5eb5d7d694b2b30ab8e4e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5949528
Reviewed-by: mohan maiya <m.maiya@samsung.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
|
5c2a2fd5
|
2024-10-21T16:00:25
|
|
Vulkan: Fix `vec4(...).zxwy[index]`
The code was actually correct, but included an unnecessary assertion.
The code incorrectly assumed `.zxwy[index]` is pre-processed with a
lookup table and turned into `[index']`, but it wasn't if the LHS is a
constructor.
The change just removes the assertion because it was correctly handling
that already.
Bug: angleproject:40096715
Change-Id: Ib1365f95a255ce3654831af55429361d35c026c4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5949527
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
ef55ca0a
|
2024-10-17T14:44:22
|
|
Update copy validation regarding ext textures
* Updated the validation functions for the following function to
accept TEXTURE_EXTERNAL_OES: glCopyImageSubDataEXT()
* Updated unit test CopyTextureTestES3.CopyImageSubDataToEGLImage
* Using TEXTURE_EXTERNAL_OES as target for glFramebufferTexture2D()
requires EXT_YUV_target. Therefore, the texture related to it is
used instead.
Bug: angleproject:361372990
Change-Id: I905d4cf89522ae3158516b42b15705d1044c6e97
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5940404
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
a19f0947
|
2024-10-17T22:42:30
|
|
Vulkan: Cache depth- and stencil-only views
Existing depth/stencil blit and resolve paths created temporary depth-
and stencil-only views. For
GL_ARM_shader_framebuffer_fetch_depth_stencil, such views are needed as
well.
In preparation for that extension, this change adds depth- and
stencil-only views to ImageViewHelper and allows them to be retrieved
through RenderTargetVk. The blit and resolve paths are consequently
simplfied as a side-effect.
Bug: angleproject:352364582
Change-Id: Ia822efb44ca7c82f63afce904eb19dd1bed02ff5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5938149
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
|
|
|
c2219ef9
|
2024-10-20T04:49:44
|
|
Removed checks for promoted extensions
Removed checks for Vulkan extensions that have been promoted into Vulkan
1.1, which is already the minimum required version for ANGLE. The
dependent features now work when the extensions are missing because the
extensions are no longer necessary.
Bug: angleproject:374483183
Change-Id: Iad92b33a8e724eaa8f4bfcbe406f5b6b8536d6d8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5944678
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
|
c42ecd73
|
2024-10-21T10:01:14
|
|
Roll vulkan-deps from b48b5be748a7 to 1ea770ceed23 (16 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/b48b5be748a7..1ea770ceed23
Also rolling transitive DEPS:
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/2bfc7cadbd52a90833416633a77ce1941086ea79..0d26b9d6d64f30105755b60fc9747065617998b4
https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/b02737a0783ae7e40c728f9b346aa919c241f270..a251560a3f1ea56fb5b1d32667d2df6e83e06eda
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/d91597a82f881d473887b560a03a7edf2720b72c..b955ae0edb4f02074bfbf134ccc1980e83122d30
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/326e17b35f028cec8c597926d4da3178760d6a93..2d2d46f38fb2e8c0362668ca3605f81d71236f68
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/56eca742a15f8a692306b66b23484682ee6e1806..2030a5b09f5656d1e9b8c9c4ab3ebe98024da150
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/bfd85956e1b4c1c79842ce857fc7fb15adb8a573..b541be2eae6f22772015dc76d215c723693ae028
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/44e69fc6823a1f11bf0dca9187287b618e30c842..edb909e193061350f0274345463e7b9747e109ba
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC angle-team@google.com,cnorthrop@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: cnorthrop@google.com
Change-Id: I2b873865717511bf9b30cefc7ebc43c101c91190
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5946146
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
d7c5710c
|
2024-10-21T08:01:56
|
|
Roll VK-GL-CTS from 5e9887eb393c to cfd0b16e7b5e (3 revisions)
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/5e9887eb393c..cfd0b16e7b5e
2024-10-17 piotr.byszewski@mobica.com Resolve workaround for instance
entry points
2024-10-17 javed@igalia.com Add tests for mutable clear operations
2024-10-17 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.10
into vk-gl-cts/main
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC angle-team@google.com,cnorthrop@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: cnorthrop@google.com
Change-Id: I7898fd44a669eafc9d5f8052137fd1011013fe52
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5945825
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
4aa12e9e
|
2024-10-07T00:00:00
|
|
Metal: Remove macOS 11.0 availability checks
Chromium now requires at least macOS 11.0.
This also implies MSL 2.3 support.
Bug: angleproject:371829506
Change-Id: I6aaf4d9775bfe58747df28173d3931aa11fa8d25
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5912903
Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
|
8ec1d518
|
2024-10-18T10:01:11
|
|
Roll vulkan-deps from 844aac33d628 to b48b5be748a7 (3 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/844aac33d628..b48b5be748a7
Also rolling transitive DEPS:
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/14388d7014727a12d245a262a8ccfdf3799ad329..ba37b3b5131832ace24becf40e65bb0857944775
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/69b169c836bf53872d00c61d4c4505a0c8792ce8..44e69fc6823a1f11bf0dca9187287b618e30c842
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC abdolrashidi@google.com,angle-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: abdolrashidi@google.com
Change-Id: I6a531c122890cc7f103635cc234f554605c95e26
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5941608
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
7bca73ac
|
2024-10-18T07:01:19
|
|
Roll Chromium from 04637c3ecbf3 to e7eae5389783 (616 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/04637c3ecbf3..e7eae5389783
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC abdolrashidi@google.com,angle-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/5c1a618e66..64f08eb696
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/d1850bb09e..3e502749c2
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/828608cedd..48150ad7ff
* third_party/android_build_tools/lint/cipd: mdSn1xC1q9jWxUbFXVABLAcfaTEVIHsHSDn1Vc-DSogC..nKZoTG4Pkcpxo4-FX-0UVN1jIfWLTTTZs2lCfkq2Zg0C
* third_party/android_build_tools/manifest_merger/cipd: 1bPC5SWXuor2mD8xg9dGl27WcKYCkBaR_LTtNPAuj8gC..BtJFh2thmUKU-OBYMaw_dRmyizFdL8AzLQ6C2pV99wUC
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/f90713ece1..dc40fdd237
* third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/08e1a067cd..d9456b7a63
* third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/9a1d90c3b4..5bfc713304
* third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/efc3baa2d1..41b4634414
* third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/490643fe6e..a661187e08
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/0870580298..fcba6e59ba
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/32b215b1b7..b2fd313bb8
* tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/599e3714e4..ed0fe5c0e0
No update to Clang.
Bug: None
Tbr: abdolrashidi@google.com
Change-Id: I1f9380a6a9d4a886a93e41f6d52f800c522a3c44
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5941606
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
ff455e8c
|
2024-10-17T13:19:09
|
|
Add tests to check copy image with TEXTURE_EXTERNAL_OES
According to spec of EXT_copy_image, GL_TEXTURE_EXTERNAL_OES should be
accepted by glCopyImageSubDataEXT.
Add two tests to check copy image from gles texture to EGLImage and from
EGLImage to gles texture by API glCopyImageSubDataEXT.
As ANGLE does not support this currently, skip these two tests on all
platforms.
Bug: angleproject:361372990
Change-Id: Iceacb2d6af2277a314a215220c3ccdf47665561c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5940214
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
182aa407
|
2024-08-14T19:52:30
|
|
Reland "Metal: translate IOSurface pbuffer's GL_RGB to RGBX/BGRX format."
This is a reland of commit f102d75a39ec8980a617c179034c24f337b12d1c
Nothing changed, it's just that the root cause was already fixed in
https://chromium-review.googlesource.com/c/angle/angle/+/5937060.
Original change's description:
> Metal: translate IOSurface pbuffer's GL_RGB to RGBX/BGRX format.
>
> Currently when IOSurface is bound to a pbuffer with GL_RGB internal
> format, we asign angle format=B8G8R8A8_UNORM/R8G8B8A8_UNORM to it.
> And then disable alpha write to the respective MTLTexture.
>
> However, when an implicit MSAA texture is created for the above
> pbuffer, it will be assigned B8G8R8A8_UNORM/R8G8B8A8_UNORM angle format
> but has no knowledge about alpha write disable. Consequently, when a
> render pass uses this implicit MSAA texture, its alpha channel won't be
> cleared properly and would contain garbage values.
>
> In order to avoid the above bug, we should use
> B8G8R8X8_UNORM/R8G8B8X8_UNORM angle format for the IOSurface pbuffer.
>
> This will fix the render corruptions found in chromium:358957665.
>
> Bug: angleproject:42261786
> Bug: chromium:358957665
> Change-Id: I8aa1e24ace2de80dd08e21711445515ba4b339ff
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5788801
> Reviewed-by: Geoff Lang <geofflang@chromium.org>
> Commit-Queue: Quyen Le <lehoangquyen@chromium.org>
Bug: angleproject:42261786
Bug: chromium:358957665
Change-Id: I1e090886ed493eafce35d2ba98010c3be7bc16c9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5937061
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Auto-Submit: Quyen Le <lehoangquyen@chromium.org>
Commit-Queue: Quyen Le <lehoangquyen@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
0fded2c4
|
2024-10-18T03:04:45
|
|
Manual roll SwiftShader from 74b783dffb9b to 0afe6a306dd2 (1 revision)
Manual roll requested by syoussefi@google.com
https://swiftshader.googlesource.com/SwiftShader.git/+log/74b783dffb9b..0afe6a306dd2
2024-10-17 syoussefi@google.com Fix input attachment read from
stencil-only attachment
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC
abdolrashidi@google.com,angle-team@google.com,syoussefi@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader:
https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: angleproject:352364582
Tbr: abdolrashidi@google.com,syoussefi@google.com
Use-Permissive-Angle-Pixel-Comparison: True
Change-Id: I692c536b08d7fb67afb733c9bb940f18028f905b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5941766
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
4b1e58d9
|
2024-10-17T09:33:53
|
|
Fix for float constant precision in the GLSL backend.
Increase the precision of floating point values written out
via std::ostringstream. 8 digits is not sufficient to represent
all floating point values.
Note: the reason the locale test was modified is because it was using
a value of 1.9, which has no exact fp32 representation. Increasing
the precision causes it to print as 1.8999998 instead of 1.9, failing
the test. I've adjusted the value to 1.5, since this does have an
exact fp32 representation. (However, note that I couldn't get the test
to fail when I removed the locale setting, with either 1.9 or 1.5.
Perhaps the locale is being handled at a different level.)
Bug: angleproject:374013421
Change-Id: Icb79eb9acd562c83d079f2cc2cdba253220e581e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5938473
Commit-Queue: Stephen White <senorblanco@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
2b329ee4
|
2024-10-18T01:37:10
|
|
Metal: fix memory leaks in Texture::getStencilView
The leaks were because we stored a strong ref to the texture itself in
mStencilView member if the texture already has a stencil format. This
caused a circular reference preventing the texture from being released.
This indirectly caused MSRTT's memory leaks in chromium:374072906 due to
MSRTT using getStencilView for blitting step.
Bug: chromium:374072906
Change-Id: I8ced300c2da2de1282c623780dd1affd9d45fb05
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5937060
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Quyen Le <lehoangquyen@chromium.org>
Auto-Submit: Quyen Le <lehoangquyen@chromium.org>
|
|
|
78f146e3
|
2024-10-14T00:00:00
|
|
Remove EAGL support
Fixed: angleproject:362530620
Change-Id: I6157655a7ad5b1e30c5d0a155d3ae3e8a81997e8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5938872
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com>
|
|
5b96316b
|
2024-10-17T14:00:41
|
|
Revert "Metal: translate IOSurface pbuffer's GL_RGB to RGBX/BGRX format."
This reverts commit f102d75a39ec8980a617c179034c24f337b12d1c.
Reason for revert: Suspecting this caused an GPU memory regression on Mac.
Bug: chromium:374072906
Original change's description:
> Metal: translate IOSurface pbuffer's GL_RGB to RGBX/BGRX format.
>
> Currently when IOSurface is bound to a pbuffer with GL_RGB internal
> format, we asign angle format=B8G8R8A8_UNORM/R8G8B8A8_UNORM to it.
> And then disable alpha write to the respective MTLTexture.
>
> However, when an implicit MSAA texture is created for the above
> pbuffer, it will be assigned B8G8R8A8_UNORM/R8G8B8A8_UNORM angle format
> but has no knowledge about alpha write disable. Consequently, when a
> render pass uses this implicit MSAA texture, its alpha channel won't be
> cleared properly and would contain garbage values.
>
> In order to avoid the above bug, we should use
> B8G8R8X8_UNORM/R8G8B8X8_UNORM angle format for the IOSurface pbuffer.
>
> This will fix the render corruptions found in chromium:358957665.
>
> Bug: angleproject:42261786
> Bug: chromium:358957665
> Change-Id: I8aa1e24ace2de80dd08e21711445515ba4b339ff
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5788801
> Reviewed-by: Geoff Lang <geofflang@chromium.org>
> Commit-Queue: Quyen Le <lehoangquyen@chromium.org>
Bug: angleproject:42261786
Bug: chromium:358957665
Change-Id: I29238588f78f2d01c77a317b2a22670a8036d2e3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5939455
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
831a52f2
|
2024-10-16T13:46:04
|
|
Hold on to error message in LinkTaskMtl as C++ string.
Make a copy of the incoming C string because the error message might
be dynamically allocated and deallocated by the caller.
Bug: angleproject:370425451
Change-Id: If4aaa93a90a1da8bc60f7839e29b705b0d2864e5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5938484
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Auto-Submit: Kenneth Russell <kbr@chromium.org>
|
|
|
79ae1e59
|
2024-10-17T10:01:09
|
|
Roll vulkan-deps from ad31dd1cb898 to 844aac33d628 (12 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/ad31dd1cb898..844aac33d628
Also rolling transitive DEPS:
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/50bc4debdc3eec5045edbeb8ce164090e29b91f3..252dc2df08f58e0e50c8437edc0e77eacdfb7559
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/5b98dea6f1ce1a6b84d733d6093cdb208f4a0752..14388d7014727a12d245a262a8ccfdf3799ad329
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/e76c08dbd4851912e001d4618d34301d95149816..69b169c836bf53872d00c61d4c4505a0c8792ce8
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC abdolrashidi@google.com,angle-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: abdolrashidi@google.com
Change-Id: I3351ae3d733537eed17a46a909db1d74833cfa97
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5940402
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
e7aa81e5
|
2024-10-17T07:00:25
|
|
Roll Chromium from fb88b76548ad to 04637c3ecbf3 (610 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/fb88b76548ad..04637c3ecbf3
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC abdolrashidi@google.com,angle-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/cf625e474b..5c1a618e66
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/cdead231af..d1850bb09e
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/cb82a60836..828608cedd
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/36c94904a0..437172bab2
* third_party/android_build_tools/error_prone/cipd: hUxlP8GvC1xhmZ6r9xjYau2laPlzHbs_P2emx4ZL4jgC..hcirhm3eL0eu2NTEMxlGV_mdnvPATJ2-iQZa4SaUUfIC
* third_party/android_build_tools/lint/cipd: kB_cywmS9q9mkY7RC6lpOXEqIsOjRPwwQdaCENEO0ucC..mdSn1xC1q9jWxUbFXVABLAcfaTEVIHsHSDn1Vc-DSogC
* third_party/android_build_tools/manifest_merger/cipd: rnIeJMlGw7adxOKZofLsm7tdYaOy1nHivJn9ck7ocVkC..1bPC5SWXuor2mD8xg9dGl27WcKYCkBaR_LTtNPAuj8gC
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/4479191661..f90713ece1
* third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/321045da9a..08e1a067cd
* tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/be6dc62553..f390ba146f
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/bfbba056b1..32b215b1b7
No update to Clang.
Bug: None
Tbr: abdolrashidi@google.com
Change-Id: I7859f5aa5f04834b765eb7c24b8a5af80d392aaf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5940033
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
2f644ed8
|
2024-10-16T00:00:00
|
|
Implement NULL translator output
Fixed: angleproject:373818287
Change-Id: If862e8e66a043ef968daea91d95717af97e3a0de
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5937827
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
323187d9
|
2024-10-11T13:48:51
|
|
Vulkan: Fix color attachment limit with framebuffer fetch
ANGLE incorreclty assumed that the input descriptor limit is at least as
big as the color attachment limit. This is not true on Intel/windows
where 8 color attachments are available but only 7 input descriptors.
With this change, the color attachment limit is dropped to 7 in such a
case so that framebuffer fetch can continue to be supported.
Bug: angleproject:372873263
Change-Id: If836563b47399a23b293b74815f6bccb21aaf47c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5919759
Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
3b0d1e44
|
2024-10-16T00:00:00
|
|
Add NULL shader output type
Also removed enum values
as they are not needed.
Bug: angleproject:373818287
Change-Id: I37eeac8fbdb3a4b4d26646b02f9f7925f59833a1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5938874
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
3fa74223
|
2024-03-26T17:13:52
|
|
Vulkan: Add check for VK_EXT_external_memory_host extension
Tests-Passing: GN Build
Bug: angleproject:42266936
Change-Id: Ie30f1cee939bc8a4b98d37f718e4526156916f05
Signed-off-by: Rafay Khurram <r.khurram@samsung.com>
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5796524
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
2ee914a4
|
2024-03-04T06:54:29
|
|
CL: Add cl_image_format map autogeneration
* Added map JSON files containing CL image formats
* Updated ANGLE format table generator to include CL foramts
Tests-Passing: GN Build
Signed-off-by: hoonee.cho <hoonee.cho@samsung.com>
Bug: angleproject:42266936
Change-Id: I2967ea6d26f69223ffa3ca12d469c05a3844200f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5798054
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Rafay Khurram <r.khurram@samsung.com>
|
|
|
897a5654
|
2024-10-16T10:32:16
|
|
CL: Rename isSet/isNotSet to intersects/excludes
In particular, `isSet` was checking if _any_ bit was set instead of if
_all_ bits were set. This was a point of confusion.
Bug: angleproject:42266936
Change-Id: I76211a423f304fb4641ceb9cbfbb0bea4ff33ccf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5937411
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
8d86ae9f
|
2024-10-16T14:38:57
|
|
Skip flaky end2end test
ClearTest.ChangeFramebufferAttachmentFromRGBAtoRGB
on Win Intel GL
Bug: angleproject:373818282
Change-Id: I92ea2ca5aa5423a13d9912a7da964c315b862ec9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5938873
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
|
|
|
e40d8581
|
2024-10-16T10:57:39
|
|
Vulkan: Fix render pass revival vs framebuffer fetch and DR
Bug: angleproject:352364582
Change-Id: I86548251fc1dec75031a23e3461bf296c852919c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5937412
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
7beb008d
|
2024-10-16T10:04:43
|
|
Vulkan: Disable dynamic rendering on Nvidia
Bug: angleproject:372883691
Change-Id: I71b45ea67a725a5a55d69b17329866000a1f37e3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5938740
Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
37dd8e92
|
2024-09-20T17:49:11
|
|
WebGPU: Stream client arrays
Add support for vertex attributes and index data without buffer
backings. Stream the data to buffers at draw time.
Bug: angleproject:368602384
Change-Id: I697b7882cdebf0dfab08fcffabd2d36048920547
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5878137
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
68ba532b
|
2024-10-09T14:38:01
|
|
Add validation for ObjectLabel
The validation of ObjectLabel is empty.
Move the validation in ValidateObjectLabelKHR to a new
ValidateObjectLabelBase (except the extension check), and make
ValidateObjectLabel and ValidateObjectLabelKHR both call
ValidateObjectLabelBase after the version/extension check.
An end2end test is added
Bug: angleproject:360903471
Change-Id: Iabfd3c16c5423b2ab2fe5e417fe75eed00237c92
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5919129
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
9e8b104e
|
2024-10-14T00:00:00
|
|
Do not test OpenGL backend on iOS
Added Metal platform to tests
that require instantiation.
Bug: angleproject:40050022
Bug: angleproject:42264029
Bug: angleproject:42266119
Bug: angleproject:42266226
Bug: angleproject:42266239
Bug: angleproject:42266249
Bug: angleproject:359136169
Fixed: angleproject:373478551
Change-Id: I915f09c7f24acce27bf0d489932645338ac3fbe8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5932659
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
|
f0b367f2
|
2024-10-16T10:01:53
|
|
Roll vulkan-deps from 4c2208c976c8 to ad31dd1cb898 (1 revision)
https://chromium.googlesource.com/vulkan-deps.git/+log/4c2208c976c8..ad31dd1cb898
Also rolling transitive DEPS:
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/d24a552c1b4aec661c608d6b57f4f34826e5ff4f..e76c08dbd4851912e001d4618d34301d95149816
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC abdolrashidi@google.com,angle-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: abdolrashidi@google.com
Change-Id: I7994312f21f1c6b045fe81621f8947015d776910
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5937490
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
597641fd
|
2024-10-16T10:01:59
|
|
Roll SwiftShader from 7a9a492a38b7 to 74b783dffb9b (1 revision)
https://swiftshader.googlesource.com/SwiftShader.git/+log/7a9a492a38b7..74b783dffb9b
2024-10-15 swiftshader.regress@gmail.com Regres: Update test lists @
7a9a492a
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC abdolrashidi@google.com,angle-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in SwiftShader:
https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: abdolrashidi@google.com
Use-Permissive-Angle-Pixel-Comparison: True
Change-Id: I4817713f943ce4c6663fd756259b87434e98a30a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5937356
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
eb557ef4
|
2024-10-16T07:02:08
|
|
Roll Chromium from b20c9c684689 to fb88b76548ad (590 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/b20c9c684689..fb88b76548ad
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC abdolrashidi@google.com,angle-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/dfadf777a1..cf625e474b
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/5c57673513..cdead231af
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/983be4aa98..cb82a60836
* third_party/android_build_tools/lint/cipd: 8os9DzCgPex0dFtZslAlzowMLYeKXFCQHSJMJYTodZsC..kB_cywmS9q9mkY7RC6lpOXEqIsOjRPwwQdaCENEO0ucC
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/20b9bdcace..c4d75a1519
* third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/6a68fd412b..321045da9a
* third_party/r8/cipd: -i5fwP_NzM6Ylg5AsSGEotYN7hQgV852gXCslvXIrRwC..K7fIEIzzANXaspaV4maRvvy6jqYIHGEgoC4gfJvSD_0C
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/ec74a08f01..0870580298
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/9273dec1de..bfbba056b1
* tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/c17b74fa2f..599e3714e4
Clang version changed llvmorg-20-init-6794-g3dbd929e:llvmorg-20-init-8527-g923566a6
Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/ec74a08f0143040a3ab174f7a3231ec5d2a19d49..087058029801c0d9784b410eb3fb458a4716169d/scripts/update.py
Bug: None
Tbr: abdolrashidi@google.com
Change-Id: I6a5e27bd4bae9eb6f137fed7ab750f5df16c2a07
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5933572
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
0dbe85f3
|
2024-10-15T13:54:36
|
|
Increase the size of vector WriteImages to max
ANGLE limits the size of vector which represents the write images when
resolving images. So when blit a multisample buffer to mrt, the sum of
write images is more than 1 and app will abort while checking the size
of the vector.
This patch increases the size of vector WriteImages to max.
Add end2end test to test blit multisampled framebuffer to MRT
framebuffer.
Bug: angleproject:361369302
Change-Id: I2d892bcd3411f2bca2ff514f6f0b6055d872668a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5872512
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
4a2f9b1c
|
2024-10-15T20:53:37
|
|
Manual roll vulkan-deps from b234b73ac73a to 4c2208c976c8 (6 revisions)
Manual roll requested by abdolrashidi@google.com
https://chromium.googlesource.com/vulkan-deps.git/+log/b234b73ac73a..4c2208c976c8
Also rolling transitive DEPS:
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/1a337fe32d4d5be2ec2af7e02647005aeb358faa..326e17b35f028cec8c597926d4da3178760d6a93
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/eb9b6043be165f06c7ec78fadbb1ff773c5fc19c..56eca742a15f8a692306b66b23484682ee6e1806
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/b63e9bd51fbd7bf8fea161a4f7c06994abc24b75..d24a552c1b4aec661c608d6b57f4f34826e5ff4f
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC abdolrashidi@google.com,angle-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: abdolrashidi@google.com
Change-Id: I4d0b466ef54db12ce1f47100c1e98c86054e00e3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5932588
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
059f66be
|
2024-10-15T10:04:23
|
|
Bugfix in UnitTest_DMSAA_dst_read
Skip UnitTest_DMSAA_dst_read test if GL_EXT_sRGB_write_control
extension is not supported
Bug: angleproject:40644776
Change-Id: I4e8ec6d184b033308b7cd33551555d480bdc8107
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5933569
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: mohan maiya <m.maiya@samsung.com>
|
|
|
91391c06
|
2024-10-02T16:07:02
|
|
Vulkan: Vertex attribute hole crash workaround
* Added condition to bypass reading from a streaming attribute
if the source pointer is null.
* Added unit test that crash if a vertex pointer is not defined
for an enabled vertex attribute.
* VertexAttribPointerCopyBufferFromInvalidAddress
* Credit for the original test: tingwei.guo
Bug: angleproject:359729255
Change-Id: I2592fed66f0eba8c7003ec02cc8ca802833f23b3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5899978
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
a1584f49
|
2024-10-11T21:17:32
|
|
Vulkan: Qualify framebuffer fetch with "Color"
In preparation for depth/stencil framebuffer fetch, many framebuffer
fetch symbols are affixed with Color to indicate that they pertain to
color framebuffer fetch logic.
Bug: angleproject:352364582
Change-Id: I86000ada5e6ef47387dec0b6a3fca589d816cdc2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5926593
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
|
|
|
f1296738
|
2024-10-15T14:27:43
|
|
Skip end2end tests failing on iOS
BlitFramebufferANGLETest.BlitWithMissingAttachments/ES2_OpenGL
Texture2DTestES3.UnitTest_DMSAA_dst_read/ES3_Metal
Texture2DTestES3.UnitTest_DMSAA_dst_read/ES3_OpenGL
Bug: angleproject:40644776, angleproject:371987004
Change-Id: I414bfa065faa0bbd20cb7d46d00e30d9d92f7f53
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5933825
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
|
|
|
1608d0be
|
2024-10-10T16:53:15
|
|
Vulkan: Isolate framebuffer fetch no-RP-break optim from DR
Prior to [1], changes to framebuffer fetch usage by shaders caused a
render pass break. This was due to a limitation of render pass
compatibility rules. It also caused other headache, such as needing to
clear the render pass cache, recreating pipelines etc.
[1]:https://chromium-review.googlesource.com/c/angle/angle/+/3697308
In [1] an important optimization was implemented for tiling GPUs where
ANGLE permanently switched to framebuffer fetch mode on first
encountering framebuffer fetch use. From that point on, ANGLE would
always make every render pass framebuffer fetch compatible.
In reality, the render pass break was unnecessary, which became apparent
with dynamic rendering (for example that whether the render pass
includes input attachments has no bearing on a pipeline that doesn't use
input attachments at all). In [2], dynamic rendering kept the render
pass break + permanent switch behavior for simplicity.
[2]:https://chromium-review.googlesource.com/c/angle/angle/+/5637155
This change untangles the optimization done for legacy render passes
from dynamic rendering, allowing dynamic rendering to start every render
pass without framebuffer fetch and enable it later if a framebuffer
fetch program is used.
This is in preparation for supporting depth/stencil framebuffer fetch,
where a perma-switch is troublesome (for example in combination with
read-only depth/stencil feedback loops).
Bug: angleproject:352364582
Change-Id: I31221cf22a28d58b9b2bf188e9c0b786cd0fe3d2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5923120
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
|
76025caa
|
2024-10-15T07:01:56
|
|
Roll Chromium from 91bda6332316 to b20c9c684689 (501 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/91bda6332316..b20c9c684689
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC abdolrashidi@google.com,angle-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/61966507f3..dfadf777a1
* buildtools/linux64: git_revision:95b0f8fe31a992a33c040bbe3867901335c12762..git_revision:feafd1012a32c05ec6095f69ddc3850afb621f3a
* buildtools/mac: git_revision:95b0f8fe31a992a33c040bbe3867901335c12762..git_revision:feafd1012a32c05ec6095f69ddc3850afb621f3a
* buildtools/win: git_revision:95b0f8fe31a992a33c040bbe3867901335c12762..git_revision:feafd1012a32c05ec6095f69ddc3850afb621f3a
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/dc547b9bc0..983be4aa98
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/dc257ad54f..36c94904a0
* third_party/android_build_tools/manifest_merger/cipd: qI7pOwGO6rjfncAZKTugRAPn9Qs_MdwCWpzfRuiBgGMC..rnIeJMlGw7adxOKZofLsm7tdYaOy1nHivJn9ck7ocVkC
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1e559a2828..20b9bdcace
* third_party/fuchsia-sdk/sdk: version:24.20241004.3.1..version:24.20241014.3.1
* third_party/r8/cipd: t4F8xIzt04fK7U39bVM4rUFnXdBdepJihfEDM1It6NUC..-i5fwP_NzM6Ylg5AsSGEotYN7hQgV852gXCslvXIrRwC
* third_party/siso/cipd: git_revision:6b2665e870db2df4da1c184a2aec2f98dcb75000..git_revision:f10ec3c74e86f2de9b9e5ad4e2d8d3b0192ea4d2
* tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/2abe3b86e0..be6dc62553
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/c8b0e5b333..ec74a08f01
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/d72d442d19..9273dec1de
* tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/a963cd9c38..c17b74fa2f
Clang version changed llvmorg-20-init-3847-g69c43468:llvmorg-20-init-6794-g3dbd929e
Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/c8b0e5b3332ed68fee3ddb20d7e717424a2a4753..ec74a08f0143040a3ab174f7a3231ec5d2a19d49/scripts/update.py
Bug: None
Tbr: abdolrashidi@google.com
Change-Id: Ieec0e8af02fe40d15246d9788a464e2f67f09939
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5933567
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
576b5ef4
|
2024-10-14T23:11:16
|
|
Manual roll vulkan-deps from 73fd75175922 to b234b73ac73a (18 revisions)
Manual roll requested by abdolrashidi@google.com
https://chromium.googlesource.com/vulkan-deps.git/+log/73fd75175922..b234b73ac73a
Also rolling transitive DEPS:
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/2acc4ea0028bc703be2d4e9bc8a4032d015d6516..2bfc7cadbd52a90833416633a77ce1941086ea79
https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/5d4562d56eb3cc8ac23f70fd48e549d0751b2fde..b02737a0783ae7e40c728f9b346aa919c241f270
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/42b315c15b1ff941b46bb3949c105e5386be8717..5b98dea6f1ce1a6b84d733d6093cdb208f4a0752
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/14345dab231912ee9601136e96ca67a6e1f632e7..d91597a82f881d473887b560a03a7edf2720b72c
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/bd1c8ea9c6ac51e4c3a6ddb9d602bb204678eb5f..1a337fe32d4d5be2ec2af7e02647005aeb358faa
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/c9a5acda16dc2759457dc856b5d7df00ac5bf4a2..eb9b6043be165f06c7ec78fadbb1ff773c5fc19c
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/8c907ea21fe0147f791d79051b18e21bc8c4ede0..bfd85956e1b4c1c79842ce857fc7fb15adb8a573
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/cbb4ab171fc7cd0b636a76ee542e238a8734f4be..b63e9bd51fbd7bf8fea161a4f7c06994abc24b75
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC abdolrashidi@google.com,angle-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: abdolrashidi@google.com
Change-Id: Ideb60784b3787d82b23c64324cafcd263a18a8dd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5932583
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
e7341113
|
2024-10-14T23:37:31
|
|
Manual roll VK-GL-CTS from 179dd9f858f0 to 5e9887eb393c (20 revisions)
Manual roll requested by abdolrashidi@google.com
* Added common source files for FragCoordConventionsTests.
* Suppressed a failing must-pass test for Pixel 4.
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/179dd9f858f0..5e9887eb393c
2024-10-11 piotr.byszewski@mobica.com Test texture LoD query in
combination with base level
2024-10-11 mateusz.bahyrycz@mobica.com Add missing coverage for sparse
binding multisampled images
2024-10-11 mateusz.bahyrycz@mobica.com Add tests for multiple bind
sparse infos
2024-10-11 ziga@lunarg.com Only use depth clamp control create info if
extension is enabled
2024-10-11 kamil.goras@mobica.com Split
KHR-GL46.framebuffer_blit.framebuffer_blit_functionality_multisampled_to_singlesampled_blit
2024-10-11 marcin.hajder@mobica.com Port KC-CTS tests to VK-GL-CTS
(fragment_coord_conventions_multisample), PART 13
2024-10-11 gleese@broadcom.com Fixes for mandatory feature and
feature_consistency tests
2024-10-11 lordalcol@users.noreply.github.com Create
vulkan-cts-withdrawal-2024-10.txt
2024-10-10 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.10
into vk-gl-cts/main
2024-10-04 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.10
into vk-gl-cts/main
2024-10-03 ziga@lunarg.com Add more tests for
VK_EXT_swapchain_maintenance1
2024-10-03 ziga@lunarg.com Test dynamic sample locations without create
info
2024-10-03 piotr.byszewski@mobica.com Coverage for extremely long debug
labels
2024-10-03 Tyler.Schneider@amd.com Add sanity check in Ray Query Stress
Tests
2024-10-03 cwabbott0@gmail.com Revert "Fix crash in local read max input
attachments test"
2024-10-03 scerveau@igalia.com Update vk_video_samples external sources
2024-10-03 rgarcia@igalia.com Add shader module identifier tests with
mesh shaders
2024-10-03 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-cts-4.6.5
into vk-gl-cts/main
2024-10-02 gleese@broadcom.com Remove mandatory_features.txt
2024-09-30 lorenzo@khronosgroup.org Set Amber back to google:main
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC abdolrashidi@google.com,angle-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: angleproject:373475678
Tbr: abdolrashidi@google.com
Change-Id: I2c31b1a15cdafc4c2e528d65a1a67a2672b932d3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5932584
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
367e9e74
|
2024-10-14T09:37:42
|
|
Android: Update targetSDK to 35
Platform hard requirement for 24Q4 is 35 for all pre-load apps.
Results diff to Android.bp:
$ diff Android.bp.before Android.bp
8035c8035
< target_sdk_version: "34",
---
> target_sdk_version: "35",
8062c8062
< target_sdk_version: "34",
---
> target_sdk_version: "35",
8101c8101
< target_sdk_version: "34",
---
> target_sdk_version: "35",
Bug: b/369722011
Change-Id: Ia39beb98cd81416746913a636f707d008ceaf2a1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5929666
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
4c35748f
|
2024-10-14T16:30:55
|
|
Skip MultisampleTestES3.CopyTexImage2DFromMsaaDefaultFbo on S22
Bug: angleproject:372059358
Change-Id: Ide36309be0310f1449bf4aedce42c60c0fda55c8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5928718
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
8f367854
|
2024-10-13T13:45:17
|
|
Vulkan: Refactor ImageCopy shader
- Refactor common shader code into "ImageCopy.inc"
- Add ImageCopyFloat shader that supports only float src and dst formats
- Perform YUV and multisampled image copies with ImageCopyFloat
Bug: angleproject:372059358
Change-Id: I34bbaf49f98920494d9ed9e1fd290b413a89ea13
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5927276
Commit-Queue: mohan maiya <m.maiya@samsung.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
a9a924e1
|
2024-10-14T07:01:18
|
|
Roll Chromium from f801b43c96ea to 91bda6332316 (730 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/f801b43c96ea..91bda6332316
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com,cnorthrop@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/99d8d6ffd9..61966507f3
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/9807e11fd0..5c57673513
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/aedfbb82cf..dc547b9bc0
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/db7cdfad03..dc257ad54f
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a31b55235f..1e559a2828
* third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/6e4ed1972b..6a68fd412b
* third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/406418bc7b..9a1d90c3b4
* third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/87f19104b5..efc3baa2d1
* third_party/r8/cipd: 6pzT4UkzHpjnobJW8Yujr0Z4dGqQgOvpH9AJh96Bmn8C..t4F8xIzt04fK7U39bVM4rUFnXdBdepJihfEDM1It6NUC
* tools/luci-go: git_revision:ff7417442432e6669b74c02c63d61834f865aa77..git_revision:7dd39503276dfa4a920102ca77a2f409f2f67655
* tools/luci-go: git_revision:ff7417442432e6669b74c02c63d61834f865aa77..git_revision:7dd39503276dfa4a920102ca77a2f409f2f67655
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/e39f5123d0..d72d442d19
* tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/5acd9395d2..a963cd9c38
No update to Clang.
Bug: None
Tbr: cnorthrop@google.com
Change-Id: I0741d847b09843d58f77249a61be0a3d7379669c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5926428
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
78a694a1
|
2024-10-10T14:08:31
|
|
Bugfix for ms_to_ss in dynamic rendering
VkMultisampledRenderToSingleSampledInfoEXT should be added into
VkRenderingInfo.pNext when using dynamic rendering pass.
Bug: angleproject:370153437
Change-Id: If9377362d95c60e610ec978eb684918de9807342
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5922915
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
e7f0d107
|
2024-10-03T00:00:00
|
|
Translator: Fix EXT_texture_query_lod shader types
These functions are available
only in fragment shaders.
Bug: angleproject:368275901
Change-Id: Ief15e93d9c7042a8d5bc0f5f951df98149b44c70
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5922477
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
a8d9d813
|
2024-10-08T15:31:37
|
|
Trace perf: save individual screenshots in offscreen
With --offscreen, _frameN.png is now the Nth frame, by reading
the offscreen buffers pixels. This is more consistent with onscreen.
Previously we would only get _frame24.png, _frame48.png etc with the
grid of frames from framebuffer 0. Now we get these as _grid1.png,
_grid2.png etc, and _frameN.png are individual frames.
gles1 is an exception as we don't have grids and only render a single
frame to framebuffer 0.
Bug: b/370508393
Change-Id: Ia8cb13120f21ef92fa3e6662b5e2cffa918983d6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5916767
Commit-Queue: Roman Lavrov <romanl@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
0f2ce2cd
|
2024-10-11T12:58:53
|
|
Tests: Add Supreme Duelist trace
Test: angle_trace_tests --gtest_filter="*supreme_duelist*"
Bug: b/372883450
Change-Id: I87931895ea67b437c36bb99e8ab4fa8e1dae3a3e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5926174
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Mark Łobodziński <mark@lunarg.com>
Reviewed-by: Mark Łobodziński <mark@lunarg.com>
|
|
|
ab1cdd22
|
2024-10-03T00:00:00
|
|
Translator: Support EXT_texture_query_lod
No backend support yet.
Bug: angleproject:368275901
Change-Id: I10bbc03feca485908315633cbc0f955e82994657
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5920240
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|