kc3-lang/angle

Log

Author Commit Date CI Message
angle-autoroll 4ce2e213 2021-01-28T07:00:42 Roll Chromium from 9ac53d238b0c to 34154bd58dcb (208 revisions) https://chromium.googlesource.com/chromium/src.git/+log/9ac53d238b0c..34154bd58dcb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/60c7f94b29..80d8522df9 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/d573d8d1be..4f733a4525 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..9d5ec46922 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/eb5ab41f38..0d2b89124b * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/6806d508f7..c3a074da20 * tools/skia_goldctl/linux: 5uRd0nSbglRL_SlkzkofedmMPgK-1F0ICeAPyhneOY4C..opL5N0hiBtWxiOFaEhRqXpJWh70uurNTInvkY8NHr8oC * tools/skia_goldctl/mac: jH1EXicKWfNsK_lsEmfi4_MozROrG68ybn4yGmcDj_oC..pmlVeVFuSc7Re0D7Efu2pAh2Oo5rEAnlg1rFIfp1RncC * tools/skia_goldctl/win: n1MqOqpTysNu10SmTHGk7eHIIUMoy2SErGFxHZBoZNIC..GRI6-L-7YmnYGw8gs2jXZDqvI5KIFIgsj_GvzZ4krYQC No update to Clang. Bug: None Tbr: jmadill@google.com Change-Id: Iecafd7f85dd36b0a1c7fe6c67fdd26876af9780b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2654433 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll a12edfa5 2021-01-27T21:27:07 Roll Chromium from 4bbaf376844e to 9ac53d238b0c (270 revisions) https://chromium.googlesource.com/chromium/src.git/+log/4bbaf376844e..9ac53d238b0c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jmadill@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/fcaf1b1b36..60c7f94b29 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/71044dffd0..e3db55b463 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/001e33eea6..d573d8d1be * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/f0c0aae6f2..f43a84ba66 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..9d5ec46922 No update to Clang. Bug: angleproject:5417 Tbr: jmadill@google.com,ynovikov@google.com Change-Id: I5f4b945ca375385c2974c06f6b727080a731b421 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2654082 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Tim Van Patten 5006a573 2021-01-26T17:15:10 Capture/Replay: Capture glUniformBlockBinding() eFootball PES 2021 uses glBindBufferRange(), which requires glUniformBlockBinding() to create the pairing of uniform block indexes to buffer bindings. The uniform buffer indexes that are assigned when each program is linked can differ between drivers, so the glUniformBlockBinding() calls need to be recorded to get the correct index values for the glBindBufferRange() calls. Bug: angleproject:5564 Change-Id: I909e05d5b1cc50e592b887bd130aa80cdb1bb40f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2650993 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tim Van Patten 351e6e8c 2021-01-26T17:08:59 Add 'UniformBlockIndex' struct Add the new structure 'UniformBlockIndex'. This is in preparation for capturing glUniformBlockBinding() calls, which requires the (new) corresponding ParamType::TUniformBlockIndex. Bug: angleproject:5564 Change-Id: I88613dd96d058659dd253e8088fab49670c32316 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2651287 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Geoff Lang bc7554f9 2021-01-27T14:41:18 Remove extension files that are not written by ANGLE. We inconsistantly added some extension txt files to our extensions folder that are not maintained but possibly implemented by ANGLE. Some of these extensions trip up Android's automatic license detection. Bug: None Change-Id: I9bde4235c7ad2bf4d9bcf5385f4138296cef2c13 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2653848 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
angle-autoroll 8f6c328d 2021-01-27T18:40:56 Roll vulkan-deps from 3849583848aa to 01ef7ce6f449 (1 revision) https://chromium.googlesource.com/vulkan-deps.git/+log/3849583848aa..01ef7ce6f449 2021-01-27 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from c47ac8e1cc37 to 31e95c1707c5 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jmadill@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jmadill@google.com,syoussefi@google.com Change-Id: I18291ddfe3171db0bbdb7d27d9a2290468d85926 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2653847 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Geoff Lang ea0f3496 2021-01-25T12:47:27 GL: Update VertexArrayGL to not store per-context state. Move StateManagerGL and FunctionsGL members out of VertexArrayGL and query them directly from the context in methods. Bug: angleproject:5577, chromium:1167179 Change-Id: I376f3eff15fbd9855c5956737064f56d54acbceb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2647868 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Jamie Madill f6925344 2021-01-25T13:13:33 Trace Tests: Update expectations. Bug: angleproject:5530 Change-Id: I48a6dc5753406e6dd6cd1845f1f28fcbfc485e34 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2647871 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Yuly Novikov 52afb6f1 2021-01-26T22:22:07 Fix angle_unittests build on iOS Link failed because libfeature_support symbols were private Bug: angleproject:5417 Change-Id: I04c4056e1a887a9ad7bde692c7c2780b5d1dd387 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2649122 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Doug Horn e7ca0aa2 2021-01-24T17:46:26 Fix crash in multi-context D3D11 backend. The crash occured due to a lack of marking a context dirty on eglMakeCurrent(), resulting in a situation where a thread B would call eglMakeCurrent() but before issuing additional GL calls, thread A would issue a draw command. Prior to this change, context state would only be marked dirty on gl calls. Test: dEQP-EGL.functional.sharing.gles2.multithread.* dEQP-EGL.functional.multithread.* dEQP-EGL.functional.render.multi_thread.* dEQP-EGL.functional.color_clears.multi_thread.* Bug: b/177602915 Change-Id: I765e0423002a373f94ea459b81b6e6f6942870d2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2646609 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Doug Horn <doughorn@google.com>
angle-autoroll fdf441ce 2021-01-27T10:01:27 Roll SwiftShader from ea1f7d10db1f to aec0826aba0d (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/ea1f7d10db1f..aec0826aba0d 2021-01-26 amaiorano@google.com VulkanBenchmarks: split out benchmark classes into separate files If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: Icd0d171ea312f0b2cd3e905b7ba75f8d5fb0e977 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2652288 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 317f4991 2021-01-27T10:01:06 Roll vulkan-deps from 0ba7f6930e7e to 3849583848aa (2 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/0ba7f6930e7e..3849583848aa 2021-01-26 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 79b22370b0b0 to c47ac8e1cc37 (1 revision) 2021-01-26 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 6abdde3ce511 to 36df92e4a0ef (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I8c18aebefb94a7b7290325f6c9c64ce20f41edfa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2652366 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 63b4df59 2021-01-27T07:35:55 Roll Chromium from 70020e670c0f to 4bbaf376844e (453 revisions) https://chromium.googlesource.com/chromium/src.git/+log/70020e670c0f..4bbaf376844e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/c4a8df816d..fcaf1b1b36 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/74d2546231..71044dffd0 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/13cdc88532..001e33eea6 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/63a2bc635d..f0c0aae6f2 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..1cd5ea42ac * third_party/libjpeg_turbo: https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/518d81558c..fa0de07678 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/94a96af5d6..eb5ab41f38 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/2b1beb5865..6806d508f7 No update to Clang. Bug: None Tbr: jmadill@google.com Change-Id: I21aff744f673c74a16fdb90d619fab2ac38271db Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2651650 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi de53e308 2021-01-26T12:44:04 Metal: Fix XFB failures on ARM. Metal back-end needs to generate 2 versions of XFB shader: - one version without XFB emulation code for rasterized draw. - one version with XFB emulation code for draws with rasterization disabled. Based on a change by le.hoang.q@gmail.com Bug: chromium:1167763 Change-Id: I2858859e15b18701fadff09092bb08778c4a7e64 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2648636 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Le Hoang Quyen <le.hoang.q@gmail.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 4921e457 2021-01-22T22:36:13 Vulkan: Avoid unnecessary pipeline rebinds Bug: angleproject:5528 Change-Id: I5502498fa5d6767f55635fe9fff949d7fd644f4f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2645640 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi c38413f8 2021-01-26T15:04:38 Make glmark2 benchmark output parsing more resilient On Linux, the following info messages are being output which are seemingly harmless: INFO: EGL CRITICAL: eglQueryString: display is not initialized. INFO: EGL ERROR: eglGetPlatformDisplayEXT: Bad platform type. These lines are now parsed and forwarded to output. Bug: angleproject:3139 Change-Id: Ia9feb2aef4c1809283588d6e5fc1b6a51ae8812b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2648641 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jonah Ryan-Davis f9afaaee 2021-01-25T13:46:22 GL: Remove in-thread link status check from parallel link path. A call to checkLinkStatus was wrongly placed in the nativeParallelCompile path, which ended up blocking on shader linking, rendering parallel compilation useless. Bug: chromium:1169477 Bug: chromium:1099763 Change-Id: Id2c5fe31e651abac76207c93919fd83d79f30556 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2647987 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
angle-autoroll 50f7d646 2021-01-26T10:01:06 Roll vulkan-deps from dbc46e43978b to 0ba7f6930e7e (8 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/dbc46e43978b..0ba7f6930e7e 2021-01-25 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 5a01949aa859 to 79b22370b0b0 (2 revisions) 2021-01-25 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 7e0458f5ee73 to 5a01949aa859 (2 revisions) 2021-01-25 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from c55e290fe581 to 7e0458f5ee73 (2 revisions) 2021-01-25 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from f3a9b5b33c61 to c55e290fe581 (2 revisions) 2021-01-25 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 1186f95a2f7b to f3a9b5b33c61 (1 revision) 2021-01-25 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 819117cd48e7 to a61600c7639c (1 revision) 2021-01-25 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 89ad2272baae to 819117cd48e7 (1 revision) 2021-01-25 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 968659aee8af to 89ad2272baae (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I4cd05e4b38e5651d33c70d072d9e86d229f1497b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2649670 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 81a751d8 2021-01-26T10:01:27 Roll SwiftShader from 413f7cb17c77 to ea1f7d10db1f (6 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/413f7cb17c77..ea1f7d10db1f 2021-01-26 sugoi@google.com Handle sampleRateShading parameters 2021-01-26 sugoi@google.com Move required interpolation logic to SpirvShader 2021-01-26 sugoi@google.com Add mode for sample qualifier 2021-01-26 natsu@google.com Update Android.bp for VK_EXT_headless_surface 2021-01-25 amaiorano@google.com VulkanBenchmarks: refactor TriangleBenchmark into a more reusable base class 2021-01-25 amaiorano@google.com VulkanBenchmarks: add solid and interpolated triangles tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: Ibd406cc362597fb2bd5576c31d0f0c69486b1907 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2649770 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 274dc1bf 2021-01-26T07:01:23 Roll Chromium from 8378a463e1a2 to 70020e670c0f (434 revisions) https://chromium.googlesource.com/chromium/src.git/+log/8378a463e1a2..70020e670c0f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/710b42c08b..c4a8df816d * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/13547b97da..74d2546231 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/b66650c011..13cdc88532 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..2b1e9cf86a * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/756cf7138c..2b1beb5865 * tools/skia_goldctl/linux: T8wzDdpKse34sb84KYsgP5FcmR1QAnFdrtUSkZOBtvcC..5uRd0nSbglRL_SlkzkofedmMPgK-1F0ICeAPyhneOY4C * tools/skia_goldctl/mac: YkIZZLTolR7P8J70QaLh9tuiSkEDPWV3MCs3BRYhX2YC..jH1EXicKWfNsK_lsEmfi4_MozROrG68ybn4yGmcDj_oC * tools/skia_goldctl/win: bN3GOEHxnirdwM8liN0rP7M9VljsA-PP_h50Tbw1XrQC..n1MqOqpTysNu10SmTHGk7eHIIUMoy2SErGFxHZBoZNIC No update to Clang. Bug: angleproject:5417 Tbr: jmadill@google.com Change-Id: I1aa6dd51eb7ae4132b35a8f365a1d51a2e344447 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2649461 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill 9bbcd86a 2021-01-25T10:52:35 Capture/Replay: Fix instanced array client data. Enables a bunch of self-tests. Bug: angleproject:5530 Change-Id: Idd14574ba0f3d44124e153ccb32fec7318baf217 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2647745 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 6689a54d 2021-01-21T00:36:14 Vulkan: autogen for SPIR-V instruction build and parse Handwritten SPIR-V instruction parse and build code is replaced with autogenerated functions based on the SPIR-V grammar. Bug: angleproject:4889 Change-Id: I09d724fd944e79c03fe4eadca3ee3e3ef0b49872 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2644721 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Amy Liu cc5083e0 2021-01-15T10:29:36 Compression of the data from vkGetPipelineCacheData. The size of pipelineCacheData sometimes is greater than 64k which cannot be saved because of the Android blob cache limitation (single cache data size should be < 64k). Implement the compression to store more cache data. Bug: angleproject:4722 Change-Id: I435b086d70d0e6378f1141464ae2bafbe076f193 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2631511 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Jamie Madill cfb9c30c 2021-01-25T10:54:09 Capture/Replay: Apply skips correctly on SwS. The skips listed currently were explicitly for ES2_Vulkan instead of applying to both desktop and SwS Vulkan implementations. This CL swaps the expectations to use wildcards so they will work for both. Bug: angleproject:5530 Change-Id: Iae83207411296cb819bb0a25d2247cb4af863adb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2645723 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 3623868e 2021-01-22T12:24:50 Trace Tests: Add xvfb command line option. This will enable running the tests on Linux. Bug: angleproject:5530 Change-Id: I7cd2155fac89d395a8bebacb2f1a44be0e7d3739 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2644723 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll d026fd35 2021-01-25T10:01:24 Roll vulkan-deps from a0047c0f6ec8 to dbc46e43978b (5 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/a0047c0f6ec8..dbc46e43978b 2021-01-25 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Headers from 684390cedbff to 9166a0677e44 (1 revision) 2021-01-22 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from fd06d42afd9a to 1186f95a2f7b (2 revisions) 2021-01-22 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from ab73ad637606 to fd06d42afd9a (1 revision) 2021-01-22 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Cross from 9acb9ec31f5a to 84a41cd4883d (1 revision) 2021-01-22 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from f37547c73a98 to 968659aee8af (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I6b69186a6d46beac39d06508fef3fcf70b020fba Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2646556 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 7ea083c4 2021-01-25T10:01:20 Roll SwiftShader from 9441aea16221 to 413f7cb17c77 (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/9441aea16221..413f7cb17c77 2021-01-22 sugoi@google.com Flip samples to their correct position 2021-01-22 capn@google.com Target macOS 10.14 on ARM64 to enable C++17 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I3e092e5b22b355942c4dc9f6950b4ee022667a9a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2646615 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll cd0b933d 2021-01-25T07:02:02 Roll Chromium from 318dff1807ef to 8378a463e1a2 (643 revisions) https://chromium.googlesource.com/chromium/src.git/+log/318dff1807ef..8378a463e1a2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/888f037dd4..710b42c08b * testing: https://chromium.googlesource.com/chromium/src/testing/+log/eeb08d20a6..b66650c011 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..957dfeae29 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/786cae1ea0..94a96af5d6 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/07f759b55a..756cf7138c * tools/skia_goldctl/linux: ISnBOFRy8pK6MqHvQt1Dssi358v4KHM5zJuWVrsmL6cC..T8wzDdpKse34sb84KYsgP5FcmR1QAnFdrtUSkZOBtvcC * tools/skia_goldctl/mac: -AmQt0We5dhSelcdGZjJtq6gbhQWATSagCOyH-JL0yIC..YkIZZLTolR7P8J70QaLh9tuiSkEDPWV3MCs3BRYhX2YC * tools/skia_goldctl/win: Dlf6e8GKMBiJAaFXTVte4LowGeiFs79erbrVany5R1gC..bN3GOEHxnirdwM8liN0rP7M9VljsA-PP_h50Tbw1XrQC No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: I52b1160913d24512b2d5ebcbcb8c3f47b4708d0d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2646357 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop 3c3b82ab 2021-01-21T20:21:34 Tests: Add Hearthstone trace Test: angle_perftests --gtest_filter="*hearthstone*" Bug: angleproject:5571 Change-Id: Idc6535bbf817cd62d34aa9e684604be068455520 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2644143 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Shahbaz Youssefi c51c3548 2021-01-19T14:15:54 Vulkan: Unconditionally expose OES_shader_io_blocks All relevant tests pass, so no longer conditioned to exposeNonConformantExtensionsAndVersions. Bug: angleproject:3580 Change-Id: I9b398bd962831fabf0ec39ad9aad3b200717d087 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2636687 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang 61bd3440 2021-01-21T16:57:38 Roll Khronos headers. Many of our GLES and EGL headers had old SGI licenses which tripped up Android's license detection. Bug: None Change-Id: Iede9a72b3619fdd77ba21895fc5a76a81f0a5790 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2643489 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Yuly Novikov 3846cff3 2021-01-21T16:37:12 Suppress headers includes privacy checks on iOS shared libraries are hidden inside ios_framework_bundle, so technically we are not allowed to include headers from them. Ignore this check since everything works fine besides "gn gen --check". All ANGLE headers are considered public, so we don't need this check. Bug: angleproject:5417 Change-Id: I6b621132dfe85e0fb1bea4ae2b93097945a8801a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2643859 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill e60ce3da 2021-01-21T16:42:17 Capture/Replay: Allow testing with multiple versions. This embeds the context version and device type info into the replay. The self-tests then can create the correct display and context types. This fixes testing against SwiftShader which is necessary for the bots. Bug: angleproject:4759 Change-Id: If9da6bfdc1c2b315ccd7e453872fc84063277054 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2643363 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill b745f6df 2021-01-21T14:41:00 Capture/Replay tests: Fixes for goma & depot tools. Adds the depot tools path to be specified via the command line. This will allow the bots to specify working directory locations. Also adds quotes around the goma path in the gn args. Bug: angleproject:5530 Change-Id: I1291a8cdf4e36e55786403b4d9a6ce8565093352 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2642894 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 5c71a4b1 2021-01-22T10:01:20 Roll SwiftShader from 22be66d40712 to 9441aea16221 (10 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/22be66d40712..9441aea16221 2021-01-22 bclayton@google.com Merge changes I6c21b03d,Ic6136d02,I988c0288,I21d11818,I79fa8162, ... 2021-01-21 capn@google.com Implement non-void indirect Reactor Call() support 2021-01-21 amaiorano@google.com Make RoutineT::getEntry() type safe 2021-01-21 swiftshader.regress@gmail.com Regres: Update test lists @ b3e5c440 2021-01-21 capn@google.com Target macOS 10.12 when building LLVM 2021-01-21 capn@google.com Use aligned allocation for classes with aligned members 2021-01-21 nicolascapens@google.com Enable and require C++17 compilation 2021-01-20 srisser@google.com Implement VK_KHR_depth_stencil_resolve 2021-01-20 amaiorano@google.com Move reusable Vulkan code from VulkanBenchmarks to new VulkanWrapper library 2021-01-20 amaiorano@google.com VulkanBenchmarks: factor out code into separate files If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: If067e1497564ff72fab0711621d95911f80bd902 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2644698 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 3f4e004f 2021-01-22T10:01:24 Roll vulkan-deps from f646afdb8929 to a0047c0f6ec8 (1 revision) https://chromium.googlesource.com/vulkan-deps.git/+log/f646afdb8929..a0047c0f6ec8 2021-01-21 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 9b4e82efb482 to 6abdde3ce511 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Iac0fb2ddd8cb81e7cec57df74062e83eca32c172 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2643123 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll c827ccbb 2021-01-22T07:01:08 Roll Chromium from 67fb6a8435bb to 318dff1807ef (435 revisions) https://chromium.googlesource.com/chromium/src.git/+log/67fb6a8435bb..318dff1807ef If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/2f05905c0d..888f037dd4 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/0c30db82f7..13547b97da * testing: https://chromium.googlesource.com/chromium/src/testing/+log/cd618b63bb..eeb08d20a6 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/947ea991af..63a2bc635d * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..957dfeae29 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/3c716375fd..786cae1ea0 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/7161349d95..07f759b55a No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: I6bc26ccad8ffc7a406c03c6726112212a492ed3d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2643865 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Steven An ff5f715e 2021-01-19T16:46:04 Properly fail upon program binary version mismatch Return angle::Result::Stop instead of Incomplete when Program::deserialize detects version mismatch. This causes the caller, Program::loadBinary, to stop trying to load it. At least with the Vulkan backend, trying to load it results in a crash. Added test case to ProgramBinariesAcrossPlatforms which exhibits the old crash. Bug: angleproject:5567 Change-Id: I2ebb27cee0aa895855504f758992b4dfec3f4aa3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2639078 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Steven An <stevenan@google.com>
Tim Van Patten 9ccd3536 2021-01-20T18:19:41 Capture/Replay: Capture all indexed buffer bindings during MEC "eFootball PES 2021" binds uniform buffers via glBindBufferRange() before any frames haves been rendered and then uses those bound buffers for all subsequent frames. A recent fix captured the UBOs that were also bound as GL_UNIFORM_BUFFER, but failed to capture all indexed buffers bound only with glBindBufferRange(). This CL captures all indexed uniform, atomic counter, and shader storage buffers during MEC setup. Bug: angleproject:5564 Change-Id: I0e638ec4407a091f943b9640e8fc6a7c9f4c4e08 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2640424 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Tim Van Patten <timvp@google.com>
Cody Northrop 70f493d6 2021-01-20T14:22:14 Tests: Add Subway Surfers trace Note this differs from the previous trace for the app, "subway_surfer_500". The previous trace is no longer compatible with the replay harness and could not be re-recorded due to using Vulkan at the time. Test: angle_perftests --gtest_filter="*subway_surfers*" Bug: angleproject:5569 Change-Id: If941a3f0e88e3e1aee7fb7db736e623f66a65de6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2641098 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Tim Van Patten 535d4783 2021-01-20T14:14:02 Vulkan: Flush if sync object is pending during SyncVk::getStatus() When a glGetSynciv() is performed for GL_SYNC_STATUS, we should flush any pending commands if a sync object is pending a flush, since the caller is interested in the status of a fence. This will guarantee that the work is submitted to the hardware and eventually completes. This is accomplished by moving mSyncObjectPendingFlush from ContextVk to ShareGroupVk, so that any sync objects used by any contexts within the share group are submitted to hardware and the required work completes. Bug: angleproject:5306 Bug: angleproject:5425 Test: FenceSyncTest.BasicOperations Change-Id: I2e2681ad01fda429ba37f061c9bac5eb91f800fd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2641095 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
Tim Van Patten 26e02593 2021-01-15T12:38:46 Capture/Replay: Erase texture from mCachedTextureLevelData When the caller issues a glCompressedTexImage call, we need to delete the cached texture data, since the texture size/data are being respecified and the old data is now stale. This fixes MEC for "Klondike Adventures". Bug: angleproject:5549 Change-Id: Ie788e2bf39f7a29ec6bc55f95d6f570f1d22d659 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2633071 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Peng Huang f5d56799 2021-01-20T10:00:54 Do not make context current during context deletion. ANGLE will make a context current during deletion, so ANGLE can release related resources, but for an external context, the API user should make sure the native context is current during deleting the ANGLE external context, so ANGLE doesn't need to make the context current. Bug: angleproject:5509 Change-Id: Ia4cee4e3965e9e9e811e3f989f6f6d72bd940f41 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2640593 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi 203154b5 2021-01-18T10:43:07 Vulkan: Remove swiftshader workaround for missing gl_Position The following line was added by the translator to work around a swiftshader bug where no gl_PerVertex declaration (and hence no gl_Position) would fail an assertion: gl_Position = gl_Position; The swiftshader bug is fixed, so this line can be removed. Bug: b/176161380 Change-Id: I68a8e0d9cd8b97e9d294a119c2daa4ab64ec863f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2633729 Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll f28a06ba 2021-01-21T10:01:24 Roll vulkan-deps from 3180f85f9bcd to f646afdb8929 (2 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/3180f85f9bcd..f646afdb8929 2021-01-20 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 1bd539b9bfc4 to f37547c73a98 (1 revision) 2021-01-20 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 56f8ed48efd5 to 1bd539b9bfc4 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I592dbdeccf1b7aeaa8bc36b0cafaf9363678b19e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2641011 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 0e37da9b 2021-01-21T08:14:23 Roll Chromium from 132575638f37 to 67fb6a8435bb (480 revisions) https://chromium.googlesource.com/chromium/src.git/+log/132575638f37..67fb6a8435bb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/3fd2266640..2f05905c0d * testing: https://chromium.googlesource.com/chromium/src/testing/+log/4dfabb3243..cd618b63bb * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..beb8370c49 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/2e4e6e975a..3c716375fd No update to Clang. Bug: angleproject:3580 Tbr: cnorthrop@google.com Change-Id: I5aeb58e86be883cbb5e03bbc910981deaede93c5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2641008 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 9f4b159b 2021-01-19T12:48:15 Translator: Avoid vector copies with multi-replacement Turns push_backs into emplace_backs and changes the TIntermSequence constructor argument to &&. Bug: angleproject:5535 Change-Id: I640ce879b6ade48a28dea6385ebb7a95cb8304ff Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2636680 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Tim Van Patten bb766000 2021-01-20T16:58:16 Vulkan: Move Flush during SyncHelper::clientWait() earlier The checks and call to contextVk->flushImpl() needs to be moved before the timeout check to ensure that the vkEvent is flushed to HW eventually when the caller is waiting on it, even if they don't specify a timeout. Bug: chromium:1060139 Test: CopyOutputScalingPixelTest.ScaledCopyOfDrawnFrame/48 Change-Id: I725ea492aaf21e291fe3e5b9ae11ea009e59e019 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2640423 Commit-Queue: Alexis Hétu <sugoi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Alexis Hétu <sugoi@chromium.org>
Shahbaz Youssefi f0286e63 2021-01-19T12:38:46 Translator: Stop allocating TIntermSequence The functions that take a TIntermSequence always copy out / Swap the contents away. This change makes all TIntermSequences live on the stack instead of being newed. Bug: angleproject:5535 Change-Id: I942f1c5e57b00199d5308183f71bd9e18b0608bd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2636679 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Sunny Sachanandani 137271ff 2021-01-13T14:34:12 Support specifying array slice for D3D11 texture EGLImage Client can specify array slice for creating the SRV/RTV with EGL_D3D11_TEXTURE_ARRAY_SLICE_ANGLE. Test: D3DTextureTest.TextureArrayImage* Bug: angleproject:5538, chromium:1116101 Change-Id: I81cb2823df2145f1d05ad1526b0e36d6a0724d5e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2628609 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Shahbaz Youssefi bb3adfa4 2020-12-01T15:43:13 Rename ShaderVariable::structName to structOrBlockName Bug: angleproject:3580 Change-Id: Ic53a5267972f153dad2e20948e493e9767a45d16 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2568247 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Geoff Lang df33d561 2021-01-19T11:42:35 EGL: Respect eglMakeCurrent with a null context. Our context virtualization code would try to optimize this case and leave the current context bound when possible. This has the side effect of leaving the current surface bound too, even if it was deleted. During Chrome's window resizing, it deletes the window, calls eglMakeCurrent with null and then recreates the window. This causes an error because the window still exists because it was left current in ANGLE. Bug: chromium:1167718 Change-Id: I857be88be48dfa9c0dd9173f235e155e727e3014 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2637717 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Peng Huang 2ebff7f2 2021-01-20T08:39:40 Support switch surfaces for external context. WebView may change surfaces due to resizing. So we need to support switching surfaces with the external context. Bug: angleproject:5509 Change-Id: Id91eed092a63b3740fd796e0a3cb819ae18baaa9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2639077 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org>
Jamie Madill 0ae61c25 2021-01-20T10:40:24 Capture/Replay tests: Use failure exit code. This will allow the test step to fail when run in CI. Bug: angleproject:5530 Change-Id: I7c156438ded82aa7191b8b597a9a52200c0efe57 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2638989 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi ea71c6b6 2021-01-12T14:13:35 Vulkan: Emulate R32F images with R32UI GL requires that imageAtomicExchange be supported for r32f formats. However VK_FORMAT_FEATURE_STORAGE_*_ATOMIC_BIT is nearly unsupported everywhere without some Vulkan extension that brings in unnecessary support. This GL feature is emulated by transforming the shader to use r32ui for all images that originally specified r32f. floatToUintBits and uintBitsToFloat is used to maintain correct usage of the image* builtin functions. Bug: angleproject:5535 Change-Id: Ie607089935d3283b3ffa054f4b4385b81fb8f53d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2635453 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Jamie Madill a4d05638 2021-01-18T14:58:22 Capture/Replay: Don't serialize compile resources string. The resources string gets changed dynamically during capture. This breaks the regression tests because they were comparing for identity. Bug: angleproject:5530 Change-Id: I0734f735577a5ff4c9083adb8f25a37aad3c0e37 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2634830 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com>
Michał Pichliński 80b45c33 2021-01-20T12:20:35 Make metal_shader_cache_file_hooking a data_deps After https://chromium-review.googlesource.com/c/angle/angle/+/2580918 angle_unittests will not run on OSX when it is non component build and metal_shader_cache_file_hooking is a shared library: dyld: Library not loaded: ./libmetal_shader_cache_file_hooking.dylib Bug: angleproject:5565 Change-Id: I1ac43d928cfaff692aa233c2ba3504a73573ee3e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2640173 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 2b242f53 2021-01-17T14:24:53 Vulkan: Simplify RewriteCubeMapSamplersAs2DArray This change is mostly done to remove an unnecessary helper in ReplaceVariable.cpp. Tested locally, as the bots all support ES3.1+. There are a few failures, with or without this change. Bug: angleproject:5556 Change-Id: I7bd2d4294c9dc164146d713db6b45cbc73e59c16 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2633437 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
angle-autoroll bd8ca051 2021-01-20T10:01:56 Roll vulkan-deps from dd50a3bce3ca to 3180f85f9bcd (11 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/dd50a3bce3ca..3180f85f9bcd 2021-01-19 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from e25db023c47a to 56f8ed48efd5 (1 revision) 2021-01-19 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from c7ffe6890160 to ab73ad637606 (2 revisions) 2021-01-19 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from efecc309816c to c7ffe6890160 (2 revisions) 2021-01-19 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from fb6e414f76dc to efecc309816c (1 revision) 2021-01-19 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 03e41cc0c2a8 to fb6e414f76dc (2 revisions) 2021-01-19 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 6886c4b57f10 to 03e41cc0c2a8 (3 revisions) 2021-01-19 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 10651a9c0bc2 to 6886c4b57f10 (1 revision) 2021-01-19 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 5b7d68ca6b3f to 9b4e82efb482 (1 revision) 2021-01-19 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 3de5cfe50ede to 5b7d68ca6b3f (1 revision) 2021-01-19 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Headers from 9efc4a631161 to 684390cedbff (1 revision) 2021-01-19 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 8383bd5d6f26 to e25db023c47a (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Ic79a5b12d8132a7f322c507150d3a7aa62ca0d66 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2639815 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 15a3d28b 2021-01-20T10:01:51 Roll SwiftShader from 8da0f82baf35 to 22be66d40712 (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/8da0f82baf35..22be66d40712 2021-01-20 capn@google.com Fix always performing early depth test when requested 2021-01-19 digit@google.com vulkan: Support VK_KHR_external_memory_fd on OS X. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Iddb4b62f284463aef7d7cdcc289b711668e0c545 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2639923 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 2900a0f4 2021-01-20T07:00:58 Roll Chromium from f3626a1bfa8f to 132575638f37 (396 revisions) https://chromium.googlesource.com/chromium/src.git/+log/f3626a1bfa8f..132575638f37 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/9766d96a51..3fd2266640 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/c38b5ab1c6..0c30db82f7 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/d6e501127c..4dfabb3243 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..05342ef131 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/819010a7e6..2e4e6e975a * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/860610b866..7161349d95 * tools/skia_goldctl/linux: fZ-8UCX4nVBdizWPWt4iEXoKw9052O2u8regRqax1zUC..ISnBOFRy8pK6MqHvQt1Dssi358v4KHM5zJuWVrsmL6cC * tools/skia_goldctl/mac: tb5CVkUBpdIU8L9wnnDjjfFYcI6Xbq9-m8iZlEi5G-EC..-AmQt0We5dhSelcdGZjJtq6gbhQWATSagCOyH-JL0yIC * tools/skia_goldctl/win: CY_g7u7URjjZnq4pgCohkA5JcSnWH4YE10bSECPnYewC..Dlf6e8GKMBiJAaFXTVte4LowGeiFs79erbrVany5R1gC No update to Clang. Bug: angleproject:2930,angleproject:3481 Tbr: cnorthrop@google.com Change-Id: If5369b42a9d3c3e994e502dd34b50044388d5e16 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2639545 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 186fe990 2021-01-15T15:49:30 Vulkan: Redo RewriteAtomicCounters With MonomorphizeUnsupportedFunctionsInVulkanGLSL and RewriteArrayOfArrayOfOpaqueUniforms transformations run, it is no longer possible to encounter array of array of atomic counters, or have any passed to functions. As a result, RewriteAtomicCounters is greatly simplified. Additionally, it is no longer necessary to pass binding/offset information for atomic counters around and they can use constants. This change removes dependency on the shaderStorageBufferArrayDynamicIndexing Vulkan feature. Bug: angleproject:3726 Bug: angleproject:3881 Change-Id: Ia43092a668f60d009eccbbceeed5deaf105a5895 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2633687 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 64c89120 2021-01-19T21:51:23 Suppress incomplete texture tests on mac/arm Bug: chromium:1168370 Change-Id: I5f3e1b76b4efd21f3655d6995293ff4bbbebea17 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2639273 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 382f016d 2021-01-19T15:35:19 Vulkan: Retain OpSource in SPIR-V Needed by AGI. It's a small instruction, and there's only one of it. This change makes the SPIR-V transformer retain this instruction even on release. Bug: b/177556123 Change-Id: I0a2ba8afe55018b08f25abd8a139b64b2a5f6f11 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2636691 Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Austin Eng 0739f07a 2021-01-19T23:54:20 Revert "Add support for building in Flutter Windows UWP configuration" This reverts commit 68ac4e43aa67c4bac9df639d80079648ea86dbe9. Reason for revert: Crashes Chrome GPU process startup on Windows x86 See crbug.com/1168272 Original change's description: > Add support for building in Flutter Windows UWP configuration > > Bug: angleproject:5527 > Change-Id: Idf5a4cbb6f84b24fa2448157cab1b6a3bce4d8be > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2620580 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Jamie Madill <jmadill@chromium.org> TBR=geofflang@chromium.org,stuart.morgan@gmail.com,jmadill@chromium.org,james@clarkezone.io # Not skipping CQ checks because original CL landed > 1 day ago. Tbr: jmadill@chromium.org Bug: angleproject:5527, chromium:1168272 Change-Id: Ifb37c8026253c6a7c334d5b6c83018c888a9f51c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2638572 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
Tim Van Patten 08e385b4 2021-01-15T17:31:19 Tests: Add Klondike Adventures trace Test: angle_perftests --gtest_filter=TracePerfTest.Run/*klondike_adventures* Bug: angleproject:5548 Change-Id: I1bab7696f3db6cb3b3be9d1f3e241891586a9cc8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2634204 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Trevor David Black 192a0147 2020-10-08T16:47:35 Multithreading in D3D11 minimum viable product Bug: b/168046573 Change-Id: I676a148333cbf5e9ca508768503e62cb14d8eeb0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2629618 Commit-Queue: Doug Horn <doughorn@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Trevor David Black <vantablack@google.com>
Shahbaz Youssefi 383442e5 2021-01-19T11:42:03 Add a helper ShaderVariable method to facilitate member rename Chromium uses ShaderVariable::structName directly, which makes it impossible to rename this variable. Bug: angleproject:3580 Change-Id: I328015b0e7f26d22d689451bac0d7a48999bef2e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2637419 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill 2e0490ee 2021-01-18T14:21:46 Capture/Replay: Serialize float states properly. Previously we were always casting to int. Instead add a float serialization helper function. Bug: angleproject:5530 Change-Id: Ifc80e1dbad9da8a04b3b013c3a3ffa60444f6d26 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2634829 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 7489bb2e 2021-01-19T14:35:59 Suppress failing tests on mac ARM Bug: chromium:1167763 Change-Id: I7f88bd60119dd630ea7733228baff97598bfd739 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2636688 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill b912eec5 2020-11-27T11:08:41 Vulkan: Support GL_EXT_tessellation_shader. Shader translator changes done in http://crrev.com/c/2633936 Adds a new DIRTY_BIT_PATCH_VERTICES state to Context. Supportes state query and transform feedback. 4 test suppressions remain as follow-up fixes. Adds a new varying packing mode for a simple Vulkan rule set. Based on work by Mohan Maiya (m.maiya@samsung.com). Test: dEQP-GLES31.functional.tessellation.* Bug: angleproject:3572 Change-Id: I4cad2cca30adb754fd12c83027673906541f566a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2568234 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Mohan Maiya <m.maiya@samsung.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Mohan Maiya acf2985d 2021-01-19T10:33:14 Vulkan: Add integer type incomplete texture tests Add tests for both signed and unsigned integer texture types. Bug: angleproject:5502 Bug: angleproject:4432 Tests: IncompleteTextureTestES3.*IntegerType* Change-Id: I22e451424d19c3e525cd08ad4c16e1150d9d2467 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2613244 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Cody Northrop dd6ac664 2021-01-18T16:30:18 Tests: Add Asphalt 8 trace Test: angle_perftests --gtest_filter="*asphalt_8*" Bug: b/150484427 Change-Id: I6a5f1feec61466eae55c1a2464272aba797ed56c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2636602 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi f45e625f 2021-01-18T21:56:46 Fix image bindings with an image after an image array of array The logic to calculate the image binding offset for each element of an array of array of images was incorrect, in that it used the arraySize accumulated so far to offset the next image's binding. Bug: angleproject:5535 Change-Id: I2dc3ce7bbf7b77302d1b56b4701bec2e990fdae1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2635452 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill feb470cc 2021-01-19T10:10:18 Test Runner: Prevent race by not resetting timeout. This instead only sets the timeout when tests start to run. That way the timeout should always be at least the default timeout and we won't get into a situation where the watchdog times out the test immediately when the test starts. Bug: angleproject:5562 Change-Id: I6b12bb8fe8edcf35f46ba4fb106fdf80ff9402a1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2637182 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cody Northrop 2e3786ed 2020-12-18T13:19:16 Capture/Replay: Use glUniform1iv on samplers, ignore images In OpenGL, GL_INT is expected for sampler uniforms. Before this our emitted code was using the underlying return type, which can be unsigned, leading to glUniformuiv. Also, don't try to set image uniforms with glUniform calls, it is not allowed. Test: Fortnite MEC Bug: b/170755560 Change-Id: I6786df487285fee77cfe792dfa85eb17feb155e9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2611557 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Jamie Madill e670fc72 2021-01-18T15:51:42 Implement shader compiler changes for Tessellation. Numerous rule changes to support validating Tessellation Control and Evaluation shaders. New per-patch inputs and output variable support. Includes a new traverser step that validates barrier function calls. Functionality changes upcoming in http://crrev.com/c/2568234 Bug: angleproject:3572 Change-Id: If8da1c21d30efa12c60ed0d6c3f8cf0b27e4c86f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2633936 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Mohan Maiya <m.maiya@samsung.com>
Cody Northrop 20f8828c 2021-01-15T16:04:29 Capture/Replay: Fixes for compressed texture cache Some compressed block sizes don't align properly to surface dimensions. For instance, ASTC_6x6_UNORM populating a 64x64 surface. Our FrameCapture code was assuming block alignment and was losing data. To handle this, round the dimensions up to natural block alignment before doing any scaling math. This also fixes the problem we've had of losing small mip levels due to scaling. Test: Aztec Ruins MEC Bug: b/160808198 Bug: angleproject:5552 Change-Id: I194cdac87f7361f85539e78f85069b336ffb1f36 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2634205 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
angle-autoroll 31f64e44 2021-01-19T10:01:55 Roll vulkan-deps from 2bb77d70cc64 to dd50a3bce3ca (3 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/2bb77d70cc64..dd50a3bce3ca 2021-01-19 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from ca3216a3a24f to 10651a9c0bc2 (1 revision) 2021-01-18 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from fb2ab876edcd to ca3216a3a24f (2 revisions) 2021-01-18 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from ee39b5db5f1d to 8383bd5d6f26 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I7042c2ca33ea9895084a4c4b2a3ad5f640f6c116 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2636675 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll c7423655 2021-01-19T10:01:52 Roll SwiftShader from 149733cead63 to 8da0f82baf35 (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/149733cead63..8da0f82baf35 2021-01-18 amaiorano@google.com VulkanBenchmarks: improve and clarify resource ownership 2021-01-18 swiftshader.regress@gmail.com Regres: Update test lists @ 149733ce If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I0f6d1f9285310bbb597efdf75a97d1fb0b21d5de Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2636754 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b69f5406 2021-01-19T07:00:52 Roll Chromium from 55486659cf9b to f3626a1bfa8f (232 revisions) https://chromium.googlesource.com/chromium/src.git/+log/55486659cf9b..f3626a1bfa8f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/43dd249695..9766d96a51 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/ca81cc1c21..d6e501127c * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..5eda7597b6 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/ba4ee03425..819010a7e6 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/42beda611f..860610b866 * tools/skia_goldctl/linux: 6Jyrz0wn3TSlHy8rWlrugbIUaDslD0FgTnUUQRePl5oC..fZ-8UCX4nVBdizWPWt4iEXoKw9052O2u8regRqax1zUC * tools/skia_goldctl/mac: YFTZ-MeyIxai3DnjeDbaQtkjXVsXKMXIiFvM2GV62_EC..tb5CVkUBpdIU8L9wnnDjjfFYcI6Xbq9-m8iZlEi5G-EC * tools/skia_goldctl/win: 6YmqskIJgPxw9ZFHFHZIlV6xTpym5GZKued9YODyoSwC..CY_g7u7URjjZnq4pgCohkA5JcSnWH4YE10bSECPnYewC No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: I9347038e8cacc723b84de71bd95594ef458b325f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2637353 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill 81430e11 2021-01-18T11:56:16 Vulkan: Remove command processor special functions. These functions are no longer needed. Bug: b/170328907 Bug: b/170329600 Bug: b/172704839 Change-Id: Icf18717905fa79dc0ccf7063d8482d4ca07d8b80 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2635073 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Peng Huang 043fcf18 2021-01-07T13:23:57 Support create ANGLE EGLContext from an external EGLContext For Android WebView, Android creates an EGLContext, EGLSurface and FBO, and makeCurrent on them, and then calls WebView draw function to draw the WebView content on the current EGLSurface or binded FBO. So to use ANGLE in WebView, this CL adds a way to create ANGLE EGLContext from an external EGLContext, and save and restore GL state in eglMakeCurrent(). Bug: angleproject:5509 Change-Id: I874986813117f125e23e975ea1adc51ac5b3a631 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2615239 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Peng Huang 5635dbb9 2021-01-15T09:43:25 Only call context::unMakeCurrent() if context is changed. Bug: angleproject:5509 Change-Id: Ifbc6aa23a218498c5e2f6a094296045b2d5dfacf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2633421 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Geoff Lang b5424bb4 2021-01-14T15:09:41 Generate internal gl entry point functions as C functions. Some internal GL functions are exported to our libGLESv1_CM library and to properly export them, they must be C functions. Bug: angleproject:5534 Change-Id: I37280312f73fd5e55166e4fa36659267d657a50b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2628139 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Geoff Lang 409c1d5e 2021-01-15T10:32:56 GL: Add detection of IMG and Vivante GPUs. Future workarounds will depend on being able to detect these GPUs. Bug: chromium:983167 Change-Id: I0aee848594e6340550507a0cee8638c9b68785f1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2633422 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Carl Woffenden 679d1187 2021-01-12T18:25:39 Fix to build with VS2019 When building with VS2019 (using is_clang=false) multiples of the following error are given: ../../src/common/mathutil.cpp(75): error C4244: '=': conversion from 'double' to 'float', possible loss of data (This is due to pow(), when passed an int for the second param, widens the first param to a double then returns a double). Since the code was being changed the opportunity was taken to: - add missing unit tests for the two 999E5 conversions - optimise out the common pow() functions The unit tests were written against the original implementation, then the optimisations added and verified against the original results. Bug: angleproject:5521, dawn:602 Change-Id: Ic9e5eaedbe3fc7ceeed697898823b76dffcd989a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2624888 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
James Clarke 68ac4e43 2021-01-10T14:29:44 Add support for building in Flutter Windows UWP configuration Bug: angleproject:5527 Change-Id: Idf5a4cbb6f84b24fa2448157cab1b6a3bce4d8be Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2620580 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 297e1ae1 2021-01-18T10:01:52 Roll SwiftShader from aedd133cd85f to 149733cead63 (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/aedd133cd85f..149733cead63 2021-01-15 sugoi@google.com Fix crash in vertex shader when position is not declared 2021-01-15 amaiorano@google.com LLVMReactorDebugInfo: fix location filename always "<unknown>" on Windows If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: Ia6b5f9d4c8b08f513af90e4aea7d3ca6650894c3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2634923 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 35c0ba88 2021-01-18T10:01:55 Roll vulkan-deps from 7b69f3d087b8 to 2bb77d70cc64 (4 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/7b69f3d087b8..2bb77d70cc64 2021-01-18 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from 9ba835885ffe to aed40d52837d (1 revision) 2021-01-15 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from 93a6c58d76e1 to 7c25ce965b92 (1 revision) 2021-01-15 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from c86cec54abe6 to 93a6c58d76e1 (1 revision) 2021-01-15 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 9150cd441f43 to ee39b5db5f1d (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: I81507391f9a18b98b7b0f7fc3f0ef2763590e2ef Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2635226 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 68f15c73 2021-01-18T07:00:50 Roll Chromium from 2ef9c5ff8ca7 to 55486659cf9b (469 revisions) https://chromium.googlesource.com/chromium/src.git/+log/2ef9c5ff8ca7..55486659cf9b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/670a9057fa..43dd249695 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/235cfe435c..c38b5ab1c6 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/ce2030d539..ca81cc1c21 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..cf567b6b96 * tools/skia_goldctl/linux: kjkgNP4EaChPUcoDLbUiF85Tgg3RbK3xzpcwZ5HyUosC..6Jyrz0wn3TSlHy8rWlrugbIUaDslD0FgTnUUQRePl5oC * tools/skia_goldctl/mac: Asi8KSWBq6NEwkADY8wYitzLWv01uuZURhT1kYqop6IC..YFTZ-MeyIxai3DnjeDbaQtkjXVsXKMXIiFvM2GV62_EC * tools/skia_goldctl/win: _5BJmSzcXDTJJSe1g7mA2Qb5L1P6cEseriZG8lUfDuAC..6YmqskIJgPxw9ZFHFHZIlV6xTpym5GZKued9YODyoSwC No update to Clang. Bug: None Tbr: timvp@google.com Change-Id: Ie133d8a37f4929190020bd9349b20659345ede6e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2633725 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi bd2954a9 2021-01-16T11:33:12 Reland "Cleanup translator option checks" This reverts commit 9173e01730923823846348e513bb8cbe7eddbbe5. Reason for revert: This was in a chain of reverts, but is unrelated to the issue. Original change's description: > Revert "Cleanup translator option checks" > > This reverts commit 9710c4e473c88a38f11eb10c600717181d6e24df. > > Reason for revert: > Earlier CL breaks pre-rotation: > https://chromium-review.googlesource.com/c/angle/angle/+/2598584 > > Original change's description: > > Cleanup translator option checks > > > > Use comparison with 0 for explicit conversion to bool. > > > > Bug: angleproject:3606 > > Change-Id: Ie0a76d7df829227c1376894535813b54e13491b4 > > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2631689 > > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> > > Reviewed-by: Charlie Lao <cclao@google.com> > > Reviewed-by: Jamie Madill <jmadill@chromium.org> > > TBR=syoussefi@chromium.org,jmadill@chromium.org,cclao@google.com > > Change-Id: Ib597a62f3c7078d28f7f5b79d1cc9f8d9e469c31 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: angleproject:3606 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2634047 > Reviewed-by: Tim Van Patten <timvp@google.com> > Commit-Queue: Tim Van Patten <timvp@google.com> TBR=timvp@google.com,syoussefi@chromium.org,jmadill@chromium.org,cclao@google.com Bug: angleproject:3606 Change-Id: I10ecca63a3db6dbc3ddedf5bb7e5319a82a80a30 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2633712 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 6c5b766b 2021-01-16T11:33:00 Reland "Vulkan: Generate xfb support code in SPIR-V for extension path" This reverts commit d090627616641f7524655627bfd415de6f8af942. Reason for revert: Fixed parent CL Original change's description: > Revert "Vulkan: Generate xfb support code in SPIR-V for extension path" > > This reverts commit d06feeac1e79d6102e01c123a360bc9099d5bba3. > > Reason for revert: > Earlier CL breaks pre-rotation: > https://chromium-review.googlesource.com/c/angle/angle/+/2598584 > > Original change's description: > > Vulkan: Generate xfb support code in SPIR-V for extension path > > > > The only piece of code that's needed to be generated for the extension > > path is the following, at the right spot (right before depth correction > > and pre-rotation): > > > > ANGLEXfbPosition = gl_Position; > > > > The SPIR-V transformer already has gl_Position loaded for depth > > correction and pre-rotation, so this change simply adds an OpStore to > > ANGLEXfbPosition. > > > > As a result of this change, @@ XFB-OUT @@ is no longer emitted if > > the transform feedback extension is supported. With the above code now > > placed correctly for geometry shaders, transform feedback tests for > > geometry shaders are enabled. > > > > Bug: angleproject:3606 > > Change-Id: I13a7956ab62a1a6b4196ff999442b99b50226c0f > > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2617659 > > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> > > Reviewed-by: Charlie Lao <cclao@google.com> > > Reviewed-by: Jamie Madill <jmadill@chromium.org> > > TBR=syoussefi@chromium.org,jmadill@chromium.org,cclao@google.com > > Change-Id: I74fa9fafe3c922cdb7cd09ee6351534e38528da9 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: angleproject:3606 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2634048 > Reviewed-by: Tim Van Patten <timvp@google.com> > Commit-Queue: Tim Van Patten <timvp@google.com> TBR=timvp@google.com,syoussefi@chromium.org,jmadill@chromium.org,cclao@google.com # Not skipping CQ checks because this is a reland. Bug: angleproject:3606 Change-Id: Ic49a0be10cdb58e2b47896554f272093e24f93b4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2633711 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 68635b43 2021-01-16T10:56:39 Reland "Vulkan: Move xfb position decl to translator in extension path" This reverts commit b4b5972627e148ed91aac3cbc02806bb6407ef0a. Reason for revert: This was in a chain of reverts, but is unrelated to the issue. Original change's description: > Revert "Vulkan: Move xfb position decl to translator in extension path" > > This reverts commit 8f5ca26678c12d54d2981a84e48a5304746ec824. > > Reason for revert: > Earlier CL breaks pre-rotation: > https://chromium-review.googlesource.com/c/angle/angle/+/2598584 > > Original change's description: > > Vulkan: Move xfb position decl to translator in extension path > > > > This change removes the @@ XFB-DECL @@ marker. The ANGLEXfbPosition > > output is unconditionally emitted in VS, TES and GS by the translator, > > and is appropriately decorated or removed by the SPIR-V transformer. > > > > Bug: angleproject:3606 > > Change-Id: Ia76224f5a6d147362eeb2d288f05e333aaf75481 > > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2617658 > > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> > > Reviewed-by: Jamie Madill <jmadill@chromium.org> > > Reviewed-by: Charlie Lao <cclao@google.com> > > TBR=syoussefi@chromium.org,jmadill@chromium.org,cclao@google.com > > Change-Id: Ia03988b9c17639513576e82e8f11cd4c7b52640b > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: angleproject:3606 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2634202 > Reviewed-by: Tim Van Patten <timvp@google.com> > Commit-Queue: Tim Van Patten <timvp@google.com> TBR=timvp@google.com,syoussefi@chromium.org,jmadill@chromium.org,cclao@google.com # Not skipping CQ checks because this is a reland. Bug: angleproject:3606 Change-Id: Ib5b5925528a5c8698390b81f71ee788f5b332a1f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2633708 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi beea4050 2021-01-16T11:32:50 Reland "Vulkan: Generate gl_Position.z correction in SPIR-V" This reverts commit e3c357369f970a94759074418670de2ef131dcb8. Reason for revert: Fixed parent CL Original change's description: > Revert "Vulkan: Generate gl_Position.z correction in SPIR-V" > > This reverts commit 1e4f8b02ae0603e7034c37e0ff6cee39c38771a9. > > Reason for revert: > Earlier CL breaks pre-rotation: > https://chromium-review.googlesource.com/c/angle/angle/+/2598584 > > Original change's description: > > Vulkan: Generate gl_Position.z correction in SPIR-V > > > > Instead of having the translator output code to transform gl_Position.z > > to Vulkan clip space in the vertex stage, this change makes the SPIR-V > > transformer perform this operation on the last geometry stage. > > > > An alternative solution would be to generate this transformation in the > > translator in every geometry stage, each controlled by a separate > > specialization constant. This change avoids unnecessary modifications > > to earlier stages. Additionally, the transformer is already modifying > > gl_Position.xy for pre-rotation, so the addition of a small > > transformation of gl_Position.z in the same spot is rather trivial. > > > > Bug: angleproject:5479 > > Change-Id: Id971179ba47b206204bfdaf3b2b295ef97dd5117 > > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2598585 > > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> > > Reviewed-by: Charlie Lao <cclao@google.com> > > Reviewed-by: Jamie Madill <jmadill@chromium.org> > > TBR=syoussefi@chromium.org,jmadill@chromium.org,cclao@google.com > > Change-Id: I3bdf3d6f743125eaf552608f2664b715bd6935c5 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: angleproject:5479 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2634203 > Reviewed-by: Tim Van Patten <timvp@google.com> > Commit-Queue: Tim Van Patten <timvp@google.com> TBR=timvp@google.com,syoussefi@chromium.org,jmadill@chromium.org,cclao@google.com # Not skipping CQ checks because this is a reland. Bug: angleproject:5479 Change-Id: Id23052b8fc6bffa5bab20cb93eb21ea49a0f80d7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2633710 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi dfd9bdfd 2021-01-16T11:32:30 Reland "Vulkan: Generate gl_Position pre-rotation in SPIR-V" This reverts commit 3d39b7c5eab88c420d982155ffbb6181c678ceea. Reason for revert: Fixed interaction with the `forceDriverUniformOverSpecConst` workaround. Original change's description: > Revert "Vulkan: Generate gl_Position pre-rotation in SPIR-V" > > This reverts commit 0f86b196ffaffeeee3460e3188f20a7ac120796d. > > Reason for revert: > Breaks pre-rotation for all apps, so they are displayed in portrait instead of landscape. > > Original change's description: > > Vulkan: Generate gl_Position pre-rotation in SPIR-V > > > > Instead of having the translator output pre-rotation code in the vertex > > stage based on a specialization constant, this change makes the SPIR-V > > transformer perform pre-rotation of gl_Position on the last geometry > > stage. > > > > An alternative solution would be to generate pre-rotation code in the > > translator in every geometry stage, each controlled by a separate > > specialization constant. This change avoids unnecessary modifications > > to earlier stages. The generated shaders are also smaller, as they > > don't contain a mat2[8] pre-rotation constant matrix. The SPIR-V > > transformer knows the pre-rotation at transformation time, so it can > > simply use swizzles to achieve the same results. > > > > This also ties in with upcoming changes which move gl_Position.z > > correction to the last geometry shader stage, which is trivially done > > piggy-backing on the infrastructure in this change. > > > > Bug: angleproject:5478 > > Change-Id: I9d5d9d19f3ccda665f5504368ce5ddfa5f383faf > > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2598584 > > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> > > Reviewed-by: Charlie Lao <cclao@google.com> > > Reviewed-by: Jamie Madill <jmadill@chromium.org> > > TBR=syoussefi@chromium.org,jmadill@chromium.org,cclao@google.com > > Change-Id: I81f237fa6b10c7d59831363bee8999e7ad2f09be > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: angleproject:5478 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2633694 > Reviewed-by: Tim Van Patten <timvp@google.com> > Commit-Queue: Tim Van Patten <timvp@google.com> TBR=timvp@google.com,syoussefi@chromium.org,jmadill@chromium.org,cclao@google.com Bug: angleproject:5478 Change-Id: I7c5eaeef03d9520abd36a1c4a766b6abbf4fdb45 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2633709 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 60015ff6 2021-01-14T02:03:07 Vulkan: Redo RewriteStructSamplers This transformation is split into two. The first transformation solely takes out the samplers out of structs, and potentially generates array of array of samplers. A second transformation is added that takes any array of array of opaque uniforms and flattens it. A follow up change will simplify RewriteAtomicCounters which also handles array of arrays (which is no longer possible), and removes dependency on shaderStorageBufferArrayDynamicIndexing. Bug: angleproject:2703 Bug: angleproject:3881 Bug: angleproject:4071 Bug: angleproject:4211 Change-Id: I352bb2bbe65ac49f4d7d753c0ba3160fa3cc925a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2628138 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Mohan Maiya 9f09435b 2021-01-14T08:13:47 Vulkan: Rename ReplaceClipDistanceVariable files With the addition of EXT_clip_cull_distance extension the files are renamed like so - ReplaceClipDistanceVariable.h -> ReplaceClipCullDistanceVariable.h ReplaceClipDistanceVariable.cpp -> ReplaceClipCullDistanceVariable.cpp Bug: angleproject:5458 Change-Id: I277b2d4b6eea6f2014e10acb251284a159292dbc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2617572 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Tim Van Patten ff170c6f 2021-01-12T10:16:43 Tests: Add Real Gangster Crime trace Note: Hand edits required to capture this trace: CaptureMidExecutionSetup(): // Check for supported textures ASSERT(index.getType() == gl::TextureType::_2D || index.getType() == gl::TextureType::_3D || index.getType() == gl::TextureType::_2DArray || index.getType() == gl::TextureType::CubeMap || index.getType() == gl::TextureType::External); <<--- add Test: angle_perftests --gtest_filter=TracePerfTest.Run/*real_gangster_crime* Bug: angleproject:5550 Change-Id: I32391cc8de0b4307334bb873af4f3c5899b584f2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2626357 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tim Van Patten 3d39b7c5 2021-01-16T00:15:14 Revert "Vulkan: Generate gl_Position pre-rotation in SPIR-V" This reverts commit 0f86b196ffaffeeee3460e3188f20a7ac120796d. Reason for revert: Breaks pre-rotation for all apps, so they are displayed in portrait instead of landscape. Original change's description: > Vulkan: Generate gl_Position pre-rotation in SPIR-V > > Instead of having the translator output pre-rotation code in the vertex > stage based on a specialization constant, this change makes the SPIR-V > transformer perform pre-rotation of gl_Position on the last geometry > stage. > > An alternative solution would be to generate pre-rotation code in the > translator in every geometry stage, each controlled by a separate > specialization constant. This change avoids unnecessary modifications > to earlier stages. The generated shaders are also smaller, as they > don't contain a mat2[8] pre-rotation constant matrix. The SPIR-V > transformer knows the pre-rotation at transformation time, so it can > simply use swizzles to achieve the same results. > > This also ties in with upcoming changes which move gl_Position.z > correction to the last geometry shader stage, which is trivially done > piggy-backing on the infrastructure in this change. > > Bug: angleproject:5478 > Change-Id: I9d5d9d19f3ccda665f5504368ce5ddfa5f383faf > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2598584 > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Charlie Lao <cclao@google.com> > Reviewed-by: Jamie Madill <jmadill@chromium.org> TBR=syoussefi@chromium.org,jmadill@chromium.org,cclao@google.com Change-Id: I81f237fa6b10c7d59831363bee8999e7ad2f09be No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: angleproject:5478 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2633694 Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Tim Van Patten <timvp@google.com>
kmx.io     mail     discord kmxgit v0.4.0