kc3-lang/angle

Log

Author Commit Date CI Message
Lubosz Sarnecki 56aee5d6 2021-12-10T12:32:58 Reland "system_utils: Add memory protection functionality." This is a reland of b1c703e5f5e44514e8db958a5fb39ff16e514fd8 that was reverted in 663831aa676c59829cc3d822340812f016bf77f6. Skip PageFaultHandlerProtect and PageFaultHandlerDefaultHandler on macOS and Fuchsia. Original change's description: > Reland "system_utils: Add memory protection functionality." > > This is a reland of ab75a90ff4ecb9d99b5c72bde92222b07c285401 > that was reverted in b007e667a8f94b47788a5ba0b2e61c9ac2d1285f. > > Implement PageFaultHandler and memory protection functions. > Uses mprotect and sigaction on POSIX and equivalent Win API functions on > win32. > > Add tests to system_utils_unittests. > > Add stubs for winuwp. > > Replace ASSERT with ASSERT_TRUE in the PageFaultHandlerDefaultHandler > test to make it succeed on release builds, as the code was optimized > out. Furthermore the test did not correctly remove protection from the > whole area it protected, which caused a hang after deinitialization on > some build configurations, since the custom page fault handler was also > still in place. The test now correclty removes protection from the whole > area and sets back the original page fault handler. > > Test: angle_unittests --gtest_filter="SystemUtils.PageFaultHandler*" > Bug: angleproject:5857 > Change-Id: Ibb0acfefd9a09c3360c04c812a2a8346b951e1da > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3322992 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com> Test: angle_unittests --gtest_filter="SystemUtils.PageFaultHandler*" Bug: angleproject:5857 Change-Id: Ifaa966a7c569aa9ff0112897a02fa8f873cd52dd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3329610 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Jamie Madill 66e1fb86 2021-12-09T11:52:24 Trace Tests: Ensure zillow runs on SwiftShader. This trace was being skipped based on incorrect GPU detection. Bug: angleproject:5133 Change-Id: I15e36e099aa2443153184f95b360a8afec278019 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3330575 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Amirali Abdolrashidi 4d0de3d2 2021-12-03T17:09:06 Update the arg types for glMultiDraw*IndirectEXT() * Updated the auto-generated types for arguments "mode" and "type" for glMultiDraw*Indirect and glMultiDrawIndirectEXT functions to PrimitiveMode and DrawElementsType, similar to the other glMultiDraw* functions. Bug: angleproject:6770 Change-Id: If02a66b6fb2f81848ab6e43a6cd406d5956bf331 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3321792 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Alexis Hetu f7d92a32 2021-12-10T10:23:32 Add debug info when loading EGL entry points fails Mac11 bots are often failing with the: "Error loading EGL entry points" error for an unknown reason. This CL adds the library path to the error message to see if it's trying to open the correct file. Bug: chromium:1277690 Change-Id: Ieb73a3097702933a89794d92c19ee44a6301c169 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3330576 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Peng Huang 933f066e 2021-12-10T15:04:53 Enable GL_ANGLE_texture_usage extension This extension doesn't change ANGLE behavior with Vulkan backend, since it is just a hint for ANGLE to optimize texture allocation. Bug: angleproject:6771,chromium:1264439 Change-Id: Ie2411894a02bbcb0a5304c635f1f5648520ad22a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3329694 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org>
Peng Huang cc516f97 2021-12-10T02:48:54 Use STL container for vulkan memory allocator There is a crash related to VMA containers, so switch to STL containers to see if it can workaround the issue. Bug: chromium:1266412 Change-Id: I8416e4b4a27588ac2d710a4ef7600cd91b080535 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3327744 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org>
angle-autoroll 9d5faed8 2021-12-10T10:01:52 Roll vulkan-deps from 38603b300bce to 267fa481ccad (8 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/38603b300bce..267fa481ccad Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/542ee69d83..ca13951205 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/438096e0c2..3156158878 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/ee8a454f88..3dfeacfe0a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I844f4180a6191558fe4ee0022ce46aa82d2e13f1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3328072 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 7a36a69b 2021-12-10T10:01:32 Roll SwiftShader from 4625f84e8d56 to 4c62980da8c1 (6 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/4625f84e8d56..4c62980da8c1 2021-12-10 capn@google.com Implement VK_KHR_vulkan_memory_model 2021-12-09 capn@google.com Update vk::Stringify() structure handling 2021-12-09 sugoi@google.com Fix using XCB with odd width 2021-12-09 capn@google.com Implement VK_EXT_format_feature_flags2 2021-12-09 andre.kempe@arm.com [pac] Add a specific flag for enabling PAC only 2021-12-09 capn@google.com Simplify scaling of 16-bit sampled texel components If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I6137850bc3b8f94cd6a4ec6127a5dba9ff816533 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3328504 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll fb82729d 2021-12-10T08:23:20 Roll Chromium from e1fa86b1827a to 6214b401e0c5 (1064 revisions) https://chromium.googlesource.com/chromium/src.git/+log/e1fa86b1827a..6214b401e0c5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/2ce7bb7605..063796f993 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/89f2e82120..d520ea5884 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/74c6eec693..d81cd6236c * testing: https://chromium.googlesource.com/chromium/src/testing/+log/0385db204c..ea8be42f0a * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/db126cca75..ac517c4de3 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..fa35beefb3 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0a233e1760..58c7c386e6 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/336fcfd099..ed8451adf6 * tools/luci-go: git_revision:31175eb1a2712bb75d06a9bad5d4dd3f2a09cd1f..git_revision:e897e118887a2e6c50a82212b660cb2a7c58d910 * tools/luci-go: git_revision:31175eb1a2712bb75d06a9bad5d4dd3f2a09cd1f..git_revision:e897e118887a2e6c50a82212b660cb2a7c58d910 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/bcefc4c28e..cb04ae000a * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/e136376e7e..68a1dfbe1d * tools/skia_goldctl/linux: wdkOk4Hhfdk2f0Fn4TnicgWCxDVdkOK0W71K0ivXMaEC..2z57AgaznK-BN6rC-A4ZVj85ldJOjFFCMFQ_LYWeUv4C * tools/skia_goldctl/mac: gJSgm5xIzq6ePie9lIvMfyt3vEXbiVb5NreHTEkFS58C..zLP4FDegN-yg3uvzWUdf4zNRVHDwHd0VLm86FkZCP_MC * tools/skia_goldctl/win: BkeCwTnJJi2hffEKlsGWTiP5quyDianpBWnloFZ49ZEC..SSrgf0lBIrCHRZ2acvLwXzzm4KTPzRg17PGIiqsMxBQC No update to Clang. Bug: angleproject:6430 Tbr: jonahr@google.com Change-Id: If65c472eac91c20a9afab55adb815b99117a561b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3328070 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Ash Burn ac9b2703 2021-12-09T15:19:33 fix typo: 'choromium' -> 'Chromium' This is truly an incredibly high priority commit. Bug: angleproject:6734 Change-Id: I921148ecfffbe1ce7fcad0eccb4a53e51d247746 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3328947 Reviewed-by: Shahbaz Youssefi <syoussefi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@google.com>
Hailin Zhang 3be551d7 2021-12-08T16:44:56 fix directUpdate buffer pointer issue. inside mapWithOffset already add the mBufferOffset Signed-off-by: Hailin Zhang<hailinzhang@google.com> Bug: b/207714894 Change-Id: Ia400bccbef1abc756cd8155e93a775338a30e8b9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3325025 Reviewed-by: Lingfeng Yang <lfy@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Hailin Zhang <hailinzhang@google.com>
Jamie Madill 663831aa 2021-12-09T18:08:28 Revert "Reland "system_utils: Add memory protection functionality."" This reverts commit b1c703e5f5e44514e8db958a5fb39ff16e514fd8. Reason for revert: Fails on fuchsia bots: https://ci.chromium.org/ui/p/chromium/builders/try/fuchsia_arm64/1020498/overview mprotect failed: Not supported Original change's description: > Reland "system_utils: Add memory protection functionality." > > This is a reland of ab75a90ff4ecb9d99b5c72bde92222b07c285401 > that was reverted in b007e667a8f94b47788a5ba0b2e61c9ac2d1285f. > > Implement PageFaultHandler and memory protection functions. > Uses mprotect and sigaction on POSIX and equivalent Win API functions on > win32. > > Add tests to system_utils_unittests. > > Add stubs for winuwp. > > Replace ASSERT with ASSERT_TRUE in the PageFaultHandlerDefaultHandler > test to make it succeed on release builds, as the code was optimized > out. Furthermore the test did not correctly remove protection from the > whole area it protected, which caused a hang after deinitialization on > some build configurations, since the custom page fault handler was also > still in place. The test now correclty removes protection from the whole > area and sets back the original page fault handler. > > Test: angle_unittests --gtest_filter="SystemUtils.PageFaultHandler*" > Bug: angleproject:5857 > Change-Id: Ibb0acfefd9a09c3360c04c812a2a8346b951e1da > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3322992 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com> Bug: angleproject:5857 Change-Id: Iaab4067a7ec9240bb6c64b810ac6d3ea7bd86fe1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3327743 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Gregg Tavares 04110e4e 2021-12-01T14:06:03 Metal: Fix Intel backend fails with tall texture Copied test from the WebGL conformance suite. A 1x<MAX_TEXTURE_SIZE> texture fails on Intel in the Metal backend. This was fixed in WebKit so just applying that fix. Bug: angleproject:6754 Change-Id: Id1cafb3b560f14630684d55b0e61cea4c7f33a6d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3311941 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Gregg Tavares <gman@chromium.org>
Charlie Lao 494a0ec2 2021-12-08T16:07:50 Vulkan: Append the actual buffer size when binding's size is 0 When app calls glBindBufferBase, the size of binding is set to 0. The spec says the actual size should be size of buffer when buffer is been referenced. But when we generate ShaderBuffersDescriptorDesc, we are directly using binding's size. But the actual descriptor set has the buffer's actual size. This causing the ShaderBuffersDescriptorDesc have a false cache hit (because size is always 0) when the actual descriptor set should be different. This CL checks bindging.getSize() and if it is 0, we use the actual buffer size. Bug: angleproject:6792 Change-Id: I3e044dc5ff113b4fae1b5c7d5e78645c6e98edf8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3325024 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
angle-autoroll 17f4d97a 2021-12-09T10:01:31 Roll SwiftShader from a4232c15e287 to 4625f84e8d56 (5 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/a4232c15e287..4625f84e8d56 2021-12-09 capn@google.com Remove OpenGL ES targets from the CMake build 2021-12-09 capn@google.com Remove the ANGLE submodule 2021-12-08 capn@google.com Refactor active blend factor determination 2021-12-08 capn@google.com Refactor active blend operation determination 2021-12-08 capn@google.com Fix passthrough blend operations If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I057a203b86aa38717122ab485c1f748163dbee2d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3325192 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 82d1f62e 2021-12-09T10:01:52 Roll vulkan-deps from bc087f672f16 to 38603b300bce (6 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/bc087f672f16..38603b300bce Changed dependencies: * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/29414ae1fd..d53b49635b * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f9bcc82ec7..438096e0c2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: Iec0463956155595a3e8203728378d3551e00df2f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3326227 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov 0e291f60 2021-12-08T19:40:32 Skip couple flaky end2end tests on Pixel 4 UniformTest.UnusedStructInlineUniformWithSampler GLES MatrixTest31.Mat3x4StructVarying Vulkan Bug: angleproject:6793, angleproject:6794 Change-Id: I8edc4f7ddc9bbbfcc2142f5724462184f25145b7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3324324 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 9b23be91 2021-12-08T13:55:22 Frame Capture: Fix client buffers in MEC. In some cases we would neglect to reset the currently bound array buffer to "null" before capturing a client array buffer in MEC. Noticed in the "badland" trace context setup. Bug: angleproject:5133 Change-Id: I693edce763b449720a7f2123dcaf460854142e91 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3323683 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Yuly Novikov 0dad5178 2021-12-08T12:31:35 Sync logdog with Chromium To make it python3 compatible, applying crrev.com/946471: Roll //third_party/logdog 9a84af84d..17ec234f Changes: 17ec234 logdog: make _MAPPING top level variable 88ab863 py3: make logdog lib python3 compatible 794d09a logdog: fix typo in docstring Bug: angleproject:6763 Change-Id: If24f49414b7c4d9fb6cc0630b0bea25a67666a53 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3323238 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Tim Van Patten 16ce5226 2021-12-01T16:58:49 Vulkan: Re-enable RGB8 for pbuffers. pbuffers support was removed from RGB8 EGL configs to prevent mismatched surface formats for surfaces backed by external memory, since ANGLE overrides RGB8->RGBA8 for all surfaces. However, ANGLE no longer supports surfaces backed by external memory with the Vulkan backend, so we can re-enable RGB8 for pbuffers. Bug: angleproject:6651 Change-Id: I7d8b666ed5e3226f067479758f44d9041dcb67b0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3312361 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Tim Van Patten <timvp@google.com>
Shahbaz Youssefi 55840e90 2021-12-03T15:24:00 Vulkan: Fix deferred flush vs UtilsVk Take the following scenario: 1. Draw 2. Flush (this is deferred) 3. Get image view (this is retain()ed) 4. Pass view to a draw-based UtilsVk function 5. Flush 6. Delete image view At step 4, UtilsVk may start a new render pass and use the image view from step 3. Since the flush at step 2 is deferred, it will be performed at this step, and so the serial of the image view is set to the previous submission. When step 4 uses this view, it doesn't retain it. Step 5 submits the new command buffer using this image view. At step 6, if the previous submission has finished, it will destroy the view immediately even though it's in use by the new submission. One solution could have been to make sure render pass closure originating from UtilsVk doesn't incur a flush. However, due to the current design where the render pass is immediately recorded in RendererVk's primary command buffer, it's possible that an unrelated context would perform the flush anyway. This change makes sure instead that the render pass is closed before any views are allocated/retained to be used by UtilsVk. Bug: chromium:1272266 Change-Id: I5bdefb34e03c368511c4c174cf7965fda158d2b8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3315976 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Lubosz Sarnecki b1c703e5 2021-12-08T14:53:46 Reland "system_utils: Add memory protection functionality." This is a reland of ab75a90ff4ecb9d99b5c72bde92222b07c285401 that was reverted in b007e667a8f94b47788a5ba0b2e61c9ac2d1285f. Implement PageFaultHandler and memory protection functions. Uses mprotect and sigaction on POSIX and equivalent Win API functions on win32. Add tests to system_utils_unittests. Add stubs for winuwp. Replace ASSERT with ASSERT_TRUE in the PageFaultHandlerDefaultHandler test to make it succeed on release builds, as the code was optimized out. Furthermore the test did not correctly remove protection from the whole area it protected, which caused a hang after deinitialization on some build configurations, since the custom page fault handler was also still in place. The test now correclty removes protection from the whole area and sets back the original page fault handler. Test: angle_unittests --gtest_filter="SystemUtils.PageFaultHandler*" Bug: angleproject:5857 Change-Id: Ibb0acfefd9a09c3360c04c812a2a8346b951e1da Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3322992 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Tim Van Patten 4f42a4d3 2021-12-01T18:57:48 Add more support for GL_RGBX8_ANGLE Update EquivalentBlitInternalFormat(), ValidReadPixelsFormatEnum(), and ValidReadPixelsFormatType() to support GL_RGBX8_ANGLE. Also update ANGLE_rgbx_internal_format.txt to indicate the new support in glBlitFramebuffer() and glReadPixels() for GL_RGBX8_ANGLE. Bug: angleproject:6690 Test: BlitFramebufferTestES31.BlitMultisampledRGBX8ToRGB8 Test: WebGL2CompatibilityTest.ReadPixelsRgbx8AngleUnsignedByte Change-Id: I75b6d5cb46eebbc904b86cc8e6bd18aca5403684 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3312367 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
Jamie Madill d02d6a40 2021-12-06T09:26:14 Frame Capture: Track written files in ReplayWriter. This means we don't need to recreate the list of written files in the JSON where we list the trace files. It will allow for more flexibility when we change what trace files we output. Bug: angleproject:5133 Change-Id: I651b6a281c50040d32361a5a020ba3eaa4241bf0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3316199 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 4b45831b 2021-12-03T12:29:35 Add a multi-context sample. This will be useful for multi-context trace testing. Bug: angleproject:5133 Change-Id: Ib4b6aac3069bc88939c1f5c409b2e7ef95a1a539 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3313598 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 0f09d378 2021-12-07T13:32:39 Frame Capture: Track return value in max resource IDs. This adds handling for return value processing when it comes to maximum resource IDs. Specifically for glCreateShader and glCreateProgram. Fixes MEC with re-capture with the blockman_go and probably other traces that call CreateShader as the final operations during setup. Bug: angleproject:5133 Change-Id: I799dfec776ca8c80a0b89c7f0c7c23423ef3896a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3320887 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 87a8b79a 2021-12-08T10:01:52 Roll vulkan-deps from 5c0e64524982 to bc087f672f16 (3 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/5c0e64524982..bc087f672f16 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/ec5ea2d6cb..542ee69d83 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/3d3aae8fab..2bbfe2ef64 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/2c2b81c051..ee8a454f88 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I57da88e044a6b15ed5c53e90b2c5ccc5ea90fded Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3322673 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 2edb84e0 2021-12-08T10:01:31 Roll SwiftShader from 3e61a772b248 to a4232c15e287 (3 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/3e61a772b248..a4232c15e287 2021-12-08 capn@google.com Report input attachment usage capability for surface images 2021-12-08 capn@google.com Report storage usage capability for surface images 2021-12-07 cwallez@google.com Bump maxUniformBufferRange 2^14 to 2^16 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: Ida0017cd238f4b83683280bef65aa183696d9823 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3322773 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll c001954a 2021-12-08T07:00:28 Roll Chromium from 111e348dc9b4 to e1fa86b1827a (530 revisions) https://chromium.googlesource.com/chromium/src.git/+log/111e348dc9b4..e1fa86b1827a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/0d9559b7b4..2ce7bb7605 * buildtools/linux64: git_revision:297669af11c70e15d465844fdb4cabbcada4dc7d..git_revision:fc295f3ac7ca4fe7acc6cb5fb052d22909ef3a8f * buildtools/mac: git_revision:297669af11c70e15d465844fdb4cabbcada4dc7d..git_revision:fc295f3ac7ca4fe7acc6cb5fb052d22909ef3a8f * buildtools/win: git_revision:297669af11c70e15d465844fdb4cabbcada4dc7d..git_revision:fc295f3ac7ca4fe7acc6cb5fb052d22909ef3a8f * testing: https://chromium.googlesource.com/chromium/src/testing/+log/eea65f3b4f..0385db204c * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..b28fe159ba * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/82f35125f4..0a233e1760 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/fb06cff8e4..336fcfd099 * tools/luci-go: git_revision:81212ba3aa0a1a724465bded12d12c16ed46da3a..git_revision:31175eb1a2712bb75d06a9bad5d4dd3f2a09cd1f * tools/luci-go: git_revision:81212ba3aa0a1a724465bded12d12c16ed46da3a..git_revision:31175eb1a2712bb75d06a9bad5d4dd3f2a09cd1f * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/58b6f08974..bcefc4c28e * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/3ae68273f2..e136376e7e Clang version changed llvmorg-14-init-11416-gc22b1106:llvmorg-14-init-11564-g37fbf238 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/fb06cff8e4f3faa8a20a3221ba0b6aae3ed5f80e..336fcfd099995c128bc93e97b8263cc6fc891cc8/scripts/update.py Bug: None Tbr: jonahr@google.com Change-Id: I6903ab1a98ec262ddf076760dd1882be0473b8ca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3322248 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Kai Ninomiya b007e667 2021-12-08T01:00:54 Revert "system_utils: Add memory protection functionality." This reverts commit ab75a90ff4ecb9d99b5c72bde92222b07c285401. Reason for revert: Causes angle_unittests to hang on many Linux FYI bots and likely Android. First known failures on Linux: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20FYI%20Release%20(AMD%20RX%205500%20XT)/7318/overview https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20FYI%20Release%20(Intel%20HD%20630)/30297/overview https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20FYI%20Experimental%20Release%20(Intel%20HD%20630)/43446/overview https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20FYI%20Release%20(Intel%20UHD%20630)/4720/overview https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20FYI%20Release%20(NVIDIA)/29040/overview https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20FYI%20Experimental%20Release%20(NVIDIA)/45374/overview And Android: https://ci.chromium.org/ui/p/chromium/builders/ci/Android%20FYI%20Release%20(Nexus%209)/35989/overview https://ci.chromium.org/ui/p/chromium/builders/ci/Android%20FYI%20Release%20(NVIDIA%20Shield%20TV)/33490/overview Original change's description: > system_utils: Add memory protection functionality. > > Implement PageFaultHandler and memory protection functions. > Uses mprotect and sigaction on POSIX and equivalent Win API functions on > win32. > > Add tests to system_utils_unittests. > > Add stubs for winuwp. > > Test: angle_unittests --gtest_filter="SystemUtils.PageFaultHandler*" > Bug: angleproject:5857 > Change-Id: Ia6d2e87c409e6139ccaebc8c7186cd4cd844fd28 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3236998 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Cody Northrop <cnorthrop@google.com> > Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com> Bug: angleproject:5857 Change-Id: I7df73a3ee3f5fa87f002045dfa87d8ca2747f60f No-Tree-Checks: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3322104 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Tim Van Patten <timvp@google.com>
Kenneth Russell 0b3ae9b8 2021-12-06T15:42:22 Add kbr as code owner. Requesting this permission mainly to be able to unblock CLs in areas of expertise like the Mac port. Bug: angleproject:6769 Change-Id: I2b50b26d868c14ac788bccec5b1106627bf9df57 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3319341 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org>
Yuly Novikov f64f9546 2021-12-07T20:17:32 Reland "Decouple gl_BaseVertex/gl_BaseInstance uniforms" This reverts commit 10e5f34d1439f0bcd5b30bea5bfbf6bdaafd4935. Reason for revert: exonerated from flaky crash suspect Original change's description: > Revert "Decouple gl_BaseVertex/gl_BaseInstance uniforms" > > This reverts commit 36bf1ebe5e9500704dd235254bd22a1f2bbd7059. > > Reason for revert: suspect causing flaky crashes > > Bug: angleproject:6763 > > Original change's description: > > Decouple gl_BaseVertex/gl_BaseInstance uniforms > > > > These are builtin uniforms removed in > > https://github.com/KhronosGroup/WebGL/pull/3278 > > > > Decouple them from the original ANGLE_base_vertex_base_instance > > extension. > > > > Make a new ANGLE_base_vertex_base_instance_shader_builtin > > extension for these builtin uniforms. > > > > Bug: angleproject:3402 > > Change-Id: I77b93917976ce435db9c578c0ade37bff18a42b0 > > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3290304 > > Commit-Queue: Shrek Shao <shrekshao@google.com> > > Reviewed-by: Geoff Lang <geofflang@chromium.org> > > Reviewed-by: Kenneth Russell <kbr@chromium.org> > > Bug: angleproject:3402 > Change-Id: I75830baa14cf4e7c53750fd14ff76501145b4823 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3315610 > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Reviewed-by: Yuly Novikov <ynovikov@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Shrek Shao <shrekshao@google.com> Bug: angleproject:6763 Bug: angleproject:3402 Change-Id: Ie436dc5d55364e464897d407a53b793941cd5d0b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3321703 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Lubosz Sarnecki 333e61d3 2021-10-19T16:06:14 trace_fixture: Add UpdateClientBufferData2WithOffset. Adds a function to update buffers with an offset. Bug: angleproject:5857 Change-Id: Iddc0dbcdd123866f31c1382e1eb6fc7e7cb922b1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3236997 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Jamie Madill dcadfa87 2021-12-07T10:34:56 Frame Capture: Fix missing header include in shared setup. This could produce undefined string errors in some traces. Bug: angleproject:5133 Bug: angleproject:6772 Change-Id: I336369a035e30fc7d73530084b5e192d60afee1b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3320865 Reviewed-by: Lubosz Sarnecki <lubosz.sarnecki@collabora.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Lubosz Sarnecki ab75a90f 2021-10-21T20:20:07 system_utils: Add memory protection functionality. Implement PageFaultHandler and memory protection functions. Uses mprotect and sigaction on POSIX and equivalent Win API functions on win32. Add tests to system_utils_unittests. Add stubs for winuwp. Test: angle_unittests --gtest_filter="SystemUtils.PageFaultHandler*" Bug: angleproject:5857 Change-Id: Ia6d2e87c409e6139ccaebc8c7186cd4cd844fd28 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3236998 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Lubosz Sarnecki 3e493db2 2021-11-19T10:47:04 tests/AndroidManifest: Disable allowNativeHeapPointerTagging. In order for the mprotect tests to pass on Android, tagged pointers need to be disabled. Bug: angleproject:5857 Change-Id: I2a9703b98443a96b486581c5c5d57e40c3365555 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3291655 Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Brian Sheedy 50d8a2af 2021-12-06T11:35:08 Remove Skia Gold master usage Removes _GetGitOriginMasterHeadSha1 in the Skia Gold Python code since _GetGitOriginMainHeadSha1 is now used in the base Chromium code. Bug: chromium:1276531 Change-Id: I8f5b793b21ba6ff0e4110a3259becc2aaec06443 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3318581 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll f4553165 2021-12-07T10:01:53 Roll vulkan-deps from 5b3be708ab2f to 5c0e64524982 (3 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/5b3be708ab2f..5c0e64524982 Changed dependencies: * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/ea61f32f24..e005e1f817 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/876a1b9c34..3d3aae8fab * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/81195dfecb..2c2b81c051 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: If794ccc456eab9b7ec17739ca3170a81d9531892 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3319464 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll c899424c 2021-12-07T07:01:04 Roll Chromium from 558e41ede9d4 to 111e348dc9b4 (338 revisions) https://chromium.googlesource.com/chromium/src.git/+log/558e41ede9d4..111e348dc9b4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/7e04e375a3..0d9559b7b4 * buildtools/linux64: git_revision:e0afadf7a743d5b14737bd454df45d5f1caf0d23..git_revision:297669af11c70e15d465844fdb4cabbcada4dc7d * buildtools/mac: git_revision:e0afadf7a743d5b14737bd454df45d5f1caf0d23..git_revision:297669af11c70e15d465844fdb4cabbcada4dc7d * buildtools/win: git_revision:e0afadf7a743d5b14737bd454df45d5f1caf0d23..git_revision:297669af11c70e15d465844fdb4cabbcada4dc7d * testing: https://chromium.googlesource.com/chromium/src/testing/+log/8d7a8e895b..eea65f3b4f * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..02439f647c * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/440d06ad1a..82f35125f4 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/d812be7bc1..fb06cff8e4 * tools/luci-go: git_revision:3de46a51120f37b29e3552d36ad2aa5882961a05..git_revision:81212ba3aa0a1a724465bded12d12c16ed46da3a * tools/luci-go: git_revision:3de46a51120f37b29e3552d36ad2aa5882961a05..git_revision:81212ba3aa0a1a724465bded12d12c16ed46da3a * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/6d0b405c13..3ae68273f2 No update to Clang. Bug: angleproject:4394 Tbr: jonahr@google.com Change-Id: I714c0b17f97220245766bf6ed69ff4949a84038b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3319352 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 920a0a7f 2021-12-06T12:43:32 Roll SwiftShader from a465cca8ec8d to 3e61a772b248 (4 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/a465cca8ec8d..3e61a772b248 2021-12-03 capn@google.com Skip building SPIRV-Tools executables 2021-12-03 kramerb@google.com Move swiftshader off deprecated llvm::IRBuilder APIs 2021-12-03 swiftshader.regress@gmail.com Regres: Update test lists @ a465cca8 2021-12-03 capn@google.com Unpack 1010102 formats into upper 16-bit components If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I65967c7bd1e8c9d7dac22515fc728ed0c9d74b87 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3317473 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll ca3dfbe7 2021-12-06T15:11:56 Roll Chromium from 840fab92609d to 558e41ede9d4 (627 revisions) https://chromium.googlesource.com/chromium/src.git/+log/840fab92609d..558e41ede9d4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jonahr@google.com,jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/b651c3285d..7e04e375a3 * buildtools/clang_format/script: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/clang/tools/clang-format.git/+log/99876cacf7..e435ad79c1 * buildtools/linux64: git_revision:b79031308cc878488202beb99883ec1f2efd9a6d..git_revision:e0afadf7a743d5b14737bd454df45d5f1caf0d23 * buildtools/mac: git_revision:b79031308cc878488202beb99883ec1f2efd9a6d..git_revision:e0afadf7a743d5b14737bd454df45d5f1caf0d23 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/0f447a3138..74c6eec693 * buildtools/win: git_revision:b79031308cc878488202beb99883ec1f2efd9a6d..git_revision:e0afadf7a743d5b14737bd454df45d5f1caf0d23 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/9044f53831..8d7a8e895b * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..02439f647c * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/98be56f2e0..440d06ad1a * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/16279ec9aa..d812be7bc1 * tools/luci-go: git_revision:2892a4983327fe6862e8657e5fac8e976e6265e9..git_revision:3de46a51120f37b29e3552d36ad2aa5882961a05 * tools/luci-go: git_revision:2892a4983327fe6862e8657e5fac8e976e6265e9..git_revision:3de46a51120f37b29e3552d36ad2aa5882961a05 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/6bdbc14474..6d0b405c13 Clang version changed llvmorg-14-init-11072-gb1bc627e:llvmorg-14-init-11416-gc22b1106 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/16279ec9aa9650adc022985ea0831c9ca0c62fd9..d812be7bc18912c71a2a02ce4aefaab8ede19ba6/scripts/update.py Bug: None Tbr: jonahr@google.com,jmadill@google.com Change-Id: I715dd4d0cf9500d98c791bbaff5d42fc973184b6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3317492 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi 006c11d9 2021-11-20T22:12:20 Vulkan: Fix xfb query ASSERT on end It's possible for the xfb query to have never been issued, as it's deferred until a draw call with xfb active is encountered, which may never happen. Bug: chromium:1209285 Change-Id: I893f9f9a06e4b9f2f9da9406affab0be3598fcb4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3294701 Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Lingfeng Yang 6d3435fd 2021-12-01T17:08:01 Validate SamplerFormat We weren't validating sampler formats in ProgramExecutable validation. Bug: chromium:1273661 Change-Id: Ida0c67c0c7169ea3f47ceb2d433bee17012a7e5e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3312717 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Lingfeng Yang <lfy@google.com>
Ian Elliott 6daca788 2021-12-06T11:04:14 Point to ANGLE Wrangler schedule website in document Bug: angleproject:6768 Change-Id: Ie274383238af120792d3a66a7e829b8e6d5c46af Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3317818 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
Lingfeng Yang 929c8ed4 2021-12-01T18:16:14 Vulkan: remove staged updates on storage set Previously we would allow staged updates to bigger versions of a texture to go through even if the texture was redefined via glTexStorage*. Bug: chromium:1262080 Change-Id: I9d861fed68d4a1fdcd0777b97caf729cc74c595e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3312718 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Lingfeng Yang <lfy@google.com>
Jamie Madill 8313ffe2 2021-11-29T15:46:25 FrameCapture: Add ReplayWriter helper class. This centralizes all of the replay file I/O into a single point. Each function is stored separately in this class. Right now there's some small file format changes: - the namespaces for the capture label are gone. these had no functional impact now that each trace was a separate module. - the header is cleaned up into private and public functions. this cleans up a few things like defining non-existent functions. - inline variables are tracked through the replay. they are now global instead of anonymous, and string sets get reused instead of duplicated between frames. There should be no functional changes with the naming of the trace files or the trace behaviour. This change sets the stage for the ReplayWriter buffering multiple frames into a single cpp file on disk, which can potentially reduce the number of object files in the compilation by a great deal. It could also be extended to work with buffered I/O so we don't block and hitch when we're writing large trace files. Bug: angleproject:5133 Change-Id: Ib96685e1202ac8101a4b828fa79642236af2120a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3311940 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 60e457b8 2021-12-06T10:01:53 Roll vulkan-deps from 9970c397e55e to 5b3be708ab2f (1 revision) https://chromium.googlesource.com/vulkan-deps.git/+log/9970c397e55e..5b3be708ab2f Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/c75a1a46f3..f9bcc82ec7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I61ffc60876eb355acb6ed75eb247eed1cb1aa3be Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3316854 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shrek Shao 10e5f34d 2021-12-04T00:10:21 Revert "Decouple gl_BaseVertex/gl_BaseInstance uniforms" This reverts commit 36bf1ebe5e9500704dd235254bd22a1f2bbd7059. Reason for revert: suspect causing flaky crashes Bug: angleproject:6763 Original change's description: > Decouple gl_BaseVertex/gl_BaseInstance uniforms > > These are builtin uniforms removed in > https://github.com/KhronosGroup/WebGL/pull/3278 > > Decouple them from the original ANGLE_base_vertex_base_instance > extension. > > Make a new ANGLE_base_vertex_base_instance_shader_builtin > extension for these builtin uniforms. > > Bug: angleproject:3402 > Change-Id: I77b93917976ce435db9c578c0ade37bff18a42b0 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3290304 > Commit-Queue: Shrek Shao <shrekshao@google.com> > Reviewed-by: Geoff Lang <geofflang@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> Bug: angleproject:3402 Change-Id: I75830baa14cf4e7c53750fd14ff76501145b4823 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3315610 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com>
Amirali Abdolrashidi d0287552 2021-11-15T08:51:41 Reland "Vulkan: Implement GL_EXT_multi_draw_indirect" This is a reland of 79f9d163b4227115a3e60e027ec4d7dbe0495f64 * Added drawcount > 1 as a condition to fall back to MultiDraw*IndirectGeneral(). * Expanded the tests to include cases with disabled support for multiDrawIndirect. Original change's description: > Vulkan: Implement GL_EXT_multi_draw_indirect > > * Optimized the implementations of multiDrawArraysIndirect() > and multiDrawElementsIndirect() for Vulkan > * Added helper functions to support drawArraysIndirect() and > drawElementsIndirect() as special cases of multiDraw*Indirect > functions. > * Added the flag to enable the multiDrawIndirect feature > (drawCount > 1). The generic implementation is used if the > flag is disabled. > > Bug: angleproject:6439 > Change-Id: Ibc653d93d355657f828de9c33da22428629e450f > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3276044 > Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Jamie Madill <jmadill@chromium.org> Bug: angleproject:6439 Change-Id: I96c015855fabc8abbb87320a5ca71a8d92d61954 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3313412 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Ian Elliott 5f1a0f32 2021-12-03T15:36:42 Vulkan: Resize deviceExtensionProps to deviceExtensionCount This is a follow-on to a previous commit that worked around an Android platform bug (see angleproject:6715 and b/206733351). In the second call of vkEnumerateDeviceExtensionProperties, ANGLE asks for one more extension than was returned by the first call (because sometimes one more is suddenly available). After the second call, ANGLE will now resize deviceExtensionProps to deviceExtensionCount elements to avoid any possible use of a potentially-empty element. Bug: b/208937840 Bug: angleproject:6715 Bug: b/206733351 Change-Id: I2195ddda4619dd1a72b2cf5bff2395d061d7780d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3315599 Reviewed-by: Jason Macnak <natsu@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
Ian Elliott 24241724 2021-11-22T13:26:53 Reland: Vulkan: Use vkResetQueryPoolEXT when available This is a reland of 97aa5187ed164f1e9a22b64c966f2a747f651bfb Original change's description: > ANGLE currently uses vkCmdResetQueryPool to reset a query pool. As > reported by Arm, this can cause GPU bubbles. It is better to use > vkResetQueryPoolEXT() when available (either by Vulkan 1.2 or by the > VK_EXT_host_query_reset extension). > > Bug: angleproject:6692 > Change-Id: I650d7d0f55bdf6587b75be43cc7bed2dc3eb935a > Reviewed-on: > https://chromium-review.googlesource.com/c/angle/angle/+/3294061 > Commit-Queue: Ian Elliott <ianelliott@google.com> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Charlie Lao <cclao@google.com> Bug: angleproject:6692 Change-Id: Idff87977bd39ccd1d05684e48929f4cd3fa733c7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3313382 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
Brian Sheedy 9408adce 2021-12-03T13:01:09 Add Gold git main method Adds _GetGitOriginMainHeadSha1 to the Skia Gold code, which is equivalent to the existing _GetGitOriginMasterHeadSha1 except that it checks against origin/main. The former will be used and the latter removed once Chromium is able to safely update which version it calls. Bug: chromium:1276531 Change-Id: I23b2da0aac91a182fde934b7c7396e41fe6bf07c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3314883 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Cody Northrop 6a699d5d 2021-12-03T08:38:25 Vulkan: Allow nonconformant EXT_gpu_shader5 ANGLE can't create an ES 3.2 context on SwiftShader due to lack of shaderImageGatherExtended, which is required for EXT_gpu_shader5. This CL extends the exposeNonConformantExtensionsAndVersions check to enable EXT_gpu_shader5 in the Vulkan backend. Test: ES 3.2 traces on SwiftShader (Asphalt 9, Fortnite, etc) Bug: angleproject:5652 Bug: angleproject:5658 Bug: angleproject:5883 Bug: angleproject:6613 Bug: angleproject:6749 Bug: b/197731391 Change-Id: I1a1ef0dd1983de39996179d27ae0399f1ef43de9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3314512 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi 1047af38 2021-12-02T14:30:42 Fix changing attached renderbuffer from MSRTT to non-MSRTT FramebufferAttachment::mRenderToTextureSamples was never updated if the renderbuffer storage was changed after attaching to framebuffer. Bug: chromium:1272068 Change-Id: Ib0cfde53c3453c0df4b0aea32ab0a246aa2ade7f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3313414 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Lingfeng Yang c88a73c8 2021-12-02T12:49:00 Fix flakiness in CpuTimeSleepy Looks like we can't really rely on the direct wall comparison---probably different resolutions are tripping us up here. Bug: chromium:1272977 Change-Id: Ie3691c59eb5b3765b79f1861200436d9c5acd609 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3313481 Commit-Queue: Lingfeng Yang <lfy@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 6f96a189 2021-12-01T11:14:33 FrameCapture: Clean up 'WriteCppReplayFunctionWithParts'. This function was using two extra temporary streams that it didn't need. Clean this up and remove the extra streams and repeated code. Bug: angleproject:5133 Change-Id: I8065a189211ba9030fee523dc7145dc5daf71d92 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3311577 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 6c00068c 2021-12-03T10:01:52 Roll vulkan-deps from 933bb8aaaef9 to 9970c397e55e (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/933bb8aaaef9..9970c397e55e Changed dependencies: * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/a152371654..ea61f32f24 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/737b390a4c..876a1b9c34 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/ae1ef56fc9..81195dfecb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: Ie5c3405f5b0c3f751aab52f3464f0b4d9037ba71 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3314498 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 9498d04b 2021-12-03T10:01:32 Roll SwiftShader from f9c39655a610 to a465cca8ec8d (3 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/f9c39655a610..a465cca8ec8d 2021-12-02 nicolascapens@google.com Add bclayton to OWNERS 2021-12-02 swiftshader.regress@gmail.com Regres: Update test lists @ f9c39655 2021-12-02 capn@google.com Update SPIR-V Tools to c75a1a46f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: Ib9b5187cb028e6f87b48806d0849c8a8622dbfac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3314172 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll f58b8aba 2021-12-03T07:02:45 Roll Chromium from d666676e2702 to 840fab92609d (514 revisions) https://chromium.googlesource.com/chromium/src.git/+log/d666676e2702..840fab92609d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/83e1eefbf9..b651c3285d * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/a281fd3d4c..0f447a3138 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/c70310ef4a..9044f53831 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/8ccce98a2e..db126cca75 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..dbf853603c * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fc79a33466..98be56f2e0 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/e8c257c917..efd9399ae0 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/401e727f2a..16279ec9aa * tools/luci-go: git_revision:91cbdea8898ac2d498f2412d35279b00784a1ece..git_revision:2892a4983327fe6862e8657e5fac8e976e6265e9 * tools/luci-go: git_revision:91cbdea8898ac2d498f2412d35279b00784a1ece..git_revision:2892a4983327fe6862e8657e5fac8e976e6265e9 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/33b0162246..58b6f08974 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/f102ca3bc2..6bdbc14474 * tools/skia_goldctl/linux: CseaUnLJ7HPr--xryu13CF7Iir6n0b8qmCJXm6gyZ4oC..wdkOk4Hhfdk2f0Fn4TnicgWCxDVdkOK0W71K0ivXMaEC * tools/skia_goldctl/mac: VY8wueKQ3PgFlxfrtkyEqIEUBvFjmyowZ9aUNYRyEhcC..gJSgm5xIzq6ePie9lIvMfyt3vEXbiVb5NreHTEkFS58C * tools/skia_goldctl/win: W_IYtpGZzolSY2j4xqryufwbZeApZYaqqcn4-CTtpL0C..BkeCwTnJJi2hffEKlsGWTiP5quyDianpBWnloFZ49ZEC Clang version changed llvmorg-14-init-8564-g34b903d8:llvmorg-14-init-11072-gb1bc627e Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/401e727f2ae6663c4e13dfd3e1006cc9fa34bb10..16279ec9aa9650adc022985ea0831c9ca0c62fd9/scripts/update.py Bug: None Tbr: ynovikov@google.com Change-Id: I150b951cc16b0bbc50fe3ca696b6f10cadda8129 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3314496 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jeff Vigil fe42ac4d 2021-11-29T15:45:40 EGL: deferredFlush fix for PRESENT_MODE_SHARED Add work around to deferredFlush for SINGLE_BUFFER Fixes issue with EGL_KHR_mutable_render_buffer and deferredFlush feature. Bug: angleproject:6739 Change-Id: I81f87899f2c92a7e001b6aee2f88ecf7ba0d40a1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3308224 Commit-Queue: Brandon Schade <b.schade@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll f3052589 2021-12-02T17:38:51 Roll vulkan-deps from cb8be59599df to 933bb8aaaef9 (25 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/cb8be59599df..933bb8aaaef9 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/febbeb4f83..ec5ea2d6cb * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/37dfb3f45f..e9cc640334 * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/814e728b30..29414ae1fd * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/d0a827a9f3..c75a1a46f3 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/3c1ad4b0d5..737b390a4c * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/b50a0f786e..08f87babad * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/00e8145e37..ae1ef56fc9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: Ia3341deca9184161c8e1f0897b54f9b1397a4388 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3313476 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Tim Van Patten 8e6f38e5 2021-12-02T17:24:32 Revert "Vulkan: Implement GL_EXT_multi_draw_indirect" This reverts commit 79f9d163b4227115a3e60e027ec4d7dbe0495f64. Reason for revert: Breaks dEQP-GLES31.functional.draw_indirect* on Pixel devices: https://blackbox.googleplex.com/dashboard/cts-graphics/target/git_master/oriole-userdebug/3/cts-angle-host-test-arm64-v8a/4 Original change's description: > Vulkan: Implement GL_EXT_multi_draw_indirect > > * Optimized the implementations of multiDrawArraysIndirect() > and multiDrawElementsIndirect() for Vulkan > * Added helper functions to support drawArraysIndirect() and > drawElementsIndirect() as special cases of multiDraw*Indirect > functions. > * Added the flag to enable the multiDrawIndirect feature > (drawCount > 1). The generic implementation is used if the > flag is disabled. > > Bug: angleproject:6439 > Change-Id: Ibc653d93d355657f828de9c33da22428629e450f > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3276044 > Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Jamie Madill <jmadill@chromium.org> Bug: angleproject:6439 Change-Id: Ia4d54ef3e7652febf4d77fdaf6809f57e8e29127 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3312829 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Tim Van Patten <timvp@google.com>
angle-autoroll 38b96fcc 2021-12-02T10:01:31 Roll SwiftShader from ff91ac52f4b7 to f9c39655a610 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/ff91ac52f4b7..f9c39655a610 2021-12-02 srisser@google.com Expose support for VK_KHR_swapchain_mutable_format If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I07818cef0b8f03f3d36caf2ab3e632d03f7439b7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3312055 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 29babe0f 2021-12-02T07:01:19 Roll Chromium from d2d61620103d to d666676e2702 (101 revisions) https://chromium.googlesource.com/chromium/src.git/+log/d2d61620103d..d666676e2702 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * testing: https://chromium.googlesource.com/chromium/src/testing/+log/ac23806e2b..c70310ef4a * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..5695a8426c * tools/luci-go: git_revision:e4c95e4e4cdc987f1860e4111589606bcd3a8f32..git_revision:91cbdea8898ac2d498f2412d35279b00784a1ece * tools/luci-go: git_revision:e4c95e4e4cdc987f1860e4111589606bcd3a8f32..git_revision:91cbdea8898ac2d498f2412d35279b00784a1ece No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: I9c9dd687124af08fe729cdfe08d0f2363a2b0651 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3312817 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 7107f8aa 2021-12-02T00:57:17 Roll Chromium from 5bf1cc589ddf to d2d61620103d (907 revisions) https://chromium.googlesource.com/chromium/src.git/+log/5bf1cc589ddf..d2d61620103d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/dcea344303..83e1eefbf9 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/665b74f7d1..89f2e82120 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/c936d73ff7..a281fd3d4c * testing: https://chromium.googlesource.com/chromium/src/testing/+log/f1bdd0ee5c..ac23806e2b * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/457dbf3362..8ccce98a2e * third_party/android_platform: https://chromium.googlesource.com/chromium/src/third_party/android_platform/+log/72e09e98a6..abc362f16d * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..5695a8426c * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/804165b445..fc79a33466 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/2231b7c84b..e8c257c917 * tools/luci-go: git_revision:7422359d33c606e8adb0e9cf461837eb9b49431f..git_revision:e4c95e4e4cdc987f1860e4111589606bcd3a8f32 * tools/luci-go: git_revision:7422359d33c606e8adb0e9cf461837eb9b49431f..git_revision:e4c95e4e4cdc987f1860e4111589606bcd3a8f32 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/4c93694b28..33b0162246 * tools/md_browser: https://chromium.googlesource.com/chromium/src/tools/md_browser/+log/9772d4c05b..b61dc90769 * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/bfbdc93fb6..0639a8c19c * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/b4c2add623..f102ca3bc2 No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: I9b98c846e8400c5e28ae0370d71dc08b98bae2bb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3312364 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shrek Shao 36bf1ebe 2021-11-17T13:31:17 Decouple gl_BaseVertex/gl_BaseInstance uniforms These are builtin uniforms removed in https://github.com/KhronosGroup/WebGL/pull/3278 Decouple them from the original ANGLE_base_vertex_base_instance extension. Make a new ANGLE_base_vertex_base_instance_shader_builtin extension for these builtin uniforms. Bug: angleproject:3402 Change-Id: I77b93917976ce435db9c578c0ade37bff18a42b0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3290304 Commit-Queue: Shrek Shao <shrekshao@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Lingfeng Yang 8815245a 2021-12-01T08:58:01 Vulkan: Don't retain in buffer/imageRead unnecessarily mUsedBuffers/images already tracks whether a buffer/image is used in a render pass, so we can add to ContextVk's resource use list only once. Bug: angleproject:6717 Change-Id: Idd528c7f0f3fcb4d8d8879ab6cc7055260ecb45d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3310523 Commit-Queue: Lingfeng Yang <lfy@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jonah Ryan-Davis 2d41e0f7 2021-11-30T16:14:03 Rework compressed texture pixel unpack state handling. Compressed images do not use the pixel unpack parameters. Instead of handling this in Context, move this to formatutils, where it's already handled for the 2D case. Also, update the test to generate an ASAN error if not ignored for the 2D case. Bug: chromium:1267496 Change-Id: Ib93bae00a2b0b75eafd74c267f737da225afd993 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3308825 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 8f6f5a4b 2021-11-30T23:48:30 Vulkan: Fix image respecify's usage tracking When respecifying an image due to mip level count changes, the previous image is staged as an update to the new image. The resource usage info was not being transferred to the image being staged as an update, causing it to be prematurely deleted. Test based on one authored by sugoi@google.com. Bug: chromium:1270658 Bug: angleproject:4835 Change-Id: I215c65ba700d7be608d0910d3cb37fcfdf297a2a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3308921 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Yuly Novikov 609eb31a 2021-12-01T10:24:59 Skip MultithreadingTestES3.MultithreadFenceTexImage on TSAN Bug: angleproject:6718 Change-Id: If67662dfb2ade1c87e9b4ba22e65efabf17f096c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3310485 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov 9d91064d 2021-11-30T17:56:31 Document using Rubber Stamper for test expectations CLs Also includes a small update about FLAKY expectations. Bug: angleproject:6740 Change-Id: I4df6534412e3720fb9f7bdeeadc555892016b7fb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3308830 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill f84dc44f 2021-11-30T12:22:21 Add a test for changing an XFB buffer after Begin. Bug: chromium:1274316 Change-Id: I4ba240ff4cc383b157a64a0c92e8ce8ab2d8061e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3309101 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Gert Wollny 3b6f80b7 2021-11-23T10:07:43 Capture/Replay: eliminate redundant parameters in GenOnBind The template parameter already defines the parameter value name and the parameter value type, so add some traits to simplify the call interface of the function. Bug: angleproject:6425 Change-Id: I037bed8e5cc2e7367d8faa3af5d4fba2bfbb52c3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3295617 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
angle-autoroll 5f67a941 2021-12-01T10:01:31 Roll SwiftShader from f12305c3a0d9 to ff91ac52f4b7 (6 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/f12305c3a0d9..ff91ac52f4b7 2021-11-30 capn@google.com Prevent exit-time destructors in src/WSI, Pipeline, and System 2021-11-30 capn@google.com Update SPIR-V Tools to d0a827a9f 2021-11-30 capn@google.com Update SPIR-V Headers to 20b02de99 2021-11-30 capn@google.com Don't handle vendor-specific SPIR-V instructions 2021-11-30 capn@google.com Don't consider OpType* instructions to be statements 2021-11-30 capn@google.com Eliminate SpirvShaderInstructions.inl If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I4beaf0c50689731ac1d05bd2b44867d806b8be8d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3309214 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov fc860bc1 2021-11-30T17:39:42 Skip *Vulkan_AsyncQueue angle_end2end_tests on TSAN Bug: angleproject:6746 Change-Id: If8bbf8ffc4c6d5df376ebd7c3d51c98c6990ea0d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3308829 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Ben Pastene 8e430236 2021-11-30T12:43:40 Enable the chromium recipe RDB results experiment for all builds. This experiment has been enabled at 100% for all chromium builds for months now. And the more builders are on it, the more we're able to refactor the chromium recipe. This was attempted in crrev.com/c/3307244, but had to be reverted since angle builds re-use much of chromium's recipe code but don't have the experiment rolled out to them. So this rolls it out to angle builds to allow for further clean-up in chromium's recipe code. Since all angle tests are wrapped via result_adapter, they should already have RDB integration (meaning their results are already uploaded to RDB). A LED run of a build with this experiment applied: https://ci.chromium.org/swarming/task/578b98d07382dd10?server=chromium-swarm.appspot.com Another LED run with that experiment and the recipe CL relanded: https://ci.chromium.org/swarming/task/578b9939cfccdb10?server=chromium-swarm.appspot.com This matches its original build: https://ci.chromium.org/ui/p/angle/builders/try/win-test/1026/overview Bug: chromium:1135718 Change-Id: Ief4993fa9c027f9c2c6c3c352eb4e65ce74b628c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3309479 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 45028d29 2021-11-30T10:37:06 D3D11: Fix OOB access in vertex conversion code. This could happen when using certain combinations of stride and offset. Fix the issue by using checked math. Bug: chromium:1274499 Change-Id: Idba3beedad10b0c0cac2dcbecba8e420c5baa6da Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3309035 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Alexis Hetu 7817761a 2021-11-23T22:47:44 Vulkan: Use the correct format when binding a pBuffer. Vulkan would get the texture format from the pBuffer's config but some pBuffer types use different formats which are queried with getBindTexImageFormat. This CL also removes nativeSizedExternalFormat. nativeSizedExternalFormat was only used when the format/type is GL_RGB/GL_UNSIGNED_BYTE. This is now obsolete since the real fix was the pBuffer fix mentioned above, so this CL cleans up the now unnecessary code. Bug: angleproject:4369 Bug: chromium:1237561 Bug: chromium:1099979 Change-Id: Ibfedea60d10856831e3a1975ac20ae5eb6a73786 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3298352 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Yuly Novikov d7b3c6d1 2021-11-30T15:25:36 Don't build dEQP tests on MSVC temporarily dEQP fails compile on MSVC Due to build switching to C++17. Temporarily stop building them while VK-GL-CTS is being fixed upstream. Bug: angleproject:6737 Change-Id: I288aab95cb76104fde7635eafb37d56b4ed0a600 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3308820 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 1125db99 2021-11-30T09:58:19 Roll Chromium from b510b0864113 to 5bf1cc589ddf (826 revisions) Manually restrict "build" dep to dcea3443035f48d58193788e0bc56daca4e5db33 due to anglebug.com/6737 And skip updating "abseil-cpp" https://chromium.googlesource.com/chromium/src.git/+log/b510b0864113..5bf1cc589ddf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/26881c1164..dcea344303 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/e504863f9e..665b74f7d1 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/f51a154281..c936d73ff7 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/103f40247e..f1bdd0ee5c * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..8cf0922154 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2ffa1bde79..804165b445 * third_party/r8: CokGsfuGfcV-GjGwN98h28Phet4ai_xhPGZkGCqotWMC..KOlWWUU4CAY1EqgiZ6iljOP7ycIjceTEFcwWxL14HFoC * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/f8964a5ccf..2231b7c84b * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/ace657580d..401e727f2a * tools/luci-go: git_revision:03f7c59feeac59c211e5b06fbbbc7405861b482e..git_revision:7422359d33c606e8adb0e9cf461837eb9b49431f * tools/luci-go: git_revision:03f7c59feeac59c211e5b06fbbbc7405861b482e..git_revision:7422359d33c606e8adb0e9cf461837eb9b49431f * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/5d2edce177..4c93694b28 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/be66670475..b4c2add623 * tools/valgrind: https://chromium.googlesource.com/chromium/src/tools/valgrind/+log/79ec84517e..ff9c7dc63d No update to Clang. Bug: angleproject:6737 Tbr: ynovikov@google.com Change-Id: I1c58d844163803dc2e861112dbc867e070d29476 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3308639 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cody Northrop ce854632 2021-11-29T10:48:48 FrameCapture: Fix Gen on Bind for MEC The logic for detecting whether a resource has been generated was not accounting for starting resources, which would only be populated if using MEC. We also weren't tracking framebuffer creation correctly in CaptureMidExecutionSetup. Test: Asphalt 9 MEC Bug: angleproject:5883 Bug: angleproject:6425 Change-Id: I8a7dfa4736c4d735dec8cd26ffa329f051927de6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3307778 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop 440e5458 2021-11-27T19:55:06 FrameCapture: Integer attribs in MEC If the component type of a vertex attribute is integer, we need to use the appropriate VertexAttribI* functions to set it up. Test: Asphalt 9 MEC Bug: angleproject:5883 Change-Id: I2ab2248e5a36cc6636b081acf6474b5dbe2484db Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3305057 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Peng Huang 65720272 2021-11-26T17:42:16 Add end2end gl test for *_ANGLE_vulkan_image extensions Bug: chromium:1264439,angleproject:6741 Change-Id: I12d332995138a020ba514fba34024c3e666b8e6b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3304396 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Gert Wollny 2020ec2b 2021-11-18T16:49:35 Capture/Replay: run tests that will crash or fail compilation These tests have to run in one-sized batches so that they do not bring down other tests run in the same batch, but it is useful to run these tests to see whether chenges to the code fix these tests. In addition, update the expectations to reflect that more tests do not crash or even pass. Mark one more test as FLAKY because a change of the batch allocation seems to change this test. Leave timeouts as skip to not burden the CI too much. Bug: angleproject:6180 Bug: angleproject:6267 Bug: angleproject:6267 Bug: angleproject:6313 Bug: angleproject:6314 Bug: angleproject:6315 Bug: angleproject:6324 Bug: angleproject:6329 Bug: angleproject:6333 Bug: angleproject:6334 Bug: angleproject:6335 Bug: angleproject:6399 Bug: angleproject:6400 Bug: angleproject:6605 Bug: angleproject:6611 Bug: angleproject:6631 Change-Id: I973ec43feff8ca51de698e0aade3d7102b193166 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3291643 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Yuly Novikov 17261f3b 2021-11-29T19:53:39 Remove not needed constexpr definitions, deprecated in C++17 Bug: angleproject:6737 Change-Id: I38ead1bd8e5eaace78750505b93a2576e19d0f83 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3307535 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll 739c414f 2021-11-30T10:01:53 Roll vulkan-deps from 81bb0c5b367f to cb8be59599df (8 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/81bb0c5b367f..cb8be59599df Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/083bdc838a..febbeb4f83 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/ef2429635d..3c1ad4b0d5 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/a01b76b168..b50a0f786e * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/dcd1e40ebb..00e8145e37 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I6fdcf724e60d785842e83e1c2a3df72bd5848409 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3308640 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov 949624bf 2021-11-29T16:57:35 Skip MultisampleTest on Mac Metal ContentPresevedAfterInterruption/ES2_Metal_NoFixture__NoStoreAndResolve Bug: angleproject:6702 Change-Id: Iefff376ec8f3fb140825ad239bf8a2b560c8effb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3307346 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Tim Van Patten ef65edf2 2021-11-22T14:23:35 Add extension: ANGLE_rgbx_internal_format Add the extension ANGLE_rgbx_internal_format, which exposes the ANGLE internal format GL_RGBX8_ANGLE. The format GL_RGBX8_ANGLE enables emulating RGB8 formats with RGBA8 within ANGLE. This also renames the format GL_RGBX8_ANGLEX to GL_RGBX8_ANGLE, since it's being exposed. Bug: angleproject:6690 Test: Texture2DTestES3.TextureRGBXImplicitAlpha1 Change-Id: I5548a3578a14e2f2a4006bbf59983b01f694b7f3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3296625 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Mohan Maiya 44d0ef69 2021-11-25T14:37:38 Vulkan: Enhance SamplerDesc for YUV formats In order to uniquely identify a VkSamplerYcbcrConversion, having just the format is insufficient. We need to account for conversion model and color component range. Refactor SamplerDesc by encapsulating YUV related fields into its own YcbcrConversionDesc. Bug: angleproject:6732 Test: Texture2DTestES3.*Yuv*Vulkan Change-Id: I23114c50646232dccde988a52b0649778ad72a90 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3301899 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Jonah Ryan-Davis 568a350e 2021-11-29T14:17:31 Suppress Texture3dTestES3.PixelUnpackStateTex[Sub]Image3D on Mac This test was newly added in the fix for https://crbug.org/1267496 It crashes similarly on Mac. Suppress for now while I work on the fix. Bug: angleproject:6738 Change-Id: Ifbdbb790b2f60fe91362ee47d1165165cb5c5382 TBR=ynovikov@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3307478 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Peng Huang a5e391d7 2021-11-19T17:35:06 Add GL_ANGLE_vulkan_image extension glAcquireTextures & glReleaseTextures are added for sharing texture ownership with an external API. Bug: chromium:1264439 Change-Id: If46d8d230b4f611768b5ff1187674509e42f01e0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3293921 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org>
Mohan Maiya 00d0b79f 2021-11-26T14:38:20 Bug fix in BitSetArray iterator Account for gaps spanning multiple BaseBitSet while iterating. Bug: angleproject:3877 Tests: BitSetArrayTest*IterationWithGaps* Change-Id: I64a0393bf117678b0a7855904a6ac328a13bb40c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3304108 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill f893c61b 2021-11-26T14:58:28 Update capture_replay_expectations.txt. Adds expectation for new skipped test. Also consolidates expectations into just SwiftShader since we cannot yet support multiple Vulkan implementations. Bug: angleproject:6688 Change-Id: I736d28f3e452624eae4cde8058a6c1acdaae1263 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3304554 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll a56d3c13 2021-11-29T10:01:31 Roll SwiftShader from edeff1f2e7db to f12305c3a0d9 (4 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/edeff1f2e7db..f12305c3a0d9 2021-11-26 capn@google.com Statically allocate function pointer tables for libXCB 2021-11-26 capn@google.com Statically allocate function pointer tables for libX11 2021-11-26 capn@google.com Refactor libXCB and libX11 wrappers 2021-11-26 ari.suonpaa@siru.fi Fix component normalization for texture gather If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I37c1985f0aa8be3004b5be2d34ff258ee8ef714e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3306222 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 460cb0d5 2021-11-29T10:00:52 Roll vulkan-deps from b497675b7cba to 81bb0c5b367f (2 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/b497675b7cba..81bb0c5b367f Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/8c155b364c..d0a827a9f3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I8e8257d6d7c19e89edf35626d38b6f8887a7f32e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3306232 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill c789169b 2021-11-26T15:21:43 Fix export_targets presubmit on Windows. It was checking for the vs toolchain in the wrong folders. Bug: angleproject:6735 Change-Id: Ia64f85b33fb6a1b30ca2ebf8ec86eee579e1e835 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3304634 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 60e3dc12 2021-11-26T15:05:45 infra: Trigger win-trace on angle_end2end_tests changes. This should prevent a common class of unexpected CQ breakage. Bug: angleproject:6670 Change-Id: Ic5706caedcb2ca326ec87883d695574e5450083c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3304555 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 14f55a7f 2021-11-02T10:16:58 infra: Enable TSAN and UBSAN tests. These tests are not yet enabled on the CQ. Bug: angleproject:5795 Change-Id: I3fc58ab800ebbc0840da8221b03b4ab145d28028 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3258003 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 2797227b 2021-11-26T08:48:30 dEQP: Add flaky result handling. A flaky expectation will allow the test harness to retry a failing test one extra time. If the second run passes the flaky test will be considered a passing result. Bug: angleproject:5795 Change-Id: I09fc4ed34ee09548ab14f46dfce35f900be5550f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3303712 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill e0b4cf6c 2021-11-26T10:23:24 Fix Python3 usage with perf tests/gold tests. Bug: angleproject:6733 Change-Id: I9d1baf78ed182db77c6a6d8e896737413ca417f3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3304012 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
kmx.io     mail     discord kmxgit v0.4.0