kc3-lang/angle/src/tests

src/tests

Log

Author Commit Date CI Message
Tim Van Patten 7ddfb565 2021-10-07T19:55:02 Android: Re-enable Texture3DCopy.FloatFormats/*Vulkan The test Texture3DCopy.FloatFormats was skipped on Android+Vulkan. This CL re-enables it. Bug: angleproject:4756 Test: Texture3DCopy.FloatFormats/*Vulkan Change-Id: Ia063b1efb5856f6623f6734f4430f06a8b143ba6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3213419 Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Tim Van Patten <timvp@google.com>
Cody Northrop 57dd7095 2021-10-07T17:48:06 Capture/Replay: Suppress flaky ES3 test The following test is flaking out: GLSLTest_ES3.ComplexCrossExpression/ES3_Vulkan_SwiftShader Bug: angleproject:6543 Change-Id: Ia615a82727144520e863c686f1f6157aa71f2e58 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3213420 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Cody Northrop fe943910 2021-10-02T21:55:34 Tests: Add Pokemon UNITE trace Test: angle_perftests --gtest_filter="*pokemon_unite*" Bug: b/201900915 Bug: angleproject:6494 Change-Id: I37b52a8557f135ca4d7e42eb964f17104d004513 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3201031 Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Kyle Piddington af5ea7f9 2021-10-07T12:47:41 PrimitiveRestart tests fail due to incorrect draw commands. Primitive restart draw commands were being encoded incorrectly. Single element ranges were being disregarded, and a maximum draw size was not being enforced when the index buffer was aliased / reused. Bug: angleproject:6535 Change-Id: I5affad4df46c4ab2b3702caa89b483ae685618a7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3212629 Commit-Queue: Kyle Piddington <kpiddington@apple.com> Reviewed-by: Gregg Tavares <gman@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Charlie Lao 5ab152c6 2021-10-04T14:08:15 Vulkan: Add tests that triggers acquireAndUpdate Add test for shader storage write followed by bufferSubData Add test for image store followed by bufferSubData. Bug: b/200067929 Change-Id: I5895eaa31ee54e79333f0fe26d92e9378f427a3d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2553171 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Cody Northrop a559c772 2021-10-07T10:27:56 Tests: Add BADLAND trace Test: angle_perftests --gtest_filter="*badland*" Bug: b/202402554 Bug: angleproject:6541 Change-Id: I357b2a7bdb74c74628d5189d701528b60fa000de Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3212627 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Jamie Madill 5862234e 2021-10-07T13:15:31 Remove old AMD/Windows/GLES expectation. Bug: angleproject:2486 Change-Id: Ia7cb1195cabe79b0e93f2787ba627999636a2305 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3212609 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 0f66c861 2021-10-07T09:32:35 Add test that covers HLSL compiler bug. Bug: angleproject:2445 Change-Id: I820b2dba3748bd10ca516ef47f226ff537b78849 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3212328 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jonah Ryan-Davis 212f4592 2021-09-22T12:02:47 Enable direct-to-metal backend by default We are switching over to Apple's direct-to-metal backend instead of generating SPIRV in the metal backend. This CL enables the direct-to-metal generation by default, but the SPIRV backend is still accessible by overriding the feature directMetalGeneration. This CL comes with a change in test expectations to catch new failures and clean up newly passing tests. Bug: angleproject:6080 Change-Id: I4b10ad93c641b88857079a08fb45d3dc575d71f1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3175664 Reviewed-by: Gregg Tavares <gman@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Cody Northrop 80e31738 2021-10-07T09:08:51 Capture/Replay: Suppress failing ES2 and ES3 tests Bug: angleproject:6180 Bug: angleproject:6425 Bug: angleproject:6513 Bug: angleproject:6538 Change-Id: I175f3f6d3b333aefc2cfcd8aeeff077ca762d396 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3212626 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tim Van Patten 27e7c4dd 2021-10-01T13:43:57 Vulkan: Submit commands when Sync objects are initialized This CL calls ContextVk::flushImpl() after the sync object (VkEvent) has been created and initialized, so it has a valid Serial when it's waited on later. This change allows us to remove any tracking of pending sync objects, since all sync objects will be flushed and submitted by the end of SyncHelper::initialize(). Bug: angleproject:6464 Test: MultithreadingTest.CreateFenceThreadAClientWaitSyncThreadBDelayedFlush Change-Id: I47e7ced452727b434ed974368311fb3439a107c9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3200274 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
Shahbaz Youssefi 62414cf8 2021-10-06T16:07:03 Fix GPU-time-tracking in WebGL perf tests GL_EXT_disjoint_timer_query is not enabled by default in WebGL mode. This change ensures that extension is enabled. Bug: angleproject:4794 Change-Id: I1835f7ed2afd7a155ff9b63fad74a066df59ea4f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3210626 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill 22ec42ac 2021-10-07T08:37:43 Remove Skip for unsupported AMD config. Bug: angleproject:2423 Change-Id: I70237576fa1e458276675d4bcb36ad890b5f5806 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3212327 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Tim Van Patten 7e490550 2021-10-06T11:16:08 Cleanup Android/Vulkan deqp_egl_test_expectations.txt There are several bugs marked as "fixed", but still have tests marked as fail/skip in deqp_egl_test_expectations.txt. This CL cleans those up. Note that "cleanup" in this case means restricting the fail/skip to just NEXUS5X, since many are still failing on that device. This CL doesn't look to make the list exactly correct, since that testing on that device is in the process of being deprecated anyway. Bug: angleproject:2546 Bug: angleproject:2635 Bug: angleproject:2715 Bug: angleproject:3081 Bug: angleproject:3270 Bug: angleproject:6533 Change-Id: I6cb9444727671997b38770f8d7ba5b3c6a1b019a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3208512 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll 66c89b0f 2021-10-06T16:28:42 Fix and disable MSVC warnings Needed because some warnings are no longer disabled after http://crrev.com/c/3189512. Also includes https://github.com/KhronosGroup/OpenCL-Headers/pull/179, needed after clang upgrade to llvmorg-14-init-5410-gd0473681 Bug: chromium:1257173 Change-Id: I4f844aa972362c488cb6d37244439e2126f2c1c3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3210629 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov 7b19a535 2021-10-06T17:13:52 Fix iOS build Broken in crrev.com/c/3206017. ANGLE roll into Chromium crrev.com/c/3208766 fails on ios-simulator due to unused function OperatingSystemVersionNumbers. Bug: chromium:1255114 Change-Id: I2cca5e3cd922733950a51bbc08bf9f41558f8436 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3209207 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Jonah Ryan-Davis 207906c1 2021-10-05T15:09:38 Clean up Metal test expectations. Before switching to the direct metal backend, we should clean up some passing test expectations so we can track the new test results post-switch. TBR: ynovikov@chromium.org Bug: angleproject:6467 Bug: angleproject:6466 Bug: angleproject:6485 Change-Id: I33e0bd48b41906eb11cc4de09bf86f3ebd44a24f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3206691 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Gregg Tavares <gman@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Jamie Madill 84f601eb 2021-10-06T13:23:21 Lift Intel specific test expectations. Bug: angleproject:2349 Change-Id: Ib0b6356424452740150b0913e61507839961cf85 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3209087 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 1b669f5d 2021-10-05T15:55:58 Add test names and metric names for BitSetIteratorPerf. New names are like so: [ RUN ] BitSetIteratorPerfTest/BitSetArray_96.Run *RESULT BitSetIteratorPerfTest/BitSetArray_96.wall_time: run= 8609.2511842004 ns .. etc ... Bug: angleproject:2244 Change-Id: I461f52a0ee098875544203c618c6b24598281f73 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3206257 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Nico Weber d78bd836 2021-10-05T16:10:27 win: Remove call to deprecated GetVersionEx Bug: chromium:1255114 Change-Id: Ie0539205d5547b1da05ec957096a369f7d9ababe Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3206017 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi daaaba0a 2021-10-04T22:28:56 Translator: Fix uniform/struct separation for anonymous arrays When a uniform array of anonymous structs was separated into a struct declaration and uniform array, the uniform symbol was being replaced, but not the intermediate nodes that index it. This caused an AST validation error. Bug: angleproject:4740 Change-Id: Ib9d0115bd01c39d1a007f644e46b5e35c12c9304 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3204590 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Shahbaz Youssefi 27a98cf4 2021-10-04T23:39:16 Vulkan: Allow debug labels inside render pass Debug groups and events were previously recorded to the outside-RP command buffer. With this change, they are inserted in the RP command buffer if render pass has started, or outside-RP command buffer otherwise. This creates a more accurate view of groups the application creates. Bug: angleproject:4597 Change-Id: If165bb88e3e66219bad2fe4acc1cc4653c97fb1b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3204591 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Ian Elliott <ianelliott@google.com>
Shahbaz Youssefi dde409be 2021-10-04T22:05:47 Translator: Produce error on func(void, int) If void is specified, another parameter cannot follow. This change ensures that this produces an error. Bug: angleproject:6338 Change-Id: I18602ea4b52c96e498f4f2dc627d4ba2210d6fa7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3203795 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 18aa5d22 2021-10-05T08:40:48 dEQP 3.1: Lift NVIDIA/Win/GL expectation. Should be fixed on the bots now. Bug: angleproject:1665 Change-Id: I70431434ac57dae3330c486d42b964b94a237491 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3205796 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 234ebd58 2021-10-05T08:34:12 Lift old AMD/Win/GL expectations. No longer tested on the bots. Bug: angleproject:1643 Change-Id: I5e1ca8b9c2f673ebcb44c67879829f9fd346edf0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3205795 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 831f017e 2021-10-05T08:05:52 Lift AMD desktop GL DrawBuffersTest expectations. We no longer test on this config. Bug: angleproject:1533 Bug: angleproject:1535 Change-Id: Iba45a9426ba316e5c83f4501918070f6439daae9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3205793 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Gert Wollny d4d4808f 2021-10-04T18:15:04 Capture/Replay: Update more expectations and add bugs Bug: angleproject:6180 Bug: angleproject:6221 Bug: angleproject:6286 Bug: angleproject:6425 Bug: angleproject:6510 Bug: angleproject:6511 Bug: angleproject:6512 Bug: angleproject:6513 Bug: angleproject:6521 Change-Id: If360279bfb1d6f9a1cb3be336e85b29f64b580c8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3200615 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Jamie Madill 9a455825 2021-10-05T07:51:31 dEQP: Enable Android mipmap tests on GLES. These should be running correctly on the Pixel 4. Bug: angleproject:1529 Change-Id: Ieb55b63d8934d8dd2c516c0f1ce71e84584d4471 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3205791 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill f85ec039 2021-10-05T07:42:41 Lift failing Android expectations. These failures were related to the N5X. Bug: angleproject:1488 Change-Id: I57b8fdeb914a8e33793b0cd011255205baf7858f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3205790 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill a49394ae 2021-10-04T16:30:58 Lift failing Android test expectations. These were in the fbo.completeness.renderable.texture group. Bug: angleproject:1487 Change-Id: I96f7e4428ebe4e018bdaee7f4ba5fd3bba131405 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3203210 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Gert Wollny f00f1009 2021-09-30T18:59:25 Capture/Replay: Fix readback of zero-sized renderbuffers Only read back the renderbuffer content if the renderbuffer has a non-zero size. Add a test to test the capture/replay in this case. Bug: angleproject:6425 Change-Id: I943804884f18a3a2b9de526309dd500de9dd6fd4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3197572 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Geoff Lang ad8e4d99 2021-09-28T11:48:46 Remove EGL_ANGLE_flexible_surface_compatibility This extension has been superseded by EGL_KHR_no_config_context. Bug: chromium:1253930 Change-Id: Ie299c34baa84e9f47c73ddb5a0636536bf510d72 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3190612 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Tim Van Patten 58626b82 2021-10-04T13:01:17 Vulkan: Enable BlitFramebufferANGLETest tests The following tests were disabled for the Vulkan backend, but appears to now be working locally: BlitFramebufferANGLETest.MultisampledBGRAToRGBA BlitFramebufferANGLETest.MultisampledRGBAToBGRA Bug: angleproject:4694 Test: BlitFramebufferANGLETest.MultisampledBGRAToRGBA Test: BlitFramebufferANGLETest.MultisampledRGBAToBGRA Change-Id: Icd88c484fbbbe65561634e97df43c51841d61c10 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3198402 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
YuxinHu a44197b5 2021-09-30T17:21:21 Tests: Add Mini World Creata Trace Vulkan test failed on Pixel4XL due to a vulkan validation layer error VUID-vkDestroyBuffer-buffer-00922. As a temp work around, I add a condition in TracePerfTest.cpp to skip the vulkan test on Qualcomm GPU Test: angle_perftests --gtest_filter="*mini_world*" Bug: b/194508684 Bug: angleproject:6443 Change-Id: I382b9dfc9aafeed92b89223214d8a4aeb75425a7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3195194 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Mateusz Przybylski 076366cc 2021-10-01T23:42:04 Revert "VertexArray: Don't syncState on Buffer map/unmap." This reverts commit 3d429f597fde950e789ca3684abbabd540157773. Reason for revert: This change is causing crashes in ANGLE stack. Original change's description: > VertexArray: Don't syncState on Buffer map/unmap. > > Map/unmap calls are now treated like contents change events. Similar > to BufferSubData calls. > > Bug: angleproject:6371 > Change-Id: Ie0a4c521ffdedfa723d47eddd21c6f68dde044ac > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3187811 > Commit-Queue: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Tim Van Patten <timvp@google.com> Bug: angleproject:6371 Change-Id: I57480a18f3c70a1bf2a539e3047402c71802655d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3200288 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Gregg Tavares fca9de6f 2021-09-29T14:59:06 Fix Metal backend not clearing stencil buffer If you had a depthstencil buffer the stencil portion was not being cleared. Bug: angleproject:6389 Change-Id: Iad3f12ae627bc12625d959f9a52fdb1dcb8c9bc3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3198800 Commit-Queue: Gregg Tavares <gman@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Kyle Piddington <kpiddington@apple.com>
Shahbaz Youssefi 32d6e806 2021-09-24T23:50:54 Vulkan: Fix rotation of interpolateAtOffset interpolateAtOffset's offset was multiplied by flipXY*rotationMatrix, which is a vector. This was unable to actually apply rotation to the offset. The multiplier is changed to a matrix. Can be tested by running interpolate_at_offset*default_framebuffer tests in deqp gles3.1 together with pre-rotation: ./angle_deqp_gles31_tests --deqp-case=dEQP.GLES31/functional_shaders_multisample_interpolation_interpolate_at_offset_no_qualifiers_default_framebuffer --emulated-pre-rotation=90 Bug: angleproject:5843 Change-Id: I9727371375e999f07463b69153df3fd8b28c2a71 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3183108 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Kenneth Russell da3db87e 2021-07-06T14:00:58 Upstream latest changes to Metal backend from Apple to 7/1/2021 This CL merges in the ANGLE changes between these two WebKit commits: https://git.webkit.org/?p=WebKit.git;a=commit;h=8648b353ab1d7730438c2e08319e1a4d64982c31 https://git.webkit.org/?p=WebKit.git;a=commit;h=166e4924a52971d6a32ad48247a439b16c00e062 Include provoking vertex buffer out of bounds fix from https://bugs.webkit.org/show_bug.cgi?id=230107 Fix bad merge of resetting of dirty bits, breaking DepthStencilFormatsTest.DepthTextureRender test and perhaps others. Disable GL_APPLE_clip_distance when the direct-to-Metal compiler is active. It can not yet handle the gl_ClipDistance array. Disable use of rectangular textures for IOSurfaces. Metal can bind IOSurfaces to 2D textures, and this was passing all tests in the SPIR-V Metal backend. Introducing rectangular textures breaks the SPIR-V Metal backend, and the tests currently fail on the direct-to-Metal backend. Fix several bugs with ProvokingVertex, which was causing both the SpirV and Direct backends to incorrectly draw indices. (https://bugs.webkit.org/show_bug.cgi?id=230107) Skip the following tests on the Metal backend which is still failing RobustResourceInitTestES3.BlitDepthStencilAfterClearBuffer GLSLTest_ES3.GLVertexIDIntegerTextureDrawArrays/ES3_Metal With these changes, angle_end2end_tests again runs to completion. Bug: angleproject:6395 Change-Id: I3cc58f531426a95fc8f177a4ad87f56c1855a546 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3167010 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kyle Piddington <kpiddington@apple.com>
Shahbaz Youssefi 2a8be9de 2021-10-01T01:26:19 Vulkan: OES_shader_multisample_interpolation is now conformant This extension was not conformant due to an imprecision in the GL spec which is now rectified. See: https://gitlab.khronos.org/opengl/API/-/issues/149 The OpenGL CTS has been fixed here: https://gerrit.khronos.org/c/vk-gl-cts/+/7862 Bug: angleproject:6190 Change-Id: I0c37332939f70291a5f76ca36fa9f24b179ce414 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3197513 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi a097ee2e 2021-09-27T15:18:02 Vulkan: Fix clearing external images with emulated format External images may already have data, and clearing them due to their format being emulated is incorrect. This change makes sure that only the emulated channels are cleared. The RGBXDataPreservedAHB test is based on one contributed by Jason Macnak <natsu@google.com>. Bug: b/192315789 Change-Id: Ibc8953fdac356f2a62a5b46512a51e1916b4a1b6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3193416 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Jamie Madill 0004ecc2 2021-09-22T13:39:55 Write GL info to test artifact in end2end_tests. These will show up as glinfo.json in the "cas outputs" of the shard that runs these tests. We currently have information for Pixel 4, NVIDIA and Intel Win/Linux, and SwiftShader Windows. GLES 1.x extensions are treated separately. Some WebGL/Mac-only/D3D-only extensions show as unsupported anywhere. In order to capture artifacts on Android, we use a render test output parameter. Bug: angleproject:6379 Change-Id: I560b219b5a586cdbb68d272090f38eedc76aba20 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3176780 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Jamie Madill 3d429f59 2021-09-27T14:27:31 VertexArray: Don't syncState on Buffer map/unmap. Map/unmap calls are now treated like contents change events. Similar to BufferSubData calls. Bug: angleproject:6371 Change-Id: Ie0a4c521ffdedfa723d47eddd21c6f68dde044ac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3187811 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Jamie Madill cf8c5678 2021-09-17T13:16:36 Vulkan: Don't sync VAOs after BufferSubData calls. We still need to syncState after buffers that contain converted attributes are updated. Includes a perf regression test. Bug: angleproject:6371 Change-Id: I54227fc43e7b3fe79072da7783dab0177ccb0486 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3182706 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill b930b9d3 2021-09-08T09:08:28 Capture/Replay: Remove redundant "capture" from label old: trex_200_capture_context1_frame001.cpp new: trex_200_context1_frame001.cpp The 'capture' word wasn't really adding any useful information. Take it out so the filenames are a bit shorter. Bug: angleproject:5133 Change-Id: Ibd7d47df2aa1f24a641c5d5b2a6dd14d6ce240e1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3149370 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi a78310ee 2021-09-29T12:37:42 Clean up ImageTest.cpp Removed manual gen/delete calls and replaced GLuints with RAII types. Bug: b/192315789 Change-Id: Ic2e7f3fcc3cefe83917d3b8dcc4ec2979c732b21 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3193415 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Gregg Tavares 85de22fd 2021-09-29T13:27:42 Set the viewport missing from a few tests A few places seem like they should be setting the viewport. Bascially any place that creates a framebuffer that's different size than the backbuffer (defined as kWidth, kHeight) should probably be setting the viewport. Bug: angleproject:6394 Change-Id: Iee64f6700e3f93c236ab46d3d5debd47c49d2fa0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3195054 Commit-Queue: Gregg Tavares <gman@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Alexis Hetu 4647e4c5 2021-09-27T17:03:05 SwANGLE copy to IOSurface This CL performs a buffer to image copy on bindTexImage and an image to buffer copy on a releaseTexImage on MacOS in order to copy from/to an IOSurface which has an arbitrary internal layout. It also changes the internal format used by GL_BGRX8_ANGLEX to GL_RGBX8_ANGLEX in order to have an internal format which accurately represents the {GL_RGB, GL_UNSIGNED_BYTE} format with the color channels in the correct order. Bug: chromium:1209250 Bug: angleproject:4369 Change-Id: I62b66c7055f8ba8a4c943abeb2e35a3825efc392 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3169472 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Brandon Schade 84bf49a5 2021-09-27T15:20:22 Vulkan: Fixed an issue with primitives generated query The primitives generated query does not work with rasterizer discard, as such rasterizer discard is disabled with the beginQuery call and re-enabled with the endQuery call. The issue is that previously rasterizer discard was not being disabled until ContextVk::resumeRenderPassQueriesIfActive in some cases. This led to cases where primitives generated query did not work. The fix is to insure all beginQuery calls disable rasterizer discard when primitives generated query is active. Added the following end2end test to cover the failure: TransformFeedbackTestES32.MultiPrimitivesGeneratedVsRasterizerDiscard Bug: angleproject:5557 Tests: KHR-GLES32.core.tessellation_shader.tessellation_invariance.invariance_rule* Change-Id: I7e1a0a0bc4a3100349c2c5dbdbe6becd1e0dda29 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3193100 Commit-Queue: Brandon Schade <b.schade@samsung.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 30878d2a 2021-09-24T09:23:56 Buffer: Notify contents changed in a separate observer list. Buffer contents changed will only notify VertexArray. Also this list is separated from the other observers because in the future most of the time we won't need to notify the VertexArrays when buffer contents changed, to avoid iterating over a large list of VertexArray observers on simple SubData calls. Bug: angleproject:6371 Change-Id: I6142a5757868caf33dc6594a1975f817f80553e8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3182701 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Gregg Tavares 696f8533 2021-09-28T15:21:51 fix GLSLTest_ES3.GLVertexIDIntegerTextureDrawArrays The test was using a gl_PointSize of 1000.0 but GL_POINTS are only required to support a max size of 1.0 Bug: angleproject:6463 Change-Id: I8a44607085583cbc7cef06f21b118121cc1fef24 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3192177 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Gregg Tavares <gman@chromium.org>
Gregg Tavares 394dc64d 2021-09-27T14:07:32 Change this expectation to skip on AMD only This appears to be an AMD only issue Bug: angleproject:6387 Change-Id: I596341ed3d4b655312abfaa8b8e768fea742074b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3192173 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Gregg Tavares <gman@chromium.org>
Ian Elliott dff5c752 2021-09-28T11:27:06 Suppress VVL error: *InterfaceTypeMismatch Suppress VVL error: UNASSIGNED-CoreValidation-Shader-InterfaceTypeMismatch Bug: angleproject:6442 Change-Id: I1d5412a1be7cba0b3571225d3f3d94c72349742f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3191390 Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Ian Elliott <ianelliott@google.com>
angle-autoroll 8f8ca06d 2021-09-06T10:01:37 Roll vulkan-deps from b1e5bf7dd9c3 to 788a2f62acbe (13 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/b1e5bf7dd9c3..788a2f62acbe Changed dependencies: * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/51d8e7be94..c2500e504d * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/789de0dc4b..7e860e3831 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/ee4d7bb1bf..20cf221e72 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/cf9d49e461..642da192c8 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/2fdf7a587b..1e6ed74d5d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:6442 Tbr: ianelliott@google.com Change-Id: Id6bcd349462f7c0a61fcb3ccf831e5238334382d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3188612 Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Ian Elliott <ianelliott@google.com>
angle-autoroll 5b699b4b 2021-09-20T15:14:42 Roll VK-GL-CTS from 7103920041db to 8e89717bf4ed (52 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/7103920041db..8e89717bf4ed 2021-09-20 gleese@broadcom.com Add missing checking of integer dot product features 2021-09-20 gleese@broadcom.com Don't silently drop features that were requested 2021-09-20 gleese@broadcom.com Update checking of VulkanFeatures structs 2021-09-17 quic_mnetsch@quicinc.com Merge vk-gl-cts/opengl-es-cts-3.2.7 into vk-gl-cts/master 2021-09-17 mikko.tiusanen@siru.fi Tests for OpenGL ES 3.1 and 3.2 compressed formats 2021-09-17 siglesias@igalia.com dEQP-VK.subgroups.*ray_tracing* missing extension check 2021-09-17 ari.suonpaa@siru.fi Re-enable protected memory tests 2021-09-17 rgarcia@igalia.com Depth/Stencil descriptor tests 2021-09-17 piotr.byszewski@mobica.com Test multiview with different depth ranges 2021-09-17 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/master 2021-09-16 root@qnegfx2.qualcomm.com Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/master 2021-09-14 piotr.byszewski@mobica.com Test blitting from ASTC formats 2021-09-14 gleese@broadcom.com Fix workgroup memory tests for int16s 2021-09-14 ari.suonpaa@siru.fi Check support for EGL 1.5 or higher when using GLES3 2021-09-14 gleese@broadcom.com Accept NaN as valid in atan2 precision tests 2021-09-10 peter.kohaut@arm.com Update Vulkan headers 2021-09-08 mika.vainola@siru.fi Fix Clang -Wcomma warnings 2021-09-08 mika.vainola@siru.fi Fix qpReleaseInfo generation with non-ASCII paths 2021-09-08 ari.suonpaa@siru.fi Add tests for VK_EXT_load_store_op_none 2021-09-07 peter.kohaut@gmail.com Merge branch 'vulkan-cts-1.2.7' 2021-09-07 stuart.brady@arm.com Add tests for VK_KHR_shader_integer_dot_product 2021-09-03 peter.kohaut@arm.com Merge branch 'vulkan-cts-1.2.7' 2021-09-03 mika.vainola@siru.fi Remove unreachable breaks 2021-09-03 antto.makinen@siru.fi Add a batch of GraphicsFuzz coverage tests 2021-09-03 mika.vainola@siru.fi Fix GLES3 Clang UBSan errors 2021-09-02 antto.makinen@siru.fi Add a batch of GraphicsFuzz coverage tests 2021-09-02 juha.heiskanen@siru.fi Add test for finding unknown memory property flag sets 2021-09-02 mika.vainola@siru.fi Fix loop over cube map faces in GL4 2021-09-02 lionel.g.landwerlin@intel.com Fix fragment shading rate validation layer warning 2021-09-02 jari.komppa@siru.fi Add run mode that verifies amber requirements 2021-09-02 mika.vainola@siru.fi Remove extra semicolons 2021-08-30 gleese@broadcom.com Fix warning in gcc-8 2021-08-28 juha.heiskanen@siru.fi Enable Vulkan matrix determinant and inverse precision tests 2021-08-26 jasuarez@igalia.com Do not overflow when copy data 2021-08-26 Neslisah.Torosdagli@amd.com Issue in serial storage address computation 2021-08-26 antto.makinen@siru.fi Add coverage for sampling a cubemap that has been rendered to 2021-08-20 galazin@protonmail.com Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/master 2021-08-20 venni.ihanakangas@siru.fi Check support in synchronization operation tests 2021-08-20 slawomir.cygan@intel.com Read stencil aspect from image in DEPTH_ATTACHMENT_STENCIL_READ_ONLY_OPTIMAL layout 2021-08-20 ilkka.saarelainen@siru.fi Optimize image clearing tests 2021-08-20 venni.ihanakangas@siru.fi Ensure that destroying old swapchain has no effect 2021-08-20 marcin.zajac@mobica.com Conservative rasterization with SampleMask 2021-08-19 galazin@protonmail.com Update Vulkan headers 2021-08-19 italonicola@collabora.com Implement getProcAddress for surfaceless platform 2021-08-19 tapani.palli@intel.com Fix for the various multisample tests with GL 4.5 2021-08-19 tapani.palli@intel.com Fix to multisample texture test shaders with GL 4.5 2021-08-19 tapani.palli@intel.com Fix for the common function tests with GL 4.5 2021-08-13 alexander.galazin@arm.com Remove shaders.arrays from the Khronos mustpass 2021-08-13 ilkka.saarelainen@siru.fi Fix Android system memory requirements 2021-08-13 piotr.byszewski@mobica.com Test multiViewport with different depth ranges 2021-08-13 piotr.byszewski@mobica.com Test OpImageQueryLod when fwidth(UV) == 0 2021-08-13 alexander.galazin@arm.com Merge vk-gl-cts/github-master into vk-gl-cts/master If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC geofflang@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:6441 Change-Id: Ifc95da798a2d6de0a794cef59ea61fb6a353f21d Tbr: geofflang@google.com,angle-bots+autoroll-info@google.com Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3188073 Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
Shahbaz Youssefi bc8fe7dd 2021-09-24T22:50:32 Translator: Fix removing inactive output vs SH_INIT_OUTPUT_VARIABLES The code that SH_INIT_OUTPUT_VARIABLES adds for inactive outputs is also removed with this change. Bug: chromium:1253016 Change-Id: I3caeb628487354de943f7b53f7462f58baa3eca8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3183107 Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 93911990 2021-09-24T12:14:33 Add regression test for PBO write to vertex buffer. There was no test coverage for the "packBuffer->onDataChanged()" call in Framebuffer::readPixels. Bug: angleproject:6371 Change-Id: Ib7ccf965a2375077046e21949dc26dc800abff09 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3182700 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Gert Wollny 55690b1c 2021-09-20T17:06:31 Capture/Replay: Updated expectations: one fixed, one skip Bug: angleproject:6324 Bug: angleproject:6180 Change-Id: I8537e684e63c2000bb877b585f9d8e9be42546f5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3169657 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Gert Wollny 29c01d51 2021-09-20T20:49:29 Capture/Replay: Write the context serialization file correctly This is what was done before we switched to not changing the working directory, and what is expected by the test script. In addition, the captured contexts were also written to the wrong files, i.e. the replay context to the CapturedContext file, and the captured context to file ReplayedContext file, so fix that too. Bug: angleproject:6412 Change-Id: I81906e3f64b2caf0002ca6a28cfce2a3d552fc8f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3171354 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Lubosz Sarnecki 9994110b 2021-09-09T15:29:13 Tests: Add Nier Reincarnation trace. Requires EGL_KHR_gl_colorspace and GL_KHR_texture_compression_astc_ldr. Test: angle_perftests --gtest_filter="*nier_reincarnation*" Bug: angleproject:6366 Change-Id: Ibb71520762cf9c0a17047324557e70215754bbbb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3151818 Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Lubosz Sarnecki e024635d 2021-09-10T13:56:28 ANGLEPerfTest: Skip tests when missing color space support. Make tests where a non-linear colorspace was requested on platforms that do not support EGL_KHR_gl_colorspace non-fatal. Add a initializeGLWithResult function to GLWindowBase, returning a new GLWindowResult enum and wrap it in EGLWindow and WGLWindow. Bug: angleproject:6366 Change-Id: Ib57327c4d988d82064272f229f8ad59287541623 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3151833 Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi eb1d5ca5 2021-01-29T15:34:49 Vulkan: Enable sync validation Based on a change by tobine@google.com Bug: angleproject:5290 Change-Id: Ieae1be5a29f0dcb3ea8aaa04e77fc402380a08b1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3171432 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Gregg Tavares d71dc819 2021-09-22T16:01:06 Fixes for RowMajor test failures row_major matrices get translated to column major matrices and the expressions rewritten. To do this temporary variables that contain the column and row index expressions are moved to separte statements before the matrix expression itself. When this happens it breaks side effects and short circuits in the expression. The solution is to call SeparateCompoundExpressions before calling RewriteRowMajorMatrices. Bug: angleproject:6386 Change-Id: I4d819ade959e2a875495f62733e11d86560d3fab Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3177337 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Gregg Tavares <gman@chromium.org>
Peter Kasting 4f2b2995 2021-09-23T09:50:46 Fix -Wshadow. This still disables the warning for glmark2 instead of fixing it, to avoid needing to upstream a patch. Bug: chromium:794619 Change-Id: Ice602996041d6090c9b09ee81c8ed095c4fa6b2e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3179860 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi e1a9af6a 2021-09-20T10:42:03 Translator: Fix HLSL vs for loop's init not having initializer The handleExcessiveLoop code expected that if a for loop has an init expression that it must necessarily have an initializer as well. That is not true in (fuzzer-produced) code such as following: for (int i; ...; ...) Bug: chromium:1238182 Change-Id: Id761e937a34a6b2feac1266e22207350a3bd616c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3170114 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Jamie Madill 3e234e24 2021-09-17T11:45:01 PerfTests: Updates to several tests. Bug: angleproject:6371 Change-Id: If71c79fd363f7463098b571550af6ceb0634c00d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3176440 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Tim Van Patten 92f1eb7b 2021-09-22T16:57:01 Skip Linux+AMD ComputeShaderTest test failures The following tests are failing on Linux w/ RX 5500 XT: ComputeShaderTest.ImageBufferMapWrite/ES3_1_OpenGL ComputeShaderTest.BufferImageBufferMapWrite/ES3_1_OpenGL These tests were added as part of: 3146319: Vulkan: Add ResourceWrite to track Read and Write Access https://chromium-review.googlesource.com/c/angle/angle/+/3146319 They are being suppressed since it's only the OpenGL backend that's failing this combination, and the ANGLE changes in the CL were only in the Vulkan backend. Bug: chromium:1252169 Test: ComputeShaderTest.ImageBufferMapWrite/ES3_1_OpenGL Test: ComputeShaderTest.BufferImageBufferMapWrite/ES3_1_OpenGL Change-Id: I607979979814327eda9f3823ae3c774b86e94c2f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3177071 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Tim Van Patten <timvp@google.com>
Jamie Madill c3e0eafa 2021-09-22T13:35:04 Revert "Perf Tests: Split samples into sub-tests on desktop." This reverts commit 90c981dafc06d6bc0696749dface1337e37784d2. Reason for revert: Causing timeouts on perf bots. Original change's description: > Perf Tests: Split samples into sub-tests on desktop. > > This adds an option to the perf test runner to split each sample of > each test into a sub-test. The sub-tests then are split among the > shards like ordinary tests, and distributed across machines. The > intent is that running on different machines will reduce inter-build > variance because of differences between test machines. > > This sampling change is only added to desktop (Linux/Win) because > Android device variance seems to be lower. > > Bug: angleproject:6090 > Change-Id: I4046a012727baa8a0f2595de2349cc34257691f9 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3152752 > Commit-Queue: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Cody Northrop <cnorthrop@google.com> > Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Bug: angleproject:6090 Change-Id: I92bffb98999f35274ec31a3b7567d87453feff94 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3174274 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Tim Van Patten 68c0da83 2021-09-15T12:00:08 Vulkan: Inform frontend when new buffer is allocated When a buffer is mapped with GL_MAP_INVALIDATE_BUFFER_BIT while it's currently in use, the Vulkan backend will allocate a new buffer, map it, and return the pointer to the new buffer. This was missing a call to inform the frontend that a new buffer was allocated, causing the old buffer data to be accessed in subsequent draw calls. The fix is to add a onStateChange(angle::SubjectMessage::SubjectGhosted) call when the new buffer is allocated, to inform the frontend. Bug: angleproject:5971 Bug: angleproject:6396 Test: TextureBufferTestES31.MapTextureBufferInvalidateThenWrite Change-Id: I9984d1049ab4d6a2066f4440fc710c9b93ff6ab8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3163244 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Tim Van Patten 9158436e 2021-07-31T18:26:16 Vulkan: glMapBuffer(): Create new buffer (Buffer Ghosting) When glMapBuffer() is called, if the buffer is in use but not being written to by the GPU: 1.) Create a new buffer. 2.) Copy the contents of the old buffer into the new buffer. 3.) Map the new buffer and return the pointer. Creating a new buffer prevents ending the renderpass and flushing the commands to allow the in-use buffer to be mapped. This change increases Idle Heroes performance from 40FPS to 125FPS. Bug: angleproject:5971 Test: VulkanPerformanceCounterTest.MappingGpuReadOnlyBufferGhostsBuffer Test: BufferDataTest.MapWriteArrayBufferDataDrawQuad Test: BufferDataTest.MapWriteArrayBufferDataDrawArrays Change-Id: I1d433d179f9f5110a948f191c5aedda5397acac8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3065799 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Tim Van Patten 57d59e83 2021-09-07T17:41:11 Vulkan: Add ResourceWrite to track Read and Write Access vk::Resource currently only tracks accesses in general, not which type of access is being performed. This CL adds the new class ResourceWrite to track whether the access is a Read or Read/Write access and when the access completes. This allows a follow-on CL to know when a buffer is being written to by the GPU or if the GPU is only reading from a buffer. Tracking write accesses to buffers is required when attempting to "Ghost" (duplicate) GPU-read-only buffers to prevent breaking the render pass when the CPU maps the buffer memory. Bug: angleproject:5971 Test: ComputeShaderTest.ImageBufferMapWrite Change-Id: I965e3e75730719ccce77334744ae4feae33c6101 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3146319 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Kyle Piddington 7dd2361b 2021-09-17T15:43:22 Metal: ANGLE Metal AutoObjCPtr == nullptr comparison is inverted Port the fix from Webkit for this inverted comparsion Unify the nullptr type throughout all functions Bug: angleproject:6351 Change-Id: Id856af31c9eea5cc79993c3454e452d1c14d0d0e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3169436 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Le Hoang Quyen <le.hoang.q@gmail.com> Reviewed-by: Gregg Tavares <gman@chromium.org>
Kyle Piddington f6616c71 2021-09-14T17:42:22 Reimplement transform feedback on direct-to-Metal backend Connect the Transform Feedback code generation from Webkit ANGLE to the shader specialization code. Bug: angleproject:6393 Change-Id: I090c44c6ee97e8e0af8c38433bfb74c2080784f9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3161455 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Gregg Tavares <gman@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org>
Jamie Madill 3666f00f 2021-09-20T16:20:50 GN: Remove the "no GTest" dEQP targets. These were unused and removing them cleans up the VS projects. Bug: None Change-Id: I1e1787ad1ceac15ecc88d9338e65b3072496066d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3173251 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Kyle Piddington 59d31ea6 2021-09-17T17:43:13 Metal Direct: TinyDepthStencilWorkaroundTest.DepthTexturesStick Change code to rewrite attributes by searching for both the standard, and rewritten name. We will match with any vertex attribute variables that experienced a renaming during shader processing Bug: angleproject:6388 Change-Id: Ia6f5b87092990e9df42f1dbb87a8bf393ba50c4c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3169438 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Kenneth Russell <kbr@chromium.org>
Jamie Madill 90c981da 2021-09-10T11:04:19 Perf Tests: Split samples into sub-tests on desktop. This adds an option to the perf test runner to split each sample of each test into a sub-test. The sub-tests then are split among the shards like ordinary tests, and distributed across machines. The intent is that running on different machines will reduce inter-build variance because of differences between test machines. This sampling change is only added to desktop (Linux/Win) because Android device variance seems to be lower. Bug: angleproject:6090 Change-Id: I4046a012727baa8a0f2595de2349cc34257691f9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3152752 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 9184973f 2021-07-21T08:28:30 Add GetCompressedTexImageANGLE to ANGLE_get_image Includes front-end support for reading back compressed texture images. Back-end support is incomplete and will be implemented in a future CL. CL authored by cnorthrop@google.com. Bug: angleproject:6177 Change-Id: I1482b15e5ffec6120f09f51b2718cdbef07c93c8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3163359 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi 46149c0e 2021-09-17T15:38:47 Translator: Fix pruning functions that declare a struct When pruning unused functions, the entire declaration of the function is removed. If the function declares a struct as part of its return value, the declaration of that struct was lost. This change makes sure that declaration survives the pruning. For example: struct S { vec4 v; } unused_func() { ... } is now replaced with: struct S { vec4 v; }; This change also makes struct usage validation more stringent. Bug: chromium:1248753 Change-Id: Idd9a87fd2e785135775cfea62995fd33adaf3c09 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3169691 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Gert Wollny 1ae79810 2021-09-16T08:47:20 Capture/Replay: Update expectations and add bugs Bug: angleproject:6314 Bug: angleproject:6334 Bug: angleproject:6399 Bug: angleproject:6400 Change-Id: Ibf1e747080bcbf482e399db18c1f14e8af61fd26 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3162438 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Tim Van Patten c85d9a19 2021-09-07T11:41:10 Destroy all unreferenced Contexts resources during terminate() When eglTerminate() is called, all of the Contexts that the Display owns need to be destroyed if they are not referenced by (current to) any Threads. This also requires a change to Display::releaseContext(), to remove the recursive call to Display::terminate() that could occur when releasing the Contexts during terminate(). Bug: skia:12413 Test: EGLContextSharingTestNoFixture.EglTerminateMultipleTimes Change-Id: Ibd0a3e22725d29875c4089bdaae47c98e5084f35 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3144146 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Jamie Madill 1af5c46c 2021-09-14T14:40:49 Move JsonSerializer from libANGLE to common. This lets us use the serializer from outside of libANGLE. The plan is to use it to serialize a list of supported extensions from the tests. Bug: angleproject:6379 Change-Id: Ib7b64cca32e733e342b80f893d3752318089f0c2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3163361 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 23b16743 2021-09-14T10:29:14 Fix compilation when disabling D3D back-ends. Common code areas weren't compiling when disabling combinations of the D3D9 and D3D11 back-ends. With manual testing this fixes various combinations of angle_enable_d3d9/d3d11/gl. Bug: angleproject:5925 Change-Id: Ie14f2b4c6169cf96c662e7ae6999751007d9adb0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3162836 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Jonah Ryan-Davis 14539cab 2021-09-16T12:06:09 Suppress failing end2end tests on direct-to-metal/M1 Two tests from UniformBlockWithOneLargeArrayMemberTest fail when using the direct-to-metal backend. Suppress until this is fixed. This CL also adds parsing for the Mac M1 chips to our end2end test expectations. Bug: angleproject:5505 Bug: angleproject:6390 Change-Id: Ia578e4c582f1522eec9e1cb2c499e3e717b67c87 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3164820 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Alexis Hetu 158ef351 2021-09-15T13:40:28 Fix integer overflow in BlockLayoutEncoder BlockLayoutEncoder::mCurrentOffset's computation had the possibility of causing integer overflows in multiple places, so this CL adds CheckedNumeric variables in a number of these occurrences in order to prevent integer overflows and causing issues. The issue in this case was an integer overflow causing the code in ValidateTypeSizeLimitations.cpp to use an invalid result from "layoutEncoder.getCurrentOffset()", which ended up compiling a shader which would later cause an OOM error. Bug: chromium:1248665 Change-Id: I688d669f21c6dc2957e43bdf91f8f8f08180a6f7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3163356 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Gert Wollny 2eba872a 2021-09-15T12:33:34 Capture/Replay: Run binary save/load tests only when supported Bug: angleproject:6325 Change-Id: Ibd4a62f93030cd01b30e8636e7663176a1763119 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3162436 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Gert Wollny 9121a79d 2021-09-14T11:57:32 Capture/Replay: Don't set CWD and pass path information instead With that we avoid complication when evaluating the module path that is used to load the test modules. Fixes: 2f3e4db838068584a0c15653cb07893683a55300 Capture/Replay: Serialize trace metadata to a JSON file. Bug: angleproject:6385 Change-Id: If4e348237d9b0e99e404f49b28dddba1ac50ef92 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3157907 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Tim Van Patten c78ebccd 2021-09-09T16:47:26 Perf: Add _many_tex_draw test Add a new perf test _many_tex_draw, which draws with 8 textures bound. The intent of this test is to stress calls like retain() with various implementations of vk::Resource. Additionally, this CL updates the textures to use format GL_RGBA, rather than GL_RGB, to avoid the emulation step that's required due to the lack of support for the 3 channel format. Bug: angleproject:5971 Test: DrawCallPerfBenchmark.Run/*_many_tex_draw Change-Id: Iffb39b76fab68cc2a76dfd2da38db7e77cb4dac0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3152171 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Tim Van Patten <timvp@google.com>
Gregg Tavares 0cea3fe2 2021-09-15T14:02:47 Suppress more flaky tests Bug: angleproject:5505 Change-Id: I6e77769b36a2cccb22f4048ff4fe47258e58d7c5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3163493 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Gregg Tavares <gman@chromium.org>
Gregg Tavares 085ab6e8 2021-09-09T10:22:04 Turn on Direct Metal tests Bug: angleproject:5505 Change-Id: I8de95f28698785e5467dd82d04cbc7636d6df042 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3152156 Commit-Queue: Gregg Tavares <gman@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Gert Wollny 54e89a1b 2021-09-02T16:48:42 Capture/Replay: handle param reading of glGetUniformuiv Enable the test that was fixed by this. Bug: angleproject:6108 Change-Id: I0bd46a85c2337e3c1a236954c8f131df12c499b5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3140155 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Cheryl Wei e10a4031 2021-09-08T15:57:00 Vulkan: Add a test to triger large VAO dirty bit handling. Some traces bind one VBO to a large number of VAOs,this will cause glBufferData spending a lot of time doing VAO dirty bit handling,which leads to high cpu load in these traces.This test could triger this issue. Bug: angleproject:6371 Change-Id: Iedc6630b497cb0f62ea0129aefc19c717c3ef905 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3147173 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Sunny Sun <sunny.sun@arm.com> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 371542cd 2021-08-23T23:10:09 Vulkan: Use VK_EXT_load_store_op_none With read-only depth/stencil attachments, ANGLE utilizes storeOp=NONE to optimize memory bandwidth (by avoiding write back of tile memory at the end of the render pass). Simultaneoulsy, this avoids a synchronization hazard with the next write to that depth/stencil image. If a framebuffer contains a depth/stencil attachment but it's unused, ANGLE utilizes loadOp=NONE/storeOp=NONE to effectively remove any memory bandwidth wasted on the attachment. Bug: angleproject:5371 Change-Id: I76cbadbf1194041532ac4b690ffe087298f2de51 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3114232 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Hailin Zhang 66886228 2021-09-13T11:58:31 delete a wrong comment delete a wrong comment for test DrawElementsElementArrayBufferMapped Signed-off-by: Hailin Zhang <hailinzhang@google.com> Change-Id: Idc95b50f3fd2ca2da65b090a20f5fdc36605b8e6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3158291 Reviewed-by: Cody Northrop <cnorthrop@google.com>
Hailin Zhang e1befb35 2021-09-09T15:53:32 fix a EXT_buffer_storage issue. According to spec, GL_MAP_PERSISTENT_BIT_EXT indicates that it is not an error for the GL to read data from or write data to an immutable buffer while it is mapped. Bug: b/188685164 Change-Id: I899a978dbf9c1d1ad3489063028fd5500c4bd5e1 Signed-off-by: Hailin Zhang <hailinzhang@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3151278 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Jamie Madill 5650273a 2021-09-07T09:41:59 Capture/Replay: Capture trace file list to JSON. Instead of using a text file, we can use a JSON file to store the list of files in a trace. We can use this list in the GN to pull the trace files directly instead of using auto-generated code. It also consolidates the trace metadata in a single location. Also captures the Windows Surface ID to the JSON file. Bug: angleproject:5133 Change-Id: I236b614f7d0c844e7c4a5276dd6ac5964e5c393d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3144214 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com>
Jamie Madill 7e8fa429 2021-09-08T11:56:45 Capture/Replay Tests: Script cleanups. Minor cleanup changes and removes some outdated parameters. Includes logging information about how much time the script spends running each child process. Bug: angleproject:6102 Bug: angleproject:6299 Change-Id: I0b4da535b858ced3cdc21c341c2c001ffe9c8192 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3149190 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com>
Jamie Madill 247ee1c3 2021-09-10T09:38:25 Perf Tests: Output results in "msBestFitFormat" again. The histogram bins for "ms" would cause excessive rounding for tests that run very quickly. For example, 0.0012354 ms would be rounded to 0.001 ms. This would produce very flat graphs that don't accurately represent the real results. Bug: angleproject:6090 Change-Id: I9293b2083d7e54dc2663648c361f4883278806ec Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3152746 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 0e021199 2021-09-08T12:31:47 Gold Tests: Append "show all results" to triage links. This should allow for easier triage when CL authors run into new images that don't match the goldens. Bug: skia:12428 Change-Id: I60fee615f23f5a1b36ddbe6c6708498fb3def46e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3149571 Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Yuly Novikov 10d6e9b0 2021-09-09T20:39:50 Suppress dEQP GLES3 failures on Mac Intel UHD 630 Bug: angleproject:6376 Change-Id: I10338ca3ec35d301195a04fc15b2148c7b7a5f4a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3152858 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 13e9817b 2021-09-08T11:57:00 Translator: Fix assert in ScalarizeVecAndMatConstructorArgs This transformation assumed that precision can be derived for constants in every possible scenario, but that's not true. The fuzzer produced the following code: void main() { mat4 m; mat2(0, bvec3(m)); } In the above, the constant 0 legimitately has no precision. The assert was in a function that attempted to make a temporary out of the constant, which this commit changes to use the original constant as-is. Bug: chromium:1246781 Change-Id: I6f247264e5213cfd9449fdfb1dc312d02b99f2f1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3149191 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill ac78d723 2021-09-08T12:19:40 Capture/Replay Tests: Allow 3 concurrent ninja processes. This is an attempt to fix the flaky ninja error when running multiple processes while still getting pretty good test times. The previous fix eliminated the flakiness but doubled the test time. In local testing this is a bit slower but not 2x slower. Bug: angleproject:6299 Change-Id: Ibcd462712d3eab759c5923ca229e009046783e9b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3149570 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
kmx.io     mail     discord kmxgit v0.4.0