kc3-lang/angle

Log

Author Commit Date CI Message
angle-autoroll 7de3c91a 2025-07-08T09:45:23 Manual roll Chromium from ecafbee68f76 to 5e47731919d1 (1548 revisions) https://chromium.googlesource.com/chromium/src.git/+log/ecafbee68f76..5e47731919d1 Manual change adds one new DEP for LLVM: llvm-objdump If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/2fbd9aa354..a6f8dde294 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/f7ada7bb31..4f8adf9e3a * third_party/android_build_tools/error_prone/cipd: dFVMo_NVD5IoNgsCTx1nb8lGGNZNmY6xP94EJtjdm3sC..2lYOqu-UyPNYEMX0rO60MpXImuj6kMqnOlVshCO6JLEC * third_party/android_build_tools/lint/cipd: vjJL0xmNT9EN1STXqXADApReB1GtO9U4OjJB03hfZG4C..SprQhm8ND7zXM2ZhH-8EwKeVUJiLGvzpriWfty0071cC * third_party/android_build_tools/manifest_merger/cipd: mVbkvXY9mSO2xflwykvZDKapEa-3YQG4myL5jEizsbEC..nttKi291XL8l3g1B2tNCmfxEtDcCa9tfIghqosYX22oC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/9c0f16eca6..c586b85d4d * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/7b82569dae..8bfd9f2e53 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/abc5109882..0d6837383d * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/02570151a8..33b29ab05d * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/cbedb1dbfa..e18275a956 * third_party/r8/cipd: EuC8PQbsjuCJyQ-BPbcNPedpvZDvZfR4uA5JGDjS6_gC..JPUb5oFXJVCZnmHps_x4jsuJNZzT4zTUYPDo0AsI1K0C * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/95fb7f7986..8bbd6f5553 * third_party/siso/cipd: git_revision:c46a6c9266d0685fa462694be456204ad243c030..git_revision:f96f46a8e4cf30c097110903d4b71516ef976fb6 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/4028ebf871..3102d2a0da * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/79aeafa6ee..93cad36976 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/9659fbf621..4c6ed84d48 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/c761ecc240..f133d28292 No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: Icd44b4254eedee58ad80081748a3f81fa42f4aa5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6715620 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Jeff Vigil 8e9132c3 2025-07-08T15:23:17 Add missing brackets to gl_tests Add missing brackets required for format style Bug: angleproject:430338389 Change-Id: I4757f03c06bc25734c7492284160d04c8c8fd459 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6715884 Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: mohan maiya <m.maiya@samsung.com>
angle-autoroll 8de23ce6 2025-07-09T10:01:43 Roll vulkan-deps from 7c32c6e7a3da to c91d04c5a3ae (9 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/7c32c6e7a3da..c91d04c5a3ae Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/a45e175a45fe2792bf62e3acebcc817fecfc8422..2e24222cd9d19e737f8c790a2f485d5ba0d62166 https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/e1d9499713162ca7053844479d84f73860417d4c..9d0dbe9d59159ac936cdc56f9fc85e001afed183 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/edce8bd5e7275462709d4c6610c0caec5457f678..54fc95232ced45f39348c091f6f95545588e350a https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/ec329e2721921f79743b90307ee047d08e057788..cb20eb451cf2e272daaf40099e864a916d8b5542 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/a5639cedf4d9f6009d11a43865003bb889982d5e..2991293a9a1d1d3a9d87d7737dbe812252c1fb40 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I826c95da0f8c78ff26a80f2b295a12cb6fcc7120 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6718293 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya d44244ca 2025-07-03T11:36:37 Vulkan: Simplify default uniform WriteDescriptorDescs ProgramExecutableVk fully encapsulates interaction with DescriptorSetDescBuilder with https:://crrev.com/c/6702410 which allows us to keep WriteDescriptorDescs members private. Remove mDefaultUniformWriteDescriptorDescs and reuse mDefaultUniformAndXfbWriteDescriptorDescs for both emulated and extension based XFB codepaths Bug: angleproject:426412564 Change-Id: Icf76440b6efbda93eb8d48c36591a99ccd1a5750 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6705152 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 735c345a 2025-07-09T08:01:19 Roll VK-GL-CTS from a7dbc48b7b02 to 46724b178e40 (5 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/a7dbc48b7b02..46724b178e40 2025-07-08 lorenzo@khronosgroup.org Add JSON for VK_KHR_surface_maintenance1 2025-07-08 lorenzo@khronosgroup.org Add JSON for VK_KHR_present_mode_fifo_latest_ready 2025-07-07 lorenzo@khronosgroup.org Merge remote-tracking branch 'vk-gl-cts/dev/VK_KHR_present_mode_fifo_latest_ready' into main 2025-07-07 lorenzo@khronosgroup.org Merge remote-tracking branch 'vk-gl-cts/dev/VK_KHR_surface_maintenance1' into main 2025-07-07 lorenzo@khronosgroup.org Update external sources (Vulkan 1.4.321) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I10a1e738142b60fc8a2bbb2135a48351a8470cd0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6717685 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya ce289330 2025-07-01T19:41:46 Vulkan: Simplify descriptor set management - Descriptor logic is contained in ProgramExecutableVk and doesn't leak into ContextVk - Reduces CPU overhead by not having to constantly copy and resize the DescriptorSetDescBuilder - Simplifies decoupling of descriptor set of uniform buffers from that of other shader resources Bug: angleproject:426412564 Change-Id: Ic0926d0d466ea21f611c2b2c7b844e0bb9027c1b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6702410 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Neil Zhang 8a9fe208 2025-06-20T16:32:11 Vulkan: Fixed rate compression not work as expected on Android On Android C++ compiler do more optimization and results different with Linux, re-write code to correct the issue. Bug: angleproject:352364583 Change-Id: I1863d2d255cd831d4ca9dd866c85e419f410bd9a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6687014 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Neil Zhang <Neil.Zhang@arm.com> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Jisun Lee 18091004 2025-06-19T16:50:58 GLES1: Skip updating vertex attrib array when binding zero texture Previously, when usecases bind the zero texture, the vertex attrib array was disabled. This made the following bound textures lose the vertex attrib data. In this change, updating vertex attrib array in prepareForDraw() is skipped when the application binds zero texture but does not activate the corresponding texture unit. Also GLES1 tests using zero texture are added to make sure vertex attrib array is enabled correctly. Test: angle_end2end_tests --gtest_filter=DrawTextureTest.* Bug: b/426740680 Change-Id: Ic5aad0a60c9d987edcb1d05cdb6b68dd93eac309 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6659335 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Tim Van Patten 2e9de3c7 2025-07-07T16:58:18 ValidateGetTexLevelParameterBase: Support GL_MEMORY_SIZE_ANGLE ANGLE supports the extension GL_ANGLE_memory_size, which adds the new parameter GL_MEMORY_SIZE_ANGLE. However, the parameter value is not supported in ValidateGetTexLevelParameterBase(), so any calls using it always fail with GL_INVALID_ENUM. The parameter is supposed to be tested by MemorySizeTest.BasicUsageTexture/*, but the portion of the test validating GL_MEMORY_SIZE_ANGLE is never executed because it requires an OpenGL ES 3.1+ context, but the test is only instantiated for GLES 2.0 and 3.0. Based on all the above: 1. Add support for GL_MEMORY_SIZE_ANGLE to ValidateGetTexLevelParameterBase(), requiring GLES 2.0+ and the extension memorySizeANGLE is enabled. 2. Instantiate MemorySizeTest to run on GLES 2.0, 3.0, 3.1, and 3.2, so the entire test is run on devices that support GLES 3.1+ contexts. Bug: b/409384875 Test: angle_end2end_tests --gtest_filter=MemorySizeTest.* Change-Id: I70c5721c5da18cb8edbc9a7e18038d5d9fb486da Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6710993 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll 12fff4bb 2025-07-08T10:01:22 Roll vulkan-deps from ab8b8743ea91 to 7c32c6e7a3da (8 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/ab8b8743ea91..7c32c6e7a3da Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/9d5196d657bdbd06d325790d56d586a3242f52cb..e1d9499713162ca7053844479d84f73860417d4c https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/cc07e5303f1613d8577c2ff61995de39ccc2effd..edce8bd5e7275462709d4c6610c0caec5457f678 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/f0f308ad2cdc2e8fd58985d6230df4a29cc44eb6..06ae73a3dc3a03466817d8370355203dac7b79b1 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/481fd7133a972edc8b59404b6fdf655c6c06b04a..a5639cedf4d9f6009d11a43865003bb889982d5e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Ibb61158338a5b2617c1c91419a8a74a8b42e58ef Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6713729 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Tim Van Patten 825b4062 2025-07-01T17:36:05 tests: Skip ProgramBinariesAcrossPlatforms on SystemEGL+Android ProgramBinariesAcrossPlatforms.CreateAndReloadBinary/* is failing when testing the system EGL on Android. The issue is that the test calls eglWindow->initializeGL(), without checking all of the required extensions are available first. Specifically, it needs the same type of checking that was added to ANGLETestBase with https://crrev.com/c/6622112. Rather than duplicating that work, we should instead find a way to refactor things so both ProgramBinariesAcrossPlatforms and ANGLETestBase can share the implementation. This would also fix the issue that ProgramBinariesAcrossPlatforms cannot be skipped with an entry in angle_end2end_tests_expectations.txt, also due to not inheriting from ANGLETestBase. Due to this, the test needs to be skipped directly within ProgramBinariesAcrossPlatforms::SetUp(), before mOSWindow->initialize() is called (and fails). Bug: b/424595860 Bug: b/429026255 Change-Id: I118a912e871a4693ac529376ddf97c60dd77b1a0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6694919 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Tim Van Patten <timvp@google.com>
angle-autoroll 2466c3ff 2025-07-07T10:01:50 Roll vulkan-deps from 61576f7bb0ed to ab8b8743ea91 (4 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/61576f7bb0ed..ab8b8743ea91 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/44c93ad924b647b0d803ef4c924251c4341b838b..cc07e5303f1613d8577c2ff61995de39ccc2effd https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/42094612240193e0748bb7c19294ca144da4db97..481fd7133a972edc8b59404b6fdf655c6c06b04a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I444a57e11e7b876fd587a51a1f89bcbb2579c516 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6707707 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 8905d531 2025-07-04T16:42:12 Manual roll vulkan-deps from e9520b14c6c9 to 61576f7bb0ed (12 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/e9520b14c6c9..61576f7bb0ed Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/0a2dad5cb501e1d201c62e6f9f6ba86079629829..9d5196d657bdbd06d325790d56d586a3242f52cb https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/16cedde3564629c43808401ad1eb3ca6ef24709a..2cd90f9d20df57eac214c148f3aed885372ddcfe https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/8beef6cb63ffadb02300bf6321b4d3af85ea7417..da8d2caad9341ca8c5a7c3deba217d7da50a7c24 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/f3cfb7fa8994e37c7c0568e33a785591af2ca696..ec329e2721921f79743b90307ee047d08e057788 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/8ee8c17b03f9e66b949fa70245bd3ec6642394df..42094612240193e0748bb7c19294ca144da4db97 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: Ifbdf6cbe17439f405950add24f07210755509e01 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6705155 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov f346ced7 2025-07-03T15:49:41 Fix UninstantiatedParameterizedTestSuite on iOS CopyCompressedTextureTestES32 missed rename in https://chromium-review.googlesource.com/c/angle/angle/+/6648198 Bug: b/419048313 Change-Id: I9c1b64a5625f9cd15b083ff6a0827c069752aa5c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6703639 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov a035c7b6 2025-07-03T16:33:11 Fix rolling to Android after googletest update Because of changes in googletest build files, re2 must be rolled into Android as well. Bug: angleproject:428697844 Change-Id: I3960cccf7cca808b8e4cc2d5f0def030a57f956f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6705237 Commit-Queue: Geoff Lang <geofflang@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Yuly Novikov 619e8bf8 2025-07-03T15:36:30 Skip MultisampleDepthStencilResolveSeparately on Pixel 6 Already skipped on Pixel 4. Fails on Pixel 6 Android 14. Bug: angleproject:42266019 Change-Id: I5e1dfd805b48d59c68e28e07a2d6e4f58653c27c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6702483 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Kramer Ge 52005af1 2025-07-02T16:11:30 Define angle_use_gbm=false when !angle_has_build angle_use_gbm is not defined when !angle_has_build. This causes build to fail. Define it to false in this case. Bug: angleproject:425569857 Change-Id: I8ba66f528b3052725467aeafe046900ec06b8989 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6701310 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Kramer Ge <fangzhoug@chromium.org>
angle-autoroll 5c8e4e48 2025-07-03T10:01:32 Roll vulkan-deps from a1b7197600d4 to e9520b14c6c9 (10 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/a1b7197600d4..e9520b14c6c9 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/8a85691a0740d390761a1008b4696f57facd02c4..a45e175a45fe2792bf62e3acebcc817fecfc8422 https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/cf70be28b43563fb5ffc2681fb3bbe424707b920..0a2dad5cb501e1d201c62e6f9f6ba86079629829 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/04b76709bf40a7ce8df3382060ef3620f19de566..c8ad050fcb29e42a2f57d9f59e97488f465c436d https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/bc7c60e96e141bc55b7099a3d35fb9e0eb1fc801..44c93ad924b647b0d803ef4c924251c4341b838b https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/f216bb107bfc6d99a9605572963613e828b10880..f3cfb7fa8994e37c7c0568e33a785591af2ca696 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/a30de91e1618558a71362e68afa62d7fc6f7ce24..8ee8c17b03f9e66b949fa70245bd3ec6642394df If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I27d47c869caa5a30dc63a20b553381f0b3159c87 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6703228 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Takuto Ikuta 74321385 2025-07-03T14:36:54 Add a missing include for std::pair Bug: chromium:40263312 Change-Id: Id2609c9cae7dedec537cb0d0db130d608166c148 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6701872 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 85a56e89 2025-07-03T03:01:25 Roll SwiftShader from 96a63130d839 to be6ed66fa563 (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/96a63130d839..be6ed66fa563 2025-07-02 swiftshader.regress@gmail.com Regres: Update test lists @ 96a63130 2025-07-02 krzysio@google.com Disable -Wbitwise-instead-of-logical. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: Iac73ac69c312b9edecb634c9267c9ad855e8fde4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6703629 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 9df55d9b 2025-07-03T08:05:24 Roll Chromium from e4e9341de2f7 to ecafbee68f76 (613 revisions) https://chromium.googlesource.com/chromium/src.git/+log/e4e9341de2f7..ecafbee68f76 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/70d5459e6e..2fbd9aa354 * buildtools/linux64: git_revision:97b68a0bb62b7528bc3491c7949d6804223c2b82..git_revision:635a71e20e99db0b08520ca0746b501167a5c7e5 * buildtools/mac: git_revision:97b68a0bb62b7528bc3491c7949d6804223c2b82..git_revision:635a71e20e99db0b08520ca0746b501167a5c7e5 * buildtools/win: git_revision:97b68a0bb62b7528bc3491c7949d6804223c2b82..git_revision:635a71e20e99db0b08520ca0746b501167a5c7e5 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/29d6e4bb40..f7ada7bb31 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/dd86c62796..5254207afe * third_party/android_build_tools/aapt2/cipd: _lNsOL_GGlXLOIMGtrbMOqNd7TQHabaP1q8SlvUpFbMC..QAJPvXRIKAdvDEnn23X7nLv-pZlN3qjPeD_vq4QsYRIC * third_party/android_build_tools/lint/cipd: eWRdzGzH7yQ87tWs3ziVgS5K-hEL5sDdOZgIR2pSduoC..vjJL0xmNT9EN1STXqXADApReB1GtO9U4OjJB03hfZG4C * third_party/android_build_tools/manifest_merger/cipd: QmC9cZkulirpeFoG7WaWIGRovPGsS8sMpycIswB1CwkC..mVbkvXY9mSO2xflwykvZDKapEa-3YQG4myL5jEizsbEC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/63527f0b9e..9c0f16eca6 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/559a8cbd6e..7b82569dae * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/615f4a2f03..abc5109882 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/34e6c8e85a..cbedb1dbfa * third_party/r8/cipd: FXmk4HnrTNsJaRZsLuDZ749YMcCaP-Es0XYIrNMTsfUC..EuC8PQbsjuCJyQ-BPbcNPedpvZDvZfR4uA5JGDjS6_gC * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/c8ffe73cf2..95fb7f7986 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/4f3180cff2..9659fbf621 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/715f296aa6..c761ecc240 No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: I0e9073cb62573cd380e9d81d47647dd580c71241 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6703225 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao 2269011c 2025-06-30T14:08:11 Remove BitSet::to_ulong and BitSetArray::to_ulong BitSet::to_ulong() is a bit redundant with bits(), and has a risk of losing upper bits on windows platform where unsigned long is 32 bit. This CL removes the usage of it and replaced with bits(). BitSetArray::to_ulong() method only captures up to 64 bits, all other bits are dropped silently which is wrong. This CL fix this and serialize it as a vector of uint64_t. BitSetArray::to_ulong() is removed in this CL. Bug: angleproject:42264163 Change-Id: I663b2cdacc0e930ee616e333131e831ec124a9d4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6691283 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Geoff Lang 2f8193ec 2025-06-25T13:17:47 Validate buffers bound for transform feedback are not modified. The ES spec says it is undefined to write to a buffer that is currently being used for transform feedback output but recommends generating an error. Generate INVALID_OPERATION in this case. Bug: chromium:427162086 Change-Id: I727d18c2035509fe2e5d60680eb5198e40a60e33 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6673310 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Charlie Lao 9a05a2b7 2025-06-23T16:24:13 Reland "Vulkan: Avoid some loops in VertexArray::onBufferChanged" This reverts commit 5df85793c602d64d47ef68e29542313be4116bc0. Reason for revert: the regression bug is fixed Some of the functionality related code has been merged into previous CL. This CL now mostly clean up. The old subject/observer code is been deleted from VertexArray. Bug: angleproject:400711938 Original change's description: > Revert "Vulkan: Avoid some loops in VertexArray::onBufferChanged" > > This reverts commit 8d6d127acc1072488e5b57ba4e7e93da2d94bfda. > > Reason for revert: https://issues.chromium.org/427064102 > > Bug: angleproject:400711938 > Original change's description: > > Vulkan: Avoid some loops in VertexArray::onBufferChanged > > > > Before this CL, VertexArray::onBufferChanged() loops over > > bufferBindingMask bits and calls onSubjectStateChange. In this CL, > > VertexArray::onSubjectStateChange is embedded into > > VertexArray::onBufferChanged(). DIRTY_BIT_ELEMENT_ARRAY_BUFFER and > > DIRTY_BIT_ELEMENT_ARRAY_BUFFER_DATA is re-arranged so that we can map > > bufferBindingMask directly to VertexArray::mDirtyBits. This especially > > useful when one buffer is bound to multiple indices in the VertexArray. > > > > This CL also removes angle::ObserverInterface from VertexArray, since it > > no longer observes anything. > > > > ASSERT is added in gl::Buffer::mContentsObservers to ensure it only > > contains BufferTexture, since vertexArray is no longer using the > > subject/observer. > > > > Bug: angleproject:400711938 > > Change-Id: Ie6e7159d7a89f0da5e1b7ca0a9dbe60a1e6c682f > > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6569638 > > Reviewed-by: Geoff Lang <geofflang@chromium.org> > > Commit-Queue: Charlie Lao <cclao@google.com> > > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > > Bug: angleproject:400711938 > Change-Id: I3b8e77db7b3d06b9ed875bfe7787904ac753da11 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6664161 > Commit-Queue: Charlie Lao <cclao@google.com> > Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Bug: angleproject:400711938 Change-Id: If7989b26701dcccbb8e49c42d388c0217e2d0b7f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6663536 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Charlie Lao 2ac49bb6 2025-07-01T12:11:12 Reland "Vulkan: Move VertexArray::ElementBuffer away from observer" This reverts commit 79ac1a8cd767a32cce6401203e20c4bd4ca4d539. Reason for revert: the regression bug is fixed in PS6 The regression bug with the original CL is caused by when we bind a vertex array without element buffer rebind, we missed to reset mIndexRangeInlineCache. The other bug is that VertexArray::mDiryBits is 64 bit but VertexArrayBufferBindingMask is 16 bit, in VertexArray::setDependentDirtyBits(), bufferBindingMask.to_ulong() << DIRTY_BIT_BUFFER_DATA_0 is only producing the 32 bit value on windows platform due to unsigned long is 32 bit value. bits() is used and bit shift is operated on to uint64_t here to avoid dropping high bits on windows. Two tests are added that reproduce the regression bug caused by the original CL. Bug: angleproject:400711938 Original change's description: > Revert "Vulkan: Move VertexArray::ElementBuffer away from observer" > > This reverts commit 3f012a43ee2c101543785720eedfeaa80708479d. > > Reason for revert: https://issues.chromium.org/427064102 > > Bug: angleproject:400711938 > Original change's description: > > Vulkan: Move VertexArray::ElementBuffer away from observer > > > > Right now, VertexArray's element buffer is always observing buffer's > > change. In previous CLs, we have moved vertex array away from > > subject/observer usage. This CL moves element buffer away from > > subject/observer as well. Since the gl::Buffer tracks buffer's binding > > to each context's current vertex array's binding point, > > kElementArrayBufferIndex is added to VertexArrayBufferBindingMask bits > > so that the element buffer is tracked exactly the same as other vertex > > array buffer bindings. The VerextArray code has been modified to handle > > this special bit, since element buffer has its own binding point > > VertexArrayState::mElementArrayBuffer as opposed to > > VertexArrayState::mVertexBindings. After this CL, VertexArray object > > should be completely off subject/observer usages. > > > > Bug: angleproject:400711938 > > Change-Id: I662ddfabc95034bdc7734939c944ab033f41801c > > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6552160 > > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > > Reviewed-by: Geoff Lang <geofflang@chromium.org> > > Commit-Queue: Charlie Lao <cclao@google.com> > > Bug: angleproject:400711938 > Change-Id: I9487ba8b108baaeda1c8a27189dba64f77616774 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6663539 > Commit-Queue: Charlie Lao <cclao@google.com> > Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Bug: angleproject:400711938 Change-Id: I3f47ad1238c41f12b5cbd7a59b84be3fce1e9562 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6664004 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Tim Van Patten de40b6e5 2025-06-06T13:18:09 tests: Add GetEglPlatform() Testing the system EGL library was recently added to ANGLE's end2end tests, breaking the assumption that the tests were interacting with the ANGLE EGL library directly. Many EGL end2end tests call eglGetPlatformDisplay() with the platform value EGL_PLATFORM_ANGLE_ANGLE. However, Android only allows EGL_PLATFORM_ANDROID_KHR, rejecting all other values (returning EGL_NO_DISPLAY). Add GetEglPlatform() to return the platform value to pass to eglGetPlatformDisplay(), based on things like the driver being tested and the OS the tests are running on. Currently, this only supports returning EGL_PLATFORM_ANDROID_KHR for SystemEGL+Android, and EGL_PLATFORM_ANGLE_ANGLE for everything else. Bug: b/279980674 Change-Id: Ib8d7970c8e178beb14ecc6a4f96156783e60c257 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6634554 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
angle-autoroll 7bfdfcc8 2025-07-02T09:47:07 Roll Chromium from 4eaa3d114a3f to e4e9341de2f7 (1812 revisions) https://chromium.googlesource.com/chromium/src.git/+log/4eaa3d114a3f..e4e9341de2f7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/71876cfb44..70d5459e6e * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/f7862e515c..f30f8f10c9 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/a4a57f7e2a..29d6e4bb40 * third_party/android_build_tools/error_prone/cipd: KOECi08Fw4fRTVXkKocxg94coB-e_dlcHRokC21yxyoC..dFVMo_NVD5IoNgsCTx1nb8lGGNZNmY6xP94EJtjdm3sC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/06a7007d07..63527f0b9e * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/57fbead964..559a8cbd6e * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4f1723dd1f..615f4a2f03 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/d9dd3097ff..34e6c8e85a * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/e0f7527112..17e748fa88 * third_party/r8/cipd: 9vZCRnASPSjh3_T-2AsumCO_8C5PuBJ5-e84K9b7-80C..FXmk4HnrTNsJaRZsLuDZ749YMcCaP-Es0XYIrNMTsfUC * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/2c5b3e50a6..c8ffe73cf2 * third_party/siso/cipd: git_revision:13b7a626dcadfb49c7f4759a44095cebea6e91bc..git_revision:c46a6c9266d0685fa462694be456204ad243c030 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/0677411eff..79aeafa6ee * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/9d5b043d87..4f3180cff2 * tools/luci-go: git_revision:e18061c271a8bd452f0205e61ca71f872a48ba9c..git_revision:421eb17838d044c10a7cd661a68b5bfa2510f6af * tools/luci-go: git_revision:e18061c271a8bd452f0205e61ca71f872a48ba9c..git_revision:421eb17838d044c10a7cd661a68b5bfa2510f6af * tools/luci-go: git_revision:e18061c271a8bd452f0205e61ca71f872a48ba9c..git_revision:421eb17838d044c10a7cd661a68b5bfa2510f6af * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/28767137ec..715f296aa6 * tools/skia_goldctl/linux: CAiXuvpP5wV2AC3jI0EO8yfxRxLXKPCBA7189V3-uR4C..2v1Ogsr5B2ZzLTgxhDCUrs7f3QNdJAw0etD0NJPFkBwC * tools/skia_goldctl/mac_amd64: MRvyuJb7Hj1mIvsxGYJCLQ6YLSGYa1H51dsruyE9wdkC..sB2C9nyKoe0aixRfQ9ociaa3TGzo8Pn5em_Md8a51a0C * tools/skia_goldctl/win: YEFP2NCjTSr_DWtN8J1z__-mKqVd9qUfnB3U3s9zmqYC..YwoTmtJT_JKxB9mVFMCkzABlA_hIEw8P2qB3pTZ0azUC No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: Ib9a5e4aef180fb50166a2afc39b813079a35837f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6699229 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Tim Van Patten 4e0537ce 2025-06-13T11:23:58 EGLWindow: Query the Context version after creation Move GetCurrentContextVersion() from src/tests/egl_tests/EGLBackwardsCompatibleContextTest.cpp to util/util_gl.h, so it can be used by both the test and EGLWindow. Without EGL_ANGLE_create_context_backwards_compatible and specifying EGL_CONTEXT_OPENGL_BACKWARDS_COMPATIBLE_ANGLE = EGL_FALSE, ANGLE will create a context with the maximum conformant version the display supports. If the extension is not supported, we need to query the actual context version, so each test can behave accordingly. EGL 1.5 Spec 3.7.1.1 OpenGL and OpenGL ES Context Versions The context returned must be the specified version, or a later version which is backwards compatible with that version. It is expected that EGL_ANGLE_create_context_backwards_compatible is *not* supported when testing the system EGL. This change also adds a log message when the requested context version does not match the actual version. Bug: b/279980674 Change-Id: I58c0779db72c2afcc39c7d88a9a559b37698c994 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6653853 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
angle-autoroll fae186be 2025-07-02T12:13:18 Roll vulkan-deps from ae9b2969a750 to a1b7197600d4 (8 revisions) Ignore optionally included "mimalloc-stats.h" https://chromium.googlesource.com/vulkan-deps.git/+log/ae9b2969a750..a1b7197600d4 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/58391db4fa55e4a19bb0b7377e24476bc88ae688..cf70be28b43563fb5ffc2681fb3bbe424707b920 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/3e25cb555c511d1375f84cb68ecb1c6ede84247a..a30de91e1618558a71362e68afa62d7fc6f7ce24 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Change-Id: I0facaf948305731b4381862d286cd561d6c47062 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6699077 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Tim Van Patten e181ce7a 2025-07-01T11:10:16 end2end: Remove reference to *_EGL configs from help message The *_EGL configs were removed with the following CL: Support running the full end2end suite against the System EGL https://crrev.com/c/6580876 Instead, users need to use the GN arg: angle_test_enable_system_egl = true Update the help message to remove the reference to *_EGL configs and point users to the GN arg instead. Bug: b/279980674 Change-Id: I05908a65eaab6d6a9fbdca9039b687ce4fc31567 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6696787 Reviewed-by: mohan maiya <m.maiya@samsung.com> Commit-Queue: Tim Van Patten <timvp@google.com>
Yuly Novikov f1ae163b 2025-07-01T17:02:14 Update googletest We need https://github.com/google/googletest/commit/fa8438ae6b70c57010177de47a9f13d7041a6328 in order to be able to roll in https://chromium-review.googlesource.com/c/chromium/src/+/6674713 This rolls: https://chromium.googlesource.com/chromium/src/third_party/googletest/+log/17bbed2084d3127bd7bcd27283f18d7a5861bea8..0784ddbe926a700e2216b224109791f7fa19eb2f https://chromium.googlesource.com/external/github.com/google/googletest/+log/2d924d7a971e9667d76ad09727fb2402b4f8a1e3..c67de117379f4d1c889c7581a0a76aa0979c2083 The above also requires adding re2 dependency, since newer googletest depends on it. re2 has 2 parts: build files in https://chromium.googlesource.com/chromium/src/third_party/re2/ and source files in https://chromium.googlesource.com/external/github.com/google/re2/. Unfortunately, git submodules don't allow us to have them nested. So, build files are copied into third_party/re2 from https://chromium.googlesource.com/chromium/src/third_party/re2/+/e9ea896a60f8d72b4943dcc079f0041863985c0e These would require manual updates if build breaks in the future. And then the sources are added as a submodule in third_party/re2/src. These would be autorolled in the future. Bug: angleproject:428697844 Change-Id: Ia695b83669d1822614177fb2aaad44f733b1dfb9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6695112 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Shufen Ma 154e5711 2025-06-24T15:28:28 Refine validation for GetQueryObjectuiv Spec says that after a graphics reset has occurred on a context, subsequent GL commands on that context (or any context which shares with that context) will generate a CONTEXT_LOST error. Exceptions to this behavior include: Any commands which might cause a polling application to block indefinitely will generate a CONTEXT_LOST error, but will also return a value indicating completion to the application. Such commands include: - GetSynciv with pname SYNC_STATUS ignores the other parameters and returns SIGNALED in values - GetQueryObjectuiv with pname QUERY_RESULT_AVAILABLE ignores the other parameters and returns TRUE in params Bug: angleproject:427242336 Change-Id: I86fd6f93a2c2a4b60c6a1e19637ee6382fadac7b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6666083 Auto-Submit: Shufen Ma <Shufen.Ma@arm.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Charlie Lao <cclao@google.com>
angle-autoroll 3ff59f61 2025-07-01T10:01:45 Roll vulkan-deps from d3f4b5f78306 to ae9b2969a750 (27 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/d3f4b5f78306..ae9b2969a750 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/95e6e51a2430185af06a92049395144a6f63a8e1..8a85691a0740d390761a1008b4696f57facd02c4 https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/9ad326e45722ca2cf321d41f5caedbe67a40a449..58391db4fa55e4a19bb0b7377e24476bc88ae688 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/40eb301f320e1d85ce3bc12798022149eae3eee3..bc7c60e96e141bc55b7099a3d35fb9e0eb1fc801 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/10739e8e00a7b6f74d22dd0a547f1406ff1f5eb9..16cedde3564629c43808401ad1eb3ca6ef24709a https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/342da33fdec78d269657194c9082835d647d2e68..8beef6cb63ffadb02300bf6321b4d3af85ea7417 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/e3fc64396755191b3c51e5c57d0454872e7fa487..f0f308ad2cdc2e8fd58985d6230df4a29cc44eb6 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/72665ee1e50db3d949080df8d727dffa8067f5f8..f216bb107bfc6d99a9605572963613e828b10880 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/3fd9510a5dcdb3604a3b16af70ba474c3a0f4944..3e25cb555c511d1375f84cb68ecb1c6ede84247a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I213fe4c2c22082e316a6ad90aec15c32e49cc1de Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6695865 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Tim Van Patten e738f5bc 2025-06-30T16:54:25 EGLWindow: Fix eglGetError in initializeSurface() From the EGL 1.5 spec: # Chapter 3 EGL Functions and Errors ## 3.1 Errors Additional information about the success or failure of the most recent EGL function called in a specific thread[1], in the form of an error code, can be obtained by calling EGLint eglGetError(void); [1] Note that calling eglGetError twice without any other intervening EGL calls will always return EGL_SUCCESS on the second call, since eglGetError is itself an EGL function, and the second call is reporting the success or failure of the first call. In other words, error checking must always be performed immediately after an EGL function fails. EGLWindow::initializeSurface() is checking the status of eglCreateWindowSurface() with eglGetError() and then calling eglGetError() again in the error log message. This results in the error message always containing 0x3000 (EGL_SUCCESS), as the spec states. Fix this by capturing the value of eglGetError() and then using the captured value in both the conditional and the log statement. Bug: b/279980674 Change-Id: I6310996b83960752a9b0d5e0bf40f5aab23174c7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6692271 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Tim Van Patten <timvp@google.com>
Tim Van Patten 56b5d523 2025-06-26T17:32:59 Fix GetTestConfigAPIFromRenderer() for SystemEGL Testing Add support for GLESDriverType::SystemEGL to GetTestConfigAPIFromRenderer() when system EGL testing is enabled with ANGLE_TEST_ENABLE_SYSTEM_EGL. This allows the correct GPUTestConfig value to be returned, rather than GPUTestConfig::kAPIUnknown. The side-effect of this is fixing the expectations file handling for entries with qualifiers like "VULKAN" and allowing those tests to be skipped, for example. Bug: b/279980674 Change-Id: Iaf039549b82f5ba7a047e621bb26968df511a75e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6681013 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
angle-autoroll 99b4ac7e 2025-07-01T03:01:11 Roll SwiftShader from 436722b39118 to 96a63130d839 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/436722b39118..96a63130d839 2025-06-30 swiftshader.regress@gmail.com Regres: Update test lists @ 436722b3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I1e778f8cf34253dee234be1f54a4ff1138c860c7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6696064 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov 777ded25 2025-06-30T15:09:52 Add a whitespace file to test auto cherry picker. Bug: chromium:428685230 Change-Id: Ie74d974c624cd4a9f0963a9f27e5796469b01b9e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6684312 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
angle-autoroll f4885b11 2025-06-30T08:01:55 Roll VK-GL-CTS from 4c617fa74b67 to a7dbc48b7b02 (7 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/4c617fa74b67..a7dbc48b7b02 2025-06-27 lorenzo@khronosgroup.org Update external sources (Vulkan 1.4.320) 2025-06-27 ziga@lunarg.com Add missing cmath include in cooperative matrix tests 2025-06-27 ziga@lunarg.com Add ray tracing query with availability bit tests 2025-06-27 rgarcia@igalia.com Add compile-time option to log test case source code origin 2025-06-27 lionel.g.landwerlin@intel.com Set LineWidth dynamic state for shader object with mesh shaders 2025-06-27 michal.jakubek@mobica.com Adapt Api Buffer Marker tests to Capabilities System 2025-06-27 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.3 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: Ice0113b1913d4309c64b0d3154505e1713611e17 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6687257 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya bb3f79dc 2025-06-26T16:59:48 Reorder shader resource dirty bits Process storage and atomic buffer dirty bits before uniform dirty bits. This helps the vulkan backend avoid duplicate work when multiple shader resources are dirty Bug: angleproject:426412564 Change-Id: Ibab3da44ee32d22078df851bfed4967d1c2a605e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6680035 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com>
Tim Van Patten bbe53b75 2025-06-05T10:36:30 tests: Skip ShaderBinaryTest for System EGL The system driver compiler version is not expected to match the version compiled into the test, causing glShaderBinary() to return GL_INVALID_VALUE due to the incompatible binaries. Bug: b/279980674 Change-Id: I6fce9848345ce981003f0d6d8954e45c2966b523 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6622113 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Tim Van Patten <timvp@google.com>
Zhuang Xu 3c8b492e 2025-06-26T09:39:29 Add histogram for DirectX device removal Bug: dawn:423964507 Change-Id: I22d40ede209797e759f4b4f9e4b86785df33dbe5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6665860 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Avi Drissman d28c6adf 2025-06-19T09:41:26 Modernize for macOS 12 macOS 12 is the minimum OS requirement, so remove the "main port" workaround and do other modernization. Bug: b/40250210 Change-Id: I9638014732f0589fc6171c0fe617b3c563f00c28 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6655558 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll ee071b31 2025-06-27T10:01:59 Roll vulkan-deps from 216f8f420080 to d3f4b5f78306 (6 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/216f8f420080..d3f4b5f78306 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/e9d166cd3bdb4d3c89c6c89c7d9f196a0c9e4ffb..95e6e51a2430185af06a92049395144a6f63a8e1 https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/00e8a166b8c371d8ff6f70ea7872a311b43817ee..9ad326e45722ca2cf321d41f5caedbe67a40a449 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/604c3e75a41b3605ac86bdf5bc26987bd9f9589f..40eb301f320e1d85ce3bc12798022149eae3eee3 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/153542280969323563e588308cb8796df5931d06..3fd9510a5dcdb3604a3b16af70ba474c3a0f4944 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I73233eba71a0bd61e4808c1cb9aad0d9ff49f087 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6682564 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 4b7b8ee3 2025-06-27T07:01:17 Roll Chromium from 3e575cefc53a to 4eaa3d114a3f (453 revisions) https://chromium.googlesource.com/chromium/src.git/+log/3e575cefc53a..4eaa3d114a3f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/9cfbcbcdd9..71876cfb44 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/78457247d1..a4a57f7e2a * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/43850be4d3..dd86c62796 * third_party/android_build_tools/lint/cipd: RevkTwhOQRk-oOzI4BBk3FYEeVAlBijeTqjNPrGsi_8C..eWRdzGzH7yQ87tWs3ziVgS5K-hEL5sDdOZgIR2pSduoC * third_party/android_build_tools/manifest_merger/cipd: v0s5-TwZ9OxfzbqU5ULhQ7vufSuKIIld6Z7TK8artzoC..QmC9cZkulirpeFoG7WaWIGRovPGsS8sMpycIswB1CwkC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/8b6c661e42..57fbead964 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/838762e3ae..4f1723dd1f * third_party/fuchsia-sdk/sdk: version:28.20250609.4.1..version:28.20250626.4.1 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/79a5aa1b7f..d9dd3097ff * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/10890f1e73..2c5b3e50a6 * tools/luci-go: git_revision:6c2c13d25bc8014a0da038302089bc3e9b236931..git_revision:e18061c271a8bd452f0205e61ca71f872a48ba9c * tools/luci-go: git_revision:6c2c13d25bc8014a0da038302089bc3e9b236931..git_revision:e18061c271a8bd452f0205e61ca71f872a48ba9c * tools/luci-go: git_revision:6c2c13d25bc8014a0da038302089bc3e9b236931..git_revision:e18061c271a8bd452f0205e61ca71f872a48ba9c * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/532e27cf37..28767137ec * tools/skia_goldctl/linux: DuaWI_iN1aKYqw68BNRC2gsLbwarydFdh-0pBp8HS6UC..CAiXuvpP5wV2AC3jI0EO8yfxRxLXKPCBA7189V3-uR4C * tools/skia_goldctl/mac_amd64: kfSAMIADvMhxx5OoeY0EajZqqvBTlkVsrDEiWApdnsMC..MRvyuJb7Hj1mIvsxGYJCLQ6YLSGYa1H51dsruyE9wdkC * tools/skia_goldctl/mac_arm64: TMdajugFqfAjHrtZbG5sFxtFgsHk5GeyYgO7Exhlx20C..yQbqw0wv-j0IsBpNmiZnivv8rVuM2ZfaKDm-2DoDw1kC * tools/skia_goldctl/win: 2KZkcCD9mC9MsaKQTOIECvyDm_gtn0YaOjpfdhXw9wcC..YEFP2NCjTSr_DWtN8J1z__-mKqVd9qUfnB3U3s9zmqYC No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: I57328330ed7040bd2f46ecefae6e107ce47c08d4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6680040 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya 3c41ca3e 2025-06-26T20:36:03 Bugfixes in YUV tests - There is no mechanism to query dataspace of AHB, ensure all color values are narrow range compatible - Ensure AHB usage flag reflects actual usage - Define YUV reference colors at the top and reuse in tests Bug: angleproject:386749841 Change-Id: I29d095055ede67653f89a11bae845c086c690b1a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6679988 Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 56e9bfff 2025-06-19T00:00:00 GL: Remove obsolete macOS workarounds Bug: angleproject:427600175 Change-Id: I8bfc062b71f1a34de09cbf76b504293ccd081fe0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6676022 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Shashank Sharma ca893fdf 2025-06-23T13:41:33 Search only for png files while pulling screenshot restricted_trace_perf.py should only look for png files in temp dir and then assert only for 1 screenshot to be present. Bug: b/427963936 Change-Id: I0692aded39f7c3bd5b0c30ee4a7b613db08eac04 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6680727 Auto-Submit: Shashank Sharma <shawshanks@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
angle-autoroll 0a40f9f3 2025-06-26T16:05:37 Manual roll Chromium from e9b993c93b3b to 3e575cefc53a (204 revisions) Manual roll requested by geofflang@google.com https://chromium.googlesource.com/chromium/src.git/+log/e9b993c93b3b..3e575cefc53a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/660c19b81f..9cfbcbcdd9 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/14abe7e6ae..78457247d1 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/cb4a6fc970..9d5b043d87 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/046519adb4..532e27cf37 No update to Clang. Bug: angleproject:427600175 Tbr: yuxinhu@google.com,geofflang@google.com Change-Id: Ie8226208abd9af52b2892fd2ab605f4c2391f61c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6680000 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Kramer Ge dcc715ee 2025-06-19T15:35:53 Enable EGL_PLATFORM_GBM_KHR platform with device selection FunctionsEGL.cpp: - Allow EGL_PLATFORM_GBM_KHR platform and explicit device selection. - Skip getPreferredDisplay if an explicit device is specified. Display.cpp: - Use DisplayEGL impl with EGL_PLATFORM_GBM_KHR. - Wayland can use GBM platform, and OPENGLES. angle.gni: - Rename ozone_platform_gbm to ozone_platform_drm since its deprecated. Bug: angleproject:425569857, b/396434686 Change-Id: I9493118f9dc95f78ebe46277bb4fcfeb7a29d465 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6663699 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Kramer Ge <fangzhoug@chromium.org>
angle-autoroll e7ede7d7 2025-06-26T10:01:15 Roll vulkan-deps from e7bba33afe37 to 216f8f420080 (18 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/e7bba33afe37..216f8f420080 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/efd24d75bcbc55620e759f6bf42c45a32abac5f8..e9d166cd3bdb4d3c89c6c89c7d9f196a0c9e4ffb https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/8e3261f207f1c520522be2021cf364ebb1bad3f0..00e8a166b8c371d8ff6f70ea7872a311b43817ee https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/2a611a970fdbc41ac2e3e328802aed9985352dca..04b76709bf40a7ce8df3382060ef3620f19de566 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/33e02568181e3312f49a3cf33df470bf96ef293a..604c3e75a41b3605ac86bdf5bc26987bd9f9589f https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/6016c4624f8ad3df64987936bfbeb29f32da2d55..153542280969323563e588308cb8796df5931d06 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: Icd95d43f905e897e4b7a59706ecfabdc07d1c3fd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6679275 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 5023a762 2025-06-26T03:01:45 Roll SwiftShader from ed01d9931de3 to 436722b39118 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/ed01d9931de3..436722b39118 2025-06-25 tikuta@google.com Fix conflicting types error in clang modules build If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I31eb7618114872edae931e04181238ffef7942b3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6678109 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 19e4deb5 2025-06-26T09:41:09 Roll Chromium from 263c8e504d0e to e9b993c93b3b (576 revisions) https://chromium.googlesource.com/chromium/src.git/+log/263c8e504d0e..e9b993c93b3b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/7404e7cb13..660c19b81f * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/cf875f9ac3..f7862e515c * testing: https://chromium.googlesource.com/chromium/src/testing/+log/c4185e4f15..14abe7e6ae * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/9fc6afe878..06a7007d07 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/0c0721de3c..8b6c661e42 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/2c359c239b..b5d83e70a1 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/e44c3c4560..02570151a8 * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/4b5d818f29..10890f1e73 * third_party/siso/cipd: git_revision:c23de742b8483ddc09d8b68ef845efc7f5c6192f..git_revision:13b7a626dcadfb49c7f4759a44095cebea6e91bc * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/b1c9da6382..046519adb4 * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/12ac1a1b8e..c52b68f9dc No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: Ibe8856d9ad9cafa0323b37d1cded42c34e611116 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6679272 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Igor Nazarov d5babf99 2025-06-23T12:46:51 Vulkan: Fix unhandled deferred clears after glGetMultisamplefv Issue was introduced in the commit that implemented deferred clears. The `glGetMultisamplefv()` synchronizes draw framebuffer which defers possibly staged clears. Since API is not handling deferred clears they are left untouched, causing the ASSERT. This change fixes the issue by not deferring clears for the `glGetMultisamplefv()` command during flushing staged updates of dirty framebuffer attachments. Changes: - Add `gl::Command::GetMultisample` enumeration for clarity. - Add `gl::CommandBlitBuffer::CommandBlitBufferDepthStencil` enumeration to improve code readability. - Add `command` parameter into `gl::State::syncDirtyObject()` method to use actual command enum instead of `Other`. - Remove `previousDeferredClears` local variable and update ASSERT in the `FramebufferVk::syncState()` method. New assert ensures empty `mDeferredClears` instead of just checking dirty attachments, since it is easy to make all attachments dirty making old and new assertions act the same. - Replace logic in `FramebufferVk::syncState()` that decides whether need to defer attachments or not with switch-case. This makes the logic more clear regarding handling individual commands and simplify updating this handling in the future. Except of the bug fix with `GetMultisample` command, handling of other command is uncached. - Remove `flushDeferredClears()` from `FramebufferVk::readPixels()` because `mDeferredClears` are not expected (now it's more clear after the refactoring). And even if there are `mDeferredClears` (in case of a bug or after API failure), `flushDeferredClears()` only flushes clears for the draw framebuffer, while checking `mDeferredClears` of the read framebuffer. This is a problem in case if read and draw framebuffers are not the same. Bug: angleproject:40644727 Test: angle_end2end_tests --gtest_filter=TextureMultisampleTest.GetMultisamplefvAfterClear/* Test: angle_end2end_tests --gtest_filter=EGLSurfaceTest.GetMultisamplefvAfterClear/* Change-Id: I376a62de52de5e17dbc63cc7ddb0506741a69266 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6661958 Commit-Queue: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Mohan Maiya b3ec3a5f 2025-06-23T14:51:13 Track active uniform and storage buffer blocks Track active uniform and storage buffer block indices so we can process updates to only active buffer blocks Bug: angleproject:426412564 Change-Id: I54fa6fbe795073887646d672303d231ed4317b65 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6663825 Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com>
angle-autoroll c455bda6 2025-06-25T09:34:06 Roll Chromium from 2fb03826f7a0 to 263c8e504d0e (692 revisions) https://chromium.googlesource.com/chromium/src.git/+log/2fb03826f7a0..263c8e504d0e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/8d59c1de51..7404e7cb13 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/39d3a59234..cf875f9ac3 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/d1addfdf7f..c4185e4f15 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/e3d58ba1a2..43850be4d3 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/f46835180c..9fc6afe878 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/c4f7831fe8..0c0721de3c * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ea7a0baff0..838762e3ae * third_party/r8/d8/cipd: F0pTWc6uG70kZPngypnQxCgD3CgY5D8O-pDqj_qeoQMC..9vZCRnASPSjh3_T-2AsumCO_8C5PuBJ5-e84K9b7-80C * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/35982745eb..4b5d818f29 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/5a2ef49216..0677411eff * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/3b495dd794..cb4a6fc970 * tools/luci-go: git_revision:b0488766ec2a119f97c0189ffa5fff13e4da0131..git_revision:6c2c13d25bc8014a0da038302089bc3e9b236931 * tools/luci-go: git_revision:b0488766ec2a119f97c0189ffa5fff13e4da0131..git_revision:6c2c13d25bc8014a0da038302089bc3e9b236931 * tools/luci-go: git_revision:b0488766ec2a119f97c0189ffa5fff13e4da0131..git_revision:6c2c13d25bc8014a0da038302089bc3e9b236931 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/c5b01d0483..b1c9da6382 * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/6c0ba3465b..12ac1a1b8e Clang version changed llvmorg-21-init-11777-gfd3fecfc:llvmorg-21-init-16348-gbd809ffb Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/3b495dd79432abeb32aeb7b51cf4021e4defd24f..cb4a6fc9704f19e6977d7fd1da2a578274b9f611/scripts/update.py Bug: None Tbr: yuxinhu@google.com Change-Id: I843a2e1464773a0305a9c37893a286746f8e35ae Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6670383 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Gyuyoung Kim e15d293c 2025-06-16T16:24:09 tvOS: Disable child process creation code tvOS does not support multi-process applications. As a result, the code that creates a new process causes build failures when building ANGLE unit tests on tvOS. This CL disables that code to prevent the build from breaking. Bug: b/424256388 Change-Id: Ib638d3f75b2839e1a75efc571645921f0d336e55 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6640919 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Solti Ho <solti@google.com>
Alexey Knyazev beae1b4a 2025-06-19T00:00:00 Metal: Remove obsolete workarounds Removed Intel-specific Metal workarounds that are not used on macOS 12 and later. Removed a redundant version check. Bug: angleproject:427600175 Change-Id: I34c7e53108f7e030512c9436ab2b9ae38ad17946 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6672312 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll 14960950 2025-06-24T10:01:50 Roll vulkan-deps from 317a1e4780ef to e7bba33afe37 (15 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/317a1e4780ef..e7bba33afe37 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/21b4e37133868b3a50ef15fc027ecd6d3a52c875..efd24d75bcbc55620e759f6bf42c45a32abac5f8 https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/da60ac4327af194dfa773a07db6cd5d5aaa6848d..8e3261f207f1c520522be2021cf364ebb1bad3f0 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/108b19e5c6979f496deffad4acbe354237afa7d3..33e02568181e3312f49a3cf33df470bf96ef293a https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/c8a2c8c9164a58ce71c1c77104e28e8de724539e..342da33fdec78d269657194c9082835d647d2e68 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/0f0babb553a60da5971d9f4d40cf720ce01602f1..72665ee1e50db3d949080df8d727dffa8067f5f8 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/89c6a9b6500e2e0bda127113bbfe1d70f1ab2d20..6016c4624f8ad3df64987936bfbeb29f32da2d55 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I9944562cd1530a415cc2173d9e6857555e38714d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6665688 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 448c8dab 2025-06-24T03:01:51 Roll SwiftShader from 0ce9bc68d3fc to ed01d9931de3 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/0ce9bc68d3fc..ed01d9931de3 2025-06-23 swiftshader.regress@gmail.com Regres: Update test lists @ 0ce9bc68 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I9883e01ac2797c0dc568965cd7c82352996a8b33 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6666627 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll bbeff29f 2025-06-24T07:00:58 Roll Chromium from f88e654e8ceb to 2fb03826f7a0 (562 revisions) https://chromium.googlesource.com/chromium/src.git/+log/f88e654e8ceb..2fb03826f7a0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/169fcf699b..8d59c1de51 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/5b7491dfe5..39d3a59234 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/0d5210a4b1..d1addfdf7f * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/c7f3762b71..f46835180c * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/a03b70978c..c4f7831fe8 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8f87843807..ea7a0baff0 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/3dc83eebbd..79a5aa1b7f * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/274de19b1d..35982745eb * third_party/turbine/cipd: npJIrAZr4-2wb6qWV0r2oeWQd-Q1wiMGAAi8Up15SkQC..oD9ecDiZFUZfazjjD0N5yl6G4aJsgODDdNjqIp5m1GwC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/ae0ff70908..3b495dd794 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/bd0baf9e31..c5b01d0483 * tools/skia_goldctl/linux: I1LygzXVm-v4LePMcFJ9j0k1AZoLq1UFO5FvEue2TbsC..DuaWI_iN1aKYqw68BNRC2gsLbwarydFdh-0pBp8HS6UC * tools/skia_goldctl/mac_amd64: uI8NbGw_UiTJ3W2CTVNlIycIt9w6x1ozArj3Y3F4UtkC..kfSAMIADvMhxx5OoeY0EajZqqvBTlkVsrDEiWApdnsMC * tools/skia_goldctl/mac_arm64: QSSJvE4WdrL_WsuphR6xIEvHYbO5MAX3yzL1OZUDCMEC..TMdajugFqfAjHrtZbG5sFxtFgsHk5GeyYgO7Exhlx20C * tools/skia_goldctl/win: 72BoyHuvkKlIhZ3QJunOfOnQ4xpyI3ImPWyF8OcXrHMC..2KZkcCD9mC9MsaKQTOIECvyDm_gtn0YaOjpfdhXw9wcC No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: Ida6202335aa1acab4cb41f7d9ef10f16536f66bc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6666420 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao 79ac1a8c 2025-06-23T11:11:10 Revert "Vulkan: Move VertexArray::ElementBuffer away from observer" This reverts commit 3f012a43ee2c101543785720eedfeaa80708479d. Reason for revert: https://issues.chromium.org/427064102 Bug: angleproject:400711938 Original change's description: > Vulkan: Move VertexArray::ElementBuffer away from observer > > Right now, VertexArray's element buffer is always observing buffer's > change. In previous CLs, we have moved vertex array away from > subject/observer usage. This CL moves element buffer away from > subject/observer as well. Since the gl::Buffer tracks buffer's binding > to each context's current vertex array's binding point, > kElementArrayBufferIndex is added to VertexArrayBufferBindingMask bits > so that the element buffer is tracked exactly the same as other vertex > array buffer bindings. The VerextArray code has been modified to handle > this special bit, since element buffer has its own binding point > VertexArrayState::mElementArrayBuffer as opposed to > VertexArrayState::mVertexBindings. After this CL, VertexArray object > should be completely off subject/observer usages. > > Bug: angleproject:400711938 > Change-Id: I662ddfabc95034bdc7734939c944ab033f41801c > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6552160 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Geoff Lang <geofflang@chromium.org> > Commit-Queue: Charlie Lao <cclao@google.com> Bug: angleproject:400711938 Change-Id: I9487ba8b108baaeda1c8a27189dba64f77616774 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6663539 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Charlie Lao 5df85793 2025-06-23T11:08:49 Revert "Vulkan: Avoid some loops in VertexArray::onBufferChanged" This reverts commit 8d6d127acc1072488e5b57ba4e7e93da2d94bfda. Reason for revert: https://issues.chromium.org/427064102 Bug: angleproject:400711938 Original change's description: > Vulkan: Avoid some loops in VertexArray::onBufferChanged > > Before this CL, VertexArray::onBufferChanged() loops over > bufferBindingMask bits and calls onSubjectStateChange. In this CL, > VertexArray::onSubjectStateChange is embedded into > VertexArray::onBufferChanged(). DIRTY_BIT_ELEMENT_ARRAY_BUFFER and > DIRTY_BIT_ELEMENT_ARRAY_BUFFER_DATA is re-arranged so that we can map > bufferBindingMask directly to VertexArray::mDirtyBits. This especially > useful when one buffer is bound to multiple indices in the VertexArray. > > This CL also removes angle::ObserverInterface from VertexArray, since it > no longer observes anything. > > ASSERT is added in gl::Buffer::mContentsObservers to ensure it only > contains BufferTexture, since vertexArray is no longer using the > subject/observer. > > Bug: angleproject:400711938 > Change-Id: Ie6e7159d7a89f0da5e1b7ca0a9dbe60a1e6c682f > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6569638 > Reviewed-by: Geoff Lang <geofflang@chromium.org> > Commit-Queue: Charlie Lao <cclao@google.com> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Bug: angleproject:400711938 Change-Id: I3b8e77db7b3d06b9ed875bfe7787904ac753da11 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6664161 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Junji Watanabe 0a47f441 2025-05-27T16:00:38 Set use_siso=true by default in .gn This CL enables use_siso=true by default. Developers builds will switch to Siso, or get suggestion to run `gn clean` to switch. Bug: b/401959048 Change-Id: I7cf7efecc9cd8c7816dbbd74ea48e66e61a1b6f2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6589553 Auto-Submit: Junji Watanabe <jwata@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Mohan Maiya 2fd033d0 2025-05-22T04:21:11 Vulkan: Optimize updates to uniform buffers ... when only the offset is modified. Most of the work done when handling dirty uniforms can be skipped since the buffer bindings haven't changed Bug: angleproject:386749841 Tests: UniformBufferTest31.UniformBufferBindingRangeChange*Vulkan Change-Id: Ic811bd71f0f2993f88ce9bcf93f9e8e46dfc6d99 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6581359 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Shahbaz Youssefi d59dd3e4 2025-06-23T10:17:46 Unskip passing tests The spec change to varying packing in Vulkan is reverted and so is the SPIR-V validation change that enforced it. Bug: angleproject:404418769 Change-Id: I6eb82b8285121f65a4ac071ad6ede106dfe07988 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6661620 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 60c50fe8 2025-06-23T10:01:26 Roll vulkan-deps from 316ed08fbc9a to 317a1e4780ef (11 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/316ed08fbc9a..317a1e4780ef Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/422150b405c2ac2e05e51a19defabb232efd9187..108b19e5c6979f496deffad4acbe354237afa7d3 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/b39ab380a44b6c8df462c34e976ea9ce2d2c336b..10739e8e00a7b6f74d22dd0a547f1406ff1f5eb9 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/dc6786e527cf8cefd244318f546b3b2ec26e84f4..c8a2c8c9164a58ce71c1c77104e28e8de724539e https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/d671923090e4dc74c0ebdb10c6e09fa0826e1fe9..e3fc64396755191b3c51e5c57d0454872e7fa487 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/54c9baf20802a13279e23fa4cb0528dd5cf16064..0f0babb553a60da5971d9f4d40cf720ce01602f1 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/4b207eefa09f304a06c237fcf4913304e0b7d8d1..89c6a9b6500e2e0bda127113bbfe1d70f1ab2d20 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I2d388ca2b4fb9ccfb6edca31fc697273d6f4513a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6661102 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 8bc3d6e2 2025-06-23T09:21:17 Roll Chromium from 558ed507cbc4 to f88e654e8ceb (799 revisions) https://chromium.googlesource.com/chromium/src.git/+log/558ed507cbc4..f88e654e8ceb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/ed15b02ce4..169fcf699b * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/b2eba427b8..5b7491dfe5 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/4e8c09e96b..0d5210a4b1 * third_party/android_build_tools/lint/cipd: Ddt_nMFT2APf615MrUZPaZpe-MqZSNrJmk8s9ud-f3gC..RevkTwhOQRk-oOzI4BBk3FYEeVAlBijeTqjNPrGsi_8C * third_party/android_build_tools/manifest_merger/cipd: JcTHGCKOl5tWhax5LSv_vf5dQV14RZdPF9xSRKU76JgC..v0s5-TwZ9OxfzbqU5ULhQ7vufSuKIIld6Z7TK8artzoC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/8a80ddf29e..c7f3762b71 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/116ec83ba8..a03b70978c * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9a17210302..8f87843807 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/e09972e094..3dc83eebbd * third_party/r8/cipd: kgSCvDyebyXaL6suvPTOC8fS-Wsu-SmeFTrIkT51K14C..9vZCRnASPSjh3_T-2AsumCO_8C5PuBJ5-e84K9b7-80C * third_party/siso/cipd: git_revision:7e7d85fc69f9084d2168385fb504b31e830dbfff..git_revision:c23de742b8483ddc09d8b68ef845efc7f5c6192f * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/dd092af0a1..5a2ef49216 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/299c639544..ae0ff70908 * tools/luci-go: git_revision:0250323d999386415553b5e2297eafe827ca41f3..git_revision:b0488766ec2a119f97c0189ffa5fff13e4da0131 * tools/luci-go: git_revision:0250323d999386415553b5e2297eafe827ca41f3..git_revision:b0488766ec2a119f97c0189ffa5fff13e4da0131 * tools/luci-go: git_revision:0250323d999386415553b5e2297eafe827ca41f3..git_revision:b0488766ec2a119f97c0189ffa5fff13e4da0131 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/854c2669c7..bd0baf9e31 No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: Icccb70141b839f1f52d8b62075183772f013099e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6661100 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 2102183a 2025-06-23T08:01:53 Roll VK-GL-CTS from 9390207187c6 to 4c617fa74b67 (9 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/9390207187c6..4c617fa74b67 2025-06-21 michal.jakubek@mobica.com Incorrect object reservation count choices made by the CTS 2025-06-21 michal.jakubek@mobica.com Adapt query pool statistics tests to Capabilities System 2025-06-21 ewerness@nvidia.com Ray tracing vertex fetch alignment changes for testing 2025-06-21 ziga@lunarg.com Add test case for tessellation matrix multiplication 2025-06-21 zzoon@igalia.com Set to use layered dpb only when separate dpb not supported 2025-06-21 michal.jakubek@mobica.com Adapt depth tests to Capabilities System 2025-06-21 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.3 into vk-gl-cts/main 2025-06-18 ewerness@nvidia.com Delete comment with a merge conflict in it 2025-06-18 lorenzo@khronosgroup.org Add comments and fix order of generated code If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: Ib2e088cffa41e78469b747f096b17d41d38ef518 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6659844 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuxin Hu 5220e634 2025-06-16T11:14:22 Fix glCopyImageSubData validation check part 2 For compressed texture, we also need to check if the copy subregion starting points (offset) are aligned with the compressed block. This change also moves *FillsEntireMip check to the ValidateCompressedRegion() function, as it is easier to do a per-dimension check. Bug: b/419048313 Bug: angleproject:42264179 Bug: angleproject:42265887 Change-Id: I0f415e575bbc77bdf5178e2b5fc1260c43e7de4b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6648198 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com>
Tim Van Patten 3b7528e1 2025-05-20T12:31:28 Support running the full end2end suite against the System EGL Update the end2end test instantiation to either fully target the packaged ANGLE libraries or the system EGL, but not a combination of both simultaneously. The GN argument |angle_test_enable_system_egl| controls which driver is being tested by all the instantiated tests. It's default value is "false", which means the tests target the ANGLE libraries by default: kDefaultGLESDriver = GLESDriverType::AngleEGL When |angle_test_enable_system_egl = true|: kDefaultGLESDriver = GLESDriverType::SystemEGL This allows for testing the system EGL with the full end2end test suite, which is useful on devices where ANGLE is the system EGL (e.g., Android). It also allows for specifying which backend to use (or all) during system EGL testing, when ANGLE is the EGL driver. This also includes removing the various ESx_EGL() functions, because the end2end tests must now fully commit to testing either the ANGLE driver or system driver, rather than a combination of both. This is similar to many other test suites, such as the Khronos CTS (dEQP), which only test validate a single driver per invocation. Bug: b/279980674 Test: angle_end2end_tests Change-Id: I4f7dc2ccb4f26b3bd02767d0a0d2876f8612f2ae Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6580876 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Amirali Abdolrashidi 6bb47e67 2025-06-17T13:42:47 Vulkan: Limit finalizing foreign image layouts Currently, any submission results in finalizing all foreign images. However, if the submission is only limited to the outside render pass command buffer, this would result in oldLayout VVL errors (01197), as it would be too early to finalize the layout of such images at those times. At this time, this type of submission can occur if the size of buffer-to-image updates exceeds the following threshold: kMaxBufferToImageCopySize In this change, finalizing the foreign image layouts would only occur when all commands are being submitted. * In ContextVk::submitCommands(), finalizeAllForeignImages() is now called only when the submission type is Submit::AllCommands. * Added new submit tests for foreign images to ImageTest: * UploadForeignUntilSubmitDoesNotBreakRenderPass * CopyToForeignUntilSubmitDoesNotBreakRenderPass Bug: b/425987310 Change-Id: Ia345e176be79017ba18ef52a57256eeeb298e39a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6653602 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
angle-autoroll 98bd576f 2025-06-19T08:01:25 Roll VK-GL-CTS from 53a925d9098c to 9390207187c6 (28 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/53a925d9098c..9390207187c6 2025-06-17 kamil.goras@mobica.com Add OpenGL tests for textureQueryLevels 2025-06-16 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkansc-cts-1.0.3 into vk-gl-cts/main 2025-06-16 lorenzo@khronosgroup.org Merge remote-tracking branch 'vk-gl-cts/dev/VK_EXT_shader_float8' 2025-06-16 lorenzo@khronosgroup.org Update external sources (Vulkan 1.4.318) 2025-06-16 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.12 into vk-gl-cts/main 2025-06-13 ziga@lunarg.com Fix missing submit infos in sync multi queue tests 2025-06-13 rgarcia@igalia.com Fix DeprecationWarnings in fetch_sources.py 2025-06-13 scerveau@igalia.com CMake: add additional pc checks 2025-06-13 rgarcia@igalia.com Test conditional rendering with ray tracing commands 2025-06-13 rgarcia@igalia.com Test "unaligned" buffer<->image copies 2025-06-13 jbolz@nvidia.com Add cooperative vector tests for readonly loads w/bounds checking 2025-06-13 rgarcia@igalia.com Test maintenance5 default point size without large points 2025-06-13 rgarcia@igalia.com Fix missing largePoints capability for multiview tests 2025-06-13 vikram.tarikere@imgtec.com Honour undefined behaviour from OpSDiv. 2025-06-13 lorenzo@khronosgroup.org Fix dependencies checks for extensions and functions 2025-06-13 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.3 into vk-gl-cts/main 2025-06-12 kamil.goras@mobica.com Add negative tests that texture lookup function bias parameter is not accepted in any other shader than fragment shader. 2025-06-11 lorenzo@khronosgroup.org Add VK_EXT_shader_float8 JSON 2025-06-11 lorenzo@khronosgroup.org Add VK_KHR_maintenance9 JSON 2025-06-11 lorenzo@khronosgroup.org Add VK_KHR_video_decode_vp9 JSON 2025-06-11 lorenzo@khronosgroup.org Add VK_KHR_unified_image_layouts JSON 2025-06-11 lorenzo@khronosgroup.org Update external sources 2025-06-11 lorenzo@khronosgroup.org Merge remote-tracking branch 'vk-gl-cts/dev/VK_KHR_maintenance9' 2025-06-10 scerveau@igalia.com video: VP9 decode tests: update public repo 2025-06-09 lorenzo@khronosgroup.org Merge remote-tracking branch 'vk-gl-cts/dev/VK_KHR_video_decode_vp9' into main 2025-06-09 lorenzo@khronosgroup.org Merge remote-tracking branch 'vk-gl-cts/dev/VK_KHR_unified_image_layouts' into main 2025-06-09 lorenzo@khronosgroup.org Update external sources (Vulkan 1.4.317) 2025-06-06 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-cts-4.6.6 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Change-Id: I1f614f11f0f5cb73c24dd4346a837ec6dc88b0bf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6658499 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang cb432540 2025-06-19T17:00:27 WebGPU: Expand dEQP test expectations This lowers our unexpectged passes from ~8k to ~3.5k. Bug: angleproject:356399840 Change-Id: Idb9d4aee9103bc18783a7283d938c368c7efbe5b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5875956 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Liza Burakova <liza@chromium.org> Commit-Queue: Liza Burakova <liza@chromium.org>
angle-autoroll b89c6008 2025-06-20T10:01:33 Roll vulkan-deps from 1c18b20944ca to 316ed08fbc9a (4 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/1c18b20944ca..316ed08fbc9a Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/da0ec29bb41cbba8af5920c81ee990536a4f6492..422150b405c2ac2e05e51a19defabb232efd9187 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/d004bbbbeb7e1bfe79533522af631bacec407ad2..4b207eefa09f304a06c237fcf4913304e0b7d8d1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I9d02c7c5f082088a6a3d7d9f95f276a24fa68737 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6655689 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 9e629bbb 2025-06-20T07:49:41 Roll Chromium from ad04c4bcf5c3 to 558ed507cbc4 (156 revisions) https://chromium.googlesource.com/chromium/src.git/+log/ad04c4bcf5c3..558ed507cbc4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/68ebe7a23d..ed15b02ce4 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/4b48c46a57..4e8c09e96b * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/3c116585c2..f43e2cc47f * third_party/android_build_tools/error_prone/cipd: RiplT9oTSE0lQHviAF6FMk5P9863t0-WHcl2te12hi0C..KOECi08Fw4fRTVXkKocxg94coB-e_dlcHRokC21yxyoC * third_party/android_build_tools/lint/cipd: 3bWjs4NjBtTIXoWH03nPx8c--ehZzlDkL8PUE_GaPKUC..Ddt_nMFT2APf615MrUZPaZpe-MqZSNrJmk8s9ud-f3gC * third_party/android_build_tools/manifest_merger/cipd: AFWUMAcwcd0L1DG2-ib4ghtQYFsCvZjWuQkhuTJl4ToC..JcTHGCKOl5tWhax5LSv_vf5dQV14RZdPF9xSRKU76JgC * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3f633ff2f9..9a17210302 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/66ae6e2bd8..e09972e094 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/0f5d505e9f..e0f7527112 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/4c7b4a2749..299c639544 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/85829f8649..854c2669c7 No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: Id969db10acb146fe01d62d62aba87f8ea0cb1e1b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6655687 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 9e24b0b1 2025-06-19T20:32:21 Manual roll vulkan-deps from 3517bebf7845 to 1c18b20944ca (4 revisions) Manual roll requested by syoussefi@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/3517bebf7845..1c18b20944ca Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/05cfcc1613c28c1274036f53616d66324f7cd383..21b4e37133868b3a50ef15fc027ecd6d3a52c875 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/dab29fb163948c142b33f0176eb8baa086fa5df3..da0ec29bb41cbba8af5920c81ee990536a4f6492 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/0bab7fb4fbccc967ca50db3466ef5c48c9f2950f..d004bbbbeb7e1bfe79533522af631bacec407ad2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,geofflang@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com,syoussefi@google.com Change-Id: I8c2831568c85b8b6f503c9068fce116f74f93731 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6654835 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang 98d2d5d8 2025-06-19T14:44:21 WebGPU: Add missing WebGPU suffix for perf tests. Bug: angleproject:419821694 Change-Id: Ic509df3fbd270ffc2a8f91c1565d673fb82a6bd2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6652900 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang 5d124404 2025-06-17T17:04:12 WebGPU: Fix bind groups leaking in CommandBuffer. Wrap all per-submission member variables in a struct so that we can reset everything at once using the default constructor. This avoids similar leaks in the future. Bug: chromium:413078308 Change-Id: I3f926c82905b73b27d6b751cfe2878a41ced916a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6652290 Reviewed-by: Matthew Denton <mpdenton@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi 64951493 2025-06-19T14:47:24 Manual roll vulkan-deps from 222889ea0395 to 3517bebf7845 (45 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/222889ea0395..3517bebf7845 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/e088d553426a3036270701d07dde28bf33d318be..da60ac4327af194dfa773a07db6cd5d5aaa6848d https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/50daff941d88609b4d2ad076eae558e727f8e5cd..2a611a970fdbc41ac2e3e328802aed9985352dca https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/e0bad2825dacf274578ec6d3c0e64e406d5e4fd7..dab29fb163948c142b33f0176eb8baa086fa5df3 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/1d6c53f65443ceeb97d3bdc695aaecc7ea6cc441..b39ab380a44b6c8df462c34e976ea9ce2d2c336b https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/63b05d2b087952662623de7eddd44f2e57d71a1e..dc6786e527cf8cefd244318f546b3b2ec26e84f4 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/fbe722654b7173da961398cf78bd4a62d1839b65..d671923090e4dc74c0ebdb10c6e09fa0826e1fe9 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/e48ae20a7938b01aee62806bfcdafe8a0883b1e4..54c9baf20802a13279e23fa4cb0528dd5cf16064 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/6d6e6ec8e51cd219498359cbc48e4762d1a80616..0bab7fb4fbccc967ca50db3466ef5c48c9f2950f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I20f12f2c5df65f356b2d4ecb6942ebcae0a71384 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6657062 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll ad7db36c 2025-06-19T18:31:26 Manual roll Chromium from f799bcdd69c9 to ad04c4bcf5c3 (768 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/chromium/src.git/+log/f799bcdd69c9..ad04c4bcf5c3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/6311c38ef2..68ebe7a23d * buildtools/linux64: git_revision:54169531ed6da64425ad6e8e9535945c8f6220d0..git_revision:97b68a0bb62b7528bc3491c7949d6804223c2b82 * buildtools/mac: git_revision:54169531ed6da64425ad6e8e9535945c8f6220d0..git_revision:97b68a0bb62b7528bc3491c7949d6804223c2b82 * buildtools/win: git_revision:54169531ed6da64425ad6e8e9535945c8f6220d0..git_revision:97b68a0bb62b7528bc3491c7949d6804223c2b82 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/77495fa0f9..4b48c46a57 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/7b109e5560..e3d58ba1a2 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/b31bc302aa..8a80ddf29e * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/5b85fe2b7c..116ec83ba8 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/377f55f382..3f633ff2f9 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/3d71fc6b43..66ae6e2bd8 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/5166221f85..0f5d505e9f * third_party/r8/cipd: vyND5ed7BNCedbc49JaNOodeA7NrhM08caDYzWEh4PoC..kgSCvDyebyXaL6suvPTOC8fS-Wsu-SmeFTrIkT51K14C * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/f9255e9cc4..274de19b1d * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/5b41c48c17..4c7b4a2749 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/2d39541093..85829f8649 No update to Clang. Bug: None Tbr: geofflang@google.com,ynovikov@google.com Change-Id: Ibe57bb67f8f3ba14df762fe0dfd3ed3253960e06 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6657245 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov ad7f595d 2025-06-19T18:20:15 Set src/common/base "Update Mechanism" Bug: chromium:419410757 Change-Id: Ib2a980edd6e7c9b9790c31c8fb6002d58da4a08f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6650800 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi f48fcb46 2025-06-19T07:11:48 Revert "Metal: Wraparound int arithmetic for add, sub" This reverts commit 2f6f0514563d81e439e04ba09eee9e8a1d6ca8d1. Reason for revert: Leads to MSL compiler errors: > error: non-const reference cannot bind to vector element Bug: angleproject:382215759 Original change's description: > Metal: Wraparound int arithmetic for add, sub > > Implement wraparound int arithmetic for > int, ivec +, -, +=, -=, ++, --. > > All of the added tests pass also without the changes. > > Bug: angleproject:382215759 > Change-Id: I7605582ab2931e63010c34fba474797f7edd19f9 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6578729 > Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Geoff Lang <geofflang@chromium.org> > Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com> Bug: angleproject:382215759 Bug: chromium:425746892 Change-Id: I831d96c6ee7b8bcdeaa08fbf32d430def87a3c30 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6656001 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Kai Ninomiya 41144603 2025-06-06T10:56:03 WebGPU: Handle Dawn breaking change in CreateInstance Needed in order to update Dawn to match the standard webgpu.h, here: https://dawn-review.googlesource.com/c/dawn/+/245242 Bug: chromium:414868137 Change-Id: I2bdf5bd5747a8da8ed0612a99d70eee8a3d09ecb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6652516 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Auto-Submit: Kai Ninomiya <kainino@chromium.org>
angle-autoroll 2f18b71d 2025-06-19T03:01:28 Roll SwiftShader from 47399fc146fa to 0ce9bc68d3fc (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/47399fc146fa..0ce9bc68d3fc 2025-06-18 swiftshader.regress@gmail.com Regres: Update test lists @ 47399fc1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I2095406397416037393189eb94ee32135d9717b8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6655415 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao 59281334 2025-05-22T17:13:22 Vulkan: Reduce kMaxEmptySlots for SharedDescriptorSetCacheKey There is report that addKey is still showing up in simpleperf. This CL breaks addKeyImpl into three functions so that SharedFramebufferCacheKey will still have the same behavior. SharedDescriptorSetCacheKey is changed to track 64 cache key at maximum, and updateEmptySlotBits() is never called in SharedDescriptorSetCacheKey. This means the shared cache key tracking is further limited to usage case where a buffer/texture is only involved in less than 64 descriptorSets. Otherwise we will not track the remaining DescriptorSets, which means if this buffer is released, the corresponding descriptorSet will not immediately destroyed, and we will rely on cache eviction code to take care of DS growing problem. Bug: b/384839847 Change-Id: I99abd17966446377babace6d06cc8f380a71c084 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6581492 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Geoff Lang dea162cc 2025-06-09T15:43:05 WebGPU: Finalize command blocks when starting a new one The command buffer abstraction would not finalize blocks of commands when creating a new block, leading to possible infinite loops when processing the commands. Bug: chromium:413078308 Change-Id: Idf4e95a5ccc71f3ddc9a4202e5e000c0e2cd5f87 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6629473 Reviewed-by: Liza Burakova <liza@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Mohan Maiya 9d70781f 2025-06-17T07:06:37 Vulkan: Bugfix in TextureVk::initImage(...) Account for compute based mipmap generation during initImage Bug: angleproject:405840226 Tests: ImageTestES3.SourceAHBTargetTexture2DGenerateMipmap* Change-Id: Ic2f6c4576ec8ff464a5d60c4a49aeb87be3a5785 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6650712 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
angle-autoroll aa23ec21 2025-06-18T09:11:41 Roll Chromium from 9832934fc40b to f799bcdd69c9 (636 revisions) https://chromium.googlesource.com/chromium/src.git/+log/9832934fc40b..f799bcdd69c9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/71742cf0df..6311c38ef2 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/175c1fa28c..b2eba427b8 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/c2344f7d79..77495fa0f9 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/84b990c066..7b109e5560 * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/34bf3dd2d9..3c116585c2 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/83a7b85088..b31bc302aa * third_party/android_platform: https://chromium.googlesource.com/chromium/src/third_party/android_platform/+log/98aee46efb..e97e62b0b5 * third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/67418b87fc..e71ef403c5 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/4481cd5a9f..5b85fe2b7c * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2ac2988f7b..377f55f382 * third_party/ijar: https://chromium.googlesource.com/chromium/src/third_party/ijar/+log/4b6f53ee62..935be444d6 * third_party/jinja2: https://chromium.googlesource.com/chromium/src/third_party/jinja2/+log/5e1ee241ab..c3027d8849 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/ced0173352..3d71fc6b43 * third_party/markupsafe: https://chromium.googlesource.com/chromium/src/third_party/markupsafe/+log/9f8efc8637..4256084ae1 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/d0fb5d4f4b..5166221f85 * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/567abeb822..f9255e9cc4 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/470d3a2ee4..4028ebf871 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/147c7317c0..dd092af0a1 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/3c75c1e0b9..5b41c48c17 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/372f32c9bd..2d39541093 * tools/valgrind: https://chromium.googlesource.com/chromium/src/tools/valgrind/+log/6e97bd1a16..5ba62550b2 No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: Ib0ca9d9b99eca6354d1beec358fd198e30459fa0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6653847 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amirali Abdolrashidi 9e000857 2025-02-04T16:12:47 Vulkan: Utilize VkBufferUsageFlags2 for bufferview * Added the following struct to bufferview createInfo in case of VK_KHR_maintenance5 support: VkBufferUsageFlags2CreateInfoKHR * Limited VVL 08779 to platforms without KHR_maintenance5 support. Bug: angleproject:394353300 Change-Id: I46beac693cda3216afc497c8ed74cbf51b72e549 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6231512 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Cody Northrop 67b3702d 2025-06-17T11:19:17 Infra: Add smoke trace list, use with ASAN Add a config that can reduce the traces used in our CI. It uses a curated list of traces to provide coverage of engines. Use the list with our ASAN builder to greatly reduce build time. Bug: b/421425259 Change-Id: I1b23eee4b96ad1ca21c121ec405b751f58e74e6b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6652311 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Charlie Lao <cclao@google.com>
Martin Arjovsky a2b84cc0 2025-06-17T09:47:58 Fix bug in translator fuzzer. We were incorrectly checking a type against a spec. bug: angleproject:425580663 Change-Id: I7a57852b143ea26a41414015414d43720e2e53b1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6650788 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Matthew Denton 243ebfa7 2025-06-16T16:07:06 WebGPU: Allow glReadPixels from non-base mip levels. Before, the WebGPU backend always read from the base level of the texture attached to the current framebuffer. Bug: angleproject:42267090 Change-Id: Ibe5b8575f6fa90c1942ba566485b6175ee10f808 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6634558 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Auto-Submit: Matthew Denton <mpdenton@chromium.org>
angle-autoroll 45ac6404 2025-06-17T03:01:55 Roll SwiftShader from 7b7b93aa0b85 to 47399fc146fa (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/7b7b93aa0b85..47399fc146fa 2025-06-16 swiftshader.regress@gmail.com Regres: Update test lists @ 7b7b93aa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I32db1c1ff658b01307ffdd574025ae45ef5c7b02 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6650656 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 84119cb6 2025-06-17T08:50:25 Roll Chromium from 1a2e111b764d to 9832934fc40b (653 revisions) https://chromium.googlesource.com/chromium/src.git/+log/1a2e111b764d..9832934fc40b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/97494799c2..71742cf0df * testing: https://chromium.googlesource.com/chromium/src/testing/+log/cdb084b125..c2344f7d79 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/fcd0e32b73..83a7b85088 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/9e57472d99..4481cd5a9f * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d4c627ed62..2ac2988f7b * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/a2f7b489cd..ced0173352 * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/886355a984..567abeb822 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/b0469a039c..147c7317c0 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/123fb93db6..3c75c1e0b9 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/a9c048e6f6..372f32c9bd * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/096f45497e..6c0ba3465b Clang version changed llvmorg-21-init-15009-g841a7f08:llvmorg-21-init-11777-gfd3fecfc Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/123fb93db6b179a3a651bf92e1def7e7856639f6..3c75c1e0b9501817a0c1012152c2f846b29761ac/scripts/update.py Bug: None Tbr: geofflang@google.com Change-Id: I7220762fe25ae4198569df1f09069afe684320ab Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6650708 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shufen Ma db70fca6 2025-06-11T16:59:36 Add a separable program test ES 3.2 spec section 7.4.1 Shader Interface Matching is vague about the case when a program has more than one shader whose interfaces do not match and the program is set to GL_PROGRAM_SEPARABLE by glProgramParameteri API. Angle implementation thinks it is not right and the program is not linked. But since the shaders are attached to one program, the program should have enough information to link. Bug: angleproject:424050949 Change-Id: Icb9c8cbff906671beb6679309795f5c1b3acec6f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6636452 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Shufen Ma <Shufen.Ma@arm.com>
Aurora Zhang dfefcbc6 2025-06-09T16:30:55 glGetProgramiv should return the properties in effect glProgramParameteri can set values to GL_PROGRAM_BINARY_RETRIEVABLE_HINT. However, this setting will not be in effect until the next time glLinkProgram or glProgramBinary has been called successfully. Also, glGetProgramiv returns the properties currently in effect for program. Therefore, we need to add a variable to record the ineffective value and copy it at the stage of glLinkProgram or glProgramBinary. Bug: angleproject:421219220 Change-Id: Ib564e6df03d34f3fc7389f926795cb3e64cbf687 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6606372 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Aurora Zhang <Aurora.Zhang@arm.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Kimmo Kinnunen 94ee620d 2025-05-22T10:07:05 Metal: Allow optimization of simple loops Reimplement the feature to avoid undefined behavior of infinite loops. Add EnsureLoopForwardProgress rewrite pass that inserts a volatile variable access to all loops that it cannot analyze as being finite. Detect loops of form `for (; i <op> x; ++i)` as being finite. The <op> can be any of <,<=,>,>=,==, != operator. The i can be int or uint. The ++i can be -- or ++, -=1, +=1. This assumes that backends using the feature emit signed int arithmetic with defined wraparound semantics. Uses volatile write instead of asm("") due to asm not forcing the behavior in some compiler versions. The volatile variable access is defined in C++ as forward progress, and by inheritance this works in MSL. Later commits may remove injectAsmStatementIntoLoopBodies if ensureLoopForwardProgress is appropriate for all use-cases. Bug: angleproject:418918522 Change-Id: Ic9c29f57044b792195386483208632354d24c854 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6575051 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com>
angle-autoroll 543b6cf6 2025-06-16T07:02:58 Roll Chromium from 5d8e5baf56fe to 1a2e111b764d (773 revisions) https://chromium.googlesource.com/chromium/src.git/+log/5d8e5baf56fe..1a2e111b764d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/cb527f4b98..97494799c2 * buildtools/linux64: git_revision:899572b32b8bb610cfeeefd162d9aefb46e29d97..git_revision:54169531ed6da64425ad6e8e9535945c8f6220d0 * buildtools/mac: git_revision:899572b32b8bb610cfeeefd162d9aefb46e29d97..git_revision:54169531ed6da64425ad6e8e9535945c8f6220d0 * buildtools/win: git_revision:899572b32b8bb610cfeeefd162d9aefb46e29d97..git_revision:54169531ed6da64425ad6e8e9535945c8f6220d0 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/dd6fb44bdc..cdb084b125 * third_party/android_build_tools/lint/cipd: Otd2S_y5ozK3q8Q7eMr1NqNH38ESBnUYT4I842UsU0UC..3bWjs4NjBtTIXoWH03nPx8c--ehZzlDkL8PUE_GaPKUC * third_party/android_build_tools/manifest_merger/cipd: UrgRDTQRxa2KqkIGo6gwYOY7uf56hYmH-QAjov2N9NMC..AFWUMAcwcd0L1DG2-ib4ghtQYFsCvZjWuQkhuTJl4ToC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/6abf1d7a33..fcd0e32b73 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/1d50003d81..9e57472d99 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/1f64d055db..a2f7b489cd * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/345a48f432..d0fb5d4f4b * third_party/r8/cipd: F0pTWc6uG70kZPngypnQxCgD3CgY5D8O-pDqj_qeoQMC..vyND5ed7BNCedbc49JaNOodeA7NrhM08caDYzWEh4PoC * third_party/siso/cipd: git_revision:d704490133011610c402696584afedea80829dbd..git_revision:7e7d85fc69f9084d2168385fb504b31e830dbfff * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/479e8c395f..b0469a039c * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/7e6f482ce7..123fb93db6 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/5730d2a457..a9c048e6f6 * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/11d67ba328..096f45497e Clang version changed llvmorg-21-init-11777-gfd3fecfc:llvmorg-21-init-15009-g841a7f08 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/7e6f482ce7bf792e6cb034b57285b766c5df1355..123fb93db6b179a3a651bf92e1def7e7856639f6/scripts/update.py Bug: None Tbr: geofflang@google.com Change-Id: I1d533ef366c9cc16d05983a994576aaf000b95e2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6643467 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuxin Hu 79ec8b34 2025-06-12T14:32:42 Fix glCopyImageSubData validation check When checking if the copy subregion meets the compressed texture alignment requirements, we should consider if the copy subregion covers the entire width and height of texture level. It is not required to make texture size aligned with compressed texture block size when creating the texture image (e.g. width and height do not have to be multiple of 6 when calling glTexStorage2D for GL_COMPRESSED_RGBA_ASTC_6X6 textures). If the copy subregion width and height equals to the width and height of the texture level, even if they are not aligned with the compressed texture block size, the copy is allowed. This is currently covered by fillsEntireMip check. However, fillsEntireMip enforces copy subregion width, height, and depth all equal to the texture level width, height, and depth, where we should not check depth because we don't enforce depth alignment for compressed texture. For example, for a 2D texture array that has dimension of 32*16*2 in current level, a copy region with width=32, heigh=16, depth=1 should be considered as fillsEntireMip. In the spec, it says: "The source and destination subregions must be contained entirely within the specified level of the corresponding image objects". Right now we only check if width and height are within the image bounds, this change adds a check to make sure depth is also within the image bounds. Bug: b/419048313 Change-Id: I6e5339cfdfd5785f935a059638c22c9646c12162 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6634232 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 26d5d4e2 2025-06-13T14:24:29 Avoid OOB access in Load* functions Bug: angleproject:424695342 Change-Id: I245612a41d55026c615ca0185af76a153c9fe3ec Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6642699 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
kmx.io     mail     discord kmxgit v0.4.0