kc3-lang/angle

Log

Author Commit Date CI Message
Ian Vollick 9199e77d 2023-03-30T17:25:33 [ios] simulator fixes for angle_unittests Disables some tests that do not currently work in the iOS simulator. Bug: angleproject:8116 Change-Id: I66bb9a6e2a5d10a567824e9fac163e7fd6b6a474 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4393495 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org>
Shahbaz Youssefi 8b79410b 2023-04-02T22:25:12 Vulkan: Treat readonly SSBOs as readonly! Instead of assuming SSBOs are always written to, this change adds plumbing for the backend to know when an SSBO is declared readonly and marks the buffer readonly accordingly. With this change, BufferVk can optimize uploads and copies to and from the buffer with the knowledge that it can be safely mapped on the CPU for read while it's being used by the GPU. Bug: b/276002151 Change-Id: I75342148c07949a83436054a738395bbd88caec5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4392720 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 25e60197 2023-03-31T14:17:26 Vulkan: Unify buffer alloc strategy for uploads and GPU copies With this change, glCopyBufferSubData uses the same buffer allocation strategy as glBufferSubData. Only exception is with buffer self-copies which never allocate a new buffer for simplicity. Additionally, this change allows glCopyBufferSubData to be done on the CPU if possible, i.e. if the source buffer is not being written to by the GPU and whenever the equivalent glBufferSubData would have used a CPU upload. Bug: b/276002151 Change-Id: Ice8df5891c5516b148245d5d6fa9b19b787df4ce Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4390023 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Maksim Sisov 746798b2 2023-03-31T11:35:33 Allocate buffer via malloc for demangle. abi::__cxa_demangle requires that the output buffer passed for demangling is malloced according to the documentation as (quote) - "If output_buffer is not long enough, it is expanded using realloc". Not doing that results in raising exceptions and calling the angle's exception handler recursively many times. That results in a huge stacktrace as a result, which is printed until the program is terminated. Bug: angleproject:8111 Change-Id: I7ddd1a623b55fef2c8b15f40136312dd0ff4ccaf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4386396 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov b49f9520 2023-04-03T18:11:04 Trace Interpreter: Improve ReadFileToString performance. Shaves off ~1s (~15%) from ~7.5s parse time on Panther for minecraft_bedrock trace. Switches the stream to std::ios::binary so on Windows the caller will need to handle \r\n Bug: b/276742336 Change-Id: I0c14e76168763875da60a0fdefb879859b0b3d0c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4392894 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov b30c05de 2023-04-04T09:36:28 Trace Interpreter: Add #include <algorithm> ANGLE-Dawn roll failed with: error: no member named 'lower_bound' in namespace 'std' Bug: b/276742336 Change-Id: Ife3d83aaa2b9f29f3750e880a12dfccf3f8fe915 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4391765 Auto-Submit: Roman Lavrov <romanl@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao 41f0a321 2023-04-03T21:58:43 Revert "Vulkan: Reactivate already started render pass when possible" This reverts commit ad9537af7f2bb5e22bc73f4e833fd3789adaa217. Reason for revert: Suspected cause for flakiness. anglebug.com/8118 Original change's description: > Vulkan: Reactivate already started render pass when possible > > In some usage case (such as lineage_mobile), we are seeing in the middle > of render pass, app switch to another fbo just to issue a glClear() > call, which the clear call itself gets deferred. Application then switch > back to the original frame buffer. Before this CL, the render pass gets > recreated due to frame buffer binding change, even though the clear gets > deferred and new render pass and the previous render pass are > essentially the same. This CL detects this situation and reactivate the > current render pass instead of creating a new one. With this CL, > lineage_m app trace reduces frame time from 3.86ms to 3.7ms, and only > one render pass is used instead of two. > > This CL also allows the render pass started by BlitFramebuffer reused by > subsequent draw calls. Asphalt_9 is hitting this use pattern and this CL > reduces frame time by 0.1245 ms (from 5.6203 ms to 5.4958 on pixel 7 > pro) > > Bug: b/273808966 > Change-Id: I48c2671cbef3ff9d6cf59caae88c37c77828ee07 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4348713 > Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Charlie Lao <cclao@google.com> Bug: b/273808966 Change-Id: I81cc2dcacb52466808b2ccf5819feda466c39fc5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4396502 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 6a94ed77 2023-04-04T10:01:35 Roll vulkan-deps from e671d7c87d3b to ec231c69caa6 (6 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/e671d7c87d3b..ec231c69caa6 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/f8a2442a16..77f7cdfb1e * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/6b72fe20c5..ac335c7634 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/67e4c7f87b..21078b582d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I241a56c924f374c6330c744c8aa431a93532a33d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4397636 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 3aea3cfd 2023-04-03T16:38:29 Vulkan: Workaround depth bias constant factor on ANV Bug: b/249380591 Change-Id: Iaeda7faf5eb40e0e2086674d3e63bf5bc9911ab4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4392893 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov c723d71f 2023-04-03T16:17:01 Trace Interpreter: Improve StringToGLenum performance. Binary search instead of linear. This gets called a lot when parsing traces to be run by the trace interpreter. I saw ~37 seconds parse time on Panther for minecraft_bedrock trace, this CL makes that ~5 times faster. Bug: b/276742336 Change-Id: Ide32c247b327f36c00f26951a90e4412d71db2b6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4392892 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Charlie Lao 96cda1ac 2023-03-31T15:08:11 Vulkan: Switch to modified framebuffer should trigger submit The feature flag preferSubmitAtFBOBoundary intended to trigger submitCommands call when FBO is switched. Right now there is a bug that when FBO is switched, submitCommands did not get called even if feature is enabled. The reason is that when framebuffer changed, we first get FramebufferVk::syncState call, and if the FBO that we switched to is drity, we will end up calling ContextVk::flushCommandsAndEndRenderPass to immediate end the render pass. The problem with that is that later on when we get to ContextVk::syncState and saw DIRTY_BIT_DRAW_FRAMEBUFFER_BINDING dirty bit and try to issue a submit, we notice render pass already ended, so mHasDeferredFlush never gets set, which means we never call submitCommands. All apps render to system framebuffer in the last render pass, and system framebuffer is always dirty due to swap chain image rotation, we hit this almost with every app. This CL avoid flushCommandsAndEndRenderPass() call from FramebufferVk::syncState. We now relies on ContextVk::onFramebufferChanged (which calls onRenderPassFinished() which will set DIRTY_RENDER_PASS bit to trigger deferred endRenderPass) to end the current render pass. This CL also add a regression test to ensure the submit indeed occur. Bug: b/275624771 Change-Id: I92b95a7a6c435f242d6684cb7852172cf41896c3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4390642 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Roman Lavrov <romanl@google.com>
Shahbaz Youssefi c5e9de23 2023-04-03T15:14:03 Revert "Vulkan: Use midRenderPass clear if RP has started but inactive" This reverts commit 98151770adfd990c533991da27615b4879494307. Reason for revert: Suspected cause for flakiness. anglebug.com/8118 Original change's description: > Vulkan: Use midRenderPass clear if RP has started but inactive > > This CL extends prior CL's optimization so that if clear is issued right > after blitFramebuffer call (this could make sense if blit and clear are > on different buffer), we can keep the started render pass and do the > midRenderPass clear instead of endRenderPass and start another > renderPass. > > Bug: b/273808966 > Change-Id: Ia2504e8e260867a6f797d42cd4c8a72f187280ef > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4374145 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Bug: b/273808966 Change-Id: I7a11635a6eceafb6f4fb3a0d95f6627ee98321c0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4393497 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang f1f80e1e 2023-03-22T12:54:08 Metal: Always prefer staged GPU uploads for textures. Uploading Metal texture data via MTLTexture::replaceRegion is a source of lots of CPU hangs and jank. There may be better heuristics to determine if we should do a CPU vs GPU upload but for now preferring GPU uploads has better overall performance. This also improves the MotionMark images test: - 40 -> 100 when using Metal. - 217 -> 235 when using Metal + https://chromium-review.googlesource.com/c/chromium/src/+/4091749 Bug: angleproject:8024, angleproject:8092, angleproject:8109 Change-Id: I36b5f585884391b4cc416365ae65f8542745beee Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4264963 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Igor Nazarov ec307af4 2023-03-30T14:17:52 Fix bug in DeallocateGlobalMutex(). Bug: angleproject:6851 Change-Id: Ie5dd32220a38a9b7a9a18ff830a4ee7b7c02b9c3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4381863 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com>
Igor Nazarov a1319e7f 2023-03-29T20:09:48 Tests: Fix EGLContextSharingTestNoFixture.SwapBuffersShared. Sometimes `swapThread` may finish until `renderThread` wait for `Step::TextureInitialized` step. In this situation `swapThread` will change `currentStep` to `Abort` in the `ThreadSynchronization<>` destructor, causing wait for `Step::TextureInitialized` to fail. Bug: angleproject:6851 Change-Id: Ib08b6de11873e9959eaa810bcf8cb404c95c80d4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4381626 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>
angle-autoroll d57a322e 2023-04-03T10:01:24 Roll vulkan-deps from bb601a935e1d to e671d7c87d3b (14 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/bb601a935e1d..e671d7c87d3b Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/45405e1d94..f8a2442a16 * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/0c34d02861..63af1cf1ee * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/5bc74b04c8..c3eb97de22 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/e60c43a479..4ad4313da0 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/75fce29052..67e4c7f87b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I9f741cedfa6a31df7c481f01068e2afcc726a74a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4394263 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 52286481 2023-04-03T10:01:20 Roll SwiftShader from c85d70d97009 to 3ecab9c1aa60 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/c85d70d97009..3ecab9c1aa60 2023-04-03 stha09@googlemail.com IWYU: add cstdint for uint64_t in sw::LRUCache If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: Idb9a1c7ab2782456dde98a0ffb58d8e40fdf73b3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4391555 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll f4af659f 2023-04-03T07:00:19 Roll Chromium from 1393a98c62ae to 198e6d1c360e (603 revisions) https://chromium.googlesource.com/chromium/src.git/+log/1393a98c62ae..198e6d1c360e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/0cdf15da5b..b3fc6af816 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/76bdd92e1c..cb5d17004e * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/6f868b2003..ab37483b42 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/5e393c2f70..124d121ec0 * third_party/android_platform: https://chromium.googlesource.com/chromium/src/third_party/android_platform/+log/1bf9b93243..ed245f0bcb * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..fdcbdb2b3e * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0c99af9051..401f0f6e43 * third_party/fuchsia-sdk/sdk: version:12.20230330.3.1..version:12.20230402.3.1 * third_party/r8: pt0cSjlfhgFLaZ3goeJsF_ejKlOjod7amOkEGzTWIkwC..GcQ-oelMmVQMKFpvjCNroGxPCOnapQAHbIqjjSymmCAC * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/eeb51e8ca2..45fb5a967f No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: I047cda30304f308ace21b0dec43fbf93efcb40b2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4394183 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexey Knyazev b24b5568 2023-03-27T00:00:00 Vulkan: Skip sample coverage for single sample rendering A new test sets sample coverage to zero and checks that it is applied only to multisampled rendering. Bug: angleproject:8102 Change-Id: I1a5649869e9b7ecf0543108fb99095bfaf6fd858 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4379839 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Cody Northrop 55fbc2c5 2023-03-31T13:15:19 Revert "Tests: Add Gacha Life trace" This reverts commit 98deaef0ebf2709f45e75e5571bb52aa4c8d6246. Reason for revert: angle_trace_test_apk is too large to sign Before this trace, if you compiled the APK with all traces enabled, we were right on the edge of MAX_INT (2147483647). ApkSigner doesn't support 64-bit offsets. Original change's description: > Tests: Add Gacha Life trace > > Test: angle_trace_tests --gtest_filter="*gacha_life*" > Bug: b/267382443 > Change-Id: I6bbfb28015bf0317ccdba699e08ce6bce51b4ce3 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4211589 > Reviewed-by: Roman Lavrov <romanl@google.com> Test: autoninja -C out/AndroidPerformance angle_trace_tests Bug: b/276474703 Change-Id: I1a3fd6386f20dc498e4f8c8b147d4431277ecc50 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4387371 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Roman Lavrov <romanl@google.com>
Maksim Sisov 61cd24d4 2023-03-31T14:54:17 MTLPixelFormatRGB9E5Float is not renderable on simulator. See https://developer.apple.com/documentation/metal/ developing_metal_apps_that_run_in_simulator?language=objc Bug: angleproject:7994 Change-Id: I07e50c19aaf6d033c7c25d0dbd4b21a8c255c1d9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4386403 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org>
Kimmo Kinnunen f176027f 2023-03-31T13:37:03 CGL: implement EGL_ANGLE_wait_until_work_scheduled It is as important to wait until scheduled in CGL, as it is in Metal. CGL waits until scheduled when glFlush() is called. Fixed: angleproject:8112 Change-Id: Id4a9e87804c6df1828b35cfd30c8427314820e52 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4386400 Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Shahbaz Youssefi 552d4271 2023-03-31T10:59:30 Vulkan: Refactor buffer init logic Bug: b/276002151 Change-Id: I28d3fa34ab11340cc8b38743e87664a514870068 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4388547 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Cody Northrop 98deaef0 2023-03-30T19:15:24 Tests: Add Gacha Life trace Test: angle_trace_tests --gtest_filter="*gacha_life*" Bug: b/267382443 Change-Id: I6bbfb28015bf0317ccdba699e08ce6bce51b4ce3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4211589 Reviewed-by: Roman Lavrov <romanl@google.com>
Constantine Shablya e975f9dc 2022-11-09T06:44:06 Capture/Replay: handle paletted textures Add a method for recompressing paletted textures on capture. Bug: angleproject:7710 Change-Id: I11af0c1cd7c3b63850c5daf96eafcd3efce65f16 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4178311 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi 336bfd60 2023-03-30T00:16:40 GL: Fix the RewriteRepeatedAssignToSwizzled workaround This transformation splits chained assignments where the LHS is assigning to a swizzle. However, instead of retaining the assignment operator (like *=, += etc), it was accidentally unconditionally using `=`. Bug: chromium:1394345 Change-Id: Icaef159e1fb57e720e08d4b4f6603f08d9cd2bfe Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4381648 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
angle-autoroll e9f57b07 2023-03-31T13:46:22 Roll VK-GL-CTS from e873c6862868 to a3d054bf72ab (4 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/e873c6862868..a3d054bf72ab 2023-03-31 rgarcia@igalia.com Add dynamic state test with NULL color blend pAttachments 2023-03-31 rgarcia@igalia.com Avoid killing program when --help is used 2023-03-31 piotr.byszewski@mobica.com Merge vk-gl-cts/vulkan-cts-1.3.5 into vk-gl-cts/main 2023-03-30 ziga@lunarg.com Add tests for vkCmdBindVertexBuffers2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: Id7d2f3951eec9a96fd2bb2560b8264129484220a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4385569 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop f066ae7d 2023-03-30T19:01:17 Tests: Add Teslagrad trace Test: angle_trace_tests --gtest_filter="*teslagrad*" Bug: b/276316424 Change-Id: If4056451ba3b948ade8466f93560694f76ab53c5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4385779 Reviewed-by: Roman Lavrov <romanl@google.com>
Colin Blundell 6458cd95 2023-03-30T14:27:07 [GL backend] Remove over-zealous ASSERT in StateManagerGL.cpp StateManagerGL::bindVertexArray asserts that the passed-in |vaoState| pointer is non-null; however, we actually pass in null directly in [1]. This assert goes off when running a WebView test with ANGLE. [1] https://source.chromium.org/chromium/chromium/src/+/main:third_party/angle/src/libANGLE/renderer/gl/StateManagerGL.cpp;l=3385;drc=48340c1e35efad5fb0253025dcc36b3a9573e258;bpv=1;bpt=1 Bug: chromium:1168587 Change-Id: I14d5f9f317f3cbe2a828ab7637edc5f1911bf81c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4381861 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll 090c6fad 2023-03-31T10:01:39 Roll vulkan-deps from e13e8828cf66 to bb601a935e1d (9 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/e13e8828cf66..bb601a935e1d Changed dependencies: * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/8e64f8ee40..3327924add * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/f96cf9a2b6..75fce29052 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I01c8a234728c1c8e3d5afc64202dccbb6fc57f58 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4385568 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov a3a649b0 2023-03-31T09:16:48 Skip BlitFramebufferTest.scissorDrawBlitAndDrawAgain on Mac AMD GL Fails since added in https://ci.chromium.org/ui/p/angle/builders/ci/mac-exp-test/258/overview Bug: b/273808966 Change-Id: I62f8876e4d177983082b3e21e50803c9c7fab0d4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4386397 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll c3c41889 2023-03-31T07:07:00 Roll Chromium from f7c2a70f23b1 to 1393a98c62ae (1678 revisions) https://chromium.googlesource.com/chromium/src.git/+log/f7c2a70f23b1..1393a98c62ae If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/052437a6e1..0cdf15da5b * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/c97a3b8902..76bdd92e1c * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/26ace673c4..6f868b2003 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/9643f2cf13..4a9d0560b4 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/29a6dda8c6..f3464caa6a * testing: https://chromium.googlesource.com/chromium/src/testing/+log/df3b0c9f14..5e393c2f70 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/b5b8912f72..20c8ae002d * third_party/android_build_tools/aapt2: 36NqCian2RIwuM6SFfizdUgKoXyZhy3q6pFfsws0szYC..fFfHyo80O9opPFsbOisSHF4d3tV4GGxLgxXWzGRuY2IC * third_party/android_build_tools/lint: E86vFKi4re9HwIfUW9yq_Ig_hc7Vr0lcl-bO3BtPQLYC..-QeaXYm6b9vGTpMVBhnqlwODS7YvC3vNdvA0KVEz0TwC * third_party/android_build_tools/manifest_merger: _aoHU11YhUwqKZXVXsn5otnhI-ZVGFT7h1Z9eCcAZM0C..zrC8AzHP0aIX3PNRmyIUO6hidQryUwSv65YE8KQEZa0C * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/115fe1141d..c17c192772 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..fdcbdb2b3e * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/df528a9d7a..0c99af9051 * third_party/fuchsia-sdk/sdk: version:12.20230327.3.1..version:12.20230330.3.1 * third_party/kotlin_stdlib: XON2v801ZWS7FjApXO8Ev7Me7cOsIAnmqzyCXJuMwJ0C..gizyEP29NQpAimwviO2pgSrqvx0YgAvSUNc5V6hvfroC * third_party/r8: BTs9W6pUBDK8YTePjjF3Q0-ZQo1snO7GBCT6frWMIj8C..pt0cSjlfhgFLaZ3goeJsF_ejKlOjod7amOkEGzTWIkwC * tools/android/errorprone_plugin: https://chromium.googlesource.com/chromium/src/tools/android/errorprone_plugin/+log/71a32a2f82..a848535fa4 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/04d87bfe25..f686247260 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/993b50afde..eeb51e8ca2 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/892ad5cc94..18e0d7aac4 * tools/skia_goldctl/mac_arm64: Jh19SHnigVXYxpk7Fp4ZDMF_ZvLpQUie2NMaK5aEISMC..432GgeQWQIAz1NADw1ssxRVYDIKzNs1i3tKIITtxDdcC * tools/skia_goldctl/win: pUOVquC14y84RkNMzEAPw_7tztey-kvH7KBwGsFViuIC..aW-NZ8C8eVMaPmBAILqVE-mOxYdoUXfiDHShsTeZMwkC No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: I336b2c934561c9824eab0b97bcdd5278a8831363 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4385566 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Dean Jackson 5fcd027e 2023-03-29T08:54:34 Fix the watchOS build for the mirror clamp to edge extension The mirror clamp to edge extension relies on MTLSamplerAddressModeMirrorClampToEdge, which is not available on watchOS. Disable the extension there for the moment. Bug: angleproject:8103 Change-Id: I52b9d5217b39080cde6663e0d0fa839e53dacecf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4379037 Reviewed-by: Kenneth Russell <kbr@chromium.org>
Charlie Lao 20f3df07 2023-03-30T11:36:29 Vulkan: ImageHelper::initExternal missing some variable init When ImageHelper::releaseImage is called and then re-initialized (due to mipmap change or usage change etc), right now we have a bug that mCurrentShaderReadStageMask and mLastNonShaderReadOnlyLayout are still left as is. And they do not get reset when image is initialized. This means if the image was reinitialized again, it may end up think the new image was previously used by fragment shader and insert an unnecessary barrier when new VkImage is used. This was discovered when I do the experimental work try to ghost VkImage for glTexSubImage call and realized that new VkImage was having a strong fragment->vertex dependency which it should not (since this is a new VkImage). This CL initialize mCurrentShaderReadStageMask and mLastNonShaderReadOnlyLayout and mCurrentQueueFamilyIndex from initExternal call since it is a new vkImage. Bug: b/273808966 Change-Id: I5bbeae5f1012f10c24620cfae8fa20365a7b5ab7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4386136 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao 98151770 2023-03-27T09:49:33 Vulkan: Use midRenderPass clear if RP has started but inactive This CL extends prior CL's optimization so that if clear is issued right after blitFramebuffer call (this could make sense if blit and clear are on different buffer), we can keep the started render pass and do the midRenderPass clear instead of endRenderPass and start another renderPass. Bug: b/273808966 Change-Id: Ia2504e8e260867a6f797d42cd4c8a72f187280ef Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4374145 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao ad9537af 2023-03-16T16:03:29 Vulkan: Reactivate already started render pass when possible In some usage case (such as lineage_mobile), we are seeing in the middle of render pass, app switch to another fbo just to issue a glClear() call, which the clear call itself gets deferred. Application then switch back to the original frame buffer. Before this CL, the render pass gets recreated due to frame buffer binding change, even though the clear gets deferred and new render pass and the previous render pass are essentially the same. This CL detects this situation and reactivate the current render pass instead of creating a new one. With this CL, lineage_m app trace reduces frame time from 3.86ms to 3.7ms, and only one render pass is used instead of two. This CL also allows the render pass started by BlitFramebuffer reused by subsequent draw calls. Asphalt_9 is hitting this use pattern and this CL reduces frame time by 0.1245 ms (from 5.6203 ms to 5.4958 on pixel 7 pro) Bug: b/273808966 Change-Id: I48c2671cbef3ff9d6cf59caae88c37c77828ee07 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4348713 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
angle-autoroll 18b675ea 2023-03-30T12:11:06 Roll vulkan-deps from d56f491466de to e13e8828cf66 (29 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/d56f491466de..e13e8828cf66 Changed dependencies: * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/09e60d74f6..8e64f8ee40 * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/90547c54e2..29ba249312 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f9f31fa5a9..6b72fe20c5 * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/9b9fd871b0..0c34d02861 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/d72476300b..5bc74b04c8 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/211fec7e9a..e60c43a479 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/9124f788b7..f96cf9a2b6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I67e1a6a1227d29895df6df2515def961dd1c9efe Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4384660 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Geoff Lang 3c8aee63 2023-03-27T13:24:47 D3D11: Fix streamed instanced attribute size calculation. D3D11 passes around a 0 instance count to signify "not an instanced draw call". This had an incorrect interaction with ComputeVertexBindingElementCount which checks for an instance count of 0 and skips instancing calculations. Force instance count to be at least 1 when computing buffer size needed. Bug: chromium:1425606 Change-Id: Ia10fa1c11abebce28c57ce4527e2b748e51516ce Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4375138 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Shahbaz Youssefi 48b431ca 2023-03-21T16:39:33 Vulkan: Fix stage component reservations w.r.t xfb Input components limit don't need to reserve any components. This change also fixes a bug where the tessellation evaluation output components didn't reserve a slot for gl_Position. Additionally, the input component count of stages are clamped by the output component count of the previous stages. Bug: b/274289482 Change-Id: Ib5b4243d7a4cb713ccea505a5f0064bf3377caa8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4356115 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org>
Cody Northrop 31321cb3 2023-03-28T09:57:48 Tests: Add Minecraft Bedrock trace This CL adds a new Minecraft trace. The app has changed engines since our first trace, updating to the Bedrock engine. Also, our first trace was recorded on Qualcomm, and the trace does not behave correctly on ARM. This also bumps the original minecraft version, but the content is unchanged. Test: angle_trace_tests --gtest_filter="*minecraft_bedrock*" Bug: b/183647942 Bug: b/197965659 Change-Id: Id65889c65df8a6a3a1560ccbe4fce239982d98de Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4376790 Reviewed-by: Roman Lavrov <romanl@google.com>
Yuxin Hu 29abd5a2 2023-03-06T11:35:45 Explicitly Add Aliased Memory Decoration in SpirV In GLSL, aliased memory qualifier is implicitly available, unless we explicitly specify the memory is restrict: https://www.khronos.org/opengl/wiki/Type_Qualifier_(GLSL)#Memory_qualifiers. However, in SpirV, aliased memory qualifier has to be explicitly specified: https://registry.khronos.org/SPIR-V/specs/unified1/SPIRV.html#AliasingSection This change adds the aliased memory decorations to SSBO if the GLSL does not specify the restrict memory qualifier. This is a temporary workaround to fix the deqp test failures on some android devices. Eventually we would like to waive this test for ANGLE due to alised memory in Vulkan does not suppose to affect SSBOs that have different set/binding, please refer to this Khronos ticket for more details: https://gitlab.khronos.org/Tracker/vk-gl-cts/-/issues/4321 Bug: b/266235549 Change-Id: Ic7afc417a5d421664b60e0413a011314787e14e7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4312130 Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 219776e2 2023-03-28T09:56:25 Roll Chromium from c83e966b4c7e to f7c2a70f23b1 (1902 revisions) Disable Rust toolchain support in standalone ANGLE, to avoid unnecessary dependencies. https://chromium.googlesource.com/chromium/src.git/+log/c83e966b4c7e..f7c2a70f23b1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/32e94e55de..052437a6e1 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/0a6c69640f..c97a3b8902 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/e44019bfac..26ace673c4 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/f132d63e88..df3b0c9f14 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/4189179faf..115fe1141d * third_party/android_sdk/public: 3Yn5Sn7BMObm8gsoZCF0loJMKg9_PpgU07G9DObCLdQC..EWnL2r7oV5GtE9Ef7GyohyFam42wtMtEKYU4dCb3U1YC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..e838386fa0 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/479e1e9055..df528a9d7a * third_party/fuchsia-sdk/sdk: version:12.20230322.3.1..version:12.20230327.3.1 * third_party/kotlin_stdlib: zeFlVAEGvnpaj3JJujWHzRlUiBEm4XeeaMQzVsdW6D4C..XON2v801ZWS7FjApXO8Ev7Me7cOsIAnmqzyCXJuMwJ0C * third_party/r8: EGf7RQo3stt-vPTw69TaMGuNtnOx0Dbk1O-MBquwswYC..BTs9W6pUBDK8YTePjjF3Q0-ZQo1snO7GBCT6frWMIj8C * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/7a7207a7f2..04d87bfe25 * tools/luci-go: git_revision:320bf3ed60cd4d24549d0ea9ee3a94394f2665ce..git_revision:3569ebf36f17a991aa4d26fd6e228cdf6e664d13 * tools/luci-go: git_revision:320bf3ed60cd4d24549d0ea9ee3a94394f2665ce..git_revision:3569ebf36f17a991aa4d26fd6e228cdf6e664d13 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/db6ffdf0ba..993b50afde * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/b55593f4dc..13f0b81ce5 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/b87bb2fac8..892ad5cc94 * tools/skia_goldctl/linux: iQ7zKud-gha6r9hEdwqYWRdOpeAs6gFfDxnviDUt4FQC..CHIKK9YvBNPOM_lAlqkfs4dTTbM6I-AKggA94sfc5PoC * tools/skia_goldctl/mac_amd64: 9Wfje1bt82IO9pJokAt9lboy59X_Pe-s0b4EpmH7RT4C..Gwb7laBBhkBhwP1nIoAb1EwklQ5sEon7g7r76v7jAasC * tools/skia_goldctl/mac_arm64: zihT2Lk2afg0XzIZozuGcZXWv7RJujaDEi_6q7QL4DgC..Jh19SHnigVXYxpk7Fp4ZDMF_ZvLpQUie2NMaK5aEISMC * tools/skia_goldctl/win: we56UJIWxJJ2GkQ_ne0o3oGAr7FBJa5T5Jr1xguLn-gC..pUOVquC14y84RkNMzEAPw_7tztey-kvH7KBwGsFViuIC No update to Clang. Bug: chromium:1292038 Change-Id: Ie7f8204e241101673768257be9c003343bc47256 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4376783 Reviewed-by: Geoff Lang <geofflang@chromium.org>
Geoff Lang bb15ceef 2023-03-27T11:32:30 Remove syncing of extended dirty bits for TexImage calls. All extended dirty bits were synced for glTexImage calls but many of them required valid GL state or a complete framebuffer. This caused errors in the Vulkan backend when we would read and write out of bounds of the framebuffer due to an incorrect render area. Bug: chromium:1410191 Change-Id: I17f156f71ded72761b631ef9842b048a9173c9b7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4374102 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Mark Lobodzinski 14ddf569 2023-03-29T10:00:47 Tests: Add fishdom trace Test: angle_trace_tests --gtest_filter="*fishdom*" Bug: b/275532615 Change-Id: I2c5668db7f9ae9f1cdf87887640fc2faf0758d6d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4374161 Reviewed-by: Cody Northrop <cnorthrop@google.com>
Mike Schuchardt 4afbbe85 2023-03-28T09:08:31 Tests: Add Vainglory trace Test: angle_trace_tests --gtest_filter=TraceTest.vainglory Bug: b/275526619 Change-Id: Ie06afa408d61935c7ab8d4f4f15f38e10b38821a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4376791 Reviewed-by: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi fe45418c 2023-03-28T11:43:23 Translator: Limit the size of private variables in WebGL shaders As a follow up to https://chromium-review.googlesource.com/c/angle/angle/+/3023033, the limit to shader-private variables (locals and globals) is further reduced to 1MB. A variable that large will not fit in GPU registers and will spill to memory, killing performance. Bug: chromium:1427865 Change-Id: I77314d4b891c591cd9a83ad2aebb77d7256f3ada Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4377639 Reviewed-by: Kenneth Russell <kbr@chromium.org>
Shahbaz Youssefi 97897d92 2023-03-27T16:02:57 Vulkan: Work around driver bug with dynamic primitive restart This CL forces the state to be static on buggy drivers. Bug: b/275210062 Change-Id: Ia3391ecb19c3c9d19c05a83e11da8c718513a4e2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4374104 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@google.com>
Shahbaz Youssefi 8b81a3d2 2023-03-27T10:03:34 GLES1: Use ASCII minus in comment Bug: angleproject:7933 Change-Id: I05fb4512594447ff02078f1845c1ceb74c1b27ce Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4374097 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 6d12a280 2023-03-24T00:00:00 D3D11: Support NV_shader_noperspective_interpolation Fixed: angleproject:8096 Change-Id: Ic7c27c735661b2ef8095c81201b2ce0a82ad3ae7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4368472 Reviewed-by: Geoff Lang <geofflang@chromium.org>
Geoff Lang da7dd31f 2023-03-27T11:29:10 GL: Disable extended dirty bit states for internal blits. New GL states have been added to the GL backend and not updated in ScopedGLState which is used to reset internal state for blits. This caused test failures when tests were run in specific orders. Ex: ClipDistanceTest.ThreeClipDistancesRedeclared/ES2_OpenGL:CopyTextureVariationsTest.CopySubTexture/ES2_OpenGL__AToBGRAFlipYUnmultiplyAlpha Bug: angleproject:5160 Bug: chromium:1410191 Change-Id: I805e39bc8c4c7d7d843b43fdc7813dd668919e8a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4374101 Reviewed-by: Peng Huang <penghuang@chromium.org>
Alexey Knyazev 21ffb23a 2023-03-27T00:00:00 Add sample coverage regression tests * SimpleOperationTest.DrawSingleSampleWithCoverage * SimpleOperationTest.DrawSingleMultiSampleWithCoverage Bug: angleproject:8102 Change-Id: Iedc520a2c7d21912c3969ceaf3a8f1ef2ed7eae0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4379837 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 57dd0e5f 2023-03-27T13:05:36 Translator: Initialize out arguments too for WebGL Local variables were initialized for WebGL, but not `out` arguments. However, `out` arguments completely overwrite the passed-in variable at call site, so they should also be zeroed out. Bug: chromium:1425685 Change-Id: Ib2f61a962eea74c4933aafa4d5ad377189cec578 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4375137 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao fcf0ddeb 2023-03-27T15:27:29 Vulkan: Add more blitFramebuffer test UtilsVk::blitResolveImpl() implementation will set up customized program and scissor rect to implement blit. In other CL we may reuse the render pass that started by blit. This CL adds more test to ensure that continiued draw without any state change will continue work properly (i.e, the state destroyed by blit gets restored properly for the follow up draw calls issued by application). Bug: b/273808966 Change-Id: I164803512b334ca467ca08ea3b008b153fac334d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4375099 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
angle-autoroll db3b2875 2023-03-28T15:06:07 Manual roll VK-GL-CTS from 9e822059a32e to e873c6862868 (18 revisions) Manual roll requested by geofflang@google.com https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/9e822059a32e..e873c6862868 2023-03-27 piotr.byszewski@mobica.com Merge vk-gl-cts/opengl-es-cts-3.2.9 into vk-gl-cts/main 2023-03-24 ziga@lunarg.com Add coverage for non-sequential dynamic vertex attributes 2023-03-24 piotr.byszewski@mobica.com Merge vk-gl-cts/opengl-cts-4.6.3 into vk-gl-cts/main 2023-03-24 anholt@google.com Detect fallback texture failures in GL linear border_color tests 2023-03-24 jasuarez@igalia.com Check geometry shaders are supported 2023-03-24 ziga@lunarg.com Add tests for copying disjoint image planes to and from buffers 2023-03-24 michal.jakubek@mobica.com Memory requirements for multiplanar formats, resolve null VkImage 2023-03-24 cturner@igalia.com Fix VUID-vkCmdDecodeVideoKHR-pDecodeInfo-07149 validation error. 2023-03-24 cturner@igalia.com Fix VUID-vkCmdDecodeVideoKHR-pDecodeInfo-07267 validation error. 2023-03-24 gaopan24@hisilicon.com Fix mantissa shift converting float64 to float16 2023-03-24 scerveau@igalia.com vulkan-video: use ESExtractor 2023-03-24 ewerness@nvidia.com Add total runtime instrumentation 2023-03-24 alexander.galazin@imgtec.com Update glslang, SPIR-V tools and headers 2023-03-24 eric@igalia.com Hide warnings about Wayland module defining packages that don't match the module name 2023-03-24 eric@igalia.com Show dEQP version even if building from git 2023-03-24 piotr.byszewski@mobica.com Merge vk-gl-cts/vulkan-cts-1.3.5 into vk-gl-cts/main 2023-03-22 piotr.byszewski@mobica.com Merge vk-gl-cts/dev/VK_EXT_image_sliced_view_of_3d into vk-gl-cts/main 2023-03-22 piotr.byszewski@mobica.com Remove verify_kc_cts_rev.py script If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I73ecd7e48a27f22cd1d57bd2e26a43761b6993e0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4376788 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Geoff Lang c6ec59dc 2023-03-27T11:15:48 Explicitly pass the extended dirty bits to syncState. Add a the extended dirty bits and bit mask to syncState instead of calling gl::State::getAndResetExtendedDirtyBits when encountering DIRTY_BIT_EXTENDED. It disallowed us from masking the extended dirty bits and feels like an anti-pattern to modify the extended dirty bits in gl::State from the backend. This is a refactor only. Bug: chromium:1410191 Change-Id: I66fdec3eb57e3426cf0fda9ccb759700eafdda14 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4374100 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Alexey Knyazev fc7cb00e 2023-03-24T00:00:00 Metal: Support NV_shader_noperspective_interpolation Fixed: angleproject:8095 Change-Id: Ieded1f704f82963984f1aee5072f152de0de374c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4368473 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Alexey Knyazev 1ee27fcd 2023-03-24T00:00:00 Fix translation of noperspective interpolation qualifier Auxiliary storage qualifiers used with 'noperspective' interpolation must be retained during ESSL translation * Added new qualifiers: * EvqNoPerspectiveCentroid * EvqNoPerspectiveCentroidIn * EvqNoPerspectiveCentroidOut * EvqNoPerspectiveSample * EvqNoPerspectiveSampleIn * EvqNoPerspectiveSampleOut * Adjusted GLSL and SPIR-V output * Adjusted 'sample' rank to be the same as 'centroid' Fixed: angleproject:4388 Change-Id: Iffc80a7a3b057beffd3bcbbc9446eeed77183c99 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4368471 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Kramer Ge fbb16d64 2023-03-24T02:23:19 Mali: Disable disjointTimerQueries on ChromeOS with MaliT8xxOrOlder ChromeOS boards using MT8183 are encountering GL_OUT_OF_MEMORY errors when using disjointTimerQueries, which leads to meets visual effects freezing after a couple of seconds. Extend the workaround treatment to ChromeOS. Bug: chromium:1356053,b/269068358 Change-Id: I212f2b4a2fed1ddd8e8344bde4f4ca9069ea3393 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4369684 Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Auto-Submit: Kramer Ge <fangzhoug@chromium.org>
Colin Blundell abbbe970 2023-03-24T08:10:40 [GL backend] Get texture bindings size from frontend caps EGLContext currently sets the texture bindings size to be GL_MAX_COMBINED_TEXTURE_IMAGE_UNITS. StateManagerGL later copies these bindings into its own textures array [1]. However, the latter texture array is clamped to a size of max 96 [2], and thus this copy can overflow (see crash in crbug.com/1418842). This CL changes the texture bindings size to be set from the frontend caps rather than the native caps. The former have the same clamping as for StateManagerGL's textures. [1] https://source.chromium.org/chromium/chromium/src/+/main:third_party/angle/src/libANGLE/renderer/gl/StateManagerGL.cpp;drc=c85c710dec58dfdcf2f35af647a0a5155639edd5;l=3274 [2] https://source.chromium.org/chromium/chromium/src/+/main:third_party/angle/src/libANGLE/angletypes.h;drc=4a77b0f5237515960673b9bd1bc5a229f0eeaa95;l=952 [3] https://source.chromium.org/chromium/chromium/src/+/main:third_party/angle/src/libANGLE/Context.cpp;l=4050-4059;drc=b4bc946c63b2b95e1f05dec4e84adcadd10499c6 Bug: chromium:1418842 Change-Id: I66c10b640f70d9dc6c7d41925f12ffb7a3ba78e0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4369699 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Alexey Knyazev d8c9ba9a 2023-03-27T00:00:00 Avoid defaulted comparison operator Not available until C++20. Bug: angleproject:8046 Change-Id: I6f4093b0bdccca55818109836e2e0d68f66897b9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4373861 Reviewed-by: Brian Osman <brianosman@google.com> Auto-Submit: Alexey Knyazev <lexa.knyazev@gmail.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev afc1e5dc 2023-03-27T00:00:00 GL: Support OES_sample_variables Bug: angleproject:8097 Change-Id: I983d6e83fe9ca942c91cbdf7274b46306e38f11f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4368476 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
angle-autoroll 98cfb969 2023-03-27T10:01:52 Roll vulkan-deps from 672a6d1840c9 to d56f491466de (13 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/672a6d1840c9..d56f491466de Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/c43008e829..45405e1d94 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/9fbe1738ba..f9f31fa5a9 * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/ee15ae402b..9b9fd871b0 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/23c3a6047f..d72476300b * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/fb440ea67d..211fec7e9a * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/b3baf74e40..9124f788b7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: Ib4fab95a31afc686c8555db2fdcdd3b510530146 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4372490 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Hailin Zhang 1301402c 2023-03-23T21:56:45 Vulkan: improve etc to bc grident texture precison. ETC has gradient modes. Two endpoints in BC are RGB565; the color depth is lower than ETC. Two endpoints in RGB888 space may be quite different, but after conversion to RGB565 they may be projected to the same point. This conversion loses quite a lot of details. This change tries to change one endpoint to an adjacent one (not optimal) in RGB565, so that all the colors are interpolated from these two endpoints. With this change, the arknight image in b/259327729 improved PSNR from 39 to 49. This change includes some of work by @gregschlom 1) Use look up table instead of bit operation. 2) Use more vector operations. This may not improve the performance but makes the code short and neat. bug: b/259327729 Change-Id: Ic0720aff17af5d466e5598dc38ba953dc084a3cc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4368021 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Hailin Zhang <hailinzhang@google.com>
Cody Northrop 249b03ac 2023-03-24T15:11:10 restricted_trace_perf: Delete settings when using default Follow up to the addition of `--renderer default`, actively delete the settings if default is chosen. Otherwise the script will just use whatever settings you already have. Test: restricted_trace_perf.py Bug: b/269645211 Change-Id: I83be7e3f7fa2f2a2bc9f9d243820b49a3cdbed82 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4368874 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Igor Nazarov 435e557c 2023-03-22T21:35:09 Vulkan: Do not enforce custom ANGLEs secondary command buffers. This change become possible after the commit: Vulkan: Fix Secondary Command Buffers with asyncCommandQueue. After the above change, `attach/detachAllocatorImpl<>()` will be skipped when using Vulkan secondary command buffers. Other places that use `mCommandAllocator` already no-op regardless of the allocator type. Therefore enforcing: ANGLE_USE_CUSTOM_VULKAN_OUTSIDE_RENDER_PASS_CMD_BUFFERS ANGLE_USE_CUSTOM_VULKAN_RENDER_PASS_CMD_BUFFERS when enabling `angle_enable_vulkan_shared_ring_buffer_cmd_alloc` is no longer required. This will remove possible confusion when configuring ANGLE build and allow mixing Vulkan secondary command buffers and ANGLEs custom secondary buffers that use `shared_ring_buffer_cmd_alloc`. Bug: angleproject:6401 Bug: b/256666069 Change-Id: I52a64065e6ce9e4aabbf76031c3f5443e0e26a3a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4360071 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com>
Igor Nazarov aa8f2e4b 2023-03-22T19:53:04 Vulkan: Minor SecondaryCommandPool::destroy() optimization. Follow up for the commit: 9b6368ccfceddf1784ef41e95e57696453cca71d Vulkan: Fix freeing Secondary Command Buffers from wrong thread. Bug: angleproject:6100 Change-Id: I8ef34898941c0c5684d3ea4378332cdf6b87c0c8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4359703 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com>
Igor Nazarov 85735eb4 2023-03-17T19:56:23 Vulkan: Enable async features for Secondary Command Buffers. Since, all known problems with Secondary Command Buffers and async features are fixed, it should be safe to allow enabling these features for testing. Locally, this CL passes custom build dEQP tests (EGL/GLES2/3/3.1) with asyncCommandQueue and Vulkan Secondary Command buffers enabled. Tests were executed on S906B that uses ANGLE as the system GLES driver. Bug: angleproject:6811 Bug: angleproject:6100 Change-Id: Id3ef6df56f0a3bd1986f2e6047f01e6eac165fc6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4350270 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>
Cody Northrop 2bd8acfe 2023-03-23T18:24:43 Tests: Add Geometry Dash trace Test: angle_trace_tests --gtest_filter="*geometry_dash*" Bug: b/271876646 Change-Id: I18ab2f22230f0c63d3aaf7c825c9cc55d896d4d0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4368019 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Roman Lavrov <romanl@google.com>
Igor Nazarov e27e7c6a 2023-03-17T19:43:54 Vulkan: Retire Command Buffers before destroying the Pools. "VulkanSecondaryCommandBuffer"s may be still in "CommandQueue" when "ContextVk" destroys the Command Pools (asyncCommandBufferReset = true). Fixed by calling "retireFinishedCommandsLocked()" when appropriate. Normally, it is only required to retire Vulkan Secondary Buffers. However, some drivers may have bug and also require to reset Primary Buffers, that have Secondaries recorded, before destroying the Secondaries Pools. Bug: angleproject:6811 Bug: angleproject:6100 Change-Id: I891547c95cfbdfab44398980f939596af56ab57b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4350269 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com>
Igor Nazarov 9524c639 2023-01-17T18:47:47 Vulkan: Fix Secondary Command Buffers with asyncCommandQueue. This change fixes following errors (asyncCommandQueue = true): 1. "vkEndCommandBuffer()" called from "asyncCommandQueue" thread. Call stack: vkEndCommandBuffer() VulkanSecondaryCommandBuffer::end() OutsideRenderPassCommandBufferHelper::flushToPrimary() CommandQueue::flushOutsideRPCommands() CommandProcessor::processTask() Fixed by calling "vkEndCommandBuffer()" from the Context thread in the new "OutsideRenderPassCommandBufferHelper::detachCommandPool()" method. 2. "vkAllocateCommandBuffers()/vkBeginCommandBuffer()" called from "asyncCommandQueue" thread. Call stack: vkAllocateCommandBuffers()/vkBeginCommandBuffer() VulkanSecondaryCommandBuffer::initialize() <*>CommandBufferHelper::initializeCommandBuffer() <*>CommandBufferHelper::reset() <*>CommandBufferHelper::flushToPrimary() CommandQueue::flush<*>Commands() CommandProcessor::processTask() Fixed by calling "vkAllocateCommandBuffers()/vkBeginCommandBuffer()" from the Context thread in the new "<*>CommandBufferHelper::attachCommandPool()" method. 3. "SecondaryCommandPool::collect()" called from "asyncCommandQueue" thread without synchronization. Call stack: SecondaryCommandPool::collect() rx::vk::RecycleCommandBufferHelper() CommandBufferRecycler<>::recycleCommandBufferHelper) RendererVk::recycle<*>CommandBufferHelper() CommandProcessor::processTask() No need for this call, because "SecondaryCommandPool" is already detached. Notes: This CL not only fixes errors, but also optimizes CommandBufferHelper recycling. Before, there was no recycling plus unnecessary "VulkanSecondaryCommandBuffer" allocation/freeing. Further optimization may add multiple "VkCommandPool"s to the "SecondaryCommandPool" to allow resetting buffers in the async thread. Bug: angleproject:6811 Bug: angleproject:6100 Change-Id: I7004c27a112e916c5c973b43b137193017d6aa3d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4342189 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>
angle-autoroll 87632d64 2023-03-24T10:01:45 Roll SwiftShader from f988757e44a3 to c85d70d97009 (3 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/f988757e44a3..c85d70d97009 2023-03-23 jif@google.com Add Android.bp for LLVM16 2023-03-23 jif@google.com Add configs/android for LLVM 16 2023-03-23 jif@google.com Add riscv to the list of configs generated on android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I77f90ab562b4439d8dabd446c3b3828860573bba Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4368572 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll f7602170 2023-03-24T10:01:05 Roll vulkan-deps from 886b2b7b32a4 to 672a6d1840c9 (11 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/886b2b7b32a4..672a6d1840c9 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/14e5a04e70..c43008e829 * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/a41cf67dfa..90547c54e2 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/5f4e694e10..9fbe1738ba * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/fa204df59c..ee15ae402b * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/728c1535de..fb440ea67d * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/357f1476ee..b3baf74e40 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: I2c9df6381945e1dc04b682718134ac3761a085a7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4368032 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amirali Abdolrashidi dae99340 2023-03-23T14:36:28 Remove uninited pixel check from TexStorageWithPBO Towards the end of the test "TexStorageWithPBO" from Texture2DTest, the color of the pixel outside the red square is checked to confirm that it is black. However, due to that part being uninitialized in the test, its color could be left over from a prior test, causing a failure. * Removed the pixel check for outside the square. * Updated the color check for the square to cover its whole area. Bug: angleproject:4126 Bug: angleproject:5081 Bug: angleproject:5097 Bug: angleproject:5651 Bug: angleproject:8093 Change-Id: I3ceb8cf30456f51a60630f9e258210a8ccae0d95 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4367898 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev c1e45f0c 2023-03-23T00:00:00 Adjust copied dylibs in update_chrome_angle.py Bug: angleproject:1944 Change-Id: Ia84ccd2f38e1d3257a9ec5261acc43d9ba2ed1a2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4367200 Auto-Submit: Alexey Knyazev <lexa.knyazev@gmail.com> Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Amirali Abdolrashidi f2c5ce4e 2023-03-16T17:44:56 Re-enable mutable texture upload for one context It was observed that in some apps, mutable textures are uploaded in a context, but that context's outside RP command buffer is not flushed at all, resulting in invalid (noise) or incorrect textures. * Added isEligibleForMutableTextureFlush() to be used to determine whether onMutableTextureUpload() should be called. * Restricted the use of mutable texture upload to single-context share groups. * When the number of contexts becomes greater than one, the original context's outside render pass command buffer is flushed. * Added related tests. * Added a test to make sure that textures can be uploaded in one thread, and used for draw calls in another, with the help of a sync object. * Added a test to make sure that textures can be uploaded in the main thread, and used in a new thread. * Added a test in which a new context is created after mutable mipmap textures are defined. Bug: b/264143971 Change-Id: I66c0d8b04d39bb7244e5752aac0e46a0192f012e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4349156 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 997c4c7b 2023-03-21T00:00:00 D3D11: Implement EXT_conservative_depth Drive-by: * Hid the extension from ES 2.0 client contexts. Bug: angleproject:8046 Change-Id: I8bca4161dde4bda7ee75541b9164777884900d89 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4366784 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Alexey Knyazev 648f3657 2023-03-21T00:00:00 Metal: Implement EXT_conservative_depth Bug: angleproject:8046 Change-Id: I3b9f497da19bf005c7948e552f2e1c7415d4ac6d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4363020 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Kyle Piddington <kpiddington@apple.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Yuly Novikov 34a06e25 2023-03-15T18:46:55 Start MacBook Pro AMD 2019 experiment on ANGLE bots Suppress failing tests Bug: chromium:1382149, angleproject:8091 Change-Id: I817d3db8badc35a12ecc9650750ca9190c617f6c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4341695 Commit-Queue: Geoff Lang <geofflang@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll 860a401f 2023-03-23T10:01:44 Roll vulkan-deps from 379ee8599f0f to 886b2b7b32a4 (12 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/379ee8599f0f..886b2b7b32a4 Changed dependencies: * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/763dbe14ab..09e60d74f6 * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/1feaf4414e..a41cf67dfa * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/90f6a2875f..5f4e694e10 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/889e6b7223..23c3a6047f * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/f196c8d3ca..728c1535de * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/8b4a4eb257..357f1476ee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: I47af7a1c45d9dae50143a881a2b6dd10eebdf6ba Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4365259 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Igor Nazarov 0e502f8c 2023-03-20T20:34:28 Vulkan: Update SharedCommandBlockPool::valid() method. Current logic returns `valid()` result whether `mAllocator` is attached or not. However this is not correct, because it is allowed to use some method even after allocator is detached. Since this class does not require initialization - it is always valid. Bug: angleproject:6401 Bug: b/256666069 Change-Id: I57f899ae7718762b7e2b68e9c3d1e04dccb2c351 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4355391 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>
angle-autoroll fc308f4a 2023-03-23T10:01:20 Roll SwiftShader from 0cc04d07ab24 to f988757e44a3 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/0cc04d07ab24..f988757e44a3 2023-03-22 jif@google.com Add CMakeLists.txt for LLVM16 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I006e6a454f7a32f130e1b4e0ed0e4080fded07aa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4363729 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll e7b7f977 2023-03-23T07:00:20 Roll Chromium from 27821cf1b122 to c83e966b4c7e (630 revisions) https://chromium.googlesource.com/chromium/src.git/+log/27821cf1b122..c83e966b4c7e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/0732a05e76..32e94e55de * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/fb59b3f632..0a6c69640f * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/af83f5d2fa..e44019bfac * testing: https://chromium.googlesource.com/chromium/src/testing/+log/982c27097c..f132d63e88 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..018d397758 * third_party/fuchsia-sdk/sdk: version:12.20230321.3.1..version:12.20230322.3.1 No update to Clang. Bug: None Tbr: solti@google.com Change-Id: I0f7ad779027607430c445470f74e1bfc05951814 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4364802 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov 74edb4b4 2023-03-22T18:38:38 Skip PixelLocalStorageTest.Interrupt on iOS Metal Bug: angleproject:7994, chromium:1421437 Change-Id: Ib6a8b316212510f73f56ef9e56c8d2da2fe07cfc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4359704 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Kramer Ge 888ca8d9 2023-03-21T18:56:56 Bind FBO before timer query on Mali GL driver. glBeginQuery(GL_TIME_ELAPSED/GL_TIMESTAMP) on Mali implementation assumes a complete FrameBuffer. Without it glGetQueryObject will return a meaningless value, causing some applications to misbehave. This workaround caches and binds a default FBO in this case. Bug: chromium:1356053,b/269068358 Change-Id: I756ded948c2c5aada744f9dd428ad77c37a009c6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4359032 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Kramer Ge <fangzhoug@chromium.org>
Alexey Knyazev ad52f12e 2023-03-21T00:00:00 Implement EXT_conservative_depth Added translator frontend and GLSL backend support for gl_FragDepth redeclaration and layout qualifiers. Added mappings to DepthGreater, DepthLess, and DepthUnchanged SPIR-V execution modes. Bug: angleproject:8046 Change-Id: I23f19ff54380741107970a44055ea269eef179f6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4355028 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 11d92052 2023-03-22T10:01:55 Roll vulkan-deps from 469b8c0e07d5 to 379ee8599f0f (10 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/469b8c0e07d5..379ee8599f0f Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/b34f619e1c..14e5a04e70 * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/d26c233e1c..763dbe14ab * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/4dc3edeb94..90f6a2875f * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/2465552d8b..8b4a4eb257 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: Ifd3c665caa7e5781ed1d4cee2cf9ad5814ee1487 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4359025 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 5b87328f 2023-03-22T10:01:30 Roll SwiftShader from 9c9608fa94a9 to 0cc04d07ab24 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/9c9608fa94a9..0cc04d07ab24 2023-03-21 jif@google.com Add configs/common and configs/linux for LLVM 16 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: Ic2504aded8e1af00115abec892aa7741cf77fbf0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4359492 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 903d24c1 2023-03-22T07:01:34 Roll Chromium from 23433174ff7f to 27821cf1b122 (589 revisions) https://chromium.googlesource.com/chromium/src.git/+log/23433174ff7f..27821cf1b122 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/af6080beca..0732a05e76 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/075950bcd5..fb59b3f632 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/9b076b8003..af83f5d2fa * testing: https://chromium.googlesource.com/chromium/src/testing/+log/ff512c1c36..982c27097c * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/5a920a24ca..b5b8912f72 * third_party/android_build_tools/lint: UwgKmRuzPgo_NJFKTlrK_7OSgm2s-sVVb7Uz4jER_soC..E86vFKi4re9HwIfUW9yq_Ig_hc7Vr0lcl-bO3BtPQLYC * third_party/android_build_tools/manifest_merger: lC0-JZAP05FMcCXlQn9Oej4oD6ytlLkFQEnExeLuAWkC.._aoHU11YhUwqKZXVXsn5otnhI-ZVGFT7h1Z9eCcAZM0C * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/34499ffdd4..4189179faf * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..c82a855930 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7a8daa2f9f..479e1e9055 * third_party/fuchsia-sdk/sdk: version:12.20230320.2.1..version:12.20230321.3.1 * third_party/r8: n_0sb2RjfuLOaX_c1F8vkC5sV5vv8HmWspFtkMqZ3BoC..EGf7RQo3stt-vPTw69TaMGuNtnOx0Dbk1O-MBquwswYC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/bdb6d43dc1..7a7207a7f2 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/e300797cbd..db6ffdf0ba No update to Clang. Bug: None Tbr: solti@google.com Change-Id: I70df9f940bd6acd5e76bbb8b8bee189f4ea5d8df Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4359021 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Greg Schlomoff a621ea88 2023-03-17T10:21:56 Adding a trace point for texture metrics. Bug: b/236121838 Change-Id: I28e7977f7b5dc6e24cb5a2be10689c223851ba0b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4348737 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Doug Horn <doughorn@google.com> Reviewed-by: Charlie Lao <cclao@google.com>
Cody Northrop ec9595f1 2023-03-21T10:02:00 restricted_trace_perf: Run against default driver On newer Android versions where ANGLE can be the default driver, selecting "native" as the driver will always seek out the system driver instead of the default driver. To allow the platform to select the GLES driver, add a "default" mode that does not use any Android settings for driver selection. To use, pass `--renderer default` Test: restricted_trace_perf.py Bug: b/269645211 Change-Id: Ie9bf64eaa823d9d54301472c1d4e48bf2f5482cd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4358331 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Auto-Submit: Cody Northrop <cnorthrop@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Chris Dalton a491bbe3 2023-03-18T19:05:08 Add PLS utilities for interrupting a rendering pass Adds two more simple commands to ANGLE_shader_pixel_local_storage that allow WebGL and the command buffer to interrupt rendering passes without having to either (1) make expensive queries, or (2) track lots of complex state for validation that they are not currently equipped to track. Bug: chromium:1421437 Change-Id: I80eaef3ae6b0b4bbbecb9cd2268ac90b43675d1c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4355032 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org>
Mark Lobodzinski 23ad4fa2 2023-03-10T11:56:00 Don't hold global surface lock during AcquireNextImage On Android, the global surface lock must be released before calls to vkAcquireNextImageKHR, though GetSurfaceIfValid must remain inside the surface lock. Bug: b/268091451 Test: Mini-game puzzles in 'Fishdom' app, available in play store Change-Id: Ia9c96de52a367b4537a42cee83e2372322fbdfbc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4316610 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Mark Łobodziński <mark@lunarg.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: mohan maiya <m.maiya@samsung.com>
Alexey Knyazev ba845fcf 2023-03-20T00:00:00 Metal: Implement EXT_clip_control * Skipped vertex shader depth correction when clip depth mode is set to GL_ZERO_TO_ONE. * Adjusted front face mode and pre-fragment vertical flip driver uniform based on the clip origin state. * Added more clip control end2end tests. * D3D11: Fixed scissored draws with upper-left clip origin. Fixed: angleproject:8065 Change-Id: Ife82fa2ad39fad463c23ec10b49bff409272ebf2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4356661 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Kyle Piddington <kpiddington@apple.com>
Alexey Knyazev 1e6dd013 2023-03-21T00:00:00 Metal: Support centroid qualifier Fixed: angleproject:8090 Change-Id: I3137599e976bc469709347f423b7e8b71e6ed9f7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4356667 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Kyle Piddington <kpiddington@apple.com>
Scott Violet 53d1a179 2023-03-20T17:17:59 Makes ToposortStructs() return consistent results This patch introduces a step in ToposortStructs() that sorts the nodes by name. Doing this ensures consistent results between calls. Without this, the order depends upon the pointer value, which varies depending upon when called. Ensuring consistent results for the same input is important for other parts of this code that use the string as key. Bug: chromium:1423136 Change-Id: I19f053df5cf86c81b800056e86b742d8c34af7d4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4357255 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org>
Alexey Knyazev f5695244 2023-03-21T00:00:00 Fix sample qualifier validation * `smooth sample` is the same as `sample` * `flat sample` is the same as `flat` Bug: angleproject:3589 Change-Id: I8615fa73f4b0cea729b8e09d86f1b8183669de2b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4356666 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll c8c742f6 2023-03-21T10:01:52 Roll vulkan-deps from 35cbe26c4b3a to 469b8c0e07d5 (8 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/35cbe26c4b3a..469b8c0e07d5 Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/ae435df4a6..4dc3edeb94 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/011d7a4ac0..889e6b7223 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/9139876c5b..2465552d8b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: Idcf64b4f9dc1becd7bf10f7a3a33d777b1e64509 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4357858 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 0709b6fd 2023-03-21T10:01:22 Roll SwiftShader from 85772f1891db to 9c9608fa94a9 (7 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/85772f1891db..9c9608fa94a9 2023-03-20 jif@google.com Add LLVM 16 at commit fce3e75e01ba 2023-03-20 jdapena@igalia.com More C++20 fixes 2023-03-20 hwennborg@google.com Add missing #include <exception> for std::terminate 2023-03-20 jdapena@igalia.com GCC: fix build error due to missing template keyword in GCC 12. 2023-03-20 jdapena@igalia.com Another C++20 fix for GCC 2023-03-20 jdapena@igalia.com GCC: fix build error due to deprecated declarations warning 2023-03-20 jif@google.com Add risc-v to marl's Android build files. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I83d6065c851427c3e3d8680a9d7429f45f172124 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4357652 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gert Wollny 0cb6697a 2023-03-09T10:35:04 Capture/restricted_traces: update documentation With the new context handling the trace files are named differently, and the description how to remove secondary contexts also is out of date. Bug: None Change-Id: Ia8258502ef53f9d90b742eff01f8125d816ca74e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4323658 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
angle-autoroll 1beb6ef8 2023-03-21T07:02:31 Roll Chromium from 528cae6045de to 23433174ff7f (599 revisions) https://chromium.googlesource.com/chromium/src.git/+log/528cae6045de..23433174ff7f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/3d39a1ae5d..af6080beca * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/55bafd8820..9643f2cf13 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/f1f84847ad..29a6dda8c6 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/8d50e19935..ff512c1c36 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..1eea754058 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/249e9a26c1..7a8daa2f9f * third_party/fuchsia-sdk/sdk: version:12.20230319.3.1..version:12.20230320.2.1 * third_party/r8: 3ISiDI_LAgX6Aa_Gn1DSvQJFrAyArwo-GiVbw1FopUQC..n_0sb2RjfuLOaX_c1F8vkC5sV5vv8HmWspFtkMqZ3BoC * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/7e4bf472a6..e300797cbd No update to Clang. Bug: None Tbr: solti@google.com Change-Id: Ie0f94e261020d6fad4764c91eb904fe112ca6ebd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4357856 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
kmx.io     mail     discord kmxgit v0.4.0