kc3-lang/angle

Log

Author Commit Date CI Message
Alexey Knyazev a20cd8b7 2022-01-22T01:40:34 Fix initialization for ETC2 punchthrough alpha formats * Zero-filled ETC2_A1 data must be treated as opaque black * Removed init functions when emulation is not needed * Fixed initialization for emulated ETC2_R8G8B8A1_SRGB_BLOCK Bug: angleproject:6936 Bug: angleproject:6941 Change-Id: Ie5555bbaa6b1a2bcfd9c22cb9c17d1a96e72aa70 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3406761 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Sergey Ulanov cac4e54a 2022-01-24T05:43:00 Mark GL_RGBX8_ANGLE format as filterable. `filterable` field was set to set to NeverSupported for GL_RGBX8_ANGLE, while it is filterable when it's supported. Bug: angleproject:6690, chromium:126982 Change-Id: If44f18014c3c7a30378f51d0426ce9980c2feae0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3411538 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 64c49da3 2022-01-24T07:58:23 Roll Chromium from b7f974a39665 to 35ed79e6a83b (570 revisions) https://chromium.googlesource.com/chromium/src.git/+log/b7f974a39665..35ed79e6a83b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/906b90c327..bec2a5518d * buildtools/linux64: git_revision:80a40b07305373617eba2d5878d353532af77da3..git_revision:0725d7827575b239594fbc8fd5192873a1d62f44 * buildtools/mac: git_revision:80a40b07305373617eba2d5878d353532af77da3..git_revision:0725d7827575b239594fbc8fd5192873a1d62f44 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/295f84c04f..c8a5d430f2 * buildtools/win: git_revision:80a40b07305373617eba2d5878d353532af77da3..git_revision:0725d7827575b239594fbc8fd5192873a1d62f44 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/9ef62302b2..8a418d7076 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..56a84f9f66 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6bfbe35cce..18a2844b53 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/170758333f..4e3276cdb9 * tools/luci-go: git_revision:5b02a4aaeb5fd78d6fe41d6d54d1cb58da17f192..git_revision:09f8b3edbbf18dc63d0d5aa7722ae7acc20b11b4 * tools/luci-go: git_revision:5b02a4aaeb5fd78d6fe41d6d54d1cb58da17f192..git_revision:09f8b3edbbf18dc63d0d5aa7722ae7acc20b11b4 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/d5139d0314..a958c71673 * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/8e8704fdfa..5b5485d9df * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/ae043af23c..7b5cbc79fb * tools/skia_goldctl/linux: YNf7R76UZBvuCmgAKDzb1F43jfA8FkFy9DCW6B98MHEC..a94AbgYafC6yjxWNmJJ4cHUWWXNhjFUQLcU79HycYjkC * tools/skia_goldctl/mac_amd64: x0lVRcTpz47HUZXm2WnVv16tuAKSZ-QUF9A1T1j2RykC..IEdOBXQmFOksbZa16aKIWU6uYVYJlgvPwyX3wktMkkIC * tools/skia_goldctl/mac_arm64: Cbv4TR0stWg2pA84PBfgi-N9jV07KWhEcAsg8ZX8ZkYC..XtI7k09JHcA8aaaRNlOF92uDqOXfr8HMmepwH0q9uk0C * tools/skia_goldctl/win: 0Z6Y_DY-axS2RajDae9CHJrDn1a4CTif2VkT4CR5jOMC..3uvz7bDTL-QoL5KPX-caB_HxcvVE7JamyMibu71hqHAC No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: Id9387ce54c2a15b3d6cfbd56deba3e45608cd500 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3411541 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya 096c268b 2022-01-12T15:21:02 Add a few overrides for Samsung 1. Enable perFrameWindowSizeQuery feature 2. Return correct vendor string Bug: angleproject:5111 Change-Id: I9efb0d2168994c6f209d8730c658f2568f3d3afa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3387848 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 339a6d18 2022-01-23T19:17:02 Roll vulkan-deps from c9b583de6eb8 to 238eaa6f9d25 (8 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/c9b583de6eb8..238eaa6f9d25 Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/8a40f6de57..c38495656d * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/60d17fe6c6..dab15e0c45 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/e5c8d9bc16..4bd7579d17 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I49a552caddb07cf78165dca447b4c86ceb577ca5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3411311 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 0f00fbae 2022-01-21T00:28:48 Translator: Make vec/matrix size getters unsigned TType stored type's primary and secondary sizes as `unsigned char`, but the getters returned `int`. This caused unnecessary casts when the size was passed from one TType to another, as well as comparisons with other unsigned numbers. This change specifies the type of these members as `uint8_t` and makes the getters return the same type. The call sites are accordingly adjusted to remove unnecessary casts, use the correct type in local variables, and add casts when passed to ostream::operator<<. Bug: angleproject:6755 Change-Id: Ia4d86bd4ccb5c1a2ae1e10a0085a5166c3a6bcf7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3402850 Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev ca3b28b4 2022-01-21T14:59:47 Metal: Fix compressed texture initialization and add DXT1 test There was a divergence between WebKit and upstream ANGLE in InitializeTextureContents' handling of compressed textures. Align upstream ANGLE with WebKit, fix a problem with emulated compressed texture formats like ETC2, and add a new test: DXT1CompressedTextureTestWebGL2.InitializeTextureContents Bug: chromium:1289428 Change-Id: Ieac6b99a4b19a34d0d87b7577882760ea395c605 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3406746 Reviewed-by: Kyle Piddington <kpiddington@apple.com> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org>
Kenneth Russell 4a5a559d 2022-01-21T09:20:28 Update Metal/iOS status from "planned" to "in progress". Apple has upstreamed basically all of their changes to ANGLE's Metal backend and are successfully using it on iOS, though this code path isn't yet being tested on ANGLE's waterfall. Bug: angleproject:6934 Change-Id: I3eda46d84fb84282cd70a043740de532c3389f78 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3402336 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org>
Mohan Maiya a0fbcb37 2022-01-13T14:26:58 Vulkan: Remove flush from SyncHelperNativeFence::serverWait The spec doesn't require a flush in native fence's server wait method Bug: angleproject:2517 Test: EGLSyncTest.AndroidNativeFence_* Change-Id: If6870fe1e25ddf3a1b724e776f5408523a7bdf50 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3388231 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
angle-autoroll 038d2877 2022-01-21T19:30:35 Roll VK-GL-CTS from bfede065f419 to 97ceb2222747 (3 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/bfede065f419..97ceb2222747 2021-12-03 syoussefi@google.com Fix shader operator tests' precision expectation 2021-12-03 quic_mnetsch@quicinc.com Merge vk-gl-cts/opengl-cts-4.6.1 into vk-gl-cts/master 2021-12-02 quic_mnetsch@quicinc.com Merge vk-gl-cts/opengl-es-cts-3.2.7 into vk-gl-cts/master If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-bots+autoroll-info@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: angle-bots+autoroll-info@google.com,syoussefi@google.com Change-Id: I1f86fa13ebba9d7e74aee087c5ea8403033b5171 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3407858 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya 29e25468 2022-01-07T07:02:53 Account for EGL 1.5 version when dealing with robustness EGL 1.5 spec allows for EGL_CONTEXT_OPENGL_RESET_NOTIFICATION_STRATEGY and EGL_CONTEXT_OPENGL_ROBUST_ACCESS enums to be passed in to eglCreateContext. Update the validation layer and queries to account for the new enums. Bug: angleproject:6883 Tests: KHR-NoContext.es32.context_flags.*flag* Tests: KHR-NoContext.es32.robustness.*reset* Change-Id: I7088e0dca08cea2cfdcf1877b6d999c0e0336e5e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3373133 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Yuly Novikov 78d482e5 2022-01-13T14:49:26 Add standalone ANGLE Pixel 6 experimental bots The bot only runs dEQP tests with Vulkan backend, not GLES. Also skipping non-Vulkan tests in angle_end2end_tests. Also no perf/trace tests, as these time out uploading to device. Adding suppressions for the failing tests at the same time. Bug: chromium:1280418, angleproject:6819 Bug: angleproject:6898, angleproject:6899, angleproject:6900 Bug: angleproject:6905, angleproject:6907, angleproject:6908 Bug: angleproject:6909, angleproject:6910, angleproject:6916 Bug: angleproject:6917, angleproject:6918, angleproject:6919 Bug: angleproject:6931 Change-Id: I3598e6ff7f458ad7ab2defb86e02a17fbf2d20ca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3387108 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Brandon Schade a5e22715 2021-09-30T17:03:34 Vulkan: Fixed TC shader and gl_PerVertex block interaction TransformSpirV() does not account for the fact that the tessellation control shader's output gl_PerVertex block is a named array. This results in the input and output blocks being sometimes flipped. Added code to track the IdRef of both input and output array gl_PerVertex blocks and swap them if necessary. Bug: angleproject:5557 Tests: KHR-GLES32.core.tessellation_shader.tessellation_control_to_tessellation_evaluation.data_pass_through Change-Id: Ie3823701b4eaa53daa8ca34faab657f54d8aee38 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3208513 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Brandon Schade <b.schade@samsung.com>
Peng Huang a64d52fd 2022-01-21T13:09:34 Add ANGLE_FORMAT_PRINTF() for catching format errors Bug: chromium:1288391 Change-Id: I0856d09b924ccce8192cad8cd7b590e0098ec5d5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3402851 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 31bb03fe 2022-01-19T10:06:49 Add more tests for program pipelines. Bug: angleproject:3570 Change-Id: I2fa5ea6d90a15f4ec8ee41cde6921c30923974c2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3402099 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll e6ed6977 2022-01-21T10:01:09 Roll SwiftShader from 2e74d5dc03df to e823eef17385 (4 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/2e74d5dc03df..e823eef17385 2022-01-20 bclayton@google.com BUILD.gn: Remove XCB sources for chromeos. 2022-01-20 bclayton@google.com BUILD.gn: Remove VK_USE_PLATFORM_XCB_KHR define 2022-01-20 capn@google.com Remove heap size padding 2022-01-20 capn@google.com Disable Kokoro builds with REACTOR_EMIT_DEBUG_INFO/PRINT_LOCATION If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:6444 Tbr: syoussefi@google.com Change-Id: I3f5e70a662cc81908008294f521fc24d7f640032 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3406608 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll a4b312c0 2022-01-21T10:01:03 Roll vulkan-deps from 70b3eb7a5ab4 to c9b583de6eb8 (1 revision) https://chromium.googlesource.com/vulkan-deps.git/+log/70b3eb7a5ab4..c9b583de6eb8 Changed dependencies: * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/f7828a52f1..e5c8d9bc16 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I6d84a63613c38b3f8ea637ae4c79969b1d9b9072 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3406624 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Lubosz Sarnecki 515f60bd 2022-01-20T17:39:48 FrameCapture: Keep MEC Setup resources in Reset. This fixes a regression in Reset when using MEC introduced by 462cdb08e395edbf5bace1408715e35239a0b1fa. Don't call MaybeCaptureUpdateResourceIDs in maybeCapturePostCallUpdates before capture starts, since it's adding resource IDs to mNewResources. Don't add resources to mNewResources if they are already in mStartingResources in CaptureUpdateResourceIDs. Add FrameBuffers to mStartingResources before MaybeCaptureUpdateResourceIDs is called. Add Buffers to mStartingResources before calling MaybeCaptureUpdateResourceIDs. Add VertexArrays to mStartingResources in CaptureMidExecutionSetup. Bug: angleproject:4599 Bug: angleproject:6870 Change-Id: If428cbbdbcfa17c221b9e110a990cf6ebc9107c2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3404087 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
angle-autoroll 034b5058 2022-01-21T08:38:24 Roll Chromium from d5bf6f7f9376 to b7f974a39665 (478 revisions) https://chromium.googlesource.com/chromium/src.git/+log/d5bf6f7f9376..b7f974a39665 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/841e388a14..906b90c327 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/7d7912617f..fd0ef6db30 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/efb2cbd374..295f84c04f * testing: https://chromium.googlesource.com/chromium/src/testing/+log/12a61da8be..9ef62302b2 * third_party/android_platform: https://chromium.googlesource.com/chromium/src/third_party/android_platform/+log/5023a5c74e..f0d4a3b4c8 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..8bc3659ded * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a657331e90..6bfbe35cce * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/5227e7d830..2dc9e853e1 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/df50898d39..170758333f * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/4b17b6153e..d5139d0314 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/2fc4907330..ae043af23c * tools/python: https://chromium.googlesource.com/chromium/src/tools/python/+log/373d1fcd62..a21ec45e2d No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: I4c867084c33a525d368d0784131a89be68736df0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3402335 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexey Knyazev 1ab6c9f6 2022-01-20T18:37:56 Hide ES 3.0+ extensions from ES 2.0 clients Bug: angleproject:6928 Change-Id: I0aa1a9c124022fb7d89c2889b18817573ec271a8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3404083 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Brandon Schade 2caa9d4f 2021-10-04T09:43:57 Vulkan: Add missing glGetProgramPipelineiv parameters handling The glGetProgramPipelineiv function call was missing the case handling for tessellation control and evaluation shaders. Bug: angleproject:5557 Tests: KHR-GLES32.core.tessellation_shader.tessellation_control_to_tessellation_evaluation.gl_MaxPatchVertices_Position_PointSize Change-Id: Id888d1a9ae94228a33cfabcc7f65d1f63d596425 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3208511 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Brandon Schade <b.schade@samsung.com>
Charlie Lao d2354968 2022-01-20T10:59:05 Vulkan: Rename BufferHelper::initFor* to allocateFor* Simply name change per feedback from other CL's review. Bug: b/205337962 Change-Id: Ieb53ed9a2922d09716a1219eb340fe273e5f1807 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3402882 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Charlie Lao a83f7e91 2022-01-19T14:14:16 Vulkan: inline some of the BufferSuballocation APIs These are simply get* calls and frequent used ones. The measurement I have on Pixel6 shows there is 0.01ms out of 2.28ms on CPU overhead with asphalt_8 app trace measured with --minimize-gpu-work. Bug: b/205337962 Change-Id: I746a1ccc67c589d1aba25495601ad874ddc034a4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3403159 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Charlie Lao 1b5efe51 2022-01-19T14:04:35 Vulkan: Rename SubAllocation to Suballocation Simply a name change to make it one word. No functional change is expected. Bug: b/205337962 Change-Id: Ic505536821f18141c0d036b13d9aa81554a8bafd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3403158 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Alexey Knyazev 659725aa 2022-01-20T15:24:40 Metal: Cleanup texture caps init The removed line is redundant as the ASTC texture support is enabled during the setTextureExtensionSupport call. Bug: angleproject:6874 Change-Id: Ib9016e4d40acf1f466fa10920384b7419e6fed49 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3404100 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Jamie Madill 3064920a 2022-01-19T11:48:57 Capture/Replay: Serialize ActiveTexturesCache. Also add group scope to samplers. Bug: angleproject:3570 Change-Id: I616a54d95544af1e3c4eeff196806e5bfb20292e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3402100 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 16164321 2022-01-20T10:01:03 Roll vulkan-deps from d1b842fca80d to 70b3eb7a5ab4 (4 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/d1b842fca80d..70b3eb7a5ab4 Changed dependencies: * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/b8047fbe45..b42ba6d92f * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/f79e0540ff..f7828a52f1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I06741f05fce94233d72452a7b8ff26f5d67a2602 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3404258 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 7ff95f28 2022-01-20T07:01:19 Roll Chromium from b24759852b71 to d5bf6f7f9376 (533 revisions) https://chromium.googlesource.com/chromium/src.git/+log/b24759852b71..d5bf6f7f9376 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/7fe67152ba..841e388a14 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/94855f7b7c..7d7912617f * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/57e4aff4a1..efb2cbd374 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/476fe6fd8d..12a61da8be * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/914c1d8c62..e79b8ea964 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..8bc3659ded * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/cb340f5b7b..a657331e90 * tools/luci-go: git_revision:d1e877e2b3e5a05a5cd34c4a340fedba14a16c2b..git_revision:5b02a4aaeb5fd78d6fe41d6d54d1cb58da17f192 * tools/luci-go: git_revision:d1e877e2b3e5a05a5cd34c4a340fedba14a16c2b..git_revision:5b02a4aaeb5fd78d6fe41d6d54d1cb58da17f192 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/f500acb211..4b17b6153e * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/160d34ae85..2fc4907330 * tools/python: https://chromium.googlesource.com/chromium/src/tools/python/+log/d17f53e496..373d1fcd62 No update to Clang. Bug: angleproject:6884 Tbr: syoussefi@google.com Change-Id: I5296d957f9def6b02f5a5553dfbacab444768768 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3403968 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Kyle Piddington 1bd1a3db 2022-01-06T15:08:48 Metal: Canvas resizing causes webpage to run out of memory For https://bugs.webkit.org/show_bug.cgi?id=232122 Introduce a maximum resident amount of memory that a single command buffer can use, before forcing a flush. As part of ensuring that a command buffer is ready, check to see if this limit is exceeded. if so, flush the command buffer, and create a new one. Bug: angleproject:6880 Change-Id: I5e89735d05adbc174237ab79b006a75bbe89e560 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3369922 Reviewed-by: Gregg Tavares <gman@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kyle Piddington <kpiddington@apple.com>
Charlie Lao 15439f8e 2022-01-13T14:58:41 Vulkan: Remove BufferMemoryAllocator This class was added in crrev.com/c/3036256. The original intention was to use VMA to implement buffer suballocation. Because VMA itself does not support buffer suballocation, I was thinking to use VMA custom pool to implement it and this class was intended to wrap all these functionality into one class. But now thanks to Jamie's effort, VMA exported generic suballocation algorithm via API and we have implemented buffer suballocation using that virtual allocation API. So this BufferMemoryAllocator class is really no longer useful. This CL mostly reverted that CL and flatten out the buffer allocation call to directly use VMA's Allocator object. Bug: b/205337962 Change-Id: I0336056e440f39e2ff49fee8e0ff4b1f355cefe4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3244022 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Yuly Novikov dcac02ac 2022-01-19T21:30:21 Revert "Enable robustnessEXT for SwiftShader." This reverts commit b803b60df1806f189c1b29ca77da47896241e0f1. Reason for revert: blocks roll into Chrome - anglebug.com/6922 Original change's description: > Enable robustnessEXT for SwiftShader. > > Bug: chromium:1287631 > Bug: angleproject:6906 > Change-Id: I3c8c32561a1ac7860c83b8d3ba22aafd0bf81fd4 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3390489 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Geoff Lang <geofflang@chromium.org> > Commit-Queue: Roman Lavrov <romanl@google.com> Bug: chromium:1287631 Bug: angleproject:6906, angleproject:6922 Change-Id: Ic8ff7dd996455009037cbff9e10b6fbbc420b37e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3402820 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill ef3fffd6 2022-01-19T16:00:42 Fix running tests with empty test set. This was causing a crash when using an overly strict filter. Bug: angleproject:5417 Change-Id: I38bae1a155a6b1047bae0856348de67f9cda21eb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3402939 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Peng Huang e5c9b385 2022-01-19T11:11:20 Add object label in glBindTexture() error message Bug: chromium:1288391 Change-Id: Ic1d1e96c33d5fde7659107735846dbf2c3ce9360 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3399244 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org>
Cody Northrop b5360798 2022-01-14T12:45:14 Vulkan: Support fetching from default FBO If GL_EXT_shader_framebuffer_fetch is enabled, specify framebuffer attachments as having VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT. Add new test FramebufferFetchES31.DefaultFramebufferTest which exercises the behavior. Also limit exposure of either framebuffer fetch extension to be Android only due to swapchain images requiring INPUT_ATTACHMENT. Test: FramebufferFetchES31.DefaultFramebufferTest Bug: angleproject:6893 Change-Id: I227e36a9844e2301f0fe0602f4e4d905874b32e3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3389791 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Geoff Lang ff5368cd 2022-01-18T13:50:10 Mark a context as shared if using global textures/semaphores The display level texture/semaphore sharing allows cross-sharegroup sharing of resources. This is not thread safe without marking the context as shared which triggers locks on GL calls. Bug: chromium:1273651 Bug: chromium:1276527 Bug: chromium:1276563 Bug: chromium:1278174 Bug: chromium:1284879 Change-Id: If5214ccfd8452beb5e3079ab38c6a3f7d7225d7f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3399249 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: vikas soni <vikassoni@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
James Price fc6b747d 2022-01-10T17:01:30 EGL: Fallback to native device if no display available On some Google-internal platforms, eglGetDisplay() fails. The EXT_device_enumeration extension is the recommended way to initialize an EGL display on these platforms. Bug: chromium:1276086 Change-Id: I68969c19d643a46e8362ae265b1115b18ca3bbc1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3378824 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Alexey Knyazev 55d12770 2022-01-19T16:00:47 Metal: Cleanup autogenerated format table Skip generating code that sets default values. Bug: angleproject:6874 Change-Id: Id12e39eedbe4665279710125e02b105318d40b82 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3399836 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
angle-autoroll cb7ff65c 2022-01-19T10:01:09 Roll SwiftShader from f6bdbed95b37 to 2e74d5dc03df (7 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/f6bdbed95b37..2e74d5dc03df 2022-01-18 capn@google.com Limit LLVM's getTargetShuffleInputs() recursion depth 2022-01-18 sugoi@google.com Fix robust OOB store accesses 2022-01-18 capn@google.com Use Ninja as CMake generator for Kokoro tests on Windows 2022-01-18 capn@google.com Remove unused dot operations and clarify FMA 2022-01-18 capn@google.com Implement VK_GOOGLE_user_type 2022-01-18 capn@google.com Expose VK_GOOGLE_hlsl_functionality1 2022-01-18 capn@google.com Expose VK_GOOGLE_decorate_string If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:6906 Tbr: syoussefi@google.com Change-Id: I327ba216692ba7942da6592c7066763938a53124 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3400889 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll eda5aa0b 2022-01-19T10:01:03 Roll vulkan-deps from 4cda77455291 to d1b842fca80d (6 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/4cda77455291..d1b842fca80d Changed dependencies: * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/08d5f5ed18..53d94a982e * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/0fd1cf08c9..60d17fe6c6 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/15ed1f6530..f79e0540ff If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: Icb0c691fbff29066112deb484354adf6c3264a27 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3400818 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 17f912bd 2022-01-19T07:01:37 Roll Chromium from 8cf5fa683fa3 to b24759852b71 (537 revisions) https://chromium.googlesource.com/chromium/src.git/+log/8cf5fa683fa3..b24759852b71 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/4730425268..7fe67152ba * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/d78d7bf604..94855f7b7c * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/c27c97a625..57e4aff4a1 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/469fa94ee5..476fe6fd8d * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/e3a86ade34..914c1d8c62 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..f92a0a2305 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fd7427ccf6..cb340f5b7b * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/3da260b0f2..df50898d39 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/b96ec062b2..f500acb211 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/e5b892c59d..160d34ae85 No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: I6f1b45549c77ac8291adb05ba213c46eb066ecd6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3400817 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Kyle Piddington 00a2a2f3 2022-01-06T17:52:23 Merge metal format table updates from Webkit Some texture formats are not supported in the Metal SDK for certain platforms. Refactor the mtl_format_table map to allow Webkit to continue to build all platforms. This change removes a large block of changes between Webkit and OSS ANGLE, due to resolving the generated file differences. Bug: angleproject:6874 Change-Id: Ib53aea4fb95e230d53ad2ebbd74bf97e847005c9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3371882 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com> Commit-Queue: Kyle Piddington <kpiddington@apple.com>
Avi Drissman af8dd1c3 2022-01-18T16:54:43 Update documentation link Bug: chromium:1288548 Change-Id: Ie53dccb39f6cbf9b12595944c70018d95a7a1438 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3399253 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org>
Yuly Novikov f071aaaf 2021-07-22T21:21:35 Use first test name instead of shard index for TestArtifacts Shard index is not available on Android if run_gtest_angle_test.py is not used, since host doesn't pass it to device by default. We'd like to remove run_gtest_angle_test.py usage, since custom scripts are not supported on iOS, so this CL is a pre-requisite to that. We still need to distinguish between dEQP test artifacts when we merge test results of different shards, so we'll be using the name of the first test in a batch instead. However, now, on Android, instead of a single TestArtifactsFakeTest entry per shard, we will have multiple entries, an entry for each GTest batch of 256 tests. On other platforms we will still have one entry per shard, since batching is done by TestSuite and not GTests there, just with a different name: Old: "tests": { "TestArtifactsFakeTest-Shard00": { "actual": "PASS", "artifacts": { "TestResults-Batch001.qpa": [ "TestResults-Batch001.qpa" ], New: "tests": { "TestArtifactsFakeTest-GLES3/info_renderer": { "actual": "PASS", "artifacts": { "TestResults-Batch001.qpa": [ "TestResults-Batch001.qpa" ], Bug: angleproject:5417 Change-Id: I649036c151e078c862e380ccab347d6c59acc929 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3046764 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Brandon Schade 7dda50fc 2022-01-13T12:09:20 Add frontend for ANDROID_extension_pack_es31a - Add entry to registry_xml file - Add handling in the DirectiveHandler Bug: angleproject:3608 Change-Id: I1cc32a4a97fd9974f65786a9a972b4b541abf658 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3388405 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Brandon Schade <b.schade@samsung.com>
Brandon Schade 28f223ac 2022-01-14T16:11:32 Vulkan: Add missing ESSL 3.2 builtin functions Builtin functions from the "OES_shader_image_atomic" and "OES_texture_storage_multisample_2d_array" extensions were missing from ESSL 3.2 builtins. Bug: angleproject:3578 Bug: angleproject:3583 Change-Id: Id372f0dcffee1eb376c66b9e4886ed50a08b1b0e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3391048 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Brandon Schade <b.schade@samsung.com>
Jamie Madill 400175d8 2022-01-07T14:54:03 Copy shader buffers into pipeline executables. Bug: angleproject:3570 Change-Id: I82e4fc15aac9f60f40aae69785b24e5dc233fd78 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3371528 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 892511fc 2022-01-05T17:35:30 Isolate LinkValidateProgramInterfaceBlocks. This moves the function to a common place, similar to other "LinkValidate" functions. Refactoring change only. Bug: angleproject:3570 Change-Id: Ib94d7961d919308d29680e7e28bdbca1f08b93f0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3373161 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill fdadc420 2021-09-17T14:39:36 Fix non-bot mode sharding on Android and disable elsewhere. There is no need to apply sharding internally on Android, since it is done on the host, except when listing tests. And on other platforms sharding in non-bot mode is not useful. Patch authored by Yuly Novikov (ynovikov@chromium.org) Bug: angleproject:5417 Change-Id: Iddc0e1a38fb514617dce527acc99d0dce85ca177 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3399250 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cody Northrop fa3241b7 2022-01-13T17:56:52 Vulkan: Move shader_framebuffer_fetch to FeaturesVk Per feedback in http://crrev/c/3371244, move the new and existing checks for whether the extension should be enabled. Controlling them based on hardware vendor should be done with FeaturesVK so we can centralize our workarounds. Also remove the envvar-based override for non-coherent extension. It can now be forced using ANGLE's feature system. The new way to force the override is: ANGLE_FEATURE_OVERRIDES_ENABLED=supportsShaderFramebufferFetchNonCoherent or on Android: debug.angle.feature_overrides_enabled=supportsShaderFramebufferFetchNonCoherent Bug: b/201764768 Bug: angleproject:6519 Bug: angleproject:6870 Bug: angleproject:6872 Change-Id: Ie78ebfa94807a156b9e7f704e8a36cd38b85f878 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3389707 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Jonah Ryan-Davis 9012c128 2022-01-17T13:30:28 Add Microsoft vendor Id parsing to SystemInfo "Microsoft Basic Render Driver" uses vendor Id 0x1414. Bug: angleproject:6904 Change-Id: I50e370159f176a8e591eda96134e59ad89e09c5a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3396417 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Jonah Ryan-Davis 453cd955 2022-01-17T13:26:39 Add EGL_ANGLE_platform_angle_display_id to D3D11 backend. Uses the same LUID parts as ANGLE_platform_angle_d3d_luid. This new extension is available on D3D11 on Windows and Metal on Mac. Bug: angleproject:6903 Change-Id: Ib695affe47e822c4dfd7f41d8a62a85e74b9b90a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3396416 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Lubosz Sarnecki a1858b02 2022-01-05T13:13:30 Tests: Add Respawnables trace. Test: angle_perftests --gtest_filter="*respawnables*" Bug: angleproject:6890 Change-Id: I4af1c783d1431e4741fd8fc3cde7c0e088f3ca69 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3398884 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Roman Lavrov b803b60d 2022-01-14T23:29:14 Enable robustnessEXT for SwiftShader. Bug: chromium:1287631 Bug: angleproject:6906 Change-Id: I3c8c32561a1ac7860c83b8d3ba22aafd0bf81fd4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3390489 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Jamie Madill 31942507 2022-01-18T09:22:36 Fix export_targets Windows presubmit with Vulkan Loader. Bug: angleproject:6912 Change-Id: I96809a46ca5898ad091c6651c07594609f342f98 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3399044 Reviewed-by: Jamie Madill <jmadill@google.com> Commit-Queue: Jamie Madill <jmadill@google.com>
angle-autoroll 8eafe491 2022-01-18T10:01:08 Roll SwiftShader from d7117384b0ee to f6bdbed95b37 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/d7117384b0ee..f6bdbed95b37 2022-01-17 capn@google.com Download Boost 1.78.0 from jfrog.io If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: Ica826dcc34a9ebc10ea4f85d7bcc09c0169a3080 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3397781 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll c31e14d9 2022-01-18T10:01:03 Roll vulkan-deps from d891854a594a to 4cda77455291 (30 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/d891854a594a..4cda77455291 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/57e25195eb..6624e13673 * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/fe5a0aa72f..08d5f5ed18 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/05c839ca01..8a40f6de57 * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/d99496fcb1..0873a22a11 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/a72d5bc3eb..0fd1cf08c9 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/d15ff77bda..2ee12e8ba3 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/d18a6f03cf..15ed1f6530 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: If4e0dd2efeec82fc0901f0373bec93a719247f92 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3398269 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Maksim Sisov 4572a176 2022-01-03T13:29:59 Add support for GL_MESA_framebuffer_flip_y 3/* This is a third CL that adds tests that exercise the extension in various use cases. Bug: chromium:1231934 Change-Id: Iae3192cd0985150b6844a2855a9a048a54353655 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3365195 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Maksim Sisov <msisov@igalia.com>
angle-autoroll a7655007 2022-01-18T07:37:29 Roll Chromium from 86a4c63b080e to 8cf5fa683fa3 (329 revisions) https://chromium.googlesource.com/chromium/src.git/+log/86a4c63b080e..8cf5fa683fa3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/856c5551f7..4730425268 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/a38a05af62..d78d7bf604 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/a09d233b29..c27c97a625 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/ff4ceffa16..469fa94ee5 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/096eb5b5c7..e3a86ade34 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..a2e49be1ef * third_party/turbine: ttEtncMGe74t-cysVW-3cc6loq-end5oDsc-Exn8WDsC..8Wzi8_CpwqQkJeczCQavMiPI6wJMCSLh_4jpRwUIlSkC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/efdf2fb479..3da260b0f2 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/4e7e1c53af..e5b892c59d Clang version changed llvmorg-14-init-14241-ged3a4a49:llvmorg-14-init-12719-gc4b45eeb Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/efdf2fb479f0ec12522b96a9b5092fb061f67318..3da260b0f2ad81546ed772ee30873fc7d9e0e862/scripts/update.py Bug: angleproject:5417 Tbr: syoussefi@google.com Change-Id: I5aec0e5564bad94f824beefc7614f8a7bfec0218 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3397541 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
SeongHwan Park 9b231f09 2022-01-18T04:49:08 Vulkan: Fix incorrect bit test when mipmapping Fixed an issue where angle::Bit was used instead of angle::BitMask when should selecting [0, x) to set bit range (x, y] in an n-bit bitmask. Bug: chromium:1287962 Change-Id: I053fbc836ef12b0dfd30305fd527de3fabfdf525 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3394468 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 158ecba6 2022-01-07T16:40:26 Vulkan: Remove cached Impl pointers from ContextVk. These pointers were a common source of programming error, where sometimes they wouldn't be updated when they were needed. Instead we can pull the objects directly from the GLES state. We added them initially to attempt a performance improvement, but it's likely they didn't significantly decrease memory accesses or the number of instructions we process for GLES calls. Hence removing them should be an improvement in safety without a perf loss. Bug: angleproject:6864 Change-Id: I54107686992065a514077c71d173b804e295515e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3378904 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Peng Huang 5adee916 2022-01-11T13:09:55 Wrap some global vulkan methods which depend on env variables ANGLE scoped sets some envion variables during initialization. Those env variables will change some vulkan global methods behavior. So to make sure those global methods have same behavior, this CL wraps those global methods, and sets those envion variables before call those vulkan methods. Bug: chromium:1264439 Change-Id: Ie4e29884fcf5b67f4e53ddd3c90a9ade7b226a1f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3379209 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org>
Takuto Ikuta 652e3db4 2022-01-17T18:58:51 use vpython3 in run_gtest_angle_test.py Bug: chromium:1275016 Change-Id: I5de36e1e89b3b657df0b6c302801303539f4fc90 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3394467 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 770c81b9 2022-01-17T10:01:09 Roll SwiftShader from cd848cd695a4 to d7117384b0ee (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/cd848cd695a4..d7117384b0ee 2022-01-14 bclayton@google.com kokoro: Switch over to using the radial docker image 2022-01-14 sergeyu@google.com [Fuchsia] Update path to .so in the generated ICD manifest If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I7921ead0d4f93eadeb65e3fac1f7a44c654462fa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3394826 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 9cfb4dd9 2022-01-17T07:02:15 Roll Chromium from c00f3886d7aa to 86a4c63b080e (890 revisions) https://chromium.googlesource.com/chromium/src.git/+log/c00f3886d7aa..86a4c63b080e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/d333ff4583..856c5551f7 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/4332092b9e..a38a05af62 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/834e4a3c86..a09d233b29 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/81e37b1320..ff4ceffa16 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..a2e49be1ef * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/af9d5b78fd..fd7427ccf6 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/bfa8372dea..efdf2fb479 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/acc125633c..b96ec062b2 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/6338c8fa23..4e7e1c53af No update to Clang. Bug: angleproject:6037 Tbr: geofflang@google.com Change-Id: I6a9a104dcf16a21c87d79d0c50fe10dab329bd0f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3394546 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jonah Ryan-Davis 0aae0d7a 2022-01-11T15:17:10 Update PrintSystemInfo with missing fields. SystemInfo's PrintSystemInfo was out of date and missing some newer fields. Bug: angleproject:6888 Change-Id: Ia73065d60ec3fab6affe21b81398ffb2fe587e9b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3379709 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Shahbaz Youssefi 6601b8d2 2022-01-14T14:15:24 Vulkan: Fix storage buffer limits on geom/tess without Vulkan support Bug: angleproject:6896 Change-Id: I7172b65b460122fcb2485921fadb360dba199283 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3388117 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill c4c73e82 2022-01-14T12:55:20 Fix RobustBufferAccessBehaviourTest. Use "NoFixture" to enable the extension when available. Bug: angleproject:6897 Change-Id: Ieb3383fbff4df664ad35dd034de3bdd7f8508ed6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3388115 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Yuly Novikov 30254d34 2022-01-14T12:54:40 Ignore VUID-RuntimeSpirv-NonWritable-06341 warning To facilitate setting up Pixel 6 bot, where it triggers Bug: angleproject:6896 Change-Id: I69241f56a3b26ed932f06563aca700ff77fdb2dd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3388195 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 158d4783 2022-01-13T13:30:34 Vulkan: Suppress VVL message about allocation exceeding heap size VMA does not check the result of vkGetBufferMemoryRequirements against the heap size before attempting to make an allocation, which leads to a validation error. The error is benign for ANGLE as the subsequent Vulkan allocation will fail, leading to an OOM generated by Vulkan isntead of ANGLE to the same effect as far as the application is concerned. Bug: angleproject:6444 Change-Id: Ia474629971d6835f727b3fb43313a6003e3c939a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3387088 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Nicolas Capens <nicolascapens@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Gert Wollny 28f05f41 2022-01-14T15:12:29 Capture/Replay: Add annotation for crashing test Bug: angleproject:6895 Change-Id: I069dbbaccc875245096d48a74fe16308d5f8d065 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3386946 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Roman Lavrov 6e2ab29d 2022-01-11T22:39:05 Avoid data race in overflow check. `mSerial + 1 > mSerial` involves reading the value multiple times which results in a data race. Bug: angleproject:6633 Change-Id: Iae289ba2ee54190703f16f60319d10988da46cb9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3381854 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll 4f3a50e5 2022-01-14T07:01:43 Roll Chromium from 3fcf884156d8 to c00f3886d7aa (595 revisions) https://chromium.googlesource.com/chromium/src.git/+log/3fcf884156d8..c00f3886d7aa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/d4614b6d58..d333ff4583 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/0c34f74b2c..4332092b9e * testing: https://chromium.googlesource.com/chromium/src/testing/+log/305f9af1e7..81e37b1320 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..17bc902374 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/42afe9a2d3..af9d5b78fd * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/0639a8c19c..8e8704fdfa * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/981ff984d3..6338c8fa23 No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: Ie24a434a2758f2a6a6c3c3f7b69feffb77a6a49d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3388867 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Tim Van Patten 6312da1a 2022-01-10T14:00:55 Vulkan: Disable GL_KHR_parallel_shader_compile Disable the extension GL_KHR_parallel_shader_compile in the Vulkan backend. Vulkan's shader compiler is very fast and is outweighed by the threading overhead. Additionally, Vulkan doesn't support parallel linking, which is where the real benefit of multithreading lies. Bug: angleproject:6748 Change-Id: I0cd14856865eaaade6bfa40d4bf9f133d613b4d6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3379302 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
Jonah Ryan-Davis 9f3c306e 2022-01-13T13:34:36 Fix collection of systemDeviceId on Mac/M1 Use the AGXAccelerator registry Id to match to the MTLDevice registry Id. Bug: angleproject:6143 Change-Id: I6fc868cbc9d5f442e042b5afeade6f71dbb2915b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3387081 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Amirali Abdolrashidi 9b1a6d8a 2022-01-06T10:38:25 Vulkan: Invalidate depth/stencil unconditionally * Moved depth/stencil content invalidation during swapImpl() to doDeferredAcquireNextImage(), so it can be done regardless of whether render pass optimization is done. Bug: angleproject:6861 Change-Id: I47fab18afe5b178bf55c2df3df712c40118aff1f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3370583 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Jamie Madill bd64b3ea 2021-12-30T13:47:09 Move pipeline uniforms into the executable. Refactoring change only. Bug: angleproject:3570 Change-Id: I8cfe41d86aa63d395d7da02dcc3c85a18fde553e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3359002 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 985db640 2022-01-13T09:59:08 Fix test harness config parsing in Compressed Tex tests. These compressed texture formats tests were producing the compressed format as the config name. This CL fixes the test names so that the config is at the beginning, which is where the test harness expects it. e.g.: https://chromium-swarm.appspot.com/task?id=586b4c3bfbd32610 "Completed batch with config: SRGB8_ALPHA8_ASTC_5x5" Prior name: <>.Test/SRGB8_ALPHA8_ASTC_5x5__ES2_Vulkan New name: <>.Test/ES2_Vulkan__SRGB8_ALPHA8_ASTC_5x5 Also includes a fix for the AsyncQueue skip on TSAN, because now AsyncQueue might not be the last part of the test name. Bug: angleproject:6280 Change-Id: Ic4ce4571ba14cc3828c9a93938d49033bcda5d6d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3387053 Reviewed-by: Peng Huang <penghuang@chromium.org> Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Alexey Knyazev f4b0a95f 2021-12-16T02:38:26 Metal: Implement EXT_shader_texture_lod Added CubeMapTextureTest.SampleCoordinateTransformGrad_ES3 Bug: angleproject:6815 Bug: angleproject:6824 Bug: angleproject:3814 Bug: angleproject:6891 Change-Id: I9007bf8ba91309fb9b597e2d1bd33281ff59644a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3343488 Reviewed-by: Gregg Tavares <gman@chromium.org> Reviewed-by: Kyle Piddington <kpiddington@apple.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
angle-autoroll 814a78af 2022-01-13T07:01:23 Roll Chromium from 3668290e6162 to 3fcf884156d8 (108 revisions) https://chromium.googlesource.com/chromium/src.git/+log/3668290e6162..3fcf884156d8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/21d8bd5b30..d4614b6d58 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/8829496cf6..0c34f74b2c * testing: https://chromium.googlesource.com/chromium/src/testing/+log/4547d2f4d5..305f9af1e7 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..17bc902374 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9fa0cb7230..42afe9a2d3 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/00a18c9625..acc125633c No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: I828f26dd1cfb04e95afd26b1fd4b8c6a6c788a28 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3385855 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll d4412d0a 2022-01-13T00:21:47 Roll Chromium from 3d4921afbcfd to 3668290e6162 (378 revisions) https://chromium.googlesource.com/chromium/src.git/+log/3d4921afbcfd..3668290e6162 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC geofflang@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/e73fdb69e8..21d8bd5b30 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/d97420b2b6..4547d2f4d5 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/9ef57f6031..096eb5b5c7 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..17bc902374 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/efd9399ae0..fc5cfd78a3 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/ad0c23f6d2..00a18c9625 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/178ab2e018..981ff984d3 No update to Clang. Bug: angleproject:6430 Tbr: geofflang@google.com,ynovikov@google.com Change-Id: Ib78663bf66304617c0ce791aaf08cd6f0e46be7b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3385195 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jonah Ryan-Davis 2f4f5f8a 2021-12-14T17:30:42 Add EGL_ANGLE_platform_angle_device_id for the Metal backend. This extension takes in a 64-bit device ID in two parts as parameters to eglGetPlatformDisplay and uses it to initialize a display backed by a specific device. The deviceID should match the MTLDevice's registryId. Bug: angleproject:6143 Change-Id: I02188b8266f8d0ac657b04325d191ab89bbef751 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3337985 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Brandon Schade 0ab15998 2022-01-07T09:59:23 Translator: Don't promote precision for assignment operation lvalues Assignment operations should use the precision of their lvalue-expression, even if their rvalue-expression has higher precision. Bug: angleproject:6889 Change-Id: I9a105631defb6c1e27870c96517aa66fbd95543e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3381906 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Brandon Schade <b.schade@samsung.com>
Peng Huang cd157aae 2022-01-12T14:44:50 Revert "Use STL container for vulkan memory allocator" This reverts commit cc516f97018fdcbcded2b0bad712a0bc2af4e227. Reason for revert: This is not the right way to use STL containers in VMA. See [1] for detail. [1] https://chromium-review.googlesource.com/c/external/github.com/GPUOpen-LibrariesAndSDKs/VulkanMemoryAllocator/+/3381940 Original change's description: > Use STL container for vulkan memory allocator > > There is a crash related to VMA containers, so switch to STL > containers to see if it can workaround the issue. > > Bug: chromium:1266412 > Change-Id: I8416e4b4a27588ac2d710a4ef7600cd91b080535 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3327744 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Peng Huang <penghuang@chromium.org> Bug: chromium:1266412 Change-Id: Ib020c824a3576489c728503a2ced68ca772d4065 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3381979 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org>
angle-autoroll 89467fa5 2022-01-12T08:12:23 Roll Chromium from 597c376626be to 3d4921afbcfd (999 revisions) https://chromium.googlesource.com/chromium/src.git/+log/597c376626be..3d4921afbcfd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/12badc1f9a..e73fdb69e8 * buildtools/linux64: git_revision:f1b1412521b41e47118b29863224171e434a27a2..git_revision:80a40b07305373617eba2d5878d353532af77da3 * buildtools/mac: git_revision:f1b1412521b41e47118b29863224171e434a27a2..git_revision:80a40b07305373617eba2d5878d353532af77da3 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/a0ace9923e..8829496cf6 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/58d1647360..834e4a3c86 * buildtools/win: git_revision:f1b1412521b41e47118b29863224171e434a27a2..git_revision:80a40b07305373617eba2d5878d353532af77da3 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/85cca6c8d9..d97420b2b6 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/edde12c2d3..9ef57f6031 * third_party/android_build_tools/aapt2: ZHiDoiurxMLwajQq_CwBH9zaDW5xwYWYGbedxIslTm8C..0yR8wK_fSMgdVKwnx4nRPi-amaLV7Kcr4Os6mg_DGI4C * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..486f67f3ec * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d3cc7ad85e..9fa0cb7230 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/6e330f7e33..bfa8372dea * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/3b1084819d..ad0c23f6d2 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/b7dc143ef9..178ab2e018 Clang version changed llvmorg-14-init-12719-gc4b45eeb:llvmorg-14-init-14241-ged3a4a49 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/6e330f7e3331c542eaf8eea1008b8b85449a2bc5..bfa8372deaca7059d7f1d79b29df50b5c0c5f05a/scripts/update.py Bug: angleproject:6884 Tbr: geofflang@google.com Change-Id: I96f32711eb0f95a7696c8cad19312ae91efc0b0d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3382569 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya d4c8209b 2022-01-10T13:30:06 Fix validation of copyImageSubData related to texture completeness Fixed an edge case in validation code where we were not properly ignoring format rules for texture completeness as required for copyImageSubData by the ES 3.2 specification Bug: angleproject:5363 Tests: KHR-GLES32.core.copy_image.r32*_texture Change-Id: Ibf8a6f4708e2135f0eb6f4ba58d4ce413f11ce5b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3379224 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Kyle Piddington 4a819ee2 2021-12-10T17:58:27 Update code generation script to work with specified generators Add --generator flag to run a single generator Bug: angleproject:6780 Change-Id: Icfa827327aed96dcb69107f3c63ec13090a76111 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3331673 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Kyle Piddington <kpiddington@apple.com>
Mohan Maiya 96fd9b72 2022-01-10T13:17:43 Fix validation of glCompressedTexImage3D GLES 3.2 spec allows for glCompressedTexImage3D to accept TEXTURE_CUBE_MAP_ARRAY as a target as well. Account for this during validation. Bug: angleproject:5393 Tests: KHR-GLES32.core.texture_cube_map_array.etc2_texture Change-Id: Ieb75e63021bea2ea6f8fcc68bd6b666d0bd7f5dc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3379225 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Lingfeng Yang 926b43e7 2022-01-06T13:31:54 Reland: Frontend: separate lock in swap prep Swapchain-based backends like Vulkan might block a lot in vkAcquireNextImageKHR, which is bad for overall fast progress if we also hold the global EGL lock there. This CL starts to split the global EGL lock. We release the EGL lock when performing vkAcquireNextImageKHR, and only maintain a lock for surfaces. This is done via a new custom entry point, EGL_PrepareSwapBuffers, so that we can control how the global lock is used throughout the entire call. Bug: angleproject:6851 Change-Id: I095cd8b3bdbb13c842cab0a46148e2122582cdfd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3373426 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Lingfeng Yang <lfy@google.com>
Mohan Maiya 2d105177 2022-01-10T11:44:37 Enable a few features for Samsung Check for Samsung vendorID and enable a few features. Bug: angleproject:5111 Change-Id: I17a93bfb9a094b80d185eb3d2a08ed00f528a30b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3379223 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Roman Lavrov 345cdcb0 2022-01-10T22:41:46 Rename features for consistency. supports_custom_border_color -> supportsCustomBorderColor supports_protected_memory -> supportsProtectedMemory Also drop EXT from the end of the variable name as other variables don't have that. Bug: angleproject:6731 Change-Id: I60b20d84387bccbca0c4c1cbc7e341c1f5e8f0ba Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3378827 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Tim Van Patten b0e15ee4 2021-12-28T20:37:33 Decide GL_KHR_parallel_shader_compile in backends GL_KHR_parallel_shader_compile was previously being enabled unconditionally in the front end. However, some backends (Vulkan) perform worse with parallel shader compilation. This CL moves the decision of enabling GL_KHR_parallel_shader_compile to the backends. To support single-threaded shader compilation without affecting the generic worker thread pool, Context::mSingleThreadPool is added to own the single-threaded WorkerThreadPool and can be returned by the new function Context::getShaderCompileThreadPool(). Otherwise, if the extension is enabled, the (renamed) Context::mMultiThreadPool is returned. Bug: angleproject:6748 Change-Id: Ic8d3a183f397608f3002a05480deb976dfe44792 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3360337 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
Yuxin Hu a026d053 2021-12-22T01:08:33 Add support for subgroupSize of 16 in Debug Overlay Module The subgroupSize on some Android devices is 16, which is not supported by current OverlayCull and OverlayDraw compute shaders. This change adds support for subgroupSize of 16. This change also removes the subgroupBallot and subgroupArithmetic paths in OverlayCull compute shader. These two paths were added by Shabi as an experiment, and he suggested to remove them for easier code maintenance purposes. Bug: angleproject:6806 Change-Id: I5ce68cb18fbf3472c987d811c89f065cb8581858 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3352865 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Geoff Lang f180ecc9 2022-01-11T10:32:23 Supress TransformFeedbackPausedDrawThenResume on Mac AMD Mac AMD OpenGL fails this test the same way as TransformFeedbackTest.TransformFeedbackQueryPausedDrawThenResume Bug: angleproject:6643 Change-Id: Ifbae1751deeaddbe64fa1ac284e0fa04e02c666f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3380009 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
angle-autoroll 5ec02c8f 2022-01-11T10:01:09 Roll SwiftShader from b57a3aaee927 to cd848cd695a4 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/b57a3aaee927..cd848cd695a4 2022-01-10 capn@google.com Optimize mirror addressing mode If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I0e54064ef9de5610987cd9e5979b02fa0863a69c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3380311 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 7f8e7c38 2022-01-11T10:01:03 Roll vulkan-deps from 328da0f26e8e to d891854a594a (9 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/328da0f26e8e..d891854a594a Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/c0a322f5f0..57e25195eb * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/c5ee1bc7bd..05c839ca01 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/f5d16bf89e..a72d5bc3eb * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/e406ff1473..d18a6f03cf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I4cda9ad2e5dc7d69a7d0e84d3848b564a0467b27 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3380312 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
John Cunningham 0b02a592 2022-01-10T20:27:25 Metal: Generated Metal shaders do not compile offline Add an explicit include for the Metal stdlib to fix missing symbol errors Bug: angleproject:6886 Change-Id: Ie84ef1c16f964387b63e36490d7e9abc0c1763f2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3379238 Reviewed-by: Kyle Piddington <kpiddington@apple.com> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org>
Gregg Tavares 6a255833 2022-01-07T16:13:58 Metal: Fix transform feedback issue The issue is if you issue 2 draw commands back to back, Metal partially ignores the 2nd. Bug: angleproject:6884 Change-Id: I702335ca06828bed1f553f1f5563ddc99f00bc99 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3373736 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Kyle Piddington <kpiddington@apple.com> Commit-Queue: Gregg Tavares <gman@chromium.org>
Mohan Maiya 37cde9e9 2022-01-10T10:59:28 Update GLES31 expectations file The commit f9dbd4efb3b8c1550 fixed a validation bug related to framebuffer and texture buffers but missed updating the expectations file. Remove skip for related test. Bug: angleproject:5579 Tests: dEQP-GLES31.functional.debug.negative_coverage.get_error.buffer.framebuffer_texture Change-Id: Id8807479e63d886b85512a88eaaeac93488e0545 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3377763 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Mohan Maiya e38dab0a 2022-01-10T10:58:40 Add missing implementation for glGetnUniformuiv() GL_KHR_robustness became core in GLES 3.2 and added glGetnUniformuiv() function in gles_3_2 entry points but this function was missing implementation in Context.cpp. Also fixes ES32 validation for glGetnUniform*v Bug: angleproject:6593 Tests: KHR-NoContext.es32.robustness.getnuniform Change-Id: Ic26190e59d448d93ae9e2e0d2a7faff14c3776f8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3373436 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Jonah Ryan-Davis 74e03b9a 2022-01-06T11:23:12 Expose the registryID of GPUs on Mac via SystemInfo As part of a new extension, ANGLE_platform_angle_device_id, GPU selection on Mac will depend on the registry ID of each GPU. These Ids must be listed in SystemInfo for Chrome to select from. Bug: angleproject:6143 Change-Id: I7ee4a796d2cb26138893dc068a60cac355fe7ba9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3370661 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
kmx.io     mail     discord kmxgit v0.4.0