|
b8d546b2
|
2024-10-30T15:40:58
|
|
Fix immutable string concats with ints
`BuildConcatenatedImmutableString("a", 10, "b")`
would construct "a\nb" because the implementation lacked int overloads
and ints would be promoted to chars implicitly.
Fix by implementing simpler way to calculate digits for numbers
and then add useful overloads. Remove
ImmutableStringBuilder::appendDecimal() since the code is already
expecting << for all other types, and the bug was due to this
expectation.
Bug: angleproject:376417347
Change-Id: Iea5e14a6e2fede068b704754b9203db794dd5bf0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5972641
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com>
|
|
7bb1e0f6
|
2024-10-29T13:18:49
|
|
restricted_trace_perf: Allow use of system ANGLE libs
This change allows the perf script to use built in ANGLE libs,
including from the system partition, instead of requiring a
separate package.
By default, the script will now use the ANGLE libs packaged in the
test APK (com.android.angle.test).
OpenGL/EGL calls will still go though the platform EGL loader, but
you no longer need to install a separate ANGLE APK containing libs.
To use the system libs, add the following flag:
--angle-package system
You can use it to point to *any* package that is queryable and
contains ANGLE libraries. To get the previous behavior, you'd use:
--angle-package org.chromium.angle
Also two small unrelated fixes:
* Fix typo when clearing shader cache
* Broaden the 'MODEL' skip in thermal throttling
Bug: b/376300037
Change-Id: I762cfd7516026e903a6a5de2949d50e96e766d48
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5976899
Reviewed-by: Roman Lavrov <romanl@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
236e0f48
|
2024-10-22T18:33:23
|
|
Add fix for create multi-window surfaces cause crash
This patch fix crash when created multiple window surfaces,
and not call corresponding eglDestroySurface, also added related test.
Bug: angleproject:374797737
Change-Id: I58941660130e84e213cf9d78806027d56d6efc8c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5981430
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
913251aa
|
2024-09-25T17:42:59
|
|
Add clear tests related to layered image
* Added tests to bind a layered framebuffer to a 3D image and clear it.
Bug: angleproject:42266869
Change-Id: I488a26883d3e05daf0cc746ccf4b409ba470cb4a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5889409
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
1652f8ed
|
2024-10-17T13:35:39
|
|
Vulkan: end2end tests when descriptorSetCache is disabled
Some end2end tests are testing specific descriptorSet cache behavior.
When cache is disabled, these tests failed. In this CL these perfCounter
based tests haven been modified to check total allocation to ensure the
descriptorSets are properly reused instead of cache hit/miss.
Bug: angleproject:372268711
Change-Id: I1d2f4cfcf622b05cdcb3317c8804416a80e72c48
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3735732
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
a7ef6444
|
2024-10-29T09:39:24
|
|
Tests: skip D3D11 dEQP-GLES2.functional.polygon_offset
Got re-enabled in
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+/0d2b73e3a4b70d3117abca393e2b86ccf99f4c31
The GLES3 version is already skipped for this config
Bug: angleproject:42260109
Change-Id: Ief290695dd97d7ecf84f2e06f352d9135e0748b6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5974494
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Roman Lavrov <romanl@google.com>
|
|
|
4397ff2f
|
2024-10-25T16:55:30
|
|
Metal: SeparateCompoundStructDeclarations fails validation
Consider GLSL:
struct S { int i; } s;
s=s;
SeparateCompoundStructDeclarations would rewrite this to:
struct S { int i; };
S s';
s=s;
The interm rewrite would rewrite the specification and declaration of s,
but not the use sites. The use sites would use the old type, and thus
something that was not in the tree anymore. This would fail the
validation.
This kind of bug was previously fixed for SeparateDeclarations
in commit 18fa02bebf901dd8501de3176f6052ae4ce984be.
Fix by adding the logic to SeparateDeclarations, as it is already
doing almost the exact task, separating `struct S { ..} a, b`.
The separation is tested in GLSLTests.StructInShader and various
other draw tests. These pass with MSL, but these would also fail
validation if that was enabled.
Bug: angleproject:375523825
Change-Id: I1697103d0ba47616dbd3159f36f9e71cb2831c4b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5964899
Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com>
Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
4a5b0284
|
2024-10-24T11:46:54
|
|
Disallow discarded uniform block references
Uniform block instances cannot be used by themselves, as there
is no way to refer to their type. Disallow the only typeless
access pattern, discarding via expression statement:
uniform MyBlock { int x; } b;
void main() {
b;
0, b;
}
Explained as disallowed in newer GLSL 300:
https://github.com/KhronosGroup/WebGL/issues/3644
The comma expression form would ASSERT in CollectVariables.
Bug: angleproject:42267026
Change-Id: I6c8b835482fd551bd97576c1bd24f005874da6af
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5961498
Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com>
Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com>
|
|
|
898a1c12
|
2024-10-24T13:09:36
|
|
Metal: Fix ToposortStructs validation == failures
ToposortStructs would convert mat, vec, struct == to ANGLE_equals()
calls. However, the functions called were not in AST. This would cause
"Found node calling previously undeclared function
<validateFunctionCall>" validation error and ASSERT.
Mat, vec equality calls would use prelude ANGLE_equals implementations.
The MSL emit already does the conversion from == to ANGLE_equals for
these builtins.
For user-defined structs the logic would be:
- collect struct decls, structs, create equality functions
- toposort
- for each sorted struct:
- insert struct decl
- insert equality function
Move the equality function creation after the toposort:
- collect struct decls, structs
- toposort
- for each sorted struct:
- insert struct decl
- create equality function
- insert equality function
This way the sort ensures that nested struct equality functions can
refer to previously introduced equality functions.
Bug: angleproject:375352601
Change-Id: I59efed98bca6d99b198abc2b5c7577cf5d1d5d83
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5961281
Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com>
|
|
08c1724f
|
2024-10-11T14:29:00
|
|
Vulkan: Support GL_ARM_shader_framebuffer_fetch_depth_stencil
Bug: angleproject:352364582
Change-Id: I63fd78314fa7ebccbf366c252e309a9c0f09c8c1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5938150
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
65fcf9c4
|
2024-10-26T10:53:18
|
|
Vulkan: Remove redundant dependent feature checks
Since [1], when a feature is overriden, the dependent features
automatically take the override into account. Tests no longer need to
account for dependent features, neither does the logic in the code.
[1]:https://chromium-review.googlesource.com/c/angle/angle/+/4749524
Bug: angleproject:42266725
Change-Id: I5440aba4a89cffbe710e26ad7de4cfee783e9bdf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5967414
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
|
c13e9963
|
2024-10-28T15:19:09
|
|
Tests: skip mac intel dEQP-GLES2.functional.polygon_offset
Got re-enabled in
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+/0d2b73e3a4b70d3117abca393e2b86ccf99f4c31
The GLES3 version is already skipped for this config
Bug: angleproject:40096462
Change-Id: I8b6eca1faec9442c6de323000cd223b0c169e35d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5972595
Commit-Queue: Roman Lavrov <romanl@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Roman Lavrov <romanl@google.com>
|
|
ba65fc48
|
2024-05-01T15:53:20
|
|
ANGLE unit test to check const expression in a shader with uniform
Bug: b/338287961
Change-Id: I81586122fdb6cdfe650b9c9094582276220741f1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5507766
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
|
|
|
0d5c0bd1
|
2024-04-25T10:26:08
|
|
ANGLE end2end test to check const expressions are handled correctly
Bug: b/337046547
Change-Id: I1bd368f8c95a9676aba13fe91313d0eaba32db03
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5490170
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
|
a0586d6e
|
2024-10-26T00:32:27
|
|
Remove feature description / condition strings
These strings show up in chrome://gpu so they can marginally be useful,
but are otherwise dead weight for most uses of ANGLE / users of ANGLE.
While slightly less convenient, the feature name can always be linked
back to the source code if needed so the presence of such metadata is
not necessary either.
This shaves 40KB from the binary size of ANGLE when built with Vulkan
only on Android.
Bug: chromium:371512561
Change-Id: I3959961bb7de95cc60a85130d0ff38a7fd533fb7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5968453
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
4353d25c
|
2024-10-25T16:16:58
|
|
Fix ASAN bug in GLSL test
Bug: chromium:375344329
Change-Id: Id275ba7877c5092bf7b55c06fcfa80614886985c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5967933
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
3a265f14
|
2024-10-24T17:34:15
|
|
Android tests: raise if --render-test-output-dir doesn't exist
For convenience when testing locally,
otherwise we get an obscure error later on
Bug: angleproject:370089935
Change-Id: I94f52aef90afb600baae45540e0e53f899554ee9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5960260
Auto-Submit: Roman Lavrov <romanl@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Roman Lavrov <romanl@google.com>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
ec262a32
|
2024-10-22T12:34:15
|
|
Trace tests: offscreen gles1 fix framebuffer binding handling
gles1 traces can call glBindFramebufferOES (ex: plague_inc) so we need
to intercept that for offscreen gles1 traces.
Also OES_framebuffer_object does not provide "read" bindings, only a
single framebuffer binding, so we need to special-case binding handling
in the gles1 case.
Bug: angleproject:370508393
Change-Id: Ia17df21ed67aa8a1e0aa45fe9bb929ce42852ba2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5953095
Commit-Queue: Roman Lavrov <romanl@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
12584049
|
2024-10-21T14:04:55
|
|
Make SimplifyLoopConditions testable
Add ShCompileOptions::simplifyLoopConditions, so that tests can turn
it on. Later edits to simplify loop condition logic are simpler to
review when the testing related edits are landed separately.
Test the feature by having ESSL as the input and ESSL as the natural
output, to reflect how AST changes.
To make the test expectations more deterministic across code changes,
change SymbolTable::kLastBuiltInId to
SymbolTable::kFirstUserDefinedSymbolId. This is simpler as no code
needs to know exact last built in id, so we can just ensure that
the user defined symbol ids do not clash with the builtin ids.
Bug: angleproject:374585769
Change-Id: Iea0efb8ac2878691d0fd5ff5cfe9a49ac754515d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5946724
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com>
|
|
|
922147f9
|
2024-10-22T18:20:44
|
|
Trace tests: offscreen sRGB traces use sRGB format
Without this offscreen screenshots end up darker.
Currently applies to 7 traces, can be found with:
% egrep 'DrawSurfaceColorSpace.*0x3089' src/tests/restricted_traces/*/*.json
Bug: angleproject:370089935
Change-Id: I4a05782de2e7400fcfcb5757d18acf758749d6ef
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5953096
Commit-Queue: Roman Lavrov <romanl@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
47c66901
|
2024-10-21T12:47:22
|
|
Vulkan: Set gl_Layer to 0 if the framebuffer is not layered
Bug: angleproject:372390039
Change-Id: I29067c9488e06f6dd2e90f207fecb843267fb77c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5949263
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
bbe68963
|
2024-10-21T15:11:27
|
|
Vulkan: Fix `precise` vs `mat4(...)[index]`
Bug: angleproject:374801303
Change-Id: I45550abe406aaaf4d2c5eb5d7d694b2b30ab8e4e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5949528
Reviewed-by: mohan maiya <m.maiya@samsung.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
|
5c2a2fd5
|
2024-10-21T16:00:25
|
|
Vulkan: Fix `vec4(...).zxwy[index]`
The code was actually correct, but included an unnecessary assertion.
The code incorrectly assumed `.zxwy[index]` is pre-processed with a
lookup table and turned into `[index']`, but it wasn't if the LHS is a
constructor.
The change just removes the assertion because it was correctly handling
that already.
Bug: angleproject:40096715
Change-Id: Ib1365f95a255ce3654831af55429361d35c026c4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5949527
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
ef55ca0a
|
2024-10-17T14:44:22
|
|
Update copy validation regarding ext textures
* Updated the validation functions for the following function to
accept TEXTURE_EXTERNAL_OES: glCopyImageSubDataEXT()
* Updated unit test CopyTextureTestES3.CopyImageSubDataToEGLImage
* Using TEXTURE_EXTERNAL_OES as target for glFramebufferTexture2D()
requires EXT_YUV_target. Therefore, the texture related to it is
used instead.
Bug: angleproject:361372990
Change-Id: I905d4cf89522ae3158516b42b15705d1044c6e97
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5940404
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
ff455e8c
|
2024-10-17T13:19:09
|
|
Add tests to check copy image with TEXTURE_EXTERNAL_OES
According to spec of EXT_copy_image, GL_TEXTURE_EXTERNAL_OES should be
accepted by glCopyImageSubDataEXT.
Add two tests to check copy image from gles texture to EGLImage and from
EGLImage to gles texture by API glCopyImageSubDataEXT.
As ANGLE does not support this currently, skip these two tests on all
platforms.
Bug: angleproject:361372990
Change-Id: Iceacb2d6af2277a314a215220c3ccdf47665561c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5940214
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
182aa407
|
2024-08-14T19:52:30
|
|
Reland "Metal: translate IOSurface pbuffer's GL_RGB to RGBX/BGRX format."
This is a reland of commit f102d75a39ec8980a617c179034c24f337b12d1c
Nothing changed, it's just that the root cause was already fixed in
https://chromium-review.googlesource.com/c/angle/angle/+/5937060.
Original change's description:
> Metal: translate IOSurface pbuffer's GL_RGB to RGBX/BGRX format.
>
> Currently when IOSurface is bound to a pbuffer with GL_RGB internal
> format, we asign angle format=B8G8R8A8_UNORM/R8G8B8A8_UNORM to it.
> And then disable alpha write to the respective MTLTexture.
>
> However, when an implicit MSAA texture is created for the above
> pbuffer, it will be assigned B8G8R8A8_UNORM/R8G8B8A8_UNORM angle format
> but has no knowledge about alpha write disable. Consequently, when a
> render pass uses this implicit MSAA texture, its alpha channel won't be
> cleared properly and would contain garbage values.
>
> In order to avoid the above bug, we should use
> B8G8R8X8_UNORM/R8G8B8X8_UNORM angle format for the IOSurface pbuffer.
>
> This will fix the render corruptions found in chromium:358957665.
>
> Bug: angleproject:42261786
> Bug: chromium:358957665
> Change-Id: I8aa1e24ace2de80dd08e21711445515ba4b339ff
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5788801
> Reviewed-by: Geoff Lang <geofflang@chromium.org>
> Commit-Queue: Quyen Le <lehoangquyen@chromium.org>
Bug: angleproject:42261786
Bug: chromium:358957665
Change-Id: I1e090886ed493eafce35d2ba98010c3be7bc16c9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5937061
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Auto-Submit: Quyen Le <lehoangquyen@chromium.org>
Commit-Queue: Quyen Le <lehoangquyen@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
4b1e58d9
|
2024-10-17T09:33:53
|
|
Fix for float constant precision in the GLSL backend.
Increase the precision of floating point values written out
via std::ostringstream. 8 digits is not sufficient to represent
all floating point values.
Note: the reason the locale test was modified is because it was using
a value of 1.9, which has no exact fp32 representation. Increasing
the precision causes it to print as 1.8999998 instead of 1.9, failing
the test. I've adjusted the value to 1.5, since this does have an
exact fp32 representation. (However, note that I couldn't get the test
to fail when I removed the locale setting, with either 1.9 or 1.5.
Perhaps the locale is being handled at a different level.)
Bug: angleproject:374013421
Change-Id: Icb79eb9acd562c83d079f2cc2cdba253220e581e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5938473
Commit-Queue: Stephen White <senorblanco@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
5b96316b
|
2024-10-17T14:00:41
|
|
Revert "Metal: translate IOSurface pbuffer's GL_RGB to RGBX/BGRX format."
This reverts commit f102d75a39ec8980a617c179034c24f337b12d1c.
Reason for revert: Suspecting this caused an GPU memory regression on Mac.
Bug: chromium:374072906
Original change's description:
> Metal: translate IOSurface pbuffer's GL_RGB to RGBX/BGRX format.
>
> Currently when IOSurface is bound to a pbuffer with GL_RGB internal
> format, we asign angle format=B8G8R8A8_UNORM/R8G8B8A8_UNORM to it.
> And then disable alpha write to the respective MTLTexture.
>
> However, when an implicit MSAA texture is created for the above
> pbuffer, it will be assigned B8G8R8A8_UNORM/R8G8B8A8_UNORM angle format
> but has no knowledge about alpha write disable. Consequently, when a
> render pass uses this implicit MSAA texture, its alpha channel won't be
> cleared properly and would contain garbage values.
>
> In order to avoid the above bug, we should use
> B8G8R8X8_UNORM/R8G8B8X8_UNORM angle format for the IOSurface pbuffer.
>
> This will fix the render corruptions found in chromium:358957665.
>
> Bug: angleproject:42261786
> Bug: chromium:358957665
> Change-Id: I8aa1e24ace2de80dd08e21711445515ba4b339ff
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5788801
> Reviewed-by: Geoff Lang <geofflang@chromium.org>
> Commit-Queue: Quyen Le <lehoangquyen@chromium.org>
Bug: angleproject:42261786
Bug: chromium:358957665
Change-Id: I29238588f78f2d01c77a317b2a22670a8036d2e3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5939455
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
|
323187d9
|
2024-10-11T13:48:51
|
|
Vulkan: Fix color attachment limit with framebuffer fetch
ANGLE incorreclty assumed that the input descriptor limit is at least as
big as the color attachment limit. This is not true on Intel/windows
where 8 color attachments are available but only 7 input descriptors.
With this change, the color attachment limit is dropped to 7 in such a
case so that framebuffer fetch can continue to be supported.
Bug: angleproject:372873263
Change-Id: If836563b47399a23b293b74815f6bccb21aaf47c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5919759
Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
8d86ae9f
|
2024-10-16T14:38:57
|
|
Skip flaky end2end test
ClearTest.ChangeFramebufferAttachmentFromRGBAtoRGB
on Win Intel GL
Bug: angleproject:373818282
Change-Id: I92ea2ca5aa5423a13d9912a7da964c315b862ec9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5938873
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
|
|
|
e40d8581
|
2024-10-16T10:57:39
|
|
Vulkan: Fix render pass revival vs framebuffer fetch and DR
Bug: angleproject:352364582
Change-Id: I86548251fc1dec75031a23e3461bf296c852919c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5937412
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
68ba532b
|
2024-10-09T14:38:01
|
|
Add validation for ObjectLabel
The validation of ObjectLabel is empty.
Move the validation in ValidateObjectLabelKHR to a new
ValidateObjectLabelBase (except the extension check), and make
ValidateObjectLabel and ValidateObjectLabelKHR both call
ValidateObjectLabelBase after the version/extension check.
An end2end test is added
Bug: angleproject:360903471
Change-Id: Iabfd3c16c5423b2ab2fe5e417fe75eed00237c92
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5919129
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
9e8b104e
|
2024-10-14T00:00:00
|
|
Do not test OpenGL backend on iOS
Added Metal platform to tests
that require instantiation.
Bug: angleproject:40050022
Bug: angleproject:42264029
Bug: angleproject:42266119
Bug: angleproject:42266226
Bug: angleproject:42266239
Bug: angleproject:42266249
Bug: angleproject:359136169
Fixed: angleproject:373478551
Change-Id: I915f09c7f24acce27bf0d489932645338ac3fbe8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5932659
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
|
0dbe85f3
|
2024-10-15T13:54:36
|
|
Increase the size of vector WriteImages to max
ANGLE limits the size of vector which represents the write images when
resolving images. So when blit a multisample buffer to mrt, the sum of
write images is more than 1 and app will abort while checking the size
of the vector.
This patch increases the size of vector WriteImages to max.
Add end2end test to test blit multisampled framebuffer to MRT
framebuffer.
Bug: angleproject:361369302
Change-Id: I2d892bcd3411f2bca2ff514f6f0b6055d872668a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5872512
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
059f66be
|
2024-10-15T10:04:23
|
|
Bugfix in UnitTest_DMSAA_dst_read
Skip UnitTest_DMSAA_dst_read test if GL_EXT_sRGB_write_control
extension is not supported
Bug: angleproject:40644776
Change-Id: I4e8ec6d184b033308b7cd33551555d480bdc8107
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5933569
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: mohan maiya <m.maiya@samsung.com>
|
|
|
91391c06
|
2024-10-02T16:07:02
|
|
Vulkan: Vertex attribute hole crash workaround
* Added condition to bypass reading from a streaming attribute
if the source pointer is null.
* Added unit test that crash if a vertex pointer is not defined
for an enabled vertex attribute.
* VertexAttribPointerCopyBufferFromInvalidAddress
* Credit for the original test: tingwei.guo
Bug: angleproject:359729255
Change-Id: I2592fed66f0eba8c7003ec02cc8ca802833f23b3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5899978
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
f1296738
|
2024-10-15T14:27:43
|
|
Skip end2end tests failing on iOS
BlitFramebufferANGLETest.BlitWithMissingAttachments/ES2_OpenGL
Texture2DTestES3.UnitTest_DMSAA_dst_read/ES3_Metal
Texture2DTestES3.UnitTest_DMSAA_dst_read/ES3_OpenGL
Bug: angleproject:40644776, angleproject:371987004
Change-Id: I414bfa065faa0bbd20cb7d46d00e30d9d92f7f53
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5933825
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
|
|
e7341113
|
2024-10-14T23:37:31
|
|
Manual roll VK-GL-CTS from 179dd9f858f0 to 5e9887eb393c (20 revisions)
Manual roll requested by abdolrashidi@google.com
* Added common source files for FragCoordConventionsTests.
* Suppressed a failing must-pass test for Pixel 4.
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/179dd9f858f0..5e9887eb393c
2024-10-11 piotr.byszewski@mobica.com Test texture LoD query in
combination with base level
2024-10-11 mateusz.bahyrycz@mobica.com Add missing coverage for sparse
binding multisampled images
2024-10-11 mateusz.bahyrycz@mobica.com Add tests for multiple bind
sparse infos
2024-10-11 ziga@lunarg.com Only use depth clamp control create info if
extension is enabled
2024-10-11 kamil.goras@mobica.com Split
KHR-GL46.framebuffer_blit.framebuffer_blit_functionality_multisampled_to_singlesampled_blit
2024-10-11 marcin.hajder@mobica.com Port KC-CTS tests to VK-GL-CTS
(fragment_coord_conventions_multisample), PART 13
2024-10-11 gleese@broadcom.com Fixes for mandatory feature and
feature_consistency tests
2024-10-11 lordalcol@users.noreply.github.com Create
vulkan-cts-withdrawal-2024-10.txt
2024-10-10 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.10
into vk-gl-cts/main
2024-10-04 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.10
into vk-gl-cts/main
2024-10-03 ziga@lunarg.com Add more tests for
VK_EXT_swapchain_maintenance1
2024-10-03 ziga@lunarg.com Test dynamic sample locations without create
info
2024-10-03 piotr.byszewski@mobica.com Coverage for extremely long debug
labels
2024-10-03 Tyler.Schneider@amd.com Add sanity check in Ray Query Stress
Tests
2024-10-03 cwabbott0@gmail.com Revert "Fix crash in local read max input
attachments test"
2024-10-03 scerveau@igalia.com Update vk_video_samples external sources
2024-10-03 rgarcia@igalia.com Add shader module identifier tests with
mesh shaders
2024-10-03 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-cts-4.6.5
into vk-gl-cts/main
2024-10-02 gleese@broadcom.com Remove mandatory_features.txt
2024-09-30 lorenzo@khronosgroup.org Set Amber back to google:main
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC abdolrashidi@google.com,angle-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: angleproject:373475678
Tbr: abdolrashidi@google.com
Change-Id: I2c31b1a15cdafc4c2e528d65a1a67a2672b932d3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5932584
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
4c35748f
|
2024-10-14T16:30:55
|
|
Skip MultisampleTestES3.CopyTexImage2DFromMsaaDefaultFbo on S22
Bug: angleproject:372059358
Change-Id: Ide36309be0310f1449bf4aedce42c60c0fda55c8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5928718
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
a8d9d813
|
2024-10-08T15:31:37
|
|
Trace perf: save individual screenshots in offscreen
With --offscreen, _frameN.png is now the Nth frame, by reading
the offscreen buffers pixels. This is more consistent with onscreen.
Previously we would only get _frame24.png, _frame48.png etc with the
grid of frames from framebuffer 0. Now we get these as _grid1.png,
_grid2.png etc, and _frameN.png are individual frames.
gles1 is an exception as we don't have grids and only render a single
frame to framebuffer 0.
Bug: b/370508393
Change-Id: Ia8cb13120f21ef92fa3e6662b5e2cffa918983d6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5916767
Commit-Queue: Roman Lavrov <romanl@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
0f2ce2cd
|
2024-10-11T12:58:53
|
|
Tests: Add Supreme Duelist trace
Test: angle_trace_tests --gtest_filter="*supreme_duelist*"
Bug: b/372883450
Change-Id: I87931895ea67b437c36bb99e8ab4fa8e1dae3a3e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5926174
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Mark Łobodziński <mark@lunarg.com>
Reviewed-by: Mark Łobodziński <mark@lunarg.com>
|
|
|
ab1cdd22
|
2024-10-03T00:00:00
|
|
Translator: Support EXT_texture_query_lod
No backend support yet.
Bug: angleproject:368275901
Change-Id: I10bbc03feca485908315633cbc0f955e82994657
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5920240
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
68de0042
|
2024-10-08T05:41:37
|
|
Vulkan: Support glCopyTexImage2D from MSAA default framebuffer
Add support for glCopyTexImage2D when the source is an MSAA
default framebuffer by enhancing UtilsVk::copyImage(...) to
support multisampled source images.
Bug: angleproject:372059358
Tests: MultisampleTestES3.CopyTexImage2DFromMsaaDefaultFbo*
Change-Id: I9b5d39f6f75ca8056f8be18b1e68eb0161c99903
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5914629
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: mohan maiya <m.maiya@samsung.com>
|
|
|
9e9cbd97
|
2024-10-10T14:49:00
|
|
Tests: Add Antistress Relaxation Toys trace
Test: angle_trace_tests --gtest_filter="*antistress*"
Bug: b/372644017
Change-Id: Ic9bff87955e25fb6d6a6d787ae012740f4158a7b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5924477
Commit-Queue: Mark Łobodziński <mark@lunarg.com>
Reviewed-by: Mark Łobodziński <mark@lunarg.com>
|
|
|
e6130b90
|
2024-10-09T13:14:10
|
|
Tests: Add Car Race 3D trace
Test: angle_trace_tests --gtest_filter="*car_race_3d*"
Bug: b/372282084
Change-Id: Icad78909e68eec6790844c75c6103219ba15299a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5922075
Reviewed-by: Mark Łobodziński <mark@lunarg.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Mark Łobodziński <mark@lunarg.com>
|
|
|
ae5c3b96
|
2024-10-08T17:02:21
|
|
Boilerplate for GL_ARM_shader_framebuffer_fetch_depth_stencil
Bug: angleproject:352364582
Change-Id: I94c670db5546564a6f60bb513a6d7f3f5bd5778c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5916771
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
|
3e8d09a1
|
2024-10-08T17:01:02
|
|
Vulkan: Enable FRAGMENT_SHADER_FRAMEBUFFER_FETCH_MRT_ARM
ANGLE correctly handles MRT with gl_LastFragColorARM, this property
should have been set to true.
Bug: b/269233744
Change-Id: Iaa554df57292fcc5c12281e2e098b6451f63d5e6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5916770
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
c9606f00
|
2024-10-07T10:15:14
|
|
Fix extensions moved to core in GLES 3.2
The GL_EXT_texture_cube_map_array, GL_EXT_texture_buffer, and
GL_OES_texture_storage_multisample_2d_array extensions were moved
into core in ES3.2, but validation still required enabling
extensions. Added 3.2 as a sufficiency.
Test: angle_end2end_tests --gtest_filter=*CompressedTexImageCubeMapArray*
Bug: b/371940347
Change-Id: Ie73a76087b6b52775d44ae79efd7f48e9fc90eb9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5912120
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Mark Łobodziński <mark@lunarg.com>
|
|
|
30ae44bf
|
2024-10-09T14:17:03
|
|
Tests: Skip going_balls on Windows Intel
Bug: b/372513853
Change-Id: Iec11e1acf3a36f7261cf46adcdfedd826ac88050
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5922076
Commit-Queue: Mark Łobodziński <mark@lunarg.com>
Auto-Submit: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Mark Łobodziński <mark@lunarg.com>
|
|
|
98b5cf46
|
2024-10-08T19:50:18
|
|
Tests: Add Piano Fire trace
Test: angle_trace_tests --gtest_filter="*piano_fire*"
Bug: b/372291936
Change-Id: Ia3ad52781e251c01246fb01fd800112b0d0f82d5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5918738
Reviewed-by: Mark Łobodziński <mark@lunarg.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
2bb5b443
|
2024-10-08T19:39:30
|
|
Tests: Add Billiards City trace
Test: angle_trace_tests --gtest_filter="*billiards_city*
Bug: b/372288799
Change-Id: I2e23d648d8fe27807ccbab26c28ad509349d2a01
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5917649
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Mark Łobodziński <mark@lunarg.com>
|
|
f0a66ba2
|
2024-10-09T00:26:15
|
|
remove angle_gl_driver_all_angle when resetting
Test: presubmit
Bug: b/367348883
Change-Id: Ief115403cd2a908873750c97f416255e61410893
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5918343
Commit-Queue: Solti Ho <solti@google.com>
Auto-Submit: Solti Ho <solti@google.com>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
|
|
|
4984fe12
|
2024-10-08T14:37:15
|
|
Add a test for framebuffer fetch and multisampling
To ensure that the fragment shader is implicitly run per-sample, such
that the read values are per-sample.
Bug: angleproject:42264719
Change-Id: I66968ea2dd92106f222ad6a43ffef0e75ad36528
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5917026
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
d0e2141a
|
2024-09-30T16:55:59
|
|
Tests: GLES1 offscreen replay uses GL_OES_framebuffer_object
ANGLE allows to mix GLES1 with non-GLES1 calls but the native driver
crashes on e.g. glGenRenderbuffers.
Use GL_OES_framebuffer_object so that we can render ANGLE and native the
same way (glGenRenderbuffersOES etc)
There is no glBlitFramebuffer for GLES1 though, so instead of that
render a single frame to the default framebuffer.
Also resize the grid from 1/3 screen to fullscreen for more useful
screenshots, and remove window /= 4 resize to simplify.
Bug: b/370508393
Change-Id: I9c8ac46937aa09f1be186a07548c1ec7e5b15579
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5899376
Commit-Queue: Roman Lavrov <romanl@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
878e1c92
|
2024-10-07T16:34:54
|
|
Vulkan: Fix line-loop draw arrays after elements
Currently, when drawing line-loop arrays in Vulkan, an index
buffer is created to assist in drawing (since Vulkan does not
natively include a line-loop draw mode). However, when LL array
draw calls are mixed with non-LL element draw calls, it can lead
to some rendering issues due to the fact that the proper index
buffer is not obtained.
* In VertexArrayVk::handleLineLoop(), if the cached indices are the
same as the last draw, the same index buffer is obtained from the
LineLoopHelper object.
* (Using the newly added getCurrentIndexBuffer())
* Added unit test in which a triangle element draw is places between
two LL array draws. Before the fix, the second LL draw would result
in an incorrect line draw.
Bug: chromium:40911000
Change-Id: Ibba9a0cb2b77a2b6ae2c1e9230afe3d16b70cb63
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5908694
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
dd66a284
|
2024-10-04T13:10:14
|
|
Perf tests: custom throttling excludes VIRTUAL-SKIN*-MODEL-*
These seems to be using different units and get stuck in throttling.
Also ignore VIRTUAL-SKIN*-CHARGE-* which I think was the intent but
the check ended up in the wrong place.
Bug: b/371573999
Change-Id: I2a9e6fbbb41bebfc5d9d85ee187f4f0918dd5e61
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5905236
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
0b78963d
|
2024-06-18T12:38:38
|
|
Perf tests: add thermalservice custom temp throttling
E.g. --custom-throttling-thermalservice-temp=36
IThermal interface isn't available on all devices. thermalservice is
another way to get similar data, but with its own limitations
(for example, on Pixel we don't see CPU ODPM temps there while we do get
them with IThermal).
Unlike --custom-throttling-temp that we use on Pixel, this flag
does not attempt to disable vendor throttling (not sure there is even a
way to do that outside of Pixel). Vendor throttling can affect perf
results, higher custom temps increase odds of that happening mid-way
during a trial.
Bug: b/347956784
Change-Id: I1166e07e4a5c88417eb379d5cb6a7440b169d073
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5639336
Commit-Queue: Roman Lavrov <romanl@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
aec90a8d
|
2024-10-07T10:56:24
|
|
Fix ignoring blit bits when attachments are missing
GLES requires that the bits provided to glBlitFramebuffer are silently
ignored if either the read or draw framebuffer is missing the
corresponding attachment.
In WebGL, this is forbidden. ANGLE was forbidding this because of
WebGL, but a recent CTS test revealed that we shouldn't be doing that
when !WebGL.
Bug: angleproject:370917919
Change-Id: I202fbf665d8a102f0aea72709b80dfdabeb71a2e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5912614
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
166b72c9
|
2024-09-30T19:07:26
|
|
GL_ANGLE_blob_cache implementation.
Bug: chromium:370538323
Change-Id: Ic51a951e78b48b315e36f518bcc39ff2d54660a6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5900761
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
|
770dc68f
|
2024-10-04T13:05:24
|
|
Tests: Add Thief Puzzle trace
Test: angle_trace_tests --gtest_filter="*thief_puzzle*"
Bug: b/371518149
Change-Id: I593964bdf4a39edf2445a54a400f5faddd4fcaff
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5909872
Reviewed-by: Mark Łobodziński <mark@lunarg.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
37c69bd6
|
2024-10-07T11:00:14
|
|
Tests: gold tests assert that filter matches a test
As described on the bug, test retries result in an unexpected value
passed to --isolated-script-test-filter, which doesn't match any traces.
Assert that there is a match as a (permanent) workaround.
Bug: chromium:371977204
Change-Id: I415507ea999005a9ac04489582cf77b7d3e29e2a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5912615
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Roman Lavrov <romanl@google.com>
|
|
|
cd10ad46
|
2024-09-30T00:00:00
|
|
Metal: Rework allowSamplerCompareGradient feature
* AMD drivers may fail when a sample_compare function is
used with explicit derivatives. To avoid such failures,
the effective level is computed from the texture size,
passed derivatives, and texture coordinates, if needed.
The level value is then used for sample_compare instead
of the explicit derivatives.
* Apple2 GPUs do not support setting texture sampler compare state
via Metal API. As a result, all sample_compare functions including
those without LOD options do not work on Apple2 GPUs. This feature
was attempting to incorrectly emulate a subset of sample_compare
functions with a hard-coded compare state.
There are no plans to support shadow samplers on Apple2 GPUs,
as it would require non-trivial emulation, so this feature is
no longer relevant for that platform.
* Metal on macOS 10.15 only supports constant zero as
the level parameter for sample_compare functions.
Ignoring the passed derivatives and using zero LOD on old OS
versions is a better fallback than dropping the derivatives
altogether because many applications use the derivatives to
set the level to zero anyway.
Bug: angleproject:365066518
Bug: angleproject:368059227
Change-Id: I4028421b785ae49328b72658e0a9783275461779
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5903970
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
|
b3d85cce
|
2024-09-30T14:28:35
|
|
Vulkan: Consolidate write colorspace override states
ColorspaceState struct is now used to cache write colorspace related
states to determine the colorspace of Vulkan draw image views.
ImageViewHelper methods are called during initialization and when
colorspace related states are toggled dynamically which in turn process
these states and determine the final write colorspace.
We can now fully support rendering to EGLImages, with colorspace
overrides, via texture or renderbuffer EGLImage targets
Bug: angleproject:40644776
Tests: ImageTest*Colorspace*Vulkan
MultithreadingTestES3.SharedSrgbTextureMultipleContexts*Vulkan
ReadPixelsPBOTest.SrgbUnorm*Vulkan
Change-Id: I2be2cd3b5b2b4ac8ecb803c34cde2b846cbd1cbe
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5901256
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: mohan maiya <m.maiya@samsung.com>
|
|
|
95379bb4
|
2024-10-07T14:14:16
|
|
Suppress flaky end2end test on Linux NVIDIA Vulkan
SixteenBppTextureTestES3.RGB5A1UploadRGBA8
Bug: angleproject:362486580
Change-Id: I2e2f36cce2e98e92b6b84d816cf09dd778a5e21d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5913434
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
|
|
|
b38cc7fa
|
2024-09-30T12:43:09
|
|
Vulkan: Consolidate read colorspace override states
ColorspaceState struct is now used to cache read colorspace related
states to determine the colorspace of Vulkan read image views.
ImageViewHelper methods are called during initialization and when
colorspace related states are toggled dynamically which in turn process
these states and determine the final read colorspace.
Bug: angleproject:40644776
Tests: ImageTest*Colorspace*Vulkan
SRGBTextureTest.SRGB*TextureParameter*Vulkan
SRGBTextureTestES3.SRGBDecodeTexelFetch*Vulkan
Change-Id: I16b3666cd80865936b826dc0738fc9210dabeda9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5901255
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: mohan maiya <m.maiya@samsung.com>
|
|
|
605c2f85
|
2024-09-27T12:00:58
|
|
Vulkan: Bugfix in FramebufferVk::blit(...)
If any color attachment of GL_DRAW_FRAMEBUFFER is already in use in the
currently started renderpass, don't reuse the renderpass for blit.
Bug: angleproject:40644776
Tests: Texture2DTestES3.UnitTest_DMSAA_dst_read*
Change-Id: Ib4266fc65d0ac7151f362f263e9e706adb1231ce
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5895158
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
f1458429
|
2024-10-04T09:50:38
|
|
Tests: Add Going Balls trace
Test: angle_trace_tests --gtest_filter="*going_balls*"
Bug: b/371526637
Change-Id: I4fad1ef0e7ec450b22f86767398d3283e2c89427
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5908703
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Mark Łobodziński <mark@lunarg.com>
|
|
|
3f132f0c
|
2024-10-03T19:36:20
|
|
Tests: Add Woodoku trace
Test: angle_trace_tests --gtest_filter="*woodoku*"
Bug: b/371501416
Change-Id: I766aac5f0409ab65264955685ac2267c2de457eb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5908693
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Mark Łobodziński <mark@lunarg.com>
|
|
|
c861f0d6
|
2024-10-04T14:18:52
|
|
Skip KHR-GLES3.framebuffer_blit.scissor_blit on S22
Started failing after VK-GL-CTS roll.
https://chromium-review.googlesource.com/c/angle/angle/+/5903935
https://ci.chromium.org/ui/p/angle/builders/ci/android-arm64-exp-s22-test/1316/overview
Bug: b/267953710
Change-Id: I63e09c9c1d73a230cf2c12fc079793390d00b095
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5905074
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
|
|
|
b16d105f
|
2024-10-03T10:25:32
|
|
Remove Desktop GL front-end support
For Desktop GL applications, please use Zink!
Bug: angleproject:370937467
Change-Id: Ie734634bb62a2e98c80e1b32d8b3d34624da3c04
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5905428
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
6024e9c0
|
2024-10-02T08:01:43
|
|
Manual roll VK-GL-CTS from 65470ff2e321 to 179dd9f858f0 (27 revisions)
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/65470ff2e321..179dd9f858f0
2024-09-30 lorenzo@khronosgroup.org Fix build
2024-09-30 mark@igalia.com Support standalone executable builds on
Android
2024-09-30 javed@igalia.com Add tests for draw count clamping with null
index buffer
2024-09-30 piotr.byszewski@mobica.com Capture replay tests for
VK_EXT_descriptor_buffer
2024-09-30 javed@igalia.com Add tests vkCmdDrawIndexedIndirectCount draw
count clamping
2024-09-30 rgarcia@igalia.com Add R8 and R16 large image tests in host
image copy test group
2024-09-30 ziga@lunarg.com Add missing linked shader object test case
2024-09-30 tapani.palli@intel.com Fix issues with GLX reset notification
strategy
2024-09-30 kamil.goras@mobica.com Split
KHR-GLES32.core.tessellation_shader.vertex.vertex_spacing
2024-09-30 jimblackler@google.com Handle resize events in EGL bounding
box tests.
2024-09-30 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.9
into vk-gl-cts/main
2024-09-30 lorenzo@khronosgroup.org Merge remote-tracking branch
'vk-gl-cts/dev/VK_EXT_depth_clamp_control' into main
2024-09-30 lorenzo@khronosgroup.org Update Vulkan spec to 1.3.296
2024-09-30 lorenzo@khronosgroup.org Merge remote-tracking branch
'vk-gl-cts/dev/VK_KHR_compute_shader_derivatives' into main
2024-09-20 lorenzo@khronosgroup.org Update SPIRV-Tools, SPIRV-Headers,
glslang, Vulkan-Docs, Vulkan-ValidationLayers external sources
2024-09-19 piotr.byszewski@mobica.com Check limits before running
mapping_to_large_index DRLR test
2024-09-19 ziga@lunarg.com Test pipeline without render pass or
VkPipelineRenderingCreateInfo
2024-09-19 piotr.byszewski@mobica.com Remove invalid dynamic rendering
local read tests
2024-09-19 piotr.byszewski@mobica.com Fix pipeline binary graphics tests
2024-09-19 piotr.byszewski@mobica.com Fix pNext chain loop in FSR tests
2024-09-19 kamil.goras@mobica.com Split KHR-Single-GL46.arrays_of_arrays
2024-09-19 marcin.hajder@mobica.com Port KC-CTS tests to VK-GL-CTS
(glGetUniform), PART 11
2024-09-19 marcin.hajder@mobica.com Port KC-CTS tests to VK-GL-CTS
(scissor_blit), PART 12
2024-09-19 marcin.zajac@mobica.com Suballocated DRM images
2024-09-19 piotr.byszewski@mobica.com Test feedback loop with dynamic
rendering local read
2024-09-19 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.9
into vk-gl-cts/main
2024-09-18 jimblackler@google.com Fix error in test logging in all
CtsDeqpTestCases
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC angle-team@google.com,syoussefi@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Change-Id: Idbc50f78119327844e1488db25d58c1c588f9ff6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5903935
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
|
|
|
9edd74e2
|
2024-10-02T09:31:31
|
|
Tests: Add Traffic Rider trace
Test: angle_trace_tests --gtest_filter="*traffic_rider*"
Bug: b/370733451
Change-Id: I35703fcbc350fbbcaf3544ba6143d5bbb1966483
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5902662
Reviewed-by: Mark Łobodziński <mark@lunarg.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
f680925b
|
2024-10-01T14:07:03
|
|
Tests: Add Warhammer 40000 Freeblade trace
Test: angle_trace_tests --gtest_filter="*warhammer_40000_freeblade*"
Bug: b/370798324
Change-Id: I77b95721363f3d2cc97a52b2e83ffe5d92e40305
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5902286
Reviewed-by: Mark Łobodziński <mark@lunarg.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
572fd30e
|
2024-09-25T13:33:01
|
|
Clean up LineLoopIndirectTest
The helper test function runTest() for LineLoopIndirectTest
includes some special cases in its args that are not used in all
cases, such as consecutive indirect calls. This CL aims to split
this function into separate test cases to make each test more
readable.
* Added functions for some of the common procedures.
* Split runTest() into each test suite with the help of the common
functions and values as well as the special cases for each.
* Removed runTest() from this test suite.
* Updated an old bug number (667 -> 42265165).
Bug: angleproject:360758685
Change-Id: I98e1facff0a6bad0ee2deca9313644379345d9c5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5892535
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
|
67a5ea45
|
2024-09-23T16:09:12
|
|
Vulkan: Fix the error from multiple lineloop draws
Since Vulkan does not support line-loop draws natively, such a
draw call requires the conversion of the related buffers to prepare
them for this operation. For glDrawElementsIndirect(), the index
and the indirect buffers would need conversion.
However, what currently happens in this case is that the original
buffer pointer is overwritten after the conversion, removing the
link to the original buffer. Therefore, if there is a second line-loop
call just after the first, it will try to use the converted buffer as
the new source, which leads to errors due the buffer already being in
use.
The index buffer for the draw is bound when the related dirty bit is
handled. Therefore, instead of using the draw index buffer directly
for handling the line-loop scenario, we can use the index buffer in
the form of a local pointer passed between functions. Then, in order
to reconcile line-loop with the other cases, the draw index buffer is
set just before setting up the indexed draw.
* Functions handling line-loop draws do not modify the element array
buffer in VertexArrayVk directly, but use local buffer pointers to
pass the current element array pointer to further processing and
drawing.
* Added mCurrentElementArrayBuffer for ContextVk to be bound to the
index buffer to used for draw instead of the one from its vertex
array object.
* Before the indexed draw, mCurrentElementArrayBuffer is set to the
last destination index buffer.
* Added unit test that makes a line-loop draw and then a non-LL call
using the same element array.
Bug: angleproject:360758685
Change-Id: I6d6328f6326c1a1f9f80e5ef346aa077c867d344
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5878764
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
|
03b5ea39
|
2024-09-27T14:03:16
|
|
Traces: --offscreen syncs on N-2 frame GPU completion
This avoids the issue described on the bug where an app's assumption
about double buffering can create a race.
This prevents the replay from getting too far ahead rendering to
offscreen framebuffers.
Also correct mOffscreenFramebuffers to use mTotalFrameCount as the use
of mOffscreenFrameCount appears accidental.
Bug: angleproject:370089935
Change-Id: I30f438eb66201fe77d61710cbe6e90d47e839dd8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5895974
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Roman Lavrov <romanl@google.com>
|
|
|
7c811715
|
2024-09-25T11:09:44
|
|
Vulkan: fix crash when clearing stencil with ClearBuffer
Follow up to [1] which fixed a crash with glClear, but the bug remained
with glClearBufferiv. This change refactors the "is stencil write
masked out" query to always take the framebuffer's stencil bit count
into account (practically always 8), which also happens to make the rest
of the code checking this query more accurate in the presence of
nonsense masks where the bottom 8 bits are 0.
[1]: https://chromium-review.googlesource.com/c/angle/angle/+/3315158
Bug: chromium:40207259
Bug: angleproject:42266334
Change-Id: I68a6b0b75c67ed2cdc8c4d03b243efe5495efce1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5889788
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
|
7b0212b3
|
2024-09-27T10:02:58
|
|
Retrace cod_mobile for minimum requirements
Test: angle_trace_tests --gtest_filter=*cod_mobile
Bug: b/369984808
Change-Id: Ibf3b5c446311d27b0a78867cbd8cc523f76adcbc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5895156
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
0621c95c
|
2024-09-09T09:43:43
|
|
Add test for repeated indirect line loop draws
This test is used to verify that two indirect draws drawing line loop
and sharing the same index buffer works.
Bug: angleproject:360758685
Change-Id: I4386e404ed0e0accf0dbb1edab8671e7f2d9939d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5855003
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
0ec8a7f1
|
2024-09-26T11:06:25
|
|
Prevent multiple solutions when retracing with get_min_reqs
Skip extensions that implicitly enable other extensions in the
retracer script when running to determine minimum requirements.
Test: Retrace cod_mobile with get_min_reqs
Bug: b/42266279
Change-Id: Iee6f629d1b338362809ff8880d8a5d9ed7c574de
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5893959
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Mark Łobodziński <mark@lunarg.com>
|
|
|
05c62ebc
|
2024-09-24T13:41:57
|
|
Fix check for whether stencil write is masked out
The stencil write mask is the only thing that decides what bits get
written to. Previously, this was masked with the reference bitmask to
determine if any bits get written to, which is incorrect.
The effect of this was that the Vulkan backend would use the READ_ONLY
layout for the depth/stencil attachment even though stencil could have
been written to the attachment.
Bug: angleproject:42266334
Change-Id: Ice6a35f4691fc8e09c7d5e1db6439c3079dfa039
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5887905
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
7e249881
|
2024-09-25T17:31:18
|
|
HLSL: Emulate mix functions when the last parameter is a bool.
Add emulation for the ESSL 310 variants of mix that use int and uint
vectors and a bool selector.
Bug: angleproject:369533080
Change-Id: I0491c50c65529b9d922d4745c0989131b9981048
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5892352
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: dan sinclair <dsinclair@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
966739ac
|
2024-09-19T23:49:06
|
|
Drop PLS support for EXT_shader_pixel_local_storage
Supporting this backend drastically increased the complexity of the
codebase, with little return. We don't support memoryless attachments on
the web anyway, and since this extension requires us to literally draw
the load/store operations, input attachments on Vulkan perform better.
Once this implemention is completely removed, we will delete the PLS
allow list, which isn't required for the other PLS implementations.
Bug: angleproject:7279
Change-Id: Ibb036d36cbd33467e7a94398ce171cda7349e4f4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5874412
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Chris Dalton <chris@rive.app>
|
|
a6ee4641
|
2024-09-25T11:41:47
|
|
WGSL: Output default uniform block and accesses to it
Default uniforms are put into a WGSL struct, and all accesses
of those uniforms now output struct accesses.
Similarly to I/O vars and builtins, these are outputted in a
pre-pass, but in the future it might make sense to do what
Vulkan does and do an AST transformation to put the default
uniforms into a UBO which should be outputted similarly.
This does not handle bool, matCx2, or array of element size < 16.
Bug: angleproject:42267100
Change-Id: If29e2895a8aba3212b581813316af87273c1515c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5878759
Reviewed-by: Liza Burakova <liza@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Matthew Denton <mpdenton@chromium.org>
|
|
|
fe6c13d7
|
2024-09-25T13:34:49
|
|
Skip dota_underlords on Linux NVIDIA
Recently became flaky on GTX 1660 driver 535.183.1.0.
Bug: angleproject:369533074
Change-Id: Ieba8657366687f742812643cb25cadfd7ba09817
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5889565
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
f1843343
|
2024-09-25T14:36:04
|
|
Skip flaky end2end test on Metal AMD
PolygonModeTest.DrawLinesWithDepthOffset
flaky on MacBookPro16,1
Bug: angleproject:369540617
Change-Id: I4c67fde9824817b63215496410490e071d61d278
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5890845
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
|
|
|
eaffa034
|
2024-09-24T20:56:04
|
|
Revert "Vulkan: Consolidate colorspace override states"
This reverts commit bffcd235ba6c031603d798daaa98f1cf9a3f3e46.
Reason for revert: Breaks Android test `org.skia.skqp.SkQPRunner#UnitTest_DMSAA_dst_read`. Details:
https://b.corp.google.com/issues/369388539.
Original change's description:
> Vulkan: Consolidate colorspace override states
>
> ColorspaceState struct is now used to cache colorspace related states
> and used to determine the colorspace of Vulkan image views.
> ImageViewHelper methods are called during initialization and when
> colorspace related states are toggled dynamically which in turn process
> these states and determine the final read and write colorspaces.
>
> We can now fully support rendering to EGLImages, with colorspace
> overrides, via texture or renderbuffer EGLImage targets
>
> Bug: angleproject:40644776
> Tests: ImageTest*Colorspace*Vulkan
> MultithreadingTestES3.SharedSrgbTextureMultipleContexts*Vulkan
> SRGBTextureTest.SRGB*TextureParameter*Vulkan
> SRGBTextureTestES3.SRGBDecodeTexelFetch*Vulkan
> ReadPixelsPBOTest.SrgbUnorm*Vulkan
> Change-Id: I1cc2b5bd834b519b83deab4d80a2fcaabeb271d6
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5841290
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Reviewed-by: Charlie Lao <cclao@google.com>
> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Bug: angleproject:40644776
Change-Id: I5bf6cf2ed0c8ec22fc02d8c3da92673ee85fe002
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5888506
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
|
|
|
75297ee9
|
2024-09-24T13:30:55
|
|
Skip dEQP GLES3 crashes on Metal AMD
dEQP-GLES3.functional.shaders.builtin_functions.precision.*
crash on MacBookPro16,1
Bug: angleproject:369219143
Change-Id: I3ec2ea9e0aef7600dcadd0d939934da9d27a227c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5887047
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
|
|
|
ff5dfad5
|
2024-09-20T11:23:07
|
|
restricted_trace_perf: Change loop order
Before this CL we are doing:
For each renderer
For each loopcount
For each trace
Do the test
Write out summary of all results
We don't get useful data unless the entire script completes.
We are seeing some devices disconnect more often, so let's
change the order to preserve data.
The loop becomes:
For each trace
For each iteration
For each renderer
Do the test
Write out summary for the trace
Output becomes:
native_1945_air_force
vulkan_1945_air_force
native_1945_air_force
vulkan_1945_air_force
etc.
The final output is unchanged. Raw data will be in a different order.
Bug: b/369203495
Change-Id: I09b189b5c578dd520123e4ac850018e75b219aa8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5884633
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Roman Lavrov <romanl@google.com>
|
|
|
49ea6f00
|
2024-09-08T11:32:16
|
|
Cleanup ImageTest skip conditions
Early-return with a compiler guard prevents a test from being
recorded in the skip test list log. Make sure to use the
"ANGLE_SKIP_TEST_IF" macros for AHB tests.
Bug: angleproject:40644776
Change-Id: I3e15203b8e17512ecb89abc7e53769c06b770213
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5842744
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: mohan maiya <m.maiya@samsung.com>
|
|
|
bffcd235
|
2024-09-13T14:58:00
|
|
Vulkan: Consolidate colorspace override states
ColorspaceState struct is now used to cache colorspace related states
and used to determine the colorspace of Vulkan image views.
ImageViewHelper methods are called during initialization and when
colorspace related states are toggled dynamically which in turn process
these states and determine the final read and write colorspaces.
We can now fully support rendering to EGLImages, with colorspace
overrides, via texture or renderbuffer EGLImage targets
Bug: angleproject:40644776
Tests: ImageTest*Colorspace*Vulkan
MultithreadingTestES3.SharedSrgbTextureMultipleContexts*Vulkan
SRGBTextureTest.SRGB*TextureParameter*Vulkan
SRGBTextureTestES3.SRGBDecodeTexelFetch*Vulkan
ReadPixelsPBOTest.SrgbUnorm*Vulkan
Change-Id: I1cc2b5bd834b519b83deab4d80a2fcaabeb271d6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5841290
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: mohan maiya <m.maiya@samsung.com>
|
|
|
86a24b84
|
2024-09-20T09:36:02
|
|
Add TraceFrameIndex atrace counter
This adds TraceFrameIndex atrace counter so that we can identify the
exact frame index in the trace.
Bug: b/319871513
Change-Id: I6cd20dd78746dd03b43ecea2ac7b102902e82d37
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5874417
Commit-Queue: Roman Lavrov <romanl@google.com>
Reviewed-by: Roman Lavrov <romanl@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
|
2ca686d2
|
2024-09-20T13:48:04
|
|
Suppress flaky test on Linux NVIDIA Vulkan
dEQP-GLES2.functional.texture.completeness.cube.npot_mirrored_repeat
Bug: angleproject:362486580
Change-Id: If1255fd052e8d0e80ef694733af3676414c5beee
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5873134
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
|
|
|
f0f65290
|
2024-09-10T15:30:30
|
|
Translator: Add check for atomic counter offset
For GLSL shaders, atomic counter offset should not exceed the
maximum atomic counter buffer size. This issue was seen on a dEQP
test when increasing the LimitToInt() limitation from INT_MAX/2
to INT_MAX+1 or INT_MAX.
* Added check to the translator to make sure the offset does not
go beyond the max atomic counter buffer size.
* Packed the existing checks into a single function.
* (checkAtomicCounterOffsetIsValid())
* Added mMaxAtomicCounterBufferSize to TParseContext for the check.
* Also added the related cap (maxShaderStorageBlockSize) for D3D11.
* Increased the limitation in LimitToInt() to (INT_MAX / 2 + 1).
* Added test based on dEQP test that failed on some platforms as
a result of updating said limitation.
* From KHR-GLES31.core.shader_atomic_counters.negative-large-offset
Bug: angleproject:361369308
Change-Id: Id6128c75e12445b2a0029f4a2eb2bdb379cad48d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5851650
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
04c2879e
|
2024-09-18T11:30:07
|
|
Modify retracer script to output min requirements json diff
After the ANGLE retracer script runs with the get_min_reqs option,
ouptut the json file diff.
Bug: b/42266279
Change-Id: Ia744e4e36fb9f8b7e8d498d44412af733c7ed9b1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5874161
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
260953c3
|
2024-09-19T14:30:12
|
|
Suppress flaky test on Linux NVIDIA Vulkan
KHR-GLES31.core.pixelstoragemodes.teximage3d.rgb10a2.16_16_1
Bug: angleproject:365974429
Change-Id: Ic2fe52a7a3adcb3dbdf9e2e585831dfab4d04699
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5875723
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
e38d25b1
|
2024-06-21T18:22:32
|
|
Vulkan: Implement EXT_clear_texture
* Added new functions to TextureVk to clear the image.
* clearImage()
* clearSubImage()
* Both implemented via clearSubImageImpl(), with the former a
special case of the latter.
* For multisample or renderable images, stagePartialClear() from
ImageHelper is called to add the update.
* For single-sampled non-renderable images, a buffer is filled with
the pixel data and applied to the image as a buffer update.
* Added new update type: ClearPartial
* Used for renderable textures. This includes multisample textures.
* LOAD_OP_CLEAR is used in a render pass to perform the clear.
* UtilsVk::clearTexture()
* (Uses ClearTextureParameters)
* Uses the following functions to get the VkClearValue from the
input data and format:
* GetVkClearColorValueFromBytes()
* GetVkClearDepthStencilValueFromBytes()
* ClearPartial updates can also be superseded and removed similar to
Buffer updates.
* Updated UtilsVk::startRenderPass() to accept a VkClearValue* as an
input arg. If used, the render pass will use LOAD_OP_CLEAR.
* Enabled the feature "clearTextureEXT" on Vulkan.
* Added new unit tests in ClearTextureEXTTest for various formats and
pixel sizes.
* Added related multisample tests in FramebufferTest.cpp.
* FramebufferTest_ES31.ClearTextureEXT*
* Disabled some of the new tests failing using OpenGL.
* Disabled stencil-only-related tests on Pineapple.
Bug: angleproject:42266869
Change-Id: I89c631d68a4ed63d9991abe1783333255ade20dd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5778348
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
3f89dfc2
|
2024-08-20T17:31:43
|
|
Update validation for EXT_clear_texture
* Added the validation condition that the texture level to be cleared
should have been defined beforehand.
* Added the condition to clearTexSubImage() at the frontend to return
if any clear extent was zero.
* In the validation tests, added checks for the following:
* Clearing a texture level before defining it.
* Clearing a compressed texture, which is not allowed.
* Added setConfigAlphaBits() to ClearTextureEXTTest setup.
* Replaced EXPECT_PIXEL_COLOR_EQ with EXPECT_PIXEL_RECT_EQ for
ClearTextureEXTTest tests for better coverage.
Bug: angleproject:42266869
Change-Id: Ieeb49e9005eba6ef9156d49ff46c71cdf4f04162
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5801655
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
a98f83bc
|
2024-09-13T10:49:08
|
|
Add pre-upload Required Extensions check to trace sync script
Add a check to make sure that a new ANGLE trace has been run through
the retracer with the 'get_min_reqs` argument before uploading to CIPD.
Bug: b/42266279
Change-Id: Id6f847faf22a42062ab189ea9bc7fb9c3506e66b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5860299
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
7e462c22
|
2024-09-17T15:32:41
|
|
WGPU: Implement SetUniform() enough so GetUniform() works
Lays out a shadow buffer for basic uniforms per-shadertype
in std140, which is close to matching WGPU's layout. This
does not actually pass the buffer to WGPU as a uniform
buffer. GetUniform() just reads from the shadow buffer.
This is copied from the VK backend and so some code is
deduplicated.
Bug: angleproject:42267100
Change-Id: I727dc9e09a7ccabbb617f148dd68590469883b07
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5867444
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Matthew Denton <mpdenton@chromium.org>
Reviewed-by: Liza Burakova <liza@chromium.org>
|