|
bd173f0e
|
2022-03-14T09:59:47
|
|
Capture/Replay: limit per shader image uniforms when capturing
The Caps::maxImageUnits are limited, but that's only the value that is
checked when compiling shaders, we have also limit the values that are
returned when using the GL interface.
In addition print out the error log when compiling a shader fails in the
Pipeline tests.
Bug: angleproject:7094
Change-Id: I19f69afe2cece4841a395543c1e35785bc6bd698
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3516078
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
|
|
e3c44919
|
2022-03-24T11:32:10
|
|
Debug: Add angle_enable_trace_events
Include the following GN arg to print all GLES and EGL commands:
angle_enable_trace_events = true
Bug: angleproject:7126
Change-Id: I78eb061c10ed519d6a0b0357eea11567d1cfb518
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3551656
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
32af258d
|
2022-03-22T16:44:14
|
|
Fix handling of incomplete CubeMapArray textures
GFXBench Car Chase binds a cube map array as a default texture,
then immediately samples from it without setting it up. This
ends up treating the cube map array as incomplete.
On the Vulkan backend, this is resulting in multiple validation
errors, followed by a crash in the driver. There are a number of
errors, but a telling one is this:
vkCreateImage(): pCreateInfo->flags contains
VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT, but pCreateInfo->arrayLayers (=1)
is not greater than or equal to 6. The Vulkan spec states: If
imageType is VK_IMAGE_TYPE_2D and flags contains
VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT, extent.width and extent.height
must be equal and arrayLayers must be greater than or equal to 6
This corresponds to language in the GLES 3.2 spec:
8.18. IMMUTABLE-FORMAT TEXTURE IMAGES
TexStorage3D Errors
An INVALID_OPERATION error is generated if any of the following
conditions hold:
* target is TEXTURE_CUBE_MAP_ARRAY and depth is not a multiple of 6
Since ANGLE treats incomplete textures as immutable, we need to update
the dimensions of the backing image for CUBE_MAP_ARRAY.
Also add a new test that exposes the problem.
Test: IncompleteTextureTestES31.IncompleteTextureCubeMapArray
Bug: b/218314686
Change-Id: Ibef41e15a7cfccb05e6039bfb8504d237bc42cd4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3546290
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
041c4c6d
|
2022-03-25T16:30:03
|
|
Vulkan: Track color attachment usage like D/S in render pass
That is in preparation for optimizing mid-render-pass clears, which
requires an answer to the following query: "has this color image been
read from / written to so far in the render pass?"
With this change, a future CL will also be able to optimize color
attachment invalidates, which currently break the render pass
unconditionally, the same way depth/stencil is optimized.
Bug: angleproject:5048
Change-Id: I3d3ee40d8444e6861c06340d5d52b17f5ee895b4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3542989
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Lingfeng Yang <lfy@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
b2c6e08e
|
2022-03-24T11:38:04
|
|
Reland Remove unnecessary suppressions for Pixel6 dEQP
This is a reland of 0455f356eda37e98cbfaff6b4be3241a0743bdcd
Original change's description:
> Remove unnecessary suppressions for Pixel6 dEQP tests
>
> Bug: b/224537784
> Change-Id: If7befe0279a06cddb79c67fdd34a62b4cb51c6e0
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3551658
> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
> Commit-Queue: Ian Elliott <ianelliott@google.com>
The previous CL was based on the pre-release Android T Pixel 6
drivers. The Chromium bots are running released Android S Pixel 6
drivers. This CL updates the expectations with the observed status,
and still removes some expectations that are now unnecessary.
Bug: b/224537784
Change-Id: I4f4041e015824fd1d8211d6d7d0adedbccaa3ddb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3552544
Reviewed-by: Roman Lavrov <romanl@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>
|
|
|
3f331fae
|
2022-03-22T15:23:38
|
|
Vulkan: Dirty bits for depth/stencil access and feedback loop
In preparation for doing the same for color, the depth/stencil render
pass access and feedback loop modes are now updated with ContextVk dirty
bits.
This change also fixes clear after read-only depth/stencil feedback
loop. The render pass wasn't broken in that case.
Bug: angleproject:5048
Change-Id: I40f9b49593f9e6f35f42408e41c9d6267edb375e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3542988
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
04680183
|
2022-03-24T11:09:39
|
|
Capture/Replay: Fixes for Car Chase
This CL contains two fixes:
* Add GL_PATCHES to list of PrimitiveMode names
* Use FramebufferTextureLayer for 3D and Cube textures
Bug: angleproject:3662
Bug: angleproject:7125
Bug: b/218314686
Change-Id: Ia97d8221cb78ef6e895156b5a474483d570d6ab5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3551096
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
361874bb
|
2022-03-24T15:38:56
|
|
D3D: generalize more stuff (mImages, mReadonlyImages).
Bug: angleproject:7121
Change-Id: I39e7df1e9aed84c225c8877a3d16ca3c44f70990
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3550543
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Stephen White <senorblanco@chromium.org>
|
|
|
cfee4070
|
2022-03-24T15:21:22
|
|
D3D: generalize Image2D, ReadonlyImage2D and AtomicCounter.
Mapify them so they can handle all shader types.
Bug: angleproject:7121
Change-Id: Ia80d46200bf30509e1484f1e198e1edfe6344207
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3550542
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Stephen White <senorblanco@chromium.org>
|
|
|
c399c693
|
2022-03-24T14:10:57
|
|
D3D: more generalization: cached Image2DBindLayouts.
Bug: angleproject:7121
Change-Id: I5cead9f7e70cfb9ebea807b886ba849948a2ec47
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3550541
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Stephen White <senorblanco@chromium.org>
|
|
0c23c72b
|
2022-03-25T17:19:37
|
|
Suppress -Wunused-but-set-variable in Bison-generated code
Recent Clang versions have enhanced the warning, causing it to fire in
preprocessor_tab_autogen.cpp and glslang_tab_autogen.cpp. Since those
are generated by Bison, we can't fix the code and instead should
suppress the warning there.
Bug: chromium:1309955
Change-Id: I31aa83571162310bef47a7ce84841446713a2d04
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3550200
Commit-Queue: Hans Wennborg <hans@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
f2e7a235
|
2022-03-25T10:00:11
|
|
D3D: generalize the Image2DBindLayoutCache to be per-shader.
Bug: angleproject:7121
Change-Id: I3b5243583ac11a0fc96c4b9271118a8fd7ee4f66
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3550540
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Stephen White <senorblanco@chromium.org>
|
|
|
4e939ac6
|
2022-03-25T09:58:52
|
|
D3D: generalize mImage2DUniforms.
Mapify this variable so it can accommodate other shader types.
Bug: angleproject:7121
Change-Id: If6893a5fceaf50db87c42176c58319ce17d23d54
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3550539
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Stephen White <senorblanco@chromium.org>
|
|
|
3e0fba60
|
2022-03-24T11:09:24
|
|
D3D: generalize DynamicHLSL calls to take a shaderType.
This allows all shader types to use these Image2D calls.
Bug: angleproject:7121
Change-Id: I95f9e8a2fd206bcc3ff2ef7e06875d093d73dcd6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3550538
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Stephen White <senorblanco@chromium.org>
|
|
5d17caef
|
2022-03-21T18:48:25
|
|
Migrate capture_replay sample to trace_fixture
Bug: angleproject:5911
Change-Id: I6987e42f39a796e5888242a0d0f0dc05c99c703d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3537535
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Roman Lavrov <romanl@google.com>
|
|
|
1d71f55f
|
2022-03-24T19:27:21
|
|
Remove unnecessary SKIPs for Pixel4* dEQP tests
Bug: b/224537784
Change-Id: I81c6f18d72ea893341ad2aa8ca819893e7d53d26
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3551659
Reviewed-by: Roman Lavrov <romanl@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>
|
|
0e6ba7d2
|
2022-03-25T10:01:09
|
|
Roll vulkan-deps from 3ef0c7c00c08 to 9fd63df2bc48 (6 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/3ef0c7c00c08..9fd63df2bc48
Changed dependencies:
* glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/397086a5b0..f1d286fcc2
* vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/0d76dd23b7..ea503f36e6
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/755d34faa1..26f222cf8b
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: ynovikov@google.com
Change-Id: I1c0b7c9f66c66c74923d85c0934f9969bccfd4b1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3552736
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
45543295
|
2022-03-25T04:36:49
|
|
Revert "Remove unnecessary suppressions for Pixel6 dEQP tests"
This reverts commit 0455f356eda37e98cbfaff6b4be3241a0743bdcd.
Reason for revert: Multiple tests that pass on my Pixel 6 fail on the bot Pixel 6's
Original change's description:
> Remove unnecessary suppressions for Pixel6 dEQP tests
>
> Bug: b/224537784
> Change-Id: If7befe0279a06cddb79c67fdd34a62b4cb51c6e0
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3551658
> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
> Commit-Queue: Ian Elliott <ianelliott@google.com>
Bug: b/224537784
Change-Id: Id3430a7632651b9b7b5e980f41678aebbdfc426c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3552124
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>
Auto-Submit: Ian Elliott <ianelliott@google.com>
|
|
|
c8f86c21
|
2022-03-22T17:40:43
|
|
A handful of clear-related tests
Credit Tim Van Patten <timvp@google.com>
Bug: angleproject:5048
Bug: angleproject:5194
Change-Id: I00eccf1049118c3fba3c2c560c781cf09cf23362
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3543732
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
cdd97fb8
|
2022-03-24T17:41:30
|
|
Reland "Vulkan: Fix invalid access with display texture share group."
This is a reland of 1099b5ef2279cfe1988a39c8e011aada59c650f1.
Original change's description:
> Vulkan: Fix invalid access with display texture share group.
> Create bufferpool that owns by RendererVk.
> If we are using EGL_ANGLE_display_texture_share_group
> extension, use the bufferpool owned RendererVk,
> otherwise, use the bufferpool owned by EGL::ShareGroup.
> The bufferpool lifetime will remain consistent with
> texture lifetime.
> Bug: chromium:1299211
> Change-Id: Ie4e87cea1dfd20dabab24e2afed6ddd92e469888
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3531155
> Reviewed-by: Charlie Lao <cclao@google.com>
> Reviewed-by: Geoff Lang <geofflang@chromium.org>
> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Bug: chromium:1299211
Change-Id: I4b8f5bcb30297f2c5f24e02404fd96011f9d843b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3550038
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
0455f356
|
2022-03-24T11:38:04
|
|
Remove unnecessary suppressions for Pixel6 dEQP tests
Bug: b/224537784
Change-Id: If7befe0279a06cddb79c67fdd34a62b4cb51c6e0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3551658
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>
|
|
|
dd4b2c21
|
2022-03-24T21:02:11
|
|
Roll vulkan-deps from c4109411d3f3 to 3ef0c7c00c08 (28 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/c4109411d3f3..3ef0c7c00c08
Changed dependencies:
* glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/c6f8e532dd..397086a5b0
* spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/565db34cba..0d4ce028bf
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/0ab57c2c42..48c8363f0a
* vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/32c07c0c53..b6554a7ff3
* vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/2f89241d4d..0d76dd23b7
* vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/74f007dcd7..3758a53671
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/e297733453..755d34faa1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: ynovikov@google.com
Change-Id: I171f1f8cc751040cffd47a80e8d086a9e767928e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3550043
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
cbbf5b5d
|
2022-03-23T18:17:17
|
|
GL: Only log all GL driver errors on debug builds
Anything that invokes localtime_r() from the GPU process can be a
slow operation on Linux. ANGLE's ClearErrors() function sometimes
spams many errors, sometimes repeating every frame. These errors
aren't necessary to print in release builds, and only logging these
in debug builds will mitigate a lot of GPU process hangs.
Bug: chromium:1077735
Change-Id: Ic1186732d477dee12caae0cb400e1d3504a0bd8b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3546718
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
|
|
18c36f8a
|
2022-03-19T19:22:08
|
|
Metal: Fix transform feedback with base instance
Added TransformFeedbackTest.BaseInstance test case.
Bug: angleproject:6963
Change-Id: Ie7b2a5dd2be456172505f07ea60ca291075bf07e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3536660
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kyle Piddington <kpiddington@apple.com>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
|
fa5c349d
|
2022-03-23T17:27:54
|
|
Add "use_custom_libcxx = false" to "roll_aosp.sh"
Per https://chromium-review.googlesource.com/c/chromium/src/+/3520025
the old gn arg "libcxx_abi_unstable" was removed, and we need to set
"use_custom_libcxx = false" instead.
This will hopefully fix the ANGLE->AOSP autoroller that was broken by
the above CL.
Bug: angleproject:7110
Change-Id: I3b6de998964efb674ea356a14e852f0e285b7242
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3546721
Reviewed-by: Ian Elliott <ianelliott@google.com>
Auto-Submit: Ian Elliott <ianelliott@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
73ec28af
|
2022-03-23T21:13:45
|
|
Revert "Vulkan: Fix invalid access with display texture share group."
This reverts commit 1099b5ef2279cfe1988a39c8e011aada59c650f1.
Reason for revert: suspect culprit of 1309304
Original change's description:
> Vulkan: Fix invalid access with display texture share group.
>
> Create bufferpool that owns by RendererVk.
> If we are using EGL_ANGLE_display_texture_share_group
> extension, use the bufferpool owned RendererVk,
> otherwise, use the bufferpool owned by EGL::ShareGroup.
> The bufferpool lifetime will remain consistent with
> texture lifetime.
>
> Bug: chromium:1299211
> Change-Id: Ie4e87cea1dfd20dabab24e2afed6ddd92e469888
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3531155
> Reviewed-by: Charlie Lao <cclao@google.com>
> Reviewed-by: Geoff Lang <geofflang@chromium.org>
> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Bug: chromium:1299211, 1309304
Change-Id: Ibdc119ef6bb52352858114d72a0f1c0edcd4da5e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3546288
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Shrek Shao <shrekshao@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
09f55382
|
2022-03-23T10:01:53
|
|
Roll SwiftShader from 57eca9df5dc5 to ea9806003d9e (4 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/57eca9df5dc5..ea9806003d9e
2022-03-22 sugoi@google.com VK_EXT_private_data support
2022-03-22 sugoi@google.com VK_EXT_private_data promoted structures
2022-03-22 capn@google.com Stop skipping VK_STRUCTURE_TYPE_IMAGE_VIEW_MIN_LOD_CREATE_INFO_EXT
2022-03-22 ari.suonpaa@siru.fi Restore support for non-uniform indexing of InterpolateAt* input
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: ynovikov@google.com
Change-Id: Ia1220a06b24923afd30cafdd8af54f696625454f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3545367
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
b19e662a
|
2022-03-22T18:28:40
|
|
TransformFeedbackQueryPausedDrawThenResume flaky
Suppression removed in crrev.com/c/3536652, but still flaky:
https://ci.chromium.org/ui/p/angle/builders/ci/win-trace/1091/overview
Bug: angleproject:6180
Change-Id: I447a173d9634c950debc3d4a16e9987ed360d522
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3542991
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
706824d8
|
2022-03-22T16:13:17
|
|
Remove "libcxx_abi_unstable" from "roll_aosp.sh"
This was removed as a gn arg by: crrev/c/3520025. That broke the
ANGLE->AOSP autoroller.
Bug: angleproject:7110
Change-Id: I3d8b4483b75fb168e91078ff5ee0a53298d98efb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3542990
Commit-Queue: Ian Elliott <ianelliott@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
1099b5ef
|
2022-03-17T17:20:44
|
|
Vulkan: Fix invalid access with display texture share group.
Create bufferpool that owns by RendererVk.
If we are using EGL_ANGLE_display_texture_share_group
extension, use the bufferpool owned RendererVk,
otherwise, use the bufferpool owned by EGL::ShareGroup.
The bufferpool lifetime will remain consistent with
texture lifetime.
Bug: chromium:1299211
Change-Id: Ie4e87cea1dfd20dabab24e2afed6ddd92e469888
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3531155
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
|
cc9cdbd7
|
2022-03-22T13:42:39
|
|
Roll chromium_revision 3e4963702e..384f873e09 (982601:983904)
Change log: https://chromium.googlesource.com/chromium/src/+log/3e4963702e..384f873e09
Full diff: https://chromium.googlesource.com/chromium/src/+/3e4963702e..384f873e09
Bug: None
Change-Id: Ieccd745500b56ec835ee4470a19ccd697e915bd7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3543725
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
6bd11e28
|
2022-03-22T12:38:13
|
|
Add back Pixel 6-specific dEQP FAIL suppression
Bug: b/224537784
Change-Id: Iddbd1cbd1aef6349dc1a4298febe74907bd126a8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3543727
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
20e7bbb7
|
2022-03-18T17:03:18
|
|
Vulkan: Fix invalidate of attachments with emulated format
Some image formats may be emulated such that the emulated format has
more channels than the original. ANGLE clears the image once so that
these extra channels contain valid values, and carefully ensures they
are never modified.
For swapchain images with such formats, as they are automatically
invalidated at the end of the frame, a workaroud was added to make sure
they are re-cleared in the beginning of the next frame. This however
doesn't fix the issue of glInvalidateFramebuffer resulting in the
contents of attachments with such formats to be discarded (even if the
following render pass clears it, the contents are invalid in between).
This change instead makes sure invalidate of images with emulated
formats that have extra channels are handled appropriately:
- On IMR hardware, the invalidate is dropped altogether as it provides
little to no benefit.
- On TBR hardware, a clear is automatically staged on the invalidated
image.
The latter replaces the workaround that was added to make the following
render pass use loadOp=CLEAR, by adding a clear that's respected
regardless of what the future usage is.
This change also paves the way for a future change where the invalidate
of color attachments is tracked in render passes similarly to how
depth/stencil currently is. With this change, the image is no longer in
an inconsistent state where its contents are considered invalid, even
though some channels are meant to remain valid.
Bug: angleproject:6860
Change-Id: Iec5b4854dfbe3a0bf93cd5aa82c19fe116065744
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3536389
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
e7f29440
|
2022-03-16T14:31:39
|
|
Remove dEQP FAIL expectations for passing tests
Based on bot runs, a number of previously FAIL'ing dEQP tests are now
passing. Need to separately test Pixel 6 and SKIP expectations.
Bug: b/203826952
Change-Id: I8a2bdb44b9050d1b93e85082c5dd1e15420e6f3e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3531073
Reviewed-by: Roman Lavrov <romanl@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>
|
|
|
3210beb8
|
2022-03-22T10:01:09
|
|
Roll vulkan-deps from 61b4f5b95321 to c4109411d3f3 (7 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/61b4f5b95321..c4109411d3f3
Changed dependencies:
* glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/538231d8b4..c6f8e532dd
* vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/ab207b0829..2f89241d4d
* vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/99500cee1e..74f007dcd7
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/af4bf61013..e297733453
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: ynovikov@google.com
Change-Id: I0b8076319edb8880af687f687c1cce47ab390be0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3539054
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
e1f37adc
|
2022-03-22T10:01:53
|
|
Roll SwiftShader from 2f3af2452783 to 57eca9df5dc5 (1 revision)
https://swiftshader.googlesource.com/SwiftShader.git/+log/2f3af2452783..57eca9df5dc5
2022-03-21 swiftshader.regress@gmail.com Regres: Update test lists @ 2f3af245
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: ynovikov@google.com
Change-Id: Ie7ca70b9ec62ee0cd75130b209a2251611fe3c0f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3540776
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
ebf4c58f
|
2022-03-20T19:48:06
|
|
Capture/Replay: Enable test that no longer times out
Bug: angleproject:6220
Change-Id: I170462fa384f06ead39bdfce64d324426ad47878
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3538364
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
|
|
|
df06c945
|
2022-03-18T15:25:13
|
|
Capture/Replay: Skip binary IO test without binary formats
Bug: angleproject:6631
Change-Id: I7093a5d71ada7b1982e7294a6a7e7b482f5037a5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3536653
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
|
|
|
b9a83e14
|
2022-03-18T17:05:44
|
|
Capture/Replay: Recheck Flaky tests and update expectations
Bug: angleproject:6180
Bug: angleproject:6286
Bug: angleproject:6373
Bug: angleproject:6511
Bug: angleproject:6538
Bug: angleproject:6543
Change-Id: I39c44f2552e3bbd7f47bf94c08f42b4ab342f7d7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3536652
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
|
|
730c1271
|
2022-01-07T13:41:08
|
|
Vulkan: Submit queue more often for texture data
Outside command buffers should be flushed more often in order
to prevent the texture data accumulation just before the first
render pass when they are referenced.
* Added a tracker next to copyBufferToImage() for texture size
(in ContextVk). When its value passes kMaxBufferToImageCopySize,
the outside command buffer operations should be submitted and
the tracker would be reset. Currently, the threshold value is
set to 1 << 28 = 256M.
* Added a variation of submitFrame() to be used in outside
command buffer submission. The main difference is that it
copies mResourceUseList into GetShareGroupVk() rather than
move it.
* Refactored the two functions into submitFrameImpl().
* Added a helper function to submit the outside command
buffer.
* Added explicit copy functions for ResourceUseList and
SharedResourceUse. The counter in the copied object is
incremented by 1.
* Added a test to make sure submitting the outside command
buffer does not break the render pass.
Bug: angleproject:6354
Change-Id: Ia1d4f857fcbd06934609c94622ccbf675b3b1c72
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3379231
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
093d4287
|
2022-03-21T12:57:10
|
|
Roll vulkan-deps from 51988dcdccbf to 61b4f5b95321 (21 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/51988dcdccbf..61b4f5b95321
Changed dependencies:
* vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/384881cc90..32c07c0c53
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/6c8f1627a3..af4bf61013
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: angleproject:7105
Change-Id: Id26d7dfdd9745f549ea08f584e4dd9dc88b7bc90
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3539789
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
0ffa221c
|
2022-03-21T16:42:32
|
|
Update commit_id.py to use python3.
This is blocking ANGLE rolls into WebKit. macOS no longer ships a
"python" binary, only "python3".
Bug: angleproject:7115
Change-Id: Ieb9473f393d006d64c18167bada2fe76ce996bb4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3537512
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
01be7a83
|
2022-03-21T21:20:54
|
|
Fix Skia build
Missing include in crrev.com/c/3191194
Bug: angleproject:6440
Change-Id: I77c08a60fb42026104b75044187f681a30c0d42a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3537513
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
15fe0474
|
2022-03-21T00:06:38
|
|
Translator: Work around tool paranoia w.r.t repeated std::move
An unknown diagnostic tool has flagged a usage in PruneNoOps, where an
empty vector is std::move'd on multiple iterations of a loop, as
error-prone. That was intended behavior. To silence the tool however,
the empty vector declaration is moved inside the loop.
Bug: chromium:1304953
Change-Id: Ie4b0c78e3f4a845db2b3b3a18d4ca095f0ba746b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3539443
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
f6910a9a
|
2022-03-20T22:43:57
|
|
Vulkan: Update pipeline creation doc
Bug: angleproject:4889
Change-Id: Idb97d0484a716300feb9ed9a3fd882fbec870dbf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3539440
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: mohan maiya <m.maiya@samsung.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
40afbe4b
|
2022-03-20T23:39:57
|
|
Translator: Fix SimplifyLoopConditions producing dead code
This causes the tree to fail validation. Dead code could be generated
if the loop body ended in a branch. In such a case, no additional
instructions are added to the transformed loop body after the original
body.
Bug: chromium:1300782
Change-Id: I4ec46c170ab5a45fa9b9b73d4e2b62c9c4fa24a3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3539442
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
cb990e40
|
2022-03-21T10:01:53
|
|
Roll SwiftShader from 341ad7e57a3c to 2f3af2452783 (2 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/341ad7e57a3c..2f3af2452783
2022-03-18 capn@google.com Use slower and less precise non-fused multiply-add for Chromium
2022-03-18 swiftshader.regress@gmail.com Regres: Update test lists @ 341ad7e5
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: ynovikov@google.com
Change-Id: If6c00fc591c629ae61ab61df23981d878383f154
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3539685
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
e56f185b
|
2022-03-19T10:41:50
|
|
Metal: clarify instance count assertions
Bug: angleproject:6963
Change-Id: I5a686d560efb7912b3426560c8be2806a943158c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3536659
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
b2c01ac4
|
2021-09-28T12:57:45
|
|
Report process memory in perf tests.
Bug: angleproject:6440
Change-Id: Ifdd4389266e3ac55963a3069d437c631bf73f72a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3191194
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
9637185c
|
2022-03-10T15:38:13
|
|
Add ForceGPUSwitch to EGL_ANGLE_power_preference
eglHandleGPUSwitch() does not work with WebKit sandbox profile.
The root cause is that we do not know the
primary display, and as such we do not know which GPU drives this.
Add eglForceGPUSwitchANGLE(display, gpuIDHigh, gpuIDLow).
This lets the caller figure out the GPU in another process. Then
the caller can just set the GPU in the sandboxed process.
Add tests that are disabled by default until the runner and the
infrastructure supports running the tests with automatic switching
enabled.
Bug: angleproject:7092
Change-Id: I316ee431156596effbdb89659a5e24291719a204
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3516274
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
|
|
|
7c616871
|
2022-02-01T15:12:53
|
|
Metal: Implement ANGLE_base_vertex_base_instance
Includes command buffer and MSL translator updates.
The DrawElementsInstancedBaseVertexBaseInstance tests from
DrawBaseVertexVariantsTest suite fail for dynamic draw and
stream draw buffer usages.
Bug: angleproject:6963
Change-Id: I6caa144860356d5fc85948b72458bec282ea3a3b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3429819
Reviewed-by: Kyle Piddington <kpiddington@apple.com>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
|
|
|
f96d2d35
|
2022-03-18T10:54:07
|
|
Test RGB invalidate with user FBOs
When an RGB image is invalidated and then used as attachment, the
cleared alpha value was previously lost due to loadOp=DONT_CARE. This
was fixed by making the following render pass use loadOp=CLEAR instead.
The test for this relied on RGB backbuffers, which is not easily
testable on many platforms. This change adds a similar test using user
FBOs.
Bug: b/180139027
Bug: angleproject:6860
Change-Id: I11f408d6cd925b45bc9bcec455563cd23a226fec
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3536387
Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
e74d0e81
|
2022-02-11T18:05:12
|
|
Vulkan: Implement EGL_KHR_partial_update
This change provides a trivial implementation of partial
update that does nothing, making apps that want this
extension happy. A possible efficient Vulkan implementation
would use the damage set to narrow down render area, but it
appears to only be useful for only some TBDR hardware.
Bug: angleproject:6960
Reviewed-by: Antonio Caggiano <antonio.caggiano@collabora.com>
Change-Id: Ic553ac9590c336093f1bf25a6521574622599bf6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3427640
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Auto-Submit: Constantine Shablya <constantine.shablya@collabora.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
b74d6768
|
2022-03-17T16:48:21
|
|
Vulkan: Refactor D/S usage tracking in render pass
This is in preparation for doing the same for color images. That is in
turn in preparation for optimizing mid-render-pass clears, which require
an answer to the following query: "has this color image been read from /
written to so far in the render pass?"
Bug: angleproject:5048
Change-Id: I8abe97919897b8fbf644482071bf7326ca3325d6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3533143
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
a55526a5
|
2022-03-17T11:11:37
|
|
Vulkan: Ignore VUID-vkCmdDraw-None-06538.
Suspected as being incompatible API usage in ANGLE.
Bug: angleproject:7105
Change-Id: I8c806b1ae090c5bedd762c1539a228c31a553858
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3533140
Auto-Submit: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
22f177eb
|
2022-03-17T16:58:37
|
|
Vulkan: Expose advanced blend for non-coherent devices as well
Reliance on coherent behavior was accidental.
Bug: angleproject:3586
Change-Id: I86d055cf640368b57256910764c44596b23ccdd8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3535299
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
65902973
|
2022-03-18T10:01:53
|
|
Roll SwiftShader from d01dca1d18d0 to 341ad7e57a3c (2 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/d01dca1d18d0..341ad7e57a3c
2022-03-17 natsu@google.com Handle VK_FORMAT_G10X6_B10X6R10X6_2PLANE_420_UNORM_3PACK16 sampling
2022-03-17 capn@google.com Optimize fragment input interpolation using FMA
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: jmadill@google.com
Change-Id: I58331331793287c2be6fc1dc529520d85d351fbd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3534695
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
3a529ce2
|
2022-03-18T07:00:31
|
|
Roll Chromium from 45902868a797 to 3e4963702e02 (1593 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/45902868a797..3e4963702e02
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/18a1f1939e..8f75e7de55
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/113dd1badb..d8c375426d
* buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/a897d0f3f8..93b8dcd57b
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/8399c3e77d..55f1dc2d27
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/3f6f1caf8d..a4297493d8
* third_party/android_build_tools/aapt2: yQIf5Ev_-q9u6Pr_a0APd1dHcImJSmotVADw4Pj151QC..wicn5Ce1ay6ivbZ1GNFF0gRSS3NYv_7hJTPtVga3O-QC
* third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/05fa71af3a..be0731f39e
* third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/5320e6281a..5f109f3c41
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..389f33bb40
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3481645827..76979dae56
* third_party/turbine: VhmfIPuSDHHeilnA7WC0MhR9ShZNF25tA0Te4RYIZG8C..Go9J3Mz5ankZAgxmn5GxeXKdEDV73zaZp2ojNfGC1RQC
* third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/b0676a1f52..923f5eb4bf
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/85f3c90818..a15c2dfa35
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/f0753eb065..e6f159df60
* tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/feb42b9a96..8a340b64dc
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/80fc9315e0..46fa9b4765
* tools/skia_goldctl/linux: wjKDZ5vJELJ_j3O037nIWhBEMF0cY4Y1g4tLc47hPJoC..iqtz2prn9CUv6A8KCcxJzadmPEDLY1FPP-b2YqIFQ1cC
* tools/skia_goldctl/mac_amd64: jw5QK1qcTGSBr-yjH0d-9F_MNeq6e5_5aWLq_oGWy0QC..Y4l14LBqCsT9EhffPIOtso9VSpwqQE9WccjZdDBZmLoC
* tools/skia_goldctl/mac_arm64: o4BSMT1hKtY4T4VBfANeSm-NuhxoxPYUp3lF0EpoUvMC..INEqc8JI_mtww_X0ShOlDkF3S8OG4tjF4Nkei0K7ci8C
* tools/skia_goldctl/win: Vg04A_bOadtB2ljbA9DGKe69_Uc6pmX5mk_ABoO2R3EC..EbVQXa1u0hbZ8pxb0Il6Rbc1ErHpIN_-kMVOzBXMQyoC
No update to Clang.
Bug: None
Tbr: jmadill@google.com
Change-Id: I3c10efcadf6995ec9da02c97666cfc3a155b701e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3534747
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
8a2a4fa7
|
2022-03-15T06:59:00
|
|
Add loongarch support
Bug: angleproject:7104
Change-Id: I9b9c57b76463f16d0c3c7ccc8b81c1bb657a3cc8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3522459
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
1e6643d5
|
2022-03-17T17:55:06
|
|
Roll VK-GL-CTS from 8252a3d3cdd3 to 823d49cf5f5e (5 revisions)
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/8252a3d3cdd3..823d49cf5f5e
2022-03-17 mika.vainola@siru.fi Fix GCC 11 misleading indentation warning
2022-03-17 jari.komppa@siru.fi Add dynamic state to instancing tests
2022-03-17 antto.makinen@siru.fi Test SRGB formats with UNIFORM_TEXEL_BUFFERs
2022-03-17 ari.suonpaa@siru.fi Rewrite portability check for Amber tests
2022-03-17 ilkka.saarelainen@siru.fi Improve coverage of MSAA copies
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC angle-bots+autoroll-info@google.com,jmadill@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: angle-bots+autoroll-info@google.com,jmadill@google.com
Change-Id: Ib3136bc6f96332a776f3ee2a3682744aabf6a3cd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3533448
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
44e84661
|
2022-03-17T15:02:21
|
|
Revert "Emulate RGB10 (no alpha) on desktop OpenGL."
This reverts commit 6404be2defd3ded3ff2f0437bb87fe515e10f2a7.
Reason for revert: Extension was not fully enabled due to test bug.
Original change's description:
> Emulate RGB10 (no alpha) on desktop OpenGL.
>
> The OpenGL ES extension GL_EXT_texture_type_2_10_10_10_REV
> requires RGB and RGBA formats to be supported but Desktop OpenGL
> does not support RGB. Emulate it with the existing
> emulatedAlphaChannel path in TextureGL.
>
> Bug: chromium:1300575
> Change-Id: I0e6d1044afbc55cf6d4f987cc98b357ff11ff006
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3517346
> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Bug: chromium:1300575
Change-Id: Ib3810a18888544f1700a1f648a5094c19973d86d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3533139
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
|
|
|
479f1988
|
2022-03-17T11:50:46
|
|
Simplify ValidCompressedBaseLevel
Bug: angleproject:7099
Change-Id: I9592aebde56808556f72b2b94a39f94d077f9db2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3529527
Reviewed-by: Brandon Schade <b.schade@samsung.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
|
b465a736
|
2021-12-21T12:52:40
|
|
Metal: Remove redundant CommandQueue::mMetalCmdBuffersTmp
Instead of a member variable, instantiate the temporary
at the use site.
Bug: angleproject:6842
Change-Id: I64848bc937ce2945e6ac55adea8a6dffcaf9b00d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3347649
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: John Cunningham <johncunningham@apple.com>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
|
|
|
e8ee847d
|
2022-02-23T12:25:39
|
|
Vulkan: Add UpdateDescriptorSetsBuilder.
This helper class encapsulates the vkUpdateDescriptorSets caching.
As part of the refactor, we switch passing a ContextVk to passing
a vk::Context with some mutable variables. This helps encapsulate
ContextVk. Since we use the perf counters in many places, this CL
moves the perf counters to vk::Context, so we can access them
everywhere.
Refactoring change only.
Bug: angleproject:6776
Change-Id: Id529962b2f425bece6f9b3bd0cd1698c692e58cb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3484980
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
7b7cf69e
|
2022-03-17T10:01:54
|
|
Roll SwiftShader from c27e99245d42 to d01dca1d18d0 (11 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/c27e99245d42..d01dca1d18d0
2022-03-17 swiftshader.regress@gmail.com Regres: Update test lists @ b3b1a3fe
2022-03-16 capn@google.com Use slow legacy log2() implementation for Chromium
2022-03-16 capn@google.com Add exp/log optimization documentation
2022-03-16 capn@google.com Improve the precision of highp log2()
2022-03-16 capn@google.com Improve the precision and performance of highp exp2()
2022-03-16 capn@google.com Fix handling infinity for relaxed precision log2()
2022-03-16 srisser@google.com Add variable to control regres daily branch
2022-03-16 joshuaduong@google.com Fix integer overflow in vkAllocateMemory.
2022-03-16 capn@google.com Implement a relaxed precision log2()
2022-03-16 capn@google.com Implement a relaxed precision exp2()
2022-03-15 swiftshader.regress@gmail.com Regres: Update test lists @ c27e9924
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: jmadill@google.com
Change-Id: I18059c70242f237a343729584a0d69f3786da7a8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3531933
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
98bb4f32
|
2022-02-23T16:51:32
|
|
Vulkan: Implement advanced blend through extension
This change exposes GL_KHR_blend_equation_advanced if
VK_EXT_blend_operation_advanced is supported. No emulation is yet
implemented.
Bug: angleproject:3586
Change-Id: Ie7a442c22e028e3aa45ccef52db320e205664d49
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3487951
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
3ddb21fd
|
2022-02-23T14:15:48
|
|
Front-end support for KHR_blend_equation_advanced
Bug: angleproject:3586
Change-Id: I27086295e7455ce8848db1c6004917fea40202e8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3484785
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
459bdc2f
|
2022-03-16T12:04:38
|
|
Reintroduce validation check only for D3D
To avoid undefined behavior, D3D requires the
base mip level to have multiple-of-4 dimensions.
Add this validation check back in.
Bug: angleproject:7099
Change-Id: Id51f6cd4c745455062b864c0d291b9857e985e35
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3530499
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com>
Commit-Queue: Brandon Schade <b.schade@samsung.com>
|
|
04460fe8
|
2022-03-15T19:04:39
|
|
end2end tests: add regression test for GL_LINE_LOOP drawing
This was fixed by 349636a05a3577a127adb6c79a1e947890bbe462. Adding
a regression test which I didn't have ready at the time.
Bug: angleproject:7102
Change-Id: Icbb685c1ffad6725a278e5ed65f881f86c5688ef
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3527604
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
d867ddbb
|
2022-03-16T09:25:03
|
|
Doc: Update supported EGL minor version
ANGLE implements the EGL 1.5 specification, update the
README to reflect that.
Bug: angleproject:1944
Change-Id: Id61d21ebab05f81bbfcd2ea6ce6c137c8a564279
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3530487
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: mohan maiya <m.maiya@samsung.com>
|
|
|
1dc9f126
|
2022-03-16T19:29:26
|
|
Revert "Flush the texture staged updates when destroying context share group"
This reverts commit 5c29d795d1625f71ac6999f157b6f3bba79d5256.
Reason for revert: this is causing some test failures on chromium and blocking the angle-chromium auto roller job: https://chromium-review.googlesource.com/c/chromium/src/+/3529771/
Original change's description:
> Flush the texture staged updates when destroying context share group
>
> If we are using the extension EGL_ANGLE_display_texture_share_group,
> flush the texture staged updates upon destroying the context. With the
> extension enabled, the texture could still be alive when both context
> and its' EGL::ShareGroup are destroyed. If we have staged updates not
> yet flushed, the updates will keep the ShareGroupVk bufferpool occupied,
> causing an error upon ShareGroupVk::onDestroy().
>
> Bug: chromium:1299211
> Change-Id: I260de93c3a3099e023e31acbe017803e824459ad
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3495879
> Reviewed-by: Charlie Lao <cclao@google.com>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Bug: chromium:1299211
Change-Id: I214161d6a8aec834e1efc5fc9d2479e62e3bfae0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3530505
Auto-Submit: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
ed590dc8
|
2022-03-11T12:54:44
|
|
FrameCapture: Add override for Glsizei* types.
Fix capturing glGetSynciv with null lengths on Linux.
When calling the default WriteParamValueReplay handler with a
nullptr, ostream on Linux will write `(nil)`.
This fixes retracing all traces containing glGetSynciv calls with null
lengths.
Add a NullLength test to FenceSyncTests that used to fail in the
capture_replay_tests.
Test: capture_replay_tests.py --gtest_filter=FenceSyncTest.NullLength/*
Bug: angleproject:7071
Bug: angleproject:6808
Change-Id: I0a2bd4db744ce2a026cd932ba0f2f4747672fcc8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3526653
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
|
|
8fb0a633
|
2022-03-15T18:11:27
|
|
Vulkan: VkFormat/DrmFourCC
Define macro and header dependency in BUILD.gn when Vulkan is enabled.
Bug: angleproject:7065
Change-Id: Ifbd9091425212689d4284b2bc46d3fe59267509c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3526654
Auto-Submit: Antonio Caggiano <antonio.caggiano@collabora.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
f8a2229e
|
2022-03-16T10:58:07
|
|
angle_system_info_test also exports androidSdkLevel
Value being non-zero would unambiguously indicate that target is
Android, not sure if the actual value is really needed but it's probably
good to have.
Bug: angleproject:6854
Change-Id: I685e8e0ffbb666349801203e9d09b082135af17e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3529966
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Roman Lavrov <romanl@google.com>
|
|
|
08e007dd
|
2022-03-15T18:23:54
|
|
angle_system_info_test passes json via file
--render-test-output-dir is supported by Android test runner so the file
is first written on the device then copied over to the host.
Bug: angleproject:6854
Change-Id: Ia56fd9c36ab68a495459efa3b1014e871a615565
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3526855
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Roman Lavrov <romanl@google.com>
|
|
|
e498d885
|
2022-03-16T10:01:52
|
|
Roll vulkan-deps from a11411926c31 to 51988dcdccbf (9 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/a11411926c31..51988dcdccbf
Changed dependencies:
* spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/0e994ee9c4..4995a2f272
* vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/2c45218b90..384881cc90
* vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/a0c7be0505..ab207b0829
* vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/795bad232d..99500cee1e
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/ca222d286f..6c8f1627a3
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: jmadill@google.com
Change-Id: Ie1322074d40a6eb1e0f5914ea5eb5b5d5e096728
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3528360
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
63b54d9d
|
2022-03-09T17:04:13
|
|
Do not copy parent layer frame position
The position value in a frame refers to its relative position to
its parent. We do not want to copy that to its new child layer.
Test: when using ANGLE (with metal or swiftshader backend) with
emulator frame, it should render the emulator at the right
position.
Bug: angleproject:7097
Change-Id: I94f78e1253d7ee016bf7ab512d908f75250ce9c7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3523622
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Auto-Submit: Yahan Zhou <yahan@google.com>
Reviewed-by: Yahan Zhou <yahan@google.com>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
|
|
349636a0
|
2022-03-15T09:39:36
|
|
Vulkan: Update mCurrentElementArrayBuffersync based on dirty bit
The previous fix crrev.com/c/3513553 has run into corner case that
requires more follow up change crrev.com/c/3522565. But with that, there
is report that now we are hitting assertion in
handleDirtyGraphicsIndexBuffer(). This becomes a bit fragile This new
fix relies on the DIRTY_BIT_INDEX_BUFFER dirty bit and should be more
reliable as long as the dirty bit is set properly (if not, then we have
other bug that it won't even send down vulkan command to bind the
correct element buffer). We could further optimize the code path and
create a fast path for most common usages in the future.
Bug: chromium:1299261
Change-Id: Ifa8f86d431798c9ca4c128ed71a3e9e0a3537ccb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3526021
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
|
5c29d795
|
2022-02-28T23:56:46
|
|
Flush the texture staged updates when destroying context share group
If we are using the extension EGL_ANGLE_display_texture_share_group,
flush the texture staged updates upon destroying the context. With the
extension enabled, the texture could still be alive when both context
and its' EGL::ShareGroup are destroyed. If we have staged updates not
yet flushed, the updates will keep the ShareGroupVk bufferpool occupied,
causing an error upon ShareGroupVk::onDestroy().
Bug: chromium:1299211
Change-Id: I260de93c3a3099e023e31acbe017803e824459ad
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3495879
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
|
|
|
6baf1675
|
2022-03-04T11:04:46
|
|
Remove invalid validation check on compressed texture formats
Remove the ValidCompressedDimension() check for non-WebGL
contexts of compressed formats. This is because compressed
texture images can have dimensions that are neither multiples
of four nor small values like one or two.
Test: gtest_filter=*DXT1CompressedTextureTest.NonBlockSizesMipLevels*
Bug: angleproject:7099
Change-Id: Ic86c15dd3187ffab0665f6db21434fffcbe04fef
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3526017
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Brandon Schade <b.schade@samsung.com>
|
|
|
d4ddd0c1
|
2022-03-10T16:31:00
|
|
Vulkan: Handle the case where the bound buffer is empty
If vertex attribute is enabled and buffer is bound, but buffer size is
0, we should not crash. This CL skips mapImpl and data copy all together
if size is 0 to avoid crash when calling mapImpl while buffer is
invalid.
This CL also added a test for this.
Bug: chromium:1296467
Change-Id: I79af348f133e1d3b4427f044e370652d0875dc91
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3516700
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
|
70af5ff0
|
2022-02-18T14:35:59
|
|
FrameCapture: Skip invalid VertexAttribPointer calls in MEC.
In CaptureVertexArrayState when a non-default VAO is bound and no
GL_ARRAY_BUFFER is bound, VertexAttribPointer calls with a non-null
offset are invalid and will produce:
"Client data cannot be used with a non-default vertex array object."
Add a test that leaves a vertex array with an invalid vertex
attribute pointer and used to produce an invalid trace with MEC.
Test: angle_end2end_tests --gtest_filter="VertexAttributeTestES3.InvalidAttribPointer/*"
Bug: angleproject:7042
Bug: angleproject:7098
Change-Id: Iaf91fe7f191c44df79db47bb5455e5df922f2ed5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3475353
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
|
|
|
0c272c67
|
2022-03-15T15:42:39
|
|
Vulkan: VkFormat/DrmFourCC
Add functions to perform a lossy conversion from VkFormat to DrmFourCC
and to convert a VkFormat to one or more DrmFourCC formats. Compilation
only happens when Vulkan is actually enabled.
Bug: angleproject:7065
Change-Id: I97c4585b9032e1ff4f773c3c427541bf7f6117fe
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3525754
Auto-Submit: Antonio Caggiano <antonio.caggiano@collabora.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
2397b5fe
|
2022-03-15T10:17:36
|
|
Vulkan: Temporarily suppress 3 perf counter tests on P6.
Bug: angleproject:7096
Change-Id: I63ce1773282ac79ee9c0656b32715182d2e89d92
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3525814
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
0f2482ff
|
2022-03-15T14:09:11
|
|
Revert "Vulkan: VkFormat/DrmFourCC"
This reverts commit daef95775f7b6dc3bdb0a40662fcb36b68ebf501.
Reason for revert: Breaking roll into Skia due to missing Vk headers.
Original change's description:
> Vulkan: VkFormat/DrmFourCC
>
> Add functions to perform a lossy conversion from VkFormat to DrmFourCC
> and to convert a VkFormat to one or more DrmFourCC formats.
>
> Bug: angleproject:7065
> Change-Id: Iecccea6a89fbf8adeb50c3cb0c737ad3aedf7c62
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3495123
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Auto-Submit: Antonio Caggiano <antonio.caggiano@collabora.com>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Bug: angleproject:7065
Change-Id: I7cbad4277929717c211f70435cd6e462f11e4bda
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3525813
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
d1415517
|
2022-03-15T06:45:23
|
|
Skip no-op base instance draw calls
Bug: angleproject:3402
Change-Id: I90f17307efb98934b1faf44f2efbdbcfa4db9e0c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3524342
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
|
b9b64b15
|
2022-03-15T06:31:32
|
|
Fix typo in DrawElementsInstancedBaseVertexBaseInstanceANGLE
Bug: angleproject:3402
Change-Id: I490695e45b4bec31ea9226c6a7df4d426759c53f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3524341
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
|
dffc9077
|
2022-03-15T08:02:57
|
|
Roll Chromium from ffa866a5ae9e to 45902868a797 (562 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/ffa866a5ae9e..45902868a797
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/f3187f1c4e..18a1f1939e
* buildtools/linux64: git_revision:f27bae882b2178ccc3c24f314c88db9a34118992..git_revision:bd99dbf98cbdefe18a4128189665c5761263bcfb
* buildtools/mac: git_revision:f27bae882b2178ccc3c24f314c88db9a34118992..git_revision:bd99dbf98cbdefe18a4128189665c5761263bcfb
* buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/289d52ce75..a897d0f3f8
* buildtools/win: git_revision:f27bae882b2178ccc3c24f314c88db9a34118992..git_revision:bd99dbf98cbdefe18a4128189665c5761263bcfb
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/d5f4353463..8399c3e77d
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..0c2e8d34dd
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c848a4ed33..3481645827
* third_party/r8: ZI5RPjew7GhVFtcZytIe_Sv91Pljm5KmhVan6HWxj8YC..ovozeRSDDfERnEFpDo_WS6OYOcEF7oT1JzGxCSf-g0kC
* third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/e466446bbc..b0676a1f52
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/407b0016e6..f0753eb065
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/611add37b5..80fc9315e0
No update to Clang.
Bug: None
Tbr: jmadill@google.com
Change-Id: Ie6604b2671f70e61b756ba02430dcd26fefcb27b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3524275
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
1760ce37
|
2022-03-03T17:29:12
|
|
Add usage of Spirv through glslang build flag
Add new build flag angle_use_spirv_gen_through_glslang.
If set, angle_enable_spirv_gen_through_glslang is enabled
and the generateSPIRVThroughGlslang feature is also enabled.
Bug: angleproject:6210
Change-Id: I8f4f71c2d01314a36b15fae795caa01a1ffa7fbc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3502529
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Brandon Schade <b.schade@samsung.com>
|
|
|
d914e7fb
|
2022-03-09T16:28:06
|
|
Add device id as a part of the key in EGLDisplay cache
Otherwise eglGetPlatformDisplay would return displays created
with other devices.
Bug: angleproject:7087
Change-Id: I6ad3fa03f02892afe43de7e7691fbba17a89d616
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3513753
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
|
|
|
daef9577
|
2022-01-05T19:55:50
|
|
Vulkan: VkFormat/DrmFourCC
Add functions to perform a lossy conversion from VkFormat to DrmFourCC
and to convert a VkFormat to one or more DrmFourCC formats.
Bug: angleproject:7065
Change-Id: Iecccea6a89fbf8adeb50c3cb0c737ad3aedf7c62
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3495123
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Auto-Submit: Antonio Caggiano <antonio.caggiano@collabora.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
776c7804
|
2022-03-14T20:33:54
|
|
Roll vulkan-deps from 2d9abfbddc1b to a11411926c31 (18 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/2d9abfbddc1b..a11411926c31
Changed dependencies:
* spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/0b51794f01..565db34cba
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/0741f42738..0ab57c2c42
* vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/42d5db3f59..a0c7be0505
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/09227446c8..ca222d286f
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: angleproject:7095
Tbr: jmadill@google.com
Change-Id: If23f91ac75a1c686c880e9d32a8a5c794772cd1f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3523741
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
708ce9cf
|
2022-03-14T10:37:31
|
|
Fix crash when pausing XFB then deleting a buffer.
Fix is to validate XFB buffer bindings even if we're paused.
This is undefined behaviour so we can use any non-crashing solution.
Bug: chromium:1305190
Change-Id: Ib95404cdb13adbde7f34d6cc77473a8b3cbf1de7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3522283
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
e9d9d933
|
2022-03-14T09:33:28
|
|
Vulkan: Fix another corner case of mCurrentElementArrayBuffer
mCurrentElementArrayBuffer is vertex array state. But it gets modified
with different draw call parameters. When this changes, we always
re-calculate mCurrentElementArrayBuffer. And we have added
updateCurrentElementArrayBuffer call at various places where we need to
reset mCurrentElementArrayBuffer to back to what bound to vertex array.
There is still one more places missing such call, that when a different
vertex array is been bound, the new vertex array may still have
mCurrentElementArrayBuffer set to the special array for LineLoop. We
need to reset it upon it gets bound.
This CL also adds a new test case DrawElementsTest.LineLoopTriangles
from Steven Noonan.
Bug: angleproject:6955
Change-Id: Ida95062b071d25be26e59f886bfe3d61e6886c5c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3522565
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
|
c32a6b21
|
2022-03-14T19:17:30
|
|
Roll VK-GL-CTS from f7e842466e0a to 8252a3d3cdd3 (8 revisions)
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/f7e842466e0a..8252a3d3cdd3
2022-03-14 quic_mnetsch@quicinc.com Merge vk-gl-cts/opengl-cts-4.6.2 into vk-gl-cts/main
2022-03-14 quic_mnetsch@quicinc.com Merge vk-gl-cts/opengl-es-cts-3.2.8 into vk-gl-cts/main
2022-03-10 rgarcia@igalia.com Avoid logging to stdout in buffer mem requirements tests
2022-03-10 jbolz@nvidia.com Fix fragment_shader_interlock vs fragment_shading_rate tests
2022-03-10 gleese@broadcom.com Use standard type definitions on all platforms
2022-03-10 gleese@broadcom.com Use common code for robustness2 tests
2022-03-10 jbolz@nvidia.com Add tests to verify compressed texture downloads to non-zero mip levels
2022-03-10 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/main
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC angle-bots+autoroll-info@google.com,jmadill@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: angle-bots+autoroll-info@google.com,jmadill@google.com
Change-Id: Iedc0b649b9a3a0693c70ffbd1da49578e806a16a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3522578
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
3739a195
|
2022-03-09T13:56:36
|
|
perf tests: Record perf counter metrics.
This adds a new command line argument that will allow the user to
specify perf counters to record into the test output.
Bug: angleproject:4918
Change-Id: Ia7432ff96eadf13ef681f67d2d503d00fd83e06e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3516970
Reviewed-by: Lingfeng Yang <lfy@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
24ad581e
|
2022-03-14T07:01:02
|
|
Roll Chromium from 06a76a17743b to ffa866a5ae9e (297 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/06a76a17743b..ffa866a5ae9e
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC yuxinhu@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/1eba6a6415..f3187f1c4e
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/aa2dfc5ea7..d5f4353463
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..b326cacd0e
* third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/85bdd6400c..e466446bbc
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/e20b3c33b1..407b0016e6
No update to Clang.
Bug: None
Tbr: yuxinhu@google.com
Change-Id: I01e3d7bf046f9cb9f87a5a3b5cc0a1727076b213
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3521401
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
7eb7596a
|
2022-03-10T14:32:58
|
|
Ensure non float uniform are actively used
In mesa, the non float uniforms are optimized out when they are
not active. This change ensures the unforms are active.
Reference: https://gitlab.freedesktop.org/mesa/mesa/-/issues/6119
Bug: angleproject:7091
Change-Id: Iedff4a4b72a7204348c226778cfe940374632a4a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3515640
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jiajia Qin <jiajia.qin@intel.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
5fe1d628
|
2022-03-11T10:01:13
|
|
Roll SwiftShader from e3d910c94d33 to c27e99245d42 (2 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/e3d910c94d33..c27e99245d42
2022-03-10 swiftshader.regress@gmail.com Regres: Update test lists @ e3d910c9
2022-03-10 capn@google.com Regres: Include UNSUPPORTED() failures in CI test runs
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC yuxinhu@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: yuxinhu@google.com
Change-Id: I20670de10c2bc099b9b9bb469bc78e7d08fb659d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3518756
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
0beb36fb
|
2022-03-11T07:52:57
|
|
Roll Chromium from ceeef8f99b7d to 06a76a17743b (500 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/ceeef8f99b7d..06a76a17743b
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC yuxinhu@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/e3d8d28103..1eba6a6415
* buildtools/linux64: git_revision:46f94b5a7f5527b5d7ef57271d3e9447a65e22ac..git_revision:f27bae882b2178ccc3c24f314c88db9a34118992
* buildtools/mac: git_revision:46f94b5a7f5527b5d7ef57271d3e9447a65e22ac..git_revision:f27bae882b2178ccc3c24f314c88db9a34118992
* buildtools/win: git_revision:46f94b5a7f5527b5d7ef57271d3e9447a65e22ac..git_revision:f27bae882b2178ccc3c24f314c88db9a34118992
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/4c82f9f99a..aa2dfc5ea7
* third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/e6c2b86f92..29766b5d64
* third_party/android_build_tools/bundletool: 2ZcLVDxyRwp8FzpeYLtLT0TfSRweZxvwh1-Kx1jZ_FoC..LoldiQDpZ0uTdAm5EPgZ8hBJ3La2KlTWLuaRxE7eDigC
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..271796d312
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/37db69d46c..c848a4ed33
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/548c2354fe..85f3c90818
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/998473d904..e20b3c33b1
* tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/da435db089..feb42b9a96
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/5d09be20c0..611add37b5
Clang version changed llvmorg-15-init-3540-g85c53c70:llvmorg-15-init-3677-g8133778d
Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/548c2354fed8dba0dbcd5ae6e4ff13b2008b175c..85f3c90818f07e06110dea490d4f7c020027b508/scripts/update.py
Bug: None
Tbr: yuxinhu@google.com
Change-Id: Iae8db71a4f8128ef0808e8ccf101be7149c06fba
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3517894
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|