|
bd173f0e
|
2022-03-14T09:59:47
|
|
Capture/Replay: limit per shader image uniforms when capturing
The Caps::maxImageUnits are limited, but that's only the value that is
checked when compiling shaders, we have also limit the values that are
returned when using the GL interface.
In addition print out the error log when compiling a shader fails in the
Pipeline tests.
Bug: angleproject:7094
Change-Id: I19f69afe2cece4841a395543c1e35785bc6bd698
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3516078
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
|
|
32af258d
|
2022-03-22T16:44:14
|
|
Fix handling of incomplete CubeMapArray textures
GFXBench Car Chase binds a cube map array as a default texture,
then immediately samples from it without setting it up. This
ends up treating the cube map array as incomplete.
On the Vulkan backend, this is resulting in multiple validation
errors, followed by a crash in the driver. There are a number of
errors, but a telling one is this:
vkCreateImage(): pCreateInfo->flags contains
VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT, but pCreateInfo->arrayLayers (=1)
is not greater than or equal to 6. The Vulkan spec states: If
imageType is VK_IMAGE_TYPE_2D and flags contains
VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT, extent.width and extent.height
must be equal and arrayLayers must be greater than or equal to 6
This corresponds to language in the GLES 3.2 spec:
8.18. IMMUTABLE-FORMAT TEXTURE IMAGES
TexStorage3D Errors
An INVALID_OPERATION error is generated if any of the following
conditions hold:
* target is TEXTURE_CUBE_MAP_ARRAY and depth is not a multiple of 6
Since ANGLE treats incomplete textures as immutable, we need to update
the dimensions of the backing image for CUBE_MAP_ARRAY.
Also add a new test that exposes the problem.
Test: IncompleteTextureTestES31.IncompleteTextureCubeMapArray
Bug: b/218314686
Change-Id: Ibef41e15a7cfccb05e6039bfb8504d237bc42cd4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3546290
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
041c4c6d
|
2022-03-25T16:30:03
|
|
Vulkan: Track color attachment usage like D/S in render pass
That is in preparation for optimizing mid-render-pass clears, which
requires an answer to the following query: "has this color image been
read from / written to so far in the render pass?"
With this change, a future CL will also be able to optimize color
attachment invalidates, which currently break the render pass
unconditionally, the same way depth/stencil is optimized.
Bug: angleproject:5048
Change-Id: I3d3ee40d8444e6861c06340d5d52b17f5ee895b4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3542989
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Lingfeng Yang <lfy@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
b2c6e08e
|
2022-03-24T11:38:04
|
|
Reland Remove unnecessary suppressions for Pixel6 dEQP
This is a reland of 0455f356eda37e98cbfaff6b4be3241a0743bdcd
Original change's description:
> Remove unnecessary suppressions for Pixel6 dEQP tests
>
> Bug: b/224537784
> Change-Id: If7befe0279a06cddb79c67fdd34a62b4cb51c6e0
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3551658
> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
> Commit-Queue: Ian Elliott <ianelliott@google.com>
The previous CL was based on the pre-release Android T Pixel 6
drivers. The Chromium bots are running released Android S Pixel 6
drivers. This CL updates the expectations with the observed status,
and still removes some expectations that are now unnecessary.
Bug: b/224537784
Change-Id: I4f4041e015824fd1d8211d6d7d0adedbccaa3ddb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3552544
Reviewed-by: Roman Lavrov <romanl@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>
|
|
|
3f331fae
|
2022-03-22T15:23:38
|
|
Vulkan: Dirty bits for depth/stencil access and feedback loop
In preparation for doing the same for color, the depth/stencil render
pass access and feedback loop modes are now updated with ContextVk dirty
bits.
This change also fixes clear after read-only depth/stencil feedback
loop. The render pass wasn't broken in that case.
Bug: angleproject:5048
Change-Id: I40f9b49593f9e6f35f42408e41c9d6267edb375e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3542988
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
1d71f55f
|
2022-03-24T19:27:21
|
|
Remove unnecessary SKIPs for Pixel4* dEQP tests
Bug: b/224537784
Change-Id: I81c6f18d72ea893341ad2aa8ca819893e7d53d26
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3551659
Reviewed-by: Roman Lavrov <romanl@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>
|
|
|
45543295
|
2022-03-25T04:36:49
|
|
Revert "Remove unnecessary suppressions for Pixel6 dEQP tests"
This reverts commit 0455f356eda37e98cbfaff6b4be3241a0743bdcd.
Reason for revert: Multiple tests that pass on my Pixel 6 fail on the bot Pixel 6's
Original change's description:
> Remove unnecessary suppressions for Pixel6 dEQP tests
>
> Bug: b/224537784
> Change-Id: If7befe0279a06cddb79c67fdd34a62b4cb51c6e0
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3551658
> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
> Commit-Queue: Ian Elliott <ianelliott@google.com>
Bug: b/224537784
Change-Id: Id3430a7632651b9b7b5e980f41678aebbdfc426c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3552124
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>
Auto-Submit: Ian Elliott <ianelliott@google.com>
|
|
|
c8f86c21
|
2022-03-22T17:40:43
|
|
A handful of clear-related tests
Credit Tim Van Patten <timvp@google.com>
Bug: angleproject:5048
Bug: angleproject:5194
Change-Id: I00eccf1049118c3fba3c2c560c781cf09cf23362
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3543732
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
cdd97fb8
|
2022-03-24T17:41:30
|
|
Reland "Vulkan: Fix invalid access with display texture share group."
This is a reland of 1099b5ef2279cfe1988a39c8e011aada59c650f1.
Original change's description:
> Vulkan: Fix invalid access with display texture share group.
> Create bufferpool that owns by RendererVk.
> If we are using EGL_ANGLE_display_texture_share_group
> extension, use the bufferpool owned RendererVk,
> otherwise, use the bufferpool owned by EGL::ShareGroup.
> The bufferpool lifetime will remain consistent with
> texture lifetime.
> Bug: chromium:1299211
> Change-Id: Ie4e87cea1dfd20dabab24e2afed6ddd92e469888
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3531155
> Reviewed-by: Charlie Lao <cclao@google.com>
> Reviewed-by: Geoff Lang <geofflang@chromium.org>
> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Bug: chromium:1299211
Change-Id: I4b8f5bcb30297f2c5f24e02404fd96011f9d843b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3550038
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
0455f356
|
2022-03-24T11:38:04
|
|
Remove unnecessary suppressions for Pixel6 dEQP tests
Bug: b/224537784
Change-Id: If7befe0279a06cddb79c67fdd34a62b4cb51c6e0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3551658
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>
|
|
18c36f8a
|
2022-03-19T19:22:08
|
|
Metal: Fix transform feedback with base instance
Added TransformFeedbackTest.BaseInstance test case.
Bug: angleproject:6963
Change-Id: Ie7b2a5dd2be456172505f07ea60ca291075bf07e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3536660
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kyle Piddington <kpiddington@apple.com>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
73ec28af
|
2022-03-23T21:13:45
|
|
Revert "Vulkan: Fix invalid access with display texture share group."
This reverts commit 1099b5ef2279cfe1988a39c8e011aada59c650f1.
Reason for revert: suspect culprit of 1309304
Original change's description:
> Vulkan: Fix invalid access with display texture share group.
>
> Create bufferpool that owns by RendererVk.
> If we are using EGL_ANGLE_display_texture_share_group
> extension, use the bufferpool owned RendererVk,
> otherwise, use the bufferpool owned by EGL::ShareGroup.
> The bufferpool lifetime will remain consistent with
> texture lifetime.
>
> Bug: chromium:1299211
> Change-Id: Ie4e87cea1dfd20dabab24e2afed6ddd92e469888
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3531155
> Reviewed-by: Charlie Lao <cclao@google.com>
> Reviewed-by: Geoff Lang <geofflang@chromium.org>
> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Bug: chromium:1299211, 1309304
Change-Id: Ibdc119ef6bb52352858114d72a0f1c0edcd4da5e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3546288
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Shrek Shao <shrekshao@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
b19e662a
|
2022-03-22T18:28:40
|
|
TransformFeedbackQueryPausedDrawThenResume flaky
Suppression removed in crrev.com/c/3536652, but still flaky:
https://ci.chromium.org/ui/p/angle/builders/ci/win-trace/1091/overview
Bug: angleproject:6180
Change-Id: I447a173d9634c950debc3d4a16e9987ed360d522
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3542991
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
1099b5ef
|
2022-03-17T17:20:44
|
|
Vulkan: Fix invalid access with display texture share group.
Create bufferpool that owns by RendererVk.
If we are using EGL_ANGLE_display_texture_share_group
extension, use the bufferpool owned RendererVk,
otherwise, use the bufferpool owned by EGL::ShareGroup.
The bufferpool lifetime will remain consistent with
texture lifetime.
Bug: chromium:1299211
Change-Id: Ie4e87cea1dfd20dabab24e2afed6ddd92e469888
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3531155
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
|
6bd11e28
|
2022-03-22T12:38:13
|
|
Add back Pixel 6-specific dEQP FAIL suppression
Bug: b/224537784
Change-Id: Iddbd1cbd1aef6349dc1a4298febe74907bd126a8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3543727
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
20e7bbb7
|
2022-03-18T17:03:18
|
|
Vulkan: Fix invalidate of attachments with emulated format
Some image formats may be emulated such that the emulated format has
more channels than the original. ANGLE clears the image once so that
these extra channels contain valid values, and carefully ensures they
are never modified.
For swapchain images with such formats, as they are automatically
invalidated at the end of the frame, a workaroud was added to make sure
they are re-cleared in the beginning of the next frame. This however
doesn't fix the issue of glInvalidateFramebuffer resulting in the
contents of attachments with such formats to be discarded (even if the
following render pass clears it, the contents are invalid in between).
This change instead makes sure invalidate of images with emulated
formats that have extra channels are handled appropriately:
- On IMR hardware, the invalidate is dropped altogether as it provides
little to no benefit.
- On TBR hardware, a clear is automatically staged on the invalidated
image.
The latter replaces the workaround that was added to make the following
render pass use loadOp=CLEAR, by adding a clear that's respected
regardless of what the future usage is.
This change also paves the way for a future change where the invalidate
of color attachments is tracked in render passes similarly to how
depth/stencil currently is. With this change, the image is no longer in
an inconsistent state where its contents are considered invalid, even
though some channels are meant to remain valid.
Bug: angleproject:6860
Change-Id: Iec5b4854dfbe3a0bf93cd5aa82c19fe116065744
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3536389
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
e7f29440
|
2022-03-16T14:31:39
|
|
Remove dEQP FAIL expectations for passing tests
Based on bot runs, a number of previously FAIL'ing dEQP tests are now
passing. Need to separately test Pixel 6 and SKIP expectations.
Bug: b/203826952
Change-Id: I8a2bdb44b9050d1b93e85082c5dd1e15420e6f3e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3531073
Reviewed-by: Roman Lavrov <romanl@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>
|
|
|
ebf4c58f
|
2022-03-20T19:48:06
|
|
Capture/Replay: Enable test that no longer times out
Bug: angleproject:6220
Change-Id: I170462fa384f06ead39bdfce64d324426ad47878
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3538364
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
|
|
|
df06c945
|
2022-03-18T15:25:13
|
|
Capture/Replay: Skip binary IO test without binary formats
Bug: angleproject:6631
Change-Id: I7093a5d71ada7b1982e7294a6a7e7b482f5037a5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3536653
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
|
|
|
b9a83e14
|
2022-03-18T17:05:44
|
|
Capture/Replay: Recheck Flaky tests and update expectations
Bug: angleproject:6180
Bug: angleproject:6286
Bug: angleproject:6373
Bug: angleproject:6511
Bug: angleproject:6538
Bug: angleproject:6543
Change-Id: I39c44f2552e3bbd7f47bf94c08f42b4ab342f7d7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3536652
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
|
|
730c1271
|
2022-01-07T13:41:08
|
|
Vulkan: Submit queue more often for texture data
Outside command buffers should be flushed more often in order
to prevent the texture data accumulation just before the first
render pass when they are referenced.
* Added a tracker next to copyBufferToImage() for texture size
(in ContextVk). When its value passes kMaxBufferToImageCopySize,
the outside command buffer operations should be submitted and
the tracker would be reset. Currently, the threshold value is
set to 1 << 28 = 256M.
* Added a variation of submitFrame() to be used in outside
command buffer submission. The main difference is that it
copies mResourceUseList into GetShareGroupVk() rather than
move it.
* Refactored the two functions into submitFrameImpl().
* Added a helper function to submit the outside command
buffer.
* Added explicit copy functions for ResourceUseList and
SharedResourceUse. The counter in the copied object is
incremented by 1.
* Added a test to make sure submitting the outside command
buffer does not break the render pass.
Bug: angleproject:6354
Change-Id: Ia1d4f857fcbd06934609c94622ccbf675b3b1c72
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3379231
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
40afbe4b
|
2022-03-20T23:39:57
|
|
Translator: Fix SimplifyLoopConditions producing dead code
This causes the tree to fail validation. Dead code could be generated
if the loop body ended in a branch. In such a case, no additional
instructions are added to the transformed loop body after the original
body.
Bug: chromium:1300782
Change-Id: I4ec46c170ab5a45fa9b9b73d4e2b62c9c4fa24a3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3539442
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
b2c01ac4
|
2021-09-28T12:57:45
|
|
Report process memory in perf tests.
Bug: angleproject:6440
Change-Id: Ifdd4389266e3ac55963a3069d437c631bf73f72a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3191194
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
9637185c
|
2022-03-10T15:38:13
|
|
Add ForceGPUSwitch to EGL_ANGLE_power_preference
eglHandleGPUSwitch() does not work with WebKit sandbox profile.
The root cause is that we do not know the
primary display, and as such we do not know which GPU drives this.
Add eglForceGPUSwitchANGLE(display, gpuIDHigh, gpuIDLow).
This lets the caller figure out the GPU in another process. Then
the caller can just set the GPU in the sandboxed process.
Add tests that are disabled by default until the runner and the
infrastructure supports running the tests with automatic switching
enabled.
Bug: angleproject:7092
Change-Id: I316ee431156596effbdb89659a5e24291719a204
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3516274
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
|
|
|
7c616871
|
2022-02-01T15:12:53
|
|
Metal: Implement ANGLE_base_vertex_base_instance
Includes command buffer and MSL translator updates.
The DrawElementsInstancedBaseVertexBaseInstance tests from
DrawBaseVertexVariantsTest suite fail for dynamic draw and
stream draw buffer usages.
Bug: angleproject:6963
Change-Id: I6caa144860356d5fc85948b72458bec282ea3a3b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3429819
Reviewed-by: Kyle Piddington <kpiddington@apple.com>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
|
|
|
f96d2d35
|
2022-03-18T10:54:07
|
|
Test RGB invalidate with user FBOs
When an RGB image is invalidated and then used as attachment, the
cleared alpha value was previously lost due to loadOp=DONT_CARE. This
was fixed by making the following render pass use loadOp=CLEAR instead.
The test for this relied on RGB backbuffers, which is not easily
testable on many platforms. This change adds a similar test using user
FBOs.
Bug: b/180139027
Bug: angleproject:6860
Change-Id: I11f408d6cd925b45bc9bcec455563cd23a226fec
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3536387
Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
e74d0e81
|
2022-02-11T18:05:12
|
|
Vulkan: Implement EGL_KHR_partial_update
This change provides a trivial implementation of partial
update that does nothing, making apps that want this
extension happy. A possible efficient Vulkan implementation
would use the damage set to narrow down render area, but it
appears to only be useful for only some TBDR hardware.
Bug: angleproject:6960
Reviewed-by: Antonio Caggiano <antonio.caggiano@collabora.com>
Change-Id: Ic553ac9590c336093f1bf25a6521574622599bf6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3427640
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Auto-Submit: Constantine Shablya <constantine.shablya@collabora.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
44e84661
|
2022-03-17T15:02:21
|
|
Revert "Emulate RGB10 (no alpha) on desktop OpenGL."
This reverts commit 6404be2defd3ded3ff2f0437bb87fe515e10f2a7.
Reason for revert: Extension was not fully enabled due to test bug.
Original change's description:
> Emulate RGB10 (no alpha) on desktop OpenGL.
>
> The OpenGL ES extension GL_EXT_texture_type_2_10_10_10_REV
> requires RGB and RGBA formats to be supported but Desktop OpenGL
> does not support RGB. Emulate it with the existing
> emulatedAlphaChannel path in TextureGL.
>
> Bug: chromium:1300575
> Change-Id: I0e6d1044afbc55cf6d4f987cc98b357ff11ff006
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3517346
> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Bug: chromium:1300575
Change-Id: Ib3810a18888544f1700a1f648a5094c19973d86d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3533139
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
|
|
|
e8ee847d
|
2022-02-23T12:25:39
|
|
Vulkan: Add UpdateDescriptorSetsBuilder.
This helper class encapsulates the vkUpdateDescriptorSets caching.
As part of the refactor, we switch passing a ContextVk to passing
a vk::Context with some mutable variables. This helps encapsulate
ContextVk. Since we use the perf counters in many places, this CL
moves the perf counters to vk::Context, so we can access them
everywhere.
Refactoring change only.
Bug: angleproject:6776
Change-Id: Id529962b2f425bece6f9b3bd0cd1698c692e58cb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3484980
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
98bb4f32
|
2022-02-23T16:51:32
|
|
Vulkan: Implement advanced blend through extension
This change exposes GL_KHR_blend_equation_advanced if
VK_EXT_blend_operation_advanced is supported. No emulation is yet
implemented.
Bug: angleproject:3586
Change-Id: Ie7a442c22e028e3aa45ccef52db320e205664d49
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3487951
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
459bdc2f
|
2022-03-16T12:04:38
|
|
Reintroduce validation check only for D3D
To avoid undefined behavior, D3D requires the
base mip level to have multiple-of-4 dimensions.
Add this validation check back in.
Bug: angleproject:7099
Change-Id: Id51f6cd4c745455062b864c0d291b9857e985e35
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3530499
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com>
Commit-Queue: Brandon Schade <b.schade@samsung.com>
|
|
04460fe8
|
2022-03-15T19:04:39
|
|
end2end tests: add regression test for GL_LINE_LOOP drawing
This was fixed by 349636a05a3577a127adb6c79a1e947890bbe462. Adding
a regression test which I didn't have ready at the time.
Bug: angleproject:7102
Change-Id: Icbb685c1ffad6725a278e5ed65f881f86c5688ef
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3527604
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
|
1dc9f126
|
2022-03-16T19:29:26
|
|
Revert "Flush the texture staged updates when destroying context share group"
This reverts commit 5c29d795d1625f71ac6999f157b6f3bba79d5256.
Reason for revert: this is causing some test failures on chromium and blocking the angle-chromium auto roller job: https://chromium-review.googlesource.com/c/chromium/src/+/3529771/
Original change's description:
> Flush the texture staged updates when destroying context share group
>
> If we are using the extension EGL_ANGLE_display_texture_share_group,
> flush the texture staged updates upon destroying the context. With the
> extension enabled, the texture could still be alive when both context
> and its' EGL::ShareGroup are destroyed. If we have staged updates not
> yet flushed, the updates will keep the ShareGroupVk bufferpool occupied,
> causing an error upon ShareGroupVk::onDestroy().
>
> Bug: chromium:1299211
> Change-Id: I260de93c3a3099e023e31acbe017803e824459ad
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3495879
> Reviewed-by: Charlie Lao <cclao@google.com>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Bug: chromium:1299211
Change-Id: I214161d6a8aec834e1efc5fc9d2479e62e3bfae0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3530505
Auto-Submit: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
ed590dc8
|
2022-03-11T12:54:44
|
|
FrameCapture: Add override for Glsizei* types.
Fix capturing glGetSynciv with null lengths on Linux.
When calling the default WriteParamValueReplay handler with a
nullptr, ostream on Linux will write `(nil)`.
This fixes retracing all traces containing glGetSynciv calls with null
lengths.
Add a NullLength test to FenceSyncTests that used to fail in the
capture_replay_tests.
Test: capture_replay_tests.py --gtest_filter=FenceSyncTest.NullLength/*
Bug: angleproject:7071
Bug: angleproject:6808
Change-Id: I0a2bd4db744ce2a026cd932ba0f2f4747672fcc8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3526653
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
|
|
f8a2229e
|
2022-03-16T10:58:07
|
|
angle_system_info_test also exports androidSdkLevel
Value being non-zero would unambiguously indicate that target is
Android, not sure if the actual value is really needed but it's probably
good to have.
Bug: angleproject:6854
Change-Id: I685e8e0ffbb666349801203e9d09b082135af17e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3529966
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Roman Lavrov <romanl@google.com>
|
|
|
08e007dd
|
2022-03-15T18:23:54
|
|
angle_system_info_test passes json via file
--render-test-output-dir is supported by Android test runner so the file
is first written on the device then copied over to the host.
Bug: angleproject:6854
Change-Id: Ia56fd9c36ab68a495459efa3b1014e871a615565
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3526855
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Roman Lavrov <romanl@google.com>
|
|
|
5c29d795
|
2022-02-28T23:56:46
|
|
Flush the texture staged updates when destroying context share group
If we are using the extension EGL_ANGLE_display_texture_share_group,
flush the texture staged updates upon destroying the context. With the
extension enabled, the texture could still be alive when both context
and its' EGL::ShareGroup are destroyed. If we have staged updates not
yet flushed, the updates will keep the ShareGroupVk bufferpool occupied,
causing an error upon ShareGroupVk::onDestroy().
Bug: chromium:1299211
Change-Id: I260de93c3a3099e023e31acbe017803e824459ad
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3495879
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
|
|
|
6baf1675
|
2022-03-04T11:04:46
|
|
Remove invalid validation check on compressed texture formats
Remove the ValidCompressedDimension() check for non-WebGL
contexts of compressed formats. This is because compressed
texture images can have dimensions that are neither multiples
of four nor small values like one or two.
Test: gtest_filter=*DXT1CompressedTextureTest.NonBlockSizesMipLevels*
Bug: angleproject:7099
Change-Id: Ic86c15dd3187ffab0665f6db21434fffcbe04fef
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3526017
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Brandon Schade <b.schade@samsung.com>
|
|
d4ddd0c1
|
2022-03-10T16:31:00
|
|
Vulkan: Handle the case where the bound buffer is empty
If vertex attribute is enabled and buffer is bound, but buffer size is
0, we should not crash. This CL skips mapImpl and data copy all together
if size is 0 to avoid crash when calling mapImpl while buffer is
invalid.
This CL also added a test for this.
Bug: chromium:1296467
Change-Id: I79af348f133e1d3b4427f044e370652d0875dc91
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3516700
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
|
70af5ff0
|
2022-02-18T14:35:59
|
|
FrameCapture: Skip invalid VertexAttribPointer calls in MEC.
In CaptureVertexArrayState when a non-default VAO is bound and no
GL_ARRAY_BUFFER is bound, VertexAttribPointer calls with a non-null
offset are invalid and will produce:
"Client data cannot be used with a non-default vertex array object."
Add a test that leaves a vertex array with an invalid vertex
attribute pointer and used to produce an invalid trace with MEC.
Test: angle_end2end_tests --gtest_filter="VertexAttributeTestES3.InvalidAttribPointer/*"
Bug: angleproject:7042
Bug: angleproject:7098
Change-Id: Iaf91fe7f191c44df79db47bb5455e5df922f2ed5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3475353
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
|
|
|
2397b5fe
|
2022-03-15T10:17:36
|
|
Vulkan: Temporarily suppress 3 perf counter tests on P6.
Bug: angleproject:7096
Change-Id: I63ce1773282ac79ee9c0656b32715182d2e89d92
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3525814
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
d914e7fb
|
2022-03-09T16:28:06
|
|
Add device id as a part of the key in EGLDisplay cache
Otherwise eglGetPlatformDisplay would return displays created
with other devices.
Bug: angleproject:7087
Change-Id: I6ad3fa03f02892afe43de7e7691fbba17a89d616
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3513753
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
|
|
|
708ce9cf
|
2022-03-14T10:37:31
|
|
Fix crash when pausing XFB then deleting a buffer.
Fix is to validate XFB buffer bindings even if we're paused.
This is undefined behaviour so we can use any non-crashing solution.
Bug: chromium:1305190
Change-Id: Ib95404cdb13adbde7f34d6cc77473a8b3cbf1de7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3522283
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
e9d9d933
|
2022-03-14T09:33:28
|
|
Vulkan: Fix another corner case of mCurrentElementArrayBuffer
mCurrentElementArrayBuffer is vertex array state. But it gets modified
with different draw call parameters. When this changes, we always
re-calculate mCurrentElementArrayBuffer. And we have added
updateCurrentElementArrayBuffer call at various places where we need to
reset mCurrentElementArrayBuffer to back to what bound to vertex array.
There is still one more places missing such call, that when a different
vertex array is been bound, the new vertex array may still have
mCurrentElementArrayBuffer set to the special array for LineLoop. We
need to reset it upon it gets bound.
This CL also adds a new test case DrawElementsTest.LineLoopTriangles
from Steven Noonan.
Bug: angleproject:6955
Change-Id: Ida95062b071d25be26e59f886bfe3d61e6886c5c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3522565
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
|
3739a195
|
2022-03-09T13:56:36
|
|
perf tests: Record perf counter metrics.
This adds a new command line argument that will allow the user to
specify perf counters to record into the test output.
Bug: angleproject:4918
Change-Id: Ia7432ff96eadf13ef681f67d2d503d00fd83e06e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3516970
Reviewed-by: Lingfeng Yang <lfy@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
7eb7596a
|
2022-03-10T14:32:58
|
|
Ensure non float uniform are actively used
In mesa, the non float uniforms are optimized out when they are
not active. This change ensures the unforms are active.
Reference: https://gitlab.freedesktop.org/mesa/mesa/-/issues/6119
Bug: angleproject:7091
Change-Id: Iedff4a4b72a7204348c226778cfe940374632a4a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3515640
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jiajia Qin <jiajia.qin@intel.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
b97aab3f
|
2022-03-09T17:36:24
|
|
Vulkan: resync mCurrentElementArrayBuffer when out of lineloop
When glDrawElements is called with GL_UNSIGNED_BYTE type or LineLoop
mode, we will internally allocate an element buffer and copy data to it.
But when we switch out of that mode, we must re-sync
mCurrentElementArrayBuffer to what it should be based on VertexArray
buffer binding. This CL fix the bug that we were previously not updating
it and end up using the wrong element buffer.
Also added three tests:
DrawWithSameBufferButDifferentTypes: that uses GL_UNSIGNED_BYTE data and
GL_UNSIGNED_SHORT data in the same buffer and switch between these two
data types without incurring buffer change.
DrawWithSameBufferButDifferentModes: draw line mode followed by triangle
without the same element buffer.
DrawArraysLineLoopFollowedByDrawElementsTriangle: draw line mode with
glDrawArrays and then followed by DrawElements.
Bug: chromium:1299261
Change-Id: I5c471117d300e9fac9127a9d8fa66d48ac312f03
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3513553
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
|
1cfbe863
|
2022-03-09T13:35:44
|
|
perf tests: Report multiple time metrics.
We can now report cpu/wall/gpu time instead of just a single timing
metric. This is in preparation for reporting other types of metric
including counters.
Also includes some other minor script improvements.
Bug: angleproject:4918
Change-Id: I52a3241893c56a1bfe982990ebac0fa168dbac51
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3516969
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
6404be2d
|
2022-03-10T11:04:22
|
|
Emulate RGB10 (no alpha) on desktop OpenGL.
The OpenGL ES extension GL_EXT_texture_type_2_10_10_10_REV
requires RGB and RGBA formats to be supported but Desktop OpenGL
does not support RGB. Emulate it with the existing
emulatedAlphaChannel path in TextureGL.
Bug: chromium:1300575
Change-Id: I0e6d1044afbc55cf6d4f987cc98b357ff11ff006
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3517346
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
|
a956162c
|
2022-03-01T13:05:29
|
|
Vulkan: Expose performance counters via extension.
This CL rewrites the Vulkan perf counters test to work in the
angle_end2end_test suite using the newly exposed AMD extension.
Note that we implement only a subset of the extension. Instead
of generating monitors and starting/stopping them we simply
read back all performance counter data at once using the special
montior value "0".
The CL also enables these tests on SwiftShader.
Bug: angleproject:4918
Change-Id: I5d8f6eecb1ccff448657cbdb65b51a225dfb90c0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3497538
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
af2e0c01
|
2021-12-13T20:47:25
|
|
Capture/Replay: Override GL_HALF_FLOAT type for legacy formats
Because GL_HALF_FLOAT and GL_HALF_FLOAT_OES have different values,
and the format table created by BuildInternalFormatInfoMap() and
queried to obtain the readback format uses GL_HALF_FLOAT_OES for
legacy formats, we have to override the type in this case.
Bug: angleproject:6333
Change-Id: Ibfdcf2ad80ccfb15872ab441c0f22f0851ffe3f0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3332721
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
|
|
|
48c86e1b
|
2022-03-04T15:38:38
|
|
Test: Add Solar Smash trace
Test: angle_perftests --gtest_filter="*solar_smash*"
Bug: angleproject:7080
Change-Id: Ia47c9fb40c0730b5131deaf81c5eb4fda0f43a04
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3504189
Auto-Submit: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
4cca6b3e
|
2022-03-08T14:54:02
|
|
Early return when rebinding the same buffer, sampler or texture
Bug: angleproject:6955
Test: SimpleStateChangeTestES3.BindingSame*
Change-Id: If946a7cf534809d21e49138d9f34dcee61a73627
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3029049
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
24c641dc
|
2022-03-01T11:12:38
|
|
Add stubs for AMD_performance_monitor.
We can piggy-back on this extension to report internal ANGLE
performance counters to the ANGLE tests.
Includes a minor variable de-duplication in the EP generator.
Bug: angleproject:4918
Change-Id: I4a76aea957b423a36a90349643bd50a4e1905849
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3497537
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
2764bda9
|
2022-03-07T15:23:25
|
|
Metal: Fix MultisampleResolveTest failure on Vulkan_SwiftShader
Bug: angleproject:7081
Change-Id: Ia62ec86431692c6550b642b2d992b883dfa3b43a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3508445
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
74f32702
|
2022-03-03T13:13:34
|
|
Metal: Fix for mulitsampled buffers losing their contents
Fixes tst included as well as WebGL CTS
https://www.khronos.org/registry/webgl/sdk/tests/conformance2/renderbuffers/multisample-draws-between-blits.html
Both fail on M1 without this fix.
Also fixes WebKit bug https://bugs.webkit.org/show_bug.cgi?id=237113
Bug: angleproject:7073
Change-Id: Id7baa2575c817561f8a0a99181c986b758376a8d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3506089
Reviewed-by: Kyle Piddington <kpiddington@apple.com>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Gregg Tavares <gman@chromium.org>
|
|
|
ea70300b
|
2022-03-01T14:55:00
|
|
Fix base level changes not updating FBO completeness check.
Bug: chromium:1299264
Change-Id: I0881a4916c3eeb9ee023d28d207795899417d530
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3498282
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Auto-Submit: Jamie Madill <jmadill@chromium.org>
|
|
|
2e7cfa9b
|
2022-02-22T13:10:12
|
|
Metal: Fix WebGL CTS fbomultisample tests failing in Metal
These tests were failing in Metal:
deqp/functional/gles3/fbomultisample.2_samples.html
deqp/functional/gles3/fbomultisample.4_samples.html
deqp/functional/gles3/fbomultisample.8_samples.html
This CL only fixed the tests failing on AMD. Intel still fails.
See: https://anglebug.com/7079
Bug: angleproject:7049
Change-Id: I745672bba2e9b8b1d34c7a81e07410889eddd35f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3482157
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Gregg Tavares <gman@chromium.org>
|
|
|
f9ade9fb
|
2022-02-18T15:08:54
|
|
Vulkan: Add feature to create pipeline during glLinkProgram
Creating the pipeline will trigger the compilation of shaders to byte
code thus warming up Vulkan shader caches. Typically most apps call into
glLinkPrograms during app loadtime and the goal is to improve cache hit
rate and reduce CPU workload during game play.
Bug: angleproject:7046
Test: ProgramBinary*CreatePipelineDuringLink*
Change-Id: I71351d45a9aa84e220ca38503735e94cff1dcf98
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3478354
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: mohan maiya <m.maiya@samsung.com>
|
|
|
bf3cdca5
|
2022-03-04T11:46:16
|
|
Capture/Replay: Mark two more tests as flaky.
TransformFeedbackTest.BufferOutOfMemory
VertexAttributeTestES3.DrawWithUnalignedData
Flaked on win-trace.
Bug: angleproject:6180
Bug: angleproject:7076
Change-Id: I75f3ca2468f2802cb3809340f32c064d56438c65
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3503693
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
ee96a461
|
2022-02-22T12:23:06
|
|
Vulkan: Fix missing empty buffer descriptor.
This could happen for SSBOs and UBOs when the shader renders
without a bound buffer, and robustness enabled.
Bug: angleproject:6707
Change-Id: I993f2489aca47f07068908858c83afa78c9e0402
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3484979
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Auto-Submit: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Roman Lavrov <romanl@google.com>
Commit-Queue: Roman Lavrov <romanl@google.com>
|
|
|
61e0c319
|
2022-03-04T15:39:40
|
|
Tests: Add Fire Emblem Heroes trace.
Test: angle_perftests --gtest_filter="*fire_emblem_heroes*"
Bug: angleproject:7077
Change-Id: I1121cca8bab51bb9a820215f7526a88e8b28e51d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3501893
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
|
|
|
d9002eef
|
2022-03-01T16:14:47
|
|
Protect against deleting a current XFB buffer.
Bug: chromium:1295411
Change-Id: I097f272c38e444e0af71aa55c0dc508a07aa0bd3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3498262
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
348ece42
|
2022-03-01T15:40:38
|
|
Vulkan: Fix issue with redefining a layered attachment.
The fix ensures we complete level redefinition before we get the
layer render target in TextureVk::getAttachmentRenderTarget.
Bug: chromium:1296866
Change-Id: Id7fa8e9fed5e766c30580b09336713c675c4e4f0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3498283
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
722ac971
|
2022-03-02T19:24:26
|
|
Fix glClearColor calls to use GLColor32F constants.
Bug: angleproject:5025
Change-Id: I8d8bc8ff0b93951e19697d57c07368e1196498ae
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3499564
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
19fd3bc5
|
2022-02-28T13:23:20
|
|
Fix unaligned reads on armeabi-v7a
If an application provides unaligned data to glVertexAttribPointer,
we may attempt an unaligned read from this application-provided buffer.
This change detects such a case and copies the data byte-by-byte in
order to prevent SIGBUS errors on architectures that do not support
unaligned reads.
This fixes the issue ONLY for integer-to-float vertex attribute
conversion. Other vertex attribute processing functions may still be
affected by this problem.
Bug: angleproject:7001
Test: VertexAttributeTestES3.DrawWithUnalignedData*
Change-Id: Ic66a150a0bf9fe4df3afe5fc5c91646a46186e8d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3448420
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: mohan maiya <m.maiya@samsung.com>
|
|
|
37bfc40d
|
2022-02-27T16:27:26
|
|
Tests: Add Blade&Soul Revolution trace
Test: angle_perftests --gtest_filter="*blade_and_soul_revolution*"
Bug: angleproject:7053
Change-Id: I0ef1442c5cf12c08f9b461559512ae858829e41c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3492850
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
6acb927f
|
2022-02-28T16:40:57
|
|
Tests: Add Castlevania: Symphony of the Night trace
Test: angle_perftests --gtest_filter="*castlevania_sotn*"
Bug: angleproject:7067
Change-Id: Id93190d4827e7c87aa585d5d73ba55321e0d09f3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3495881
Reviewed-by: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
2a9c4b01
|
2022-02-10T11:33:32
|
|
dEQP: Enable CreateSurfacePlatformEXT tests
Add the corresponding capability to NativeWindow and implement
getPlatformExtension virtual method to return a native pointer that can
be used with eglCreatePlatformWindowSurfaceEXT().
Bug: angleproject:6961
Change-Id: Ieb1a1fd8b3cae4e6f199c269f3922cbd0307aa35
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3452102
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Auto-Submit: Antonio Caggiano <antonio.caggiano@collabora.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
b92ebdb7
|
2022-02-24T12:23:09
|
|
EGL: Add code-gen for dmabuf extensions
Add code-gen for EGL_EXT_image_dma_buf_import and
EGL_EXT_image_dma_buf_import_modifiers.
Bug: angleproject:7065
Change-Id: Ib1bd2a881f11e96b1e7e5128975bdba3bdc41e0f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3495122
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
ef6688c9
|
2022-03-01T09:21:20
|
|
Tests: Add Five Nights at Freddy's trace
Test: angle_perftests --gtest_filter="*five_nights_at_freddys*"
Bug: angleproject:7066
Change-Id: Iad911da90eea7e798fabeaf697afea29fb53ce93
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3495880
Reviewed-by: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
309e6dad
|
2022-02-18T12:31:31
|
|
Tests: Add Final Fantasy Brave Exvius trace.
Test: angle_perftests --gtest_filter="*final_fantasy_brave_exvius*"
Bug: angleproject:7041
Change-Id: I3a30a317b1c10b016652dbdaadcd577bf167c5f0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3475352
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
|
|
|
5118002e
|
2021-11-29T21:01:03
|
|
Capture/Replay: test and handle texture gen-on-bind
Bug: angleproject:6425
Change-Id: Ieb4c0a7a6ffdbf0690c07c10e001835a0dcbb6e1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3295620
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
|
|
|
bc20e55b
|
2021-11-29T21:00:45
|
|
Capture/Replay: test and handle renderbuffer gen-on-bind
Bug: angleproject:6425
Change-Id: I591bf0fdfe2e7f83d7e02f63c8265234f7b85df6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3295618
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
|
|
|
efb951e8
|
2021-11-29T21:00:02
|
|
Capture/Replay: test and handle buffer gen-on-bind
Bug: angleproject:6425
Change-Id: If8b573d0d77192befe6db82498158c535bd3b104
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3295619
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
|
|
|
5236a767
|
2022-02-23T12:15:26
|
|
Capture/Replay: enable running GLES 3.2 tests with script
In addition add annotations for the tests that fail (crash)
Bug: angleproject:5366
Change-Id: I92747e70b4c0a494fb7f67ed0c282bd76788f505
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3484057
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
|
|
|
32881018
|
2022-01-14T16:03:22
|
|
Capture/Replay: atomic counter buffer limits are shader specific
Therefore, the override must also be applied to the per shader
values.
Bug: angleproject:6895
Change-Id: Iecd790afaca9358ee767d41b4c806bb8257b5fa6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3386948
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
|
|
5749ec7d
|
2022-03-01T02:14:42
|
|
Revert "Vulkan: Move mid-RP color clear to loadOp if content undefined"
This reverts commit cfe5a1735a934cc83133bb6c69d19aa27278a270.
Reason for revert: https://bugs.chromium.org/p/angleproject/issues/detail?id=5048#c7
@timvp That change just caused a regression in my project. I clear the color + depth buffer before drawing, but initially draw only to the depth buffer. It seems that it decided to ignore the color buffer clear as a result of that.
Original change's description:
> Vulkan: Move mid-RP color clear to loadOp if content undefined
>
> Instead of using vkCmdClearAttachments, if the color attachment has not
> been written to, modify the loadOp of the currently open renderpass to
> CLEAR.
>
> Bug: angleproject:5048
> Test: VulkanPerformanceCounterTest.MidRenderpassClear
> Change-Id: Ida47e6ac7d0f29e2c49bdf2e74c1d876a5d7c223
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3381912
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Commit-Queue: Tim Van Patten <timvp@google.com>
Bug: angleproject:5048
Change-Id: Iec5c73632429a80f955f7d659cf670f9cbb6c9b7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3496662
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Tim Van Patten <timvp@google.com>
|
|
|
cfe5a173
|
2022-01-11T19:26:42
|
|
Vulkan: Move mid-RP color clear to loadOp if content undefined
Instead of using vkCmdClearAttachments, if the color attachment has not
been written to, modify the loadOp of the currently open renderpass to
CLEAR.
Bug: angleproject:5048
Test: VulkanPerformanceCounterTest.MidRenderpassClear
Change-Id: Ida47e6ac7d0f29e2c49bdf2e74c1d876a5d7c223
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3381912
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>
|
|
|
802e0d4d
|
2022-02-15T16:40:07
|
|
Document perf test metrics
Bug: angleproject:1944
Change-Id: I7f0d5c73c943ba28b3e0270e17681d7e69a7ee4a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3466757
Reviewed-by: Lingfeng Yang <lfy@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Auto-Submit: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
c11cef2f
|
2022-02-16T10:42:41
|
|
Add Clearifying comment about Occlusion Query Test
Bug: angleproject:6752
Change-Id: I710273c43694b50ab4fb59a840ae15d6cb14391d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3469718
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
|
|
|
fd44f1a0
|
2022-02-25T13:34:01
|
|
Update API version in VulkanHelper to 1.1
* Updated the API version in VulkanHelper to avoid the
validation error regarding UNASSIGNED-API-Version-Violation on
Android devices.
Bug: angleproject:7062
Change-Id: Iacb12cd5c79ecc803cdb5fe5c8738d1ac352eec0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3491502
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
6db60483
|
2022-02-25T11:13:40
|
|
Android: Skip flaky EGL end2end tests
Skip flaky EGL end2end tests on Android.
Bug: angleproject:7059
Test: EGLSurfaceTest.ResizeWindowWithDraw
Test: EGLReadinessCheckTest.IsRunningOnANGLE
Test: EGLReadinessCheckTest.GetProcAddressNegativeTest
Test: EGLReadinessCheckTest.HasGetPlatformDisplayEXT
Test: EGLContextSharingTestNoSyncTextureUploads.NoSync
Change-Id: Ib6637625fa3bead4860268fcacd108da2183ce86
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3491501
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
e2f8c5c6
|
2022-02-22T19:15:11
|
|
Vulkan: Add ClearBenchmark.Run/vulkan_scissoredClear
Add the test ClearBenchmark.Run/vulkan_scissoredClear to benchmark
scissored clears with the Vulkan backend.
Bug: angleproject:5194
Test: ClearBenchmark.Run/vulkan_scissoredClear
Change-Id: I7d6aeb8683b2ac2488e1c961d0cc194e6107b7f1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3408457
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>
|
|
|
1e773db9
|
2022-02-22T10:51:15
|
|
Vulkan: Shader support for KHR_blend_equation_advanced
Translator can accept the layout qualifiers for the advanced blend
equation. No emulation code is currently generated, and ANGLE will
initially rely on the corresponding Vulkan extension.
Based on change by Brandon Schade <b.schade@samsung.com>
Bug: angleproject:3586
Test: angle_unittests --gtest_filter=*KHRBlendEquationAdvanced*
Change-Id: I3b728c5f144386d7030bbbb301ddb07daa1492b9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3481309
Reviewed-by: Brandon Schade <b.schade@samsung.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
b69349bc
|
2022-02-15T14:59:03
|
|
Tests: Add Real Racing 3 trace.
Add GL_EXT_shader_framebuffer_fetch prerequisite.
Test: angle_perftests --gtest_filter="*real_racing3*"
Bug: angleproject:7026
Change-Id: Ie76e7ca43bb3a95c343e56d3b830f1f6d6e733c4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3475351
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
19704a89
|
2022-02-15T13:21:12
|
|
Capture/Replay: Capture GetTexLevelParameterfvANGLE params
Bug: angleproject:3565
Change-Id: I940154a4e3ace9a3b8683eebdcd7bbb14402a641
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3461564
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
|
|
|
913d8add
|
2022-01-25T11:43:40
|
|
Capture/Replay: Mark another test as Windows-only crash
Bug: angleproject:6631
Change-Id: I30395b2cc9358963d73f0748c179300c5bfbe72b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3413158
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
|
|
|
223a25f0
|
2022-01-25T11:15:16
|
|
Capture/Replay: Allow capturing of multisample texture content
It just works.
Bug: angleproject:6611
Change-Id: Ia3da2ee0ea3e09889a65910fd101a7daaa99ea56
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3413157
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
|
|
|
d98f4812
|
2022-02-17T15:22:22
|
|
FrameCapture: Capture empty buffer generation.
This avoids emitting VertexAttribPointer with non-null offsets when
the array buffer is empty and a vertex array is bound in MEC.
When no buffer is bound, which was also the case if the buffer was
empty, non-null offsets are not allowed in VertexAttribPointer and
will result in:
"Client data cannot be used with a non-default vertex array object."
Add EmptyArrayBuffer test to VertexAttributeTestES3.
Test: angle_end2end_tests --gtest_filter="VertexAttributeTestES3.EmptyArrayBuffer/*"
Bug: angleproject:7026
Change-Id: I0cb02a5588f5d2bbc85f58b75fd14493b644d52b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3468524
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
|
|
|
f996d4d8
|
2022-02-16T09:27:04
|
|
Vulkan: Fix DynamicBuffer cache reuse.
There is a regression bug that the DynamicBuffer's BufferHelper's size
is no longer the size of entire buffer block's size, but the size of
suballocation. This caused buffer reuse logic to screw up since it
relies on the size to make the decision to keep or free the
mFreeBufferList. This CL fixes this bug by using the buffer block's
size.
This CL also removes DynamicBufferPolicy since it is not used any more
since most of DynamicBuffer usages that triggered that
DynamicBufferPolicy implementation have been switched to BufferPool. The
remaining DynamicBuffer usage is only for attributes and uniforms which
are generally small and per context.
Bug: angleproject:6980
Change-Id: I9e013cbd67dd74f5e7fc5bb7d9c9696bd1f69965
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3469714
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
|
8dc9e83e
|
2022-02-16T21:48:53
|
|
Translator: Fix RunAtTheEndOfShader w.r.t discard
RunAtTheEndOfShader wrapped main() if it ended in discard. However, it
didn't account for the fact that the discard instruction could be
wrapped in a block. This change makes RunAtTheEndOfShader more
conservative w.r.t discard and has it wrap main() on any encounter of
discard.
The change additionally adds AST validation to ensure transformations
don't generate dead code after branches.
Test credit to Cody Northrop.
Test: GLSLTest_ES3.ConstantConditionGuardingDiscard
Test: GLSLTest_ES3.NestedUnconditionalDiscards
Bug: angleproject:7033
Change-Id: Ie9d5210a5cfbb13449720a8a3f44666df9443d98
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3471014
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
00169174
|
2022-02-17T14:11:01
|
|
gl.xml: Remove GL_BLEND_EQUATION_EXT from GetPName.
When retrieving the GL_BLEND_EQUATION enum using glGet, FrameCapture
incorrectly emitted GL_BLEND_EQUATION_EXT, which is not part of core
GL4, GLES 2+3.
Add BlendEquationGetInteger test to SimpleOperationTest which failed to
compile in the capture/replay tests before this change.
Bug: angleproject:7026
Test: angle_end2end_tests --gtest_filter="SimpleOperationTest.BlendEquationGetInteger/*"
Change-Id: I886e64ca316754f05ada8e45604bd3aef58a5ba5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3468522
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
|
|
|
8d966f7d
|
2022-02-08T11:05:09
|
|
Vulkan: Simplify SubAllocation data types.
We no longer need to bootstrap on the wrapper classes because we
use a separate garbage list. This simplifies the code for the
allocation tracking considerably. Also we remove a few mutable
accessor to fortify our OOP design.
(Credit to Jamie since it is splited from his CL)
Bug: angleproject:6980
Change-Id: I2025ec4d141531273e824bb586957a38efc30be1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3469715
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
ad462491
|
2022-02-16T13:36:21
|
|
Refine suppression for GLSLTest.SwizzledChainedAssignIncrement.
On NVIDIA, skip only on OpenGL and GLES, not Vulkan.
Bug: angleproject:7029
Change-Id: I2ec2732a94d3952a147df8616fd248876f12172c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3469723
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
8cb58667
|
2022-02-16T13:47:22
|
|
Vulkan: Add uniform descriptor set caching test.
This covers the case where we'd continually miss the cache due to
buffer size mismatches.
Bug: angleproject:6980
Change-Id: Ia58871f431b6241af52fa0c37ab51952bc1c4f97
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3469227
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Auto-Submit: Jamie Madill <jmadill@chromium.org>
|
|
|
a0d558f0
|
2022-02-16T12:23:29
|
|
Vulkan: Fix D/S invalidation for MSAA EGL configs
Bug: angleproject:7007
Change-Id: I165ce16e8fdd388ae13aa2e3d05901199706ee24
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3469221
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
2893effa
|
2022-02-10T14:28:32
|
|
validationESEXT: Implement ValidateGetCompressedTexImageANGLE.
Add CompressedTexImageNegativeAPI test.
Bug: angleproject:6177
Test: angle_end2end_tests --gtest_filter="GetImageTest.CompressedTexImageNegativeAPI*"
Change-Id: Ia7ed503a7a98f10e4b02deb3954f367f842da3fa
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3452112
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
|
|
|
b1075951
|
2022-02-09T17:35:56
|
|
vk_helpers: Adjust CopyImageToBuffer extent to block size.
When using readPixels with compressed formats, the VkBufferImageCopy
bufferRowLength and bufferImageHeight need to be a multiple of the block
size.
This prevents the following Vk validation errors:
VUID-vkCmdCopyImageToBuffer-bufferRowLength-00203
VUID-vkCmdCopyImageToBuffer-bufferImageHeight-00204
Add tests with texture sizes that are not multiple of block size.
Test: angle_end2end_tests --gtest_filter="GetImageTest.CompressedTexImageNotBlockMultiple*"
Test: angle_end2end_tests --gtest_filter="GetImageTest.CompressedTexImageCubeMap*"
Test: angle_end2end_tests --gtest_filter="GetImageTestES32.CompressedTexImageCubeMapArray*"
Bug: angleproject:6177
Change-Id: I34c788efece285753857500801e88abeaa6a8a78
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3452111
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
|
|
|
bdedf146
|
2022-01-14T13:35:30
|
|
TextureVk: Implement getCompressedTexImage.
Extend ImageHelper::readPixels to support compressed formats.
Implement readPixelsForCompressedGetImage.
Add compression tests to GetImageTest.
Implement CaptureGetCompressedTexImageANGLE_pixels in
capture_gles_ext_params.
Test: angle_end2end_tests --gtest_filter="GetImageTest*.CompressedTexImage*"
Bug: angleproject:6177
Change-Id: I6e5b6d746b9c6cc9b885fa44f75a985660d8fb58
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3452110
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
|