|
c88a73c8
|
2021-12-02T12:49:00
|
|
Fix flakiness in CpuTimeSleepy
Looks like we can't really rely on the direct wall comparison---probably
different resolutions are tripping us up here.
Bug: chromium:1272977
Change-Id: Ie3691c59eb5b3765b79f1861200436d9c5acd609
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3313481
Commit-Queue: Lingfeng Yang <lfy@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
6f96a189
|
2021-12-01T11:14:33
|
|
FrameCapture: Clean up 'WriteCppReplayFunctionWithParts'.
This function was using two extra temporary streams that it didn't
need. Clean this up and remove the extra streams and repeated code.
Bug: angleproject:5133
Change-Id: I8065a189211ba9030fee523dc7145dc5daf71d92
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3311577
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
fe42ac4d
|
2021-11-29T15:45:40
|
|
EGL: deferredFlush fix for PRESENT_MODE_SHARED
Add work around to deferredFlush for SINGLE_BUFFER
Fixes issue with EGL_KHR_mutable_render_buffer and
deferredFlush feature.
Bug: angleproject:6739
Change-Id: I81f87899f2c92a7e001b6aee2f88ecf7ba0d40a1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3308224
Commit-Queue: Brandon Schade <b.schade@samsung.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
8e6f38e5
|
2021-12-02T17:24:32
|
|
Revert "Vulkan: Implement GL_EXT_multi_draw_indirect"
This reverts commit 79f9d163b4227115a3e60e027ec4d7dbe0495f64.
Reason for revert:
Breaks dEQP-GLES31.functional.draw_indirect* on Pixel devices:
https://blackbox.googleplex.com/dashboard/cts-graphics/target/git_master/oriole-userdebug/3/cts-angle-host-test-arm64-v8a/4
Original change's description:
> Vulkan: Implement GL_EXT_multi_draw_indirect
>
> * Optimized the implementations of multiDrawArraysIndirect()
> and multiDrawElementsIndirect() for Vulkan
> * Added helper functions to support drawArraysIndirect() and
> drawElementsIndirect() as special cases of multiDraw*Indirect
> functions.
> * Added the flag to enable the multiDrawIndirect feature
> (drawCount > 1). The generic implementation is used if the
> flag is disabled.
>
> Bug: angleproject:6439
> Change-Id: Ibc653d93d355657f828de9c33da22428629e450f
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3276044
> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Bug: angleproject:6439
Change-Id: Ia4d54ef3e7652febf4d77fdaf6809f57e8e29127
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3312829
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>
|
|
36bf1ebe
|
2021-11-17T13:31:17
|
|
Decouple gl_BaseVertex/gl_BaseInstance uniforms
These are builtin uniforms removed in
https://github.com/KhronosGroup/WebGL/pull/3278
Decouple them from the original ANGLE_base_vertex_base_instance
extension.
Make a new ANGLE_base_vertex_base_instance_shader_builtin
extension for these builtin uniforms.
Bug: angleproject:3402
Change-Id: I77b93917976ce435db9c578c0ade37bff18a42b0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3290304
Commit-Queue: Shrek Shao <shrekshao@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
|
|
|
8815245a
|
2021-12-01T08:58:01
|
|
Vulkan: Don't retain in buffer/imageRead unnecessarily
mUsedBuffers/images already tracks whether a buffer/image is used in a
render pass, so we can add to ContextVk's resource use list only once.
Bug: angleproject:6717
Change-Id: Idd528c7f0f3fcb4d8d8879ab6cc7055260ecb45d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3310523
Commit-Queue: Lingfeng Yang <lfy@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
2d41e0f7
|
2021-11-30T16:14:03
|
|
Rework compressed texture pixel unpack state handling.
Compressed images do not use the pixel unpack parameters. Instead of
handling this in Context, move this to formatutils, where it's already
handled for the 2D case. Also, update the test to generate an ASAN error
if not ignored for the 2D case.
Bug: chromium:1267496
Change-Id: Ib93bae00a2b0b75eafd74c267f737da225afd993
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3308825
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
8f6f5a4b
|
2021-11-30T23:48:30
|
|
Vulkan: Fix image respecify's usage tracking
When respecifying an image due to mip level count changes, the previous
image is staged as an update to the new image. The resource usage info
was not being transferred to the image being staged as an update,
causing it to be prematurely deleted.
Test based on one authored by sugoi@google.com.
Bug: chromium:1270658
Bug: angleproject:4835
Change-Id: I215c65ba700d7be608d0910d3cb37fcfdf297a2a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3308921
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
609eb31a
|
2021-12-01T10:24:59
|
|
Skip MultithreadingTestES3.MultithreadFenceTexImage on TSAN
Bug: angleproject:6718
Change-Id: If67662dfb2ade1c87e9b4ba22e65efabf17f096c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3310485
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
f84dc44f
|
2021-11-30T12:22:21
|
|
Add a test for changing an XFB buffer after Begin.
Bug: chromium:1274316
Change-Id: I4ba240ff4cc383b157a64a0c92e8ce8ab2d8061e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3309101
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
3b6f80b7
|
2021-11-23T10:07:43
|
|
Capture/Replay: eliminate redundant parameters in GenOnBind
The template parameter already defines the parameter value name and
the parameter value type, so add some traits to simplify the call
interface of the function.
Bug: angleproject:6425
Change-Id: I037bed8e5cc2e7367d8faa3af5d4fba2bfbb52c3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3295617
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
fc860bc1
|
2021-11-30T17:39:42
|
|
Skip *Vulkan_AsyncQueue angle_end2end_tests on TSAN
Bug: angleproject:6746
Change-Id: If8bbf8ffc4c6d5df376ebd7c3d51c98c6990ea0d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3308829
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
45028d29
|
2021-11-30T10:37:06
|
|
D3D11: Fix OOB access in vertex conversion code.
This could happen when using certain combinations of stride and
offset. Fix the issue by using checked math.
Bug: chromium:1274499
Change-Id: Idba3beedad10b0c0cac2dcbecba8e420c5baa6da
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3309035
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
7817761a
|
2021-11-23T22:47:44
|
|
Vulkan: Use the correct format when binding a pBuffer.
Vulkan would get the texture format from the pBuffer's config but
some pBuffer types use different formats which are queried with
getBindTexImageFormat.
This CL also removes nativeSizedExternalFormat.
nativeSizedExternalFormat was only used when the format/type is
GL_RGB/GL_UNSIGNED_BYTE. This is now obsolete since the real fix
was the pBuffer fix mentioned above, so this CL cleans up the now
unnecessary code.
Bug: angleproject:4369
Bug: chromium:1237561
Bug: chromium:1099979
Change-Id: Ibfedea60d10856831e3a1975ac20ae5eb6a73786
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3298352
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
|
|
ce854632
|
2021-11-29T10:48:48
|
|
FrameCapture: Fix Gen on Bind for MEC
The logic for detecting whether a resource has been generated
was not accounting for starting resources, which would only
be populated if using MEC. We also weren't tracking framebuffer
creation correctly in CaptureMidExecutionSetup.
Test: Asphalt 9 MEC
Bug: angleproject:5883
Bug: angleproject:6425
Change-Id: I8a7dfa4736c4d735dec8cd26ffa329f051927de6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3307778
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
440e5458
|
2021-11-27T19:55:06
|
|
FrameCapture: Integer attribs in MEC
If the component type of a vertex attribute is integer, we need to
use the appropriate VertexAttribI* functions to set it up.
Test: Asphalt 9 MEC
Bug: angleproject:5883
Change-Id: I2ab2248e5a36cc6636b081acf6474b5dbe2484db
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3305057
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
65720272
|
2021-11-26T17:42:16
|
|
Add end2end gl test for *_ANGLE_vulkan_image extensions
Bug: chromium:1264439,angleproject:6741
Change-Id: I12d332995138a020ba514fba34024c3e666b8e6b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3304396
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
2020ec2b
|
2021-11-18T16:49:35
|
|
Capture/Replay: run tests that will crash or fail compilation
These tests have to run in one-sized batches so that they do
not bring down other tests run in the same batch, but it is
useful to run these tests to see whether chenges to the code
fix these tests.
In addition, update the expectations to reflect that more
tests do not crash or even pass.
Mark one more test as FLAKY because a change of the batch
allocation seems to change this test.
Leave timeouts as skip to not burden the CI too much.
Bug: angleproject:6180
Bug: angleproject:6267
Bug: angleproject:6267
Bug: angleproject:6313
Bug: angleproject:6314
Bug: angleproject:6315
Bug: angleproject:6324
Bug: angleproject:6329
Bug: angleproject:6333
Bug: angleproject:6334
Bug: angleproject:6335
Bug: angleproject:6399
Bug: angleproject:6400
Bug: angleproject:6605
Bug: angleproject:6611
Bug: angleproject:6631
Change-Id: I973ec43feff8ca51de698e0aade3d7102b193166
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3291643
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
|
|
|
17261f3b
|
2021-11-29T19:53:39
|
|
Remove not needed constexpr definitions, deprecated in C++17
Bug: angleproject:6737
Change-Id: I38ead1bd8e5eaace78750505b93a2576e19d0f83
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3307535
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
949624bf
|
2021-11-29T16:57:35
|
|
Skip MultisampleTest on Mac Metal
ContentPresevedAfterInterruption/ES2_Metal_NoFixture__NoStoreAndResolve
Bug: angleproject:6702
Change-Id: Iefff376ec8f3fb140825ad239bf8a2b560c8effb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3307346
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
ef65edf2
|
2021-11-22T14:23:35
|
|
Add extension: ANGLE_rgbx_internal_format
Add the extension ANGLE_rgbx_internal_format, which exposes the ANGLE
internal format GL_RGBX8_ANGLE. The format GL_RGBX8_ANGLE enables
emulating RGB8 formats with RGBA8 within ANGLE.
This also renames the format GL_RGBX8_ANGLEX to GL_RGBX8_ANGLE, since
it's being exposed.
Bug: angleproject:6690
Test: Texture2DTestES3.TextureRGBXImplicitAlpha1
Change-Id: I5548a3578a14e2f2a4006bbf59983b01f694b7f3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3296625
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
44d0ef69
|
2021-11-25T14:37:38
|
|
Vulkan: Enhance SamplerDesc for YUV formats
In order to uniquely identify a VkSamplerYcbcrConversion, having just
the format is insufficient. We need to account for conversion model
and color component range. Refactor SamplerDesc by encapsulating YUV
related fields into its own YcbcrConversionDesc.
Bug: angleproject:6732
Test: Texture2DTestES3.*Yuv*Vulkan
Change-Id: I23114c50646232dccde988a52b0649778ad72a90
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3301899
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
|
|
|
568a350e
|
2021-11-29T14:17:31
|
|
Suppress Texture3dTestES3.PixelUnpackStateTex[Sub]Image3D on Mac
This test was newly added in the fix for https://crbug.org/1267496
It crashes similarly on Mac. Suppress for now while I work on the
fix.
Bug: angleproject:6738
Change-Id: Ifbdbb790b2f60fe91362ee47d1165165cb5c5382
TBR=ynovikov@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3307478
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
a5e391d7
|
2021-11-19T17:35:06
|
|
Add GL_ANGLE_vulkan_image extension
glAcquireTextures & glReleaseTextures are added for sharing
texture ownership with an external API.
Bug: chromium:1264439
Change-Id: If46d8d230b4f611768b5ff1187674509e42f01e0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3293921
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
|
|
|
00d0b79f
|
2021-11-26T14:38:20
|
|
Bug fix in BitSetArray iterator
Account for gaps spanning multiple BaseBitSet while iterating.
Bug: angleproject:3877
Tests: BitSetArrayTest*IterationWithGaps*
Change-Id: I64a0393bf117678b0a7855904a6ac328a13bb40c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3304108
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
f893c61b
|
2021-11-26T14:58:28
|
|
Update capture_replay_expectations.txt.
Adds expectation for new skipped test.
Also consolidates expectations into just SwiftShader since we cannot
yet support multiple Vulkan implementations.
Bug: angleproject:6688
Change-Id: I736d28f3e452624eae4cde8058a6c1acdaae1263
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3304554
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
14f55a7f
|
2021-11-02T10:16:58
|
|
infra: Enable TSAN and UBSAN tests.
These tests are not yet enabled on the CQ.
Bug: angleproject:5795
Change-Id: I3fc58ab800ebbc0840da8221b03b4ab145d28028
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3258003
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
|
|
|
2797227b
|
2021-11-26T08:48:30
|
|
dEQP: Add flaky result handling.
A flaky expectation will allow the test harness to retry a failing
test one extra time. If the second run passes the flaky test will
be considered a passing result.
Bug: angleproject:5795
Change-Id: I09fc4ed34ee09548ab14f46dfce35f900be5550f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3303712
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
e0b4cf6c
|
2021-11-26T10:23:24
|
|
Fix Python3 usage with perf tests/gold tests.
Bug: angleproject:6733
Change-Id: I9d1baf78ed182db77c6a6d8e896737413ca417f3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3304012
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
268653c9
|
2021-11-25T13:37:58
|
|
Vulkan: Update a test to triger large dirty bit handling
Some traces bind one VBO to a large number of VAOs,and use glBufferData
to change buffer size frequently,this will cause glBufferData spending
a lot of time doing VAO dirty bit handling, which leads to high cpu load
in these traces.This test could triger this issue.
Bug: angleproject:6371
Change-Id: I99292825b8cb5bba58cc6b37e3baa7adcd02c780
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3301536
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
7f1ab9be
|
2021-11-25T21:59:51
|
|
Vulkan: add explicit template specialization for barrierImpl
ImageHelper::barrierImpl with primary command buffer is used in
other translation units (SurfaceVk::acquireNextSwapchainImage()).
Linking fails if compiler has optimized out symbol for primary
command buffer.
Bug: chromium:819294
Change-Id: I91d79788ae51d24472e8bd1d20cdb1a375e86300
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3301705
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
43ae7834
|
2021-11-25T21:52:45
|
|
GCC: fix type conversion in FramebufferGL
GCC has some problems deducing template argument.
Help with assigning the value to a new const variable
before using it.
Error message:
../../third_party/angle/src/libANGLE/renderer/gl/FramebufferGL.cpp:308:70:
error: default type conversion cannot deduce template argument for
'template<class Dst, typename std::enable_if<angle::base::internal::
IsNumericRangeContained<Dst,
unsigned int, void>::value, void>::type* <anonymous> >
constexpr angle::base::internal::StrictNumeric<T>::operator Dst() const
[with Dst = Dst;
typename std::enable_if<angle::base::internal::
IsNumericRangeContained<Dst, T>::
value>::type*
<anonymous> = <anonymous>; T = unsigned int]'
308 | tmpPixels = new GLubyte[checkedAllocatedBytes.
ValueOrDie()];
|
Bug: chromium:819294
Change-Id: I3e720fea4a8e24aab0a9a9b3dedf9abdebaa44a5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3301704
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
870f458f
|
2021-11-22T14:30:52
|
|
Ignore the pixel unpack state for compressed textures.
From OpenGL ES 3 spec: All pixel storage modes are ignored when decoding
a compressed texture image
This was causing a bad access when calling compressedTexImage3D
with GL_UNPACK_IMAGE_HEIGHT greater than the image height.
Bug: chromium:1267496
Change-Id: I9b1f4c645548af64f2695fd23262225a1ad07cd7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3296622
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
e00ad443
|
2021-11-15T20:16:16
|
|
Add EGL_ANGLE_vulkan_image extension
This extension is for exporting VkImage from EGLImage.
The VkImage must be used with the same VkDevice used by ANGLE
Vulkan backend.
Bug: chromium:1264439
Change-Id: I222d900465cf2716d94fc64f06e240390ec518ac
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3285025
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
|
|
a0924015
|
2021-11-22T19:44:05
|
|
Metal:Fix GLSLTest_ES3.GLVertexIDIntegerTextureDrawElements Metal
The test was failing if the "first" argument to glDrawElements
was odd. When odd the offset was not a multiple of 2 bytes
and the code was going down a different path than when the
offset was event.
The fix for that just removes a check for alignment to 4 bytes.
Checking with UNSIGNED_BYTE indices though and it still
failed. That was because it was encoding the index conversion
path on one command buffer and the provoking index prep
on another and so they were happening out of order.
Putting both on the same command buffer fixes that.
Bug: angleproject:6688
Change-Id: I89b68ba965d073e0fa70b6d5b444dc743b5e34a7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3296631
Commit-Queue: Gregg Tavares <gman@chromium.org>
Reviewed-by: Kyle Piddington <kpiddington@apple.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
110ac03a
|
2021-11-23T09:36:08
|
|
Vulkan: Revert change to sRGB override support.
An accidental testing change slipped into a fix for base/max level
updates. This reverts the unintended change.
Bug: angleproject:6728
Change-Id: I61e371149be590ce506cfc88165c4391538e54b3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3298428
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
2fa1adf0
|
2021-11-24T18:29:13
|
|
Revert "Vulkan: Use vkResetQueryPoolEXT when available"
This reverts commit 97aa5187ed164f1e9a22b64c966f2a747f651bfb.
Reason for revert: This apparently caused crbug.com/1273344
Original change's description:
> Vulkan: Use vkResetQueryPoolEXT when available
>
> ANGLE currently uses vkCmdResetQueryPool to reset a query pool. As
> reported by Arm, this can cause GPU bubbles. It is better to use
> vkResetQueryPoolEXT() when available (either by Vulkan 1.2 or by the
> VK_EXT_host_query_reset extension).
>
> Bug: angleproject:6692
> Change-Id: I650d7d0f55bdf6587b75be43cc7bed2dc3eb935a
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3294061
> Commit-Queue: Ian Elliott <ianelliott@google.com>
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Reviewed-by: Charlie Lao <cclao@google.com>
Bug: angleproject:6692
Change-Id: I70d5eeb0b98f016fd262935194f8f4abee2a72b9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3300309
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Lingfeng Yang <lfy@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>
|
|
|
6c172e4b
|
2021-11-20T16:27:14
|
|
Add support for memory cleanup on process exit
This patch adds a callback to cleanup memory on process exit.
Bug: angleproject:6723
Test: Android CTS WrapperTest.testThreadCleanup
Change-Id: Ia517d4c6ae280ddc1f17a3b6f77d437aaaad0678
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3294581
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
|
|
79f9d163
|
2021-11-15T08:51:41
|
|
Vulkan: Implement GL_EXT_multi_draw_indirect
* Optimized the implementations of multiDrawArraysIndirect()
and multiDrawElementsIndirect() for Vulkan
* Added helper functions to support drawArraysIndirect() and
drawElementsIndirect() as special cases of multiDraw*Indirect
functions.
* Added the flag to enable the multiDrawIndirect feature
(drawCount > 1). The generic implementation is used if the
flag is disabled.
Bug: angleproject:6439
Change-Id: Ibc653d93d355657f828de9c33da22428629e450f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3276044
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
924c8d8a
|
2021-11-18T22:58:04
|
|
Vulkan: Fix image tiling when DRM format modifiers are specified
Bug: angleproject:6679
Change-Id: I5198a180608535131b127c135423fb80c6478140
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3292027
Reviewed-by: Craig Stout <cstout@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
17bf6e98
|
2021-11-11T20:53:31
|
|
Implement GL_EXT_multi_draw_indirect
* Added the validation functions for multiDrawArraysIndirect()
and multiDrawElementsIndirect() according to the specs.
* Added generic implementation for the two functions that can
be called by back-ends.
* Added unit tests for the multiDrawIndirect functions.
* Added flags for back-ends so they can enable the extension.
* Minor cleanup in MultiDrawTest.cpp
Bug: angleproject:6439
Change-Id: I4e5f1cab05c6de330aef82d115492dcc9d2fad44
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3276043
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
8b60855b
|
2021-09-15T15:16:10
|
|
EGL: implement EGL_KHR_mutable_render_buffer
Pass render buffer mode change to WindowSurfaceVk.
On mode change trigger OUT_OF_DATE. Then in CreateSwapchain,
if new mode, set the Presentation mode and the Image count.
OffscreenSurfaceVk ignores mode change.
Add MUTABLE_RENDER_BUFFER_BIT to GenerateDefaultConfig.
Test: dEQP-EGL.functional.mutable_render_buffer.*
Bug: angleproject:3966
Change-Id: I7b59708514bcda10f8d45ce5f9528aa840fcccfa
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3171822
Commit-Queue: Brandon Schade <b.schade@samsung.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
97aa5187
|
2021-11-22T13:26:53
|
|
Vulkan: Use vkResetQueryPoolEXT when available
ANGLE currently uses vkCmdResetQueryPool to reset a query pool. As
reported by Arm, this can cause GPU bubbles. It is better to use
vkResetQueryPoolEXT() when available (either by Vulkan 1.2 or by the
VK_EXT_host_query_reset extension).
Bug: angleproject:6692
Change-Id: I650d7d0f55bdf6587b75be43cc7bed2dc3eb935a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3294061
Commit-Queue: Ian Elliott <ianelliott@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
|
4ae30a63
|
2021-11-22T16:25:11
|
|
Vulkan: Don't attempt to convert vertices in empty buffers
Bug: chromium:1271671
Change-Id: I869f30fd9c8a52c07263bb7a72978a31f2aceb9a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3297026
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
ce6f9c8f
|
2021-11-19T14:52:48
|
|
Update checked numerics library.
This library hadn't been updated in quite some time and had bugs
which affected UBSAN in some operators.
Bug: angleproject:5795
Change-Id: I40f658655034ce03df29cf4c71acb3f6fe96bef0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3289941
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
6e2e36cc
|
2021-11-19T00:57:29
|
|
[Fuchsia] Fix SwiftShader ICD discovery
ANGLE needs to set VK_ICD_FILENAMES for the Vulkan loader to discover
SwiftShader's ICD. Enable this logic on Fuchsia.
Also updated ConcatenatePath() to handle absolute paths correctly.
Bug: chromium:1225002
Change-Id: Ib69be0d7dcaef09f1da9d411023e90a3b7b4fca2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3292347
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
1d555687
|
2021-11-09T11:16:24
|
|
Capture/Replay: Set FBO ID when generated on bind
GLES allows FBO ID's to be reserved on bind, so if a FBO is bound with
and ID that was not yet reserved by a glGenFramebuffers call, update the
resource tracking and the resource map to account for this resources
that was created on bind.
Bug: angleproject:6425
Change-Id: I343fc17bfbbfd9c8c47d6fe207a4f3817acb835d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3190970
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
5859bb10
|
2021-11-19T13:25:38
|
|
Make D3D11 non instanced draw path explict
To make sure instanceCount == 0 is no-op according to OpenGL ES
3.2 spec section 10.5.
Before the fix the behavior on linux (gl) and win (d3d) are
inconsistent.
Bug: angleproject:3402
Change-Id: I70ec215d8b65c1591b4c816f76c92e88e9f0dc61
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3293749
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shrek Shao <shrekshao@google.com>
|
|
ef637366
|
2021-11-19T22:38:56
|
|
Revert the order of texture sync and frame buffer object sync
This change reverts the sync order swap done in
CL a280c671f178daf73da447d1030773b58b534998,
to address a performance issue in TRex.
The crash that sync order swap was
trying to resolve was addressed by
another CL 0fcad6260a3e3943fb84657a3a7f488d1e155fb7.
Bug: angleproject:6014
Change-Id: Ie49628295b6dcd5d012dc795bf123865b1a7f893
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3292636
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
9de37b58
|
2021-11-20T21:45:02
|
|
Vulkan: Fix draw with emulated xfb without xfb active
When transform feedback is not active, make sure the code that captures
xfb is not generated, even though it's guarded against with an if. This
is because no buffer is bound to the capture buffer, and by avoiding
generation of code that references that buffer, SwiftShader will not
attempt to access the missing descriptor set.
Currently, the actual declaration of the buffer is left in the SPIR-V,
which seems to be benign. If that causes issues in the future, the
SPIR-V transformer can be modified to remove that variable as well.
Bug: chromium:1209285
Change-Id: I83da8d1dea5390ecacc681f8ada9f586932deaa4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3294661
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
b6e2e8a0
|
2021-11-16T13:13:14
|
|
GL: Fix share groups for display texture sharing.
Chrome uses display-level texture share groups for WebGL contexts. When
this extension is in use, make sure all internal contexts are created in
the same share group.
Bug: chromium:1268830, chromium:1268389, chromium:1268218
Change-Id: I3925dffb9bb23fbbc7adcd3bee8cd62323b993e5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3285213
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
|
d781ef09
|
2021-11-22T11:12:10
|
|
Roll VK-GL-CTS from 234f8a066b4d to bfede065f419 (18 revisions)
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/234f8a066b4d..bfede065f419
2021-11-20 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/master
2021-11-19 ari.suonpaa@siru.fi Add tests for buffer size requirements
2021-11-19 jari.komppa@siru.fi Extend interpolateAt* tests
2021-11-19 jari.komppa@siru.fi Add power of two checks for physical device limits
2021-11-19 jari.komppa@siru.fi Modify dual source blend tests to use discard
2021-11-19 juha.heiskanen@siru.fi Add fragment operations occlusion query tests
2021-11-19 mohd.faisal@arm.com Fix wrong conversion from shared pointer to int.
2021-11-19 arkadiusz.sarwa@amd.com Enable anisotropic tests for mipmap images
2021-11-19 jason.ekstrand@intel.com Remove invalid semaphore import/export tests
2021-11-18 quic_mnetsch@quicinc.com Merge vk-gl-cts/opengl-es-cts-3.2.7 into vk-gl-cts/master
2021-11-15 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/master
2021-11-13 quic_mnetsch@quicinc.com Merge vk-gl-cts/opengl-es-cts-3.2.7 into vk-gl-cts/master
2021-11-13 michal.jakubek@mobica.com Various methods passing of PhysicalStorageBuffer tests
2021-11-13 venni.ihanakangas@siru.fi Improve coverage of MSAA copies
2021-11-13 michal.jakubek@mobica.com Fix Buffer Memory Requirements tests compilation errors
2021-11-13 r.potter@samsung.com Mirror existing ANGLE waiver for Samsung devices
2021-11-13 ruoyu@amd.com Support FP16 CPU Rendering
2021-11-09 alex.lan@arm.com Add yuv420 format to EGL AHB tests
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC geofflang@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: angleproject:6724
Change-Id: Ied03caaa16832597f9a694398577a4b24e11ce90
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3296262
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
41a8981e
|
2021-11-21T21:52:37
|
|
Use AttributeMap in eglLockSurfaceKHR's validation
Bug: angleproject:6062
Change-Id: I0eea431313700b11184265a9ff895417ce4b1d4d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3295164
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: (use @chromium please) Shahbaz Youssefi <syoussefi@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
ff89ba1b
|
2021-11-19T11:52:55
|
|
Capture/Replay: Repeat logs for unexpected results
The Ci logs are quite long and it is difficult to find the log for
the actual CI failures, so repeat the logs for unexpected failures,
crashes, compile errors, and timeouts at the end of the log.
Bug: angleproject:6542
Change-Id: Id9dff4cc70649d0d9cc8bd4509477fbe3ef10de8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3291653
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
647026fa
|
2021-11-19T19:08:14
|
|
Reland "Fix unused variable "useSwiftShader""
This is a reland of d721cdefdcf4c3e62ae364f0dc525e3ca54042a3
Adding a missing include.
Original change's description:
> Fix unused variable "useSwiftShader"
>
> -Wunused-but-set-variable when rolling into Chromium crrev.com/c/3293895
>
> Bug: angleproject:6496
> Change-Id: I02f7de303b52319c6a1821d7b697b7ee9bea8f89
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3292034
> Reviewed-by: Tim Van Patten <timvp@google.com>
> Commit-Queue: Tim Van Patten <timvp@google.com>
Bug: angleproject:6496
Change-Id: Id39e10a8f343600ea6b2f023442b4d8c7e1856dc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3292036
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
18b9f2dc
|
2021-11-20T02:52:05
|
|
Revert "Fix unused variable "useSwiftShader""
This reverts commit d721cdefdcf4c3e62ae364f0dc525e3ca54042a3.
Reason for revert: missing include
Original change's description:
> Fix unused variable "useSwiftShader"
>
> -Wunused-but-set-variable when rolling into Chromium crrev.com/c/3293895
>
> Bug: angleproject:6496
> Change-Id: I02f7de303b52319c6a1821d7b697b7ee9bea8f89
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3292034
> Reviewed-by: Tim Van Patten <timvp@google.com>
> Commit-Queue: Tim Van Patten <timvp@google.com>
Bug: angleproject:6496
Change-Id: I12748620cc20348bbcbe0304609a19ab65052b0e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3292035
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
d721cdef
|
2021-11-19T19:08:14
|
|
Fix unused variable "useSwiftShader"
-Wunused-but-set-variable when rolling into Chromium crrev.com/c/3293895
Bug: angleproject:6496
Change-Id: I02f7de303b52319c6a1821d7b697b7ee9bea8f89
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3292034
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>
|
|
|
98a49220
|
2021-11-19T15:02:47
|
|
GLES 1: Fix missing validation returns.
The validation was correctly generating an error but ANGLE
was not aborting the API calls for several validation calls.
This was detected by UBSAN tests which would trip a division
by zero.
Test: GLSLTest_ES3.GLVertexIDIntegerTextureDrawArrays/*
Bug: angleproject:5795
Change-Id: I5d5d8448454ce19cb4bdf1cd76a6ce513a6e9c6e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3293821
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
de5e8577
|
2021-11-19T15:05:12
|
|
MultithreadingTest: Initialize an atomic bool.
This variable was getting garbage data in UBSAN. Fix it by setting
an initial value of false.
Bug: angleproject:5795
Change-Id: I0a40bea427d7c02c8a12616c472c8d9ce70cb937
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3293822
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
edc2cfe5
|
2021-11-19T14:57:16
|
|
Fix signed integer overflow in angle_end2end_tests.
The test math was causing an signed overflow in the most extreme
case.
Test: GLSLTest_ES3.GLVertexIDIntegerTextureDrawArrays/ES3_Vulkan_SwiftShader
Bug: angleproject:5795
Change-Id: Id6b845577cb6ce585ec67251dcb6111d5773012f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3289942
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
8d51bd4b
|
2021-11-19T00:34:22
|
|
Capture/Replay: Add default return path for AccessParamValue
Some versions of MSVC have a bug that it will not detect when
all values of an enum are exhausted in a switch statement, which
leads to a warning that not all code path return a value, and
since the warning is treated as an error, compilation fails.
Bug: angleproject:6721
Change-Id: I4d62191ce83a04ba554dd804f13e7d428afd86a4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3291649
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
e28083ad
|
2021-11-09T18:00:17
|
|
Enable RenderDoc capture for debug builds
Enable RenderDoc capture in builds where Vulkan Validation Layers are
enabled. This essentially enables the '--renderdoc' flag for debug
builds when running end2end/deqp tests to make it easier to debug tests.
This CL also add the '--no-renderdoc' flag to force disabling RenderDoc
capture.
Bug: angleproject:6072
Change-Id: Iae7aae30aae9bdc58a7546118d156aef2047c210
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3270600
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>
|
|
|
f44a6fd2
|
2021-11-18T20:15:31
|
|
GLES1: Hard code integer values in the ubershader
This CL continues the process of removing uniform values from
the GLES1 ubershader to increase speed on mobile platforms.
The first phase removed bools 2091451e.
We've identified integers (enums) as providing the biggest bang for
buck to optimize speed while having acceptable program generation.
Allowing floats as well proved too much specialization. Many GLES1
conformance tests would grind to a halt while providing little to no
benefit to app traces.
This CL does the following:
* Create a GLES1ShaderState class that contains hashable data
* Populate it with all states influencing ubershader generation
* Hash the class to perform the lookup of existing programs
Frame times on Android ARM with locked GPU clocks:
Trace Before After
dr_driving: 4.2986 -> 0.8155
sonic_the_hedgehog: 2.8223 -> 0.6254
summoners_war: 15.9810 -> 2.3937
wordscapes: 7.6167 -> 1.1496
zillow: 2.9368 -> 1.9318
Test: end2end, perftests, gles1_conformance
Bug: angleproject:6644
Change-Id: I060280e282d7b514d3e410c4f8c5e09659e85d3b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3280355
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Lingfeng Yang <lfy@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
1cc5d096
|
2021-10-21T19:58:58
|
|
mathutil: Add roundDownPow2.
Bug: angleproject:5857
Change-Id: I6c7ae92a41957e9e6b40b6449f763a49493488d1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3236996
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
a00ce2ca
|
2021-11-19T10:23:53
|
|
Vulkan: Fix CFI ignore config.
This was being applied to "vulkan" when it should be higher in
the chain of depedencies. This CL moves it to "vulkan_icd".
Bug: angleproject:6496
Bug: chromium:1271193
Change-Id: I064caac6afe237d7008389f444d6ef9f37cff286
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3289937
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
1f5eb6b8
|
2021-11-17T16:42:20
|
|
Avoid Android vkEnumerateDeviceExtensionProperties() bug
This works around a race-condition during Android start-up, when ANGLE
is used as the default GLES driver and when render engine (RE) is
using SkiaGL (which uses ANGLE, which uses Vulkan). The race
condition occassionally results in different numbers of extensions
between ANGLE's first and second calls to
vkEnumerateDeviceExtensionProperties(). In that case, the second call
would return VK_INCOMPLETE instead of VK_SUCCESS. That caused ANGLE
to fail to initialize, causing RE to fail to initialize.
This change works around this problem by increasing the number of
extensions asked for in the second call to
vkEnumerateDeviceExtensionProperties().
Background: Surface Flinger uses Hardware Composer (HWC) for
hardware-based composition (e.g. using overlays), and RE for GPU
composition (e.g. rendering to combine multiple app and system windows
together). SF, RE, and HWC all start about the same time. HWC sets a
property if it can support display timing. This gets passed through
SF to RE's Vulkan loader. The Vulkan loader uses that property to
determine whether to enable the VK_GOOGLE_display_timing extension.
The Vulkan loader used to make a synchronous call to SF in
vkEnumerateDeviceExtensionProperties() in order to get this property.
That took some number of milliseconds to complete and affected the
start-up time of every Vulkan/ANGLE app. To eliminate that
performance problem, the property now propogates in an asynchronous
manner. At that time, it was thought that RE would always get the
property in time. However, a partner's experience is that
VK_INCOMPLETE is happening 0.5% of the time.
ANGLE doesn't need to use the VK_GOOGLE_display_timing extension.
This is because the Android EGL loader provides the related
EGL_ANDROID_get_frame_timestamps extension. The issue that ANGLE is
working around is that it shouldn't fail to initialize in this
situation.
Bug: angleproject:6715
Bug: b/206733351
Change-Id: I4eb2197cdcc9692518b1bf5984d06fc8a1a7d145
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3290506
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>
|
|
|
1bcbbd3b
|
2021-11-18T10:53:04
|
|
Roll chromium_revision 426f5c5607..c801e56b48 (941724:943107)
Change log: https://chromium.googlesource.com/chromium/src/+log/426f5c5607..c801e56b48
Full diff: https://chromium.googlesource.com/chromium/src/+/426f5c5607..c801e56b48
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/cfe2150f91..b0986a849c
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/b138e6ce86..075dd7e228
* buildtools/linux64: git_revision:90294ccdcf9334ed25a76ac9b67689468e506342..git_revision:4aa9bdfa05b688c58d3d7d3e496f3f18cbb3d89e
* buildtools/mac: git_revision:90294ccdcf9334ed25a76ac9b67689468e506342..git_revision:4aa9bdfa05b688c58d3d7d3e496f3f18cbb3d89e
* buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/707d75f53e..81212d29a2
* buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/51ffc5ed5c..7f068e554e
* buildtools/win: git_revision:90294ccdcf9334ed25a76ac9b67689468e506342..git_revision:4aa9bdfa05b688c58d3d7d3e496f3f18cbb3d89e
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/65e053eeaf..4cd7b34100
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/312bb312c9..13257ba994
* third_party/android_sdk/public: AuYa11pULKT8AI14_owabJrkZoRGuovL-nvwmiONlYEC..Ez2NWws2SJYCF6qw2O-mSCqK6424l3ZdSTpppLyVR_cC
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..e6e1eb6895
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7b33514431..1c7dec337d
* third_party/r8: CgqKHWrPllIffdVKV209JAStQqR93hUpTzSwKQ5Mth8C..nqWomZTwNDoogX26WeCSoFGg6aQN1FrwzoU4hCS0duEC
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/32d7c383a4..8caa4c5164
* tools/luci-go: git_revision:0e76392e6557cc3ff8d95c3bc012540e0dbc128a..git_revision:2dfe2f218f0395673f336d17b841edf629907ae3
* tools/luci-go: git_revision:0e76392e6557cc3ff8d95c3bc012540e0dbc128a..git_revision:2dfe2f218f0395673f336d17b841edf629907ae3
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/e1dd5dfb7b..9e42d0c22f
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/ffa11379f7..19145774c9
DEPS diff: https://chromium.googlesource.com/chromium/src/+/426f5c5607..c801e56b48/DEPS
No update to Clang.
TBR=geofflang@google.com,
BUG=None
Change-Id: I628302cee721b340b722ffff2be0bf45645ac13e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3289108
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
|
5f755c29
|
2021-11-17T16:29:37
|
|
Vulkan: Lock around handle counter.
TSAN showed we could have a data race when multiple threads
were releasing objects because of the singleton handle
counter.
Bug: angleproject:6714
Change-Id: I23b5d343bec421a663198e7efc30c78dab2bde8f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3288328
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
8700d9cc
|
2021-11-17T16:17:59
|
|
Vulkan: Lock around debug annotator.
TSAN showed thread contention could happen during make current
calls and when inserting debug markers.
Bug: angleproject:6714
Change-Id: I343b0bd6efbd46621f9e69bd8a329c135aed0d90
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3288327
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
8c634492
|
2021-11-17T11:06:23
|
|
Updates to perf test running script.
- Fixes logging (needed reload)
- Improves logging messages (less spam)
- Reduces time in test calibration & sampling
- Record failures on test errors more robustly
- Redesign the result recording class
Bug: angleproject:6090
Change-Id: I53fd86e9e009bd52ec98507334c69b05e711d83e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3288206
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
06d34598
|
2021-11-17T16:16:27
|
|
Vulkan: Add mutex around cache stats.
TSAN showed thread contention could happen in multithreading
tests because of the singleton cache stats object.
Bug: angleproject:6714
Change-Id: I701aa0079b5eb9d60ef557b13ce57efba17df2fa
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3288326
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
71bffb8a
|
2021-11-09T11:16:07
|
|
Capture/Replay: Handle newly generated FBOs in tracker
Bug: angleproject:6425
Change-Id: I39d22a6770290a0c407ac358b1c059c6a2ddeefa
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3269886
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
|
|
|
9a36c3b6
|
2021-11-15T13:46:06
|
|
infra: Update NVIDIA to 1660 testing.
Bug: angleproject:6694
Change-Id: I2580b53e45e633af98be757d9bb081461c06de95
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3283163
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
|
|
|
83fa1890
|
2021-11-17T12:17:31
|
|
Disable variable shadow warnings on more ES1 conformance tests
The list of gles1 sources is used in several targets without a
common config.
Bug: angleproject:6703
Change-Id: Ib78719c9dc322075dfba05380e99ec1ada8a3265
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3289616
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
|
e9f9fa17
|
2021-11-09T18:13:15
|
|
Add cpu time measurement to perf tests
Bug: angleproject:6667
Change-Id: I16570a7b51d363dd1c0f35789b985520cb76d488
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3270601
Commit-Queue: Lingfeng Yang <lfy@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
|
30c03b56
|
2021-10-28T12:54:39
|
|
Capture/Replay: Capture GetTexLevelParameter return param
Bug: angleproject:6180
Change-Id: Ia063d297bab85d6cb559642b9be213cc6f10a9bb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3250884
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
613f0361
|
2021-11-13T14:19:16
|
|
Fix typo in SystemInfo_libpci.cpp
Bug: angleproject:6691
Change-Id: I26d4cdc3839b71002c40ff114e5cb43d60ef2e81
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3279232
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
82cccf04
|
2021-10-28T12:49:55
|
|
Capture/Replay: Additional tests that now compile
Bug: angleproject:6108
Change-Id: I010ae0cd276fcd5093860400c2f7436c9b0bfedf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3250883
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
fc5fe46d
|
2021-10-28T12:47:15
|
|
Capture/Replay: Capture GetProgramResourceLocation name param
Bug: angleproject:6180
Change-Id: I5f27c695c31a32989c579b54e31cccc5b337bd58
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3250882
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
95e1d244
|
2021-10-28T12:24:59
|
|
Capture/Replay: Capture GetProgramResource params correctly
If a non-nullpointer is passed for length then the the number
of param entries that is written is returned in *length.
Otherwise, just capture the full buffer size as specified by
bufSize.
Bug: angleproject:6180
Change-Id: If7c3084e56c990477ddb6e93b8682e27004ba1e3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3250881
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
3ce1abd8
|
2021-11-16T14:38:15
|
|
Test Runner: Print output snippet in test timeout.
This will be helpful in diagnosing test failures.
Bug: angleproject:6694
Change-Id: I0ea491fe8ab48dfd017ce40150f606c571f3fa6c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3285805
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
c664c9fc
|
2021-11-16T12:22:47
|
|
Vulkan: Generalize barrier VVL suppression.
Seems to pop up in other tests as well. Seems to only affect
SwiftShader configs.
Run capture_replay_tests.py with the below test.
Test: BuiltinVariableVertexIdTest.LineLoop/ES3_Vulkan_SwiftShader
Bug: angleproject:6701
Change-Id: I857d4785d6e04edf96fb137a492548ed4d9fbcc4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3285445
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
b9c0194c
|
2021-11-16T11:36:52
|
|
Add EVENT0 markers for why we call vkAcquireNextImage
This will help when looking at AGI system traces.
Bug: angleproject:6696
Change-Id: Ic4b06f1a1ec155076cfcb47299afe451cd325327
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3283428
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
27bc56c6
|
2021-11-15T18:18:53
|
|
Vulkan: MAP_UNSYNCHRONIZED_BIT: Skip ghosting/idling
Respect the following spec language:
No GL error is generated if pending operations which source or modify
the buffer overlap the mapped region, but the result of such previous
and any subsequent operations is undefined
Test: cpu time improves in unsync case in perf-tests/MapBufferRange.cpp
Bug: angleproject:6680
Change-Id: I6133952546735aced6e6ee8468ef2ac695316fb6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3272018
Commit-Queue: Lingfeng Yang <lfy@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
|
|
|
647a703e
|
2021-11-12T13:48:06
|
|
Vulkan: Reorder logic in BufferVk::mapRange
This CL flattens the logic, ordering read case first, then write, and
simpler cases before more complex ones.
This is to prepare for an optimization where we ignore certain paths if
MAP_UNSYNCHRONIZED_BIT is set. No change in functionality or performance
is expected.
Bug: angleproject:6680
Change-Id: I0a2e9ee969216c90353eac7af6dabf648dea2173
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3279615
Commit-Queue: Lingfeng Yang <lfy@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
b9a8f092
|
2021-11-16T10:44:26
|
|
Disable variable shadow warnings on ES1 conformance tests
Bug: angleproject:6703
Change-Id: Ie66b5afc12c4f29f69b8d7e205de02cadd5268a3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3285383
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
316dcb56
|
2021-10-06T09:31:49
|
|
Add SwANGLE Skia Gold testing.
Required updating our system info helper to be able to retrieve
SwiftShader device information.
Bug: angleproject:6496
Change-Id: Ib38ea4da65d199433e17b87df2630c3fd77cb619
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3208646
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
5c6998e4
|
2021-03-30T09:33:55
|
|
Mark objects as initialized when robust init is disabled.
If a context with robust resource init disabled allocates a texture,
make sure it's marked as initialized or else the texture may be
reinitialized later by a context with robust resource init enabled.
Bug: chromium:1192632
Change-Id: I643f616c89420312f341b53cedbd1a4e4dc58675
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2794621
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
|
|
|
d27552f2
|
2021-11-11T11:43:30
|
|
Re-land: "Vulkan: Allow SystemInfo to pick ICD."
Re-land fixes build on iOS and Android with ANGLE/Vulkan.
This will be used in conjunction with SwiftShader.
Bug: angleproject:6496
Change-Id: Id38403da1e377bba293dc8368d1c1aac29bf56a9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3282426
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
7d33e71a
|
2021-11-15T11:20:25
|
|
Vulkan: SPIR-V Gen: Don't generate names for constants
Multiple constant variables can have the same value, and they are
coalesced to the same SPIR-V id. It's not useful to attempt to generate
multiple constants with different names, especially as those names don't
make it into the SPIR-V-Cross-generated GLSL. Additionally, most
constants in the translator don't retain their name, only the ones that
are not folded do (and which are folded is a rather arbitrary decision).
By generating names for these constants, the SPIR-V gen code was
introducing a bug where multiple OpNames could be generated for the
same OpConstant* id. This change removes OpNames generated for
constants in the first place.
Bug: angleproject:6644
Change-Id: Ife2f4bee8e2eb095dc0b22994420ee1dfc6023c6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3282425
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
ae3f67ab
|
2021-11-11T20:32:32
|
|
Implement GL_EXT_multi_draw_indirect
* Auto-generated the code to lay the foundation for
the following functions:
* multiDrawArraysIndirect()
* multiDrawElementsIndirect()
Bug: angleproject:6439
Change-Id: I7ab5111692376229515e0d6d9e6148909ce9a8a1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3276042
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
fdad9531
|
2021-11-10T22:09:00
|
|
Forward extra --deqp-* flags to deqp
This allows angle_deqp_* executables to be passed extra --deqp-* flags
that are unknown to ANGLE.
Bug: angleproject:6682
Change-Id: I9930cb8dd76b1c7bc7da9b731659277392fcd3ce
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3274175
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
3a84ef5e
|
2021-11-12T17:40:40
|
|
Add EGL_VULKAN_GET_INSTANCE_PROC_ADDR
Add EGL_VULKAN_GET_INSTANCE_PROC_ADDR for query Vulkan
vkGetInstanceProcAddr function pointer associate with the
Vulkan EGLDevice.
Bug: chromium:1264439
Change-Id: I4ff14e2aef7b8ca651e13b4d2867a540aed1b321
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3279100
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
|
|
|
3128c055
|
2021-11-12T14:59:46
|
|
Vulkan: Add wait semaphores to queueSubmitOneOff
For use in follow up change.
Bug: angleproject:3966
Change-Id: I5bfac51ef9d47a6df5d52268d3ce4863b848b1d1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3279226
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Lingfeng Yang <lfy@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
d87d10cd
|
2021-11-12T11:02:01
|
|
Fix ASAN issue with GLVertexIDIntegerTextureDrawElements
Was
GLint clearData[] = {42};
glClearBufferiv(GL_COLOR, 0, clearData);
Now
GLint clearData[4] = {42};
glClearBufferiv(GL_COLOR, 0, clearData);
Bug: angleproject:6688
Change-Id: Ia8fa0c7d406626046a32e613fda3a165a06941b6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3278489
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
b2cf52e6
|
2021-11-10T14:49:09
|
|
Bug fix in unpack buffer validation
For an implementation that supports GL_EXT_buffer_storage extension
it is valid to read or write from a buffer that is partially or fully
mapped if it was allocated by a call to glBufferStorageEXT with the
GL_MAP_PERSISTENT_BIT_EXT included in <flags>
Bug: angleproject:5056
Bug: angleproject:6689
Test: BufferStorageTestES3.TexImage2DPixelUnpackBufferMappedPersistently
Change-Id: Ia4b6967aab02bbfb101d5253b9c83d314bc92f5f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3278482
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
|
573f9415
|
2021-11-12T12:22:39
|
|
Vulkan: Prefer aggregate barriers on SwiftShader
SwiftShader is not currently sensitivel to stage masks, so aggregating
barriers leads to more efficient rendering.
Bug: angleproject:4633
Change-Id: I262d1e98d4b08a1ca134a1c5c64ae964ceb6cd16
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3279020
Reviewed-by: Alexis Hétu <sugoi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
6fe13477
|
2021-11-11T00:47:14
|
|
Vulkan: Add external's pNext to ANGLE_external_objects_flags
ANGLE was chaining VkImageFormatListCreateInfoKHR to
VkImageCreateInfo::pNext to support sRGB extensions. For external
images, it was unknown whether that was valid because there was no way
to know if external used an identical chain of pNexts. This was causing
a discrepancy between images created by Chrome and those created by
ANGLE as part of an import.
This change updates ANGLE_external_objects_flags to take in the pNext
chain external has used to create the image so ANGLE could create the
image identically.
Bug: chromium:1266094
Change-Id: I479b9e7ff39d437425dc91c79834880749766f99
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3274177
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
eb3ef08e
|
2021-11-11T17:41:48
|
|
Vulkan: Differentiate perf warnings and RP closure events
... and application events, by using different debug source enums,
translating to different colors in API debuggers.
Bug: angleproject:2472
Change-Id: Ice422c7ae59fb508a10500b9fbed79d4c9664c11
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3275840
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
dbc0c646
|
2021-11-06T01:09:26
|
|
Vulkan: Output the reason for RP closure in command buffer
To make it easier when viewing the command buffer in a graphics
debugger, this change inserts a marker just before closing the render
pass that specifies why the render pass was closed.
Bug: angleproject:2472
Change-Id: I862e500cd58332d6e199c853315c560fe6a73dc2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3265609
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|