kc3-lang/angle

Log

Author Commit Date CI Message
Jamie Madill cb87d78c 2021-07-08T08:28:04 Enable -Wshadow with Clang. Also fixes a few instances of variable shadowing in the code. Bug: angleproject:6148 Change-Id: Ic51d722a3f953f246f51af6d74abb302f832cf44 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3014875 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Gert Wollny 54ade715 2021-06-29T11:40:37 Enable passing tests out of BlitFramebufferANGLETest.*/* Bug: None Change-Id: I680f22bdc18af84547dcc51491923b0662e2b389 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2987993 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill 0e1ed36c 2021-07-02T12:32:03 Trace Tests: Improve state serialization. This encapsulates several colliding states into grouped scopes. It also improves serialization of several of the resources by including the resource ID in the serialization key. Also other minor improvements. This change should improve detection of state mis-management. Bug: angleproject:5133 Change-Id: I6ee5c02bb3ba70e91a595db2408076b15e4a9e67 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3003384 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Gert Wollny <gert.wollny@collabora.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 68d4e392 2021-07-02T14:18:54 Trace Tests: Add option for ASAN builds. ASAN builds can detect OOB memory accesses. This is very useful for diagnosing some kinds of flaky OOB crashes. Removes a test that was calling BufferSubData with a null data argument. This behaviour is undefined and we shouldn't be testing it. Also includes some minor refactorings and script changes. Bug: angleproject:5133 Change-Id: I5a7d9a5500c50a51f6369e944a5f0a533709f00d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3002510 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Gert Wollny <gert.wollny@collabora.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll f7c3c5b6 2021-07-08T10:01:00 Roll SwiftShader from 3c89f07b349b to 9534228df856 (3 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/3c89f07b349b..9534228df856 2021-07-07 capn@google.com Eliminate Subzero sandboxing support 2021-07-07 capn@google.com Assume Microsoft ABI on Windows 2021-07-07 capn@google.com Eliminate support for the PNaCl ABI If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: Ifd9886fd875daf9ddd5d323d2ef6356b37e31f56 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3012943 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll e9f0daa1 2021-07-08T10:01:19 Roll vulkan-deps from cda66075b3f4 to 015a6f8b338d (4 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/cda66075b3f4..015a6f8b338d Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/ae2a562936..9e707294f1 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/697cc6c387..8b86fbac17 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/394157ab51..f2912cd0f6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: Iebd455a306a409d2d9e05906aeafc1ffee822183 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3013456 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gert Wollny 2c22e080 2021-06-28T10:43:47 Capture/Replay: Enable SRGBFramebufferTest.Validation/* The test passes now. Bug: None Change-Id: I789f8fac225c42414bc8cc342138e1fd70a7f745 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2988684 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Gert Wollny 5fb5f63b 2021-06-29T09:56:43 Capture: Write captured context for empty frames When a frame is empty, still write the captured context for that frame because the index file will contain the frame file, and the replay will execute the according swapbuffer so that the replay will query the context serialization when testing trace correctness. With that enable RobustResourceInitTest.SurfaceInitializedAfterSwap/* for capture/replay. Bug: angleproject:5939 Change-Id: Ib280d55f739cc2bb8d2da0919e98c37a2cd576ba Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2987991 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll 08946bee 2021-07-08T07:00:20 Roll Chromium from 7c193479c917 to 8b6aa9a9bcc2 (411 revisions) https://chromium.googlesource.com/chromium/src.git/+log/7c193479c917..8b6aa9a9bcc2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/04f716686d..27e956c028 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/fd3f3c1998..2500c1d8f3 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/8fa8794677..79a2e924d9 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/d87a06daa9..cb34896ebd * testing: https://chromium.googlesource.com/chromium/src/testing/+log/57a831388b..7a41b10cc1 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/173d8869cf..3a5a816917 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..096f6b42b5 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/00ade15d94..199485df6c * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/ccc7ba229a..293314acab * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/116022c2e3..c3d86f5268 Clang version changed llvmorg-13-init-14634-gf814cd74:llvmorg-13-init-14732-g8a7b5ebf Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/ccc7ba229ab7e050d8276a442cf1f9ad25c846cc..293314acabd2beeb271e67c1cdd11664db9c2881/scripts/update.py Bug: angleproject:5505 Tbr: timvp@google.com Change-Id: I9d067fac37b5b64d150f646166f357ec9b11b429 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3013455 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 5718b0c9 2021-07-07T16:19:19 Roll vulkan-deps from 6dda7d6b86d6 to cda66075b3f4 (43 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/6dda7d6b86d6..cda66075b3f4 Changed dependencies: * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/9cdeefb5e3..1ae2b58f19 * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/f95c3b3761..ddf3230c14 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/8cc8b6562b..c26baf4c93 * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/37164a5726..0193e158bc * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/8926213dd0..697cc6c387 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/c09be02a36..394157ab51 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC timvp@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: timvp@google.com,ynovikov@google.com Change-Id: Ia0c6220963851caa505ad871b08afbe0639880c5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3010682 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Gert Wollny 4964513a 2021-06-28T20:07:46 ANGLETest: When on WebGL compatibility then use index buffers WebGL actually requires the use of index buffers, otherwise the call is invalid, therefore explicitely request index buffers in the according VertexAttributeOORTest tests. In addition, assert on the indices when the glDrawElements call is captured. With that we can enable VertexAttributeOORTest.* Bug: angleproject:6125 Change-Id: Id3855c78d4c5fcab5599f19dd74ce745d059fb1c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2999523 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Gert Wollny 2c8391b1 2021-06-28T17:53:10 Capture/Replay: Enable passing tests, disable flaky Tests now passing: UnpackAlignmentTest.* UnpackRowLengthTest.* VertexAttributeCachingTest.* ViewportTest.* These tests start to fail when run in the new batch layout triggered by the new passing tests: WebGLCompatibilityTest. DrawElementsBufferOutOfBoundsInIndexBuffer/ DrawElementsBufferOutOfBoundsInVertexBuffer/ ES2_Vulkan_SwiftShader Bug: None Change-Id: I4902f2eca864ca8b371d915c89487943af54bc89 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2987989 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Gert Wollny 68d9f433 2021-06-28T15:39:04 Capture/Replay: capture param of glGetQueryiv Enable TimerQueriesTest.* with that. Add flaky test WebGLCompatibilityTest. DrawElementsBufferOutOfBoundsInVertexBuffer/ ES2_Vulkan_SwiftShader that start to fail because the batches have changed. Bug: angleproject:6114 Bug: angleproject:6136 Change-Id: I91617255a8e3e8783c8e70c17dedd32be421fd66 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2993092 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Gert Wollny 4b464dd4 2021-06-28T14:50:22 tests: Skip WebGL/EnableProgramBinaryExtension with no formats If the extensions is exposed, but the backend doesn't support binary formats, then the part of the tests loading and storing a binary shader are skipped. With that also Capture/Replay of the test is fixed. Bug: angleproject:6112 Change-Id: Iaa25860a9be69207e4dbd6213cf77e75fd87a766 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2993090 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Gert Wollny b3e920e2 2021-06-28T14:32:13 Capture/Replay: don't capture DrawElements with count zero Usually Context::noopDraw would reject calls that doen't draw, but FrameCapture::maybeCaptureDrawElementsClientData seems to be called before Context::noopDraw, and since in ComputeTypedIndexRange we would obtain the illegal range [0,0) (which is actually prohibited by an ssertion "count > 0"), we have to exit early. With that the test can be enabled. Bug: angleproject:6111 Change-Id: I4c242712bd90602f84ad6072b02c3a13a26840f7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2993089 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Trevor David Black 5d314b59 2021-06-01T03:03:22 Fix undefined behavior associated with Runescape Mobile Bug: b/184287970 Change-Id: I5d3baf5e7a8a20c30e1b787b69597110226521d8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2929352 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Geoff Lang 37c5d36f 2021-07-07T13:15:13 GL: Use glClear for robust init on Android. The allowClearForRobustResourceInit was used to work around driver bugs on other Windows and Linux and has a lot of CPU overhead. Re-enable it on Android (except some older Adreno). Bug: chromium:983167 Change-Id: Ibfb4eb4fcdc7310fb6181c57f5c8d7a645ffad9d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3011420 Reviewed-by: Peng Huang <penghuang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Yuly Novikov 396518e0 2021-07-07T15:34:43 Skip SamplerMetadataUpdateOnSetProgram on Mac Metal Blocking vulkan-deps roll. Bug: chromium:1227129 Change-Id: Iaa7f4d18e80b8353dc0be001e1d2e229196f3186 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3010469 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
SeongHwan Park 9f256d10 2021-07-07T02:14:13 D3D11: Fix incorrect bounds checking in Blit11 This could lead to blitting depthStencil buffer incorrectly. Bug: angleproject:6140 Change-Id: I2c5786c0375f8e2fefe862da68929340844ce9ae Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3009736 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Alexis Hetu daa19c0a 2021-07-06T16:19:57 Fix alpha setting of WebGL contexts with SwANGLE on MacOS The emulation of the "alpha: false" setting was done with an RGBA format under the hood, which caused some unexpected results, which included non constant alpha values. Replacing GL_BGRA8_EXT with GL_BGRX8_ANGLEX solves this issue. This was discovered while debugging the following test: conformance/context/context-no-alpha-fbo-with-alpha.html but it may fix many other tests (I will update the expectations file after this fix rolls into Chromium) Bug: chromium:1099960 Change-Id: Ib7b2d352a8e920983d3398de28a8c1dde3b97130 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3010579 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org>
angle-autoroll 19ea3d11 2021-07-07T10:01:00 Roll SwiftShader from 6f1260556b10 to 3c89f07b349b (5 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/6f1260556b10..3c89f07b349b 2021-07-06 srisser@google.com Replace curl command with git-hooks submodule 2021-07-06 capn@google.com Clarify contributing documentation for Windows users 2021-07-06 capn@google.com Fix -Wundefined-var-template warnings for ARM32 and MIPS32 2021-07-06 capn@google.com Define constant static template members as constexpr 2021-07-06 capn@google.com Make Subzero opcode pointer constant If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: I82b48672e7476512422fe79466e7a273e50ca902 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3010757 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 55746d13 2021-07-07T08:09:02 Roll Chromium from 1d5cc5e25281 to 7c193479c917 (278 revisions) https://chromium.googlesource.com/chromium/src.git/+log/1d5cc5e25281..7c193479c917 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/92f8e1efea..04f716686d * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/ae0481e55f..d87a06daa9 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/7ec8dcae8b..57a831388b * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..096f6b42b5 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/081034a4ff..ccc7ba229a * tools/luci-go: git_revision:40f945205c8670537d14901c310374774f589254..git_revision:6808332cfd84a07aeefa906674273fc762510c8c * tools/luci-go: git_revision:40f945205c8670537d14901c310374774f589254..git_revision:6808332cfd84a07aeefa906674273fc762510c8c * tools/luci-go: git_revision:40f945205c8670537d14901c310374774f589254..git_revision:6808332cfd84a07aeefa906674273fc762510c8c * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/02ac209364..95d98b6900 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/2904cc4e6d..116022c2e3 * tools/skia_goldctl/linux: CyXSNty61zPEJfx8gghQIiNd-4sZL4u-Py3wKKiSThcC..gyVsF3sYTmaXRfH5ZxgrkitNlEIMmcqWZBcixfrfJ30C * tools/skia_goldctl/mac: 4ighzAwClyw2f7qzLc7vNBeEyyur8GGNNt7d1d32IvQC..b-Qs2BgADASerBkyWLb2sUtPJBkhTpZQJNAwASkgrmcC * tools/skia_goldctl/win: 9c1KMLUktX61ANQhF4IrBQchPmmj73ZqzJi74TiKn_sC..qrVPZODzWaMfj0T74i2cbqiMzFoqTbUk01Xft2ZTSRMC Clang version changed llvmorg-13-init-14563-gbcaf57ca:llvmorg-13-init-14634-gf814cd74 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/081034a4ff0462c46b9261be81de77562d19936e..ccc7ba229ab7e050d8276a442cf1f9ad25c846cc/scripts/update.py Bug: None Tbr: timvp@google.com Change-Id: I76274f4412baf19a183d894ba4a6390ebfbd738b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3010680 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill 51937ab3 2021-06-25T09:10:42 Re-land "Add SearchType to OpenSharedLibraryWithExtension." This fixes a bug in SystemInfo_vulkan where we were using the System search path for the Vulkan loader when we prefer using the custom ANGLE loader. Re-land fixes a bug where we would try to load the custom libVulkan on Android and other platforms where we should be using the system version. Bug: chromium:1219969 Change-Id: I34b592fb87cbddfd02c837a17942cac54c85d9d1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3007265 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi cfaaf2ab 2021-06-30T17:23:55 Vulkan: SPIR-V Gen: Fixes to std430 block definition Bug: angleproject:4889 Change-Id: I18feff0916f348c8514cc97ba438d42fc00d0cba Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2999023 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Takuto Ikuta d91af7b8 2021-07-06T12:17:33 infra/config: remove unused isolated property angle is migrated to RBE-CAS from isolate. Bug: chromium:1224266 Change-Id: Id2ca778edf6b34f5241da0fbfcd86b43941f83b0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3007600 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 7455507e 2021-07-06T10:01:00 Roll SwiftShader from 69deca60e70d to 6f1260556b10 (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/69deca60e70d..6f1260556b10 2021-07-05 capn@google.com Fix -Wundefined-var-template warnings 2021-07-05 capn@google.com Regres: Increase MaxProcMemory to 6 GiB If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: I3b7d0c7922b5b7cf5ec55765185b5e3a1be48b47 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3007076 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b6f0faa8 2021-07-06T07:01:02 Roll Chromium from 38c67803c283 to 1d5cc5e25281 (194 revisions) https://chromium.googlesource.com/chromium/src.git/+log/38c67803c283..1d5cc5e25281 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/6f773f2fd2..92f8e1efea * buildtools/linux64: git_revision:4d207c94eab41f09c9a8505eb47f3d2919e47943..git_revision:31f2bba8aafa8015ca5761100a21f17c2d741062 * buildtools/mac: git_revision:4d207c94eab41f09c9a8505eb47f3d2919e47943..git_revision:31f2bba8aafa8015ca5761100a21f17c2d741062 * buildtools/win: git_revision:4d207c94eab41f09c9a8505eb47f3d2919e47943..git_revision:31f2bba8aafa8015ca5761100a21f17c2d741062 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/537028df55..7ec8dcae8b * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..de5768d311 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/e1e56a5807..081034a4ff * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/8eae38b597..2904cc4e6d Clang version changed llvmorg-13-init-14086-ge1b8fde1:llvmorg-13-init-14563-gbcaf57ca Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/e1e56a58075d9d3ee55a86be0ed2e87be317968a..081034a4ff0462c46b9261be81de77562d19936e/scripts/update.py Bug: None Tbr: timvp@google.com Change-Id: I7f8f56e0672cf2bc5973d983ffef0309e9b96d4c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3007567 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 3b0fcf6a 2021-06-30T15:14:48 Vulkan: SPIR-V Gen: Support type casts in constructors GLSL basic, vector and matrix constructors can convert between types. This was already done for constants used in constructors. This change implements the cast for non-constant expressions. Bug: angleproject:4889 Change-Id: I0a8c1a6e97ffced0d1652032a41fb87c70be16ca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2999022 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 0fa2e7f9 2021-07-06T02:09:20 Roll vulkan-deps from e0136f0880da to 6dda7d6b86d6 (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/e0136f0880da..6dda7d6b86d6 Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/e065c482c6..8cc8b6562b * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/16266c3883..c09be02a36 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC timvp@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: timvp@google.com,ynovikov@google.com Change-Id: I8e1e0ec1d35000dffa33c8bb59835f8b6911458a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3006477 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov f8d5d5ed 2021-07-05T21:11:23 Revert "Add SearchType to OpenSharedLibraryWithExtension." This reverts commit 18e99f4a2b37468b103da4a56c5b0fff25458062. Reason for revert: breaks Mac, e.g. https://ci.chromium.org/ui/p/chromium/builders/ci/mac-arm64-rel-tests/2197/overview Original change's description: > Add SearchType to OpenSharedLibraryWithExtension. > > This fixes a bug in SystemInfo_vulkan where we were using the > System search path for the Vulkan loader when we prefer using the > custom ANGLE loader. > > Bug: chromium:1219969 > Change-Id: Iedf0fd11fe9ed8cc020b445ea9e12a7936937361 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2988791 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Jamie Madill <jmadill@chromium.org> Bug: chromium:1219969, chromium:1225040, chromium:1226675 Change-Id: I7a7e329181b69b0fb546e5245d8842723077126f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3006320 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov 0beafe86 2021-07-05T16:12:10 Ignore VUID-VkSpecializationMapEntry-constantID-00776 New check added in https://github.com/KhronosGroup/Vulkan-ValidationLayers/pull/2903 Blocks VVL rolls. Bug: chromium:1226682 Change-Id: Iaf12187c33a0c3736acae6e772277dbe6aa4c402 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3007137 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi 0461d8d4 2021-06-23T23:20:33 Vulkan: SPIR-V Gen: texture and image built-ins GLSL contains a large number of built-in texture* and image* functions, but these map to only a handful of SPIR-V instructions. The bulk of the work to map these is to extract the arguments from the built-ins based on their ordinal position. Bug: angleproject:4889 Change-Id: I760d986bd9171ddde35f9f046c549ca53252df17 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2992980 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill d665593b 2021-07-05T15:02:11 Update TextureState::getEnabledLevelCount. Instead of simply returning a count of all non-empty texture desc levels, we iterate the levels from the base level and return the count of levels that make a consistent mip chain. This will fix edge cases where Textures are defined sequentially with inconsistent mip levels, but valid rendering states. Bug: angleproject:4780 Change-Id: Id3ebf2d7ad706070896cb5cdf2a311dba2c88949 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3007135 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 955b4620 2021-07-01T22:55:59 Fix angle_commit.h dependency when git packs refs If there are too many files in .git/refs/heads/, git packs them in .git/packed-refs. This breaks the build as gen/angle/angle_commit.h depends on .git/refs/heads/<branch-name>. With this change, when gn is run and the dependency to this file is set up, it's unpacked from .git/packed-refs if it's missing from .git/refs/heads/. One corner case not solved by this change is if a commit is amended with no changes and git packs the refs (and so the .git/refs/heads/<branch-name> file goes away), ninja doesn't rerun gn as it doesn't believe there to be any changes, yet fails the build as the dependency is now missing. Running `gn gen` manually fixes the issue. The issue is automatically fixed when switching branches. Bug: angleproject:6131 Change-Id: Ie2404e874a5cb3374a652b93faa143acb68eaa19 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3001906 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 73792a63 2021-07-05T09:38:02 Roll Chromium from 3406cb648bea to 38c67803c283 (515 revisions) https://chromium.googlesource.com/chromium/src.git/+log/3406cb648bea..38c67803c283 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/765bbc94ea..6f773f2fd2 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/aa6d8cbd3e..537028df55 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..de5768d311 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/5633839bd5..e1e56a5807 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/43c036ca86..02ac209364 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/1e130552d4..8eae38b597 * tools/skia_goldctl/linux: yGEFrRQrT0GK0GqIKxNRbT092eKdKLQsfsDEAeHNUz0C..CyXSNty61zPEJfx8gghQIiNd-4sZL4u-Py3wKKiSThcC No update to Clang. Bug: None Tbr: ianelliott@google.com Change-Id: Ia86ec18356af1df6d62e1af39eb65ce1a48de888 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3005676 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 236fe4ad 2021-07-05T10:01:00 Roll SwiftShader from 314508f788b2 to 69deca60e70d (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/314508f788b2..69deca60e70d 2021-07-02 jerumble@gmail.com Fix gcc < 9 builds If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: I7f4fa82dd6ddc347472553d6cc26d8d00f931ce6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3005639 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Peter Kasting 1bffabe8 2021-06-29T18:13:39 Fix -Wunreachable-code-aggressive. Bug: chromium:1066980 Change-Id: I1fa08a40dbf223d60a10681af33ca8a29b12bf8b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2991094 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Gert Wollny 16c993c3 2021-06-24T12:03:03 Capture/Replay: Only capture initialized renderbuffer content Enable the DepthStencilTest.* that was failing before. Bug: angleproject:6094 Change-Id: I8c69de4927c0e70143cd632e97f0abdb740a013f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2982550 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
angle-autoroll e78b1bf1 2021-07-02T10:19:48 Roll VK-GL-CTS from 5e375439542a to 875c981f4c59 (9 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/5e375439542a..875c981f4c59 2021-07-01 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/master 2021-07-01 michal.jakubek@mobica.com Handle vkGetDeviceAccelerationStructureCompabilityKHR function. 2021-07-01 gleese@broadcom.com Drop subgroup size requirement for uniform control 2021-07-01 siglesias@igalia.com Check support for triangle fan primitive topology on rasterization tests 2021-07-01 boris.zanin@mobica.com Revert initial layout for depth/stencil attachment in makeRenderPass 2021-07-01 antto.makinen@siru.fi Add a batch of GraphicsFuzz coverage tests 2021-07-01 piotr.byszewski@mobica.com Fix compilation issue in float_controls 2021-07-01 jari.komppa@siru.fi Add sample decorator to interpolation tests 2021-06-30 jajones@nvidia.com Add VK_EXT_device_drm_properties tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC geofflang@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com,angle-bots+autoroll-info@google.com Change-Id: I2cc99b941a040358a98a0ad3e2eefef4ad2b55b7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3003322 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 5d8f7a02 2021-07-02T10:01:00 Roll SwiftShader from 1231b445b902 to 314508f788b2 (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/1231b445b902..314508f788b2 2021-07-01 capn@google.com Work around MemorySanitizer false-positive 2021-07-01 cwallez@google.com Increase max workgroup size for WebGPU If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: Id3965897c2cccf191cb5f9ec8cf3a7da468c1442 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3003065 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 91d048f9 2021-07-02T07:01:33 Roll Chromium from 69ddea72a93b to 3406cb648bea (368 revisions) https://chromium.googlesource.com/chromium/src.git/+log/69ddea72a93b..3406cb648bea If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/fde1df76f6..765bbc94ea * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/d46361bc7b..ae0481e55f * testing: https://chromium.googlesource.com/chromium/src/testing/+log/a0672af08c..aa6d8cbd3e * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..36f311b034 * tools/luci-go: git_revision:e20098f56b10587e3cc0bc9ccac4934a13158de3..git_revision:40f945205c8670537d14901c310374774f589254 * tools/luci-go: git_revision:e20098f56b10587e3cc0bc9ccac4934a13158de3..git_revision:40f945205c8670537d14901c310374774f589254 * tools/luci-go: git_revision:e20098f56b10587e3cc0bc9ccac4934a13158de3..git_revision:40f945205c8670537d14901c310374774f589254 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/4a2cc422b8..43c036ca86 * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/84ad259424..7235d59a2b * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/15547a6864..1e130552d4 * tools/skia_goldctl/mac: X-Gty06U_OR4SINwPASbahacEQPOSfbsvTEOGR3R5mUC..4ighzAwClyw2f7qzLc7vNBeEyyur8GGNNt7d1d32IvQC * tools/skia_goldctl/win: hbz09RIw2GLrYnSdrOxyXjIwJxp5hXG2qxyaEPT1D-YC..9c1KMLUktX61ANQhF4IrBQchPmmj73ZqzJi74TiKn_sC No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: Iffe56c66b6bf28c8f0fbc7dfbdecece355214815 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3002942 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 4a3fc4b5 2021-07-01T10:01:00 Roll SwiftShader from 9c5d0d73e2f3 to 1231b445b902 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/9c5d0d73e2f3..1231b445b902 2021-06-30 capn@google.com Disable the legacy OpenGL ES targets for Android If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: Ida7b22caf5bf122b11e5ff27afda96936dd0b50a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3000014 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 9f99de9d 2021-07-01T07:04:02 Roll Chromium from 20cc6c3bb504 to 69ddea72a93b (424 revisions) https://chromium.googlesource.com/chromium/src.git/+log/20cc6c3bb504..69ddea72a93b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/28cc786905..fde1df76f6 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/e6d9961216..a0672af08c * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/a38974fc98..173d8869cf * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/5764d6acf7..329436118b * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..949bca87e0 * tools/luci-go: git_revision:ede472114f4e51eaa068cd84cadcf470773f19ef..git_revision:e20098f56b10587e3cc0bc9ccac4934a13158de3 * tools/luci-go: git_revision:ede472114f4e51eaa068cd84cadcf470773f19ef..git_revision:e20098f56b10587e3cc0bc9ccac4934a13158de3 * tools/luci-go: git_revision:ede472114f4e51eaa068cd84cadcf470773f19ef..git_revision:e20098f56b10587e3cc0bc9ccac4934a13158de3 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/709694a7a0..4a2cc422b8 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/9361ecc481..15547a6864 No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: Ic9ee180399ae53ad526c588d928ce25613c39119 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2999409 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gert Wollny dba2e136 2021-05-13T20:33:46 Capture/Replay: Emit InitializeReplay() late Only emit InitializeReplay() after all captured frames have been run, so that the readBufferSize and the maxClientArraySize are really sufficiently large for all frames. To achieve this a layer of indirection is added, that is because InitializeReplay() has to be called from SetupFrame() which is still emitted with the first frame, a new function InitReplay() is added. The call to this function is emitted with the first frame, buts its body is emitted after the last frame has been captured. Bug: angleproject:5965 Change-Id: Ic38791b4c02989594ec87d1ba3f031fd81471314 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2940841 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Matthias Lederhofer 824e56f2 2021-06-30T17:12:19 Fix markdown link Bug: None Change-Id: Id6ebeb0c768d494f19d6619d68cdaf5ee18e981d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2997303 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
angle-autoroll e9757dd6 2021-06-30T12:58:15 Roll VK-GL-CTS from 9fa02d6ab07f to 5e375439542a (4 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/9fa02d6ab07f..5e375439542a 2021-06-30 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/master 2021-06-30 alexander.galazin@arm.com Merge vk-gl-cts/opengl-cts-4.6.1 into vk-gl-cts/master 2021-06-30 gleese@broadcom.com Add uniform control flow extension to allowed list 2021-06-29 rgarcia@igalia.com Add VK_EXT_multi_draw tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC geofflang@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com,angle-bots+autoroll-info@google.com Change-Id: I68376eaedfd7c4b246073005241b834273ddc6f9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2993641 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi d6202fce 2021-06-28T16:53:45 Vulkan: Disable GL_KHR_texture_compression_astc_sliced_3d 3D ASTC formats are not supported in Vulkan, sliced or not. The non-sliced extension is already disabled, and this change disables the sliced version. Bug: angleproject:6038 Change-Id: I055838345ccb8ad77fe4c05e65dd8b10a8a4d36b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2993459 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 790004db 2021-06-30T10:01:13 Roll SwiftShader from a3726e06b4f1 to 9c5d0d73e2f3 (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/a3726e06b4f1..9c5d0d73e2f3 2021-06-29 capn@google.com Fix Android Vulkan build 2021-06-29 capn@google.com Implement Pragma() for Reactor MemorySanitizer instrumentation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: Ia32974617f216ce50bb520efb0643c73fbf0f1bf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2996342 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll ceb92d21 2021-06-30T07:01:11 Roll Chromium from 1078c63704e4 to 20cc6c3bb504 (842 revisions) https://chromium.googlesource.com/chromium/src.git/+log/1078c63704e4..20cc6c3bb504 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/9211e71997..28cc786905 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/82a4d60220..fd3f3c1998 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/79a2e924d9..8fa8794677 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/bf260ac892..d46361bc7b * testing: https://chromium.googlesource.com/chromium/src/testing/+log/dffb539454..e6d9961216 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/dc7751ee11..a38974fc98 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/ba4a77b238..5764d6acf7 * third_party/android_platform: https://chromium.googlesource.com/chromium/src/third_party/android_platform/+log/fdaa5e5b9f..b291e88d8e * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..2bc697bc64 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2a6dffaf4b..a806594b95 * third_party/jinja2: https://chromium.googlesource.com/chromium/src/third_party/jinja2/+log/6906af9d94..7c54c1f227 * third_party/markupsafe: https://chromium.googlesource.com/chromium/src/third_party/markupsafe/+log/0944e71f4b..1b882ef637 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/6274a5523a..5633839bd5 * tools/luci-go: git_revision:8ed83b4afa51020c8900d121bb57624b35882dec..git_revision:ede472114f4e51eaa068cd84cadcf470773f19ef * tools/luci-go: git_revision:8ed83b4afa51020c8900d121bb57624b35882dec..git_revision:ede472114f4e51eaa068cd84cadcf470773f19ef * tools/luci-go: git_revision:8ed83b4afa51020c8900d121bb57624b35882dec..git_revision:ede472114f4e51eaa068cd84cadcf470773f19ef * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/200428d9fe..709694a7a0 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/b08c62ecda..9361ecc481 * tools/skia_goldctl/linux: UdQNElAXaCXfe2mgtDvG-3qVDSF8BDcA3wN2gDEFUjgC..yGEFrRQrT0GK0GqIKxNRbT092eKdKLQsfsDEAeHNUz0C * tools/skia_goldctl/mac: dukW3C-pL5BBIPLAczaYnnXruUL-y4BAWG28KyiLl-0C..X-Gty06U_OR4SINwPASbahacEQPOSfbsvTEOGR3R5mUC * tools/skia_goldctl/win: lgJKP9M_eCaX9oj-mmbEPdV27wkXYV_GtjD9My6G5TkC..hbz09RIw2GLrYnSdrOxyXjIwJxp5hXG2qxyaEPT1D-YC Clang version changed llvmorg-13-init-13925-g0f24ffcd:llvmorg-13-init-14086-ge1b8fde1 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/6274a5523af83afe7762ab96d383f50109376fe7..5633839bd5ef2dd9a19e8fc547447d04f832c698/scripts/update.py Bug: None Tbr: geofflang@google.com Change-Id: Iff927524aff04aa541ef24872bd69d27093c871a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2995721 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop a8959a9b 2021-06-29T21:23:21 Tests: Add Toon Blast trace Test: angle_project --gtest_filter="*toon_blast*" Tbr: jmadill@google.com, timvp@google.com Bug: b/192408760 Bug: angleproject:6121 Change-Id: Id301c48921a24164d4dccd7d53c1a4e51a0795ce Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2993753 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi dc59772e 2021-06-22T22:37:26 Vulkan: SPIR-V Gen: Support switch With the infrastructure to support this in place, switch is simply implemented as a conditional with multiple blocks. Each block either ends with a branch to the merge block or the next block, implementing fallthrough. Bug: angleproject:4889 Change-Id: I5831531d918ac06648cced7707d1d48ffeb6b1b0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2983559 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi a8c9cecf 2021-06-12T00:12:34 Vulkan: SPIR-V Gen: Support break and continue This is simply done by issuing a branch to the merge or continue blocks respectively. Bug: angleproject:4889 Change-Id: I3e96a3b0f1a0533aa4eac519ab64a87600c0983b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2957810 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Cody Northrop e45682b4 2021-06-29T17:55:36 Tests: Add Township trace Test: angle_perftests --gtest_filter="*township*" Tbr: jmadill@google.com, timvp@google.com Bug: b/192402770 Bug: angleproject:6120 Change-Id: I3ef0bb6e896a081c17a07f18037805be5494af2e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2993882 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop 1c39335a 2021-06-29T16:40:43 Tests: Add Farm Heroes Saga trace Test: angle_perftests --gtest_filter="*farm_heroes_saga*" Tbr: jmadill@google.com, timvp@google.com Bug: b/192395241 Bug: angleproject:6119 Change-Id: Iebec311e37e5f84ad85e5a77aa36b3cffb55d2e4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2995383 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Tim Van Patten a09052ea 2021-06-29T16:18:15 generate_android_bp.py: Don't include buildtools/third_party/libc++/ The buildtools/ directory is not included in the AOSP version of ANGLE and is unnecessary, so update generate_android_bp.py to filter out that include directory. Bug: b/187342779 Change-Id: I3a2d0506ac53f7d369597c797fffb211ffde41f1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2995382 Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Tim Van Patten <timvp@google.com>
Jamie Madill ec8cdd5d 2021-06-28T15:59:38 infra: Add perf tests to Android/Linux/Mac. These use the same config as the previous perf bots. Bug: angleproject:6090 Change-Id: I0ed4bc32cdc5b27f1fbd00fded1fa8d2ccbe45d9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2993458 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 69c2d820 2021-06-29T11:58:41 Perf Tests: Register trace tests programatically. Using testing::RegisterTests lets us filter out the disabled configs. This helps sharding the tests because some shards were getting a very uneven distribution of real tests vs skipped tests. A couple shards were running 20 minutes, while most were about 6 minutes. More work might be needed to even that out. Bug: angleproject:6090 Change-Id: Ibdf35677cfea86dfc374a2b18bb57cd9f289ddee Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2994726 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Lubosz Sarnecki dcfde515 2021-06-24T15:59:04 gl.xml: Add GL_FRAMEBUFFER_SRGB_EXT to EnableCap group. Add GL_EXT_sRGB_write_control in registry_xml.py. This makes FrameCapture write a GL_FRAMEBUFFER_SRGB_EXT enum instead of it's hex value in glEnable/Disable calls. Bug: angleproject:5857 Change-Id: Ifa01118c2958275c7623c6bfe29f015fa8875fce Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2988356 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Peter Kasting d2816b4e 2021-06-25T14:52:02 Fix a -Wdeprecated-copy warning. Bug: chromium:1221591 Change-Id: Idbbb4aa16e58a9f4e7e25590667cf15706233de4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2989632 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll 04f775a8 2021-06-29T11:51:16 Roll VK-GL-CTS from 7329723d8103 to 9fa02d6ab07f (21 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/7329723d8103..9fa02d6ab07f 2021-06-29 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/master 2021-06-29 alexander.galazin@arm.com Update extension dependencies 2021-06-29 siglesias@igalia.com Improve existing cull distance tests 2021-06-29 siglesias@igalia.com Add tests checking Input and Resolve attachments can be the same attachment in a subpass 2021-06-29 rgarcia@igalia.com Fix 64-bit atomics mandatory feature checks 2021-06-29 jason.ekstrand@intel.com Fix tessellation SPIR-V tests use of Restrict 2021-06-29 gleese@broadcom.com Fix buffer copy extents in blit tests 2021-06-29 alexander.galazin@arm.com Allow the use of the standard types 2021-06-29 slawomir.cygan@intel.com Allocate memory for reference buffer 2021-06-29 gleese@broadcom.com Fix YCbCr linear filtering support check 2021-06-29 gleese@broadcom.com Don't run _concurrent sync tests on 1 queue devices 2021-06-29 gleese@broadcom.com Fix stage flags for INPUT_ATTACHMENT descriptors 2021-06-29 gleese@broadcom.com Remove spurious feature dependencies in 1.2 tests 2021-06-29 gleese@broadcom.com Fix feature dependency in vulkan1.2 test 2021-06-29 gleese@broadcom.com Fix image aspect handling in fragdepth tests 2021-06-29 gleese@broadcom.com Fix output components limit in fragment input tests 2021-06-28 alexander.galazin@arm.com Update Vulkan headers 2021-06-21 alexander.galazin@arm.com Update Vulkan headers 2021-06-18 rgarcia@igalia.com Check shader image atomic mandatory features 2021-06-18 antto.makinen@siru.fi Add a batch of GraphicsFuzz coverage tests 2021-06-18 siglesias@igalia.com Add timestamp query test variants with availability bit If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC geofflang@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com,angle-bots+autoroll-info@google.com Change-Id: If61a0d74e30a5292d8ac95751fa7a9095b2b30f6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2994440 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill 72c8d46d 2021-06-29T08:05:11 infra: Build traces on perf bots. This is necessary to ensure they run the trace tests in perf. Bug: angleproject:6090 Change-Id: Ib96418c4371f700dbbd54933241b1b88912f9938 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2991903 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll afe4a824 2021-06-29T10:01:13 Roll SwiftShader from e4fea30bb438 to a3726e06b4f1 (7 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/e4fea30bb438..a3726e06b4f1 2021-06-29 cwallez@google.com Increase limits to support base WebGPU. 2021-06-28 bclayton@google.com SpirvShader: Consider OpEntryPoint interface IDs 2021-06-28 capn@google.com Determine MSan instrumentation for Reactor at run-time 2021-06-28 stha09@googlemail.com GCC: readd visibility attributes for EGL/GLESv2 2021-06-28 capn@google.com Fix -warn-stack-size command line option for LLVM 12 2021-06-28 sugoi@google.com Only perform LOD computation when it is necessary 2021-06-28 swiftshader.regress@gmail.com Regres: Update test lists @ e4fea30b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I992e37df1bbd0be9fef2a998bf2584adf2459480 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2990981 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gert Wollny c14e6b5f 2021-06-28T15:22:44 Capture/Replay: enable some more passing tests Test: PixmapTest.Clearing/* StateChangeRenderTest.GenerateMipmap/ SyncQueriesTest.Basic/ES2_Vulkan SyncQueriesTest.Validation/ES2_Vulkan TextureLimitsTest.MaxCombinedTextures/ Bug: None Change-Id: I3d3f36551b42ae24332d441c49f8a66f4df7d9a9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2993091 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Gert Wollny 130d1987 2021-06-28T14:24:15 Capture/Replay: enable passing WebGLCompatibilityTest tests Bug: None Change-Id: I9b894e49766c8b840fc58470bd42f466bc138796 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2988688 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Gert Wollny 65a94128 2021-05-21T15:18:39 Capture/Replay: enable IndexBufferOffsetTest.* tests With robustResourceInit in place we can enable the the tests. Bug: angleproject:5974 Change-Id: I53911ebf9aed1ef537ebf4c539eca7b284a17e98 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2912676 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Gert Wollny e793a027 2021-06-28T11:17:01 Capture/Replay: Capture TexSubImage2DRobustAngle, enable tests The tests RobustClientMemoryTest.* now all pass. Bug: angleproject:6108 Change-Id: I980c1fd9e065cb5c4ed575770f86e09faeb19d4c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2988685 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Gert Wollny 433e3921 2021-06-28T10:39:41 Capture/Replay: enable passing UniformTest.Sampler/* Bug: None Change-Id: Ib32e27ea7c767e1251f18f6e8e7fb80289110e9f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2988683 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Cody Northrop e70c21f4 2021-06-28T09:27:36 Tests: Add Beach Buggy Racing trace Test: angle_perftests --gtest_filter="*beach_buggy_racing*" Tbr: timvp@google.com, jmadill@google.com Bug: b/192237726 Bug: angleproject:6113 Change-Id: I16fa42bd1af632daf90f857c453e70218225b4f0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2992574 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Tim Van Patten 0b5f268a 2021-06-28T13:03:46 Fixes and updates to roll_aosp.sh 1.) Remove unused zlib contrib/ directories - There are missing licenses in third_party/zlib/contrib/, so remove the unused directories from the AOSP checkin. 2.) `git add` all third_party/ changes - All of the unused third_party/ changes have been manually merged, so we can now automatically add any changes to third_party/. Bug: b/191882454 Bug: b/187342779 Change-Id: If209ff3bb34ad53c08f431a06a2f84d153181e45 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2992578 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
Jamie Madill a25f0f2c 2021-06-28T14:56:26 Suppress flaky TSAN TLS false positive. Introduces "ANGLE_NO_SANITIZE_THREAD" which works the same way as "ANGLE_NO_SANITIZE_MEMORY". Bug: chromium:1223970 Change-Id: I9409771f7c4748bbc186da3fc38031d3b1d1e4d8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2987875 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Gert Wollny 8513e538 2021-06-28T10:38:03 Capture/Replay: enable passing DrawBuffersTest.* Bug: None Change-Id: Ib857194d701372322ebf458bf00ac9aa681c079a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2988682 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Cody Northrop 3fa51867 2021-06-28T07:44:45 Capture/Replay: Disable GL_OES_depth32 during capture Depth32 is not a renderable format on native mobile GLES drivers. Disabling GL_OES_depth32 during capture provides a more portable trace. Apps fall back to Depth24, i.e.: glRenderbufferStorage(GL_RENDERBUFFER, GL_DEPTH_COMPONENT32, 760, 360); Becomes: glRenderbufferStorage(GL_RENDERBUFFER, GL_DEPTH_COMPONENT24, 760, 360); Test: Beach Buggy Racing MEC Bug: b/192237726 Bug: angleproject:6113 Change-Id: Id188ca0186c67d2584f8ad7070cdc8c9baaf2aaa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2992573 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Peng Huang 5a2bd6fd 2021-05-03T14:43:35 Disable shader cache for PowerVR Rogue GPUs. We disable shader cache for Validating decoder in chrome, so port this workaround into ANGLE to see if it can fix crbug.com/1203652. Bug: chromium:1203652,chromium:480992 Change-Id: I08611c148217abc9c32d11fefe8a7d15873f3b30 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2867269 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Mohan Maiya e2881e25 2021-06-27T10:45:41 Vulkan: Handle incompatible pipeline layouts It is necessary that a pipeline layout be compatible with active textures. Make sure to recreate the pipeline layout otherwise. Bug: b/155487768 Bug: angleproject:5033 Bug: angleproject:5773 Test: ImageTest.SourceAHBTarget2DExternalCycleThroughRgbAndYuvTargets*Vulkan Change-Id: Iab371a9035b6cd143585e5000e2e68c7302ef447 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2992056 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 5f869b74 2021-06-28T18:02:42 Revert "Vulkan: Load custom Vk Loader." This reverts commit e6e99c5472d2fe9beaa12840fa4a71191667b9a4. Reason for revert: Seems to be flaking on linux-clang-rel: https://ci.chromium.org/ui/p/angle/builders/try/linux-clang-rel/22602/overview Original change's description: > Vulkan: Load custom Vk Loader. > > Uses a GN copy rule to duplicate the loader. Also updates volk to > load using the new custom loader. Once both are in place we can > go back and remove the copy. > > Bug: chromium:1219969 > Change-Id: I8c48d168a842539f7cdba1ebfdaf3b08c3e1990d > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2982499 > Commit-Queue: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Geoff Lang <geofflang@chromium.org> > Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Bug: chromium:1219969 Change-Id: Ib29014e728c1ce63c5e5bf7136ce19de7692964d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2987874 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Gert Wollny 3d8d1b77 2021-06-28T10:35:42 Capture/Replay: enable passing OcclusionQueriesTest.* Bug: None Change-Id: I445ff7a25a7e91663a61e1cd4d32861497140055 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2988681 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Cody Northrop aec47ff6 2021-06-22T15:47:43 Capture/Replay: Update CopyImageSubData params The parameters to glCopyImageSubData are flexible and can take a TextureID or a RenderbufferID as a GLuint. Our replay needs to remap those values, so we'll convert the GLuint based on the target. This leads to a change like the following. Before: glCopyImageSubData(138, 0x0DE1, 0, 0, 0, 0, 642, 0x0DE1, 1, 0, 0, 0, 256, 256, 1); After: glCopyImageSubData(gTextureMap[138], 0x0DE1, 0, 0, 0, 0, gTextureMap[642], 0x0DE1, 1, 0, 0, 0, 256, 256, 1); Test: PUBG Mobile MEC Bug: angleproject:6087 Bug: angleproject:6104 Change-Id: I5cd422e41ffbb4f08c8909e520bdce63e3008c5a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2981464 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Gert Wollny 5fb6baef 2021-06-28T10:33:28 Capture/Replay: enable passing IndexedPointsTest* tests Bug: None Change-Id: Ie4f5c50985c5c3e403e0be8e806e461572b04e42 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2988680 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Gert Wollny dbc7cb5a 2021-06-11T14:38:42 Capture/Replay: capture GetMaterialfv parameters Enable according tests Bug: angleproject:6052 Change-Id: I67bc4d74c997afecf9ed16c7af217de273557587 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2954265 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Shahbaz Youssefi 153240b2 2021-06-11T16:36:32 Vulkan: SPIR-V Gen: Support loops Loops are similar to if-else in that they generate a number of blocks where the first block specifies divergence (OpLoopMerge) and the merge block. Differently from if-else, there is a block where the condition is evaluated and a block which `continue;` leads to (this last block is the only one allowed to back-jump to the beginning of the loop). Bug: angleproject:4889 Change-Id: Ic59f4bf3e05fbf93cb5af85acd3bc4b0da8412af Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2957809 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Gert Wollny 8cf6d8cc 2021-06-28T10:00:54 Capture/Replay: Handle Gen/Delete Semaphores and fix map emit Add capturing of the handles used in GenSemaphores and DeleteSemaphore, fix the emission of the gSemaphoreMap. and enable capture/replay tests. Change-Id: Iabb88bd1d6c22c08271d0883607efb72de9d3d0c Bug: angleproject:6107 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2988679 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Jamie Madill e6e99c54 2021-06-23T08:25:58 Vulkan: Load custom Vk Loader. Uses a GN copy rule to duplicate the loader. Also updates volk to load using the new custom loader. Once both are in place we can go back and remove the copy. Bug: chromium:1219969 Change-Id: I8c48d168a842539f7cdba1ebfdaf3b08c3e1990d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2982499 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Jamie Madill 18e99f4a 2021-06-25T09:10:42 Add SearchType to OpenSharedLibraryWithExtension. This fixes a bug in SystemInfo_vulkan where we were using the System search path for the Vulkan loader when we prefer using the custom ANGLE loader. Bug: chromium:1219969 Change-Id: Iedf0fd11fe9ed8cc020b445ea9e12a7936937361 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2988791 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 971ba359 2021-06-23T16:45:33 Add angle::BitMask for creating bit masks angle::BitMask(n) implements the common pattern of angle::Bit(n)-1. Bug: angleproject:6048 Change-Id: Icd56ef1504804add59d0804a7249b3035c96f9c2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2984099 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Gert Wollny 27e9883b 2021-06-22T12:20:08 Capture/Replay: Limit number of compile processes based on load When replaying, for each batch a limited number of compile processes is launched, but no all-over limit is set, so that on computers with a low processor count and/or limited working memory the machine may become un-responsive. Therefore, tell ninja to not spawn new processes when the load is larger than the number of available processors. Bug: angleproject:6078 Change-Id: I9982a139ef2346d0cf25fbd510c7aff038e48071 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2976658 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Jamie Madill da523f6b 2021-06-25T17:25:24 Trace Tests: Use hermetic depot_tools. We no longer need to use the depot_tools in the system path. Bug: angleproject:6102 Change-Id: I6772ceeb4c61e686d15b2638fb4348e93179e321 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2989671 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll b13cb48d 2021-06-28T10:01:38 Roll SwiftShader from 8f075627d16b to e4fea30bb438 (3 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/8f075627d16b..e4fea30bb438 2021-06-25 pkasting@chromium.org Fix -Wloop-analysis warnings in llvm-subzero. 2021-06-25 capn@google.com Enable the -Wdeprecated-copy compiler warning 2021-06-25 capn@google.com Prevent changing Reference<> address If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: Ifdf575c73d1c13cac92efe7d302ec792faa120b3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2992690 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gert Wollny f8d2c429 2021-06-24T11:22:59 Capture/Replay: Add test to capture an uninitialized buffer Handle the serialization in case the buffer is not yet set up. Bug: angleproject:6093 Change-Id: I06a8e15d181c4ec514a334f952ce29a4026970a6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2982549 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
angle-autoroll e72bdb4f 2021-06-28T07:01:45 Roll Chromium from 94cea2515faf to 1078c63704e4 (468 revisions) https://chromium.googlesource.com/chromium/src.git/+log/94cea2515faf..1078c63704e4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/710d444030..9211e71997 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/46bcd59544..82a4d60220 * buildtools/linux64: git_revision:d924640c25f9d90386716116a53957f24d709042..git_revision:4d207c94eab41f09c9a8505eb47f3d2919e47943 * buildtools/mac: git_revision:d924640c25f9d90386716116a53957f24d709042..git_revision:4d207c94eab41f09c9a8505eb47f3d2919e47943 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/8fa8794677..79a2e924d9 * buildtools/win: git_revision:d924640c25f9d90386716116a53957f24d709042..git_revision:4d207c94eab41f09c9a8505eb47f3d2919e47943 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/30b38aa65f..dffb539454 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/33e2b30b78..ba4a77b238 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..11a2ddfb3e * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6f0df68e8b..2a6dffaf4b * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/8415fd8519..6274a5523a * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/ff3ba154c1..200428d9fe * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/f8baec67b7..b08c62ecda Clang version changed llvmorg-13-init-13689-g93938943:llvmorg-13-init-13925-g0f24ffcd Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/8415fd8519d19a25ef5d5df132d9a3722409c36d..6274a5523af83afe7762ab96d383f50109376fe7/scripts/update.py Bug: None Tbr: jonahr@google.com Change-Id: Ie93aab2b5ebb5000fd7d44a2e09b76b8b0685756 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2992012 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gert Wollny e833128d 2021-06-24T11:20:53 Capture/Replay: Enable BufferDataTests.* With the robustResourceInit in place these tests now pass. Bug: angleproject:5973 Change-Id: I7b5fd991b86ede8cf85cc298d61a60d86ef07bc9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2982548 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Gert Wollny 52c47e94 2021-06-24T11:02:59 Capture/Replay: SimpleOperationTest.* pass now With robustResourceInit and the hadling of the serialization of uninitialized attachments these tests pass now. Bug: None Change-Id: I86af69f7e928d32570fde90b106e34d21617f0f8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2982547 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Cody Northrop 8767ec15 2021-06-27T19:28:28 Tests: Add Bricks Breaker Quest trace Test: angle_perftests --gtest_filter="*bricks_breaker_quest*" Tbr: jmadill@google.com, timvp@google.com Bug: b/192195614 Bug: angleproject:6106 Change-Id: I5301256c34d2552f1107e5718acb2faa09576fc2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2991680 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop a84ec2cf 2021-06-25T16:06:13 Tests: Add Mario Kart Tour trace Test: angle_perftests --gtest_filter="*mario_kart_tour*" Tbr: jmadill@google.com, timvp@google.com Bug: b/192102888 Bug: angleproject:6103 Change-Id: I7b96d96144391873c6fa5a7b4b795030d9daeefd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2988362 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi c3c934a3 2021-06-25T01:40:54 Translator: Better group ES100 texture builtins The ES100 texture built-ins are now (similarly to ES300 ones) grouped based on whether they include a Bias, or Lod. Bug: angleproject:4889 Change-Id: I495af48644c68286b1b0cc2a5580566fdd22cfc9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2987859 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 8b24e2a4 2021-06-25T13:51:19 infra: Add perf mb configs. This will set up the GN args for the perf builders. Bug: angleproject:6090 Change-Id: I3c00a5b78932ae41199953a46c525b435b566d12 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2989669 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Peter Kasting 5fc3fa9a 2021-06-25T10:18:06 Fix -Wimplicit-int-float-conversions. Bug: chromium:989932 Change-Id: Id7a49a4bd925508ea0362d1e6b9d853bf860ddb9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2987733 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 8b4f6e6d 2021-06-23T09:06:59 infra: Add perf configs. Adds Win/Linux/Android configs. Bug: angleproject:6090 Change-Id: Ie80a12a16997aab08e9dbba0cc0a9b14414fc8f2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2988793 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill da17d561 2021-06-23T13:50:15 Trace Tests: Use xvfb consistently on Linux. Previously there were two places where we missed the xvfb script. This was causing the replay to fail. Bug: angleproject:6085 Change-Id: I833916fa0cdacc163ec2bdd08831249807f319c5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2979353 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill bd797f75 2021-06-14T11:27:27 D3D11: Fix OOB write in Blit11. This could happen for specific values of the 'dest' target. Bug: chromium:1219082 Change-Id: Ic19a5dc4a95531f9513403ad9c97a4b4c5dc5a6f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2961070 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Yuly Novikov cc280ff3 2021-06-25T11:07:45 Remove obsolete Android bots from CQ android-angle-chromium-try + android-angle-try replace android_angle_deqp_rel_ng + android_angle_rel_ng Bug: angleproject:4483 Change-Id: I96d51ee610ca7b025e1976d0076409c4990836c3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2988792 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
kmx.io     mail     discord kmxgit v0.4.0