kc3-lang/angle

Log

Author Commit Date CI Message
Charlie Lao cd367796 2022-12-12T15:10:09 Vulkan: Add assert to ensure never setQueueSerial backwards This CL add an assertion in ResourceUse::SetQueueSerial to ensure that we never set a serial smaller than what it already has. If that happens, we could potentially destroy it while GPU still accessing it. With this assertion, it exposed a bug that when a buffer is read accessed by a renderpassCommands and then read accessed by outsideRenderPassCommands, we were incorrectly setting the queueSerial with outsideRP's serial, overwriting the queueSerial already set by renderPassCommands. To fix this, this CL detects this case and keeps the queueSerial set by renderPassCommands. Bug: b/262047600 Change-Id: I51b17ab4a93bccd0d0b079784af96cef9d79f16f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4099804 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Jamie Madill ef6f2127 2022-12-15T10:53:30 Capture/Replay: Fix trace interpreter autogen inputs. We were using the Khronos-specific XML file list, when we were really using both the Khronos and ANGLE XML files. Also updates auto-gen with the new data. Bug: angleproject:7775 Change-Id: Ifbc74bceec24a767ef45d94dd2e8a5cf850396ff Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4111198 Commit-Queue: Jamie Madill <jmadill@chromium.org> Auto-Submit: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Roman Lavrov 2ce2146b 2022-12-12T15:31:29 Fix --render-test-output-dir to work in TestSuite. https://crrev.com/c/3956937 introduced the issue where this flag is consumed by ANGLEPerfTestArgs.cpp logic which runs before the TestSuite constructor and removes the flag so we end up with an empty mTestArtifactDirectory in TestSuite. Bug: angleproject:7755 Change-Id: Ic32d3a2ddceca7842a0aebe5a1e40cbedaedf2eb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4097325 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Cody Northrop 001ba94e 2022-12-14T20:10:44 Tests: Add Plants vs. Zombies Heroes trace Test: angle_trace_tests --gtest_filter="*plants_vs_zombies_heroes*" Bug: angleproject:7848 Change-Id: Ieb8721401aa3d270b459d60944f12468ea2dbd28 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4109319 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
angle-autoroll 38261872 2022-12-15T10:01:25 Roll SwiftShader from 22d5e1e91e82 to c70b46423fc4 (3 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/22d5e1e91e82..c70b46423fc4 2022-12-14 sugoi@google.com Fix use-of-uninitialized-value issue for indexType 2022-12-14 swiftshader.regress@gmail.com Regres: Update test lists @ 647d3d24 2022-12-13 sugoi@google.com Fix LLVM update from google3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: I5249463f64ef2e52dec6b768cc26d35451b83d76 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4110571 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 7de7eb9b 2022-12-15T10:01:27 Roll vulkan-deps from a87c64cdfe8d to 3f9a78474605 (2 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/a87c64cdfe8d..3f9a78474605 Changed dependencies: * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/9b48e83ef8..75a6b83f21 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/21839cd4be..2beda7f6bd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: Icc31764c80e866eac5ba0b12a3ae76b969ddf4fd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4109322 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 2c60b86e 2022-12-15T08:00:44 Roll Chromium from 72727941e886 to 276f2cb5e838 (618 revisions) https://chromium.googlesource.com/chromium/src.git/+log/72727941e886..276f2cb5e838 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/967a60a2f7..c91a4dbdb6 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/6c567bfa24..dcbf73cdcb * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/19ffb9c006..2fc3d70467 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/09a1f53060..5e22a7fe23 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/70fb2d591b..ccd26eebd4 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/266ad209dc..e9f6c8927d * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..0d416fe68a * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e1c8efebe0..41a2d0f1a0 * third_party/r8: lillZvBtdIMEXU6ZjAiEGDqyEqLe0DiozKLwy2X0QKkC..pv_BIbpK8sxEFp63muv1gKsbyWJoyv4PDw342wc9H6AC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/60f2ca4e90..7356f69af6 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/6460c2fc71..6db9ff4559 No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: Iae34b0d5d1fe42de1b97c05664a3af7dc0b7b890 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4109321 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop 7fe33996 2022-12-02T00:04:28 Capture/Replay: Regen/Restore shaders and programs Add missing functionality that can recreate shaders and programs that are deleted during the run. Test: Plants vs. Zombies Heroes MEC Bug: angleproject:5968 Bug: angleproject:7848 Change-Id: I2d41ebe9df1e2ad1beef831acd72fd3f06f4eb1f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4060241 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll 20f4aced 2022-12-15T01:34:11 Roll vulkan-deps from a7b8bd76ed0c to a87c64cdfe8d (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/a7b8bd76ed0c..a87c64cdfe8d Changed dependencies: * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/ffa89a4447..dda9ae0f91 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/56e3ebda22..21839cd4be If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC romanl@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com,syoussefi@google.com Change-Id: Ia4cdd9810b8a6b9f9b9e44a4c3031f9a6b263ca3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4109317 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao a703eea4 2022-12-09T15:55:03 Vulkan: Remove Serial::valid() check QueueSerial right now checks if serial is valid or not in various comparison. This CL removes valid() method from class Serial and rely on the fact that default constructor always constructs kZeroSerial and kZeroSerial is always smaller than any serial, i.e, always appears as flushed, submitted and completed. This removes one branch from critical code path where we try to detect if a buffer/image is used by a renderpass or not etc. Bug: b/262047600 Change-Id: Ic76fe1409d9911dc7eb86107c9a930d8bb5eaa05 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4089848 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Shahbaz Youssefi 412dd368 2022-10-05T23:51:52 Vulkan: Use vkCmdClearAttachments for unmasked scissored clears Building on work by Tim Van Patten <timvp@google.com> In https://chromium-review.googlesource.com/c/angle/angle/+/3388635, not only were unmasked scissored clears made to use vkCmdClearAttachments, but also scissored clears could use loadOp=Clear. While this is potentially faster, it comes with a number of complications. This change only does the former. Unfortunately, due to a Qualcomm driver bug that forces ANGLE to avoid vkCmdClearAttachments, code simplification in the draw path cannot be made. Bug: angleproject:5194 Change-Id: Iec4184a09ca7fd09e3e8148c53db503512e6b8f0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3935893 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Elliott Hughes 0f3aaebf 2022-12-14T01:00:42 [PATCH] Add riscv64 support Bug: b/262585507 Change-Id: I7e081c5a1dacbcf1221d7580f33ce504442ebbbc Signed-off-by: Zhang Ye <haocheng.zy@linux.alibaba.com> Signed-off-by: Mao Han <han_mao@linux.alibaba.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4104471 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Charlie Lao <cclao@google.com>
Shahbaz Youssefi c3209b13 2022-12-13T16:05:51 Vulkan: Remove GlslangWrapperVk This class was just forwarding functions, and had over time become too thin. Bug: angleproject:7220 Change-Id: I7ae84ba017478d5c36b1e6d5f98a52d6b1cffb66 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4103744 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Shahbaz Youssefi 40c17b58 2022-12-13T15:35:23 Vulkan: Move SPIR-V transform to vulkan/ No longer used by metal/. Bug: angleproject:7220 Change-Id: Idb3a6369fefbcf87e7993daa652c8702ec53c20f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4104002 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Peng Huang e108858e 2022-12-14T12:16:39 Reland "Workaround GetModulePath() returns incorrect path for exe in Chrome" Original change's description: > Revert "Workaround GetModulePath() returns incorrect path for exe in Chrome" > > This reverts commit 4e54e434bd436e1a9d26ea527e1100747860dad8. > > Reason for revert: Causes ANGLE to crash on Android when loading from an APK > > Original change's description: > > Workaround GetModulePath() returns incorrect path for exe in Chrome > > > > Chrome changes process title that causes dladdr returns wrong module > > path for executable binary. Workaround the problem by using > > GetExecutablePath() which gets path from /proc/self/exe. > > > > Bug: chromium:1399828 > > Change-Id: I7dd89387160103af51e267a1dc8464715311f771 > > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4089450 > > Auto-Submit: Peng Huang <penghuang@chromium.org> > > Commit-Queue: Peng Huang <penghuang@chromium.org> > > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > > Test: Load ANGLE from APK on Android > Bug: angleproject:7888 > Change-Id: I27f3e8fa7e5bbb0911669ece6afce61f4e9a2713 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4105340 > Auto-Submit: Cody Northrop <cnorthrop@google.com> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Cody Northrop <cnorthrop@google.com> Bug: angleproject:7888 Change-Id: I2702c02dddea22713a8bbd79a4ed96e7475a4252 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4106348 Commit-Queue: Peng Huang <penghuang@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 77c95de4 2022-11-16T21:12:28 Vulkan: Threaded monolithic pipeline creation With this change, once a pipeline is created out of libraries, a task is scheduled (if necessary) to asynchronously create a corresponding monolithic pipeline. Once the task is complete, the linked pipeline handle is replaced by the monolithic one, gaining back any performance that might have been lost due to the use of libraries. Bug: angleproject:7369 Change-Id: I525fb1e09f8bedc61b9dbef19f9cce7026ff9c53 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4031151 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Shahbaz Youssefi 2072aea9 2022-12-13T15:23:49 Metal: Remove references to GLSLANG Bug: angleproject:7220 Change-Id: Ifae4dc427e34cdd3ec17b8f897c7dec59c779633 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4104001 Reviewed-by: Gregg Tavares <gman@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 69d9f077 2022-12-13T15:10:36 Metal: Remove references to ShaderInterfaceVariableInfoMap Bug: angleproject:7220 Change-Id: Ib78daa77779258aa450067d891c6af4ee4877446 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4104000 Reviewed-by: Gregg Tavares <gman@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Quyen Le <lehoangquyen@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 03abe6cd 2022-12-14T10:01:08 Roll vulkan-deps from 66d1f426b724 to a7b8bd76ed0c (8 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/66d1f426b724..a7b8bd76ed0c Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/c6b3f279a7..f9b760e6c7 * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/c77b09b57c..a89dea3c49 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/e7a0c9bc0d..56e3ebda22 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: I3690f26e05a616f7ec50460297a67e4dfb873948 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4104746 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 1b5dfec1 2022-12-14T09:54:34 Roll Chromium from 438de6cec0a1 to 72727941e886 (660 revisions) https://chromium.googlesource.com/chromium/src.git/+log/438de6cec0a1..72727941e886 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/4a983da20b..967a60a2f7 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/910aaedf13..6c567bfa24 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/c994418314..19ffb9c006 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/564b746622..70fb2d591b * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/ab365d399e..266ad209dc * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/1e254c17ed..3ec81a68ed * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/cf97dd948b..62a97b8cd6 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..e28e9f182e * third_party/fuchsia-sdk/sdk: version:11.20221209.0.1..version:11.20221213.1.1 * third_party/r8: 3Vuxtp3m63h2bcmamz2iBC04rNQOUmQ3O6eDyLoVY3EC..lillZvBtdIMEXU6ZjAiEGDqyEqLe0DiozKLwy2X0QKkC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/3344dd8997..60f2ca4e90 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/395e41c4fb..94ca0e8b0a * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/b445cdb1c0..6460c2fc71 Clang version changed llvmorg-16-init-13328-g110fe4f4:llvmorg-16-init-12251-g87d0ff91 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/3344dd8997f422862a1c5477b490b3611be31351..60f2ca4e90a683f220a29c8485bf409f348fd423/scripts/update.py Bug: None Tbr: romanl@google.com Change-Id: Ia7e3ae193bdf7078791507ff3fe5dee98e935934 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4104431 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop 4a4ae726 2022-12-13T18:55:17 Revert "Workaround GetModulePath() returns incorrect path for exe in Chrome" This reverts commit 4e54e434bd436e1a9d26ea527e1100747860dad8. Reason for revert: Causes ANGLE to crash on Android when loading from an APK Original change's description: > Workaround GetModulePath() returns incorrect path for exe in Chrome > > Chrome changes process title that causes dladdr returns wrong module > path for executable binary. Workaround the problem by using > GetExecutablePath() which gets path from /proc/self/exe. > > Bug: chromium:1399828 > Change-Id: I7dd89387160103af51e267a1dc8464715311f771 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4089450 > Auto-Submit: Peng Huang <penghuang@chromium.org> > Commit-Queue: Peng Huang <penghuang@chromium.org> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Test: Load ANGLE from APK on Android Bug: angleproject:7888 Change-Id: I27f3e8fa7e5bbb0911669ece6afce61f4e9a2713 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4105340 Auto-Submit: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Charlie Lao 214742be 2022-12-13T10:43:52 D3D: Remove ResourceSerial The only difference between ResourceSerial and UniqueueSerial (formerly Serial) appears to be ResourceSerial is wrapper of object pointer. This CL removes ResourceSerial class and switched it to UniqueSerial class instead. (We may need to see why it needs to use pointer to initialize the serial, that sounds like the exact thing serial try to avoid.) Bug: b/262047600 Change-Id: Ic8e1b26d7da9304ff02fd9a7e1b584bb70efcb77 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4102107 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Charlie Lao b19d17b8 2022-12-09T14:38:08 Vulkan: Split Serial class into UniqueSerial and Serial This CL splits Serial class into two classes: UniqueSerial and Serial. UniqueSerial supports the object unique serial usage where there is == and != operator but no > or < comparison. UniqueSerial can have invalid value, but Serial will not have invalid value (in next CL). The main reason is for next CL we can further optimize out the invalid value check in the QueueSerial comparison. Bug: b/262047600 Change-Id: Ieaed2a0d5546b012a6d63aa18b6006595e4aee1b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4093557 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Shahbaz Youssefi 22d73114 2022-12-13T09:53:34 Vulkan: Remove unnecessary pipeline library retain Vertex input and fragment output partial pipelines are kept alive until context destruction, so there's no need to retain them. Bug: angleproject:7369 Change-Id: I8cbe5b9f70845bb5d9348f11889f64a6a94a6b87 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4100407 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Ivan Murashov 816505f9 2022-12-13T12:35:50 GCC: Make some operators of QueueSerial non constexpr Fix build breakage for GCC because of calling non constexpr function from a constexpr function. The error example: third_party/angle/src/libANGLE/renderer/serial_utils.h:214:40: error: call to non-'constexpr' function 'rx::Serial rx::AtomicQueueSerialFixedArray::operator[](rx::SerialIndex) const' Bug: chromium:819294 Change-Id: Ic09be54ce9418ab3f7d947eaa27c97b55c3c2bab Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4098527 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
angle-autoroll aa921a63 2022-12-13T15:05:57 Roll SwiftShader from 36e043fa6d46 to 22d5e1e91e82 (7 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/36e043fa6d46..22d5e1e91e82 2022-12-13 sugoi@google.com Revert "Float only writeColor" 2022-12-13 swiftshader.regress@gmail.com Regres: Update test lists @ 29dc5eb3 2022-12-12 syoussefi@google.com Implement VK_KHR_surface/swapchain_maintenance1 2022-12-12 sugoi@google.com Float only writeColor 2022-12-12 syoussefi@google.com Update Vulkan headers to version 1.3.225 2022-12-12 sugoi@google.com Merge changes I6664b301,Iccccf7fd,I44bfc249,Ibd600b7e 2022-12-12 sugoi@google.com Fix Kokoro presubmit checks If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC romanl@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:7878 Tbr: romanl@google.com,syoussefi@google.com Change-Id: Idd7055de0a56e304923a701d5c6214fcee447c87 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4100742 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Chris Dalton 004c5c94 2022-12-10T14:50:01 Prefix all PLS enums with "GL_" Bug: angleproject:7279 Change-Id: Ifb4062e502305f4e59546f067d195d1a05fbabe4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4095380 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Chris Dalton <chris@rive.app> Reviewed-by: Steven Noonan <steven@valvesoftware.com>
Roman Lavrov 65e3ec8e 2022-12-13T14:01:45 Revert "Re-enable dEQP-EGL.functional.resize.surface_size on Linux." This reverts commit e4b55b85bc8c0680c58daf2d312f0174db14f755. Reason for revert: Still flaky https://ci.chromium.org/ui/p/angle/builders/try/linux-test/10487/overview Original change's description: > Re-enable dEQP-EGL.functional.resize.surface_size on Linux. > > These were flaky, let's see if recent X11 related changes fixed this. > > Bug: angleproject:5753 > Change-Id: I9f112f8d01cb838bc588b818a0a7d0a4ec5fd087 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4097404 > Auto-Submit: Roman Lavrov <romanl@google.com> > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bug: angleproject:5753 Change-Id: Ia3042f65754f1436eca6d8ce014cc73245c4c7e4 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4100406 Commit-Queue: Roman Lavrov <romanl@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
angle-autoroll f8720bdb 2022-12-13T10:01:41 Roll vulkan-deps from 8b5ea902f8d4 to 66d1f426b724 (5 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/8b5ea902f8d4..66d1f426b724 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/6d8b00b1c6..c6b3f279a7 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/9c6a925c87..43c99b5ee0 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/b43758588b..96488e2b2e * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/46f343d060..e7a0c9bc0d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: Iae931aa7a36e69667e85611e45062c1f7a25cb44 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4099696 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 5dc73efc 2022-12-13T07:45:45 Roll Chromium from 1c9a08119fdd to 438de6cec0a1 (605 revisions) https://chromium.googlesource.com/chromium/src.git/+log/1c9a08119fdd..438de6cec0a1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/3d4b0c1e77..4a983da20b * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/202b660eb5..910aaedf13 * buildtools/linux64: git_revision:70d6c60823c0233a0f35eccc25b2b640d2980bdc..git_revision:5e19d2fb166fbd4f6f32147fbb2f497091a54ad8 * buildtools/mac: git_revision:70d6c60823c0233a0f35eccc25b2b640d2980bdc..git_revision:5e19d2fb166fbd4f6f32147fbb2f497091a54ad8 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/52399655fd..c994418314 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/25a3d07096..123239cdb6 * buildtools/win: git_revision:70d6c60823c0233a0f35eccc25b2b640d2980bdc..git_revision:5e19d2fb166fbd4f6f32147fbb2f497091a54ad8 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/815aab8052..564b746622 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..20cf5c69af * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a964ca1296..e1c8efebe0 * third_party/r8: fFQ1Rqv_uAJXc7HegDNUyiPFP55MX8M60L6HLFijCwgC..3Vuxtp3m63h2bcmamz2iBC04rNQOUmQ3O6eDyLoVY3EC * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/88fc00c3f4..395e41c4fb * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/eb45a81dce..b445cdb1c0 No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: I04ad8bdd12972eb4501d13e13dbf4e183ca1fbc5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4099694 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 91bfd02e 2022-12-12T22:43:53 Roll VK-GL-CTS from d90c76e77622 to 9f4465eccb37 (6 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/d90c76e77622..9f4465eccb37 2022-12-12 quic_mnetsch@quicinc.com Merge vk-gl-cts/opengl-cts-4.6.2 into vk-gl-cts/main 2022-12-12 quic_mnetsch@quicinc.com Merge vk-gl-cts/opengl-es-cts-3.2.8 into vk-gl-cts/main 2022-12-08 amber@igalia.com Add tests for 0 pWaitDstStageMask in VkSubmitInfo and events. 2022-12-08 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkan-cts-1.3.4 into vk-gl-cts/main 2022-12-08 ziga@lunarg.com Add tests with primitive restart generating no primitives 2022-12-07 rgarcia@igalia.com Add tests for VK_EXT_extended_dynamic_state3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: I7d1e458a5a2fede6c0c6cea693527bca81e746d7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4098375 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao 89cd8583 2022-12-12T11:23:59 Vulkan: Clean up Resource class Resource::retainCommands() API name no longer make sense. This CL removes retainCommands and retainReadOnly and retainReadWrite APIs and replaced with setQueueSerial and setWriteQueueSerial call directly. This CL also merges some of single inline functions to minimize the file, sine the class is small anyway. Bug: b/262048658 Change-Id: I9d16b82c79b27f3285311393601705a4ee7f6d8a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4098005 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Shahbaz Youssefi a1be7188 2022-12-12T16:11:34 Vulkan: Keep referenced pipeline libraries alive As required by the spec, it's not enough to keep the linked pipeline alive. With this change, the serials of the invidual libraries are updated every time the serial of a linked pipeline is updated. Bug: angleproject:7369 Change-Id: Iedc98a427d988d00b4e8745964d9827fdf51ea7f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4098744 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao f3ebb2ca 2022-12-08T17:02:12 Vulkan: Better mUse tracking for DynamicallyGrowingPool<Pool> This is used only from DynamicallyGrowingPool<Pool>::onEntryFreed to set the its tracking QueueSerial. There is better way to do this now with per context serial. We can simply merge the QueryHelper's mUse into the pool instead of setting pool's use to the current queueSerial. The benefit of doing that is to possibly allow pool gets reuse/freed earlier (i.e., more accurate tracking). This CL switches it to more accurate tracking and removes mCurrentSerial from Context. This CL also removes unused DynamicSemaphorePool class. Bug: b/262054987 Change-Id: Iac3e2495cc0e3623ba63e9da7f32ad6e9c223467 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4089847 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Amirali Abdolrashidi 052277fc 2022-11-30T15:18:11 Fix the input arg after the trace_tests change * Added angle_trace_tests as an acceptable input for run_angle_android_test.py after the change to split trace tests from perf tests. Bug: angleproject:7755 Change-Id: Ia95d20c1ba8479c14055aa1515c1c4b6dc264a86 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4068354 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Amirali Abdolrashidi 684ff60b 2022-06-21T10:52:31 Vulkan: Add shared ring buffer cmd alloc feature * Added RingBufferAllocator.cpp with implementation. * Main classes: * RingBufferAllocator (fast allocation with bulk deallocation) * SharedRingBufferAllocator (wrapper to help with shared use and multiple threads) * Implemented "angle_enable_vulkan_shared_ring_buffer_cmd_alloc" feature. (Disabled by default) * Details (from the original CL) * The angle::PoolAllocator replaced with angle::RingBufferAllocator. * Before, there was separate angle::PoolAllocator per each CommandBufferHelper. Now, a single angle::RingBufferAllocator is shared between multiple CommandBufferHelper objects. * Commands data from multiple CommandBufferHelpers is tightly packed without fragmentation. * Significantly less memory overhead, observed with enabled async queue. * Moved the parts of the code related to the allocators into the classes in the new AllocatorHelperPool and AllocatorHelperRing files for better management. The allocator can be switched by changing the following BUILD flag: `angle_enable_vulkan_shared_ring_buffer_cmd_alloc` * It is connected to the following macro: ANGLE_ENABLE_VULKAN_SHARED_RING_BUFFER_CMD_ALLOC * The two main allocator classes in each file are aliased as: * SecondaryCommandBlockAllocator (in CommandBufferHelper objects) * SecondaryCommandBlockPool (in SecondaryCommandBuffer) * Also added placeholder functions for VulkanSecondaryCommandBuffer. * Added descriptions regarding the two allocators. * renderer/vulkan/doc/Allocators.md Credit: Original CL authored by Igor Nazarov <i.nazarov@samsung.com> Bug: angleproject:6401 Bug: b/256666069 Change-Id: I0f24793eef6334bf4ff8e327b9665338807dad37 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3715968 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Roman Lavrov e4b55b85 2022-12-12T10:22:09 Re-enable dEQP-EGL.functional.resize.surface_size on Linux. These were flaky, let's see if recent X11 related changes fixed this. Bug: angleproject:5753 Change-Id: I9f112f8d01cb838bc588b818a0a7d0a4ec5fd087 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4097404 Auto-Submit: Roman Lavrov <romanl@google.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Yuly Novikov f08fd32d 2022-12-12T15:44:39 Skip DrawElementsIndexOutOfRangeWithDynamicDraw on Win Intel Bug: angleproject:7866 Change-Id: I0eb403e8217da5a9bd1602e3297b581ed34be28e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4096988 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov f98d3f6c 2022-12-12T15:18:37 More PixelLocalStorage skips on iOS Bug: angleproject:7756 Change-Id: I90865aec0bb5b685396962c1a4376adca99c6537 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4096987 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
angle-autoroll 64e1904b 2022-12-12T10:27:56 Roll vulkan-deps from 89b9b4762b94 to 8b5ea902f8d4 (14 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/89b9b4762b94..8b5ea902f8d4 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/ed257e2bdf..6d8b00b1c6 * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/1d31a10040..70ff9d939c * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/bf3b3fb14e..9b48e83ef8 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/f846ef57a0..ffa89a4447 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/934d2bddab..46f343d060 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: Id03925e7a568f7295770341feaa2b646791f41e0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4096008 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 66ee308c 2022-12-12T10:01:57 Roll SwiftShader from 6ebc3347af9d to 36e043fa6d46 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/6ebc3347af9d..36e043fa6d46 2022-12-10 capn@google.com Add a macro for indicating unoptimized code paths If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I163782840b5dfa28b6d0f070b4102c6a6caec6c6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4095296 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b1b46401 2022-12-12T07:00:15 Roll Chromium from 3b96c02c7465 to 1c9a08119fdd (378 revisions) https://chromium.googlesource.com/chromium/src.git/+log/3b96c02c7465..1c9a08119fdd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/2c6fbff58d..3d4b0c1e77 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/4fb9b31a5c..202b660eb5 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/e4e39cee1f..52399655fd * testing: https://chromium.googlesource.com/chromium/src/testing/+log/770e331176..815aab8052 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/cf8a24d091..ab365d399e * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..2f1cf6121c * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8e77bba1ae..a964ca1296 * third_party/fuchsia-sdk/sdk: version:10.20221207.3.1..version:11.20221209.0.1 * third_party/r8: rTXVKiqoOxR4GVJBXkVmN4qH8FbxwXX7Nu1H3X414-MC..fFQ1Rqv_uAJXc7HegDNUyiPFP55MX8M60L6HLFijCwgC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/6b1d726a99..3344dd8997 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/b8921723e9..88fc00c3f4 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/49461e5506..eb45a81dce Clang version changed llvmorg-16-init-12251-g87d0ff91:llvmorg-16-init-13328-g110fe4f4 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/6b1d726a99a8f92ba7a8abdad0bc8931f9376010..3344dd8997f422862a1c5477b490b3611be31351/scripts/update.py Bug: None Tbr: abdolrashidi@google.com Change-Id: Ic77e2594aa00305171105c0b1f46e4f94f1a1edc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4093504 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao f8980c98 2022-12-08T11:51:42 Vulkan: Make ReadWriteResource subclass from Resource To simplify the code slightly. The main reason for this is that the two class variables of ReadWriteResource totally does not make sense: mReadOnlyUse actually manes any usage, read or write. mReadWriteUse actually means write usage. Since Resource class's mUse means any access, subclass ReadWriteResource from Resource class makes more sense since mUse means exact same thing in both classes. This CL also changes ReadQriteResource::mReadWriteUse to mWriteUse. Bug: b/262048658 Change-Id: I0e3172a70b8cb6a6481045c46690b69fbfe9523c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4089983 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Charlie Lao 6830b7d3 2022-11-23T11:51:28 Vulkan: Use finishQueueSerial for queueSubmitOneOff Right now for oneoff submission we are creating a fence and pass in the fence and then wait for fence outside the normal wait code path. This creates a problem that the command buffer and garbage clean up code does not gets run and may end up hitting assertion. This might be necessary before because complication with ResourceList. With recent work that removes ResourceList, this can be much simpler now. This CL removes the fence creation and wait in the oneoff submission code path (except the external fence) and switch to finishQueueSerial call. Bug: b/255414841 Change-Id: I2b16c187becbda9c2397685c7212abac994e8dc2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4053261 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Charlie Lao 1219f55a 2022-12-07T16:19:37 Vulkan: Remove Resource::isCurrentlyInUse Due to header file include order, this function can not directly made inline. This CL removes the function and replace it with renderer->getUnfinishedUse() to reduce one extra function call of one line function. Bug: b/262048658 Change-Id: Ied33b63d0ec88336a5ce42cf7726f16b2b883b86 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4089623 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao 798b97b8 2022-12-07T15:37:51 Vulkan: mapRangeImpl should call flushImpl if unflushed write BufferVk::mapRangeImpl() want to ensure any GPU write command has been flushed and finished. Right now it calls flushImpl if there is any unflushed access. It should only need to flush if there is any unflushed *write* command. This CL changes check of any access to any write access. This CL also inlines isCurrentlyInUseForWrite/finishGPUWriteCommands and removed these two single line function calls. Bug: b/261772793 Change-Id: I1628ec31eaceb87f82e654cb1f317570ff2f6c12 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4086972 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Charlie Lao 702018d2 2022-12-08T13:29:24 Vulkan: Make PipelineHelper go through normal collectGarbage Right now there are two different type of garbages. Objects like buffer or VkImage that can be used by different contexts and are GPU tracked as they are been used. These objects goes to RendererVk::mSharedGarbage. The one time use objects or objects are not been tracked as they are been accessed, they add to the context's garbage list and their mUse gets updated when commands gets submitted. With new per active context queue serial, the update of mUse can be immediate and low cost ( write to an entry in the array), so there really isn't a good need to keep two garbage list. This CL only deals with PipelineHelper object that makes it goes through general collectGarbage code path instead of ContextVk::mCurrentGarabge, since the PipelineHelper object is already mUse tracked properly. Bug: angleproject:7862 Change-Id: Ie77229683828590546f06938add057cf5610835b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4089984 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Shahbaz Youssefi 55670895 2022-12-08T10:50:27 Vulkan: Move desc set updates cache to share group This ensures that if one context batches updates to a descriptor set, that other contexts in other threads are able to flush them if necessary. This is necessary as descriptor sets are themselves shared between contexts. Bug: b/261552549 Bug: angleproject:7881 Change-Id: Id1a895b05fe31d118e8fb3fa64e5ccd67cff7923 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4088904 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org>
Shahbaz Youssefi fd75686e 2022-12-07T16:40:54 Vulkan: Fix EGL image queue change vs threads ANGLE records commands (a queue transfer and layout transition) when an external image is bound to a texture or a renderbuffer. If another thread starts using these resources, the recorded commands should have been flushed. The application is not required to synchronize between the threads in this case (or at least, there are applications that don't). Bug: b/261552549 Change-Id: I9f345316269baf5f10576dbef73b86924efd5c6f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4088903 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Charlie Lao <cclao@google.com>
Yuly Novikov cc6a8536 2022-12-09T18:01:53 Skip couple non-deterministic angle_restricted_trace_gold_tests on Win Intel Vulkan. black_desert_mobile the_gardens_between produce slightly different images each run. Bug: angleproject:7879 Change-Id: I3a7c218b8e67b4800b4620ab7d1dc6ee15a5a089 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4092915 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Alexey Knyazev 0103213e 2022-12-05T00:00:00 GL: Support clip and cull distance redeclarations * Fixed gl_PerVertex qualifier string. * Updated ValidateClipCullDistanceTraverser to output redeclared array sizes and maximum constant indices. * Made DeclarePerVertexBlocks available for non-Vulkan outputs. * Updated DeclarePerVertexBlocks to remove gl_ClipDistance and gl_CullDistance redeclarations. * Enabled DeclarePerVertexBlocks for ESSL output when gl_ClipDistance or gl_CullDistance are redeclared. * Updated ESSL output to use 3.10 shading language version, when the context has GL_EXT_clip_cull_distance enabled. * Updated ESSL output to enable GL_EXT_shader_io_blocks when gl_ClipDistance or gl_CullDistance are redeclared. * Updated extension exposure conditions. * Fixed typos in ParseContext. Bug: angleproject:7763 Change-Id: Ib87368a1953ad546a407d634d8b00f71cf92c40c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4083705 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao f4e64938 2022-12-07T13:01:15 Vulkan: Remove CommandQueue::mQueueSerialMutex This mutex lock is no longer used and needed, thus removed in this CL. Also removed unused BufferAccess enum class. Bug: b/261737134 Change-Id: I7391e84c5b2abcd87de6ce9e66ba85f81ff7dce3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4086934 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi db9ffea3 2022-12-08T22:08:51 Vulkan: Remove the unused shadowBuffer feature Bug: angleproject:4339 Change-Id: I4f4524ba597af25bd6da3792bd7a85ae1b52962e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4089448 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao 02cc4cd5 2022-12-07T12:03:26 Vulkan: Remove ImageHelper::mImageAndViewGarbage This was introduced in crrev.com/c/3449450. At that time this is necessary, because we can not copy mUse for immediate view garbage collection. Now with recent work, mUse is copyable, we no longer need to accumulate the view garbage. They can be released immediately with a copy of image's mUse. Bug: b/261737134 Change-Id: Ic4393f8c4ee7c0e3be4669a0a557507c909a77ab Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4087323 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov 104faff5 2022-12-09T15:01:54 Enable angle_restricted_trace_gold_tests retries on Win Intel UHD630 Flaky 4x8 pixel artifacts like with older GPU/driver. Also expand flaky Texture2DTestES3.NonZeroBaseEmulatedClear skip. Bug: angleproject:5415, angleproject:7866 Change-Id: Iea11f7dcb75e71f89dcf83f0cdde7ff74d6385f9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4092005 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Peng Huang 4e54e434 2022-12-09T09:36:42 Workaround GetModulePath() returns incorrect path for exe in Chrome Chrome changes process title that causes dladdr returns wrong module path for executable binary. Workaround the problem by using GetExecutablePath() which gets path from /proc/self/exe. Bug: chromium:1399828 Change-Id: I7dd89387160103af51e267a1dc8464715311f771 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4089450 Auto-Submit: Peng Huang <penghuang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Chris Dalton eb1a13d8 2022-12-06T21:56:42 Improve PLS load and store op tokens Define more new tokens that are more clearly named, as opposed to recycling tokens that were meant for a different purpose. Bug: angleproject:7279 Change-Id: I840e5ea168235c49eec2693b2231c2d329027b0e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4082057 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Jamie Madill 54176f07 2022-12-08T15:58:05 Better support for "vulkan-null" backend in trace tests. This allows running the "null" Mock ICD with the Vulkan secondaries version, and allow you to specify "vulkan-null" as an ANGLE back-end generally. Bug: angleproject:7852 Change-Id: Id8c59a167345a6079bd71916ae6ef9c41a6039a7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4089449 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Jamie Madill <jmadill@chromium.org>
angle-autoroll 9e086ee1 2022-12-09T10:01:06 Roll vulkan-deps from 4affe58949d3 to 89b9b4762b94 (5 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/4affe58949d3..89b9b4762b94 Changed dependencies: * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/ce45337c51..f846ef57a0 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/9788bc1859..934d2bddab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I0f34edc09e839dc73f7850c79d7e0eca92822fbc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4092026 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gert Wollny f7cf3226 2022-12-08T10:08:56 Capture/Replay: Only create active secondary contexts in MEC This finalized the fix attempted in b432c84c2b8cb6d20873e2b33b6684bee76db90d Capture/Replay: Fix collecting the initialized contexts Bug: angleproject:7858 Change-Id: Ie2bbcdb3f23fe4970ce3a9bb46df6f60fe6c8ab6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4084926 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
angle-autoroll caccbdc1 2022-12-09T07:00:50 Roll Chromium from eb46dc0d0fce to 3b96c02c7465 (547 revisions) https://chromium.googlesource.com/chromium/src.git/+log/eb46dc0d0fce..3b96c02c7465 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/0e5c336082..2c6fbff58d * testing: https://chromium.googlesource.com/chromium/src/testing/+log/c9e298613f..770e331176 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/e1923458e4..cf97dd948b * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..562809c7e4 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d259b31644..8e77bba1ae * third_party/r8: 5Ckp25uPxCBEH3n_3JC6k2Jf1STCD2VMtCxHeUDjz6oC..rTXVKiqoOxR4GVJBXkVmN4qH8FbxwXX7Nu1H3X414-MC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/72ab3202b5..6b1d726a99 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/0103aeaf9b..b8921723e9 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/9ed590cee3..49461e5506 No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: Iebaaa973b89e28e1e064f950c211d5e9a6420a3f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4091422 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexis Hétu c9e7fd9c 2022-12-08T22:20:32 Revert "Skip AssignAssignmentToSwizzled on SwS Linux/Win" This reverts commit 0f7471ff610f3de0a9ef7f28b4bfc4bbbf693dc1. Reason for revert: Attempting a Revert to see if the tests are now fixed. Original change's description: > Skip AssignAssignmentToSwizzled on SwS Linux/Win > > Bug: angleproject:7863 > Change-Id: I9921e2e08834f793071ea07b211941bc8887b313 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4082150 > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Bug: angleproject:7863 Change-Id: I341da5b2c51fe7f22fc1958680cb7a955ee10c7a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4090823 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Alexis Hétu <sugoi@chromium.org>
angle-autoroll 1e9a6726 2022-12-08T18:39:02 Roll vulkan-deps from 5e89361766f7 to 4affe58949d3 (3 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/5e89361766f7..4affe58949d3 Changed dependencies: * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/82d4232f0f..b43758588b * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/1e422524e7..9788bc1859 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com,syoussefi@google.com Change-Id: I2c49fd87433dec41d26c550ea91f74b600a6b37e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4087619 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 1193b664 2022-10-11T01:00:40 Vulkan: Use VK_EXT_pipeline_protected_access This extension allows pipelines to be restricted to protected or unprotected command buffers only. Bug: angleproject:7714 Change-Id: Id07be4c2ffd7ca19b8b4a2a869828bc11e89e467 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3943535 Reviewed-by: Charlie Lao <cclao@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Charlie Lao 7e378da9 2022-12-01T16:36:08 Vulkan: Remove synchronous commands from CommandProcessor Some command tokens in CommandProcessor are doing synchronous calls. For example, finishResourceUse() and waitIdle(). They are inserting a token and then wait for CommandProcessor to drain. This CL removes these commands from CommandProcessor and it just ask CommandProcessor to drain and then call into mCommandQueue to finishResourceUse or waitIdle. This is a minor clean up for now, but in future CL we will also avoid waitForWorkComplete if the mUse has already been drained from CommandProcessor. Bug: b/261098465 Change-Id: I7672a9c0b1e477ea3537652cd83350aa97f7caa7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4072223 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Charlie Lao fa45eae4 2022-12-07T10:39:31 Vulkan: Remove QueryVk::hasUnsubmittedUse() QueryVk has a list stashed query helpers and current queryHelper. The mStashedQueryHelpers are always older than mQueryHelper. When we want to check if all queryHelpers has been submitted or not, we really only need to check the last one, which is mQueryHelper. There is no need to check mStashedQueryhelper. This CL turns that check against mStashedQueryhelper into an assertion inside finishRunningCommands. Bug: b/261737134 Change-Id: I2369e6690c46bcd338d4bfcb679a77478d3fdb84 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4087321 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
angle-autoroll 6784fe5d 2022-12-08T16:21:04 Roll vulkan-deps from 7935ee7ccbc0 to 5e89361766f7 (1 revision) https://chromium.googlesource.com/vulkan-deps.git/+log/7935ee7ccbc0..5e89361766f7 Changed dependencies: * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/b75e5a02b6..bf3b3fb14e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com,syoussefi@google.com Change-Id: I6f7ad7f52c12df8cd1b236133262a1a1e01afb3a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4087617 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov 28290e34 2022-12-08T16:11:55 Skip Texture2DTestES3.NonZeroBaseEmulatedClear/ES3_Vulkan on Win Intel Bug: angleproject:7866 Change-Id: I747d30d9774e237f9733eed0e0007d0c10b553cd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4088983 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Yuly Novikov 81a3c71e 2022-12-01T18:51:39 Enable tests on Win Intel Optiplex 7080 experimental bot Suppress failing end2end tests and run single process Suppress VUID-VkDescriptorImageInfo-imageView-06711 Bug: chromium:1349828, angleproject:7874 Bug: angleproject:7865, angleproject:7866, angleproject:7872 Change-Id: I18c9099af6635cf41f5368960dc1d35d9decc48c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4071925 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll a5fd8ab6 2022-12-08T10:01:35 Roll SwiftShader from 0c98167cb31e to 6ebc3347af9d (6 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/0c98167cb31e..6ebc3347af9d 2022-12-08 swiftshader.regress@gmail.com Regres: Update test lists @ 6f73609d 2022-12-07 sugoi@google.com Add missing include <string> 2022-12-07 sugoi@google.com Add early exits for OOB index buffer offset or first index 2022-12-07 sugoi@google.com Fix VK_EXT_graphics_pipeline_library related crash 2022-12-07 sugoi@google.com Fix Regres false crash reports 2022-12-07 swiftshader.regress@gmail.com Regres: Update test lists @ 0c98167c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I0e56f3f521f279b6bde5ac8c2bcfed0012d384be Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4086877 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll fee1f5c3 2022-12-08T07:02:26 Roll Chromium from b1141d77c69a to eb46dc0d0fce (599 revisions) https://chromium.googlesource.com/chromium/src.git/+log/b1141d77c69a..eb46dc0d0fce If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/e3833ca15b..0e5c336082 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/71c674dc56..4fb9b31a5c * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/a9779c11d2..e4e39cee1f * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/f46bba92c0..25a3d07096 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/fd5b3b5068..09a1f53060 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..562809c7e4 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/107142ac38..d259b31644 * third_party/fuchsia-sdk/sdk: version:10.20221201.3.1..version:10.20221207.3.1 * third_party/r8: smgiQDhBHEfz8KVdqBXas7z0ALaukjW3Yh-JVGPsFksC..5Ckp25uPxCBEH3n_3JC6k2Jf1STCD2VMtCxHeUDjz6oC No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: Iaf899f1cb3f5de88a618d7400a6b2ebb2cc51702 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4088301 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 52b07369 2022-12-08T03:37:56 Roll Chromium from 81e6bda0f261 to b1141d77c69a (1 revision) https://chromium.googlesource.com/chromium/src.git/+log/81e6bda0f261..b1141d77c69a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..932b0825c3 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/d866d41e16..18d27fa10b No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: Ib4ade92aefa677e34e520f81127e3d45464b3a9e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4087871 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 15ae19c0 2022-12-08T02:50:18 Roll Chromium from 716fac091414 to 81e6bda0f261 (2 revisions) https://chromium.googlesource.com/chromium/src.git/+log/716fac091414..81e6bda0f261 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * testing: https://chromium.googlesource.com/chromium/src/testing/+log/21ed928654..c9e298613f * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..932b0825c3 No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: I3fa4b4b3b6699cabd0b7b3bf955a34ad7ffff56f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4087869 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
angle-autoroll ffe584f1 2022-12-08T00:31:54 Roll Chromium from 1c2e19edc873 to 716fac091414 (3 revisions) https://chromium.googlesource.com/chromium/src.git/+log/1c2e19edc873..716fac091414 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..932b0825c3 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/5a18712799..9ed590cee3 No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: I25217eab799bec6dcec7cd5fbee9c65eae9262e4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4086979 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
angle-autoroll 40b4fcc0 2022-12-07T23:18:11 Roll vulkan-deps from a497ee9d6755 to 7935ee7ccbc0 (10 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/a497ee9d6755..7935ee7ccbc0 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/a7603c132d..ed257e2bdf * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/40f5bf59c6..9c6a925c87 * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/891c40de1a..b75e5a02b6 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/1f2848428c..1e422524e7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: If8bf400e994587a5cd0f2a01b50e426664258d9e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4086969 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll f63e5ab3 2022-12-07T23:45:40 Roll Chromium from 9edf8e710ec9 to 1c2e19edc873 (5 revisions) https://chromium.googlesource.com/chromium/src.git/+log/9edf8e710ec9..1c2e19edc873 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..932b0825c3 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/ef102c057a..0103aeaf9b No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: If85745d89e8547a330cd2b2732a7db449b5ce503 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4086975 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll dbbed929 2022-12-07T22:47:13 Roll Chromium from 998dcf5599d0 to 9edf8e710ec9 (8 revisions) https://chromium.googlesource.com/chromium/src.git/+log/998dcf5599d0..9edf8e710ec9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..932b0825c3 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/22e920cc38..ef102c057a * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/993564df50..5a18712799 No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: I557cc0f6c65677005e55b5ee39616ba3a524ee7c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4086968 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Chris Dalton f551faf7 2022-12-01T17:14:14 Use typed UAV loads for pixel local storage, when supported D3D11.3 supports typed UAV/ROV loads on some hardware. Check for this feature and use it when available. I haven't been able to measure a meaningful performance difference from this change, presumably because the bottleneck is memory bandwidth, but it's simple and more consistent with the other backends. Bug: angleproject:7855 Change-Id: I1713fc12842380ef1a685a6878948bc0293074c5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4072222 Commit-Queue: Chris Dalton <chris@rive.app> Reviewed-by: Stephen White <senorblanco@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org>
angle-autoroll 45a62515 2022-12-07T22:04:57 Roll Chromium from ee01bc900c32 to 998dcf5599d0 (21 revisions) https://chromium.googlesource.com/chromium/src.git/+log/ee01bc900c32..998dcf5599d0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/7aa5d7d4ea..e3833ca15b * testing: https://chromium.googlesource.com/chromium/src/testing/+log/fbed698ae2..21ed928654 * third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/a7365fc087..0ba8b5fcef * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..8fd5368fb8 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/32b2e85c08..993564df50 No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: I2095cde6ed4535cd551bf3350c3772558064d105 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4086966 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
angle-autoroll 302fccd1 2022-12-07T20:54:19 Roll Chromium from ee01bc900c32 to 17b77809b4ca (1 revision) https://chromium.googlesource.com/chromium/src.git/+log/ee01bc900c32..17b77809b4ca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * testing: https://chromium.googlesource.com/chromium/src/testing/+log/efbf0a9100..fbed698ae2 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..8fd5368fb8 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/9f615fd096..72ab3202b5 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/c58592b8d7..32b2e85c08 No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: I016442bb4af962a409d0d7dbe9397c0785c76ee7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4086933 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Charlie Lao ca263d4a 2022-11-23T12:11:49 Vulkan: Remove UsedInRunningCommands The only difference of UsedInRunningCommands() and hasUnfinishedUse() is the latter excludes the case where it has not submitted yet. But all usages are already checked if it has been submitted or not. This CL removes UsedInRunningCommands and uses hasUnfinishedUse instead. Bug: b/255414841 Change-Id: I94ef0b63a0c888219cffcdfcecfa0a095fee616b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4053262 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
angle-autoroll a3808d58 2022-12-07T18:54:35 Roll Chromium from 6a123e5dfc29 to ee01bc900c32 (481 revisions) https://chromium.googlesource.com/chromium/src.git/+log/6a123e5dfc29..ee01bc900c32 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/d286aa4250..7aa5d7d4ea * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/d1379d3f07..71c674dc56 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/8e00079800..a9779c11d2 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/2b51e6f1ec..fd5b3b5068 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/af35c6055b..efbf0a9100 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/9181906668..cf8a24d091 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/e8b385d860..e1923458e4 * third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/c5a3f52f05..a7365fc087 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..8fd5368fb8 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/25334bb18e..107142ac38 * third_party/r8: 0SzbA94FRVtzsELRN30my7jJQTeHVH65wHSU1JF2bQMC..smgiQDhBHEfz8KVdqBXas7z0ALaukjW3Yh-JVGPsFksC * tools/luci-go: git_revision:4814885a05fd7cc925933f614dc6fcc58bc83e4b..git_revision:bac571b5399502fa16ac48a1d3820e1117505085 * tools/luci-go: git_revision:4814885a05fd7cc925933f614dc6fcc58bc83e4b..git_revision:bac571b5399502fa16ac48a1d3820e1117505085 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/d9c9c23e02..22e920cc38 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/a5b1342192..c58592b8d7 * tools/skia_goldctl/linux: VJBQvPCDWNHadBXHtx4iViP5ju0oF2ZlEK5Zle80ZVUC..GYJyu-6ZtuFKlycWv9v7SFg61ONNNobNlfP0HTV6IGQC * tools/skia_goldctl/mac_amd64: 1EpS2K-VevNOMzNiw1LmYktlqKVv1SyqDm2q4DRQtNkC..SVMraIHmdNooMzoPH_0l0pHjwN9wgULMxNntBbrNQyMC * tools/skia_goldctl/mac_arm64: SXjqn6JoFOUmIaVPnyQWa19dyUeEb00rdwMuL9feyvoC..CklLGpnehytIF37cw7TK3rU3GqE_NzN76x9OERwfrNMC * tools/skia_goldctl/win: GXa5gfPznAu49j4sXrqFvYWFSD0LTIB_TVal2oqGlAIC..jmDxbBm43jkyCFWbnBLpWu8GADl05R5x2kV-ttxKaUgC No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: I8dbaf77519f111e7ca9763e99f5914d3fa8af1fa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4087002 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill 64cb7bc0 2022-12-07T11:37:38 infra: Remove toolchain from CI dashboard. With the exception of MSVC and WinUWP, all of our toolchains were "clang". This change makes it so that MSVC/UWP is combined with the OS name to make the dashboard easier to read. Bug: angleproject:7871 Change-Id: I9d86b67504ff6e12b63ddb1f520b4ea6e3f56146 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4086742 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 82eba6cd 2022-12-07T11:21:41 infra: Remove UBSAN-specific configs. Because the UBSAN flag is turned on in the ASAN builder, we don't need a separate UBSAN builder. Bug: angleproject:7871 Change-Id: I4f6c8d56bdd209efea381677b2972616b6a6df14 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4086741 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 2364578f 2022-12-07T10:33:05 infra: Enable UBSAN together with ASAN and LSAN. These flags are compatible. This should save on testing resources. Bug: angleproject:7871 Change-Id: I860e3724f54bdbf06e7530bd6bfe72ec0f53cc54 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4086283 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Yuly Novikov 583fc6a7 2022-12-07T16:21:36 Skip FramebufferExtensionsTest.ColorBufferHalfFloat on iOS Bug: angleproject:7853 Change-Id: I25f2a37a64ac2445b4eb5eb567acf32834f5e55f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4085142 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
angle-autoroll 9dc82cb3 2022-12-07T10:01:47 Roll SwiftShader from 2783f6bf0a03 to 0c98167cb31e (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/2783f6bf0a03..0c98167cb31e 2022-12-06 sugoi@google.com Merge changes I1950088a,Iecb2d8a2,I250a1541,I4dc2e503 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I85f264a26fc8007258d0f89755b9ba4c05cb5ba5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4084529 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amirali Abdolrashidi dad69cc7 2022-12-06T12:00:39 Suppress rgb_to_hsl_vertex test on Pixel 6 Bug: angleproject:7867 Change-Id: I2678c0db19fafb780245f818f365e88c7736c5ca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4083524 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
angle-autoroll 3bd0cce8 2022-12-06T09:56:58 Roll Chromium from bdfdd7d2b008 to 6a123e5dfc29 (584 revisions) https://chromium.googlesource.com/chromium/src.git/+log/bdfdd7d2b008..6a123e5dfc29 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/988bc9fa63..d286aa4250 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/1547c3fe52..d1379d3f07 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/f92e1b7e40..8e00079800 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/44d54baf42..f46bba92c0 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/fd49ee4ee9..2b51e6f1ec * testing: https://chromium.googlesource.com/chromium/src/testing/+log/2a9f393809..af35c6055b * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..d8be2db858 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ec1882fbc2..25334bb18e * third_party/turbine: 4Cvss-AYlYPcW_PIdcX45Ew7ZQwsaeurs7mUjS3LFyQC..R-Qp1tMBqIuETMfXNqQU9GB00ij6dsPjVmjDuvH_194C * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/dabb142daf..9f615fd096 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/828f44d2de..d9c9c23e02 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/cb53190619..a5b1342192 No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: I645582357f53670d974323ff9b3c2d04e3dc5852 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4083106 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Gert Wollny 384ce5cf 2022-11-29T14:18:34 Capture/Replay: Corretly reset the UnpackAlignment at end of MEC Direcly setting the value doesn't set the relevant dirty state, use the appropriate setter call instead. This fixes the reported difference between the UnpackAlignment value stored in the trace and the one recorded ruring validation for MEC. Bug: angleproject:7564 Bug: angleproject:7180 Change-Id: Ic931cac9b7e33519e992ae55ee5cab2adb2958ca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4063892 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
angle-autoroll 701ef3f2 2022-12-06T10:01:53 Roll SwiftShader from e6a3153888f0 to 2783f6bf0a03 (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/e6a3153888f0..2783f6bf0a03 2022-12-06 sugoi@google.com Change Chromium's SwiftShader owners 2022-12-06 swiftshader.regress@gmail.com Regres: Update test lists @ e6a31538 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I1e6340f37ef870026e8fb49e575ad9bccc0ce024 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4082295 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll aba757d4 2022-12-06T10:01:08 Roll vulkan-deps from ca8ca2aba961 to a497ee9d6755 (62 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/ca8ca2aba961..a497ee9d6755 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/88fd417b0b..a7603c132d * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/c214f6f2d1..1d31a10040 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/46ca66e699..40f5bf59c6 * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/b092b2fccc..891c40de1a * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/3a092fe869..82d4232f0f * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/ec541c410e..ce45337c51 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/7a9d51a51c..1f2848428c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I2feeac1a9e1fed54d9f57d4f29e926b48efa33e5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4083107 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll a9464755 2022-12-06T01:50:52 Roll SwiftShader from 6a259c87ef52 to e6a3153888f0 (24 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/6a259c87ef52..e6a3153888f0 2022-12-02 capn@google.com Use helper function for SPIR-V explicit layout storage classes 2022-12-02 sugoi@google.com Add memory allocation checks 2022-11-29 lokokung@google.com Adds some extra comment/documentation for DebugMessenger in VkInstance. 2022-11-28 lokokung@google.com Fixes leaking DebugUtilsMessenger in Instance. 2022-11-28 sugoi@google.com Unify BGRA masks 2022-11-25 sugoi@google.com Add 5/6-bit unorm support to the floating point version of writeColor 2022-11-25 sugoi@google.com Add 4-bit unorm support to the floating point version of writeColor 2022-11-25 sugoi@google.com Add 10-bit unorm support to the floating point version of writeColor 2022-11-25 sugoi@google.com Add sRGB support to the floating point version of writeColor 2022-11-25 sugoi@google.com Add 8-bit unorm support to the floating point version of writeColor 2022-11-25 sugoi@google.com Color write mask refactor 2022-11-24 sugoi@google.com Add utility function to transpose BGRA data 2022-11-24 sugoi@google.com Fix linear to sRGB conversion functions 2022-11-24 swiftshader.regress@gmail.com Regres: Update test lists @ bb5d3bdb 2022-11-24 sugoi@google.com Update SPIR-V Tools to 597631b69 2022-11-24 capn@google.com Output storage class stores have effect in helper invocations 2022-11-24 swiftshader.regress@gmail.com Regres: Update test lists @ 95c2e209 2022-11-24 capn@google.com Fix SPIRV-Tools Android.bp build, part two 2022-11-23 capn@google.com Fix SPIRV-Tools Android.bp build 2022-11-23 capn@google.com infra: Also automatically run win-swangle-try-tot-swiftshader-x64 2022-11-23 swiftshader.regress@gmail.com Regres: Update test lists @ d34588e0 2022-11-21 swiftshader.regress@gmail.com Regres: Update test lists @ d89bb011 2022-11-18 capn@google.com Update SPIR-V Tools to 1a7f71afb 2022-11-18 capn@google.com Update SPIR-V Headers to c214f6f2d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I7e9dbb80b332e11c9ea65f0ccf170e00e4440bba Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4081062 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amirali Abdolrashidi 982755e0 2022-12-05T15:32:42 Suppress VUID-vkCmdDraw-None-06887 * Suppressed the following VVLs: * VUID-vkCmdDraw-None-06887 * VUID-vkCmdDrawIndexed-None-06887 Bug: angleproject:7861 Change-Id: I15cdf934bd87b5d5219e69eebc9d339d4c180660 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4082149 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Amirali Abdolrashidi 0f7471ff 2022-12-05T16:28:41 Skip AssignAssignmentToSwizzled on SwS Linux/Win Bug: angleproject:7863 Change-Id: I9921e2e08834f793071ea07b211941bc8887b313 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4082150 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Amirali Abdolrashidi 3b57c2a8 2022-12-05T15:33:43 Add cmnt for VUID-vkDestroySemaphore suppression Bug: angleproject:7729 Change-Id: I46d8afe9702b9263a776e9acfa9a3364b7184579 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4080592 Reviewed-by: Ian Elliott <ianelliott@google.com> Auto-Submit: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
Charlie Lao 2d87551d 2022-12-05T10:47:40 Vulkan: Make mLargestAllocatedIndex atomic TSAN is complaining mLargestAllocatedIndex not thread safe. This CL makes it atomic and make it mean " the largest queue index we have ever allocated/seen" so that it will be thread safe. It is impossible to use a queueIndex before it been allocated. But it is still possible that some mUse still referencing a queueIndex after it is been released. The only downside is that we may get into slightly less optimal code path for GetBatchCountUpToSerials if we ever get into more than 64 queueIndex and then get bellow 64 again, but that should not a real concern. Bug: angleproject:7860 Change-Id: I4c99bae24e9d72298253e43f8d108444a8f46ebc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4080590 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi bd79968a 2022-12-02T14:17:14 Vulkan: Make sure program's pipeline cache is created The condition to create or use the program's pipeline cache has become quite complicated. This change simplifies things by making sure the pipeline cache is created if and when it's used, instead of guessing how it will be used and pre-create it. Bug: angleproject:7369 Change-Id: I7f3558e55f391da8c701e359d2f88d248c820de4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4076508 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao 8181c056 2022-11-22T15:34:48 Vulkan: Remove RenderPassSerial RenderPassSerial was introduced to uniquely identify a RenderPassCommands. With the work of per current context queue serial, now every started RenderPassCommands already have a unique QueueSerial. This CL removes RenderPassSerial and use renderPass's queueSerial instead. Bug: b/255414841 Change-Id: Id0a87319a9132cdb74aba195f1f05aa31454592b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4049966 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Alexey Knyazev 87815de2 2022-12-01T00:00:00 Adjust GetFramebufferAttachmentParameterivBase validation GL_FRAMEBUFFER_ATTACHMENT_COMPONENT_TYPE_EXT state queries should be allowed for ES 2.0 clients when floating-point color buffer extensions are enabled. Bug: angleproject:7853 Change-Id: I4a0a3b336e44648635233be54f598a3ab20cf717 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4071926 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
kmx.io     mail     discord kmxgit v0.4.0