kc3-lang/angle

Branch :


Log

Author Commit Date CI Message
cf03c7ae 2020-02-12 07:01:07 Roll third_party/spirv-tools/src fe10239f92f4..6c218ec60b5f (3 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/fe10239f92f4..6c218ec60b5f Created with: gclient setdep -r third_party/spirv-tools/src@6c218ec60b5f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: courtneygo@google.com Change-Id: I181af12ac2a95d8619b581c8734f38ab63e09273 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2050005 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
7adc9736 2020-02-12 07:01:05 Roll third_party/vulkan-validation-layers/src b60b35843e66..d439b17da022 (38 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/b60b35843e66..d439b17da022 git log b60b35843e66..d439b17da022 --date=short --first-parent --format='%ad %ae %s' 2020-02-12 s.fricke@samsung.com tests: Add test for 00360 2020-02-12 s.fricke@samsung.com layers: Add support for 00360 2020-02-12 s.fricke@samsung.com tests: Add tests for 01973 and 01069 2020-02-12 s.fricke@samsung.com layers: Add support for 01973 and 01069 2020-02-11 mark@lunarg.com layers: Update stateless validation doc 2020-02-11 mark@lunarg.com corechecks: Convert core val to use new logging funcs 2020-02-11 mark@lunarg.com corechecks: Converted buffer validation to new logging funcs 2020-02-11 mark@lunarg.com corechecks: Use new logging calls in shader validation 2020-02-11 mark@lunarg.com corechecks: Move helpers inside validation object 2020-02-11 mark@lunarg.com threading: Change log_msg calls to LogError calls 2020-02-11 mark@lunarg.com theading: Pass object pointer instead of report_data 2020-02-11 mark@lunarg.com corechecks: Move misplaced validation call into core validation 2020-02-11 mark@lunarg.com chassis: Changed log_msg calls to LogWarning calls 2020-02-11 mark@lunarg.com corechecks: Convert drawdispatch.cpp to new logging funcs 2020-02-11 mark@lunarg.com gpuval: Moved to new-style logging functions 2020-02-11 mark@lunarg.com corechecks: Converted descriptor_sets.cpp to new logging calls 2020-02-11 mark@lunarg.com practices: Convert WARNINGS to new logging calls 2020-02-11 mark@lunarg.com practices: Convert perf warnings to new logging funcs 2020-02-11 mark@lunarg.com practices: Change info message to warning 2020-02-11 mark@lunarg.com objlifetimes: Convert object tracker to new logging calls 2020-02-11 mark@lunarg.com stateless: Convert parameter validation to new logging calls 2020-02-11 mark@lunarg.com tests: Fix pipeline create state test 2020-02-11 s.fricke@samsung.com tests: Added test for 00701 2020-02-11 s.fricke@samsung.com layers: Added support for 00701 2020-02-11 s.fricke@samsung.com layers: Added condition to display 01427 2020-02-11 s.fricke@samsung.com layers: Added condition to display 01430 2020-02-11 s.fricke@samsung.com tests: Added test for 01988 2020-02-11 s.fricke@samsung.com layers: Added support for 01988 2020-02-11 s.fricke@samsung.com tests: Added test for 01143 2020-02-11 s.fricke@samsung.com layers: Added support for 01143 2020-02-11 s.fricke@samsung.com tests: Added test for 00317 and 00318 2020-02-11 s.fricke@samsung.com layers: Added support for 00317 and 00318 2020-02-11 raul.tambre@cleveron.com layers: Don't issue VU01564 for immutable samplers 2020-02-10 jeremy@lunarg.com tests: Test unaligned CmdPushDescriptorSet 2020-02-10 jeremy@lunarg.com layers: Validate unaligned CmdPushDescriptorSet 2020-02-10 jzulauf@lunarg.com tests: Add layout for middle subresource test 2020-02-10 jzulauf@lunarg.com layers: Fix range_vector excess erasure 2020-02-10 jeremy@lunarg.com layers: Fix unitialized variable. Created with: gclient setdep -r third_party/vulkan-validation-layers/src@d439b17da022 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: courtneygo@google.com Change-Id: I8275b4fab12c0b5124af7583c0ce1e5c0a318594 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2050004 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
58e7790c 2020-02-12 07:01:08 Roll third_party/SwiftShader b3b2a4fc756f..6cbb02e0dc93 (11 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/b3b2a4fc756f..6cbb02e0dc93 git log b3b2a4fc756f..6cbb02e0dc93 --date=short --first-parent --format='%ad %ae %s' 2020-02-11 bclayton@google.com CMakeLists: Drop the explicit include path to marl 2020-02-11 bclayton@google.com Bulk clang format 2020-02-11 bclayton@google.com Change SpirvShaderInstructions.inc extension to .inl 2020-02-11 bclayton@google.com Merge changes Ide16cac3,Id5d767fc 2020-02-11 jiaxun.yang@flygoat.com Fix MIPS build cflags 2020-02-11 bclayton@google.com Don't use std::initializer_list for array views. 2020-02-11 sugoi@google.com Support for VK_KHR_separate_depth_stencil_layouts 2020-02-11 sugoi@google.com Support for VK_KHR_create_renderpass2 2020-02-11 bclayton@google.com Revert "Add missed symbol __aeabi_idivmod for Android." 2020-02-11 gmouse@google.com Add missed symbol __aeabi_idivmod for Android. 2020-02-10 bclayton@google.com Debug: Rename levels. Created with: gclient setdep -r third_party/SwiftShader@6cbb02e0dc93 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: courtneygo@google.com Change-Id: Ie73f8091b61e7a08e6fa11aac7801d3b7f50080c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2049960 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
e1ccac7f 2020-02-11 17:45:02 Don't print INFO level log messages in Release by default. Even with dcheck_always_on. INFO level log messages will still be printed in Debug or when angle_enable_trace is enabled. Bug: angleproject:3525 Change-Id: Ic3807f94307af2878aee78426c969ab846ae3881 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2050890 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
3b82506a 2020-02-11 09:35:38 Vulkan: Command graph linearization (Step 5). Implements ES 3.1 support. Bug: angleproject:4029 Change-Id: I3c08602cf4ec64621bfdb40cd40d142b666e6edf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2046052 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
72e9f4d7 2020-02-11 11:14:35 Vulkan: Update bug number in KHR ES 3.1 expectations It was pointing to general ES 3.1 bug. Bug: angleproject:4107 Change-Id: Ief726c57d5a853d633df705eb30e8cdad3f6c9ca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2050030 Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
8c0b4889 2020-02-11 07:01:05 Roll third_party/vulkan-tools/src 428455ca6121..45b9d01815d9 (2 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/428455ca6121..45b9d01815d9 git log 428455ca6121..45b9d01815d9 --date=short --first-parent --format='%ad %ae %s' 2020-02-10 charles@lunarg.com vulkaninfo: Check for surface extensions 2020-02-10 petr_kraus@email.cz build: Fix android update not understanding headers version Created with: gclient setdep -r third_party/vulkan-tools/src@45b9d01815d9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: courtneygo@google.com Change-Id: I709bbc83ddf30dd93235b8bc731859265c8a13f1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2049668 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
1a8b7758 2020-02-11 10:34:00 Fix assignment of CacheOpResult::EnumCount The special enum value 'EnumCount' is used by EnumSize() to determine how large to make the PackedEnumMap::mPrivateData array. However, that enum entry was being assigned an incorrect value, leading to the array being constructed too small and causing a crash in PackedEnumMap's std::initializer_list constructor when it went beyond the size of the array to assign each of the necessary values. The fix is to remove the assignment of CacheOpResult::EnumCount and let it indicate the real number of entries in the enum. Bug: angleproject:4393 Test: end2end Change-Id: If9635c61e72aadc6527d416f83be18add8b24572 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2050026 Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
b40d48a6 2020-02-09 10:38:40 Vulkan: Remove ensure init from updateActiveImages. The ensure should already be triggered from the front-end. Bug: angleproject:3539 Bug: angleproject:3887 Change-Id: Ic7ee10f9c767440e55befb929b414c0c894754c9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2046051 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
cd8167fb 2020-02-10 14:17:09 Vulkan: Fix EGLBlobCacheTest. Several runs of the same test in a row would cause a failure if the cache would get hit. Fix the flakiness by resetting the cache between runs. Also cleans up some of the variable naming and adds a stream output for pretty test errors. Fixed while working on the standalone test harness. Bug: angleproject:3162 Change-Id: I64da8a37eedf562860e3e5409cbf6fb08e81dfa4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2047417 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
3c066404 2020-02-05 12:43:12 Vulkan: Command graph linearization (Step 4). Implements GLES 3.0 functionality for the new command recording style. Tested with angle_end2end_tests. dEQP/CTS testing will come later. Bug: angleproject:4029 Change-Id: Ibdc4f1355a7b880946699ec227fd9807f4a27af9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2040197 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
041ebfed 2020-02-10 13:39:34 Speed up InstancingTest.LineLoop. This test was taking 14-20 seconds in release mode. Likely because of the way we were issuing a ReadPixels and "std::endl" to a stream for every pixel of a 256x256 Framebuffer. Instead issue a single ReadPixels call and no stream flushes. Now runs in less than 500ms. Helps prevent timeouts when running tests multi-process. Also enables the test on D3D9. Bug: angleproject:3162 Change-Id: I27aad773040d6b6668cbde003802345e01044a7d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2047414 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
8257ac30 2020-02-07 14:17:08 Vulkan: Defer RenderPass image barriers. We accumulate image barriers in two places: * for GL sampler textures * for GL framebuffer attachments (Render Targets) Then we issue the barriers together in a single call before the RP. This fixes a bug where we were missing a layout transition in some cases when transitioning between a sampler and a render target. It should also be faster to issue a single barrier before a RP than issue several smaller barriers. Bug: angleproject:3539 Bug: angleproject:4029 Change-Id: I180b770f0df6b44d209e5c618ba36bcc1c6372e4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2044236 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
788fa360 2020-02-10 14:07:12 Suppress two failing NVIDIA D3D11 tests. Bug: angleproject:4391 Bug: angleproject:4392 Change-Id: I81cbf261cf206cd2d38cff93d16056c21bf78557 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2047416 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
9d86f331 2020-02-04 18:27:20 Capture/Replay: Avoid null pointer dereference in MEC Small fix to progress Manhattan MEC. Bug: angleproject:4091 Test: Working through Manhattan frames 5-10, TRex still works Change-Id: I7981e19a64f121b2ecca4451574ca2886641c6ac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2039532 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
fc1e8503 2020-02-05 10:59:27 Capture/Replay: Initial support for framebuffer textures Bug: angleproject:3662 Test: Working through Manhattan frames 5-10, TRex still works Change-Id: I3d9b4dced4c1667382154fb68839d01ba2db9b98 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2039531 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
00b96fe7 2020-02-10 07:01:08 Roll third_party/SwiftShader dd48b7e2d06e..b3b2a4fc756f (11 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/dd48b7e2d06e..b3b2a4fc756f git log dd48b7e2d06e..b3b2a4fc756f --date=short --first-parent --format='%ad %ae %s' 2020-02-08 bclayton@google.com Fix Android build: Add missing .cpp to Android.bp 2020-02-08 amaiorano@google.com Subzero: fix cosh/sinh deqp failures 2020-02-08 amaiorano@google.com ReactorUnitTests: fix clang-format messing up test suites 2020-02-08 bclayton@google.com Reactor: Copy System/Debug code to Reactor copy 2020-02-08 bclayton@google.com SpirvShaderDebugger: Ignore non-statements 2020-02-07 bclayton@google.com Debug: Control logging level using a compile time knob 2020-02-07 bclayton@google.com Fix chromium build. 2020-02-07 bclayton@google.com Debugging: Merge VkDebug into System/Debug 2020-02-07 bclayton@google.com VkDebug: Android - log messages to logcat. 2020-02-07 bclayton@google.com ReactorBenchmarks: Sweep coroutine perf. 2020-02-07 bclayton@google.com vscode: Add third_party/benchmark to include dirs Created with: gclient setdep -r third_party/SwiftShader@b3b2a4fc756f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I0fcc005ec068e5e4f1de2a08f59d137b00c81693 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2046532 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
572d63a7 2020-02-10 07:01:08 Roll third_party/glslang/src 95c414ffee64..ae59435606fc (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/95c414ffee64..ae59435606fc Created with: gclient setdep -r third_party/glslang/src@ae59435606fc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Iff9284070cc4d7446cc238f5bec31a71fa3d7509 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2046531 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
a8e6a463 2020-02-09 13:10:24 Suppress Vulkan RobustResourceInit tests. These tests are flaky because of a bug in ANGLE's Vulkan robust resource init. Mark them as failing until we can resolve the bug. Bug: angleproject:4255 Bug: angleproject:4384 Change-Id: I8e18a8532850848fc7a25e137dce27dd0d19fa55 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2046053 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
0a6e118d 2020-01-27 13:37:29 Change g_Mutex from std::mutex to std::recursive_mutex When running flatland on android-10.0.0_r21 (Pixel 3), libgui's ~EglImage calls eglTerminate which grabs angle's EGL entry point mutex. The path continues to libvulkan where eventually another egl call happens (eglDestroyImageKHR) and it will attempt to take the mutex at the entry point again. So we try to get the mutex multiple times from the same thread. Change this mutex to a recursive_mutex to allow for this re-entry of EGL calls Tests: android-10.0.0_r21/frameworks/native/cmds/flatland Bug: angleproject:4354 Change-Id: If8a817df45e9f58d5f06884510350e17d7127fa9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2029218 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
0d224cce 2020-02-05 11:00:59 Capture/Replay: Add 2DArray and 3D texture support for MEC This also includes support for compressed formats, which required a small refactor to streamline the code, since all of the entrypoints have slightly different parameter lists for imageSize and data. Bug: angleproject:3662 Test: Working through Manhattan frames 5-10, TRex still works Change-Id: I007ad9366934fff773f367ecb6387bc8b0d13aa0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2039530 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
9681190d 2020-02-05 12:51:25 Make Debug marker functions return angle::Result. Allows error handling in these functions. Necessary for the Vulkan back-end. Bug: angleproject:4209 Change-Id: I2092e58e719c6ee562807e1c7e8ad26988342855 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2040196 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
c3854ebc 2020-02-07 11:11:26 Vulkan: Clamp vertex buffer offsets. Vulkan mandates that vertex buffer offsets are within the size of the buffer even if robust buffer access is enabled. Do a check in VertexArrayVk::syncDirtyAttrib to guard against this. Bug: angleproject:3350 Change-Id: Ia01deb9b7335dd8f632f2cf9b32d2908ba55645c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2044491 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
ca035803 2020-02-06 17:24:48 Vulkan: Add missing wrapper functions for XFB. Found when working on the command graph refactor. Also replace the offsets array with nullptr which should have the same effect. Bug: angleproject:4029 Change-Id: I72e31c5403c645d72619e14aafef612e454183f1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2043270 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
51fd2958 2020-02-07 07:01:07 Roll third_party/spirv-tools/src 1f03ac10270a..fe10239f92f4 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/1f03ac10270a..fe10239f92f4 Created with: gclient setdep -r third_party/spirv-tools/src@fe10239f92f4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Icdd0cfc181c77ee14bfa4054ea849301078b184f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2043351 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
55de83af 2020-02-07 07:01:07 Roll third_party/glslang/src 656650f461c8..95c414ffee64 (2 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/656650f461c8..95c414ffee64 Created with: gclient setdep -r third_party/glslang/src@95c414ffee64 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Id3d1ccb162c60fa5c157982b11641ddab9f2558d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2043352 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
e02f4996 2020-02-06 12:26:07 Vulkan: Pass correct level count in getLevelDrawImageView This bug was hit by a KHR ES 3.1 test. This CL just applies the obvious fix already noted by jmadill@. Test: KHR-GLES31.core.shader_image_size.*-nonMS-* Bug: angleproject:4008 Bug: angleproject:4108 Change-Id: I5d05c0a7432f7b70d2b995fd8b11224c119ece5f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2042491 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
36f2c80a 2019-07-31 13:36:04 Fuchsia: Fix size & position of test window on Scenic Scenic places our window in with its center in the corner if we don't apply any translation. Therefore we only see 1/4 of the surface. Translate the surface so the full size is visible. Also account for display scaling as we're sizing in pixels and scenic is sizing in density independent pixels. Bug: angleproject:4382 Test: angle_end2end_tests Change-Id: I1ae0b877c0ed7cf9d810bb2c8317b9842bd322a1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1716226 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
3a2522de 2020-02-06 10:05:23 Make TransformFeedbackTest deterministic. Instead of using rand(), use a fixed seed RNG. This can ensure runs use the same draw call counts no matter the time of day. Note: there may have been a setting somewhere that was seeding the RNG because I wasn't seeing variation between test runs locally. This change makes it explicit. Bug: angleproject:4029 Change-Id: Ic51bf2a6779da3b96a3357eed99c0f7fa9d81648 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2042210 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
463c318a 2020-02-06 16:03:02 Roll third_party/vulkan-loader/src b932cf53f769..c731adec183b (4 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/b932cf53f769..c731adec183b git log b932cf53f769..c731adec183b --date=short --first-parent --format='%ad %ae %s' 2020-02-06 cnorthrop@google.com loader: Avoid clang warning about parentheses 2020-02-05 charles@lunarg.com loader: secure_getenv change logging WARN to INFO 2020-02-05 charles@lunarg.com loader: don't unconditionally add std-val meta layer 2020-02-05 lenny@lunarg.com loader: Fix buffer size updates in registry search Created with: gclient setdep -r third_party/vulkan-loader/src@c731adec183b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-loader-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I9fda2c484d8cf0a170fefd6f75dcf52282664ac1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2042235 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
e9dc0201 2020-02-04 12:04:28 GL: Mark unused uniform locations that were explicitly bound as ignored If a uniform location is unused, but a call to glBindUniformLocation has explicitly bound the uniform, ANGLE validation still treated the uniform as unused and returned errors. The correct behavior is to ignore the uniform and silently fail. Bug: angleproject:4374 Change-Id: Ic7b97f23cf8bc2d5380129322595e51b3d4a9fcc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2036676 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
7572c967 2020-02-06 09:26:08 Roll third_party/glslang/src b82ed734e767..656650f461c8 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/b82ed734e767..656650f461c8 Created with: gclient setdep -r third_party/glslang/src@656650f461c8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I4d5fcf594c2ce786a3ae35e613e7a0dd1a87d6d5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2041034 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
5e28a2b3 2020-02-06 07:01:07 Roll third_party/spirv-tools/src 9e52bc0d0c1d..1f03ac10270a (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/9e52bc0d0c1d..1f03ac10270a Created with: gclient setdep -r third_party/spirv-tools/src@1f03ac10270a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Iaa49097d4c41ec5b9be5dab1a5f2671bddb1f9c8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2041076 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
f5d128fa 2020-02-06 07:01:05 Roll third_party/vulkan-validation-layers/src ab47cacfd3b3..b60b35843e66 (6 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/ab47cacfd3b3..b60b35843e66 git log ab47cacfd3b3..b60b35843e66 --date=short --first-parent --format='%ad %ae %s' 2020-02-06 brucedawson@google.com Fix duplicate header file entry 2020-02-05 mark@lunarg.com tests: Revert "Call 1.2 core API using GetInstanceProcAddr" 2020-02-05 mark@lunarg.com tests: Call 1.2 core API using GetInstanceProcAddr 2020-02-05 mark@lunarg.com chassis: Limit GetPhysDevProcAddr to physical device funcs 2020-02-05 tony@lunarg.com layers: Use correct VK version when validating spec consts 2020-02-05 tony@lunarg.com tests: Use maxBoundDescriptorSets instead of hard coding Created with: gclient setdep -r third_party/vulkan-validation-layers/src@b60b35843e66 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Ie303bda1194333bba94d8d21d3b4becdc75a435b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2041075 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
010c82d4 2020-02-06 07:01:04 Roll third_party/vulkan-tools/src 260679605f98..428455ca6121 (2 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/260679605f98..428455ca6121 git log 260679605f98..428455ca6121 --date=short --first-parent --format='%ad %ae %s' 2020-02-05 timo.gurr@gmail.com vkcube: fix unknown CMake command error 2020-01-31 shannon@lunarg.com build: Update known-good for 1.2.132 header Created with: gclient setdep -r third_party/vulkan-tools/src@428455ca6121 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Ibb125e6cfecda694041c7aa83998c6510d5f7e0f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2041074 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
a5bfe7d5 2020-02-06 07:01:08 Roll third_party/SwiftShader 8e8e1d0dd729..dd48b7e2d06e (2 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/8e8e1d0dd729..dd48b7e2d06e git log 8e8e1d0dd729..dd48b7e2d06e --date=short --first-parent --format='%ad %ae %s' 2020-02-05 amaiorano@google.com Fix MSAN LLVM jit false positives 2020-02-05 bclayton@google.com Disable new gcc 9 warning [init-list-lifetime] Created with: gclient setdep -r third_party/SwiftShader@dd48b7e2d06e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I75bcfe8bc85d98104835ab9740c3c3f7c267e9fb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2041077 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
e5385ea9 2020-01-27 13:40:18 Vulkan: Compile shaders at link time Since line raster emulation was changed to use specialization constants, it has been possible to compile shaders at link time. However, program pipeline objects would have required keeping the shader sources around for recompilation. Now that all necessary decorations are modified directly in SPIR-V, it's possible to compile the shaders at link time and forget about their sources. Program pipeline objects then simply "reconfigure" the generated SPIR-V. A next step could be to also create the Vulkan pipeline object at link time. A number of failures due to gaps in CTS testing prevent that work currently. In particular, in some situations the generated SPIR-V is not per spec, for example it may contain vertex attributes with aliasing locations, or have transform feedback capture of array elements misconfigured. Bug: angleproject:3394 Bug: angleproject:4253 Change-Id: I54c0884cf056b511a4a306225cc6ed2cef84d257 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2023186 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
f1b2c4be 2020-02-05 10:22:19 Vulkan: Fix overlay with command graph disabled. Also fixes the missing RenderPass count in the new command recorder. Bug: angleproject:4029 Change-Id: If7f0cf9e80ef815781ad2684ad1d93a3ed4912ad Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2037786 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tobin Ehlis <tobine@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
25b7b846 2020-02-05 10:22:18 Vulkan: Command graph linearization (Step 3). Implements queries with the new command graph syntax. The T-Rex capture benchmark uses queries so this fixes several errors. Bug: angleproject:4029 Change-Id: Ia785f8e31257116aa3c75032dd66471b49926a78 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2021003 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tobin Ehlis <tobine@google.com>
20b1259a 2020-02-05 17:08:05 Vulkan: Command graph linearization (Step 2). ES 2.0 is feature complete. Passes all of the angle_end2end_tests with the new linear command recording method. Also runs the T-Rex benchmark without any obvious glitches. Likely has issues with creating too many RenderPasses. ES3 is mostly untouched. Bug: angleproject:4029 Change-Id: Ic5acf3d768495fbffd07b07bf0a6f2b5787c51f8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2012900 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
806ba566 2019-12-12 13:02:01 Extend ANGLE_iosurface_client_buffer to Vulkan backend for Swangle Implement an IOSurface-backed pBuffer surface for the Vulkan backend on Mac, through SwANGLE. ANGLE will pass a raw pointer to Swiftshader and handle locking/unlocking the IOSurface. Bug: chromium:1015454 Change-Id: Ia3ead55334736003d405b54ba8dcc7701706fbb2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1965434 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
5641d193 2020-02-04 21:31:47 Move generic code from rx::DisplayAndroid/Ozone to rx::DisplayEGL This CL is intended to move and factorize code only. Move DisplayAndroid::generateConfigs to DisplayEGL::generateConfigs because the code is generic and not Android specific. It will be useful later to provide a default implementation of rx::DisplayEGL. Same for createWindowSurface and createPbufferSurface, they have been moved without changes from DisplayAndroid to DisplayEGL. Unimplemented functions in DisplayOzone and DisplayAndroid have been moved to DisplayEGL. Bug: angleproject:4328 Change-Id: Ibbd36f99ea457cbd69391beb4a83f23403bc40fb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2038286 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
a44d96dc 2020-02-05 14:20:59 Apply compressed format workarounds to texStorage entrypoints Bug: angleproject:4266 Change-Id: I70b3cdef35395b3a92bd460c9911b1ed963e0dcd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2038573 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
eb63016d 2020-02-04 16:15:41 Add environment overrides for ANGLE features. Allows the application to override ANGLE behaviour without having to modify the code or use the ANGLE extension. Useful for testing with the command graph refactor. Adds a new string utility for parsing lists of strings from environment variables. Bug: angleproject:4029 Change-Id: Ibae93b743c0c385392cd259d9604ce2f2ed988dc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2037784 Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
9c62f66c 2020-02-05 09:09:08 Roll third_party/glslang/src 540662253ea3..b82ed734e767 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/540662253ea3..b82ed734e767 Created with: gclient setdep -r third_party/glslang/src@b82ed734e767 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I74671608ecc264f49611e82a3c9ef0a3e4930b9f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2038127 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
ec816af6 2020-02-05 07:01:02 Roll third_party/vulkan-loader/src 807f14657a25..b932cf53f769 (3 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/807f14657a25..b932cf53f769 git log 807f14657a25..b932cf53f769 --date=short --first-parent --format='%ad %ae %s' 2020-02-04 lenny@lunarg.com loader: Add core 1.2 functions to gpa_helper 2020-02-04 charles@lunarg.com loader: add null check to loaderValidateLayers 2020-02-04 charles@lunarg.com loader: Warn when loader_secure_getenv() fails Created with: gclient setdep -r third_party/vulkan-loader/src@b932cf53f769 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-loader-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I6b37613fe780e0d146def7885657b17495b1c93f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2038120 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
d81ec05e 2020-02-05 07:01:08 Roll third_party/SwiftShader 41a7302e9c62..8e8e1d0dd729 (4 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/41a7302e9c62..8e8e1d0dd729 git log 41a7302e9c62..8e8e1d0dd729 --date=short --first-parent --format='%ad %ae %s' 2020-02-04 bclayton@google.com Shader: Add missing switch cases to operationString 2020-02-04 bclayton@google.com OpenGL: Fix switch with only a default case. 2020-02-04 amaiorano@google.com Regres: fix no env-vars for deqp on Windows 2020-02-04 lfy@google.com android: avoid exporting normal Vulkan APIs Created with: gclient setdep -r third_party/SwiftShader@8e8e1d0dd729 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Ia9ff11bbc842f324e2b65745fd6647cede0ba138 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2038122 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
a4053e2c 2020-02-05 07:01:05 Roll third_party/vulkan-validation-layers/src e85fe4c3cc9f..ab47cacfd3b3 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/e85fe4c3cc9f..ab47cacfd3b3 git log e85fe4c3cc9f..ab47cacfd3b3 --date=short --first-parent --format='%ad %ae %s' 2020-02-04 tony@lunarg.com gpu: Use updated interface to instrumentation Created with: gclient setdep -r third_party/vulkan-validation-layers/src@ab47cacfd3b3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Icfbd19b525474b1d3aabe96bb741c5f30c856af1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2038176 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
7f2d013e 2020-02-05 07:01:07 Roll third_party/spirv-tools/src 7a2d408dea60..9e52bc0d0c1d (11 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/7a2d408dea60..9e52bc0d0c1d Created with: gclient setdep -r third_party/spirv-tools/src@9e52bc0d0c1d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Ie6f6f11d84983936e736d7293c5e48d7add4d24e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2038121 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
f764fc02 2020-02-03 10:33:58 Fix varying linking by location This change breaks the assumption everywhere that varyings can be identified uniquely by name throughout all stages of the pipeline. It further implements linking of varyings by location, if specified. Bug: angleproject:4355 Change-Id: Ie45e48879008c3f0c22d1da3d0d26f37c655e54e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2030026 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
58fc8b11 2020-01-31 19:03:12 Implement RGTC (BC4, BC5) compressed texture formats gl.xml was modified as two enums were missing from their proper group. dxgi_support_data.json was fixed to not expect BC4 and BC5 on FL9_3 Bug: angleproject:3149 Change-Id: Ieb97a8cf8e92258c1b44e090e823fac227997174 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2033068 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Kenneth Russell <kbr@chromium.org>
4933d9d2 2020-01-16 13:16:45 Capture/Replay: Track compressed texture data Rather than try to read back compressed data using ANGLE_get_image (which does not yet support compressed formats), track a shadow copy of the compressed image and store it like client data. Test: Mid-execution capture and replay of TRex frames using ETC1 Bug: angleproject:4036 Change-Id: Id15be60f7444cc2e1356e76ff18069c42e552663 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2015818 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
3e691bb9 2020-02-03 14:25:03 Vulkan: Count active renderpasses in overlay. Useful debugging information for benchmarks. Also helpful when working with the command graph to ensure we don't regress performance. Bug: angleproject:4029 Bug: angleproject:4320 Change-Id: Ibe224c40a3acaca9231bf3869486a0f8bba07ba0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2036402 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Tobin Ehlis <tobine@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
d8c4b5fb 2020-01-31 16:47:51 Expose ASTC 2D on OpenGL Bug: angleproject:4372 Change-Id: Ic1800ac10b12547ca9816f7ad9dfd62f83f227c0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2033066 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org>
9e774041 2020-01-31 15:09:01 Update S3TC GL extension strings Added avoid_dxt1_srgb_texture_format workaround Bug: angleproject:4266 Change-Id: I286a9c66f6ea1d2c9d3587f6ca85608336eb44a6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2033065 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
0536fb47 2020-02-04 07:01:02 Roll third_party/vulkan-loader/src fb94ccddb725..807f14657a25 (2 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/fb94ccddb725..807f14657a25 git log fb94ccddb725..807f14657a25 --date=short --first-parent --format='%ad %ae %s' 2020-02-03 lenny@lunarg.com build: Regenerate files for debug utils changes 2020-02-03 lenny@lunarg.com loader: Fix debug utils terminators being skipped Created with: gclient setdep -r third_party/vulkan-loader/src@807f14657a25 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-loader-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I85fda88b6f1cb17e1e9bae96431471a77d6f73ae Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2036416 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
31f43a63 2020-02-04 08:31:08 Roll third_party/glslang/src 5e86b28ffb81..540662253ea3 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/5e86b28ffb81..540662253ea3 Created with: gclient setdep -r third_party/glslang/src@540662253ea3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I42d8f32fdc6b12dff781f426a7c099458f556056 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2036425 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
aa6dd50d 2020-02-03 17:10:58 Share scratch buffers between contexts. The Display now owns scratch buffers and loans them out to contexts while they are current. This allows us to to only allocate one scratch buffer in a single-threaded use case. Tick the scratch buffers every time a new context is made current. Lower the lifetime from 1000 to 64 to ensure that in the worst case, the buffers are cleared after not being used for ~1 second. BUG=chromium:1030835 BUG=angleproject:4363 Change-Id: I83552424e2beac62b9e41152876b04fc84f53692 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2031698 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Zhenyao Mo <zmo@chromium.org>
4546c5ce 2020-01-31 15:05:35 Skip failing end2end tests on Windows on ARM There are multiple failing tests on Windows on ARM which are related to drawing differences. They seem to be similar to an already reported issue (anglebug.com/3748). Bug: angleproject:4356 Bug: angleproject:4357 Change-Id: Ide5cc2e6f42d4c4b6fb88352833d20e517005c14 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2033067 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
326c900e 2020-02-03 07:01:05 Roll third_party/vulkan-validation-layers/src bd4b3a888fca..e85fe4c3cc9f (3 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/bd4b3a888fca..e85fe4c3cc9f git log bd4b3a888fca..e85fe4c3cc9f --date=short --first-parent --format='%ad %ae %s' 2020-01-31 s.fricke@samsung.com tests: Added tests for Ycbcr in vkCreateImage 2020-01-31 s.fricke@samsung.com layers: Added Ycbcr support in VkImageCreateInfo 2020-01-31 tony@lunarg.com layers: Use safe_VkImageCreateInfos Created with: gclient setdep -r third_party/vulkan-validation-layers/src@e85fe4c3cc9f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: tobine@google.com Change-Id: I7c9dc2a0b4aed5232065fa44edda034cd72d9f6c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2035158 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
3861bbea 2020-02-03 07:01:08 Roll third_party/SwiftShader 79b36b640692..41a7302e9c62 (3 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/79b36b640692..41a7302e9c62 git log 79b36b640692..41a7302e9c62 --date=short --first-parent --format='%ad %ae %s' 2020-01-31 capn@google.com Split JIT creation from LLVMReactor.cpp into LLVMJIT.cpp 2020-01-31 bclayton@google.com CMake: Add build rules for google benchmark. 2020-01-31 bclayton@google.com Add google benchmark submodule to third_party. Created with: gclient setdep -r third_party/SwiftShader@41a7302e9c62 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: tobine@google.com Change-Id: I4d800b6768fae30052cbc2ca56e42973b1756ad5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2035159 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
fed0dda1 2020-01-31 12:59:31 Remove getIndexRange call from ValidateDrawRangeElements The spec doesn't require implementation to validate indices against range. This extra validation is costing performance dearly, thus should be removed. Bug: angleproject:4373 Change-Id: I61b0628e75de368d9e869008b7c99c429222fd6f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2033495 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Tobin Ehlis <tobine@google.com>
49a53d68 2020-01-30 16:30:30 Vulkan: Request used features Some features were used but not enabled. There is no validation error for this. This change enables the following features: - shaderStorageBufferArrayDynamicIndexing: used by atomic counter emulation. - shaderSampledImageArrayDynamicIndexing: used by sampler array of array emulation, as well EXT_gpu_shader5. - shaderUniformBufferArrayDynamicIndexing: used by EXT_gpu_shader5. Bug: angleproject:4071 Change-Id: I582750d1552055deeec50485e6511788b98490c2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2032144 Reviewed-by: Tobin Ehlis <tobine@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
07795d47 2020-01-31 16:08:52 Disable rewriteRowMajorMatrices workaround. It's causing flaky crashes in tests. Leave the revised code in place so it's easier to debug. Disable test which required the workaround. Bug: angleproject:2273 Bug: angleproject:3843 Change-Id: Iebb682bd3c6282031cc57eda5d3d4d5636be7294 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2033870 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org>
a8c7e10f 2020-01-28 19:50:38 Fuchsia: Switch ScenicWindow to use PresentOrReplaceView This avoids a deprecation warning: [01253.076] [WARNING:src/ui/bin/root_presenter/app.cc(109)] Using multiple presentations is deprecated. Call PresentOrReplaceView() to force replacement of current presentation. Bug: angleproject:4360 Change-Id: Icb1898ee542bde8c26a2dcd55c783372fc8ae7c1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2027935 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
f63fbcd5 2020-01-29 16:13:56 Fuchsia: Limit number of concurrent presents in ScenicWindow The test suite occasionally runs into the following error: [02036.794449][326733][326738][klog] INFO: [ERROR:src/ui/scenic/lib/scenic/session.cc(412)] Scenic session error (session_id: 1): Present2() called with no more present calls allowed. Terminating session. This is actually a problem with the test harness as resetting the window triggers a present with no fences and no OnFramePresentedCallback which means there is no way to know if we will exceed the limit. Add an OnFramePresentedCallback and count presents to stay under the limit. This blocks if there's more than 2 in flight presents. A dedicated async loop is used to avoid re-entering other code while waiting to present (there is no such case in the ANGLE test suite currently, but better safe than sorry). Typically if we run the whole suite there will be a failure in the middle, but re-trying the test that failed won't repro the issue. Add a test that reliably exhausts the limit by calling resetNativeWindow() in a loop. Bug: angleproject:4360 Change-Id: I24eb01fd72fc0be57c36e49b5875023a80d6ab91 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2027934 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
a36f8bd4 2020-01-29 12:10:17 Mark MemoryBuffer allocation functions as NO_DISCARD Not all call sites were checking the return value of MemoryBuffer::resize, mark the return value as NO_DISCARD and fix all the warnings. BUG=chromium:1030835 Change-Id: I762796e3d11efc131a814069d78a195b0d4c9f8f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2028151 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
1736c47b 2020-01-31 11:16:41 Vulkan: Remove transient cmd buffer workaround We no longer need this workaround. Also mCommandPoolFreeList dead code. Bug: angleproject:3508 Change-Id: Ib73ddd431eb1bf9a55c3421111af4df5976cc1fb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2033485 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tobin Ehlis <tobine@google.com> Commit-Queue: Tobin Ehlis <tobine@google.com>
21a3262e 2020-01-31 17:35:05 Roll third_party/vulkan-validation-layers/src 8317b28e672a..bd4b3a888fca (27 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/8317b28e672a..bd4b3a888fca git log 8317b28e672a..bd4b3a888fca --date=short --first-parent --format='%ad %ae %s' 2020-01-31 tobine@google.com build: Add NOMINMAX to Win ninja build 2020-01-30 mark@lunarg.com build: Move NOMINMAX definition from src to cmake file 2020-01-29 shannon@lunarg.com build: Update known-good for 1.2.132 header 2020-01-28 tony@lunarg.com layers: Fix call to overwrite_range 2020-01-28 s.fricke@samsung.com tests: Added test for VUID 02283 2020-01-28 s.fricke@samsung.com layers: Added VUID 02283 2020-01-28 tony@lunarg.com tests: Add test for 02829 and 02830 2020-01-28 tony@lunarg.com layers: Add validation for 02829 and 02830 2020-01-28 s.fricke@samsung.com layers: Removed redundant sType check 2020-01-28 s.fricke@samsung.com layers: Fix shader not looping correctly 2020-01-27 jeremy@lunarg.com tests: Test specialization constant size 2020-01-27 jeremy@lunarg.com layers: Fix specialization constant size 2020-01-27 tony@lunarg.com tests: Better checking for 1.2 2020-01-24 jzulauf@lunarg.com layers: Optimize descriptor allocation 2020-01-23 Andrew.Fobel@amd.com tests: Add tests for VK_EXT_separate_stencil_usage 2020-01-23 Andrew.Fobel@amd.com layers: Add VK_EXT_separate_stencil_usage support 2020-01-23 jzulauf@lunarg.com build: Update copyright header dates for modified 2020-01-23 jzulauf@lunarg.com layers: Bug fix for parallel iterator 2020-01-23 jzulauf@lunarg.com layers: performance tune ImageSubresourceLayoutMap 2020-01-23 jzulauf@lunarg.com layers: implement small range map and wrapper 2020-01-23 jzulauf@lunarg.com layers: Cleanups and fixes from further unit test 2020-01-23 jzulauf@lunarg.com layers: Fix ImageLayoutIntialState tracking 2020-01-23 jzulauf@lunarg.com layers: Add range map view to image_layout 2020-01-23 jzulauf@lunarg.com layers: Apply google style to new image layout impl 2020-01-23 jzulauf@lunarg.com layers: ImageLayout traversal to iterators 2020-01-23 jzulauf@lunarg.com layers: Refactor heavyweight ForRange/Iterator 2020-01-23 jzulauf@lunarg.com layers: New sparse map for image subresource data Created with: gclient setdep -r third_party/vulkan-validation-layers/src@bd4b3a888fca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: tobine@google.com Change-Id: Ib96b03f57e54f3e39573482c56cae1a2bd0970a3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2033407 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
4dc1eb42 2020-01-31 14:05:46 Add UWP builders to CQ Also update doc. Bug: angleproject:3928 Change-Id: I1134e1fa9338fa95d647502bf62edb42555caec8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2033487 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
a805ac7c 2020-01-31 10:54:21 Allow overriding ANGLE_PLATFORM_EXPORT. Bug: angleproject:4365 Change-Id: I4098ebdd718624e9d0578e0ee69f0a84a5b78183 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2033064 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
71153201 2020-01-29 14:42:30 Vulkan: Disable restartRenderPassAfterLoadOpClear workaround This workaround was added due to qualcomm driver bug b/129281932. But this has been fixed with recent drivers. Removing the WR here so that it will not negatively affect performance. Bug: angleproject:4344 Change-Id: Iea2ec86082a0ced64bfe843bf916c6bdb2aea60b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2029210 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Tobin Ehlis <tobine@google.com>
e580ca8b 2020-01-29 16:21:05 Capture/Replay: Implement Manhattan ES 3.0 support Populate the entrypoints required to get gfxBench Manhattan scene to capture and replay correctly from the beginning of the trace. Test: Captured and replayed Manhattan frames 0-500 on both Windows and Linux (Nvidia GPUs) Bug: angleproject:4091 Change-Id: I5447a6835e55e944772d37219f2bd414606f0a70 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2029216 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
c73475fb 2020-01-29 11:37:05 Vulkan: Fix UtilsVk dirtying driver uniforms descriptor set binding Most UtilsVk functions bind a descriptor set to index 0 (same as driver uniforms). If that happens to close a render pass, all is well as starting a new render pass ensures all descriptor sets are rebound. However, if the render pass is not closed, or if a dispatch call is issued (which never rebinds descriptor sets if not explicitly necessary), then the driver uniforms descriptor set may end up never rebound, causing a validation error (and possible crash or corruption). This change makes sure that UtilsVk notifies the context when it binds a descriptor set. The context then dirties the driver uniforms binding as appropriate. Bug: angleproject:4272 Change-Id: Ief20c7884fbe39712f844247489812afc70b30a9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2027938 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
5de415c5 2020-01-31 07:01:09 Roll third_party/SwiftShader 6c3dc3581eaf..79b36b640692 (13 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/6c3dc3581eaf..79b36b640692 git log 6c3dc3581eaf..79b36b640692 --date=short --first-parent --format='%ad %ae %s' 2020-01-30 capn@google.com Fix use after free 2020-01-30 capn@google.com Have Kokoro accept imports from Piper 2020-01-30 amaiorano@google.com Subzero: fix incorrect cast 2020-01-30 capn@google.com Export Vulkan API entry functions 2020-01-30 capn@google.com Support LLVM 9+ build changes 2020-01-30 bclayton@google.com Regres: Fix unix build 2020-01-29 capn@google.com Regres: aways use build output path for ICD json 2020-01-29 capn@google.com Associate bug IDs with unimplemented functionality 2020-01-29 amaiorano@google.com Fix memory leak in rr::Optimizer 2020-01-29 bclayton@google.com Regres: Make it work on windows. 2020-01-29 amaiorano@google.com Subzero: implement coroutines for Win32 2020-01-29 bclayton@google.com SpirvShaderDebugger: Expose builtins in HLSL / GLSL. 2020-01-29 bclayton@google.com Vulkan/Debug: Add VariableContainer::extend() Created with: gclient setdep -r third_party/SwiftShader@79b36b640692 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: tobine@google.com Change-Id: I9ef2fb4008e8f9061df5b71bbf532f20a9caf188 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2032848 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
dd0f12d0 2020-01-31 07:01:04 Roll third_party/vulkan-tools/src ebe1b7497acb..260679605f98 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/ebe1b7497acb..260679605f98 git log ebe1b7497acb..260679605f98 --date=short --first-parent --format='%ad %ae %s' 2020-01-29 jeremyk@lunarg.com build: Update MoltenVK version in known_good.json Created with: gclient setdep -r third_party/vulkan-tools/src@260679605f98 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: tobine@google.com Change-Id: Ia19dd5c1d3ce0bfbd2197c8e8482b9cd6572399d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2032835 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
e5dbecac 2020-01-31 07:01:02 Roll third_party/vulkan-loader/src 44ac9b2f406f..fb94ccddb725 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/44ac9b2f406f..fb94ccddb725 git log 44ac9b2f406f..fb94ccddb725 --date=short --first-parent --format='%ad %ae %s' 2020-01-28 shannon@lunarg.com build: Update known-good for 1.2.132 header Created with: gclient setdep -r third_party/vulkan-loader/src@fb94ccddb725 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-loader-angle-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: tobine@google.com Change-Id: I4e12eb0260422c2dc86f2a71cc60fbf321647dd2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2032834 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
2742cd10 2020-01-31 07:01:07 Roll third_party/spirv-tools/src 97f1d485b763..7a2d408dea60 (4 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/97f1d485b763..7a2d408dea60 Created with: gclient setdep -r third_party/spirv-tools/src@7a2d408dea60 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: tobine@google.com Change-Id: Ia823c5eff6f7513d78345ef6d0193c026e0bf19e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2032837 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
689295e3 2020-01-31 07:01:08 Roll third_party/glslang/src 9a80305c0897..5e86b28ffb81 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/9a80305c0897..5e86b28ffb81 Created with: gclient setdep -r third_party/glslang/src@5e86b28ffb81 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: tobine@google.com Change-Id: Ia4b90712005cf624f973a43dca3e335f552f963b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2032838 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
088b1baa 2020-01-30 17:53:07 Change uuid attributes to declspec in winrt. Due to warning C4467: usage of ATL attributes is deprecated Bug: angleproject:3928 Change-Id: I6620acc85ae974445a2a01fc109568fac8c3b23b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2032152 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
e196bc85 2020-01-17 13:11:20 Add driver bug workaround for rewriting row major matrices. Joint work with syoussefi@, who wrote the RewriteRowMajorMatrices pass, and revised it for this CL to not rely on the NameNamelessUniformBuffers pass - which was breaking it on the GL backend. Hook up previously written RewriteRowMajorMatrices transformation, and enable on all GPU types on macOS. It is needed at least for AMD and Intel GPUs. Add a new test which verifies the behavior of dynamically-indexed arrays of row-major matrices. Bug: angleproject:2273 Bug: angleproject:3843 Change-Id: Id582f9cf6b9b1a59091aab1786539174f360b705 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2008717 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
c8e486b1 2020-01-30 13:23:42 Roll chromium_revision e1633af636..8ffb18d0b9 (724302:736949) To include Windows toolchain with UWP support from build. Change log: https://chromium.googlesource.com/chromium/src/+log/e1633af636..8ffb18d0b9 Full diff: https://chromium.googlesource.com/chromium/src/+/e1633af636..8ffb18d0b9 Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/dfe5662014..e5293d8fa2 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/6b3e658d6f..afc5b798c7 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/c1b508625d..cf6ed46cff * third_party/googletest: https://chromium.googlesource.com/chromium/src/third_party/googletest/+log/f8eeeb06c0..c83f99e10c * third_party/jsoncpp: https://chromium.googlesource.com/chromium/src/third_party/jsoncpp/+log/1cfec065ed..493c9385c9 * third_party/libjpeg_turbo: https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/bc13578529..ce0e57e8e6 * third_party/yasm: https://chromium.googlesource.com/chromium/src/third_party/yasm/+log/02a8d2167f..0d0134789a * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/f262c1b3c4..b9b9a5af7c * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/a9190d6699..953ea7aff8 DEPS diff: https://chromium.googlesource.com/chromium/src/+/e1633af636..8ffb18d0b9/DEPS Clang version changed c2443155a0fb245c8f17f2c1c72b6ea391e86e81:eaabaf7e04fe98990a8177a3e053346395efde1c Details: https://chromium.googlesource.com/chromium/src/+/e1633af636..8ffb18d0b9/tools/clang/scripts/update.py TBR=ynovikov@chromium.org, Bug: angleproject:3928 Change-Id: I8346ac7f178e73388d3dda26c6994302ece79585 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2031764 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
d9884d3e 2020-01-29 15:26:39 Vulkan: Don't dirty index/vertex buffers on each syncState. This will help for the command graph refactor so we can set up the command buffer barriers before we start the render pass for draw. Bug: angleproject:3539 Bug: angleproject:4029 Change-Id: If5a55db6ac1e06609a3a1e2245d7ab351152886a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2028450 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
ee07cb31 2020-01-29 18:02:50 Test Harness: Allow filter with sharding params. Some tweaks to when we call gtest initialization allows this to work. Bug: angleproject:3162 Change-Id: I75159108d3f746f666e57c1a6495a8c8616ef1cf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2024335 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
12c0e765 2020-01-29 13:00:40 Add GN arg to extract native libs in APK Added GN bool arg "angle_extract_native_libs." When "false," which is the default, the native libs are zipped in the ANGLE apk. When true, the libs will be extracted which is useful when capturing flame graphs in order to see the ANGLE function names in your flamegraph. Bug: angleproject:4304 Change-Id: I86c91e5028688142b1137b859c800f2243c124d9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2028524 Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Tobin Ehlis <tobine@google.com>
e4859ae5 2020-01-27 15:21:58 Fix re-enabling ARB_texture_rectangle My earlier change https://crrev.com/c/1991969 had a bug. If ARB_texture_rectangle is disabled once, it can't be re-enabled because the extension behavior entry is deleted. ResetExtensionBehavior needs to restore it. Bug: angleproject:3770 Change-Id: Icf96acece8ea8d17287c8d09fb4849b61c9c2a36 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2023398 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org>
80da4214 2020-01-29 10:12:31 D3D11: Copy from Image objects instead of TextureStorage when possible. glCopyTextureCHROMIUM calls in D3D11 would call getNativeTexture on the copy source which would allocate a TextureStorage11 if one did not already exist. This caused full mip-chain allocations in some cases when we could have just copied directly from the staging Image11. When navigating to wikipedia.org: Peak memory | Stable memory Passthrough (before): 142 mb | 119 mb Passthrough (after): 138 mb | 106 mb Validating: 139 mb | 110 mb No mip-mapped textures were allocated after this change. BUG=chromium:1030835 Change-Id: Icd14afaec445299423cfea293cba501d774f6ade Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2028147 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Rafael Cintron <rafael.cintron@microsoft.com>
053929ac 2020-01-24 18:15:38 Fuchsia: Enable perFrameWindowSizeQuery by default Fuchsia won't return VK_ERROR_OUT_OF_DATE_KHR after a size change, so we need to check every frame. In fact we don't even tell Scenic what the new size is during resize, because it does not care - the surface size determines the "window size", not the other way around. Bug: angleproject:4348 Change-Id: I8f9af0d1379f4993865c7ccedc9aba3cab90cf54 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2023914 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
33027d3e 2020-01-28 16:08:02 Enable GL_OES_depth_texture_cube_map with Vulkan backend GL_OES_depth_texture_cube_map depends on depthTextureOES, but adds the same new texture format/type requirements as GL_OES_packed_depth_stencil, so instead of adding a specific check for GL_OES_depth_texture_cube_map, the Vulkan backend checks for a combination of GL_OES_depth_texture and GL_OES_depth_texture_cube_map to enable GL_OES_depth_texture_cube_map. ANGLE has no specific checks for whether a format is "cubemappable", but Vulkan has no restrictions of the format of cubemaps, so if the proper formats are supported, creating a cube of any of these formats should be implicitly supported. Bug: angleproject:4293 Change-Id: I968dbe8869ba0f50de18dd41f1195e847c06b520 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2026027 Commit-Queue: Alexis Hétu <sugoi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
09d51a57 2020-01-24 17:28:24 Fuchsia: Skip PointSpriteAlternatingDrawTypes on ARM Fuchsia This is not passing currently, skip it for now. Bug: angleproject:4349 Change-Id: If36a144e8d17cc94c2186a7a794358b14223349e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2023913 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
eca11cc8 2020-01-28 14:18:40 SH_CLAMP_INDIRECT_ARRAY_BOUNDS logic update Remain the old hardware requirement for turning on clampArrayAccess. But also turns it on universally for WebGL context. So that we won't suffer from clampArrayAccess not handled properly on some compute shader deqp tests. Bug: chromium:1042252, angleproject:4361 Change-Id: Ib11affd6df27ce7d2100980d2b8decdee36876e8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2026029 Reviewed-by: James Darpinian <jdarpinian@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com>
b91acdcf 2020-01-21 11:02:26 Vulkan: Cleanup glslang wrapper There are no longer @@ QUALIFIER and or @@ LAYOUT markers. Only @@ XFB-DECL @@ and @@ XFB-OUT @@ markers remain, which are now replaced with simple string manipulation. Bug: angleproject:3394 Change-Id: I9c1883458d9de3ea59ac08aae57a7c8985e7afbe Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2012741 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
cb2b5136 2020-01-10 11:04:38 Vulkan: Simplify format table generation Remove the "override" table. That gets in the way of some solutions. If a format cannot be supported by a native Vulkan format as indicated in the "map" table, then check fallbacks. Also add support for native RGBA4 and R5G5B5A1 support. Previously those formats would be emulated with RGBA8 due to the override, but now code will check if the native format is available and use it. Bug: angleproject:4282 Change-Id: Ib33ea40543d91a2c2a95075b277f825a8822037c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1994538 Reviewed-by: Tobin Ehlis <tobine@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
f1f082e1 2020-01-17 14:53:38 Vulkan: Set varying location & xfb decorations in SPIR-V The shader translator outputs arbitrary location indices. Once compiled by glslang, the SPIR-V transformer modifies these decorations. If the transform feedback extension is used, it will also add the relevant decorations to the varyings that are captured. Bug: angleproject:3394 Change-Id: I5ecafd0536408612a5d4b920dbabbfabe650657c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2008468 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
05e08edf 2019-12-26 20:58:48 Disable skipValidation when context is lost. Lost no-error contexts should gracefully handle GetProgramiv, etc. Includes test that a lost no-error context doesn't crash on getProgramiv. Firefox bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1601703 Bug: angleproject:4244 Change-Id: I8c37df37e83308ab85ad958df6dab46b0ab348e1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2003239 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
13c44dfe 2020-01-29 07:01:22 Roll third_party/glslang/src 07a55839eed5..9a80305c0897 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/07a55839eed5..9a80305c0897 Created with: gclient setdep -r third_party/glslang/src@9a80305c0897 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: tobine@google.com Change-Id: I3161499b3a6b2e3ad96ef5952782c4409289fa1c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2027195 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
71508b20 2020-01-29 07:01:06 Roll third_party/vulkan-tools/src e39b5cf6a1b6..ebe1b7497acb (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/e39b5cf6a1b6..ebe1b7497acb git log e39b5cf6a1b6..ebe1b7497acb --date=short --first-parent --format='%ad %ae %s' 2020-01-28 charles@lunarg.com vulkaninfo: use patch version from instance Created with: gclient setdep -r third_party/vulkan-tools/src@ebe1b7497acb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: tobine@google.com Change-Id: I878644e5a636c1a21740dda675b6199a86b9f118 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2027217 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
1f4ddc96 2020-01-29 07:01:08 Roll third_party/SwiftShader 34e16df059f8..6c3dc3581eaf (2 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/34e16df059f8..6c3dc3581eaf git log 34e16df059f8..6c3dc3581eaf --date=short --first-parent --format='%ad %ae %s' 2020-01-28 capn@google.com Support LLVM 8+ build changes 2020-01-28 bclayton@google.com SpirvShaderDebugger: Fix double nesting of struct members Created with: gclient setdep -r third_party/SwiftShader@6c3dc3581eaf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: tobine@google.com Change-Id: Ie221229f552143cbb8c98b731b5bd4fdd3a17195 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2027194 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
5ca050d1 2020-01-20 14:59:41 Vulkan: Set fragment output locations in SPIR-V The shader translator outputs arbitrary location indices for fragment outputs. Once compiled by glslang, the SPIR-V transformer modifies these decorations. Bug: angleproject:3394 Change-Id: Ib9d8336bccc392e789e4d93031fdcce9c466b7a6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2011214 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
bef8ca7d 2020-01-20 14:19:05 Vulkan: Set vertex attribute locations in SPIR-V The shader translator outputs arbitrary location indices for vertex attributes. Once compiled by glslang, the SPIR-V transformer modifies these decorations. Bug: angleproject:3394 Change-Id: I88453b44e3a8770f51e79228148233ff308f1885 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2011212 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>