kc3-lang/angle

Log

Author Commit Date CI Message
Yuly Novikov d51c2516 2024-08-26T14:30:12 Add iOS build instructions. Bug: angleproject:40096751 Change-Id: I3168663374906afbdec5a4ad5398704dbcf3731d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5812088 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Alexey Knyazev 966d0a1a 2024-08-20T00:00:00 Metal: Cleanup memoryless storage mode support detection Bug: angleproject:360147119 Change-Id: Ic47f1d84e748f65194aa819a39418db66b1948c3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5802956 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com>
Yuly Novikov 8281af52 2024-08-15T16:26:02 Skip timing out end2end tests on Samsung S24 Xclipse. Add GALAXYS24 expectation tag and skip: FramebufferTest_ES31.ChangeFBOSizeAndAttachmentsCount FramebufferTest_ES31.ChangeFBOSizeWithNoAttachments FramebufferTest_ES31.CreateNoAttachmentFBOWithDifferentSize FramebufferTest_ES31.RenderingLimitToDefaultFBOSizeWithNoAttachments Bug: angleproject:359904354 Change-Id: If88fa3876b7fcf534d99fee75b5aa4fa6da140c6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5808948 Reviewed-by: Solti Ho <solti@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Alexey Knyazev 003737c8 2024-08-20T00:00:00 Metal: Adjust texture storage mode compile guards Used managed mode only for macOS and Mac Catalyst compile targets. Fixed compilation for visionOS. Bug: angleproject:360147119 Change-Id: I88fae28ff6d1ecb5ba303d32c4a3874bf3f8aa87 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5802959 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Alexey Knyazev a36c459e 2024-08-20T00:00:00 Metal: Remove redundant symbol redeclarations MTLBlitOptionRowLinearPVRTC - macOS 11.0 (min compile 12.0) - iOS/tvOS 9.0 (min compile 17.0) MTLBarrierScope - macOS 10.14 (min compile 12.0) - iOS/tvOS 12.0 (min compile 17.0) MTLBarrierScopeRenderTargets - Moved compile guards to call sites MTLRenderStages, MTLRenderStageVertex, MTLRenderStageFragment - macOS 10.13 (min compile 12.0) - iOS/tvOS 10.0 (min compile 17.0) Bug: angleproject:360147119 Change-Id: I7dac46accde63be486a7de918284bbd6e8367a4e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5806896 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Alexey Knyazev 1f1b7426 2024-08-20T00:00:00 Metal: Remove compile guards for preserveInvariance MTLCompileOptions.preserveInvariance - macOS 11.0 (min compile 12.0, min deploy 10.15) - iOS/tvOS 14.0 (min compile 17.0, min deploy 15.0) Bug: angleproject:360147119 Change-Id: I54bd75f3136e907ebb738b855f12b80f3c161b41 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5806898 Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
angle-autoroll ddec94e6 2024-08-26T10:01:09 Roll vulkan-deps from d95811d4259d to 38174d6926f6 (8 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/d95811d4259d..38174d6926f6 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/d205aff40b4e15d4c568523ee6a26f85138126d9..a6a5dc0d078ade9bde75bd78404462509cbdce99 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/cfeba7074a6a0260bbcc8f912a6c51bcc125c546..25049cde8bf8b0a8053aec5016472d2874e0ef94 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/40294f25aa4522fe309504aaf30c1c259e11b75b..7e82aea5fc1394d417a0df6a5680a4cce5c37286 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/9b6e18888be3ac761a3f71594c3949f8dc862ccc..7ea05992a52e96426bd4c56ea12d208e0d6c9a5f https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/be0b0bba40ae901c82bbaa47770d629192957a19..2b69b240b90bf096848952cecf5de0ff6788cdd6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I7fdfb1747a00aad4aaab2762ed9a5ed6066df918 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5812102 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 7c065142 2024-08-26T07:02:31 Roll Chromium from edd99dda0b7b to eca761dbc106 (740 revisions) https://chromium.googlesource.com/chromium/src.git/+log/edd99dda0b7b..eca761dbc106 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/0ad9d6f198..6a42fd6513 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/a8c444eac6..4434cfea96 * buildtools/linux64: git_revision:d010e218ca7077928ad7c9e9cc02fe43b5a8a0ad..git_revision:225e90c5025bf74f41dbee60d9cde4512c846fe7 * buildtools/mac: git_revision:d010e218ca7077928ad7c9e9cc02fe43b5a8a0ad..git_revision:225e90c5025bf74f41dbee60d9cde4512c846fe7 * buildtools/win: git_revision:d010e218ca7077928ad7c9e9cc02fe43b5a8a0ad..git_revision:225e90c5025bf74f41dbee60d9cde4512c846fe7 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/1fd2d9c009..f96bb12230 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/c530bb2c89..4917becfcf * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4eb5cc887d..f5e1092339 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/6491ee32ba..6071843cd8 * third_party/r8: DkEQJQKHFcd_oZaA7BLxJLXPTT-MTlqGRyZ7sN1dTp4C..Ct5P52jBNitwDrzqSn-X_dyAlLSpDkGgQQgDk6OUUlMC * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/ff7581fe6b..4f3ee3fd09 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/344cf79356..0ba4cb96fe * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/10e7beb304..634176da98 No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: I86258630a21e3cf9d64f0e24a93bc6702f15d738 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5810699 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao acf63b9e 2024-08-22T09:52:41 Vulkan: call traceGpuEvent after queueSerial has been allocated traceGpuEvent() will write to mOutsideRenderPassCommands. This means if we destroy context immediately it will flush OutsideRenderPassCommands. This will trigger assertion that the queueSerialIndex is invalid. This CL moves queueSerialIndex allocation before traceGpuEvent. Bug: b/361570359 Change-Id: I70909ebd23c43c05cb793319b255f81e65a17a9d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5806203 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Greg Schlomoff <gregschlom@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Gowtham Tammana 3f1c47bf 2024-08-13T15:06:40 Vulkan: Add VK_KHR_variable_pointers ext if available Add VK_KHR_variable_pointers exetensions to enabled extension if it is supported. This is needed when SPIR-V 1.4 is supported. Bug: angleproject:360031000 Change-Id: Ia93604ae308c9f304acb3bc39457811401a0ca7b Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5789897 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov 2e35835b 2024-08-23T11:28:54 Suppress new VUIDs VUID-RuntimeSpirv-OpEntryPoint-08743 VUID-RuntimeSpirv-OpEntryPoint-07754 VUID-RuntimeSpirv-maintenance4-06817 Started reporting after VVL roll https://chromium-review.googlesource.com/c/angle/angle/+/5807076 Bug: angleproject:361600662 Change-Id: Ibdf30bd2506366460009f18a4e1f63559d23eb97 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5803266 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll e5802ddc 2024-08-23T10:01:40 Roll vulkan-deps from 2df89413855e to d95811d4259d (2 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/2df89413855e..d95811d4259d Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/592de6cf78e0fb359fc3e2854c9dc0f3cf6d4820..ffd454c57bdbea8ae493df7a5d2733ae2b02cb81 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/438875314dc838d130098127c6e908798500fecc..cfeba7074a6a0260bbcc8f912a6c51bcc125c546 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Ia8b1b71d33ce0da0f7a1132a32e782085e2025c6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5807113 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 58c1e56b 2024-08-23T10:01:50 Roll SwiftShader from 7216df70d311 to dc27069e5d04 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/7216df70d311..dc27069e5d04 2024-08-22 swiftshader.regress@gmail.com Regres: Update test lists @ 7216df70 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I074b0c59f24681686631f1ffefa0466059df7680 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5807862 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 54d53342 2024-08-23T07:22:18 Roll Chromium from 6994f4772212 to edd99dda0b7b (526 revisions) https://chromium.googlesource.com/chromium/src.git/+log/6994f4772212..edd99dda0b7b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/7798ff7e56..0ad9d6f198 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/941596c255..a8c444eac6 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/7a59f77e6f..1fd2d9c009 * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/301a1695a1..994f942b63 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/9f91481f1d..c530bb2c89 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8f617b4617..4eb5cc887d * third_party/fuchsia-sdk/sdk: version:23.20240815.4.1..version:23.20240823.0.1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/9c3fb06173..6491ee32ba * third_party/libjpeg_turbo: https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/ccfbe1c82a..4426a8da65 * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/116c20dae6..dc70138c3e * third_party/r8: BLP0V0lHIffRLj-o9uhUnvAjMOzA8ZJtIejMb-Kobb8C..DkEQJQKHFcd_oZaA7BLxJLXPTT-MTlqGRyZ7sN1dTp4C * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/4533290e05..f7fd8eedc4 * tools/luci-go: git_revision:ad7b787aa0ee53a81bc88fb4f7fee7a3ff1e8c29..git_revision:5845c6112f584c023a47776b31c3b6f08f562fb8 * tools/luci-go: git_revision:ad7b787aa0ee53a81bc88fb4f7fee7a3ff1e8c29..git_revision:5845c6112f584c023a47776b31c3b6f08f562fb8 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/d0d33d43fb..10e7beb304 No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: I50108fb6d688303018d1b96ba62819af98b1ae1a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5807108 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao 38d5b4d6 2024-08-21T15:49:33 Vulkan: Clean up the CovertVertexBuffer* API Some minor clean up of the API so that the arguments we passed into these two functions CovertVertexBufferGPU and CovertVertexBufferCPU are symmetrical. This CL also factor out the common logic in these two functions into a helper function CalculateOffsetAndVertexCountForConversion(). Bug: b/357622380 Change-Id: I5339850c99d733dfea5039ba74734290f8326bd3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5804529 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Charlie Lao 8fc6d8a8 2024-08-13T09:49:46 Vulkan: Limit vertexBufferConversion to the data within dirtyRange Right now when we do vertex buffer conversion, we always convert from the binding.offset all the way to the end of the buffer, because we do not know who much vertex will be drawn. According to the comment, if we choose to only convert the number of vertices this draw call will be using, then we may end up issuing a lot of conversions in the case that there are many draw calls with small vertex numbers. This CL intends to keep this behavior (i.e, still do the conversion of the data from binding offset to end of the buffer), but apply the optimization that pays attention of mDirtyRange and only convert the portion of data that has actually been modified. Note that the mDirtyRange is the union of all data ranges that has been modified, so may include the unmodified data between two modified ranges. Bug: b/357622380 Change-Id: I91f3dbf4cacb17d3fa4d8d599519865be765557f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5785860 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 267e806b 2024-08-22T16:15:40 Manual roll vulkan-deps from 1863e513f0db to 2df89413855e (11 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/1863e513f0db..2df89413855e Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/25b4e42ead9fbea6b74e31aa488dee2e54c23ae8..edc68950bf725edc89b3e1974c533454cf2ae37c https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/f993f9722589d339a2e2766332b4d591157b5ade..40294f25aa4522fe309504aaf30c1c259e11b75b https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/dee644bbffbd9abd8e677ac96634b25d50df1439..be0b0bba40ae901c82bbaa47770d629192957a19 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com,ynovikov@google.com Change-Id: I49be3110a21a0569477be16890328f0e4bc4f6b4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5807076 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao 6f97a8b3 2024-08-21T13:25:28 Vulkan: Add two tests for vertex conversion Two glBufferSubData calls and then use the buffer (get down to the vertex conversion code path, at least with forced fallback config). The test will exercise the logic regarding the conversion with multiple dirty ranges. Two tests are added in this CL, one with two overlapping range and another with non-overlapping range. Bug: b/357622380 Change-Id: Id8fa23a6e1511e2f03c002782ab99f167416ca02 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5805244 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
angle-autoroll 99fa4d4e 2024-08-22T14:14:37 Manual roll vulkan-deps from d8208b108762 to 1863e513f0db (19 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/d8208b108762..1863e513f0db Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/d59c84d388c805022e2bddea08aa41cbe7e43e55..592de6cf78e0fb359fc3e2854c9dc0f3cf6d4820 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/1b75a4ae0b4289014b4c369301dc925c366f78a6..69ab0f32dc6376d74b3f5b0b7161c6681478badd https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/87fcbaf1bc8346469e178711eff27cfd20aa1960..25b4e42ead9fbea6b74e31aa488dee2e54c23ae8 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/452b3fd7d3a3ba5449ee45f32695f943460d8c61..438875314dc838d130098127c6e908798500fecc https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/494d32f2da0bd8a782d88fdaa98b9e1967148d1b..f993f9722589d339a2e2766332b4d591157b5ade https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/ee7aabe61203c57a8123503b985dd603e08fe806..dee644bbffbd9abd8e677ac96634b25d50df1439 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com,ynovikov@google.com Change-Id: I0041e44811c7320bb29050d283113bffd85ef874 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5807074 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll b78833b1 2024-08-22T09:28:29 Roll Chromium from 79944459a28c to 6994f4772212 (2584 revisions) Update location of: third_party/android_system_sdk/cipd per: https://chromium-review.googlesource.com/c/chromium/src/+/5790209 https://chromium.googlesource.com/chromium/src.git/+log/79944459a28c..6994f4772212 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/c21cc4a276..7798ff7e56 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/36b281734a..941596c255 * buildtools/linux64: git_revision:54f5b539df8c4e460b18c62a11132d77b5601136..git_revision:d010e218ca7077928ad7c9e9cc02fe43b5a8a0ad * buildtools/mac: git_revision:54f5b539df8c4e460b18c62a11132d77b5601136..git_revision:d010e218ca7077928ad7c9e9cc02fe43b5a8a0ad * buildtools/reclient: re_client_version:0.157.0.d2566cec-gomaip..re_client_version:0.158.0.ddc2270e-gomaip * buildtools/win: git_revision:54f5b539df8c4e460b18c62a11132d77b5601136..git_revision:d010e218ca7077928ad7c9e9cc02fe43b5a8a0ad * testing: https://chromium.googlesource.com/chromium/src/testing/+log/b28404ae36..7a59f77e6f * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/ed3733b91e..1b7ed5a193 * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/7ae3036e4c..301a1695a1 * third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/dc4679d47e..783f19f6e1 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/799e21b232..9f91481f1d * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/37a737c1bc..8f617b4617 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/40b967f07b..9c3fb06173 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/eb6567388e..a834cb2539 * third_party/r8: C4UQJ3lVMOKokpVF4Wxbgqb8EdzZ7NSCihUEqDgrlDIC..BLP0V0lHIffRLj-o9uhUnvAjMOzA8ZJtIejMb-Kobb8C * third_party/siso/cipd: git_revision:87262779ecc3482c8c60b070404b225107212d0d..git_revision:250f32bbb04e51117d17db783c9535dd956f7d44 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/4efc34892e..ff7581fe6b * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/63b7be17f8..4533290e05 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/6abb195855..344cf79356 * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/d7a1bee91c..bd3ae34fa1 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/167cffa814..d0d33d43fb * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/a69a8ecdbf..b732825d28 * tools/skia_goldctl/linux: 8P9u35-wUJOuCZt7KfoaHql4TnnYfCE6PcMUJaLjcG0C..gEqE2FO6iRIbYzXJtbhu6FRkrdGqtPx6XrU4h8pmwEEC * tools/skia_goldctl/mac_amd64: msDdo7ZqznAXC4geehuff02Ggz-TUFdGe5bqHvnWCQ4C..Q4WuHUZxKIIzq1OUqXi5Dd_saMZmLnqIRbvnrVoeUUwC * tools/skia_goldctl/mac_arm64: neECyUAIg1_QJCcxMv9PgZnZ5iVqoq43ZRTFhE5F12YC..ZtqPSxqhpVysf1666ZhdkdDn_cDRZXNIvpTOxxfF7cMC * tools/skia_goldctl/win: YufvDpBuGUe9YcFanPljAShLJMIp6_OV_XLBY0JrltgC..REwg09_A3MRvXcOWOKRWyN0Rjuf6P__3Mmh8R97hIoQC No update to Clang. Bug: angleproject:361262466, angleproject:361372438 Change-Id: I243291d2be95692138fb60ad0e50b2b420e60079 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5804540 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll bf167aa3 2024-08-22T08:01:27 Roll VK-GL-CTS from f105fd7ea388 to 21ff94426906 (2 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/f105fd7ea388..21ff94426906 2024-08-19 rgarcia@igalia.com Fix gen_framework.py warnings about invalid escape sequences 2024-08-16 lorenzo@khronosgroup.org Merge branch 'dev/VK_EXT_legacy_vertex_attributes' If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I2210977c46e82e60f82b0ceecef169bd48ab4804 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5806317 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao 790e0162 2024-08-09T17:11:38 Vulkan: Add dirty range to VertexConversionBuffer class Previously, ConversionBuffer only has a boolean indicates it is dirty or not. This CL adds mDirtyRange to it to indicate which range of data has been modified. The existing dirty boolean has been changed to mEntireBufferDirty so that all the current code will still work. Right now mEntireBufferDirty is always set when we mark it dirty, which means entire buffer gets converted. mDirtyRange has not been used to reduce the data to be converted. Right now the range is always being merged to the existing range and not actually being used in this CL. It will be used in the next CL. Bug: b/357622380 Change-Id: Ibfa702b29011f4e26c511d5db85c07cbf2a4aefb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5778347 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Alexey Knyazev 33c2ff07 2024-08-20T00:00:00 Metal: Remove obsolete watchOS compile guards MTLSamplerAddressModeMirrorClampToEdge: - macOS 10.11 (min compile 12.0, min deploy 10.15) - iOS 14.0 (min compile 17.0, min deploy 15.0) - tvOS 16.0 (min compile 17.0, min deploy 17.0) Bug: angleproject:360147119 Change-Id: I21457e7f0694d09857153199037929f9739eded0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5803986 Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Matthew Denton d263945a 2024-08-20T16:32:36 Translator: make replaceChildNode() a little more type-safe If we know the type the child node should be, instead of static_cast<>ing to the expected type, use getAs{ExpectedType}() and crash if nullptr. This would have saved me when the ReplaceVariables() AST transformaton replaced a TIntermSymbol in a TIntermGlobalQualifierDeclaration with a TIntermTyped that was not a TIntermSymbol. But TIntermGlobalQualifierDeclaration can only have a TIntermSymbol as a child, so this caused confusing crashes. Other node types have similar expectations of the types of their children. This doesn't enforce any type safety on TIntermAggregate children as those are a little more flexible and complicated. This CL also doesn't enforce non-nullptr children when the parent can't handle nullptr children. Bug: angleproject:42267100 Change-Id: Ic7fb41039705aa4f6daec052940d9bfc4974d955 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5800264 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org>
angle-autoroll 41309a2f 2024-08-20T08:01:27 Manual Roll VK-GL-CTS from 50e83129b558 to f105fd7ea388 (16 revs) Added deqp.gni changes for: gl3cPrimitiveRestart.hpp/cpp es3cDriverErrorTests.hpp/cpp https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/50e83129b558..f105fd7ea388 2024-08-16 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.9 into vk-gl-cts/main 2024-08-16 ziga@lunarg.com Fix race condition in EGL multithreading tests 2024-08-16 younggwan.kim@arm.com Add coverage for depth bound test without depth attachment 2024-08-16 tomek.bury@broadcom.com Fix dEQP-EGL.functional.fence_sync.valid.egl_fence_persistent_buffer 2024-08-16 okuznetsov@google.com New tests group for known driver error tests 2024-08-16 marcin.hajder@mobica.com Port KC-CTS tests to VK-GL-CTS (primitive_restart_mode), PART 10 2024-08-16 piotr.byszewski@mobica.com Test DRLR remapping while using shader object 2024-08-16 ziga@lunarg.com Test drawing with stencil test and without vkCmdSetFrontFace 2024-08-16 rgarcia@igalia.com Reuse scratch buffer creating acceleration structures back-to-back 2024-08-16 rgarcia@igalia.com Test preemption with VK_KHR_global_priority 2024-08-16 rgarcia@igalia.com Removed ESO compute tests using Amber 2024-08-16 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.11 into vk-gl-cts/main 2024-08-14 syoussefi@google.com Remove DE_NULL's definition 2024-08-05 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-cts-4.6.5 into vk-gl-cts/main 2024-08-05 ziga@lunarg.com Fix broken build on windows 2024-08-04 michal.jakubek@mobica.com VK_DEFINE_PLATFORM_TYPE macro doesn't accept nullptr If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I71223610821b102501a78eea2abecb95d10f4910 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5799167 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Alexey Knyazev 1dabe52c 2024-08-20T00:00:00 Metal: Remove texture swizzle compile guards Texture swizzle support: - macOS 10.15 (min compile 12.0, min deploy 10.15) - iOS/tvOS 13.0 (min compile 17.0, min deploy 15.0) Bug: angleproject:360147119 Change-Id: If7e59cc094e5bcdb145a54541662d0fe0a989e8d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5803984 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll deba56c2 2024-08-21T14:08:19 Manual roll vulkan-deps from dad70915c62f to d8208b108762 (6 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/dad70915c62f..d8208b108762 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/595c8d4794410a4e64b98dc58d27c0310d7ea2fd..d205aff40b4e15d4c568523ee6a26f85138126d9 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/83cd92c725987857a84c871bd8bc11b249d239b1..452b3fd7d3a3ba5449ee45f32695f943460d8c61 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/32379b03f828619cb54eed874a11ab7e5ceafb3a..494d32f2da0bd8a782d88fdaa98b9e1967148d1b https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/45b881573538f8e481cb6e1d811a9076be6920c1..9b6e18888be3ac761a3f71594c3949f8dc862ccc https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/d9e05641700bb3f0537c74a190e9a9183e3b58aa..ee7aabe61203c57a8123503b985dd603e08fe806 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com,ynovikov@google.com Change-Id: I5931cdade413f4e1a2adb3e9d7c874bf38bd38b4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5803902 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexey Knyazev f551a112 2024-08-20T00:00:00 Metal: Remove obsolete compile guards from the command buffer memoryBarrierWithScope and memoryBarrierWithResources: - macOS 10.14 (min compile 12.0, min deploy 10.15) - iOS/tvOS 12.0 (min compile 17.0, min deploy 15.0) dispatchThreads: - macOS 10.13 (min compile 12.0, min deploy 10.15) - iOS 11.0 (min compile 17.0, min deploy 15.0) - tvOS 14.5 (min compile 17.0, min deploy 15.0) Bug: angleproject:360147119 Change-Id: I05e4e5dac81b4e07c47e0f3a1b7d165ff9406cc3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5804021 Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Yuly Novikov 36f7e03a 2024-08-21T13:49:10 Revert "Metal: Fix availability for kIOMainPortDefault" This reverts commit a712626e940cbd3ff6f279a6e838362392a3fd1d. Reason for revert: breaks iOS https://chromium-review.googlesource.com/c/chromium/src/+/5802272 https://ci.chromium.org/ui/p/chromium/builders/try/ios-simulator/2048194/overview Original change's description: > Metal: Fix availability for kIOMainPortDefault > > Remove ad hoc deprecation disables for > kIOMasterPortDefault. > macCatalyst kIOMainPortDefault available 15.0, > less than minimum 15.6. Remove the ifdefs. > > Bug: angleproject:360147118 > Change-Id: I2ccc08814e267984ff53275cc2886e2bfa8d4c2a > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5797149 > Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com> > Reviewed-by: Geoff Lang <geofflang@chromium.org> > Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> > Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com> Bug: angleproject:360147118 Change-Id: Iab3e8d1dece4866732ecbebab4c83f274b99e034 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5803985 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Le Hoang Quyen f102d75a 2024-08-14T19:52:30 Metal: translate IOSurface pbuffer's GL_RGB to RGBX/BGRX format. Currently when IOSurface is bound to a pbuffer with GL_RGB internal format, we asign angle format=B8G8R8A8_UNORM/R8G8B8A8_UNORM to it. And then disable alpha write to the respective MTLTexture. However, when an implicit MSAA texture is created for the above pbuffer, it will be assigned B8G8R8A8_UNORM/R8G8B8A8_UNORM angle format but has no knowledge about alpha write disable. Consequently, when a render pass uses this implicit MSAA texture, its alpha channel won't be cleared properly and would contain garbage values. In order to avoid the above bug, we should use B8G8R8X8_UNORM/R8G8B8X8_UNORM angle format for the IOSurface pbuffer. This will fix the render corruptions found in chromium:358957665. Bug: angleproject:42261786 Bug: chromium:358957665 Change-Id: I8aa1e24ace2de80dd08e21711445515ba4b339ff Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5788801 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Quyen Le <lehoangquyen@chromium.org>
Kimmo Kinnunen 5cf94ffa 2024-08-20T10:41:40 Metal: Use pipeline rasterSampleCount Use MTLRenderPipelineDescriptor rasterSampleCount instead of sampleCount. This avoids the use of the deprecation macro. Availability: iOS 8.0 (min: 15.0), mac Catalyst 13.1 (min: 16.5), macOS 10.11 (min: 10.15), tvOS 11.0 (min: 15.0), visionOS 1.0+ Bug: angleproject:360147118 Change-Id: I7009a7d7b39ecb763e23f4b97441fb45a64a891d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5797134 Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com> Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com>
Kimmo Kinnunen 25237423 2024-08-20T15:22:32 Metal: Remove ifdefs for primitive topology class MTLPrimitiveTopologyClass availability iOS 12.0, minimum runtime 15.0. Remove the ifdefs. Hardcoding ANGLE_IOS_DEPLOY_TARGET is dangerous, likely it has never been correct. Remove. Should use __IPHONE_OS_VERSION_MIN_REQUIRED. Bug: angleproject:360147118 Change-Id: I43d7a364fa0237af1ee1f546015ae884fc373b15 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5797141 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com> Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com>
Kimmo Kinnunen a712626e 2024-08-20T15:12:19 Metal: Fix availability for kIOMainPortDefault Remove ad hoc deprecation disables for kIOMasterPortDefault. macCatalyst kIOMainPortDefault available 15.0, less than minimum 15.6. Remove the ifdefs. Bug: angleproject:360147118 Change-Id: I2ccc08814e267984ff53275cc2886e2bfa8d4c2a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5797149 Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com>
Charlie Lao 86508e20 2024-08-16T14:56:37 Vulkan: Make VertexConversionBuffer a class And wrap the cache key (i.e, formatID/stride/offset) into a CacheKey struct so that we can easily add more data members. This CL also changes ConversionBuffer from struct to class to have better encapsulation. No functional changes is expected here. Bug: b/357622380 Change-Id: Ieecf5c922b95a940137c8e54657ef3f458c55fc9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5793921 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Charlie Lao a3f9f6c3 2024-08-16T12:12:00 Vulkan: Move VertexConversionBuffer out of BufferVk class This is another preparation CL to make code review easier. In the future CL, VertexConversionBuffer will be used in other files. BufferVk::VertexConversionBuffer is a bit too verbose. Make VertexConversionBuffer a standalone class makes code a bit easier to read. We could potentially merge ConversionBuffer and VertexConversionBuffer into single class, but I am leaving it for future exercise. Bug: b/357622380 Change-Id: I2255a1c9b01f5d6c3846e8017cc667e6a9d66ffc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5787504 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Charlie Lao 7080b766 2024-08-16T11:31:39 Vulkan: Move LineLoopHelper from vk to rx namespace There is no line loop support in vulkan. LineLoopHelper is a utility function for backend, not a helper function for vulkan object. So it is better fit in rx namespace instead of vk namespace. This also helps my next CL where I am going to change initBufferForVertexConversion to take a ConversionBuffer instead of BufferHelper. LineLoopHelper uses initBufferForVertexConversion, which means I have to change LineLoopHelper to uses ConversionBuffer. This causes header inclusion problem that now vk namespace object end up have to include rx namespace header. This CL fixes this inclusion problem by moving it to the proper namespace. Bug: b/357622380 Change-Id: I6d6cf1aa926f726bb1b1ab1017bcab092eaf5d37 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5787502 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Kimmo Kinnunen e0f790c0 2024-08-20T12:08:40 Metal: Use present APIs for Metal availability Use non-deprecated APIs for checking Metal backend availability. macCatalyst and macOS needs MacFamily2 Availability: - macOS 10.15, minimum runtime 10.15 - macCatalyst 13.1, minimum runtime 16.5 iOS, minimum runtime 15.0, can always use the backend. Bug: angleproject:360147118 Change-Id: Id0b70c81bc8b54a22b94ba514aab148b202d58ef Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5797053 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Kimmo Kinnunen eb6c4bfe 2024-08-20T09:58:11 Metal: Fix availabilities of MTLGPUFamily use Fixes compile in case of targeting only the newer SDKS. [MTLDevice supportsFamily:] is supported on all minimum runtimes: - macOS 10.15 (minimum runtime 10.15) - macCatalyst 13.1 (minimum runtime 16.5) - iOS/tvOS 13.0 (minimum runtime 15.0) Remove the ifdefs and fallbacks. MTLGPUFamilyMacCatalyst1 is deprecated on macCatalyst 16.0. Replace with MTLGPUFamilyMac2. MTLGPUFamilyMac1 is deprecated on macOS 13.0. Replace with MTLGPUFamilyMac2. MTLGPUFamilyApple7 is present on iOS/tvOS 14.0, minimum runtime 15.0. Remove ifdefs. MTLGPUFamilyApple6,7 are present on macOS 11.0 SDK, minimum SDK 12.0. Remove ifdefs. Bug: angleproject:360147118 Change-Id: I337d1ad44940a2f39a57ba8a28de0e1d7387658c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5797050 Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Kimmo Kinnunen 2758d4dc 2024-08-20T16:00:07 Metal: Remove shared event related ifdefs Shared events are supported by iOS 12, macOS 10.14, included in the minimum versions iOS 15, macOS 10.15. Bug: angleproject:360147118 Change-Id: I5b62dade045f9d50864ef1906cb22a18fd09e4da Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5797150 Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Geoff Lang 2f2cdbb8 2024-08-19T11:05:22 D3D11: Fix uniform setting for mat3 followed by float A single float following a float3x3 will pack tightly in the last row of the matrix. The uniform setting code for matricies would write a full row stride's worth of data for the last matrix row, overwriting the float packed at the end. Update ExpandMatrix to only write colsSrc worth of values in the last row. Bug: angleproject:42266878, chromium:345525082 Change-Id: Ieb616972387501cd8c30f02b267f86a7f81cf01a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5796631 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Le Hoang Quyen 1a191b1d 2024-08-16T17:31:38 Metal: add an option to emulate DontCare loadOp with randomized Clear. This is useful for testing undefined initial values caused by DontCare MTLLoadAction on non-tiled GPUs. Bug: angleproject:42261786 Change-Id: Id5c4a9ee8510a8a9143bdd67e276bfcf2bd7eaa5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5791386 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Quyen Le <lehoangquyen@chromium.org>
Alexey Knyazev 57a3e9a7 2024-08-15T00:00:00 Prevent compilation with unsupported Apple SDK versions Bug: angleproject:360147119 Change-Id: Ie9924cb49ffa729d454a2869a2d19d957500bd10 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5793513 Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll 4931cab2 2024-08-19T12:47:15 Roll SwiftShader from 65157d32945d to 7216df70d311 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/65157d32945d..7216df70d311 2024-08-19 swiftshader.regress@gmail.com Regres: Update test lists @ 65157d32 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: Ia12a368e4bd750687fb46052c0fa8958c3320dcf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5796985 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Kimmo Kinnunen 62cc3790 2024-08-19T11:05:52 Metal: Remove UseResource old SDK fallbacks Fixes deprecation compile errors on newer SDKs. Remove the version guards, the useResource API is available on: macOS 10.15, minimum supported version 10.15 iOS 13, minimum supported version 15 macCatalyst 13.1, minimum supported version 16.6 (for macOS 13.5) Bug: angleproject:360147118 Change-Id: I6d2dd7cb510d6134b75d4479ae7159b8fbcfc96b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5796002 Commit-Queue: Geoff Lang <geofflang@chromium.org> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com>
Gowtham Tammana 579a5855 2024-08-13T11:39:54 Vulkan: Add query for 64bit fp support feature check Add a feature check for shaderFloat64 support. If present expose the corresponding feature check. The following files are updated by running the autogen script - `run_auto_code_generation.py` - include/platform/autogen/FeaturesVk_autogen.h - util/autogen/angle_features_autogen.cpp - util/autogen/angle_features_autogen.h Bug: angleproject:360031000 Change-Id: If2a11190729550ad5b84714e0a3aa3b81956c66a signed-off-by: gowtham tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5789896 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Gowtham Tammana e90cd0c4 2024-08-12T17:07:47 Vulkan: Add check for int8 extension support Vulkan backend currently has a check for float16 part in VK_KHR_shader_float16_int8 extension. Add the int8 support as well. The changes in below files are generated through `scripts/run_code_generation.py` script - include/platform/autogen/FeaturesVk_autogen.h - util/autogen/angle_features_autogen.cpp - util/autogen/angle_features_autogen.h Bug: angleproject:360031000 Change-Id: I8811779299e3d24b4536d1871e1eadcbb87432c2 Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5792021 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Gowtham Tammana 319907d2 2024-04-05T16:05:33 Vulkan: Propagate the support of shaderInt16/64 feature Progate the support of shaderInt16/64 features in to enabled feature list. Bug: angleproject:360031000 Change-Id: I38915a764fb2f1dd31348c01bc2fcfa4913ebdec Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5792019 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Kimmo Kinnunen 78dd9a8e 2024-08-16T15:44:49 Metal: Support compiling without OpenGL on macOS Avoid OpenGL framework use unless CGL is enabled. It was used in active GPU resolution for older macOSes. Bug: angleproject:360159407 Change-Id: I6d820ea37290d5e75151db0b42dc266910bcba6a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5793512 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org>
Roman Lavrov 2f28264e 2024-08-15T18:05:43 Trace perf: add origin/main revision to summary if != HEAD Bug: None Change-Id: Iacacd98993d7dc5fbea8489b46236e939f465689 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5792199 Reviewed-by: Cody Northrop <cnorthrop@google.com>
angle-autoroll af57b492 2024-08-16T09:51:31 Roll Chromium from 43d3902d1733 to 79944459a28c (572 revisions) Update locations of: third_party/android_build_tools/aapt2/cipd third_party/android_build_tools/lint/cipd third_party/android_build_tools/manifest_merger/cipd per: https://chromium-review.googlesource.com/c/chromium/src/+/5786445 https://chromium-review.googlesource.com/c/chromium/src/+/5788856 https://chromium-review.googlesource.com/c/chromium/src/+/5789026 https://chromium.googlesource.com/chromium/src.git/+log/43d3902d1733..79944459a28c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/79a64724b2..c21cc4a276 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/d32a89311c..36b281734a * testing: https://chromium.googlesource.com/chromium/src/testing/+log/017985f8f0..b28404ae36 * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/5b07f6628f..7ae3036e4c * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/a2d0eac2df..4c82e77bef * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/39ca85acf5..37a737c1bc * third_party/fuchsia-sdk/sdk: version:23.20240808.4.1..version:23.20240815.4.1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/0a4a51e9b2..40b967f07b * third_party/r8: PFS599OjKnxQ27aLLtQdtC8iQBQzEVd5uMOs2iqYMSYC..C4UQJ3lVMOKokpVF4Wxbgqb8EdzZ7NSCihUEqDgrlDIC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/1f2403c8ec..63b7be17f8 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/a33c4e72e9..167cffa814 * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/e27ef2019a..a69a8ecdbf No update to Clang. Bug: angleproject:5224, angleproject:5225, angleproject:6430, angleproject:7425 Change-Id: I9b214b6b9d630597ca53d418602d6da9c07e8fda Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5792313 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Garrett Beaty 2fa5e818 2024-08-15T16:39:12 Load //testing/buildbot/mixins.pyl directly. //infra/spec/generate_test_spec_json.py only needs the mixins used in the chromium //testing/buildbot directory. Rather than load all of the configuration files, loading mixins.pyl directly will remove the need for gn_isolate_map.pyl, test_suites.pyl and variants.pyl to be synced over to //testing/buildbot in the chromium/src repo. Bug: chromium:360187776 Change-Id: I67106785e9242e9eca8a42c1f0dea26d529b5e02 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5792035 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 30358a2f 2024-08-16T10:01:06 Roll vulkan-deps from 91058f2297c9 to dad70915c62f (6 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/91058f2297c9..dad70915c62f Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/0dc6711e5a178e4d5643437af688c6b48f829f5c..d59c84d388c805022e2bddea08aa41cbe7e43e55 https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/a12be94856baf210bb7ae9457dbdf907148caa0a..a24a94aa0d1fc4e5556bdf9c6b2afe8eacc55326 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/7d5cdf62e4f2935425faab1270fe1c9a401fa664..32379b03f828619cb54eed874a11ab7e5ceafb3a https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/4eb3585f32ec194efe2d9cd88a2b2943ff41f922..d9e05641700bb3f0537c74a190e9a9183e3b58aa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I437d1a284858a2a7706553738071627219ce6471 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5792314 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Kimmo Kinnunen 26c842fc 2024-08-15T14:51:22 Metal: use injectAsmStatementIntoLoopBodies on iOS The setting should be enabled for iOS. Bug: chromium:1513738 Change-Id: I5efd4126711eff6df8f5d84689f7f3310d7e8487 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5788428 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com>
Austin Annestrand 83ca89e5 2024-08-08T19:53:32 CL: Update logic for default platform on context creation In ANGLE, when multiple backends are enabled (e.g. passthrough, Vulkan, etc.), each backend is its own platform. Existing validation code was failing in this case for clCreateContext in the event of user not manually specifying CL_CONTEXT_PLATFORM. Spec says implementation then decides which platform to be associated with that context. ANGLE has a Platform::GetDefault() routine that was used and it simply grabs the 1st platform from our platform list in ANGLE (passthrough mode platform object in this case). We erroneously fail the validation in the case where we pass Vulkan device in our device_list since default-platform != Vulkan-platform. Updating the logic to use device's platform (from list) as default case. For clCreateContextFromType, we can continue to use Platform::GetDefault() as this routine generates the appropriate device list for the user to query/get via clGetContextInfo. Bug: angleproject:42266872 Change-Id: I285459688309d1cc76ade5a8564164a5538e1eda Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5789652 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov 31ad61c4 2024-08-15T16:31:23 Skip end2end WebGPU tests flaky crashing on Linux Intel Seen on UHD630 Ubuntu 22.04 Mesa 23.2.1 experiment. Bug: angleproject:360083331 Change-Id: I63f1eda1dc3ef7f64e3b5e37b678a31ac9a190af Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5786999 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Austin Annestrand 21905014 2024-08-08T16:55:52 CL: Fix entrypoint validation for ICDs For some OpenCL ICD implementations, the clGetPlatformIDs API is left as nullptr in the ICD dispatch table. This is because the OpenCL ICD Loader instead uses the clIcdGetPlatformIDsKHR call instead. Updating the passthrough code to only require checking the clGetPlatformIDs API if the platform is not an ICD. Bug: angleproject:42266872 Change-Id: Ic723adbf3ad0f6c79389ef629dd24ae8a82ca9ba Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5789651 Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Mark Lobodzinski 77616aa3 2024-08-14T13:22:32 Tests: Add Gwent Witcher Card Game trace Test: angle_trace_tests --gtest_filter="*gwent_witcher_card_game*" Bug: b/359910003 Change-Id: I6b93d36ac58df7639f07b7f21107f4d4522f6cee Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5789276 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
angle-autoroll e6b46eae 2024-08-15T10:01:05 Roll vulkan-deps from f084a55f96da to 91058f2297c9 (4 revisions) Suppress new VUIDs: VUID-vkCmdDraw-Input-07939 VUID-vkCmdDrawIndexed-Input-07939 VUID-vkCmdDrawIndexedIndirect-Input-07939 VUID-vkCmdDrawIndirect-Input-07939 https://chromium.googlesource.com/vulkan-deps.git/+log/f084a55f96da..91058f2297c9 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/3a08cd8de1f88d114c18670366f29226db453a9e..0dc6711e5a178e4d5643437af688c6b48f829f5c https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/f013f08e4455bcc1f0eed8e3dd5e2009682656d9..1b75a4ae0b4289014b4c369301dc925c366f78a6 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/8d902c7f67edd9e54b0fa5f7d2c34f9abfeacba8..4eb3585f32ec194efe2d9cd88a2b2943ff41f922 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: chromium:359904720 Change-Id: Idf82bf9a210b953785fc2387e5c64ef157ec36e6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5791052 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 727c6dcc 2024-08-15T07:01:36 Roll Chromium from fdf9925b6b4a to 43d3902d1733 (610 revisions) https://chromium.googlesource.com/chromium/src.git/+log/fdf9925b6b4a..43d3902d1733 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/278b5d141a..79a64724b2 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/ef71623932..d32a89311c * buildtools/reclient: re_client_version:0.156.0.a46645a7-gomaip..re_client_version:0.157.0.d2566cec-gomaip * testing: https://chromium.googlesource.com/chromium/src/testing/+log/d26671f1f0..017985f8f0 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/0b4fc47c61..ed3733b91e * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/e7ed14eb8f..799e21b232 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/7679949608..0a4a51e9b2 * third_party/r8: pDW3OBH87Wm9f3PIhkxRptVG2qnlAiobu7ORMykmy1cC..PFS599OjKnxQ27aLLtQdtC8iQBQzEVd5uMOs2iqYMSYC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/de41d6c162..1f2403c8ec * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/6ef7f80e30..a33c4e72e9 No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: Id61968d7dc6451d433d06386398f60f235ff6261 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5790064 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gowtham Tammana 2003e062 2024-08-09T17:52:38 Vulkan: Set queue family index for oneoff command buffer Use the queue family index that the Renderer has chosen for creation of oneoff command buffers. Bug: angleproject:359623670 Change-Id: I0a36edf79a751133d477d433c9cfd8dbddaad221 Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5785864 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Austin Annestrand 2b723c13 2024-02-02T14:12:06 CL/VK: Add initial enqueueCopyBuffer Generalizing the copy buffer with appropriate barrier inserts and commandbuffer command. Bug: angleproject:42267074 Change-Id: I02fd36a221ea70f007aee78ceeef84c24fa85682 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5410935 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Gowtham Tammana ef6a3132 2024-06-25T17:30:03 CL: Return error code for not supported APIs The spec requires error codes to be reported for not supported API calls. Fixing to return relevant error codes. Bug: angleproject:359296611 Change-Id: Ia64bf2673446269c6557308c169f019c7dd67cc8 Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5782397 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Geoff Lang da572160 2024-07-23T16:36:10 Reland: GL: Forward client-side arrays to the driver when possible The OpenGL driver can handle client-side arrays when the context is OpenGL ES or a desktop GL compatibility profile. When in these situations, use the driver default VAO for all frontend context VAOs and forward client-side data directly to the driver. Fix synchronizing the default VAO state for external contexts. There is no valid VertexArrayStateGL for external VAOs so make sure it's nulled and the VAO dirty bits are set so the correct VAO state is reapplied. Disable syncing to the default VAO for external contexts. The only VAO that they can share with ANGLE's internal state is the default VAO so avoid having to save and restore its state. Bug: angleproject:355034686 Change-Id: I015bbbc854938fe4bc1e92d0ca8fe04628d0db16 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5743284 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Ho Cheung 28b845f0 2024-08-13T11:56:22 Roll third_party/dawn/ eb249b37e..1eca38fa5 (570 commits; 8 trivial rolls) https://dawn.googlesource.com/dawn.git/+log/eb249b37e3e8..1eca38fa5236 $ git log eb249b37e..1eca38fa5 --date=short --no-merges --format='%ad %ae %s' 2024-08-13 jiawei.shao Tint: Fix outdated URLs in lang/core/core.def and lang/core/address_space.def 2024-08-13 jiawei.shao Add `mInternalUsage` to store all internal and external buffer usages 2024-08-12 dawn-autoroll Roll ANGLE from 11724133cd8f to f8fc8ac36280 (8 revisions) 2024-08-12 rharrison [tint][ir][val] Check results and operands for bitcasts 2024-08-12 dneto msl:ast_printer: Polyfill 4x8 int dot products on AMD RDNA1, RDNA2 2024-08-12 rharrison [tint][ir][val] Check frag_depth only on fragment entry points 2024-08-12 dawn-autoroll Roll DirectX Shader Compiler from 06da989c4ab6 to f810e92e72ab (1 revision) 2024-08-12 chouinard [tint][spirv] Allow signed subgroupBroadcast ID 2024-08-12 jrprice [spirv] Use IR by default for CLI and E2E tests 2024-08-12 jrprice [spirv] Add missing E2E test expectations 2024-08-12 jrprice [vulkan] Remove AST path for SPIR-V codegen 2024-08-12 bsheedy Suppress VulkanImageWrappingTests failures 2024-08-12 chouinard [tint] Implement subgroupShuffle 2024-08-12 rharrison [tint][ir][val] Check that Var results are pointers or references 2024-08-12 dawn-autoroll Roll ANGLE from 6e248bcb44bf to 11724133cd8f (1 revision) 2024-08-12 dawn-autoroll Roll vulkan-deps from fab6b980639e to a5d4d42457c3 (1 revision) 2024-08-11 dawn-autoroll Roll vulkan-deps from c658a888e75c to fab6b980639e (2 revisions) 2024-08-10 dawn-autoroll Roll ANGLE from 0bb0a886ffb4 to 6e248bcb44bf (1 revision) 2024-08-10 dawn-autoroll Roll ANGLE from 6ecc3542d47a to 0bb0a886ffb4 (2 revisions) 2024-08-10 dawn-autoroll Roll vulkan-deps from 236cdecbee13 to c658a888e75c (2 revisions) 2024-08-09 chouinard [tint] Implement subgroupElect and BroadcastFirst 2024-08-09 chouinard [tint] Implement subgroupAll and subgroupAny 2024-08-09 sunnyps Add ComputeEstimatedMemoryUsage 2024-08-09 dawn-autoroll Roll ANGLE from 98b0669607ee to 6ecc3542d47a (3 revisions) 2024-08-09 dawn-autoroll Roll ANGLE from d335f134eaae to 98b0669607ee (5 revisions) 2024-08-09 chouinard [tint] Implement subgroupMin and Max 2024-08-08 dawn-autoroll Roll vulkan-deps from 0f7909f6bf64 to 236cdecbee13 (2 revisions) 2024-08-08 chouinard [tint] Implement subgroupAnd, Or, Xor builtins 2024-08-08 jaswant.panchumarti Update samples to use preferred texture format for surface 2024-08-08 lokokung [emscripten] Fix Cmake parse arguments to build samples. 2024-08-08 bsheedy Suppress 16" AMD Macbook failures 2024-08-08 chouinard [tint][hlsl] Add countOneBits/reverseBits polyfill 2024-08-08 rharrison [tint][ir][val] Rework how CheckConstruct works 2024-08-08 bsheedy Revert "Add Linux/NVIDIA Exp to rolls" 2024-08-08 dawn-autoroll Roll DirectX Shader Compiler from 84f68ed1a40d to 06da989c4ab6 (1 revision) 2024-08-08 rharrison [tint][ir][val] Check results and operands to converts 2024-08-08 rafael.cintron Run ColorStateTests in Warp 2024-08-08 bsheedy Revert "[tint][benchmark] Generate depfile for inputs" 2024-08-08 amaiorano DXC: enable asserts in non-debug builds 2024-08-08 chouinard [tint] Allow subgroup builtins in fragment shaders 2024-08-08 rharrison [tint][ir][val] Handle construct with undefined args or results 2024-08-08 bsheedy Suppress Linux/NVIDIA failures 2024-08-08 dawn-autoroll Roll ANGLE from 27c0f10a9543 to d335f134eaae (4 revisions) 2024-08-08 dawn-autoroll Roll DirectX Shader Compiler from 99f2d4981053 to 84f68ed1a40d (1 revision) 2024-08-08 bsheedy Suppress Linux/NVIDIA failures 2024-08-07 sunnyps metal: Skip emitting memoryless texutres in memory dumps 2024-08-07 dawn-autoroll Roll ANGLE from 70f2e2033b17 to 27c0f10a9543 (6 revisions) 2024-08-07 dawn-autoroll Roll vulkan-deps from 699b3c2a0349 to 0f7909f6bf64 (9 revisions) 2024-08-07 dsinclair [HLSL] Sort vars when updating buffer accesses. 2024-08-07 chouinard [tint][wgsl] Add subgroupAdd,Mul builtin checks (...) 2024-07-04 jaswant.panchumarti Refine the bundling step for `webgpu_dawn` 2024-07-04 ynovikov Suppress Pixel 6 Android 14 failures already suppressed on Android T 2024-07-04 dneto Update buildtools, clang, rust, libc++, libc++abi to latest in Chromium 2024-07-04 blundell [YCbCr Samplers] Separate YCbCr from non-YCbCr in hashing/equality 2024-07-04 beaufort.francois Add deprecation warning to Adapter::GetProperties() 2024-07-04 dawn-autoroll Roll ANGLE from b954755f4e31 to f2ee319dda4e (1 revision) 2024-07-04 dsinclair [hlsl] Polyfill matrix multiplication. 2024-07-03 dsinclair [hlsl] Simplify type emission in HLSL IR printer. 2024-07-03 dsinclair [hlsl] Support let pointer to var. 2024-07-03 dsinclair [hlsl] Polyfill float32 modulo 2024-07-03 kainino Roll CTS: Rename *.worker.js to *.as_worker.js 2024-07-03 dsinclair [hlsl] Remove UserCall handling in DecomposeMemoryAccess. 2024-07-03 dsinclair [hlsl] Handle access chains of unnamed access chains 2024-07-03 dsinclair [hlsi] Enable passing DISABLED tests. 2024-07-03 dsinclair [hlsl] Add load support into decompose memory access. 2024-07-03 jrprice [msl] Skip push constants in the AST fuzzer 2024-07-03 kainino Generate files to use Emscripten bindings from outside Emscripten 2024-07-03 dsinclair [hlsl] Add polyfill for `trunc` 2024-07-03 jrprice [spirv] Remove AST fuzzers 2024-07-03 dawn-autoroll Roll ANGLE from 2efce9babc18 to b954755f4e31 (3 revisions) 2024-07-03 dneto Update build tools, clang, libc++, libc++abi, rust 2024-07-03 dawn-autoroll Roll vulkan-deps from a69f4fce99da to 5fdd3da87369 (7 revisions) 2024-07-03 dawn-autoroll Roll DirectX Shader Compiler from bd5b7380e29f to 4a81bdfa70f9 (1 revision) 2024-07-03 dawn-autoroll Roll ANGLE from d8700dc951b6 to 2efce9babc18 (4 revisions) 2024-07-03 lehoangquyen D3D11: Use compute shader for T2B with certain formats. 2024-07-03 lehoangquyen Native: Add buffer's internal CopySrc usage 2024-07-02 jrprice [ir] Skip constant builtin structs in fuzzer 2024-07-02 jrprice [ir] Skip builtin structures when creating AST 2024-07-02 dcheng [MSan] Fix use-after-dtor issues in generated C++ APIs. 2024-07-02 dsinclair [hlsl]: Add DirectVariableAccess to HLSL IR backend. 2024-07-02 kainino Copy Emscripten's WebGPU bindings into Dawn 2024-07-02 dsinclair [hlsl] Decompose load/store vector element 2024-07-02 dawn-autoroll Roll DirectX Shader Compiler from 1fefbc429bad to bd5b7380e29f (1 revision) 2024-07-02 dsinclair [hlsl] Add ByteAddressBuffer type. 2024-07-02 bsheedy [tools][cts] Default to immutable chunks 2024-07-02 jrprice [msl] Avoid non-standard __VA_ARGS__ behavior 2024-07-02 jrprice [msl] Add polyfill for frexp builtin 2024-07-02 jrprice [msl] Add polyfill for modf 2024-07-02 jrprice [ir] Handle `let` in RenameConflicts 2024-07-02 jrprice [msl] Emit TINT_INVARIANT macro 2024-07-02 jrprice [msl] Add polyfill for integer sign 2024-07-02 jrprice [msl] Add polyfill for floating point modulo 2024-07-02 dsinclair [hlsl] Pass module into RUN_TRANSFORM. 2024-07-02 jaswant.panchumarti Fix linker errors for android webgpu library 2024-07-02 kainino Add OWNERS for generator and emdawnwebgpu 2024-07-02 jimblackler Fix for path in Android cmake file. 2024-07-02 dawn-autoroll Roll ANGLE from a674dc1dae8f to d8700dc951b6 (7 revisions) 2024-07-02 dawn-autoroll Roll vulkan-deps from 4a2ff9e87700 to a69f4fce99da (5 revisions) 2024-07-01 dawn-autoroll Roll DirectX Shader Compiler from 49d1ae9a029c to 1fefbc429bad (1 revision) 2024-07-01 lehoangquyen Implement BufferMapExtendedUsages on D3D11 Created with: roll-dep third_party/dawn Bug: chromium:355003178 Change-Id: Ifb5e9d2a7ad54d76768e4bc049d856de25eaf9c0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5776166 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Matthew Denton <mpdenton@chromium.org> Auto-Submit: Ho Cheung <hocheung@chromium.org>
angle-autoroll 86d5c013 2024-08-14T09:59:04 Roll Chromium from 6ff5641dd7da to fdf9925b6b4a (714 revisions) Update third_party/kotlin_stdlib/BUILD.gn per https://chromium-review.googlesource.com/c/chromium/src/+/5786197 https://chromium.googlesource.com/chromium/src.git/+log/6ff5641dd7da..fdf9925b6b4a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/04dc0570f0..278b5d141a * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/1e192ffd2c..ef71623932 * buildtools/linux64: git_revision:449f3e4dfb45f6489321746f79f47f3e0d50211d..git_revision:54f5b539df8c4e460b18c62a11132d77b5601136 * buildtools/mac: git_revision:449f3e4dfb45f6489321746f79f47f3e0d50211d..git_revision:54f5b539df8c4e460b18c62a11132d77b5601136 * buildtools/win: git_revision:449f3e4dfb45f6489321746f79f47f3e0d50211d..git_revision:54f5b539df8c4e460b18c62a11132d77b5601136 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/0c63da3611..d26671f1f0 * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/eb283993fe..5b07f6628f * third_party/android_build_tools/lint: 9K7_0qP6qLJYoTIBQbzGyQrp5Mg5hynCauo4C2CNmQgC..lUNkrgd8i-8yn5XP5j3GBmtw_wbbcLVe4ZcxMsgP03cC * third_party/android_build_tools/manifest_merger: JXk3VujXEXETb_EDbiIDzz75OTJypjHecAkL5Ep2TesC..VOU97ku-mZhXrQUHZ4fQMJVmlvMZcKInINigQJyvQQAC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/757d1c1c40..a2d0eac2df * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/2ebd180cb2..e7ed14eb8f * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1e6454f8d2..39ca85acf5 * third_party/kotlin_stdlib: 6Zgw7vC2xVE_bQKd2NaOI2QDOwLrO_0AsFjxzqNW56IC..LPDM6HLFsJuO_Crq0eaKCdr056AgYZ7Jz_D8NYTxragC * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/de70eaccdf..7679949608 * third_party/r8: CK0fl-ENuJLkuGA1H6GOtYYCSYXfAMMa4fOmz8m-ImQC..pDW3OBH87Wm9f3PIhkxRptVG2qnlAiobu7ORMykmy1cC * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/71660e196b..d3aea2341c * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/21fc900137..4efc34892e * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/06fb241a9b..6abb195855 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/b9d36da21d..6ef7f80e30 * tools/skia_goldctl/linux: Bas4r4RnsyHJXGNTH4kqbShe_rCQjSkO5x2WcksxR1AC..8P9u35-wUJOuCZt7KfoaHql4TnnYfCE6PcMUJaLjcG0C * tools/skia_goldctl/mac_amd64: blbu8gzUuPifi_YFD7taMkRJoR4pkRHoRdn9w7tnvwYC..msDdo7ZqznAXC4geehuff02Ggz-TUFdGe5bqHvnWCQ4C * tools/skia_goldctl/mac_arm64: VypwLRz6xpTltEBkjr98ys-HTWA7bhclqK3Zyv51TlAC..neECyUAIg1_QJCcxMv9PgZnZ5iVqoq43ZRTFhE5F12YC * tools/skia_goldctl/win: F3cqWj6Vpw9BrQoAOWqMXpEYc56DoYJWoQH_hk9SSdcC..YufvDpBuGUe9YcFanPljAShLJMIp6_OV_XLBY0JrltgC No update to Clang. Bug: chromium:359175488 Change-Id: I22e58a3ea0a8fe3b7810ee2d1276230c5c953c29 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5787922 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Geoff Lang 6fddb18d 2024-07-26T12:44:23 GL: Disable heavily emulated extensions for non-WebGL. The multidraw and base vertex base instance extensions are heavily emulated in ANGLE's GL backend, manipulating vertex arrays multiple times per draw. This is often a performance improvement for deep pipelines such as WebGL but slower for shallow stacks like Chrome's rasterization. Mark these extensions as "emulated" and disable them in the frontend for non-WebGL contexts. Only EXT_base_instance can have true native support. Add a frontend feature to re-enable these extensions and use it in the existing end2end tests. Bug: angleproject:355645824 Change-Id: I897559fb270e2aa0f476d7784d25d97574e28f43 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5743837 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
angle-autoroll b5d2b1c9 2024-08-14T10:01:58 Roll vulkan-deps from c297ee8a1d20 to f084a55f96da (1 revision) https://chromium.googlesource.com/vulkan-deps.git/+log/c297ee8a1d20..f084a55f96da Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/2d73636d5425ddfa7c58967474522e65bc45f0f0..8d902c7f67edd9e54b0fa5f7d2c34f9abfeacba8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I44522b08a574f1b83c2610680acc4c6539728cb5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5787782 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 087afc91 2024-08-10T20:40:53 Vulkan: Prefer fallback to renderable texture than CPU copy When a texture copy is done, the transfer path is preferred. If transfer is not possible, ANGLE falls back to a draw-based copy. However, if the format is not renderable, ANGLE falls back to CPU copy. Instead, this change makes ANGLE try to fall back to a renderable format before giving up on the draw-based copy. Bug: b/351872449 Change-Id: I3d09dd88cc0b7feb5e92e58c4f19380973eb5e94 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5775592 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Austin Annestrand 5967afe7 2024-04-02T17:45:48 CL: Update Platform ctor to handle rx errors Bug: angleproject:359294584 Change-Id: I7aad107e57ea6f29b8fc69205ba72c27de6a9428 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5421576 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com>
Geoff Lang 072dc5d1 2024-08-13T13:53:52 Metal: Disable multisampled render to texture. Corruption has been seen on M1 Macs for WebGL content which uses a multisampled backbuffer. Bug: chromium:358957665, angleproject:42261786 Change-Id: Ia17581b15cd032e91e2642d80abace8d57ceb23b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5783540 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Quyen Le <lehoangquyen@chromium.org>
angle-autoroll 8639be94 2024-08-13T14:34:10 Manual roll vulkan-deps from 77d583f37170 to c297ee8a1d20 (3 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/77d583f37170..c297ee8a1d20 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/faeb5882c7faf3e683ebb1d9d7dbf9bc337b8fa6..83cd92c725987857a84c871bd8bc11b249d239b1 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/3aec0e6c90c942691063318194637d007306159f..2d73636d5425ddfa7c58967474522e65bc45f0f0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I520f03098204a16bfcac57fd6e01382459ff1501 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5785295 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Geoff Lang b36d94dc 2024-08-02T16:23:03 WebGPU: Implement viewport and scissor Tested using samples. dEQP tests covering viewport and scissor require more shader translation to be completed. Bug: angleproject:0 Change-Id: Ia76f2edeea5a07af1881704a21fafb64ab7df43a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5756127 Reviewed-by: Liza Burakova <liza@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov c1767fd9 2024-08-13T12:37:18 Suppress deqp_khr_gles31 failure on Samsung S22 KHR-GLES31.core.shader_image_load_store.basic-allTargets-loadStoreCS regressed in http://ci.chromium.org/ui/p/angle/builders/ci/android-arm64-exp-s22-test/912 http://chromium-review.googlesource.com/c/angle/angle/+/5719258 Bug: angleproject:350994515 Change-Id: I342043208cd85acf2877399f9a528c3dd428631b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5785959 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Sylvain Defresne c9bf5465 2024-08-12T11:47:16 Reland "Remove the linkage-specification on `main`" This is a reland of commit b60dc9d59aad03e641b86431c277c877d4ca9d7a Original change's description: > Remove the linkage-specification on `main` > > According to the standard, the main function should have no > linkage-specification [1]. New version of clang will enforce > this via a warning [2] which causes build failure if building > with `-Werror` which treats warnings as error. > > Remove the superfluous linkage-specification to fix the error. > > [1]: https://eel.is/c++draft/basic.start#main-3 > [2]: https://github.com/llvm/llvm-project/pull/101853 > > Fixed: chromium:358427300 > Change-Id: I541166cbd122c7e296ecdd2b5a9f9a107fe82872 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5782349 > Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Fixed: chromium:358427300 Change-Id: I380fdf74dc2a056f94af35c5c6c566a88d750c7d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5785953 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll fdd26da9 2024-08-13T09:46:13 Manual roll vulkan-deps from c95d5ac066d8 to 77d583f37170 (7 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/c95d5ac066d8..77d583f37170 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/7c4d91e7819a1d27213aa3499953d54ae1a00e8f..3a08cd8de1f88d114c18670366f29226db453a9e https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/7c8f556c0039383ebb7cba1cbe96b539c14d360a..3aec0e6c90c942691063318194637d007306159f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I84f9ac5bf6f7ecabe75e619951481174f206a11f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5785658 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov 1735415a 2024-08-13T10:14:57 Remove unused deqp_khr_gles3 expectations KHR-GL33.cull_distance.functional was split into individual cases in https://chromium-review.googlesource.com/c/angle/angle/+/5710888 Also move SWIFTSHADER expectations added in that CL to be after VULKAN ones, to avoid conflicts due to VULKAN expectations applying to SWIFTSHADER as well. Bug: b/353358652 Change-Id: Idebfba9ef90b7e882d7072538722a591c9dc007b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5785955 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
angle-autoroll 3da39c32 2024-08-13T07:24:53 Roll Chromium from cb6c951edfe3 to 6ff5641dd7da (549 revisions) https://chromium.googlesource.com/chromium/src.git/+log/cb6c951edfe3..6ff5641dd7da If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/9c8e2f1a26..04dc0570f0 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/b1b19dce16..1e192ffd2c * buildtools/linux64: git_revision:05eed8f6252e2dd6b555e0b65192ef03e2c4a276..git_revision:449f3e4dfb45f6489321746f79f47f3e0d50211d * buildtools/mac: git_revision:05eed8f6252e2dd6b555e0b65192ef03e2c4a276..git_revision:449f3e4dfb45f6489321746f79f47f3e0d50211d * buildtools/reclient: re_client_version:0.155.0.f89f6fe3-gomaip..re_client_version:0.156.0.a46645a7-gomaip * buildtools/win: git_revision:05eed8f6252e2dd6b555e0b65192ef03e2c4a276..git_revision:449f3e4dfb45f6489321746f79f47f3e0d50211d * testing: https://chromium.googlesource.com/chromium/src/testing/+log/8ee8e2d2b4..0c63da3611 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/5e53b74c00..757d1c1c40 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7762989876..1e6454f8d2 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/edb1e0a15d..de70eaccdf * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/d29518255a..21fc900137 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/e341adad10..de41d6c162 * tools/luci-go: git_revision:be41b8d978e22d396ecb4aa9f50ddc3f25977359..git_revision:ad7b787aa0ee53a81bc88fb4f7fee7a3ff1e8c29 * tools/luci-go: git_revision:be41b8d978e22d396ecb4aa9f50ddc3f25977359..git_revision:ad7b787aa0ee53a81bc88fb4f7fee7a3ff1e8c29 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/18f2887c9b..06fb241a9b * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/78e90830f6..b9d36da21d * tools/skia_goldctl/linux: HBWTb3YUFBBjYkOtjhxS1wlkmEml8L10JqtlnSdhw-UC..Bas4r4RnsyHJXGNTH4kqbShe_rCQjSkO5x2WcksxR1AC * tools/skia_goldctl/mac_amd64: W-fY5DncMFHUQVRKwZ-6a1bTL3Q0Cb0nqA5Kn8m2cZ4C..blbu8gzUuPifi_YFD7taMkRJoR4pkRHoRdn9w7tnvwYC * tools/skia_goldctl/mac_arm64: 0-qMzZ4dqMlt0A1qSjLar6NlcpAkZNqG3wxM17cGS4AC..VypwLRz6xpTltEBkjr98ys-HTWA7bhclqK3Zyv51TlAC * tools/skia_goldctl/win: zOnwb1fg3Utxextms-shBCXVqq3TZ4q-P-8Yh4Uv7uwC..F3cqWj6Vpw9BrQoAOWqMXpEYc56DoYJWoQH_hk9SSdcC No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: Ia414628ef49b49c00bb39b8c8ec40003ccb64c31 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5785655 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Austin Annestrand 5b4517ec 2024-02-02T14:04:29 CL/VK: Add helper for inserting barriers Adding a helper function to insert execution and memory barriers when resource access commands are recorded into the command buffer in CLCommandQueueVk. An example of a copy buffer command with src and dst ``` set access.readBuffer <- src set access.writeBuffer <- dst insert barriers - onResourceAccess(access) add copy command - commandBuffer->copyBuffer() ``` Bug: angleproject:42267073 Change-Id: I61d8064fd015a4bf3dab018cbb83d147915ed627 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5409249 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com>
Gowtham Tammana f8fc8ac3 2024-08-05T11:50:11 Vulkan: Remove dependency on ContextVk for CommandBufferHelper Following on the changes in [1], this makes the `CommandBufferHelperCommon` and `OutsideRenderPassCommandBufferHelper` interfaces independent of `ContextVk` state. Any dependency is made explicit. In addition, interfaces that are not specific to GLES context are also updated. [1]: Commit (bcf814fda5 Vulkan: Constrain the dependency on ContextVk in BufferHelper) Bug: angleproject:8544 Change-Id: I7d90ad915e8c14187ab5584453b9e8802bd91e2b Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5319147 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov 3d6cf23c 2024-08-12T16:26:03 Skip end2end tests failing on iOS simulator Bug: angleproject:359136169 Change-Id: Ic1100d74f308c6d8a3d2f450e8b5f46e8539f2a5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5782861 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Le Hoang Quyen ee25dddb 2024-08-09T01:03:26 Metal: Properly clear render pass' attachment with an emulated alpha. When a texture is created with emulated format such as RGB, its alpha channel is initialized to 1 and the write mask is configured such that the alpha value won't be overwritten or set to other values. However, if we use this texture as an attachment in a render pass, and DontCare loadAction is used, the alpha value would be initialized with garbage values. No draw calls within the render pass would change these garbage values because the configured write mask already prevents that. Thus the garbage alpha values would be stored in the memory after the render pass ends. This bug also affects MSRTT's unresolve step, because it uses a draw call to blit the resolve texture to the MSAA texture. However, the alpha write is disabled thus the MSAA texture will remain having garbage alpha values. The fix for this bug is that: if we detect that the texture has emulated format and its loadAction is DontCare, we change it to Clear action to clear the alpha channel to 1. Bug: angleproject:42261786 Change-Id: I994849bd4b3c3ab51698833d1cc520376ae6de44 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5773347 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Auto-Submit: Quyen Le <lehoangquyen@chromium.org> Commit-Queue: Quyen Le <lehoangquyen@chromium.org>
angle-autoroll 526e0408 2024-08-12T09:49:32 Roll Chromium from 26ff6a053683 to cb6c951edfe3 (1358 revisions) Add newly needed dependencies: third_party/android_build_tools/error_prone/cipd third_party/android_build_tools/error_prone_javac/cipd https://chromium.googlesource.com/chromium/src.git/+log/26ff6a053683..cb6c951edfe3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/a0e5713502..9c8e2f1a26 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/1926812554..b1b19dce16 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/7605e1a3e3..8ee8e2d2b4 * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/f7c885fa9e..eb283993fe * third_party/android_build_tools/lint: VSZsvsCZqxvPmRURoEXm6_9prLL38jGMQKXQNZUHmkcC..9K7_0qP6qLJYoTIBQbzGyQrp5Mg5hynCauo4C2CNmQgC * third_party/android_build_tools/manifest_merger: xoWqP0Bmz9ReU5nL9ems2x3Ir4Ir3PMTLyba0Ibs824C..JXk3VujXEXETb_EDbiIDzz75OTJypjHecAkL5Ep2TesC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/2feeb46c60..2ebd180cb2 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/75932421da..7762989876 * third_party/fuchsia-sdk/sdk: version:22.20240801.2.1..version:23.20240808.4.1 * third_party/kotlin_stdlib: qtDQdcYfgSh4FeSY3TnkSjnZ5FqCbP1kjk1Zj1m6Jd4C..6Zgw7vC2xVE_bQKd2NaOI2QDOwLrO_0AsFjxzqNW56IC * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/7993b2fda2..edb1e0a15d * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/6db1ccfa71..116c20dae6 * third_party/r8: PXH37yAaLUOxMKapVN58gGbrt4ncdU0of7PVnU1hqlAC..CK0fl-ENuJLkuGA1H6GOtYYCSYXfAMMa4fOmz8m-ImQC * third_party/siso/cipd: git_revision:54a843e6d76610b340d62437aca89653a9a9e18f..git_revision:87262779ecc3482c8c60b070404b225107212d0d * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/324faa7115..d29518255a * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/bd2518c73b..e341adad10 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/647af9c63d..78e90830f6 No update to Clang. Bug: chromium:354802413 Change-Id: I86c41fd2d80087628fdb513958d579ab9e4754df Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5782309 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Solti Ho <solti@google.com>
Yuly Novikov f0465cac 2024-08-12T15:46:14 Revert "Remove the linkage-specification on `main`" This reverts commit b60dc9d59aad03e641b86431c277c877d4ca9d7a. Reason for revert: Fails to roll into Chromium https://chromium-review.googlesource.com/c/chromium/src/+/5782182 https://cr-buildbucket.appspot.com/build/8739800008401884241 Original change's description: > Remove the linkage-specification on `main` > > According to the standard, the main function should have no > linkage-specification [1]. New version of clang will enforce > this via a warning [2] which causes build failure if building > with `-Werror` which treats warnings as error. > > Remove the superfluous linkage-specification to fix the error. > > [1]: https://eel.is/c++draft/basic.start#main-3 > [2]: https://github.com/llvm/llvm-project/pull/101853 > > Fixed: chromium:358427300 > Change-Id: I541166cbd122c7e296ecdd2b5a9f9a107fe82872 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5782349 > Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Change-Id: Id9f99c21480e7f72617b2907c35356e5033a3ce4 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5782859 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cody Northrop 681b681b 2024-08-10T14:03:28 Tests: Add Grand Mountain Adventure trace Test: angle_trace_tests --gtest_filter="*grand_mountain_adventure*" Bug: b/358846996 Change-Id: If6815705b357eb69a777156d840be17fbe362938 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5779619 Commit-Queue: Roman Lavrov <romanl@google.com> Auto-Submit: Cody Northrop <cnorthrop@google.com> Reviewed-by: Roman Lavrov <romanl@google.com>
Sylvain Defresne b60dc9d5 2024-08-12T11:47:16 Remove the linkage-specification on `main` According to the standard, the main function should have no linkage-specification [1]. New version of clang will enforce this via a warning [2] which causes build failure if building with `-Werror` which treats warnings as error. Remove the superfluous linkage-specification to fix the error. [1]: https://eel.is/c++draft/basic.start#main-3 [2]: https://github.com/llvm/llvm-project/pull/101853 Fixed: chromium:358427300 Change-Id: I541166cbd122c7e296ecdd2b5a9f9a107fe82872 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5782349 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll f52aaf99 2024-08-12T10:01:04 Roll vulkan-deps from 236cdecbee13 to c95d5ac066d8 (6 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/236cdecbee13..c95d5ac066d8 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/b64a423b44f448df5464978173e28be12069b73c..87fcbaf1bc8346469e178711eff27cfd20aa1960 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/3131e4be90985c9f3c063d1527f0368a98166765..7c8f556c0039383ebb7cba1cbe96b539c14d360a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I386a2729bb16de928a0e0511e51afa1e10f51911 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5782389 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Kimmo Kinnunen 11724133 2024-08-06T12:02:54 Metal: Separate vars with normal types Separate compound expressions separates expressions as temporary values. Previously creating a temporary variable would copy the entire type. Qualifiers and interface block info but shouldn't ever be applied to temporary variables. This would lead to assertions during MSL output. Fix by copying the type and unsetting qualifiers and interface block info. Bug: angleproject:357622691 Change-Id: Id868cd3eaabe3710121d6c9a565304e282ddb69f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5762605 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com>
Alexey Knyazev 6e248bcb 2024-06-20T00:00:00 Metal: Fix ASTC on visionOS Adjusted compile guards to include visionOS target. Fixed: angleproject:358393363 Change-Id: If7ead234f5deaee524172d2fb38d4a041c915716 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5777140 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Roman Lavrov 0bb0a886 2024-08-08T17:05:27 Drop .{ANGLE_REVISION} from ANGLE version when revision == 0 This can happen when git revision is unavailable, such as in rolls to Android. Instead of using ANGLE 2.1.0 git hash: ... use: ANGLE 2.1 git hash: ... This applies to GL_VERSION, version we see in logcat etc. Bug: b/348044346 Change-Id: Iaef13025922cf0a1a9c2c1e556b9e9fe2a1aae01 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5774120 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Igor Nazarov 2b15c795 2024-08-09T17:13:17 Make explicit that GenerateCrc() return correct CRC32 hash According to the documentation of `crc32_z()`, to get required initial value need to call `crc32_z()` with nullptr "buf" parameter. Using this initial value will produce correct CRC32 hash. On practice, `crc32_z()` with nullptr "buf" produces "0", so the current code actually calculates correct CRC32 hash. However, this is still against the documentation, and in different versions of zlib or architectures may produce incorrect results. Technically, `GenerateCrc()` does not require to produce correct CRC32 hash - the main purpose is to calculate some hash value. But because updating this function to produce correct CRC32 hash is very easy, this change updates the implementation and renames it to `GenerateCRC32()` to explicitly state that it generates correct CRC32 hash. After this, function may be used in scenarios where CRC32 hash is really required. Bug: angleproject:4722 Change-Id: Ib159f2d3ad1a8388f505abb09a6d0b19a51b7eec Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5777145 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 6ecc3542 2024-08-09T10:01:23 Roll vulkan-deps from 9b5edb173670 to 236cdecbee13 (1 revision) https://chromium.googlesource.com/vulkan-deps.git/+log/9b5edb173670..236cdecbee13 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/5398d55e33dff7d26fecdd2c35808add986c558c..7c4d91e7819a1d27213aa3499953d54ae1a00e8f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: Id17a1d58acc2136af7c92145149f9b9d4848cdf8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5775610 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexey Knyazev 7bab5bce 2024-06-20T00:00:00 Metal: Support BC texture formats with non-macOS targets Used supportsBCTextureCompression device query to check BC formats support on Apple GPUs. Fixed: angleproject:42266573 Change-Id: I60fd5614d10d0c4558992e2c5d3e4b4c1a396aaa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5771136 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Igor Nazarov bacd3a7d 2024-08-07T19:01:18 Vulkan: Fix CompressAndStorePipelineCacheVk() crashing `ContextVk` may be destroyed while `CompressAndStorePipelineCacheTask()` is still running. Context is only used to output a performance warning. So in case of such performance warning, `gl::State::mDebug` object may be already destroyed, causing undefined behavior. Change removes `ContextVk` from the function and uses `WARN()` instead. The `CompressAndStorePipelineCacheTask` stores pointer to the `vk::Renderer` instead of `ContextVk`. Bug: angleproject:4722 Change-Id: Iba9cad78ce5c6ea29cc2143f7bd2340cf0484855 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5768881 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Austin Annestrand 98b06696 2024-06-17T17:28:56 CL/Vulkan: Add initial profiling support This PR introduces initial cl_event profiling support. For now, use CPU timestamps (later look into Vulkan GPU device timestamps). Bug: angleproject:357902512 Change-Id: I2197e396e222d2842ab31304f91934f9e000ea0d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5767598 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Brian Sheedy 4b4ef052 2024-08-08T13:58:49 Suppresess SmallRowLength failure Suppresses the ReadPixelsPBOTest.SmallRowLength failure that is happening on the experimental Linux/Intel config with OpenGL. Bug: angleproject:358407353 Change-Id: I2ebaf935cc4d2cf101e7a3597a16ceeffbd0c4d7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5774484 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Austin Annestrand d1d9cd63 2024-06-17T17:22:16 CL/Vulkan: Init events to NULL before enqueue On a CL enqueue API call, if the passed cl_event object ref is not NULL, set the object to NULL initially before we create it during enqueue call. Bug: angleproject:357902512 Change-Id: I7d94012c38eb96e7021da20ea22bd741e536de53 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5767597 Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Kimmo Kinnunen cb27b4a4 2024-08-08T10:17:47 Metal: Remove MTLGPUFamilyApple9, it is unused Fixes visionOS compiles, the SDKs do not define the symbols. Changes the SDK #if checks to be more consistent: - Remove version checks from WATCHOS, as it's expected to be compiled with fairly recent SDK (Metal is not supported). - Compile fallbacks only when needed by the minimum deployment target. - Add Apple3 -> :MTLFeatureSet_tvOS_GPUFamily2_v1 mapping just for consistency. Bug: angleproject:347739670 Change-Id: I054c9faeba4245be8be6cfa7128f17df03f448da Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5771352 Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com>
angle-autoroll a8064b1c 2024-08-08T10:01:22 Roll vulkan-deps from b4b1cdd9bdc8 to 9b5edb173670 (6 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/b4b1cdd9bdc8..9b5edb173670 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/246daf246bb17336afcf4482680bba434b1e5557..b64a423b44f448df5464978173e28be12069b73c https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/2b259270bc36c993ddd88ee1bedf0a5cf92b1504..3131e4be90985c9f3c063d1527f0368a98166765 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I71f83fe5901edec8c623fe29f45813e0bdf08c51 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5772895 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll d335f134 2024-08-08T08:18:56 Roll Chromium from 0023a97ccc68 to 26ff6a053683 (629 revisions) https://chromium.googlesource.com/chromium/src.git/+log/0023a97ccc68..26ff6a053683 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/ccf6cbbf69..a0e5713502 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/4b215dfd6d..1926812554 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/9572d0e05d..7605e1a3e3 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/98becd7a82..0b4fc47c61 * third_party/android_sdk/public: mU9jm4LkManzjSzRquV1UIA7fHBZ2pK7NtbCXxoVnVUC..fv6JzkTqfxfIbmsRC8u1b2y0EQO7yQDMDzY3-g0NVu4C * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/bb1174425b..2feeb46c60 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2f8e1e499d..75932421da * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/2f631b93b6..7993b2fda2 * third_party/r8: V0rEm7HQ4M0KO8bD73BfJZhw3OOkTwVL8DgbglfHMvEC..PXH37yAaLUOxMKapVN58gGbrt4ncdU0of7PVnU1hqlAC * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/a5de1b1a82..324faa7115 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/97770e8b1f..bd2518c73b * tools/luci-go: git_revision:771ea9a614a104c71655f699ef82219a2a474817..git_revision:be41b8d978e22d396ecb4aa9f50ddc3f25977359 * tools/luci-go: git_revision:771ea9a614a104c71655f699ef82219a2a474817..git_revision:be41b8d978e22d396ecb4aa9f50ddc3f25977359 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/db937e1788..647af9c63d * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/d6935c210b..e27ef2019a * tools/skia_goldctl/linux: dPSh2hSFImVtYVOiMVjHTBEre0Asyy65tgiDL8miZbgC..HBWTb3YUFBBjYkOtjhxS1wlkmEml8L10JqtlnSdhw-UC * tools/skia_goldctl/mac_amd64: qtaQhHygWRQcSDpg6ZVJNUfceR2EZH3rto0pOFEebzkC..W-fY5DncMFHUQVRKwZ-6a1bTL3Q0Cb0nqA5Kn8m2cZ4C * tools/skia_goldctl/mac_arm64: VRxzxVSfFBWl3AlTnrcO-4gQY5i6AYveLfh2Eop5-UIC..0-qMzZ4dqMlt0A1qSjLar6NlcpAkZNqG3wxM17cGS4AC * tools/skia_goldctl/win: DJGQjlpG-s27CzX1oKqNQtH9fBh6kgVemcGds9How_4C..zOnwb1fg3Utxextms-shBCXVqq3TZ4q-P-8Yh4Uv7uwC No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: Ib1fcc02ae38d3c433a4438fb4a772be71e025ff9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5772893 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuxin Hu 81c01d2f 2024-08-01T14:15:48 Add an option to output baked angle git hash to angle_commit.h We can leverage the ${rolling_to} hash value that is available in skia auto roller and use it as the ANGLE_COMMIT_HASH for Android Builds. Skia roller script can set ${rolling_to} hash to an environment variable ANGLE_UPSTREAM_HASH. In commit_id.py, check that if environment variable ANGLE_UPSTREAM_HASH is available, output the environment var into angle_commit.h. Bug: b/348044346 Bug: skia:356444755 Change-Id: I5232e4026d8b02d3ba603af0018060edb487566e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5758427 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Roman Lavrov <romanl@google.com>
kmx.io     mail     discord kmxgit v0.4.0