kc3-lang/angle

Log

Author Commit Date CI Message
angle-autoroll db0c266c 2025-06-13T07:01:21 Roll Chromium from 3d57e475d87b to 5d8e5baf56fe (514 revisions) https://chromium.googlesource.com/chromium/src.git/+log/3d57e475d87b..5d8e5baf56fe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/d3120086b9..cb527f4b98 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/5585f637a9..175c1fa28c * testing: https://chromium.googlesource.com/chromium/src/testing/+log/e1f1d61956..dd6fb44bdc * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/46e997c931..84b990c066 * third_party/android_build_tools/error_prone/cipd: OFmDaNXqS5PTb5YKd4fCb0Y4cK4ImQXeZISzw9p1ILcC..RiplT9oTSE0lQHviAF6FMk5P9863t0-WHcl2te12hi0C * third_party/android_build_tools/lint/cipd: elV-KSOeiX0hBeuw8Swk8wWiXT8Ns35MNwiOp6SLR4QC..Otd2S_y5ozK3q8Q7eMr1NqNH38ESBnUYT4I842UsU0UC * third_party/android_build_tools/manifest_merger/cipd: VcONzD64-9oyADpPb46XY3qQ0bWCJVaFIKA2dNziAY4C..UrgRDTQRxa2KqkIGo6gwYOY7uf56hYmH-QAjov2N9NMC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/850859350a..1d50003d81 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ea261d7c75..d4c627ed62 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/3a31ad538c..e44c3c4560 * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/79e514564f..5bbf35ae68 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/383ed10195..1f64d055db * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/9ca8819752..886355a984 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/03b01d3183..7e6f482ce7 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/a7295ec21f..5730d2a457 No update to Clang. Bug: None Tbr: solti@google.com Change-Id: Ic359a4bc4ee967be0c8ca055b39eb524a1b75326 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6642231 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Tim Van Patten fdff1170 2025-06-06T10:46:03 tests: SystemEGL: Skip tests needing unsupported ANGLE EXTs The system EGL may not expose ANGLE extensions, even if it *is* ANGLE, due to platform EGL restrictions (e.g., Android platform EGL). Skip any tests requiring ANGLE-specific extensions during test setup, rather than failing them. This also requires refactoring ANGLETestBase to derive ::testing::Test so it has access to Test::IsSkipped(). Bug: b/279980674 Change-Id: I8e424509c41fa5a69dee9fc8e0c92da58e4758fe Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6622112 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Matthew Denton 005336e4 2025-06-11T17:17:16 WGPU: Basic texture cubes Allows uploading to texture cube faces and sampling from them in shaders using samplerCube. Bug: angleproject:420782526 Change-Id: I45d4370fcc418f39afb225114d13632a78c7c200 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6593999 Reviewed-by: Liza Burakova <liza@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org>
Yuxin Hu 5d63c8d5 2025-06-11T13:01:25 Reformat VVL error message Update the VVL error message to use the new format. Remove the unused VVL error. Bug: angleproject:42264926 Bug: angleproject:42263911 Bug: angleproject:42265079 Bug: angleproject:42264496 Change-Id: I151960942c1bbf346693f250ec57f01fa3432784 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6634225 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
angle-autoroll 746ccc66 2025-06-12T03:01:00 Roll SwiftShader from 13a5d59c83e4 to 7b7b93aa0b85 (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/13a5d59c83e4..7b7b93aa0b85 2025-06-11 syoussefi@google.com Implement VK_KHR_unified_image_layouts 2025-06-11 ynovikov@chromium.org Add missing include If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:422982681 Tbr: solti@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I1b6ba1ff4c994fa05f67d3d8ecba5ac3b8f3f944 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6639522 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 8cc8bdc7 2025-06-12T10:01:07 Roll vulkan-deps from e16ef854c44f to cd8294df9efa (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/e16ef854c44f..cd8294df9efa Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/3b9447dc98371e96b59a6225bd062a9867e1d203..50daff941d88609b4d2ad076eae558e727f8e5cd https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/e9a8ceeddbf7e3aaadac2ab6f8a6ab6437872e88..27dd301f866121798eca9f2b920b6cb58be3a92e https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/59483c4ebaaecbaa4ca887a68c1631d17177a35c..95dbf1f8f499b068e47967e58ccd3d4eaa941422 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: I07862f99b92e8c1bc8bf83d1a2617c19a835c17f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6640345 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 37b9f78d 2025-06-12T07:53:59 Roll Chromium from 618b8dc7c27c to 3d57e475d87b (645 revisions) https://chromium.googlesource.com/chromium/src.git/+log/618b8dc7c27c..3d57e475d87b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/af5fc163a6..d3120086b9 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/164f8abf67..5585f637a9 * buildtools/linux64: git_revision:8ea3af9118a65387fe4d8428db6f59c5927dd55a..git_revision:899572b32b8bb610cfeeefd162d9aefb46e29d97 * buildtools/mac: git_revision:8ea3af9118a65387fe4d8428db6f59c5927dd55a..git_revision:899572b32b8bb610cfeeefd162d9aefb46e29d97 * buildtools/win: git_revision:8ea3af9118a65387fe4d8428db6f59c5927dd55a..git_revision:899572b32b8bb610cfeeefd162d9aefb46e29d97 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/9e9017624a..e1f1d61956 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/2b011cd0e9..46e997c931 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/8413456528..6abf1d7a33 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/a1a1df4d27..850859350a * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/974e876217..ea261d7c75 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/aca8664738..3a31ad538c * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/e3eb847e51..79e514564f * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/2be4a578cb..383ed10195 * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/1097f51190..9ca8819752 * tools/luci-go: git_revision:a716714d42790a4677b6abb0bf0c3102d6d5bb6f..git_revision:0250323d999386415553b5e2297eafe827ca41f3 * tools/luci-go: git_revision:a716714d42790a4677b6abb0bf0c3102d6d5bb6f..git_revision:0250323d999386415553b5e2297eafe827ca41f3 * tools/luci-go: git_revision:a716714d42790a4677b6abb0bf0c3102d6d5bb6f..git_revision:0250323d999386415553b5e2297eafe827ca41f3 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/d57ede6ba3..a7295ec21f * tools/skia_goldctl/linux: lkxqvhJtv-45S0zRCu7Z3er-IcDc6t931-7jM1lN-RMC..I1LygzXVm-v4LePMcFJ9j0k1AZoLq1UFO5FvEue2TbsC * tools/skia_goldctl/mac_amd64: r2LyNXR63hRBteBs8GN14Otjpbnu_VQvVOvDVUFjeV4C..uI8NbGw_UiTJ3W2CTVNlIycIt9w6x1ozArj3Y3F4UtkC * tools/skia_goldctl/mac_arm64: tJUKq9z8lfdk4KydEare4F1gdGAXnTVuC5W3k8mBQBMC..QSSJvE4WdrL_WsuphR6xIEvHYbO5MAX3yzL1OZUDCMEC * tools/skia_goldctl/win: 1pUE-hNBek5om-0mUbI4sJSEt4-m1AwEGnVNuEfMFOIC..72BoyHuvkKlIhZ3QJunOfOnQ4xpyI3ImPWyF8OcXrHMC No update to Clang. Bug: None Tbr: solti@google.com Change-Id: I4d32caf5fd38da29d16e8e71069ce9d63bea83ef Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6639844 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jisun Lee d8c15499 2025-05-27T03:46:24 Vulkan: Clear depth and stencil unresolve separately To take into account two situations. 1. LoadOp for depth and stencil attachments are set differently. 2. depth and stencil unresolves could be different between the previous render pass and the current render pass. Bug: angleproject:42266019 Change-Id: I9e069b3972f86abb84eee6280919e6bba2901225 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6590197 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Tim Van Patten d9818437 2025-05-22T12:52:29 tests: Cleanup build_angle_end2end_tests_library block 1. If Vulkan is enabled, always include the Vulkan tests in the end2end tests, rather than excluding them when build_angle_end2end_tests_library is 'true'. 2. Remove NDK include. It's unnecessary, because the 'angle' target already manages its own include_dirs. Bug: b/279980674 Change-Id: Ibf3c29a5f90f161a7c9a69f5c4736ea4c3ef49ae Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6580875 Reviewed-by: Solti Ho <solti@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Tim Van Patten <timvp@google.com>
Tim Van Patten 3c2bff4b 2025-05-22T12:33:12 Rename angle_end2end_tests_aosp to angle_end2end_tests_library Rename the GN arg angle_end2end_tests_aosp to angle_end2end_tests_library, because while building the end2end tests is relevant for Android, it's not restricted or specific to Android. Bug: b/279980674 Change-Id: I8f03e0fe264ac918cb34c379be85b65d7bfc0ab1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6580873 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Tim Van Patten <timvp@google.com>
Tim Van Patten f9053516 2025-06-10T14:24:13 MultiviewTestBase: Remove setWebGLCompatibilityEnabled(true) Remove setWebGLCompatibilityEnabled(true) from MultiviewTestBase since it's not required and prevents running the tests when the extension EGL_ANGLE_create_context_webgl_compatibility is not available. Bug: b/279980674 Test: angle_end2end_tests --gtest_filter=*Multiview* Change-Id: I32a95b110e17afcb0d45c0c8447d43f456310fee Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6635032 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Tim Van Patten 0d441eda 2025-05-29T12:04:46 util: Give all ConfigParameters default values ConfigParameters has a mix of 'bool' and 'Optional<bool>', with some tests setting the Optional<> values to the default value, inadvertently creating a dependency on the associated extension. To reduce the dependency on various extensions and allow more tests to run, update ConfigParameters to only contain raw bools and initialize them to the default values defined by the associated spec. This allows EGLWindow to only require the necessary extension when a non-default value is set by a test. This also requires updates to a handful of tests which were relying on the state of extensions due to non-default values. Bug: b/279980674 Change-Id: I77a7e102559e4393aadcdbf37886ae80cbbb9e29 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6618033 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
angle-autoroll d54c84e4 2025-06-11T10:01:56 Roll vulkan-deps from c102e5508704 to e16ef854c44f (5 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/c102e5508704..e16ef854c44f Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/90cfb3e96463b267e2a3b88181edf7bfde08d947..e9a8ceeddbf7e3aaadac2ab6f8a6ab6437872e88 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/a8f8e645cd32508a134597bd9089a35e8da26240..59483c4ebaaecbaa4ca887a68c1631d17177a35c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: I9de3b10b3647614b564bb810be9cabd469f81c94 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6637589 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 97043921 2025-06-11T03:01:07 Roll SwiftShader from a857503547cb to 13a5d59c83e4 (3 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/a857503547cb..13a5d59c83e4 2025-06-11 syoussefi@google.com Fix Debug build 2025-06-10 syoussefi@google.com Update Vulkan headers to version 1.4.317 2025-06-10 swiftshader.regress@gmail.com Regres: Update test lists @ a8575035 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:422982681 Tbr: solti@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I590150706f1054a7218dd578367cf4443f6662ae Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6637332 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 569f567e 2025-06-11T07:16:00 Roll Chromium from 48d63a682177 to 618b8dc7c27c (379 revisions) https://chromium.googlesource.com/chromium/src.git/+log/48d63a682177..618b8dc7c27c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/110bbb568f..af5fc163a6 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/941e05d14d..164f8abf67 * buildtools/linux64: git_revision:e5c4d1881b85b82789b7013233a944cf1a46370f..git_revision:8ea3af9118a65387fe4d8428db6f59c5927dd55a * buildtools/mac: git_revision:e5c4d1881b85b82789b7013233a944cf1a46370f..git_revision:8ea3af9118a65387fe4d8428db6f59c5927dd55a * buildtools/win: git_revision:e5c4d1881b85b82789b7013233a944cf1a46370f..git_revision:8ea3af9118a65387fe4d8428db6f59c5927dd55a * testing: https://chromium.googlesource.com/chromium/src/testing/+log/105a2f2754..9e9017624a * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d255a8d41e..974e876217 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/c7b224d8e8..2be4a578cb * third_party/r8/d8/cipd: i5l_yPIc-ZuKle_ibElGMSf50XN8buMgspBkoObkkRAC..F0pTWc6uG70kZPngypnQxCgD3CgY5D8O-pDqj_qeoQMC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/37098fd050..03b01d3183 * tools/luci-go: git_revision:4ee25ef52cdb1d0ce5bba817578a4b40381bc39e..git_revision:a716714d42790a4677b6abb0bf0c3102d6d5bb6f * tools/luci-go: git_revision:4ee25ef52cdb1d0ce5bba817578a4b40381bc39e..git_revision:a716714d42790a4677b6abb0bf0c3102d6d5bb6f * tools/luci-go: git_revision:4ee25ef52cdb1d0ce5bba817578a4b40381bc39e..git_revision:a716714d42790a4677b6abb0bf0c3102d6d5bb6f * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/d0f35a370e..d57ede6ba3 No update to Clang. Bug: None Tbr: solti@google.com Change-Id: I298b834f37ddd9c736c3ddba6f85afdb6c522fa6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6635836 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shashank Sharma c6b3440b 2025-06-06T23:34:33 Vulkan: Add G10X6_B10X6R10X6_2PLANE_420_UNORM_3PACK16 support. Add support for YCBCR_P010 format. Bug: b/408996471 Change-Id: I899533b604e5b2fd0ad1fb1e940dd1f119179794 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6628658 Reviewed-by: Solti Ho <solti@google.com> Auto-Submit: Shashank Sharma <shawshanks@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Amirali Abdolrashidi c39f4a5c 2025-06-05T15:35:06 Vulkan: Update border color assignment for stencil In texture border clamp, if the border color is assigned together stencil mode (both using glTexParameter()), its red component is used to set up a border color to be used in each backend: * (Set up in AdjustBorderColor()) In the Vulkan backend, this is used when updating SamplerDesc, which is then used later to set up the custom border color: * (VkSamplerCustomBorderColorCreateInfoEXT) According to the spec, in case of undefined format, integer border color, and stencil image, the implementation is required to use either the first or the second component of the custom color, although it is recommended to use the first. However, at the moment, only the first component is being populated, while using the second component is also valid. * Added feature: usesSecondComponentForStencilBorderColor * Added bit to SamplerDesc: mUsesSecondComponentForStencil * It is set based on the feature flag above and the texture format. * When setting the custom border color info, the second component will be used based on the above flag. * Added test suites to test this on ES31 and ES32: TextureBorderClampTestES3*.CustomBorderColorWithStencil* * Updated capture params for glTexParameterIuivEXT(). * Suppressed the ES32 version for the following: * P4 * Linux/NVIDIA (due to out-of-date driver) Bug: b/390710636 Change-Id: Ie50c19e8ea66da40dc8b8db49d7e622a582637a5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6626416 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Aurora Zhang 65159c4e 2025-06-05T15:05:46 Update pipeline desc when sample count changes * If the sample count changes when calling glFramebufferTexture2DMultisampleEXT, we need to update pipeline desc to ensure it is the same as the API requires. * Add a new end2end test to verify. Bug: angleproject:422611722 Change-Id: I7de7d3d17513cf03f5e24baa2db83633a229b4b8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6623419 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Aurora Zhang <Aurora.Zhang@arm.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 2519de7c 2025-06-10T18:34:57 Manual roll Chromium from 89af20128575 to 48d63a682177 (1478 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/chromium/src.git/+log/89af20128575..48d63a682177 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/74fd4e41fc..110bbb568f * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/64b9f65d16..941e05d14d * testing: https://chromium.googlesource.com/chromium/src/testing/+log/0cb342c45f..105a2f2754 * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/18bc289fc3..34bf3dd2d9 * third_party/android_build_tools/lint/cipd: B12WztL3EZsuJ7B1dMlfrnCHVd4n5qgxf_HYDQyzOkAC..elV-KSOeiX0hBeuw8Swk8wWiXT8Ns35MNwiOp6SLR4QC * third_party/android_build_tools/manifest_merger/cipd: 1QtZ_gZ5icFNOEvVrY34lJgcC2XoXxBfgPmz-eBrk7UC..VcONzD64-9oyADpPb46XY3qQ0bWCJVaFIKA2dNziAY4C * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/aa341ec41f..a1a1df4d27 * third_party/fuchsia-sdk/sdk: version:28.20250605.5.1..version:28.20250609.4.1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/cdae0b78c3..2c359c239b * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/39b4cdb3bd..c7b224d8e8 * third_party/r8/cipd: pxgwR4ardZ3LnNCARPEbdl_gTA9R1aaHowtsCNRpZaYC..F0pTWc6uG70kZPngypnQxCgD3CgY5D8O-pDqj_qeoQMC * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/4a625964c6..1097f51190 * third_party/siso/cipd: git_revision:963177240b1a36697c9762856f51ad36ab545ceb..git_revision:d704490133011610c402696584afedea80829dbd * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/60453178b6..479e8c395f * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/71e38a3895..37098fd050 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/04d0441efb..1c0b50128b * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/70322b4cf9..d0f35a370e No update to Clang. Bug: None Tbr: solti@google.com,ynovikov@google.com Change-Id: I79296225469163b4d99f784d1389742578588427 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6634622 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuxin Hu 1e613fec 2025-05-27T16:59:26 Compiler: sort uniforms by precision This change reoreders the AST sequences so that uniform declarations with lower precisions are places in front of uniform declarations with higher precisions. This is to prepare for the upcoming change that converts uniforms declared with mediump or lowp to 16-bit and pack them to 32-bit integeter using packHalf2x16(). Bug: b/405795981 Change-Id: I5e1e293399dc8b51b9a6e83115f95beb0c4a7b1b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6594255 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Mohan Maiya c45e7c83 2025-05-22T04:14:52 Vulkan: Optimize uniform and storage buffer updates Maintain a map between buffer block index and its DescriptorDesc index in WriteDescriptorDescs and look up the map instead of repeatedly calculating it when updating DescriptorDesc Bug: angleproject:386749841 Change-Id: I74d14f6205f07992fae1e338697998d04de1c563 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6603986 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Tim Van Patten b888dc2b 2025-06-09T16:58:38 OcclusionQueriesTest: Convert to ANGLETest<> Convert OcclusionQueriesTest to an ANGLETest<> and remove calling ANGLETestSetUp() directly. This can be error-prone if ANGLETestSetUp() doesn't complete, but the test still executes GL commands either in SetUp() or testSetUp(), before the test itself can be skipped. In that case, there may not be a current Context, leading to calls like glGetString() returning nullptr. This also includes some additional cleanup to remove the GetParam() calls. Bug: b/279980674 Change-Id: I5604836c78845424b82b693bc1b74e84b6b557d4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6631025 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Tim Van Patten 0ac62dd7 2025-06-09T16:47:22 MultiviewRenderTest: Return if test should be skipped MultiviewFramebufferTestBase::FramebufferTestSetUp() may not complete if ANGLETestBase::ANGLETestSetUp() determines the test needs to be skipped due to (for example) missing extension support. In that case, there may not be a current Context, leading to calls like glGetString() returning nullptr. Check if the test is marked "Skipped" before continuing in MultiviewRenderTest::SetUp(). Bug: b/279980674 Change-Id: Iba869029bc26fc5528853be0323fd3c50037a493 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6631023 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Shahbaz Youssefi ef85f283 2025-06-10T10:45:06 Test for deferred clear vs robust init vs invalidate Bug: b/381284577 Change-Id: I15effe1f216523a51af83a154ad27d2921e52258 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6633791 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Tim Van Patten de00cc6b 2025-05-28T17:06:59 tests: Move wglWindow to a guard statement WGL tests are currently disabled. Refactor the check to be a guard statement earlier in ANGLETestBase::ANGLETestSetUp(), so it bails out sooner. This also allows for pulling everything in the else-block out, reducing indentation and improving readability. Bug: b/279980674 Change-Id: Id91b68e2a2e5ffd301a7c49733940b7f08892dce Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6604937 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Tim Van Patten <timvp@google.com>
angle-autoroll 8c512f3e 2025-06-10T10:01:24 Roll vulkan-deps from 9fc5fb6a6005 to c102e5508704 (8 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/9fc5fb6a6005..c102e5508704 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/ec1c9ca71ae2e0a63f4245978accde381865266b..90cfb3e96463b267e2a3b88181edf7bfde08d947 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/bf4ea01344ced4bbfee5d2a04ce02e8c1e99df99..63b05d2b087952662623de7eddd44f2e57d71a1e https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/6104c98e8d16bcd392116cf30d32c519835a6cfe..a8f8e645cd32508a134597bd9089a35e8da26240 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: I7c60072e04e65720bc81831c05c79310ac45fc71 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6631749 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jeff Vigil a7877665 2025-06-02T08:13:30 Fix drm format and modifier handling Move functions to private Change case on methods to lowercase per style guide Change related methods to use set instead of vector, this saves a copy from set to vector. Initialize formats before supportsDmaBufFormat because queryDmaBufModifiers can be called before queryDmaBufFormats and need to initialize at supportsDmaBufFormats. Bug: angleproject:412730346 Change-Id: I8575bee6e7a6a09d9065ed81acff899e73004764 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6610088 Reviewed-by: mohan maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Amirali Abdolrashidi d84248ce 2025-06-09T10:40:37 Revert "Disable unused private field for dEQP compilation" This reverts commit b670d47b7aaff94d3a9e2e1b975e73d0ea336d85. Reason for revert: Warnings resolved on the tests Bug: angleproject:420728429 Original change's description: > Disable unused private field for dEQP compilation > > Incoming VK-GL-CTS rolls are failing due to the following error > for some dEQP targets: > "private field 'm_size' is not used [-Werror,-Wunused-private-field]" > This warning can be suppressed for this target temporarily, allowing > the autoroller to merge new changes. Once the issue has been addressed > on the CTS code, this change should be reverted. > > * Added -Wno-unused-private-field to gles2 and gles31 targets. > * This is a temporary change. It should be removed once the issue > has been addressed. > > Bug: angleproject:420728429 > Change-Id: I0177ded84ad58a148884e8abfac3aea9a1ff7d43 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6604679 > Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> > Reviewed-by: Yuxin Hu <yuxinhu@google.com> Bug: angleproject:420728429 Change-Id: I6b655a37568f42fabf710380c82ab775b126bdc7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6630278 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Panfeng Hou 9a436772 2025-06-04T16:47:51 Vulkan: Add entry points for GL_EXT_fragment_shading_rate Bug: angleproject:420310117 Change-Id: I8a8efad6cad810b2cb0b600106f6496070495605 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6620340 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com>
Mavis Deng 65091427 2025-06-05T14:08:01 Query draw buffer should return NONE for no surface default FB When querying the draw buffer state via glGetIntegerv(GL_DRAW_BUFFER) on the default framebuffer with no surface bound, GL_NONE should be returned. Bug: angleproject:422631118 Change-Id: Iad2f1662692b0a92563e4cfd7fe09437cb40f0c7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6619453 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Mavis Deng <mavis.deng@arm.com> Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 2ca17c76 2025-06-09T03:01:54 Roll SwiftShader from 11dc1b167af4 to a857503547cb (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/11dc1b167af4..a857503547cb 2025-06-06 swiftshader.regress@gmail.com Regres: Update test lists @ 11dc1b16 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I2671e20e557946685a52fb39cd0a23f80471074e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6630254 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 666809c0 2025-06-09T10:55:52 Roll vulkan-deps from 1c3b39ad6dc0 to 9fc5fb6a6005 (13 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/1c3b39ad6dc0..9fc5fb6a6005 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/fd96661925488574fe247a779babe5d380b63635..3b9447dc98371e96b59a6225bd062a9867e1d203 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/7dda3c01fb4c0f9941d3cb792947d57d896ac55f..ec1c9ca71ae2e0a63f4245978accde381865266b https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/b11eecd68fb4b770f30fe2c9da522ff966f95b1e..1d6c53f65443ceeb97d3bdc695aaecc7ea6cc441 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/bf4aec7ddb0f46d729ebd3255296d9fe8eed73ec..bf4ea01344ced4bbfee5d2a04ce02e8c1e99df99 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/e4fb76dc08f139df0436e9c3031f75be5e1f6264..fbe722654b7173da961398cf78bd4a62d1839b65 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/03e1445cc7cce22baeeef8eff7bb934362d040eb..e48ae20a7938b01aee62806bfcdafe8a0883b1e4 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/287caf1be206dca1b8a391b10eab474a7e238fd6..6104c98e8d16bcd392116cf30d32c519835a6cfe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: Icff35c41cc4da5955e3e8e3d2ef79da675222d4b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6630275 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll a8da66d3 2025-06-09T08:01:22 Roll VK-GL-CTS from 832d82a93cb1 to 53a925d9098c (12 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/832d82a93cb1..53a925d9098c 2025-06-06 piotr.byszewski@mobica.com Add coverage for scalar int to/from float conversions 2025-06-06 ziga@lunarg.com Test not setting unused dynamic states 2025-06-06 marcin.zajac@cognizant.com Compact and update acceleration structures 2025-06-06 michal.jakubek@mobica.com Add various tests for bfloat16 type. 2025-06-06 rgarcia@igalia.com Test updating empty acceleration structures 2025-06-06 erik.faye-lund@collabora.com Correct failure condition for max-samples 2025-06-06 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.3 into vk-gl-cts/main 2025-06-05 michal.jakubek@mobica.com Allow vkt::TestCase access to VkInstance and VkDevice 2025-06-05 lorenzo@khronosgroup.org Improvements to code generation for mandatory features 2025-06-05 lorenzo@khronosgroup.org Fixes to mandatory feature tests generation (also corrects typo) 2025-06-05 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.3 into vk-gl-cts/main 2025-06-04 lorenzo@khronosgroup.org Update external sources (Vulkan 1.4.316) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: Ifc321611524caed58916324c8cbfa39e21a06ebd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6629607 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya 3a15fab0 2025-06-05T13:47:18 Add tests for per-sample shading state tracking Add tests to cover usecases exposed by these optimizations - - https://chromium-review.googlesource.com/c/angle/angle/+/6622156 - https://chromium-review.googlesource.com/c/angle/angle/+/6619019 Bug: angleproject:386749841 Change-Id: I848ed68afe00757a10c8c970ee1f9a9b4646e9ab Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6622107 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
angle-autoroll 3d81e45d 2025-06-06T10:01:23 Roll vulkan-deps from 0dbc05833984 to 1c3b39ad6dc0 (3 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/0dbc05833984..1c3b39ad6dc0 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/fc060af4813d2d9b973f982c4987e1d53b1ec1c6..ac1c686d562147c751a0c284f879499418beee46 https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/7bcaa58729088d25eb6cbe6fce3dee9a9812f43e..e088d553426a3036270701d07dde28bf33d318be https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/596534df7e93137255f803653de4614e9d9e7ba2..287caf1be206dca1b8a391b10eab474a7e238fd6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I80aa1fe06a26cfb4dd66ca53d118e52d94afc352 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6626328 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 0cab8c9c 2025-06-06T03:01:39 Roll SwiftShader from b62ac8aa106b to 11dc1b167af4 (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/b62ac8aa106b..11dc1b167af4 2025-06-05 syoussefi@google.com Keep VIEW_INDEX_FROM_DEVICE_INDEX_BIT unsupported 2025-06-05 yiwzhang@google.com specify the gerrit listener type to be legacy poller If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: Ia9d9d451eba376b44d986fe180b750902ff595e0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6626392 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 921b5a1c 2025-06-06T07:01:29 Roll Chromium from ae0de49bcdc3 to 89af20128575 (548 revisions) https://chromium.googlesource.com/chromium/src.git/+log/ae0de49bcdc3..89af20128575 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/e78b1cf9e6..74fd4e41fc * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/3c185fa96c..64b9f65d16 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/4abe594e45..0cb342c45f * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/ea769d2a2a..aa341ec41f * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6d52c22ee3..d255a8d41e * third_party/fuchsia-sdk/sdk: version:28.20250528.4.1..version:28.20250605.5.1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/0e242589e5..cdae0b78c3 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/644c27c66c..39b4cdb3bd * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/483563e40f..4a625964c6 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/6268d2158a..71e38a3895 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/db7318cc95..70322b4cf9 * tools/skia_goldctl/linux: bg1T2otEnMQQe-Lo1MLLZexZL1VsvAVAqfwuhhjSxQ4C..lkxqvhJtv-45S0zRCu7Z3er-IcDc6t931-7jM1lN-RMC * tools/skia_goldctl/mac_amd64: v4HGLZ-ir5Y-4pZMGKYMAgJ7yAEv5Y5Kj-cdpYfzlgoC..r2LyNXR63hRBteBs8GN14Otjpbnu_VQvVOvDVUFjeV4C * tools/skia_goldctl/mac_arm64: LNWlZ0vnIDglaN4JlNc530ujLuhm_WIlIjLZEbgNfOcC..tJUKq9z8lfdk4KydEare4F1gdGAXnTVuC5W3k8mBQBMC * tools/skia_goldctl/win: RKUSAHdNBItBShnfuk9DnsnmBS-7kTAt7k2N_GzFzmsC..1pUE-hNBek5om-0mUbI4sJSEt4-m1AwEGnVNuEfMFOIC No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: I3cdec55cddf71ee03a4a4e8f85ceacf1a9028080 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6626326 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya db962407 2025-06-03T08:00:43 Vulkan: Optimize FramebufferVk::getSamples() Cache value of samples during syncState(...) and return this value on subsequent queries Bug: angleproject:386749841 Change-Id: I21fb2221187c7b2159fed1b271da642ba2552348 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6619019 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Alexey Knyazev f6b40bc8 2025-05-15T00:00:00 Add a missing compile macro Bug: angleproject:406922380 Change-Id: If2d4cc1472b490b3507591f0a6ac940369df5ccb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6624377 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 8c48b502 2025-06-05T02:09:54 Vulkan: Fix deferred clear vs robust init vs invalidate The DIRTY_OBJECT_DRAW_ATTACHMENTS bit, when handled, goes over framebuffer attachments and requests that they be cleared. This is done only with robust init. The DIRTY_OBJECT_DRAW_FRAMEBUFFER bit, when handled, results in staged updates to be applied to the attachments. When syncDirtyObjects is called, the above bits are handled. If we end up in a situation where DIRTY_OBJECT_DRAW_ATTACHMENTS is set, but not DIRTY_OBJECT_DRAW_FRAMEBUFFER, the following happens with Vulkan: - Handle DIRTY_OBJECT_DRAW_ATTACHMENTS - TextureVk::initializeContents - ImageHelper::stageResourceClearWithFormat - Observer message to TextureVk->Texture->Framebuffer->Context - Context sets DIRTY_OBJECT_DRAW_FRAMEBUFFER - However syncDirtyObjects does not notice this bit, as it has cached the dirty objects and is in the middle of looping over them In the above scenario, the call that results in syncDirtyObjects does not process the draw framebuffer (if not already dirty for some other reason), meaning the clear is not applied _before_ the current operation but after it (whenever framebuffer is synced next). In this change, I attempted to ensure that if DIRTY_OBJECT_DRAW_ATTACHMENTS is ever dirty, DIRTY_OBJECT_DRAW_FRAMEBUFFER is also dirty. There were a few operations that could theoretically lead to this which are fixed by this change. The particular one that revealed the bug was State::syncDirtyObject syncing only the FRAMEBUFFER bit and leaving the ATTACHMENTS bit for the unsuspecting following operation. The aforementioned assertion is not included in this change however, as it revealed one unresolved issue with the d3d backend where DIRTY_OBJECT_DRAW_ATTACHMENTS is not set, but processing DIRTY_OBJECT_DRAW_ATTACHMENTS sets it while dirty bits are being processed. Bug: b/381284577 Change-Id: If3c35fbade069ae75f66dd6d4df5d73882a08a93 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6621059 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 92dec961 2025-05-15T00:00:00 Enforce validation consistency for lockless entry points Bug: angleproject:406922380 Change-Id: If4e6051d0ac465f4ae8abca0a62cad14d1d739b7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6624114 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Amirali Abdolrashidi b6579180 2025-05-15T15:29:28 Add test case for CS writes without barriers * Added the following test to ComputeShaderTest: WriteToSeparateSSBOComponentsWithoutExplicitBarrier * Based on KHR-GLES31 test: .core.shader_storage_buffer_object.advanced-switchBuffers-cs * It involves writing to different components of an SSBO without explicit barriers in between. Bug: b/417769912 Change-Id: I9f6170937c9ccf3487d8f9e7758196c950252ea3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6552162 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
angle-autoroll 25fc5046 2025-06-05T03:01:42 Roll SwiftShader from a8133cbb3c89 to b62ac8aa106b (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/a8133cbb3c89..b62ac8aa106b 2025-06-04 swiftshader.regress@gmail.com Regres: Update test lists @ a8133cbb 2025-06-04 syoussefi@google.com Fix a number of asserts hit by latest tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: Ibaa7fc30224a1cf9b48953d36af07310ae4003f7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6623507 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 6400268a 2025-06-05T10:01:17 Roll vulkan-deps from d308a0e9d35f to 0dbc05833984 (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/d308a0e9d35f..0dbc05833984 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/b888ebcee8ffaa59536b5f33277936536249d9be..fc060af4813d2d9b973f982c4987e1d53b1ec1c6 https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/bb77842234bc567399f2621ec52e9649b80fdad0..7bcaa58729088d25eb6cbe6fce3dee9a9812f43e https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/7168a5ad041f6b6b9170f027c7417f98a2056ff0..fd96661925488574fe247a779babe5d380b63635 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/2e743e96b990f7390290630243b00ca0a75b8547..7dda3c01fb4c0f9941d3cb792947d57d896ac55f https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/338676d66f73bebfc1b64639b0a17149827ea7ac..596534df7e93137255f803653de4614e9d9e7ba2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: Ifdeea7e1e1099d3b595a83fac5b4f3dc43b72455 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6622668 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll c2250cb4 2025-06-05T08:00:51 Roll Chromium from 0e7cd65001cf to ae0de49bcdc3 (680 revisions) https://chromium.googlesource.com/chromium/src.git/+log/0e7cd65001cf..ae0de49bcdc3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/fedeebe26a..e78b1cf9e6 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/52827af8a8..3c185fa96c * buildtools/linux64: git_revision:b99a82ca8ee957da829d6313b818b99df8e7ccb8..git_revision:e5c4d1881b85b82789b7013233a944cf1a46370f * buildtools/mac: git_revision:b99a82ca8ee957da829d6313b818b99df8e7ccb8..git_revision:e5c4d1881b85b82789b7013233a944cf1a46370f * buildtools/win: git_revision:b99a82ca8ee957da829d6313b818b99df8e7ccb8..git_revision:e5c4d1881b85b82789b7013233a944cf1a46370f * testing: https://chromium.googlesource.com/chromium/src/testing/+log/838439e50c..4abe594e45 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/f457992f2e..2b011cd0e9 * third_party/android_build_tools/error_prone/cipd: d635j0CoYfvepgbzkY8HflRSqwy4iELc08Rp569cJgkC..OFmDaNXqS5PTb5YKd4fCb0Y4cK4ImQXeZISzw9p1ILcC * third_party/android_build_tools/lint/cipd: xY4TOq8o-UL3ddPKL_Md8HxqA-8zygxI2qe4TOy99UwC..B12WztL3EZsuJ7B1dMlfrnCHVd4n5qgxf_HYDQyzOkAC * third_party/android_build_tools/manifest_merger/cipd: 08J0vF1HTJjf04BVy5fG5CWz9mJamI6-WLN9zSX7ZwEC..1QtZ_gZ5icFNOEvVrY34lJgcC2XoXxBfgPmz-eBrk7UC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/c35f24154b..8413456528 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/d200280fa4..ea769d2a2a * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a55a42f55b..6d52c22ee3 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/275cada5de..0e242589e5 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/81a117beb4..644c27c66c * third_party/r8/cipd: 92cfx3PA_Av-Zy3T2B_Whp1BtsuG_yeS_4HfsZra62IC..pxgwR4ardZ3LnNCARPEbdl_gTA9R1aaHowtsCNRpZaYC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/9663e533dd..6268d2158a * tools/luci-go: git_revision:963177240b1a36697c9762856f51ad36ab545ceb..git_revision:4ee25ef52cdb1d0ce5bba817578a4b40381bc39e * tools/luci-go: git_revision:963177240b1a36697c9762856f51ad36ab545ceb..git_revision:4ee25ef52cdb1d0ce5bba817578a4b40381bc39e * tools/luci-go: git_revision:963177240b1a36697c9762856f51ad36ab545ceb..git_revision:4ee25ef52cdb1d0ce5bba817578a4b40381bc39e * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/5edb7a1ed8..04d0441efb * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/c8cadb6f86..db7318cc95 * tools/skia_goldctl/linux: tuzeYVGxTKob1ipSmtH0hGunYFgqsvIk3fi6LKfo-JUC..bg1T2otEnMQQe-Lo1MLLZexZL1VsvAVAqfwuhhjSxQ4C * tools/skia_goldctl/mac_amd64: 9WP08e9kVtdiE5A8xbucFZLJbVhEaWpy6lPHloEq28IC..v4HGLZ-ir5Y-4pZMGKYMAgJ7yAEv5Y5Kj-cdpYfzlgoC * tools/skia_goldctl/mac_arm64: GmbmM4D9tFMSiRmMyhJC2m8Qn9ALIaSjqE23bxg300AC..LNWlZ0vnIDglaN4JlNc530ujLuhm_WIlIjLZEbgNfOcC * tools/skia_goldctl/win: fqCHxyWS11f2OKiSL4CdTjHjEZx0Bm1PvJ3KDHjgf_0C..RKUSAHdNBItBShnfuk9DnsnmBS-7kTAt7k2N_GzFzmsC No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: I76fa677c8d1b130b309d514e1b81f85eac8a61e0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6622933 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya ef31b3ed 2025-06-04T12:00:04 Vulkan: Selectively dirty DIRTY_BIT_SAMPLE_SHADING When program executable changes dirty DIRTY_BIT_SAMPLE_SHADING bit if either the current or previous program enabled per sample shading Bug: angleproject:386749841 Change-Id: I82aa7df29473e455aa68dfba9fefdb1bc712a78d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6622156 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 93184102 2025-06-04T11:34:27 Manual roll vulkan-deps from 84aa8fdf32d0 to d308a0e9d35f (47 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/84aa8fdf32d0..d308a0e9d35f Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/be4ee7d0e3bfd151bfda7b3a8e03f8c49c55ed7b..b888ebcee8ffaa59536b5f33277936536249d9be https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/4841ea0a48c4ea07e9f24db3322f31541a25a101..bb77842234bc567399f2621ec52e9649b80fdad0 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/9a46274d2ef215d3c258ed4d1863bff4514fa316..7168a5ad041f6b6b9170f027c7417f98a2056ff0 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/a9d7fde99e73a619bbdda648473eff5895ead273..2e743e96b990f7390290630243b00ca0a75b8547 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/75ad707a587e1469fb53a901b9b68fe9f6fbc11f..b11eecd68fb4b770f30fe2c9da522ff966f95b1e https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/c913466fdc5004584890f89ff91121bdb2ffd4ba..bf4aec7ddb0f46d729ebd3255296d9fe8eed73ec https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/60b640cb931814fcc6dabe4fc61f4738c56579f6..e4fb76dc08f139df0436e9c3031f75be5e1f6264 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/49ac28931f28bffaa3cd73dc4ad997284d574962..03e1445cc7cce22baeeef8eff7bb934362d040eb https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/e2d41fdd5ac2b0138112b61bd6eed0e0bb0ea693..338676d66f73bebfc1b64639b0a17149827ea7ac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com,ynovikov@google.com Change-Id: I624c45182141a8611c6e9dab69a597c0749c99ff Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6618312 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 71910994 2025-06-04T07:00:09 Roll Chromium from 0b76caa6045f to 0e7cd65001cf (607 revisions) https://chromium.googlesource.com/chromium/src.git/+log/0b76caa6045f..0e7cd65001cf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/9d1a4700d6..fedeebe26a * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/176c77f623..52827af8a8 * buildtools/linux64: git_revision:a84e399f9999003472192286abc03d752c9cb1f0..git_revision:b99a82ca8ee957da829d6313b818b99df8e7ccb8 * buildtools/mac: git_revision:a84e399f9999003472192286abc03d752c9cb1f0..git_revision:b99a82ca8ee957da829d6313b818b99df8e7ccb8 * buildtools/win: git_revision:a84e399f9999003472192286abc03d752c9cb1f0..git_revision:b99a82ca8ee957da829d6313b818b99df8e7ccb8 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/3273e1952b..838439e50c * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/7a3de773a3..d200280fa4 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/57dfc366b7..a55a42f55b * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/536618d78c..275cada5de * third_party/nasm: https://chromium.googlesource.com/chromium/deps/nasm.git/+log/9f916e90e6..e2c93c3498 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/afcd61ed9a..5edb7a1ed8 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/4da90bcf9c..c8cadb6f86 No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: I47d8ec5981deeffca18c8388f812f6844a4e9bd4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6620578 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 23097376 2025-06-03T22:26:05 Update src/common/base's README Bug: chromium:378273323 Change-Id: Iaa40abac52fdb2d5f8e3a65333d589097cb98834 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6617103 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Jiaqi Li 88ea74bf 2025-05-30T14:17:09 Add another condition to call copyBufferDataToImage directly To directly copy from a buffer, it's necessary that the buffer does not need conversion. Add this condition to the check function. Add related end2end test. Bug: angleproject:421288695 Change-Id: Id57df32f91a8f385bc07b2788149cc4478ccbab4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6605140 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Jiaqi Li <Jiaqi.Li@arm.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
angle-autoroll 87217c88 2025-06-03T08:01:03 Manual Roll VK-GL-CTS from 2231585b0204 to 832d82a93cb1 (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/2231585b0204..832d82a93cb1 2025-05-30 kamil.goras@mobica.com Add missing coverage for ClearTex[Sub]Image for OpenGL If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: b/421940612 Tbr: yuxinhu@google.com Change-Id: I5b57cfc7b1d23b30fd8764db735eb5cf516ddc20 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6616574 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Xiang Wang e877e655 2025-06-02T17:02:36 Reland "Suppress VUID-VkRenderPassBeginInfo-renderPass-00904" This reverts commit 8c75960e034a09bad67ece528c99e202bed69b64. Reason for revert: retry dry-run without revert Bug: b/303441816 Original change's description: > Revert "Suppress VUID-VkRenderPassBeginInfo-renderPass-00904" > > This reverts commit f8f9847771fa86589da29527c806d89e6f92c7a9. > As the issue is no longer reproducible on a P25 device with > latest ANGLE. > > Bug: b/303441816 > Change-Id: Iae86b3f4e30609cd5b1aedb4293192b06be71919 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6614157 > Commit-Queue: Xiang Wang <xwxw@google.com> > Reviewed-by: Yuxin Hu <yuxinhu@google.com> > Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Bug: b/303441816 Change-Id: Ib447a5af33bd17f891a8db99766fc8f275162a6c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6614164 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Xiang Wang <xwxw@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Yuly Novikov d8c00a9d 2025-06-03T07:39:44 Revert "Increase linux-asan-test timeout" This reverts commit b709754166bfb7dd9a8f936800b9fac10f327023. Reason for revert: culprit reverted Bug: angleproject:421425259 Original change's description: > Increase linux-asan-test timeout > > Slow compile after crrev.com/c/6596941. > > Bug: angleproject:421425259 > Change-Id: I58d8cf0981c53ddb368860e0f94da1b158756947 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6611580 > Commit-Queue: Yuly Novikov <ynovikov@chromium.org> > Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Bug: angleproject:421425259 No-Try: true Change-Id: I7086ea907c94b221fdc0556512024d3c0fb3e97b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6617900 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 0c8da5fc 2025-06-03T07:06:39 Roll Chromium from 055e258e91fc to 0b76caa6045f (4644 revisions) https://chromium.googlesource.com/chromium/src.git/+log/055e258e91fc..0b76caa6045f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/69dc3b19a1..9d1a4700d6 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/cd169314af..176c77f623 * buildtools/linux64: git_revision:ebc8f16ca7b0d36a3e532ee90896f9eb48e5423b..git_revision:a84e399f9999003472192286abc03d752c9cb1f0 * buildtools/mac: git_revision:ebc8f16ca7b0d36a3e532ee90896f9eb48e5423b..git_revision:a84e399f9999003472192286abc03d752c9cb1f0 * buildtools/reclient: re_client_version:0.178.0.5ee9d3e8-gomaip..re_client_version:0.179.0.28341fc7-gomaip * buildtools/win: git_revision:ebc8f16ca7b0d36a3e532ee90896f9eb48e5423b..git_revision:a84e399f9999003472192286abc03d752c9cb1f0 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/6a20ae4677..3273e1952b * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/2401283880..f457992f2e * third_party/android_build_tools/error_prone/cipd: 2jzgic7at7ZxQds7qXCsmkfC4bO7d3qnWU5Q7SFUiJwC..d635j0CoYfvepgbzkY8HflRSqwy4iELc08Rp569cJgkC * third_party/android_build_tools/lint/cipd: PaYB6553MH9GJfamUZLduJESRbN13Clv2N2beHR6IQAC..xY4TOq8o-UL3ddPKL_Md8HxqA-8zygxI2qe4TOy99UwC * third_party/android_build_tools/manifest_merger/cipd: 0L0N3_u2ypIxEEtf0k_l36g_2CykW2BNuZBXm-v5qAUC..08J0vF1HTJjf04BVy5fG5CWz9mJamI6-WLN9zSX7ZwEC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/4333e5ba90..c35f24154b * third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/20cf331dc7..67418b87fc * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/938fc9953b..7a3de773a3 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f73c587323..57dfc366b7 * third_party/fuchsia-sdk/sdk: version:28.20250515.3.1..version:28.20250528.4.1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/a01c02c9d4..536618d78c * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/9810fb23f6..aca8664738 * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/8575f4ae4f..e3eb847e51 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/9c3ae3120f..81a117beb4 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/d30c1f18b8..345a48f432 * third_party/r8/cipd: QhYGRVpYYKZmt3f_Zb2HoJ9LIBEnWaeeLXRNei47Z30C..92cfx3PA_Av-Zy3T2B_Whp1BtsuG_yeS_4HfsZra62IC * third_party/r8/d8/cipd: QhYGRVpYYKZmt3f_Zb2HoJ9LIBEnWaeeLXRNei47Z30C..i5l_yPIc-ZuKle_ibElGMSf50XN8buMgspBkoObkkRAC * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/b7156762f0..483563e40f * third_party/siso/cipd: git_revision:d9393c2115244b6e4a797189055e4a2b6769a64d..git_revision:963177240b1a36697c9762856f51ad36ab545ceb * third_party/turbine/cipd: VGtOG2ivl1SJR7Lai5FQddIu15mWCYDnp47QtozMQeoC..npJIrAZr4-2wb6qWV0r2oeWQd-Q1wiMGAAi8Up15SkQC * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/e8ff3f3555..470d3a2ee4 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/61859fe79e..9663e533dd * tools/luci-go: git_revision:45d1c0a0168f06a2bbde9eca9a03087ed1da523e..git_revision:963177240b1a36697c9762856f51ad36ab545ceb * tools/luci-go: git_revision:45d1c0a0168f06a2bbde9eca9a03087ed1da523e..git_revision:963177240b1a36697c9762856f51ad36ab545ceb * tools/luci-go: git_revision:45d1c0a0168f06a2bbde9eca9a03087ed1da523e..git_revision:963177240b1a36697c9762856f51ad36ab545ceb * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/ddbe6fbaf9..4da90bcf9c * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/d88ef9e4de..11d67ba328 * tools/skia_goldctl/linux: bTGNxI6oWidGO0rn_gOIbBQco8hNmWt0yS6ARBqSjlsC..tuzeYVGxTKob1ipSmtH0hGunYFgqsvIk3fi6LKfo-JUC * tools/skia_goldctl/mac_amd64: uq36HPTxtJXcSA6VRu488Anq19CjDz64IikQoKeegjIC..9WP08e9kVtdiE5A8xbucFZLJbVhEaWpy6lPHloEq28IC * tools/skia_goldctl/mac_arm64: BpQkTzfhHyLozwZTFhy8nvc_t9VRDDXcaqdjQLA56bcC..GmbmM4D9tFMSiRmMyhJC2m8Qn9ALIaSjqE23bxg300AC * tools/skia_goldctl/win: Qp03cZtVqA0CskUhi8g8_bciB5Nz1CHp4lpn0cprJWgC..fqCHxyWS11f2OKiSL4CdTjHjEZx0Bm1PvJ3KDHjgf_0C No update to Clang. Bug: angleproject:413078308,angleproject:420743402 Tbr: yuxinhu@google.com Change-Id: I92737683d509d9ececba43ee826f6aa28c07a668 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6615259 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Roberto Rodriguez af6313f5 2025-06-02T10:31:27 Check redundant statements for comma op in MSL translator. Bug: angleproject:421891565 Change-Id: I0475476f360f103a3da4df263dae9c604a8bfef5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6610091 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com> Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com>
Yuly Novikov ac596fd8 2025-06-03T03:50:01 Revert "Tests: Add Aquarium trace" This reverts commit 537d40dcac601e051e9954ed8b08cafd2cc55ff0. Reason for revert: increases linux-asan-test compile time by 2 hours Bug: b/420699380 Original change's description: > Tests: Add Aquarium trace > > Test: angle_trace_tests --gtest_filter="*aquarium*" > Bug: b/420699380 > Change-Id: I30e0b0cbf2520b98dc265a6686e81cc3280f5555 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6594253 > Reviewed-by: Mark Łobodziński <mark@lunarg.com> > Commit-Queue: Cody Northrop <cnorthrop@google.com> Bug: b/420699380, angleproject:421425259 Change-Id: I2931dec718e603c4e7903cfaa268ef1fb7aa3370 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6617080 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Xiang Wang 8c75960e 2025-05-30T16:06:54 Revert "Suppress VUID-VkRenderPassBeginInfo-renderPass-00904" This reverts commit f8f9847771fa86589da29527c806d89e6f92c7a9. As the issue is no longer reproducible on a P25 device with latest ANGLE. Bug: b/303441816 Change-Id: Iae86b3f4e30609cd5b1aedb4293192b06be71919 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6614157 Commit-Queue: Xiang Wang <xwxw@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Tim Van Patten 7644c9db 2025-06-02T11:44:38 test: Remove EGLSingleBufferTest.VerifyMutableRenderBufferKHR The test is enforcing that specifying/querying EGL_SINGLE_BUFFER requires the extension EGL_KHR_mutable_render_buffer. However, EGL_RENDER_BUFFER/EGL_SINGLE_BUFFER were introduced in EGL 1.4, removing any extension requirements for devices that support EGL 1.4+. 3.5 Rendering Surfaces 3.5.1 Creating On-Screen Rendering Surfaces ... EGL_RENDER_BUFFER specifies which buffer should be used by default for client API rendering to the window, as described in section 2.2.2. If its value is EGL_SINGLE_BUFFER, then client APIs should render directly into the visible window. If its value is EGL_BACK_BUFFER, then all client APIs should render into the back buffer. The default value of EGL_RENDER_BUFFER is EGL_BACK_- BUFFER The extension itself requires a minimum of EGL 1.2, meaning only versions 1.2 and 1.3 require EGL_KHR_mutable_render_buffer to use EGL_SINGLE_BUFFER. Remove the test since it doesn't gives us any information anymore since we always expose EGL 1.5 anyway. Bug: b/417459061 Change-Id: I060e196600e6ece6179a164d9125a8b98c0d8498 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6613123 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov b7097541 2025-06-02T17:52:30 Increase linux-asan-test timeout Slow compile after crrev.com/c/6596941. Bug: angleproject:421425259 Change-Id: I58d8cf0981c53ddb368860e0f94da1b158756947 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6611580 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
angle-autoroll 8644b18c 2025-06-02T08:01:40 Roll VK-GL-CTS from 7be6d4540af2 to 2231585b0204 (10 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/7be6d4540af2..2231585b0204 2025-05-30 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.12 into vk-gl-cts/main 2025-05-30 rgarcia@igalia.com Add tess test to reproduce RADV sync issue 2025-05-30 ziga@lunarg.com Test not setting depthWriteEnable 2025-05-30 rgarcia@igalia.com Test multiple vertices with constant outputs per mesh shader instance 2025-05-30 ziga@lunarg.com Fix image layout in dynamic state tests 2025-05-30 piotr.byszewski@mobica.com Extend interface matching tests 2025-05-30 piotr.byszewski@mobica.com Fix create_device_queue2_all_combinations test 2025-05-30 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.2 into vk-gl-cts/vulkan-cts-1.4.3 2025-05-30 lorenzo@khronosgroup.org Add video fetching instructions to the Vulkan README 2025-05-27 lorenzo@khronosgroup.org Allow conformance version Vulkan CTS 1.4.3.0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: Ie30395de05164532d7c32f00e47ff20627825ee8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6609031 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov bb518ce1 2025-06-02T12:59:00 Stop ANGLE Mac NVIDIA testing. MacBookPro11,3 machines support only up to macOS 11, which is no longer supported by Chromium. Bug: chromium:420724818 Change-Id: I55b9e26a7770027df6b5182af31b371666dd94bf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6611578 Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Serdar Kocdemir b1359277 2025-05-14T22:53:36 Declare lavapipe device type Fixes 'Unknown GPU architecture' warning when using lavapipe driver with guest side ANGLE enabled on the emulators. Also treats lavapipe similar to swiftshader for test coverage purposes. Bug: b/417791087 Test: run goldfish emulator with '-gpu lavapipe' Change-Id: I40002ce191aa49f08d887c066321c4d0c27f2738 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6547537 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Yuxin Hu f000acf8 2025-05-28T12:37:20 Vulkan: Remove suppressed VVL errors that no longer applies on bots All the devices on bots support VK_ATTACHMENT_STORE_OP_NONE. To pass the bot, we no longer need to suppress the VVL errors that only occur on devices where VK_ATTACHMENT_STORE_OP_NONE is not supported. Remove the error messages from the suppression list. Bug: angleproject:42264496 Bug: angleproject:42265159 Change-Id: I47bfcb6cff77ae68b1755e8e0105411f31f713e0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6598217 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Tingwei Guo ef29d42e 2025-05-22T15:52:49 Support ASTC decode mode extensions in ANGLE Added support for GL_EXT_texture_compression_astc_decode_mode and GL_EXT_texture_compression_astc_decode_mode_rgb9e5 in ANGLE. Also added corresponding end-to-end tests for ASTC decode mode queries, including ASTC decode mode queries and rendering with ASTC texture formats with different decode modes on GL_TEXTURE_2D works. Bug: angleproject:419403188 Change-Id: I0f2dced8468c4e25597740d1de346b2f699bb81e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6575285 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com>
angle-autoroll 65b25882 2025-05-30T10:01:43 Roll vulkan-deps from 58febb14bdad to 84aa8fdf32d0 (9 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/58febb14bdad..84aa8fdf32d0 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/da48bb20bdfc8a214d5bffdacca2d1d2ae849009..a9d7fde99e73a619bbdda648473eff5895ead273 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/99e5ce205de87dc2485e1ffc7fbd5bc9604f7c89..e2d41fdd5ac2b0138112b61bd6eed0e0bb0ea693 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: Ie8598870c94819f32364c406675a1c82d6b3c6c9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6606860 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 20b08f95 2025-05-29T10:14:33 Roll VK-GL-CTS from c9d2e24d1a6d to 7be6d4540af2 (27 revisions) * Added gl4cTextureBufferTests files to deqp.gni. https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/c9d2e24d1a6d..7be6d4540af2 2025-05-26 rgarcia@igalia.com Test vkGetPhysicalDeviceFormatProperties2 pNext chain 2025-05-26 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.2 into vk-gl-cts/main 2025-05-26 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.12 into vk-gl-cts/main 2025-05-23 kamil.goras@mobica.com Add test texture buffer size clamping 2025-05-23 piotr.byszewski@mobica.com Tests null FS with cull distance and sample mask 2025-05-23 piotr.byszewski@mobica.com Use bad VkPipelineRenderingCreateInfo when it is not needed in GPL 2025-05-23 boris.zanin@amd.com Verify stride is non-constant value in OpCooperativeMatrixStore/Load 2025-05-23 petermcneeley@google.com Amber tests for NClamp spir-v extended instruction 2025-05-23 david.rosca@amd.com Fix film grain flag for dEQP-VK.video.decode.av1.argon_filmgrain_10_test1019_*_dpb 2025-05-23 ziga@lunarg.com Fix enabling extensions in swapchain maintenance1 tests 2025-05-23 lionel.g.landwerlin@intel.com Fix default SampleMask value in VK_EXT_shader_object tests 2025-05-23 mateusz.bahyrycz@mobica.com Fix for missing synchronization in BufferViewTestInstance 2025-05-23 piotr.byszewski@mobica.com Port selected tests to new capabilities system 2025-05-23 michal.jakubek@mobica.com Reduce createCustomInstance() calls. 2025-05-23 michal.jakubek@mobica.com Capabilities system for custom device creation 2025-05-23 rgarcia@igalia.com Test multistream rasterization with XFB 2025-05-23 rgarcia@igalia.com Test image-to-image copies for 96-bit formats with linear tiling 2025-05-23 rgarcia@igalia.com More DGC conditional rendering tests related to preprocessing 2025-05-23 rgarcia@igalia.com Test sampling VK_FORMAT_A1R5G5B5_UNORM_PACK16 2025-05-23 rgarcia@igalia.com Add tests with additional commands on secondary command buffers 2025-05-23 rgarcia@igalia.com Fix verification thresholds in sampling tests for small formats 2025-05-23 rgarcia@igalia.com Test copying immutable samplers 2025-05-23 rgarcia@igalia.com Add ldexp tests with non-32-bit exponents 2025-05-23 rgarcia@igalia.com Add XFB tests with primitive restart 2025-05-23 rgarcia@igalia.com Test arbitrary matching queue family values in barriers 2025-05-23 rgarcia@igalia.com Test geometry shader side effects always happen 2025-05-23 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.2 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:420728429 Tbr: abdolrashidi@google.com Change-Id: Iee73fa63e10dd084a4c67bcae7ab1779f8efdbcf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6601054 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Amirali Abdolrashidi b670d47b 2025-05-29T13:37:27 Disable unused private field for dEQP compilation Incoming VK-GL-CTS rolls are failing due to the following error for some dEQP targets: "private field 'm_size' is not used [-Werror,-Wunused-private-field]" This warning can be suppressed for this target temporarily, allowing the autoroller to merge new changes. Once the issue has been addressed on the CTS code, this change should be reverted. * Added -Wno-unused-private-field to gles2 and gles31 targets. * This is a temporary change. It should be removed once the issue has been addressed. Bug: angleproject:420728429 Change-Id: I0177ded84ad58a148884e8abfac3aea9a1ff7d43 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6604679 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Mohan Maiya 58f21f8f 2025-05-29T07:53:02 Vulkan: Optimize ProgramExecutableVk::bindDescriptor(...) Cache valid descriptor set indices in a bitset, this helps eliminate branches within loops and makes for more readable code Bug: angleproject:386749841 Change-Id: I06fbf529ceb6c8ece9313b3b5e9edd6c6b63542b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6601733 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com>
Geoff Lang 433906d7 2025-05-29T16:22:18 WebGPU: Protect against null compilation info. compilationInfo is an optional parameter of this callback. Bug: chromium:413078308 Change-Id: I12770c566b3daad5eaf8d6c8b66e464a85da06f7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6596988 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Kai Ninomiya 7ddc219f 2025-05-28T22:25:37 WebGPU: Handle Dawn breaking change in QueueWorkDoneCallback Needed in order to update Dawn to match the standard webgpu.h, here: https://dawn-review.googlesource.com/c/dawn/+/243697 Bug: chromium:414868699 Change-Id: Ib52c0e32b685ef3f9f05fe1fe549ab16e8eec610 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6600550 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Auto-Submit: Kai Ninomiya <kainino@chromium.org>
Alexey Knyazev 8dbb0997 2025-05-15T00:00:00 Autogen support checks for ANGLE_base_vertex_base_instance Bug: angleproject:409484297 Change-Id: Id730b55709e27910f2908294637e17cde9a791b8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6597178 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll 568d810a 2025-05-29T10:01:49 Roll vulkan-deps from 22a10043cac0 to 58febb14bdad (8 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/22a10043cac0..58febb14bdad Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/c9aad99f9276817f18f72a4696239237c83cb775..9a46274d2ef215d3c258ed4d1863bff4514fa316 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/01021466b5e71deaac9054f56082566c782bfd51..da48bb20bdfc8a214d5bffdacca2d1d2ae849009 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/8f0b8537e97369ccc6f32507ec9295e852abcb91..99e5ce205de87dc2485e1ffc7fbd5bc9604f7c89 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I5969919eb7ddecbd29770c19597f3572ae68c125 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6600962 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexey Knyazev 7855312a 2025-05-15T00:00:00 Adjust multi draw validation * Fixed validation of negative drawcount for all MultiDraw*ANGLE entry points. * Added missing extension checks to MultiDraw*BaseInstanceANGLE entry points. Fixed: angleproject:420956723 Change-Id: I3a058471446cd96a883970d4e38ba5af2fa07a8c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6597176 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 79cef542 2025-05-15T00:00:00 Autogen EGL image extension entry points Bug: angleproject:409484297 Change-Id: I0e4a83c5e902f010a66fefa4fa6cc4169ab5529f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6596617 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop e7118451 2025-04-15T09:55:48 restricted_trace_perf: Script fixes Minor fixes. Tests: restricted_trace_perf Bug: b/404239853 Change-Id: I429f2c69c47bd9a8dc725ac3f499143827755de6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6455541 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Alexey Knyazev d5d76108 2025-05-15T00:00:00 Do not define GL_GLEXT_VERSION in gl2ext.h Bug: angleproject:409484297 Change-Id: I2d71a4e923207f4d7ed410f8c4770aee9aff9d19 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6597675 Reviewed-by: Geoff Lang <geofflang@chromium.org>
Alexey Knyazev 4c964bc7 2025-05-15T00:00:00 Roll third_party/OpenGL-Registry/src/ 5bae8738b..200cea403 (74 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/OpenGL-Registry/+log/5bae8738b23d..200cea4030cb Additional changes: * Removed obsolete workarounds for mismatching signatures between CreateShaderProgramvEXT and CreateShaderProgramv. * Aligned GL backend bindings for GL_OVR_multiview entry points with the specs. * Updated include/GLES2/gl2ext.h. Bug: angleproject:409484297 Change-Id: Ifbb63dcc4bad312b22a368455a121e088b346fab Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6596941 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop 537d40dc 2025-05-27T12:43:55 Tests: Add Aquarium trace Test: angle_trace_tests --gtest_filter="*aquarium*" Bug: b/420699380 Change-Id: I30e0b0cbf2520b98dc265a6686e81cc3280f5555 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6594253 Reviewed-by: Mark Łobodziński <mark@lunarg.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
angle-autoroll e67f4123 2025-05-28T10:01:19 Roll vulkan-deps from d18d20e2f8cd to 22a10043cac0 (8 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/d18d20e2f8cd..22a10043cac0 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/640f35dd85d25122371fa99b8788d944b71bc5e8..4841ea0a48c4ea07e9f24db3322f31541a25a101 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/b75f27bc902ea48c1758d958222c742ecccf3aa2..8f0b8537e97369ccc6f32507ec9295e852abcb91 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: Icf05d2d4077cc0d1fb0fe626fd63b5ca61ed7f20 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6593998 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexey Knyazev 6462880b 2025-05-15T00:00:00 Autogen support checks for query extensions Bug: angleproject:409484297 Change-Id: I91e6b7318c62868e65d48ceb380b7c2d53c447ac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6596569 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Alexey Knyazev 392dc591 2025-05-15T00:00:00 Remove GL_CHROMIUM_sync_query Fixed: angleproject:420627279 Change-Id: I26dac7c55a7cf6b04121658144e1387be65d2569 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6593552 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Robic Sun 88f1a668 2025-05-20T10:35:36 Query sample count by getting image format props ANGLE should query the image format properties to set TextureCaps.sampleCounts based on internalformats. Bug: angleproject:418815176 Change-Id: I7718121008acd9bb9bbb9964af5842646d7a689a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6564528 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com> Auto-Submit: Robic Sun <Robic.Sun@arm.com> Reviewed-by: Charlie Lao <cclao@google.com>
Kaiyi Li 2642ee46 2025-05-27T17:39:06 Add downstream to watch ANGLE feature changes Bug: b/417527313 Change-Id: Idb36f7bac0c25391752a35cf5ed2ad99e6a6a636 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6594071 Auto-Submit: Kaiyi Li <kaiyili@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Shahbaz Youssefi bc2c85a6 2025-05-27T11:40:33 Translator: Set correct qualifiers on user-declared gl_PerVertex Bug: angleproject:409439499 Change-Id: Ia4bc1335d977f2b138af877e5d698914b182ff52 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6592612 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Mohan Maiya 90668ecf 2025-05-25T10:51:52 Vulkan: Reset uniform buffer dirty bit on program change When a program changes all of its non-texture shader resources are invalidated, there is no need to re-invalidate uniform buffers. Bug: angleproject:386749841 Change-Id: I7e941784c40046cef3a2ce297e6941a963b3a8dc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6583476 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Yuxin Hu eafcbbf9 2025-05-27T11:24:17 Vulkan: Reformat VVL error message Remove the VVL skip messages that no longer apply. Set the messageContents1 and messageContents2 to nullptr for ease of clean up later. Bug: angleproject:399191283 Change-Id: I6d4477a6c401e6b7d2915b1fc574413be31fdc9b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6594251 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Auto-Submit: Yuxin Hu <yuxinhu@google.com>
Yuxin Hu 6542fea9 2025-05-07T17:28:45 Vulkan: Fix SpirV Error in Tessellation Control Shader When feature varyingsRequireMatchingPrecisionInSpirv is enabled, in the generated SpirV, if the shader output varying precision needs to be adjusted, we create a new shader varying to replace the original shader output varying, and save the original shader output varying to the replacement shader output varying at the end of the function. However, this does not work for tessellation control shader, because the SpirV generated will perform following equivalent peudo code: layout (vertices=3) out; in mediump float tc_in[]; out mediump float tc_out[]; highp float original_out[]; void main() { original_out[gl_InvocationID] = tc_in[gl_InvocationID]; // some other code in between tc_out = original_out; } The last line will attempt to write to all indice of tc_out. However, according to the spec, "each tessellation control shader invocation may write only to those outputs corresponding to its output patch vertex. Tessellation control shader must use the special variable gl_InvocationID as the vertex number index when writing to per-vertex output variables." This change fixes the problem by keeping the precision of tessellation control shader output as it is, and adjust the precision of tessellation evaluation shader input instead. Bug: b/42266751 Change-Id: I398545e2cbbf703c716d6738f1ba278baac4171f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6521225 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Kimmo Kinnunen 27a1b2c9 2025-03-13T09:10:54 Metal: Fix crash with 3d tex, alpha, depth Fix a crash when generating mipmaps for a 3d texture that has mipmaps with w,h == 1, i.e. depth > max(2*w, 2*h). Bug: angleproject:419755713 Change-Id: I7bf7f1f71c03b2bf6f8a30df30dc77ad06d433fe Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6580167 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com>
Geoff Lang dac0ef51 2025-05-27T18:36:56 WebGPU: Add a feature to avoid wgpuInstanceWaitAny Synchronous waiting is not available in Chrome's renderer process yet. Add a temporary feature to avoid some WaitAny calls and just log errors instead. Bug: angleproject:413078308 Change-Id: I67e54dfcfc093fd250da8cc616c05d44b78c8d64 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6593531 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Solti 101cf210 2025-05-15T16:40:43 roll rapidjson src to Android See b/279980674#comment52 for more details. Test: presubmit, and tested the rolling to Android in https://googleplex-android-review.git.corp.google.com/c/platform/external/angle/+/33713920 Bug: b/279980674 Change-Id: I834317a4a81d169cb0bfa32f0e33f2b0929ce279 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6579712 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Solti Ho <solti@google.com>
Kimmo Kinnunen 2f6f0514 2025-05-22T15:59:19 Metal: Wraparound int arithmetic for add, sub Implement wraparound int arithmetic for int, ivec +, -, +=, -=, ++, --. All of the added tests pass also without the changes. Bug: angleproject:382215759 Change-Id: I7605582ab2931e63010c34fba474797f7edd19f9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6578729 Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com>
angle-autoroll 9cb64dc6 2025-05-27T10:01:58 Roll vulkan-deps from bf024288c340 to d18d20e2f8cd (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/bf024288c340..d18d20e2f8cd Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/93231001597dad1149a5d035af30eda50b9e6b6c..be4ee7d0e3bfd151bfda7b3a8e03f8c49c55ed7b https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/67b5d1d7f84660ca14951315afb4f9baa08ae138..640f35dd85d25122371fa99b8788d944b71bc5e8 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/ae56bd6e65d9faa731150e931cb35f0d895223bc..49ac28931f28bffaa3cd73dc4ad997284d574962 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/84b023ac42601ff51ea6094dc2c18ca62960b25d..b75f27bc902ea48c1758d958222c742ecccf3aa2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I7449245e3c956c836c733c8eb05c4036b4253b4b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6590199 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mavis Deng 2a18fdbf 2025-05-21T16:14:51 Fix sync issue between XFB output and UBO input For the following scenario, where the first draw writes to the transform feedback buffer and the second draw reads from the same buffer as UBO, it is necessary to end the render pass between the two draws and add a barrier. // xfb write glBindBufferBase(GL_TRANSFORM_FEEDBACK_BUFFER, 0, xfb); glBeginTransformFeedback(); glDrawArrays(); glEndTransformFeedback(); // Draw with same buffer as UBO glBindBuffer(GL_UNIFORM_BUFFER, xfb); glDraw(); Bug: angleproject:418568423 Change-Id: Ia294d174111c6104b55762590ec26056ee759b53 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6572198 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 2802e9db 2025-05-26T03:01:28 Roll SwiftShader from f70c1194c173 to a8133cbb3c89 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/f70c1194c173..a8133cbb3c89 2025-05-23 syoussefi@google.com Fix 3D blit's z-clamp If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:419755713 Tbr: abdolrashidi@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: Id338db8529395ae750a49d18f9273c7658d2528e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6586403 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll a38ac25b 2025-05-26T10:01:53 Roll vulkan-deps from a4af0bcda127 to bf024288c340 (3 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/a4af0bcda127..bf024288c340 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/e1218d0e9ff42234a1841443176d8ed24405ee93..67b5d1d7f84660ca14951315afb4f9baa08ae138 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/2cfeb90c13053a5003a8d5a2ee66fee4a0e0cdce..84b023ac42601ff51ea6094dc2c18ca62960b25d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I388ad3d49f4e103c58d168609ebed324cfeef3f8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6585112 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexey Knyazev 7470cae4 2025-05-15T00:00:00 GL: Do not emulate EXT_base_instance If a driver does not support the corresponding commands, do not expose the extension at all, regardless of the enabled features. Bug: angleproject:355645824 Change-Id: Ideaae32e401c169690ca3aca6e437443a4b038f2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6580170 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Geoff Lang f0c46b2a 2025-05-25T10:44:23 WebGPU: Do not set autoresizingMask on the iOS Metal Layer autoresizingMask is not a member on iOS builds. This mirrors the window surface in the Metal backend. Bug: angleproject:342213844 Change-Id: I8b5cfbb2b7f7af4f3284ddd7055e68e762c77883 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6584993 Reviewed-by: Colin Blundell <blundell@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Brian Johnson ec4d8f8e 2025-05-23T11:00:03 Changes to support sdk35 Set the sdkVersion to 35, which forces edge to edge mode. Edge-to-edge mode without changes causes the ANGLE Preferences settings page to render the title bar on top of the content. The fix is to add an inset listener in the fragment, to adjust the window's marginTop by the inset amount. The preferences page that was being used had been deprecated as it used the old ListView, so I updated it to the new way, using PreferenceFragmentCompat which uses a RecyclerView. This fragment change cascaded a few changes with the Activity itself, and the theme, all of which are updated for this change to use PreferenceFragmentCompat. Tested: Built in the Android tree, flashed on a Pixel device. Tested in portrait and landscape, light and dark modes. Bug: b/403455598 Change-Id: I012b2ea2f9f0973f3e0a926a93d2c3b31daeccca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6581364 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Solti Ho <solti@google.com> Auto-Submit: Brian Johnson <hibrian@google.com>
Geoff Lang 4b375fe5 2025-05-23T18:44:54 WebGPU: Fix NoOpErrorScope constructor. We would always build with asserts enabled on our bots and missed that this constructor did not match the ErrorScope constructor. Bug: angleproject:342213844 Change-Id: Ieb73e6e1b0a0359b0ad336f14b7b9580c2ecc00b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6580169 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang 61e383dc 2025-05-23T18:41:57 WebGPU: Fix build on iOS and ChromeOS. Make sure we return a NativeWindowSystem in all branches. Build the Metal window surface on iOS. Bug: chromium:419793882 Change-Id: Ic829c83b71c18df9907ef729320377d82958f6ad Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6580168 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
kmx.io     mail     discord kmxgit v0.4.0