scripts/code_generation_hashes


Log

Author Commit Date CI Message
Le Hoang Quyen 0f9feb49 2025-03-15T23:51:04 Metal: Use render passes for B2T PBO copies. This would make it possible to avoid setting ShaderWrite usage to all textures in future. Bug: chromium:392521084 Change-Id: I25145f3578589c71ee469df08162d3a3f17c8cbe Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6356129 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Quyen Le <lehoangquyen@chromium.org>
Alexey Knyazev f56c8e02 2025-03-28T00:00:00 Fix & cleanup advanced blend equations support * Made advanced blend equation extensions enableable to facilitate better testing. * Made initial BLEND_ADVANCED_COHERENT state to be unconditionally true regardless of the extension support. If the coherent extension is unsupported, that state must not be observable anyway. * Ensured that advanced blend equation functionality is supported on unextended OpenGL ES 3.2 contexts. * Removed redundant ES 2.0+ context version checks because these extensions must never be enabled on ES 1.x contexts. * Fixed ValidateBlendBarrierKHR to set the correct error code and properly mark invalid calls. * Added more negative test cases and enabled tests on OpenGL ES 3.0 contexts. Bug: angleproject:42262258 Bug: angleproject:406922380 Change-Id: I709376ad40b09972a31a691ca3813e87dd2c8165 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6421857 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Roman Lavrov cbfa8e38 2025-03-31T09:51:33 Add "likely" hints to common validation paths This makes the hot path assembly more local. I can't tell if there is an observable effect of just doing this on the regular build performance, but this generally makes sense and reduces the assembly difference with PGO builds. Bug: b/383305597 Change-Id: Icb191e8e927217d9db4cb505d5cd6f76536403e3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6416263 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll 406f9217 2025-03-28T19:01:21 Manual roll vulkan-deps from 525b5b9d77ef to 23bc8dbadec2 (10 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/525b5b9d77ef..23bc8dbadec2 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/0e710677989b4326ac974fd80c5308191ed80965..8c88e0c4c94a21de825efccba5f99a862b049825 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/6b3cbe3f81357a47cdcac896bd9b145bcd3fa14e..10054abc9804429e754c89e086479ec02fbc1f41 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I4127b1d4165da7c07248e678b6f9ad3b0640c676 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6408893 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Aurora Zhang 34db1c20 2025-03-20T12:56:42 Vulkan: glReadPixels should nearest sample the YUV render target Vulkan backend uses texture except texelFetch to obtain the YUV image value for glReadPixels. According to the chroma filter set in the image, it may apply LINEAR sampling. * Change this filter to NEAREST inside glReadPixels to get the correct pixel values. * Modify the fragment shader used in glReadPixels to make sure sampling from the center of the pixel. * Add a new end2end test. Bug: angleproject:404394628 Change-Id: I0e574a464639e11671f0a09eee3e9f38b5abd919 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6366299 Auto-Submit: Aurora Zhang <Aurora.Zhang@arm.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 4b3fb1fa 2025-03-21T10:01:35 Roll vulkan-deps from 181443c3df2b to d6d779f39976 (13 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/181443c3df2b..d6d779f39976 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/9dc50c256f9a9f2794a6dfdccc8f5560e54ade1a..80814c3ed544804f19d9fc4bd9992c6e3b59482a https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/0c1ca5815ace3e4d84d3c7a1d59f0c06a189ea2b..db06346b03b5e01b8af58b842fe4b068f47f9e46 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/d64e9e156ac818c19b722ca142230b68e3daafe3..78c359741d855213e8685278eb81bb62599f8e56 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/006f10fb9ef19b7c7be7fc282cd53bca8a67946d..b817f36ef1995f328457a8d2cfca363ac67da810 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: Id3fea7959ee290be52c7b2c556fc47730072598e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6381892 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b039e7f9 2025-03-20T10:01:39 Roll vulkan-deps from 6737c973130b to 181443c3df2b (15 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/6737c973130b..181443c3df2b Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/8842cf92e3de290f275c46d55cbfe42b7d0775a6..e57f993cff981c8c3ffd38967e030f04d13781a9 https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/d6ec71c7a4734af3e5c0d0fa809c57d7a9bb64de..9dc50c256f9a9f2794a6dfdccc8f5560e54ade1a https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/d5ee9ed2bbe96756a781bffb19c51d62a468049a..0e710677989b4326ac974fd80c5308191ed80965 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/ff4d8908292812814e380f1965371677f82817a4..0c1ca5815ace3e4d84d3c7a1d59f0c06a189ea2b https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/abfdbf73d37ca2e617fae79728f856b303585915..006f10fb9ef19b7c7be7fc282cd53bca8a67946d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I419e92e24394e6f81de8afc895b95349ee653181 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6370594 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 98d4a537 2025-03-19T10:01:36 Roll vulkan-deps from bf9998679aee to 6737c973130b (20 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/bf9998679aee..6737c973130b Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/81fd2fce240f5cfaf94879df1e2c75872a321f96..d6ec71c7a4734af3e5c0d0fa809c57d7a9bb64de https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/ddd2c099be25e3fec7cdc14106c17aca99512082..d5ee9ed2bbe96756a781bffb19c51d62a468049a https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/ba1359d203e544bd458373ba249a47c44e97b071..ff4d8908292812814e380f1965371677f82817a4 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/cacef3039d277c448c89336290ec3937270b0996..d64e9e156ac818c19b722ca142230b68e3daafe3 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/b2c8bd421aa5c1502fd56c3c07fb2831a8ceb882..abfdbf73d37ca2e617fae79728f856b303585915 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I9fb5dabfd9fca69124c1eb6487df6a1023a5953c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6371589 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Chris Dalton 292bb458 2025-03-14T12:17:49 Cut MAX_COLOR_ATTACHMENTS_WITH_ACTIVE_PIXEL_LOCAL_STORAGE_ANGLE Since the number of real devices that support framebuffer fetch, but do not support draw_buffers_indexed, is effectively zero, MAX_COLOR_ATTACHMENTS_WITH_ACTIVE_PIXEL_LOCAL_STORAGE_ANGLE is an unnecessary complication. These hypothetical devices can fall back on shader images or just not support pixel local storage at all. This closes the door for WEBGL_shader_pixel_local_storage to ever be implemented on top of the ES2 extension that inspired it all, EXT_shader_pixel_local_storage, but WebGL can just use framebuffer fetch instead, or maybe even EXT_shader_pixel_local_storage2 some day. This dramatically simplifies the WEBGL_shader_pixel_local_storage extension. Bug: angleproject:40096838 Change-Id: I9c51f2ce000620f883cb7917d4e8618c8e9ee803 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6354657 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Chris Dalton <chris@rive.app>
angle-autoroll 0f7f5c48 2025-03-17T08:01:39 Roll VK-GL-CTS from d742379bbd26 to a10a27282b98 (15 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/d742379bbd26..a10a27282b98 2025-03-14 mateusz.bahyrycz@mobica.com Add support for sparse resources in ray tracing pipeline module 2025-03-14 javed@igalia.com Add logicop tests for float/srgb formats 2025-03-14 zzoon@igalia.com Fix validation errors in Vulkan Video decoding tests. 2025-03-14 michal.jakubek@mobica.com Fix validation error in multiview tests 2025-03-14 tomnom@google.com Add watchdog touch to dEQP-VK.texture.explicit_lod test 2025-03-14 kamil.goras@mobica.com Add testing for GL_PRIMITIVES_SUBMITTED_ARB query. 2025-03-14 marcin.zajac@cognizant.com Sequential timestamps 2025-03-14 marcin.zajac@cognizant.com Mixed primitive restart scenarios 2025-03-14 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.1 into vk-gl-cts/main 2025-03-13 lorenzo@khronosgroup.org Merge remote-tracking branch 'vk-gl-cts/dev/VK_EXT_external_memory_acquire_unmodified' into main 2025-03-12 rgarcia@igalia.com Missing include for std::log2 2025-03-12 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.1 into vk-gl-cts/main 2025-03-12 lorenzo@khronosgroup.org Merge "Merge branch 'dev/VK_EXT_external_memory_metal'" into main 2025-03-12 lorenzo@khronosgroup.org Merge "Merge remote-tracking branch 'vk-gl-cts/dev/VK_KHR_maintenance8'" into main 2025-03-12 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-cts-4.6.6 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I44f5de9308ffc65a1e274f630248ae5f0c61d922 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6360377 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Chris Dalton b600a42c 2025-03-13T15:18:40 Remove the PLS allow list All the interactions with render passes have been properly solved now, and there is no longer a need for the allow list. Bug: angleproject:40096838 Change-Id: I0219fb8824820e076c128f10f49c85f0f76270ef Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6355312 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Chris Dalton <chris@rive.app>
Mark Lobodzinski f86d0711 2025-03-07T13:30:58 Tests: Add My Talking Angela 2 Trace Test: angle_trace_tests --gtest_filter=*my_talking_angela_2 Bug: b/401473491 Change-Id: Ic0416ba7c6ab3db82865e9da01a69802590f33c1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6352326 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Chris Dalton fbb1829d 2024-12-08T01:46:39 Allow glClear while PLS is active It just makes sure to not clear any draw buffers that may be in use for pixel local storage. Bug: angleproject:402810076 Bug: angleproject:40096838 Bug: angleproject:42266150 Change-Id: I60a573d5e9e5dbadce12d79e3f4b6fc57747e655 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6312336 Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Chris Dalton <chris@rive.app>
angle-autoroll 9817c211 2025-03-13T10:01:19 Roll vulkan-deps from a6bd78fcdd17 to 552ac332629b (15 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/a6bd78fcdd17..552ac332629b Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/3a50d1708349ab612322edbf911a12faf3ab9664..0051b92b6fff2fd3dbc99b7dae316fa51a7f4767 https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/aad9239b4da66385e7228a95b4530989881c3524..81fd2fce240f5cfaf94879df1e2c75872a321f96 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/54a521dd130ae1b2f38fef79b09515702d135bdd..ddd2c099be25e3fec7cdc14106c17aca99512082 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/d6b6c5397b09e4bce4437732b0b212ee2cb21cc6..74a6b7dc828078cf2f1524d3947f65a29a1562e9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: Iaea03f87ac830950c98d28ee250cd679a9bfa6a5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6351333 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop db48967f 2025-03-05T09:07:10 Reland "Add GL_BGRA_EXT as a sized renderable format" This reverts commit 4bfb9da6f98b3e28905cc759a77bff750dfe3ff7. Reason for revert: More mapping fixes for GL backend Original change's description: > Revert "Reland "Add GL_BGRA_EXT as a sized renderable format"" > > This reverts commit 8f2fbbd1a0d16471596afad57c88f950a1ee3032. > > Reason for revert: http://anglebug.com/399913714 > > Original change's description: > > Reland "Add GL_BGRA_EXT as a sized renderable format" > > > > This reverts commit 22dfe435daa7c680c07bb8d4f1d98ab765e60ad0. > > > > Reason for revert: Fixed mapping back to BGRA_EXT for GL backend > > > > Original change's description: > > > Revert "Add GL_BGRA_EXT as a sized renderable format" > > > > > > This reverts commit 80093a7d8f850c3ab551ddb4972c2f1f27511433. > > > > > > Reason for revert: suspect for blocking rolling ANGLE into Chroimum > > > https://chromium-review.googlesource.com/c/chromium/src/+/6283973 > > > https://ci.chromium.org/ui/p/chromium/builders/try/chromeos-amd64-generic-rel-gtest/372754/overview > > > > > > Original change's description: > > > > Add GL_BGRA_EXT as a sized renderable format > > > > > > > > dEQP tests were updated to cover GL_BGRA_EXT as a sized renderable > > > > format. It was apparently always supposed to be, based on the > > > > wording of the spec. > > > > > > > > This CL adds that support and updates expectations, along with a few > > > > extra tests. > > > > > > > > Includes contributions from Robic.Sun@arm.com. > > > > > > > > Test: angle_end2end_tests, angle_deqp_*_tests > > > > Bug: b/42267264 > > > > Bug: angleproject:394384906 > > > > Change-Id: Ia10bcd61f66c5d99a3d27a2cfd6008c991ddcaa7 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6235444 > > > > Reviewed-by: Geoff Lang <geofflang@chromium.org> > > > > Commit-Queue: Cody Northrop <cnorthrop@google.com> > > > > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > > > > > > Bug: b/42267264 > > > Bug: angleproject:394384906 > > > Change-Id: I64572361cfed33b4ea17eabf278f580471d045c2 > > > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6285628 > > > Auto-Submit: Yuly Novikov <ynovikov@chromium.org> > > > Commit-Queue: Yuly Novikov <ynovikov@chromium.org> > > > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> > > > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > > > > Bug: b/42267264 > > Bug: angleproject:394384906 > > Change-Id: I1bd9df904d93fd54286cbfce53fe89db89e842b9 > > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6310699 > > Commit-Queue: Cody Northrop <cnorthrop@google.com> > > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > > Reviewed-by: Geoff Lang <geofflang@chromium.org> > > Bug: b/42267264 > Bug: angleproject:394384906 > Bug: angleproject:399913714 > Change-Id: I9f79f39a6d9cba3b23c261005bc3e012d70cd1cf > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6312977 > Auto-Submit: Cody Northrop <cnorthrop@google.com> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bug: b/42267264 Bug: angleproject:394384906 Bug: angleproject:399913714 Change-Id: Ifc98fcbb0883dc4a55ad358825e9c1935fa26eaa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6330036 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Chris Dalton 97083463 2025-03-10T09:07:16 Polish PLS interactions with xform feedback & QCOM_tiled_rendering For the simplest integration with WebGL, it was decided that glBeginTransformFeedback() and glStartTilingQCOM() should implicitly disable PLS, whereas glBeginPixelLocalStorageANGLE() should fail if either of these modes are active. Bug: angleproject:40096838 Change-Id: I859a496c99c60c5b040c5eac542f43d85872eb30 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6339788 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Chris Dalton <chris@rive.app>
Chris Dalton 4b39a6a9 2025-03-08T14:16:29 Generate errors for framebuffer invals during PLS Generate GL_INVALID_OPERATION for InvalidateFramebuffer, InvalidateSubFramebuffer, and DiscardFramebufferEXT (and add them to the PLS allow list so we can test the new validation). This is part of a final preparation before deleting the allow list. Bug: angleproject:40096838 Change-Id: If8ffb9c1998ca739798171ae4643a3c9ad3ee049 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6335750 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Chris Dalton <chris@rive.app> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Chris Dalton 1ead4cbd 2025-03-07T09:49:21 Allow texture modification commands while PLS is active Just do a little extra validation and bounce modifications if they would modify an active PLS plane. Bug: angleproject:40096838 Change-Id: I6f27951f5d0ef5dfaf23b5a005a2d94a749e2c4f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6337703 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Chris Dalton <chris@rive.app>
Shahbaz Youssefi 5b343e8f 2025-03-11T11:35:08 Vulkan: Remove support for Stadia Bug: angleproject:42262714 Change-Id: Icae5fe828fe4e0bcd287d297df1bc586708ef86e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6344390 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll baf5d9ed 2025-03-11T08:01:06 Roll VK-GL-CTS from ba86fb950043 to d742379bbd26 (14 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/ba86fb950043..d742379bbd26 2025-03-10 yuxinhu@google.com Remove the unused class member 2025-03-10 linyaa@google.com Move class vktApiExternalMemoryTests.cpp::ImageTestConfig 2025-03-10 linyaa@google.com Add member vktApiExternalMemoryTests.cpp:ImageTestConfig::tiling 2025-03-10 ziga@lunarg.com Test framebuffer with image view created with VK_REMAINING_ARRAY_LAYERS 2025-03-10 mateusz.bahyrycz@mobica.com Add support for sparse resources in ray query module 2025-03-10 javed@igalia.com Add tests for mutable formats with sparse resident images 2025-03-10 marcin.zajac@mobica.com Optimizing valid usage flags combinations 2025-03-10 ziga@lunarg.com Fix sType assert in mesh_shader_features_ext test 2025-03-10 jasuarez@igalia.com Fix barrier to read uniform texel buffer 2025-03-10 boris.zanin@amd.com Fix precision-based winding problems in watertightness tests 2025-03-10 rgarcia@igalia.com Add standard sample location variants of sample location tests 2025-03-10 rgarcia@igalia.com Basic tests to make sure index buffer binding persists 2025-03-10 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.1 into vk-gl-cts/main 2025-03-06 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.12 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: Ia0edef7193e72e40f9dde8070176e07f99015a23 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6342525 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 113bd9ef 2025-03-08T11:26:16 Manual roll vulkan-deps from e369814ee08e to adee401e9cba (14 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/e369814ee08e..adee401e9cba Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/19d232bb93a8585236051094cf49f747cc892e26..92356079fb9c9f6aa5c9c7766d5f8c5d52f436c3 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/0f0cfd88d7e6ece3ca6456df692f0055bde94be7..cacef3039d277c448c89336290ec3937270b0996 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/1bc9d032a89ef9b09e5b395d2f93fcd59fedf8ad..8491f31d36a8c642e588220b89729129721fec31 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/7efad3a101ea6e641e5948a4ed0d6e93b99b7bff..2bcf294ed82185b17c6c73ff512033a59dedb12d https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/50563f48368d75281bc2fb1c3407dc531ce28910..bc3a4d9fd9b46729651a3cec4f5226f6272b8684 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/85582585bee9e1ff7660dafeba76afcb524dbed3..789e54cec2e2c8e134522cc90f4b327852cdf0de If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,solti@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com,ynovikov@google.com Change-Id: I76a1b65476db8197efddf004d55e72b7d655e058 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6337447 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi 3d806ba6 2025-03-02T00:15:36 Translator: Split textureGather* ops ... based on whether the comp or refz arguments are present. Bug: angleproject:349994211 Change-Id: I19e638f6cb27cdb890c5e30c0662aad30888d2da Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6313582 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 8dd4a6e8 2025-02-28T16:50:51 Translator: Remove rect and 2DMS* images from atomic ops They are a relic of desktop GLSL support. Bug: angleproject:349994211 Change-Id: I111467fea111d22e2d12003d639bec268e418b44 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6313639 Commit-Queue: Cody Northrop <cnorthrop@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop 4bfb9da6 2025-02-28T12:49:28 Revert "Reland "Add GL_BGRA_EXT as a sized renderable format"" This reverts commit 8f2fbbd1a0d16471596afad57c88f950a1ee3032. Reason for revert: http://anglebug.com/399913714 Original change's description: > Reland "Add GL_BGRA_EXT as a sized renderable format" > > This reverts commit 22dfe435daa7c680c07bb8d4f1d98ab765e60ad0. > > Reason for revert: Fixed mapping back to BGRA_EXT for GL backend > > Original change's description: > > Revert "Add GL_BGRA_EXT as a sized renderable format" > > > > This reverts commit 80093a7d8f850c3ab551ddb4972c2f1f27511433. > > > > Reason for revert: suspect for blocking rolling ANGLE into Chroimum > > https://chromium-review.googlesource.com/c/chromium/src/+/6283973 > > https://ci.chromium.org/ui/p/chromium/builders/try/chromeos-amd64-generic-rel-gtest/372754/overview > > > > Original change's description: > > > Add GL_BGRA_EXT as a sized renderable format > > > > > > dEQP tests were updated to cover GL_BGRA_EXT as a sized renderable > > > format. It was apparently always supposed to be, based on the > > > wording of the spec. > > > > > > This CL adds that support and updates expectations, along with a few > > > extra tests. > > > > > > Includes contributions from Robic.Sun@arm.com. > > > > > > Test: angle_end2end_tests, angle_deqp_*_tests > > > Bug: b/42267264 > > > Bug: angleproject:394384906 > > > Change-Id: Ia10bcd61f66c5d99a3d27a2cfd6008c991ddcaa7 > > > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6235444 > > > Reviewed-by: Geoff Lang <geofflang@chromium.org> > > > Commit-Queue: Cody Northrop <cnorthrop@google.com> > > > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > > > > Bug: b/42267264 > > Bug: angleproject:394384906 > > Change-Id: I64572361cfed33b4ea17eabf278f580471d045c2 > > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6285628 > > Auto-Submit: Yuly Novikov <ynovikov@chromium.org> > > Commit-Queue: Yuly Novikov <ynovikov@chromium.org> > > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> > > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > > Bug: b/42267264 > Bug: angleproject:394384906 > Change-Id: I1bd9df904d93fd54286cbfce53fe89db89e842b9 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6310699 > Commit-Queue: Cody Northrop <cnorthrop@google.com> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Geoff Lang <geofflang@chromium.org> Bug: b/42267264 Bug: angleproject:394384906 Bug: angleproject:399913714 Change-Id: I9f79f39a6d9cba3b23c261005bc3e012d70cd1cf No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6312977 Auto-Submit: Cody Northrop <cnorthrop@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cody Northrop 8f2fbbd1 2025-02-27T13:33:06 Reland "Add GL_BGRA_EXT as a sized renderable format" This reverts commit 22dfe435daa7c680c07bb8d4f1d98ab765e60ad0. Reason for revert: Fixed mapping back to BGRA_EXT for GL backend Original change's description: > Revert "Add GL_BGRA_EXT as a sized renderable format" > > This reverts commit 80093a7d8f850c3ab551ddb4972c2f1f27511433. > > Reason for revert: suspect for blocking rolling ANGLE into Chroimum > https://chromium-review.googlesource.com/c/chromium/src/+/6283973 > https://ci.chromium.org/ui/p/chromium/builders/try/chromeos-amd64-generic-rel-gtest/372754/overview > > Original change's description: > > Add GL_BGRA_EXT as a sized renderable format > > > > dEQP tests were updated to cover GL_BGRA_EXT as a sized renderable > > format. It was apparently always supposed to be, based on the > > wording of the spec. > > > > This CL adds that support and updates expectations, along with a few > > extra tests. > > > > Includes contributions from Robic.Sun@arm.com. > > > > Test: angle_end2end_tests, angle_deqp_*_tests > > Bug: b/42267264 > > Bug: angleproject:394384906 > > Change-Id: Ia10bcd61f66c5d99a3d27a2cfd6008c991ddcaa7 > > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6235444 > > Reviewed-by: Geoff Lang <geofflang@chromium.org> > > Commit-Queue: Cody Northrop <cnorthrop@google.com> > > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > > Bug: b/42267264 > Bug: angleproject:394384906 > Change-Id: I64572361cfed33b4ea17eabf278f580471d045c2 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6285628 > Auto-Submit: Yuly Novikov <ynovikov@chromium.org> > Commit-Queue: Yuly Novikov <ynovikov@chromium.org> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Bug: b/42267264 Bug: angleproject:394384906 Change-Id: I1bd9df904d93fd54286cbfce53fe89db89e842b9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6310699 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi d39cabbd 2025-02-27T15:15:46 Translator: textureGather* always takes refZ with shadow sampler Bug: angleproject:349994211 Change-Id: I8337b80bf1d9ecae6943c6f1432b710040081273 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6309579 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Yuxin Hu 25a22dec 2025-02-24T14:32:42 Manual roll VK-GL-CTS from 69ec1790cb7c to ba86fb950043 (18 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/69ec1790cb7c..ba86fb950043 2025-02-21 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-cts-4.6.6 into vk-gl-cts/main 2025-02-21 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.12 into vk-gl-cts/main 2025-02-21 rgarcia@igalia.com Test "remaining array layers" and cube images with HIC 2025-02-21 javed@igalia.com Add coverage for tess shader IO 2025-02-21 marcin.zajac@cognizant.com Complex acceleration structure updates 2025-02-21 jbolz@nvidia.com Add tests for VK_NV_cooperative_vector 2025-02-21 syoussefi@google.com Remove last references to DE_NULL 2025-02-21 abdolrashidi@google.com Fix non-zero offset added to nullptr 2025-02-21 zzoon@igalia.com Vulkan Video Decode: Increase MAX_BOUND_MEMORY 2025-02-21 lionel.g.landwerlin@intel.com Fix incorrect structure type check 2025-02-21 gleese@broadcom.com Fix test data generation for copy tests 2025-02-21 javed@igalia.com Add tests for differing mutable format 2025-02-21 gleese@broadcom.com Stop querying device address from unbound buffers 2025-02-21 scerveau@igalia.com video: rename clip description names 2025-02-21 kamil.goras@mobica.com Add test that redeclaring gl_FragDepth is not permitted in ES 2025-02-21 kamil.goras@mobica.com Fix KHR-GLES31.core.nearest_edge.* tests that fail with EXT_read_format_bgra formats. If BGRA format and type 1_5_5_5 are preffered by device use BGRA_EXT and UNSIGNED_SHORT_1_5_5_5_REV_EXT in ReadPixels and swizzle colors. 2025-02-21 mateusz.bahyrycz@mobica.com Add support for sparse mode for ray tracing utils 2025-02-21 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.1 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: b/398956813 Tbr: yuxinhu@google.com Change-Id: I8d2de8b6f8671b5cf66d6b4210877ca8f187528b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6298534 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Auto-Submit: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Robic Sun 34faa3db 2025-02-08T15:17:10 Fix issue that stride setting is incorrect when rotation is true When rotateXY is true, stride should increase or decrease on the Y axis. Bug: angleproject:395131251 Change-Id: I0f5363c9952ccdf0a036499a9f918853eff7cd10 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6242496 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Auto-Submit: Robic Sun <Robic.Sun@arm.com>
Amirali Abdolrashidi c21e31a1 2025-02-20T17:32:17 Add handling null input to eglGetProcAddress * Modified eglGetProcAddress() so it can handle a null input by returning nullptr. * Added a test for this case: * EGLReadinessCheckTest.GetProcAddressNullInput * Fixed some typos. Bug: angleproject:397720948 Change-Id: If55223b12831649252e2e06e47abaf8d3546c86f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6289249 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
angle-autoroll eb22e1f8 2025-02-21T11:44:31 Roll vulkan-deps from 126c9b378eb7 to f489bd52916f (18 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/126c9b378eb7..f489bd52916f Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/e66176c3f685b14dfa83882329e5d02f4e027c9b..104bd85d990155f04f050972374a3502b4631830 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/09913f088a1197aba4aefd300a876b2ebbaa3391..54a521dd130ae1b2f38fef79b09515702d135bdd https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/9fa14b91414994e2bf4d9509b8efc8071f154991..a80d3b5c505e6541d98003b880ae583bc706bbc9 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/234c4b7370a8ea3239a214c9e871e4b17c89f4ab..952f776f6573aafbb62ea717d871cd1d6816c387 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/087c22a441e5fb8563516b6b515483898c843242..a10e2725f99c333bbc468373159442fe41158039 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Ifb414ab9bbbd524973d4944854649deb0f1714c5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6288472 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Chris Dalton be98f841 2024-11-30T02:11:05 Implicitly end PLS for framebuffer reads and writes In preparation for removing the PLS allow list, convert more problematic methods to the new paradigm of implicitly ending PLS instead of generating errors. Also simplify the disable logic for framebuffer modifications, and just blindly disable PLS for framebuffer updates, regardless of whether it's GL_READ_FRAMEBUFFER or GL_DRAW_FRAMEBUFFER. Bug: angleproject:40096838 Change-Id: Ie4390a219f5f05ef0a3d00f405d4914592726283 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6077335 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov 22dfe435 2025-02-20T06:46:07 Revert "Add GL_BGRA_EXT as a sized renderable format" This reverts commit 80093a7d8f850c3ab551ddb4972c2f1f27511433. Reason for revert: suspect for blocking rolling ANGLE into Chroimum https://chromium-review.googlesource.com/c/chromium/src/+/6283973 https://ci.chromium.org/ui/p/chromium/builders/try/chromeos-amd64-generic-rel-gtest/372754/overview Original change's description: > Add GL_BGRA_EXT as a sized renderable format > > dEQP tests were updated to cover GL_BGRA_EXT as a sized renderable > format. It was apparently always supposed to be, based on the > wording of the spec. > > This CL adds that support and updates expectations, along with a few > extra tests. > > Includes contributions from Robic.Sun@arm.com. > > Test: angle_end2end_tests, angle_deqp_*_tests > Bug: b/42267264 > Bug: angleproject:394384906 > Change-Id: Ia10bcd61f66c5d99a3d27a2cfd6008c991ddcaa7 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6235444 > Reviewed-by: Geoff Lang <geofflang@chromium.org> > Commit-Queue: Cody Northrop <cnorthrop@google.com> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Bug: b/42267264 Bug: angleproject:394384906 Change-Id: I64572361cfed33b4ea17eabf278f580471d045c2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6285628 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop 80093a7d 2025-02-03T08:50:21 Add GL_BGRA_EXT as a sized renderable format dEQP tests were updated to cover GL_BGRA_EXT as a sized renderable format. It was apparently always supposed to be, based on the wording of the spec. This CL adds that support and updates expectations, along with a few extra tests. Includes contributions from Robic.Sun@arm.com. Test: angle_end2end_tests, angle_deqp_*_tests Bug: b/42267264 Bug: angleproject:394384906 Change-Id: Ia10bcd61f66c5d99a3d27a2cfd6008c991ddcaa7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6235444 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Mark Lobodzinski bace6371 2025-02-17T15:14:37 Tests: Add Brotato ANGLE trace Test: angle_trace_tests --gtest_filter=*brotato Bug: b/397185288 Change-Id: I3d89d4b073b56efeede42abf5b0f44f8e9bd221a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6277708 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Cody Northrop c8049a47 2025-02-12T13:21:56 Tests: Add Tower of Fantasy trace Test: angle_trace_tests --gtest_filter="*tower_of_fantasy" Bug: b/389808881 Change-Id: I16a4ab0c12c18d2feb9df41cb0ba5667adb1f161 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6258901 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Mark Łobodziński <mark@lunarg.com>
Alex Dean c0d806b4 2025-02-10T23:01:33 CL: OpenCL support for ANGLE Capture/Replay Implementation of OpenCL Capture/Replay tool in ANGLE. Brief notes about the change: - Most meaningful changes for the capture process are made in src/libANGLE/capture/ - Most meaningful changes for replay are made in util/capture/ and src/tests/perf_tests/ - Many autogenerated files are changed/added to allow the capture of OpenCL objects & calls - The following applications were captured/replayed: benchmark_model, GeekBench Compute, GeekBench ML, AI-Benchmark, various OCL CTS tests - End2end test added to capture_tests. CapturedTestCL.MultiFrameCL/ES3_Vulkan Bug: angleproject:383841335 Change-Id: I55fdaa6cd6c7ba740aaa2351e4d29050059d6d1d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6102105 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Roman Lavrov <romanl@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Geoff Lang 9f8d7cc2 2025-01-23T13:27:19 WebGPU: Stream incompatible vertex and index data. Support reading back index and vertex buffers to stream incompatible source data. For now this includes: * Non-multiple-of-4 stride vertex data * Stride not a multiple of the type size * Unsigned byte indices Fix fallback formats so that all GLES formats have a fallback. Fix CopyToFloatVertexData writing the alpha channel as Float32One with a static_cast which converted Float32One (an integer) to a float instead of bit-casting. Bug: angleproject:368602384 Change-Id: I7eb1ba7ad1ec4292060c18de22f5948136cbb0a3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6194556 Reviewed-by: Liza Burakova <liza@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll a7f5ae52 2025-02-07T10:01:08 Roll vulkan-deps from 4d67b5012a2f to c32804ca5a39 (25 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/4d67b5012a2f..c32804ca5a39 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/39766a06679bf5e4bc1e0339136f1b6a519fcec5..8a6b381c9afbfaf9fff851582539fab15ea480c0 https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/5728a66537b23986135f50c465fcb282b0434da4..a15ec3f54859037512aac22e58ea45aef09cde40 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/e7294a8ebed84f8c5bd3686c68dbe12a4e65b644..09913f088a1197aba4aefd300a876b2ebbaa3391 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/9d07794bc955101c79cbd260233fcc65b9951cfc..682bcd51548e670811f1d03511968bb59a1157ce https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/c52931f012cb7b48e42bbf2050a7fb2183b76406..a9f88a232a4cd6634e47f0f93c8fac5789387a7a https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/e9d5ff418fd29381205b7617170a6d556bc6a10e..e00009bc3f550898c92e96a77ae4dca963778301 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I304fb09e84cc50d18abd28938ee4733042ca739c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6243349 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
angle-autoroll e9cda7f6 2025-02-06T08:01:49 Roll VK-GL-CTS from 48e7f3020f52 to 1177f7b7d556 (5 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/48e7f3020f52..1177f7b7d556 Includes manual merge to remove GN reference to deDefs_kc_cts.h 2025-02-04 lorenzo@khronosgroup.org Remove all references to KC-CTS and GTF 2025-02-04 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.1 into vk-gl-cts/main 2025-02-04 elima@igalia.com Add VK_KHR_video_maintenance2 tests 2025-02-04 lorenzo@khronosgroup.org Update external sources and use Vulkan 1.4.307 2025-02-04 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.1 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I881df1f09ca98c892a485c5a8368c3f6eda390f5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6237566 Reviewed-by: Solti Ho <solti@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Roman Lavrov 60a9320c 2025-02-06T14:31:43 Move unlikely path of MakeLengthOp to a function call This function gets inlined many times, adding 96 bytes of assembly to each caller such as angle::spirv::WriteStore etc. In total, this CL reduces Android release .so size by ~14KB Bug: angleproject:394848869 Change-Id: Ief364116fd9b881f9c0dfefb1ca5005282bf57ba Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6236799 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Kimmo Kinnunen 49e2b5e2 2025-01-31T15:52:39 Support compiling without GetProcAddress Move GetProcAddress implementation next to the proc array. This way it is possible to not compile the implementation. Bug: angleproject:393513311 Change-Id: Ic9c9022ee74a7619bec25f1481fd9da68b14b119 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6219320 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com>
angle-autoroll 0c2d793c 2025-01-31T11:52:51 Manual roll vulkan-deps from 3a89e5275402 to 430dae9cea66 (15 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/3a89e5275402..430dae9cea66 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/5165b6d2bdff5244e8aef6408441a962424cf2d1..c1c4712c75bc123dac21daea5dfffd416e103e59 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/3364b982713a0440d1d342dd5eec65b122a61b71..04b4a204aa501992ae85a207be1e200e195c98e1 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/e43027aa41c4f51b12d79aeae53ff608951c36ec..39f924b810e561fd86b2558b6711ca68d4363f68 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/369afe24d1351d6e03cbfc3daf1fc5f6cd103649..0508dee4ff864f5034ae6b7f68d34cb2822b827d https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/7658238ddc50d7ef1fe923d95b7112597a5adc68..c52931f012cb7b48e42bbf2050a7fb2183b76406 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/1ddbe6c40aeaf98d4138f07c325ebb01beeece68..fe7a09b13899c5c77d956fa310286f7a7eb2c4ed https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/cc4c765c9ccacabd6338f348082841846053abb9..c3dc948b0b960b3a01506b57a15ecee2a9e31bf2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: If34c6c40f06e14b42316a05ad5dc59a9c9314c9b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6220892 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll a870888a 2025-01-30T10:01:18 Roll vulkan-deps from 0a35e614cfbd to 3a89e5275402 (14 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/0a35e614cfbd..3a89e5275402 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/633e9b6e15b7b142eb311ecc316858eab5425033..0549c7127c2fbab2904892c9d6ff491fa1e93751 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/2b2e05e088841c63c0b6fd4c9fb380d8688738d3..e7294a8ebed84f8c5bd3686c68dbe12a4e65b644 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/bdf077623c55dabae66ce64639086b4391e14016..3364b982713a0440d1d342dd5eec65b122a61b71 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/0d99e5aad4299d8e4b3bcf4bf1e1bea4a32a9044..cc4c765c9ccacabd6338f348082841846053abb9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: Iaf74dbf889388ac22d282ba89ffd5fdc8bd73d21 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6217422 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 8d76df50 2025-01-27T10:01:52 Roll vulkan-deps from 1b571b5a7b3c to 7425f0646395 (14 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/1b571b5a7b3c..7425f0646395 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/3f129d076b44221b8b56a63215446d33b570ced8..4897b17f67bd6ddfeabb9c4e0bf5e8298eab3064 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/e02275ec02b68e3d175528f768871c97ae9eee90..173fe3c60a8d9c7d35d7842ae267bb9df267a127 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/a03d2f6d5753b365d704d58161825890baad0755..e43027aa41c4f51b12d79aeae53ff608951c36ec https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/1586f33d6d79eb9ffa5963ce4f70423986b95d8a..ce3fbf53c8f77d04bc23d573a45b57fb6ed52e86 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/8ce2501d2511b6f4e6389a03ff08c4e84d54fa25..7658238ddc50d7ef1fe923d95b7112597a5adc68 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/f07e27717a642fa193c967440f21ed634ea17987..8ec84823afa46cd054c8b094269eab958e078010 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/afad70fbb26c643b19cf53a5990852a4d83664b6..258528b408898da932e3c681ff731b0be73fd9fc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: Ia0016ff0c2769e7c8be65b2a69ce705ee62b593c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6200657 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi c1214ec2 2025-01-22T14:22:56 Vulkan: Rename Context to ErrorContext In preparation for adding another Context (derived by GL and CL contexts), which includes logic that pertains to command recording (such as barrier tracking). Bug: angleproject:390443243 Change-Id: Idf495b62e63fb9aa901a2f16447fdaf3c2acd90b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6191248 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 6dc14ded 2025-01-17T11:25:34 Roll vulkan-deps from 8d2a13cc4374 to 476cafde9e9d (37 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/8d2a13cc4374..476cafde9e9d Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/e43514866f7e0f8265c677039d2fe773c892d44b..b5dc38707208efae0b7a1606790ca33d237d950e https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/a380cd25433092dbce9a455a3feb1242138febee..2b2e05e088841c63c0b6fd4c9fb380d8688738d3 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/9064fe8637daf9f694c8a2e035a34da94022f2be..321692686b64873ccf4972754e36185697993e21 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/d4a196d8c84e032d27f999adcea3075517c1c97f..a03d2f6d5753b365d704d58161825890baad0755 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/369f59ad598b60d6ed9f553af651c5cccd20234c..35a851d182cdebef408493b9a82ba212d1a2629c https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/5a88b6042edb8f03eefc8de73bd73a899989373f..2fe3a7791dc9c34a581dc45522ab9b4363b4f321 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/ea05bf71f2948d64f7d36651ffcad59216401095..a80bafccd11d2b4e44dee21c530da49b41083682 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I8da429f8817a31aa573acb6c39864db8e24b83e1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6181014 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Steven Noonan 49e5f944 2025-01-07T22:27:33 egl_angle_ext: add value for EGL_CONTEXT_MEMORY_USAGE_ANGLE The enum was declared as a dependency of the extension EGL_ANGLE_memory_usage_report, but no value was defined. Bug: angleproject:351866412 Change-Id: I956da38930e69eb83c179ac70c244f0df7ef7f04 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6165287 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Steven Noonan <steven@uplinklabs.net> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll b4cb17b8 2025-01-15T10:08:39 Roll VK-GL-CTS from 9509eb274dfe to 962460e9975c (9 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/9509eb274dfe..962460e9975c 2025-01-10 javed@igalia.com Add tests for input assembly primitive stat with tess 2025-01-10 piotr.byszewski@mobica.com Fix promoted extension tests not running correctly 2025-01-10 ziga@lunarg.com Fix supported sample count check in draw_copy_resolve tests 2025-01-10 marcin.zajac@mobica.com Fix validation error in api tests 2025-01-10 nikolaysmirnov@google.com Add multiple_render_targets_overdraw test 2025-01-10 gleese@broadcom.com gen_framework.py: Fix some alignment 2025-01-10 gleese@broadcom.com Update amber version to the latest upstream 2025-01-10 rgarcia@igalia.com Test varying tessellation state in Indirect Execution Sets 2025-01-10 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.1 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:390138123 Change-Id: I6b653b347550d4a7d4f75e3ce1a0f7bf20e0d0cb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6175280 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi bbc0d702 2024-12-27T07:44:01 Vulkan: Add entry points to lock the Vulkan queue ... which can be retrieved via EGL_ANGLE_device_vulkan. Otherwise the application is unable to use the VkQueue that is retrieved out of ANGLE from other threads (such as Chromium's DrDC feature). Bug: chromium:380295059 Change-Id: Ife80f54440777486f72fc61697a68fb0c2b2d0f7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6116046 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Steven Noonan 3226a3df 2024-12-13T14:06:55 Reland: vulkan: add EGL_ANGLE_platform_angle_vulkan_device_uuid Implement the ability to select a specific device and driver combination through a few new selection criteria: VkPhysicalDeviceIDProperties::deviceUUID VkPhysicalDeviceIDProperties::driverUUID VkPhysicalDeviceDriverProperties::driverID Earlier version had problems due to a test build issue. Per syoussefi@, going to rework the test into a separate CL so that we get the core change merged. Bug: angleproject:351866412 Change-Id: I0a3f4f1a2154a06bf6286a037c9ad4834ef4dda2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6165286 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Steven Noonan <steven@uplinklabs.net>
Yuly Novikov 3b092269 2025-01-09T08:54:00 Revert "vulkan: add EGL_ANGLE_platform_angle_vulkan_device_uuid" This reverts commit 96abb2c3d9e296ae12e50e0026bf5d3a7b925e7e. Reason for revert: breaks rolling into Chromium https://chromium-review.googlesource.com/c/chromium/src/+/6158098 Original change's description: > vulkan: add EGL_ANGLE_platform_angle_vulkan_device_uuid > > Implement the ability to select a specific device and driver combination > through a few new selection criteria: > > VkPhysicalDeviceIDProperties::deviceUUID > VkPhysicalDeviceIDProperties::driverUUID > VkPhysicalDeviceDriverProperties::driverID > > Bug: angleproject:351866412 > Change-Id: Ia6716aaed658d2563612d8b5d81287df97b57462 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5686557 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Auto-Submit: Steven Noonan <steven@uplinklabs.net> > Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bug: angleproject:351866412 Change-Id: Ic7cf9dcf6a950556cc44f5920498db429c866340 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6164164 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Roman Lavrov 31ccf78b 2025-01-07T15:46:15 Inline GetVertexFormatID using lookup tables Before this change the switch produced >1KB of assembly due to all the branching. This reduces the .so size by ~3KB and avoids the function call into a seemingly cold page. No obvious perf improvement in my tests from just this change. Changing underlying enum type to minimize table sizes. Bug: b/383305597 Change-Id: I724aa093ab5edf7af016b5b04764437a345517d1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6153395 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll c9fec1f7 2025-01-09T10:01:45 Roll vulkan-deps from 5f05f0592633 to 1fa2eb257bf0 (5 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/5f05f0592633..1fa2eb257bf0 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/3f17b2af6784bfa2c5aa5dbb8e0e74a607dd8b3b..a380cd25433092dbce9a455a3feb1242138febee https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/8a7619fc7dc30177cbb1d32c457c4fb05e9f82db..196627ca4ebb72cb1367755b9d97a9ed716e4728 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: Idff66b4047049e3ce84f069f6cd407db098d4694 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6162097 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Steven Noonan 96abb2c3 2024-12-13T14:06:55 vulkan: add EGL_ANGLE_platform_angle_vulkan_device_uuid Implement the ability to select a specific device and driver combination through a few new selection criteria: VkPhysicalDeviceIDProperties::deviceUUID VkPhysicalDeviceIDProperties::driverUUID VkPhysicalDeviceDriverProperties::driverID Bug: angleproject:351866412 Change-Id: Ia6716aaed658d2563612d8b5d81287df97b57462 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5686557 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Steven Noonan <steven@uplinklabs.net> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov 465299fb 2025-01-06T16:49:15 context_private_call.cpp -> context_private_call.inl.h Most functions are trivial wrappers resulting in unnecessary forwarding calls. Most are called exactly once from entry points autogen. This _reduces_ the .so size by ~14KB and I'm seeing 1-2% better frame time in my driver_overhead_2 tests on a mobile device. Bug: b/383305597 Change-Id: I1f2a048e067c76993bacfbbce655fc1c898fdba7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6149814 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Mark Lobodzinski 491335c4 2024-12-26T10:25:32 Tests: Add Bullet Echo ANGLE trace Test: angle_trace_tests --gtest_filter=*bullet_echo Bug: b/387973432 Change-Id: Ib5694f53dd2f5a2b0d8a417582e4ff8054565461 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6149436 Commit-Queue: Mark Łobodziński <mark@lunarg.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
angle-autoroll ed3deea8 2025-01-06T08:01:00 Roll VK-GL-CTS from 77d5e6888a99 to 9509eb274dfe (8 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/77d5e6888a99..9509eb274dfe 2025-01-03 piotr.byszewski@mobica.com Test concurrent access across device and host 2025-01-03 ziga@lunarg.com Add missing shader object test case 2025-01-03 russellc@nvidia.com Lower dimensions for image concurrent copy tests 2025-01-03 marcin.zajac@cognizant.com Fix validation error in ycbcr tests 2025-01-03 marcin.zajac@cognizant.com Fix validation error in transform feedback tests 2025-01-03 marcin.hajder@mobica.com Made border_clamp tests independent on out of spec precision 2025-01-03 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.1 into vk-gl-cts/main 2024-12-31 andrew.shadura@collabora.co.uk Fix instances of -Wmissing-template-arg-list-after-template-kw If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: I2deed801ab285a74a6ece7121904460d4d6fc7d3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6147148 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 35ea113c 2024-12-27T06:03:23 Manual roll VK-GL-CTS from 1797eec1a51d to 7655439d7333 (15 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/1797eec1a51d..7655439d7333 2024-12-20 michal.jakubek@mobica.com Vulkan SC doesn't report waived test case count 2024-12-20 piotr.byszewski@mobica.com Test NoContraction keyword 2024-12-20 marcin.hajder@mobica.com Added tests for non-layered bindings of 2D shader images 2024-12-20 kamil.goras@mobica.com Enable ES31_compatbility tests. Those tests are implemented but were not added to any test package. Move SampleVariablesTests, ShaderImageLoadStoreTests, ShaderStorageBufferObjectTests to common 2024-12-20 piotr.byszewski@mobica.com Fix copy tests using NaN for sfloat formats 2024-12-20 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.1 into vk-gl-cts/main 2024-12-18 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.1 into vk-gl-cts/main 2024-12-16 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkansc-cts-1.0.2 into vk-gl-cts/main 2024-12-12 rgarcia@igalia.com Test depth/stencil copies on the transfer queue 2024-12-12 mateusz.bahyrycz@mobica.com Fix validation error in ray tracing tests 2024-12-12 antonio.ospite@collabora.com Build testlog-* and other tools also on Android 2024-12-12 marcin.hajder@mobica.com Added missing texture parameter for shadow samplers 2024-12-12 tomeu@tomeuvizoso.net Fix Android standalone executables to work with EGL tests 2024-12-12 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.1 into vk-gl-cts/main 2024-12-12 gleese@broadcom.com Make autogen for VK, VK SC consistent If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Change-Id: I73077c44cfae8ba31d7334e2b149e368c6c1f579 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6116045 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 81a41e4f 2024-12-21T01:14:31 Manual roll vulkan-deps from 2d70513951de to 45d90843193e (20 revisions) Manual roll requested by abdolrashidi@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/2d70513951de..45d90843193e Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/6a74a7d65cafa19e38ec116651436cce6efd5b2e..d4a196d8c84e032d27f999adcea3075517c1c97f https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/7ccaa5e0206fcaa03135312fccb4624ae110a19b..b8315514467ace9e22070dd8e0491aaffb9690d1 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/2744de9936755fea6912d47e7a0a8857d8a4fdee..a71347ae4d76eb8454459373d4e1bfb929ea6a89 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/7f8738669b15a7a158b2a77aff2033973dcd8751..5a88b6042edb8f03eefc8de73bd73a899989373f https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/2cbfec7bb95b3de7bab8db92716197ec9a855fb2..90851ef5b77757556217122061672dc52e21629c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I7f4b0e5ffbae1a159fe1085aaf48c5eb4f219cda Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6115340 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mark Lobodzinski 0dabe316 2024-12-18T09:35:35 Tests: Add Monopoly Go trace Test: angle_trace_tests --gtest_filter=*monopoly_go Bug: b/384879555 Change-Id: I64ab6efb23745ab9e099c1243d4f09cee0f311d5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6106530 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Cody Northrop 0f0d2cc7 2024-12-17T09:50:56 Tests: Add Riptide GP2 trace Test: angle_trace_tests --gtest_filter="*riptide_gp2*" Bug: b/384714388 Change-Id: I09984201c2c96797dcc867ef818aa18684561275 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6101168 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Roman Lavrov <romanl@google.com>
Roman Lavrov 00d9ef8f 2024-12-13T11:59:29 Inline GetUniformTypeInfoFromIndex A very small function call on hot path, highlighted by PGO profile data from driver_overhead_2. Makes driver_overhead_2 1~2% faster on Pixel 8 (measured with shared context lock off). Bug: b/335295728 Bug: b/383305597 Change-Id: I36e58b42b06c72c8f4c282110c85bb5130ced8d0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6094283 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Mark Lobodzinski e9b33f04 2024-12-11T15:17:51 Tests: Add Don't Starve Pocket Edition trace Test: angle_trace_tests --gtest_filter=*dont_starve Bug: b/383500194 Change-Id: I924436d5bb2b166dac5798feff1d614ce1453adb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6090033 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Mark Lobodzinski 09f3bc3a 2024-12-10T15:57:49 Tests: Add Loop Hero trace Test: angle_trace_tests --gtest_filter=*loop_hero Bug: b/383282700 Change-Id: Iff3b5a37b3dfea898344007f544ec25c8b6fa0be Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6085489 Commit-Queue: Mark Łobodziński <mark@lunarg.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Le Hoang Quyen 6bb1bc9b 2024-12-10T16:56:33 Add an extension to report total memory usage of all GL objects Currently the extension will only count GL buffers, textures and render buffers' memory. Fixed: angleproject:383256300 Change-Id: I33ce6fafae8aa5b60071e66366d35dc098e1313b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6084013 Auto-Submit: Quyen Le <lehoangquyen@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Quyen Le <lehoangquyen@chromium.org>
angle-autoroll 1cef3e81 2024-12-10T08:01:03 Roll VK-GL-CTS from 08a7f888a933 to 1797eec1a51d (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/08a7f888a933..1797eec1a51d 2024-12-09 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.1 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I5976b94bdd5caa1e616c3c6e85d3ad2f027a9597 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6083123 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuxiang Qian fb743105 2024-11-26T14:37:39 Add stubs for EGL_EXT_surface_compression This patch adds stubs for EGL_EXT_surface_compression to ANGLE, including new API eglQuerySupportedCompressionRatesEXT and adding EGL_SURFACE_COMPRESSION_EXT in EGLQuerySurface and EGLCreateWindowSurface/EGLCreatePlatformWindowSurface. Bug: angleproject:375496226 Change-Id: I1962a11e8e3e5eb2cd5b13c5ba0f685781dfd015 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6073354 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop eee895e1 2024-12-09T08:32:34 Tests: Add Return to Monkey Island trace Test: angle_trace_tests --gtest_filter="*return_to_monkey_island*" Bug: b/383027719 Change-Id: Idc31426199888e7645c2c644bea611f3cc98f202 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6080212 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Alexey Knyazev e6c8f06a 2024-11-29T00:00:00 Metal: Remove line markers from internal shaders Line markers generated by Clang preprocessor are platform-dependent and cause extra git noise. Metal shader compiler does not need them anyway. Fixed: angleproject:382564808 Change-Id: I792a523ac9269a097c7f52a4cd64a24ed6145567 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6074518 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Quyen Le <lehoangquyen@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop 244c0514 2024-12-07T23:06:03 Tests: Add Balatro trace Test: angle_trace_tests --gtest_filter="*balatro*" Bug: b/382914040 Bug: b/382960265 Change-Id: Iebebae9dc2da1b1f20f6e9c184130ebfd544ae52 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6077333 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
angle-autoroll 6b683732 2024-12-09T08:01:02 Roll VK-GL-CTS from a9f7069b9a5b to 08a7f888a933 (6 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/a9f7069b9a5b..08a7f888a933 2024-12-05 javed@igalia.com Add tests for mutable format resolves 2024-12-05 javed@igalia.com Add coverage for pipeline binary keys 2024-12-05 piotr.byszewski@mobica.com Coverage for different operations and helper invocations 2024-12-05 rgarcia@igalia.com Test tessellation state changes with shader objects 2024-12-05 piotr.byszewski@mobica.com Fix validation error in dedicated DRLR tests 2024-12-05 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.1 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I97154e2205e4a45afa4e4adf5cb14eec9f48def6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6079679 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexey Knyazev e82a2eab 2024-11-28T00:00:00 Support multisample 2D array textures on ES 3.0 contexts Supported via OES_texture_storage_multisample_2d_array enabled together with ANGLE_texture_multisample. Drive-by: Fixed exposure conditions in the OpenGL backend to match the implementation. Fixed: angleproject:382298321 Change-Id: I21b037aac7bebc35df267e9dd468088ebce35e71 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6075241 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Alexey Knyazev 26414249 2024-11-28T00:00:00 Remove GetTexLevelParameter* from ANGLE_texture_multisample These functions are always provided by the GL_ANGLE_get_tex_level_parameter frontend extension. Fixed: angleproject:382291448 Change-Id: I59b4ccc56478f2e0931d1f5bd665cfdd5a34391e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6072222 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Chris Dalton cc841237 2024-11-29T13:45:50 Accept framebuffer modifications while PLS is active The only way for a WebGL implementation to know if PLS is actually active is to call glGetIntegerv(PIXEL_LOCAL_STORAGE_ACTIVE_PLANES_ANGLE) (because glBeginPixelLocalStorageANGLE() can fail). So the original behavior of not allowing glBindFramebuffer() et. al. while PLS was active created a state scenario that was expensive for the browser to track. Instead, just allow glBindFramebuffer() et. al., and implicitly disable PLS if they are called while it's active. Bug: angleproject:40096838 Change-Id: Ibd303f9f9950fb5b7f1add2d41882e4379c51e62 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6060301 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Chris Dalton <chris@rive.app> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 96a49b8a 2024-12-04T08:01:01 Roll VK-GL-CTS from b27686793f88 to a9f7069b9a5b (18 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/b27686793f88..a9f7069b9a5b 2024-12-03 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.1 into vk-gl-cts/main 2024-11-28 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.1 into vk-gl-cts/main 2024-11-27 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.1 into vk-gl-cts/main 2024-11-23 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.1 into vk-gl-cts/main 2024-11-23 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-cts-4.6.5 into vk-gl-cts/main 2024-11-22 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkansc-cts-1.0.2 into vk-gl-cts/main 2024-11-22 ziga@lunarg.com Add shader object tests with color write disabled 2024-11-22 piotr.byszewski@mobica.com Test VIEW_INDEX_FROM_DEVICE_INDEX with link time optimizations 2024-11-22 mateusz.bahyrycz@mobica.com Add missing coverage for sparse resident multisampled images 2024-11-22 geofflang@chromium.org Add 'static' to more functions marked as 'inline'. 2024-11-22 michal.jakubek@mobica.com Unexpected crash on 32bit drivers. 2024-11-22 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.0 into vk-gl-cts/vulkan-cts-1.4.1 2024-11-22 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.0 into vk-gl-cts/vulkan-cts-1.4.1 2024-11-20 lorenzo@khronosgroup.org Merge remote-tracking branch 'vk-gl-cts/vulkan-cts-1.4.0' 2024-11-15 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.10 into vk-gl-cts/main 2024-11-14 petermcneeley@google.com Adding amber test for barriered atomics in vulkan 2024-11-14 ziga@lunarg.com Test vkCmdClearColorImage with 2D-compatible 3D images 2024-11-14 syoussefi@google.com Replace DE_INLINE with inline If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I48849d3c578a8c446859cb0810dcfda4c3f4b9f4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6069072 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Panfeng Hou a504b6a2 2024-11-25T15:59:05 Support GL_OES_required_internalformat Enable GL_OES_required_internalformat GLES extension. Bug: angleproject:364069034 Change-Id: Ia57548469abff189472aa20b13ca99179c45f2c0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6038448 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Panfeng Hou <panfeng.hou@arm.com>
Alexey Knyazev 0bb109aa 2024-11-28T00:00:00 Fix validation for 2D multisample array textures * Fixes: * TEXTURE_BINDING_2D_MULTISAMPLE_ARRAY query must be rejected if the functionality is not enabled. * GetInternalFormativ must accept TEXTURE_2D_MULTISAMPLE_ARRAY on unextended OpenGL ES 3.2 contexts. * Added validation to the OpenGL ES 3.2 TexStorage3DMultisample entry point. * Cleanups: * Removed OES suffix from the enum conversion. * Incorrect extension name in the error message. * Do not create a 2D multisample array zero texture object if the backend does not support the functionality. * Replaced redundant FramebufferTexture validation with an assertion. * Do not allocate texture binding vectors for 2D multisample array textures if the backend does not support the functionality. * Aligned the 2D multisample array texture target assert in RecordBindTextureTypeError with the actual error condition. Fixed: angleproject:381270278 Change-Id: Idbbc86e2efe1bbc25d9570d515b67c1a32255d99 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6063068 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao 7adbb3e8 2024-11-26T17:06:07 Vulkan: Remove explicit destroy calls Since now SharedPtr will automatically call destroy(device) when last reference goes away, there is no need for explicitly calling destroy(device) any more. Bug: angleproject:372268711 Change-Id: I208b17cf7e090babd51d6f337c20fdfd74c75b6b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6052886 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Igor Nazarov 65d674b0 2024-12-02T18:36:11 Vulkan: Must run UnlockedTailCall from flush and finish `glFlush` and `glFinish` may call `WindowSurfaceVk::swapImpl()` implicitly when the current Window Surface is in the single buffer mode. The `WindowSurfaceVk::swapImpl()` in turn may add unlocked tail call in order to perform CPU throttling. It seems, that CPU throttling is only possible if also enable the `EGL_FRONT_BUFFER_AUTO_REFRESH_ANDROID` attribute (using `VK_PRESENT_MODE_SHARED_CONTINUOUS_REFRESH_KHR`). Without this attribute (`VK_PRESENT_MODE_SHARED_DEMAND_REFRESH_KHR`) `vkQueuePresentKHR()` performs implicit waiting for GPU, making ANGLE's throttling uncessary (the serial is already finished). This fix allows running the tail call from `glFlush` and `glFinish` (because these APIs are not performance critical). Alternative solution may instead perform the CPU throttling immediately if the `WindowSurfaceVk::swapImpl()` is called from the `WindowSurfaceVk::onSharedPresentContextFlush()`. Additionally, added "ASSERT(!any())" at the beginning of each entry point. This is to catch scenarios, if some API adds the unlocked tail call and for some reason exit without checking the assert of running the call. Test: angle_end2end_tests --gtest_filter=EGLAndroidAutoRefreshTest.SwapCPUThrottling/ES3_Vulkan_NoFixture Bug: angleproject:42266581 Change-Id: I418c552f6e95b4cfc01db738c9989533377f1050 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6063719 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>
Chris Dalton 7070a9e9 2024-11-20T00:21:16 Remove draw buffer validation clauses from PLS It was cumbersome to implement all this validation browser side for WebGL. Rather than making it an error to update blend and color mask on reserved PLS draw buffers, glBeginPixelLocalStorageANGLE() can just implicitly disable blend, and enable the color mask on overridden draw buffers. Later calls to enable blend or change the color mask on overridden planes are silently ignored until glEndPixelLocalStorageANGLE(). Bug: angleproject:40096838 Change-Id: Ic7e1c5113e7d3fad3b80d0178075df646540d743 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6045421 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Chris Dalton <chris@rive.app>
angle-autoroll b47144c6 2024-12-02T10:01:01 Roll vulkan-deps from ef4dc615f82d to ff00298c3058 (3 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/ef4dc615f82d..ff00298c3058 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/9dff1f571ce25b92639854b89b28539602b6b97b..49af1bfe467dd5a9efc22f7867d95fdde50e2b00 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/a62cf6e7f366c1d5285a4b54edc6bfdb9eb60551..f29e7f255fd201d04d6720439554f25ffee39e8c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I1229374513b965bd7466afd73275b8d01190c669 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6061626 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Robic Sun f51170b3 2024-11-21T16:30:40 Enable GL_KHR_texture_compression_astc_hdr Vulkan supports GL_KHR_texture_compression_astc_hdr, so this extension can be enabled in Angle. Bug: angleproject:379186304 Change-Id: I438a120c3f884a7eefcd883ad71abf68f81cb473 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6038457 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Panfeng Hou d57b1d30 2024-11-28T11:09:53 Vulkan: Support GL_OES_required_internalformat Only export 'GL_OES_required_internalformat' in GLES extension. Bug: angleproject:364069034 Change-Id: I6198b7b79fc2853c7585ebff183016ee110a25e5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6055198 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Xinyu Fang 5d3d299d 2024-11-25T16:35:51 Expose the required GLES1.0/1.1 extensions in ANGLE Exposed below extensions: GL_OES_texture_mirrored_repeat GL_OES_blend_subtract Bug: angleproject:380704155 Change-Id: Ib095f9bfaabda92bb2c588d633f1512e118f066e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6038450 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll e10220f8 2024-11-28T18:24:35 Manual roll vulkan-deps from 3c7156644de7 to 0e28d467e76d (59 revisions) Manual roll requested by syoussefi@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/3c7156644de7..0e28d467e76d Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/1f1ef7560399322558793d91a53b34cdd34f4fe1..0099ed6ad09a78b083c93be9369791dd72cf8a33 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/45b314049d6262c850cc873c8f9a30f41a1e0c13..36d5e2ddaa54c70d2f29081510c66f4fc98e5e53 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/ea1d8cd9814852428d25d3ea113683a6c9686afb..7d5bc35197be75e10000f14ea9eb3954ca2b0aab https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/f864bc6dfe6229a399566e979c16795386d0f308..9dff1f571ce25b92639854b89b28539602b6b97b https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/4cd2a86fa6a88abfcf44a7630212fc375fbe0fe5..2534c1e2327990e55f51b8a1f8328085e8e3ff31 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/df2ac1bb61f09a80db979d7108adf07b6fe55913..a2224abf350f61211462a33e5b540201fa17de0d https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/c31e717dcd817279e9e90516612f9dbfc84b0e51..b538fb5b08513aa78346cd414ad5e576a2a3e920 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/fdbdd359fb2bbb50352e84b259171813957d1ee3..b61aa3f59711c9a45e6bac13f70c61dc9e4650c8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: Ieecaf46ecf017defffaca78bb003b0b7dcf094f6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6058269 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao 87d61997 2024-11-21T14:20:55 Vulkan: Switch ShaderModule to use SharedPtr This CL gets rid of many vk::RefCounted<vk::ShaderModule> usage which is risky due to it allows you to direct manipulate reference count. Switch to vk::SharedPtr manages the reference counting automatically. Bug: angleproject:372268711 Change-Id: I14f5c509bcbd9ea7d17101637e033652a68710a0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6039117 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Xin Yuan b6b826b3 2024-11-27T09:57:18 Add stubs for GL_EXT_EGL_image_storage_compression Bug: angleproject:352345943 Change-Id: I993a7908e868019852c0d682bf2131e46a2cf304 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6051521 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang e3199b5f 2024-11-21T14:17:47 Add bison/flex binaries on Mac. Use the same bucket as Windows and Linux (mac folder). Update documentation for how to get and update these binaries. Bug: angleproject:377941128 Change-Id: Ia2de3bb4e98109821d1adeb22d0cbc49edc07b1d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6042552 Commit-Queue: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Amirali Abdolrashidi c02e0184 2024-11-22T17:21:38 Add GL_ARM_rgba8 * It is a subset of GL_OES_rgb8_rgba8. Bug: angleproject:352352894 Change-Id: I07f031157344385c847cd229a85ebf59cc6dfcfc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6044333 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Kimmo Kinnunen 8e9dc1a6 2024-11-19T11:08:31 Validate anonymous struct names with namespace Consider GLSL: struct { vec4 e; } g; struct sbbf { vec4 f; }; The struct name validation would fail if user chosen struct name would clash with a symbol name that ANGLE internally gave to an anonymous struct. Fix by importing Name abstraction from MSL backend. A symbol name is a pair (namespace, string). Move operator<<(std::ostream &os, const ImmutableString &str) to sh namespace because that is more natural for operator overloading name resolution. MSVC works with this. Bug: angleproject:379758201 Change-Id: Icc9b02aa8cb532e1d925e2fba4c45468f01b9144 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6035029 Reviewed-by: Geoff Lang <geofflang@chromium.org> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com>
Cody Northrop 594a11ac 2024-11-20T16:55:06 Tests: Add Need For Speed: No Limits trace Test: angle_trace_tests --gtest_filter="*need_for_speed_no_limits" Bug: b/380107298 Change-Id: I216574367e8e495a69c63de2ec04a6c9e3c73ff4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6037637 Reviewed-by: Mark Łobodziński <mark@lunarg.com> Commit-Queue: Mark Łobodziński <mark@lunarg.com>
Shahbaz Youssefi 770242db 2024-11-20T17:03:07 Translator: Remove the `gimage1D` base type This is a desktop GL type, whose removal was left out of b16d105fc6. Bug: angleproject:370937467 Change-Id: I0bda5453b95ddf924ba0583de346902b333603a6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6037776 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 1f0ac74a 2024-11-20T16:43:50 Translator: Remove SubpassInputMS ANGLE never generates multisampled input attachments, because it cannot know if the shader will be used with a single-sampled or multisampled framebuffer. The SPIR-V transformer takes care of changing the type and ops to be multisampled if needed. Bug: angleproject:37093746 Change-Id: Ic9c3057536c0a5d543512dbd3c347033453a29f4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6039437 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Shahbaz Youssefi c4533e0a 2024-11-20T16:21:40 Translator: Remove the `double` base type This is a desktop GL type, whose removal was left out of b16d105fc6. Bug: angleproject:37093746 Change-Id: I185beef71099aafc3e350efc3dad019e2a72c0e6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6039436 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
angle-autoroll 174694c1 2024-11-16T02:15:55 Manual roll VK-GL-CTS from f674555ab03e to b27686793f88 (29 revisions) Manual roll requested by yuxinhu@google.com https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/f674555ab03e..b27686793f88 2024-11-14 syoussefi@google.com Use std functions instead of de* wrappers (deString.h) 2024-11-14 mateusz.bahyrycz@mobica.com Add coverage for instanced draws with tessellation 2024-11-14 rgarcia@igalia.com Test alpha-to-coverage with sample shading 2024-11-14 mateusz.gawrysiak@intel.com Fixed ycbcr_sampler.graphics array tests by adding combinedImageSamplerDescriptorCount multiplication 2024-11-14 scerveau@igalia.com EncodeTests: rework the result queries 2024-11-14 scerveau@igalia.com EncodeTests: set the decoder to use layeredDpb 2024-11-14 mateusz.gawrysiak@intel.com Fix imageFormatProperties check before VK_FORMAT_G8_B8R8_2PLANE_420_UNORM array creation 2024-11-13 yuxinhu@google.com Add #include <cmath> in glcTextureStorageTests.cpp 2024-11-08 marcin.hajder@mobica.com Port KC-CTS tests to VK-GL-CTS (draw_buffers_test1), PART 14 2024-11-08 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.11 into vk-gl-cts/main 2024-11-08 piotr.byszewski@mobica.com Test operations which must always preserve denorms 2024-11-08 ziga@lunarg.com Add image concurrent copy tests 2024-11-08 piotr.byszewski@mobica.com Test DRLR with DS attachments that use one aspect 2024-11-08 ziga@lunarg.com Add host image copy tests with array and depth offsets 2024-11-08 benjamin.cheng@amd.com Create encode DPB image without TRANSFER_SRC usage 2024-11-08 benjamin.cheng@amd.com Fix video-profile-independent DPB creation 2024-11-08 lionel.g.landwerlin@intel.com Enable device-only events in sync2 tests 2024-11-08 kamil.goras@mobica.com KHR-Single-GL46.enhanced_layouts.varying_locations breaks spec and requires more than GL_MAX_GEOMETRY_INPUT_COMPONENTS components in geometry stage for some test cases. Such cases are skipped. 2024-11-08 marcin.hajder@mobica.com Port KC-CTS tests to VK-GL-CTS (texture_stencil8_gl44), PART 16 2024-11-08 gleese@broadcom.com Revert "Fix support check for dynamic state tests" 2024-11-08 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.10 into vk-gl-cts/main 2024-11-04 gleese@broadcom.com Fix frag_coord_conventions test when not supported 2024-11-01 michal.jakubek@mobica.com Make vktComputeBasicComputeShaderTests.cpp buildable 2024-10-31 mateusz.bahyrycz@mobica.com Remove commented code 2024-10-31 piotr.byszewski@mobica.com GPL with unusual multisample states 2024-10-31 mateusz.bahyrycz@mobica.com Add coverage for indirect draws with tessellation 2024-10-31 javed@igalia.com Add coverage for mesh shader with GPL/ESO 2024-10-31 marcin.hajder@mobica.com Port KC-CTS tests to VK-GL-CTS (texture_storage_compressed_texture_data), PART 15 2024-10-31 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.10 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,solti@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com,yuxinhu@google.com Change-Id: I617a3b8a149bd157e3d922b0dc726bf395a4b27e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6027274 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cody Northrop 828e2d19 2024-11-16T14:41:10 Tests: Add Block Blast trace Test: angle_trace_tests --gtest_filter="*block_blast*" Bug: b/379456572 Change-Id: I751b69320f68dc4afaa6fdd29e054fb543c43d22 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6026306 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Roman Lavrov <romanl@google.com>
Neil Zhang 8a2b60b2 2024-11-06T17:13:16 Add stubs for GL_EXT_texture_storage_compression Bug: angleproject:352364583 Change-Id: I607c19c0c9bec7f0e3dd325e44b42e73f826b61c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5998012 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop 33c86fde 2024-11-14T14:33:21 Tests: Add SimCity BuildIt trace Test: angle_trace_tests --gtest_filter="*simcity_buildit*" Bug: b/379097986 Change-Id: I8753014ebcf6ab1ea55868141a527429e8fb4f8c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6021680 Reviewed-by: Mark Łobodziński <mark@lunarg.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Mark Lobodzinski c7a43ec8 2024-10-28T12:26:05 Capture/Replay: Track framebuffers by context Some game titles treat framebuffer objects as shared. Framebuffer objects are now tracked per-context to avoid conflicts. Test: angle_trace_tests --gtest_filter=TraceTest.limbo --offscreen Bug: b/371985732 Change-Id: I34ae5b54d569eec75ad86b7b363f7a84d56d955c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5973639 Commit-Queue: Mark Łobodziński <mark@lunarg.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Gowtham Tammana 05b58737 2024-11-04T13:52:09 CL: Add CL command execution status to the enum list Adding the CL command execution status enums to the auto enum generation list - packed_cl_enums.json. The execution status are defined as cl_int in the CL api, and as such they are not packed at the entry points - entry_points_cl_autogen.{h,cpp}, and are left to be used at the implementation layer. The following files are autogeneration through `run_code_generation.py` script. - scripts/code_generation_hashes/packed_enum.json - src/common/PackedCLEnums_autogen.cpp - src/common/PackedCLEnums_autogen.h Bug: angleproject:37997556 Change-Id: Ia00fc12ef02e3882d47a1ad18cd6c11ce6bf63dc Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6004062 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>