kc3-lang/angle

Log

Author Commit Date CI Message
Shahbaz Youssefi f96d2d35 2022-03-18T10:54:07 Test RGB invalidate with user FBOs When an RGB image is invalidated and then used as attachment, the cleared alpha value was previously lost due to loadOp=DONT_CARE. This was fixed by making the following render pass use loadOp=CLEAR instead. The test for this relied on RGB backbuffers, which is not easily testable on many platforms. This change adds a similar test using user FBOs. Bug: b/180139027 Bug: angleproject:6860 Change-Id: I11f408d6cd925b45bc9bcec455563cd23a226fec Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3536387 Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Constantine Shablya e74d0e81 2022-02-11T18:05:12 Vulkan: Implement EGL_KHR_partial_update This change provides a trivial implementation of partial update that does nothing, making apps that want this extension happy. A possible efficient Vulkan implementation would use the damage set to narrow down render area, but it appears to only be useful for only some TBDR hardware. Bug: angleproject:6960 Reviewed-by: Antonio Caggiano <antonio.caggiano@collabora.com> Change-Id: Ic553ac9590c336093f1bf25a6521574622599bf6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3427640 Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Auto-Submit: Constantine Shablya <constantine.shablya@collabora.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi b74d6768 2022-03-17T16:48:21 Vulkan: Refactor D/S usage tracking in render pass This is in preparation for doing the same for color images. That is in turn in preparation for optimizing mid-render-pass clears, which require an answer to the following query: "has this color image been read from / written to so far in the render pass?" Bug: angleproject:5048 Change-Id: I8abe97919897b8fbf644482071bf7326ca3325d6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3533143 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill a55526a5 2022-03-17T11:11:37 Vulkan: Ignore VUID-vkCmdDraw-None-06538. Suspected as being incompatible API usage in ANGLE. Bug: angleproject:7105 Change-Id: I8c806b1ae090c5bedd762c1539a228c31a553858 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3533140 Auto-Submit: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 22f177eb 2022-03-17T16:58:37 Vulkan: Expose advanced blend for non-coherent devices as well Reliance on coherent behavior was accidental. Bug: angleproject:3586 Change-Id: I86d055cf640368b57256910764c44596b23ccdd8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3535299 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 65902973 2022-03-18T10:01:53 Roll SwiftShader from d01dca1d18d0 to 341ad7e57a3c (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/d01dca1d18d0..341ad7e57a3c 2022-03-17 natsu@google.com Handle VK_FORMAT_G10X6_B10X6R10X6_2PLANE_420_UNORM_3PACK16 sampling 2022-03-17 capn@google.com Optimize fragment input interpolation using FMA If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I58331331793287c2be6fc1dc529520d85d351fbd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3534695 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 3a529ce2 2022-03-18T07:00:31 Roll Chromium from 45902868a797 to 3e4963702e02 (1593 revisions) https://chromium.googlesource.com/chromium/src.git/+log/45902868a797..3e4963702e02 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/18a1f1939e..8f75e7de55 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/113dd1badb..d8c375426d * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/a897d0f3f8..93b8dcd57b * testing: https://chromium.googlesource.com/chromium/src/testing/+log/8399c3e77d..55f1dc2d27 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/3f6f1caf8d..a4297493d8 * third_party/android_build_tools/aapt2: yQIf5Ev_-q9u6Pr_a0APd1dHcImJSmotVADw4Pj151QC..wicn5Ce1ay6ivbZ1GNFF0gRSS3NYv_7hJTPtVga3O-QC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/05fa71af3a..be0731f39e * third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/5320e6281a..5f109f3c41 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..389f33bb40 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3481645827..76979dae56 * third_party/turbine: VhmfIPuSDHHeilnA7WC0MhR9ShZNF25tA0Te4RYIZG8C..Go9J3Mz5ankZAgxmn5GxeXKdEDV73zaZp2ojNfGC1RQC * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/b0676a1f52..923f5eb4bf * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/85f3c90818..a15c2dfa35 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/f0753eb065..e6f159df60 * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/feb42b9a96..8a340b64dc * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/80fc9315e0..46fa9b4765 * tools/skia_goldctl/linux: wjKDZ5vJELJ_j3O037nIWhBEMF0cY4Y1g4tLc47hPJoC..iqtz2prn9CUv6A8KCcxJzadmPEDLY1FPP-b2YqIFQ1cC * tools/skia_goldctl/mac_amd64: jw5QK1qcTGSBr-yjH0d-9F_MNeq6e5_5aWLq_oGWy0QC..Y4l14LBqCsT9EhffPIOtso9VSpwqQE9WccjZdDBZmLoC * tools/skia_goldctl/mac_arm64: o4BSMT1hKtY4T4VBfANeSm-NuhxoxPYUp3lF0EpoUvMC..INEqc8JI_mtww_X0ShOlDkF3S8OG4tjF4Nkei0K7ci8C * tools/skia_goldctl/win: Vg04A_bOadtB2ljbA9DGKe69_Uc6pmX5mk_ABoO2R3EC..EbVQXa1u0hbZ8pxb0Il6Rbc1ErHpIN_-kMVOzBXMQyoC No update to Clang. Bug: None Tbr: jmadill@google.com Change-Id: I3c10efcadf6995ec9da02c97666cfc3a155b701e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3534747 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
马爱国 8a2a4fa7 2022-03-15T06:59:00 Add loongarch support Bug: angleproject:7104 Change-Id: I9b9c57b76463f16d0c3c7ccc8b81c1bb657a3cc8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3522459 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 1e6643d5 2022-03-17T17:55:06 Roll VK-GL-CTS from 8252a3d3cdd3 to 823d49cf5f5e (5 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/8252a3d3cdd3..823d49cf5f5e 2022-03-17 mika.vainola@siru.fi Fix GCC 11 misleading indentation warning 2022-03-17 jari.komppa@siru.fi Add dynamic state to instancing tests 2022-03-17 antto.makinen@siru.fi Test SRGB formats with UNIFORM_TEXEL_BUFFERs 2022-03-17 ari.suonpaa@siru.fi Rewrite portability check for Amber tests 2022-03-17 ilkka.saarelainen@siru.fi Improve coverage of MSAA copies If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-bots+autoroll-info@google.com,jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: angle-bots+autoroll-info@google.com,jmadill@google.com Change-Id: Ib3136bc6f96332a776f3ee2a3682744aabf6a3cd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3533448 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Geoff Lang 44e84661 2022-03-17T15:02:21 Revert "Emulate RGB10 (no alpha) on desktop OpenGL." This reverts commit 6404be2defd3ded3ff2f0437bb87fe515e10f2a7. Reason for revert: Extension was not fully enabled due to test bug. Original change's description: > Emulate RGB10 (no alpha) on desktop OpenGL. > > The OpenGL ES extension GL_EXT_texture_type_2_10_10_10_REV > requires RGB and RGBA formats to be supported but Desktop OpenGL > does not support RGB. Emulate it with the existing > emulatedAlphaChannel path in TextureGL. > > Bug: chromium:1300575 > Change-Id: I0e6d1044afbc55cf6d4f987cc98b357ff11ff006 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3517346 > Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Geoff Lang <geofflang@chromium.org> Bug: chromium:1300575 Change-Id: Ib3810a18888544f1700a1f648a5094c19973d86d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3533139 Reviewed-by: Geoff Lang <geofflang@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Alexey Knyazev 479f1988 2022-03-17T11:50:46 Simplify ValidCompressedBaseLevel Bug: angleproject:7099 Change-Id: I9592aebde56808556f72b2b94a39f94d077f9db2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3529527 Reviewed-by: Brandon Schade <b.schade@samsung.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Kimmo Kinnunen b465a736 2021-12-21T12:52:40 Metal: Remove redundant CommandQueue::mMetalCmdBuffersTmp Instead of a member variable, instantiate the temporary at the use site. Bug: angleproject:6842 Change-Id: I64848bc937ce2945e6ac55adea8a6dffcaf9b00d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3347649 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: John Cunningham <johncunningham@apple.com> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Jamie Madill e8ee847d 2022-02-23T12:25:39 Vulkan: Add UpdateDescriptorSetsBuilder. This helper class encapsulates the vkUpdateDescriptorSets caching. As part of the refactor, we switch passing a ContextVk to passing a vk::Context with some mutable variables. This helps encapsulate ContextVk. Since we use the perf counters in many places, this CL moves the perf counters to vk::Context, so we can access them everywhere. Refactoring change only. Bug: angleproject:6776 Change-Id: Id529962b2f425bece6f9b3bd0cd1698c692e58cb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3484980 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 7b7cf69e 2022-03-17T10:01:54 Roll SwiftShader from c27e99245d42 to d01dca1d18d0 (11 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/c27e99245d42..d01dca1d18d0 2022-03-17 swiftshader.regress@gmail.com Regres: Update test lists @ b3b1a3fe 2022-03-16 capn@google.com Use slow legacy log2() implementation for Chromium 2022-03-16 capn@google.com Add exp/log optimization documentation 2022-03-16 capn@google.com Improve the precision of highp log2() 2022-03-16 capn@google.com Improve the precision and performance of highp exp2() 2022-03-16 capn@google.com Fix handling infinity for relaxed precision log2() 2022-03-16 srisser@google.com Add variable to control regres daily branch 2022-03-16 joshuaduong@google.com Fix integer overflow in vkAllocateMemory. 2022-03-16 capn@google.com Implement a relaxed precision log2() 2022-03-16 capn@google.com Implement a relaxed precision exp2() 2022-03-15 swiftshader.regress@gmail.com Regres: Update test lists @ c27e9924 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I18059c70242f237a343729584a0d69f3786da7a8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3531933 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 98bb4f32 2022-02-23T16:51:32 Vulkan: Implement advanced blend through extension This change exposes GL_KHR_blend_equation_advanced if VK_EXT_blend_operation_advanced is supported. No emulation is yet implemented. Bug: angleproject:3586 Change-Id: Ie7a442c22e028e3aa45ccef52db320e205664d49 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3487951 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 3ddb21fd 2022-02-23T14:15:48 Front-end support for KHR_blend_equation_advanced Bug: angleproject:3586 Change-Id: I27086295e7455ce8848db1c6004917fea40202e8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3484785 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Brandon Schade 459bdc2f 2022-03-16T12:04:38 Reintroduce validation check only for D3D To avoid undefined behavior, D3D requires the base mip level to have multiple-of-4 dimensions. Add this validation check back in. Bug: angleproject:7099 Change-Id: Id51f6cd4c745455062b864c0d291b9857e985e35 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3530499 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com> Commit-Queue: Brandon Schade <b.schade@samsung.com>
Steven Noonan 04460fe8 2022-03-15T19:04:39 end2end tests: add regression test for GL_LINE_LOOP drawing This was fixed by 349636a05a3577a127adb6c79a1e947890bbe462. Adding a regression test which I didn't have ready at the time. Bug: angleproject:7102 Change-Id: Icbb685c1ffad6725a278e5ed65f881f86c5688ef Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3527604 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Mohan Maiya d867ddbb 2022-03-16T09:25:03 Doc: Update supported EGL minor version ANGLE implements the EGL 1.5 specification, update the README to reflect that. Bug: angleproject:1944 Change-Id: Id61d21ebab05f81bbfcd2ea6ce6c137c8a564279 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3530487 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Yuxin Hu 1dc9f126 2022-03-16T19:29:26 Revert "Flush the texture staged updates when destroying context share group" This reverts commit 5c29d795d1625f71ac6999f157b6f3bba79d5256. Reason for revert: this is causing some test failures on chromium and blocking the angle-chromium auto roller job: https://chromium-review.googlesource.com/c/chromium/src/+/3529771/ Original change's description: > Flush the texture staged updates when destroying context share group > > If we are using the extension EGL_ANGLE_display_texture_share_group, > flush the texture staged updates upon destroying the context. With the > extension enabled, the texture could still be alive when both context > and its' EGL::ShareGroup are destroyed. If we have staged updates not > yet flushed, the updates will keep the ShareGroupVk bufferpool occupied, > causing an error upon ShareGroupVk::onDestroy(). > > Bug: chromium:1299211 > Change-Id: I260de93c3a3099e023e31acbe017803e824459ad > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3495879 > Reviewed-by: Charlie Lao <cclao@google.com> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Yuxin Hu <yuxinhu@google.com> Bug: chromium:1299211 Change-Id: I214161d6a8aec834e1efc5fc9d2479e62e3bfae0 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3530505 Auto-Submit: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Lubosz Sarnecki ed590dc8 2022-03-11T12:54:44 FrameCapture: Add override for Glsizei* types. Fix capturing glGetSynciv with null lengths on Linux. When calling the default WriteParamValueReplay handler with a nullptr, ostream on Linux will write `(nil)`. This fixes retracing all traces containing glGetSynciv calls with null lengths. Add a NullLength test to FenceSyncTests that used to fail in the capture_replay_tests. Test: capture_replay_tests.py --gtest_filter=FenceSyncTest.NullLength/* Bug: angleproject:7071 Bug: angleproject:6808 Change-Id: I0a2bd4db744ce2a026cd932ba0f2f4747672fcc8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3526653 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Antonio Caggiano 8fb0a633 2022-03-15T18:11:27 Vulkan: VkFormat/DrmFourCC Define macro and header dependency in BUILD.gn when Vulkan is enabled. Bug: angleproject:7065 Change-Id: Ifbd9091425212689d4284b2bc46d3fe59267509c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3526654 Auto-Submit: Antonio Caggiano <antonio.caggiano@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Roman Lavrov f8a2229e 2022-03-16T10:58:07 angle_system_info_test also exports androidSdkLevel Value being non-zero would unambiguously indicate that target is Android, not sure if the actual value is really needed but it's probably good to have. Bug: angleproject:6854 Change-Id: I685e8e0ffbb666349801203e9d09b082135af17e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3529966 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Roman Lavrov 08e007dd 2022-03-15T18:23:54 angle_system_info_test passes json via file --render-test-output-dir is supported by Android test runner so the file is first written on the device then copied over to the host. Bug: angleproject:6854 Change-Id: Ia56fd9c36ab68a495459efa3b1014e871a615565 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3526855 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll e498d885 2022-03-16T10:01:52 Roll vulkan-deps from a11411926c31 to 51988dcdccbf (9 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/a11411926c31..51988dcdccbf Changed dependencies: * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/0e994ee9c4..4995a2f272 * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/2c45218b90..384881cc90 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/a0c7be0505..ab207b0829 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/795bad232d..99500cee1e * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/ca222d286f..6c8f1627a3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: Ie1322074d40a6eb1e0f5914ea5eb5b5d5e096728 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3528360 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yahan Zhou 63b54d9d 2022-03-09T17:04:13 Do not copy parent layer frame position The position value in a frame refers to its relative position to its parent. We do not want to copy that to its new child layer. Test: when using ANGLE (with metal or swiftshader backend) with emulator frame, it should render the emulator at the right position. Bug: angleproject:7097 Change-Id: I94f78e1253d7ee016bf7ab512d908f75250ce9c7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3523622 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Auto-Submit: Yahan Zhou <yahan@google.com> Reviewed-by: Yahan Zhou <yahan@google.com> Commit-Queue: Kenneth Russell <kbr@chromium.org>
Charlie Lao 349636a0 2022-03-15T09:39:36 Vulkan: Update mCurrentElementArrayBuffersync based on dirty bit The previous fix crrev.com/c/3513553 has run into corner case that requires more follow up change crrev.com/c/3522565. But with that, there is report that now we are hitting assertion in handleDirtyGraphicsIndexBuffer(). This becomes a bit fragile This new fix relies on the DIRTY_BIT_INDEX_BUFFER dirty bit and should be more reliable as long as the dirty bit is set properly (if not, then we have other bug that it won't even send down vulkan command to bind the correct element buffer). We could further optimize the code path and create a fast path for most common usages in the future. Bug: chromium:1299261 Change-Id: Ifa8f86d431798c9ca4c128ed71a3e9e0a3537ccb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3526021 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Yuxin Hu 5c29d795 2022-02-28T23:56:46 Flush the texture staged updates when destroying context share group If we are using the extension EGL_ANGLE_display_texture_share_group, flush the texture staged updates upon destroying the context. With the extension enabled, the texture could still be alive when both context and its' EGL::ShareGroup are destroyed. If we have staged updates not yet flushed, the updates will keep the ShareGroupVk bufferpool occupied, causing an error upon ShareGroupVk::onDestroy(). Bug: chromium:1299211 Change-Id: I260de93c3a3099e023e31acbe017803e824459ad Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3495879 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Brandon Schade 6baf1675 2022-03-04T11:04:46 Remove invalid validation check on compressed texture formats Remove the ValidCompressedDimension() check for non-WebGL contexts of compressed formats. This is because compressed texture images can have dimensions that are neither multiples of four nor small values like one or two. Test: gtest_filter=*DXT1CompressedTextureTest.NonBlockSizesMipLevels* Bug: angleproject:7099 Change-Id: Ic86c15dd3187ffab0665f6db21434fffcbe04fef Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3526017 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Brandon Schade <b.schade@samsung.com>
Charlie Lao d4ddd0c1 2022-03-10T16:31:00 Vulkan: Handle the case where the bound buffer is empty If vertex attribute is enabled and buffer is bound, but buffer size is 0, we should not crash. This CL skips mapImpl and data copy all together if size is 0 to avoid crash when calling mapImpl while buffer is invalid. This CL also added a test for this. Bug: chromium:1296467 Change-Id: I79af348f133e1d3b4427f044e370652d0875dc91 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3516700 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Lubosz Sarnecki 70af5ff0 2022-02-18T14:35:59 FrameCapture: Skip invalid VertexAttribPointer calls in MEC. In CaptureVertexArrayState when a non-default VAO is bound and no GL_ARRAY_BUFFER is bound, VertexAttribPointer calls with a non-null offset are invalid and will produce: "Client data cannot be used with a non-default vertex array object." Add a test that leaves a vertex array with an invalid vertex attribute pointer and used to produce an invalid trace with MEC. Test: angle_end2end_tests --gtest_filter="VertexAttributeTestES3.InvalidAttribPointer/*" Bug: angleproject:7042 Bug: angleproject:7098 Change-Id: Iaf91fe7f191c44df79db47bb5455e5df922f2ed5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3475353 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Antonio Caggiano 0c272c67 2022-03-15T15:42:39 Vulkan: VkFormat/DrmFourCC Add functions to perform a lossy conversion from VkFormat to DrmFourCC and to convert a VkFormat to one or more DrmFourCC formats. Compilation only happens when Vulkan is actually enabled. Bug: angleproject:7065 Change-Id: I97c4585b9032e1ff4f773c3c427541bf7f6117fe Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3525754 Auto-Submit: Antonio Caggiano <antonio.caggiano@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 2397b5fe 2022-03-15T10:17:36 Vulkan: Temporarily suppress 3 perf counter tests on P6. Bug: angleproject:7096 Change-Id: I63ce1773282ac79ee9c0656b32715182d2e89d92 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3525814 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 0f2482ff 2022-03-15T14:09:11 Revert "Vulkan: VkFormat/DrmFourCC" This reverts commit daef95775f7b6dc3bdb0a40662fcb36b68ebf501. Reason for revert: Breaking roll into Skia due to missing Vk headers. Original change's description: > Vulkan: VkFormat/DrmFourCC > > Add functions to perform a lossy conversion from VkFormat to DrmFourCC > and to convert a VkFormat to one or more DrmFourCC formats. > > Bug: angleproject:7065 > Change-Id: Iecccea6a89fbf8adeb50c3cb0c737ad3aedf7c62 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3495123 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Auto-Submit: Antonio Caggiano <antonio.caggiano@collabora.com> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Jamie Madill <jmadill@chromium.org> Bug: angleproject:7065 Change-Id: I7cbad4277929717c211f70435cd6e462f11e4bda No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3525813 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Alexey Knyazev d1415517 2022-03-15T06:45:23 Skip no-op base instance draw calls Bug: angleproject:3402 Change-Id: I90f17307efb98934b1faf44f2efbdbcfa4db9e0c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3524342 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Alexey Knyazev b9b64b15 2022-03-15T06:31:32 Fix typo in DrawElementsInstancedBaseVertexBaseInstanceANGLE Bug: angleproject:3402 Change-Id: I490695e45b4bec31ea9226c6a7df4d426759c53f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3524341 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
angle-autoroll dffc9077 2022-03-15T08:02:57 Roll Chromium from ffa866a5ae9e to 45902868a797 (562 revisions) https://chromium.googlesource.com/chromium/src.git/+log/ffa866a5ae9e..45902868a797 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/f3187f1c4e..18a1f1939e * buildtools/linux64: git_revision:f27bae882b2178ccc3c24f314c88db9a34118992..git_revision:bd99dbf98cbdefe18a4128189665c5761263bcfb * buildtools/mac: git_revision:f27bae882b2178ccc3c24f314c88db9a34118992..git_revision:bd99dbf98cbdefe18a4128189665c5761263bcfb * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/289d52ce75..a897d0f3f8 * buildtools/win: git_revision:f27bae882b2178ccc3c24f314c88db9a34118992..git_revision:bd99dbf98cbdefe18a4128189665c5761263bcfb * testing: https://chromium.googlesource.com/chromium/src/testing/+log/d5f4353463..8399c3e77d * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..0c2e8d34dd * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c848a4ed33..3481645827 * third_party/r8: ZI5RPjew7GhVFtcZytIe_Sv91Pljm5KmhVan6HWxj8YC..ovozeRSDDfERnEFpDo_WS6OYOcEF7oT1JzGxCSf-g0kC * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/e466446bbc..b0676a1f52 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/407b0016e6..f0753eb065 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/611add37b5..80fc9315e0 No update to Clang. Bug: None Tbr: jmadill@google.com Change-Id: Ie6604b2671f70e61b756ba02430dcd26fefcb27b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3524275 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Brandon Schade 1760ce37 2022-03-03T17:29:12 Add usage of Spirv through glslang build flag Add new build flag angle_use_spirv_gen_through_glslang. If set, angle_enable_spirv_gen_through_glslang is enabled and the generateSPIRVThroughGlslang feature is also enabled. Bug: angleproject:6210 Change-Id: I8f4f71c2d01314a36b15fae795caa01a1ffa7fbc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3502529 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Brandon Schade <b.schade@samsung.com>
Kimmo Kinnunen d914e7fb 2022-03-09T16:28:06 Add device id as a part of the key in EGLDisplay cache Otherwise eglGetPlatformDisplay would return displays created with other devices. Bug: angleproject:7087 Change-Id: I6ad3fa03f02892afe43de7e7691fbba17a89d616 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3513753 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org>
Antonio Caggiano daef9577 2022-01-05T19:55:50 Vulkan: VkFormat/DrmFourCC Add functions to perform a lossy conversion from VkFormat to DrmFourCC and to convert a VkFormat to one or more DrmFourCC formats. Bug: angleproject:7065 Change-Id: Iecccea6a89fbf8adeb50c3cb0c737ad3aedf7c62 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3495123 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Antonio Caggiano <antonio.caggiano@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 776c7804 2022-03-14T20:33:54 Roll vulkan-deps from 2d9abfbddc1b to a11411926c31 (18 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/2d9abfbddc1b..a11411926c31 Changed dependencies: * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/0b51794f01..565db34cba * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/0741f42738..0ab57c2c42 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/42d5db3f59..a0c7be0505 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/09227446c8..ca222d286f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:7095 Tbr: jmadill@google.com Change-Id: If23f91ac75a1c686c880e9d32a8a5c794772cd1f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3523741 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 708ce9cf 2022-03-14T10:37:31 Fix crash when pausing XFB then deleting a buffer. Fix is to validate XFB buffer bindings even if we're paused. This is undefined behaviour so we can use any non-crashing solution. Bug: chromium:1305190 Change-Id: Ib95404cdb13adbde7f34d6cc77473a8b3cbf1de7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3522283 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Charlie Lao e9d9d933 2022-03-14T09:33:28 Vulkan: Fix another corner case of mCurrentElementArrayBuffer mCurrentElementArrayBuffer is vertex array state. But it gets modified with different draw call parameters. When this changes, we always re-calculate mCurrentElementArrayBuffer. And we have added updateCurrentElementArrayBuffer call at various places where we need to reset mCurrentElementArrayBuffer to back to what bound to vertex array. There is still one more places missing such call, that when a different vertex array is been bound, the new vertex array may still have mCurrentElementArrayBuffer set to the special array for LineLoop. We need to reset it upon it gets bound. This CL also adds a new test case DrawElementsTest.LineLoopTriangles from Steven Noonan. Bug: angleproject:6955 Change-Id: Ida95062b071d25be26e59f886bfe3d61e6886c5c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3522565 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
angle-autoroll c32a6b21 2022-03-14T19:17:30 Roll VK-GL-CTS from f7e842466e0a to 8252a3d3cdd3 (8 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/f7e842466e0a..8252a3d3cdd3 2022-03-14 quic_mnetsch@quicinc.com Merge vk-gl-cts/opengl-cts-4.6.2 into vk-gl-cts/main 2022-03-14 quic_mnetsch@quicinc.com Merge vk-gl-cts/opengl-es-cts-3.2.8 into vk-gl-cts/main 2022-03-10 rgarcia@igalia.com Avoid logging to stdout in buffer mem requirements tests 2022-03-10 jbolz@nvidia.com Fix fragment_shader_interlock vs fragment_shading_rate tests 2022-03-10 gleese@broadcom.com Use standard type definitions on all platforms 2022-03-10 gleese@broadcom.com Use common code for robustness2 tests 2022-03-10 jbolz@nvidia.com Add tests to verify compressed texture downloads to non-zero mip levels 2022-03-10 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-bots+autoroll-info@google.com,jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: angle-bots+autoroll-info@google.com,jmadill@google.com Change-Id: Iedc0b649b9a3a0693c70ffbd1da49578e806a16a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3522578 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill 3739a195 2022-03-09T13:56:36 perf tests: Record perf counter metrics. This adds a new command line argument that will allow the user to specify perf counters to record into the test output. Bug: angleproject:4918 Change-Id: Ia7432ff96eadf13ef681f67d2d503d00fd83e06e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3516970 Reviewed-by: Lingfeng Yang <lfy@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 24ad581e 2022-03-14T07:01:02 Roll Chromium from 06a76a17743b to ffa866a5ae9e (297 revisions) https://chromium.googlesource.com/chromium/src.git/+log/06a76a17743b..ffa866a5ae9e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/1eba6a6415..f3187f1c4e * testing: https://chromium.googlesource.com/chromium/src/testing/+log/aa2dfc5ea7..d5f4353463 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..b326cacd0e * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/85bdd6400c..e466446bbc * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/e20b3c33b1..407b0016e6 No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: I01e3d7bf046f9cb9f87a5a3b5cc0a1727076b213 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3521401 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Xu Xing 7eb7596a 2022-03-10T14:32:58 Ensure non float uniform are actively used In mesa, the non float uniforms are optimized out when they are not active. This change ensures the unforms are active. Reference: https://gitlab.freedesktop.org/mesa/mesa/-/issues/6119 Bug: angleproject:7091 Change-Id: Iedff4a4b72a7204348c226778cfe940374632a4a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3515640 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jiajia Qin <jiajia.qin@intel.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 5fe1d628 2022-03-11T10:01:13 Roll SwiftShader from e3d910c94d33 to c27e99245d42 (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/e3d910c94d33..c27e99245d42 2022-03-10 swiftshader.regress@gmail.com Regres: Update test lists @ e3d910c9 2022-03-10 capn@google.com Regres: Include UNSUPPORTED() failures in CI test runs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I20670de10c2bc099b9b9bb469bc78e7d08fb659d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3518756 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 0beb36fb 2022-03-11T07:52:57 Roll Chromium from ceeef8f99b7d to 06a76a17743b (500 revisions) https://chromium.googlesource.com/chromium/src.git/+log/ceeef8f99b7d..06a76a17743b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/e3d8d28103..1eba6a6415 * buildtools/linux64: git_revision:46f94b5a7f5527b5d7ef57271d3e9447a65e22ac..git_revision:f27bae882b2178ccc3c24f314c88db9a34118992 * buildtools/mac: git_revision:46f94b5a7f5527b5d7ef57271d3e9447a65e22ac..git_revision:f27bae882b2178ccc3c24f314c88db9a34118992 * buildtools/win: git_revision:46f94b5a7f5527b5d7ef57271d3e9447a65e22ac..git_revision:f27bae882b2178ccc3c24f314c88db9a34118992 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/4c82f9f99a..aa2dfc5ea7 * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/e6c2b86f92..29766b5d64 * third_party/android_build_tools/bundletool: 2ZcLVDxyRwp8FzpeYLtLT0TfSRweZxvwh1-Kx1jZ_FoC..LoldiQDpZ0uTdAm5EPgZ8hBJ3La2KlTWLuaRxE7eDigC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..271796d312 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/37db69d46c..c848a4ed33 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/548c2354fe..85f3c90818 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/998473d904..e20b3c33b1 * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/da435db089..feb42b9a96 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/5d09be20c0..611add37b5 Clang version changed llvmorg-15-init-3540-g85c53c70:llvmorg-15-init-3677-g8133778d Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/548c2354fed8dba0dbcd5ae6e4ff13b2008b175c..85f3c90818f07e06110dea490d4f7c020027b508/scripts/update.py Bug: None Tbr: yuxinhu@google.com Change-Id: Iae8db71a4f8128ef0808e8ccf101be7149c06fba Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3517894 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao b97aab3f 2022-03-09T17:36:24 Vulkan: resync mCurrentElementArrayBuffer when out of lineloop When glDrawElements is called with GL_UNSIGNED_BYTE type or LineLoop mode, we will internally allocate an element buffer and copy data to it. But when we switch out of that mode, we must re-sync mCurrentElementArrayBuffer to what it should be based on VertexArray buffer binding. This CL fix the bug that we were previously not updating it and end up using the wrong element buffer. Also added three tests: DrawWithSameBufferButDifferentTypes: that uses GL_UNSIGNED_BYTE data and GL_UNSIGNED_SHORT data in the same buffer and switch between these two data types without incurring buffer change. DrawWithSameBufferButDifferentModes: draw line mode followed by triangle without the same element buffer. DrawArraysLineLoopFollowedByDrawElementsTriangle: draw line mode with glDrawArrays and then followed by DrawElements. Bug: chromium:1299261 Change-Id: I5c471117d300e9fac9127a9d8fa66d48ac312f03 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3513553 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Jamie Madill 1cfbe863 2022-03-09T13:35:44 perf tests: Report multiple time metrics. We can now report cpu/wall/gpu time instead of just a single timing metric. This is in preparation for reporting other types of metric including counters. Also includes some other minor script improvements. Bug: angleproject:4918 Change-Id: I52a3241893c56a1bfe982990ebac0fa168dbac51 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3516969 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Geoff Lang 6404be2d 2022-03-10T11:04:22 Emulate RGB10 (no alpha) on desktop OpenGL. The OpenGL ES extension GL_EXT_texture_type_2_10_10_10_REV requires RGB and RGBA formats to be supported but Desktop OpenGL does not support RGB. Emulate it with the existing emulatedAlphaChannel path in TextureGL. Bug: chromium:1300575 Change-Id: I0e6d1044afbc55cf6d4f987cc98b357ff11ff006 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3517346 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Jamie Madill a956162c 2022-03-01T13:05:29 Vulkan: Expose performance counters via extension. This CL rewrites the Vulkan perf counters test to work in the angle_end2end_test suite using the newly exposed AMD extension. Note that we implement only a subset of the extension. Instead of generating monitors and starting/stopping them we simply read back all performance counter data at once using the special montior value "0". The CL also enables these tests on SwiftShader. Bug: angleproject:4918 Change-Id: I5d8f6eecb1ccff448657cbdb65b51a225dfb90c0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3497538 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Gert Wollny af2e0c01 2021-12-13T20:47:25 Capture/Replay: Override GL_HALF_FLOAT type for legacy formats Because GL_HALF_FLOAT and GL_HALF_FLOAT_OES have different values, and the format table created by BuildInternalFormatInfoMap() and queried to obtain the readback format uses GL_HALF_FLOAT_OES for legacy formats, we have to override the type in this case. Bug: angleproject:6333 Change-Id: Ibfdcf2ad80ccfb15872ab441c0f22f0851ffe3f0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3332721 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
angle-autoroll f7474347 2022-03-10T10:01:12 Roll SwiftShader from 3c9e2a377a64 to e3d910c94d33 (4 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/3c9e2a377a64..e3d910c94d33 2022-03-09 sugoi@google.com VK_KHR_shader_integer_dot_product implementation 2022-03-09 sugoi@google.com Use enums of promoted 1.3 extensions 2022-03-09 sugoi@google.com Use VK_EXT_texture_compression_astc_hdr's promoted features 2022-03-09 helo@vewd.com Convert failing assert condition If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I10cb043d24c243930f6ce10d2d9cc9ee84292711 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3515681 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 09b55fbe 2022-03-10T10:01:53 Roll vulkan-deps from 4661f6635ad5 to 2d9abfbddc1b (4 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/4661f6635ad5..2d9abfbddc1b Changed dependencies: * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/f24a0c67fc..42d5db3f59 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/c5705bdcef..09227446c8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: Ic5016a544b8ca35f1788e664a1a7feb59653dca9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3515974 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 7185c19e 2022-03-10T07:02:14 Roll Chromium from 7a1995be961b to ceeef8f99b7d (533 revisions) https://chromium.googlesource.com/chromium/src.git/+log/7a1995be961b..ceeef8f99b7d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/eced039f51..e3d8d28103 * buildtools/linux64: git_revision:d7c2209cebcfe37f46dba7be4e1a7000ffc342fb..git_revision:46f94b5a7f5527b5d7ef57271d3e9447a65e22ac * buildtools/mac: git_revision:d7c2209cebcfe37f46dba7be4e1a7000ffc342fb..git_revision:46f94b5a7f5527b5d7ef57271d3e9447a65e22ac * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/738dc100c6..289d52ce75 * buildtools/win: git_revision:d7c2209cebcfe37f46dba7be4e1a7000ffc342fb..git_revision:46f94b5a7f5527b5d7ef57271d3e9447a65e22ac * testing: https://chromium.googlesource.com/chromium/src/testing/+log/fbc5b46c4c..4c82f9f99a * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/3f292eb82c..3f6f1caf8d * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..5b79b29052 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8edc960e9a..37db69d46c * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/fc754cb46f..998473d904 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/fe0215ceda..5d09be20c0 No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: If45490a9f7101a77940619c1edd3d21d944e1b79 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3515638 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jeff Vigil 66a5c924 2022-03-08T08:51:12 Remove unused Semaphore::init Bug: angleproject:7086 Change-Id: If7bd40ec7cbfebd3238f6a23aa682a57c14bd22b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3511312 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Antonio Caggiano ab786b21 2022-02-24T15:06:59 Vulkan: Non-mutable DmaBuf images When creating Vulkan images, certain DRM format modifiers can only be used without the mutable format flag. Bug: angleproject:7027 Change-Id: I6d57a4be1c21d30a963b17794aad6806b22acac8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3488048 Auto-Submit: Antonio Caggiano <antonio.caggiano@collabora.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao fe4fa1cb 2022-03-08T11:10:16 Vulkan: Tune pruneEmptyBuffers() to be a bit more aggressive Right now we check every second and if we find a buffer is empty and remains empty for 4 checks, we free the buffer. This means we may keep peak memory usage for 4 seconds. This CL reduces the check to 1/4 seconds, so that a buffer will gets freed if not used for 1 second. Also added a threshold to keep maximum count of empty buffers to 16. This CL also optimizes pruneEmptyBuffers() function to avoid erase calls on each empty buffer block. We set the pointer to null as we free the empty buffer and a new loop is added at the end to remove all null elements at once. Bug: b/223428306 Change-Id: Iff93d6eb404ca22399b26c7adb7efe5c4b87270d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3511311 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Cody Northrop 48c86e1b 2022-03-04T15:38:38 Test: Add Solar Smash trace Test: angle_perftests --gtest_filter="*solar_smash*" Bug: angleproject:7080 Change-Id: Ia47c9fb40c0730b5131deaf81c5eb4fda0f43a04 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3504189 Auto-Submit: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Lubosz Sarnecki <lubosz.sarnecki@collabora.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Mohan Maiya 4cca6b3e 2022-03-08T14:54:02 Early return when rebinding the same buffer, sampler or texture Bug: angleproject:6955 Test: SimpleStateChangeTestES3.BindingSame* Change-Id: If946a7cf534809d21e49138d9f34dcee61a73627 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3029049 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jeff Vigil 2bfec1a2 2022-03-03T08:22:11 Vulkan: Add EGL to VULKAN mapping for BT2020 colorspace Bug: angleproject:7072 Change-Id: I8d79a9ddcc9f0a4946c72821da25d0eda884d4cc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3508166 Reviewed-by: mohan maiya <m.maiya@samsung.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 5e0c51ce 2022-03-09T10:01:53 Roll vulkan-deps from a7a3a6313703 to 4661f6635ad5 (4 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/a7a3a6313703..4661f6635ad5 Changed dependencies: * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/aa18f182eb..2c45218b90 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/6524b598f6..f24a0c67fc * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/078d44e466..795bad232d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: Id16919c87438c803bbce6c7214f5d133c43695b7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3510879 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 6c0a001f 2022-03-09T10:01:11 Roll SwiftShader from fc40ddd2a901 to 3c9e2a377a64 (5 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/fc40ddd2a901..3c9e2a377a64 2022-03-09 capn@google.com Pass the RelaxedPrecision decoration value to all affected instructions 2022-03-09 capn@google.com Support specifying math precision through a template argument 2022-03-09 capn@google.com Improve exp2 accuracy through weight adjustment 2022-03-09 swiftshader.regress@gmail.com Regres: Update test lists @ fc40ddd2 2022-03-08 nicolascapens@google.com Merge changes Id0d4524c,Ife5beff3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I7ba263ce35d735d0ced515b74c24a9c68ae0caac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3511714 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 592954da 2022-03-09T08:21:58 Roll Chromium from 614f751bf536 to 7a1995be961b (475 revisions) https://chromium.googlesource.com/chromium/src.git/+log/614f751bf536..7a1995be961b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/eaff38ed1a..eced039f51 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/a17b48994f..fbc5b46c4c * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..5b79b29052 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9ce8be3339..8edc960e9a * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/aa6909a566..85bdd6400c * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/1d6f62fbd1..fc754cb46f * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/3c34a54fcd..da435db089 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/e59bded5fa..fe0215ceda No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: I5f170a3fffa7d457047baa29fd9bdd790f2f4414 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3512497 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Brandon Schade 2d12b321 2022-03-03T10:42:03 Remove limit on exposeNonConformantExtensionsAndVersions to expose 3.2 Fix an issue where using the feature exposeNonConformantExtensionsAndVersions would still be limited to version 3.1. Remove this restraint when the feature is enabled. Continue to limit version to 3.1 if either it is a WebGL context or Geometry and Tessellation shader support is not present. Bug: angleproject:3647 Change-Id: I17f46756c22d95b39f2fd9ecb2db7ce4de903a2a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3502173 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: mohan maiya <m.maiya@samsung.com> Commit-Queue: Brandon Schade <b.schade@samsung.com>
Jamie Madill 24c641dc 2022-03-01T11:12:38 Add stubs for AMD_performance_monitor. We can piggy-back on this extension to report internal ANGLE performance counters to the ANGLE tests. Includes a minor variable de-duplication in the EP generator. Bug: angleproject:4918 Change-Id: I4a76aea957b423a36a90349643bd50a4e1905849 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3497537 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Gregg Tavares 2764bda9 2022-03-07T15:23:25 Metal: Fix MultisampleResolveTest failure on Vulkan_SwiftShader Bug: angleproject:7081 Change-Id: Ia62ec86431692c6550b642b2d992b883dfa3b43a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3508445 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 7bf08f3c 2022-03-08T10:01:53 Roll vulkan-deps from ac2a0b67e505 to a7a3a6313703 (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/ac2a0b67e505..a7a3a6313703 Changed dependencies: * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/4ec1fb0aa9..0b51794f01 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/0b8426346d..0741f42738 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/89749bc34e..c5705bdcef If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I9a2ed96ef2665cf3b2753b5db007c4011a5d07e6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3509223 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll f2d32f9a 2022-03-08T08:11:57 Roll Chromium from 62518720406c to 614f751bf536 (474 revisions) https://chromium.googlesource.com/chromium/src.git/+log/62518720406c..614f751bf536 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/f37efeddb5..eaff38ed1a * testing: https://chromium.googlesource.com/chromium/src/testing/+log/278ae8528b..a17b48994f * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/4a57e9eac2..3f292eb82c * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/0d28d3589a..05fa71af3a * third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/4a6d53b8f7..5320e6281a * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..34063a860c * third_party/libjpeg_turbo: https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/02959c3ee1..22f1a22c99 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/1f05f8edb2..548c2354fe * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/94def6cfc4..1d6f62fbd1 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/863a9e517b..e59bded5fa Clang version changed llvmorg-15-init-1995-g5bec1ea7:llvmorg-15-init-3540-g85c53c70 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/1f05f8edb265a2fda9c8a862b48170f3958a9ebd..548c2354fed8dba0dbcd5ae6e4ff13b2008b175c/scripts/update.py Bug: None Tbr: yuxinhu@google.com Change-Id: If40e6fbc26401c68e179f4ea36b6e2c23857a0bb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3509222 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gregg Tavares 74f32702 2022-03-03T13:13:34 Metal: Fix for mulitsampled buffers losing their contents Fixes tst included as well as WebGL CTS https://www.khronos.org/registry/webgl/sdk/tests/conformance2/renderbuffers/multisample-draws-between-blits.html Both fail on M1 without this fix. Also fixes WebKit bug https://bugs.webkit.org/show_bug.cgi?id=237113 Bug: angleproject:7073 Change-Id: Id7baa2575c817561f8a0a99181c986b758376a8d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3506089 Reviewed-by: Kyle Piddington <kpiddington@apple.com> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Gregg Tavares <gman@chromium.org>
Jamie Madill ea70300b 2022-03-01T14:55:00 Fix base level changes not updating FBO completeness check. Bug: chromium:1299264 Change-Id: I0881a4916c3eeb9ee023d28d207795899417d530 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3498282 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Auto-Submit: Jamie Madill <jmadill@chromium.org>
Antonio Caggiano 47977b0e 2022-03-01T15:24:51 EGL: Validate and implement dmabuf extensions Add validation and default implementation of dmabuf extensions. Actual implementation should be defined by concrete Display subclasses. Bug: angleproject:7065 Change-Id: Ie8d7081f7bcb065c809a52a42abdb7af0e75c816 Signed-off-by: Antonio Caggiano <antonio.caggiano@collabora.com> Signed-off-by: Constantine Shablya <constantine.shablya@collabora.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3497840 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 53eb7671 2022-03-07T10:53:53 Roll vulkan-deps from e572921329ff to ac2a0b67e505 (9 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/e572921329ff..ac2a0b67e505 Changed dependencies: * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/6c7a40822f..4ec1fb0aa9 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f56726a323..0b8426346d * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/a4fb0b36cf..6524b598f6 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/78684b1a0b..89749bc34e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: I717ddba1b3c26ea2d9fd93d76e94ea4add1e5ec4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3506091 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 4b1d67fd 2022-03-07T10:01:11 Roll SwiftShader from 561264b73b36 to fc40ddd2a901 (3 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/561264b73b36..fc40ddd2a901 2022-03-06 swiftshader.regress@gmail.com Regres: Update test lists @ 60bf3b4c 2022-03-04 swiftshader.regress@gmail.com Regres: Update test lists @ 561264b7 2022-03-04 dvet@google.com Update debug info code to compile with latest LLVM If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: Ifdee9088c66b943679d93dd8679c5462aa7ae459 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3506232 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gregg Tavares 2e7cfa9b 2022-02-22T13:10:12 Metal: Fix WebGL CTS fbomultisample tests failing in Metal These tests were failing in Metal: deqp/functional/gles3/fbomultisample.2_samples.html deqp/functional/gles3/fbomultisample.4_samples.html deqp/functional/gles3/fbomultisample.8_samples.html This CL only fixed the tests failing on AMD. Intel still fails. See: https://anglebug.com/7079 Bug: angleproject:7049 Change-Id: I745672bba2e9b8b1d34c7a81e07410889eddd35f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3482157 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Gregg Tavares <gman@chromium.org>
angle-autoroll e75be480 2022-03-07T07:00:23 Roll Chromium from 46c84f1b0c3f to 62518720406c (527 revisions) https://chromium.googlesource.com/chromium/src.git/+log/46c84f1b0c3f..62518720406c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/ab05046d45..f37efeddb5 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/fca7fc03ce..278ae8528b * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/9892f2d7c2..0d28d3589a * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..34063a860c * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/df1a3c0bb8..9ce8be3339 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/a84f13d03d..94def6cfc4 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/116401e58c..863a9e517b No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: Ia7e8fa6a83493314146821c2598f2a63b8c22c4a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3506086 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Hailin Zhang 36132a26 2022-02-24T10:52:31 Reland "add host cached bit for staging buffer" This is a reland of commit e1af34a6f4fbcdc9bf1da5498f87b6d2aa8b526b Original change's description: > add host cached bit for staging buffer > > bug: b/219974369 > Change-Id: Ia31109839af9cfa5b862b72152f7189c42e48e53 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3488773 > Reviewed-by: Charlie Lao <cclao@google.com> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Jamie Madill <jmadill@chromium.org> bug: b/219974369 Change-Id: If1b69490a9cbe0784972d85d1ceac8d598c68def Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3503997 Reviewed-by: Hailin Zhang <hailinzhang@google.com> Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Antonio Caggiano e67027c2 2022-02-15T17:21:44 Vulkan: Fix DRM format support verification Include VkImageFormatListCreateInfo structure in pNext chains to both support verification and creation functions. Bug: angleproject:7027 Change-Id: I04ba396252c159f4d28dde002b7e07b7194623ab Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3464856 Auto-Submit: Antonio Caggiano <antonio.caggiano@collabora.com> Reviewed-by: Craig Stout <cstout@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov 389707fc 2022-03-04T14:39:33 Capture/Replay: Clarify that capture is disabled by default. https://crrev.com/c/3163360 disabled capture when no vars are specified by changing the ANGLE_CAPTURE_FRAME_END default from 10 to 0. Bug: angleproject:6397 Change-Id: I22efceafa412fabf283542cb05f54a84d308931d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3503699 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Auto-Submit: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Charlie Lao 36ce2646 2022-03-04T11:37:08 Vulkan: Align the size before calling into VMA's allocator The size we saved in BufferSuballocation object may used for vkFlushMappedMemory() call. This will ensure that we save the aligned size to avoid VVL error for unaligned size in that flush call. bug: b/219974369 Change-Id: Iccf3199f43cd346dab80083d5494fbaeee39948f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3504000 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Mohan Maiya f9ade9fb 2022-02-18T15:08:54 Vulkan: Add feature to create pipeline during glLinkProgram Creating the pipeline will trigger the compilation of shaders to byte code thus warming up Vulkan shader caches. Typically most apps call into glLinkPrograms during app loadtime and the goal is to improve cache hit rate and reduce CPU workload during game play. Bug: angleproject:7046 Test: ProgramBinary*CreatePipelineDuringLink* Change-Id: I71351d45a9aa84e220ca38503735e94cff1dcf98 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3478354 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Cody Northrop fa595ac3 2022-03-02T14:51:37 Docs: Update CaptureAndReplay to include Perf tests This CL: * Updates the file list for captures * Remove outdated references to the source contents * Adds a section with steps that allow running your capture on Android via our trace replay harness (angle_perftests) Bug: angleproject:1944 Change-Id: Ied15a8af004681d7b7b626a27b7bdeeee727dd4f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3500905 Reviewed-by: Roman Lavrov <romanl@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Yuxin Hu 1cef917c 2022-03-02T23:50:11 Reland "Remove ImageViewHelper from ResourceUseList" This is a reland of 126e967de3978f0dc4f6cf0fa3f9749366ea39ba Original change's description: > Remove ImageViewHelper from ResourceUseList > > Instead of keeping a dedicated SharedResourceUse mUse for > ImageViewHelper, let ImageViewHelper take ImageHelper.mUse > for lifetime tracking. ImageViewHelper no longer needs to > add its' own mUse in the ResourceUseList through retain() > calls, and this should cut the ResourceUseList size by > almost half. For instance, in the trace aztec_ruins, > the maximum ResourceUseList size before the change is 3643, > and the maximum ResourceUseList size after the change is 1694. > Since ImageViewHelper no longer needs to keep SharedResourceUse > mUse as a class memberWe can remove the inheritance from > Resource class, and make ImageViewHelper simply a NonCopyable class. > Bug: angleproject:6717 > Change-Id: I460e83f5f3c1d6ef9722b9f3c9a5ba9552563cb9 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3449450 > Reviewed-by: Charlie Lao <cclao@google.com> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Yuxin Hu <yuxinhu@google.com> Bug: angleproject:6717 Change-Id: I3aa9785d7dcdc8db82847f1586f8cd7d5c838d7c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3501194 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Jamie Madill ef17f38a 2022-03-01T10:15:26 Vulkan: Add overlay widget for cache key size. Bug: angleproject:6776 Change-Id: I35ab18bc5919129b2decf58d541499f771140e47 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3472754 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Roman Lavrov bf3cdca5 2022-03-04T11:46:16 Capture/Replay: Mark two more tests as flaky. TransformFeedbackTest.BufferOutOfMemory VertexAttributeTestES3.DrawWithUnalignedData Flaked on win-trace. Bug: angleproject:6180 Bug: angleproject:7076 Change-Id: I75f3ca2468f2802cb3809340f32c064d56438c65 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3503693 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill ee96a461 2022-02-22T12:23:06 Vulkan: Fix missing empty buffer descriptor. This could happen for SSBOs and UBOs when the shader renders without a bound buffer, and robustness enabled. Bug: angleproject:6707 Change-Id: I993f2489aca47f07068908858c83afa78c9e0402 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3484979 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Auto-Submit: Jamie Madill <jmadill@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Lubosz Sarnecki 61e0c319 2022-03-04T15:39:40 Tests: Add Fire Emblem Heroes trace. Test: angle_perftests --gtest_filter="*fire_emblem_heroes*" Bug: angleproject:7077 Change-Id: I1121cca8bab51bb9a820215f7526a88e8b28e51d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3501893 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
angle-autoroll 31e739d6 2022-03-04T16:11:30 Roll VK-GL-CTS from 2328c3fcf88d to f7e842466e0a (5 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/2328c3fcf88d..f7e842466e0a 2022-03-04 quic_mnetsch@quicinc.com Merge "Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/main" into main 2022-03-03 siglesias@igalia.com Add a check that drmFormatModifierTilingFeatures has at least one bit set 2022-03-03 rgarcia@igalia.com Test primitive ID is not affected by culling 2022-03-03 antto.makinen@siru.fi Verify Depth/Stencil Write conditions 2022-03-03 quic_mnetsch@quicinc.com Merge vk-gl-cts/opengl-cts-4.6.2 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-bots+autoroll-info@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: angle-bots+autoroll-info@google.com,romanl@google.com Change-Id: I90b971c39b628e8c419768c9e2490fdca7258fe4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3498547 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 91dce104 2022-03-04T14:39:58 Roll Chromium from e2a60c1d35cf to 46c84f1b0c3f (1077 revisions) https://chromium.googlesource.com/chromium/src.git/+log/e2a60c1d35cf..46c84f1b0c3f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC romanl@google.com,jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/e795961f78..ab05046d45 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/893aa038dd..113dd1badb * testing: https://chromium.googlesource.com/chromium/src/testing/+log/dd7b891b7a..fca7fc03ce * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/a13888fac0..4a57e9eac2 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/060e35fe22..9892f2d7c2 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..10d8471fc7 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1c22c511d0..df1a3c0bb8 * third_party/r8: cEv1yyfxfmP_MaZrG22cR7YPc7hehgHAZd82lRx0DFAC..ZI5RPjew7GhVFtcZytIe_Sv91Pljm5KmhVan6HWxj8YC * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/aa5ea608a4..aa6909a566 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/3a67a5003b..1f05f8edb2 * tools/luci-go: git_revision:a1616e207f0d9c24beefe848ee899b7a73efcb70..git_revision:cb424e70e75136736a86359ef070aa96425fe7a3 * tools/luci-go: git_revision:a1616e207f0d9c24beefe848ee899b7a73efcb70..git_revision:cb424e70e75136736a86359ef070aa96425fe7a3 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/f2517d8f97..a84f13d03d * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/a7f0df865f..116401e58c * tools/skia_goldctl/linux: eZ3k373CYgRxlu4JKph6e-_7xkP02swy_jePFFMiyIQC..wjKDZ5vJELJ_j3O037nIWhBEMF0cY4Y1g4tLc47hPJoC * tools/skia_goldctl/mac_amd64: nHUjLIViYsLxRjv-zDdmzqT8p1R3VoyHq5gdGkKeMYwC..jw5QK1qcTGSBr-yjH0d-9F_MNeq6e5_5aWLq_oGWy0QC * tools/skia_goldctl/mac_arm64: -mc865SGfJAqreLZM6fkn8tgCJ7u5QLk5zm7r-ZRJ9gC..o4BSMT1hKtY4T4VBfANeSm-NuhxoxPYUp3lF0EpoUvMC * tools/skia_goldctl/win: iEqqRADI7znrc6pG-MVnc5pBZwD25koILREPC6x2AFAC..Vg04A_bOadtB2ljbA9DGKe69_Uc6pmX5mk_ABoO2R3EC No update to Clang. Bug: None Tbr: romanl@google.com,jmadill@google.com Change-Id: I8e53918f24745f5c51c4c4c5d5468bdedc8f003f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3503714 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Jamie Madill e14a20e3 2022-03-04T15:05:07 Revert "add host cached bit for staging buffer" This reverts commit e1af34a6f4fbcdc9bf1da5498f87b6d2aa8b526b. Reason for revert: Causes VVL error on Pixel 6: https://ci.chromium.org/ui/p/angle/builders/ci/android-arm64-exp-test/237/overview Original change's description: > add host cached bit for staging buffer > > bug: b/219974369 > Change-Id: Ia31109839af9cfa5b862b72152f7189c42e48e53 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3488773 > Reviewed-by: Charlie Lao <cclao@google.com> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Jamie Madill <jmadill@chromium.org> Change-Id: Ie91fe94471f48ac880c6470c69ac5e7746c603c9 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3503690 Auto-Submit: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 0b5485c5 2022-03-04T08:26:06 Call generate_test_spec_json with vpython3. Bug: chromium:1302648 Change-Id: If071d8f98b28b0dc3d279d35abd2cecde0976a58 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3503688 Reviewed-by: Jamie Madill <jmadill@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill d9002eef 2022-03-01T16:14:47 Protect against deleting a current XFB buffer. Bug: chromium:1295411 Change-Id: I097f272c38e444e0af71aa55c0dc508a07aa0bd3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3498262 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 8f9dac58 2022-03-04T10:01:12 Roll SwiftShader from 7089ef18891d to 561264b73b36 (7 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/7089ef18891d..561264b73b36 2022-03-04 capn@google.com Remove explicit broadcasts of constants in fragment operations 2022-03-03 capn@google.com Fix obtaining the RelaxedPrecision decoration from the result ID 2022-03-03 natsu@google.com Support VK_FORMAT_G10X6_B10X6R10X6_2PLANE_420_UNORM_3PACK16 2022-03-03 dvet@google.com Update googletest submodule to release-1.11.0 2022-03-03 capn@google.com Benchmark mediump GLSL.std.450 instructions 2022-03-03 capn@google.com Simplify obtaining SPIR-V decorations 2022-03-03 capn@google.com Remove duplicate transcendental functions If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: Ieca176e79636e225e2c6950ef7864ec093ca9411 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3499034 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 75422a63 2022-03-04T10:01:53 Roll vulkan-deps from a30aef1d7967 to e572921329ff (5 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/a30aef1d7967..e572921329ff Changed dependencies: * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/2ce1e5c140..6c7a40822f * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/d18d0d92e5..f56726a323 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/2f61d0d86c..78684b1a0b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: I9f45d4bd1895ff6c382639e6189422a515acd41d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3503448 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao b72718d2 2022-02-22T16:18:45 Vulkan: Fix the data race for mUse from two threads A data race of mUse object between two threads can occur with the following sequences: 1) You use the buffer in the context, it adds into mResourceUseList 2) You release the buffer. Now it goes into mGarbageList, even though it is still in the mResourceUseList. Now this mUse object has references from two lists, the mGarbageList and mResourceUseList, and they do not use the same mutex lock. This means the race could happen and corrupt the mUse data. The same thing could happen with ImageHelper object as well. This quick fix also grabs mGrabageMutex while processing mResourceUseList. This CL creates a new garbage list to hold garbage that has not been submitted to vulkan. And this list will only accessed from submission thread and with mGarbageMutex lock held. The advantage of this is that mSharedGarbage will only have objects that already submitted, which means it is in FIFO order so that we can break out the loop as soon as we see an uncompleted garbage. This bug was exposed by MultithreadingTest.MultiContextClear/ES3_Vulkan_SwiftShader on linux-tsan-test Bug: angleproject:7045 Change-Id: I264c970579aaa53373a61ff067fa0e21eb410ae6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3482158 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Amirali Abdolrashidi 9050cd64 2022-03-01T10:36:19 Add angle_white_box_tests to SwANGLE tests * Added angle_white_box_tests to the following: * swangle_gtests * swangle_non_deqp_slow_gtests * swangle_slow_gtests Bug: angleproject:7074 Change-Id: I703655d1901a6dc660d5e6b5c4044baf0994205d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3499200 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Tomasz Śniatowski 4a4bb07b 2022-03-03T21:56:05 Don't create a string out of a nullptr The code path is already behind an UNREACHABLE(), but having the code return nullptr in a function returning std::string is still UB, and won't compile in C++23. Return an empty string instead. Bug: chromium:1302724 Change-Id: I151d488c4e7e951dcae9f55c142ca49526e3b102 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3502448 Auto-Submit: Tomasz Śniatowski <tsniatowski@vewd.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Hailin Zhang e1af34a6 2022-02-24T10:52:31 add host cached bit for staging buffer bug: b/219974369 Change-Id: Ia31109839af9cfa5b862b72152f7189c42e48e53 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3488773 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
kmx.io     mail     discord kmxgit v0.4.0