kc3-lang/angle

Log

Author Commit Date CI Message
hoonee cho fb648546 2025-02-24T17:20:39 third_party/clspv: Update CLSPV(#1423) The clspv is rebased to the below commit to fix test_vectors vec_align_struct with the spir64/phy_addressing option - 60f822e8 fix LongVectorLoweringPass when removing dead long-vector globals that were lowered. (#1423) As part of that clspv rebase, llvm is rebased to the version used by clspv - 1fd8d3fea53e (HEAD) [mlir] Fix wrong names in LinalgOps and ScalableValueBoundsConstraintSet (#117227) The rebase of LLVM required updates to the GN build files in clspv, appropriate changes are made. * .bc files are pre-builts and they are deviations from upstream. Update of gn files for libclc will be followed in separate patch. Bug: angleproject:383647253 Change-Id: Ia75c1446d47b780000446d521503ebee9a7585fb Signed-off-by: Hoonee Cho <hoonee.cho@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6299711 Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao 9202e05a 2025-02-21T18:42:42 Vulkan: Invalidate the SharedCacheKey when cache gets evicted When descriptorSet cache gets evicted, right now we have a bug that the sharedCacheKey does not gets invalidated. This caused SharedCacheKeyManager always think the sharedCacheKey is valid and the mEmptySlotBits never gets cleared, which leads to mEmptySlotBits growth over time, and increases CPU overhead when walking mEmptySlotBits vector. This CL adds an assertion to ensure that all valid sharedCacheKeys has a corresponding entry in the cache, which means without this CL, some traces and dEQP tests are hitting the assertion. This CL also fixes the bug. Bug: b/384839847 Change-Id: If013443144aceb5d62f67f619074ef831e73653b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6292988 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Tim Van Patten 9592b970 2025-02-21T12:33:57 Move LogFeatureStatus() into overrideFeatures() Both overrideFeatures() and LogFeatureStatus() a looping through the overridden features the same way, with one applying the feature override and the other logging the feature being overridden. Rather than looping twice, build up the feature override log string concurrently in overrideFeatures() and return the string, which can be logged (or not). Bug: b/372694741 Change-Id: I70b06792046fe80057f45cefaf18bdd3d05f1f21 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6288657 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Tim Van Patten <timvp@google.com>
Tim Van Patten 99032263 2024-12-30T16:05:22 Log EGL attribute feature overrides Log the ANGLE feature overrides performed by the EGL attributes when creating a display: * EGL_FEATURE_OVERRIDES_ENABLED_ANGLE * EGL_FEATURE_OVERRIDES_DISABLED_ANGLE These log messages are useful on platforms that override features at runtime using the EGL attributes. For example, when using a configuration file to enable/disable ANGLE features. This results in log messages like: Feature: disableSeparateShaderObjects enabled Bug: b/372694741 Change-Id: I35c374c8ec29e038008224049116cfc3265e70c0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6133778 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll f439541f 2025-02-25T02:01:36 Roll SwiftShader from 2407a54c9b29 to c12c13839d68 (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/2407a54c9b29..c12c13839d68 2025-02-24 swiftshader.regress@gmail.com Regres: Update test lists @ 2407a54c 2025-02-24 dneto@google.com test/kokoro: linux: use cpp-builder instead of radial-build If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I901998c31cf5dfe90f2b3254ed557a0b1941ff65 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6301962 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 67d508d3 2025-02-25T07:00:47 Roll Chromium from 17e7fcbd53ab to 3ba664797d91 (566 revisions) https://chromium.googlesource.com/chromium/src.git/+log/17e7fcbd53ab..3ba664797d91 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/5ae20d9aa6..1cff0029dc * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/eaa072a717..1b5a0e6c51 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/7f5cacb256..359f882b6f * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/04dc59d2c8..2705c6655c * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/39fcf9351a..f85b2cdafd * third_party/android_platform: https://chromium.googlesource.com/chromium/src/third_party/android_platform/+log/c00c3b606a..4727162453 * third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/b84ee3745c..62d56e0f00 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/09f963b5f4..5b10d02d31 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f945c74073..feeac124f2 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/94672e2af4..cdc82e180c * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/7f56829772..feff25d517 * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/4d1b3107e3..fcd44ae4be * third_party/siso/cipd: git_revision:4442c27a02f2b5de389f88be9639e4e638ff761a..git_revision:b146378738dc716f49267d22ed7b7953cdbccecb * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/73ffcd21c3..51e897712d * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/1aabbb2e23..858e0d3059 No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: Icbf31e34a6a162290b007deea7906f3f7e7eefd3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6299941 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amirali Abdolrashidi e2dace71 2025-02-24T19:21:19 Revert "Suppress dEQP ASAN failures" This reverts commit cab0acdf6208e483ac26448de926e3ca0df9dbd1. Reason for revert: The following roll has landed: https://crrev.com/c/6298534 Original change's description: > Suppress dEQP ASAN failures > > These block upgrading Clang to a new version that detects more problems. > > Bug: b/395920316 > Change-Id: Ie07d1fce240741f2572546c86e838f8b16c4950c > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6281031 > Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bug: b/395920316 Change-Id: Ibbb5519a91b9ec95fb4dc74328d6fa28b6e79738 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6299712 Auto-Submit: Amirali Abdolrashidi <abdolrashidi@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Yuxin Hu 25a22dec 2025-02-24T14:32:42 Manual roll VK-GL-CTS from 69ec1790cb7c to ba86fb950043 (18 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/69ec1790cb7c..ba86fb950043 2025-02-21 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-cts-4.6.6 into vk-gl-cts/main 2025-02-21 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.12 into vk-gl-cts/main 2025-02-21 rgarcia@igalia.com Test "remaining array layers" and cube images with HIC 2025-02-21 javed@igalia.com Add coverage for tess shader IO 2025-02-21 marcin.zajac@cognizant.com Complex acceleration structure updates 2025-02-21 jbolz@nvidia.com Add tests for VK_NV_cooperative_vector 2025-02-21 syoussefi@google.com Remove last references to DE_NULL 2025-02-21 abdolrashidi@google.com Fix non-zero offset added to nullptr 2025-02-21 zzoon@igalia.com Vulkan Video Decode: Increase MAX_BOUND_MEMORY 2025-02-21 lionel.g.landwerlin@intel.com Fix incorrect structure type check 2025-02-21 gleese@broadcom.com Fix test data generation for copy tests 2025-02-21 javed@igalia.com Add tests for differing mutable format 2025-02-21 gleese@broadcom.com Stop querying device address from unbound buffers 2025-02-21 scerveau@igalia.com video: rename clip description names 2025-02-21 kamil.goras@mobica.com Add test that redeclaring gl_FragDepth is not permitted in ES 2025-02-21 kamil.goras@mobica.com Fix KHR-GLES31.core.nearest_edge.* tests that fail with EXT_read_format_bgra formats. If BGRA format and type 1_5_5_5 are preffered by device use BGRA_EXT and UNSIGNED_SHORT_1_5_5_5_REV_EXT in ReadPixels and swizzle colors. 2025-02-21 mateusz.bahyrycz@mobica.com Add support for sparse mode for ray tracing utils 2025-02-21 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.1 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: b/398956813 Tbr: yuxinhu@google.com Change-Id: I8d2de8b6f8671b5cf66d6b4210877ca8f187528b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6298534 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Auto-Submit: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Amirali Abdolrashidi e3178f0e 2025-02-24T14:38:36 Add AHB clear tests using glClearTexImage * Add tests to clear AHB images before readback, but using glClearTexImage() instead of using a framebuffer and glClear() * AHBClearAppliedViaClearTexImageBeforeReadBack * AHBTwiceClearViaClearTexImageAppliedBeforeReadBack Bug: b/223456677 Change-Id: Ic5ad2b5202aa24f38dc1783205900a0dab5125f9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6299797 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Tim Van Patten 56b6b628 2025-02-07T16:08:39 renderer_utils: Clean up Clang-tidy warnings Clean up various Clang-tidy warnings in renderer_utils.[cpp|h]. Most of these are around for loops: * Using const references, rather than making copies. * Using range-based for loops. There are other changes related to cleaning up ineffective const qualifiers, unused values, trivial ctors/dtors, etc. Bug: b/372694741 Change-Id: I1c88124a67a3e60537e1d5747603077f1c9cc8d3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6244613 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Amirali Abdolrashidi 91fe334e 2025-02-19T14:07:21 Vulkan: Take stride into account for max buf size * Added LimitToIntAnd() to limit the input value to a certain threshold in addition to the int limit. * Cached the max buffer size limit in the renderer. * mMaxBufferMemorySizeLimit * In vk_caps_utils: Capped the following buffer size-related limits to the maximum memory allocation size: * maxStorageBufferRange * maxTexelBufferElements * maxUniformBufferRange Bug: angleproject:391002353 Test: KHR-GLES31.core.texture_buffer.texture_buffer_max_size KHR-GLES32.core.texture_buffer.texture_buffer_max_size Change-Id: Iee9b13f5440a4f5e6f952e7d2beaf9485f864c2d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6283625 Reviewed-by: mohan maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Shahbaz Youssefi 5775a974 2025-02-21T11:00:05 Vulkan: Fix transition to FORIEGN and back in same submission Image layout transitions are typically automatically handled. In some cases however, the image layout is specifically "finalized". For foreign images, the relevant cases are all about the point in time when the image is being released. When a foreign image's layout is finalized, a barrier is generated to transition it to the FOREIGN queue on submission. Previously, an incorrect assumption was made that after such a point, the VkImage will no longer be used by any commands. This was incorrect because of EGL Images, which let the same VkImage (and ImageHelper) be shared between multiple textures. The following scenario broke that assumption: - Texture is bound to the (foreign) EGL image - Texture is used and deleted * VkImage's transition back to foreign is cached, but not executed - Another texture is bound to the same EGL image - Texture is used * At this point, the texture is re-acquired from foreign, but it wasn't released in the first place! In this change, a vkQueueSubmit is issued after the foreign image's layout is finalized to make sure the transition back to FOREIGN is applied. Bug: angleproject:42263241 Bug: angleproject:42262454 Bug: angleproject:390443243 Bug: chromium:382527242 Change-Id: Ibe3e6d60f282f9fb0eed1deba3325456017c3617 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6292804 Reviewed-by: mohan maiya <m.maiya@samsung.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Alex Dean b47fffc8 2025-02-20T11:11:25 CL/VK: Add rewrite-packed-structs and int8 CLSPV option To support structs with three- and four-component vectors, --rewrite-packed-structs is needed as a CLSPV option. The --int8 option is added to allow shaders to process char buffers. Tests-Passing: OCLCTS.test_vectors vec_align_packed_struct_arr Bug: angleproject:397733768 Change-Id: I98ecc9e82bc599453c27f60737bde752c69decd4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6284137 Reviewed-by: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Xin Yuan 5e056364 2025-02-20T11:38:23 Ignore other attributes when use EGL_CONFIG_ID to choose config Per spec, when use EGL_CONFIG_ID in eglChooseConfig, other attributes should be ignored, so additional attributes should not be inserted in this case. Bug: angleproject:396190956 Change-Id: I1170dc5312a9590c972d81f91e3d2140f2145805 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6262970 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll 2430d519 2025-02-24T10:01:40 Roll vulkan-deps from f489bd52916f to 02cb40cbb578 (13 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/f489bd52916f..02cb40cbb578 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/a80d3b5c505e6541d98003b880ae583bc706bbc9..aafd524577cc90fcdd13a6f0bcbfb929a30ee90f https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/24e67179e2b0c7f9a2945927362c5ab0728e1fa8..809941a4ca137df69dc9c6e8eb456bd70309197c https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/dbe142e8f3a7f11478c2e4741c0d4c4b748fce4b..176fef0bccaba8bdf51de54ab4eed8d5d9aaac77 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/fe7a09b13899c5c77d956fa310286f7a7eb2c4ed..6be00ca9f51c714780cc1d6f537f8bc5650b6204 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/a10e2725f99c333bbc468373159442fe41158039..fc5788170fbe2e29162862bc817357c7fb9a04e4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: Ic16686060887d140d2b1011c5bf40b2ca48b6887 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6296627 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll f4622589 2025-02-24T07:01:58 Roll Chromium from 365dbf46bc08 to 17e7fcbd53ab (816 revisions) https://chromium.googlesource.com/chromium/src.git/+log/365dbf46bc08..17e7fcbd53ab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/530d40d7d3..5ae20d9aa6 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/99bd087289..eaa072a717 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/0d1f0f2d5d..7f5cacb256 * third_party/android_build_tools/error_prone/cipd: BLHCsmBI1vzyXlOtCyA-B4yW3gdbkW5iSjfvfnBjOvcC..nMr_RGT4rigGBhQsXW9PYfo20Zi0ABB1XBIdMvKrtkoC * third_party/android_build_tools/lint/cipd: fgLlp9RaOxtJuuPeWET3B6EvLyGvsuX_b9n9AbFup9IC..9zfe4Uaw-NwRZwOiAl-D_BvgC9wZWqTWAlRyLjUhM04C * third_party/android_build_tools/manifest_merger/cipd: Ff5T4JIhkmgt7xA50Kq8XHnzWaR6mKOwEtxCBXFE5rUC..Zs3uzARJ77tL_Rkbn-4hU-qHip99y98mQPLSeYlAqZsC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/a818d47882..39fcf9351a * third_party/android_platform: https://chromium.googlesource.com/chromium/src/third_party/android_platform/+log/e96dafd97e..c00c3b606a * third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/9ed8f7c020..b84ee3745c * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2259aa1766..f945c74073 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/1a88911caa..94672e2af4 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/e722dac269..7f56829772 * third_party/r8/cipd: 2ChXGrcBJ9WNhFhS069j3L6VMp0jw5xyyPqKhlOqj_sC..a5lzGHzibplY-YfBMiaHgYRnmll4wB1csMwXCzHMoH8C * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/55237f5cfb..73ffcd21c3 * tools/luci-go: git_revision:19861b3a5b37b383e7e9555e11aa43f34d71bd48..git_revision:0cddbdc27507a17134e1e038f938b62d0f509756 * tools/luci-go: git_revision:19861b3a5b37b383e7e9555e11aa43f34d71bd48..git_revision:0cddbdc27507a17134e1e038f938b62d0f509756 * tools/luci-go: git_revision:19861b3a5b37b383e7e9555e11aa43f34d71bd48..git_revision:0cddbdc27507a17134e1e038f938b62d0f509756 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/8e880be2d6..b5b26a8e87 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/ff6b5b7245..1aabbb2e23 No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: Ib59abc755cb1eeeb817f43f1d3be56178bf748ef Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6296625 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao f09a19ce 2025-02-21T17:27:30 OpenCL: Pass bufferPtrOffsets by reference not value enqueueNativeKernel() is passing `const std::vector<size_t> bufferPtrOffsets` by value instead of reference. Changed to pass by reference in this CL. Bug: b/42266859 Change-Id: I337eb62451631297c8f389c9f850ff9ddd2421ec Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6293727 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi db8c86bd 2025-02-22T20:33:31 Vulkan: Disable imageless framebuffers on buggy ARM drivers Bug: chromium:371512561 Change-Id: Ibf8c4ed84a29139afd6d234690d240785656cc06 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6293786 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Solti Ho <solti@google.com> Commit-Queue: Solti Ho <solti@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Robic Sun 34faa3db 2025-02-08T15:17:10 Fix issue that stride setting is incorrect when rotation is true When rotateXY is true, stride should increase or decrease on the Y axis. Bug: angleproject:395131251 Change-Id: I0f5363c9952ccdf0a036499a9f918853eff7cd10 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6242496 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Auto-Submit: Robic Sun <Robic.Sun@arm.com>
Charlie Lao 23df4f26 2025-02-21T10:30:04 Vulkan: Avoid storage grow related copy for mDefaultUniformBlocks mDefaultUniformBlocks.uniformLayout is a std::vector, and my profile on all app traces indicates quite some storage reallocation on this data. This CL reserves enough storage upfront to avoids storage reallocation in LinkTaskVk::initDefaultUniformLayoutMapping(). Bug: b/293297177 Change-Id: If249a373aa3bd1795757d974cbcfce38a153a813 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6288314 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Alexey Knyazev 03de46ef 2025-02-20T00:00:00 Metal: Remove divMatrixScalar polyfills MSL 2.3+ natively supports matrix by scalar division. Bug: angleproject:372169468 Change-Id: I2055ab8cfff01d8a52ddc0de4d5c3bc115271aed Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6289047 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Amirali Abdolrashidi c21e31a1 2025-02-20T17:32:17 Add handling null input to eglGetProcAddress * Modified eglGetProcAddress() so it can handle a null input by returning nullptr. * Added a test for this case: * EGLReadinessCheckTest.GetProcAddressNullInput * Fixed some typos. Bug: angleproject:397720948 Change-Id: If55223b12831649252e2e06e47abaf8d3546c86f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6289249 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Igor Nazarov 323c49a3 2025-02-20T15:44:08 Vulkan: Fix swap optimization after staged clear for MSAA If the MSAA image only had a clear update and the update wasn't going to be applied to the swapchain image, the clear update was accidentally dropped because `flushStagedUpdates` wouldn't see the clear update which is already extracted in `deferredClearValues`. Test: angle_end2end_tests --gtest_filter=EGLSingleBufferTest.StagedClearResolveOnSwap/* Bug: angleproject:382006939 Change-Id: I53ae26eeb8a7f38b7758f86bf97982a90b1990dd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6285627 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Igor Nazarov e5b87adc 2025-02-20T15:32:16 Vulkan: Fix WindowSurfaceVk::hasStagedUpdates w.r.t MSAA The old `hasStagedUpdates()` checked swapchain image for staged updates. However in case of MSAA, staged updates are added to the `mColorImageMS`. Universal solution is to check staged updates on the renderpass image from `mColorRenderTarget`, which will be `mColorImageMS` in case of MSAA surface, and the currently acquired swapchain image otherwise. No automated test is possible, since `glReadPixels()` still works as expected. Other reason is that `ANGLE_VK_TRACE_EVENT_AND_MARKER` before acquire inserts commands into the outside renderpass command buffer causing flush to happen. In other words, the debug marker interfering with the normal ANGLE behavior, so even visual test is not possible. Bug: angleproject:237449314 Change-Id: I237514a640a23a33d894109856711c1eb2dcbb29 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6285626 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>
angle-autoroll eb22e1f8 2025-02-21T11:44:31 Roll vulkan-deps from 126c9b378eb7 to f489bd52916f (18 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/126c9b378eb7..f489bd52916f Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/e66176c3f685b14dfa83882329e5d02f4e027c9b..104bd85d990155f04f050972374a3502b4631830 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/09913f088a1197aba4aefd300a876b2ebbaa3391..54a521dd130ae1b2f38fef79b09515702d135bdd https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/9fa14b91414994e2bf4d9509b8efc8071f154991..a80d3b5c505e6541d98003b880ae583bc706bbc9 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/234c4b7370a8ea3239a214c9e871e4b17c89f4ab..952f776f6573aafbb62ea717d871cd1d6816c387 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/087c22a441e5fb8563516b6b515483898c843242..a10e2725f99c333bbc468373159442fe41158039 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Ifb414ab9bbbd524973d4944854649deb0f1714c5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6288472 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Aurora Zhang 3972cfa1 2025-02-18T19:52:06 YUV should support on all the shader stages * The spec requires all shader stages should support YUV. Therefore, move YUV related functions out of the switch. * Add a new end2end test that sampling YUV in the vertex shader. Bug: angleproject:391919465 Change-Id: I7811d419d5f1461c2499c522a902c3b2149289a1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6263325 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Aurora Zhang ba174a76 2025-02-19T16:35:15 Vulkan: Bugfix for nullColorAttachmentWithExternalFormatResolve When nullColorAttachmentWithExternalFormatResolve is VK_TRUE, * The imageView in VkRenderingAttachmentInfo for dynamic rendering should be VK_NULL_HANDLE. * Push YUV resolveImageView as if it is the color attachment to ensure the coherency between ops, clearValues and attachmentViews for both dynamic rendering and render pass objects. Then pack the YUV resolve information first as well. * Add end2end tests that render and clear YUV with a depth attachment. Bug: angleproject:395212980 Change-Id: I8b6173b41723ed7dc12359e181791fb1ac22fc41 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6262510 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Igor Nazarov 03bdf1ca 2025-02-18T16:37:49 Vulkan: Use correct actual FormatID for MSAA swapchain image Implementation of "overrideSurfaceFormatRGB8ToRGBA8" feature missed updating actual FormatID for the MSAA swapchain image. This bug makes possible to initialize RGBA8 swapchain image and RGB8 MSAA image. However, on practice MSAA is still RGBA8 because RGB8 renderable is generally emulated on Android. VUID-vkCmdResolveImage-srcImage-01386: srcImage and dstImage must have been created with the same image format. This fix is cosmetic and is not expected to fix any real bugs (because RGB8 is generally emulated with RGBA8). Bug: angleproject:42265147 Change-Id: Ief4b74ac31e93a655f5088b7927e970585255f25 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6275968 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>
Alexey Knyazev f9566385 2025-02-06T00:00:00 Fix GetBooleani_v validation That entrypoint must require OpenGL ES 3.1. Fixed: angleproject:394610814 Change-Id: I9ee80d1497afadfdc0d714e49bb97b741ad57b63 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6243878 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
angle-autoroll 8d21acb3 2025-02-21T02:01:31 Roll SwiftShader from d7ed113c66ec to 2407a54c9b29 (3 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/d7ed113c66ec..2407a54c9b29 2025-02-20 natsu@google.com Fix LLVM's AlignOf after previous change to support c++23 2025-02-20 tikuta@google.com Add missing include headers 2025-02-20 dneto@google.com kokoro: Use streamlined image for check_style If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I58ecd3186cc48e489c64cfdaf4d78cef8d1489ad Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6290599 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 8b4c42fe 2025-02-21T07:01:01 Roll Chromium from 8fcb1d1f64ae to 365dbf46bc08 (522 revisions) https://chromium.googlesource.com/chromium/src.git/+log/8fcb1d1f64ae..365dbf46bc08 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/e42ba23e14..530d40d7d3 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/d1ed719a33..99bd087289 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/75065cfcbb..0d1f0f2d5d * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/30345af7ee..09f963b5f4 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ab387d1ddc..2259aa1766 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/e36be6784f..1a88911caa * third_party/r8/cipd: QDwsH_fhjzc4w9ejy5IKJrAl9g6ct71e1UJiFwGoqYMC..2ChXGrcBJ9WNhFhS069j3L6VMp0jw5xyyPqKhlOqj_sC * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/ca9f905839..4d1b3107e3 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/1bc9dfc738..7d5d00ed00 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/a6615a458d..55237f5cfb * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/810ed5860b..ff6b5b7245 No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: I58343fe5d873e4e99e54ddb74a5b1e5a4491345f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6288470 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Chris Dalton be98f841 2024-11-30T02:11:05 Implicitly end PLS for framebuffer reads and writes In preparation for removing the PLS allow list, convert more problematic methods to the new paradigm of implicitly ending PLS instead of generating errors. Also simplify the disable logic for framebuffer modifications, and just blindly disable PLS for framebuffer updates, regardless of whether it's GL_READ_FRAMEBUFFER or GL_DRAW_FRAMEBUFFER. Bug: angleproject:40096838 Change-Id: Ie4390a219f5f05ef0a3d00f405d4914592726283 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6077335 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao 8f8b41e3 2025-02-14T17:54:51 Vulkan: Optimize for multiple TexSubImage calls in the same level Based on app traces, some apps make glTexSubImage call for the same level multiple times in a row. One extreme example is lumino_city, which it creates a 2D texture with nullptr data, and then calls glTexSubImage2D many times back to back for each row of the texture to update the data. Because we uses std::vector to store the per level update struct (SubresourceUpdate), it means we copy these data structures every time it grows 2x, until it hit the max size 1081. The other common case we get into is app update some area of the texture (like google map and gacha_life) which also end up with a few texSubImage calls back to back. The other more common case is we staged a clear first and then glTexSubImage which end up with vector size of 2. This CL changes to use std::deque instead of std::vector to store the staged update for a given level, which allows it to grow without extra penalty. Bug: b/293297177 Change-Id: Iabbc143074ad9d6fcf47abbddee09ecf7f78d1a7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6271964 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Charlie Lao c96844d9 2025-02-14T10:26:25 Vulkan: More vector storage fix BufferPool::mBufferBlocks reserves 32 entry storage based on data gathered from trace. BufferPool::mEmptyBufferBlocks switched to queue since we almost never walk the entire list unless it gets destroyed. Renderer::CollectGarbage is changed to take only one object. The only time it get called with more than one object is from ImageHelper::releaseImage(), which in this CL we now creates and pass GarbageObjects to Renderer::collectGarbage directly. This also allows me to delete recursive CollectGarbage() and DestroyGarbage() functions (which is doing emplace_back quite often, even though only two entries). PipelineHelper::mTransitions is updated to reserve storage for 8 entries based on trace data. Bug: b/293297177 Change-Id: I3e4552939a780dd26f9b7b8a67deee0d52d4f9bc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6270518 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
angle-autoroll bd643a1a 2025-02-19T12:16:50 Roll vulkan-deps from 2a09ac22553e to 126c9b378eb7 (19 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/2a09ac22553e..126c9b378eb7 Manual suppression for new VVL error: SYNC-HAZARD-READ-AFTER-WRITE for vkCmdDrawIndexed Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/ef5207f9f8cce5097568efb15d3297d8b5d13014..e66176c3f685b14dfa83882329e5d02f4e027c9b https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/0ed717a810d28e7533d935a7c0017f6d267a8671..c98e976b567735776a4dc692bc744231dae4b13a https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/fde0f9718bd60b49cf8efc80d3fb7a093c309ac0..24e67179e2b0c7f9a2945927362c5ab0728e1fa8 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/a9f88a232a4cd6634e47f0f93c8fac5789387a7a..dbe142e8f3a7f11478c2e4741c0d4c4b748fce4b https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/e3b763ef7c17f7fd6d21a7ffe4069b0e1b45469b..087c22a441e5fb8563516b6b515483898c843242 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: b/397775556 Tbr: cnorthrop@google.com Change-Id: I8a22df0dd3b8238abc1c9c6998604d9f20a3a6c2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6280153 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Neil Zhang f974ffa8 2025-01-27T11:06:30 Vulkan: Add stubs for expose VK_KHR_swapchain_mutable_format Bug: angleproject:386688871 Change-Id: I77a45e342ee46f65c4f2947071c713f914a937a2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6196939 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov 22dfe435 2025-02-20T06:46:07 Revert "Add GL_BGRA_EXT as a sized renderable format" This reverts commit 80093a7d8f850c3ab551ddb4972c2f1f27511433. Reason for revert: suspect for blocking rolling ANGLE into Chroimum https://chromium-review.googlesource.com/c/chromium/src/+/6283973 https://ci.chromium.org/ui/p/chromium/builders/try/chromeos-amd64-generic-rel-gtest/372754/overview Original change's description: > Add GL_BGRA_EXT as a sized renderable format > > dEQP tests were updated to cover GL_BGRA_EXT as a sized renderable > format. It was apparently always supposed to be, based on the > wording of the spec. > > This CL adds that support and updates expectations, along with a few > extra tests. > > Includes contributions from Robic.Sun@arm.com. > > Test: angle_end2end_tests, angle_deqp_*_tests > Bug: b/42267264 > Bug: angleproject:394384906 > Change-Id: Ia10bcd61f66c5d99a3d27a2cfd6008c991ddcaa7 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6235444 > Reviewed-by: Geoff Lang <geofflang@chromium.org> > Commit-Queue: Cody Northrop <cnorthrop@google.com> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Bug: b/42267264 Bug: angleproject:394384906 Change-Id: I64572361cfed33b4ea17eabf278f580471d045c2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6285628 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 7d577447 2025-02-20T10:56:18 Manual roll Chromium from c3ce5b627f8f to 8fcb1d1f64ae (66 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/chromium/src.git/+log/c3ce5b627f8f..8fcb1d1f64ae If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * testing: https://chromium.googlesource.com/chromium/src/testing/+log/236a573eb2..75065cfcbb * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/b05ea6f335..62e217a12e * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/99782c3117..e722dac269 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/e7ca9835dd..a6615a458d * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/6bc9879f04..810ed5860b No update to Clang. Bug: None Tbr: cnorthrop@google.com,ynovikov@google.com Change-Id: I6cad89a625feb0cee3dde865be34bfe2df637012 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6284133 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 2e82883f 2025-02-20T02:01:56 Roll SwiftShader from 720189cae847 to d7ed113c66ec (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/720189cae847..d7ed113c66ec 2025-02-20 dneto@google.com kokoro: fix check-style 2025-02-19 dneto@google.com Fix Python esacpe sequences (presubmit warning) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I1fd82f14d8965d70335ce2a4440285e43ef8678d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6284355 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll e5afe8b2 2025-02-20T07:00:53 Roll Chromium from e496ee581bf7 to c3ce5b627f8f (570 revisions) https://chromium.googlesource.com/chromium/src.git/+log/e496ee581bf7..c3ce5b627f8f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/de88ea082e..e42ba23e14 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/cd6f832f55..236a573eb2 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/cfa9c31cbe..30345af7ee * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ee429f3694..ab387d1ddc * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/d3d825f7b3..e36be6784f * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/d499ef8787..99782c3117 * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/2717bc8be9..ca9f905839 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/a7cdbef5ab..1bc9dfc738 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/aaf0275a08..e7ca9835dd * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/12e1725706..6bc9879f04 * tools/skia_goldctl/linux: BUSKiikgKynZFrvG5LYEzy3rGwyxdF0XCfjXYnJNcVEC..cFP5_MeKETBLhyiZ3wrHD1ei0WT9jfIt4d_zmFFDlL0C * tools/skia_goldctl/mac_amd64: ZsOrg7xgPaaYo156AG7K_MFTx9f-wDEH0q6BFQxUiL0C..9ZKSPWL0BFFJ9i-XXta9akbpsxgQzTvJFPOSLaFXrIgC * tools/skia_goldctl/mac_arm64: csw65C75AJ7kjYY7eVIUUKBqJvrsMzejzZF_e66ZjagC..ocDZkono_-0H7--idWYeYTAFQeO3RVx7ugf5aj4Y4sYC * tools/skia_goldctl/win: C13nP-0qMu6SzC6Sq-P5kaZJ6p4yEykqSj3TnK39NiUC..nkeh5UQvxZz54dBmhgRp3xrCFIEaVW45Smum7g2NkJIC No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: I52486098986f0d4ad25a6cfff8a47ddf24e48464 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6285234 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop 80093a7d 2025-02-03T08:50:21 Add GL_BGRA_EXT as a sized renderable format dEQP tests were updated to cover GL_BGRA_EXT as a sized renderable format. It was apparently always supposed to be, based on the wording of the spec. This CL adds that support and updates expectations, along with a few extra tests. Includes contributions from Robic.Sun@arm.com. Test: angle_end2end_tests, angle_deqp_*_tests Bug: b/42267264 Bug: angleproject:394384906 Change-Id: Ia10bcd61f66c5d99a3d27a2cfd6008c991ddcaa7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6235444 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 6aa46bef 2025-02-19T12:31:10 Manual roll Chromium from 7a15ef98fa46 to e496ee581bf7 (6392 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/chromium/src.git/+log/7a15ef98fa46..e496ee581bf7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/dc7b3561cd..de88ea082e * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/6377d6649b..d1ed719a33 * buildtools/reclient: re_client_version:0.175.0.98046de5-gomaip..re_client_version:0.176.0.8c46330a-gomaip * testing: https://chromium.googlesource.com/chromium/src/testing/+log/8a57c900f4..cd6f832f55 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/9d07d51c6e..04dc59d2c8 * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/3539c64cce..3a5a3b1187 * third_party/android_build_tools/error_prone/cipd: PW_AkPGAdnmLPk-dG161a_wYd9FRhQ9INn9f8HKj3fcC..BLHCsmBI1vzyXlOtCyA-B4yW3gdbkW5iSjfvfnBjOvcC * third_party/android_build_tools/lint/cipd: jsEEMs5gHWH0oWH-A-WwE4Q4a5JnfgwwHYdaNd9UP9oC..fgLlp9RaOxtJuuPeWET3B6EvLyGvsuX_b9n9AbFup9IC * third_party/android_build_tools/manifest_merger/cipd: no0RMx3qPOc-XlBlr8d_hUdnAYnHUeN6-qd2kXZO9e0C..Ff5T4JIhkmgt7xA50Kq8XHnzWaR6mKOwEtxCBXFE5rUC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/e531e94991..a818d47882 * third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/16e8416791..9ed8f7c020 * third_party/android_sdk/public: OCGHZKTdjXjIELVI6FMAgcDkfnd_1ybB0_MtljPtz-8C..bCFMX8oYIRJ_tP3tzaPcTKNqOAVdNk5TV_cwMp3GmE8C * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/d516686190..cfa9c31cbe * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0cc30c3baf..ee429f3694 * third_party/fuchsia-sdk/sdk: version:27.20250130.7.1..version:27.20250207.1.1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/2e25154d49..d3d825f7b3 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/634228a732..94c5d7a8ed * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/e55d8cf51c..b05ea6f335 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/6d0c8ee02e..d499ef8787 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/d8e413be0c..486abb63f2 * third_party/r8/cipd: 8dKduCb-T1CXo1k__TsFWTWKwtx92qcCCIJ8zGP7QaAC..QDwsH_fhjzc4w9ejy5IKJrAl9g6ct71e1UJiFwGoqYMC * third_party/r8/d8/cipd: ukddmPlorF_6XXPBcxDxCmK2PSAJlhu_MDUhZQCz1l8C..a5lzGHzibplY-YfBMiaHgYRnmll4wB1csMwXCzHMoH8C * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/588e69eab2..2717bc8be9 * third_party/siso/cipd: git_revision:0b6159c39573013a79a47f8544200df07a6a74fc..git_revision:4442c27a02f2b5de389f88be9639e4e638ff761a * third_party/turbine/cipd: qNNUfaj7w4cSHTjVawVaZpq0pABVec9LcFebN19wm4EC..iJs7aB4rFWVA7mWGYiFq93N3ME_xpSuyIULTpTxD5Z0C * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/5634698162..788cb3c270 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/d5b1dd58bd..a7cdbef5ab * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/1340d3ed8b..aaf0275a08 * tools/luci-go: git_revision:b408832fea9036895f2767817491be5463ee6b22..git_revision:19861b3a5b37b383e7e9555e11aa43f34d71bd48 * tools/luci-go: git_revision:b408832fea9036895f2767817491be5463ee6b22..git_revision:19861b3a5b37b383e7e9555e11aa43f34d71bd48 * tools/luci-go: git_revision:b408832fea9036895f2767817491be5463ee6b22..git_revision:19861b3a5b37b383e7e9555e11aa43f34d71bd48 * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/8e9b58419b..14089a7f57 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/2ed187cab2..12e1725706 * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/05dbbfdcec..8b154f5837 * tools/skia_goldctl/linux: Djmxg641BIFDuvtwbk4GxAWptW7AWRnqZ5hCffbpETcC..BUSKiikgKynZFrvG5LYEzy3rGwyxdF0XCfjXYnJNcVEC * tools/skia_goldctl/mac_amd64: w4KjkADnVRHE8TgQXpDuP6qD3uivftyQ3ue-Ee-gqWQC..ZsOrg7xgPaaYo156AG7K_MFTx9f-wDEH0q6BFQxUiL0C * tools/skia_goldctl/mac_arm64: 4aUb9UJChUHJebFHC5FjJ5d6Lf7cYuLSEJbco0uC3WEC..csw65C75AJ7kjYY7eVIUUKBqJvrsMzejzZF_e66ZjagC * tools/skia_goldctl/win: Rj9DcPKzbqhsLO2by6iMiqZvlUFzBcSsp42l8nyHD8MC..C13nP-0qMu6SzC6Sq-P5kaZJ6p4yEykqSj3TnK39NiUC * tools/valgrind: https://chromium.googlesource.com/chromium/src/tools/valgrind/+log/aa44e7637f..6e97bd1a16 Clang version changed llvmorg-20-init-17108-g29ed6000:llvmorg-21-init-1655-g7b473dfe Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/1340d3ed8bae85ab0e8410c4439289dde1d3fea6..aaf0275a0825a4fdf7033c559b239e33aaf3d5fc/scripts/update.py Bug: angleproject:389733590 Tbr: cnorthrop@google.com,ynovikov@google.com Change-Id: Ib767a0354172f7234c64a55c1e09cfdf66da0d6f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6281465 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Igor Nazarov 4eed3a0c 2025-02-18T20:57:38 Vulkan: Remove EGL_WIDTH/HEIGHT from WindowSurfaceVk initialize The EGL_WIDTH and EGL_HEIGHT are only applicable when "EGL_ANGLE_window_fixed_size" is supported, which is currently only exposed by D3D backends. Bug: angleproject:40096349 Change-Id: I45886185d4740804709f274b70b73728b2a2e59d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6276201 Commit-Queue: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Mohan Maiya 91d0c56b 2025-02-18T20:00:00 Vulkan: Disable support for GL_EXT_YUV_target ... on vendors that don't have support for nullColorAttachmentWithExternalFormatResolve Bug: angleproject:386749841 Change-Id: I3437bf189bdfb40cba760143a442df13d6ebf8dc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6277811 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Yuly Novikov cab0acdf 2025-02-19T16:22:07 Suppress dEQP ASAN failures These block upgrading Clang to a new version that detects more problems. Bug: b/395920316 Change-Id: Ie07d1fce240741f2572546c86e838f8b16c4950c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6281031 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Mohan Maiya 0f969b98 2025-02-18T07:48:03 Vulkan: Disable dynamic rendering for Samsung Enable VK_KHR_maintenance5 iff VK_KHR_dynamic_rendering is enabled Bug: angleproject:386749841 Change-Id: I60f949b2454dd43599516f051fa51f7378513cf5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6267100 Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com>
Austin Annestrand d5a0d83a 2025-02-14T15:47:06 CL/VK: Fix addMemoryDependencies RAW barrier Additionally, remove unused barrier insertion code in processKernelResources(). Bug: angleproject:380188569 Change-Id: Id9f330410eecf45f94fe77bf072cf6601bd2a9e2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6271135 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Gowtham Tammana 8c0ac979 2024-06-20T16:39:26 Vulkan: Setup compute only queue for OpenCL Select compute only for OpenCL vulkan backend if `angle_enable_cl_compute_only_pipe` is set to true in gn args. And setting it as default for OpenCL. Bug: angleproject:395045928 Change-Id: Ie1a53e629646dbd5ba332dd297a4c8b737070e95 Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6244610 Reviewed-by: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop e7833a01 2025-02-19T06:38:36 Reland "Remove use of is_chromeos_lacros" This reverts commit 80b55daa99c0170d0dc3f87a68b63ef51561233a. Reason for revert: Did not stabilize CI Original change's description: > Revert "Remove use of is_chromeos_lacros" > > This reverts commit 8dda514cb833c0c8392a4521f6d15454a053ebf7. > > Reason for revert: Possible cause of chromium CI failures like: > https://ci.chromium.org/ui/p/chromium/builders/try/linux-angle-chromium-try/27421/overview > > Original change's description: > > Remove use of is_chromeos_lacros > > > > Lacros is gone and this condition is always false. > > > > Bug: b/354842935 > > Change-Id: I587144eada64bbd6236dff89cce901ee382a481b > > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6275695 > > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> > > Reviewed-by: Yuly Novikov <ynovikov@chromium.org> > > Reviewed-by: Cody Northrop <cnorthrop@google.com> > > Bug: b/354842935 > Change-Id: I4416c6ee4abe20bac65d7f21cbe20325618a67cd > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6278811 > Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> > Reviewed-by: Cody Northrop <cnorthrop@google.com> > Commit-Queue: Cody Northrop <cnorthrop@google.com> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bug: b/354842935 Change-Id: If06fdb3ffe886d665360125a88cf2d8c20df383c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6281466 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Rafay Khurram f102ef02 2025-02-18T18:05:28 CL/Vulkan: Fix handling for NormalizedSamplerMaskPushConstant * Fixes creation of normalized sampler for push constant * CLSamplerVk should check if the sampler has not been created Tests-Passing: OCLCTS.test_image_streams CL_FILTER_NEAREST 3D, OCLCTS.test_image_streams max_images CL_FILTER_NEAREST 3D, OCLCTS.test_image_streams use_pitches CL_FILTER_NEAREST 3D Bug: angleproject:42266936 Change-Id: Ic70c55ad05f4babdd10b516e78a061bdb7aa2488 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6277809 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop 80b55daa 2025-02-18T18:51:12 Revert "Remove use of is_chromeos_lacros" This reverts commit 8dda514cb833c0c8392a4521f6d15454a053ebf7. Reason for revert: Possible cause of chromium CI failures like: https://ci.chromium.org/ui/p/chromium/builders/try/linux-angle-chromium-try/27421/overview Original change's description: > Remove use of is_chromeos_lacros > > Lacros is gone and this condition is always false. > > Bug: b/354842935 > Change-Id: I587144eada64bbd6236dff89cce901ee382a481b > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6275695 > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Yuly Novikov <ynovikov@chromium.org> > Reviewed-by: Cody Northrop <cnorthrop@google.com> Bug: b/354842935 Change-Id: I4416c6ee4abe20bac65d7f21cbe20325618a67cd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6278811 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Liza Burakova bc40362b 2025-02-18T13:24:31 Add line loop emulation for draw arrays Bug: angleproject:383356846 Change-Id: I43f4835e17ecb2401418f77555fd70332612e1bf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6090912 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Liza Burakova <liza@chromium.org> Reviewed-by: Matthew Denton <mpdenton@chromium.org>
Georg Neis 8dda514c 2025-02-18T03:05:40 Remove use of is_chromeos_lacros Lacros is gone and this condition is always false. Bug: b/354842935 Change-Id: I587144eada64bbd6236dff89cce901ee382a481b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6275695 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Yuly Novikov 91deaea3 2025-02-13T13:57:37 Roll third_party/dawn/ 1eca38fa5..8119dbd27 (1982 commits; 30 trivial rolls) https://dawn.googlesource.com/dawn.git/+log/1eca38fa5236..8119dbd27471 $ git log 1eca38fa5..8119dbd27 --date=short --no-merges --format='%ad %ae %s' 2025-02-12 zhuangxu Set MacOS deployment target to 11.0 when building with CMake 2025-02-12 dsinclair Revert "Remove stale WebGPU Compat CTS expectations" 2025-02-12 rharrison [tint][ir][fuzz] Add missing capability to tint::hlsl::writer::IRFuzzer 2025-02-11 shrekshao [Compat] Remove gles min31 end2end suppressions 2025-02-11 shrekshao [Compat] Fix toggle string for UseBlitForRG11B10UfloatTextureCopy 2025-02-11 rharrison [tint][ir][val] Add operand and result checks for MemberBuiltinCall 2025-02-11 rharrison [tint][ir][val] Check InstructionResult->Instruction is inst 2025-02-11 jrprice [node] Support subgroupMatrixConfigs query in dawn.node 2025-02-11 jrprice [vulkan] Enable subgroup matrix feature 2025-02-11 ynovikov Remove stale WebGPU Compat CTS expectations 2025-02-11 ynovikov Remove stale WebGPU CTS expectations 2025-02-11 dawn-autoroll Roll ANGLE from e746fb068fd3 to 19c5293e1347 (5 revisions) 2025-02-11 jrprice [metal] Enable subgroup matrix feature 2025-02-11 jrprice [dawn] Add SubgroupMatrixConfigs to adapter info 2025-02-11 kylechar Skip setting Vulkan object labels 2025-02-11 dsinclair [spirv-reader][ir] Add derivative operations. 2025-02-11 lehoangquyen D3D11: skip waiting on the fence that is owned by the same queue. 2025-02-11 dawn-autoroll Roll vulkan-deps from cd5e835851d1 to a88fd25a6a0d (8 revisions) 2025-02-11 dsinclair [spirv-reader][ir] Cleanup duplicate argument code. 2025-02-11 jrprice [dawn] Add feature for subgroup matrix extension 2025-02-11 dsinclair [spirv-reader][ir] Add support for `OpAny`. 2025-02-11 dsinclair [spirv-reader][ir] Add support for `OpAll` 2025-02-11 dsinclair [spirv-reader][ir] Add support for `OpBitReverse`. 2025-02-11 cwallez [tint] Make type::BindingArray use ArrayCount 2025-02-11 rharrison [tint][ir][val] Add additional checking to builtin calls 2025-02-11 dsinclair [spirv-reader][ir] Support `OpBitFieldUExtract`. 2025-02-11 lehoangquyen D3D11: return error if D3D feature level < 11.0 2025-02-11 shaoboyan Dawn Native: Setup ClampFragDepth offset in Vulkan Backend 2025-02-10 dawn-autoroll Roll ANGLE from c4caed5f649d to e746fb068fd3 (8 revisions) 2025-02-10 gman Compat: Fixup Device Limits 2025-02-10 dsinclair [spirv-reader][ir] Support `OpBitFieldSExtract`. 2025-02-10 dsinclair [spirv-reader][ir] Support `OpBitFieldInsert`. 2025-02-10 brandon1.jones Add Missing Synchronization For D3D12 Shared Buffers 2025-02-10 ynovikov Skip more textureSample tests on WebGPU CTS compat Android 2025-02-10 cwallez [dawn][frontend] Fix error message when @group > maxBindGroups 2025-02-10 dawn-autoroll Roll SwiftShader from 5017ce3c800e to 720189cae847 (1 revision) 2025-02-10 titouan Include tint fuzzers in high-end fuzzer build. 2025-02-10 dsinclair [spirv-reader][ir] Support `OpBitCount`. 2025-02-10 dawn-autoroll Roll ANGLE from 38aa0780bb36 to c4caed5f649d (28 revisions) 2025-02-10 jrprice [spirv] Require Vulkan Memory Model when fuzzing subgroup matrices 2025-02-10 jwata infra: Add project property to $build/siso 2025-02-10 dawn-autoroll Roll vulkan-deps from b4c8dd090b72 to cd5e835851d1 (1 revision) 2025-02-09 ynovikov Skip textureSample tests on WebGPU CTS compat Android 2025-02-09 dawn-autoroll Roll vulkan-deps from dbe0a14ab512 to b4c8dd090b72 (1 revision) 2025-02-08 ynovikov Remove stale WebGPU Compat CTS expectations 2025-02-08 ynovikov Remove stale WebGPU CTS expectations 2025-02-08 ynovikov Generalize Linux NVIDIA WebGPU CTS expectation 2025-02-07 dawn-autoroll Roll vulkan-deps from c32804ca5a39 to dbe0a14ab512 (9 revisions) 2025-02-07 shrekshao [Compat] fix glsl name collisions between stages for handle 2025-02-07 shrekshao Compat suppress min es31 failure tests (...) 2024-08-15 rharrison [tint][ir][val] Improve checks on Returns 2024-08-15 petermcneeley [tint] Minor follow-up fix for insert before 2024-08-15 dawn-autoroll Roll ANGLE from 2003e06230b1 to 83ca89e58cef (6 revisions) 2024-08-15 dsinclair Allow marking expectations as INVALID. 2024-08-15 bsheedy Suppress additional Linux/NVIDIA failures 2024-08-15 chouinard Generate missing hlsl e2e tests 2024-08-15 petermcneeley [tint] MSL texture array negative integer clamp 2024-08-15 dsinclair Remove the CTS cache code 2024-08-15 amaiorano Generated missing tint e2e tests for ir.dxc.hlsl 2024-08-15 jiawei.shao Tint: Add validations on the type of `clip_distances` 2024-08-15 dawn-autoroll Roll ANGLE from 6fddb18d77a3 to 2003e06230b1 (6 revisions) 2024-08-15 jiawei.shao Tint: Add WGSL extension and built-in variable `clip_distances` 2024-08-15 jiawei.shao Remove `DeviceBase::ForceSetToggleForTesting` 2024-08-15 jiawei.shao Rename `BufferBase::GetUsage` and `BufferBase::GetUsageExternalOnly` 2024-08-15 bsheedy Suppress 16" Macbook failures 2024-08-14 rharrison [tint][ir][val] Check swizzles are well formed 2024-08-14 chouinard [tint] Implement quadSwapX, Y and Diagonal 2024-08-14 amaiorano [hlsl] Emit mip level 0 for storage textures 2024-08-14 amaiorano Regen ir.fxc.hlsl files 2024-08-14 jrprice [benchmark] Add --check-stale option 2024-08-14 dawn-autoroll Roll vulkan-deps from c297ee8a1d20 to 7660e21e64db (3 revisions) 2024-08-14 amaiorano Fix DXC roll 2024-08-14 dawn-autoroll Roll ANGLE from 5967afe70699 to 6fddb18d77a3 (3 revisions) 2024-08-14 dneto [tint] validate clamp const low <= const high when first arg is runtime-eval 2024-08-14 chouinard [tint] Implement quadBroadcast 2024-08-14 dawn-autoroll Roll ANGLE from fdd26da99a12 to 5967afe70699 (6 revisions) 2024-08-14 jrprice [benchmark][msl] Flatten bindings 2024-08-14 jrprice [benchmark] Split generated shaders into multiple lines 2024-08-14 jiawei.shao Don't check adapter nullability in the constructor of DeviceBase 2024-08-14 jrprice [benchmark] Generate map directly 2024-08-14 jrprice [benchmark] Convert SPIR-V when generating header 2024-08-14 jrprice [benchmark] Check in the generated header 2024-08-14 jrprice [benchmark] Remove spv_reader and wgsl_writer deps 2024-08-13 enga Add DeviceGetAdapter and AdapterGetInstance to client_side_commands 2024-08-13 jrprice [benchmark] Don't convert SPIR-V to WGSL at init 2024-08-13 rharrison [tint][ir][val] Check disards in validator 2024-08-13 chouinard [tint] Implement subgroupShuffleXor, Up and Down 2024-08-13 senorblanco Fix texture-only arg in combine samplers transform. 2024-08-13 jrprice [spirv] Remove ast_generate_bindings 2024-08-13 dawn-autoroll Roll vulkan-deps from 77d583f37170 to c297ee8a1d20 (3 revisions) 2024-08-13 jrprice [tint] Remove the quantizeToF16 AST polyfill 2024-08-13 jrprice [spirv] Remove AST backend 2024-08-13 jrprice [loopy] Switch to IR version of SPIR-V backend 2024-08-13 shrekshao [Compat] Use @size attribute for glsl pad struct 2024-08-13 jrprice Reland "[tint][benchmark] Generate depfile for inputs" 2024-08-13 jrprice [spirv] Move E2E expectations to default paths 2024-08-13 jrprice [spirv] Remove AST E2E expectations 2024-08-13 jrprice [tint] Only allow --use-ir with WIP IR backends 2024-08-13 dawn-autoroll Roll ANGLE from f8fc8ac36280 to fdd26da99a12 (4 revisions) 2024-08-13 dawn-autoroll Manual roll vulkan-deps from a5d4d42457c3 to 77d583f37170 (8 revisions) Created with: roll-dep third_party/dawn Bug: angleproject:396213611 Change-Id: I124bbd59dccd14d8609c37ef62ccdd4455897b2c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6270256 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Mark Lobodzinski bace6371 2025-02-17T15:14:37 Tests: Add Brotato ANGLE trace Test: angle_trace_tests --gtest_filter=*brotato Bug: b/397185288 Change-Id: I3d89d4b073b56efeede42abf5b0f44f8e9bd221a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6277708 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Takuto Ikuta ba3dcfa4 2025-02-13T17:57:29 Roll third_party/glmark2/src/ cb550a25c..6edcf0220 (2 commits) https://chromium.googlesource.com/external/github.com/glmark2/glmark2/+log/cb550a25c75a..6edcf02205fd $ git log cb550a25c..6edcf0220 --date=short --no-merges --format='%ad %ae %s' 2025-02-12 tikuta Add a missing include for std::copy 2025-01-17 alexandros.frantzis github: Add CI build for dispmanx-glesv2 Created with: roll-dep third_party/glmark2/src Bug: chromium:40263312 Change-Id: I8b64984816cf1439a4573e671f79a48daf532f35 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6263327 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll e0332c86 2025-02-17T10:01:12 Roll vulkan-deps from b62b2ca7025e to 2a09ac22553e (8 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/b62b2ca7025e..2a09ac22553e Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/dc1641d168304d3ef97bba23d5fc45c9bead45f5..9fa14b91414994e2bf4d9509b8efc8071f154991 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/266d5cd69a94c1262c44307f4c4209c97f5c6ec4..e3b763ef7c17f7fd6d21a7ffe4069b0e1b45469b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I4094cc49d026755696c5dd07644de595b37798fd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6275592 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya 51d2561b 2025-01-29T11:11:50 Vulkan: Enable a few features for Samsung Enable the following features for Samsung - 1. enableAdditionalBlendFactorsForDithering 2. forceSampleUsageForAhbBackedImages Bug: angleproject:386749841 Change-Id: I9e822b884ea4e44af38c2d2dd95c67b020b94f98 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6207669 Commit-Queue: mohan maiya <m.maiya@samsung.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
hoonee cho bf9f69fc 2025-02-14T11:57:14 CL/Vulkan: Add support for LiteralSampler The support for LiteralSampler in clspv is enabled through the SPIR-V non-sementic clspv reflection instructions - LiteralSampler [1]. Setting the utility functions to process these instructions. Bug: angleproject:394767574 Change-Id: I47aa03dac050f723d2e3f2a7f9c6c1756e7ac9cf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6239519 Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Austin Annestrand <a.annestrand@samsung.com>
Brian Johnson bef478f5 2025-02-11T10:44:48 Set system settings to A14 until edge to edge is fixed Bug: b/389208485 Change-Id: Ic70cfd7135a5cbc1f14656246835476dadad8034 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6254737 Reviewed-by: Cody Northrop <cnorthrop@google.com> Auto-Submit: Brian Johnson <hibrian@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Charlie Lao 2ba1f129 2025-02-11T15:27:16 Vulkan: Avoid storage reallocation in UpdateDescriptorSetsBuilder UpdateDescriptorSetsBuilder::mDescriptorBufferInfos and mDescriptorImageInfos will keep grow to a few hundreds of entries and that grow will end up with data copy and patching mWriteDescriptorSets. There is no requirement that entire vector of mDescriptorBufferInfos andmDescriptorImageInfos must be continuous. The only requirement is that when allocDescriptorBufferInfos(count) is called, the count of entries must be continuous. This CL uses a queue of vectors so that when we need to allocate new storage we just add another vector and allocate out of the new vector. This avoids all related data copy. Similar thing applies to mWriteDescriptorSets. The only thing I added for mWriteDescriptorSets is that I try to grow the first vector big enough to hold all of the entries for next submission to minimize the vkUpdateDescriptorSets call. Bug: b/293297177 Change-Id: Ief417ace8c8f7b477a1962505e9487bf31bae2ac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6253675 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
angle-autoroll a55c9a50 2025-02-14T10:01:32 Roll vulkan-deps from f943784c5cbd to b62b2ca7025e (5 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/f943784c5cbd..b62b2ca7025e Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/00ac5651f528d84cc3cf7320b34407bce7d38d93..ef5207f9f8cce5097568efb15d3297d8b5d13014 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/8a39540feb81ee451e57058fd8a3e5fc2cd6c9c6..266d5cd69a94c1262c44307f4c4209c97f5c6ec4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I831466a77ff357d1d5b4d6f2078dce3f5ecba010 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6267962 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao 7afa2345 2025-02-12T11:45:59 Vulkan: More std::vector storage fix for TransformFeedbackVk etc PersistentCommandPool::mFreeBuffers switched to use std::deque since there is no need to be continuous storage TransformFeedbackVk::mBufferObserverBindings restored storage before calling emplace_back in a loop. We could use std::array, but this works as good. Bug: b/293297177 Change-Id: Id658216d3d4d25ee1d5cb4ccb8f1a4499b18c38d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6259279 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Mark Lobodzinski 367541f5 2025-02-05T16:45:13 Capture/Replay: Add multi-capture support to tracer Multiple captures can now be grabbed by setting the trigger value to the desired framecount and then resetting it to zero to trigger a new capture. Captures will be saved in the current capture.out_dir directory and this should be changed between captures to keep traces separate. Note that this feature will not work with apps using persistent coherent memory, and in these cases the tracer will exit, preserving the initial, valid trace. Bug: b/394107532, angleproject:42263521 Change-Id: I9d31d19ec6c3736dbda356405eb91fba2dd5a8d7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6258503 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Austin Annestrand c8dc7c08 2025-02-13T16:35:05 CL: Fix typo in cl::BitField's exclude() routine Ignored passed "other" param. Bug: angleproject:42266936 Change-Id: Ia616bc7e2d1bfbdd39ed22221157b6aca5529ed2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6265705 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 064449af 2025-02-13T14:02:33 Vulkan: Fix race condition with foreign image transitions Bug: b/395155346 Bug: b/395513429 Bug: chromium:394148453 Change-Id: Ie6bcd74d8b6c8fdc37af0a0fbd29c0a7a96d0ec1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6265924 Reviewed-by: Jason Macnak <natsu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao 93656e2d 2025-02-11T12:06:17 Vulkan: Reserve storage for ShaderInterfaceVariableInfoMap::mData To avoid data copy associated with vector storage reallocation, reserve enough space based on data gathered from app traces. Bug: b/293297177 Change-Id: I573fc89bd1c8590d9cfb72f576751c94f83720cd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6253674 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Charlie Lao 3d29a799 2025-02-11T10:05:35 Vulkan: Reserve enough storage for ImageHelper::mSubresourceUpdates Most app specify textures from level 0 to level N, which works against std::vector storage grow scheme (which grows in size of 1,2,4,8,16). This CL simply reserve space for 12 mipmap levels to accommodate for most used texture sizes. Bug: b/293297177 Change-Id: I44818ed7ee436c73ab7ff146972f122ae9f08f33 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6253673 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
angle-autoroll cd7f92e1 2025-02-13T10:38:05 Roll vulkan-deps from e2163451af70 to f943784c5cbd (9 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/e2163451af70..f943784c5cbd Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/20827027233f389701af54586900463f7c9ff8e7..00ac5651f528d84cc3cf7320b34407bce7d38d93 https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/8d6c54f05bdaab45945555a3afeb639b0f6aa091..0ed717a810d28e7533d935a7c0017f6d267a8671 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/66e57d1146fe9cd4649b63e361f526bcd239f0e1..dc1641d168304d3ef97bba23d5fc45c9bead45f5 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/b256782810c54e15209b64476823010f57f10b2a..8a39540feb81ee451e57058fd8a3e5fc2cd6c9c6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: Iade252edadbced393dfda3f9ce5e603dddd0887e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6261916 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop c8049a47 2025-02-12T13:21:56 Tests: Add Tower of Fantasy trace Test: angle_trace_tests --gtest_filter="*tower_of_fantasy" Bug: b/389808881 Change-Id: I16a4ab0c12c18d2feb9df41cb0ba5667adb1f161 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6258901 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Mark Łobodziński <mark@lunarg.com>
Yuly Novikov 7014e9ec 2025-02-12T16:42:40 Further suppress dEQP-GLES2.functional.fragment_ops.blend on WGPU Only blend.*constant_alpha* were previously suppressed, but many other tests are flaky on Mac Intel. Bug: angleproject:370690274 Change-Id: I8618c6251956308fa06fe2739eff5050c9578f2c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6258051 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov 688f328f 2025-02-12T06:55:55 Revert "Suppress ImageTestES3 on Pixel 6 Vulkan" This reverts commit ef2ef107242781000ebe2f4f11839ea233aae01b. Reason for revert: should be fixed by https://github.com/KhronosGroup/Vulkan-ValidationLayers/pull/9418 Original change's description: > Suppress ImageTestES3 on Pixel 6 Vulkan > > ImageTestES3.ClearYUVAHB > ImageTestES3.RenderToYUVAHB > > Report on Pixel 6 Android 14: > VUID-VkSubpassDescription2-nullColorAttachmentWithExternalFormatResolve-09336 > > Suppress temporarily while VUID is being fixed. > > Bug: angleproject:395223719 > Change-Id: I52c7fea1058b522badbbd3be5050a01b099d15a7 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6243416 > Auto-Submit: Yuly Novikov <ynovikov@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bug: angleproject:395223719 Change-Id: I22b6ccde6444990d31b95771f067a31669ac3aa1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6258049 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Amirali Abdolrashidi 7ed5575f 2025-02-11T16:21:56 Tests: Skip monopoly_go on Linux/Intel * Skipped this trace on Linux/Intel due to failure on the perf bot. Bug: angleproject:385226328 Change-Id: If1d741fb681027865409c16ebe736c5ce8516ac1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6254465 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 6abdc117 2025-02-12T10:01:10 Roll vulkan-deps from a88fd25a6a0d to e2163451af70 (6 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/a88fd25a6a0d..e2163451af70 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/8a6b381c9afbfaf9fff851582539fab15ea480c0..20827027233f389701af54586900463f7c9ff8e7 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/a7fd3d2fe19f9e6e6c1c98f1fa010621ab90a2db..b256782810c54e15209b64476823010f57f10b2a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I09a61c3632d0244f27f0be267915dd2450f6c188 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6257086 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jordan 706e3be9 2025-02-05T05:38:50 Updating README.chromium license field for EGL-Registry Bug: b/358504615 Change-Id: I06074fa3500d6db53196c510bd1f363463634ed3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6232502 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Owners-Override: Jordan Brown <rop@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Jordan Brown <rop@google.com>
Cody Northrop f8493aaa 2025-01-29T15:31:40 FrameCapture: Fix framebuffer setup for multiple contexts In some traces we're seeing garbage in Context specific setup for framebuffers. It seems the context is being lost in the final bind. For instance, we see this bad sequence in SetupReplayContext2: glGenFramebuffers(1, (GLuint *)gReadBuffer); UpdateFramebufferID2(2, 2, 0); glBindFramebuffer(GL_FRAMEBUFFER, gFramebufferMapPerContext[2][2]); glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, gTextureMap[50], 0); glGenFramebuffers(1, (GLuint *)gReadBuffer); UpdateFramebufferID2(2, 3, 0); glBindFramebuffer(GL_FRAMEBUFFER, gFramebufferMapPerContext[2][3]); glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, gTextureMap[50], 0); glBindFramebuffer(GL_FRAMEBUFFER, gFramebufferMapPerContext[2863311360][0]); Note the very large number in the last line. That is supposed to be a context number! This is due to a missing call to set the context for that instruction. It was added in one spot, but was needed in several. With the fix in this CL, we get the correct context: glGenFramebuffers(1, (GLuint *)gReadBuffer); UpdateFramebufferID2(2, 2, 0); glBindFramebuffer(GL_FRAMEBUFFER, gFramebufferMapPerContext[2][2]); glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, gTextureMap[50], 0); glGenFramebuffers(1, (GLuint *)gReadBuffer); UpdateFramebufferID2(2, 3, 0); glBindFramebuffer(GL_FRAMEBUFFER, gFramebufferMapPerContext[2][3]); glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, gTextureMap[50], 0); glBindFramebuffer(GL_FRAMEBUFFER, gFramebufferMapPerContext[2][0]); Test: Capture apps that set up multiple contexts Bug: b/371985732 Change-Id: Id12d7f0ec0ec9a2cdc2b4bfeca08faf9b8b7e775 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6217081 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Mark Łobodziński <mark@lunarg.com>
Cole Faust cfa03e75 2025-02-03T11:56:01 Replace .toList() with .collect() .toList() was introduced to android in api level 34, which is newer than angle's min_sdk_version. This was found during an android lint update. Replace it with .collect(Collectors.joining(",")). Bug: b/394096385 Test: Presubmits Change-Id: I053adfa7f8e1d6d9758413f789115eee7d66fd7a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6226327 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Roman Lavrov 19c5293e 2025-02-11T10:28:41 Tests: fix Swiftshader test instantiation logic Tests should not be disabled when IsSwiftshaderDevice(), for example running ANGLE builds without Swiftshader on cuttlefish which has Swiftshader set up as the GLES driver. Bug: angleproject:42266725 Change-Id: Id7155c0dfef84a775e558cfc84eb241b727a93a0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6253838 Auto-Submit: Roman Lavrov <romanl@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alex Dean c0d806b4 2025-02-10T23:01:33 CL: OpenCL support for ANGLE Capture/Replay Implementation of OpenCL Capture/Replay tool in ANGLE. Brief notes about the change: - Most meaningful changes for the capture process are made in src/libANGLE/capture/ - Most meaningful changes for replay are made in util/capture/ and src/tests/perf_tests/ - Many autogenerated files are changed/added to allow the capture of OpenCL objects & calls - The following applications were captured/replayed: benchmark_model, GeekBench Compute, GeekBench ML, AI-Benchmark, various OCL CTS tests - End2end test added to capture_tests. CapturedTestCL.MultiFrameCL/ES3_Vulkan Bug: angleproject:383841335 Change-Id: I55fdaa6cd6c7ba740aaa2351e4d29050059d6d1d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6102105 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Roman Lavrov <romanl@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Roman Lavrov cfb430c8 2025-02-10T13:19:05 Remove angle::ErrorStream helper Most uses of the helper either use just the code or a fixed string, which compiles to a few instructions. Using this helper adds 200+ bytes of assembly to each use, due to the unneeded instantiation of ostringstream which allocates a buffer etc. The combined effect of this CL on an Android perf build is ~12KB (0.2%) reduction in size. The cases where the message is actually formatted are converted to an explicit use of ostringstream. Removing the helper so that the new code is explicit about the intent to use ostringstream, or an alternative way to format the message. Discovered accidentally while looking into size reduction due to __builtin_unreachable() Semi-automated code change, risk of copy-paste mistakes should be minimal. Bug: angleproject:394129077 Change-Id: I47c2642d750d31416b08a1cfa435d5463c294e35 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6250078 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
angle-autoroll e4c707b3 2025-02-11T10:01:26 Roll vulkan-deps from b4c8dd090b72 to a88fd25a6a0d (9 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/b4c8dd090b72..a88fd25a6a0d Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/a0bfdde8b720c81fb37f42d2fa00522e68699268..8d6c54f05bdaab45945555a3afeb639b0f6aa091 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/b3fe11f89bd6673a1a8c55b0ddb9ba42811f0774..66e57d1146fe9cd4649b63e361f526bcd239f0e1 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/05e71c3af5bb92b26af767b00789e71bc65b72aa..a7fd3d2fe19f9e6e6c1c98f1fa010621ab90a2db If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: If3688bc9c9f13b55f92dc2fae20a039ac6c8ab47 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6250273 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 39c52044 2025-02-11T02:01:02 Roll SwiftShader from 5017ce3c800e to 720189cae847 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/5017ce3c800e..720189cae847 2025-02-10 swiftshader.regress@gmail.com Regres: Update test lists @ 5017ce3c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I9a94f0b88524f6c51cdca600ea76d1c719aa1ff5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6252265 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Geoff Lang e746fb06 2025-01-23T13:23:30 WebGPU: Implement blending Constant alpha is not handled yet. It needs to be emualted or added to WebGPU. Bug: angleproject:370690274 Change-Id: I5f8402f74ab08345b2f02c18e2d43fa39b2479a7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6194554 Reviewed-by: Liza Burakova <liza@chromium.org> Reviewed-by: Matthew Denton <mpdenton@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Amirali Abdolrashidi 9e86d8c0 2025-02-05T16:31:22 Vulkan: Fix VVL due to memory map range VVL: VUID-VkMappedMemoryRange-size-01390 * Updated BufferBlock::map() so the device memory uses the actually allocated buffer size. * To flush and invalidate a mapped memory range (non-coherent), the memory size is now aligned with nonCoherentAtomSize from the physical device limits. * Added an assert to make sure that the mapped size is within the allocated buffer size range. * Unskipped ExternalBufferTestES31 cases for Pixel6, except one case which seems to take a long time and result in timeout. * BufferDoesNotLeakAHB Bug: angleproject:394685081 Change-Id: Iddfb45997fed53c5ee99938d9bb57b670550b9a6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6238059 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang 869dde72 2025-02-07T15:44:12 Remove code paths for invoking the offline Metal compiler We experimented with invoking the Metal shader compiler directly to create cacheable shader libraries but the project did not show useful gains. It is currently all dead code, remove it. Bug: b/391990604 Change-Id: I6d13278d1a27d8b3ae961a0846f31292f2506b23 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6245258 Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Yuxiang Qian 883f6246 2025-01-22T16:36:26 Add validation for eglSetDamageRegionKHR Although this is not mentioned in spec, n_rects in eglSetDamageRegionKHR should be a valid value. It doesn't make sense if it's less than 0. Refine the validation in ANGLE and also add end2end test. Bug: angleproject:395482390 Change-Id: Idbde839be85bac927486b7613005f25d54c3d5f5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6242903 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Juston Li 2dc7d413 2025-02-10T10:37:38 Revert "Disable gl backend for desktop android" This reverts commit 3dc3de6225f927cf8e8495322fa201c167e84671. Reason for revert: This causes webview crashes on desktop CF Bug: b/394410295 Original change's description: > Disable gl backend for desktop android > > Desktop android only uses the vulkan backend > > Bug: b/388074349 > Change-Id: Ib42f04af0ed947cf93d3d891e78aef1ae0a81a63 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6164687 > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Cody Northrop <cnorthrop@google.com> Bug: b/388074349 Change-Id: I22ab3a1c1766de7b9eb7da1fe5814cb25f8305e8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6249964 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi d252425d 2025-02-06T14:51:36 Vulkan: Check source image usage flags in copy paths ... instead of the format feature flags. If the source of the copy is has external format (allowed with glCopy[Sub]TextureCHROMIUM), the format feature checks are unable to query the format features. However, the image usage flags already have the required information (whether the image can be copied from, sampled from, etc). Bug: chromium:383056998 Change-Id: I2ba8820751eb526ef497a8be724193276fd46160 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6238265 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Igor Nazarov ae84e067 2025-02-10T19:31:37 Vulkan: Use correct feature in queryAndAdjustSurfaceCaps() Check "supportsSurfaceMaintenance1" feature instead of "supportsSwapchainMaintenance1", because `VkSurfacePresentModeEXT` structure requires "VK_EXT_surface_maintenance1" extension and not "VK_EXT_swapchain_maintenance1". Some platforms may expose one but not the other, causing inconsistent `GetMinImageCount()` calculations and swapchain recreation on each frame if "perFrameWindowSizeQuery" feature is enabled. Bug: angleproject:42267111 Change-Id: Id17bec8017799a7c175e6a4b03583665faf5dddd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6249841 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 0026006d 2025-02-10T12:03:40 Vulkan: Fix missing barrier between dispatch calls When storage images are used, ANGLE accidentally did not mark the images as being written to, so subsequent barriers were not produced when necessary. Bug: angleproject:352610491 Bug: b/394611669 Change-Id: Idd3e6aa6b90212605594240a533ebaec66850ea9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6249459 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Roman Lavrov c4caed5f 2025-02-10T06:17:01 Revert "UNREACHABLE -> __builtin_unreachable() in release clang builds" This reverts commit 7370bb573dd8b37006d409fc8917ff49912dd75a. Reason for revert: issue identified by fuzzer crbug.com/394980074 Original change's description: > UNREACHABLE -> __builtin_unreachable() in release clang builds > > This enables compiler optimizations such as reducing the amount of > branching, see anglebug.com/394129077#comment1 > > Reduces .so size in an Android perf build by 0.4%. I spot checked a few > differences and saw less branches (this will be causing a different > behavior in UNREACHABLE branches) as well as more functions getting > inlined (likely due to compiler heuristics due to less branches) > > Bug: angleproject:394129077 > Change-Id: I23411ca7a49d3daf2a0621bfcc0b2523d4db4f5a > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6231111 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Charlie Lao <cclao@google.com> > Commit-Queue: Roman Lavrov <romanl@google.com> Bug: angleproject:394129077 Bug: chromium:394980074 Change-Id: I7398d86c692e5c50ac1185c30e2053eb87f9bd70 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6248417 Auto-Submit: Roman Lavrov <romanl@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll a4b89fc8 2025-02-10T08:01:51 Roll VK-GL-CTS from 1177f7b7d556 to 69ec1790cb7c (8 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/1177f7b7d556..69ec1790cb7c 2025-02-06 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.1 into vk-gl-cts/main 2025-02-06 rgarcia@igalia.com Test DGC with mesh shaders and no fragment shader 2025-02-06 rgarcia@igalia.com Add SampleMask variants to dynamic A2C DGC tests 2025-02-06 rgarcia@igalia.com Test dynamic FSR with device-generated commands 2025-02-06 rgarcia@igalia.com Test destroying set layout immediately after creating DGC IES 2025-02-06 rgarcia@igalia.com Test using a depth-only pass with mesh shaders 2025-02-06 marcin.zajac@cognizant.com Fix subgroups multiple dispatches test for Vulkan SC 2025-02-06 kamil.goras@mobica.com Test maximum degree of anisotropy. Testing was removed by #637. Add excluding tests using *test-issues.txt for gles3-khr in build_mustpass.py If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I3c4203b0da9b9cfc95fccc695a31df7ba972e99d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6247809 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 9b75ed9a 2025-02-10T10:01:11 Roll vulkan-deps from c32804ca5a39 to b4c8dd090b72 (10 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/c32804ca5a39..b4c8dd090b72 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/a15ec3f54859037512aac22e58ea45aef09cde40..a0bfdde8b720c81fb37f42d2fa00522e68699268 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/682bcd51548e670811f1d03511968bb59a1157ce..b3fe11f89bd6673a1a8c55b0ddb9ba42811f0774 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/e00009bc3f550898c92e96a77ae4dca963778301..05e71c3af5bb92b26af767b00789e71bc65b72aa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I4346a51c1ed3565df37ba0914b8866f28c80b0de Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6247811 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov ef2ef107 2025-02-09T10:53:00 Suppress ImageTestES3 on Pixel 6 Vulkan ImageTestES3.ClearYUVAHB ImageTestES3.RenderToYUVAHB Report on Pixel 6 Android 14: VUID-VkSubpassDescription2-nullColorAttachmentWithExternalFormatResolve-09336 Suppress temporarily while VUID is being fixed. Bug: angleproject:395223719 Change-Id: I52c7fea1058b522badbbd3be5050a01b099d15a7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6243416 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Mohan Maiya aef40167 2025-02-07T13:42:34 Vulkan: Account for padBuffersToMaxVertexAttribStride ... when evaluating maxTextureBufferSize Bug: angleproject:391002353 Test: KHR-GLES31.core.texture_buffer.texture_buffer_max_size KHR-GLES32.core.texture_buffer.texture_buffer_max_size Change-Id: I7f59d642ed5af87fdb0c683189da88b0a70a1122 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6244611 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Robic Sun b5584cfd 2025-02-05T15:14:52 ValidTexLevelDestinationTarget should add external related cases GL_TEXTURE_EXTERNAL_OES is not documented in OES_EGL_image_external spec, but we consider that to be an omission in the spec. Bug: angleproject:394380758 Change-Id: Idb5523c173ae0a5910af97639dadff3c5adf9fdf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6232504 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com>
Charlie Lao ffb7575c 2025-02-07T10:25:22 Vulkan: Reserve reasonable amount storage for GarbageObjects Based on data collected from app traces, set the initial storage enough to accommodate most of the usage cases. For ContextVk::mCurrentGarbage, the problem is that after the collectGarbage call, it lose the capacity value, so next time it end up with 0 and slowly grow the capacity again. This CL always keeps the capacity after the collectGarbage call. Bug: b/293297177 Change-Id: I70deccd879311aebe6ea3bbf4ecf5c54a74ef584 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6244922 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Charlie Lao 3dcd143c 2025-02-06T15:06:02 Vulkan: Reduce GL_EXT_texture_storage_compression related overhead Most of apps not using fixed rate compression extension, but we are getting into all these logic that checking for vulkan driver's support of compression rate. This CL adds a check in TextureVk::initImage(), so that it only goes down that logic if mState.getSurfaceCompressionFixedRate() is not GL_SURFACE_COMPRESSION_FIXED_RATE_NONE_EXT. This means for all existing app traces we have, we should not go down these logic any more. This CL also made TextureVk::getFormatSupportedCompressionRatesImpl() and ImageHelper::getCompressionFixedRate() out of TextureVk and ImageHelper class given they are not accessing the data member at all. Bug: b/293297177 Bug: angleproject:352364583 Change-Id: Ib5eebf54172f194d7c65c2d2d751326b7923403f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6239523 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao f6c5db26 2025-02-06T13:28:03 Vulkan: Reserve enough storage for GLRates Bug: b/293297177 Change-Id: Ie42dd646f7a4f5b0710058fc1612148c1d650e03 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6231517 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Charlie Lao 6eb9789e 2025-02-06T11:59:31 Vulkan: Reserve enough storage for mSwapchainImages Investigation shows that when running traces in back to back mode, mSwapchainImages end up with max size of 6 or 7. This CL reserve the enough capacity (8 to be power of 2) so that no storage reallocation related data copy will occur. Similar storage is reserved for mSwapchainImageBindings as well. Bug: b/293297177 Change-Id: I1e216b6eaeed72554a20d27963b797b00ca5fd07 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6240592 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
kmx.io     mail     discord kmxgit v0.4.0