-
Show log
Commit
-
Hash : 4cc89e2b
Author :
Date : 2017-08-31T14:25:54
ES31: Enable 'location' layout qualifier on shader interfaces in compiler This patch enables 'location' layout qualifier for vertex outputs and fragment shader inputs when the shader version is 3.1 in ANGLE GLSL compiler and adds the check on location conflicts for these varyings. According to GLSL ES 3.1 SPEC (Chapter 4.4.1 and Chapter 4.4.2), 'location' layout qualifier is allowed on both inputs and outputs of vertex and fragment shaders. 'location' layout qualifier on shader interfaces is only valid on shaders whose version is 3.1 and above. According to GLSL ES 3.0 SPEC, vertex shader cannot have output layout qualifiers (Chapter 4.3.8.2) and fragment shader cannot have input layout qualifiers (Chapter 4.3.8.1). The 'location' qualifier on varyings is used in the shader interface matching defined in OpenGL ES 3.1. (OpenGL ES 3.1 SPEC Chapter 7.4.1). This new link rule will be added to Program.cpp in another patch. For the OpenGL ES 3.1 extension GL_OES_geometry_shader, according to GL_OES_shader_io_blocks SPEC (Chapter 4.4.1 and Chapter 4.4.2), 'location' layout qualifier is both valid on geometry shader inputs and outputs. This feature will be implemented together with other rules on geometry shader inputs and outputs. BUG=angleproject:2144 TEST=angle_unittests Change-Id: I62d85f7144c177448321c2db36ed7aaeaa1fb205 Reviewed-on: https://chromium-review.googlesource.com/645366 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
-
Files
- API_test.cpp
- ARB_texture_rectangle_test.cpp
- AppendixALimitations_test.cpp
- AtomicCounter_test.cpp
- BufferVariables_test.cpp
- CollectVariables_test.cpp
- ConstantFoldingNaN_test.cpp
- ConstantFoldingOverflow_test.cpp
- ConstantFolding_test.cpp
- ConstructCompiler_test.cpp
- DebugShaderPrecision_test.cpp
- EXT_YUV_target_test.cpp
- EXT_blend_func_extended_test.cpp
- EmulateGLFragColorBroadcast_test.cpp
- ExpressionLimit_test.cpp
- FloatLex_test.cpp
- FragDepth_test.cpp
- GLSLCompatibilityOutput_test.cpp
- GeometryShader_test.cpp
- HLSLOutput_test.cpp
- InitOutputVariables_test.cpp
- IntermNode_test.cpp
- NV_draw_buffers_test.cpp
- Pack_Unpack_test.cpp
- PruneEmptyDeclarations_test.cpp
- PrunePureLiteralStatements_test.cpp
- PruneUnusedFunctions_test.cpp
- QualificationOrderESSL31_test.cpp
- QualificationOrder_test.cpp
- RecordConstantPrecision_test.cpp
- RemovePow_test.cpp
- RewriteDoWhile_test.cpp
- SamplerMultisample_test.cpp
- ShCompile_test.cpp
- ShaderExtension_test.cpp
- ShaderImage_test.cpp
- ShaderValidation_test.cpp
- ShaderVariable_test.cpp
- TypeTracking_test.cpp
- UnrollFlatten_test.cpp
- VariablePacker_test.cpp
- WEBGL_multiview_test.cpp
- WorkGroupSize_test.cpp
