deqp_support

Diff

Show log
Commit

Hash : 0fefbe83
Author :
Date : 2022-09-14T15:20:00

Vulkan: Do not cache the FramebufferHelper with no attachment

If two FBOs don't have any attachments,
and their GL_FRAMEBUFFER_DEFAULT_WIDTH
and GL_FRAMEBUFFER_DEFAULT_HEIGHT are
different, there is no difference in
their cache key (vk::FramebufferDesc).
Therefore the Vulkan backend is not able
to distinguish between the two FBOs.

This can create issues when we
1. create first FBO with a smaller size, renders to it
2. create second FBO with a bigger size, renders to it

The second renderpass will use the FBO created
in the first renderpass, because it managed to
retrieve the first FBO from the cache with
the same cachekey. This triggers the
vulkan validation error:
VUID-VkRenderPassBeginInfo-pNext-02853,
saying the render area exceeds the
framebuffer size.

This CL fixed it by not adding the FramebufferHelper
to the cache, if it doesn't have any attachment.
These framebufferHelpers are cheap, without
cache there should not be much performance
drop.

Bug: angleproject:3579
Bug: angleproject:7351
Bug: angleproject:7666
Bug: b/246334302
Change-Id: Iddecafddb042bd16401f983f9ee1a021b845d8bb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3891543
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

Properties

Git HTTP	https://git.kmx.io/kc3-lang/angle.git
Git SSH	git@git.kmx.io:kc3-lang/angle.git
Public access ?	public
Description	A conformant OpenGL ES implementation for Windows, Mac, Linux, iOS and Android. Homepage Github
Users
Tags

README.md
dEQP Support

ANGLE integrates dEQP (i.e. the OpenGL CTS) for conformance testing. It uses gtest to run tests, and provides the means for dEQP to use ANGLE.

Overriding dEQP files

Occasionally, ANGLE overrides certain dEQP files by copying them to this directory, adding the _override suffix, and modifying them. deqp.gni is used to select these override files to be built with dEQP instead of the original files.

This is primarily done to fix tests until they are fixed upstream.

Expectation files format

For every set of dEQP tests, for example GLES3 tests on the Vulkan backend, an expectations file exists to let the test harness know which tests it should skip (as they are known to crash), or expect to see failed. Warnings are generated if a test unexpectedly passes, but an unexpected failure is an error. This let’s ANGLE ensure there are no regressions.

If multiple test expectations in a file match a specific test due to wildcards, the test harness picks the first match in the file as the overriding expectation.

While developing a feature, or testing on a new platform, the expectations files can be modified to reflect the reality of the situation. The expected format for every line in these files is:
```
{BUG#} {MODIFIERS} : {TEST_NAME} = {PASS,FAIL,FLAKY,TIMEOUT,SKIP}
```
MODIFIERS can be a combination of the below list, combined with a logical AND:
```
WIN XP VISTA WIN7 WIN8 WIN10
MAC LEOPARD SNOWLEOPARD LION MOUNTAINLION MAVERICKS YOSEMITE ELCAPITAN SIERRA HIGHSIERRA MOJAVE
LINUX CHROMEOS ANDROID
NVIDIA AMD INTEL
DEBUG RELEASE
D3D9 D3D11 OPENGL GLES VULKAN
NEXUS5X PIXEL2ORXL PIXEL4ORXL PIXEL6
QUADROP400
SWIFTSHADER
PREROTATION PREROTATION90 PREROTATION180 PREROTATION270
NOSAN ASAN TSAN UBSAN
```
TEST_NAME can be a specific test name, or set of test names using '*' as wildcard anywhere in the name. Examples:
```
// Disabled everywhere as is too slow:
3445 : dEQP-GLES31.functional.ssbo.layout.random.all_shared_buffer.48 = SKIP

// Crashes on both D3D11 and OPENGL:
1442 OPENGL : dEQP-GLES31.functional.separate_shader.* = SKIP
1442 D3D11 : dEQP-GLES31.functional.separate_shader.* = SKIP

// Unsupported feature:
3726 VULKAN ANDROID : dEQP-GLES31.functional.synchronization.inter_call.without_memory_barrier.*atomic_counter* = FAIL

// Failing test in Nvidia's OpenGL implementation on windows:
1665 WIN NVIDIA OPENGL : dEQP-GLES31.functional.draw_indirect.negative.command_offset_not_in_buffer_unsigned32_wrap = FAIL

// Failing when emulated pre-rotation is enabled, no matter which angle:
1234 PREROTATION : dEQP-GLES3.*blit* = FAIL

// Failing when emulated pre-rotation is enabled with 270 degree angle:
1234 PREROTATION270 : dEQP-GLES3.*blit* = FAIL

// Flaky when run with thread-sanitizer (TSan)
6678 TSAN : dEQP-EGL.functional.sharing.gles2.multithread.random* = FLAKY
```

kc3-lang/angle/src/tests/deqp_support

Commit

Files

Properties

README.md

dEQP Support

Overriding dEQP files

Expectation files format