kc3-lang/angle/src/libANGLE/renderer/vulkan

• Show log

  Commit

• Hash : 3dfaeeb0
  Author :
  Date : 2020-10-30T16:57:44
  

  Vulkan: Don't flush deferred clears on READ framebuffer sync
  
  Deferred clears are not collected when syncing the READ framebuffer.
  Prior to this change, we had in FramebufferVk::syncState:
  
      if (READ && deferredClears.any())
      {
          flushDeferredClears();
      }
  
  However, this is impossible / unnecessary:
  
  - Every operation whose syncState (for the DRAW framebuffer) collects
    deferred clears will flush the deferred clears.  In fact, it's an
    error for the next operation's syncState to encounter pre-existing
    deferred clears.
  - The READ framebuffer is synced before the DRAW framebuffer.  This
    makes it impossible for there to be deferred clears when READ is
    synced.
  
  It may be necessary to swap the order in which the READ and DRAW
  framebuffers are synced.  See http://anglebug.com/5266.  In that case,
  if the READ and DRAW framebuffers are identical:
  
  - The DRAW framebuffer's sync will collect deferred clears.  The READ
    framebuffer's sync will see deferred clears, but it must not flush
    them!
  
  Bug: angleproject:4988
  Change-Id: I179002d739608ccb8bda95d4379dc6d54e2bf4bb
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2511372
  Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
  Reviewed-by: Tim Van Patten <timvp@google.com>
  Reviewed-by: Jamie Madill <jmadill@chromium.org>
  

• Files

• BUILD.gn
• BufferVk.cpp
• BufferVk.h
• CommandProcessor.cpp
• CommandProcessor.h
• CompilerVk.cpp
• CompilerVk.h
• ContextVk.cpp
• ContextVk.h
• DebugAnnotatorVk.cpp
• DebugAnnotatorVk.h
• DeviceVk.cpp
• DeviceVk.h
• DisplayVk.cpp
• DisplayVk.h
• DisplayVk_api.h
• FenceNVVk.cpp
• FenceNVVk.h
• FramebufferVk.cpp
• FramebufferVk.h
• GlslangWrapperVk.cpp
• GlslangWrapperVk.h
• ImageVk.cpp
• ImageVk.h
• MemoryObjectVk.cpp
• MemoryObjectVk.h
• OWNERS
• OverlayVk.cpp
• OverlayVk.h
• PersistentCommandPool.cpp
• PersistentCommandPool.h
• ProgramExecutableVk.cpp
• ProgramExecutableVk.h
• ProgramPipelineVk.cpp
• ProgramPipelineVk.h
• ProgramVk.cpp
• ProgramVk.h
• QueryVk.cpp
• QueryVk.h
• README.md
• RenderTargetVk.cpp
• RenderTargetVk.h
• RenderbufferVk.cpp
• RenderbufferVk.h
• RendererVk.cpp
• RendererVk.h
• ResourceVk.cpp
• ResourceVk.h
• SamplerVk.cpp
• SamplerVk.h
• SecondaryCommandBuffer.cpp
• SecondaryCommandBuffer.h
• SemaphoreVk.cpp
• SemaphoreVk.h
• ShaderVk.cpp
• ShaderVk.h
• SurfaceVk.cpp
• SurfaceVk.h
• SyncVk.cpp
• SyncVk.h
• TextureVk.cpp
• TextureVk.h
• TransformFeedbackVk.cpp
• TransformFeedbackVk.h
• UtilsVk.cpp
• UtilsVk.h
• VertexArrayVk.cpp
• VertexArrayVk.h
• android/
• display/
• doc/
• fuchsia/
• gen_vk_format_table.py
• gen_vk_internal_shaders.py
• gen_vk_mandatory_format_support_table.py
• ggp/
• mac/
• shaders/
• vk_cache_utils.cpp
• vk_cache_utils.h
• vk_caps_utils.cpp
• vk_caps_utils.h
• vk_format_map.json
• vk_format_table_autogen.cpp
• vk_format_utils.cpp
• vk_format_utils.h
• vk_helpers.cpp
• vk_helpers.h
• vk_internal_shaders_autogen.cpp
• vk_internal_shaders_autogen.gni
• vk_internal_shaders_autogen.h
• vk_mandatory_format_support_data.json
• vk_mandatory_format_support_table_autogen.cpp
• vk_mem_alloc_wrapper.cpp
• vk_mem_alloc_wrapper.h
• vk_utils.cpp
• vk_utils.h
• vk_wrapper.h
• win32/
• xcb/

• Properties

• Git HTTP	https://git.kmx.io/kc3-lang/angle.git
  Git SSH	git@git.kmx.io:kc3-lang/angle.git
  Public access ?	public
  Description	A conformant OpenGL ES implementation for Windows, Mac, Linux, iOS and Android. Homepage Github
  Users
  Tags