-
Show log
Commit
-
Hash : daeac238
Author :
Date : 2021-05-08T22:09:38
Translator: Ensure structs and blocks are uniquely defined A new AST validation is added to ensure that the same TStructure or TInterfaceBlock is not redundantly defined. This helps with SPIR-V generation by allowing the id to be used as key in a hash map that looks up the corresponding SPIR-V type id. A bug is fixed where the Vulkan driver uniform declaration created two identical declarations for ANGLEDepthRangeParams. A number of other bugs are also fixed in this change, where if a variable declaration is eliminated (for example due to constant folding, or inactive interface variable removal) and it contained a struct specifier, the struct declaration was also removed. OutputGLSLBase had a hack where structs were declared on first encounter, which was incorrect as the scope of the declaration could change. Those bugs are fixed and this hack is removed. Bug: angleproject:2733 Bug: angleproject:4889 Bug: angleproject:5936 Change-Id: I8e13748c0bf552ae8b052249282769a1f0775603 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2881942 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
-
Files
- ASTMetadataHLSL.cpp
- ASTMetadataHLSL.h
- AtomicCounterFunctionHLSL.cpp
- AtomicCounterFunctionHLSL.h
- BaseTypes.h
- BuiltInFunctionEmulator.cpp
- BuiltInFunctionEmulator.h
- BuiltInFunctionEmulatorGLSL.cpp
- BuiltInFunctionEmulatorGLSL.h
- BuiltInFunctionEmulatorHLSL.cpp
- BuiltInFunctionEmulatorHLSL.h
- BuiltinsWorkaroundGLSL.cpp
- BuiltinsWorkaroundGLSL.h
- CallDAG.cpp
- CallDAG.h
- CodeGen.cpp
- CollectVariables.cpp
- CollectVariables.h
- Common.h
- Compiler.cpp
- Compiler.h
- ConstantUnion.cpp
- ConstantUnion.h
- Declarator.cpp
- Declarator.h
- Diagnostics.cpp
- Diagnostics.h
- DirectiveHandler.cpp
- DirectiveHandler.h
- ExtensionBehavior.cpp
- ExtensionBehavior.h
- ExtensionGLSL.cpp
- ExtensionGLSL.h
- FlagStd140Structs.cpp
- FlagStd140Structs.h
- FunctionLookup.cpp
- FunctionLookup.h
- HashNames.cpp
- HashNames.h
- ImageFunctionHLSL.cpp
- ImageFunctionHLSL.h
- ImmutableString.h
- ImmutableStringBuilder.cpp
- ImmutableStringBuilder.h
- ImmutableString_ESSL_autogen.cpp
- ImmutableString_autogen.cpp
- InfoSink.cpp
- InfoSink.h
- Initialize.cpp
- Initialize.h
- InitializeDll.cpp
- InitializeDll.h
- InitializeGlobals.h
- IntermNode.cpp
- IntermNode.h
- IsASTDepthBelowLimit.cpp
- IsASTDepthBelowLimit.h
- Operator.cpp
- Operator.h
- OutputESSL.cpp
- OutputESSL.h
- OutputGLSL.cpp
- OutputGLSL.h
- OutputGLSLBase.cpp
- OutputGLSLBase.h
- OutputHLSL.cpp
- OutputHLSL.h
- OutputTree.cpp
- OutputTree.h
- OutputVulkanGLSL.cpp
- OutputVulkanGLSL.h
- OutputVulkanGLSLForMetal.h
- OutputVulkanGLSLForMetal.mm
- ParseContext.cpp
- ParseContext.h
- ParseContext_ESSL_autogen.h
- ParseContext_complete_autogen.h
- ParseContext_interm.h
- PoolAlloc.cpp
- PoolAlloc.h
- Pragma.h
- QualifierTypes.cpp
- QualifierTypes.h
- ResourcesHLSL.cpp
- ResourcesHLSL.h
- Severity.h
- ShaderLang.cpp
- ShaderStorageBlockFunctionHLSL.cpp
- ShaderStorageBlockFunctionHLSL.h
- ShaderStorageBlockOutputHLSL.cpp
- ShaderStorageBlockOutputHLSL.h
- ShaderVars.cpp
- StaticType.h
- StructureHLSL.cpp
- StructureHLSL.h
- Symbol.cpp
- Symbol.h
- SymbolTable.cpp
- SymbolTable.h
- SymbolTable_ESSL_autogen.cpp
- SymbolTable_autogen.cpp
- SymbolTable_autogen.h
- SymbolUniqueId.cpp
- SymbolUniqueId.h
- TextureFunctionHLSL.cpp
- TextureFunctionHLSL.h
- TranslatorESSL.cpp
- TranslatorESSL.h
- TranslatorGLSL.cpp
- TranslatorGLSL.h
- TranslatorHLSL.cpp
- TranslatorHLSL.h
- TranslatorMetal.cpp
- TranslatorMetal.h
- TranslatorVulkan.cpp
- TranslatorVulkan.h
- Types.cpp
- Types.h
- UtilsHLSL.cpp
- UtilsHLSL.h
- ValidateAST.cpp
- ValidateAST.h
- ValidateBarrierFunctionCall.cpp
- ValidateBarrierFunctionCall.h
- ValidateClipCullDistance.cpp
- ValidateClipCullDistance.h
- ValidateGlobalInitializer.cpp
- ValidateGlobalInitializer.h
- ValidateLimitations.cpp
- ValidateLimitations.h
- ValidateMaxParameters.cpp
- ValidateMaxParameters.h
- ValidateOutputs.cpp
- ValidateOutputs.h
- ValidateSwitch.cpp
- ValidateSwitch.h
- ValidateVaryingLocations.cpp
- ValidateVaryingLocations.h
- VariablePacker.cpp
- VariablePacker.h
- VersionGLSL.cpp
- VersionGLSL.h
- blocklayout.cpp
- blocklayout.h
- blocklayoutHLSL.cpp
- blocklayoutHLSL.h
- builtin_function_declarations.txt
- builtin_variables.json
- emulated_builtin_function_data_hlsl.json
- emulated_builtin_functions_hlsl_autogen.cpp
- gen_builtin_symbols.py
- gen_emulated_builtin_function_tables.py
- generate_parser.py
- glslang.h
- glslang.l
- glslang.y
- glslang_lex_autogen.cpp
- glslang_tab_autogen.cpp
- glslang_tab_autogen.h
- glslang_wrapper.cpp
- glslang_wrapper.h
- length_limits.h
- span_unittest.cpp
- tree_ops/
- tree_util/
- util.cpp
- util.h
