kc3-lang/angle/src/libANGLE/HandleAllocator_unittest.cpp

• Show log

  Commit

• Hash : 03786d77
  Author :
  Date : 2015-05-27T11:22:30
  

  After a create-on-bind, the subsequent glGen* should not waste handle space.
  
  Consider this calling sequence:
  glBindTexture(GL_TEXTURE_2D, 3); // create-on-bind
  glGenTextures(1, tex);
  
  Before this fix, mUnallocatedList in HandleAllocator is in reverse sorted
  order. It's split into (4, MAX_UINT) and (1, 3). The glGen gets tex = 4,
  and handles 1 and 2 will not be allocated until it reaches MAX_UINT.
  With this fix, the elements in mUnallocatedList is in sorted order
  (1, 3) and (4, MAX_UINT). So tex is 1, and we can have all rest handles.
  
  Change-Id: If408ea92f7c243791119fe386e3e0ea27954e55c
  Reviewed-on: https://chromium-review.googlesource.com/273886
  Reviewed-by: Jamie Madill <jmadill@chromium.org>
  Tested-by: Minmin Gong <mgong@microsoft.com>
  

Download

• src/libANGLE/HandleAllocator_unittest.cpp

• //
  // Copyright 2015 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  // Unit tests for HandleAllocator.
  //
  
  #include "gmock/gmock.h"
  #include "gtest/gtest.h"
  
  #include "libANGLE/HandleAllocator.h"
  
  namespace
  {
  
  TEST(HandleAllocatorTest, ReservationsWithGaps)
  {
      gl::HandleAllocator allocator;
  
      std::set<GLuint> allocationList;
      for (GLuint id = 2; id < 50; id += 2)
      {
          allocationList.insert(id);
      }
  
      for (GLuint id : allocationList)
      {
          allocator.reserve(id);
      }
  
      std::set<GLuint> allocatedList;
      for (size_t allocationNum = 0; allocationNum < allocationList.size() * 2; ++allocationNum)
      {
          GLuint handle = allocator.allocate();
          EXPECT_EQ(0u, allocationList.count(handle));
          EXPECT_EQ(0u, allocatedList.count(handle));
          allocatedList.insert(handle);
      }
  }
  
  TEST(HandleAllocatorTest, Random)
  {
      gl::HandleAllocator allocator;
  
      std::set<GLuint> allocationList;
      for (size_t iterationCount = 0; iterationCount < 40; ++iterationCount)
      {
          for (size_t randomCount = 0; randomCount < 40; ++randomCount)
          {
              GLuint randomHandle = (rand() % 1000) + 1;
              if (allocationList.count(randomHandle) == 0)
              {
                  allocator.reserve(randomHandle);
                  allocationList.insert(randomHandle);
              }
          }
  
          for (size_t normalCount = 0; normalCount < 40; ++normalCount)
          {
              GLuint normalHandle = allocator.allocate();
              EXPECT_EQ(0u, allocationList.count(normalHandle));
              allocationList.insert(normalHandle);
          }
      }
  }
  
  TEST(HandleAllocatorTest, Reallocation)
  {
      // Note: no current test for overflow
      gl::HandleAllocator limitedAllocator(10);
  
      for (GLuint count = 1; count < 10; count++)
      {
          GLuint result = limitedAllocator.allocate();
          EXPECT_EQ(count, result);
      }
  
      for (GLuint count = 1; count < 10; count++)
      {
          limitedAllocator.release(count);
      }
  
      for (GLuint count = 2; count < 10; count++)
      {
          limitedAllocator.reserve(count);
      }
  
      GLint finalResult = limitedAllocator.allocate();
      EXPECT_EQ(finalResult, 1);
  }
  
  // The following test covers reserving a handle with max uint value.
  // See http://anglebug.com/1052
  TEST(HandleAllocatorTest, ReserveMaxUintHandle)
  {
      gl::HandleAllocator allocator;
  
      GLuint maxUintHandle = std::numeric_limits<GLuint>::max();
      allocator.reserve(maxUintHandle);
  
      GLuint normalHandle = allocator.allocate();
      EXPECT_EQ(1u, normalHandle);
  }
  
  // To test if the allocator keep the handle in a sorted order.
  TEST(HandleAllocatorTest, SortedOrderHandle)
  {
      gl::HandleAllocator allocator;
  
      allocator.reserve(3);
  
      GLuint allocatedList[5];
      for (GLuint count = 0; count < 5; count++)
      {
          allocatedList[count] = allocator.allocate();
      }
  
      EXPECT_EQ(1u, allocatedList[0]);
      EXPECT_EQ(2u, allocatedList[1]);
      EXPECT_EQ(4u, allocatedList[2]);
      EXPECT_EQ(5u, allocatedList[3]);
      EXPECT_EQ(6u, allocatedList[4]);
  }
  
  }
  

Download