Branch :
| Author | Commit | Date | CI | Message |
|---|---|---|---|---|
| 533186d2 | 2013-05-19 12:24:48 | tests: fix a botched heading comment * t/parallel-tests-recheck-pr11791.sh: Here. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| b8e9d8d0 | 2013-05-19 12:22:22 | tests: fix another spurious with FreeBSD make * t/parallel-tests-recheck-pr11791.sh: Here. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| 478740de | 2013-05-19 00:09:30 | tests: fix a spurious failure with FreeBSD make Failures due to known VPATH support issues in that make implementation (the same issues that have been causing the long-standing bug#7884). * t/lex-multiple.sh: Adjust. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| 0cca184f | 2013-05-18 15:23:20 | Merge branch 'micro' into maint * micro: lisp: fix a failure with Solaris /usr/xpg4/bin/sh tests: sanitize 'unset' usages tests: fix some botched/outdated comments tests: use perl, not find+rm, to remove temporary directories Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| 0256f1d6 | 2013-05-18 13:35:16 | lisp: fix a failure with Solaris /usr/xpg4/bin/sh * lib/am/lisp.am (.el.elc): By initializing the 'am__dir' properly here. For most shells, the lacking initialization, while technically incorrect, didn't cause any issue in practice, because in those shells "test -d" returns an exit status of 0. But with /usr/xpg4/bin/sh, the shell complains like this: "test: argument expected", and returns a non-zero exit status. This caused testsuite failures in several lisp tests. Also, while we are at it, use more proper quoting in the recipe, to ensure a missing initialization to now be caught by more forgiving shells as well. * NEWS: Update. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| 84e12c32 | 2013-05-17 13:45:44 | tests: sanitize 'unset' usages In some shells (e.g., Solaris 10 /bin/ksh, or NetBSD 5.1 /bin/sh), "unset VAR" returns a non-zero exit status in case the VAR variable is already unset. This doesn't interact well with our usage of "set -e" in the testsuite. So far, we've avoided spurious failures by either explicitly ignoring the exit status from unset: unset VAR || : or explicitly ensuring that a variable is set, before trying to unset it: VAR=; unset VAR But we can do better, by aliasing the 'unset' command to a custom function that will take care of these details for us. This will avoid us annoying spurious failures in the future, failures that have already bitten us too much times. For an example, refer to commit 'v1.12.2-88-g5b1dae5' of 2012-08-05 (tests: avoid tons of spurious failures on NetBSD). * t/ax/test-lib.sh (_am_unset): New function. (unset): New alias to it. (_am_exit): Adjust comments. * t/ax/am-test-lib.sh: No need to temporary disable the 'errexit' shell flag when unsetting variables that are potentially already unset. (am_process_requirements): Adjust to remove a now-useless workaround related to unset. * t/aclocal-macrodir.tap: Likewise. * t/aclocal-macrodirs.tap: Likewise. * t/auxdir-autodetect.sh: Likewise. * t/ax/am-test-lib.sh: Likewise. * t/ax/test-lib.sh: Likewise. * t/check-tests-in-builddir.sh: Likewise. * t/dist-formats.tap: Likewise. * t/distcheck-configure-flags-am.sh: Likewise. * t/distcheck-configure-flags.sh: Likewise. * t/java-empty-classpath.sh: Likewise. * t/javaflags.sh: Likewise. * t/lflags.sh: Likewise. * t/lflags2.sh: Likewise. * t/lisp-flags.sh: Likewise. * t/lisp6.sh: Likewise. * t/missing-auxfile-stops-makefiles-creation.sh: Likewise. * t/parallel-am.sh: Likewise. * t/parallel-am2.sh: Likewise. * t/parallel-am3.sh: Likewise. * t/parallel-tests-log-override-recheck.sh: Likewise. * t/pkg-config-macros.sh: Likewise. * t/python-missing.sh: Likewise. * t/python-too-old.sh: Likewise. * t/python11.sh: Likewise. * t/self-check-dir.tap: Likewise. * t/self-check-report.sh: Likewise. * t/self-check-seq.tap: Likewise. * t/silent-configsite.sh: Likewise. * t/suffix6c.sh: Likewise. * t/tar-override.sh: Likewise. * t/tests-environment-and-log-compiler.sh: Likewise. * t/vala-configure.sh: Likewise. * t/werror3.sh: Likewise. * t/yflags-cmdline-override.sh: Likewise. * t/yflags.sh: Likewise. * t/yflags2.sh: Likewise. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| 176d229b | 2013-05-16 14:49:44 | tests: fix some botched/outdated comments * t/ax/test-defs.in: Here. Also, fix a couple of grammaros while at it. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| 361430c0 | 2013-05-16 14:18:55 | tests: use perl, not find+rm, to remove temporary directories The File::Path::rmtree function from perl, if used right, is more reliable and more portable of our past idiom: find $dirs -type d ! -perm -700 -exec chmod u+rwx {} ';'; rm -rf $$dirs || exit 1 at least of the face of unreadable dirs/files and other similar permission issues (and we have those in our test directories). In fact, this change fixes some spurious failures seen in "make distcheck" on Solaris 10. * t/ax/deltree.pl: New. * Makefile.am (EXTRA_DIST): Add it. (clean-local-check): Use it. * t/ax/test-lib.sh (rm_rf_): Use it. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| 9c468420 | 2013-05-16 13:36:49 | tests: remove remaining exec bits ('maint' branch) The executable bit gives the impression that the tests are directly runnable, as with "./t/foo.sh", but it has been a while since that was the case. Today, tests are runnable only through "make check" or "./runtest". This change is for the 'maint' branch (automake 1.13a), and is a follow-up to commit 'v1.13.2-3-g74017b5', done on the 'micro' branch (automake 1.13.2a). It will soon be followed by a similar patch for the 'master' branch (automake 1.99a). * t/am-prog-cc-c-o.sh: Remove executable bit. * t/ccnoco4.sh: Likewise. * t/dist-shar.sh: Likewise. * t/dist-tarZ.sh: Likewise. * t/lex-multiple.sh: Likewise. * t/preproc-basics.sh: Likewise. * t/preproc-c-compile.sh: Likewise. * t/preproc-demo.sh: Likewise. * t/preproc-errmsg.sh: Likewise. * t/rm-f-probe.sh: Likewise. * t/self-check-cc-no-c-o.sh: Likewise. * t/txinfo-builddir.sh: Likewise. * t/txinfo-nodist-info.sh: Likewise. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| 6aaa128d | 2013-05-16 13:35:45 | Merge branch 'micro' into maint * micro: tests: remove exec bit from all of them ('micro' branch) maint: tests no longer need to have executable bit set | ||
| 74017b56 | 2013-05-16 12:18:43 | tests: remove exec bit from all of them ('micro' branch) It gives the impression that they are directly runnable, as with "./t/foo.sh", but it has been a while since that was the case. Today, tests are runnable only through "make check" or "./runtest". This change is for the 'micro' branch (automake 1.13.2a). It will soon be followed by similar patches for the 'maint' branch (automake 1.13a) and the 'master' branch (automake 1.99a). * t/*.sh, t/*.tap: Remove executable bit. * maint.mk (sc_tests_executable): Remove. (syntax_check_rules): Adjust. * gen-testsuite-part: Set permissions of generated tests to '444' (-r--r--r--), rather than 555 (-r-xr-xr-x). Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| 48fc2d83 | 2013-05-16 12:13:32 | maint: tests no longer need to have executable bit set It has been a while since they are runnable only through "make check" or "./runtest", and not directly. * HACKING: Adjust. * t/README: Likewise, and updated the surrounding text to get rid of obsolete statements and advices. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| 5969f68e | 2013-05-16 00:21:20 | PLANS: subdir-objects: various updates Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| 52a76013 | 2013-05-15 22:54:15 | Merge branch 'micro' into maint * micro: post-release: micro version bump (1.13.2a) release: stable micro release 1.13.2 vala tests: skip in a cross compiler setup HACKING: miscellaneous fixes, updates and enhancements NEWS: minor improvements to wording (about new versioning scheme) Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| e89b9083 | 2013-05-15 22:44:43 | post-release: micro version bump (1.13.2a) * configure.ac, m4/amversion.m4: Bump version: 1.13.2 -> 1.13.2a Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| 21824fbc | 2013-05-15 19:43:39 | release: stable micro release 1.13.2 * configure.ac (AC_INIT): Bump version number to 1.13.2. * m4/amversion.m4: Likewise (auto-updated by "make bootstrap"). Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| 4348577b | 2013-05-15 22:05:21 | vala tests: skip in a cross compiler setup The "vala + pkg-config" doesn't interact well with cross-compilation: <https://mail.gnome.org/archives/vala-list/2012-September/msg00094.html> That is causing annoying failures in our testsuite when it's run in cross-compilation mode. It's not worth trying too be overly smart and work around these problems; just skip the affected tests instead. * t/ax/am-test-lib.sh (require_tool): A new requirement 'valac', telling that the test needs to compile Vala-generated C files. In particular, this causes the test to be skipped when using a cross-compiler. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| 3a4c7cf9 | 2013-05-15 19:34:41 | HACKING: miscellaneous fixes, updates and enhancements Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| 1a05e925 | 2013-05-15 19:13:13 | NEWS: minor improvements to wording (about new versioning scheme) Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| 563ecade | 2013-05-15 15:55:44 | THANKS: update Akim's e-mail address Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| 7810a65d | 2013-05-14 15:50:12 | tests: less uses of "make -e"; avoid spurious failures in 'check-cc-no-c-o' That is, when the testsuite is run using a fake C compiler that doesn't grasp the '-c' and '-o' options together. * t/instdir-prog.sh: Adjust. * t/instdir-ltlib.sh: Likewise. * t/python-virtualenv.sh: Likewise. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| c6b827b2 | 2013-05-14 14:18:00 | build: be more respectful of user-specified verbosity * t/Makefile.in (check-cc-no-c-o, check-no-trailing-backslash-in-recipes, installcheck-testsuite, perf): Here. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| cce6192b | 2013-05-14 13:40:48 | check-cc-no-c-o: unify initializations in a single place * t/ax/test-defs.in: That is, by setting CC and GNU_CC here, in accord with the value of the variable 'AM_TESTSUITE_SIMULATING_NO_CC_C_O'. * t/Makefile.in (check-cc-no-c-o) : No need to reset CC and GNU_CC any longer in the recursive "make check" invocation. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| 6653939c | 2013-05-14 13:17:50 | check-cc-no-c-o: avoid a spurious failure * t/am-prog-cc-c-o.sh: In this test, by relying on the knowledge that we are running under the aegis of the 'check-cc-no-c-o' maintainer-specific target, knowledge given us by ... * t/Makefile.in (check-cc-no-c-o) : ... the new environment variable 'AM_TESTSUITE_SIMULATING_NO_CC_C_O', set to a value of "yes" by this rule. * t/ax/test-defs.in: Initialize the new variable to "no" by default, and add an explanatory comment. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| e142bcb0 | 2013-05-14 12:12:44 | build: fixup for building in a VPATH setup * bin/Makefile.inc (%D%/automake, %D%/aclocal): Make sure that the directory where the targets scripts are going to be built exists, before trying to create said scripts. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| c148dc73 | 2013-05-11 11:45:16 | Use AC_DEFUN_ONCE to define AM_PROG_CC_C_O If AM_PROG_CC_C_O is expanded multiple times, and the compiler does not support -c and -o together, each expansion of the macro will prepend the compile script to CC. This can result in the compile script invoking the compile script, which at best pointless and silly. Fortunately, there does not appear to be any serious problems as the first compile invocation strips out -o options, causing subsequent invocations of the script to merely exec their arguments. Other than fixing the above, this should not normally cause any changes to the resulting configure script, except in the (hopefully rare) case where AM_PROG_CC_C_O is directly expanded (i.e., *not* using AC_REQUIRE) in the body of a macro defined with AC_DEFUN. In that case, the use of AC_DEFUN_ONCE may cause the expansion of AM_PROG_CC_C_O to appear earlier in the configure script. * m4/minuso.m4: Change the definition of AM_PROG_CC_C_O to use AC_DEFUN_ONCE, avoiding problems caused by multiple expansions. Copyright-paperwork-exempt: yes Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| 32eb770b | 2013-05-11 11:03:41 | compile: avoid AC_PROG_CC messy rewrite Instead, add an hook to AC_OUTPUT to have AM_PROG_CC_C_O invoked automatically. See also the long-winded discussion about automake bug#13378. * m4/minuso.m4 (AM_PROG_CC_C_O): Bring back the old implementation, from commit v1.13.1-55-g1ab8fb6. * m4/init.m4 (AC_PROG_CC): Remove this horrible, hacky re-write. * (AM_INIT_AUTOMAKE): Arrange for AM_PROG_CC_C_O to be called if necessary. * t/am-prog-cc-c-o.sh: Adjust to avoid spurious failure. * t/subobj.sh: Likewise. Suggested-by: Nick Bowler <nbowler@elliptictech.com> Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| f233bf8f | 2013-05-11 10:25:33 | options: tiny simplification in dealing with incompatible versions * lib/Automake/Options.pm (_process_option_list): Here, when an incompatible version number option is detected, there's no need to call error() with the "uniq_scope => US_GLOBAL" switch. In fact, if the same incompatible version number is specified in AUTOMAKE_OPTIONS in both (say) 'Makefile.am' and 'sub/Makefile.am', we want each such erroneous usage reported separately, rather than just the first time it is encountered (as we'd expect to happen when "uniq_scope => US_GLOBAL" is used). Ideally, this change should have been folded into the similar commit 'v1.13.1d-129-gf7ef16f', but we noticed that too late. Oh well. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| 9f21b55d | 2013-05-11 00:28:15 | options: try to report as much errors as possible For example, if two invalid options are used in AUTOMAKE_OPTIONS, don't report just the first one, but both of them. * lib/Automake/Options.pm (_process_option_list): Do so by avoiding early returns in here. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| 421f0ad9 | 2013-05-11 00:16:14 | Merge branch 'branch-1.13.2' into maint * branch-1.13.2: warns: don't tell AM_PROG_MKDIR_P is going to be removed | ||
| 74be388e | 2013-05-10 23:59:02 | warns: don't tell AM_PROG_MKDIR_P is going to be removed That is no longer true. For a more extended rationale, see file 'PLANS/obsolete-removed/am-prog-mkdir-p.txt' in the maint branch (as of commit v1.13.1d-132-g90ec3fe). * automake.in (scan_autoconf_traces): So adjust the warning message here. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| 90ec3fe5 | 2013-05-10 23:50:25 | refactor: fix few "inverted boolean" usages In some subroutines, we used a return value of 0 to indicate success, and a return status of 1 to indicate failure. That was not very consistent with the perl interpretation of 0 as a false value and 1 as a true value. So we now invert the meaning of the exit statuses. * lib/Automake/Options.pm (_process_option_list): Here. (process_global_option_list, process_option_list): And by reflex, here as well. * bin/automake.in (handle_options): And here. (generate_makefile, scan_autoconf_traces): Adjust. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| 9a0d4868 | 2013-05-10 23:29:04 | options: better name for an internal function * lib/Automake/Options.pm (_option_must_be_from_configure): Rename ... (_option_is_from_configure): ... like this. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| 117ddf8d | 2013-05-10 23:08:28 | options: more consistency in use of return statuses to report errors * lib/Automake/Options.pm (_option_must_be_from_configure): By giving a proper return status here. (_process_option_list): And using it here. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| f7ef16fe | 2013-05-10 23:01:27 | options: tiny simplification in dealing with erroneous opts * lib/Automake/Options.pm (_process_option_list): Here, when an invalid option is detected, there's no need to call &error with the "uniq_scope => US_GLOBAL" switch. In fact, if the same erroneous option is specified in AUTOMAKE_OPTIONS in both (say) 'Makefile.am' and 'sub/Makefile.am', we want each such erroneous usage reported separately, rather than just the first time it is encountered (as happens when "uniq_scope => US_GLOBAL" is used). Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| 6e486c5d | 2013-05-10 22:50:54 | options: consistently use return statuses to report errors * lib/Automake/Options.pm (_process_option_list): Here. (process_option_list, process_global_option_list): Remove redundant use of 'return'. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| b636268a | 2013-05-10 22:34:21 | options: re-enable some sanity checks They had been unwittingly disabled by a slightly incorrect code ordering. * lib/Automake/Options.pm (process_option_list): Here. (process_global_option_list): And here. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| efa6880f | 2013-05-10 22:19:03 | THANKS: update Eric Blake's e-mail address Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| b602d99c | 2013-05-10 22:17:43 | NEWS: typofix Reported-by: Eric Blake <eblake@redhat.com> Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| 7a2ff99d | 2013-05-10 21:17:30 | news: document new 'subdir-objects' warning * NEWS: Automake 1.14 will warn if a subdir source file is specified but the 'subdir-objects' option is not given. This is done to smooth the transition to Automake 2.0, which will unconditionally assume the behaviour now given only with the 'subdir-objects' option. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| 0fd44c9b | 2013-05-10 20:56:07 | PLANS: one minor fixlet (mostly cosmetic) Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| ebadaac0 | 2013-05-10 20:52:36 | PLANS: we have already dropped support for split info files in master Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| 0709f52f | 2013-05-10 20:35:21 | NEWS: fix a reference to Automake 1.14 where Automake 2.0 was intended Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| c0e30c4f | 2013-05-10 20:09:42 | PLANS: fix reference to non-existent 'next' branch * PLANS/obsolete-removed/configure.in.txt: Here. We should refer to the 'master' branch instead. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| cfba5c03 | 2013-05-10 20:06:08 | PLANS: fix botched version reference * PLANS/rm-f-without-args.txt: Here. The probe checking that "rm -f" without arguments works will be introduced in Automake 1.14, not in Automake 1.13.2. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| 05703b1a | 2013-05-10 19:32:20 | maintcheck: fix two references to old location of aclocal and automake * maintainer/syntax-checks.mk (sc_perl_at_substs): Here: it should refer to 'bin/automake' and 'bin/aclocal', not 'automake' and 'alocal'. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| 780299d9 | 2013-05-10 19:22:06 | dist: deprecated shar and tar+compress formats See also discussion about automake wishlist bug#13324. * lib/Automake/Options.pm: Give proper warnings in the 'obsolete' category if the 'dist-shar' or 'dist-tarZ' options are used. * lib/distdir.am: When the 'dist-tarZ' or 'dist-shar' targets are invoked, make them give a non-fatal warning. * doc/automake.texi: Report the new deprecations. * t/dist-shar.sh: New test. * t/dist-tarZ.sh: Likewise. * t/lzma.sh: While at it, rename ... * t/dist-lzma.sh: ... like this, and tweak it to keep more in sync with the new tests. * t/dist-formats.tap: Remove references to deprecated formats. * t/list-of-tests.mk: Adjust. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| 0736c67c | 2013-05-10 13:31:59 | Merge branch 'dog-feeding' into maint * dog-feeding: build: move automake and aclocal in 'bin' subdir build: break up monolithic Makefile.am in subdir-specific fragments | ||
| 2df8f3fe | 2013-05-10 13:31:45 | Merge branch 'branch-1.13.2' into maint * branch-1.13.2: automake: typofix in comments: s/AC_CONFIG_HEADER/AC_CONFIG_HEADERS/ | ||
| a5a167fc | 2013-05-10 12:13:00 | automake: typofix in comments: s/AC_CONFIG_HEADER/AC_CONFIG_HEADERS/ Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| 126cd524 | 2013-05-10 10:57:38 | am: prefer a shorter idiom where possible That is, prefer: test -f FILE || do_action over: if test ! -f FILE; then do_action; else :; fi * lib/am/remake-hdr.am (%CONFIG_H%): Here. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| 5a37b0e7 | 2013-05-10 10:53:15 | Merge branch 'branch-1.13.2' into maint * branch-1.13.2: cosmetics: fix few typos, grammaros and missing whitespace fixup: remove an obsolete comment docs: we still don't have the promised better Java interface | ||
| 66ab18ae | 2013-05-10 10:50:05 | cosmetics: fix few typos, grammaros and missing whitespace * lib/am/*.am: In comments in some of these files. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| 53201da1 | 2013-05-10 10:35:26 | fixup: remove an obsolete comment * lib/am/header-vars.am (am__make_running_with_option): Here. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| 4ccf9a80 | 2013-05-09 20:23:40 | docs: we still don't have the promised better Java interface Reported by Michael Zucchi: <http://lists.gnu.org/archive/html/automake/2013-05/threads.html> See also automake bug#9088. * doc/automake.texi (Java): Adjust and clarify. * THANKS: Update. Reported-by: Michael Zucchi <notzed@gmail.com> Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| 1021f5cf | 2013-05-09 20:13:19 | maint: re-run "make update-copyright" ... * t/lex-multiple.sh: ... which updates the copyright years of this test (they were somehow not bumped in the past). Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| 56070294 | 2013-05-09 19:50:38 | tests: avoid spurious failure with older flex (2.5.4) That old version is unfortunately still relevant, being the one installed on NetBSD 5.1. * t/lex-multiple.sh: Use the '-o' option rather than the longer equivalent '--outfile'. The latter is not supported by older versions of flex (e.g., flex 2.5.4). Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| 25194b62 | 2013-05-09 14:14:00 | Merge branch 'branch-1.13.2' into maint * branch-1.13.2: announcement: cater to more flexible NEWS format | ||
| d2ed3559 | 2013-05-09 13:55:15 | announcement: cater to more flexible NEWS format * maint.mk (announcement): Here, be prepared to handle the case in which the first section of the NEWS file is dedicated to report future backward-incompatibilities and/or other warnings. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| ce70cf4b | 2013-05-09 11:57:20 | build: move automake and aclocal in 'bin' subdir * automake.in: Rename ... * bin/automake.in: ... like this. * aclocal.in: Rename ... * bin/aclocal.in: ... like this. * Makefile.am: Move parts that dealt with the building/distribution of aclocal and Automake .. * bin/Makefile.inc): ... in this new included fragment. Adjust as needed, and make deliberate use of the '%D%' substitution. * lib/gen-perl-protos: Move ... * bin/gen-perl-protos: ... here. * bootstrap.sh, configure.ac, maintainer/rename-tests, t/wrap/aclocal.in, t/wrap/automake.in, doc/Makefile.inc, t/ax/tap-setup.sh, .gitignore: Adjust. * maintainer/syntax-checks.mk: Likewise, and enhance a little. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| c8f106c7 | 2013-05-09 11:17:47 | build: break up monolithic Makefile.am in subdir-specific fragments This is convenient to do, now that we have improved "relative directory" support with the '%reladir%' (a.k.a. '%D%') and '%canon_reladir%' (a.k.a. '%C%') Automake-time substitutions for included makefile fragments. This move also satisfy our philosophy of using new Automake features in our own build system, as a way of facilitating early discovery of possible bugs or interface warts. * Makefile.am: Break up ... * doc/Makefile.inc, lib/Automake/Makefile.inc, lib/Makefile.inc, lib/am/Makefile.inc, m4/Makefile.inc, t/Makefile.inc): ... in this new included fragments. Adjust as needed, and make deliberate use of the '%D%' substitution. * contrib/t/local.am: Rename ... * contrib/t/Makefile.inc: ... like this. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| 1667d369 | 2013-05-05 00:53:27 | maint branch: we are going to become Automake 1.14 * configure.ac (AC_INIT): So adjust beta version in here, from 1.13.2a to 1.13a. * m4/amversion.m4: Regenerate. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| 57cb996d | 2013-05-05 00:52:01 | Merge branch 'branch-1.13.2' into maint * branch-1.13.2: maint: version bump after beta release 1.13.1d release: beta release 1.13.1d (will become 1.13.2) NEWS: document more robust handling/recognition of make options Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| 799fa256 | 2013-05-05 00:46:54 | maint: version bump after beta release 1.13.1d * configure.ac (AC_INIT): Bump version number to 1.13.1e. * m4/amversion.m4: Likewise (autoupdated by "make bootstrap"). Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| 3e6cad96 | 2013-05-04 23:19:36 | release: beta release 1.13.1d (will become 1.13.2) * configure.ac (AC_INIT): Bump version number to 1.13.1d. * m4/amversion.m4: Likewise (auto-updated by "make bootstrap"). Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| 8a11e2fd | 2013-05-04 22:58:25 | NEWS: document more robust handling/recognition of make options Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| 481c9975 | 2013-05-04 14:02:06 | tests: typofixes in comments in t/preproc-c-compile.sh Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| 9c813963 | 2013-05-04 13:59:19 | tests: remove bashism from a test * t/preproc-c-compile.sh (Makefile.am): Use "test foo = bar", not the bash-specific "test foo == bar". Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| 2d3a2e36 | 2013-05-04 11:50:10 | Merge branch 'branch-1.13.2' into maint * branch-1.13.2: maint: targets and recipes to simplify testing on real-world packages build: preparatory refactoring build: tiny reduction in code duplication make flags analysis: handle more options with args make flags analysis: use simpler variable names make flags analysis: whitespace changes make flags analysis: embed in a subshell make flags analysis: be more robust make flags analysis: cater to GNU make 3.83 (still unreleased as of now) tests: expose weaknesses in make flags analysis tests: improve debugging output in checks on make flags analysis make flags analysis: refactor, to reduce code duplication tests: avoid one tricky use of "make -e" tests: avoid a spurious error with Solaris make subdirs: don't return false positives for the '-k' option's presence header-vars: recognize more make flags ('-k' in particular) header-vars: simplify how make flags are determined tests: remove dead code from t/make-dryrun.tap header-vars: new variable $(am__running_with_option) tests: expose bug#12554 (false positives for presence of '-k' make option) | ||
| f5f75eef | 2013-05-04 11:37:09 | Merge 'better-makeflags-recognition' and 'testing-work' into branch-1.13.2 * better-makeflags-recognition: make flags analysis: handle more options with args make flags analysis: use simpler variable names make flags analysis: whitespace changes make flags analysis: embed in a subshell make flags analysis: be more robust make flags analysis: cater to GNU make 3.83 (still unreleased as of now) tests: expose weaknesses in make flags analysis tests: improve debugging output in checks on make flags analysis make flags analysis: refactor, to reduce code duplication * testing-work: maint: targets and recipes to simplify testing on real-world packages build: preparatory refactoring build: tiny reduction in code duplication | ||
| b993a265 | 2013-05-03 23:02:11 | maint: targets and recipes to simplify testing on real-world packages We introduce a new section in the maintainer-specific makefile that contains recipes to test the build system of some well-known GNU packages with the current development version of Automake. Not the cleanest way to do so, but good enough for the moment. We'll revisit the matter after the 1.13.2 release (which we now hope will happen soon). * maint.mk (git-sv-host): New. (SV_GIT_CF, SV_GIT_AC, SV_GIT_GL): Use it to reduce code duplication. (ALL_PACKAGES, FEW_PACKAGES): New, lists of GNU packages to try out. (ttp-check, ttp-check-all): New targets, do the checking with said packages. (ttp): New, alias for 'ttp-check'. (ttp-all): New, alias for 'ttp-check-all'. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| eddba1cc | 2013-05-03 21:02:42 | build: preparatory refactoring No semantic change intended. This change will be required by a later patch. * Makefile.am (setup_autotools_paths): New. ($(srcdir)/doc/amhello-1.0.tar.gz): Use it. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| dc3cdb1d | 2013-05-03 20:56:02 | build: tiny reduction in code duplication The code was only duplicated two times, but we are soon going to need a third occurrence, and that would be one to much. * Makefile.am (extend_path): New. (update_mans): Use it instead of copying & pasting its contents. ($(srcdir)/doc/amhello-1.0.tar.gz): Likewise, and minor related adjustments. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| 57925b67 | 2013-05-03 14:06:25 | make flags analysis: handle more options with args That is, not only -I, but also -O (for upcoming GNU make 3.83), -l (GNU make), -d, -E, -D, -m (BSD make), -J, -T (NetBSD make). * lib/am/header-vars.am (am__make_running_with_option): Extend and adjust, both code and comments. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| 1adb0570 | 2013-05-03 13:01:35 | make flags analysis: use simpler variable names * lib/am/header-vars.am (am__make_running_with_option): Here. Now that we expect to be run in a subshell, we don't have to worry about being namespace-safe. And '$foo' is much more pleasant to read than '$am__foo' -- and pleasant code tends to be more correct. (am__make_dryrun, am__make_keepgoing): Adjust. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| 6d643e93 | 2013-05-03 12:52:14 | make flags analysis: whitespace changes * lib/am/header-vars.am (am__make_running_with_option): Here. No semantic change is intended. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| 5c4aaae2 | 2013-05-03 12:47:59 | make flags analysis: embed in a subshell So that we won't have to worry about leaking temporary variables, and similar stuff. * lib/am/header-vars.am (am__make_dryrun, am__make_keepgoing): Here. (am__make_running_with_option): Minor adjustments. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| b62616b3 | 2013-05-02 19:41:24 | make flags analysis: be more robust In particular, catering to option-with-argument bundled together with options-without-arguments, as in: # With GNU make 3.82: $ make -f- <<<'all:; echo "$$MFLAGS"' -s -k -I none -skiI none # With development version of GNU make (Git commit b5ea49b): $ make -f- <<<'all:; @echo "$$MFLAGS"' -I none -skiI none This fixes some lingering failures in the testsuite; precisely, in tests 'make-dryrun.tap' and 'make-keepgoing.tap'. * t/header-vars.am (am__make_running_with_option): Enhance. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| c93bc3d4 | 2013-05-02 01:10:13 | make flags analysis: cater to GNU make 3.83 (still unreleased as of now) The current development version of GNU make (that is planned to become GNU make 3.83, sooner or later) has changed the format its $(MFLAGS) variable slightly, removing the space between an option and its argument: # With GNU make 3.82, compiled from official tarball: $ make -f- <<<'all:; @echo "$$MFLAGS"' -I none -I none # With development version of GNU make (Git commit b5ea49b): $ make -f- <<<'all:; @echo "$$MFLAGS"' -I none -Inone This was done on purpose, in order to support more easily the new option '-O', which takes an optional argument; see: <http://lists.gnu.org/archive/html/bug-make/2013-05/msg00001.html> So Just adapt to the new format as well. * t/header-vars.am (am__make_running_with_option): Adjust to cater to the new GNU make behaviour. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| 7aa99186 | 2013-05-02 00:43:33 | tests: expose weaknesses in make flags analysis This introduces some failures in the testsuite, that will be fixed soon enough by follow-up patches. * t/make-dryrun.tap: Enhance and extend. * t/make-keepgoing.tap: Likewise. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| d017b54b | 2013-05-02 00:27:46 | tests: improve debugging output in checks on make flags analysis * t/make-dryrun.tap: Here. * t/make-keepgoing.tap: And here. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| e242b44e | 2013-05-01 23:26:42 | make flags analysis: refactor, to reduce code duplication And make it a little more reliable. * t/header-vars.am (am__make_running_with_option): Here. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| 425fe1e8 | 2013-05-01 17:06:42 | tests: avoid one tricky use of "make -e" Which was causing a spurious failure on FreeBSD. Not particularly surprising, given how brittle "make -e" is in general ... * t/cxx-lt-demo.sh: Instead of forcing $(CC) to be 'false' by exporting "CC=false" in the environment and then passing the '-e' option to make, do so by passing "CC=false" on the make command line, both directly and using AM_MAKEFLAGS. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| d432f067 | 2013-04-30 23:55:47 | Merge branch 'fix-pr12554' into branch-1.13.2 * fix-pr12554: tests: avoid a spurious error with Solaris make subdirs: don't return false positives for the '-k' option's presence header-vars: recognize more make flags ('-k' in particular) header-vars: simplify how make flags are determined tests: remove dead code from t/make-dryrun.tap header-vars: new variable $(am__running_with_option) tests: expose bug#12554 (false positives for presence of '-k' make option) | ||
| e5e3a629 | 2013-04-30 23:03:50 | Merge branch 'branch-1.13.2' into maint * branch-1.13.2: cosmetics: remove few trailing whitespace occurrences typofix: in NEWS (extra whitespace) | ||
| 6d3ffeb9 | 2013-04-30 23:00:53 | cosmetics: remove few trailing whitespace occurrences Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| 8430d412 | 2013-04-30 22:59:30 | typofix: in NEWS (extra whitespace) Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| 96b1303d | 2013-04-30 15:35:46 | Merge branch 'branch-1.13.2' into maint * branch-1.13.2: sync: update files from upstream with "make fetch" maintcheck: remove outdated whitelisting tar: format 'ustar' cannot support UID/GID longer than 21 bits Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| 2a40fa71 | 2013-04-30 14:48:45 | Merge branch 'fix-pr13588-pax-hangs' into branch-1.13.2 * fix-pr13588-pax-hangs: tar: format 'ustar' cannot support UID/GID longer than 21 bits | ||
| 5a29f7aa | 2013-04-29 20:43:02 | tests: avoid a spurious error with Solaris make * t/make-keepgoing.tap (Makefile.am): Here. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| 02ead48e | 2013-04-29 16:12:34 | subdirs: don't return false positives for the '-k' option's presence This change fixes automake bug#12554. The old implementation of the code descending into $(SUBDIRS) entries used the following snippet to decide whether make is running with the '-k' a.k.a. '--keep-going' option, and thus whether a failure in a subdirectory should prevent the descent in the following ones: fail= failcom='exit 1'; \ for f in x $$MAKEFLAGS; do \ case $$f in \ *=* | --[!k]*);; \ *k*) failcom='fail=yes';; \ esac; \ done It's clear that the second pattern in the 'case' construct could possibly match false positives, for examples in these two cases: make check TESTS="x.test k.test" make -I /usr/local/kool-fragments which are somewhat unusual, but not invalid. So we need a more resilient implementation, as we did for the detection of the '-n' flag. This implementation is now provided by the new private macro '$(am__make_keepgoing)' (introduced in recent commits); so we can just us that to fix the bug. * lib/am/subdirs.am ($(am__recursive_targets)): Use '$(am__make_keepgoing)' instead of ad-hoc and more brittle checks. * t/list-of-tests.mk (XFAIL_TESTS): Remove the now-passing test case 't/subdir-keep-going-pr12554.sh'. Reported-by: Michael Daniels <mdaniels@rim.com> Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| 69f77915 | 2013-04-29 15:22:10 | header-vars: recognize more make flags ('-k' in particular) * lib/am/header-vars.am (am__running_with_option): Here. Few improvements to comments, while at it. (am__make_keepgoing): New, tell whther make is being runt with the '-k' option. * t/make-keepgoing.tap: New test. * t/list-of-tests.mk: Add it. * t/make-dryrun.tap: Minor edits to keep it more in sync with the new test. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| f6338e8c | 2013-04-29 16:44:00 | sync: update files from upstream with "make fetch" * lib/config.guess: Likewise. * lib/config.sub: Likewise. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| ba7b59bf | 2013-04-29 16:39:47 | maintcheck: remove outdated whitelisting * syntax-checks.mk (sc_tests_overriding_macros_on_cmdline): Here. The test 'make-dryrun.sh' has been since long rewritten as the TAP test 'make-dryrun.tap', and no longer spuriously triggers this maintainer check. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| e432b0d3 | 2013-04-27 16:09:43 | header-vars: simplify how make flags are determined Actually, son far only the '-n' option ("dry mode") was detected, but this change will allow us to soon detect more options. * lib/am/header-vars.am (am__running_with_option): Even when $MAKEFLAGS appears to contain definition of variables with embedded whitespace, use simple textual pre-processing over $MAKEFLAGS rather than tricky recursive invocations of make to determine whether the '-n' option was given. This is enough to correctly handle all the tricky usages covered in the testsuite. * t/nodep.sh: Adjust to avoid a spurious failure. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| c97218a5 | 2013-04-27 15:49:52 | tests: remove dead code from t/make-dryrun.tap Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| 6eedee4c | 2013-04-27 15:25:06 | header-vars: new variable $(am__running_with_option) This is a preparatory refactoring, needed by later patches. No semantic change is intended. * lib/am/header-vars.am (am__running_with_option): New, contains shell code that determines whether the current make instance is running with a given one-letter option (e.g., -k, -n) that takes no argument. Actually, the only supported option at the moment is '-n' (support for '-k' will be added soon). (am__make_dryrun): Rewrite as a thin wrapper around '$(am__make_running_with_option)'. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| cbf23ceb | 2012-10-02 21:27:28 | tests: expose bug#12554 (false positives for presence of '-k' make option) The current implementation of the code descending into $(SUBDIRS) entries uses the following snippet to decide whether make is running with the '-k' a.k.a. '--keep-going' option, and thus whether a failure in a subdirectory should prevent the descent in the following ones: fail= failcom='exit 1'; \ for f in x $$MAKEFLAGS; do \ case $$f in \ *=* | --[!k]*);; \ *k*) failcom='fail=yes';; \ esac; \ done It's clear that the second pattern in the 'case' construct can possibly match false positives, for examples in these two cases: make check TESTS="x.test k.test" make -I /usr/local/kool-fragments which are somewhat unusual, but not invalid. So we need a more resilient implementation, as we did for the detection of the '-n' flag. But alas, such an implementation seems quite tricky to obtain in portable make. So for the moment we content ourselves with exposing the bug, with the hope of being able to fix soon enough. * t/subdir-keep-going-pr12554.sh: New test. * t/list-of-tests.mk (handwritten_TESTS, XFAIL_TESTS): Add it. * THANKS: Update Reported-by: Michael Daniels <mdaniels@rim.com> Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| edfd3bc4 | 2013-02-17 16:42:46 | tar: format 'ustar' cannot support UID/GID longer than 21 bits See automake bug#8343 and bug#13588. POSIX 1988 'ustar' format is defined with *fixed-size* fields. There is notably a 21 bits limit (2097151) for the UID and the GID. Tom Rini tom_rini@mentor.com says (in bug#8343): When the user has a UID or GID that is larger than the ustar format supports, pax does not error out gracefully in some cases (FC13). Marc Herbert <marc.herbert@intel.com> adds (in bug#8343): When "configure" is run by a user with an UID bigger than 21 bits, BSD pax 3.4 aborts when trying to create the 'conftest.tar' test archive and leaves an empty or corrupted conftest.tar file behind. In the next step, pax tries to extract this incomplete or corrupted archive and this *** hangs the whole ./configure script ***. Note: GNU cpio 2.9 pretends to pass the test but it is a LIE: it silently truncates any big UID to its lower 21 bits. I don't know what can be the consequences of this lie. I think there is currently a design issue in automake/m4/tar.m4 considering that a ustar archive should should *never* succeed when ./configure is run from a big user ID. Months later, Petr Hracek <phracek@redhat.com> reports a similar issue (in bug#13588) for Fedora 17: I am trying to solve problem in case a user is created with big UID and during configuration pax hangs with message ATTENTION! pax archive volume change required. Ready for archive volume: 1 Input archive name or "." to quit pax. Archive name > and needs user interaction. Reference: <https://bugzilla.redhat.com/show_bug.cgi?id=843376> Time to fix this issue, on the line of a preliminary patch provided by Petr Hracek in bug#13588. The final patch ended up being remarkably different from that original proposition, though. * m4/tar.m4 (_AM_PROG_TAR): If the UID or GID of the current user is too high (> 2097151), the 'ustar' format cannot work. Adjust checks accordingly. Some related code reordering and clean-up. * t/tar-ustar-id-too-high.sh: New test. * t/list-of-tests.mk: Add it. * t/tar.sh: While at it, tweak and enhance a little. * t/tar2.sh: Likewise. * t/tar3.sh: Likewise. * t/tar-override.sh: Likewise. * NEWS: Update. * THANKS: Likewise. Helped-by: Pavel Raiskup <praiskup@redhat.com> Helped-by: Petr Hracek <phracek@redhat.com> Helped-by: Marc Herbert <marc.herbert@intel.com> Helped-by: Tom Rini <tom_rini@mentor.com> Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com> | ||
| f0d1288f | 2013-04-26 20:39:40 | Merge branch 'branch-1.13.2' into maint * branch-1.13.2: docs: issues with configure substitutions in TESTS tests: avoid possible autotools caching issues (automake bug#13832) docs: add myself and Ralf Wildenhues as authors authors: add myself dry-run: don't get confused by '-I' option tests: avoid a spurious failure with the Korn Shell dry-run: with GNU make, prefer $(MFLAGS) over $(MAKEFLAGS) header vars: can determine whether we are running under GNU make NEWS: improve wording for automake bug#13514 fix NEWS: document fix for automake bug#13514 |