Log

Author Commit Date CI Message
Behdad Esfahbod 40d5d19d 2018-10-02T17:04:05 [ragel] Use ts/te (token-start / token-end) instead of manual tracking
Behdad Esfahbod 9efddb9d 2018-10-02T16:05:26 Treat a base+mark... ligature as base, not ligature Fixes https://github.com/harfbuzz/harfbuzz/issues/746
Behdad Esfahbod 3cca9787 2018-10-02T15:02:16 Move code around
Behdad Esfahbod 0a371fee 2018-10-02T14:48:39 Minor
Behdad Esfahbod 94d15528 2018-10-02T14:45:09 Minor
Behdad Esfahbod 729f6347 2018-10-02T14:40:14 Disable joiner-skipping when looking back for base to attach mark to Fixes https://github.com/harfbuzz/harfbuzz/issues/1189
Behdad Esfahbod c36f3f5b 2018-10-02T14:34:29 [arabic] Use manual-zwj instead of flipping joiners
Behdad Esfahbod 48c513fe 2018-10-02T14:17:42 Minor
Behdad Esfahbod cca757ae 2018-10-02T13:27:11 Minor
Behdad Esfahbod 96eca87f 2018-10-02T13:24:40 Move things
Behdad Esfahbod 588a4ac8 2018-10-02T13:13:47 Rename
Behdad Esfahbod 10b6c7c6 2018-10-02T13:11:18 Minor include cleanup
Behdad Esfahbod 1d1734e9 2018-10-02T13:04:05 Shuffle code around
Ebrahim Byagowi bf5088b3 2018-10-02T11:07:06 Minor, fix -Weverthing bot warnings (#1210)
Khaled Hosny d27e5ec3 2018-10-02T08:25:29 Skip BOM in the Python sample file Fixes https://github.com/harfbuzz/harfbuzz/issues/1208
HinTak f9ea3dc4 2018-10-02T06:43:06 Missing "out" indicator (#1209) Missing "out" indicator. Affect gobject introspection.
Ebrahim Byagowi 9742679b 2018-10-02T03:20:48 [circleci] Remove some of the not needed flags
Ebrahim Byagowi f72b7483 2018-10-02T00:16:08 [circleci] Fix "msan" and "everything" bots (#1205)
Behdad Esfahbod 8bf4027d 2018-10-01T20:05:00 [indic] Remove Consonant_Medial from grammar and code The only Indic CM is U+0A75 GURMUKHI SIGN YAKASH, which Uniscribe doesn't treat specially, and font designers design for that. So, do the same.
Behdad Esfahbod ab4c37f7 2018-10-01T19:35:48 [khmer] Add mark-ordering tests Fixes https://github.com/harfbuzz/harfbuzz/issues/667
Behdad Esfahbod 51436547 2018-10-01T19:09:58 [khmer] Rewrite grammar completely Based on experimenting with Uniscribe to extract grammar and categories. Failures down from 44 to 35: KHMER: 299089 out of 299124 tests passed. 35 failed (0.0117008%) We still don't enforce the one-matra rule pre-decomposition, but enforce an order and one-matra-per-position post-decomposition. https://github.com/harfbuzz/harfbuzz/issues/667
Behdad Esfahbod aaaa65ba 2018-10-01T16:59:48 [khmer] Remove unused code
Behdad Esfahbod eb1e6028 2018-10-01T15:31:50 [test] Try import unicodedata2 as unicodedata
Behdad Esfahbod 81afdbe8 2018-10-01T15:01:04 [use] Disable automatic ZWJ for 'akhn' feature Fixes https://github.com/harfbuzz/harfbuzz/issues/746
Behdad Esfahbod ceef311d 2018-10-01T12:45:06 [use] Change categories for Left_And_* matras These are only relevant to Sinhala, because they decompose in other cases. The USE spec categorizes them all as VPst. No idea why we weren't following that before.
Behdad Esfahbod 3426a361 2018-10-01T12:55:57 Unbreak bots
Behdad Esfahbod 98ac01d3 2018-10-01T12:10:00 [morx] Break out if buffer gets into error Was getting stuck not making progress somehow.
Behdad Esfahbod df827a6a 2018-10-01T11:34:20 [cache] Fix cache coherency corner-case If key_bits+value_bits-cache_bits==32 then -1 is ambiguous...
Ebrahim Byagowi 0fa1edbd 2018-10-01T09:40:29 [circleci] Couple of fixes (#1200) * Raise error on warnings on -everything * Enable fontconfig to two bots * Fix msan bot now that all of its real complain are gone
Behdad Esfahbod 3babb081 2018-09-30T20:02:30 [msan] Disable icu explicitly
Behdad Esfahbod dc9b47ae 2018-09-30T18:35:12 [msan] Remove uninstrumented libraries
Behdad Esfahbod ad1c190e 2018-09-30T18:26:45 Correct fix for glib-mkenum warning
Behdad Esfahbod 1dd1e56b 2018-09-30T18:25:58 Revert "Fix glib-mkenum warning" This reverts commit 247756a7d89008ee6a7d1171dc07ba22454c6034. Was wrong. Right fix coming.
Behdad Esfahbod 3f08750f 2018-09-30T18:23:34 Move _POSIX_SOURCE to hb.hh
Behdad Esfahbod 90dd255e 2018-09-30T18:19:54 Change _HB_SCRIPT_MAX_VALUE from 0xFFFFFFFF to 0x7FFFFFFF Fixes https://github.com/harfbuzz/harfbuzz/issues/504
Behdad Esfahbod dcfcb950 2018-09-30T18:14:50 [test] Fix -Wunused-parameter warnings
Behdad Esfahbod be0b2ed3 2018-09-30T18:01:20 More warning fixes
Behdad Esfahbod 5c65ed80 2018-09-30T17:48:55 Fix bug introduced in 9b0b40b3c1ac8155c80ed5dc976228f4d3ec7e1f Also discovered by msan bot.
Behdad Esfahbod 247756a7 2018-09-30T13:10:54 Fix glib-mkenum warning GEN hb-gobject-enums.h WARNING: Failed to parse "/*< private >*/" in ../../src/hb-buffer.h
Ebrahim Byagowi 0a89f957 2018-09-30T17:44:15 [circleci] Pass ‌freetype compile flags to right place
Ebrahim Byagowi ad701f05 2018-09-30T17:30:42 [circleci] Use an instrumented freetype on msan bot
Ebrahim Byagowi 57aabbc2 2018-09-30T16:31:28 [circleci] Another on fixing msan
Ebrahim Byagowi 24f148df 2018-09-30T14:46:56 [circleci] minor
Ebrahim Byagowi 0a9aab67 2018-09-30T14:45:43 [circleci] Try to fix msan bot
Behdad Esfahbod b5285b34 2018-09-30T12:23:01 [util] Remove unneeded virtual clang warning: ../../util/options.hh:72:13: warning: destination for this 'memset' call is a pointer to dynamic class 'option_parser_t'; vtable pointer will be overwritten [-Wdynamic-class-memaccess] memset (this, 0, sizeof (*this)); ~~~~~~ ^ ../../util/options.hh:72:13: note: explicitly cast the pointer to silence this warning memset (this, 0, sizeof (*this)); ^ (void*)
Behdad Esfahbod 89ed040b 2018-09-30T06:06:26 [util] Fix more non-virtual-destructor warnings
Behdad Esfahbod 2382dd07 2018-09-30T05:54:47 Minor
Behdad Esfahbod 9caa432d 2018-09-30T05:49:08 [util] Use HB_FALLTHROUGH Sure, gcc knows to warn about this as well: ../../util/options.cc:175:17: warning: this statement may fall through [-Wimplicit-fallthrough=] case 1: m.r = m.t; ~~~~^~~~~ ../../util/options.cc:176:5: note: here case 2: m.b = m.t; ^~~~ But HOLY SMOKES, look at clang -Weverything bot message: options.cc:176:5: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough] case 2: m.b = m.t; ^ options.cc:176:5: note: insert 'HB_FALLTHROUGH;' to silence this warning case 2: m.b = m.t; ^ HB_FALLTHROUGH; Right, it's telling me to insert "HB_FALLTHROUGH;" there!!!!!!!!!
Behdad Esfahbod 2e728a7d 2018-09-30T05:47:36 [util] Mark var static From clang -Weverything bot: options.cc:39:3: warning: no previous extern declaration for non-static variable 'supported_font_funcs' [-Wmissing-variable-declarations]
Behdad Esfahbod e910a1ae 2018-09-30T05:46:20 [util] Add empty virtual destructor to option_group_t From clang -Weverything bot: ./options.hh:57:8: warning: 'option_group_t' has virtual functions but non-virtual destructor [-Wnon-virtual-dtor] struct option_group_t ^
Behdad Esfahbod b1e07e1e 2018-09-30T05:43:22 [indic/khmer] Remove use of global constructors Alternative woul have been to resurrect F_COMBINE that I removed in 70136a78cb9eda244767f8e8a3d30d0f3c569d01 But this does it for now. I'm not sure why check-static-inits.sh didn't catch this before. Clang -Weverything bot did: CXX libharfbuzz_la-hb-ot-shape-complex-indic.lo hb-ot-shape-complex-indic.cc:99:1: warning: declaration requires a global constructor [-Wglobal-constructors] indic_features[] = ^ 1 warning generated. CXX libharfbuzz_la-hb-ot-shape-complex-khmer.lo hb-ot-shape-complex-khmer.cc:36:1: warning: declaration requires a global constructor [-Wglobal-constructors] khmer_features[] = ^ 1 warning generated.
Behdad Esfahbod 00cd00e6 2018-09-30T05:34:30 Tweak HB_TAG and HB_UNTAG uint32_t was getting promoted to signed int, which is not what we wanted... Wow, clang has become good at generating warnings... ../../src/hb-common.h:349:29: warning: signed shift result (0xFF000000) sets the sign bit of the shift expression's type ('int') and becomes negative [-Wshift-sign-overflow] _HB_SCRIPT_MAX_VALUE = HB_TAG_MAX, /*< skip >*/ ^~~~~~~~~~ ../../src/hb-common.h:93:20: note: expanded from macro 'HB_TAG_MAX' define HB_TAG_MAX HB_TAG(0xff,0xff,0xff,0xff) ^~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../src/hb-common.h:89:57: note: expanded from macro 'HB_TAG' define HB_TAG(c1,c2,c3,c4) ((hb_tag_t)((((uint8_t)(c1))<<24)|(((uint8_t)(c2))<<16)|(((uint8_t)(c3))<<8)|((uint8_t)(c4)))) ~~~~~~~~~~~~~~~^ ~~ ../../src/hb-common.h:349:3: warning: ISO C restricts enumerator values to range of 'int' (4294967295 is too large) [-Wpedantic] _HB_SCRIPT_MAX_VALUE = HB_TAG_MAX, /*< skip >*/ ^ ~~~~~~~~~~
Behdad Esfahbod 8a31e406 2018-09-30T05:27:39 [font] Make *_advance() fallback to *_advances And remove redundant implementations.
Behdad Esfahbod bd07d287 2018-09-30T03:54:40 Use buffer scratch_flags to remember if we had any joiners
Behdad Esfahbod ba0f0f15 2018-09-30T03:49:52 Document setlocale() threadsafety issue "Fixes" //github.com/harfbuzz/harfbuzz/issues/1191
Ebrahim Byagowi 06be2aa9 2018-09-30T00:15:25 [ci] Build glib and freetype and enable msan bot (#1198)
Ebrahim Byagowi cefdef02 2018-09-29T10:19:54 Minor on test-multithread, align the actual and expected results
Ebrahim Byagowi 678beff6 2018-09-29T10:16:14 [circleci] Add -Wno-reserved-id-macro to clang-everything
Behdad Esfahbod c763b944 2018-09-28T20:53:07 [test-multithread] Disable FreeType funcs
Behdad Esfahbod 9b0b40b3 2018-09-28T11:16:18 Fix fallback kerning to check for current glyph's mask
Ebrahim Byagowi 909a07b5 2018-09-29T03:10:13 [circleci] Improve clang-everything bot log, more to come #1196
Ebrahim Byagowi 9be8062b 2018-09-29T02:11:05 [ci] Another try on mingw bot
Ebrahim Byagowi d4d261a9 2018-09-29T01:57:50 [ci] Another try on fixing mingw bots Per https://github.com/Alexpux/MSYS2-packages/issues/163#issuecomment-73555971
Ebrahim Byagowi 7b68edf2 2018-09-28T20:53:48 [tests] Don't try to get glyph names on failures As it may cause a race unrelated to the issue actually happened
Ebrahim Byagowi d289d638 2018-09-28T20:47:21 [ci] Trying to fix mingw bot As https://github.com/Alexpux/MSYS2-packages/issues/702
Behdad Esfahbod 33231a85 2018-09-28T11:06:49 Fix pthread fail for real Using a hack...
Behdad Esfahbod 8cb8209c 2018-09-28T10:55:28 Fix bot fails
Behdad Esfahbod f4072e8c 2018-09-28T10:14:23 [morx] Remove mark_set from Insertion text-rendering-tests test MORX-32 shows that for Insertion, an unset mark is treated as mark set at 0. This is unlike the Reordering lookup where un unset mark performs nothing. Fixes MORX-32.
Behdad Esfahbod 0d18ec54 2018-09-28T10:00:07 [morx] unsafe-to-break in Insertion Makes MORX-29, MORX-30, MORX-31 pass.
Behdad Esfahbod 02bebe42 2018-09-28T09:51:35 [test/text-rendering-tests] Update from upstream
Behdad Esfahbod 4cd342ba 2018-09-28T09:47:45 Fix ubsan bot
Behdad Esfahbod b435df3a 2018-09-28T09:13:14 More atomic tuneup
Behdad Esfahbod 7e6e094a 2018-09-28T08:45:57 [test-multithread] Install ot funcs before filling ref buffer
Behdad Esfahbod 21fbee83 2018-09-28T08:43:37 [test-multithread] Take num-threads and num-iters from command-line
Behdad Esfahbod 598be3bb 2018-09-28T08:33:26 Minor
Ebrahim Byagowi c09bf3d5 2018-09-28T16:13:01 test-multithread, check the results on every iteration (#1194)
Ebrahim Byagowi dbc3070a 2018-09-28T16:01:15 Make test-multithread pass the tsan bot test (#1193)
Behdad Esfahbod d2542cd2 2018-09-27T17:23:24 More atomic fixup
Behdad Esfahbod 3ee96984 2018-09-27T17:20:26 Fixup atomics from recent change
Behdad Esfahbod 30546870 2018-09-27T16:54:23 [cache] Use atomic writes in clear() To help TSan.
Volker Krause 9e9a36ee 2018-09-27T16:33:49 Fix infinite loop when walking up the directory hierarchy (#1183) A single find_package(harfbuzz) line in user code resulted in this loop getting stuck when _harfbuzz_libdir_iter became "/".
Ebrahim Byagowi 0c1d852b 2018-09-27T11:53:17 Use clang for compiling freetype for tsan bot
Behdad Esfahbod 662f7d7e 2018-09-26T18:42:37 [arabic] Do the joiner-flipping only for rlig feature See comment.
Behdad Esfahbod 7f30629c 2018-09-26T16:40:23 [ft] Make TSan happy
Behdad Esfahbod ec743fce 2018-09-26T16:37:18 Add more atomic intrinsics
Behdad Esfahbod d183b33c 2018-09-26T16:29:35 Rename test
Ebrahim Byagowi c9c75fe3 2018-09-27T00:08:06 [ci] Compile freetype on tsan and put sanitizer flags on correct places (#1188)
Ebrahim Byagowi 39da1914 2018-09-26T23:32:45 Test freetype funcs on test-multithread (#1187)
Ebrahim Byagowi e88009a9 2018-09-26T22:53:02 Minor, remove the no longer needed comment on test-multithread
Behdad Esfahbod 90a0f9fa 2018-09-26T15:03:07 Make TSan happy with make_immutable()
Behdad Esfahbod 34d5a259 2018-09-26T15:02:21 Fix test-multithread and increase num_threads to 30 What were you thinking? ;)
Ebrahim Byagowi 8bb73dad 2018-09-26T20:50:51 Add a multithreaded test (#1184)
Behdad Esfahbod 04caf116 2018-09-26T12:13:47 [hb-view] Change subpixel bits from 8 to 6 To match FreeType units, such that FreeType gets correct size from us. This matters more now that we allow setting --ft-load-flags.
Behdad Esfahbod 824111d4 2018-09-25T12:47:37 Fix iOS build Fixes https://github.com/harfbuzz/harfbuzz/pull/1179
Ebrahim Byagowi 4b4be770 2018-09-25T09:24:35 [circle] Add an obsessive clang bot (#1178)
Behdad Esfahbod 8282e881 2018-09-24T19:43:01 Disable msan bot again Fixes https://github.com/harfbuzz/harfbuzz/issues/1175
Behdad Esfahbod 6c0e7eb6 2018-09-24T19:07:23 Minor
Behdad Esfahbod d748dc76 2018-09-24T18:30:50 More iter inits
Behdad Esfahbod d9867497 2018-09-24T18:11:59 Minor
Behdad Esfahbod 70136a78 2018-09-24T18:03:34 Remove F_COMBINE Now I wonder if any bots will be unhappy we calling | in static const initializations... Or would that cost runtime init? Our tests don't detect any..