Hash :
8d62ad3b
Author :
Date :
2025-03-23T15:27:36
[directwrite] Don’t release IDWriteFace pass to hb_directwrite_font_create That was a leftover from previous code and is incorrect now as we would be double releasing it.
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142
/*
* Copyright © 2022 Red Hat, Inc.
*
* This is part of HarfBuzz, a text shaping library.
*
* Permission is hereby granted, without written agreement and without
* license or royalty fees, to use, copy, modify, and distribute this
* software and its documentation for any purpose, provided that the
* above copyright notice and the following two paragraphs appear in
* all copies of this software.
*
* IN NO EVENT SHALL THE COPYRIGHT HOLDER BE LIABLE TO ANY PARTY FOR
* DIRECT, INDIRECT, SPECIAL, INCIDENTAL, OR CONSEQUENTIAL DAMAGES
* ARISING OUT OF THE USE OF THIS SOFTWARE AND ITS DOCUMENTATION, EVEN
* IF THE COPYRIGHT HOLDER HAS BEEN ADVISED OF THE POSSIBILITY OF SUCH
* DAMAGE.
*
* THE COPYRIGHT HOLDER SPECIFICALLY DISCLAIMS ANY WARRANTIES, INCLUDING,
* BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND
* FITNESS FOR A PARTICULAR PURPOSE. THE SOFTWARE PROVIDED HEREUNDER IS
* ON AN "AS IS" BASIS, AND THE COPYRIGHT HOLDER HAS NO OBLIGATION TO
* PROVIDE MAINTENANCE, SUPPORT, UPDATES, ENHANCEMENTS, OR MODIFICATIONS.
*
* Author: Matthias Clasen
*/
#include "hb-test.h"
#include "hb-directwrite.h"
/* Declare object creator for dynamic support of DWRITE */
typedef HRESULT (WINAPI *t_DWriteCreateFactory)(
DWRITE_FACTORY_TYPE factoryType,
REFIID iid,
IUnknown **factory
);
IDWriteFontFace *
get_dwfontface (const char *font_path)
{
auto *face = hb_test_open_font_file (font_path);
auto *dw_font_face = hb_directwrite_face_get_dw_font_face (face);
dw_font_face->AddRef ();
hb_face_destroy (face);
return dw_font_face;
}
static void
test_native_directwrite_basic (void)
{
IDWriteFontFace *dwfontface;
hb_font_t *font;
IDWriteFontFace *dwfontface2;
dwfontface = get_dwfontface ("fonts/Roboto-Regular.abc.ttf");
g_assert_nonnull (dwfontface);
font = hb_directwrite_font_create (dwfontface);
dwfontface2 = hb_directwrite_font_get_dw_font_face (font);
g_assert_true (dwfontface2 == dwfontface);
hb_font_destroy (font);
dwfontface->Release ();
}
static void
test_native_directwrite_variations (void)
{
IDWriteFontFace *dw_face;
IDWriteFontResource *dw_fontresource;
IDWriteFontFace5 *dw_face5, *dw_facevariations;
DWRITE_FONT_AXIS_VALUE dw_axisvalues[5];
hb_font_t *font;
const float *coords;
unsigned int length;
dw_face = get_dwfontface ("fonts/AdobeVFPrototype.abc.otf");
g_assert_nonnull (dw_face);
dw_face->QueryInterface (__uuidof(IDWriteFontFace5), (void **)&dw_face5);
dw_face->Release ();
g_assert_nonnull (dw_face5);
// Check that wght axis originally set on the face is different from what we will set.
if (!dw_face5->HasVariations ())
{
g_test_skip ("Font has no variations. Possiply using Wine’s DWrite.dll");
return;
}
g_assert_cmpuint (dw_face5->GetFontAxisValueCount (), ==, 5);
dw_face5->GetFontAxisValues (dw_axisvalues, 5);
g_assert_cmpuint (dw_axisvalues[0].axisTag, ==, DWRITE_FONT_AXIS_TAG_WEIGHT);
g_assert_cmpfloat (dw_axisvalues[0].value, !=, 900.0f);
dw_face5->GetFontResource (&dw_fontresource);
dw_face5->Release();
g_assert_nonnull (dw_fontresource);
// Set wght axis to 900.0
dw_axisvalues[0].value = 900.0f;
dw_fontresource->CreateFontFace (DWRITE_FONT_SIMULATIONS_NONE, dw_axisvalues, 5, &dw_facevariations);
dw_fontresource->Release ();
g_assert_nonnull (dw_facevariations);
// Check that wght axis is now set to 900.0
g_assert_cmpuint (dw_facevariations->GetFontAxisValueCount (), ==, 5);
dw_facevariations->GetFontAxisValues (dw_axisvalues, 5);
g_assert_cmpuint (dw_axisvalues[0].axisTag, ==, DWRITE_FONT_AXIS_TAG_WEIGHT);
g_assert_cmpfloat (dw_axisvalues[0].value, ==, 900.0f);
font = hb_directwrite_font_create (dw_facevariations);
// Check that wght axis is also set to 900.0 on the hb_font_t
coords = hb_font_get_var_coords_design(font, &length);
g_assert_cmpuint (length, ==, 2);
g_assert_cmpfloat (coords[0], ==, 900.0f);
hb_font_destroy (font);
dw_facevariations->Release ();
}
int
main (int argc, char **argv)
{
hb_test_init (&argc, &argv);
hb_test_add (test_native_directwrite_basic);
hb_test_add (test_native_directwrite_variations);
return hb_test_run ();
}