Log

Author Commit Date CI Message
Guillem Jover fe21244b 2022-12-20T22:47:02 include: Use __has_builtin to detect __builtin_offsetof support The __has_builtin operator is more specific and is supported by GCC and Clang, while __is_identifier() is less specific and only supported by Clang, so we should prefer the former whenever it is available, and only fallback to use the latter when the former is missing and the latter.
Khem Raj ec88b7bb 2022-12-15T09:02:22 funopen: Replace off64_t with off_t in funopen_seek() AC_SYS_LARGEFILE in configure.ac is setting needed defines to make 64bit off_t on relevant platforms. Fixes build on musl: | src/funopen.c:68:28: error: unknown type name 'off64_t'; did you mean 'off_t'? | funopen_seek(void *cookie, off64_t *offset, int whence) | ^~~~~~~ | off_t Closes: !24 Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Guillem Jover <guillem@hadrons.org>
Florian Weimer 5dea9da3 2022-12-13T03:37:06 build: Improve C99 compatibility of __progname configure check The check uses printf, so it needs to include <stdio.h> for compilers which do not support implicit function declarations. (They were removed from C99.) Closes: !23 Signed-off-by: Guillem Jover <guillem@hadrons.org>
Guilherme Janczak 23377191 2022-12-07T04:06:37 man: Prune unneeded <sys/types.h> include in setproctitle(3) FreeBSD first declared the function in unistd.h in 2000: https://cgit.freebsd.org/src/commit/include/unistd.h?id=9feac5c21886 No other #include line was needed to use the function, but the man page unnecessarily instructed users to include sys/types.h until 2022-11-29: https://cgit.freebsd.org/src/commit/?id=5b6f0a5012e9bc37dcb32b57b41e2443a46da620 libbsd first declared the function in unistd.h in 2010 with commit 3fed78e5b08f78256e533788b4bcd6502b0949d7 and inherited the bug from FreeBSD's man page. No need to do anything for backwards compat. Signed-off-by: Guillem Jover <guillem@hadrons.org>
Guillem Jover b9bf42dd 2022-12-13T03:35:05 build: Enable -Wall for automake This will make sure to warn about bogus or deprecated constructs.
Guillem Jover e57c0787 2022-12-13T03:34:37 build: Add missing AM_PROG_AR macro call to configure.ac Warned-by: autoreconf
Guillem Jover 80f1927d 2022-12-13T03:31:38 build: Fix configure.ac indentation Use the same style as the newly added code, which should make the code more readable, and produce more conforming C output.
Guillem Jover b7a8bc22 2022-12-13T03:10:28 build: Require automake 1.11 This is a rather old release (from 2009), that provides AM_SILENT_RULES.
Guillem Jover e5089628 2022-11-23T23:31:54 build: Do not require funopen() to be ported This function cannot be easily and (more importantly) correctly ported without cooperation from the libc stdio layer. We already document that users should be prepared to have the function not available on some platforms and that they should ideally switch their code to other more portable and better interfaces. Instead of making the build fail, and requiring porters to add exceptions for something that most probably cannot be ported correctly anyway, simply print a warning and let it build. This will not be a regression because on those systems libbsd would have never been built before. Prompted-by: Jens Finkhaeuser <jens@finkhaeuser.de>
Guillem Jover 00b538ff 2022-11-23T23:28:34 build: Terminate lists in variables with «# EOL» This means we can add a trailing «\» to every element, so that they can be removed without requiring modification of other lines, and can be easily sorted. Replace the old usage of $(nil) which could possibly end up with junk added if such variable is ever defined, in the environment.
Guillem Jover 5cfa39e5 2022-11-23T23:42:49 build: Use «yes» instead of «true» for AC_CHECK_FUNCS cache value This autoconf macro sets the ac_cv_func_ cached variable to «yes» not «true» so we were checking for an impossible condition.
Guillem Jover 084911ce 2022-10-06T04:07:52 Release libbsd 0.11.7
Guillem Jover 3538d38f 2022-10-06T03:59:33 man: Discourage using the library in non-overlay mode This makes code using it non-portable, and requires the namespeced headers from libbsd, instead of any generic system headers. It also requires more code changes than the overlay mode.
Guillem Jover 03fccd15 2022-10-05T12:08:31 include: Adjust reallocarray() per glibc adoption On glibc 2.29 reallocarray() was moved to _DEFAULT_SOURCE. Closes: !20 Based-on-patch-by: Callum Farmer <gmbr3@opensuse.org> Signed-off-by: Guillem Jover <guillem@hadrons.org>
Callum Farmer 6b6e686b 2022-10-05T12:08:31 include: Adjust arc4random() per glibc adoption Some arc4random functions were added in glibc 2.36. Signed-off-by: Callum Farmer <gmbr3@opensuse.org> Signed-off-by: Guillem Jover <guillem@hadrons.org>
Callum Farmer da1f45ac 2022-10-03T16:09:18 include: explicit_bzero() requires _DEFAULT_SOURCE Signed-off-by: Callum Farmer <gmbr3@opensuse.org> Signed-off-by: Guillem Jover <guillem@hadrons.org>
Guillem Jover 2f9eddc2 2022-10-05T02:05:46 include: Simplify glibc version dependent macro handling We test once whether __GLIBC__ is not defined, so we do not need to test whether it is on the OR branch afterwards. We decouple the glibc version restriction check from the _*_SOURCE variable, as that contains an implicit opposite version check.
Guillem Jover 28298ac0 2022-10-05T01:35:08 doc: Switch references from pkg-config to pkgconf The former used to be the reference implementation, but it has been stagnant to the point of not showing much signs of life. Switch to the currently active and more complete implementation for references.
Guillem Jover ef981f93 2022-10-04T04:28:05 doc: Add missing empty line to separate README sections
Guillem Jover 6928d789 2022-10-04T04:27:44 doc: Refer to the main git repository as primary
Guillem Jover d5865759 2022-08-25T00:52:43 test: Fix explicit_bzero() test on the Hurd On the Hurd a small read(3) might end up (indirectly) copying the data on the stack, which we will end up finding even when we have cleared the buffer. To avoid these side effects, we add a new function, that we force not to be inlined, so that we can reuse the same stack space, that will blank any possible stack side effects. This should be portable regardless of stack growing up or down. Diagnosis-by: Samuel Thibault <sthibault@debian.org>
Guillem Jover be327c6e 2022-08-24T01:58:58 fgetwln: Add comment about lack of getwline(3) for recommendation Ideally we'd recommend getwline(3), but unfortunately even though it was part of the ISO/IEC TR 24731-2:2010 draft, it did not make it into C11 and is not widely implemented.
Guillem Jover a14612d9 2022-08-23T23:49:34 setmode: Dot not use saveset after free While we are only doing a pointer difference and not dereferencing it, it's easier and more correct to do the pointer difference before passing it to reallocarray(). Warned-by: gcc
Guillem Jover f4baceb8 2022-08-03T03:05:52 man: Rewrite gerprogname(3bsd) from scratch This gets rid of one of the last man pages with a BSD-4-clause license.
Guillem Jover f35c5458 2022-08-03T02:21:16 man: Lowercase man page title While using fully uppercase man page titles has been the usual convention for a very long time, it is rather ugly and something that some other projects are switching away from.
Guillem Jover b466b14a 2022-08-03T01:23:09 man: Document that some arc4random(3) functions are now in glibc 2.36
Guillem Jover 1f6a48b2 2022-08-03T02:03:05 Sync arc4random(3) implementation from OpenBSD Closes: #12
Fabrice Fontaine 873639eb 2022-06-07T19:27:13 Fix ELF support for big endian SH Fix the following build failure with big endian SH (e.g. sh4aeb): ,--- In file included from nlist.c:44: nlist.c: In function '__elf_is_okay__': local-elf.h:223:25: error: 'ELFDATA2LMSB' undeclared (first use in this function); did you mean 'ELFDATA2LSB'? 223 | #define ELF_TARG_DATA ELFDATA2LMSB | ^~~~~~~~~~~~ `--- Fixes: http://autobuild.buildroot.org/results/2980fb79c208454195d77383f1ece9afbd7f981b Closes: !19 Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> Signed-off-by: Guillem Jover <guillem@hadrons.org>
Guillem Jover c9c78fdf 2022-04-04T11:49:52 man: Use -compact also for alternative functions in libbsd(7) The other function lists use the compact mode, let's be uniform about this.
Guillem Jover 5f213075 2022-03-31T20:46:56 getentropy: Fix function cast for getauxval() Fix also the Hurd implementation, missed in the original fix. Extends: commit 72a82ee262795c9162e712885381a111fcf988bc Warned-by: gcc
Guillem Jover 84acf215 2022-03-30T23:09:35 Release libbsd 0.11.6
WANG Xuerui 15200ec7 2021-09-11T12:54:28 Add LoongArch support to nlist() Closes: !13 Signed-off-by: WANG Xuerui <git@xen0n.name> Signed-off-by: Guillem Jover <guillem@hadrons.org>
Guillem Jover f7465b93 2022-03-30T22:56:43 man: Document when functions were added to musl in libbsd(7) The explicit_bzero(3) and reallocarray(3) functions are also present on musl libc, mention it in the superseded section.
Guilherme Janczak e5ed5fdd 2021-12-31T08:25:08 Remove arc4random() OpenBSD support The arc4random() support for OpenBSD does not build. The intention was to include any portability code so that the library could be easily ported to such systems, but it makes little sense to build it on OpenBSD where most of the functionality will be already present, or the software would have been ported anyway. [guillem@hadrons.org: Reword commit message to add rationale. ] Closes: !15 Signed-off-by: Guillem Jover <guillem@hadrons.org>
Duncan Overbruck abb1a6b1 2022-01-24T15:11:38 build: Add alpine to CI for tests with musl libc Closes: !18 Signed-off-by: Guillem Jover <guillem@hadrons.org>
Guillem Jover c9ff8368 2022-01-29T14:48:22 test: Import explicit_bzero and strtonum test cases from OpenBSD - Remove trailing spaces. - Declare file-scope functions and variables static. - Declare functions with a proper prototype. - Do not mix declarations and code for C90 conformance. - Do not compare size_t and ssize_t variables.
Guillem Jover 62e67bb4 2022-01-29T14:52:08 build: Sort test programs in .gitignore
Duncan Overbruck 87b13070 2022-01-25T20:34:39 test: Add fpurge() test case using open_memstream(3) FILE Signed-off-by: Guillem Jover <guillem@hadrons.org>
Duncan Overbruck ba3c46b3 2022-01-25T20:32:30 fpurge: Make it work with non fd based FILEs Streams opened with for example open_memstream(3) will have no associated file descriptor, and fileno(3) will fail. Signed-off-by: Guillem Jover <guillem@hadrons.org>
Duncan Overbruck 091097e0 2022-01-24T16:47:00 test: Remove static FILE declaration from fpurge test This does not work with libcs that do not declare the structure in a header file, like musl. And gets in the way of supporting non-fd based streams. Signed-off-by: Guillem Jover <guillem@hadrons.org>
Guillem Jover 5f9608c7 2022-01-25T01:48:29 Release libbsd 0.11.5
Guillem Jover eef07993 2022-01-25T01:41:14 Revert "build: Add missing proctitle unit test program" This reverts commit beafad2657c7a57109c28f8bad9cb028c84c7dd5. This test was already handled later on as part of the BUILD_LIBBSD_CTOR conditional. Adding it to the unconditional set made the build fail when the system does not have GNU .init_array section support. Closes: #9 Analysis-by: Duncan Overbruck <mail@duncano.de>
Guillem Jover c6d589bc 2022-01-23T21:07:45 Document how to build from git and from a tarball release Closes: #8
Guillem Jover 2975d809 2022-01-23T18:54:33 build: Check for objdump explicitly We should not assume that something will implicitly check for this tool, as we need it ourselves, and this is an internal implementation detail of right now libtool. Fixes: commit f11ab6722367f1cf62704ed3c827b9b68dcb5397
Sam James f11ab672 2022-01-23T15:36:55 build: Respect $(OBJDUMP) We already search for it in `./configure` so let's respect the result of that search. This helps with cross-compilation and any other cases where one might want to choose a different toolchain. Closes: !16 Bug: https://bugs.gentoo.org/831863 Signed-off-by: Sam James <sam@gentoo.org> Signed-off-by: Guillem Jover <guillem@hadrons.org>
Guillem Jover 54796231 2022-01-22T22:41:51 Release libbsd 0.11.4
Guillem Jover 7aed0edf 2021-12-02T00:35:05 man: Add missing comma in .Dd for tree(3) Reported-by: Thorsten Glaser <tg@mirbsd.de>
Guillem Jover fafcc397 2021-11-30T04:00:54 man: Update tree(3) man page from OpenBSD This man page has a BSD-3-clause-author license instead of the old BSD-4-clause license.
Guillem Jover 48107fc8 2021-11-28T23:19:16 build: Clarify link-time warnings Mention the involved function instead of stating an implicit "this function". Mention libbsd when proposing using an alternative libmd to make the context clear.
Guillem Jover e7cf8c57 2021-11-28T22:44:08 Switch md5 compatibility logic back to direct linking When using the recent dlsym() based wrapper, we are not requiring any symbol from libmd, as we resolve those dynamically at run-time. We were ending up linking against libmd because in another part of the code we require (depending on the architecture) the SHA512 functions for the getentropy() local implementation. But that function might be provided by the system libc on some systems, which means we end up not linking against libmd at all. To solve this we go back to the previous simpler solution of linking directly, which had the main drawback of then making programs fail to link when not specifying -lmd (on platforms that need it). And then switch the .so link point from a symlink to a linker script, so that we can inject the -lmd library as-needed. This is similar to what glibc is doing. Fixes: commit 31f034e3862debda8615a449b1c11c4d6920dcc7
Guillem Jover 25d35625 2021-11-28T22:40:58 build: Split libmd dependency due to MD5 functions from SHA requirements To be able to rework the md5 deprecation logic, we need to detangle when we depend on libmd due to requiring MD5 functions, which might be otherwise provided by libc, or when we require SHA functions for the internal getentropy() implementation.
Guillem Jover 500b3080 2021-11-28T22:34:59 build: Add new libbsd_symver_weak() macro We will use it for the reworked md5 deprecation logic.
Guillem Jover 1eba4060 2021-11-27T21:09:18 test: Check that strdup() does not fail Warned-by: gcc
Guillem Jover 8ad7570c 2021-11-27T21:07:00 getentropy: Add missing prototype for BSD variant Warned-by: gcc
Guillem Jover 43a82703 2021-11-27T20:26:05 nlist: Remove condition which is always true The nlist() function is limited to handle ELF binaries of the same class as size as the size_t of the architecture built. In addition the SIZE_T_MAX macro is BSD specific, and was falling back to the wrong constant on most 64-bit non-BSD systems. Warned-by: gcc
Guillem Jover 6a71b24b 2021-11-27T22:52:28 build: Append __ after __attribute and __typeof keywords Be consistent with other usages in the code base.
Guillem Jover 7389fe8d 2021-11-27T06:54:49 build: Ignore backup files
Victor Westerhuis 2716dfd0 2021-11-26T20:24:20 test: Explicitly mark symbols as used Because some of the symbols are not otherwise referenced, GCC would like to remove them. Closes: !14 Signed-off-by: Guillem Jover <guillem@hadrons.org>
Victor Westerhuis 54f87456 2021-11-26T20:01:18 build: Enable .init_array support when building with LTO Because these symbols are not otherwise referenced, GCC would like to remove them. Signed-off-by: Guillem Jover <guillem@hadrons.org>
Guillem Jover 6145b561 2021-08-17T03:14:57 test: Do not pass NULL as the first funopen() argument Warned-by: gcc -W
Guillem Jover 731b0a77 2021-08-17T02:59:59 build: Detect sed at configure time Check whether sed is available and use the implementation matching the requirements via the SED variable.
Guillem Jover 50b50a43 2021-03-02T05:18:04 vis: Add prototypes for strnvis() and strnunvis() variants Warned-by: gcc
Guillem Jover 25e88f64 2021-03-02T00:48:31 test: Cast literal strings to (char *) on n_name assignment The member is declared as n_name so we cannot directly assign a literal string constant. Warned-by: gcc
Guillem Jover 04a8fb24 2021-03-02T00:48:02 Add missing prototypes to functions Warned-by: gcc
Guillem Jover 4f68a88f 2021-02-19T06:55:17 build: Add compiler warnings support Detect as many warnings as possible during configure and enable them if the user did not supply any, so that any such problem can be spotted and fixed.
Guillem Jover 428be9e0 2021-10-07T23:08:42 man: Fix .Nx macro usage Its arguments are used as version numbers, so we need continue the content on the next line.
Alexander Miller c7a5d780 2021-09-30T03:39:57 build: Allow building with -flto on gcc-10 and newer Global asm statements (like .symver directives) do not work reliably in gcc with link time optimization. Use the symver attribute introduced with gcc-10 to set symbol versions instead, if available. [guillem@hadrons.org: - Simplify by using __has_attribute fallback from <sys/cdefs.h>. - Coding style changes. ] Signed-off-by: Guillem Jover <guillem@hadrons.org>
Guillem Jover 1808d64b 2021-03-01T05:14:10 test: Fix pipe_feed() to allow checking fprintf format strings Warned-by: gcc -W
Guillem Jover beafad26 2021-03-07T00:22:59 build: Add missing proctitle unit test program
Guillem Jover 8f59221c 2021-02-19T06:51:18 nlist: Remove repeated shadowing variable declaration Warned-by: gcc
Guillem Jover 72a82ee2 2021-02-20T22:22:54 getentropy: Fix function cast for getauxval() Warned-by: gcc
Guillem Jover 3c305f28 2021-02-19T06:49:53 test: Add proper prototypes for main() function Warned-by: gcc
Guillem Jover 25278891 2021-02-19T06:49:24 Mark local functions as static Warned-by: gcc
Guillem Jover e35d9141 2021-02-11T04:41:46 Add link-time warnings to MD5 wrapper functions Let's get the word out that these functions are deprecated and should be switched away from.
Guillem Jover 4feda870 2021-02-11T04:40:48 Require a semicolon for libbsd_link_warning() macro Remove the semicolon in the macro definition to force adding one on the call sites, to make the code look like an actual function.
Guillem Jover d563a174 2021-02-18T23:38:30 man: Call the libbsd-ctor library by its name instead of bsd-ctor
Guillem Jover 785cf9d1 2021-02-18T23:38:30 man: Fix pkg-config(1) references in libbsd(7) man page
Guillem Jover 15bd284b 2021-02-28T05:16:01 build: Add code coverage support in the GitLab CI
Guillem Jover a9fc2859 2021-02-28T05:14:54 build: Use apt-get instead of apt in the GitLab CI The former is to be used programmatically, while the latter is intended for interactive use.
Guillem Jover c0d86a64 2021-02-09T08:35:36 build: Add a Libs.private field to overlay pkg-config file We need to list all internal libraries there so that we can statically link. Fixes: commit 2374f409defb380d0c5c07f28b9c166ef8bdc742
Guillem Jover 1fb25b7d 2021-02-09T06:14:25 Release libbsd 0.11.3
Guillem Jover 31f034e3 2021-02-09T05:57:37 Switch libmd wrapper to use dlsym() Switch from the previous versioned symbol implementation which required users to also link against the message digest provider explicitly, or they would fail to find the symbols, to an implementation that loads the symbols from the linked library providing the functions using dlsym(), thus preserving backwards compatibility.
Guillem Jover 2374f409 2021-02-09T05:56:49 build: Add a Libs.private field to pkg-config file We need to list all internal libraries there so that we can statically link.
Guillem Jover a4e0db2b 2021-02-09T06:04:38 build: Use a single variable to track libraries to link against Using various variables means we have to keep these in sync in various places. Just use a single variable that we can use anywhere where this is needed.
Guillem Jover 43d34c9d 2021-02-09T06:02:46 build: Fix message digest library checks They were not failing when not finding the SHA-2 functions and were hardcoding -lmd regardless of what library had been found.
Guillem Jover 1c3ff616 2021-02-09T02:46:49 Use uintptr_t and size_t instead of __-prefixed types in <sys/cdefs.h> The __-prefixed types cannot be assumed to be defined. Use the standard types instead. Closes: #6
Guillem Jover edea268c 2021-02-08T03:59:56 Release libbsd 0.11.2
Guillem Jover e832b768 2021-02-08T03:45:06 closefrom: Use close_range() on Linux when available Closes: !11 Based-on-patch-by: cptpcrd <cptpcrd.git@gmail.com> Signed-off-by: Guillem Jover <guillem@hadrons.org>
cptpcrd c4fca5bb 2021-02-07T14:22:21 closefrom: Handle lowfd < 0 properly More important if close_range() is going to be used, since casting negative values to 'unsigned int' might hide the errors. [guillem@hadrons.org: Minor coding style fix. ] Signed-off-by: Guillem Jover <guillem@hadrons.org>
Guillem Jover a1f79978 2021-02-08T02:52:50 closefrom: Import some changes from sudo Take most of the changes done in sudo, but preserve the existing local changes and refactoring. In addition, refactor pstat implementation into closefrom_pstat(), so that the code is easier to read, and requires no conditional declarations.
Faidon Liambotis 46760262 2021-02-07T20:47:00 Update <sys/queue.h> from FreeBSD This brings <sys/queue.h> to the most up-to-date version from FreeBSD, incorporating 18 commits from the past 5 years (2015-02-24 - 2021-01-25): $ git log --oneline 9090a24aed70..8d55837dc133 sys/sys/queue.h share/man/man3/queue.3 Only minimal changes compared to the FreeBSD version have been applied (queue.3 -> queue.3bsd, _LIBBSD_ prefix). [guillem@hadrons.org: Remove reference to kernel mode in man page. ] Closes: !12 Signed-off-by: Guillem Jover <guillem@hadrons.org>
Guillem Jover 25f9b306 2021-02-07T23:24:51 test: Improve code coverage for strnstr(3) unit tests
Guillem Jover 18ebabf2 2021-02-07T10:56:51 man: Update libbsd(7) man page with updates in 0.11.0
Guillem Jover 4ab11c7f 2021-02-07T10:37:18 build: Install libmd-dev in the gitlab CI
Guillem Jover 766c883e 2021-02-07T10:35:57 build: Switch gitlab CI to use a Debian buster
Guillem Jover a4de4d95 2021-02-07T02:03:59 Release libbsd 0.11.1
Guillem Jover 233cab9d 2021-02-06T23:28:42 Add support for new LIBBSD_VIS_OPENBSD selection macro This will make it possible to explicitly select the OpenBSD vis implementation (the current default) for code of OpenBSD origins.
Guillem Jover 2462cd88 2021-02-07T00:23:43 Release libbsd 0.11.0
Guillem Jover d54ceb37 2021-02-07T00:09:45 Update copyright claims
Guillem Jover 847e682f 2021-02-07T00:09:30 Use libmd hashing function implementations instead of embedding our own This splits the implementation responsibilities, and reduces embedded code copies, which was one of the driving points with this project to start with, so it's nice to give a good example.