|
5c8a59e8
|
2010-11-09T10:19:05
|
|
Merge remote branches 'github/20_evdns_cancel_segfault_v2', 'github/20_http_close_detect', 'github/20_http_versions', 'github/20_more_http_methods', 'github/20_shutdown_iocp_listener' and 'github/20_win64_fixes'
|
|
|
3db6bc00
|
2010-11-09T10:03:00
|
|
Remove some debugging puts() calls from allow_methods test
|
|
|
75e3320e
|
2010-11-04T12:41:13
|
|
Units test for unexpected evhttp methods.
|
|
34b84b97
|
2010-11-03T14:38:45
|
|
Fix more wn64 warnings.
|
|
|
985430ae
|
2010-11-03T15:17:57
|
|
Remove need for http_compat.h in http tests
|
|
|
0b137f45
|
2010-11-03T15:14:29
|
|
Stop accessing http request struct directly from in the unit tests.
|
|
|
c91622d1
|
2010-11-03T15:04:44
|
|
Stop using event_compat.h in regress_http
|
|
|
9bb82393
|
2010-11-03T14:31:23
|
|
Convert the rest of the http tests to be non-legacy unit tests.
|
|
|
353402a8
|
2010-11-03T14:13:20
|
|
Rename the confusing "base" static variable in regress_http.c
|
|
|
8505a744
|
2010-11-03T13:55:20
|
|
Start porting http tests to not use legacy interfaces
|
|
|
7484df61
|
2010-11-01T13:43:43
|
|
Fix even more win64 warnings
|
|
|
f8064762
|
2010-10-28T10:11:25
|
|
Increase the skew tolerance to 2 seconds in thread/deferred_cb_skew
This is to make the test not fail on Sebastian Hahn's Win7 box.
|
|
f817bfa4
|
2010-10-27T17:31:52
|
|
Fix some ints to evutil_socket_t; make tests pass on win64.
|
|
|
5d389dc0
|
2010-10-26T22:27:57
|
|
Fix some uses of int for socket in regress
|
|
|
c281aba3
|
2010-10-24T11:38:29
|
|
Fix a nasty bug related to use of dup() with epoll on Linux
Current versions of the Linux kernel don't seem to remove the struct
epitem for a given (file,fd) combo when the fd is closed unless the
file itself is also completely closed. This means that if you do:
fd = dup(fd_orig);
add(fd);
close(fd);
dup2(fd_orig, fd);
add(fd);
you will get an EEXIST when you should have gotten a success. This
could cause warnings and dropped events when using dup and epoll.
The solution is pretty simple: when we get an EEXIST from
EPOLL_CTL_ADD, we retry with EPOLL_CTL_MOD.
Unit test included to demonstrate the bug.
Found due to the patient efforts of Gilad Benjamini; diagnosed with
help from Nicholas Marriott.
|
|
|
bf11e7dd
|
2010-10-21T15:33:13
|
|
Merge branch 'http_uri_parse'
|
|
|
bc98f5e6
|
2010-10-21T14:53:21
|
|
Unit tests for evhttp_uri_set*
|
|
|
45f6869c
|
2010-10-21T14:41:12
|
|
Make evhttp_uri non-public, and give it accessor functions.
|
|
|
d9ffa899
|
2010-10-21T12:48:13
|
|
Update the HTTP regression tests to use Libevent2 apis for non-http stuff
|
|
|
1f507d75
|
2010-10-21T12:27:16
|
|
Stop using Libevent-1 headers in regress_http
|
|
|
cd00079b
|
2010-10-21T12:19:28
|
|
Add evhttp_connection_get_base() to get the event_base from an http connection
Based on a patch by Mark Ellzey from 27 July 2010.
Closes ticket 3052406
|
|
|
a5a76e68
|
2010-10-19T12:35:50
|
|
Add a huge pile of tests for the new URI functions, and make them pass.
|
|
|
ad923a11
|
2010-10-19T12:33:50
|
|
Improvements to tinytest_macros.h
First, handle cases where we have %s in a tt_want or tt_assert.
Second, add tt_want_*_op that do a tt_*_op test, but do not exit the
test on failure.
We should push these upstream to tinytest some time.
|
|
|
eaa5f1d9
|
2010-10-19T11:26:59
|
|
Revise evhttp_uri_parse implementation to handle more of RFC3986
|
|
86dd720a
|
2010-08-08T16:46:39
|
|
Introduce absolute URI parsing helpers.
See evhttp_uri_parse(), evhttp_uri_free() and evhttp_uri_join() for details.
|
|
|
f13e449b
|
2010-10-18T14:20:06
|
|
Merge branch 'http_parse'
|
|
|
e5870690
|
2010-10-18T13:53:31
|
|
Modernize header usage in bench_http.c
|
|
|
4ebf9509
|
2010-10-14T14:40:40
|
|
Fixes for MSVC compilation
|
|
|
e06f514d
|
2010-10-14T13:51:24
|
|
Fix signed/unsigned warnings on win32
|
|
|
e5c214a4
|
2010-10-14T13:16:41
|
|
Fix -Wsigned-compare warnings in test/*
|
|
|
02f6259f
|
2010-10-14T11:44:32
|
|
New unit test for ssl bufferevents starting with connected SSLs.
|
|
|
34331e45
|
2010-10-08T01:09:02
|
|
The corrected bufferevent filter semantics let us fix our openssl tests
|
|
|
a8148ced
|
2010-10-08T13:05:13
|
|
New evhttp_uri(encode|decode) functions to handle + and NUL characters right
The old evhttp_decode_uri() function would act as tough it was doing
an (illegal, undefined) decode operation on a whole URL at once, and
treat + characters following a ? as different from + characters
preceding one. But that's not useful: If you are decoding a URI
before splitting off query parameters, you are begging to fail as soon
as somebody gives you a value with an encoded & in it.
The new evhttp_uridecode() function takes an argument that says
whether to decode + signs. Both uridecode and uriencode also now
support encoding or decoding to strings with internal 0-valued
characters.
|
|
|
62b429af
|
2010-10-07T13:41:39
|
|
Make iocp/listener/error work; don't accept again if lev is disabled.
|
|
|
127d4f21
|
2010-09-23T16:49:58
|
|
Add a LEV_OPT_THREADSAFE option for threadsafe evconnlisteners
|
|
|
b1756d01
|
2010-10-06T11:48:52
|
|
Let evhttp_parse_query return -1 on failure
We already detected certain malformed queries, but we responded by
aborting the query-parsing process half-way through without telling
the user. Now, if query-parsing fails, no headers are returned, and
evhttp_parse_query returns -1.
|
|
|
5b7a3706
|
2010-10-05T14:29:48
|
|
Fix warnings on mingw with gcc 4.5
|
|
|
d49b5e33
|
2010-09-27T15:12:55
|
|
Do not search outside of the system directory for windows DLLs
Hardens against some attacks.
|
|
|
045eef4c
|
2010-09-23T14:23:45
|
|
Unit tests for listener error callbacks
|
|
|
4858b794
|
2010-09-15T01:54:51
|
|
Remove the now-useless evsig_caught and evsig_process
|
|
|
720bd933
|
2010-09-15T01:08:39
|
|
Warn when using the error-prone EV_SIGNAL interface in an error-prone way. Also, fix a couple of race conditions in signal.c
When using the signal.c signal backend, Libevent currently only allows
one event_base to actually receive signals at a time. (This has been
the behavior since at least 1.4 and probably much earlier.) Now, we
detect and warn if you're likely to be racing about which signal goes
to which thread.
We also add a lock to control modifications of the evsig_base field,
to avoid race conditions like those found by Jason Toffaletti.
Also, more comments. Comments are good.
|
|
|
f0bd83ea
|
2010-09-09T16:13:09
|
|
Bump to the latest version of tinytest
This lets us do without libevent-specific code in tinytest.c, and
lets us add a feature to skip individual tests from the command
line.
|
|
|
a5ce9ad4
|
2010-09-09T16:01:42
|
|
Make SSL tests cover enabling/disabling EV_READ.
I want my 80% coverage.
|
|
|
2756a10c
|
2010-09-09T13:43:31
|
|
Add a missing time.h include to test/regress_thread.c
|
|
|
fb36f9a7
|
2010-09-09T13:00:54
|
|
Fix an uninitialized-variable warning on windows
|
|
|
3ec65d69
|
2010-09-08T19:55:13
|
|
Fix a few Windows compile warnings.
|
|
|
25b6a74b
|
2010-09-08T14:53:57
|
|
Merge branch 'tests'
|
|
|
de412948
|
2010-09-08T14:52:24
|
|
Add a missing header for regress_thread.c
|
|
911e0db8
|
2010-09-08T20:29:39
|
|
Fix a compile warning in regress_thread.c
|
|
|
3658b169
|
2010-09-08T14:12:12
|
|
Merge remote branch 'chrisd/iocp-fixes4'
Conflicts:
test/regress_thread.c
|
|
|
9580e282
|
2010-09-08T14:00:45
|
|
Merge branch 'th_notify_fd_reinit'
|
|
|
ce85280b
|
2010-09-08T13:29:06
|
|
Improve testing of when thread-notification occurs
|
|
|
17a14f1a
|
2010-09-01T11:04:57
|
|
Only process up to MAX_DEFERRED deferred_cbs at a time.
If threads queue callbacks while event_process_deferred_callbacks is
running, the loop may spin long enough to significantly skew timers.
A unit test stressing this behavior is also in this commit.
|
|
|
2447fe88
|
2010-08-28T04:07:48
|
|
Add event_config_set_num_cpus_hint for tuning thread pools, etc.
|
|
|
499452f4
|
2010-08-28T02:44:11
|
|
IOCP-related unit test tweaks
|
|
|
d844242f
|
2010-08-28T02:08:27
|
|
Stop IOCP when freeing the event_base.
|
|
|
1115366e
|
2010-09-07T10:28:15
|
|
Fix a few memory leaks in the tests
|
|
|
42090072
|
2010-09-06T15:47:07
|
|
Move the "function to getsockname() on a listener" to regress_testutils
This reverts commit fab50488fcb741884ccdfa7b83643eac3e5c9cbf.
The function was, on reflection, not important enough to break the feature
freeze, since it's trivial to build on your own.
|
|
b0f284cb
|
2010-09-06T10:10:17
|
|
Fix event_del(0) instance in bench.c
|
|
|
b5dd8064
|
2010-09-03T22:00:25
|
|
Fix uninitialized port var in http_delete_test. Last one, I hope.
|
|
|
3b3fb743
|
2010-09-03T21:03:25
|
|
Fix uninitialized variables in http_bad_request_test. (oops)
|
|
|
a97320ac
|
2010-09-03T18:48:31
|
|
Allow more than one copy of regression tests to run at once
Mostly this was a matter of just removing all the hardwired ports in
the test code. The http/connection_retry test is still a little
screwy, though.
|
|
|
041989fb
|
2010-08-17T14:44:12
|
|
Rename regress_pthread.c to regress_thread.c
|
|
|
743f8665
|
2010-08-23T11:48:46
|
|
Honor NDEBUG; build without warnings with NDEBUG; make NDEBUG always-off in unit test code
|
|
|
5fb10958
|
2010-08-16T22:55:45
|
|
Add a unit test for conditions
|
|
|
d74ae381
|
2010-08-16T12:38:22
|
|
Make the regress_pthread.c tests work on windows with current test APIs
|
|
|
4022b287
|
2010-08-13T11:34:39
|
|
Change include order in Makefile.nmake
If there is an event-config.h in include/event2 (either because we
screwed up packaging like in 2.0.6-rc or because we previously tried
building with mingw and we didn't make distclean in the middle), we
want MSVC to find the one one in WIN32-Code/include/event2 first.
Found by Gilad Benjamini.
|
|
|
0bffe43a
|
2010-08-09T12:08:40
|
|
Fix a nasty dangling-event bug when using rate-limiting groups
When we freed a bufferevent that was in a rate-limiting group and
blocked on IO, the process of freeing it caused it to get removed
from the group. But removing the bufferevent from the group made
its limits get removed, which could make it get un-suspended and in
turn cause its events to get re-added. Since we would then
immediately _free_ the events, this would result in dangling
pointers.
Fixes bug 3041007.
|
|
|
ec347b92
|
2010-07-07T16:45:03
|
|
Move event-config.h to include/event2
This change means that all required include files are in event2, and
all files not in event2/* are optional.
|
|
|
28f31a4f
|
2010-08-06T16:36:23
|
|
Fix unit tests with -DUSE_DEBUG enabled
If you were to enable USE_DEBUG and slog through all 700+ MB of
debugging output, you'd find that one of the unit tests failed,
since it tested the debug logging code, but the string it expected
and the string it logged differed by a tab vs 2 spaces.
|
|
|
ea1ea3d6
|
2010-08-06T13:34:51
|
|
Make test-changelist count cpu usage right on win32
|
|
|
9b602096
|
2010-08-06T13:03:17
|
|
Use AF_INET socketpair to test sendfile on Solaris
|
|
|
170ffd2b
|
2010-08-05T15:57:30
|
|
Increase the tolerance in our unit tests for sloppy clocks.
(Apparently openbsd in virtualbox just doesn't keep very accurate time.)
|
|
|
e996b3d4
|
2010-08-05T15:51:16
|
|
Make tests quieter on local dns resolver failure
|
|
|
b2c6202d
|
2010-08-04T15:52:32
|
|
Fix an assertion bug in test-ratelim
If the rate limit was low enough, then the echo_conns wouldn't finish
inside the 300 msec we allowed for them to close. Instead, count the
number of connections we have, and keep waiting until they are all
closed.
|
|
|
42f6b624
|
2010-08-04T15:51:14
|
|
Add option to test-ratelim to test min_share
|
|
|
42a8c711
|
2010-07-31T17:10:04
|
|
Build more cleanly with NetBSDs that dislike toupper(char)
To be fair, when char can be signed, if toupper doesn't take negative
characters, toupper(char) is a very bad idea. So let's just use the
nice safe EVUTIL_TOUPPER instead. (It explicitly only upcases ASCII,
but we only use it for identifiers that we know to be ASCII anyway).
|
|
840a72fb
|
2010-07-29T20:32:40
|
|
Fix badly-behaved subtest of dns/bufferevent_connect_hostname
The bufferevent_connect_hostname test was specifying AF_INET, but the
gethostbyname test we were using to see what error to expect was using
PF_UNSPEC, leading to possible divergence of results.
|
|
|
7c926916
|
2010-07-19T15:14:10
|
|
Make test/test.sh call test-changelist
Eventually test-changelist should expand to try more cases, maybe
query the status of the actual changelist somehow, and integrate it
with the rest of the unit tests.
Also, add test-changelist to gitignore.
|
|
|
cb927a51
|
2010-07-19T15:03:43
|
|
Fix whitespace.
|
|
|
b00d4c04
|
2010-07-19T14:58:08
|
|
Remove unused variables in test/test-changelist.c
|
|
cf249e7d
|
2010-07-19T13:44:56
|
|
Possible fix to 100% cpu usage with epoll and openssl
I'm running a fairly simple bit of test code using libevent2 with epoll and
openssl bufferevents and I've run into a 100% cpu usage problem.
Looking into it 100% usage was caused by epoll_wait constantly
returning write events on the openssl socket when it shouldn't really have
been looking for write events at all (N_ACTIVE_CALLBACKS() was returning 0
also).
Looking a bit deeper eventbuffer_openssl socket seems to be requesting
that the EV_WRITE event be removed when it should, but the event isn't
actually being removed from epoll.
Continuing to follow this I think I've found a bug in
event_changelist_del.
For evpoll event_del calls event_changelist_del which caches the change
which is then actioned later when evpoll_dispatch is called.
In event_changlist_del there is a check so that if the currently changed
action is an add then the cached action is changed to a no-op rather than a
delete (which makes sense). The problem arises if there are more than
two add or delete operations between calls to dispatch, in this case it's
possible that the delete is turned into a no-op when it shouldn't have
been.
For example starting with the event on, a delete followed by an add and
then another delete results in a no-op when it should have been a delete (I
added a fair bit of debug output that seems to confirm this behaviour).
I've applied a small change that checks the original old_event stored with
the change and only converts the delete to a no-op if the event isn't on in
old_event. This seems to have fixed my problem.
|
|
|
7510aac3
|
2010-06-21T12:23:32
|
|
Unit test for event_get_struct_event_size()
|
|
|
17a8e2d7
|
2010-06-07T12:06:43
|
|
Add a function to retrieve the other side of a bufferevent pair
|
|
|
44d57eee
|
2010-06-03T11:25:54
|
|
Add test for behavior on remote socket close
On all the backends on this little mac laptop, that behavior is to
report a remote socket close as both EV_READ and EV_WRITE.
Historically, we had problem for some of these behaviors on some
backends, so let's make sure that such behaviors don't come back.
|
|
|
3689bd2d
|
2010-05-26T13:32:32
|
|
Have the unit tests report errors from test.sh
The default behavior of test.sh was to suppress all output from
test/regress, and say nothing but OKAY or FAILED. This wasn't so good
for getting bugs reported, since lots of people didn't know to set
TEST_OUTPUT_FILE, or re-run ./test/regress on its own.
Now, when you don't specify an output file for test.sh, it runs
regress with the --quiet option. This option makes the unit tests
only print output on failure, which is what we probably wanted.
|
|
|
faf2a04f
|
2010-05-26T13:31:41
|
|
Make test.sh exit with nonzero status if tests fail
This behavior makes "make verify" actually fail when the tests fail,
which is what it's supposed to do.
|
|
|
8bc1e3d6
|
2010-05-26T13:19:08
|
|
Remove all non-error prints from test/regress.c
Now, running ./test/regress --quiet will indeed only inform you
about errors. Previously, it would also spew extra output.
|
|
|
e73f1d79
|
2010-05-26T13:18:30
|
|
Remove the now-obsolete setup_test() and cleanup_test() functions
|
|
|
bda21e7f
|
2010-05-17T11:58:07
|
|
Avoid close of uninitialized socket in evbuffer unit test
Attempts to fix a crash bug found by Brodie Thiesfield.
|
|
|
75701e89
|
2010-05-14T14:30:09
|
|
Add some missing includes to fix Linux build again
|
|
|
b5bfc44d
|
2010-05-13T15:38:39
|
|
Make test-ratelim clean up after itself better.
|
|
|
2b44dcca
|
2010-05-13T12:01:30
|
|
Add options to test-ratelim.c to check its results
The new options let you specify a maximum deviation of bandwidth used
from expected bandwidth used, and make test-ratelim.c exit with a
nonzero status when those deviations are violated.
This patch also adds a test-ratelim.sh script to run test-ratelim with
a few sensible options for testing.
|
|
|
33bbbed9
|
2010-05-13T10:57:30
|
|
Mark the event_err() functions as __attribute__((noreturn))
This attribute tells gcc (and anything else that understands gcc
attributes) that the functions will never return control, and helps
the optimizer a little. With luck, it will also tell
less-than-full-program dataflow analysis tools that they don't need to
worry about any code path that involves calling one of these functions
and then returning.
This patch also forces event_exit() to always exit, no matter what the
user-supplied fatal_callback does. This means that the old unit tests
for the event_err* functions don't work any more, since they assume it
is safe to call event_err* if you've given it a bogus fatal_callback
that doesn't exit. Instead, we have to make the unit tests fork
before calling event_err(), and have the main unit test process wait
for the event_err() test to exit with a sane exit code. On unix,
that's trivial. On windows, let's not bother and just assume that
event_err* works.
|
|
|
dfb75ab2
|
2010-05-12T15:38:28
|
|
Test the unlocked-deferred callback case of bufferevents
|
|
|
3d9e05b1
|
2010-05-08T19:56:25
|
|
Fix test.sh on freebsd
It turns out that in all conformant shells, "unset FOO" removes FOO
both from the shell's variables and from the exported environment.
(I've tested this on msys, opensolaris, linux, osx, and freebsd.)
And in nearly every shell I can find, "unset FOO; export FOO" does
the same as unset FOO... except in my FreeBSD VM, where the "export
FOO" sets the exported value of FOO equal to "". This broke test.sh
for us.
The fix is simple: remove the needless exports!
|
|
|
0ee6f6ce
|
2010-05-08T18:00:26
|
|
Make test.sh support mingw/msys on win32
This required:
- Adding another WIN32 section in test.sh
- not running "touch /dev/null"
- calling WSAStartup in all the test binaries
- Fixing a dumb windows-only bug in test-time.c
|
|
|
f89168e7
|
2010-05-08T19:11:50
|
|
Make test for bufferevent_connect_hostname system-neutral
Previously, the be5_outcome field for the dns error would be set to
something dependent on our system resolver. It turns out that you
can't rely on nameservers to really give you an NEXIST answer for
xyz.example.com nowadays: too many of them are annoyingly broken and
like to redirect you to their locked-in portals. This patch changes
the bufferevent_connect_hostname test so that it makes sure that the
dns_error of be5_outcome is "whatever you would get from resolving
the target hostname"
|
|
|
88a543fc
|
2010-05-08T19:09:09
|
|
Make unit test for add_file able to tell "error" from "done"
Importantly, we don't actually want to call evbuffer_write() when
the buffer is empty. This makes it an error to ever get a -1 return
value from evbuffer_add_file(), which makes it safe for us to test
the return value.
|
|
|
384d1245
|
2010-05-08T17:15:52
|
|
Fix bench_http build on win32.
|