Log

Author Commit Date CI Message
Daniel Stone a0e180b0 2010-06-15T16:42:06 Expose tbGetBuffer to the rest of libxkbcommon This will let us implement XkbAtomGetString on top of XkbAtomText, instead of having the latter get a duplicated string, dump it into a temporary buffer, and subsequently free it (sigh). Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone 4346e006 2010-06-15T16:41:10 xkbcomp: keycodes: Silence gcc warnings It was right to warn us: some of these were actually bogus. Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone 18039a6c 2010-06-15T15:25:40 xkbcomp: Atom text and expr leak fixes part #973 Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone a22386d4 2010-06-15T15:23:23 xkbcomp: Don't leak atom text and string exprs, again Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone 5df3dff7 2010-06-15T15:27:12 xkbcomp: geometry: Plug numerous atom text & expr leaks This code is absolute misery. Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone d20bdd3b 2010-06-15T15:14:58 xkbcomp: vmod: Don't get and immediately intern atoms XkbcInternAtom(XkbcAtomGetString(atom)) has to be the most spectacularly broken antipattern I've yet seen. Just compare the atoms directly. Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone a8bb86a4 2009-04-25T14:51:16 Test: Keysym: Add tests for new keysym <-> string conversions Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone 50a037ca 2010-06-15T15:13:56 xkbcomp: Replace open-coded strdup Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone 51402502 2009-04-25T18:15:02 Add testcase for XkbcCanonicaliseComponents Should be reasonably thorough; the shell part is, however, quite unpleasant. Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone 85b7f47d 2009-04-25T18:13:52 Add XkbcCanonicaliseComponents Canonicalises two sets of components (new and old), e.g.: new: +bar old: foo result: foo+bar This is required as part of the spec, so clients can reuse part of the device's old keymap. Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone 8904c6ee 2010-06-15T15:22:05 xkbcomp: expr: Use XkbcAtomText instead of GetString This returns us a temporary string, rather than leaking the atom. Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone 8ffa3713 2009-04-25T18:13:24 XKBcommon.h: Make header self-contained Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone 8b5af79b 2009-04-25T14:55:59 Keysym: Add apallingly bad API documentation for keysym <-> string Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone ad0a3d7c 2010-06-15T15:20:32 xkbcomp: Don't leak atom text and string exprs Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone 70b64213 2009-04-25T14:52:51 Make keysym <-> string conversion public API Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone 62eb167d 2009-04-25T14:51:46 XKB: Text: Use keysym <-> string conversion from keysym.c Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone cdc735c8 2009-04-25T14:42:42 Keysym: Fix conversion for Unicode and bare numbers Ensure that Unicode string representations are accepted and turned into numbers, as well as hexadecimal numbers in 0xabcd1234 form; unknown keysyms are output as 0xabcd1234 in string form. This also ensures that strings are never returned malloc()ed. Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone 8e3239a7 2009-04-25T14:32:04 KeySym: Actually handle NoSymbol Add NoSymbol into the keysym table, so keysym <-> string conversion works for that, too; also eliminate special-casing of VoidSymbol. This will require special-casing in libX11 to preserve its API. Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone a5ce9754 2009-04-25T14:29:23 test: Fix srcdir != objdir build and test failures filecomp would fail because it couldn't find the input files, after compilation failed due to missing includes. Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Dan Nicholson 4e854a21 2009-04-21T23:22:25 listing: Drop unused deviceSpec argument The server might care about this, but ListComponents is just reading xkb files.
Dan Nicholson 481deea1 2009-04-20T06:40:34 xkbcomp: Another fairly major rewrite of the listing mode The listing code in xkbcomp had been setup to allocate a set of buffers with file paths and then later parse through them to find which maps were needed. All the allocation (with the additional allocation for the components list) was making it really slow, so this patch makes everything simpler by just generating the components list as we walk the directory tree.
Dan Nicholson 18b43f8d 2009-04-19T16:30:36 Rewrite listing code to generate XkbComponentListPtr In xkbcomp, the listing code printed out the xkb files to stdout and the caller would parse the output. Here, we can just generate a XkbComponentListPtr and pass it back. This should be a series of smaller commits, but there was no clean way to do it since it's basically a complete rewrite except for the core map matching logic. A lot of code used for special printing modes in xkbcomp has been shedded. Callers can massage the output as they please.
Dan Nicholson 559305a5 2009-04-16T21:47:28 xkbcomp: Kill unused listing code and make functions static Much of this was only called from xkbcomp and not used to generate listings for the server.
Dan Nicholson 5983a4e6 2009-04-16T20:01:13 Scale back global variables Some of the global variables were either not used anymore or only used in the listing code.
Dan Nicholson 9520ea0e 2009-04-12T12:30:12 Add XkbNameMatchesPattern implementation from xkbfile The xkbcomp listing code matches a glob type pattern against installed xkb files. This adds a Xkbc implementation of the pattern matching code.
Dan Nicholson fa183ce3 2009-04-12T12:15:05 xkbcomp: Fix use of removed macros
Dan Nicholson 3d4c4d06 2009-04-12T11:13:52 Revert "xkbcomp: Remove listing sources" This reverts commit c4c9e36fbf4019d802323d9053f54cbfa6d3d5e5. It turns out that the listing code is used to support the X_kbListComponents request (via XkbListComponents). This will have to be refactored into some reasonable interface instead of the current usage where the server reads xkbcomp stdout. Gross.
Dan Nicholson 3dee8ac9 2009-04-12T12:14:36 misc: Coding-style cleanup
Dan Nicholson 53ead9b5 2009-04-11T10:35:44 Use xkbpath API for locating rules Instead of hardcoding the XKB base directory when searching for rules in the xkbcomp code, we can extend the xkbpath API to cover rules and reuse it. That will make it more convenient if it's ever exposed so people can set their XKB search paths in a reasonable way.
Dan Nicholson c728d91b 2009-04-10T12:33:31 Program and files for testing CompileKeymapFromFile A few simple test cases for verifying the operation of parsing a keymap file and compiling a keyboard description from it.
Dan Nicholson abbd1419 2009-04-10T12:25:51 Add interface to compile keyboard description from keymap files We need to support generating a keyboard description from a keymap file because there are just some cases where RMLVO or ktcsg is not enough. The map choosing logic has been refactored into its own function and now supports choosing a named or default keymap.
Dan Nicholson e98eb805 2009-04-09T20:52:26 test: Remove extraneous includes These programs don't actually use the internal API.
Dan Nicholson 0280b10d 2009-04-09T14:29:32 Make XkbcInitAtoms externally accessible Applications (like the server) need to initialize the atoms system before using the rest of the library. Maybe it should just init itself implicitly.
Dan Nicholson f5d37e27 2009-04-08T17:59:15 Constify public API There's no reason the arguments can't be const.
Dan Nicholson babae389 2009-04-08T17:54:55 Change CompileKeymapFromRules to take XkbRMLVOSet Let's use a nice interface now that it's available from XKBrulescommon.h.
Dan Nicholson 6a84a34d 2009-04-08T07:46:25 Remove all non-public API from XKBcommon.h header The noble intention was to expose all the new API and new generic types in the split out kbproto headers through XKBcommon.h. It turns out that would be a massive amount of work in the server. Someday, but first just wedging in XkbCompileKeymap* would be good. Most of the API is in new internal xkb*.h headers. In order to allow the XKBcommon.h header to be used from the server, we can't pull in other headers from kbproto since the server has its own copies. However, types that are different (XkbDescRec, XkbAction) still have Xkbc equivalents here, and I think they should be used in the server.
Dan Nicholson b4a3c39b 2009-04-07T19:56:41 Remove KS macros available in XKBfilecommon.h now A couple of the XkbcKS* macros become redundant with XKBfilecommon.h split out in kbproto.
Dan Nicholson 5889cef8 2009-04-05T20:27:35 Require strdup and remove utils wrapper This kills a couple warnings from using the uStringDup wrapper. If you don't have strdup on your platform, you have bigger issues.
Dan Nicholson 8b100fc0 2009-04-05T15:15:20 Add action datatypes as defined in the server Some of the XkbAction types are defined differently in the server, so we add those to XKBcommon.h and use them here like XkbcDescPtr. We'll have to deal with the impedance mismatch on the client side later.
Dan Nicholson e0e77b71 2009-04-05T09:30:15 Coding style cleanup on key allocation functions
Dan Nicholson 713c8f41 2009-04-04T12:54:44 test: Exercise compiling from components This could probably use a lot more real world test cases, but it does the job for now.
Dan Nicholson a2e59767 2009-04-04T12:50:27 xkbcomp: Don't say we're exiting when we're not
Dan Nicholson 85039a0d 2009-04-04T12:31:55 xkbcomp: Give keymap file empty name if none supplied Ensure that the keymap file topName is not NULL since it gets blindly dereferenced later.
Dan Nicholson 125ce76f 2009-04-04T12:21:05 xkbcomp: Ensure at least keycodes supplied in components It seems that at least a non-empty keycodes component is required to compile a XkbcDescPtr.
Dan Nicholson fdd8a9ec 2009-04-04T12:17:50 xkbcomp: Don't dereference NULL VarDefsPtr
Dan Nicholson 99d2f4a5 2009-04-04T12:16:04 xkbcomp: Refactor keymap file generator
Dan Nicholson 4f736db9 2009-04-04T11:04:35 test: Minor refactor to allow $EXEEXT in program names
Dan Nicholson 8f9a6129 2009-04-04T10:52:23 test: Add logging and some intentionally failing cases We want to log the output of the tests rather than letting them go to stderr. This allows tests we expect to fail to be run.
Dan Nicholson 8269cbce 2009-04-04T10:02:39 xkbcomp: Generating components requires rules _and_ layout This came from trial and error, but it seems that you can generate a valid keymap with only rules and layout.
Dan Nicholson fa96602d 2009-04-04T09:51:33 xkbcomp: Fail when converting rules to components returns an error XkbcRF_GetComponents was returning an error but leaving the generated components alone. This ensures that the broken XkbComponentNamesPtr is freed and the error is passed up to the caller.
Dan Nicholson e72fc29f 2009-04-04T09:48:59 xkbcomp: Cleanup error messages
Dan Nicholson 83367a8d 2009-04-04T09:46:20 xkbcomp: Ensure user has supplied a rules name
Dan Nicholson 95dbbb8a 2009-04-04T09:37:53 rulescomp: Remove unneeded API
Dan Nicholson 5d95a43a 2009-04-04T09:29:43 Refactor xkbpath so that it implicitly initializes Instead of requiring the user to call XkbInitIncludePath() and XkbAddDefaultDirectoriesToPath(), all the path entry points now implicitly initialize the path. When initializing, the default directories are added so it's useful. This provides normal operation without exposing the xkbpath API. That might happen later to allow apps to edit the XKB search path.
Dan Nicholson 5c910623 2009-04-04T09:19:51 Remove trailing spaces in source files
Dan Nicholson 5cc55d7c 2009-04-04T09:14:20 Test compiler to simulate xkbcomp usage Added a test program, rulescomp, which takes a RMLVO set and generates a XkbcDescPtr. This is essentially what the xserver will do, except that we still need to access some xkbcomp internal API to make it work.
Dan Nicholson 51eff3d9 2009-04-04T08:52:17 Fix cleanup error in names allocation A conditional got reversed during the coding style cleanup.
Dan Nicholson c38cdc5d 2009-04-03T21:18:58 xkbcomp: Ignore generated parser
Dan Nicholson 3a709e39 2009-04-03T21:16:56 xkbcomp: Don't segfault if the debug files aren't set Another interface that needs to be cleaned up.
Dan Nicholson ec86ce1f 2009-04-03T20:34:41 xkbcomp: Declare global debugging vars These will need to be sanitized at some point, but for now let's just get the code running.
Dan Nicholson c14c60bb 2009-04-03T20:33:01 xkbcomp: Back out strdup warning cleanup There are some spots in the code that use strdup without checking the argument, so we need this to not segfault. Cleanup later...
Dan Nicholson 71baa3d8 2009-04-03T19:35:01 Fix install path for XKBcommon.h
Dan Nicholson 5216f0c9 2009-04-02T06:37:16 Drop keysym.h pollution from XKBcommon.h There's really no need to pull this into a public header.
Dan Nicholson a9822d87 2009-04-01T06:22:06 Add xkbcommon pkg-config file
Dan Nicholson db03c9b7 2009-03-31T19:30:44 xkbcomp: Clean up utils prototypes Includes using a macro for the gcc format attributes instead of repeated ifdef's.
Dan Nicholson a27e56b6 2009-03-31T07:21:20 xkbcomp: Remove duplicated macros
Dan Nicholson 05daf09f 2009-03-31T07:09:47 xkbcomp: Kill warnings about address always evaluating as true
Dan Nicholson a1513292 2009-03-31T06:57:06 Merge commit 'tilt/master'
Dan Nicholson a8d936bd 2009-03-31T05:36:52 Compile keyboard description from XKB rules, too XkbcCompileKeymapFromRules can be used to generate a XkbDescPtr from XKB rules instead of using components. The previous XkbcCompileKeymap has been renamed to XkbcCompileKeymapFromComponents.
Dan Nicholson 94fd3174 2009-03-29T11:25:44 Add rules file parsing from xkbfile Copy over the Xkb_RF* rules parsing functions from xkbfile's maprules.c. Eventually, this will be tied into xkbcomp's path searching utilities so you don't need to supply a full path to the rules file. Also, it this should eventually incorporate the server's RMLVOSet.
Dan Nicholson e1284944 2009-03-29T11:25:44 Add rules rules file parsing from xkbfile Copy over the Xkb_RF* rules parsing functions from xkbfile's maprules.c. Eventually, this will be tied into xkbcomp's path searching utilities so you don't need to supply a full path to the rules file. Also, it this should eventually incorporate the server's RMLVOSet.
Dan Nicholson 3fc0dcc8 2009-03-29T08:55:18 Generate keyboard description from components Finally, we can generate a XkbcDescPtr from a XkbComponentNamesPtr. This involves turning the components into a parsed XKB file and then passing it into the compiler. This first conversion needs more error handling.
Dan Nicholson 1115d555 2009-03-29T08:17:13 xkbcomp: Include Xdefs.h for Atom in tokens.h
Dan Nicholson 587a5d95 2009-03-29T08:15:27 xkbcomp: Add missing includes for Bool in xkbpath
Dan Nicholson e86b31ce 2009-03-29T08:11:25 Add XKBlib resizing functions These were originally in XKBMalloc.c.
Dan Nicholson d43a7bf0 2009-03-28T19:21:18 Copy xkbfile IsUpper/IsLower macros xkbcomp was using Xlib's XConvertCase to check upper/lowercase. That's a lot of code, so hopefully the xkbfile macros using _XkbKSCheckCase are good enough. This also required that <X11/keysym.h> is included to get all the XK_* definitions.
Dan Nicholson eff1c538 2009-03-28T19:00:13 Copy XkbEnsureSafeMapName from xkbfile
Dan Nicholson c4c9e36f 2009-03-28T18:50:29 xkbcomp: Remove listing sources The xkbcomp listing APIs were only needed for the "xkblist" mode, which won't be supported here.
Dan Nicholson fe94593d 2009-03-28T18:17:34 malloc/misc/xkb: Coding style cleanup
Dan Nicholson 5315e5d1 2009-03-28T17:55:46 Add XKBlib API to support keytypes Added common variants of XkbComputeEffectiveMap, XkbInitCanonicalKeyTypes and all their needed functions. A couple functions that were in alloc.c moved to malloc.c to mirror the libX11 sources better. Original code in libX11/src/xkb/XKBMalloc.c libX11/src/xkb/XKBMisc.c libX11/src/xkb/XKB.c
Dan Nicholson baa9581d 2009-03-28T16:21:25 geom: Coding-style cleanup
Dan Nicholson 62482b96 2009-03-28T16:08:46 Add geometry Compute API from XKBlib A small needed subset from libX11/src/xkb/XKBGeom.c.
Dan Nicholson 28de09e5 2009-03-28T15:51:06 Add xkbcommon macro for XkbKSIsKeypad and XkbKSIsDeadKey(k) IsKeypad is used in symbols, but we'll just grab them both. It might be better to split parts of XKBfile.h out eventually.
Dan Nicholson a53b9b1e 2009-03-28T15:32:51 Add XkbModIndexText replacement Now, I think we should have all the *Text functions we need.
Dan Nicholson a59ce8f5 2009-03-28T15:24:06 Drop another unneeded format argument Almost cleared of XkbMessage...
Dan Nicholson 54aea7fe 2009-03-28T15:12:30 Add VMod Text functions from xkbfile
Dan Nicholson 46e5e164 2009-03-28T12:39:21 Copy XkbAddGeom* functions from XKBlib These are needed by the geometry compiler in xkbcomp.
Dan Nicholson b0acc97a 2009-03-28T12:03:35 xkbcomp: s/XStringToKeysym/XkbcStringToKeysym/
Dan Nicholson 1f08ae1e 2009-03-28T11:56:35 Expose all the geometry allocation subroutines We need a couple in xkbcomp, but they might also be needed externally, too.
Dan Nicholson 39d7be43 2009-03-28T11:45:05 xkbcomp: Use xkbcommon allocation functions s/XkbAlloc/XkbcAlloc/ so we don't know XKBlib.
Dan Nicholson 2671b777 2009-03-28T14:06:26 Add more *Text functions from xkbfile This should cover all the usage in xkbcomp. The format arguments were dropped except for the special case of XkbModMaskText, which needs to write in XkbCFile format in HandleVModDef. This was just changed to a Bool to avoid the need for the macros in XKBfile.h. The function prefixes have been renamed to be unique from xkbfile.
Dan Nicholson b9335d58 2009-03-28T14:09:36 Kill off usage of Display The use of Display in xkbcomp always boiled down to passing it to XkbInternAtom and XkbAtomGetString. This shouldn't be a problem here.
Dan Nicholson 8544cde5 2009-03-28T06:56:26 xkbcomp: Drop unused Display argument in Atom functions The xkbcommon Atom implementation doesn't take Display into account.
Dan Nicholson 18337008 2009-03-27T20:58:27 libxkbcomp: Use the internal Atom implementation s/XkbInternAtom/XkbcInternAtom/ and s/XkbAtomGetString/XkbcAtomGetString/
Dan Nicholson 4fe322aa 2009-03-27T20:13:22 libxkbcomp: s/XPointer/char */ Replace XPointer with its definition since we don't have the privilege of using Xlib.h. Why this is char * and not void *, I'll never know.
Dan Nicholson c277d3d4 2009-03-27T20:53:26 libxkbcomp: s/Status/int/ since we don't have Xlib.h
Dan Nicholson d5a9be65 2009-03-27T20:32:33 libxkbcomp: Drop unused format field for *Text functions
Dan Nicholson 6a578de9 2009-03-27T20:20:01 libxkbcomp: Add non-xkbfile XkbActionTypeText
Dan Nicholson 72df9bb3 2009-03-28T06:32:08 Move *Text APIs into libxkbcommon These seem like they might be generally useful, and more will be needed from xkbfile.
Dan Nicholson 37769b5a 2009-03-27T20:01:32 libxkbcomp: s/XkbDescPtr/XkbcDescPtr/ We need to use the keyboard description structure from XKBcommon.h since it doesn't have the Display field.