Branch :
| Author | Commit | Date | CI | Message |
|---|---|---|---|---|
| c24d97e4 | 2012-03-01 19:45:37 | Don't leak DoodadInfo's from GeometryInfo Signed-off-by: Ran Benita <ran234@gmail.com> | ||
| c800c60a | 2012-03-01 19:25:37 | Don't leak ActionInfo's Signed-off-by: Ran Benita <ran234@gmail.com> | ||
| 5c40bee6 | 2012-02-29 21:57:15 | Don't leak the "minimum"/"maximum" string Signed-off-by: Ran Benita <ran234@gmail.com> | ||
| c50c87bc | 2012-03-01 21:26:25 | Don't leak the various *Info's names when overriding them Signed-off-by: Ran Benita <ran234@gmail.com> | ||
| d67e73bd | 2012-03-01 00:10:37 | Don't leak KeyNamesInfo Signed-off-by: Ran Benita <ran234@gmail.com> | ||
| 889a299e | 2012-03-02 14:49:36 | Free XkbFile's when no longer needed Signed-off-by: Ran Benita <ran234@gmail.com> | ||
| c357a11a | 2012-03-01 21:20:45 | Add function to free XkbFile's Signed-off-by: Ran Benita <ran234@gmail.com> | ||
| 3216ecc0 | 2012-02-24 10:46:41 | Don't cache loaded rules files This needlessly occupies memory for the lifetime of the library, and does not make a noticeable difference otherwise. This rules file won't be loaded more than once in most cases anyway, so just load it again when it happens. Signed-off-by: Ran Benita <ran234@gmail.com> | ||
| ca9829ea | 2012-02-24 09:59:25 | Don't cache parsed files This needlessly occupies memory for the lifetime of the library, and does not make a noticeable difference otherwise. Instead, just parse the same file again when it happens. Signed-off-by: Ran Benita <ran234@gmail.com> | ||
| 266dfae5 | 2012-02-29 21:26:28 | Remove useless casts Signed-off-by: Ran Benita <ran234@gmail.com> | ||
| a64e9708 | 2012-03-02 15:56:03 | Remove unneeded freeing mechanisms Signed-off-by: Ran Benita <ran234@gmail.com> | ||
| c7bf3687 | 2012-03-02 22:36:32 | Make the sections array local to the keymap compiling function Signed-off-by: Ran Benita <ran234@gmail.com> | ||
| baf6a677 | 2012-03-02 22:34:14 | Remove unused global type tokens Signed-off-by: Ran Benita <ran234@gmail.com> | ||
| f549ce07 | 2012-03-02 17:25:58 | Use global tables for action string handling Signed-off-by: Ran Benita <ran234@gmail.com> | ||
| d2c3dd0c | 2012-03-02 22:31:29 | Constify some more text functions Signed-off-by: Ran Benita <ran234@gmail.com> | ||
| eb738b13 | 2012-03-02 17:40:19 | Constify global tables Signed-off-by: Ran Benita <ran234@gmail.com> | ||
| 4bc839ab | 2012-02-29 20:50:17 | Use memset instead of bzero Signed-off-by: Ran Benita <ran234@gmail.com> | ||
| a3e40917 | 2012-03-01 23:43:51 | Remove return's at the end of void functions Signed-off-by: Ran Benita <ran234@gmail.com> | ||
| f278cea1 | 2012-02-29 20:25:11 | Remove all uses of the register keyword Signed-off-by: Ran Benita <ran234@gmail.com> | ||
| 6a34e4e1 | 2012-02-29 19:56:39 | Don't check for NULL before free() Signed-off-by: Ran Benita <ran234@gmail.com> | ||
| c41061a0 | 2012-02-23 19:26:33 | Use yacc-generated header instead of tokens.h The yacc implementation can generate all the necessary token definitions itself; there is no need to maintain a hand written file for that. Signed-off-by: Ran Benita <ran234@gmail.com> | ||
| f3e4335f | 2012-02-24 16:07:17 | Fix all constness warnings These are all trivial/obvious fixes which clear a bunch of warnings. Signed-off-by: Ran Benita <ran234@gmail.com> | ||
| cca1c050 | 2012-02-24 16:03:44 | Fix possible null dereferences Fix all reported null dereferences from clang-analyzer. There seems to be one false negative (in file indicators.c), but it is fixed anyway. Signed-off-by: Ran Benita <ran234@gmail.com> | ||
| 744527e9 | 2012-02-24 16:10:06 | Fix remaining warnings Signed-off-by: Ran Benita <ran234@gmail.com> | ||
| eff72fab | 2012-02-25 11:53:01 | Fix warnings in scanner and parser Signed-off-by: Ran Benita <ran234@gmail.com> | ||
| 1d969c5c | 2012-02-24 16:08:55 | Fix an incorrect sizeof Signed-off-by: Ran Benita <ran234@gmail.com> | ||
| 9005624f | 2012-02-24 16:00:10 | Remove unneeded assignments and variables Signed-off-by: Ran Benita <ran234@gmail.com> | ||
| a0dd0526 | 2012-02-25 11:46:12 | Remove unused includes of "tokens.h" Signed-off-by: Ran Benita <ran234@gmail.com> | ||
| 9ad0be33 | 2012-02-24 10:04:16 | Remove unused debug #defines Signed-off-by: Ran Benita <ran234@gmail.com> | ||
| 1ab058bb | 2012-02-20 17:47:46 | Fix typo in ExprResolveKeyCode Signed-off-by: Daniel Stone <daniel@fooishbar.org> | ||
| e209fe31 | 2012-02-20 17:33:39 | Perform bounds checking in ExprResolveGroup Every caller did the exact same check on the group bounds after calling ExprResolveGroup, so might as well do it inside. Signed-off-by: Daniel Stone <daniel@fooishbar.org> | ||
| 43ed3ff0 | 2012-02-20 17:14:04 | Switch expression resolution priv from char to void Avoids a lot of really lame casts. Signed-off-by: Daniel Stone <daniel@fooishbar.org> | ||
| eb6d9a05 | 2012-02-20 17:09:06 | Remove chaining support from LookupModMask Turns out we never use it, so. Signed-off-by: Daniel Stone <daniel@fooishbar.org> | ||
| 11ea0791 | 2012-02-20 17:07:48 | Invert LookupModMask/LookupVModMask order We never want to solely lookup a virtual modifier without also looking up core modifiers. So, rather than chaining the vmod lookup inside the core modifier lookup, invert the ordering. Signed-off-by: Daniel Stone <daniel@fooishbar.org> | ||
| 1a2f2556 | 2012-02-20 17:00:51 | Remove unused LookupPriv::priv Signed-off-by: Daniel Stone <daniel@fooishbar.org> | ||
| 55e058f8 | 2012-02-20 16:59:51 | Move some definitions from expr.h to expr.c Signed-off-by: Daniel Stone <daniel@fooishbar.org> | ||
| 90d86c36 | 2012-02-20 16:54:54 | Remove field reference lookup support None of the lookup functions anyone ever used supported field references, so don't pretend we do in the API. Signed-off-by: Daniel Stone <daniel@fooishbar.org> | ||
| 590df28c | 2012-02-20 16:35:39 | Move groupNames mask definition to its user groupNames was declared in compat.c as a global to anything which included compat.h (for which groupNames was its sole reason to exist), but only ever used in indicators.c. Which is kind of fortunate, given that e314931e removed identical definitions of groupNames (as integers, not masks) from both action.c and symbols.c. Signed-off-by: Daniel Stone <daniel@fooishbar.org> | ||
| 91b89852 | 2012-02-20 16:24:02 | Turn ExprResolveInteger into a simple wrapper Move the bulk of ExprResolveInteger into an internal function called ExprResolveIntegerLookup, and introduce ExprResolveInteger as a simple wrapper which doesn't take priv/lookup arguments. Signed-off-by: Daniel Stone <daniel@fooishbar.org> | ||
| d32822e6 | 2012-02-20 16:04:37 | Open-code a radio group SimpleLookup Because, joke's on you, it wasn't actually looking up radio groups. Just checking to see if it was a string that was "none", or an integer. Lord give me strength. Signed-off-by: Daniel Stone <daniel@fooishbar.org> | ||
| e314931e | 2012-02-20 15:47:57 | Add ExprResolveGroup helper Just a dumb wrapper around ExprResolveInteger. Signed-off-by: Daniel Stone <daniel@fooishbar.org> | ||
| 8b47dbbf | 2012-02-20 15:47:38 | Add ExprResolveButton helper Just a dumb wrapper around ExprResolveInteger. Signed-off-by: Daniel Stone <daniel@fooishbar.org> | ||
| 3431a089 | 2012-02-20 15:37:53 | Introduce ExprResolveLevel helper Which returns an integer representing the level number represented by the given expression. Signed-off-by: Daniel Stone <daniel@fooishbar.org> | ||
| 193e9b39 | 2012-02-20 15:33:40 | Introduce ExprResolveRadioGroup helper Just a tiny special-cased version of ExprResolveInteger. Signed-off-by: Daniel Stone <daniel@fooishbar.org> | ||
| 26285a7b | 2012-02-20 14:15:08 | Remove priv arguments from ExprResolveString They've never been used. Signed-off-by: Daniel Stone <daniel@fooishbar.org> | ||
| b7b49eb0 | 2012-02-20 14:10:41 | Remove priv arguments from ExprResolveKeySym They've never been used by its one caller. Signed-off-by: Daniel Stone <daniel@fooishbar.org> | ||
| 70033b13 | 2012-02-20 14:08:55 | Remove priv arguments from ExprResolveKeyName They've never been used. Signed-off-by: Daniel Stone <daniel@fooishbar.org> | ||
| 482d4faa | 2012-02-20 13:44:27 | Remove priv arguments from ExprResolveBoolean They've never been used. Signed-off-by: Daniel Stone <daniel@fooishbar.org> | ||
| 94041575 | 2012-02-20 13:40:34 | Remove priv arguments from ExprResolveFloat They've never been used. Signed-off-by: Daniel Stone <daniel@fooishbar.org> | ||
| 3151ce36 | 2012-02-20 13:34:36 | Remove priv arguments from ExprResolveModMask What with them now being unused and all. Signed-off-by: Daniel Stone <daniel@fooishbar.org> | ||
| 67605d2c | 2012-02-20 13:32:09 | Introduce ExprResolveVModMask Which is just a slightly more typesafe wrapper around the chained ExprResolveModMask everyone was using earlier. Signed-off-by: Daniel Stone <daniel@fooishbar.org> | ||
| fbb82199 | 2012-02-16 11:18:49 | Respect explicit minimum/maximum keycodes Make sure we carry over an explicit minimum/maximum keycode setting, rather than just using the computed minimum/maximum; this got broken while changing the keycode range to be unsigned. Signed-off-by: Daniel Stone <daniel@fooishbar.org> Reported-by: Pekka Paalanen <ppaalanen@gmail.com> | ||
| c45cdb0c | 2012-02-16 00:22:11 | Still more memory leak fixes Signed-off-by: Daniel Stone <daniel@fooishbar.org> | ||
| 83f18b1c | 2012-02-15 19:39:33 | Fix xkbparse.y compilation Thanks to autotools happily building stale generated sources, I hadn't actually ever built my xkbparse.y changes. Fix that so it not only compiles, but works. This seems to parse long keycodes correctly, although I very much would not recommend testing this by declaring 0x1fffffff as your highest keycode. Signed-off-by: Daniel Stone <daniel@fooishbar.org> | ||
| eb8c96cb | 2012-02-15 16:42:45 | Don't leak SymbolsInfo Signed-off-by: Daniel Stone <daniel@fooishbar.org> | ||
| 67c874d7 | 2012-02-15 16:24:07 | Enable stderr debugging by default (If debugFlags is set to non-zero.) Signed-off-by: Daniel Stone <daniel@fooishbar.org> | ||
| 1a6c3807 | 2012-02-15 15:58:14 | vmod: Pass xkb_desc explicitly to vmod functions Some error paths don't set info->xkb correctly, so just do like most utility functions and pass the xkb_desc explicitly. Signed-off-by: Daniel Stone <daniel@fooishbar.org> | ||
| 4e228511 | 2012-02-15 14:34:08 | Introduce xkb_keycode_t for keycodes And use it consistently everywhere, including with a special long-safe internal keycode type, to ease the transition to large keycodes. Signed-off-by: Daniel Stone <daniel@fooishbar.org> | ||
| 8f01b144 | 2012-02-15 12:54:11 | xkbscan: Copy, rather than assign, file name For some reason, lex decided to reduce a strcpy into an assignment, leading to entirely justified valgrind warnings about invalid reads, when scanFile was set to a string which may have only ever lived on the stack of a now-exited function. Make it a strdup() instead. Signed-off-by: Daniel Stone <daniel@fooishbar.org> | ||
| ead9d0cb | 2012-02-15 11:49:10 | Move include path from X11/extensions/ to xkbcommon/ Signed-off-by: Daniel Stone <daniel@fooishbar.org> | ||
| 615291f1 | 2012-01-05 14:20:35 | xkbcomp: Silence warning of return of uninitialised value Some routes through HandleGeometryVar do not set a return value. Set a default value for the return variable to avoid returning an uninitialised value. | ||
| c19661b9 | 2011-12-16 12:52:00 | Add xkbc_free_keymap helper Which just calls XkbcFreeKeyboard with the only arguments you'd ever pass it. Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com> Signed-off-by: Daniel Stone <daniel@fooishbar.org> | ||
| 99e29de2 | 2011-10-27 14:30:21 | xkbcomp: Copy the string into the buffer rather than updating pointer Avoids assigning the global pointer to a value that may only have a stack lifetime: Fixes valgrind warnings such as: ==24795== Invalid read of size 1 ==24795== at 0x4A06E9A: strcpy (mc_replace_strmem.c:311) ==24795== by 0x4E54D68: ProcessIncludeFile (misc.c:73) ==24795== by 0x4E59726: HandleIncludeSymbols.constprop.3 (symbols.c:829) ==24795== by 0x4E59D8E: HandleSymbolsFile (symbols.c:1673) ==24795== by 0x4E5A068: CompileSymbols (symbols.c:2211) ==24795== by 0x4E51A61: CompileKeymap (keymap.c:155) ==24795== by 0x4E5B410: xkb_compile_keymap_from_components (xkbcomp.c:236) ==24795== by 0x4E5B587: xkb_compile_keymap_from_rules (xkbcomp.c:161) ==24795== by 0x405ED2: display_create (window.c:2007) ==24795== by 0x403732: main (desktop-shell.c:320) ==24795== Address 0x7fefff0a0 is just below the stack ptr. To suppress, use: --workaround-gcc296-bugs=yes ==24795== ==24795== Source and destination overlap in strcpy(0x7fefff430, 0x7fefff430) ==24795== at 0x4A06F3D: strcpy (mc_replace_strmem.c:311) ==24795== by 0x4E54D68: ProcessIncludeFile (misc.c:73) ==24795== by 0x4E59726: HandleIncludeSymbols.constprop.3 (symbols.c:829) ==24795== by 0x4E59D8E: HandleSymbolsFile (symbols.c:1673) ==24795== by 0x4E5A068: CompileSymbols (symbols.c:2211) ==24795== by 0x4E51A61: CompileKeymap (keymap.c:155) ==24795== by 0x4E5B410: xkb_compile_keymap_from_components (xkbcomp.c:236) ==24795== by 0x4E5B587: xkb_compile_keymap_from_rules (xkbcomp.c:161) ==24795== by 0x405ED2: display_create (window.c:2007) ==24795== by 0x403732: main (desktop-shell.c:320) | ||
| f91afe4f | 2011-06-03 17:19:09 | Add prototype for CheckDefaultMap(). Those warnings disappear accordingly: | CC parseutils.lo | parseutils.c:742: warning: no previous prototype for ‘CheckDefaultMap’ | CC xkbscan.lo | xkbscan.l: In function ‘XKBParseString’: | xkbscan.l:220: warning: implicit declaration of function ‘CheckDefaultMap’ | xkbscan.l:220: warning: nested extern declaration of ‘CheckDefaultMap’ Reviewed-by: Dirk Wallenstein <halsmit@t-online.de> Signed-off-by: Cyril Brulebois <kibi@debian.org> | ||
| 621c2a7a | 2011-01-29 14:24:46 | Get rid of unneeded <X11/Xlib.h> include. There's no need for this xlib include: | YACC xkbparse.c | CC xkbparse.lo | xkbparse.y:98:22: error: X11/Xlib.h: No such file or directory Signed-off-by: Cyril Brulebois <kibi@debian.org> Signed-off-by: Kristian Høgsberg <krh@bitplanet.net> | ||
| a63e82be | 2010-12-17 21:14:54 | Rename XkbcInternAtom() to xkb_intern_atom() and export Signed-off-by: Kristian Høgsberg <krh@bitplanet.net> | ||
| f5076604 | 2010-12-07 11:09:13 | config: let Automake handle Lex and Yacc dist and cleaning BUILT_SOURCES and MAINTAINERCLEAN are not needed for lex and yacc Note that xkbscan was missing on those lines. Automake generates all the rules to handle building, distribution and cleaning. Acked-by: Daniel Stone <daniel@fooishbar.org> Reviewed-by: Kristian Høgsberg <krh@bitplanet.net> Signed-off-by: Gaetan Nadon <memsize@videotron.ca> | ||
| 63e2719a | 2010-12-07 10:33:23 | config: replace deprecated INCLUDES with AM_CPPFLAGS Fixes automake warning. Acked-by: Daniel Stone <daniel@fooishbar.org> Reviewed-by: Kristian Høgsberg <krh@bitplanet.net> Signed-off-by: Gaetan Nadon <memsize@videotron.ca> | ||
| ceba14dc | 2010-12-07 10:23:18 | config: update subdirs .gitignore Signed-off-by: Gaetan Nadon <memsize@videotron.ca> | ||
| f8301ebc | 2010-11-11 23:27:21 | xkbscan: resolve build warning/rpmlint error xkbscan.l: In function 'setScanState': xkbscan.l:201:1: warning: control reaches end of non-void function I: Program returns random data in a function E: libxkbcommon no-return-in-nonvoid-function xkbscan.l:201 Change return type of setScanState to void, since a return value is never used by its callers. Signed-off-by: Jan Engelhardt <jengelh@medozas.de> | ||
| c88439db | 2010-10-20 22:27:07 | Update xkb->ctrls->num_groups when copying the keysyms This used to be set when we read an XKM file. | ||
| 12569157 | 2010-10-20 15:57:45 | Restore compatible action structs This unbreaks the X server code to serialize an xkb_desc, but loses the 32 bit vmod fields. Needs some work... | ||
| a84c0879 | 2010-10-19 21:57:59 | Use flex for generating the scanner, add support for parsing from strings Signed-off-by: Kristian Høgsberg <krh@bitplanet.net> | ||
| 73ca959d | 2010-09-27 16:05:52 | Dead code removal and static markup Signed-off-by: Adam Jackson <ajax@redhat.com> | ||
| fb05ee47 | 2010-09-03 20:35:28 | Remove libxkbfile dependency for real this time | ||
| 20bfe128 | 2010-08-29 21:30:10 | Use const char * in struct xkb_rule_names | ||
| be2bd661 | 2010-08-25 14:51:52 | Pull in a few #defines from libxkbfile and lower kbproto requirement | ||
| b3805a23 | 2010-07-02 12:26:43 | Get rid of a few unused #defines in public header | ||
| 97fbc348 | 2010-07-02 12:14:03 | Rename XkbRMLVOSet to struct xkb_rule_names | ||
| 3f0034a9 | 2010-07-02 11:50:01 | Rename public entry points to lowercase and underscore | ||
| 9f602686 | 2010-07-01 14:35:24 | Pull in enough structs and defines from XKBstr.h to only need XKB.h We want to move away from sharing implementation structs and let libX11 and libxkbcommon use each their own set of structs. | ||
| e10e16ad | 2010-06-30 17:20:56 | Constify XkbcAtomText() Atoms aren't mutable and this lets us put tbGetBuffer() back in the box. | ||
| 0ece2cdb | 2010-06-30 16:56:24 | Drop more malloc/free wrappers | ||
| a76df865 | 2010-06-30 16:33:25 | Use the right action structs We were casting the union members to the wrong action structs (from kbproto). | ||
| 1723ef1b | 2010-06-30 15:48:39 | Copy over missing action structs from kbproto | ||
| 9258cc3d | 2010-06-30 13:31:21 | Rename Xkbc*Action to struct xkb_*_action | ||
| 399d4bd6 | 2010-06-28 06:58:01 | Drop malloc wrappers | ||
| 47d3b396 | 2010-06-28 06:50:12 | Drop CARD32 and Opaque types | ||
| 2fb329c9 | 2010-06-23 16:25:10 | Copy and duplicate XkbModsRec and XkbKTMapEntryRec Copy these types in so we can extend the vmod size. Signed-off-by: Daniel Stone <daniel@fooishbar.org> | ||
| 8693c265 | 2010-06-22 15:54:52 | Add really rudimentary rules caching support Keep the parsed form of the last-used rules file around, and reuse that if we get asked for the same ruleset. If not, bin it and cache the other one. Signed-off-by: Daniel Stone <daniel@fooishbar.org> | ||
| 7257d4c8 | 2010-06-21 14:28:34 | Use CARD32 instead of Atom, move geom headers in Use CARD32 instead of Atom/KeySym/et al to avoid type size confusion between server and non-server code; relatedly, move the geometry headers in from kbproto, so every non-simple type (i.e. structs containing nothing more than basic types) is now copied into xkbcommon. Signed-off-by: Daniel Stone <daniel@fooishbar.org> | ||
| b3852542 | 2010-06-21 14:27:58 | Interp: More lazy keysym resolution Resolve the keysyms when we create an InterpDef, rather than directly in the parser. Signed-off-by: Daniel Stone <daniel@fooishbar.org> | ||
| 15b0db54 | 2010-06-17 05:56:08 | Copy in XkbCompatMapRec and XkbSymInterpretRec These contain actions, so transition them ahead to XkbcAction and move them into XKBcommon.h. Signed-off-by: Daniel Stone <daniel@fooishbar.org> | ||
| 60e7eeeb | 2010-06-17 03:16:09 | Use CARD32 instead of Atom, drag in XkbClientMapRec On 64-bit architectures, XID varies in size between the server (always 32 bits), and non-server (always unsigned long) for some inexplicable reason. Use CARD32 instead to avoid this horrible trap. This involves dragging in XkbClientMapRec so we don't get stuck in the KeySym trap. Signed-off-by: Daniel Stone <daniel@fooishbar.org> | ||
| a22386d4 | 2010-06-15 15:23:23 | xkbcomp: Don't leak atom text and string exprs, again Signed-off-by: Daniel Stone <daniel@fooishbar.org> | ||
| acc467de | 2010-06-15 19:39:15 | xkbcomp: Use fread() instead of getc() So, it turns out that if you're parsing a fairly large amount of data, using getc() to get all the input rather than, say, read(), is some kind of remarkably daft and unperformant idea. Signed-off-by: Daniel Stone <daniel@fooishbar.org> | ||
| d2d787df | 2010-06-17 00:51:49 | Regroup actions into current vs. deprecated, resize vmod Use Xkbc* for all our actions that we intend to keep around, and Xkb* for deprecated ones we can hopefully get rid of, at least internally. While we're at it, make vmods be a uint32_t. Signed-off-by: Daniel Stone <daniel@fooishbar.org> | ||
| e564235b | 2010-06-15 19:43:14 | xkbcomp: Don't malloc() and free() most scanned tokens Use a constant buffer instead. Sigh. Signed-off-by: Daniel Stone <daniel@fooishbar.org> | ||
| f246db20 | 2010-06-15 19:40:31 | Fix compilation with DEBUG Signed-off-by: Daniel Stone <daniel@fooishbar.org> | ||
| 240a0c34 | 2010-06-15 19:38:16 | xkbcomp: Lazy keysym parsing (avoid XStringToKeysym) Instead of calling XStringToKeysym on every keysym we parse, store it as a string until we need to store it in an actual keymap. Signed-off-by: Daniel Stone <daniel@fooishbar.org> |