thodg/libgit2/src/config.c

---

src/config.c

---

Log

Author	Commit	Date	CI	Message
	86c02614	2013-08-09T11:05:02		config: deduplicate iterator creation When the glob iterator is passed NULL regexp, call the non-globbing iterator so we don't have to special-case which functions to call.
	d8488b98	2013-08-09T10:37:35		config: implement _foreach and _foreach_match on top of the iterator directly Use a glob iterator instead of going through git_config_backend_foreach_match. This function is left as it's exposed in the API.
	54f3a572	2013-08-09T10:29:11		config: introduce a regex-filtering iterator
	d8289b9f	2013-08-09T11:03:13		config: handle empty backends when iterating
	5880962d	2013-08-09T09:05:19		config: introduce _iterator_new() As the name suggests, it iterates over all the entries
	a319ffae	2013-08-08T21:00:33		config: fix leaks in the iterators
	1e96c9d5	2013-08-08T20:47:06		config: add _next() and _iterator_free() Make it look like the refs iterator API.
	99dfb538	2013-08-08T17:57:59		config: working multivar iterator Implement the foreach version as a wrapper around the iterator.
	cca5df63	2013-08-08T16:59:39		config: hopefully get the iterator to work on multivars
	3a7ffc29	2013-08-08T16:18:07		config: initial multivar iterator
	eba73992	2013-08-08T14:39:32		config: move next() and free() into the iterator Like we have in the references iterator, next and free belong in the iterator itself.
	4efa3290	2013-08-08T13:41:18		config: get_multivar -> get_multivar_foreach The plain function will return an iterator, so move this one out of the way.
	84fec6f6	2013-08-08T13:14:35		config: saner iterator errors Really report an error in foreach if we fail to allocate the iterator, and don't fail if the config is emtpy.
	4d588d97	2013-08-08T11:24:47		Don't typedef a pointer Make the iterator structure opaque and make sure it compiles.
	a603c191	2013-03-18T21:02:36		replaced foreach() with non callback based iterations in git_config_backend new functions in struct git_config_backend: * iterator_new(...) * iterator_free(...) * next(...) The old callback based foreach style can still be used with `git_config_backend_foreach_match`
	e4fda954	2013-07-09T16:46:18		A little git_config_get_multivar code cleanup
	07fba63e	2013-07-06T23:51:40		Fix return value in git_config_get_multivar If there is not an error, the return value was always the return value of the last call to file->get_multivar With this commit GIT_ENOTFOUND is only returned if all the calls to filge-get_multivar return GIT_ENOTFOUND.
	37f66e82	2013-06-12T15:21:21		Fix Windows warnings This fixes problems with missing function prototypes and 64-bit data issues on Windows.
	6de9b2ee	2013-06-12T21:10:33		util: It's called `memzero`
	eb58e2d0	2013-06-12T21:05:48		Merge remote-tracking branch 'arrbee/minor-paranoia' into development
	3e9e6cda	2013-06-07T09:54:33		Add safe memset and use it This adds a `git__memset` routine that will not be optimized away and updates the places where I memset() right before a free() call to use it.
	f658dc43	2013-05-31T14:09:58		Zero memory for major objects before freeing By zeroing out the memory when we free larger objects (i.e. those that serve as collections of other data, such as repos, odb, refdb), I'm hoping that it will be easier for libgit2 bindings to find errors in their object management code.
	16adc9fa	2013-05-24T10:35:58		Typedef git_config_level_t and use it everywhere The GIT_CONFIG_LEVEL constants actually work well as an enum because they are mutually exclusive, so this adds a typedef to the enum and uses that everywhere that one of these constants are expected, instead of the old code that typically used an unsigned int.
	0700ca1a	2013-05-23T16:11:53		More config code checks and cleanups
	3b32b6d3	2013-05-23T09:19:42		More tests of config with various absent files Plus a bit of extra paranoia to ensure config object has valid contents.
	0cb16fe9	2013-05-15T20:26:55		Unify whitespaces to tabs
	5d831887	2013-05-07T00:10:02		config: convenience function to open global/xdg The rules for which one to open is a bit silly, so let's make it easier for our users.
	a4b75dcf	2013-05-06T21:51:25		repo: unconditionally create a global config backend When a repository is initialised, we need to probe to see if there is a global config to load. If this is not the case, the user isn't able to write to the global config without creating the backend and adding it themselves, which is inconvenient and overly complex. Unconditionally create and add a backend for the global config file regardless of whether it exists as a convenience for users. To enable this, we allow creating backends to files that do not exist yet, changing the semantics somewhat, and making some tests invalid.
	3f663178	2013-05-01T13:38:56		More care catching and setting config errors
	0a1755c0	2013-04-30T03:15:45		Catch issue in config set with no config file This prevents a segfault when setting a value in the config of a repository that doesn't have a config file.
	6be368bf	2013-04-22T16:24:53		Clear repo config cache when cfgs are set This is a conservative change, but it seemed like the only safe thing to do -- i.e. clear the cvar cache when a config gets set.
	ab01cbd4	2013-04-22T14:24:12		Add configs to repo config cache This adds a bunch of additional config values to the repository config value cache and makes it easier to add a simple boolean config without creating enum values for each possible setting. Also, this fixes a bug in git_config_refresh where the config cache was not being cleared which could lead to potential incorrect values. The work to start using the new cached configs will come in the next couple of commits...
	83041c71	2013-04-19T11:52:04		Move git_config_backend to include/git2/sys Moving backend implementor objects into include/git2/sys so the APIs can be isolated from the ones that normal libgit2 users would be likely to use.
	5b27bf7e	2013-03-18T16:17:14		Merge pull request #1417 from arrbee/opts-for-paths Implement opts interface for global/system file search paths
	41954a49	2013-03-18T14:19:35		Switch search paths to classic delimited strings This switches the APIs for setting and getting the global/system search paths from using git_strarray to using a simple string with GIT_PATH_LIST_SEPARATOR delimited paths, just as the environment PATH variable would contain. This makes it simpler to get and set the value. I also added code to expand "$PATH" when setting a new value to embed the old value of the path. This means that I no longer require separate actions to PREPEND to the value.
	50eb8520	2013-03-18T14:05:31		Merge pull request #1420 from KindDragon/static-code-analyzer-warnings Several warnings detected by static code analyzer fixed
	10c06114	2013-03-17T04:46:46		Several warnings detected by static code analyzer fixed Implicit type conversion argument of function to size_t type Suspicious sequence of types castings: size_t -> int -> size_t Consider reviewing the expression of the 'A = B == C' kind. The expression is calculated as following: 'A = (B == C)' Unsigned type is never < 0
	5540d947	2013-03-15T16:39:00		Implement global/system file search paths The goal of this work is to expose the search logic for "global", "system", and "xdg" files through the git_libgit2_opts() interface. Behind the scenes, I changed the logic for finding files to have a notion of a git_strarray that represents a search path and to store a separate search path for each of the three tiers of config file. For each tier, I implemented a function to initialize it to default values (generally based on environment variables), and then general interfaces to get it, set it, reset it, and prepend new directories to it. Next, I exposed these interfaces through the git_libgit2_opts interface, reusing the GIT_CONFIG_LEVEL_SYSTEM, etc., constants for the user to control which search path they were modifying. There are alternative designs for the opts interface / argument ordering, so I'm putting this phase out for discussion. Additionally, I ended up doing a little bit of clean up regarding attr.h and attr_file.h, adding a new attrcache.h so the other two files wouldn't have to be included in so many places.
	48bde2f1	2013-03-08T02:11:34		config: don't allow passing NULL as a value to set Passing NULL is non-sensical. The error message leaves to be desired, though, as it leaks internal implementation details. Catch it at the `git_config_set_string` level and set an appropriate error message.
	487fc724	2013-03-01T13:41:53		Allow empty config object and use it This removes assertions that prevent us from having an empty git_config object and then updates some tests that were dependent on global config state to use an empty config before running anything.
	1e7799e8	2013-01-29T12:15:18		Implement config key validation rules This is a new implementation of core git's config key checking rules that prevents non-alphanumeric characters (and '-') for the top-level section and key names inside of config files. This also validates the target section name when renaming sections.
	359fc2d2	2013-01-08T17:07:25		update copyrights
	c7231c45	2012-11-30T16:31:42		Deploy GITERR_CHECK_VERSION
	69177621	2012-11-29T14:07:50		Deploy git_config_backend version
	7bf87ab6	2012-11-28T09:58:48		Consolidate text buffer functions There are many scattered functions that look into the contents of buffers to do various text manipulations (such as escaping or unescaping data, calculating text stats, guessing if content is binary, etc). This groups all those functions together into a new file and converts the code to use that. This has two enhancements to existing functionality. The old text stats function is significantly rewritten and the BOM detection code was extended (although largely we can't deal with anything other than a UTF8 BOM).
	54b2a37a	2012-11-20T16:02:25		Clean up config.h
	cc6b4162	2012-11-20T10:24:18		It is okay to not have a .gitconfig file Opening a repo is generating an error if you don't have a .gitconfig file in your home directory, but that should be legal.
	270160b9	2012-11-17T13:39:24		config: Opening a nonexistent file returns ENOTFOUND
	0ec11828	2012-11-16T02:17:57		Fix -Wmaybe-uninitialized warning
	6132a54e	2012-11-13T16:13:10		Fix a few valgrind errors
	0da81d2b	2012-11-13T14:43:23		config: return an emtpy string when there is no value Returning NULL for the string when we haven't signaled an error condition is counter-intuitive and causes unnecessary edge cases. Return an empty string when asking for a string value for a configuration variable such as '[section] var' to avoid these edge cases. If the distinction between no value and an empty value is needed, this can be retrieved from the entry directly. As a side-effect, this change stops the int parsing functions from segfaulting on such a variable.
	3ee078c0	2012-11-13T13:46:17		config: rename get_config_entry -> config_entry We're already in the git_config namespace, there is no need to repeat it.
	55f9837f	2012-11-09T21:49:50		config: make git_config_open_level() work with an empty config
	744cc03e	2012-10-30T12:10:36		Add git_config_refresh() API to reload config This adds a new API that allows users to reload the config if the file has changed on disk. A new config callback function to refresh the config was added. The modified time and file size are used to test if the file needs to be reloaded (and are now stored in the disk backend object). In writing tests, just using mtime was a problem / race, so I wanted to check file size as well. To support that, I extended `git_futils_readbuffer_updated` to optionally check file size in addition to mtime, and I added a new function `git_filebuf_stats` to fetch the mtime and size for an open filebuf (so that the config could be easily refreshed after a write). Lastly, I moved some similar file checking code for attributes into filebuf. It is still only being used for attrs, but it seems potentially reusable, so I thought I'd move it over.
	1b934689	2012-10-25T10:55:03		Merge pull request #925 from nulltoken/topic/moving-branch-updates-config Updates config upon moving and deletion of branches
	505f37b4	2012-10-25T19:22:35		config: Only dereference value on success
	aba70781	2012-09-11T18:11:26		config: introduce git_config_rename_section()
	a1abe66a	2012-09-10T12:11:02		Add config level support in the config API Added `struct git_config_entry`: a git_config_entry contains the key, the value, and the config file level from which a config element was found. Added `git_config_open_level`: build a single-level focused config object from a multi-level one. We are now storing `git_config_entry`s in the khash of the config_file
	4258d483	2012-10-02T17:21:07		Rename xdr to xdg Signed-off-by: Sven Strickroth <email@cs-ware.de>
	c378a118	2012-09-25T00:11:53		git_config_open_default: Honour xdr config Signed-off-by: Sven Strickroth <email@cs-ware.de>
	d7940ac3	2012-09-25T00:09:44		Fixed missing method Signed-off-by: Sven Strickroth <email@cs-ware.de>
	8b4f9b17	2012-09-24T18:59:00		Correctly read xdr compatible %HOME%/.config/git/config config file This file is not just read if the global config file (%HOME%/.gitconfig) is not found, however, it is used everytime but with lower priority. Signed-off-by: Sven Strickroth <email@cs-ware.de>
	7fbca880	2012-08-24T14:32:45		Support new config locations As of git v1.7.12, $HOME/.config/git/ is supported as a new location for "config", "attributes", and "ignore" files.
	85bd1746	2012-08-22T16:03:35		Some cleanup suggested during review This cleans up a number of items suggested during code review with @vmg, including: * renaming "outside repo" config API to `git_config_open_default` * killing the `git_config_open_global` API * removing the `git_` prefix from the static functions in fileops * removing some unnecessary functionality from the "cp" command
	ca1b6e54	2012-07-31T17:02:54		Add template dir and set gid to repo init This extends git_repository_init_ext further with support for initializing the repository from an external template directory and with support for the "create shared" type flags that make a set GID repository directory. This also adds tests for much of the new functionality to the existing `repo/init.c` test suite. Also, this adds a bunch of new utility functions including a very general purpose `git_futils_mkdir` (with the ability to make paths and to chmod the paths post-creation) and a file tree copying function `git_futils_cp_r`. Also, this includes some new path functions that were useful to keep the code simple.
	b8457baa	2012-07-24T07:57:58		portability: Improve x86/amd64 compatibility
	b3ff1dab	2012-07-10T15:22:39		Adding git_config_foreach_match() iteration fn Adding a new config iteration function that let's you iterate over just the config entries that match a particular regular expression. The old foreach becomes a simple use of this with an empty pattern. This also fixes an apparent bug in the existing `git_config_foreach` where returning a non-zero value from the iteration callback was not correctly aborting the iteration and the returned value was not being propogated back to the caller of foreach. Added to tests to cover all these changes.
	e203e9d4	2012-05-19T18:13:38		config: do not set an error for GIT_ENOTFOUND An unset config variable isn't bad per se -- let the call site set an error in case GIT_ENOTFOUND isn't acceptable.
	904b67e6	2012-05-18T01:48:50		errors: Rename error codes
	e172cf08	2012-05-18T01:21:06		errors: Rename the generic return codes
	29e948de	2012-05-10T10:38:10		global: Change parameter ordering in API Consistency is good.
	3fbcac89	2012-05-02T19:56:38		Remove old and unused error codes
	01fed0a8	2012-04-25T10:36:01		Convert hashtable usage over to khash This updates khash.h with some extra features (like error checking on allocations, ability to use wrapped malloc, foreach calls, etc), creates two high-level wrappers around khash: `git_khash_str` and `git_khash_oid` for string-to-void-ptr and oid-to-void-ptr tables, then converts all of the old usage of `git_hashtable` over to use these new hashtables. For `git_khash_str`, I've tried to create a set of macros that yield an API not too unlike the old `git_hashtable` API. Since the oid hashtable is only used in one file, I haven't bother to set up all those macros and just use the khash APIs directly for now.
	7784bcbb	2012-04-11T11:52:59		Refactor git_repository_open with new options Add a new command `git_repository_open_ext` with extended options that control how searching for a repository will be done. The existing `git_repository_open` and `git_repository_discover` are reimplemented on top of it. We may want to change the default behavior of `git_repository_open` but this commit does not do that. Improve support for "gitdir" files where the work dir is separate from the repo and support for the "separate-git-dir" config. Also, add support for opening repos created with `git-new-workdir` script (although I have only confirmed that they can be opened, not that all functions work correctly). There are also a few minor changes that came up: - Fix `git_path_prettify` to allow in-place prettifying. - Fix `git_path_root` to support backslashes on Win32. This fix should help many repo open/discover scenarios - it is the one function called when opening before prettifying the path. - Tweak `git_config_get_string` to set the "out" pointer to NULL if the config value is not found. Allows some other cleanup. - Fix a couple places that should have been calling `git_repository_config__weakptr` and were not. - Fix `cl_git_sandbox_init` clar helper to support bare repos.
	95dfb031	2012-03-30T14:40:50		Improve config handling for diff,submodules,attrs This adds support for a bunch of core.* settings that affect diff and status, plus fixes up some incorrect implementations of those settings from before. Also, this cleans up the handling of config settings in the new submodules code and in the old attrs/ignore code.
	bfc9ca59	2012-03-28T16:45:36		Added submodule API and use in status When processing status for a newly checked out repo, it is possible that there will be submodules that have not yet been initialized. The only way to distinguish these from untracked directories is to have some knowledge of submodules. This commit adds a new submodule API which, given a name or path, can determine if it appears to be a submodule and can give information about the submodule.
	dda708e7	2012-03-09T19:55:50		error-handling: On-disk config file backend Includes: - Proper error reporting when encountering syntax errors in a config file (file, line number, column). - Rewritten `config_write`, now with 99% less goto-spaghetti - Error state in `git_filebuf`: filebuf write functions no longer need to be checked for error returns. If any of the writes performed on a buffer fail, the last call to `git_filebuf_commit` or `git_filebuf_hash` will fail accordingly and set the appropiate error message. Baller!
	e54d8d89	2012-03-07T01:37:09		error-handling: Config
	c5e94482	2012-03-01T00:52:21		config: Refactor & add `git_config_get_mapped` Sane API for real-world usage.
	3005855f	2012-02-05T00:29:26		Implement setting multivars
	5e0dc4af	2012-02-04T23:18:30		Support getting multivars
	5e0de328	2012-02-13T17:10:24		Update Copyright header Signed-off-by: schu <schu-github@schulog.org>
	2d840502	2012-01-05T15:03:42		Throw first error in chain, not rethrow. This is the first time this error is throw, so use git__throw instead of git__rethrow.
	9191a6d2	2012-01-02T09:56:48		Merge remote-tracking branch 'arrbee/git-attributes' into development Conflicts: tests-clay/clay_main.c
	9dd4c3e8	2011-12-31T05:56:39		config: Rename the `delete` callback name `delete` is a reserved keyword in C++.
	73b51450	2011-12-28T23:28:50		Add support for macros and cache flush API. Add support for git attribute macro definitions. Also, add support for cache flush API to clear the attribute file content cache when needed. Additionally, improved the handling of global and system files, making common utility functions in fileops and converting config and attr to both use the common functions. Adds a bunch more tests and fixed some memory leaks. Note that adding macros required me to use refcounted attribute assignment definitions, which complicated, but probably improved memory usage.
	80a665aa	2011-12-16T02:28:39		config: really delete variables Instead of just setting the value to NULL, which gives unwanted results when asking for that variable after deleting it, delete the variable from the list and re-write the file.
	97769280	2011-11-30T11:27:15		Use git_buf for path storage instead of stack-based buffers This converts virtually all of the places that allocate GIT_PATH_MAX buffers on the stack for manipulating paths to use git_buf objects instead. The patch is pretty careful not to touch the public API for libgit2, so there are a few places that still use GIT_PATH_MAX. This extends and changes some details of the git_buf implementation to add a couple of extra functions and to make error handling easier. This includes serious alterations to all the path.c functions, and several of the fileops.c ones, too. Also, there are a number of new functions that parallel existing ones except that use a git_buf instead of a stack-based buffer (such as git_config_find_global_r that exists alongsize git_config_find_global). This also modifies the win32 version of p_realpath to allocate whatever buffer size is needed to accommodate the realpath instead of hardcoding a GIT_PATH_MAX limit, but that change needs to be tested still.
	9462c471	2011-11-25T08:16:26		repository: Change ownership semantics The ownership semantics have been changed all over the library to be consistent. There are no more "borrowed" or duplicated references. Main changes: - `git_repository_open2` and `3` have been dropped. - Added setters and getters to hotswap all the repository owned objects: `git_repository_index` `git_repository_set_index` `git_repository_odb` `git_repository_set_odb` `git_repository_config` `git_repository_set_config` `git_repository_workdir` `git_repository_set_workdir` Now working directories/index files/ODBs and so on can be hot-swapped after creating a repository and between operations. - All these objects now have proper ownership semantics with refcounting: they all require freeing after they are no longer needed (the repository always keeps its internal reference). - Repository open and initialization has been updated to keep in mind the configuration files. Bare repositories are now always detected, and a default config file is created on init. - All the tests affected by these changes have been dropped from the old test suite and ported to the new one.
	3286c408	2011-10-28T14:51:13		global: Properly use `git__` memory wrappers Ensure that all memory related functions (malloc, calloc, strdup, free, etc) are using their respective `git__` wrappers.
	11d51ca6	2011-10-26T16:43:55		windows: Add support for non-UTF codepages Our previous assumption that all paths in Windows are encoded in UTF-8 is rather weak, specially when considering that Git is encoding-agnostic. These set of functions allow the user to change the library's active codepage globally, so it is possible to access paths and files on all international versions of Windows. Note that the default encoding here is UTF-8 because we assume that 99% of all Git repositories will be in UTF-8. Also, if you use non-ascii characters in paths, anywhere, please burn on a fire.
	fafd4710	2011-09-30T16:08:06		config: Proper type declarations for 64 bit ints
	358a15fd	2011-09-30T15:43:58		config: fix check for environment string expansion If ExpandEnvironmentStringsW is successful, it returns the amount of characters written, including the NUL terminator. Thanks to Emeric for reading the MSDN documentation correctly. Signed-off-by: Carlos Martín Nieto <carlos@cmartin.tk>
	6c8b458d	2011-09-29T17:04:45		mingw: Fix compilation warnings
	780bea6e	2011-09-29T16:23:24		mingw: Fix printf identifiers
	a5b0e7f8	2011-09-27T20:08:13		Really fix MSVC These was left over from the previous PRs. Signed-off-by: Carlos Martín Nieto <carlos@cmartin.tk>
	4c562347	2011-09-22T21:34:46		Add git_config_find_system This allows the library to guess where the system configuration file should be located. Signed-off-by: Carlos Martín Nieto <carlos@cmartin.tk>
	01d7fded	2011-09-22T20:44:30		Revert "Rewrite getenv to use Win32 version on Windows" This reverts commit e1b86444676b70154bf8ab450d429bdef57a8276.
	ad196c6a	2011-09-21T23:17:39		config: make git_config_[get|set]_long() able to properly deal with 8 bytes wide values Should fix issue #419. Signed-off-by: nulltoken <emeric.fermas@gmail.com>
	e1b86444	2011-09-21T11:17:30		Rewrite getenv to use Win32 version on Windows