|
61838295
|
2022-01-26T16:22:04
|
|
object: move oid header printing to object
|
|
|
b7a46fa8
|
2022-01-23T12:25:03
|
|
object: move oid header parsing to object
|
|
|
0b068214
|
2021-12-11T15:34:27
|
|
oid: add functions to inspect oid information
Provide helper functions to provide information about the object id size
given its type.
|
|
|
0acaf3a8
|
2022-01-17T13:40:37
|
|
oid: define GIT_OID_SHA1_ZERO
Callers should not assume the layout of the oid structure; provide them
a macro that defines the null / zero sha1 object id.
|
|
|
dbc4ac1c
|
2022-01-22T23:10:03
|
|
oid: `GIT_OID_*SZ` is now `GIT_OID_SHA1_*SIZE`
In preparation for SHA256 support, `GIT_OID_RAWSZ` and `GIT_OID_HEXSZ`
need to indicate that they're the size of _SHA1_ OIDs.
|
|
|
cdff2f02
|
2022-06-13T21:34:01
|
|
repo: allow administrator to own the configuration
Update our ownership checks that were introduced in libgit2 v1.4.3
(to combat CVE 2022-24765). These were not compatible with git's; git
itself allows administrators to own the path. Our checks now match
this behavior.
|
|
|
96c61174
|
2022-06-13T11:19:55
|
|
cmake: only use `getloadavg` where it exists
|
|
|
3809ab0e
|
2022-06-13T10:50:40
|
|
cmake: add `gnu` library for Haiku
|
|
|
9bc82c8f
|
2022-06-13T10:46:21
|
|
cmake: detect `getentropy`
Look for `getentropy` and flag its existence.
|
|
|
7eb7edd4
|
2022-06-12T10:51:13
|
|
Merge pull request #6278 from lhchavez/git_transport_smart_remote_connect_options
transport: introduce `git_transport_smart_remote_connect_options`
|
|
|
d333dbea
|
2022-06-12T10:40:12
|
|
Merge pull request #6288 from libgit2/cmn/mwindow-simplifications
A couple of simplications around mwindow
|
|
0a7c00be
|
2022-06-11T14:31:16
|
|
Merge remote-tracking branch 'origin/main' into main
|
|
|
a7541676
|
2022-06-11T14:29:15
|
|
Apply suggestions from code review
Co-authored-by: Edward Thomson <ethomson@github.com>
|
|
|
2b28ee77
|
2022-06-11T16:51:04
|
|
Merge pull request #6319 from libgit2/ethomson/progress_32bit
CLI: progress updates
|
|
|
28d2ea1d
|
2022-06-11T16:50:56
|
|
Merge pull request #6305 from zawata/fix_refdb_error_msg
refs: fix missing error message
|
|
|
4f7b568d
|
2022-06-11T16:26:50
|
|
Merge pull request #6291 from libgit2/cmn/midx-no-hash
midx: do not verify the checksum on load
|
|
|
3a737169
|
2022-06-11T16:14:11
|
|
progress: fewer updates about throughput
Avoid too much flashing on the console with updates about throughput.
Only update throughput once a second.
|
|
|
286e7f0a
|
2022-06-11T16:08:28
|
|
cli: show progress on 32 bit machines
|
|
97954ee5
|
2022-05-20T09:06:50
|
|
Replace bitwise AND 0x7fffffff with XOR 0x80000000.
Though both are correct, this makes it clear that we're dealing with
the same value.
|
|
|
8a765c72
|
2022-05-19T16:33:57
|
|
midx: fix large object offset table check.
It's insufficient to only check if the offset high order bit is set, we
must also check to see if object_large_offsets are in use.
This bug is causing objects to appear missing because they can't be
found in the index.
|
|
640e8a63
|
2022-05-17T11:01:43
|
|
fix missing error message
|
|
a3f9617b
|
2022-05-03T14:09:40
|
|
midx: do not verify the checksum on load
This is something we only want to do during explicit verification rather than on
every load.
Verifying does not seem like a big deal when we're running with test workloads
but once your `multi-pack-index` reaches gigabytes, we spend more time hashing
this than doing any work.
|
|
|
0f594445
|
2022-04-29T10:50:02
|
|
mwindow: use multiplication instesad of conditionals
This is a very verbose way of performing a comparison where we already
have the identity value with both signs. Instead of chainging several
conditions, we can rely on the maths working out.
|
|
|
55c84333
|
2022-04-29T10:32:45
|
|
mwindow: include both the offset and the extra in the same call
This makes it a bit easier to read while letting the caller specify
how big the hash size is for this particular call.
|
|
|
13502d9e
|
2022-04-25T09:22:02
|
|
Merge pull request #6274 from libgit2/ethomson/cli_clone
cli: clone
|
|
|
3b52e5f5
|
2022-04-18T17:12:27
|
|
Merge pull request #6265 from libgit2/ethomson/sha256_two
sha256: refactoring in preparation for sha256
|
|
|
1d88605c
|
2022-04-16T08:19:38
|
|
transport: introduce `git_transport_smart_remote_connect_options`
6fc6eeb66c40310086c8f059cae41de69ad4c6da removed
`git_transport_smart_proxy_option`, and there was nothing added to
replace it. That made it hard for custom transports / smart
subtransports to know what remote connect options to use (e.g. proxy
options).
This change introduces `git_transport_smart_remote_connect_options` to
replace it.
|
|
|
8a757ae2
|
2020-04-04T18:31:00
|
|
cli: introduce a clone command
|
|
|
7babe76f
|
2020-05-12T08:56:55
|
|
cli: introduce signal handler
Provide a mechanism to add a signal handler for Unix or Win32.
|
|
|
48506f2b
|
2020-04-04T18:29:34
|
|
cli: introduce a progress class
Provide a class that will display progress information to the console.
Initially, it contains callbacks for fetch progress and checkout
progress.
|
|
|
4161ebdd
|
2022-04-11T21:31:25
|
|
repo: make ownership checks optional
Introduce the `GIT_OPT_SET_OWNER_VALIDATION` option, so that users can
disable repository ownership validation.
|
|
|
fa366921
|
2022-04-11T15:18:44
|
|
repo: honor safe.directory during ownership checks
Obey the `safe.directory` configuration variable if it is set in the
global or system configuration. (Do not try to load this from the
repository configuration - to avoid malicious repositories that then
mark themselves as safe.)
|
|
|
f7f7e835
|
2022-04-11T13:04:26
|
|
repo: refactor global config loader function
Pull the global configuration loader out of the symlink check so that it
can be re-used.
|
|
|
c0b7f88e
|
2022-04-11T17:06:55
|
|
fs_path: mock ownership checks
Provide a mock for file ownership for testability.
|
|
|
c0dfd1ad
|
2022-04-11T09:56:26
|
|
repo: ensure that repo dir is owned by current user
Ensure that the repository directory is owned by the current user; this
prevents us from opening configuration files that may have been created
by an attacker.
|
|
|
bf2620bc
|
2022-04-10T21:29:43
|
|
fs_path: refactor ownership checks into current user and system
Provide individual file ownership checks for both the current user and
the system user, as well as a combined current user and system user
check.
|
|
|
71049b4a
|
2022-01-22T09:03:34
|
|
midx: use raw oid data
A multi-pack index uses raw oid data, use a byte array to index
into them.
|
|
|
41d4ac51
|
2022-01-22T08:49:06
|
|
index: use raw oid data
The index contains entries with raw oid data, use a byte array for the
raw entry data.
|
|
|
4fc3ce15
|
2022-01-22T07:46:41
|
|
pack: use raw oid data
A packfile contains arrays of raw oid data, use a byte array to index
into them.
|
|
|
c2b3b0d8
|
2022-01-21T19:38:13
|
|
commit_graph: use raw oid data
The commit graph contains arrays of raw oid data, use a byte array to
index into them.
|
|
|
9ffa33a1
|
2022-01-22T08:48:43
|
|
oid: introduce `git_oid_raw_cpy`
Now that oids are type-aware, they use their type to understand how many
bytes to copy. Some callers may need to copy the raw bytes of the
object id.
This is equivalent to a memcpy that is a little more semantic.
|
|
|
6d8c7cab
|
2022-01-21T19:37:53
|
|
oid: introduce `git_oid_raw_ncmp`
|
|
|
526e8869
|
2022-01-21T19:17:40
|
|
oid: `hashcmp` is now `raw_cmp`
We will talk about "raw" oids as untyped blobs of data; use a name for
the comparison function that is in keeping with that.
|
|
|
c569738c
|
2022-01-22T08:55:41
|
|
indexer: write raw id data
Don't write the object id structure, write its raw oid data.
|
|
|
563751d1
|
2022-01-22T06:42:50
|
|
treecache: write the raw id not the object
We explicitly want to write on the id data, not the beginning of the
object data, which may contain other information in the future.
|
|
|
831e20ac
|
2022-01-22T06:39:38
|
|
oidmap: hash on the id, not the object
We explicitly want to hash on the id data, not the beginning of the
object data, which may contain other information in the future.
|
|
|
590ff981
|
2022-01-21T19:49:09
|
|
oid: don't assume the size of an oid
Don't assume that a `git_oid` is a particular size; allocate
`sizeof(git_oid)` instead.
|
|
|
ab042161
|
2022-01-18T08:12:18
|
|
tree: move git_oid into tree entry
A tree entry previously pointed directly into the object id within the
tree object itself; this is useful to avoid any unnecessary memory copy
(and an unnecessary use of 40 bytes per tree entry) but difficult if we
change the underlying `git_oid` object to not simply be a raw object id
but have additional structure.
This commit moves the `git_oid` directly into the tree entry; this
simplifies the tree entry creation from user data. We now copy the
`git_oid` into place when parsing.
|
|
|
7e8d9be0
|
2022-04-10T09:45:51
|
|
Merge pull request #6260 from lhchavez/midx-fix-ub
midx: Fix an undefined behavior (left-shift signed overflow)
|
|
|
606afeda
|
2022-04-10T09:44:41
|
|
Merge pull request #6244 from jorio/fix-diff_delta_format_path-crash
Fix crash when regenerating a patch with unquoted spaces in filename
|
|
71bb92b5
|
2022-04-10T09:25:54
|
|
Update src/libgit2/diff_print.c
|
|
|
cd8fde82
|
2022-04-05T22:40:28
|
|
Merge pull request #6258 from libgit2/ethomson/sha256_openssl_dynamic
sha256: support dynamically loaded openssl
|
|
|
33b1d3fd
|
2022-04-05T13:10:33
|
|
[midx] Fix an undefined behavior (left-shift signed overflow)
There was a missing check to ensure that the `off64_t` (which is a
signed value) didn't overflow when parsing it from the midx file. This
shouldn't have huge repercusions since the parsed value is immediately
validated afterwards, but then again, there is no such thing as "benign"
undefined behavior.
This change makes all the bitwise arithmetic happen with unsigned types
and is only casted to `off64_t` until the very end.
Thanks to Taotao Gu for finding and reporting this!
|
|
|
d8015d28
|
2022-04-04T13:30:27
|
|
Merge pull request #6251 from libgit2/ethomson/oid_fetch
fetch: support OID refspec without dst
|
|
|
3bd9bb8d
|
2022-04-04T13:28:40
|
|
sha256: support dynamically loaded openssl
|
|
|
0e30becc
|
2021-12-13T17:49:57
|
|
sha: cast nonsense for obnoxious gcc warnings
gcc (mingw) warns when you cast the result of `GetProcAddress`; cast the
results to `void *` before casting them to the actual result.
|
|
|
ce78c83b
|
2021-12-13T15:31:21
|
|
sha: ensure we test both cng and cryptoapi on windows
When GIT_SHA1_WIN32 or GIT_SHA256_WIN32 is used, ensure that we test
both CryptoNG ("cng") and CryptoAPI.
|
|
|
6a7d5d23
|
2021-12-13T11:54:49
|
|
sha: support Win32 for SHA256
Adding SHA256 support prompted an overdue refactoring of some of the
unnecessary complexity around the CNG/CryptoAPI abstraction.
|
|
|
6b4a6faa
|
2021-12-12T15:41:47
|
|
sha: support OpenSSL for SHA256
|
|
|
b3e3fa10
|
2021-12-12T15:34:35
|
|
sha: support mbedTLS for SHA256
|
|
|
83c27786
|
2021-12-12T15:14:21
|
|
sha: support CommonCrypto for SHA256
|
|
|
b900981c
|
2021-12-12T14:25:25
|
|
sha: add sha256 algorithm
Add support for a SHA256 hash algorithm, and add the "builtin" SHA256
hash engine (from RFC 6234).
|
|
|
36df49c2
|
2021-12-12T14:29:11
|
|
sha: GIT_ERROR_SHA1 is deprecated in favor of GIT_ERROR_SHA
The more generic GIT_ERROR_SHA allows for SHA256 errors as well as SHA1.
|
|
|
c7b189ba
|
2021-12-12T13:19:36
|
|
sha1: refactor folder structure
Eliminate the `sha1` folder, move it down into `hash` so that future
impelmentations can share common code.
|
|
|
8bc998f4
|
2021-12-12T12:44:13
|
|
sha1: remove generic implementation
Remove the "generic" implementation; it should never be used; it only
existed for a no-dependencies configuration, and our bundled sha1dc
satisfies that requirement _and_ is correct.
|
|
|
a9a7967a
|
2022-03-22T22:16:57
|
|
fetch: support OID refspec without dst
Support the ability to create a refspec that is a single object ID
without a destination.
|
|
ecc722c3
|
2022-03-16T10:25:11
|
|
Fix a string parsing bug when validating extensions from the configuration
As builtin extensions are evaluated in the latter half of `check_valid_extension`, a string `cfg` is concatenated with the static string 'extension.' and the value from `builtin_extension`, before being compared with the configured value. This string is not being cleared while iterating through the names of the extensions. Because there is currently only one extension ('noop'), the bug was never noticible.
This patch corrects the behavior by clearing the string on each iteration, as is done in the first block.
|
|
d427f952
|
2022-03-13T17:40:54
|
|
diff_delta_format_path: handle null filename
This fixes a crash in test cases
test_diff_parse__new_file_with_space_and_regenerate_patch
and
test_diff_parse__delete_file_with_space_and_regenerate_patch
|
|
|
073e63d0
|
2022-02-27T10:05:24
|
|
object: validate that `odb_obj` was set
|
|
|
241d838f
|
2022-02-27T10:02:05
|
|
http: skip processing when body is null or 0 length
Mistakenly `&&` when we should have `||`d.
|
|
|
9f0088c4
|
2022-02-27T09:26:16
|
|
fs_path: exit quickly in `dirname_r` failure
When we encounter a situation where we need to exit, simply `return -1`
instead of trying to set `len = -1` and then jumping to the exit
handler, which would erroneously do work based on the `len` value.
|
|
|
043a87a0
|
2022-02-27T09:21:53
|
|
refdb: unlock mutex on assertion failure
If we're safely asserting (and returning an error to the caller), we
should still unlock our mutex.
|
|
|
d9b041e6
|
2022-02-27T09:20:58
|
|
assert: add `ASSERT_WITH_CLEANUP`
Now that we safely assert and return, we may need to be in a place where
we need to unlock mutexes or cleanup resources. Provide
`ASSERT_WITH_CLEANUP` that permits for this behavior by taking a block.
|
|
|
e32db9f2
|
2022-02-27T08:54:09
|
|
cli: always give a value to `error`
|
|
|
e427d0a1
|
2021-11-30T10:33:24
|
|
cli: add `hash-object` command
Introduce a simple command that emulates `git hash-object`.
|
|
|
dcabef22
|
2022-02-21T13:06:43
|
|
futils: produce improved error messages
|
|
|
e7be6b76
|
2021-11-29T12:04:06
|
|
futils: provide an option to read a whole file by fd
|
|
|
b8771227
|
2021-11-28T10:32:03
|
|
cli: add `cat-file` command
Introduce a simple command that emulates `git cat-file`.
|
|
|
f8e7d8fd
|
2021-11-26T17:33:38
|
|
cli: support `help <command>`
Support `help <command>` by re-invoking the command itself with the
`--help` argument. This allows us to keep the help logic with the
commands itself.
|
|
|
c6dd82d9
|
2020-02-23T11:54:33
|
|
cli: introduce a help command
Add a framework for commands to be defined, and add our first one,
"help". When `git2_cli help` is run, the `cmd_help` function will be
invoked with the remaining command line arguments. This allows users to
invoke `git2_cli help foo` to get information about the `foo` subcommand.
|
|
|
8526cbd5
|
2021-11-26T09:37:29
|
|
opt: use a custom function to print usage
Our argument parser (https://github.com/ethomson/adopt) includes a
function to print a usage message based on the allowed options. Omit
this and use a cutom function that understands that we have subcommands
("checkout", "revert", etc) that each have their own options.
|
|
|
3a3ab065
|
2020-05-03T23:13:28
|
|
cli: infrastructure for a cli project
Introduce a command-line interface for libgit2. The goal is for it to
be git-compatible.
1. The libgit2 developers can more easily dogfood libgit2 to find bugs,
and performance issues.
2. There is growing usage of libgit2's examples as a client; libgit2's
examples should be exactly that - simple code samples that illustrate
libgit2's usage. This satisfies that need directly.
3. By producing a client ourselves, we can better understand the needs
of client creators, possibly producing a shared "middleware" for
commonly-used pieces of client functionality like interacting with
external tools.
4. Since git is the reference implementation, we may be able to benefit
from git's unit tests, running their test suite against our CLI to
ensure correct behavior.
This commit introduces a simple infrastructure for the CLI.
The CLI is currently links libgit2 statically; this is because the
utility layer is required for libgit2 _but_ shares the error state
handling with libgit2 itself. There's no obviously good solution
here without introducing annoying indirection or more complexity.
Until we can untangle that dependency, this is a good step forward.
In the meantime, we link the libgit2 object files, but we do not include
the (private) libgit2 headers. This constrains the CLI to the public
libgit2 interfaces.
|
|
|
3344fddc
|
2021-11-16T23:29:22
|
|
refactor: `tests` is now `tests/libgit2`
Like we want to separate libgit2 and utility source code, we want to
separate libgit2 and utility tests. Start by moving all the tests into
libgit2.
|
|
|
91ba0896
|
2021-11-15T09:54:00
|
|
cmake: rename git2internal target to libgit2
The `git2internal` target is actually the git library; call it such so
that IDE users have visibility into it.
|
|
|
d7b49ed4
|
2021-11-15T14:54:17
|
|
cmake: remove unnecessary xcode hack
|
|
|
5fcfada5
|
2021-11-15T07:45:16
|
|
cmake: document CMakeLists.txt hierarchy
|
|
|
c3b7ace9
|
2021-11-14T16:43:53
|
|
refactor: make util an object library
Instead of simply including the utility files directly, make them a
cmake object library for easy reusability between other projects within
libgit2.
Now the top-level `src` is responsible for platform selection, while the
next-level `libgit2` and `util` configurations are responsible for
identifying what objects they include.
|
|
|
ef4ab298
|
2021-11-14T08:47:40
|
|
refactor: `src` is now `src/libgit2`
|
|
|
49e180c8
|
2022-02-15T22:55:48
|
|
errors: expose `git_error_set`
The `git_error_set` function is useful for callers who implement
backends and advanced callbacks. Expose it.
|
|
|
c716b9f2
|
2022-02-21T10:16:05
|
|
odb: initialize `object` before use
Newer gcc is complaining about `object` being potentially not
initialized; initialize it.
|
|
|
eca9e1cf
|
2022-02-22T07:17:12
|
|
Merge pull request #6228 from libgit2/ethomson/win32_systemdirs
win32: `find_system_dirs` does not return `GIT_ENOTFOUND`
|
|
|
f45121ed
|
2022-02-21T16:13:52
|
|
win32: `find_system_dirs` does not return `GIT_ENOTFOUND`
Allow for no Git for Windows installation. When there is no GfW found
in the path or registry, `git_win32__find_system_dirs` would return a
`GIT_ENOTFOUND`. Callers were not expecting this. Since this is no
error, we simply return `0` so that callers can move on with their
lives.
|
|
|
15860aa0
|
2022-02-21T10:03:06
|
|
remote: do store the update_tips callback error value
We use `git_error_set_after_callback_function` to determine whether
`update_tips` returned an error but do not store its return value making us
think it always returns 0.
Fix it by adding the common patter of storing it inside the `if` when calling it.
|
|
|
83f2a20e
|
2022-02-18T09:30:18
|
|
Merge pull request #6220 from libgit2/ethomson/version
meta: update version number to v1.5.0-alpha
|
|
|
b722c45d
|
2022-02-17T13:55:34
|
|
xdiff: use xdl_free not free
We've added a lovely abstraction layer in xdiff so that it can call our
allocation functions. But it also needs to call our free functions. We
missed some `free` calls in `xmerge.c`. Update them to use `xdl_free`.
Without this, we will pass a pointer allocated with a custom allocator
to the system free function. :bomb:
|
|
|
056fe4be
|
2022-02-14T07:12:36
|
|
meta: provide an accessor for prerelease info
|
|
|
aded938e
|
2022-02-12T21:23:01
|
|
Merge pull request #6204 from boretrk/merge_flags
merge: fix overlap between GIT_MERGE_FILE_FAVOR__CONFLICTED and GIT_MERGE_FILE_SIMPLIFY_ALNUM
|
|
|
416f7cb3
|
2022-02-12T10:38:08
|
|
Merge pull request #6208 from jorio/fix-stale-filesize-crash
diff_file: fix crash if size of diffed file changes in workdir
|
|
|
4467bd66
|
2022-02-12T09:09:17
|
|
Merge pull request #6207 from libgit2/ethomson/prng
mktmp: improve our temp file creation
|
|
|
0fbf62cd
|
2022-02-12T08:46:55
|
|
merge: make the internal flags public
We made the flags that enable recursive merge internal, on the
assumption that nobody would want them and they're hard to reason about.
(Giving people an option that nobody wants is just extra noise.)
However, it made it hard for _us_ to reason about. There's no good
reason to keep it private, let's just make it public and push that
cognitive load onto our poor users. But they should expect it, they're
dealing with git, after all.
|