thodg/libgit2/src

Diff

  • Show log

    Commit

  • Hash : 1db9d2c3
    Author : Paul Betts
    Date : 2012-02-23T17:11:20 

    Ensure that commits don't fail if committing content that already exists

Making a commit that results in a blob that already exists in the ODB (i.e.
committing something, then making a revert commit) will result in us trying
to p_rename -> MoveFileExW a temp file into the existing ODB entry. Despite
the MOVEFILE_REPLACE_EXISTING flag is passed in, Win32 does not care and
fails it with STATUS_ACCESS_DENIED.

To fix this, we p_unlink the ODB entry before attempting to rename it. This
call will typically fail, but we don't care, we'll let the p_rename fail if
the file actually does exist and we couldn't delete it for some reason (ACLs,
etc).

kmx.io     mail     discord kmxgit v0.4.0