thodg/libgit2/src

Diff

  • Show log

    Commit

  • Hash : 3f6fe054
    Author : Edward Thomson
    Date : 2019-10-20T17:23:01 

    gssapi: protect GSS_ERROR macro

The GSS_ERROR(x) macro may expand to `(x & value)` on some
implementations, instead of `((x) & value)`.  This is the case on macOS,
which means that if we attempt to wrap an expression in that macro, like
`a = b`, then that would expand to `(a = b & value)`.

Since `&` has a higher precedence, this is not at all what we want, and
will set our result code to an incorrect value.  Evaluate the expression
then test it with `GSS_ERROR` independently to avoid this.

kmx.io     mail     discord kmxgit v0.4.0