• Show log

    Commit

  • Hash : 0927156a
    Author : Patrick Steinhardt
    Date : 2019-10-24T12:32:11

    config_file: refactor taking entries ref to return an error code
    
    The function to take a reference to the config file's config entries
    currently returns the reference via return value. Due to this, it's
    harder than necessary to integrate into our typical coding style, as one
    needs to make sure that a proper error code is set before erroring out
    from the caller. This bites us in `config_file_delete`, where we call
    `goto out` directly when `config_file_entries_take` returns `NULL`, but
    we actually forget to set up the error code and thus return success.
    
    Fix the issue by refactoring the function to return an error code and
    pass the reference via an out-pointer.