thodg/libgit2/src

Diff

  • Show log

    Commit

  • Hash : 9e07f684
    Author : Patrick Steinhardt
    Date : 2019-04-26T08:01:56 

    cmake: fix include ordering issues with bundled deps

When linking against bundled libraries, we include their header
directories by using "-isystem". The reason for that is that we
want to handle our vendored library headers specially, most
importantly to ignore warnings generated by including them. By
using "-isystem", though, we screw up the order of searched
include directories by moving those bundled dependencies towards
the end of the lookup order. Like this, chances are high that any
other specified include directory contains a file that collides
with the actual desired include file.

Fix this by not treating the bundled dependencies' include
directories as system includes. This will move them to the front
of the lookup order and thus cause them to override
system-provided headers. While this may cause the compiler to
generate additional warnings when processing bundled headers,
this is a tradeoff we should make regardless to fix builds on
systems hitting this issue.

(cherry picked from commit ee3d71fb86bad4a681d762d90374e46f1d005714)

kmx.io     mail     discord kmxgit v0.4.0