• Show log

    Commit

  • Hash : b4b96d56
    Author : Scott J. Goldman
    Date : 2012-05-05T13:30:33

    Fix gitno_connect() error handling on Windows
    
    gitno_connect() can return an error or socket, which is fine on most
    platforms where sockets are file descriptors (signed int), but on Windows,
    SOCKET is an unsigned type, which is problematic when we are trying to
    test if the socket was actually a negative error code.
    
    This fix seperates the error code and socket in gitno_connect(), and fixes
    the error handling in do_connect() functions to compensate. It appears
    that git_connect() and the git-transport do_connect() functions had bugs
    in the non-windows cases too (leaking sockets, and not properly reporting
    connection error, respectively) so I went ahead and fixed those too.